WebKit-https.git
8 years agohttps://bugs.webkit.org/show_bug.cgi?id=45164
hyatt@apple.com [Mon, 14 Mar 2011 20:56:18 +0000 (20:56 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=45164

Reviewed by Dan Bernstein.

REGRESSION: <a><img align=top></a> Clickable area too large

Make sure to clamp hit testing of quirky inline flow boxes the same way we already clamped
painting.

Source/WebCore:

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::nodeAtPoint):

LayoutTests:

* fast/inline/inline-position-top-align-expected.txt: Added.
* fast/inline/inline-position-top-align.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-14 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Mon, 14 Mar 2011 20:53:38 +0000 (20:53 +0000)]
2011-03-14  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Adam Roben.

        REGRESSION (r75138-r75503): Animations on Apple HTML5 Gallery demo are wrong
        https://bugs.webkit.org/show_bug.cgi?id=52845

        The lastCommitTime() value in CACFLayerTreeHost was returning as the time
        the render previous to this one happened. That often made it seem like
        animations started more in the past than they did, breaking many animations.
        The startAnimations() call actually fires from a CACF callback after all the
        WebKit content has been rendered. So sending currentTime as the start time
        to the animations is close enough for proper synchronization.

        * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
        (WebCore::CACFLayerTreeHost::notifyAnimationsStarted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-11 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 14 Mar 2011 20:47:34 +0000 (20:47 +0000)]
2011-03-11  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        Selection uses first mousemove's localRect instead of that of mousedown
        https://bugs.webkit.org/show_bug.cgi?id=56213

        Fixed the bug by adding an extra call to updateSelectionForMouseDrag in handleMouseDraggedEvent
        using the mouse coordinates of the mousedown event that started the drag.

        Test: editing/selection/drag-select-rapidly.html

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseDraggedEvent):
2011-03-11  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        Selection uses first mousemove's localRect instead of that of mousedown
        https://bugs.webkit.org/show_bug.cgi?id=56213

        Added a test to ensure the selection start is computed using the mouse coordinates passed down
        to the corresponding mousedown event instead of that of the first mousemove event.

        The test is co-authored by Evan Martin.

        * editing/selection/anchor-focus2-expected.txt: Editing delegate changes.
        * editing/selection/anchor-focus3-expected.txt: Ditto.
        * editing/selection/drag-select-rapidly-expected.txt: Added.
        * editing/selection/drag-select-rapidly.html: Added.
        * platform/mac/editing/selection/drag-select-1-expected.txt: Selects the correct range of text.
        * platform/mac/editing/selection/fake-drag-expected.txt: Ditto.
        * platform/mac/editing/selection/inline-closest-leaf-child-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a baseline for linux for this test since it matches what we have for OSX
levin@chromium.org [Mon, 14 Mar 2011 20:45:29 +0000 (20:45 +0000)]
Add a baseline for linux for this test since it matches what we have for OSX
except for the typical minor font differences.

* platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Added.
* platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
* platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
mrowe@apple.com [Mon, 14 Mar 2011 20:40:49 +0000 (20:40 +0000)]
<webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

* API/JSClassRef.cpp:
(OpaqueJSClass::OpaqueJSClass): Don't leak any existing entry for the given name if
the class definition contains duplicates. This also removes what look to be leaks
of the StringImpl instances that are used as keys: the HashMap key type is a RefPtr
which retains / releases the instances at the appropriate time, so explicitly calling
ref is not necessary.

Tools:

* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions): Remove duplicate entries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoApply a large, blunt object directly to the skull of the Leopard build.
mrowe@apple.com [Mon, 14 Mar 2011 20:40:45 +0000 (20:40 +0000)]
Apply a large, blunt object directly to the skull of the Leopard build.

Reviewed by Timothy Hatcher.

* Configurations/Base.xcconfig: Disable the generation of debugging symbols when
building the Debug configuration on Leopard. This should cut the size of the object
files that the linker needs to process by over 85%. This will hopefully allow them
to fit in to the 32-bit address space of the Leopard linker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=56246
hyatt@apple.com [Mon, 14 Mar 2011 20:30:06 +0000 (20:30 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=56246

Reviewed by Beth Dakin.

Add support for relative positioning to table cells.   Back out the code that hacked around the lack of support
for offsetLeft, and add new tests to demonstrate that relative positioning works.

Source/WebCore:

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::offsetParent):
* rendering/RenderObject.h:
(WebCore::RenderObject::isRelPositioned):
* rendering/RenderTableCell.h:
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

* fast/table/relative-position-containment.html: Added.
* fast/table/relative-position-offsets.html: Added.
* fast/table/relative-position-stacking.html: Added.
* platform/mac/fast/table/overflowHidden-expected.txt:
* platform/mac/fast/table/relative-position-containment-expected.checksum: Added.
* platform/mac/fast/table/relative-position-containment-expected.png: Added.
* platform/mac/fast/table/relative-position-containment-expected.txt: Added.
* platform/mac/fast/table/relative-position-offsets-expected.checksum: Added.
* platform/mac/fast/table/relative-position-offsets-expected.png: Added.
* platform/mac/fast/table/relative-position-offsets-expected.txt: Added.
* platform/mac/fast/table/relative-position-stacking-expected.checksum: Added.
* platform/mac/fast/table/relative-position-stacking-expected.png: Added.
* platform/mac/fast/table/relative-position-stacking-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPartial backout of https://bugs.webkit.org/show_bug.cgi?id=56230. Go back to repaint...
hyatt@apple.com [Mon, 14 Mar 2011 20:20:00 +0000 (20:20 +0000)]
Partial backout of https://bugs.webkit.org/show_bug.cgi?id=56230.  Go back to repainting the root
layer, since first layouts and printing mess up otherwise.

Reviewed by Beth Dakin.

* page/FrameView.cpp:
(WebCore::FrameView::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImprovements for the mondo linux debug failure list changes:
levin@chromium.org [Mon, 14 Mar 2011 20:19:02 +0000 (20:19 +0000)]
Improvements for the mondo linux debug failure list changes:
 + Add more tests that belong there.
 + Sort the tests that are there.
 + Add PASS to the lines that are there since these tests are known to pass and a passing
   result for them shouldn't cause a test run to go orange.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
alice.liu@apple.com [Mon, 14 Mar 2011 19:13:38 +0000 (19:13 +0000)]
DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"

Reviewed by Dan Bernstein.

* DumpRenderTree/mac/PerlSupport/Makefile:
Add whitespace when joining "-arch" with the architectures passed in as arguments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClean up full repainting of layers during layout and at other times. Platforms that...
hyatt@apple.com [Mon, 14 Mar 2011 18:59:52 +0000 (18:59 +0000)]
Clean up full repainting of layers during layout and at other times.  Platforms that did not do an invalidation on
size changes were incorrectly relying on the DoFullRepaint case of RenderLayer::updateLayerPositions to invalidate
for them. However this code is now wrong, since it assumed that the outermost layer was a RenderView that encompassed
all of the child layers.  This is no longer the case since the overflow changes that tightened up visual overflow
and limited that overflow only to content that the layer painted.

Reviewed by Simon Fraser.

Eliminate the DoFullRepaint flag and actually make no repainting of any kind happen from the layer code if FrameView's
m_doFullRepaint boolean is set.  This will flush out any ports that aren't just invalidating the world on their
own in response to view resizes or fixed layout size changes and force them to fix things to be consistent with
the other ports.

Make the two dynamic calls to updateLayerPositions still do a full repaint by setting the repaint flag on the layer.
I'm suspicious as to the correctness of the repainting in both of these cases (both before and after this patch),
but the behavior should be the same.

No new tests, since this is untestable on ports that invalidate on a resize.

* page/FrameView.cpp:
(WebCore::FrameView::layout):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::styleDidChange):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::removeOnlyThisLayer):
* rendering/RenderLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaselines due to r81035.
levin@chromium.org [Mon, 14 Mar 2011 18:51:38 +0000 (18:51 +0000)]
Rebaselines due to r81035.
Also, added yet more tests to the linux debug crash sweeping through the layout tests.

* platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-1-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-1-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-10-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-10-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-2-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-2-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-3-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-3-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-4-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-4-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-5-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-5-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-6-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-6-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-7-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-7-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-8-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-8-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-9-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-9-expected.png: Added.
* platform/chromium-linux/fast/html/details-no-summary1-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-no-summary1-expected.png: Added.
* platform/chromium-linux/fast/html/details-no-summary2-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-no-summary2-expected.png: Added.
* platform/chromium-linux/fast/html/details-no-summary3-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-no-summary3-expected.png: Added.
* platform/chromium-linux/fast/html/details-no-summary4-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-no-summary4-expected.png: Added.
* platform/chromium-linux/fast/html/details-open-javascript-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-open-javascript-expected.png: Added.
* platform/chromium-linux/fast/html/details-open1-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-open1-expected.png: Added.
* platform/chromium-linux/fast/html/details-open2-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-open2-expected.png: Added.
* platform/chromium-linux/fast/html/details-open3-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-open3-expected.png: Added.
* platform/chromium-linux/fast/html/details-open4-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-open4-expected.png: Added.
* platform/chromium-linux/fast/html/details-open5-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-open5-expected.png: Added.
* platform/chromium-linux/fast/html/details-open6-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-open6-expected.png: Added.
* platform/chromium-linux/fast/html/details-position-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-position-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-1-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-remove-summary-1-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-2-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-remove-summary-2-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-3-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-remove-summary-3-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-4-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-remove-summary-4-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-5-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-remove-summary-5-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-6-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-remove-summary-6-expected.png: Added.
* platform/chromium-linux/fast/html/details-writing-mode-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-writing-mode-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-1-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-1-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-1-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-10-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-10-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-10-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-2-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-2-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-2-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-3-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-3-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-3-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-4-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-4-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-4-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-5-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-5-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-5-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-6-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-6-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-6-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-7-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-7-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-7-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-8-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-8-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-8-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-9-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-9-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-9-expected.txt: Added.
* platform/chromium-mac/fast/html/details-no-summary1-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-no-summary1-expected.png: Added.
* platform/chromium-mac/fast/html/details-no-summary1-expected.txt: Added.
* platform/chromium-mac/fast/html/details-no-summary2-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-no-summary2-expected.png: Added.
* platform/chromium-mac/fast/html/details-no-summary2-expected.txt: Added.
* platform/chromium-mac/fast/html/details-no-summary3-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-no-summary3-expected.png: Added.
* platform/chromium-mac/fast/html/details-no-summary3-expected.txt: Added.
* platform/chromium-mac/fast/html/details-no-summary4-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-no-summary4-expected.png: Added.
* platform/chromium-mac/fast/html/details-no-summary4-expected.txt: Added.
* platform/chromium-mac/fast/html/details-open-javascript-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-open-javascript-expected.png: Added.
* platform/chromium-mac/fast/html/details-open-javascript-expected.txt: Added.
* platform/chromium-mac/fast/html/details-open1-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-open1-expected.png: Added.
* platform/chromium-mac/fast/html/details-open1-expected.txt: Added.
* platform/chromium-mac/fast/html/details-open2-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-open2-expected.png: Added.
* platform/chromium-mac/fast/html/details-open2-expected.txt: Added.
* platform/chromium-mac/fast/html/details-open3-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-open3-expected.png: Added.
* platform/chromium-mac/fast/html/details-open3-expected.txt: Added.
* platform/chromium-mac/fast/html/details-open4-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-open4-expected.png: Added.
* platform/chromium-mac/fast/html/details-open4-expected.txt: Added.
* platform/chromium-mac/fast/html/details-open5-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-open5-expected.png: Added.
* platform/chromium-mac/fast/html/details-open5-expected.txt: Added.
* platform/chromium-mac/fast/html/details-open6-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-open6-expected.png: Added.
* platform/chromium-mac/fast/html/details-open6-expected.txt: Added.
* platform/chromium-mac/fast/html/details-position-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-position-expected.png: Added.
* platform/chromium-mac/fast/html/details-position-expected.txt: Added.
* platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-remove-summary-1-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-remove-summary-1-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-1-expected.txt: Added.
* platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-remove-summary-2-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-remove-summary-2-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-2-expected.txt: Added.
* platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-remove-summary-3-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-remove-summary-3-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-3-expected.txt: Added.
* platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-remove-summary-4-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-remove-summary-4-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-4-expected.txt: Added.
* platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-remove-summary-5-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-remove-summary-5-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-5-expected.txt: Added.
* platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-remove-summary-6-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-remove-summary-6-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-6-expected.txt: Added.
* platform/chromium-mac/fast/html/details-writing-mode-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-writing-mode-expected.png: Added.
* platform/chromium-mac/fast/html/details-writing-mode-expected.txt: Added.
* platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-1-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-1-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-1-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-10-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-10-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-10-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-2-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-2-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-2-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-3-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-3-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-3-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-4-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-4-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-4-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-5-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-5-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-5-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-6-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-6-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-6-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-7-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-7-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-7-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-8-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-8-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-8-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-9-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-9-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-9-expected.txt: Added.
* platform/chromium-win/fast/html/details-no-summary1-expected.checksum: Added.
* platform/chromium-win/fast/html/details-no-summary1-expected.png: Added.
* platform/chromium-win/fast/html/details-no-summary1-expected.txt: Added.
* platform/chromium-win/fast/html/details-no-summary2-expected.checksum: Added.
* platform/chromium-win/fast/html/details-no-summary2-expected.png: Added.
* platform/chromium-win/fast/html/details-no-summary2-expected.txt: Added.
* platform/chromium-win/fast/html/details-no-summary3-expected.checksum: Added.
* platform/chromium-win/fast/html/details-no-summary3-expected.png: Added.
* platform/chromium-win/fast/html/details-no-summary3-expected.txt: Added.
* platform/chromium-win/fast/html/details-no-summary4-expected.checksum: Added.
* platform/chromium-win/fast/html/details-no-summary4-expected.png: Added.
* platform/chromium-win/fast/html/details-no-summary4-expected.txt: Added.
* platform/chromium-win/fast/html/details-open-javascript-expected.checksum: Added.
* platform/chromium-win/fast/html/details-open-javascript-expected.png: Added.
* platform/chromium-win/fast/html/details-open-javascript-expected.txt: Added.
* platform/chromium-win/fast/html/details-open1-expected.checksum: Added.
* platform/chromium-win/fast/html/details-open1-expected.png: Added.
* platform/chromium-win/fast/html/details-open1-expected.txt: Added.
* platform/chromium-win/fast/html/details-open2-expected.checksum: Added.
* platform/chromium-win/fast/html/details-open2-expected.png: Added.
* platform/chromium-win/fast/html/details-open2-expected.txt: Added.
* platform/chromium-win/fast/html/details-open3-expected.checksum: Added.
* platform/chromium-win/fast/html/details-open3-expected.png: Added.
* platform/chromium-win/fast/html/details-open3-expected.txt: Added.
* platform/chromium-win/fast/html/details-open4-expected.checksum: Added.
* platform/chromium-win/fast/html/details-open4-expected.png: Added.
* platform/chromium-win/fast/html/details-open4-expected.txt: Added.
* platform/chromium-win/fast/html/details-open5-expected.checksum: Added.
* platform/chromium-win/fast/html/details-open5-expected.png: Added.
* platform/chromium-win/fast/html/details-open5-expected.txt: Added.
* platform/chromium-win/fast/html/details-open6-expected.checksum: Added.
* platform/chromium-win/fast/html/details-open6-expected.png: Added.
* platform/chromium-win/fast/html/details-open6-expected.txt: Added.
* platform/chromium-win/fast/html/details-position-expected.checksum: Added.
* platform/chromium-win/fast/html/details-position-expected.png: Added.
* platform/chromium-win/fast/html/details-position-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-1-expected.checksum: Added.
* platform/chromium-win/fast/html/details-remove-summary-1-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-1-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-2-expected.checksum: Added.
* platform/chromium-win/fast/html/details-remove-summary-2-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-2-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-3-expected.checksum: Added.
* platform/chromium-win/fast/html/details-remove-summary-3-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-3-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-4-expected.checksum: Added.
* platform/chromium-win/fast/html/details-remove-summary-4-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-4-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-5-expected.checksum: Added.
* platform/chromium-win/fast/html/details-remove-summary-5-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-5-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-6-expected.checksum: Added.
* platform/chromium-win/fast/html/details-remove-summary-6-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-6-expected.txt: Added.
* platform/chromium-win/fast/html/details-writing-mode-expected.checksum: Added.
* platform/chromium-win/fast/html/details-writing-mode-expected.png: Added.
* platform/chromium-win/fast/html/details-writing-mode-expected.txt: Added.
* platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix windows build
oliver@apple.com [Mon, 14 Mar 2011 18:39:40 +0000 (18:39 +0000)]
Fix windows build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-14 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Mon, 14 Mar 2011 18:38:38 +0000 (18:38 +0000)]
2011-03-14  Daniel Bates  <dbates@rim.com>

        https://bugs.webkit.org/show_bug.cgi?id=55438
        Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
        when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-14 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Mon, 14 Mar 2011 18:23:24 +0000 (18:23 +0000)]
2011-03-14  Daniel Bates  <dbates@rim.com>

        Reviewed by David Kilzer.

        Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
        https://bugs.webkit.org/show_bug.cgi?id=55438

        Separate out the EFL- and WinCE-specific logic from the port-independent logic in
        webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
        CMake arguments for feature defines.

        * Scripts/build-webkit:
          - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
          - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
          - Sorted forward declarations.
          - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
            Modified call sites as needed.
        * Scripts/webkitdirs.pm:
          - Added cleanCMakeGeneratedProject() to clean a CMake build.
          - Added buildCMakeGeneratedProject() to build using generated build system.
          - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
          - Added generateBuildSystemFromCMakeProject() to generate the build system from
            a CMake project.
          - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-11 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 14 Mar 2011 18:16:36 +0000 (18:16 +0000)]
2011-03-11  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Ensure all values are correctly tagged in the registerfile
        https://bugs.webkit.org/show_bug.cgi?id=56214

        This patch makes sure that all JSCell pointers written to
        the registerfile are correctly tagged as JSCells, and replaces
        raw int usage with the immediate representation.

        For performance, register pressure, and general saneness reasons
        I've added abstractions for reading and writing the tag
        and payload of integer registers directly for the JSVALUE64
        encoding.

        * interpreter/Register.h:
        (JSC::Register::withInt):
        (JSC::Register::withCallee):
        (JSC::Register::operator=):
        (JSC::Register::i):
        (JSC::Register::activation):
        (JSC::Register::function):
        (JSC::Register::propertyNameIterator):
        (JSC::Register::scopeChain):
        * jit/JIT.h:
        * jit/JITCall.cpp:
        (JSC::JIT::compileOpCallInitializeCallFrame):
        (JSC::JIT::compileOpCallVarargs):
        (JSC::JIT::compileOpCall):
        * jit/JITCall32_64.cpp:
        (JSC::JIT::compileOpCallInitializeCallFrame):
        (JSC::JIT::compileOpCallVarargs):
        (JSC::JIT::compileOpCall):
        (JSC::JIT::compileOpCallSlowCase):
        * jit/JITInlineMethods.h:
        (JSC::JIT::emitPutToCallFrameHeader):
        (JSC::JIT::emitPutCellToCallFrameHeader):
        (JSC::JIT::emitPutIntToCallFrameHeader):
        * jit/JITOpcodes.cpp:
        (JSC::JIT::privateCompileCTINativeCall):
        (JSC::JIT::emit_op_get_pnames):
        (JSC::JIT::emit_op_next_pname):
        (JSC::JIT::emit_op_load_varargs):
        (JSC::JIT::emitSlow_op_load_varargs):
        * jit/JITOpcodes32_64.cpp:
        (JSC::JIT::privateCompileCTINativeCall):
        (JSC::JIT::emit_op_get_pnames):
        (JSC::JIT::emit_op_next_pname):
        * jit/JSInterfaceJIT.h:
        (JSC::JSInterfaceJIT::intPayloadFor):
        (JSC::JSInterfaceJIT::intTagFor):
        * jit/SpecializedThunkJIT.h:
        (JSC::SpecializedThunkJIT::returnJSValue):
        (JSC::SpecializedThunkJIT::returnDouble):
        (JSC::SpecializedThunkJIT::returnInt32):
        (JSC::SpecializedThunkJIT::returnJSCell):
2011-03-11  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Ensure all values are correctly tagged in the registerfile
        https://bugs.webkit.org/show_bug.cgi?id=56214

        Make sure everything builds still.

        * bridge/c/c_class.cpp:
        * bridge/c/c_runtime.cpp:
        * bridge/jni/JavaMethod.cpp:
        * plugins/PluginViewNone.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix for r81035.
luiz@webkit.org [Mon, 14 Mar 2011 18:02:39 +0000 (18:02 +0000)]
Unreviewed build fix for r81035.

* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::defaultEventHandler):
* rendering/RenderDetailsMarker.cpp:
(WebCore::createDownArrowPath):
(WebCore::createUpArrowPath):
(WebCore::createLeftArrowPath):
(WebCore::createRightArrowPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-12 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Mon, 14 Mar 2011 17:52:31 +0000 (17:52 +0000)]
2011-03-12  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        FullScreen: Handle entering full screen security restrictions
        https://bugs.webkit.org/show_bug.cgi?id=56264

        * fullscreen/full-screen-css.html: Use runWithKeyDown.
        * fullscreen/full-screen-remove-ancestor.html: Ditto.
        * fullscreen/full-screen-remove.html: Ditto.
        * fullscreen/full-screen-request.html: Ditto.
        * fullscreen/full-screen-twice.html: Ditto.
        * fullscreen/full-screen-test.js:
        * fullscreen/full-screen-iframe-allowed-expected.txt: Added.
        * fullscreen/full-screen-iframe-allowed.html: Added.
        * fullscreen/full-screen-iframe-not-allowed-expected.txt: Added.
        * fullscreen/full-screen-iframe-not-allowed.html: Added.
        (runWithKeyDown): Added.  Wraps the command in a keyDown/keyPress
            listener.
        * platform/mac-wk2/Skipped: Added new tests to skipped list.
        * platform/qt-wk2/Skipped: Ditto.
2011-03-13  Jer Noble  <jer.noble@apple.com>

        FullScreen: Handle entering full screen security restrictions
        https://bugs.webkit.org/show_bug.cgi?id=56264

        Tests: fullscreen/full-screen-iframe-allowed.html
               fullscreen/full-screen-iframe-not-allowed.html

        Disable full screen documents in the following conditions:
        1) requesting element is in an iframe which does not have a
        webkitallowfullscreen attribute.
        2) page is not processing a user gesture.

        * dom/Document.cpp:
        (WebCore::Document::fullScreenIsAllowedForElement): Added.  Checks
            to see if elements contained in IFRAMES are allowed to
            enter full screen.
        (WebCore::Document::webkitRequestFullScreenForElement): Checks
            if page is currently processing a user gesture.
        * dom/Document.h:
        * html/HTMLAttributeNames.in: Added webkitallowfullscreenAttr.
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::allowFullScreen): Added.
        * html/HTMLFrameElementBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r80892): Use of uninitialized variable "m_syncCloseDatabase" in StorageAre...
levin@chromium.org [Mon, 14 Mar 2011 17:46:29 +0000 (17:46 +0000)]
REGRESSION(r80892): Use of uninitialized variable "m_syncCloseDatabase" in StorageAreaSync::sync
https://bugs.webkit.org/show_bug.cgi?id=56303

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-14
Reviewed by David Levin.

Initialized m_syncCloseDatabase to false in the StorageAreaSync constructor.

* storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::StorageAreaSync):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-14 Steve Block <steveblock@google.com>
steveblock@google.com [Mon, 14 Mar 2011 17:39:12 +0000 (17:39 +0000)]
2011-03-14  Steve Block  <steveblock@google.com>

        Reviewed by Oliver Hunt.

        JavaMethod.cpp does not compile with V8
        https://bugs.webkit.org/show_bug.cgi?id=56306

        Moved the ScopeChain.h include to JavaStringJSC.

        No new tests, build fix only.

        * bridge/jni/JavaMethod.cpp:
        * bridge/jni/jsc/JavaStringJSC.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHTML5 <details> and <summary>: rendering
luiz@webkit.org [Mon, 14 Mar 2011 17:35:17 +0000 (17:35 +0000)]
HTML5 <details> and <summary>: rendering
https://bugs.webkit.org/show_bug.cgi?id=51071

Reviewed by Dave Hyatt.

Source/WebCore:

Tests: fast/html/details-add-summary-1-and-click.html
       fast/html/details-add-summary-1.html
       fast/html/details-add-summary-10-and-click.html
       fast/html/details-add-summary-10.html
       fast/html/details-add-summary-2-and-click.html
       fast/html/details-add-summary-2.html
       fast/html/details-add-summary-3-and-click.html
       fast/html/details-add-summary-3.html
       fast/html/details-add-summary-4-and-click.html
       fast/html/details-add-summary-4.html
       fast/html/details-add-summary-5-and-click.html
       fast/html/details-add-summary-5.html
       fast/html/details-add-summary-6-and-click.html
       fast/html/details-add-summary-6.html
       fast/html/details-add-summary-7-and-click.html
       fast/html/details-add-summary-7.html
       fast/html/details-add-summary-8-and-click.html
       fast/html/details-add-summary-8.html
       fast/html/details-add-summary-9-and-click.html
       fast/html/details-add-summary-9.html
       fast/html/details-mouse-click.html
       fast/html/details-no-summary1.html
       fast/html/details-no-summary2.html
       fast/html/details-no-summary3.html
       fast/html/details-no-summary4.html
       fast/html/details-open-javascript.html
       fast/html/details-open1.html
       fast/html/details-open2.html
       fast/html/details-open3.html
       fast/html/details-open4.html
       fast/html/details-open5.html
       fast/html/details-open6.html
       fast/html/details-position.html
       fast/html/details-remove-summary-1-and-click.html
       fast/html/details-remove-summary-1.html
       fast/html/details-remove-summary-2-and-click.html
       fast/html/details-remove-summary-2.html
       fast/html/details-remove-summary-3-and-click.html
       fast/html/details-remove-summary-3.html
       fast/html/details-remove-summary-4-and-click.html
       fast/html/details-remove-summary-4.html
       fast/html/details-remove-summary-5-and-click.html
       fast/html/details-remove-summary-5.html
       fast/html/details-remove-summary-6-and-click.html
       fast/html/details-remove-summary-6.html
       fast/html/details-writing-mode.html

http://www.w3.org/TR/html5/interactive-elements.html#the-details-element

The main <summary> element is the first <summary> element of a <details> element.
All other childs of the <details> element are rendered only if the attribute 'open' is set.
Click event toggles the 'open' attribute.

* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::HTMLDetailsElement):
(WebCore::HTMLDetailsElement::findMainSummary):
(WebCore::HTMLDetailsElement::childrenChanged):
(WebCore::HTMLDetailsElement::finishParsingChildren):
(WebCore::HTMLDetailsElement::parseMappedAttribute):
(WebCore::HTMLDetailsElement::childShouldCreateRenderer):
(WebCore::HTMLDetailsElement::defaultEventHandler):
* html/HTMLDetailsElement.h:
(WebCore::HTMLDetailsElement::mainSummary):

Method createRenderer added to class HTMLSummaryElement.

* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createRenderer):
* html/HTMLSummaryElement.h:

The first <summary> element is positioned at the top of its <details> parent.
The area occupied by this main <summary> element is the interactive area of the
<details> element. If the <details> tag has no <summary> child an OwnedSummaryRenderer
is created and added to the corresponding RenderDetails object.

* rendering/RenderDetails.cpp:
(WebCore::RenderDetails::RenderDetails):
(WebCore::RenderDetails::destroy):
(WebCore::RenderDetails::summaryBlock):
(WebCore::RenderDetails::contentBlock):
(WebCore::RenderDetails::addChild):
(WebCore::RenderDetails::removeChild):
(WebCore::RenderDetails::setMarkerStyle):
(WebCore::RenderDetails::styleDidChange):
(WebCore::RenderDetails::getRenderPosition):
(WebCore::RenderDetails::markerDestroyed):
(WebCore::RenderDetails::summaryDestroyed):
(WebCore::RenderDetails::moveSummaryToContents):
(WebCore::RenderDetails::createSummaryStyle):
(WebCore::RenderDetails::replaceMainSummary):
(WebCore::RenderDetails::createDefaultSummary):
(WebCore::RenderDetails::checkMainSummary):
(WebCore::RenderDetails::layout):
(WebCore::RenderDetails::isOpen):
(WebCore::RenderDetails::getParentOfFirstLineBox):
(WebCore::RenderDetails::firstNonMarkerChild):
(WebCore::RenderDetails::updateMarkerLocation):
* rendering/RenderDetails.h:
(WebCore::RenderDetails::interactiveArea):
(WebCore::RenderDetails::removeLeftoverAnonymousBlock):
(WebCore::RenderDetails::createsAnonymousWrapper):
(WebCore::RenderDetails::requiresForcedStyleRecalcPropagation):

A marker is added to the main <summary> element to indicate the current value of the 'open'
attribute of the <details> element.

* rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::RenderDetailsMarker):
(WebCore::RenderDetailsMarker::destroy):
(WebCore::RenderDetailsMarker::lineHeight):
(WebCore::RenderDetailsMarker::baselinePosition):
(WebCore::RenderDetailsMarker::computePreferredLogicalWidths):
(WebCore::RenderDetailsMarker::layout):
(WebCore::RenderDetailsMarker::getRelativeMarkerRect):
(WebCore::RenderDetailsMarker::isOpen):
(WebCore::createPath):
(WebCore::createDownArrowPath):
(WebCore::createUpArrowPath):
(WebCore::createLeftArrowPath):
(WebCore::createRightArrowPath):
(WebCore::RenderDetailsMarker::orientation):
(WebCore::RenderDetailsMarker::getCanonicalPath):
(WebCore::RenderDetailsMarker::getPath):
(WebCore::RenderDetailsMarker::paint):
* rendering/RenderDetailsMarker.h:
(WebCore::toRenderDetailsMarker):

* rendering/RenderSummary.cpp:
(WebCore::RenderSummary::RenderSummary):
(WebCore::RenderSummary::destroy):
(WebCore::RenderSummary::parentDetails):
(WebCore::RenderSummary::styleDidChange):
* rendering/RenderSummary.h:

* rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):

LayoutTests:

* fast/html/details-add-summary-1-and-click.html: Added.
* fast/html/details-add-summary-1.html: Added.
* fast/html/details-add-summary-10-and-click.html: Added.
* fast/html/details-add-summary-10.html: Added.
* fast/html/details-add-summary-2-and-click.html: Added.
* fast/html/details-add-summary-2.html: Added.
* fast/html/details-add-summary-3-and-click.html: Added.
* fast/html/details-add-summary-3.html: Added.
* fast/html/details-add-summary-4-and-click.html: Added.
* fast/html/details-add-summary-4.html: Added.
* fast/html/details-add-summary-5-and-click.html: Added.
* fast/html/details-add-summary-5.html: Added.
* fast/html/details-add-summary-6-and-click.html: Added.
* fast/html/details-add-summary-6.html: Added.
* fast/html/details-add-summary-7-and-click.html: Added.
* fast/html/details-add-summary-7.html: Added.
* fast/html/details-add-summary-8-and-click.html: Added.
* fast/html/details-add-summary-8.html: Added.
* fast/html/details-add-summary-9-and-click.html: Added.
* fast/html/details-add-summary-9.html: Added.
* fast/html/details-mouse-click-expected.txt: Added.
* fast/html/details-mouse-click.html: Added.
* fast/html/details-no-summary1.html: Added.
* fast/html/details-no-summary2.html: Added.
* fast/html/details-no-summary3.html: Added.
* fast/html/details-no-summary4.html: Added.
* fast/html/details-open-javascript.html: Added.
* fast/html/details-open1.html: Added.
* fast/html/details-open2.html: Added.
* fast/html/details-open3.html: Added.
* fast/html/details-open4.html: Added.
* fast/html/details-open5.html: Added.
* fast/html/details-open6.html: Added.
* fast/html/details-position.html: Added.
* fast/html/details-remove-summary-1-and-click.html: Added.
* fast/html/details-remove-summary-1.html: Added.
* fast/html/details-remove-summary-2-and-click.html: Added.
* fast/html/details-remove-summary-2.html: Added.
* fast/html/details-remove-summary-3-and-click.html: Added.
* fast/html/details-remove-summary-3.html: Added.
* fast/html/details-remove-summary-4-and-click.html: Added.
* fast/html/details-remove-summary-4.html: Added.
* fast/html/details-remove-summary-5-and-click.html: Added.
* fast/html/details-remove-summary-5.html: Added.
* fast/html/details-remove-summary-6-and-click.html: Added.
* fast/html/details-remove-summary-6.html: Added.
* fast/html/details-writing-mode.html: Added.
* platform/qt/fast/html/details-add-summary-1-and-click-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-1-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-10-and-click-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-10-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-2-and-click-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-2-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-3-and-click-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-3-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-4-and-click-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-4-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-5-and-click-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-5-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-6-and-click-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-6-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-7-and-click-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-7-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-8-and-click-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-8-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-9-and-click-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-9-expected.txt: Added.
* platform/qt/fast/html/details-no-summary1-expected.txt: Added.
* platform/qt/fast/html/details-no-summary2-expected.txt: Added.
* platform/qt/fast/html/details-no-summary3-expected.txt: Added.
* platform/qt/fast/html/details-no-summary4-expected.txt: Added.
* platform/qt/fast/html/details-open-javascript-expected.txt: Added.
* platform/qt/fast/html/details-open1-expected.txt: Added.
* platform/qt/fast/html/details-open2-expected.txt: Added.
* platform/qt/fast/html/details-open3-expected.txt: Added.
* platform/qt/fast/html/details-open4-expected.txt: Added.
* platform/qt/fast/html/details-open5-expected.txt: Added.
* platform/qt/fast/html/details-open6-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-1-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-2-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-3-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-4-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-5-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-6-expected.txt: Added.
* platform/qt/fast/html/details-writing-mode-expected.txt: Added.
* platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=56296
beidson@apple.com [Mon, 14 Mar 2011 17:20:24 +0000 (17:20 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=56296
Clean up IconDatabaseBase header.

Reviewed by Sam Weinig.

-Get rid of the "PlatformString.h" include and replace it with a forward declaration.
-Group methods by which are used in WebCore directly and which are used in WebKit ports.

This'll make it easier to use in external frameworks (like WebKit2).

* loader/icon/IconDatabase.h:
* loader/icon/IconDatabaseBase.h:
(WebCore::IconDatabaseBase::retainIconForPageURL):
(WebCore::IconDatabaseBase::releaseIconForPageURL):
(WebCore::IconDatabaseBase::iconForPageURL):
(WebCore::IconDatabaseBase::setIconURLForPageURL):
(WebCore::IconDatabaseBase::setIconDataForIconURL):
(WebCore::IconDatabaseBase::iconDataKnownForIconURL):
(WebCore::IconDatabaseBase::loadDecisionForIconURL):
(WebCore::IconDatabaseBase::importIconURLForPageURL):
(WebCore::IconDatabaseBase::importIconDataForIconURL):
(WebCore::IconDatabaseBase::open):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKit2: No icon shown for <input type=file>
weinig@apple.com [Mon, 14 Mar 2011 16:47:22 +0000 (16:47 +0000)]
WebKit2: No icon shown for <input type=file>
<rdar://problem/8988982>
https://bugs.webkit.org/show_bug.cgi?id=54288

Reviewed by Darin Adler.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::chooseIconForFiles):
Add implementation for chooseIconForFiles which calls down to Icon::createIconForFiles.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-14 Sheriff Bot <webkit.review.bot@gmail.com>
podivilov@chromium.org [Mon, 14 Mar 2011 16:43:08 +0000 (16:43 +0000)]
2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81026.
        http://trac.webkit.org/changeset/81026
        https://bugs.webkit.org/show_bug.cgi?id=56313

        Breaks gtk 64-bit tests (Requested by podivilov on #webkit).

        * inspector/debugger/xhr-breakpoints-expected.txt: Removed.
        * inspector/debugger/xhr-breakpoints.html: Removed.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81026.
        http://trac.webkit.org/changeset/81026
        https://bugs.webkit.org/show_bug.cgi?id=56313

        Breaks gtk 64-bit tests (Requested by podivilov on #webkit).

        * inspector/InspectorBrowserDebuggerAgent.cpp:
        (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
        (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
        (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
        (WebCore::InspectorBrowserDebuggerAgent::clear):
        * inspector/InspectorBrowserDebuggerAgent.h:
        * inspector/front-end/BreakpointManager.js:
        (WebInspector.BreakpointManager.prototype.createXHRBreakpoint):
        (WebInspector.BreakpointManager.prototype._createXHRBreakpoint):
        (WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
        (WebInspector.BreakpointManager.prototype._projectChanged):
        (WebInspector.BreakpointManager.prototype._validateBreakpoints):
        (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId):
        (WebInspector.BreakpointManager.prototype._createXHRBreakpointId):
        (WebInspector.XHRBreakpoint):
        (WebInspector.XHRBreakpoint.prototype._enable):
        (WebInspector.XHRBreakpoint.prototype._disable):
        (WebInspector.XHRBreakpoint.prototype._serializeToJSON):
        (WebInspector.XHRBreakpointView):
        (WebInspector.XHRBreakpointView.prototype.compareTo):
        (WebInspector.XHRBreakpointView.prototype.populateEditElement):
        (WebInspector.XHRBreakpointView.prototype.populateLabelElement):
        (WebInspector.XHRBreakpointView.prototype.populateStatusMessageElement):
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.XHRBreakpointsSidebarPane.addButtonClicked):
        (WebInspector.XHRBreakpointsSidebarPane):
        (WebInspector.XHRBreakpointsSidebarPane.prototype.addBreakpointItem):
        (WebInspector.XHRBreakpointsSidebarPane.prototype._startEditingBreakpoint):
        (WebInspector.XHRBreakpointsSidebarPane.prototype._hideEditBreakpointDialog):
        * inspector/front-end/CallStackSidebarPane.js:
        (WebInspector.CallStackSidebarPane.prototype.update):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype._debuggerPaused):
        (WebInspector.ScriptsPanel.prototype._clearInterface):
        * inspector/front-end/Settings.js:
        (WebInspector.Settings):
        * inspector/front-end/inspector.js:
        (WebInspector.resetFocusElement):
        (WebInspector.createXHRBreakpointsSidebarPane.breakpointAdded):
        (WebInspector.createXHRBreakpointsSidebarPane):
        (WebInspector.set attached):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-14 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Mon, 14 Mar 2011 16:08:51 +0000 (16:08 +0000)]
2011-03-14  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Factor out binary search algo from the insertionIndexForObjectInListSortedByFunction function.
        https://bugs.webkit.org/show_bug.cgi?id=56312

        Test: inspector/utilities.html

        * inspector/front-end/utilities.js:

2011-03-14  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Factor out binary search algo from the insertionIndexForObjectInListSortedByFunction function.
        https://bugs.webkit.org/show_bug.cgi?id=56312

        * inspector/utilities-expected.txt: Added.
        * inspector/utilities.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-12 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 14 Mar 2011 15:27:41 +0000 (15:27 +0000)]
2011-03-12  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: re-implement xhr breakpoints.
        https://bugs.webkit.org/show_bug.cgi?id=56252

        * inspector/debugger/xhr-breakpoints-expected.txt: Added.
        * inspector/debugger/xhr-breakpoints.html: Added.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-03-12  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: re-implement xhr breakpoints.
        https://bugs.webkit.org/show_bug.cgi?id=56252

        - restore xhr breakpoints one by one instead of using setAllBrowserBreakpoints
        - store xhr breakpoints in a separate setting
        - move presentation-related code from BreakpointManager to XHRBreakpointsSidebarPane

        Test: inspector/debugger/xhr-breakpoints.html

        * inspector/InspectorBrowserDebuggerAgent.cpp:
        (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
        (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
        (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
        (WebCore::InspectorBrowserDebuggerAgent::clear):
        * inspector/InspectorBrowserDebuggerAgent.h:
        * inspector/front-end/BreakpointManager.js:
        (WebInspector.BreakpointManager.prototype.setXHRBreakpoint):
        (WebInspector.BreakpointManager.prototype.removeXHRBreakpoint):
        (WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
        (WebInspector.BreakpointManager.prototype._projectChanged):
        (WebInspector.BreakpointManager.prototype._validateBreakpoints):
        (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId):
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.XHRBreakpointsSidebarPane):
        (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked.finishEditing):
        (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked):
        (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint):
        (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint):
        (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu.removeBreakpoint):
        (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu):
        (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked):
        (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked.finishEditing):
        (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked):
        (WebInspector.XHRBreakpointsSidebarPane.prototype.highlightBreakpoint):
        (WebInspector.XHRBreakpointsSidebarPane.prototype.clearBreakpointHighlight):
        (WebInspector.XHRBreakpointsSidebarPane.prototype._saveBreakpoints):
        (WebInspector.XHRBreakpointsSidebarPane.prototype._restoreBreakpoints):
        (WebInspector.XHRBreakpointsSidebarPane.prototype._projectChanged):
        * inspector/front-end/CallStackSidebarPane.js:
        (WebInspector.CallStackSidebarPane.prototype.update):
        (WebInspector.CallStackSidebarPane.prototype._xhrBreakpointHit):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype._debuggerPaused):
        (WebInspector.ScriptsPanel.prototype._clearInterface):
        * inspector/front-end/Settings.js:
        (WebInspector.Settings):
        * inspector/front-end/inspector.js:
        (WebInspector.resetFocusElement):
        (WebInspector.set attached):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-14 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 14 Mar 2011 15:16:45 +0000 (15:16 +0000)]
2011-03-14  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: move breakpoints restoring to debugger presentation model.
        https://bugs.webkit.org/show_bug.cgi?id=56123

        * http/tests/inspector/debugger-test.js:
        (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):
2011-03-14  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: move breakpoints restoring to debugger presentation model.
        https://bugs.webkit.org/show_bug.cgi?id=56123

        DebuggerModel's "breakpoint-added" and "breakpoint-removed" events are gone since
        setBreakpoint/removeBreakpoint are now called from DPM only.

        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::disable):
        (WebCore::InspectorDebuggerAgent::enableDebuggerAfterShown):
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype.enableDebugger):
        (WebInspector.DebuggerModel.prototype._debuggerWasEnabled):
        (WebInspector.DebuggerModel.prototype._debuggerWasDisabled):
        (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
        (WebInspector.DebuggerModel.prototype.setBreakpoint):
        (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
        (WebInspector.DebuggerModel.prototype.removeBreakpoint):
        (WebInspector.DebuggerModel.prototype._breakpointResolved):
        (WebInspector.DebuggerModel.prototype.reset):
        (WebInspector.DebuggerDispatcher.prototype.debuggerWasEnabled):
        (WebInspector.DebuggerDispatcher.prototype.debuggerWasDisabled):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel):
        (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled):
        (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
        (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
        (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
        (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
        (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
        (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
        (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
        (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
        (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
        (WebInspector.DebuggerPresentationModel.prototype.reset):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
        (WebInspector.ScriptsPanel.prototype._debuggerWasDisabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-14 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Mon, 14 Mar 2011 14:21:57 +0000 (14:21 +0000)]
2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81015.
        http://trac.webkit.org/changeset/81015
        https://bugs.webkit.org/show_bug.cgi?id=56308

        A Similar patch landed in r76960 (Requested by philn-tp on
        #webkit).

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 14 Mar 2011 14:00:29 +0000 (14:00 +0000)]
2011-03-14  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: don't use innerText, use textContent instead.
        https://bugs.webkit.org/show_bug.cgi?id=56307

        * inspector/elements/edit-dom-actions-expected.txt:
        * inspector/elements/edit-dom-actions.html:
        * inspector/extensions/extensions-audits-expected.txt:
2011-03-14  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: don't use innerText, use textContent instead.
        https://bugs.webkit.org/show_bug.cgi?id=56307

        * inspector/front-end/AuditFormatters.js:
        (WebInspector.AuditFormatters.snippet):
        * inspector/front-end/ElementsTreeOutline.js:
        * inspector/front-end/GoToLineDialog.js:
        * inspector/front-end/HelpScreen.js:
        (WebInspector.HelpScreen):
        * inspector/front-end/ShortcutsHelp.js:
        (WebInspector.ShortcutsSection.prototype.renderSection):
        (WebInspector.ShortcutsSection.prototype._renderHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-14 Andrey Adaikin <aandrey@google.com>
podivilov@chromium.org [Mon, 14 Mar 2011 13:44:59 +0000 (13:44 +0000)]
2011-03-14  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: [Text editor] Disable live-edit in favor of the text editor
        https://bugs.webkit.org/show_bug.cgi?id=56176

        * inspector/front-end/Settings.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-14 Andrey Adaikin <aandrey@google.com>
podivilov@chromium.org [Mon, 14 Mar 2011 13:41:23 +0000 (13:41 +0000)]
2011-03-14  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: [REGRESSION] scroll does not work in source frame when mouse is inside the gutter
        https://bugs.webkit.org/show_bug.cgi?id=56095

        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-11 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 14 Mar 2011 13:36:51 +0000 (13:36 +0000)]
2011-03-11  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: move breakpoints restoring after live edit to debugger presentation model.
        https://bugs.webkit.org/show_bug.cgi?id=56179

        Presentation model should move breakpoints based on text diff as required by "revert to revision" action in resources panel.

        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel):
        (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
        (WebInspector.DebuggerModel.prototype.setBreakpoint):
        (WebInspector.DebuggerModel.prototype.reset):
        (WebInspector.DebuggerModel.prototype.editScriptSource.didEditScriptSource):
        (WebInspector.DebuggerModel.prototype.editScriptSource):
        (WebInspector.DebuggerModel.prototype.get callFrames):
        (WebInspector.DebuggerModel.prototype._pausedScript):
        (WebInspector.DebuggerModel.prototype._resumedScript):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel):
        (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Mon, 14 Mar 2011 12:51:50 +0000 (12:51 +0000)]
2011-03-10  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Optimize backend-frontend data transfer volume for CSS styles
        https://bugs.webkit.org/show_bug.cgi?id=56111

        * inspector/styles/styles-new-API.html:
        * inspector/styles/styles-source-offsets.html:
2011-03-10  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Optimize backend-frontend data transfer volume for CSS styles
        https://bugs.webkit.org/show_bug.cgi?id=56111

        This change reduces the getStylesForNode() payload more than twice for BODY elements.

        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyle::populateObjectWithStyleProperties):
        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSProperty.parsePayload):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-14 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Mon, 14 Mar 2011 12:26:09 +0000 (12:26 +0000)]
2011-03-14  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Steve Block.

        Detach Geolocation from Frame when Page destroyed.
        https://bugs.webkit.org/show_bug.cgi?id=52877

        Ensure that all geolocation permission requests are cancelled
        when the page is detached from its frame.

        Fix fast/dom/Geolocation/window-close-popup.html to ignore position error
        generated on watch when window is closed.

        * fast/dom/Geolocation/page-reload-cancel-permission-requests-expected.txt: Added.
        * fast/dom/Geolocation/page-reload-cancel-permission-requests.html: Added.
        * fast/dom/Geolocation/resources/page-reload-cancel-permission-requests-inner.html: Added.
        * fast/dom/Geolocation/script-tests/page-reload-cancel-permission-requests.js: Added.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt-wk2/Skipped:
2011-03-14  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Steve Block.

        Detach Geolocation from Frame when Page destroyed.
        https://bugs.webkit.org/show_bug.cgi?id=52877

        On Page destruction, any outstanding Geolocation permission
        requests should be cancelled, because the Geolocation can only
        access the client indirectly via m_frame->page().

        Page destruction is signalled by a call to the
        Frame::pageDestroyed() method. This explictly calls
        DOMWindow::resetGeolocation which ultimately calls Geolocation::reset.

        Geolocation::reset() detaches from the GeolocationController,
        cancels requests, watches and single shots, and sets the
        permission state back to Unknown.

        Frame::pageDestroyed() is also called by FrameLoader even though
        the page is not destroyed. We should still cancel permission
        requests, because the GeolocationClient will become inaccessible
        to the Geolocation object after this call.

        Frame::transferChildFrameToNewDocument also indirectly calls
        Geolocation::reset when the frame is reparented between
        pages. Ideally we would like the Geolocation's activities to
        continue after reparenting, see bug
        https://bugs.webkit.org/show_bug.cgi?id=55577

        Since GeolocationController is owned by Page, and all Geolocation
        objects will now unsubscribe from the GeolocationController on
        pageDetached(), we no longer need to call stopUpdating() from the
        GeolocationController's destructor. Instead we can simply assert
        that there should be no no observers. See related bug
        https://bugs.webkit.org/show_bug.cgi?id=52216 .

        Introduced new method 'numberOfPendingPermissionRequests' on
        GeolocationClientMock to count the number of outstanding pending
        permission requests. This provides a reusable implementation for
        client-based implementations of the LayoutTestController's
        numberOfPendingGeolocationPermissionRequests method.

        Test: fast/dom/Geolocation/page-reload-cancel-permission-requests.html

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::resetGeolocation):
        * page/DOMWindow.h:
        * page/Frame.cpp:
        (WebCore::Frame::pageDestroyed):
        (WebCore::Frame::transferChildFrameToNewDocument):
        * page/Geolocation.cpp:
        (WebCore::Geolocation::~Geolocation):
        (WebCore::Geolocation::page):
        (WebCore::Geolocation::reset):
        (WebCore::Geolocation::disconnectFrame):
        (WebCore::Geolocation::lastPosition):
        (WebCore::Geolocation::requestPermission):
        (WebCore::Geolocation::startUpdating):
        (WebCore::Geolocation::stopUpdating):
        * page/Geolocation.h:
        * page/GeolocationController.cpp:
        (WebCore::GeolocationController::~GeolocationController):
        * page/Navigator.cpp:
        (WebCore::Navigator::resetGeolocation):
        * page/Navigator.h:
        * platform/mock/GeolocationClientMock.cpp:
        (WebCore::GeolocationClientMock::numberOfPendingPermissionRequests):
        * platform/mock/GeolocationClientMock.h:
2011-03-14  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Steve Block.

        Detach Geolocation from Frame when Page destroyed.
        https://bugs.webkit.org/show_bug.cgi?id=52877

        Add accessors to the WebGeolocationClientMock to allow the number of
        pending geolocation permission requests to be queried.

        * public/WebGeolocationClientMock.h:
        * src/WebGeolocationClientMock.cpp:
        (WebKit::WebGeolocationClientMock::numberOfPendingPermissionRequests):
2011-03-14  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Steve Block.

        Detach Geolocation from Frame when Page destroyed.
        https://bugs.webkit.org/show_bug.cgi?id=52877

        Extend the layout test controller to expose the number of pending
        geolocation requests, so that we can test that the requests have
        been cancelled on page close.

        * DumpRenderTree/LayoutTestController.cpp:
        (numberOfPendingGeolocationPermissionRequestsCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
        * DumpRenderTree/mac/UIDelegate.h:
        * DumpRenderTree/mac/UIDelegate.mm:
        (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::numberOfPendingGeolocationPermissionRequests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-14 Andrey Adaikin <aandrey@google.com>
podivilov@chromium.org [Mon, 14 Mar 2011 12:11:32 +0000 (12:11 +0000)]
2011-03-14  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: REGRESSION: Messed up with the tabIndex for text editor
        https://bugs.webkit.org/show_bug.cgi?id=56183

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._handleKeyDown):
        (WebInspector.SourceFrame.prototype._handleSave):
        (WebInspector.SourceFrame.prototype._handleRevertEditing):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextEditorMainPanel):
        (WebInspector.TextEditorMainPanel.prototype.set readOnly):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-14 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 14 Mar 2011 11:57:37 +0000 (11:57 +0000)]
2011-03-14  Alejandro G. Castro  <alex@igalia.com>

        Rebaseline GTK+ tests after r80996.

        * platform/gtk/fast/text/soft-hyphen-2-expected.txt:
        * platform/gtk/fast/text/soft-hyphen-4-expected.checksum: Added.
        * platform/gtk/fast/text/soft-hyphen-4-expected.png: Added.
        * platform/gtk/fast/text/soft-hyphen-4-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-14 Chris Rogers <crogers@google.com>
crogers@google.com [Mon, 14 Mar 2011 11:40:52 +0000 (11:40 +0000)]
2011-03-14  Chris Rogers  <crogers@google.com>

        Reviewed by Xan Lopez.

        Add all web audio auto-generated files to GTK make system
        https://bugs.webkit.org/show_bug.cgi?id=50497

        No new tests since these are build-system tweaks.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-14 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Mon, 14 Mar 2011 11:21:19 +0000 (11:21 +0000)]
2011-03-14  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Steve Block.

        Fix flaky layout test: fast/dom/Geolocation/window-close-crash.html
        https://bugs.webkit.org/show_bug.cgi?id=56202

        By testing for geolocation watch errors, the test tests more than
        it should, which can cause a flaky result as demonstrated by
        https://bugs.webkit.org/show_bug.cgi?id=56126 .

        * fast/dom/Geolocation/resources/window-close-popup.html:
        * fast/dom/Geolocation/script-tests/window-close-crash.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-14 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 14 Mar 2011 11:19:42 +0000 (11:19 +0000)]
2011-03-14  Alejandro G. Castro  <alex@igalia.com>

        Update more expectations after r80857.

        * platform/gtk/fast/layers/video-layer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove the crash result and the bug to the debug line for the test (instead of release)
levin@chromium.org [Mon, 14 Mar 2011 10:55:53 +0000 (10:55 +0000)]
Move the crash result and the bug to the debug line for the test (instead of release)
since that is where the crash occurs.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 14 Mar 2011 10:29:40 +0000 (10:29 +0000)]
2011-03-14  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: remove the flaky part of the new inspector test for now.

        * inspector/elements/edit-dom-actions-expected.txt:
        * inspector/elements/edit-dom-actions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 14 Mar 2011 09:45:00 +0000 (09:45 +0000)]
2011-03-14  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: make DOMAgent event target, remove dependency from ElementsPanel.
        https://bugs.webkit.org/show_bug.cgi?id=56268

        * inspector/elements/elements-panel-search.html:
        * inspector/elements/mutate-unknown-node.html:
2011-03-14  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: make DOMAgent event target, remove dependency from ElementsPanel.
        https://bugs.webkit.org/show_bug.cgi?id=56268

        * inspector/Inspector.idl:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::reset):
        (WebCore::InspectorDOMAgent::performSearch):
        (WebCore::InspectorDOMAgent::cancelSearch):
        (WebCore::InspectorDOMAgent::onMatchJobsTimer):
        (WebCore::InspectorDOMAgent::reportNodesAsSearchResults):
        * inspector/InspectorDOMAgent.h:
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMAgent.prototype.requestDocument.mycallback):
        (WebInspector.DOMAgent.prototype.requestDocument):
        (WebInspector.DOMAgent.prototype._attributesUpdated):
        (WebInspector.DOMAgent.prototype._characterDataModified):
        (WebInspector.DOMAgent.prototype._documentUpdated):
        (WebInspector.DOMAgent.prototype._setDocument):
        (WebInspector.DOMAgent.prototype._childNodeCountUpdated):
        (WebInspector.DOMAgent.prototype._childNodeInserted):
        (WebInspector.DOMAgent.prototype._childNodeRemoved):
        (WebInspector.DOMAgent.prototype._removeBreakpoints):
        (WebInspector.DOMAgent.prototype.performSearch):
        (WebInspector.DOMAgent.prototype.cancelSearch):
        (WebInspector.DOMDispatcher.prototype.searchResults):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel):
        (WebInspector.ElementsPanel.prototype._reset):
        (WebInspector.ElementsPanel.prototype._documentUpdated):
        (WebInspector.ElementsPanel.prototype.searchCanceled):
        (WebInspector.ElementsPanel.prototype.performSearch):
        (WebInspector.ElementsPanel.prototype._addNodesToSearchResult):
        (WebInspector.ElementsPanel.prototype._attributesUpdated):
        (WebInspector.ElementsPanel.prototype._characterDataModified):
        (WebInspector.ElementsPanel.prototype._nodeInserted):
        (WebInspector.ElementsPanel.prototype._nodeRemoved):
        (WebInspector.ElementsPanel.prototype._childNodeCountUpdated):
        (WebInspector.ElementsPanel.prototype.updateModifiedNodes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 14 Mar 2011 09:42:17 +0000 (09:42 +0000)]
2011-03-14  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add tests for edit dom operations.
        https://bugs.webkit.org/show_bug.cgi?id=56248

        * inspector/elements/edit-dom-actions-expected.txt: Added.
        * inspector/elements/edit-dom-actions.html: Added.
2011-03-14  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add tests for edit dom operations.
        https://bugs.webkit.org/show_bug.cgi?id=56248

        Test: inspector/elements/edit-dom-actions.html

        * inspector/Inspector.idl:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::assertNode):
        (WebCore::InspectorDOMAgent::assertElement):
        (WebCore::InspectorDOMAgent::assertHTMLElement):
        (WebCore::InspectorDOMAgent::nodeToSelectOn):
        (WebCore::InspectorDOMAgent::querySelector):
        (WebCore::InspectorDOMAgent::querySelectorAll):
        (WebCore::InspectorDOMAgent::setAttribute):
        (WebCore::InspectorDOMAgent::removeAttribute):
        (WebCore::InspectorDOMAgent::getOuterHTML):
        (WebCore::InspectorDOMAgent::setOuterHTML):
        * inspector/InspectorDOMAgent.h:
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode.prototype.setAttribute):
        (WebInspector.DOMNode.prototype.removeAttribute):
        * inspector/front-end/inspector.js:
        (WebInspector.startEditing.defaultFinishHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-14 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Mon, 14 Mar 2011 09:07:59 +0000 (09:07 +0000)]
2011-03-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Unreviewed. Modify my email address in committers.py.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix typo TEXT vs TEST.
levin@chromium.org [Mon, 14 Mar 2011 08:44:25 +0000 (08:44 +0000)]
Fix typo TEXT vs TEST.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline some test due to r80996.
levin@chromium.org [Mon, 14 Mar 2011 08:28:11 +0000 (08:28 +0000)]
Rebaseline some test due to r80996.
Rearrange some expectations (from IMAGE to IMAGE_TEXT) due to r80996
and add a few bugs which track the other failures.

* platform/chromium-linux/fast/text/capitalize-boundaries-expected.txt:
* platform/chromium-linux/fast/text/soft-hyphen-4-expected.checksum: Added.
* platform/chromium-linux/fast/text/soft-hyphen-4-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/8762095> and https://bugs.webkit.org/show_bug.cgi?id=55172
beidson@apple.com [Mon, 14 Mar 2011 07:44:17 +0000 (07:44 +0000)]
<rdar://problem/8762095> and https://bugs.webkit.org/show_bug.cgi?id=55172
Need WK2 API to view/manage origins with LocalStorage

Reviewed by Dan Bernstein.

../WebCore:

* storage/StorageTracker.cpp:
(WebCore::StorageTracker::initializeTracker): Make sure the TextEncoding map is initialized on the main thread
  before the StorageTracker thread can do it on the background thread.

../WebKit2:

Hookup the existing API stubs to the WebCore implementations:
* WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp:
(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManager::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManager::deleteAllEntries):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-14 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Mon, 14 Mar 2011 07:11:14 +0000 (07:11 +0000)]
2011-03-14  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Move cache_directory api
        https://bugs.webkit.org/show_bug.cgi?id=52139

        Move cache directory related apis from ewk_view to ewk_settings because
        those are not related to ewk_view.

        * ewk/ewk_main.cpp:
        (_ewk_init_body):
        * ewk/ewk_settings.cpp:
        (ewk_settings_cache_directory_path_set):
        (ewk_settings_cache_directory_path_get):
        * ewk/ewk_settings.h:
        * ewk/ewk_view.cpp:
        (_ewk_view_priv_new):
        (_ewk_view_priv_del):
        * ewk/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixed lock-taking order to prevent deadlock, added lock for m_client,
beidson@apple.com [Mon, 14 Mar 2011 06:24:46 +0000 (06:24 +0000)]
Fixed lock-taking order to prevent deadlock, added lock for m_client,
removed premature return in syncImportOriginIdentifiers when tracker
db does not exist because that prevented syncFileSystemAndTrackerDatabase()
from running until next LocalStorage db creation, cleaned up
StorageTracker::scheduleTask() code for readability.

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-13
Reviewed by Brady Eidson and David Levin, landed by Brady Eidson.

https://bugs.webkit.org/show_bug.cgi?id=56285

* storage/StorageTracker.cpp:
(WebCore::StorageTracker::trackerDatabasePath):
(WebCore::StorageTracker::syncImportOriginIdentifiers): If tracker db isn't
optionally opened (as in the case when it doesn't exist on disk), don't
exit early and call syncFileSystemAndTrackerDatabase(), which will create
a tracker db if localstorage db files are found on disk by calling setOriginDetails.
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::scheduleTask): readability changes.
(WebCore::StorageTracker::syncSetOriginDetails):
(WebCore::StorageTracker::syncDeleteAllOrigins):
(WebCore::StorageTracker::syncDeleteOrigin):
(WebCore::StorageTracker::cancelDeletingOrigin): order lock-taking consistently to avoid deadlock.
(WebCore::StorageTracker::setClient):
* storage/StorageTracker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReviewed and landed by Brady Eidson.
beidson@apple.com [Mon, 14 Mar 2011 06:20:58 +0000 (06:20 +0000)]
Reviewed and landed by Brady Eidson.

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-13
Invalid assertion in StorageTracker - PageGroup::numberOfPageGroups() == 1
https://bugs.webkit.org/show_bug.cgi?id=56240

This assertion is invalid until LocalStorage is either global or is isolated by PageGroup.

* storage/StorageTracker.cpp:
(WebCore::StorageTracker::origins):
(WebCore::StorageTracker::deleteAllOrigins):
(WebCore::StorageTracker::deleteOrigin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake adjustMIMETypeIfNecessary use CFNetwork directly
psolanki@apple.com [Mon, 14 Mar 2011 06:02:26 +0000 (06:02 +0000)]
Make adjustMIMETypeIfNecessary use CFNetwork directly
https://bugs.webkit.org/show_bug.cgi?id=55912

Reviewed by Dan Bernstein.

Follow up fix for Layout Test failure. Fix typo - it should be text/plain, not test/plain.

* platform/network/mac/WebCoreURLResponse.mm:
(WebCore::adjustMIMETypeIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/9127270> and https://bugs.webkit.org/show_bug.cgi?id=56282
beidson@apple.com [Mon, 14 Mar 2011 05:47:55 +0000 (05:47 +0000)]
<rdar://problem/9127270> and https://bugs.webkit.org/show_bug.cgi?id=56282

Reviewed by Sam Weinig.

Pass the path along with creation parameters:
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:

Add SPI to set the path:
* UIProcess/API/C/WKContext.cpp:
(WKContextSetLocalStorageDirectory):
* UIProcess/API/C/WKContextPrivate.h:

Pass the path along in the process creation parameters:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::localStorageDirectory):
* UIProcess/WebContext.h:
(WebKit::WebContext::setLocalStorageDirectory):

* UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformDefaultLocalStorageDirectory):
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformDefaultLocalStorageDirectory):
* UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformDefaultLocalStorageDirectory):
* UIProcess/win/WebContextWin.cpp:
(WebKit::WebContext::platformDefaultLocalStorageDirectory):

Include the path with settings updates, because WebCore needs it set on the Settings object:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
* WebProcess/WebProcess.h:
(WebKit::WebProcess::localStorageDirectory):

Sandboxing stuff:
* WebProcess/com.apple.WebProcess.sb:
* WebProcess/mac/WebProcessMac.mm:
(WebKit::initializeSandbox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-12 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Mon, 14 Mar 2011 05:35:23 +0000 (05:35 +0000)]
2011-03-12  Jer Noble  <jer.noble@apple.com>

        Reviewed by Mark Rowe.

        WebKit2: Build WKFullScreenWindowController cleanly in 32-bit.
        https://bugs.webkit.org/show_bug.cgi?id=56260

        Include <Carbon/Carbon.h> instead of <HIToolbox/MacApplication.h>.

        * UIProcess/mac/WKFullScreenWindowController.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImprove my hasitly added build fix and added a bug https://bugs.webkit.org/show_bug...
levin@chromium.org [Mon, 14 Mar 2011 05:23:08 +0000 (05:23 +0000)]
Improve my hasitly added build fix and added a bug https://bugs.webkit.org/show_bug.cgi?id=56288
above addressing this FIXME.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClean up overlapping test_expectation which I mistakenly added in my haste.
levin@chromium.org [Mon, 14 Mar 2011 05:23:01 +0000 (05:23 +0000)]
Clean up overlapping test_expectation which I mistakenly added in my haste.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInclude hyphenation information in text representation of render tree
mitz@apple.com [Mon, 14 Mar 2011 05:10:18 +0000 (05:10 +0000)]
Include hyphenation information in text representation of render tree
https://bugs.webkit.org/show_bug.cgi?id=56287

Reviewed by Sam Weinig.

Source/WebCore:

(WebCore::writeTextRun): If the text box is hyphenated, output the hyphenation
string.

LayoutTests:

* fast/text/soft-hyphen-4-expected.txt:
* platform/mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt:
* platform/mac-snowleopard/fast/text/hyphenate-locale-expected.txt:
* platform/mac/fast/text/basic/014-expected.txt:
* platform/mac/fast/text/capitalize-boundaries-expected.txt:
* platform/mac/fast/text/hyphenate-character-expected.txt:
* platform/mac/fast/text/hyphenate-first-word-expected.txt:
* platform/mac/fast/text/hyphens-expected.txt:
* platform/mac/fast/text/midword-break-after-breakable-char-expected.txt:
* platform/mac/fast/text/soft-hyphen-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoA few Heap-related renames (sans file moves, which should come next)
ggaren@apple.com [Mon, 14 Mar 2011 04:56:46 +0000 (04:56 +0000)]
A few Heap-related renames (sans file moves, which should come next)
https://bugs.webkit.org/show_bug.cgi?id=56283

Reviewed by Sam Weinig.

ConservativeSet => ConservativeRoots. "Set" was misleading, since items
are not uniqued. Also, "Roots" is more specific about what's in the set.

MachineStackMarker => MachineThreads. "Threads" is more descriptive of
the fact that this class maintains a set of all threads using JSC.
"Stack" was misleading, since this class traverses stacks and registers.
"Mark" was misleading, since this class doesn't mark anything anymore.

registerThread => addCurrentThread. "Current" is more specific.
unregisterThread => removeCurrentThread. "Current" is more specific.

"currentThreadRegistrar" => threadSpecific. The only point of this data
structure is to register a thread-specific destructor with a pointer to
this.

"mark...Conservatively" => "gather". "Mark" is not true, since these
functions don't mark anything. "Conservatively" is redundant, since they
take "ConservativeRoots" as an argument.

* API/APIShims.h:
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
* JavaScriptCore.exp:
* runtime/ConservativeSet.cpp:
(JSC::ConservativeRoots::grow):
(JSC::ConservativeRoots::add):
* runtime/ConservativeSet.h:
(JSC::ConservativeRoots::ConservativeRoots):
(JSC::ConservativeRoots::~ConservativeRoots):
(JSC::ConservativeRoots::size):
(JSC::ConservativeRoots::roots):
* runtime/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::markRoots):
* runtime/Heap.h:
(JSC::Heap::machineThreads):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::makeUsableFromMultipleThreads):
* runtime/MachineStackMarker.cpp:
(JSC::MachineThreads::MachineThreads):
(JSC::MachineThreads::~MachineThreads):
(JSC::MachineThreads::makeUsableFromMultipleThreads):
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::removeThread):
(JSC::MachineThreads::removeCurrentThread):
(JSC::MachineThreads::gatherFromCurrentThreadInternal):
(JSC::MachineThreads::gatherFromCurrentThread):
(JSC::MachineThreads::gatherFromOtherThread):
(JSC::MachineThreads::gatherConservativeRoots):
* runtime/MachineStackMarker.h:
* runtime/MarkStack.h:
(JSC::MarkStack::append):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBUILD FIX for armv7 after r80969
ddkilzer@apple.com [Mon, 14 Mar 2011 04:53:15 +0000 (04:53 +0000)]
BUILD FIX for armv7 after r80969

Bug 56270 - The JIT 'friend's many classes in JSC; start unwinding this.
<https://bugs.webkit.org/show_bug.cgi?id=56270>

* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load32): Made void* address argument
const.
(JSC::MacroAssemblerARMv7::store32): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix adding remaining enum values to switch statement.
levin@chromium.org [Mon, 14 Mar 2011 04:37:33 +0000 (04:37 +0000)]
Build fix adding remaining enum values to switch statement.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):

Add more crashing tests to an existing bug about the same issue
for Chromium Linux Debug. :(

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd some test failures that I need to investigate further.
levin@chromium.org [Mon, 14 Mar 2011 04:02:43 +0000 (04:02 +0000)]
Add some test failures that I need to investigate further.
Clean up a duplicate test expectation (default-timing-function.html ).
Add a missing test expection for linux debug which was there for linux release (border-image-vertical-lr.html).

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd more crashing tests to an existing bug about the same issue
levin@chromium.org [Mon, 14 Mar 2011 04:02:37 +0000 (04:02 +0000)]
Add more crashing tests to an existing bug about the same issue
for Chromium Linux Debug.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoVersioning.
mrowe@apple.com [Mon, 14 Mar 2011 03:02:27 +0000 (03:02 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdated expected results after r80982.
mitz@apple.com [Mon, 14 Mar 2011 02:36:48 +0000 (02:36 +0000)]
Updated expected results after r80982.

* platform/mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNot reviewed.
ggaren@apple.com [Mon, 14 Mar 2011 01:35:16 +0000 (01:35 +0000)]
Not reviewed.

Try to fix the Mac build.

* JavaScriptCore.xcodeproj/project.pbxproj: Make sure to forward
ConervativeSet.h, since it's now visible when compiling other projects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix windows build.
weinig@apple.com [Mon, 14 Mar 2011 01:27:37 +0000 (01:27 +0000)]
Fix windows build.

* platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::ResourceError):
Add missing constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-13 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 14 Mar 2011 01:16:15 +0000 (01:16 +0000)]
2011-03-13  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Removed another case of DeprecatedPtr (ConservativeSet)
        https://bugs.webkit.org/show_bug.cgi?id=56281

        The ConservativeSet is an internal data structure used during marking,
        so direct pointers are fine.

        * runtime/ConservativeSet.cpp:
        (JSC::ConservativeSet::grow):
        * runtime/ConservativeSet.h: Added some accessors, for use by MarkStack::append.
        (JSC::ConservativeSet::~ConservativeSet): Fixed a typo where we calculated
        the size of the set based on sizeof(DeprecatedPtr<T>*) instead of
        sizeof(DeprecatedPtr<T>). I'm not sure if this had real-world implications or not.
        (JSC::ConservativeSet::size):
        (JSC::ConservativeSet::set): Use direct pointers, as stated above.

        * runtime/Heap.cpp:
        (JSC::Heap::markRoots):
        * runtime/MarkStack.h:
        (JSC::MarkStack::append): Created a special case of append for
        ConservativeSet. I didn't want to add back a generic "append JSCell*"
        function, since other class might start using that wrong. (In the end,
        this function might go away, since the Heap will want to do something
        slightly more interesting with the conservative set, but this is OK for
        now.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: REGRESSION: Soft hyphen is not always rendered
mitz@apple.com [Mon, 14 Mar 2011 01:09:26 +0000 (01:09 +0000)]
Source/WebCore: REGRESSION: Soft hyphen is not always rendered
https://bugs.webkit.org/show_bug.cgi?id=56017

Patch by David Sosby <dsosby@rim.com> on 2011-03-13
Reviewed by Dan Bernstein.

The check to flag a text block as hyphenated was only
occurring at break points in the line. If no break points
were found after the soft hyphen then the line would not
be flagged hyphenated. Adding a check for soft hyphen at
the end of the text run resolves the issue.

Test: fast/text/soft-hyphen-4.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak):

LayoutTests: Reviewed and tweaked by Dan Bernstein.

Patch by David Sosby <dsosby@rim.com> on 2011-03-13
REGRESSION: Soft hyphen is not always rendered
https://bugs.webkit.org/show_bug.cgi?id=56017

Adding new test that verifies soft hyphen is rendered
when it is the last breakable point in a line.

* fast/text/soft-hyphen-4-expected.checksum: Added.
* fast/text/soft-hyphen-4-expected.png: Added.
* fast/text/soft-hyphen-4-expected.txt: Added.
* fast/text/soft-hyphen-4.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate some baselines due to r80868.
levin@chromium.org [Mon, 14 Mar 2011 00:58:03 +0000 (00:58 +0000)]
Update some baselines due to r80868.
Also, add MAC to a failure line where I should have put it previously.

* platform/chromium-mac/fast/backgrounds/animated-svg-as-background-expected.checksum: Added.
* platform/chromium-mac/fast/backgrounds/animated-svg-as-background-expected.png: Added.
* platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.checksum: Added.
* platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r80438): fast/text/hyphenate-character failing in pixel mode
mitz@apple.com [Mon, 14 Mar 2011 00:54:59 +0000 (00:54 +0000)]
REGRESSION (r80438): fast/text/hyphenate-character failing in pixel mode
https://bugs.webkit.org/show_bug.cgi?id=56280

Reviewed by Mark Rowe.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::tryHyphenating): Avoid subtracting 1 from an unsigned 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd ability to create a WKErrorRef
weinig@apple.com [Mon, 14 Mar 2011 00:34:34 +0000 (00:34 +0000)]
Add ability to create a WKErrorRef
<rdar://problem/9115768>
https://bugs.webkit.org/show_bug.cgi?id=56279

Reviewed by Anders Carlsson.

Source/WebCore:

* WebCore.exp.in:
Add new exports.

* platform/network/cf/ResourceError.h:
* platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::platformCompare):
(WebCore::ResourceError::cfError):
(WebCore::ResourceError::operator CFErrorRef):
(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::cfStreamError):
(WebCore::ResourceError::operator CFStreamError):
* platform/network/mac/ResourceErrorMac.mm:
(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::platformCompare):
(WebCore::ResourceError::nsError):
(WebCore::ResourceError::operator NSError *):
(WebCore::ResourceError::cfError):
(WebCore::ResourceError::operator CFErrorRef):
Clean up ResourceError a bit and add ability to create a ResourceError from a CFErrorRef
regardless of whether CFNetwork is being used.

Source/WebKit2:

* Shared/API/c/cf/WKErrorCF.cpp: Added.
(WKErrorCreateWithCFError):
(WKErrorCopyCFError):
* Shared/API/c/cf/WKErrorCF.h: Added.
Add new API to create a WKErrorRef from a CFErrorRef
and vice-versa.

* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* win/WebKit2Generated.make:
Add new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-13 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 14 Mar 2011 00:34:32 +0000 (00:34 +0000)]
2011-03-13  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Removed another case of DeprecatedPtr (PutPropertySlot)
        https://bugs.webkit.org/show_bug.cgi?id=56278

        * runtime/PutPropertySlot.h:
        (JSC::PutPropertySlot::setExistingProperty):
        (JSC::PutPropertySlot::setNewProperty):
        (JSC::PutPropertySlot::base): Direct pointer is fine for PutPropertySlot,
        since it's a stack-allocated temporary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd one more failure which is related to change in this range:
levin@chromium.org [Mon, 14 Mar 2011 00:31:59 +0000 (00:31 +0000)]
Add one more failure which is related to change in this range:
  http://trac.webkit.org/log/?verbose=on&rev=80866&stop_rev=80860
that I haven't been able to narrow down yet.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd more crashing tests to an existing bug about the same issue
levin@chromium.org [Mon, 14 Mar 2011 00:31:52 +0000 (00:31 +0000)]
Add more crashing tests to an existing bug about the same issue
for Chromium Linux Debug.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-13 Joe Wild <joseph.wild@nokia.com>
commit-queue@webkit.org [Mon, 14 Mar 2011 00:15:31 +0000 (00:15 +0000)]
2011-03-13  Joe Wild  <joseph.wild@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] QtLauncher does not load the same set of fonts as the DRT
        https://bugs.webkit.org/show_bug.cgi?id=34959

        This patch adds the option "-use-test-fonts" to the QtTestBrowser.
        When this option is used the webkit fonts are loaded the same
        as they are in DumpRenderTree.  This option can be used on
        QtTestBrowser and run-launcher.  It can only be used
        on Linux systems with FcInit and is configured as such.

        * QtTestBrowser/launcherwindow.h:
        (WindowOptions::WindowOptions):
        * QtTestBrowser/main.cpp:
        (initWebKitTestFonts):
        (launcherMain):
        (LauncherApplication::handleUserOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-13 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 14 Mar 2011 00:14:18 +0000 (00:14 +0000)]
2011-03-13  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Removed one case of DeprecatedPtr (ScopeChainIterator)
        https://bugs.webkit.org/show_bug.cgi?id=56277

        * runtime/ScopeChain.h: Direct pointer is fine for ScopeChainIterator,
        since it's a stack-allocated temporary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake adjustMIMETypeIfNecessary use CFNetwork directly
psolanki@apple.com [Mon, 14 Mar 2011 00:10:38 +0000 (00:10 +0000)]
Make adjustMIMETypeIfNecessary use CFNetwork directly
https://bugs.webkit.org/show_bug.cgi?id=55912

Reviewed by Brady Eidson.

Source/WebCore:

Convert category method [NSURLResponse adjustMIMETypeIfNecessary] to C function
WebCore::adjustMIMETypeIfNecessary() that takes a CFURLResponseRef and is functionally
identical.

Testing is covered by existing LayoutTests.

* WebCore.exp.in:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
* platform/network/mac/ResourceHandleMac.mm:
(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
* platform/network/mac/WebCoreURLResponse.h:
* platform/network/mac/WebCoreURLResponse.mm:
(WebCore::createBinaryExtensionsSet):
(WebCore::createExtensionToMIMETypeMap):
(WebCore::mimeTypeFromUTITree):
(WebCore::adjustMIMETypeIfNecessary):

Source/WebKit/mac:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Support for new WKSI functions.

Source/WebKit2:

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Support for new WKSI functions.

WebKitLibraries:

Add new WKSI functions needed to implement adjustMIMETypeIfNecessary.

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the expectation to refer to transitions/default-timing-function.html
levin@chromium.org [Sun, 13 Mar 2011 22:41:00 +0000 (22:41 +0000)]
Fix the expectation to refer to transitions/default-timing-function.html
instead of bug1318. My change log description also made the same mistake.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSort some test expectations into a better place. Move a linux debug
levin@chromium.org [Sun, 13 Mar 2011 22:37:37 +0000 (22:37 +0000)]
Sort some test expectations into a better place. Move a linux debug
crash to be near the other instances of it.

Remove fast/text/font-size-zero.html as it appears to be passing consistently.

Add the expectation for bug1318.html due to r80806 changing its output in a way
that looks less optimal than it did before.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBug 56273 - Add three operand forms to MacroAssember operations.
barraclough@apple.com [Sun, 13 Mar 2011 22:11:13 +0000 (22:11 +0000)]
Bug 56273 - Add three operand forms to MacroAssember operations.

Reviewed by Sam Weinig.

Adding for X86(_64) for now, should be rolled out to other backends as necessary.
These may allow more efficient code generation in some cases, avoiding the need
for unnecessary register-register move instructions.

* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):
    - marked these methods const.
(JSC::AbstractMacroAssembler::Jump::isSet):
    - add a method to check whether a Jump object has been set to
      reference an instruction, or is in a null, unset state.
* assembler/MacroAssemblerCodeRef.h:
(JSC::FunctionPtr::FunctionPtr):
    - add non-explicit constructor, for FunctionPtr's to C/C++ functions.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::and32):
(JSC::MacroAssemblerX86Common::lshift32):
(JSC::MacroAssemblerX86Common::or32):
(JSC::MacroAssemblerX86Common::rshift32):
(JSC::MacroAssemblerX86Common::urshift32):
(JSC::MacroAssemblerX86Common::xor32):
(JSC::MacroAssemblerX86Common::moveDouble):
(JSC::MacroAssemblerX86Common::addDouble):
(JSC::MacroAssemblerX86Common::divDouble):
(JSC::MacroAssemblerX86Common::subDouble):
(JSC::MacroAssemblerX86Common::mulDouble):
(JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerX86Common::branchTest32):
(JSC::MacroAssemblerX86Common::branchTest8):
(JSC::MacroAssemblerX86Common::branchAdd32):
(JSC::MacroAssemblerX86Common::branchMul32):
(JSC::MacroAssemblerX86Common::branchSub32):
    - add three operand forms of these instructions.
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::addDouble):
(JSC::MacroAssemblerX86_64::convertInt32ToDouble):
(JSC::MacroAssemblerX86_64::loadPtr):
(JSC::MacroAssemblerX86_64::branchTestPtr):
* assembler/X86Assembler.h:
(JSC::X86Assembler::JmpSrc::isSet):
    - add a method to check whether a JmpSrc object has been set to
      reference an instruction, or is in a null, unset state.
(JSC::X86Assembler::movsd_rr):
    - added FP register-register move.
(JSC::X86Assembler::linkJump):
    - Add an assert to check jumps aren't linked more than once.
* jit/JITInlineMethods.h:
(JSC::JIT::emitLoadInt32ToDouble):
    - load integers to the FPU via regsiters on x86-64.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd some more crashing tests to an existing bug about the same issue
levin@chromium.org [Sun, 13 Mar 2011 22:05:54 +0000 (22:05 +0000)]
Add some more crashing tests to an existing bug about the same issue
for Chromium Linux Debug.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoARM build fix.
barraclough@apple.com [Sun, 13 Mar 2011 21:26:16 +0000 (21:26 +0000)]
ARM build fix.

* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::load32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBug 56270 - The JIT 'friend's many classes in JSC; start unwinding this.
barraclough@apple.com [Sun, 13 Mar 2011 21:16:29 +0000 (21:16 +0000)]
Bug 56270 - The JIT 'friend's many classes in JSC; start unwinding this.

Reviewed by Sam Weinig.

The JIT need to 'friend' other classes in order to be able to calculate offsets
of various properties, or the absolute addresses of members within specific objects,
in order to JIT generate code that will access members within the class when run.

Instead of using friends in these cases, switch to providing specific accessor
methods to provide this information.  In the case of offsets, these can be static
functions, and in the case of pointers to members within a specific object these can
be const methods returning pointers to const values, to prevent clients from
modifying values otherwise encapsulated within classes.

* bytecode/SamplingTool.h:
* interpreter/Register.h:
* interpreter/RegisterFile.h:
* runtime/JSArray.h:
* runtime/JSCell.h:
* runtime/JSTypeInfo.h:
* runtime/JSVariableObject.h:
* runtime/Structure.h:
* wtf/RefCounted.h:
    - Change these classes to no longer friend the JIT, add accessors for member offsets.
* jit/JIT.cpp:
* jit/JITCall32_64.cpp:
* jit/JITInlineMethods.h:
* jit/JITOpcodes.cpp:
* jit/JITOpcodes32_64.cpp:
* jit/JITPropertyAccess.cpp:
* jit/JITPropertyAccess32_64.cpp:
    - Change the JIT to use class accessors, rather than taking object ofsets directly.
* assembler/AbstractMacroAssembler.h:
* assembler/MacroAssemblerX86_64.h:
* assembler/X86Assembler.h:
    - Since the accessors for objects members return const pointers to retain encapsulation,
      methods generating code with absolute addresses must be able to handle const pointers
      (the JIT doesn't write to these values, do dies treat the pointer to value as const
      from within the C++ code of the JIT, if not at runtime!).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebPageProxy cleanup
mitz@apple.com [Sun, 13 Mar 2011 20:30:21 +0000 (20:30 +0000)]
WebPageProxy cleanup
https://bugs.webkit.org/show_bug.cgi?id=56267

Reviewed by Darin Adler.

* UIProcess/WebPageProxy.cpp: Moved all Mac-only function implementations from
here to WebPageProxyMac.mm.
* UIProcess/WebPageProxy.h: Cleaned up #includes.
* UIProcess/mac/WebPageProxyMac.mm: Moved all Mac-only function implementations
here.
(WebKit::WebPageProxy::updateWindowIsVisible):
(WebKit::WebPageProxy::windowAndViewFramesChanged):
(WebKit::WebPageProxy::getMarkedRange):
(WebKit::WebPageProxy::characterIndexForPoint):
(WebKit::WebPageProxy::firstRectForCharacterRange):
(WebKit::WebPageProxy::writeSelectionToPasteboard):
(WebKit::WebPageProxy::setDragImage):
(WebKit::WebPageProxy::performDictionaryLookupAtLocation):
(WebKit::WebPageProxy::interpretKeyEvent):
(WebKit::WebPageProxy::sendComplexTextInputToPlugin):
(WebKit::WebPageProxy::uppercaseWord):
(WebKit::WebPageProxy::lowercaseWord):
(WebKit::WebPageProxy::capitalizeWord):
(WebKit::WebPageProxy::setSmartInsertDeleteEnabled):
(WebKit::WebPageProxy::didPerformDictionaryLookup):
(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
(WebKit::WebPageProxy::registerUIProcessAccessibilityTokens):
(WebKit::WebPageProxy::setComplexTextInputEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/8949683> WebKit2: Drag image is offset when the page is scrolled...
mitz@apple.com [Sun, 13 Mar 2011 20:28:08 +0000 (20:28 +0000)]
<rdar://problem/8949683> WebKit2: Drag image is offset when the page is scrolled down
https://bugs.webkit.org/show_bug.cgi?id=56265

Reviewed by Darin Adler.

* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::startDrag): Send the location in view coordinates rather than
document coordinates.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix a crash when dragging.
mitz@apple.com [Sun, 13 Mar 2011 20:24:06 +0000 (20:24 +0000)]
Fix a crash when dragging.

Reviewed by Mark Rowe.

* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::convertImageToBitmap): Retain the saved context.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-13 Jeremy Moskovich <jeremy@chromium.org>
jeremy@chromium.org [Sun, 13 Mar 2011 19:46:06 +0000 (19:46 +0000)]
2011-03-13  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Dimitri Glazkov.

        Update comment in CSSValueKeywords.in
        https://bugs.webkit.org/show_bug.cgi?id=56266

        The enums the comment refers to were moved from RenderStyle.h to RenderStyleConstants.h
        in r36579 but it appears that the comment in CSSValueKeywords.in wasn't updated.

        No tests - just updating a comment.

        * css/CSSValueKeywords.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-13 Anton D'Auria <adauria@apple.com>
commit-queue@webkit.org [Sun, 13 Mar 2011 19:07:55 +0000 (19:07 +0000)]
2011-03-13  Anton D'Auria  <adauria@apple.com>

        Reviewed by Alice Liu.

        StorageTracker constructor shouldn't have initialization code and isMainThread() assertion
        https://bugs.webkit.org/show_bug.cgi?id=56259

        Move all StorageTracker initialization to
        StorageTracker::initializeTracker. This also removes the
        requirement that the StorageTracker constructor isn't run
        on the main thread.

        * storage/StorageTracker.cpp:
        (WebCore::StorageTracker::initializeTracker):
        (WebCore::StorageTracker::tracker):
        (WebCore::StorageTracker::StorageTracker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-13 Rob Buis <rwlbuis@gmail.com>
rwlbuis@webkit.org [Sun, 13 Mar 2011 18:47:27 +0000 (18:47 +0000)]
2011-03-13  Rob Buis  <rwlbuis@gmail.com>

        Reviewed by Dave Hyatt.

        REGRESSION (r61383): Navigation menu laid out incorrectly on aboardtheworld.com
        https://bugs.webkit.org/show_bug.cgi?id=53470

        Prefer !important over normal properties when dealing with duplicate properties in style rules.

        Test: fast/css/duplicate-property-in-rule-important.html

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd expectation (and bug) for test that has failed with an image
levin@chromium.org [Sun, 13 Mar 2011 18:42:20 +0000 (18:42 +0000)]
Add expectation (and bug) for test that has failed with an image
mismatch ever since it was added in r80867.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate test expections due to the OSX specific ex size change done in r80755.
levin@chromium.org [Sun, 13 Mar 2011 18:09:33 +0000 (18:09 +0000)]
Update test expections due to the OSX specific ex size change done in r80755.

* platform/chromium-mac/fast/lists/008-expected.checksum: Added.
* platform/chromium-mac/fast/lists/008-expected.png: Added.
* platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.checksum: Added.
* platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.png: Added.
* platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.checksum: Added.
* platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.png: Added.
* platform/chromium-mac/fast/replaced/width100percent-radio-expected.checksum: Added.
* platform/chromium-mac/fast/replaced/width100percent-radio-expected.png: Added.
* platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum: Added.
* platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix test expectations due to bad update:
levin@chromium.org [Sun, 13 Mar 2011 17:04:49 +0000 (17:04 +0000)]
Fix test expectations due to bad update:
  r80820 which limited to win/mac when it still regularly fails on Linux
  and it made the test fail with the expectation IMAGE instead of IMAGE+TEXT
  as well as occaisionally pass.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded the following expectations:
levin@chromium.org [Sun, 13 Mar 2011 10:07:36 +0000 (10:07 +0000)]
Added the following expectations:
  fast/backgrounds/background-position-parsing.html new test in r80868
  fast/css-generated-content/table-row-before-after.html new test in r80871
  fast/table/dynamic-descendant-percentage-height.html new test in r80878

Updated test_expectation to cover a failure due to a missing layout test feature
and added an appropriate bug.

* platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.checksum: Added.
* platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.png: Added.
* platform/chromium-linux/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
* platform/chromium-linux/fast/css-generated-content/table-row-before-after-expected.png: Added.
* platform/chromium-linux/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
* platform/chromium-linux/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
* platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.checksum: Added.
* platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.png: Added.
* platform/chromium-mac/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
* platform/chromium-mac/fast/css-generated-content/table-row-before-after-expected.png: Added.
* platform/chromium-mac/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
* platform/chromium-mac/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
* platform/chromium-win/fast/backgrounds/background-position-parsing-expected.checksum: Added.
* platform/chromium-win/fast/backgrounds/background-position-parsing-expected.png: Added.
* platform/chromium-win/fast/backgrounds/background-position-parsing-expected.txt: Added.
* platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
* platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.png: Added.
* platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.txt: Added.
* platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
* platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
* platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate test results due to r80755. All of these tests started failing
levin@chromium.org [Sun, 13 Mar 2011 09:30:02 +0000 (09:30 +0000)]
Update test results due to r80755. All of these tests started failing
on that check in and were given new baselines in that check in.

* platform/chromium-mac/css1/text_properties/text_indent-expected.checksum: Added.
* platform/chromium-mac/css1/text_properties/text_indent-expected.png: Added.
* platform/chromium-mac/css1/units/length_units-expected.checksum: Added.
* platform/chromium-mac/css1/units/length_units-expected.png: Added.
* platform/chromium-mac/css2.1/t040302-c61-ex-len-00-b-a-expected.checksum: Added.
* platform/chromium-mac/css2.1/t040302-c61-ex-len-00-b-a-expected.png: Added.
* platform/chromium-mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.checksum: Added.
* platform/chromium-mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.png: Added.
* platform/chromium-mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Added.
* platform/chromium-mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
* platform/chromium-mac/css2.1/t100801-c544-valgn-01-d-ag-expected.checksum: Added.
* platform/chromium-mac/css2.1/t100801-c544-valgn-01-d-ag-expected.png: Added.
* platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
* platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Added.
* platform/chromium-mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.checksum: Added.
* platform/chromium-mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png: Added.
* platform/chromium-mac/css2.1/t1507-c526-font-sz-02-b-a-expected.checksum: Added.
* platform/chromium-mac/css2.1/t1507-c526-font-sz-02-b-a-expected.png: Added.
* platform/chromium-mac/css2.1/t1601-c547-indent-00-b-a-expected.checksum: Added.
* platform/chromium-mac/css2.1/t1601-c547-indent-00-b-a-expected.png: Added.
* platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.checksum: Added.
* platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Added.
* platform/chromium-mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.checksum: Added.
* platform/chromium-mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.png: Added.
* platform/chromium-mac/editing/selection/caret-ltr-2-expected.checksum:
* platform/chromium-mac/editing/selection/caret-ltr-2-expected.png:
* platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.checksum:
* platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.png:
* platform/chromium-mac/editing/selection/caret-ltr-expected.checksum:
* platform/chromium-mac/editing/selection/caret-ltr-expected.png:
* platform/chromium-mac/editing/selection/caret-ltr-right-expected.checksum:
* platform/chromium-mac/editing/selection/caret-ltr-right-expected.png:
* platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum: Added.
* platform/chromium-mac/editing/selection/caret-rtl-2-expected.png: Added.
* platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.checksum: Added.
* platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png: Added.
* platform/chromium-mac/editing/selection/caret-rtl-expected.checksum: Added.
* platform/chromium-mac/editing/selection/caret-rtl-expected.png: Added.
* platform/chromium-mac/editing/selection/caret-rtl-right-expected.checksum: Added.
* platform/chromium-mac/editing/selection/caret-rtl-right-expected.png: Added.
* platform/chromium-mac/fast/block/margin-collapse/103-expected.checksum:
* platform/chromium-mac/fast/block/margin-collapse/103-expected.png:
* platform/chromium-mac/fast/css/ex-after-font-variant-expected.checksum: Added.
* platform/chromium-mac/fast/css/ex-after-font-variant-expected.png: Added.
* platform/chromium-mac/fast/css/non-standard-checkbox-size-expected.checksum: Added.
* platform/chromium-mac/fast/css/non-standard-checkbox-size-expected.png: Added.
* platform/chromium-mac/fast/forms/minWidthPercent-expected.checksum: Added.
* platform/chromium-mac/fast/forms/minWidthPercent-expected.png: Added.
* platform/chromium-mac/fast/overflow/overflow-rtl-expected.checksum: Added.
* platform/chromium-mac/fast/overflow/overflow-rtl-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-12 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Sun, 13 Mar 2011 07:34:38 +0000 (07:34 +0000)]
2011-03-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80895.
        http://trac.webkit.org/changeset/80895
        https://bugs.webkit.org/show_bug.cgi?id=56261

        Causing crashes in several tests including
        t1202-counters-16-c.html (see
        http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80956%20(15528)/results.html)
        (Requested by dave_levin on #webkit).

        * rendering/CounterNode.cpp:
        (WebCore::CounterNode::CounterNode):
        (WebCore::CounterNode::create):
        (WebCore::CounterNode::resetRenderer):
        (WebCore::CounterNode::resetRenderers):
        (WebCore::CounterNode::recount):
        (WebCore::CounterNode::insertAfter):
        (WebCore::CounterNode::removeChild):
        (WebCore::showTreeAndMark):
        * rendering/CounterNode.h:
        (WebCore::CounterNode::renderer):
        * rendering/RenderCounter.cpp:
        (WebCore::findPlaceForCounter):
        (WebCore::RenderCounter::~RenderCounter):
        (WebCore::RenderCounter::originalText):
        (WebCore::RenderCounter::invalidate):
        (WebCore::destroyCounterNodeWithoutMapRemoval):
        (WebCore::RenderCounter::destroyCounterNodes):
        (WebCore::RenderCounter::destroyCounterNode):
        (WebCore::updateCounters):
        (showCounterRendererTree):
        * rendering/RenderCounter.h:
        * rendering/RenderObjectChildList.cpp:
        (WebCore::invalidateCountersInContainer):
        (WebCore::RenderObjectChildList::invalidateCounters):
        * rendering/RenderObjectChildList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd results for newly added test in r80883.
levin@chromium.org [Sun, 13 Mar 2011 04:19:09 +0000 (04:19 +0000)]
Add results for newly added test in r80883.
The differences appear to be very small in keep with the typical
font drawing differences.

* platform/chromium-linux/fast/multicol/scrolling-overflow-expected.checksum: Added.
* platform/chromium-linux/fast/multicol/scrolling-overflow-expected.png: Added.
* platform/chromium-mac/fast/multicol/scrolling-overflow-expected.checksum: Added.
* platform/chromium-mac/fast/multicol/scrolling-overflow-expected.png: Added.
* platform/chromium-win/fast/multicol/scrolling-overflow-expected.checksum: Added.
* platform/chromium-win/fast/multicol/scrolling-overflow-expected.png: Added.
* platform/chromium-win/fast/multicol/scrolling-overflow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
darin@apple.com [Sun, 13 Mar 2011 04:05:39 +0000 (04:05 +0000)]
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::startDrag): Fixed typo in a comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agor80743 updated the main baseline due to a jsc change.
levin@chromium.org [Sun, 13 Mar 2011 04:03:33 +0000 (04:03 +0000)]
r80743 updated the main baseline due to a jsc change.
chromium isn't affected by the change.

* platform/chromium/fast/js/regexp-caching-expected.txt: Added.
chromium already had a specific baseline for this but it was in chromium-win,
so I moved this result to the more general chromium direction.
* platform/chromium-win/fast/js/regexp-caching-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove bad test_expectation updates.
levin@chromium.org [Sun, 13 Mar 2011 03:46:57 +0000 (03:46 +0000)]
Remove bad test_expectation updates.

I fixed both of these already:
  http://trac.webkit.org/changeset/80911
  http://trac.webkit.org/changeset/80904
so it is unclear why they were added.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-12 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 13 Mar 2011 03:46:50 +0000 (03:46 +0000)]
2011-03-12  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        REGRESSION (r76474): IntegerArray hash hashes only 1/4 of the array
        https://bugs.webkit.org/show_bug.cgi?id=56258

        No tests because the wrong hashing is mostly harmless. The only symptom
        we have seen is an occasional assertion in debug builds about the size
        not being a multiple of two. But a worse hash is worse for performance too.

        * platform/cf/BinaryPropertyList.cpp:
        (WebCore::IntegerArrayHash::hash): Pass in the size in bytes rather
        than the number of array entries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNot reviewed.
cwzwarich@webkit.org [Sun, 13 Mar 2011 03:36:23 +0000 (03:36 +0000)]
Not reviewed.

Fix the build with newer GCCs and remove some extra whitespae.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::uint8_t):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80951 268f45cc-cd09-0410-ab3c-d52691b4dbfc