12 years ago2008-04-24 Adele Peterson <adele@apple.com>
adele@apple.com [Thu, 24 Apr 2008 22:56:51 +0000 (22:56 +0000)]
2008-04-24  Adele Peterson  <adele@apple.com>

        Reviewed by Darin.

        Consolidate two versions of pathGetFileName.

        * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): Call FileSystem.h version of pathGetFileName and removed the static helper function.
        * platform/posix/FileSystemPOSIX.cpp: (WebCore::pathGetFileName): Moved general case from HTMLFormElement version here.
          If other platforms relied on that default they should implement this function for their platform specific version of FileSystem.cpp
        * platform/win/FileSystemWin.cpp: (WebCore::pathGetFileName): Moved win implementation from HTMLFormElement here.
        * platform/wx/FileSystemWx.cpp: (WebCore::pathGetFileName): Moved wx implementation from HTMLFormElement here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-24 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 24 Apr 2008 21:49:19 +0000 (21:49 +0000)]
2008-04-24  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        Fix layout test regressions from my earlier preferences/settings tweak.

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:]): Even if we're not posting
          the notification to update the settings, each WebView still needs to register for the
          notification - restore that behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-24 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 24 Apr 2008 21:45:31 +0000 (21:45 +0000)]
2008-04-24  Anders Carlsson  <andersca@apple.com>

        Windows build fix.

        * html/HTMLFormElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd svg mask example.
hyatt@apple.com [Thu, 24 Apr 2008 19:43:09 +0000 (19:43 +0000)]
Add svg mask example.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd svg file of a circle.
hyatt@apple.com [Thu, 24 Apr 2008 19:42:19 +0000 (19:42 +0000)]
Add svg file of a circle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd more files.
hyatt@apple.com [Thu, 24 Apr 2008 19:26:17 +0000 (19:26 +0000)]
Add more files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd kate gradient pic.
hyatt@apple.com [Thu, 24 Apr 2008 19:21:36 +0000 (19:21 +0000)]
Add kate gradient pic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-24 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 24 Apr 2008 19:16:07 +0000 (19:16 +0000)]
2008-04-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Don't call fprintf from the signal handler.

        * DumpRenderTree/mac/DumpRenderTree.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdjust files.
hyatt@apple.com [Thu, 24 Apr 2008 19:16:05 +0000 (19:16 +0000)]
Adjust files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-24 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 24 Apr 2008 19:15:40 +0000 (19:15 +0000)]
2008-04-24  Anders Carlsson  <andersca@apple.com>

        Don't crash when the string is empty.

        * html/HTMLMediaElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd more files.
hyatt@apple.com [Thu, 24 Apr 2008 19:12:57 +0000 (19:12 +0000)]
Add more files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Thu, 24 Apr 2008 19:09:48 +0000 (19:09 +0000)]

        Reviewed by Darin Adler.

        - preparation for https://bugs.webkit.org/show_bug.cgi?id=3729
          <rdar://problem/4036353> REGRESSION: arrow keys move insertion bar backwards in RTL text

        The three main changes in this patch are:

        1) Making all inline boxes know their bidi level, instead of just text
           boxes knowing whether their bidi level is odd or even. This is
           required for the next change.

        2) Replacing RenderObject::inlineBox() with
           Position::getInlineBoxAndOffset() in recognition of the fact that the
           inline box containing the primary caret for a position in a given
           node may belong to a different node's renderer.

        3) Changing RenderObject::caretRect() to take an InlineBox parameter,
           and changing callers to call VisiblePosition::caretRect(), which
           locates the inline box, then calls caretRect() on the renderer for
           that box. This, combined with the previous change, ensures that the
           primary caret is rendered at the right place for positions that
           lie on a directionality boundary.

        Test: platform/mac/editing/input/caret-primary-bidi.html

        * WebCore.base.exp: Added the VisiblePosition(Node*, int, EAffinity)
        constructor and VisiblePosition::caretRect(), and sorted.

        * dom/Position.cpp:
        (WebCore::nextRenderedEditable): Adjusted for the removal of
        (WebCore::previousRenderedEditable): Ditto.
        (WebCore::Position::rendersInDifferentPosition): Ditto.
        (WebCore::Position::getInlineBoxAndOffset): Added. Gets the inline box
        and the offset within that box at which the primary caret for this
        position should render.

        * dom/Position.h:

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::mergeParagraphs): Changed to call
        VisiblePosition::caretRect() instead of calling the RenderObject method.

        * editing/SelectionController.cpp:
        (WebCore::caretY): Ditto.
        (WebCore::SelectionController::xPosForVerticalArrowNavigation): Ditto.
        (WebCore::SelectionController::layout): Ditto.

        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::caretRect): Changed to call
        getInlineBoxAndOffset() to get the correct inline box and call the
        renderer for that box.

        * editing/VisiblePosition.h:
        (WebCore::VisiblePosition::getInlineBoxAndOffset): Added convenience
        methods for getting the inline box and caret offset for a visible
        position, accounting for its affinity.

        * editing/visible_units.cpp:
        (WebCore::rootBoxForLine): Changed to use getInlineBoxAndOffset()
        instead of RenderObject::inlineBox().
        (WebCore::previousLinePosition): Ditto.
        (WebCore::nextLinePosition): Ditto.

        * page/AccessibilityObject.cpp:
        (WebCore::updateAXLineStartForVisiblePosition): Ditto.

        * page/Frame.cpp:
        (WebCore::Frame::firstRectForRange): Ditto.

        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::caretMinOffset): Changed to forward to the
        (WebCore::InlineBox::caretMaxOffset): Ditto.
        * rendering/InlineBox.h: Replaced the m_reversed bit, intended for use
        in InlineTextBox only, with six bits of the bidi level of the box,
        intended for use in all leaf inline boxes.
        (WebCore::InlineBox::InlineBox): Added missing initializer for
        m_dirOverride and initialized the bidi level.
        (WebCore::InlineBox::bidiLevel): Added this accessor.
        (WebCore::InlineBox::setBidiLevel): Ditto.
        (WebCore::InlineBox::direction): Ditto.
        (WebCore::InlineBox::caretLeftmostOffset): Added this convenience
        (WebCore::InlineBox::caretRightmostOffset): Ditto.

        * rendering/InlineTextBox.cpp: Replaced all references to m_reversed
        with checking of direction().

        * rendering/RenderBR.cpp: Removed inlineBox().
        * rendering/RenderBR.h: Ditto.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::caretRect): Changed to take an inline box and
        account for the direction of the box (or the renderer) in positioning
        the caret: in right-to-left boxes, the "before" position is to the right
        while "after" is to the left.
        * rendering/RenderBox.h:

        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::caretRect): Updated the signature.
        * rendering/RenderFlow.h:

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::caretRect): Updated the signature.
        (WebCore::RenderObject::caretMaxOffset): Changed to return the child
        node count (or 1 if there are no children) for replaced elements, such
        as <select>s.
        * rendering/RenderObject.h:

        * rendering/RenderReplaced.cpp: Removed caretMinOffset() and
        caretMaxOffset() because the base class implementation does the right
        thing for replaced objects now.
        * rendering/RenderReplaced.h:

        * rendering/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::caretRect): Updated the signature.
        (WebCore::RenderSVGInlineText::positionForCoordinates): Updated for
        the change from m_reversed to direction().
        * rendering/RenderSVGInlineText.h:

        * rendering/RenderText.cpp:
        (WebCore::RenderText::caretRect): Changed to take an inline box and
        removed the code that used to find the inline for the given position.
        Changed use of m_reversed to use direction().
        (WebCore::RenderText::position): Changed use of m_reversed to use
        * rendering/RenderText.h:

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::textWithHardLineBreaks): Adjusted for the
        removal of RenderObject::inlineBox().

        * rendering/RenderTreeAsText.cpp:
        (WebCore::writeTextRun): Changed to use direction() instead of

        * rendering/SVGInlineTextBox.cpp: Ditto.

        * rendering/SVGRenderTreeAsText.cpp: Ditto.

        * rendering/SVGRootInlineBox.cpp: Ditto.

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::constructLine): Made this function set the
        bidi level on all leaf boxes.

        * svg/SVGTextContentElement.cpp: Changed to use direction() instead of


        Reviewed by Darin Adler.

        - preparation for https://bugs.webkit.org/show_bug.cgi?id=3729
          <rdar://problem/4036353> REGRESSION: arrow keys move insertion bar backwards in RTL text

        * WebView/WebFrame.mm:
        (-[WebFrame _caretRectAtNode:offset:affinity:]): Changed to use
        VisiblePosition::caretRect() instead of the RenderObject method which
        was removed.


        Reviewed by Darin Adler.

        - test the visual position of the primary caret in bidirectional text

        * platform/mac/editing/input/caret-primary-bidi-expected.txt: Added.
        * platform/mac/editing/input/caret-primary-bidi.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCheck in kate image for blog post.
hyatt@apple.com [Thu, 24 Apr 2008 19:09:07 +0000 (19:09 +0000)]
Check in kate image for blog post.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd blog files for mask post.
hyatt@apple.com [Thu, 24 Apr 2008 19:00:51 +0000 (19:00 +0000)]
Add blog files for mask post.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago../mac:
beidson@apple.com [Thu, 24 Apr 2008 18:57:58 +0000 (18:57 +0000)]

2008-04-24  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        Rework the Settings population again.

        * WebView/WebView.mm:
        (-[WebView _updateSettingsFromPreferences:]): This method is called both from _preferencesChangedNotification
          and directly from WebView's common init function.
        (-[WebView _preferencesChangedNotification:]):
        (-[WebView _commonInitializationWithFrameName:groupName:]): Call _updateSettingsFromPreferences immediately
          after creating the new Page


2008-04-24  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        Revert my previous change to WebKit/Win until I can make it act more like the new Mac code

        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-24 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 24 Apr 2008 18:53:34 +0000 (18:53 +0000)]
2008-04-24  Sam Weinig  <sam@webkit.org>

        Fix the world.

        * bindings/js/kjs_proxy.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd blog images.
hyatt@apple.com [Thu, 24 Apr 2008 18:51:14 +0000 (18:51 +0000)]
Add blog images.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-24 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 24 Apr 2008 18:45:53 +0000 (18:45 +0000)]
2008-04-24  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        Add a #define to easily enable collecting on every allocation to aid
        debugging GC bugs.

        * kjs/collector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
darin@apple.com [Thu, 24 Apr 2008 17:54:27 +0000 (17:54 +0000)]

2008-04-24  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        - fix crash in regression test where we'd ask a frame for a user agent string
          after the WebView was already closed

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::scheduleHTTPRedirection): Quietly do nothing if this is
        called on a frame that's already detached from its page.
        (WebCore::FrameLoader::scheduleLocationChange): Ditto.
        (WebCore::FrameLoader::scheduleRefresh): Ditto.
        (WebCore::FrameLoader::scheduleHistoryNavigation): Ditto.
        (WebCore::FrameLoader::redirectionTimerFired): Assert that this is never called
        for a frame that's already detached from its page.
        (WebCore::FrameLoader::scheduleRedirection): Ditto.
        (WebCore::FrameLoader::startRedirectionTimer): Ditto.


2008-04-24  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        - fix crash in regression test where we'd ask a frame for a user agent string
          after the WebView was already closed

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::userAgent): Assert that the WebView is not nil. Also
        added some code to prevent the crash in release builds if this problem happens

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd a new callFunction helper function to remove duplicate code
timothy@apple.com [Thu, 24 Apr 2008 17:50:12 +0000 (17:50 +0000)]
Add a new callFunction helper function to remove duplicate code
for calling JavaScript functions with arguments.

Reviewed by Darin Adler.

* page/InspectorController.cpp:
(WebCore::InspectorController::callSimpleFunction): Call callFunction.
(WebCore::InspectorController::callFunction): Extended version of the original
callSimpleFunction, with script function arguments and an exception argument.
(WebCore::InspectorController::focusNode): Use callFunction.
(WebCore::InspectorController::addScriptResource): Ditto.
(WebCore::InspectorController::removeScriptResource): Ditto.
(WebCore::InspectorController::addDatabaseScriptResource): Ditto.
(WebCore::InspectorController::removeDatabaseScriptResource): Ditto.
(WebCore::InspectorController::addScriptConsoleMessage): Ditto.
* page/InspectorController.h: Add callFunction.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca@apple.com [Thu, 24 Apr 2008 17:45:17 +0000 (17:45 +0000)]

2008-04-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Change some String arguments to be const references instead.

        * css/CSSRule.cpp:
        * css/CSSRule.h:
        * html/HTMLFormElement.cpp:
        * html/HTMLMediaElement.cpp:
        * page/EditorClient.h:
        * platform/SecurityOrigin.cpp:
        * platform/graphics/MediaPlayer.cpp:
        * platform/graphics/MediaPlayer.h:
        * rendering/MediaControlElements.cpp:
        * rendering/MediaControlElements.h:
        * svg/animation/SVGSMILElement.cpp:
        * svg/animation/SVGSMILElement.h:
        * svg/graphics/SVGImageEmptyClients.h:
        * xml/XSLTProcessor.cpp:


2008-04-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Change some String arguments to be const references instead.

        * WebCoreSupport/EditorClientGtk.cpp:
        * WebCoreSupport/EditorClientGtk.h:


2008-04-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Change some String arguments to be const references instead.

        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm:


2008-04-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Change some String arguments to be const references instead.

        * WebCoreSupport/EditorClientQt.cpp:
        * WebCoreSupport/EditorClientQt.h:


2008-04-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Change some String arguments to be const references instead.

        * WebCoreSupport/WebEditorClient.cpp:
        * WebCoreSupport/WebEditorClient.h:


2008-04-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Change some String arguments to be const references instead.

        * WebKitSupport/EditorClientWx.cpp:
        * WebKitSupport/EditorClientWx.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justin.garcia@apple.com [Thu, 24 Apr 2008 17:41:11 +0000 (17:41 +0000)]

2008-04-24  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/5604313> FormatBlock to apply an h1 also inserts a style span around the first letter (16004)

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::advance): We emit an extra newline when leaving a
        block element that has atypical margin/padding. When we emit the extra newline,
        it needs to be positioned after that block's contents, not after the block.
        This is how we position the first newline, too, since the range for emitted newlines
        should start where the line break begins visually.


2008-04-24  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/5604313> FormatBlock leaves first letter incorrectly styled (16004)

        * editing/execCommand/5604313-expected.txt: Added.
        * editing/execCommand/5604313.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-24 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 24 Apr 2008 17:25:01 +0000 (17:25 +0000)]
2008-04-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Only avoid implicit entries when doing the initial caching.

        * loader/appcache/ApplicationCacheGroup.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
kmccullough@apple.com [Thu, 24 Apr 2008 17:20:01 +0000 (17:20 +0000)]

2008-04-24  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adam and Sam.

        -<rdar://problem/5770054> JavaScript profiler (10928)
        -Only profile the page group that starts profiling to avoid profiling
        tools that shouldn't be profiled unless explicitly requested to.

        * JavaScriptCore.exp: Export new signature.
        * kjs/JSGlobalObject.cpp: Add unique identifiers to the JSGlobalObject.
        * kjs/JSGlobalObject.h: Ditto.
        * profiler/Profiler.cpp: Check the identifier of the page group of the
        lexical global exec state and only profile if it matches the given page
        group identifier.
        * profiler/Profiler.h: Ditto.


2008-04-24  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adam and Sam.

        -<rdar://problem/5770054> JavaScript profiler (10928)
        -Only profile the page group that starts profiling to avoid profiling
        tools that shouldn't be profiled unless explicitly requested to.

        * bindings/js/kjs_proxy.cpp: When a new global object is created set its
        page group identifier.
        * page/Console.cpp: When calling console.profile set the identifier of
        the page group being profiled.
        * page/PageGroup.cpp: Implement unique identifiers.
        * page/PageGroup.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
sullivan@apple.com [Thu, 24 Apr 2008 16:55:37 +0000 (16:55 +0000)]

2008-04-24  John Sullivan  <sullivan@apple.com>

        Mac buid fix

        * page/mac/WebCoreViewFactory.h:
        add declarations of six new AX methods that were added to LocalizedStrings.h

        * platform/mac/LocalizedStringsMac.mm:
        implement by calling through to WebCoreViewFactory as we do with the other functions here


2008-04-24  John Sullivan  <sullivan@apple.com>

        Mac build fix

        * WebCoreSupport/WebViewFactory.mm:
        (-[WebViewFactory AXButtonActionVerb]):
        implement this method using the text in WebCoreLocalizedStrings.cpp
        (-[WebViewFactory AXRadioButtonActionVerb]):
        (-[WebViewFactory AXTextFieldActionVerb]):
        (-[WebViewFactory AXCheckedCheckBoxActionVerb]):
        (-[WebViewFactory AXUncheckedCheckBoxActionVerb]):
        (-[WebViewFactory AXLinkActionVerb]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago../mac:
beidson@apple.com [Thu, 24 Apr 2008 16:33:20 +0000 (16:33 +0000)]

2008-04-23  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        In some current work I noticed that when a new Page is created, it is possible that it requires info from its Settings
        object before the Settings object is initialized.  It seems quite prudent to post the preferences changed notification,
        thereby populating the Settings object, immediately after the Page is created.

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:]): Post the notification right after the Page is created


2008-04-23  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        In some current work I noticed that when a new Page is created, it is possible that it requires info from its Settings
        object before the Settings object is initialized.  It seems quite prudent to post the preferences changed notification,
        thereby populating the Settings object, immediately after the Page is created.

        * WebView.cpp:
        (WebView::initWithFrame): Post the notification right after the Page is created

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-24 John Sullivan <sullivan@apple.com>
sullivan@apple.com [Thu, 24 Apr 2008 15:23:51 +0000 (15:23 +0000)]
2008-04-24  John Sullivan  <sullivan@apple.com>

        Reviewed by Jess

        - fixed <rdar://problem/5886655> JavaScript input panel automatic resizing doesn't work right with HiDPI

        * Misc/WebNSControlExtras.m:
        (-[NSControl sizeToFitAndAdjustWindowHeight]):
        deploy userSpaceScaleFactor when using view distances on the window

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Thu, 24 Apr 2008 14:07:29 +0000 (14:07 +0000)]
Holger Hans Peter Freyther <zecke@selfish.org>

Cosmetic changes to make the code more readable.
    -Early exit if we don't have a webview
    -handle the empty tooltip and non-empty tooltip case separately

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix text rendering in -reverse mode on Qt/Mac.
hausmann@webkit.org [Thu, 24 Apr 2008 14:07:16 +0000 (14:07 +0000)]
Fix text rendering in -reverse mode on Qt/Mac.

For Font::width() don't use a plain QFontMetrics object but also the properly
setup QTextLayout that has the RTL/LTR force flags set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 14:06:57 +0000 (14:06 +0000)]
Tor Arne Vestbø <tavestbo@trolltech.com>

Don't do anti-aliasing for arcs, lines and rects, but continue to anti-alias
all drawing primitives in the HTML Canvas element.

This speeds up drawing of dashed outlines significantly.

Also preserve the anti-aliasing renderhint for transparency layers and
get rid of the mostly unused device pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPaul Olav Tvete <paul@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 13:45:27 +0000 (13:45 +0000)]
Paul Olav Tvete <paul@trolltech.com>

Fix various compiler warnings related to QString(const char *)
construction by using QLatin1String.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPaul Olav Tvete <paul@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 13:44:53 +0000 (13:44 +0000)]
Paul Olav Tvete <paul@trolltech.com>

Automatically wrap tooltip text and hide a shown tooltip when it is empty.

QWidget::setTooltip("") will still show the old tooltip for up to 10 seconds.
Workaround as discussed with Matthias.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMorten Johan Sørvig <msorvig@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 13:30:03 +0000 (13:30 +0000)]
Morten Johan Sørvig <msorvig@trolltech.com>

Work around QMacStyle bug in repainting the vertical scrollbar.

We draw the scrollbar using HITheme but somehow the translation and the
clipping we previously set using ClipCGContextToRegion is ignored. Drawing
without the translation fixes the clip.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Thu, 24 Apr 2008 11:20:39 +0000 (11:20 +0000)]
Holger Hans Peter Freyther <zecke@selfish.org>

Allow to disable caching completeley by calling setObjectCacheCapacities(0, 0, 0)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Thu, 24 Apr 2008 11:20:22 +0000 (11:20 +0000)]
Holger Hans Peter Freyther <zecke@selfish.org>

* Set an expiration date for local files as we do not know what will happen
  to these files (in contrast to a http server with max-age and other headers)
* Remember the time when we started the job and use that for the expiration date
* QNetworkManager does not handle expiration at all, we might want to set the
  expiration for all downloads but this will be a performance nightmare.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Gtk and Qt builds.
hausmann@webkit.org [Thu, 24 Apr 2008 11:16:54 +0000 (11:16 +0000)]
Fix the Gtk and Qt builds.

Added missing localization stubs for accessibility.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 10:35:27 +0000 (10:35 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

Improve keyboard scrolling

Match Down/Up keys scroll distance with Safari (i.e. faster) and add Home and End shortcuts to scroll to the top/botom.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoOlivier Goffart <ogoffart@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 10:20:51 +0000 (10:20 +0000)]
Olivier Goffart  <ogoffart@trolltech.com>

Fix various compiler warnings in the Qt port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAndre Poenitz <andre.poenitz@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 10:20:14 +0000 (10:20 +0000)]
Andre Poenitz <andre.poenitz@trolltech.com>

Removed spurious QHideEvent forward declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-24 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Thu, 24 Apr 2008 09:01:14 +0000 (09:01 +0000)]
2008-04-24  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Simon.

        Bug 15940: Implement threading API for Qt

        Original patch by Justin Haygood, tweaked by me.

        * JavaScriptCore.pri:
        * wtf/ThreadingQt.cpp: Added.
        (WTF::waitForThreadCompletion): return !res to return
        0 on success (to match the pthreads implementation).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 08:53:44 +0000 (08:53 +0000)]
Tor Arne Vestbø <tavestbo@trolltech.com>

Render text areas using Qt (ensures proper style).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 08:53:27 +0000 (08:53 +0000)]
Tor Arne Vestbø <tavestbo@trolltech.com>

Make mouse wheel events over scrollbars behave the same as in Qt, i.e. both
horizontal and vertical wheel events will scroll the view in the orientation
of the scrollbar underneath the cursor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-23 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 24 Apr 2008 08:25:26 +0000 (08:25 +0000)]
2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Brady.

        Implement accDoDefaultAction().

        * AccessibleBase.cpp:
        (AccessibleBase::accDoDefaultAction): Call the object's
        performDefaultAction() method. Return S_FALSE if the call returns false,
        indicating that the object has no default action associated with it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-23 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 24 Apr 2008 08:24:58 +0000 (08:24 +0000)]
2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Adam.

        Don't allow a hit test to return an AccessibilityObject that should be

        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::doAccessibilityHitTest): If this result
        object's accessibility is ignored, return the parent unignored object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-23 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 24 Apr 2008 08:24:26 +0000 (08:24 +0000)]
2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Adam.

        Fix a crash when performing a hit test on an AccessibilityObject with
        no layer (e.g., an AccessibilityObject for a RenderText object).

        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::doAccessibilityHitTest): Added a null
        check for layer. Removed a null check for m_renderer, which shouldn't

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-23 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 24 Apr 2008 08:23:51 +0000 (08:23 +0000)]
2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Adam.

        Implement accHitTest().

        * AccessibleBase.cpp:
        (AccessibleBase::accHitTest): Perform a hit test for a child object. If
        none is found, report whether the point was within our own bounding box.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-23 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 24 Apr 2008 08:23:12 +0000 (08:23 +0000)]
2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Adam and Darin.

        Implement accNavigate().

        * AccessibleBase.cpp:
        (AccessibleBase::accNavigate): This method navigates between elements,
        given a start point and a direction. The directions UP, DOWN, LEFT,
        RIGHT are not are not implemented, matching Mozilla and IE. The
        directions FIRSTCHILD and LASTCHILD are only allowed from self. NEXT and
        PREVIOUS are allowed from self or any of our children.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-23 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 24 Apr 2008 08:22:28 +0000 (08:22 +0000)]
2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Adam.

        Implement accLocation().

        * AccessibleBase.cpp:
        (AccessibleBase::accLocation): Report the screen coordinates for the
        object's bounding box.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-23 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 24 Apr 2008 08:21:40 +0000 (08:21 +0000)]
2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Adam.

        Implement contentsToScreen() and screenToContents() on Windows.

        * platform/ScrollView.h: Make these declarations conditional on
        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::contentsToScreen): Translate from coordinates
        relative to the ScrollView to coordinates relative to the screen. Do
        this by getting the offset of the ScrollView in screen coordinates and
        moving the rect by this amount.
        (WebCore::ScrollView::screenToContents): Translate from coordinates
        relative to the screen to coordinates relative to the ScrollView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-23 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 24 Apr 2008 08:20:44 +0000 (08:20 +0000)]
2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Adam, Darin, Oliver.

        Implement get_accDefaultAction().

        * AccessibleBase.cpp:
        (AccessibleBase::get_accDefaultAction): Report the result of calling the
        object's actionVerb method.
        * English.lproj/Localizable.strings: Updated with new strings.
        * WebCoreLocalizedStrings.cpp:
        (WebCore::AXButtonActionVerb): Return a localized string representing
        the object's default action.
        (WebCore::AXRadioButtonActionVerb): Same.
        (WebCore::AXTextFieldActionVerb): Same.
        (WebCore::AXCheckedCheckBoxActionVerb): Same
        (WebCore::AXUncheckedCheckBoxActionVerb): Same.
        (WebCore::AXLinkActionVerb): Same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 24 Apr 2008 08:19:43 +0000 (08:19 +0000)]
2008-04-22  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Adam.

        Implement get_accFocus().

        * AccessibleBase.cpp:
        (AccessibleBase::get_accRole): Remove redundant initialize; VariantInit
        does this.
        (AccessibleBase::get_accState): Same.
        (AccessibleBase::get_accSelection): Relocated next to accSelect().
        (AccessibleBase::get_accFocus): If the focused object is this object or
        a child of this object, report it. Otherwise, report VT_EMPTY.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Alp Toker.
christian@webkit.org [Thu, 24 Apr 2008 08:15:37 +0000 (08:15 +0000)]
Reviewed by Alp Toker.

        Emit a warning about an unknown setting only if it is
        not a valid property. Otherwise applications can't
        subclass WebKitWebSettings to add new properties.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 07:55:22 +0000 (07:55 +0000)]
Tor Arne Vestbø  <tavestbo@trolltech.com>

Cleaned up copyright headers in the Qt port (removed misplaced class
descriptions and fixed inconsistent whitespace and indentation).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 07:44:52 +0000 (07:44 +0000)]
Tor Arne Vestbø <tavestbo@trolltech.com>

Added basic URL guessing to QtLauncher (same as in the demo browser).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 07:44:39 +0000 (07:44 +0000)]
Tor Arne Vestbø <tavestbo@trolltech.com>

Disable vanlilla focus rings since Qt provides this as part of the style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoGeorge Staikos <george@staikos.net>
hausmann@webkit.org [Thu, 24 Apr 2008 07:38:30 +0000 (07:38 +0000)]
George Staikos <george@staikos.net>

This optimization in BitmapImage::drawPattern for the identity
transform is bogus and causes incorrect results on sites like youtube.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Thu, 24 Apr 2008 07:31:31 +0000 (07:31 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

Prevent double deletions of the default web interface.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber-stamped by Dave Hyatt.
mitz@apple.com [Thu, 24 Apr 2008 04:29:49 +0000 (04:29 +0000)]
    Rubber-stamped by Dave Hyatt.

        - update computed style results for border-image and mask-image

        * fast/css/computed-style-expected.txt:
        * fast/css/computed-style-without-renderer-expected.txt:
        * svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Alp Toker.
kevino@webkit.org [Thu, 24 Apr 2008 03:55:16 +0000 (03:55 +0000)]
Reviewed by Alp Toker.

Typo fix to restore text entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-23 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 24 Apr 2008 03:39:23 +0000 (03:39 +0000)]
2008-04-23  Brady Eidson  <beidson@apple.com>

        Reviewed by Jon Honeycutt

        Preparing for making LocalStorageAreas persistent.

        Since LocalStorageAreas will need to do a lot of additional work for each of the basic
        operations a Storage object supports, this patch makes the API entry points virtual so
        LocalStorageArea can override them.  The behavior for both Local and Session StorageAreas
        is unchanged with this patch, but LocalStorageArea will override them in the future.

        * storage/StorageArea.cpp: Rename the implementations to internalFoo

        * storage/StorageArea.h: Call internalFoo variants

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
hyatt@apple.com [Thu, 24 Apr 2008 03:12:04 +0000 (03:12 +0000)]

2008-04-23  David Hyatt  <hyatt@apple.com>

        Implement getComputedStyle for border-image.

        Reviewed by Dan Bernstein

        Added fast/css/getComputedStyle-border-image.html

        * css/CSSComputedStyleDeclaration.cpp:


2008-04-23  David Hyatt  <hyatt@apple.com>

        Implement getComputedStyle for -webkit-border-image.

        Reviewed by Dan Bernstein

        * fast/css/getComputedStyle-border-image-expected.txt: Added.
        * fast/css/getComputedStyle-border-image.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 23 Apr 2008 21:41:42 +0000 (21:41 +0000)]
2008-04-22  Darin Adler  <darin@apple.com>

        Reviewed by Anders.

        - simplify use of HashTraits to prepare for some upcoming hash table changes

        * page/AXObjectCache.h: Removed uneeded AXIDHashTraits, which are no different
        from the default hash traits for unsigned.
        * page/mac/AXObjectCacheMac.mm:
        (WebCore::AXObjectCache::removeAXID): Remove assertion that's already done
        by HashTable that the value is not the deleted value.

        * platform/graphics/StringTruncator.cpp: Removed unneeded include.
        * svg/SVGFontFaceElement.cpp: Removed unneeded include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 23 Apr 2008 21:41:10 +0000 (21:41 +0000)]
2008-04-22  Darin Adler  <darin@apple.com>

        Reviewed by Anders.

        - simplify use of HashTraits to prepare for some upcoming hash table changes

        * kjs/SymbolTable.h: Made SymbolTableIndexHashTraits derive from HashTraits<size_t>
        and specialize only the empty value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fixes. Changing BackgroundLayer -> FillLayer and adding Frame::disconnectPla...
kevino@webkit.org [Wed, 23 Apr 2008 21:19:01 +0000 (21:19 +0000)]
wx build fixes. Changing BackgroundLayer -> FillLayer and adding Frame::disconnectPlatformScriptObjects()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
hyatt@apple.com [Wed, 23 Apr 2008 20:31:13 +0000 (20:31 +0000)]

2008-04-23  David Hyatt  <hyatt@apple.com>

        Add support for mask-box-image (similar to border-image).  This property enables a single image
        to overlay the entire mask area (with nine-piece slicing rules similar to border image).

        Reviewed by Dan Bernstein

        Added inline-mask-overlay.html, block-mask-overlay.html

        * css/CSSComputedStyleDeclaration.cpp:
        * css/CSSParser.cpp:
        * css/CSSPropertyNames.in:
        * css/CSSStyleSelector.cpp:
        * rendering/InlineFlowBox.cpp:
        * rendering/RenderBox.cpp:
        * rendering/RenderFlow.cpp:
        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:
        * rendering/RenderStyle.cpp:
        * rendering/RenderStyle.h:
        * rendering/RenderTable.cpp:
        * rendering/RenderTableCell.cpp:


2008-04-23  David Hyatt  <hyatt@apple.com>

        Add support for a new mask-box-image property that is analogous to border-image.

        Reviewed by Dan Bernstein

        * fast/borders/block-mask-overlay-image.html: Added.
        * fast/borders/inline-mask-overlay-image.html: Added.
        * fast/borders/resources/mask.png: Added.
        * platform/mac/fast/borders/block-mask-overlay-image-expected.checksum: Added.
        * platform/mac/fast/borders/block-mask-overlay-image-expected.png: Added.
        * platform/mac/fast/borders/block-mask-overlay-image-expected.txt: Added.
        * platform/mac/fast/borders/inline-mask-overlay-image-expected.checksum: Added.
        * platform/mac/fast/borders/inline-mask-overlay-image-expected.png: Added.
        * platform/mac/fast/borders/inline-mask-overlay-image-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justin.garcia@apple.com [Wed, 23 Apr 2008 18:25:10 +0000 (18:25 +0000)]

2008-04-23  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/5825350> OWA: Caret disappears when navigating with arrows keys in contenteditable div

        * editing/htmlediting.cpp:
        (WebCore::firstEditablePositionAfterPositionInRoot): Return a null VisiblePosition if
        this function moves out of highestRoot.  Re-wrote so as to not duplicate code inside
        and outside of the while loop.
        (WebCore::lastEditablePositionBeforePositionInRoot): Ditto.


2008-04-23  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/5825350> OWA: Caret disappears when navigating with arrows keys in contenteditable div

        * editing/selection/5825350-1-expected.txt: Added.
        * editing/selection/5825350-1.html: Added.
        * editing/selection/5825350-2-expected.txt: Added.
        * editing/selection/5825350-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
pewtermoose@webkit.org [Wed, 23 Apr 2008 17:49:52 +0000 (17:49 +0000)]

2008-04-23  Daniel Zucker  <zucker@wake3.com>

        Reviewed by Adam Roben.

        Fix build errors needed to compile Curl in Cairo build.  Add stubs for
        didReceiveAuthenticationChallenge, receivedCredential,
        receivedRequestToContinueWithoutCredential, and receivedCancellation.

        * platform/network/ResourceHandle.h:
        * platform/network/curl/ResourceHandleCurl.cpp:


2008-04-23  Daniel Zucker  <zucker@wake3.com>

        Reviewed by Adam Roben.


        * WebError.h:  include RetainPtr.h to fix build errors in Cairo build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-23 Daniel Zucker <zucker@wake3.com>
pewtermoose@webkit.org [Wed, 23 Apr 2008 17:43:40 +0000 (17:43 +0000)]
2008-04-23  Daniel Zucker  <zucker@wake3.com>

        Reviewed by Adam Roben.

        Move the location of #if USE(CFNETWORK) to fix a cairo/curl build error.

        * WebError.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Make crashes be reported as crashes, not hangs
aroben@apple.com [Wed, 23 Apr 2008 17:35:56 +0000 (17:35 +0000)]
    Make crashes be reported as crashes, not hangs

        Reviewed by David Kilzer.

        * Scripts/run-webkit-tests:
        (top level): Use the new status field of the output from
        readFromDumpToolWithTimer to determine if the test crashed or hung.
        (sub readFromDumpToolWithTimer):
          - If we fail to read a line and $! is not EAGAIN, then we've crashed
            and should not try to read any more.
          - Changed the timedout field to a more general status field.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-23 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 23 Apr 2008 16:08:22 +0000 (16:08 +0000)]
2008-04-23  Darin Adler  <darin@apple.com>

        - updated a test affected by the addition of mask-composite

        * svg/css/getComputedStyle-basic-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Wed, 23 Apr 2008 14:50:22 +0000 (14:50 +0000)]

        Reviewed by Darin Adler.

        - fix a bug where moving forward in bidirectional text skips over the
          position after the end of the line

        Test: editing/selection/move-past-trailing-space.html

        * dom/Position.cpp:
        (WebCore::Position::upstream): Changed the logic for identifying when a
        position is after the last character of a text box of a text node that
        continues on the next line, to make it work correctly when boxes are not
        laid out in logical order.
        (WebCore::Position::downstream): Ditto.


        Reviewed by Darin Adler.

        - test that moving forward through bidirectional text does not skip the
          position after the last character on the line

        * editing/selection/move-past-trailing-space.html: Added.
        * platform/mac/editing/selection/move-past-trailing-space-expected.checksum: Added.
        * platform/mac/editing/selection/move-past-trailing-space-expected.png: Added.
        * platform/mac/editing/selection/move-past-trailing-space-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix compilation against Qt 4.3
hausmann@webkit.org [Wed, 23 Apr 2008 14:45:02 +0000 (14:45 +0000)]
Fix compilation against Qt 4.3

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Wed, 23 Apr 2008 14:36:37 +0000 (14:36 +0000)]
Holger Hans Peter Freyther <zecke@selfish.org>

* Make sure the "Inspect Element" item gets added to the ContextMenu, a call
  to ContextMenu::populate() is not adding it, the ContextMenuController does
  add it after the call to populate(). Do that as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBrad Hughes <bhughes@trolltech.com>
hausmann@webkit.org [Wed, 23 Apr 2008 14:36:24 +0000 (14:36 +0000)]
Brad Hughes <bhughes@trolltech.com>

Fix release build with the intel compiler

Intel compiler can't compile qtwebkit with -O2 or -O1, so we're left with -O0

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSimon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Wed, 23 Apr 2008 14:36:10 +0000 (14:36 +0000)]
Simon Hausmann <hausmann@webkit.org>

Fix crashes on window.close().

We should not delete the QWebPage object in the ChromeClient but leave it up to
the application when and whether to delete a browser window. For this we now
emit the windowCloseRequested() signal.

Done with Tor Arne.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix parsing of external scripts/stylesheets when using setHtml(const QString &html).
hausmann@webkit.org [Wed, 23 Apr 2008 14:21:50 +0000 (14:21 +0000)]
Fix parsing of external scripts/stylesheets when using setHtml(const QString &html).

We used to pass the html string to the frameloader in utf-16, which also meant that the default
encoding of external scripts/stylesheets became utf-16. That doesn't make sense, so assume utf-8
by default. This is now also documented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoHolger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Wed, 23 Apr 2008 13:58:56 +0000 (13:58 +0000)]
Holger Hans Peter Freyther  <zecke@selfish.org>

Removed the #define for USE_SYSTEM_MALLOC that we set in WebKit.pri

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Wed, 23 Apr 2008 08:31:02 +0000 (08:31 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

Fixes background color propagation when using a custom QWebPage

Set the palette in setPage(), not during the creation on-demand.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Wed, 23 Apr 2008 08:26:35 +0000 (08:26 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

Fix the user agent on the mac to be BSD4

Put Q_OS_DARWIN before Q_OS_BSD4 sense they are both defined on the mac

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdded missing copyright notice.
hausmann@webkit.org [Wed, 23 Apr 2008 08:07:38 +0000 (08:07 +0000)]
Added missing copyright notice.
Small fixes to the documentation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoZack Rusin <zack@tungstengraphics.com>
hausmann@webkit.org [Wed, 23 Apr 2008 07:49:08 +0000 (07:49 +0000)]
Zack Rusin <zack@tungstengraphics.com>

Added a contentsSize() property.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders Carlsson.
mitz@apple.com [Wed, 23 Apr 2008 04:22:56 +0000 (04:22 +0000)]
    Reviewed by Anders Carlsson.

        - remove unused calls to Position::upstream()

        * editing/InsertLineBreakCommand.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Wed, 23 Apr 2008 04:19:05 +0000 (04:19 +0000)]
2008-04-22  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Sam.

        Implement get_accKeyboardShortcut().

        * AccessibleBase.cpp:
        (AccessibleBase::get_accKeyboardShortcut): Report the key combination
        that will perform the object's access key action, represented as a

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Wed, 23 Apr 2008 04:18:33 +0000 (04:18 +0000)]
2008-04-22  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Sam.

        Add a method to query which modifier keys the platform uses for access
        key actions.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleAccessKey): Bitwise and the event's
        modifier keys with the platform's access key modifier mask to determine
        whether this event can perform an access key action.
        * page/EventHandler.h: Added s_accessKeyModifiers, a platform-defined
        mask of modifier keys used for access key actions, and a getter.
        * page/mac/EventHandlerMac.mm: Use PlatformKeyboardEvent::CtrlKey for
        access key actions.
        * page/qt/EventHandlerQt.cpp: Same.
        * page/gtk/EventHandlerGtk.cpp: Use AltKey.
        * page/win/EventHandlerWin.cpp: Same.
        * page/wx/EventHandlerWx.cpp: Same.
        * platform/PlatformKeyboardEvent.h: Added an enum, ModifierKey.
        (WebCore::PlatformKeyboardEvent::modifiers): Return which modifier keys
        were active, a combination of ModifierKey values.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 23 Apr 2008 03:52:21 +0000 (03:52 +0000)]
2008-04-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Maciej Stachowiak.

        Make the KJSProxy and FrameLoader member variables instead of pointers
        in FramePrivate in a bid to do a little clean up before the last of the
        split window patches.  Also, make the KJSProxy not lazily created, as the
        real benefit comes from lazily creating the JSDOMWindowWrapper, which we
        still do.

        * page/Frame.cpp:
        * page/FramePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Wed, 23 Apr 2008 03:42:31 +0000 (03:42 +0000)]

2008-04-22  Anatoli Papirovski  <apapirovski@mac.com>

        Reviewed by Dan Bernstein.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18584
        border-color, outline-color, column-color, -webkit-text-stroke-color,
        and -webkit-text-fill-color inheritance to correctly use parent's color
        if the parent's corresponding (border, outline, etc.)-color property
        wasn't set.

        Test: fast/borders/border-color-inherit.html

        * css/CSSStyleSelector.cpp:


2008-04-22  Anatoli Papirovski  <apapirovski@mac.com>

        Reviewed by Dan Bernstein.

        Add a test case for border-color inheritance.

        * fast/borders/border-color-inherit.html: Added.
        * platform/mac/fast/borders/border-color-inherit-expected.checksum: Added.
        * platform/mac/fast/borders/border-color-inherit-expected.png: Added.
        * platform/mac/fast/borders/border-color-inherit-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 Alp Toker <alp@nuanti.com>
alp@webkit.org [Wed, 23 Apr 2008 03:14:26 +0000 (03:14 +0000)]
2008-04-22  Alp Toker  <alp@nuanti.com>

        GTK+ debug build fix for changes in r32257.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 Alp Toker <alp@nuanti.com>
alp@webkit.org [Wed, 23 Apr 2008 02:15:51 +0000 (02:15 +0000)]
2008-04-22  Alp Toker  <alp@nuanti.com>

        Rubber-stamped by Dave Hyatt.

        Move GraphicsContext::clipToImageBuffer() notImplemented() stub to

        * platform/graphics/GraphicsContext.cpp:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
hyatt@apple.com [Wed, 23 Apr 2008 02:13:27 +0000 (02:13 +0000)]

2008-04-22  David Hyatt  <hyatt@apple.com>

        Add support for mask-composite to match background-composite.

        Reviewed by Sam Weinig

        Added fast/backgrounds/mask-composite.html

        * css/CSSComputedStyleDeclaration.cpp:
        * css/CSSParser.cpp:
        * css/CSSPropertyNames.in:
        * css/CSSStyleSelector.cpp:
        * rendering/InlineFlowBox.cpp:


2008-04-22  David Hyatt  <hyatt@apple.com>

        Add support for mask-composite.

        Reviewed by Sam Weinig

        * fast/backgrounds/mask-composite.html: Added.
        * fast/backgrounds/resources/mask-bottom-left.png: Added.
        * fast/backgrounds/resources/mask-bottom-right.png: Added.
        * fast/backgrounds/resources/mask-bottom.png: Added.
        * fast/backgrounds/resources/mask-center.png: Added.
        * fast/backgrounds/resources/mask-left.png: Added.
        * fast/backgrounds/resources/mask-right.png: Added.
        * fast/backgrounds/resources/mask-top-left.png: Added.
        * fast/backgrounds/resources/mask-top-right.png: Added.
        * fast/backgrounds/resources/mask-top.png: Added.
        * platform/mac/fast/backgrounds/mask-composite-expected.checksum: Added.
        * platform/mac/fast/backgrounds/mask-composite-expected.png: Added.
        * platform/mac/fast/backgrounds/mask-composite-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 23 Apr 2008 00:45:53 +0000 (00:45 +0000)]
2008-04-22  David Hyatt  <hyatt@apple.com>

        Fix for bug 18688, background-color stopped painting on inlines.  Fix a virtual function
        misnaming that led to the derived class not getting called properly.

        Reviewed by Mark Rowe

        * ChangeLog:
        * rendering/InlineFlowBox.cpp:
        * rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd new layout test results.
hyatt@apple.com [Wed, 23 Apr 2008 00:16:37 +0000 (00:16 +0000)]
Add new layout test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 23 Apr 2008 00:13:31 +0000 (00:13 +0000)]
2008-04-22  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        <rdar://problem/5733282> and https://bugs.webkit.org/show_bug.cgi?id=18680
        Always loads default shortcut icon URL when an external <script> is referenced before the icon URL is set.

        * dom/Document.cpp:
        (WebCore::Document::implicitClose): Call FrameLoader->startIconLoader() here, when the document is
          finished parsing.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::endIfNotLoadingMainResource):  Don't start the icon load here, when the
          document is finished parsing.  This was often too early, as document parsing may be blocked
          on an external script and therefore the correct iconURL is not set yet.
          The isLoadingFromCachedPage() check was when we started the icon load based on *loading* instead parsing,
          and is now irrelevant.
        * loader/FrameLoader.h:  Make startIconLoader() public

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 Antti Koivisto <antti@apple.com>
antti@apple.com [Tue, 22 Apr 2008 23:52:11 +0000 (23:52 +0000)]
2008-04-22  Antti Koivisto  <antti@apple.com>

        Update SVG animation test results.

        * platform/mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 Antti Koivisto <antti@apple.com>
antti@apple.com [Tue, 22 Apr 2008 23:51:49 +0000 (23:51 +0000)]
2008-04-22  Antti Koivisto  <antti@apple.com>

        Reviewed by Oliver.

        Support keyPoints attribute of <animateMotion>.

        Tested by SVG test suite test

        * svg/SVGAnimateMotionElement.cpp:
        * svg/SVGAnimationElement.cpp:
        * svg/SVGAnimationElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Tue, 22 Apr 2008 21:49:59 +0000 (21:49 +0000)]
2008-04-22  Holger Hans Peter Freyther  <zecke@selfish.org>

        Unreviewed build fix.

        Update WebKit.qrc to catch up with the addition and removal of images
        from page/inspector/Images in recent commits.

        * page/inspector/WebKit.qrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Bug 18683: update-webkit returns 0 even if it fails
ddkilzer@apple.com [Tue, 22 Apr 2008 21:44:04 +0000 (21:44 +0000)]
    Bug 18683: update-webkit returns 0 even if it fails


        Reviewed by Mitz Pettel.

        * Scripts/update-webkit:
        (runSvnUpdate): Die if close() fails.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
hyatt@apple.com [Tue, 22 Apr 2008 21:40:35 +0000 (21:40 +0000)]

2008-04-22  David Hyatt  <hyatt@apple.com>

        Fix for <rdar://5589634>.

        Implement CSS alpha masks.  The syntax is very similar to that used for backgrounds.  Multiple mask images
        can be specified, and each one can be tiled, positioned, etc.  The following new properties have been
        added (all of which are analogous to their background-* counterparts).

        mask, mask-image, mask-clip, mask-origin, mask-repeat, mask-attachment, mask-position

        The alpha values in the final composite image are used to determine how the mask applies (alpha of 1 = show,
        alpha of 0 = don't show).

        SVG images and CSS gradients can also be used as masks.

        Reviewed by Dan

        Added fast/backgrounds/repeat/mask-negative-offset-repeat.html, fast/backgrounds/svg-as-mask.html

        * css/CSSMutableStyleDeclaration.cpp:
        * css/CSSParser.cpp:
        * css/CSSStyleSelector.cpp:
        * rendering/InlineFlowBox.cpp:
        * rendering/InlineFlowBox.h:
        * rendering/RenderBlock.cpp:
        * rendering/RenderBox.cpp:
        * rendering/RenderBox.h:
        * rendering/RenderFieldset.cpp:
        * rendering/RenderFieldset.h:
        * rendering/RenderInline.cpp:
        * rendering/RenderLayer.cpp:
        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:
        * rendering/RenderReplaced.cpp:
        * rendering/RenderStyle.cpp:
        * rendering/RenderStyle.h:
        * rendering/RenderTable.cpp:
        * rendering/RenderTable.h:
        * rendering/RenderTableCell.cpp:
        * rendering/RenderTableCell.h:
        * rendering/RenderWidget.cpp:
        * svg/graphics/SVGImage.cpp:


2008-04-22  David Hyatt  <hyatt@apple.com>

        Add support for CSS alpha masks.  Test cases.

        Reviewed by Dan

        * fast/backgrounds/repeat/mask-negative-offset-repeat.html: Added.
        * fast/backgrounds/repeat/resources/white.gif: Added.
        * fast/backgrounds/svg-as-mask.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-22 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 22 Apr 2008 21:38:56 +0000 (21:38 +0000)]
2008-04-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        Make DOMAbstractView have a weak reference to the Frame instead of ref'ing
        the DOMWindow.

        To ensure that the WindowScriptObject (which is a DOMAbstractView) stays valid
        after a navigation once the split window is completed, the DOMAbstractView must
        wrap the Frame instead of a DOMWindow since the DOMWindow will change.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOMAbstractView.mm: Added.
        (-[DOMAbstractView dealloc]):
        (-[DOMAbstractView finalize]):
        (-[DOMAbstractView document]):
        (-[DOMAbstractView _disconnectFrame]):
        (-[DOMAbstractView WebCore::]):
        (-[DOMAbstractView _initWithFrame:WebCore::]):
        (+[DOMAbstractView _wrapAbstractView:WebCore::]):
        Add custom implementation to implement weak reference semantics.

        * bindings/objc/DOMAbstractViewFrame.h: Added.
        Declare the [DOMAbstractView _disconectFrame] selector.
        * bindings/objc/DOMInternal.h:
        Remove DOMRGBColor Internal category since it is now generated.

        * bindings/objc/DOMUtility.mm:
        Don't ever create a DOMAbstractView from a JSDOMWindow, only from JSDOMWindowWrapper.

        * bindings/scripts/CodeGeneratorObjC.pm:
        Generate internal header for IDLs that want custom implementations.

        * css/RGBColor.idl:
        Make this a PODType as it really is in the implementation.

        * page/AbstractView.idl:
        This now needs a custom objective-c binding implementation.

        * page/Frame.cpp:
        disconnect the weak frame reference in the WindowScriptObject.

        * page/Frame.h:
        * page/gtk/FrameGtk.cpp:
        (WebCore::Frame::disconnectPlatformScriptObjects): Dummy implementation.
        * page/mac/FrameMac.mm:
        (WebCore::Frame::windowScriptObject): ASSERT that the windowScriptObject is a DOMAbstractView.
        (WebCore::Frame::disconnectPlatformScriptObjects): Disconnect the frame pointer from the windowScriptObject.
        * page/qt/FrameQt.cpp:
        (WebCore::Frame::disconnectPlatformScriptObjects): Dummy implementation.
        * page/win/FrameWin.cpp:
        (WebCore::Frame::disconnectPlatformScriptObjects): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix typo in ChangeLog.
mitz@apple.com [Tue, 22 Apr 2008 20:45:56 +0000 (20:45 +0000)]
Fix typo in ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Tue, 22 Apr 2008 20:42:02 +0000 (20:42 +0000)]

        Reviewed by Sam Weinig.

        - preparation https://bugs.webkit.org/show_bug.cgi?id=3729
          <rdar://problem/4036353> REGRESSION: arrow keys move insertion bar backwards in RTL text

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::layoutInlineChildren): Make sure to give the
        trailing white space a bidi level consistent with its position.


        Reviewed by Sam Weinig.

        - updated results with the trailing space having the right directionality

        * platform/mac/fast/text/trailing-white-space-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32402 268f45cc-cd09-0410-ab3c-d52691b4dbfc