WebKit-https.git
11 years ago Fix build.
sfalken@apple.com [Fri, 23 Jan 2009 19:03:51 +0000 (19:03 +0000)]
    Fix build.

        * rendering/RenderThemeSafari.cpp:
        (WebCore::RenderThemeSafari::baselinePosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-23 Darin Fisher <darin@chromium.org>
darin@chromium.org [Fri, 23 Jan 2009 18:56:17 +0000 (18:56 +0000)]
2009-01-23  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23506
        Copy existing ImageDecoder.h in preparation for landing Skia changes on top.

        * platform/image-decoders/skia/ImageDecoder.h: Copied from platform/image-decoders/ImageDecoder.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-23 Darin Fisher <darin@chromium.org>
darin@chromium.org [Fri, 23 Jan 2009 18:53:20 +0000 (18:53 +0000)]
2009-01-23  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23506
        Copy existing image-decoders in preparation for landing Skia changes on top.

        * platform/image-decoders/skia: Added.
        * platform/image-decoders/skia/GIFImageDecoder.cpp: Copied from platform/image-decoders/gif/GIFImageDecoder.cpp.
        * platform/image-decoders/skia/GIFImageDecoder.h: Copied from platform/image-decoders/gif/GIFImageDecoder.h.
        * platform/image-decoders/skia/GIFImageReader.cpp: Copied from platform/image-decoders/gif/GIFImageReader.cpp.
        * platform/image-decoders/skia/GIFImageReader.h: Copied from platform/image-decoders/gif/GIFImageReader.h.
        * platform/image-decoders/skia/JPEGImageDecoder.cpp: Copied from platform/image-decoders/jpeg/JPEGImageDecoder.cpp.
        * platform/image-decoders/skia/JPEGImageDecoder.h: Copied from platform/image-decoders/jpeg/JPEGImageDecoder.h.
        * platform/image-decoders/skia/PNGImageDecoder.cpp: Copied from platform/image-decoders/png/PNGImageDecoder.cpp.
        * platform/image-decoders/skia/PNGImageDecoder.h: Copied from platform/image-decoders/png/PNGImageDecoder.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Oliver Hunt.
ap@webkit.org [Fri, 23 Jan 2009 16:57:16 +0000 (16:57 +0000)]
    Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=23478
        Add a test for application test resource loading failure

        * http/tests/appcache/404-resource-expected.txt: Added.
        * http/tests/appcache/404-resource.html: Added.
        * http/tests/appcache/resources/404-resource.manifest: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix in RenderThemeGtk for RenderBox usage.
zecke@webkit.org [Fri, 23 Jan 2009 16:18:13 +0000 (16:18 +0000)]
Build fix in RenderThemeGtk for RenderBox usage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-23 David Levin <levin@chromium.org>
ap@webkit.org [Fri, 23 Jan 2009 16:07:37 +0000 (16:07 +0000)]
2009-01-23  David Levin  <levin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Bug 22720: Make XMLHttpRequest work in Workers
        <https://bugs.webkit.org/show_bug.cgi?id=22720>

        Add copy/adopt for ResourceResponse(Base)/ResourceRequest(Base) to allow the
        data to be passed across threads.

        No observable change in behavior, so no test.

        * platform/network/FormData.cpp:
        (WebCore::FormData::deepCopy):
        * platform/network/FormData.h:
        * platform/network/HTTPHeaderMap.cpp:
        (WebCore::HTTPHeaderMap::copyData):
        (WebCore::HTTPHeaderMap::adopt):
        * platform/network/HTTPHeaderMap.h:
        * platform/network/ResourceRequestBase.cpp:
        (WebCore::ResourceRequestBase::adopt):
        (WebCore::ResourceRequestBase::copyData):
        * platform/network/ResourceRequestBase.h:
        * platform/network/ResourceResponseBase.cpp:
        (WebCore::ResourceResponseBase::adopt):
        (WebCore::ResourceResponseBase::copyData):
        * platform/network/ResourceResponseBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-23 Dmitry Titov <dimich@chromium.org>
ap@webkit.org [Fri, 23 Jan 2009 15:53:42 +0000 (15:53 +0000)]
2009-01-23  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=23374
        Add WorkerRunLoop to encapsulate message queue and timer heap.
        This is first half (timer heap is added as separate patch).

        * GNUmakefile.am: Added WorkerRunLoop.cpp to the build.
        * WebCore.vcproj/WebCore.vcproj: Same as above.
        * WebCore.xcodeproj/project.pbxproj: Same as above
        * dom/WorkerContext.cpp:
        (WebCore::WorkerContext::postTask):
        * dom/WorkerContext.h:
        * dom/WorkerMessagingProxy.cpp:
        (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
        (WebCore::WorkerMessagingProxy::workerThreadCreated):
        * dom/WorkerRunLoop.cpp: Added.
        (WebCore::WorkerRunLoop::run): Runs the loop until terminate() is called.
        (WebCore::WorkerRunLoop::terminate): Causes the loop to exit.
        (WebCore::WorkerRunLoop::postTask): Adds a task to the internal queue.
        * dom/WorkerRunLoop.h: Added.
        (WebCore::WorkerRunLoop::WorkerRunLoop):
        * dom/WorkerThread.cpp:
        (WebCore::WorkerThread::workerThread):
        (WebCore::WorkerThread::stop):
        * dom/WorkerThread.h:
        (WebCore::WorkerThread::runLoop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRedo previous patch http://trac.webkit.org/changeset/34260 which fixes a
treat@webkit.org [Fri, 23 Jan 2009 15:02:38 +0000 (15:02 +0000)]
Redo previous patch trac.webkit.org/changeset/34260 which fixes a
huge memory leak by ensuring that the timer is fired one last time on
application tear down thus triggering the GCController thereby freeing
JavaScript objects as well as triggering other timer based tear down methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Oliver Hunt.
ap@webkit.org [Fri, 23 Jan 2009 14:50:54 +0000 (14:50 +0000)]
    Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=23459
        Workers are not properly terminated if execution hasn't begun yet

        Doesn't affect observable behavior, so test case is not possible.

        * dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): Call forbidExecution() if
        it couldn't be called earlier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Fri, 23 Jan 2009 13:29:42 +0000 (13:29 +0000)]
2009-01-23  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon Hausmann.

        Make the test more robust by taking into account the platform-specific
        cursor flashing time.

        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Fri, 23 Jan 2009 12:39:32 +0000 (12:39 +0000)]
2009-01-23  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        [Qt] Fix the build after RenderBox refactoring in r40153.

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::baselinePosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Fri, 23 Jan 2009 12:39:10 +0000 (12:39 +0000)]
2009-01-23  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Alexey Proskuryakov.

        Fix the build after RenderBox refactoring in r40153.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::invalidateWindowlessPluginRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Fri, 23 Jan 2009 12:38:47 +0000 (12:38 +0000)]
2009-01-23  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon Hausmann.

        [Qt] Simplify the assertion.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::getWindowsContext):
        (WebCore::GraphicsContext::releaseWindowsContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoLand updated layout tests (progressions) after border/padding move.
hyatt@apple.com [Fri, 23 Jan 2009 07:19:48 +0000 (07:19 +0000)]
Land updated layout tests (progressions) after border/padding move.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-22 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 23 Jan 2009 07:14:49 +0000 (07:14 +0000)]
2009-01-22  David Hyatt  <hyatt@apple.com>

        Move the border and padding methods from RenderObject to RenderBox.

        Reviewed by Oliver Hunt

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * editing/DeleteButtonController.cpp:
        (WebCore::DeleteButtonController::createDeletionUI):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::hitTestResultAtPoint):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::placeBoxesVertically):
        * rendering/InlineFlowBox.h:
        (WebCore::InlineFlowBox::borderLeft):
        (WebCore::InlineFlowBox::borderRight):
        (WebCore::InlineFlowBox::paddingLeft):
        (WebCore::InlineFlowBox::paddingRight):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::clearFloats):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paddingTop):
        (WebCore::RenderBox::paddingBottom):
        (WebCore::RenderBox::paddingLeft):
        (WebCore::RenderBox::paddingRight):
        (WebCore::RenderBox::calcHeight):
        (WebCore::RenderBox::containingBlockWidthForPositioned):
        (WebCore::RenderBox::containingBlockHeightForPositioned):
        (WebCore::RenderBox::calcAbsoluteHorizontal):
        (WebCore::RenderBox::calcAbsoluteHorizontalValues):
        (WebCore::RenderBox::calcAbsoluteVertical):
        (WebCore::RenderBox::calcAbsoluteVerticalValues):
        (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
        (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
        * rendering/RenderBox.h:
        (WebCore::RenderBox::borderTop):
        (WebCore::RenderBox::borderBottom):
        (WebCore::RenderBox::borderLeft):
        (WebCore::RenderBox::borderRight):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
        * rendering/RenderObject.h:
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::textBlockWidth):
        (WebCore::RenderTextControl::calcHeight):
        (WebCore::RenderTextControl::calcPrefWidths):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::preferredContentWidth):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::operator<<):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::repaintViewRectangle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-22 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 23 Jan 2009 05:13:22 +0000 (05:13 +0000)]
2009-01-22  David Hyatt  <hyatt@apple.com>

        Devirtualize the marginTop/Right/Left/Bottom functions and move them to RenderBox (along with some of the
        other margin functions that have to come along for the ride).

        Reviewed by Oliver Hunt

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * editing/TextIterator.cpp:
        (WebCore::shouldEmitExtraNewlineForNode):
        * rendering/InlineBox.cpp:
        * rendering/InlineBox.h:
        (WebCore::InlineBox::renderBox):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::marginLeft):
        (WebCore::InlineFlowBox::marginRight):
        (WebCore::InlineFlowBox::placeBoxesHorizontally):
        (WebCore::InlineFlowBox::computeLogicalBoxHeights):
        (WebCore::InlineFlowBox::placeBoxesVertically):
        (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::isSelfCollapsingBlock):
        (WebCore::RenderBlock::adjustPositionedBlock):
        (WebCore::RenderBlock::handleCompactChild):
        (WebCore::RenderBlock::estimateVerticalPosition):
        (WebCore::getBorderPaddingMargin):
        (WebCore::RenderBlock::calcInlinePrefWidths):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcHeight):
        * rendering/RenderBox.h:
        (WebCore::RenderBox::hasHorizontalBordersPaddingOrMargin):
        (WebCore::RenderBox::hasHorizontalBordersOrPadding):
        (WebCore::RenderBox::marginTop):
        (WebCore::RenderBox::marginBottom):
        (WebCore::RenderBox::marginLeft):
        (WebCore::RenderBox::marginRight):
        (WebCore::RenderBox::isSelfCollapsingBlock):
        (WebCore::RenderBox::collapsedMarginTop):
        (WebCore::RenderBox::collapsedMarginBottom):
        (WebCore::RenderBox::isTopMarginQuirk):
        (WebCore::RenderBox::isBottomMarginQuirk):
        (WebCore::RenderBox::maxTopMargin):
        (WebCore::RenderBox::maxBottomMargin):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
        * rendering/RenderObject.h:
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::lineHeight):
        (WebCore::RenderSVGContainer::baselinePosition):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::calcHeight):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::baselinePosition):
        * rendering/bidi.cpp:
        (WebCore::getBorderPaddingMargin):
        (WebCore::inlineWidth):
        (WebCore::RenderBlock::computeHorizontalPositionsForLine):
        (WebCore::inlineFlowRequiresLineBox):
        (WebCore::requiresLineBox):
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDisable GCC_WARN_ABOUT_MISSING_PROTOTYPES temporarily.
mrowe@apple.com [Fri, 23 Jan 2009 04:57:00 +0000 (04:57 +0000)]
Disable GCC_WARN_ABOUT_MISSING_PROTOTYPES temporarily.

Rubber-stamped by Anders Carlsson.

Current versions of Xcode only respect it for C and Objective-C files,
and our code doesn't currently compile if it is applied to C++ and
Objective-C++ files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix build bustage on Gtk.
hyatt@apple.com [Fri, 23 Jan 2009 04:30:47 +0000 (04:30 +0000)]
Fix build bustage on Gtk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-22 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 23 Jan 2009 04:07:34 +0000 (04:07 +0000)]
2009-01-22  David Hyatt  <hyatt@apple.com>

        Move the m_widthChanged bit on RenderTableCell into RenderFlow's set of bits.  Let intrinsicPaddingTop and
        intrinsicPaddingBottom just be normal non-bitfield values.

        Reviewed by Oliver Hunt

        * rendering/RenderFlow.h:
        (WebCore::RenderFlow::RenderFlow):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::RenderTableCell):
        (WebCore::RenderTableCell::updateWidth):
        (WebCore::RenderTableCell::layout):
        * rendering/RenderTableCell.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate layout tests for table cell changes.
hyatt@apple.com [Fri, 23 Jan 2009 04:06:06 +0000 (04:06 +0000)]
Update layout tests for table cell changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate layout tests for table cell changes.
hyatt@apple.com [Fri, 23 Jan 2009 04:05:26 +0000 (04:05 +0000)]
Update layout tests for table cell changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate layout tests for table cell changes.
hyatt@apple.com [Fri, 23 Jan 2009 04:04:53 +0000 (04:04 +0000)]
Update layout tests for table cell changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate layout tests for table cell changes.
hyatt@apple.com [Fri, 23 Jan 2009 04:03:48 +0000 (04:03 +0000)]
Update layout tests for table cell changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate layout tests for table cell changes.
hyatt@apple.com [Fri, 23 Jan 2009 04:03:12 +0000 (04:03 +0000)]
Update layout tests for table cell changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-22 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 23 Jan 2009 03:55:34 +0000 (03:55 +0000)]
2009-01-22  David Hyatt  <hyatt@apple.com>

        Properly encapsulate m_frameRect.y() behind the RenderBox::y() method now that they are the same thing.
        Make m_frameRect private.

        Reviewed by Oliver Hunt

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paint):
        (WebCore::RenderBlock::clearFloats):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::offsetTop):
        (WebCore::RenderBox::nodeAtPoint):
        (WebCore::RenderBox::paint):
        (WebCore::RenderBox::paintCustomHighlight):
        (WebCore::RenderBox::containingBlockWidth):
        (WebCore::RenderBox::localToAbsolute):
        (WebCore::RenderBox::offsetFromContainer):
        (WebCore::RenderBox::computeAbsoluteRepaintRect):
        (WebCore::RenderBox::repaintDuringLayoutIfMoved):
        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::layout):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutBlock):
        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::paint):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paintReplaced):
        (WebCore::RenderImage::nodeAtPoint):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::paint):
        (WebCore::RenderListMarker::getRelativeMarkerRect):
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::paint):
        (WebCore::RenderReplaced::shouldPaint):
        * rendering/RenderReplica.cpp:
        (WebCore::RenderReplica::paint):
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::applyContentTransforms):
        (WebCore::RenderSVGRoot::paint):
        (WebCore::RenderSVGRoot::absoluteTransform):
        (WebCore::RenderSVGRoot::nodeAtPoint):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::calcWidth):
        (WebCore::RenderTable::layout):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::paint):
        (WebCore::RenderTableCell::paintBackgroundsBehindCell):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::setCellWidths):
        (WebCore::RenderTableSection::calcRowHeight):
        (WebCore::RenderTableSection::layoutRows):
        (WebCore::RenderTableSection::paint):
        (WebCore::RenderTableSection::nodeAtPoint):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-22 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 23 Jan 2009 03:42:12 +0000 (03:42 +0000)]
2009-01-22  David Hyatt  <hyatt@apple.com>

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23487.

        This patch completely reworks vertical alignment of table cells.  The current system uses methods called borderTopExtra() and borderBottomExtra() to
        add extra space above and below the content of a cell.  This system was not confined to the table code and spilled out into all the other RenderObjects.
        The y-position of the table cell box was set to the outer edge of the cell, but the y() method of RenderBox lied and added in borderTopExtra().  height()
        also excluded the extra space, so did not accurately reflect the true size of the cell.

        With the new system, the table cell box is completely accurate.  The extra space becomes part of the padding of the cell.  Padding has been reworked so that
        additional intrinsic padding can be added on to the specified padding from style.  Only the table code has to deal with the extra cell padding.

        localToAbsoluteForContent has now been removed, since there no longer has to be a special hacked content box.

        A number of table layout tests progress with this change, since the new layout system actually fixes existing bugs in baseline alignment of cells.

        Reviewed by Oliver Hunt

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        Make CSSComputedStyleDeclaration ask for padding values that exclude the built-in intrinsic padding.  This ensures that getComputedStyle continues
        to give the right answer.

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::getLowerRightCorner):
        * editing/visible_units.cpp:
        (WebCore::previousLinePosition):
        (WebCore::nextLinePosition):
        * rendering/LayoutState.cpp:
        (WebCore::LayoutState::LayoutState):
        Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::overflowRect):
        Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.

        (WebCore::RenderBlock::layoutBlock):
        (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
        The expandsToEncloseOverhangingFloats logic has been reworked.  Table cells and fieldsets did not properly handle floats that spilled into the bottom padding.  The
        resulting box needed to not only expand to encompass the float, but also needed to place the full bottom padding after the float.  The switch to make the extra table cell
        space into padding exposed this issue.  No extra layout test is required, since an existing table layout test exposes this issue and progresses to match Firefox with
        this change.

        (WebCore::RenderBlock::selectionGapRects):
        (WebCore::RenderBlock::paintSelection):
        (WebCore::RenderBlock::fillSelectionGaps):
        (WebCore::RenderBlock::nodeAtPoint):
        (WebCore::RenderBlock::positionForCoordinates):
        (WebCore::RenderBlock::offsetForContents):
        Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.

        * rendering/RenderBlock.h:
        Add the new simplified method for expanding to encompass overhanging floats.  The method has been devirtualized and made to include all of the cases (and not just a subset).

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::absoluteRects):
        (WebCore::RenderBox::absoluteQuads):
        (WebCore::RenderBox::absoluteContentBox):
        (WebCore::RenderBox::paintBoxDecorations):
        (WebCore::RenderBox::paintMask):
        (WebCore::RenderBox::getOverflowClipRect):
        (WebCore::RenderBox::localToAbsolute):
        (WebCore::RenderBox::absoluteToLocal):
        (WebCore::RenderBox::localToAbsoluteQuad):
        Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.

        * rendering/RenderBox.h:
        (WebCore::RenderBox::y):
        (WebCore::RenderBox::location):
        (WebCore::RenderBox::borderBoxRect):
        (WebCore::RenderBox::offsetHeight):
        Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.

        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::addLineBoxRects):
        * rendering/RenderFieldset.cpp:
        (WebCore::RenderFieldset::paintBoxDecorations):
        (WebCore::RenderFieldset::paintMask):
        * rendering/RenderFieldset.h:
        (WebCore::RenderFieldset::avoidsFloats):
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::localCaretRect):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPosition):
        (WebCore::RenderLayer::paintLayer):
        (WebCore::RenderLayer::hitTestLayer):
        (WebCore::RenderLayer::boundingBox):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::isPointInOverflowControl):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::localToAbsolute):
        (WebCore::RenderObject::absoluteToLocal):
        (WebCore::RenderObject::localToAbsoluteQuad):
        (WebCore::RenderObject::offsetFromContainer):
        (WebCore::RenderObject::paddingTop):
        (WebCore::RenderObject::paddingBottom):
        (WebCore::RenderObject::paddingLeft):
        (WebCore::RenderObject::paddingRight):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::hasOverhangingFloats):
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::selectionRect):
        (WebCore::RenderReplaced::localSelectionRect):
        Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.  Also modifed paddingLeft/Top/Right/Bottom to take an argument indicating
        whether or not the intrinsic padding of an object should be included (by default it is).  getComputedStyle needs to exclude it, which is why this argument is
        necessary.

        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::RenderTableCell):
        (WebCore::RenderTableCell::paddingTop):
        (WebCore::RenderTableCell::paddingBottom):
        The new paddingTop() and paddingBottom() methods on table cells include the extra intrinsic padding.

        (WebCore::RenderTableCell::setOverrideSize):
        When a table's override size gets altered, the intrinsic padding needs to be cleared.

        (WebCore::RenderTableCell::absoluteClippedOverflowRect):
        (WebCore::RenderTableCell::computeAbsoluteRepaintRect):
        (WebCore::RenderTableCell::baselinePosition):
        (WebCore::RenderTableCell::paint):
        (WebCore::RenderTableCell::paintBackgroundsBehindCell):
        (WebCore::RenderTableCell::paintBoxDecorations):
        (WebCore::RenderTableCell::paintMask):
        Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.

        * rendering/RenderTableCell.h:
        (WebCore::RenderTableCell::setIntrinsicPaddingTop):
        (WebCore::RenderTableCell::setIntrinsicPaddingBottom):
        (WebCore::RenderTableCell::setIntrinsicPadding):
        (WebCore::RenderTableCell::clearIntrinsicPadding):
        (WebCore::RenderTableCell::intrinsicPaddingTop):
        (WebCore::RenderTableCell::intrinsicPaddingBottom):
        Add new helper methods for getting/setting a cell's intrinsic padding.

        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::calcRowHeight):
        calcRowHeight has been modified to exclude the intrinsic padding when calculating the base height of rows prior to flexing.  Because a cell now includes that
        extra space, it has to be subtracted out in this method.

        (WebCore::RenderTableSection::layoutRows):
        Modify the code that sets up the intrinsic padding so that it does a relayout if the intrinsic padding changes.   There was also an error where the baseline
        position mismatched leading to negative intrinsic padding being added in (this error exists in ToT).  The code now properly ignores cells that don't establish
        a baseline.  A number of tests progress with this change.

        * rendering/RenderText.cpp:
        (WebCore::RenderText::addLineBoxRects):
        Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.

        * rendering/RenderTreeAsText.cpp:
        (WebCore::operator<<):
        (WebCore::writeTextRun):
        Modify the render tree dumping code to continue to produce the same results as before.  This is really a hack, since we're now capable of indicating the correct
        position for the descendants of cells with intrinsic padding (and also indicating what the correct cell box is).  A future patch can remove these hacks so that the
        layout test results can all be regenerated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago https://bugs.webkit.org/show_bug.cgi?id=23489
sfalken@apple.com [Fri, 23 Jan 2009 02:30:29 +0000 (02:30 +0000)]
    https://bugs.webkit.org/show_bug.cgi?id=23489

        Return currentTime() in correct units for the two early return cases.

        Reviewed by Mark Rowe.

        * wtf/CurrentTime.cpp:
        (WTF::currentTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 23 Jan 2009 01:01:31 +0000 (01:01 +0000)]
2009-01-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add support for Invoke and InvokeDefault. Clean up code.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCBooleanReply):
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        (WebKit::NetscapePluginInstanceProxy::Reply::):
        (WebKit::NetscapePluginInstanceProxy::BooleanReply::BooleanReply):
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
        * Plugins/Hosted/ProxyInstance.h:
        * Plugins/Hosted/ProxyInstance.mm:
        (WebKit::ProxyInstance::invoke):
        (WebKit::ProxyInstance::invokeMethod):
        (WebKit::ProxyInstance::supportsInvokeDefaultMethod):
        (WebKit::ProxyInstance::invokeDefaultMethod):
        (WebKit::ProxyInstance::methodsNamed):
        (WebKit::ProxyInstance::fieldNamed):
        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHost.defs:
        * Plugins/Hosted/WebKitPluginHostTypes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Justin Garcia.
eric@webkit.org [Fri, 23 Jan 2009 00:46:58 +0000 (00:46 +0000)]
    Reviewed by Justin Garcia.

        Remove <span> turds left by editing commands
        https://bugs.webkit.org/show_bug.cgi?id=23466

        Tests:
        * editing/execCommand/empty-span-removal.html
        * editing/execCommand/toggle-styles.html

        * editing/ApplyStyleCommand.cpp:
        (WebCore::styleSpanClassString):
        (WebCore::isStyleSpan):
        (WebCore::isUnstyledStyleSpan):
        (WebCore::isSpanWithoutAttributesOrUnstyleStyleSpan):
        (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
        (WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
        (WebCore::ApplyStyleCommand::removeHTMLBidiEmbeddingStyle):
        (WebCore::ApplyStyleCommand::removeCSSStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 22 Jan 2009 23:24:30 +0000 (23:24 +0000)]
2009-01-22  Anders Carlsson  <andersca@apple.com>

        Fix Windows build.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Eric Seidel.
zimmermann@webkit.org [Thu, 22 Jan 2009 22:53:47 +0000 (22:53 +0000)]
Reviewed by Eric Seidel.

Rename some of the casting functions in dom/*Element.cpp:
formControlElementForElement -> toFormControlElement
inputElementForElement -> toInputElement
optionElementForElement -> toOptionElement
optionGroupElementForElement -> toOptionGroupElement

Suggested by Alexey, while refactoring the Element*->ScriptElement* code.
The Element*->ScriptElement* helper function is already named 'toScriptElement'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-22 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 22 Jan 2009 22:48:26 +0000 (22:48 +0000)]
2009-01-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Fix for <rdar://problem/6439247>
        FastMalloc allocating an extra 4MB of meta-data on 64-bit

        Rely on the fact that on all known x86-64 platforms only use 48 bits of
        address space to shrink the initial size of the PageMap from ~4MB to 120K.
        For 64-bit we still use a 3-level radix tree, but now each level is only 12
        bits wide.

        No performance change.

        * wtf/FastMalloc.cpp:
        (WTF::MapSelector): Add specialization for 64 bit that takes into account the
        16 bits of unused address space on x86-64.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by George Staikos.
zimmermann@webkit.org [Thu, 22 Jan 2009 22:24:03 +0000 (22:24 +0000)]
Rubber-stamped by George Staikos.
Forgot to include in my last commit: Activate code depending on WMLOptionElement/WMLOptGroupElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by George Staikos.
zimmermann@webkit.org [Thu, 22 Jan 2009 22:04:49 +0000 (22:04 +0000)]
Reviewed by George Staikos.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=23454

Add WML <option>/<optgroup> element support.
Currently the implementation is stubbed, all relevant parts can be enabled
once WMLSelectElement/SelectElement has been created.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
bdakin@apple.com [Thu, 22 Jan 2009 21:51:47 +0000 (21:51 +0000)]
JavaScriptCore:

2009-01-22  Beth Dakin  <bdakin@apple.com>

        Reviewed by Sam Weinig.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23461 LayoutTests/
        fast/js/numeric-conversion.html is broken, and corresponding
        <rdar://problem/6514842>

        The basic problem here is that parseInt(Infinity) should be NaN,
        but we were returning 0. NaN matches Safari 3.2.1 and Firefox.

        * runtime/JSGlobalObjectFunctions.cpp:
        (JSC::globalFuncParseInt):

LayoutTests:

2009-01-22  Beth Dakin  <bdakin@apple.com>

        Reviewed by Sam Weinig.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23461 LayoutTests/
        fast/js/numeric-conversion.html is broken, and corresponding
        <rdar://problem/6514842>

        The basic problem here is that parseInt(Infinity) should be NaN,
        but we were returning 0. NaN matches Safari 3.2.1 and Firefox.

        * fast/js/numeric-conversion-expected.txt:
        * fast/js/resources/numeric-conversion.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
dglazkov@chromium.org [Thu, 22 Jan 2009 21:16:25 +0000 (21:16 +0000)]
WebCore:

2009-01-22  Eric Roman  <eroman@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=20806
        Send referrer for history navigations.

        Test: http/tests/navigation/back-send-referrer.html

        Consolidates HistoryItem::rssFeedReferrer and HistoryItem::formReferrer into a single HistoryItem::referrer property.

        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::HistoryItem):
        (WebCore::HistoryItem::referrer):
        (WebCore::HistoryItem::setReferrer):
        (WebCore::HistoryItem::formReferrer):
        (WebCore::HistoryItem::rssFeedReferrer):
        (WebCore::HistoryItem::setRSSFeedReferrer):
        (WebCore::HistoryItem::setFormInfoFromRequest):
        * history/HistoryItem.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadItem):

WebKit/win:

2009-01-22  Eric Roman  <eroman@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=20806
        Deprecate RSSFeedReferrer() and setRSSFeedReferrer().

        * WebHistoryItem.cpp:
        (WebHistoryItem::RSSFeedReferrer):
        (WebHistoryItem::setRSSFeedReferrer):

WebKit/mac:

2009-01-22  Eric Roman  <eroman@chromium.og>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=20806
        Deprecate RSSFeedReferrer() and setRSSFeedReferrer().

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem RSSFeedReferrer]):
        (-[WebHistoryItem setRSSFeedReferrer:]):

LayoutTests:

2009-01-22  Eric Roman  <eroman@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=20806
        "Referer" header not sent for history navigation.

        * http/tests/navigation/back-send-referrer-expected.txt: Added.
        * http/tests/navigation/back-send-referrer.html: Added.
        * http/tests/navigation/resources/back-send-referrer-helper.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/6516853> (r39682-r39736) JSFunFuzz: crash on "(function(){({ x2:...
oliver@apple.com [Thu, 22 Jan 2009 21:07:14 +0000 (21:07 +0000)]
<rdar://problem/6516853> (r39682-r39736) JSFunFuzz: crash on "(function(){({ x2: x }), })()"
<https://bugs.webkit.org/show_bug.cgi?id=23479>

Reviewed by Geoff Garen.

Automatic semicolon insertion was resulting in this being accepted in the initial
nodeless parsing, but subsequent reparsing for code generation would fail, leading
to a crash.  The solution is to ensure that reparsing a function performs parsing
in the same state as the initial parse.  We do this by modifying the saved source
ranges to include rather than exclude the opening and closing braces.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Eric Seidel.
zimmermann@webkit.org [Thu, 22 Jan 2009 20:40:18 +0000 (20:40 +0000)]
Reviewed by Eric Seidel.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=23465

Further enhancments to share code between HTMLOptionElement and the upcoming WMLOptionElement.

Rename optionText() to textIndentedToRespectGroupLabel() in (HTML)OptionElement, as it fits better.
optionText() returns the options text prefixed with some spaces, in case it got an optgroup parent.

Add two more pure-virtual functions to OptionElement: setSelectedState(bool) & value().
These aren't used outside of html/ at the moment (unlike the other pure-virtual functions
used by RenderMenuList/RenderListBox) - but they will be used by SelectElement, once it exists.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-22 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.com [Thu, 22 Jan 2009 20:30:32 +0000 (20:30 +0000)]
2009-01-22  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Justin Garcia.

        Bug 23464: Infinite recursion at SelectionController::setSelection
        https://bugs.webkit.org/show_bug.cgi?id=23464

        Check for conditions leading to infinite recursion.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::setSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 22 Jan 2009 20:12:47 +0000 (20:12 +0000)]
2009-01-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Clean up the test plug-in code. We now always use the CG drawing model and the
        Cocoa event model. It is however possible to revert to the old Carbon event model by
        specifying forcecarbon=true in the embed/object tag.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
        * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
        (NPP_New):
        (handleEventCarbon):
        (handleEventCocoa):
        (NPP_HandleEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 22 Jan 2009 19:06:18 +0000 (19:06 +0000)]
2009-01-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Don't crash or hang when we fail to instantiate a plug-in.

        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::instantiatePlugin):
        Return 0 on failure.

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView JSC::Bindings::createPluginBindingsInstance:JSC::Bindings::]):
        Null check for the proxy member.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Fix WML build problem in RenderBox.cpp, WMLNames is undefined.
zimmermann@webkit.org [Thu, 22 Jan 2009 18:55:42 +0000 (18:55 +0000)]
Not reviewed. Fix WML build problem in RenderBox.cpp, WMLNames is undefined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the Qt build after RenderBox changes.
treat@webkit.org [Thu, 22 Jan 2009 15:29:25 +0000 (15:29 +0000)]
Fix the Qt build after RenderBox changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-22 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 22 Jan 2009 09:41:39 +0000 (09:41 +0000)]
2009-01-22  David Hyatt  <hyatt@apple.com>

        Fix regressions in list box selection on Mac.  The wrong color was being used for the list box
        background, and list box colors actually weren't even being properly fetched because of a bug in
        the RenderTheme base class.  Existing pixel tests cover the bug fix.

        Reviewed by Jon Honeycutt

        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
        (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
        (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
        (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-22 David Levin <levin@chromium.org>
ap@webkit.org [Thu, 22 Jan 2009 08:58:16 +0000 (08:58 +0000)]
2009-01-22  David Levin  <levin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Bug 22720: Make XMLHttpRequest work in Workers
        <https://bugs.webkit.org/show_bug.cgi?id=22720>

        Add copy/adopt for HTTPHeaderMap to allow the data to be passed across threads.

        No observable change in behavior, so no test.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.scons:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * platform/network/HTTPHeaderMap.cpp: Added.
        (WebCore::HTTPHeaderMap::copyData):
        (WebCore::HTTPHeaderMap::adopt):
        * platform/network/HTTPHeaderMap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-22 Dmitry Titov <dimich@chromium.org>
ap@webkit.org [Thu, 22 Jan 2009 08:32:45 +0000 (08:32 +0000)]
2009-01-22  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=23373

        Implement ThreadCondition::timedWait().
        Since we borrow the code for condition variables from other sources,
        I did the same for timedWait(). See comments in ThreadingWin.cpp for
        rationale and more info.

        * wtf/CONTRIBUTORS.pthreads-win32:
        Added. A list of Pthreads-win32 contributors mentioned in their license. The license itself
        is included into wtf/ThreadingWin32.cpp.

        * wtf/Threading.h:
        * wtf/ThreadingWin.cpp:
        Additional info and Pthreads-win32 license at the beginning.
        (WTF::PlatformCondition::timedWait): new method, derived from Pthreads-win32.
        (WTF::PlatformCondition::signal): same
        (WTF::ThreadCondition::ThreadCondition):
        (WTF::ThreadCondition::~ThreadCondition):
        (WTF::ThreadCondition::wait): this now calls PlatformCondition::timedWait.
        (WTF::ThreadCondition::timedWait): same
        (WTF::ThreadCondition::signal): this now calls PlatformCondition::signal.
        (WTF::ThreadCondition::broadcast): same

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix build bustage in WML from RenderBox changes.
hyatt@apple.com [Thu, 22 Jan 2009 08:15:16 +0000 (08:15 +0000)]
Fix build bustage in WML from RenderBox changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Gtk build bustage.
hyatt@apple.com [Thu, 22 Jan 2009 08:12:35 +0000 (08:12 +0000)]
Fix Gtk build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Qt build bustage.
hyatt@apple.com [Thu, 22 Jan 2009 08:11:09 +0000 (08:11 +0000)]
Fix Qt build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-21 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 22 Jan 2009 07:54:25 +0000 (07:54 +0000)]
2009-01-21  David Hyatt  <hyatt@apple.com>

        Back out a portion of my patch that I did not mean to land.  Revert paintOutline back to the way it
        was before my landing.  Fixes failing SVG focus ring tests.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::paintOutline):
        * rendering/RenderObject.h:
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::paint):
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-21 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 22 Jan 2009 07:19:19 +0000 (07:19 +0000)]
2009-01-21  David Hyatt  <hyatt@apple.com>

        Fix Node's renderBox() method on Windows.

        * dom/Node.cpp:
        (WebCore::Node::renderBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-21 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 22 Jan 2009 07:05:57 +0000 (07:05 +0000)]
2009-01-21  David Hyatt  <hyatt@apple.com>

        Fix RenderThemeSafari bustage on Win32.

        * rendering/RenderThemeSafari.cpp:
        (WebCore::RenderThemeSafari::baselinePosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-21 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 22 Jan 2009 06:58:18 +0000 (06:58 +0000)]
2009-01-21  David Hyatt  <hyatt@apple.com>

        Fix bustage in RenderThemeWin. It's actually terrible that RenderThemeWin is using absoluteContentBox,
        but that's a problem for another day.

        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::paintSearchFieldCancelButton):
        (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
        (WebCore::RenderThemeWin::paintSearchFieldResultsButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBecause bdash hates freedom (tyop fix).
barraclough@apple.com [Thu, 22 Jan 2009 05:59:46 +0000 (05:59 +0000)]
Because bdash hates freedom (tyop fix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-21 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Thu, 22 Jan 2009 05:57:59 +0000 (05:57 +0000)]
2009-01-21  Gavin Barraclough  <barraclough@apple.com>

        Rubber stamped by Geoff "Cameron Zwarich" Garen.

        Add pre & post standalone driver stcripts to assist running the javascript layout tests
        on jsc, rather than a full webkit build.

        * fast/js/resources/standalone-post.js: Copied from fast/js/resources/js-test-post.js.
        * fast/js/resources/standalone-pre.js: Copied from fast/js/resources/js-test-pre.js.
        (description):
        (debug):
        (escapeString):
        (testPassed):
        (testFailed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 23470: Crash when page load occurs while processing scroll event with MallocScrib...
oliver@apple.com [Thu, 22 Jan 2009 05:48:32 +0000 (05:48 +0000)]
Bug 23470: Crash when page load occurs while processing scroll event with MallocScribble enabled
<https://bugs.webkit.org/show_bug.cgi?id=23470>

Reviewed by Dave Hyatt

Add a RefPtr protector to handleWheelEvent to guard against destruction
while processing the scroll event.  Alas the absurd set of circumstances
required to trigger this do not appear to be reproducible in DRT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
barraclough@apple.com [Thu, 22 Jan 2009 04:28:05 +0000 (04:28 +0000)]
JavaScriptCore:

2009-01-21  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23469.

        We need to check all numbers in integer switches, not just those
        represented as integer JSImmediates.

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::privateExecute):
        (JSC::Interpreter::cti_op_switch_imm):

LayoutTests:

2009-01-21  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Add layout test for switch (-0).

        * fast/js/resources/switch-behaviour.js:
        * fast/js/switch-behaviour-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-21 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Thu, 22 Jan 2009 03:35:42 +0000 (03:35 +0000)]
2009-01-21  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff Garen.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23468.

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::privateExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Thu, 22 Jan 2009 02:31:52 +0000 (02:31 +0000)]
WebCore:

2009-01-21  David Hyatt  <hyatt@apple.com>

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23453

        Devirtualize the width/height/x/y methods of the render tree.  The methods are now non-virtual on RenderBox.
        Many functions that were previously in RenderObject.cpp are now in RenderBox.cpp.

        Reviewed by Eric Seidel and Darin Adler

        * WebCore.base.exp:
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::sizingBox):
        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::getUpperLeftCorner):
        (WebCore::ContainerNode::getLowerRightCorner):
        * dom/Element.cpp:
        (WebCore::Element::offsetLeft):
        (WebCore::Element::offsetTop):
        (WebCore::Element::offsetWidth):
        (WebCore::Element::offsetHeight):
        (WebCore::Element::offsetParent):
        (WebCore::Element::clientLeft):
        (WebCore::Element::clientTop):
        (WebCore::Element::clientWidth):
        (WebCore::Element::clientHeight):
        (WebCore::Element::scrollLeft):
        (WebCore::Element::scrollTop):
        (WebCore::Element::setScrollLeft):
        (WebCore::Element::setScrollTop):
        (WebCore::Element::scrollWidth):
        (WebCore::Element::scrollHeight):
        * dom/Node.cpp:
        (WebCore::Node::renderBox):
        (WebCore::Node::getRect):
        * dom/Node.h:
        * dom/Position.cpp:
        (WebCore::endsOfNodeAreVisuallyDistinctPositions):
        (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
        (WebCore::Position::isCandidate):
        * dom/PositionIterator.cpp:
        (WebCore::PositionIterator::isCandidate):
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
        * editing/DeleteButtonController.cpp:
        (WebCore::isDeletableElement):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::removeNode):
        * editing/Editor.cpp:
        (WebCore::Editor::insideVisibleArea):
        * editing/EditorCommand.cpp:
        (WebCore::verticalScrollDistance):
        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::isKeyboardFocusable):
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::willDraw):
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::isFocusable):
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::width):
        (WebCore::HTMLFrameElementBase::height):
        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::width):
        (WebCore::HTMLImageElement::height):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::drawNodeHighlight):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
        * page/FrameView.cpp:
        (WebCore::FrameView::createScrollbar):
        (WebCore::FrameView::updateDashboardRegions):
        * page/animation/AnimationBase.cpp:
        (WebCore::blendFunc):
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::imageRect):
        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::renderBox):
        (WebCore::InlineBox::adjustPosition):
        * rendering/InlineBox.h:
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::placeBoxesHorizontally):
        (WebCore::InlineFlowBox::verticallyAlignBoxes):
        (WebCore::InlineFlowBox::placeBoxesVertically):
        * rendering/InlineFlowBox.h:
        * rendering/RenderApplet.cpp:
        (WebCore::RenderApplet::createWidgetIfNecessary):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::overflowHeight):
        (WebCore::RenderBlock::overflowWidth):
        (WebCore::RenderBlock::overflowRect):
        (WebCore::RenderBlock::isSelfCollapsingBlock):
        (WebCore::RenderBlock::layout):
        (WebCore::RenderBlock::layoutBlock):
        (WebCore::RenderBlock::adjustPositionedBlock):
        (WebCore::RenderBlock::adjustFloatingBlock):
        (WebCore::RenderBlock::handleSpecialChild):
        (WebCore::RenderBlock::handlePositionedChild):
        (WebCore::RenderBlock::handleFloatingChild):
        (WebCore::RenderBlock::handleCompactChild):
        (WebCore::RenderBlock::insertCompactIfNeeded):
        (WebCore::RenderBlock::handleRunInChild):
        (WebCore::RenderBlock::collapseMargins):
        (WebCore::RenderBlock::clearFloatsIfNeeded):
        (WebCore::RenderBlock::estimateVerticalPosition):
        (WebCore::RenderBlock::determineHorizontalPosition):
        (WebCore::RenderBlock::handleBottomOfBlock):
        (WebCore::RenderBlock::layoutBlockChildren):
        (WebCore::RenderBlock::layoutOnlyPositionedObjects):
        (WebCore::RenderBlock::layoutPositionedObjects):
        (WebCore::RenderBlock::markPositionedObjectsForLayout):
        (WebCore::RenderBlock::repaintOverhangingFloats):
        (WebCore::RenderBlock::paint):
        (WebCore::RenderBlock::paintChildren):
        (WebCore::RenderBlock::paintObject):
        (WebCore::RenderBlock::paintFloats):
        (WebCore::RenderBlock::paintContinuationOutlines):
        (WebCore::clipOutPositionedObjects):
        (WebCore::RenderBlock::fillSelectionGaps):
        (WebCore::RenderBlock::fillBlockSelectionGaps):
        (WebCore::RenderBlock::leftSelectionOffset):
        (WebCore::RenderBlock::rightSelectionOffset):
        (WebCore::RenderBlock::insertPositionedObject):
        (WebCore::RenderBlock::removePositionedObject):
        (WebCore::RenderBlock::removePositionedObjects):
        (WebCore::RenderBlock::insertFloatingObject):
        (WebCore::RenderBlock::removeFloatingObject):
        (WebCore::RenderBlock::positionNewFloats):
        (WebCore::RenderBlock::newLine):
        (WebCore::RenderBlock::lowestPosition):
        (WebCore::RenderBlock::rightmostPosition):
        (WebCore::RenderBlock::leftmostPosition):
        (WebCore::RenderBlock::clearFloats):
        (WebCore::RenderBlock::addOverhangingFloats):
        (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
        (WebCore::RenderBlock::getClearDelta):
        (WebCore::RenderBlock::nodeAtPoint):
        (WebCore::RenderBlock::positionForCoordinates):
        (WebCore::RenderBlock::layoutColumns):
        (WebCore::RenderBlock::getBaselineOfFirstLineBox):
        (WebCore::RenderBlock::getBaselineOfLastLineBox):
        (WebCore::getHeightForLineCount):
        (WebCore::RenderBlock::adjustForBorderFit):
        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::FloatWithRect::FloatWithRect):
        (WebCore::RenderBlock::hasOverhangingFloats):
        (WebCore::RenderBlock::CompactInfo::compact):
        (WebCore::RenderBlock::CompactInfo::set):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::RenderBox):
        (WebCore::RenderBox::offsetLeft):
        (WebCore::RenderBox::offsetTop):
        (WebCore::RenderBox::offsetParent):
        (WebCore::RenderBox::clientWidth):
        (WebCore::RenderBox::clientHeight):
        (WebCore::RenderBox::scrollWidth):
        (WebCore::RenderBox::scrollHeight):
        (WebCore::RenderBox::scrollLeft):
        (WebCore::RenderBox::scrollTop):
        (WebCore::RenderBox::setScrollLeft):
        (WebCore::RenderBox::setScrollTop):
        (WebCore::RenderBox::absoluteRects):
        (WebCore::RenderBox::absoluteQuads):
        (WebCore::RenderBox::absoluteContentBox):
        (WebCore::RenderBox::absoluteContentQuad):
        (WebCore::RenderBox::absoluteOutlineBounds):
        (WebCore::RenderBox::addFocusRingRects):
        (WebCore::RenderBox::reflectionBox):
        (WebCore::RenderBox::reflectionOffset):
        (WebCore::RenderBox::reflectedRect):
        (WebCore::RenderBox::overrideWidth):
        (WebCore::RenderBox::overrideHeight):
        (WebCore::RenderBox::nodeAtPoint):
        (WebCore::RenderBox::paint):
        (WebCore::RenderBox::maskClipRect):
        (WebCore::RenderBox::repaintLayerRectsForImage):
        (WebCore::RenderBox::paintCustomHighlight):
        (WebCore::RenderBox::getOverflowClipRect):
        (WebCore::RenderBox::getClipRect):
        (WebCore::RenderBox::containingBlockWidth):
        (WebCore::RenderBox::localToAbsolute):
        (WebCore::RenderBox::offsetFromContainer):
        (WebCore::RenderBox::position):
        (WebCore::RenderBox::computeAbsoluteRepaintRect):
        (WebCore::RenderBox::repaintDuringLayoutIfMoved):
        (WebCore::RenderBox::calcWidth):
        (WebCore::RenderBox::calcWidthUsing):
        (WebCore::RenderBox::calcHorizontalMargins):
        (WebCore::RenderBox::calcHeight):
        (WebCore::RenderBox::calcPercentageHeight):
        (WebCore::RenderBox::calcReplacedHeightUsing):
        (WebCore::RenderBox::containingBlockWidthForPositioned):
        (WebCore::RenderBox::containingBlockHeightForPositioned):
        (WebCore::RenderBox::calcAbsoluteHorizontal):
        (WebCore::RenderBox::calcAbsoluteVertical):
        (WebCore::RenderBox::calcAbsoluteVerticalValues):
        (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
        (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
        (WebCore::RenderBox::localCaretRect):
        (WebCore::RenderBox::lowestPosition):
        (WebCore::RenderBox::rightmostPosition):
        (WebCore::RenderBox::leftmostPosition):
        (WebCore::RenderBox::localTransform):
        * rendering/RenderBox.h:
        (WebCore::):
        (WebCore::RenderBox::x):
        (WebCore::RenderBox::y):
        (WebCore::RenderBox::width):
        (WebCore::RenderBox::height):
        (WebCore::RenderBox::setX):
        (WebCore::RenderBox::setY):
        (WebCore::RenderBox::setWidth):
        (WebCore::RenderBox::setHeight):
        (WebCore::RenderBox::location):
        (WebCore::RenderBox::size):
        (WebCore::RenderBox::setLocation):
        (WebCore::RenderBox::setSize):
        (WebCore::RenderBox::move):
        (WebCore::RenderBox::frameRect):
        (WebCore::RenderBox::setFrameRect):
        (WebCore::RenderBox::borderBoxRect):
        (WebCore::RenderBox::contentBoxRect):
        (WebCore::RenderBox::previousSiblingBox):
        (WebCore::RenderBox::nextSiblingBox):
        (WebCore::RenderBox::parentBox):
        (WebCore::RenderBox::overflowHeight):
        (WebCore::RenderBox::overflowWidth):
        (WebCore::RenderBox::setOverflowHeight):
        (WebCore::RenderBox::setOverflowWidth):
        (WebCore::RenderBox::overflowLeft):
        (WebCore::RenderBox::overflowTop):
        (WebCore::RenderBox::overflowRect):
        (WebCore::RenderBox::contentWidth):
        (WebCore::RenderBox::contentHeight):
        (WebCore::RenderBox::offsetWidth):
        (WebCore::RenderBox::offsetHeight):
        (WebCore::RenderBox::clientLeft):
        (WebCore::RenderBox::clientTop):
        (WebCore::RenderBox::availableWidth):
        (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):
        * rendering/RenderButton.cpp:
        (WebCore::RenderButton::controlClipRect):
        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::layout):
        (WebCore::RenderContainer::positionForCoordinates):
        * rendering/RenderContainer.h:
        (WebCore::RenderContainer::firstChildBox):
        (WebCore::RenderContainer::lastChildBox):
        * rendering/RenderFieldset.cpp:
        (WebCore::RenderFieldset::calcPrefWidths):
        (WebCore::RenderFieldset::layoutLegend):
        (WebCore::RenderFieldset::findLegend):
        (WebCore::RenderFieldset::paintBoxDecorations):
        (WebCore::RenderFieldset::paintMask):
        * rendering/RenderFieldset.h:
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::maxFilenameWidth):
        (WebCore::RenderFileUploadControl::paintObject):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::FlexBoxIterator::FlexBoxIterator):
        (WebCore::FlexBoxIterator::first):
        (WebCore::FlexBoxIterator::next):
        (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths):
        (WebCore::RenderFlexibleBox::calcVerticalPrefWidths):
        (WebCore::RenderFlexibleBox::layoutBlock):
        (WebCore::RenderFlexibleBox::layoutHorizontalBox):
        (WebCore::RenderFlexibleBox::layoutVerticalBox):
        (WebCore::RenderFlexibleBox::placeChild):
        (WebCore::RenderFlexibleBox::allowedChildFlex):
        * rendering/RenderFlexibleBox.h:
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::absoluteClippedOverflowRect):
        (WebCore::RenderFlow::lowestPosition):
        (WebCore::RenderFlow::rightmostPosition):
        (WebCore::RenderFlow::leftmostPosition):
        (WebCore::RenderFlow::localCaretRect):
        (WebCore::RenderFlow::addFocusRingRects):
        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::paint):
        (WebCore::RenderFrameSet::layout):
        (WebCore::RenderFrameSet::positionFrames):
        * rendering/RenderHTMLCanvas.cpp:
        (WebCore::RenderHTMLCanvas::paintReplaced):
        (WebCore::RenderHTMLCanvas::canvasSizeChanged):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::imageChanged):
        (WebCore::RenderImage::paintReplaced):
        (WebCore::RenderImage::nodeAtPoint):
        (WebCore::RenderImage::calcReplacedWidth):
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::absoluteRects):
        (WebCore::RenderInline::boundingBoxWidth):
        (WebCore::RenderInline::boundingBoxHeight):
        (WebCore::RenderInline::positionForCoordinates):
        * rendering/RenderInline.h:
        (WebCore::RenderInline::offsetWidth):
        (WebCore::RenderInline::offsetHeight):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateTransform):
        (WebCore::RenderLayer::updateLayerPosition):
        (WebCore::RenderLayer::scrollbarCornerPresent):
        (WebCore::RenderLayer::createScrollbar):
        (WebCore::RenderLayer::positionOverflowControls):
        (WebCore::RenderLayer::paintScrollCorner):
        (WebCore::RenderLayer::paintResizer):
        (WebCore::RenderLayer::paintLayer):
        (WebCore::RenderLayer::hitTestLayer):
        (WebCore::RenderLayer::calculateRects):
        (WebCore::RenderLayer::boundingBox):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::calcHeight):
        (WebCore::RenderListBox::controlClipRect):
        * rendering/RenderListItem.cpp:
        (WebCore::RenderListItem::positionListMarker):
        (WebCore::RenderListItem::paint):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::paint):
        (WebCore::RenderListMarker::layout):
        (WebCore::RenderListMarker::imageChanged):
        (WebCore::RenderListMarker::getRelativeMarkerRect):
        (WebCore::RenderListMarker::selectionRect):
        * rendering/RenderMarquee.cpp:
        (WebCore::RenderMarquee::computePosition):
        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::layout):
        (WebCore::RenderMedia::lowestPosition):
        (WebCore::RenderMedia::rightmostPosition):
        (WebCore::RenderMedia::leftmostPosition):
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::controlClipRect):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::RenderObject):
        (WebCore::RenderObject::markAllDescendantsWithFloatsForLayout):
        (WebCore::RenderObject::paintOutline):
        (WebCore::RenderObject::addLineBoxRects):
        (WebCore::RenderObject::absoluteBoundingBoxRect):
        (WebCore::RenderObject::addAbsoluteRectForLayer):
        (WebCore::RenderObject::paintingRootRect):
        (WebCore::RenderObject::container):
        (WebCore::RenderObject::removeFromObjectLists):
        (WebCore::RenderObject::updateHitTestResult):
        (WebCore::RenderObject::addDashboardRegions):
        (WebCore::RenderObject::localTransform):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::isBox):
        (WebCore::RenderObject::hasMask):
        (WebCore::RenderObject::setIsText):
        (WebCore::RenderObject::setIsBox):
        (WebCore::RenderObject::borderTop):
        (WebCore::RenderObject::borderBottom):
        (WebCore::RenderObject::absoluteRects):
        (WebCore::RenderObject::collectAbsoluteLineBoxQuads):
        (WebCore::RenderObject::absoluteQuads):
        (WebCore::RenderObject::hasReflection):
        (WebCore::RenderObject::addFocusRingRects):
        (WebCore::RenderObject::absoluteOutlineBounds):
        * rendering/RenderPart.cpp:
        (WebCore::RenderPart::updateWidgetPosition):
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::layout):
        (WebCore::RenderPath::paint):
        (WebCore::RenderPath::absoluteOutlineBounds):
        * rendering/RenderPath.h:
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::layout):
        (WebCore::RenderReplaced::paint):
        (WebCore::RenderReplaced::shouldPaint):
        (WebCore::RenderReplaced::positionForCoordinates):
        (WebCore::RenderReplaced::localSelectionRect):
        (WebCore::RenderReplaced::adjustOverflowForBoxShadow):
        (WebCore::RenderReplaced::overflowRect):
        * rendering/RenderReplica.cpp:
        (WebCore::RenderReplica::layout):
        (WebCore::RenderReplica::calcPrefWidths):
        (WebCore::RenderReplica::paint):
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::paint):
        (WebCore::RenderSVGContainer::absoluteOutlineBounds):
        * rendering/RenderSVGContainer.h:
        (WebCore::RenderSVGContainer::width):
        (WebCore::RenderSVGContainer::height):
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::layout):
        * rendering/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::computeAbsoluteRectForRange):
        (WebCore::RenderSVGInlineText::positionForCoordinates):
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::layout):
        (WebCore::RenderSVGRoot::applyContentTransforms):
        (WebCore::RenderSVGRoot::paint):
        (WebCore::RenderSVGRoot::absoluteTransform):
        (WebCore::RenderSVGRoot::nodeAtPoint):
        * rendering/RenderSVGTSpan.cpp:
        (WebCore::RenderSVGTSpan::absoluteRects):
        (WebCore::RenderSVGTSpan::absoluteQuads):
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::layout):
        (WebCore::RenderSVGText::relativeBBox):
        * rendering/RenderSVGTextPath.cpp:
        (WebCore::RenderSVGTextPath::absoluteRects):
        (WebCore::RenderSVGTextPath::absoluteQuads):
        * rendering/RenderSVGViewportContainer.cpp:
        (WebCore::RenderSVGViewportContainer::nodeAtPoint):
        * rendering/RenderScrollbar.cpp:
        (WebCore::RenderScrollbar::createCustomScrollbar):
        (WebCore::RenderScrollbar::RenderScrollbar):
        (WebCore::RenderScrollbar::setParent):
        * rendering/RenderScrollbar.h:
        (WebCore::RenderScrollbar::owningRenderer):
        * rendering/RenderScrollbarPart.cpp:
        (WebCore::RenderScrollbarPart::layout):
        (WebCore::RenderScrollbarPart::layoutHorizontalPart):
        (WebCore::RenderScrollbarPart::layoutVerticalPart):
        (WebCore::RenderScrollbarPart::computeScrollbarWidth):
        (WebCore::RenderScrollbarPart::computeScrollbarHeight):
        (WebCore::RenderScrollbarPart::paintIntoRect):
        * rendering/RenderSlider.cpp:
        (WebCore::HTMLSliderThumbElement::defaultEventHandler):
        (WebCore::RenderSlider::layout):
        (WebCore::RenderSlider::mouseEventIsInThumb):
        (WebCore::RenderSlider::positionForOffset):
        (WebCore::RenderSlider::trackSize):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::calcWidth):
        (WebCore::RenderTable::layout):
        (WebCore::RenderTable::paint):
        (WebCore::RenderTable::getBaselineOfFirstLineBox):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::updateWidth):
        (WebCore::RenderTableCell::computeAbsoluteRepaintRect):
        (WebCore::RenderTableCell::localToAbsolute):
        (WebCore::RenderTableCell::absoluteToLocal):
        (WebCore::RenderTableCell::localToAbsoluteQuad):
        (WebCore::RenderTableCell::paint):
        (WebCore::RenderTableCell::paintBackgroundsBehindCell):
        * rendering/RenderTableCell.h:
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::addChild):
        (WebCore::RenderTableSection::addCell):
        (WebCore::RenderTableSection::setCellWidths):
        (WebCore::RenderTableSection::calcRowHeight):
        (WebCore::RenderTableSection::layoutRows):
        (WebCore::RenderTableSection::lowestPosition):
        (WebCore::RenderTableSection::rightmostPosition):
        (WebCore::RenderTableSection::leftmostPosition):
        (WebCore::RenderTableSection::getBaselineOfFirstLineBox):
        (WebCore::RenderTableSection::paint):
        (WebCore::RenderTableSection::recalcCells):
        (WebCore::RenderTableSection::nodeAtPoint):
        * rendering/RenderTableSection.h:
        (WebCore::RenderTableSection::overflowWidth):
        (WebCore::RenderTableSection::overflowHeight):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::RenderText):
        (WebCore::RenderText::boundingBoxX):
        (WebCore::RenderText::boundingBoxY):
        (WebCore::RenderText::firstRunX):
        (WebCore::RenderText::firstRunY):
        (WebCore::RenderText::boundingBoxHeight):
        (WebCore::RenderText::boundingBoxWidth):
        * rendering/RenderText.h:
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::textBlockHeight):
        (WebCore::RenderTextControl::textBlockWidth):
        (WebCore::RenderTextControl::setSelectionRange):
        (WebCore::RenderTextControl::calcHeight):
        (WebCore::RenderTextControl::hitInnerTextBlock):
        (WebCore::RenderTextControl::controlClipRect):
        * rendering/RenderTextControlMultiLine.cpp:
        (WebCore::RenderTextControlMultiLine::layout):
        (WebCore::RenderTextControlMultiLine::adjustControlHeightBasedOnLineHeight):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::paint):
        (WebCore::RenderTextControlSingleLine::layout):
        (WebCore::RenderTextControlSingleLine::nodeAtPoint):
        (WebCore::RenderTextControlSingleLine::forwardEvent):
        (WebCore::RenderTextControlSingleLine::textBlockWidth):
        (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight):
        (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
        (WebCore::RenderTextControlSingleLine::clientPaddingRight):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::hitTestMediaControlPart):
        (WebCore::RenderTheme::baselinePosition):
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
        (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
        (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
        (WebCore::RenderThemeMac::hitTestMediaControlPart):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::operator<<):
        * rendering/RenderVideo.cpp:
        (WebCore::RenderVideo::videoBox):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::RenderView):
        (WebCore::RenderView::calcHeight):
        (WebCore::RenderView::calcWidth):
        (WebCore::RenderView::layout):
        (WebCore::RenderView::viewRect):
        (WebCore::RenderView::docHeight):
        (WebCore::RenderView::docWidth):
        (WebCore::RenderView::setBestTruncatedAt):
        * rendering/RenderView.h:
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint):
        (WebCore::RenderWidget::updateWidgetPosition):
        (WebCore::RenderWidget::nodeAtPoint):
        * rendering/RootInlineBox.h:
        (WebCore::RootInlineBox::floats):
        (WebCore::RootInlineBox::floatsPtr):
        * rendering/SVGInlineFlowBox.cpp:
        (WebCore::SVGInlineFlowBox::verticallyAlignBoxes):
        * rendering/SVGInlineFlowBox.h:
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::operator<<):
        (WebCore::write):
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBox::verticallyAlignBoxes):
        (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
        (WebCore::SVGRootInlineBox::layoutInlineBoxes):
        * rendering/SVGRootInlineBox.h:
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::computeHorizontalPositionsForLine):
        (WebCore::RenderBlock::computeVerticalPositionsForLine):
        (WebCore::RenderBlock::layoutInlineChildren):
        (WebCore::RenderBlock::determineStartPosition):
        (WebCore::RenderBlock::matchedEndLine):
        (WebCore::RenderBlock::skipTrailingWhitespace):
        (WebCore::RenderBlock::skipLeadingWhitespace):
        (WebCore::RenderBlock::fitBelowFloats):
        (WebCore::RenderBlock::findNextLineBreak):
        (WebCore::RenderBlock::checkLinesForOverflow):
        * svg/SVGLength.cpp:
        (WebCore::SVGLength::PercentageOfViewport):

WebKit/mac:

2009-01-21  David Hyatt  <hyatt@apple.com>

        Devirtualize width/height/x/y on RenderObject and move the methods to RenderBox.

        Reviewed by Eric Seidel and Darin Adler

        * WebView/WebRenderNode.mm:
        (copyRenderNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-21 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 22 Jan 2009 01:39:57 +0000 (01:39 +0000)]
2009-01-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        More browser->plug-in scripting support.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCNPObjectHasPropertyReply):
        (WKPCNPObjectHasMethodReply):
        (WKPCNPObjectInvokeReply):
        MIG reply functions.

        (WKPCIdentifierInfo):
        Return information about an identifier given its 64-bit value.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        Add new reply structs.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::addValueToArray):
        Split out code that adds values to the arrays from marshalValue.

        (WebKit::NetscapePluginInstanceProxy::marshalValue):
        Call addValueToArray.

        (WebKit::NetscapePluginInstanceProxy::marshalValues):
        Marshal a list of values.

        (WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
        Actually create a proxy instance.

        * Plugins/Hosted/ProxyInstance.h:
        * Plugins/Hosted/ProxyInstance.mm:
        (WebKit::ProxyClass::methodsNamed):
        (WebKit::ProxyClass::fieldNamed):
        Add a proxy ProxyClass class that just forwards everything to the ProxyInstance class.

        (WebKit::proxyClass):
        Shared proxyClass getter.

        (WebKit::ProxyField::ProxyField):
        (WebKit::ProxyField::valueFromInstance):
        (WebKit::ProxyField::setValueToInstance):
        Add a proxy ProxyField class that just forwards everything to the ProxyInstance class.

        (WebKit::ProxyMethod::ProxyMethod):
        (WebKit::ProxyMethod::serverIdentifier):
        (WebKit::ProxyMethod::numParameters):
        Add a dummy ProxyMethod class.

        (WebKit::ProxyInstance::invokeMethod):
        Call _WKPHNPObjectInvoke.

        (WebKit::ProxyInstance::defaultValue):
        (WebKit::ProxyInstance::stringValue):
        (WebKit::ProxyInstance::numberValue):
        (WebKit::ProxyInstance::booleanValue):
        (WebKit::ProxyInstance::valueOf):
        Add dummy implementations (taken from CInstance).

        (WebKit::ProxyInstance::methodsNamed):
        Call _WKPHNPObjectHasMethod to determine whether a method with the given name exists.

        (WebKit::ProxyInstance::fieldNamed):
        Call _WKPHNPObjectHasProperty to determine whether a property with the given name exists.

        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHost.defs:
        Add new MIG definitions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-21 Pierre-Olivier Latour <pol@apple.com>
pol@apple.com [Thu, 22 Jan 2009 01:39:19 +0000 (01:39 +0000)]
2009-01-21  Pierre-Olivier Latour  <pol@apple.com>

        Tweaked earlier fix to only print a warning when Perian is installed,
        and fail completely only if attempting to generate new pixel test results.

        https://bugs.webkit.org/show_bug.cgi?id=23392

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-21 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 22 Jan 2009 00:50:44 +0000 (00:50 +0000)]
2009-01-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        * WebCore.LP64.exp:
        Add some bridge related symbols.

        * WebCore.xcodeproj/project.pbxproj:
        Make runtime_object.h a private header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 22720: Make XMLHttpRequest work in Workers
oliver@apple.com [Thu, 22 Jan 2009 00:22:45 +0000 (00:22 +0000)]
Bug 22720: Make XMLHttpRequest work in Workers
<https://bugs.webkit.org/show_bug.cgi?id=22720>

Contributed by David Levin.

Reviewed by Alexey Proskuryakov

More removal of document usage from XMLHttpRequest.
* Abstracted away the sync and async requests behind the ThreadableLoader class, which
  will get an implementation for Workers.  It follows the same model as SubresourceLoader, since
  it is a thin wrapper around it.
* Consolidated dashboard compatibility checks into usesDashboardBackwardCompatibilityMode
  which handles workers.

No observable change in behavior, so no test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix for https://bugs.webkit.org/show_bug.cgi?id=23317
cmarrin@apple.com [Thu, 22 Jan 2009 00:13:31 +0000 (00:13 +0000)]
    Fix for https://bugs.webkit.org/show_bug.cgi?id=23317

        The high CPU usage was really from repeatedly firing transitions caused
        by a bug in the way we handle background-color animations. If animating
        from a valid background color to no background color, we sometimes left
        (based on timing) the background color as transparent black, but valid
        rather than invalid, which it should be. Fixing that got rid of the
        repeated firing.

        But we really were doing more expensive iteration of all objects with
        animations or transitions on them (running or not). So I added two
        optimizations to quickly short circuit when an object had no running
        animations or transitions. Things are now as zippy as ever.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Justin Garcia.
eric@webkit.org [Wed, 21 Jan 2009 23:37:08 +0000 (23:37 +0000)]
    Reviewed by Justin Garcia.

        Remove the style='' turds left by some editing commands
        https://bugs.webkit.org/show_bug.cgi?id=23463

        Test: editing/execCommand/toggle-styles.html

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::removeCSSStyle): check if we just removed the last CSS property and remove the style attribute as well
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::removeNodeAttribute): remove extra ;

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoClean up how we force invocations of API that happened on background threads over...
mrowe@apple.com [Wed, 21 Jan 2009 23:25:36 +0000 (23:25 +0000)]
Clean up how we force invocations of API that happened on background threads over to the main thread.

This was previously accomplished in a somewhat ad-hoc manner using a mutable dictionary to pass arguments
and return values back from the function.  The new approach is to use a proxy object that forwards an
NSInvocation over to the main thread and applies it to the target object, which leads to a much cleaner
call site.

Reviewed by Tim Hatcher.

* Misc/WebNSObjectExtras.h:
* Misc/WebNSObjectExtras.mm:
(-[WebMainThreadInvoker initWithTarget:]):
(-[WebMainThreadInvoker forwardInvocation:]):
(-[WebMainThreadInvoker methodSignatureForSelector:]):
(-[WebMainThreadInvoker handleException:]):
(-[NSInvocation _webkit_invokeAndHandleException:]): Execute the invocation and forward any exception that was
raised back to the WebMainThreadInvoker.
(-[NSObject _webkit_invokeOnMainThread]):

The following methods are updated to use the proxy object to forward methods to the main thread:

* WebView/WebArchive.mm:
(-[WebArchive initWithMainResource:subresources:subframeArchives:]):
(-[WebArchive mainResource]):
(-[WebArchive subresources]):
(-[WebArchive subframeArchives]):
* WebView/WebResource.mm:
(-[WebResource data]):
(-[WebResource URL]):
(-[WebResource MIMEType]):
(-[WebResource textEncodingName]):
(-[WebResource frameName]):
(-[WebResource _ignoreWhenUnarchiving]):
(-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
(-[WebResource _initWithData:URL:response:]):
(-[WebResource _suggestedFilename]):
(-[WebResource _response]):
(-[WebResource _stringValue]):
* WebView/WebView.mm:
(-[WebView initWithFrame:frameName:groupName:]):
(-[WebView initWithCoder:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago No review, build fix.
eric@webkit.org [Wed, 21 Jan 2009 23:20:31 +0000 (23:20 +0000)]
    No review, build fix.

        Fix release-only build failure (and do a tiny code-cleanup).

        * editing/ApplyStyleCommand.cpp:
        (WebCore::createFontElement):
        (WebCore::createStyleSpanElement):
        (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 23443: Table accessibility should be re-enabled after fixing crash that occurs...
cfleizach@apple.com [Wed, 21 Jan 2009 22:55:01 +0000 (22:55 +0000)]
Bug 23443: Table accessibility should be re-enabled after fixing crash that occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when attempting to create a link in a rich text message
https://bugs.webkit.org/show_bug.cgi?id=23443

Re-enable Accessibility tables and make sure accessibility code does not interrogate the render tree
during render tree updates

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Justin Garcia.
eric@webkit.org [Wed, 21 Jan 2009 22:16:37 +0000 (22:16 +0000)]
    Reviewed by Justin Garcia.

        Fix execCommand() 'super' and 'sub' commands to add <sup> and <sub> in quirks mode, and to toggle when called twice
        https://bugs.webkit.org/show_bug.cgi?id=17733

        Test changed: editing/execCommand/toggle-styles-expected.txt

        * editing/ApplyStyleCommand.cpp:
        (WebCore::StyleChange::applySubscript):
        (WebCore::StyleChange::applySuperscript):
        (WebCore::StyleChange::StyleChange):
        (WebCore::StyleChange::init):
        (WebCore::StyleChange::checkForLegacyHTMLStyleChange):
        (WebCore::ApplyStyleCommand::isHTMLStyleNode):
        (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
        * editing/EditorCommand.cpp:
        (WebCore::executeSubscript):
        (WebCore::executeSuperscript):
        * editing/htmlediting.cpp:
        (WebCore::createHTMLElement):
        * editing/htmlediting.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-21 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 21 Jan 2009 21:52:16 +0000 (21:52 +0000)]
2009-01-21  Anders Carlsson  <andersca@apple.com>

        Fix 64-bit build.

        * WebCore.LP64.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 23458: Reintroduce CanvasPixelArray in ImageData.idl
oliver@apple.com [Wed, 21 Jan 2009 21:05:46 +0000 (21:05 +0000)]
Bug 23458: Reintroduce CanvasPixelArray in ImageData.idl
<https://bugs.webkit.org/show_bug.cgi?id=23458>

Reviewed by Alexey Proskuryakov.

Return CanvasPixelArray, et al -- the only difference between this
and the original CPA implementation is that it now uses a ByteArray
rather than a vector.  JSC still uses a custom wrapper, but this allows
ObjC, COM, and V8 bindings to be autogenerated again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-21 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Wed, 21 Jan 2009 20:07:07 +0000 (20:07 +0000)]
2009-01-21  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Remove last relics of platform dependent PaintServer in SVG.
        We draw everything with the help of GraphicsContext.

        Remove SVGPaintServerPlatform's
        [https://bugs.webkit.org/show_bug.cgi?id=23439]

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * svg/graphics/SVGPaintServer.cpp:
        (WebCore::SVGPaintServer::draw):
        (WebCore::SVGPaintServer::renderPath):
        (WebCore::SVGPaintServer::teardown):
        * svg/graphics/SVGPaintServer.h:
        * svg/graphics/SVGPaintServerGradient.cpp:
        * svg/graphics/SVGPaintServerGradient.h:
        * svg/graphics/SVGPaintServerPattern.cpp:
        * svg/graphics/SVGPaintServerPattern.h:
        * svg/graphics/SVGPaintServerSolid.cpp:
        * svg/graphics/SVGPaintServerSolid.h:
        * svg/graphics/cairo/SVGPaintServerCairo.cpp: Removed.
        * svg/graphics/cg/SVGPaintServerCg.cpp: Removed.
        * svg/graphics/qt/SVGPaintServerQt.cpp: Removed.
        * svg/graphics/skia/SVGPaintServerSkia.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Alexey Proskuryakov.
zimmermann@webkit.org [Wed, 21 Jan 2009 19:49:37 +0000 (19:49 +0000)]
Reviewed by Alexey Proskuryakov.

Move "Element -> ScriptElement" casting functionality into ScriptElement.h
to be consistent with FormControlElement/InputElement/OptionElement/OptionGroupElement.

It was living in XMLTokenizer before, which is not an obvious place for this.
TODO: Rename 'formControlElementForElement' to 'toFormControlElement' (analogous changes for InputElement etc.)
      as suggested by Alexey, it really reads better this way.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Suggested by Oliver Hunt. Reviewed by Oliver Hunt.
ap@webkit.org [Wed, 21 Jan 2009 18:09:40 +0000 (18:09 +0000)]
    Suggested by Oliver Hunt. Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=23456
        Function argument names leak

        * parser/Nodes.cpp: (JSC::FunctionBodyNode::~FunctionBodyNode): Destruct parameter names.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by George Staikos.
zimmermann@webkit.org [Wed, 21 Jan 2009 16:44:25 +0000 (16:44 +0000)]
Reviewed by George Staikos.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=23444

Refactor some functionality from HTMLOption/OptGroupElement needed by RenderListBox/RenderMenuList
in two abstract base classes: OptionElement & OptionGroupElement living in dom/ - just like it
has been done before for FormControlElement and RenderTextControl.

This is needed to prepare the addtion of WMLOption/OptGroupElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 21 Jan 2009 07:39:02 +0000 (07:39 +0000)]
2009-01-20  Darin Adler  <darin@apple.com>

        Reviewed by Alexey Proskuryakov.

        Bug 23448: memory leak in Mac version of preferredExtensionForImageSourceType
        https://bugs.webkit.org/show_bug.cgi?id=23448

        * platform/graphics/cg/ImageSourceCGMac.mm:
        (WebCore::preferredExtensionForImageSourceType): Use RetainPtr to avoid the leak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 21 Jan 2009 07:25:08 +0000 (07:25 +0000)]
2009-01-20  Darin Adler  <darin@apple.com>

        Reviewed by Alexey Proskuryakov.

        Bug 23450: string leaks seen in DumpRenderTree accessibility test code
        https://bugs.webkit.org/show_bug.cgi?id=23450

        * DumpRenderTree/AccessibilityUIElement.cpp:
        (isAttributeSettableCallback): Add the missing JSStringRelease call.
        (attributeValueCallback): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 21 Jan 2009 06:38:55 +0000 (06:38 +0000)]
2009-01-20  Darin Adler  <darin@apple.com>

        Try to fix Wx build.

        * platform/wx/PasteboardWx.cpp:
        (WebCore::Pasteboard::writeSelection): Removed code that replaces backslash
        with backslashAsCurrencySymbol. I'm pretty sure this is not needed when writing
        to the clipboard. Other platforms don't do it. If it was needed, the new function
        to use would be displayStringModifiedByEncoding.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTeach Cairo post-build stage to copy animation headers.
bfulgham@webkit.org [Wed, 21 Jan 2009 05:28:57 +0000 (05:28 +0000)]
Teach Cairo post-build stage to copy animation headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Dmitry Titov <dimich@chromium.org>
alp@webkit.org [Wed, 21 Jan 2009 04:49:50 +0000 (04:49 +0000)]
2009-01-20  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=23413
        Remove unused WebCore::setDeferringTimers()

        * platform/Timer.cpp:
        (WebCore::updateSharedTimer):
        * platform/Timer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix
oliver@apple.com [Wed, 21 Jan 2009 03:51:15 +0000 (03:51 +0000)]
Windows build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 21 Jan 2009 03:19:50 +0000 (03:19 +0000)]
2009-01-20  David Hyatt  <hyatt@apple.com>

        Tighten up the type of RenderObject owned by RenderLayer to be a RenderBox.  Rename m_object to
        m_renderer to be consistent with the corresponding member function.

        Reviewed by Jon Honeycutt

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::RenderLayer):
        (WebCore::RenderLayer::updateLayerPositions):
        (WebCore::RenderLayer::updateVisibilityStatus):
        (WebCore::RenderLayer::updateLayerPosition):
        (WebCore::RenderLayer::stackingContext):
        (WebCore::RenderLayer::enclosingPositionedAncestor):
        (WebCore::RenderLayer::enclosingTransformedAncestor):
        (WebCore::RenderLayer::isTransparent):
        (WebCore::RenderLayer::convertToLayerCoords):
        (WebCore::RenderLayer::scrollByRecursively):
        (WebCore::RenderLayer::scrollToOffset):
        (WebCore::RenderLayer::scrollRectToVisible):
        (WebCore::RenderLayer::resize):
        (WebCore::RenderLayer::scrollbarCornerPresent):
        (WebCore::RenderLayer::createScrollbar):
        (WebCore::RenderLayer::setHasHorizontalScrollbar):
        (WebCore::RenderLayer::setHasVerticalScrollbar):
        (WebCore::RenderLayer::positionOverflowControls):
        (WebCore::RenderLayer::computeScrollDimensions):
        (WebCore::RenderLayer::updateOverflowStatus):
        (WebCore::RenderLayer::updateScrollInfoAfterLayout):
        (WebCore::RenderLayer::paintOverflowControls):
        (WebCore::RenderLayer::paintScrollCorner):
        (WebCore::RenderLayer::paintResizer):
        (WebCore::RenderLayer::isPointInResizeControl):
        (WebCore::RenderLayer::paintLayer):
        (WebCore::RenderLayer::hitTestLayer):
        (WebCore::RenderLayer::updateClipRects):
        (WebCore::RenderLayer::calculateClipRects):
        (WebCore::RenderLayer::calculateRects):
        (WebCore::RenderLayer::clearClipRects):
        (WebCore::RenderLayer::repaintIncludingDescendants):
        (WebCore::RenderLayer::styleChanged):
        (WebCore::RenderLayer::updateScrollCornerStyle):
        (WebCore::RenderLayer::updateResizerStyle):
        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::renderer):
        (WebCore::RenderLayer::hasReflection):
        (WebCore::RenderLayer::hasTransform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 21 Jan 2009 01:59:22 +0000 (01:59 +0000)]
2009-01-20  David Hyatt  <hyatt@apple.com>

        Fix Mac build bustage from my selection changes.  I forgot to implement the functions on RenderThemeMac
        for returning the appropriate listbox selection colors.

        Reviewed by Adele

        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::platformActiveListBoxSelectionForegroundColor):
        (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor):
        (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Wed, 21 Jan 2009 01:53:11 +0000 (01:53 +0000)]
2009-01-20  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Mark Rowe.

        Structure property table deleted offset maps are being leaked.
        Probably shouldn't be doing that.

        https://bugs.webkit.org/show_bug.cgi?id=23442

        * runtime/Structure.cpp:
        (JSC::Structure::~Structure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Pierre-Olivier Latour <pol@apple.com>
pol@apple.com [Wed, 21 Jan 2009 00:30:39 +0000 (00:30 +0000)]
2009-01-20  Pierre-Olivier Latour  <pol@apple.com>

        Reviewed by Darin Adler.

        Print warning regarding display color profile change in run-webkit-tests instead of DRT.

        https://bugs.webkit.org/show_bug.cgi?id=23392

        * DumpRenderTree/mac/PixelDumpSupportMac.mm:
        (setupMainDisplayColorProfile):
        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix selection colors and focus rings on Windows.
hyatt@apple.com [Tue, 20 Jan 2009 23:31:34 +0000 (23:31 +0000)]
Fix selection colors and focus rings on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Pierre-Olivier Latour <pol@apple.com>
pol@apple.com [Tue, 20 Jan 2009 23:25:15 +0000 (23:25 +0000)]
2009-01-20  Pierre-Olivier Latour  <pol@apple.com>

        Reviewed by Darin Adler.

        Changed run-webkit-tests to abort on the Mac if pixel tests are enabled and Perian is installed,
        in order to avoid result differences in some media tests.

        https://bugs.webkit.org/show_bug.cgi?id=22615

        * Scripts/run-webkit-tests:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAttempt to fix gtk build
oliver@apple.com [Tue, 20 Jan 2009 22:35:33 +0000 (22:35 +0000)]
Attempt to fix gtk build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by George Staikos.
zimmermann@webkit.org [Tue, 20 Jan 2009 22:29:09 +0000 (22:29 +0000)]
Reviewed by George Staikos.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=23434

Add WML <input> element support - it required a lot of changes to the RenderText*/HTMLInput* code.
Now any language can provide <input>-style elements, without having to inherit from HTML* classes.

No WML specific features/attributes are handled so far. A follow-up patch will provide those bits.
Added very simple fast/wml/input.wml, just checking that input elements can be rendered properly now.
Detailed testcases will follow in conjunction with the WML specific attribute support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 20 Jan 2009 21:54:40 +0000 (21:54 +0000)]
2009-01-20  Darin Adler  <darin@apple.com>

        Reviewed by John Sullivan.

        Remove a little dead code left over after the fix for
        https://bugs.webkit.org/show_bug.cgi?id=11395, which
        moved pointer-events from SVG to be shared with HTML.

        * css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGValue): Remove SVG's parsing of this
        property since it's handled in the non-SVG function now so we'll
        never get here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago009-01-20 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Tue, 20 Jan 2009 21:54:25 +0000 (21:54 +0000)]
009-01-20  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Darin Adler.

        Bug 23438: Provide a default value to the .in file parser

        Added the default value 1 as it simplifies some of
        the format by removing some "=1" that were awkward.

        This was suggested by Darin Adler as par of a previous
        review.

        * bindings/scripts/InFilesParser.pm: When no value
        was entered (the second part of the split is undef),
        provide the default value.

        * html/HTMLAttributeNames.in: Removed unnecessary "=1".
        * html/HTMLTagNames.in: Ditto.
        * svg/svgattrs.in: Ditto.
        * svg/svgtags.in: Ditto.
        * svg/xlinkattrs.in: Ditto.
        * wml/WMLAttributeNames.in: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 20 Jan 2009 21:41:36 +0000 (21:41 +0000)]
2009-01-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        * bridge/c/c_class.cpp:
        * bridge/c/c_class.h:
        Get rid of CClass::name().

        * bridge/jni/jni_class.h:
        Get rid of JavaClass::name().

        * bridge/objc/objc_class.h:
        * bridge/objc/objc_class.mm:
        Get rid of ObjcClass::name().

        * bridge/objc/objc_instance.h:
        Get rid of supportsSetValueOfUndefinedField.

        * bridge/objc/objc_instance.mm:
        (ObjcInstance::setValueOfUndefinedField):
        Fold supportsSetValueOfUndefinedField into setValueOfUndefinedField.

        * bridge/runtime.cpp:
        Get rid of getValueOfField and setValueOfField.

        * bridge/runtime.h:
        (JSC::Bindings::Instance::setValueOfUndefinedField):
        Have this return a bool and get rid of supportsSetValueOfUndefinedField

        * bridge/runtime_object.cpp:
        (JSC::RuntimeObjectImp::fieldGetter):
        Call Field::valueFromInstance on the field.

        (JSC::RuntimeObjectImp::put):
        Call Field::setValueToInstance on the field.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Forgot to land build changes for non-mac platforms.
zimmermann@webkit.org [Tue, 20 Jan 2009 21:29:37 +0000 (21:29 +0000)]
Not reviewed. Forgot to land build changes for non-mac platforms.
Add InputElement.cpp & FormControlElement.cpp to build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Adam Roben.
zimmermann@webkit.org [Tue, 20 Jan 2009 21:18:19 +0000 (21:18 +0000)]
Reviewed by Adam Roben.

Fix last-minute regression, introduced by simplifying max length determination - by
clamping using min/max, negative maxLength values got broken.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Adam Roben.
zimmermann@webkit.org [Tue, 20 Jan 2009 21:02:58 +0000 (21:02 +0000)]
Reviewed by Adam Roben.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=23433

Add InputElement abstraction, similar to the FormControlElement refactorization
done a month ago. The goal is to share as much code as possible between HTML/WMLInputElement.
In a previous patch the RenderTextControl class has been split-up in RenderTextControlSingle/MultiLine,
RenderTextControl itself only depends on FormControlElement, RenderTextControlSingleLine still
depends on HTMLInputElement directly -> change that and make it use the new InputElement abstraction.

A lot of code from HTMLInputElement now lives in InputElement, as static member functions - the
InputElement class itself is an abstract virtual class, just like ScriptElement. HTML/WMLInputElement
derive from InputElement, and hold a InputElementData member variable, that they pass to the
static functions in InputElement. The abstraction is equal to the one chosen for HTML/SVGScriptElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Pierre-Olivier Latour <pol@apple.com>
pol@apple.com [Tue, 20 Jan 2009 20:54:55 +0000 (20:54 +0000)]
2009-01-20  Pierre-Olivier Latour  <pol@apple.com>

        Previously uploaded reference images were generated with Perian installed, which affected them
        as explained in https://bugs.webkit.org/show_bug.cgi?id=22615.

        * platform/mac/media/video-zoom-expected.checksum:
        * platform/mac/media/video-zoom-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Tue, 20 Jan 2009 19:52:10 +0000 (19:52 +0000)]
2009-01-20  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Make SVG pattern platform independent and remove platform code.

        Make SVGPattern platform independent
        https://bugs.webkit.org/show_bug.cgi?id=21205

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::applyStrokePattern):
        (WebCore::GraphicsContext::applyFillPattern):
        (WebCore::GraphicsContext::drawPath):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::strokeRect):
        * svg/graphics/SVGPaintServerPattern.cpp:
        (WebCore::SVGPaintServerPattern::SVGPaintServerPattern):
        (WebCore::SVGPaintServerPattern::~SVGPaintServerPattern):
        (WebCore::SVGPaintServerPattern::setup):
        (WebCore::SVGPaintServerPattern::renderPath):
        (WebCore::SVGPaintServerPattern::teardown):
        * svg/graphics/SVGPaintServerPattern.h:
        * svg/graphics/cairo/SVGPaintServerPatternCairo.cpp: Removed.
        * svg/graphics/cg/SVGPaintServerPatternCg.cpp: Removed.
        * svg/graphics/qt/SVGPaintServerPatternQt.cpp: Removed.
        * svg/graphics/skia/SVGPaintServerPatternSkia.cpp: Removed.

        LayoutTests:

        stroke-pattern is wrong and coords-units-01-b match the behavior of
        batik and Firefox.

        * platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
        * platform/mac/svg/custom/stroked-pattern-expected.checksum:
        * platform/mac/svg/custom/stroked-pattern-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 20 Jan 2009 19:39:14 +0000 (19:39 +0000)]
2009-01-20  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23436
        Upstream rendering/RenderThemeChromium*

        * rendering/RenderThemeChromiumGtk.cpp: Added.
        * rendering/RenderThemeChromiumGtk.h: Added.
        * rendering/RenderThemeChromiumMac.h: Added.
        * rendering/RenderThemeChromiumMac.mm: Added.
        * rendering/RenderThemeChromiumWin.cpp: Added.
        * rendering/RenderThemeChromiumWin.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit:
andersca@apple.com [Tue, 20 Jan 2009 19:33:48 +0000 (19:33 +0000)]
WebKit:

2009-01-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add ProxyInstance files.

        * WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-01-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add and implement GetScriptableNPObject.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCGetScriptableNPObjectReply):
        Create a new reply struct and set it as the current reply.

        (WKPCEvaluate):
        Get rid of an unused variable.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        (WebKit::NetscapePluginInstanceProxy::Reply::):
        (WebKit::NetscapePluginInstanceProxy::GetScriptableNPObjectReply::GetScriptableNPObjectReply):
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
        Call _WKPHGetScriptableNPObject and wait for a reply.

        * Plugins/Hosted/ProxyInstance.h: Added.
        * Plugins/Hosted/ProxyInstance.mm: Added.
        Add empty files.

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView JSC::Bindings::createPluginBindingsInstance:JSC::Bindings::]):
        Call NetscapePluginInstanceProxy::createBindingsInstance.

        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHost.defs:
        Add new declarations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-20 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 20 Jan 2009 18:38:58 +0000 (18:38 +0000)]
2009-01-20  Darin Adler  <darin@apple.com>

        * runtime/StringPrototype.cpp:
        (JSC::substituteBackreferences): Add back the initialization to fix the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40060 268f45cc-cd09-0410-ab3c-d52691b4dbfc