WebKit-https.git
5 years agoFixed a typo in the change log.
mitz@apple.com [Mon, 25 Nov 2013 20:53:27 +0000 (20:53 +0000)]
Fixed a typo in the change log.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Cocoa] Put most of the Cocoa API behind WK_API_ENABLED guards
mitz@apple.com [Mon, 25 Nov 2013 20:52:04 +0000 (20:52 +0000)]
[Cocoa] Put most of the Cocoa API behind WK_API_ENABLED guards
https://bugs.webkit.org/show_bug.cgi?id=124850

Reviewed by Brady Eidson.

Source/WebKit2:

Guarded all Cocoa API headers and implementatiosn with WK_API_ENABLED. Left the WKView class
unguarded, but limited its API.

* Shared/API/Cocoa/WKFoundation.h: Replaced OBJ_VISIBLE with an explicit attribute.
* Shared/API/Cocoa/WKRemoteObjectCoder.mm: Moved #if WK_API_ENABLED before the rest of the
imports.
* Shared/API/Cocoa/WKRemoteObjectInterface.mm: Ditto.
* Shared/API/Cocoa/WKRemoteObjectRegistry.mm: Ditto.
* Shared/API/Cocoa/WKRemoteObjectRegistryPrivate.h: Ditto.
* UIProcess/API/mac/WKBrowsingContextController.h: Guarded all declarations with
WK_API_ENABLED, changed to use WK_API_CLASS instead of WK_EXPORT.
* UIProcess/API/mac/WKBrowsingContextController.mm: Guarded everything with WK_API_ENABLED.
(-[WKBrowsingContextController dealloc]):
(-[WKBrowsingContextController setPolicyDelegate:]):
(-[WKBrowsingContextController backForwardList]):
(didChangeBackForwardList):
(setUpPageLoaderClient):
(setUpPagePolicyClient):
(-[WKBrowsingContextController _initWithPageRef:]):
* UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Ditto.
* UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Ditto.
* UIProcess/API/mac/WKBrowsingContextGroup.h: Guarded all declarations with WK_API_ENABLED,
chanegd to use WK_API_CLASS instead of WK_EXPORT.
* UIProcess/API/mac/WKBrowsingContextGroup.mm: Removed redundant import, guarded everything
with WK_API_ENABLED.
* UIProcess/API/mac/WKBrowsingContextGroupPrivate.h: Guarded with WK_API_ENABLED.
* UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h: Added necessary import.
* UIProcess/API/mac/WKConnection.h: Guarded all declarations with WK_API_ENABLED, chanegd to
use WK_API_CLASS instead of WK_EXPORT.
* UIProcess/API/mac/WKConnection.mm: Guarded everything with WK_API_ENABLED.
(-[WKConnection remoteObjectRegistry]):
(didReceiveMessage):
* UIProcess/API/mac/WKConnectionInternal.h: Guarded the delcarations with WK_API_ENABLED.
* UIProcess/API/mac/WKProcessGroup.h: Ditto. Also changed to use WK_API_CLASS instead of
WK_EXPORT.
* UIProcess/API/mac/WKProcessGroup.mm: Guarded everything with WK_API_ENABLED.
(-[WKProcessGroup initWithInjectedBundleURL:]):
* UIProcess/API/mac/WKProcessGroupPrivate.h: Guarded the declarations with WK_API_ENABLED.
* UIProcess/API/mac/WKTypeRefWrapper.h: Moved #if WK_API_ENABLED before the rest of the
imports, changed to use WK_API_CLASS instead of WK_EXPORT.
* UIProcess/API/mac/WKTypeRefWrapper.mm: Removed empty line after #import "config.h".
* UIProcess/API/mac/WKView.h: Added #if WK_API_ENABLED around API that uses other Cocoa API
types.
* UIProcess/API/mac/WKView.mm: Added #if WK_API_ENABLED around implementations of methods
that are only declared when the API is enabled.
* UIProcess/API/mac/WKViewInternal.h: Reordered imports.
* UIProcess/mac/WKFullScreenWindowController.mm: Added comment to #endif.
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess): Guarded use of
WKBrowsingContextController with WK_API_ENABLED.
(WebKit::WebContext::platformInitializeNetworkProcess): Ditto.
* UIProcess/mac/WebContextMenuProxyMac.mm: Removed newline between imports.
* WebProcess/InjectedBundle/API/mac/WKDOMDocument.h: Moved #if WK_API_ENABLED before the
rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.
* WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm: Removed newline after #import
"config.h".
* WebProcess/InjectedBundle/API/mac/WKDOMElement.h: Moved #if WK_API_ENABLED before the
rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.
* WebProcess/InjectedBundle/API/mac/WKDOMElement.mm: Removed newline after #import
"config.h".
* WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm: Ditto.
* WebProcess/InjectedBundle/API/mac/WKDOMNode.h: Moved #if WK_API_ENABLED before the
rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.
* WebProcess/InjectedBundle/API/mac/WKDOMNode.mm: Removed redundant import.
* WebProcess/InjectedBundle/API/mac/WKDOMRange.h:  Moved #if WK_API_ENABLED before the
rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.
* WebProcess/InjectedBundle/API/mac/WKDOMRange.mm: Removed newline and redundant import.
* WebProcess/InjectedBundle/API/mac/WKDOMText.h: Moved #if WK_API_ENABLED before the
rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.
* WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.h: Ditto.
* WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.mm: Removed newline after
#import "config.h".
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h: Moved #if WK_API_ENABLED before
the rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm: Removed newline and redundant
imports.
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.h:  Moved #if
WK_API_ENABLED before the rest of the imports, and changed to use WK_API_CLASS instead of
WK_EXPORT.
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm: Removed
newline after #import "config.h".

Tools:

Added #if WK_API_ENABLED guards around tests that use the Objective-C API.

* TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
* TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
* TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
* TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
* TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
* TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
* TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSet the svn:ignore property on the Xcode project to ignore the workspace and user...
mitz@apple.com [Mon, 25 Nov 2013 19:10:18 +0000 (19:10 +0000)]
Set the svn:ignore property on the Xcode project to ignore the workspace and user data.

* WebInspectorUI.xcodeproj: Added property svn:ignore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove code now unnecessary after r159575
robert@webkit.org [Mon, 25 Nov 2013 18:50:36 +0000 (18:50 +0000)]
Remove code now unnecessary after r159575
https://bugs.webkit.org/show_bug.cgi?id=124809

Reviewed by Antti Koivisto.

Covered by existing tests fast/block/margin-collapse/self-collapsing-block-with-float*

* rendering/line/LineBreaker.cpp:
(WebCore::LineBreaker::skipLeadingWhitespace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd complex line layout path version of empty-clear-blocks.html
robert@webkit.org [Mon, 25 Nov 2013 18:46:51 +0000 (18:46 +0000)]
Add complex line layout path version of empty-clear-blocks.html
https://bugs.webkit.org/show_bug.cgi?id=124808

Reviewed by Sam Weinig.

* fast/block/margin-collapse/empty-clear-blocks-complex-expected.html: Added.
* fast/block/margin-collapse/empty-clear-blocks-complex.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r159752 and r159754.
commit-queue@webkit.org [Mon, 25 Nov 2013 18:41:13 +0000 (18:41 +0000)]
Unreviewed, rolling out r159752 and r159754.
http://trac.webkit.org/changeset/159752
http://trac.webkit.org/changeset/159754
https://bugs.webkit.org/show_bug.cgi?id=124847

Broke linux test bots. (Requested by mhahnenberg on #webkit).

* Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
* Scripts/run-javascriptcore-tests:
* Scripts/run-jsc-stress-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoVertical border spacing is doubled between table row groups
ossy@webkit.org [Mon, 25 Nov 2013 18:24:56 +0000 (18:24 +0000)]
Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.

Rebaseline the rest of EFL and GTK tests.

* platform/efl/tables/mozilla/bugs/bug10296-1-expected.txt:
* platform/efl/tables/mozilla/bugs/bug26178-expected.txt:
* platform/efl/tables/mozilla/bugs/bug27038-1-expected.txt:
* platform/efl/tables/mozilla/bugs/bug278385-expected.txt:
* platform/efl/tables/mozilla/bugs/bug55789-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
* platform/efl/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
* platform/efl/tables/mozilla_expected_failures/core/captions1-expected.txt:
* platform/efl/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
* platform/efl/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
* platform/efl/tables/mozilla_expected_failures/other/test4-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_valign_bottom-expected.png:
* platform/gtk/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_valign_bottom-expected.png:
* platform/gtk/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFollowup fix after r159752
mhahnenberg@apple.com [Mon, 25 Nov 2013 18:02:58 +0000 (18:02 +0000)]
Followup fix after r159752

* Scripts/run-jsc-stress-tests: We need to handle Release builds too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoVertical border spacing is doubled between table row groups
ossy@webkit.org [Mon, 25 Nov 2013 17:34:35 +0000 (17:34 +0000)]
Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.

Rebaseline efl tests (+mac corrections).

* platform/efl/fast/forms/input-align-expected.png:
* platform/efl/fast/forms/input-align-expected.txt:
* platform/efl/fast/forms/input-value-expected.png:
* platform/efl/fast/forms/input-value-expected.txt:
* platform/efl/fast/table/border-collapsing/004-vertical-expected.png:
* platform/efl/fast/table/border-collapsing/004-vertical-expected.txt:
* platform/efl/fast/table/floating-th-expected.png:
* platform/efl/fast/table/floating-th-expected.txt:
* platform/efl/fast/table/frame-and-rules-expected.png:
* platform/efl/fast/table/frame-and-rules-expected.txt:
* platform/efl/fast/table/multiple-captions-display-expected.png:
* platform/efl/fast/table/multiple-captions-display-expected.txt:
* platform/efl/fast/table/rowindex-expected.png:
* platform/efl/fast/table/rowindex-expected.txt:
* platform/efl/fast/table/table-display-types-expected.png:
* platform/efl/fast/table/table-display-types-expected.txt:
* platform/efl/fast/table/table-display-types-strict-expected.png:
* platform/efl/fast/table/table-display-types-strict-expected.txt:
* platform/efl/fast/table/table-display-types-vertical-expected.png:
* platform/efl/fast/table/table-display-types-vertical-expected.txt:
* platform/efl/tables/mozilla/bugs/bug119786-expected.png:
* platform/efl/tables/mozilla/bugs/bug119786-expected.txt:
* platform/efl/tables/mozilla/bugs/bug13118-expected.png:
* platform/efl/tables/mozilla/bugs/bug13118-expected.txt:
* platform/efl/tables/mozilla/bugs/bug19061-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug19061-1-expected.txt:
* platform/efl/tables/mozilla/bugs/bug19061-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug19061-2-expected.txt:
* platform/efl/tables/mozilla/bugs/bug220536-expected.png:
* platform/efl/tables/mozilla/bugs/bug220536-expected.txt:
* platform/efl/tables/mozilla/bugs/bug27038-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug27038-2-expected.txt:
* platform/efl/tables/mozilla/bugs/bug27038-3-expected.png:
* platform/efl/tables/mozilla/bugs/bug27038-3-expected.txt: Added.
* platform/efl/tables/mozilla/bugs/bug30418-expected.png:
* platform/efl/tables/mozilla/bugs/bug30418-expected.txt:
* platform/efl/tables/mozilla/bugs/bug3263-expected.png:
* platform/efl/tables/mozilla/bugs/bug3263-expected.txt:
* platform/efl/tables/mozilla/bugs/bug38916-expected.png:
* platform/efl/tables/mozilla/bugs/bug38916-expected.txt:
* platform/efl/tables/mozilla/bugs/bug46268-3-expected.png:
* platform/efl/tables/mozilla/bugs/bug46268-3-expected.txt:
* platform/efl/tables/mozilla/bugs/bug46268-5-expected.png:
* platform/efl/tables/mozilla/bugs/bug46268-5-expected.txt:
* platform/efl/tables/mozilla/bugs/bug46268-expected.png:
* platform/efl/tables/mozilla/bugs/bug46268-expected.txt:
* platform/efl/tables/mozilla/bugs/bug46924-expected.png:
* platform/efl/tables/mozilla/bugs/bug46924-expected.txt:
* platform/efl/tables/mozilla/bugs/bug57378-expected.png:
* platform/efl/tables/mozilla/bugs/bug57378-expected.txt:
* platform/efl/tables/mozilla/dom/appendTbodyExpand1-expected.png:
* platform/efl/tables/mozilla/dom/appendTbodyExpand1-expected.txt:
* platform/efl/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
* platform/efl/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
* platform/efl/tables/mozilla/marvin/backgr_position-table-expected.png:
* platform/efl/tables/mozilla/marvin/backgr_position-table-expected.txt:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-expected.png:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-expected.txt:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
* platform/efl/tables/mozilla/marvin/body_tfoot-expected.png:
* platform/efl/tables/mozilla/marvin/body_tfoot-expected.txt:
* platform/efl/tables/mozilla/marvin/body_thead-expected.png:
* platform/efl/tables/mozilla/marvin/body_thead-expected.txt:
* platform/efl/tables/mozilla/marvin/table_rules_groups-expected.png:
* platform/efl/tables/mozilla/marvin/table_rules_groups-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_align_center-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_align_center-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_align_char-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_align_char-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_align_justify-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_align_justify-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_align_left-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_align_left-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_align_right-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_align_right-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_char-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_char-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_valign_middle-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_valign_top-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_valign_top-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_align_center-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_align_center-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_align_char-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_align_char-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_align_justify-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_align_justify-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_align_left-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_align_left-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_align_right-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_align_right-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_char-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_char-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_valign_top-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_align_center-expected.png:
* platform/efl/tables/mozilla/marvin/thead_align_center-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_align_char-expected.png:
* platform/efl/tables/mozilla/marvin/thead_align_char-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_align_justify-expected.png:
* platform/efl/tables/mozilla/marvin/thead_align_justify-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_align_left-expected.png:
* platform/efl/tables/mozilla/marvin/thead_align_left-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_align_right-expected.png:
* platform/efl/tables/mozilla/marvin/thead_align_right-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_char-expected.png:
* platform/efl/tables/mozilla/marvin/thead_char-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_valign_baseline-expected.png:
* platform/efl/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_valign_bottom-expected.png:
* platform/efl/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_valign_middle-expected.png:
* platform/efl/tables/mozilla/marvin/thead_valign_middle-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_valign_top-expected.png:
* platform/efl/tables/mozilla/marvin/thead_valign_top-expected.txt:
* platform/efl/tables/mozilla/marvin/x_table-expected.png:
* platform/efl/tables/mozilla/marvin/x_table-expected.txt:
* platform/efl/tables/mozilla/marvin/x_table_border-expected.png:
* platform/efl/tables/mozilla/marvin/x_table_border-expected.txt:
* platform/efl/tables/mozilla/marvin/x_table_border_none-expected.png:
* platform/efl/tables/mozilla/marvin/x_table_border_none-expected.txt:
* platform/efl/tables/mozilla/marvin/x_table_border_px-expected.png:
* platform/efl/tables/mozilla/marvin/x_table_border_px-expected.txt:
* platform/efl/tables/mozilla/marvin/x_table_frame_void-expected.png:
* platform/efl/tables/mozilla/marvin/x_table_frame_void-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_align_center-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_align_center-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_align_char-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_align_char-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_align_left-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_align_left-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_align_right-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_align_right-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_valign_baseline-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_valign_bottom-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_valign_middle-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_valign_top-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_center-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_center-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_char-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_char-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_left-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_left-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_right-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_right-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_class-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_class-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_id-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_id-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_style-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_style-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_valign_middle-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_valign_top-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_align_center-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_align_center-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_align_char-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_align_char-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_align_justify-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_align_left-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_align_left-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_align_right-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_align_right-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_class-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_class-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_id-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_id-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_style-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_style-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_valign_baseline-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_valign_bottom-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_valign_middle-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_valign_top-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug4294-expected.png:
* platform/efl/tables/mozilla_expected_failures/bugs/bug4294-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug46268-4-expected.png:
* platform/efl/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug51000-expected.png:
* platform/efl/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug8499-expected.png:
* platform/efl/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.txt:
* platform/mac-mountainlion/fast/forms/input-value-expected.txt:
* platform/mac-mountainlion/tables/mozilla/bugs/bug26178-expected.txt:
* platform/mac/fast/forms/input-value-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agorun-jsc-stress-tests should be able to package its tests and move them places
mhahnenberg@apple.com [Mon, 25 Nov 2013 17:29:23 +0000 (17:29 +0000)]
run-jsc-stress-tests should be able to package its tests and move them places
https://bugs.webkit.org/show_bug.cgi?id=124549

Reviewed by Filip Pizlo.

* Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation
of grep -i -q
* Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
* Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory.
We now also copy whatever VM was specified, along with its associated framework, into this directory.
All of the generated scripts now are completely relative within the results directory. This allows
run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a
tarball of the generated results directory. Also refactored several portions of the script into
separate functions to make it easier to run them conditionally depending on which mode we're running in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoVertical border spacing is doubled between table row groups
ossy@webkit.org [Mon, 25 Nov 2013 17:02:01 +0000 (17:02 +0000)]
Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.

Rebase GTK results after r159747.

* platform/gtk/fast/forms/input-value-expected.png:
* platform/gtk/fast/forms/input-value-expected.txt:
* platform/gtk/fast/table/011-expected.txt:
* platform/gtk/fast/table/border-collapsing/004-expected.txt:
* platform/gtk/fast/table/border-collapsing/004-vertical-expected.png:
* platform/gtk/fast/table/border-collapsing/004-vertical-expected.txt:
* platform/gtk/fast/table/floating-th-expected.png:
* platform/gtk/fast/table/floating-th-expected.txt:
* platform/gtk/fast/table/frame-and-rules-expected.png:
* platform/gtk/fast/table/frame-and-rules-expected.txt:
* platform/gtk/fast/table/rowindex-expected.png:
* platform/gtk/fast/table/rowindex-expected.txt:
* platform/gtk/fast/table/table-display-types-expected.png:
* platform/gtk/fast/table/table-display-types-expected.txt:
* platform/gtk/fast/table/table-display-types-strict-expected.png:
* platform/gtk/fast/table/table-display-types-strict-expected.txt:
* platform/gtk/fast/table/table-display-types-vertical-expected.png:
* platform/gtk/fast/table/table-display-types-vertical-expected.txt:
* platform/gtk/fast/table/tableInsideCaption-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug10296-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug119786-expected.png:
* platform/gtk/tables/mozilla/bugs/bug119786-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug13118-expected.png:
* platform/gtk/tables/mozilla/bugs/bug13118-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug19061-1-expected.png:
* platform/gtk/tables/mozilla/bugs/bug19061-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug19061-2-expected.png:
* platform/gtk/tables/mozilla/bugs/bug19061-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug220536-expected.png:
* platform/gtk/tables/mozilla/bugs/bug220536-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug26178-expected.png:
* platform/gtk/tables/mozilla/bugs/bug26178-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug27038-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug27038-2-expected.png:
* platform/gtk/tables/mozilla/bugs/bug27038-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug27038-3-expected.png:
* platform/gtk/tables/mozilla/bugs/bug27038-3-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug278385-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug30418-expected.png:
* platform/gtk/tables/mozilla/bugs/bug30418-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug3263-expected.png:
* platform/gtk/tables/mozilla/bugs/bug3263-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug38916-expected.png:
* platform/gtk/tables/mozilla/bugs/bug38916-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug46268-3-expected.png:
* platform/gtk/tables/mozilla/bugs/bug46268-3-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug46268-5-expected.png:
* platform/gtk/tables/mozilla/bugs/bug46268-5-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug46268-expected.png:
* platform/gtk/tables/mozilla/bugs/bug46268-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug46924-expected.png:
* platform/gtk/tables/mozilla/bugs/bug46924-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug55789-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug57378-expected.png:
* platform/gtk/tables/mozilla/bugs/bug57378-expected.txt:
* platform/gtk/tables/mozilla/dom/appendTbodyExpand1-expected.png:
* platform/gtk/tables/mozilla/dom/appendTbodyExpand1-expected.txt:
* platform/gtk/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
* platform/gtk/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
* platform/gtk/tables/mozilla/marvin/backgr_position-table-expected.png:
* platform/gtk/tables/mozilla/marvin/backgr_position-table-expected.txt:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.png:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.txt:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
* platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
* platform/gtk/tables/mozilla/marvin/body_tfoot-expected.png:
* platform/gtk/tables/mozilla/marvin/body_tfoot-expected.txt:
* platform/gtk/tables/mozilla/marvin/body_thead-expected.png:
* platform/gtk/tables/mozilla/marvin/body_thead-expected.txt:
* platform/gtk/tables/mozilla/marvin/table_rules_groups-expected.png:
* platform/gtk/tables/mozilla/marvin/table_rules_groups-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_align_center-expected.png:
* platform/gtk/tables/mozilla/marvin/tbody_align_center-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_align_char-expected.png:
* platform/gtk/tables/mozilla/marvin/tbody_align_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_align_justify-expected.png:
* platform/gtk/tables/mozilla/marvin/tbody_align_justify-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_align_left-expected.png:
* platform/gtk/tables/mozilla/marvin/tbody_align_left-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_align_right-expected.png:
* platform/gtk/tables/mozilla/marvin/tbody_align_right-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_char-expected.png:
* platform/gtk/tables/mozilla/marvin/tbody_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
* platform/gtk/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
* platform/gtk/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_valign_middle-expected.png:
* platform/gtk/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/tbody_valign_top-expected.png:
* platform/gtk/tables/mozilla/marvin/tbody_valign_top-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_align_center-expected.png:
* platform/gtk/tables/mozilla/marvin/tfoot_align_center-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_align_char-expected.png:
* platform/gtk/tables/mozilla/marvin/tfoot_align_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_align_justify-expected.png:
* platform/gtk/tables/mozilla/marvin/tfoot_align_justify-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_align_left-expected.png:
* platform/gtk/tables/mozilla/marvin/tfoot_align_left-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_align_right-expected.png:
* platform/gtk/tables/mozilla/marvin/tfoot_align_right-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_char-expected.png:
* platform/gtk/tables/mozilla/marvin/tfoot_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
* platform/gtk/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
* platform/gtk/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
* platform/gtk/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/tfoot_valign_top-expected.png:
* platform/gtk/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_align_center-expected.png:
* platform/gtk/tables/mozilla/marvin/thead_align_center-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_align_char-expected.png:
* platform/gtk/tables/mozilla/marvin/thead_align_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_align_justify-expected.png:
* platform/gtk/tables/mozilla/marvin/thead_align_justify-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_align_left-expected.png:
* platform/gtk/tables/mozilla/marvin/thead_align_left-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_align_right-expected.png:
* platform/gtk/tables/mozilla/marvin/thead_align_right-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_char-expected.png:
* platform/gtk/tables/mozilla/marvin/thead_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_valign_baseline-expected.png:
* platform/gtk/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_valign_middle-expected.png:
* platform/gtk/tables/mozilla/marvin/thead_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_valign_top-expected.png:
* platform/gtk/tables/mozilla/marvin/thead_valign_top-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table-expected.png:
* platform/gtk/tables/mozilla/marvin/x_table-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table_border-expected.png:
* platform/gtk/tables/mozilla/marvin/x_table_border-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table_border_none-expected.png:
* platform/gtk/tables/mozilla/marvin/x_table_border_none-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table_border_px-expected.png:
* platform/gtk/tables/mozilla/marvin/x_table_border_px-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_table_frame_void-expected.png:
* platform/gtk/tables/mozilla/marvin/x_table_frame_void-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_align_center-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tbody_align_center-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_align_char-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tbody_align_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_align_left-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tbody_align_left-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_align_right-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tbody_align_right-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_valign_baseline-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_valign_bottom-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_valign_middle-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_valign_top-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_align_center-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tfoot_align_center-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_align_char-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tfoot_align_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_align_left-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tfoot_align_left-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_align_right-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tfoot_align_right-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_class-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tfoot_class-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_id-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tfoot_id-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_style-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tfoot_style-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_valign_middle-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_valign_top-expected.png:
* platform/gtk/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_align_center-expected.png:
* platform/gtk/tables/mozilla/marvin/x_thead_align_center-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_align_char-expected.png:
* platform/gtk/tables/mozilla/marvin/x_thead_align_char-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_align_justify-expected.png:
* platform/gtk/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_align_left-expected.png:
* platform/gtk/tables/mozilla/marvin/x_thead_align_left-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_align_right-expected.png:
* platform/gtk/tables/mozilla/marvin/x_thead_align_right-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_class-expected.png:
* platform/gtk/tables/mozilla/marvin/x_thead_class-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_id-expected.png:
* platform/gtk/tables/mozilla/marvin/x_thead_id-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_style-expected.png:
* platform/gtk/tables/mozilla/marvin/x_thead_style-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_valign_baseline-expected.png:
* platform/gtk/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_valign_middle-expected.png:
* platform/gtk/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_valign_top-expected.png:
* platform/gtk/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug4294-expected.png:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug4294-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug46268-4-expected.png:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug51000-expected.png:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.png:
* platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.png:
* platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.png:
* platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoVertical border spacing is doubled between table row groups
ossy@webkit.org [Mon, 25 Nov 2013 16:04:59 +0000 (16:04 +0000)]
Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.

Rebase Mac results after r159747.

* platform/mac/tables/mozilla/bugs/bug119786-expected.txt:
* platform/mac/tables/mozilla/bugs/bug19061-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug220536-expected.txt: Added.
* platform/mac/tables/mozilla/bugs/bug26178-expected.txt:
* platform/mac/tables/mozilla/bugs/bug27038-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug27038-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug27038-3-expected.txt: Added.
* platform/mac/tables/mozilla/bugs/bug278385-expected.txt:
* platform/mac/tables/mozilla/bugs/bug30418-expected.txt:
* platform/mac/tables/mozilla/bugs/bug38916-expected.txt:
* platform/mac/tables/mozilla/bugs/bug46268-3-expected.txt:
* platform/mac/tables/mozilla/bugs/bug46268-5-expected.txt:
* platform/mac/tables/mozilla/bugs/bug46268-expected.txt:
* platform/mac/tables/mozilla/bugs/bug46924-expected.txt:
* platform/mac/tables/mozilla/bugs/bug55789-expected.txt:
* platform/mac/tables/mozilla/bugs/bug57378-expected.txt:
* platform/mac/tables/mozilla/marvin/table_rules_groups-expected.txt:
* platform/mac/tables/mozilla/marvin/tbody_align_center-expected.txt:
* platform/mac/tables/mozilla/marvin/tbody_align_char-expected.txt:
* platform/mac/tables/mozilla/marvin/tbody_align_justify-expected.txt:
* platform/mac/tables/mozilla/marvin/tbody_align_left-expected.txt:
* platform/mac/tables/mozilla/marvin/tbody_align_right-expected.txt:
* platform/mac/tables/mozilla/marvin/tbody_char-expected.txt:
* platform/mac/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
* platform/mac/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
* platform/mac/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
* platform/mac/tables/mozilla/marvin/tbody_valign_top-expected.txt:
* platform/mac/tables/mozilla/marvin/tfoot_align_center-expected.txt:
* platform/mac/tables/mozilla/marvin/tfoot_align_char-expected.txt:
* platform/mac/tables/mozilla/marvin/tfoot_align_justify-expected.txt:
* platform/mac/tables/mozilla/marvin/tfoot_align_left-expected.txt:
* platform/mac/tables/mozilla/marvin/tfoot_align_right-expected.txt:
* platform/mac/tables/mozilla/marvin/tfoot_char-expected.txt:
* platform/mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
* platform/mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
* platform/mac/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
* platform/mac/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
* platform/mac/tables/mozilla/marvin/thead_align_center-expected.txt:
* platform/mac/tables/mozilla/marvin/thead_align_char-expected.txt:
* platform/mac/tables/mozilla/marvin/thead_align_justify-expected.txt:
* platform/mac/tables/mozilla/marvin/thead_align_left-expected.txt:
* platform/mac/tables/mozilla/marvin/thead_align_right-expected.txt:
* platform/mac/tables/mozilla/marvin/thead_char-expected.txt:
* platform/mac/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
* platform/mac/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
* platform/mac/tables/mozilla/marvin/thead_valign_middle-expected.txt:
* platform/mac/tables/mozilla/marvin/thead_valign_top-expected.txt:
* platform/mac/tables/mozilla/marvin/x_table-expected.txt:
* platform/mac/tables/mozilla/marvin/x_table_border-expected.txt:
* platform/mac/tables/mozilla/marvin/x_table_border_none-expected.txt:
* platform/mac/tables/mozilla/marvin/x_table_border_px-expected.txt:
* platform/mac/tables/mozilla/marvin/x_table_frame_void-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tbody_align_center-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tbody_align_char-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tbody_align_left-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tbody_align_right-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tfoot_align_center-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tfoot_align_char-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tfoot_align_left-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tfoot_align_right-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tfoot_class-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tfoot_id-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tfoot_style-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
* platform/mac/tables/mozilla/marvin/x_thead_align_center-expected.txt:
* platform/mac/tables/mozilla/marvin/x_thead_align_char-expected.txt:
* platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
* platform/mac/tables/mozilla/marvin/x_thead_align_left-expected.txt:
* platform/mac/tables/mozilla/marvin/x_thead_align_right-expected.txt:
* platform/mac/tables/mozilla/marvin/x_thead_class-expected.txt:
* platform/mac/tables/mozilla/marvin/x_thead_id-expected.txt:
* platform/mac/tables/mozilla/marvin/x_thead_style-expected.txt:
* platform/mac/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
* platform/mac/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:
* platform/mac/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
* platform/mac/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug4294-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
* platform/mac/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
* platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
* platform/mac/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
* platform/mac/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.txt:
* platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoEWS creates 0 byte sized log files
commit-queue@webkit.org [Mon, 25 Nov 2013 15:48:07 +0000 (15:48 +0000)]
EWS creates 0 byte sized log files
https://bugs.webkit.org/show_bug.cgi?id=107606

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-11-25
Reviewed by Ryosuke Niwa.

There was a modification in r138264, that tried to make less log,
because some of the messeges were duplicated. After this the EWS
created the log file (with the same name as the bugID) but doesn't
write anything into it, even if there were errors during the build.
From now only creates the log file only if there is some error.

* Scripts/webkitpy/tool/bot/queueengine.py:
(QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
there is nothing to log. Open the log file only if a ScriptError was raised to
avoid to make empty log files for bugs.
(QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
because of changes in r138264. Teeing is used for locally testing purposes and
this feature is not used anymore.
(QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output
teeing anymore. It is a necessary change because of QueueEngine._open_work_log
change.
* Scripts/webkitpy/tool/bot/queueengine_unittest.py:
(LoggingDelegate): The order of the callbacks was changed by this patch.
(QueueEngineTest.test_trivial): Won't create log file if the queue was terminated,
so we have to update this test.
(QueueEngineTest.test_unexpected_error): The order of the callbacks was changed by
this patch.
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
to be able to handle it in QueueEngine.run. Without this change, the existing
exception handler never run (the process_work_item method never raise ScriptError)
We can get the error message only from the ScriptError at this point.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[arm][mips] Fix crash in dfg-arrayify-elimination layout jsc test.
commit-queue@webkit.org [Mon, 25 Nov 2013 15:28:45 +0000 (15:28 +0000)]
[arm][mips] Fix crash in dfg-arrayify-elimination layout jsc test.
https://bugs.webkit.org/show_bug.cgi?id=124839

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-25
Reviewed by Michael Saboff.

In ARM EABI and MIPS, 64-bit values have to be aligned on stack too.

* jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
* jit/JITInlines.h:
(JSC::JIT::callOperation): Add missing EABI_32BIT_DUMMY_ARG.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoVertical border spacing is doubled between table row groups
ossy@webkit.org [Mon, 25 Nov 2013 14:57:38 +0000 (14:57 +0000)]
Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.

Source/WebCore:

Based on Chromium fix https://chromium.googlesource.com/chromium/blink/+/eb615069267f895c59bc576f9d65b3fa5add41e9

Rebaseline needed for table related tests (100+).

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):

LayoutTests:

First tuple of rebaselined tests for mac. Rebaseline needed for table related tests (100+).

* fast/table/anonymous-table-section-removed.html:
* platform/mac/accessibility/table-detection-expected.txt:
* platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
* platform/mac/fast/forms/input-value-expected.txt:
* platform/mac/fast/table/011-expected.txt:
* platform/mac/fast/table/border-collapsing/004-expected.txt:
* platform/mac/fast/table/border-collapsing/004-vertical-expected.txt:
* platform/mac/fast/table/floating-th-expected.txt:
* platform/mac/fast/table/frame-and-rules-expected.txt:
* platform/mac/fast/table/multiple-captions-display-expected.txt:
* platform/mac/fast/table/rowindex-expected.txt:
* platform/mac/fast/table/table-display-types-expected.txt:
* platform/mac/fast/table/table-display-types-strict-expected.txt:
* platform/mac/fast/table/table-display-types-vertical-expected.txt:
* platform/mac/fast/table/tableInsideCaption-expected.txt:
* platform/mac/tables/mozilla/bugs/bug10296-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug13118-expected.txt:
* platform/mac/tables/mozilla/bugs/bug19061-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug3263-expected.txt:
* platform/mac/tables/mozilla/dom/appendTbodyExpand1-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_position-table-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_simple-table-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
* platform/mac/tables/mozilla/marvin/body_tfoot-expected.txt:
* platform/mac/tables/mozilla/marvin/body_thead-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GStreamer] Seeking fails on media content provided by servers not supporting Range...
commit-queue@webkit.org [Mon, 25 Nov 2013 14:03:25 +0000 (14:03 +0000)]
[GStreamer] Seeking fails on media content provided by servers not supporting Range requests
https://bugs.webkit.org/show_bug.cgi?id=85994

Patch by Andres Gomez <agomez@igalia.com> on 2013-11-25
Reviewed by Philippe Normand.

Source/WebCore:

Based on the patch written by Andre Moreira Magalhaes.

When the GStreamer web source was doing a "Range" request we were
expecting to receive a 206 status reply with the "Content-Range"
header and just the requested data. Supporting "Range" requests is
not mandatory so, for the servers not supporting it they will be
replying with a 200 status and the whole content of the media
element. Now, we are properly handling these replies too.

Test: http/tests/media/media-seeking-no-ranges-server.html

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient::handleResponseReceived): Do not fail when
receiving 200 as response for HTTP range requests.
(StreamingClient::handleDataReceived): Manually seek on stream
when receiving the full data after a seek.

LayoutTests:

Added test to check that seeking media files on http servers not
supporting "Range" requests doesn't trigger an error.

* http/tests/media/media-seeking-no-ranges-server-expected.txt: Added.
* http/tests/media/media-seeking-no-ranges-server.html: Added.
* http/tests/media/resources/load-video.php: Added support for new
"ranges" paramenter.
* http/tests/media/resources/serve-video.php: Added support for
new "ranges" paramenter. When "ranges" is "no" we always answer
the HTTP status "200 OK" and send the whole file.
* platform/mac/TestExpectations: New test skipped in Mac port as
media playback download control is passed to AVFoundation that
doesn't like fancy PHP URLs like the one used in the test and, in
addition, they won't care about HTTP servers not supporting
"Range" requests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemoved obsolete FIXME after the landing of visual overflow patch (https://bugs.webki...
stavila@adobe.com [Mon, 25 Nov 2013 12:14:52 +0000 (12:14 +0000)]
Removed obsolete FIXME after the landing of visual overflow patch (https://bugs.webkit.org/show_bug.cgi?id=118665).
https://bugs.webkit.org/show_bug.cgi?id=124833

Reviewed by Mihnea Ovidenie.

* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::layoutBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed GTK gardening. Removed expectations for test that is no
mario.prada@samsung.com [Mon, 25 Nov 2013 11:36:11 +0000 (11:36 +0000)]
Unreviewed GTK gardening. Removed expectations for test that is no
longer failing for the GTK bots, according to the flakiness dashboard.

* platform/gtk-wk2/TestExpectations: Removed expectation.
* platform/gtk/TestExpectations: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Mon, 25 Nov 2013 11:19:36 +0000 (11:19 +0000)]
Unreviewed GTK gardening.
Managing current failures and removing redundant baselines.

* platform/gtk-wk2/TestExpectations:
* platform/gtk/TestExpectations:
* platform/gtk/fast/dom/gc-attribute-node-expected.txt: Removed.
* platform/gtk/fast/repaint/increasing-region-content-height-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Need to update EFL TestExpectations file
commit-queue@webkit.org [Mon, 25 Nov 2013 09:52:17 +0000 (09:52 +0000)]
[EFL] Need to update EFL TestExpectations file
https://bugs.webkit.org/show_bug.cgi?id=124825

Unreviewed, EFL gardening.

webgl/1.0.2/conformance/extensions/webgl-compressed-texture-s3tc.html
webgl/conformance/extensions/webgl-compressed-texture-s3tc.html
Above two tests are passed in Webkit2 layout test after r158798.

Patch by Jongwoo Choi <jw0330.choi@samsung.com> on 2013-11-25

* platform/efl-wk1/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CSS Grid Layout] Cache several vectors to avoid malloc/free churn
svillar@igalia.com [Mon, 25 Nov 2013 08:22:08 +0000 (08:22 +0000)]
[CSS Grid Layout] Cache several vectors to avoid malloc/free churn
https://bugs.webkit.org/show_bug.cgi?id=123995

Reviewed by Dean Jackson.

From Blink r158228 by <jchaffraix@chromium.org>

Laying-out the grid items means a lot of calls to
distributeSpaceToTracks() and
resolveContentBasedTrackSizingFunctionsForItems() as they're
called in a loop. This means that there is a lot of malloc/free
going on there. By moving the vectors used by these methods to a
new class which is kept during the whole layout process we save a
lot of those calls.

This obviously mean that the price we pay for a significant
perfomance improvement is that we keep the maximum allocation till
the end of each layout, but it's an amount of memory that we have
to allocate anyway. The improvement in the
auto-grid-lots-of-data.html perf test is ~24% (165 runs/s vs 207
runs/s).

No new tests required as we're just refactoring code to a new
helper class. Nevertheless the performance improvement is backed
by the perf test mentioned above.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::GridSizingData::GridSizingData):
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
(WebCore::RenderGrid::distributeSpaceToTracks):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::findChildLogicalPosition):
* rendering/RenderGrid.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWebPageGroup's should keep track of what processes they are being used by
weinig@apple.com [Mon, 25 Nov 2013 03:09:03 +0000 (03:09 +0000)]
WebPageGroup's should keep track of what processes they are being used by
https://bugs.webkit.org/show_bug.cgi?id=124556

Reviewed by Dan Bernstein.

* Scripts/webkit2/messages.py:
(struct_or_class):
Mark WebPageGroupData as a struct.

* Shared/UserMessageCoders.h:
* Shared/mac/ObjCObjectGraphCoders.h:
* Shared/mac/ObjCObjectGraphCoders.mm:
* WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
* UIProcess/WebConnectionToWebProcess.cpp:
* UIProcess/WebContext.cpp:
* UIProcess/WebContextUserMessageCoders.h:
* UIProcess/WebPageProxy.cpp:
* UIProcess/WebPageProxy.h:
Pass the WebProcess/WebProcessProxy to both encode and decode.

* Shared/WebPageCreationParameters.h:
Pass the page group by ID when creating a page, as it will have had its own
creation message sent already.

* UIProcess/WebPageGroup.cpp:
* UIProcess/WebPageGroup.h:
Keep track of processes.

* UIProcess/WebProcessProxy.cpp:
* UIProcess/WebProcessProxy.h:
Keep track of the page groups used by the process.

* WebProcess/WebPage/WebPage.cpp:
Get the already create page group on creation.

* WebProcess/WebProcess.cpp:
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:
Explicitly create page groups in the WebProcess.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed EFL gardening. Rebaselining various tests under fast/
jinwoo7.song@samsung.com [Mon, 25 Nov 2013 02:00:09 +0000 (02:00 +0000)]
Unreviewed EFL gardening. Rebaselining various tests under fast/

* platform/efl/fast/backgrounds/background-position-parsing-expected.png:
* platform/efl/fast/backgrounds/background-position-parsing-expected.txt:
* platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
* platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
* platform/efl/fast/css/empty-pseudo-class-expected.png:
* platform/efl/fast/css/empty-pseudo-class-expected.txt:
* platform/efl/fast/css/fieldset-display-row-expected.txt:
* platform/efl/fast/css/first-child-pseudo-class-expected.png:
* platform/efl/fast/css/first-child-pseudo-class-expected.txt:
* platform/efl/fast/css/last-child-pseudo-class-expected.png:
* platform/efl/fast/css/last-child-pseudo-class-expected.txt:
* platform/efl/fast/css/only-child-pseudo-class-expected.png:
* platform/efl/fast/css/only-child-pseudo-class-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed EFL gardening. Rebaselining after r159579.
jinwoo7.song@samsung.com [Mon, 25 Nov 2013 00:10:37 +0000 (00:10 +0000)]
Unreviewed EFL gardening. Rebaselining after r159579.

* platform/efl/css1/formatting_model/vertical_formatting-expected.txt:
* platform/efl/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
* platform/efl/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDatabaseProcess: Add "UniqueIDBDatabase" that multiple WebProcesses can connect to
beidson@apple.com [Sun, 24 Nov 2013 23:12:28 +0000 (23:12 +0000)]
DatabaseProcess: Add "UniqueIDBDatabase" that multiple WebProcesses can connect to
https://bugs.webkit.org/show_bug.cgi?id=124819

Reviewed by Dan Bernstein.

Source/WebCore:

* Modules/indexeddb/IDBDatabaseBackend.cpp:
(WebCore::IDBDatabaseBackend::~IDBDatabaseBackend): Unregister from the IDBFactory.

Source/WebKit2:

UniqueIDBDatabase instances are per-DatabaseProcess, so it manages the set of them.
* DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::getOrCreateUniqueIDBDatabase):
(WebKit::DatabaseProcess::removeUniqueIDBDatabase):
* DatabaseProcess/DatabaseProcess.h:

* DatabaseProcess/DatabaseToWebProcessConnection.h:

Start forwarding things along to the appropriate UniqueIDBDatabase.
* DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:
(WebKit::DatabaseProcessIDBConnection::~DatabaseProcessIDBConnection):
(WebKit::DatabaseProcessIDBConnection::disconnectedFromWebProcess):
(WebKit::DatabaseProcessIDBConnection::establishConnection):
(WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata):
* DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:

A class that represents a single concrete IDB database that multiple WebProcesses can connect to.
* DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::UniqueIDBDatabase):
(WebKit::UniqueIDBDatabase::~UniqueIDBDatabase):
(WebKit::UniqueIDBDatabase::registerConnection):
(WebKit::UniqueIDBDatabase::unregisterConnection):
(WebKit::UniqueIDBDatabase::getIDBDatabaseMetadata):
* DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
(WebKit::UniqueIDBDatabase::create):
(WebKit::UniqueIDBDatabase::identifier):

A class to help uniquely identify an IDBDatabase that can be expanded as needed.
Importantly, it knows how to be used as a key in a HashMap.
* DatabaseProcess/IndexedDB/UniqueIDBDatabaseIdentifier.cpp: Added.
(WebKit::UniqueIDBDatabaseIdentifier::UniqueIDBDatabaseIdentifier):
(WebKit::UniqueIDBDatabaseIdentifier::isHashTableDeletedValue):
(WebKit::UniqueIDBDatabaseIdentifier::hash):
(WebKit::UniqueIDBDatabaseIdentifier::isNull):
(WebKit::operator==):
* DatabaseProcess/IndexedDB/UniqueIDBDatabaseIdentifier.h: Added.
(WebKit::UniqueIDBDatabaseIdentifier::databaseName):
(WebKit::UniqueIDBDatabaseIdentifier::openingOrigin):
(WebKit::UniqueIDBDatabaseIdentifier::mainFrameOrigin):
(WebKit::UniqueIDBDatabaseIdentifierHash::hash):
(WebKit::UniqueIDBDatabaseIdentifierHash::equal):
(WebKit::UniqueIDBDatabaseIdentifierHashTraits::isEmptyValue):

* Shared/SecurityOriginData.cpp:
(WebKit::operator==):
* Shared/SecurityOriginData.h:

* UIProcess/WebContext.cpp:

* WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::WebIDBFactoryBackend::open):
(WebKit::WebIDBFactoryBackend::removeIDBDatabaseBackend):

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix more fallout from failed attempts at div/mod DFG strength reductions
fpizlo@apple.com [Sun, 24 Nov 2013 21:46:43 +0000 (21:46 +0000)]
Fix more fallout from failed attempts at div/mod DFG strength reductions
https://bugs.webkit.org/show_bug.cgi?id=124813

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithMod):

LayoutTests:

* js/dfg-mod-1-int.html: Added.
* js/dfg-mod-1-int-expected.txt: Added.
* js/script-tests/dfg-mod-1-int.js: Added.
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUpstream USE(IOSURFACE) from the iOS port
timothy_horton@apple.com [Sun, 24 Nov 2013 19:14:00 +0000 (19:14 +0000)]
Upstream USE(IOSURFACE) from the iOS port
https://bugs.webkit.org/show_bug.cgi?id=124814

Reviewed by Sam Weinig.

Some code guarded by USE(IOSURFACE) was recently upstreamed,
but not the definition of WTF_USE_IOSURFACE itself.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WK2][GTK] Adding SpatialNavigation setting to webkit2
commit-queue@webkit.org [Sun, 24 Nov 2013 18:20:54 +0000 (18:20 +0000)]
[WK2][GTK] Adding SpatialNavigation setting to webkit2
https://bugs.webkit.org/show_bug.cgi?id=114298

Patch by Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>, Arunprasad Rajkumar <arurajku@cisco.com> on 2013-11-24
Reviewed by Anders Carlsson.

Adding SpatialNavigation support to WebPreferencesStore allows us
to toggle that feature on WebKitSettings.

* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetSpatialNavigationEnabled):
(WKPreferencesGetSpatialNavigationEnabled):
* UIProcess/API/C/WKPreferences.h:
* UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_set_enable_spatial_navigation):
(webkit_settings_get_enable_spatial_navigation):
* UIProcess/API/gtk/WebKitSettings.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoGenerate toHTMLMarquee|OListElement() to cleanup static_cast<>
gyuyoung.kim@samsung.com [Sun, 24 Nov 2013 15:24:33 +0000 (15:24 +0000)]
Generate toHTMLMarquee|OListElement() to cleanup static_cast<>
https://bugs.webkit.org/show_bug.cgi?id=124707

Reviewed by Darin Adler.

As a step to use toFoo(), we need to generate toHTMLMarquee|OListElement().
Besides this patch cleans up remaining static_cast<> usage.

No new tests, no behavior changes.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::State::initElement):
(WebCore::StyleResolver::locateCousinList):
(WebCore::StyleResolver::findSiblingForStyleSharing):
* dom/Attr.cpp:
(WebCore::Attr::style):
* dom/Element.cpp:
(WebCore::Element::removeAttribute):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::wrappingStyleForSerialization):
* editing/Editor.cpp:
(WebCore::Editor::applyEditingStyleToElement):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
* html/HTMLMarqueeElement.h:
* html/HTMLOListElement.h:
* html/HTMLTagNames.in:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
* inspector/InspectorOverlay.cpp:
(WebCore::buildObjectForElementInfo):
* page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):
* rendering/RenderCounter.cpp:
(WebCore::planCounter):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::updateListMarkerNumbers):
* rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::marqueeSpeed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r156291): TileController tiles don't always repaint when they resize
timothy_horton@apple.com [Sun, 24 Nov 2013 08:34:26 +0000 (08:34 +0000)]
REGRESSION (r156291): TileController tiles don't always repaint when they resize
https://bugs.webkit.org/show_bug.cgi?id=124796

Reviewed by Simon Fraser.

In removing platformCALayerDidCreateTiles, r156291 also removed
the call to setNeedsDisplay when tiles are resized, without
putting it somewhere else.

* platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::setNeedsDisplay):
Use hasStaleContent when invalidating a whole tile, just
like we do for partial tile repaints.

(WebCore::TileController::setTileNeedsDisplayInRect):
Mark hasStaleContent for any unparented layers, so they'll be painted
when they are reparented.

(WebCore::TileController::ensureTilesForRect):
Invalidate the whole tile when it changes size.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove lint from expected result.
robert@webkit.org [Sat, 23 Nov 2013 16:20:14 +0000 (16:20 +0000)]
Remove lint from expected result.

Unreviewed.

* platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GStreamer] Remove 0.10 codepath
calvaris@igalia.com [Sat, 23 Nov 2013 14:35:26 +0000 (14:35 +0000)]
[GStreamer] Remove 0.10 codepath
https://bugs.webkit.org/show_bug.cgi?id=124534

Reviewed by Philippe Normand.

.:

* Source/cmake/OptionsEfl.cmake: Removed GST_API_VERSION_1
definition.

Source/WebCore:

All GStreamer ports are using 1.0 now so we remove the 0.10
codepath.

* GNUmakefile.list.am:
* PlatformEfl.cmake:
* PlatformGTK.cmake:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters: Removed
GStreamerVersioning.
* platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(onGStreamerWavparsePadAddedCallback): Removed.
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
Replaced webkitGstPipelineGetBus and removed 0.10 codepath.
(WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer):
Replaced webkitGstPipelineGetBus.
* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::copyGstreamerBuffersToAudioChannel):
(WebCore::onAppsinkPullRequiredCallback): Removed 0.10 codepath.
(WebCore::AudioFileReader::~AudioFileReader): Replaced
webkitGstPipelineGetBus and removed 0.10 codepath.
(WebCore::AudioFileReader::handleSample): Left as only codepath.
(WebCore::AudioFileReader::handleBuffer): Removed.
(WebCore::AudioFileReader::handleNewDeinterleavePad): Removed 0.10
codepath.
(WebCore::AudioFileReader::plugDeinterleave): Replaced
getGstAudioCaps.
(WebCore::AudioFileReader::decodeAudioForBusCreation): Replaced
webkitGstPipelineGetBus.
(WebCore::AudioFileReader::createBus): Removed 0.10 codepath.
* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(getGStreamerMonoAudioCaps):
(webKitWebAudioGStreamerChannelPosition): Removed 0.10 codepath.
(webkit_web_audio_src_class_init): Replaced
setGstElementClassMetadata.
(webkit_web_audio_src_init):
(webKitWebAudioSrcConstructed):
(webKitWebAudioSrcFinalize):
(webKitWebAudioSrcLoop): Removed 0.10 codepath.
* platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
* platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
Removed checks for 1.0 as it is the only codepath now.
* platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::GstElement):
(WTF::GstPad):
(WTF::GstPadTemplate):
(WTF::GstTask):
(WTF::GstBus):
(WTF::GstElementFactory):
(WTF::adoptGRef): Replaced gstObjectIsFloating.
(WTF::refGRef): Replaced webkitGstObjectRefSink.
(WTF::GstTagList):
(WTF::GstSample): Removed checks for 1.0 as it is the only
codepath now.
* platform/graphics/gstreamer/GRefPtrGStreamer.h: Removed checks
for 1.0 as it is the only codepath now.
* platform/graphics/gstreamer/GStreamerUtilities.cpp:
(WebCore::webkitGstGhostPadFromStaticTemplate):
(WebCore::getVideoSizeAndFormatFromCaps):
(WebCore::createGstBuffer):
(WebCore::createGstBufferForData):
(WebCore::getGstBufferDataPointer):
(WebCore::mapGstBuffer):
(WebCore::unmapGstBuffer): Moved here from GstVersioning and added
to WebCore namespace.
* platform/graphics/gstreamer/GStreamerUtilities.h:
(WebCore::webkitGstCheckVersion): Moved here from GstVersioning
and added to WebCore namespace.
* platform/graphics/gstreamer/GStreamerVersioning.cpp: Removed.
* platform/graphics/gstreamer/GStreamerVersioning.h: Removed.
* platform/graphics/gstreamer/ImageGStreamer.h: Removed checks for
1.0 as it is the only codepath now.
* platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
(ImageGStreamer::ImageGStreamer): Removed 0.10 codepath.
(ImageGStreamer::~ImageGStreamer): Removed checks for 1.0 as it is
the only codepath now.
* platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h:
* platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
* platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
Removed checks for 1.0 as it is the only codepath now.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::setAudioStreamPropertiesCallback): Removed 0.10 codepath.
(WebCore::mediaPlayerPrivateTextChangedCallback): Removed checks
for 1.0 as it is the only codepath now.
(WebCore::MediaPlayerPrivateGStreamer::isAvailable): Replaced
gPlaybinName.
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
Removed checks for 1.0 and replaced webkitGstPipelineGetBus.
(WebCore::MediaPlayerPrivateGStreamer::duration): Removed 0.10
codepath.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
(WebCore::MediaPlayerPrivateGStreamer::textChanged):
Removed checks for 1.0 as it is the only codepath now.
(WebCore::MediaPlayerPrivateGStreamer::buffered): Replaced
gPercentMax.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Removed
0.10 codepath.
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContents):
Removed checks for 1.0 as it is the only codepath now.
(WebCore::MediaPlayerPrivateGStreamer::totalBytes): Removed 0.10
codepath.
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): Replaced
gPlaybinName and webkitGstPipelineGetBus and removed checks for
1.0.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
Removed checks for 1.0 as it is the only codepath now.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::naturalSize):
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::paint): Removed 0.10
codepath.
* platform/graphics/gstreamer/TextCombinerGStreamer.cpp:
* platform/graphics/gstreamer/TextCombinerGStreamer.h:
* platform/graphics/gstreamer/TextSinkGStreamer.cpp:
* platform/graphics/gstreamer/TextSinkGStreamer.h:
* platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
* platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h: Removed
checks for 1.0 as it is the only codepath now.
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkRender): Removed 0.10 codepath and added WebCore
as createGstBuffer namespace.
(webkitVideoSinkSetCaps): Removed 0.10 codepath.
(webkitVideoSinkProposeAllocation): Removed checks for 1.0 as it
is the only codepath now.
(webkitVideoSinkMarshalVoidAndMiniObject): Removed as it was 0.10.
(webkit_video_sink_class_init): Removed 0.10 codepath and replaced
setGstElementClassMetadata.
* platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:
* platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:
Removed checks for 1.0 as it is the only codepath now.
* platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:
(webkit_media_src_class_init): Replaced
setGstElementClassMetadata.
(webKitMediaSrcAddSrc): Added WebCore namespace to
webkitGstGhostPadFromStaticTemplate.
(MediaSourceClientGstreamer::didReceiveData): Added WebCore
namespace to createGstBufferForData.
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
Removed 0.10 codepath.
(webKitWebSrcQuery): Removed as it was 0.10 only.
(void webkit_web_src_class_init): Replaced setGstElementClassMetadata.
(webkit_web_src_init): Removed haveAppSrc27 private attribute and
0.10 codepath.
(webKitWebSrcStop): Removed checks for 1.0 as it is the only
codepath now.
(webKitWebSrcSetProperty):
(webKitWebSrcUriGetType):
(webKitWebSrcGetProtocols):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri): Removed 0.10 codepath.
(StreamingClient::createReadBuffer): Removed checks for 1.0 and
replaced getGstBufferSize.
(StreamingClient::handleResponseReceived): Removed 0.10 codepath
and replaced notifyGstTagsOnPad.
(StreamingClient::handleDataReceived): Removed 0.10 codepath and
replaced setGstBufferSize and gst_buffer_get_size.

Source/WebKit:

* PlatformEfl.cmake: Removed FullscreenVideoControllerEfl.cpp.

Source/WebKit/efl:

* WebCoreSupport/FullscreenVideoControllerEfl.cpp: Removed.

Source/WTF:

* wtf/Platform.h: Removed macro for GStreamer 1.0 as it is the
only codepath now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRebaseline empty-clear-blocks.html after r159575
robert@webkit.org [Sat, 23 Nov 2013 11:05:53 +0000 (11:05 +0000)]
Rebaseline empty-clear-blocks.html after r159575

Unreviewed, rebaselining.

* platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd DatabaseProcessCreationParameters, starting with the database path.
beidson@apple.com [Sat, 23 Nov 2013 07:11:28 +0000 (07:11 +0000)]
Add DatabaseProcessCreationParameters, starting with the database path.
https://bugs.webkit.org/show_bug.cgi?id=124804

Reviewed by Dean Jackson and Benjamin Poulain.

* DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::initializeDatabaseProcess):
* DatabaseProcess/DatabaseProcess.h:
(WebKit::DatabaseProcess::indexedDatabaseDirectory):
* DatabaseProcess/DatabaseProcess.messages.in:

* Shared/Databases/DatabaseProcessCreationParameters.cpp: Added.
(WebKit::DatabaseProcessCreationParameters::DatabaseProcessCreationParameters):
(WebKit::DatabaseProcessCreationParameters::encode):
(WebKit::DatabaseProcessCreationParameters::decode):
* Shared/Databases/DatabaseProcessCreationParameters.h: Added.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureDatabaseProcess):

* WebKit2.xcodeproj/project.pbxproj:
* Scripts/webkit2/messages.py:
(struct_or_class):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Build break after r159724
ryuan.choi@samsung.com [Sat, 23 Nov 2013 06:03:11 +0000 (06:03 +0000)]
[EFL] Build break after r159724
https://bugs.webkit.org/show_bug.cgi?id=124806

Reviewed by Tim Horton.

* Platform/CoreIPC/Connection.h: Include atomic header.
* UIProcess/CoordinatedGraphics/WebView.cpp: Rename didChangeContentsSize to didChangeContentSize.
(WebKit::WebView::didChangeContentSize):
* UIProcess/CoordinatedGraphics/WebView.h: Ditto.
* WebProcess/InjectedBundle/API/c/WKBundlePage.h: Adjust TARGET_OS_IPHONE macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoLayout Test editing/deleting/password-delete-performance.html is failing
rniwa@webkit.org [Sat, 23 Nov 2013 04:50:45 +0000 (04:50 +0000)]
Layout Test editing/deleting/password-delete-performance.html is failing
https://bugs.webkit.org/show_bug.cgi?id=124781

Reviewed by Alexey Proskuryakov.

PerformanceTests:

Add a new performance test to replace editing/deleting/password-delete-performance.html.
We skip this test by default since it's a micro benchmark.

* Interactive/DeletingInPasswordField.html: Added.
* Skipped:

LayoutTests:

Removed the test that has been timing out.

* TestExpectations:
* editing/deleting/password-delete-performance.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAttempt build fixes for 32-bit after 159724.
timothy_horton@apple.com [Sat, 23 Nov 2013 03:43:57 +0000 (03:43 +0000)]
Attempt build fixes for 32-bit after 159724.

There's probably a better fix, but this will work for now.

* UIProcess/API/mac/WKView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUpstream iOS WebKit2 to OpenSource (part 3).
enrica@apple.com [Sat, 23 Nov 2013 03:29:50 +0000 (03:29 +0000)]
Upstream iOS WebKit2 to OpenSource (part 3).
https://bugs.webkit.org/show_bug.cgi?id=124803

Reviewed by Anders Carlsson and Tim Horton.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoJSC Obj-C API should have real documentation
mhahnenberg@apple.com [Sat, 23 Nov 2013 02:54:31 +0000 (02:54 +0000)]
JSC Obj-C API should have real documentation
https://bugs.webkit.org/show_bug.cgi?id=124805

Reviewed by Geoffrey Garen.

Massaging the header comments into proper headerdocs.

* API/JSContext.h:
* API/JSExport.h:
* API/JSManagedValue.h:
* API/JSValue.h:
* API/JSVirtualMachine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Mac] Can't drag full-screen video to another monitor
jer.noble@apple.com [Sat, 23 Nov 2013 00:57:51 +0000 (00:57 +0000)]
[Mac] Can't drag full-screen video to another monitor
https://bugs.webkit.org/show_bug.cgi?id=124798

Reviewed by Geoffrey Garen.

Source/WebCore:

Make full screen windows movable by default. Previously, we wanted non-movable full screen
windows since they were in the same space and were just placed atop non-full screen windows.
Now that all our supported Mac platforms have explicit full screen support, we can remove this
non-movable restriction.

* platform/mac/WebCoreFullScreenWindow.mm:
(-[WebCoreFullScreenWindow initWithContentRect:styleMask:backing:defer:]):

Source/WebKit2:

Make full screen windows resizable by default. This allows the window to be resized when
moved between monitors with different resolutions.

* UIProcess/API/mac/WKView.mm:
(-[WKView createFullScreenWindow]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCodeBlock::m_numCalleeRegisters shouldn't also mean frame size, frame size needed...
fpizlo@apple.com [Sat, 23 Nov 2013 00:36:55 +0000 (00:36 +0000)]
CodeBlock::m_numCalleeRegisters shouldn't also mean frame size, frame size needed for exit, or any other unrelated things
https://bugs.webkit.org/show_bug.cgi?id=124793

Reviewed by Mark Hahnenberg.

Now m_numCalleeRegisters always refers to the number of locals that the attached
bytecode uses. It never means anything else.

For frame size, we now have it lazily computed from m_numCalleeRegisters for the
baseline engines and we have it stored in DFG::CommonData for the optimizing JITs.

For frame-size-needed-at-exit, we store that in DFG::CommonData, too.

The code no longer implies that there is any arithmetic relationship between
m_numCalleeRegisters and frameSize. Previously it implied that the latter is greater
than the former.

The code no longer implies that there is any arithmetic relationship between the
frame Size and the frame-size-needed-at-exit. Previously it implied that the latter
is greater that the former.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::frameRegisterCount):
* bytecode/CodeBlock.h:
* dfg/DFGCommonData.h:
(JSC::DFG::CommonData::CommonData):
(JSC::DFG::CommonData::requiredRegisterCountForExecutionAndExit):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::frameRegisterCount):
(JSC::DFG::Graph::requiredRegisterCountForExit):
(JSC::DFG::Graph::requiredRegisterCountForExecutionAndExit):
* dfg/DFGGraph.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
* dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
* ftl/FTLLink.cpp:
(JSC::FTL::link):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
* ftl/FTLOSREntry.cpp:
(JSC::FTL::prepareOSREntry):
* interpreter/CallFrame.cpp:
(JSC::CallFrame::frameExtentInternal):
* interpreter/JSStackInlines.h:
(JSC::JSStack::pushFrame):
* jit/JIT.h:
(JSC::JIT::frameRegisterCountFor):
* jit/JITOperations.cpp:
* llint/LLIntEntrypoint.cpp:
(JSC::LLInt::frameRegisterCountFor):
* llint/LLIntEntrypoint.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] Clean up ColorSpace handling in Windows code
bfulgham@apple.com [Sat, 23 Nov 2013 00:17:11 +0000 (00:17 +0000)]
[Win] Clean up ColorSpace handling in Windows code
https://bugs.webkit.org/show_bug.cgi?id=124795

Reviewed by Tim Horton.

Functionality covered by existing fast/css/color test suite.

* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::safeRGBColorSpaceRef): Handle case of Windows CG implementation not
handling sRGB correctly.
(WebCore::sRGBColorSpaceRef): Use new helper function.
* platform/graphics/win/FontCGWin.cpp:
(WebCore::Font::drawGlyphs): Pass correct color space to fill functions.
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::platformInit): Initialize color space to value passed
via the style to the constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WK2] Another build fix for NetworkProcess on iOS
benjamin@webkit.org [Sat, 23 Nov 2013 00:07:55 +0000 (00:07 +0000)]
[WK2] Another build fix for NetworkProcess on iOS
https://bugs.webkit.org/show_bug.cgi?id=124797

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-11-22
Reviewed by Alexey Proskuryakov.

* NetworkProcess/NetworkResourceLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WK2] Fix the build of the NetworkProcess on iOS
benjamin@webkit.org [Fri, 22 Nov 2013 23:47:49 +0000 (23:47 +0000)]
[WK2] Fix the build of the NetworkProcess on iOS
https://bugs.webkit.org/show_bug.cgi?id=124794

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-11-22
Reviewed by Alexey Proskuryakov.

* NetworkProcess/AsynchronousNetworkLoaderClient.cpp:
(WebKit::AsynchronousNetworkLoaderClient::didReceiveBuffer):
* NetworkProcess/NetworkResourceLoader.h:
* NetworkProcess/SynchronousNetworkLoaderClient.cpp:
(WebKit::SynchronousNetworkLoaderClient::willSendRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWebCrypto algorithms should check that key algorithm matches
ap@apple.com [Fri, 22 Nov 2013 23:43:54 +0000 (23:43 +0000)]
WebCrypto algorithms should check that key algorithm matches
https://bugs.webkit.org/show_bug.cgi?id=123628

Reviewed by Anders Carlsson.

No change in behavior yet, because we have one algorithm per key class.
Will be tested once more algorithms are added.

* WebCore.xcodeproj/project.pbxproj: Updated for file renames.

* bindings/js/JSCryptoAlgorithmDictionary.cpp:
(WebCore::createRsaKeyParamsWithHash):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):
* bindings/js/JSCryptoKeySerializationJWK.cpp:
(WebCore::createRSAKeyParametersWithHash):
(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm):
* crypto/CryptoAlgorithmParameters.h:
(WebCore::CryptoAlgorithmParameters::ENUM_CLASS):
* crypto/parameters/CryptoAlgorithmRsaKeyParamsWithHash.h: Copied from Source/WebCore/crypto/parameters/CryptoAlgorithmRsaSsaKeyParams.h.
* crypto/parameters/CryptoAlgorithmRsaSsaKeyParams.h: Removed.
Renamed RsaSsaKeyParams to RsaKeyParamsWithHash, because other algorithms (like RSA-OAEP)
are in the same boat. Depending on where the spec goes, we might need to introduce
algorithm specific RSA parameter classes later, but let's reduce copy/pasted code at
least for now.

* crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp: Moved to the correct directory.
* crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp: Copied from Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp.
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign): Factored out Mac specific
code, leaving type casting to cross-platform files.
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify): Ditto.

* crypto/CryptoAlgorithmRegistry.h:
(WebCore::CryptoAlgorithmRegistry::registerAlgorithm):
* crypto/mac/CryptoAlgorithmRegistryMac.cpp:
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
Reduce copy/pasting in registration code.

* crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
(WebCore::CryptoAlgorithmAES_CBC::keyAlgorithmMatches): Check key type and algorithm.
(WebCore::CryptoAlgorithmAES_CBC::encrypt): Cross platform type casting code.
Maybe we'll find a way to autogenerate or eliminate it one day.
(WebCore::CryptoAlgorithmAES_CBC::decrypt): Ditto.

* crypto/algorithms/CryptoAlgorithmAES_CBC.h:
* crypto/algorithms/CryptoAlgorithmHMAC.cpp:
(WebCore::CryptoAlgorithmHMAC::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):
* crypto/algorithms/CryptoAlgorithmHMAC.h:
* crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::importKey):
* crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
* crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:
(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):
* crypto/mac/CryptoAlgorithmHMACMac.cpp:
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):
Same changes for all algorithms that have keys.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Review enabled/disabled CSS features for release builds
rego@igalia.com [Fri, 22 Nov 2013 22:57:02 +0000 (22:57 +0000)]
[GTK] Review enabled/disabled CSS features for release builds
https://bugs.webkit.org/show_bug.cgi?id=124791

Reviewed by Martin Robinson.

Enable and disable some CSS features according to what last versions of
Safari ship or not.

* Source/autotools/SetupWebKitFeatures.m4: Enable ENABLE_CSS_REGIONS and
ENABLE_CSS_STICKY_POSITION. Disable ENABLE_CSS_EXCLUSIONS and
ENABLE_CSS_SHAPES.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove the remaining page loader clients out into separate files
andersca@apple.com [Fri, 22 Nov 2013 22:52:12 +0000 (22:52 +0000)]
Move the remaining page loader clients out into separate files
https://bugs.webkit.org/show_bug.cgi?id=124792

Reviewed by Dan Bernstein.

* UIProcess/API/C/WKPage.h:
* UIProcess/API/C/WKPageContextMenuClient.h: Added.
* UIProcess/API/C/WKPageFindClient.h: Added.
* UIProcess/API/C/WKPageFindMatchesClient.h: Added.
* UIProcess/API/C/WKPageFormClient.h: Added.
* UIProcess/API/C/WKPageLoaderClient.h:
* UIProcess/API/C/WKPagePolicyClient.h: Added.
* UIProcess/API/C/WKPageUIClient.h: Added.
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFire "change" event on TextTrackList when a TextTrack's mode changes
commit-queue@webkit.org [Fri, 22 Nov 2013 22:24:26 +0000 (22:24 +0000)]
Fire "change" event on TextTrackList when a TextTrack's mode changes
https://bugs.webkit.org/show_bug.cgi?id=124789

Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-22
Reviewed by Eric Carlson.

Source/WebCore:

Since AudioTrackList and VideoTrackList already have this event, the
interesting bits are in TrackListBase::scheduleChangeEvent(), and we
just need to call it for TextTrackList changes.

Test: media/track/track-change-event.html

* html/HTMLMediaElement.cpp:
(HTMLMediaElement::textTrackModeChanged): Call TrackListBase::scheduleChangeEvent().
* html/track/TextTrackList.idl: Add onchange event listener.

LayoutTests:

* media/track/track-change-event-expected.txt: Added.
* media/track/track-change-event.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCombine SymbolTable and SharedSymbolTable
fpizlo@apple.com [Fri, 22 Nov 2013 22:03:56 +0000 (22:03 +0000)]
Combine SymbolTable and SharedSymbolTable
https://bugs.webkit.org/show_bug.cgi?id=124761

Reviewed by Geoffrey Garen.

SymbolTable was never used directly; we now always used SharedSymbolTable. So, this
gets rid of SymbolTable and renames SharedSymbolTable to SymbolTable.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::symbolTable):
* bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedFunctionExecutable::symbolTable):
(JSC::UnlinkedCodeBlock::symbolTable):
(JSC::UnlinkedCodeBlock::finishCreation):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::symbolTable):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGStackLayoutPhase.cpp:
(JSC::DFG::StackLayoutPhase::run):
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::symbolTableFor):
* runtime/Arguments.h:
(JSC::Arguments::finishCreation):
* runtime/Executable.h:
(JSC::FunctionExecutable::symbolTable):
* runtime/JSActivation.h:
(JSC::JSActivation::create):
(JSC::JSActivation::JSActivation):
(JSC::JSActivation::registersOffset):
(JSC::JSActivation::allocationSize):
* runtime/JSSymbolTableObject.h:
(JSC::JSSymbolTableObject::symbolTable):
(JSC::JSSymbolTableObject::JSSymbolTableObject):
(JSC::JSSymbolTableObject::finishCreation):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::JSVariableObject):
* runtime/SymbolTable.cpp:
(JSC::SymbolTable::destroy):
(JSC::SymbolTable::SymbolTable):
* runtime/SymbolTable.h:
(JSC::SymbolTable::create):
(JSC::SymbolTable::createStructure):
* runtime/VM.cpp:
(JSC::VM::VM):
* runtime/VM.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove WKPageLoaderClient out into a separate header
andersca@apple.com [Fri, 22 Nov 2013 21:59:32 +0000 (21:59 +0000)]
Move WKPageLoaderClient out into a separate header
https://bugs.webkit.org/show_bug.cgi?id=124790

Reviewed by Dan Bernstein.

* UIProcess/API/C/WKPage.h:
* UIProcess/API/C/WKPageLoaderClient.h: Added.
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd TextTrackList::getTrackById().
commit-queue@webkit.org [Fri, 22 Nov 2013 21:44:22 +0000 (21:44 +0000)]
Add TextTrackList::getTrackById().
https://bugs.webkit.org/show_bug.cgi?id=124785

Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-22
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-id.html

* html/track/TextTrackList.cpp: Add getTrackById()
(TextTrackList::getTrackById):
* html/track/TextTrackList.h: Same.
* html/track/TextTrackList.idl: Same.

LayoutTests:

Update this test to make it more interesting. It now checks that the "id"
changes when the <track> id changes, makes sure TextTrack::id is readonly,
and looks the track up by id with getTrackById().

* media/track/track-id-expected.txt:
* media/track/track-id.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSpeculative Mountain Lion build fix.
dino@apple.com [Fri, 22 Nov 2013 21:22:50 +0000 (21:22 +0000)]
Speculative Mountain Lion build fix.

* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate openDocument:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove residual references to "dynamicGlobalObject".
mark.lam@apple.com [Fri, 22 Nov 2013 21:09:25 +0000 (21:09 +0000)]
Remove residual references to "dynamicGlobalObject".
https://bugs.webkit.org/show_bug.cgi?id=124787.

Reviewed by Filip Pizlo.

* JavaScriptCore.order:
* interpreter/CallFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix Mountain Lion bug.
andersca@apple.com [Fri, 22 Nov 2013 20:57:50 +0000 (20:57 +0000)]
Fix Mountain Lion bug.

* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate openDocument:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMiniBrowser should use the blocks-based NSOpenPanel API
andersca@apple.com [Fri, 22 Nov 2013 20:38:42 +0000 (20:38 +0000)]
MiniBrowser should use the blocks-based NSOpenPanel API
https://bugs.webkit.org/show_bug.cgi?id=124786

Reviewed by Simon Fraser.

* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate frontmostBrowserWindowController]):
Account for windows that don't have a BrowserWindowController.

(-[BrowserAppDelegate openDocument:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoEnsure that arity fixups honor stack alignment requirements.
mark.lam@apple.com [Fri, 22 Nov 2013 20:31:38 +0000 (20:31 +0000)]
Ensure that arity fixups honor stack alignment requirements.
https://bugs.webkit.org/show_bug.cgi?id=124756.

Reviewed by Geoffrey Garen.

The LLINT and all the JITs rely on CommonSlowPaths::arityCheckFor() to
compute the arg count adjustment for the arity fixup. We take advantage
of this choke point and introduce the stack alignment padding there in
the guise of additional args.

The only cost of this approach is that the padding will also be
initialized to undefined values as if they were args. Since arity fixups
are considered a slow path that is rarely taken, this cost is not a
concern.

* runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::arityCheckFor):
* runtime/VM.h:
(JSC::VM::isSafeToRecurse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoBytecodeGenerator should align the stack according to native conventions
fpizlo@apple.com [Fri, 22 Nov 2013 20:18:18 +0000 (20:18 +0000)]
BytecodeGenerator should align the stack according to native conventions
https://bugs.webkit.org/show_bug.cgi?id=124735

Source/JavaScriptCore:

Reviewed by Mark Lam.

Rolling this back in because it actually fixed fast/dom/gc-attribute-node.html, but
our infrastructure misleads peole into thinking that fixing a test constitutes
breaking it.

* bytecompiler/BytecodeGenerator.h:
(JSC::CallArguments::registerOffset):
(JSC::CallArguments::argumentCountIncludingThis):
* bytecompiler/NodesCodegen.cpp:
(JSC::CallArguments::CallArguments):

LayoutTests:

Reviewed by Mark Lam.

* platform/mac/fast/dom/gc-attribute-node-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix 32-bit build.
andersca@apple.com [Fri, 22 Nov 2013 20:06:42 +0000 (20:06 +0000)]
Fix 32-bit build.

* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController dealloc]):
(-[WKBrowsingContextController _initWithPageRef:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDebug builds unconditionally dump remote layer tree transactions to stderr.
mitz@apple.com [Fri, 22 Nov 2013 19:48:03 +0000 (19:48 +0000)]
Debug builds unconditionally dump remote layer tree transactions to stderr.

Reviewed by Sam Weinig.

* Platform/Logging.h: Declared RemoteLayerTree logging channel.
* Shared/mac/RemoteLayerTreeTransaction.h: Declared description().
* Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::dump): Changed to use description().
(WebKit::RemoteLayerTreeTransaction::description): Returns a CString with the description.
* UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::commit): Changed to use logging instead of calling dump().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CSS Shapes] When the <box> value is set, derive radii from border-radius
hmuller@adobe.com [Fri, 22 Nov 2013 19:35:07 +0000 (19:35 +0000)]
[CSS Shapes] When the <box> value is set, derive radii from border-radius
https://bugs.webkit.org/show_bug.cgi?id=124228

Reviewed by Dean Jackson.

Source/WebCore:

Add support for BoxShape elliptical corners.

Tests: fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-001.html
       fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-002.html

* platform/graphics/FloatRoundedRect.h:
(WebCore::FloatRoundedRect::bottomLeftCorner): Corrected a copy-and-pasteO.
* rendering/shapes/BoxShape.cpp:
(WebCore::BoxShape::getExcludedIntervals): Returned interval now depends on the top and bottom of the line.
* rendering/shapes/Shape.cpp:
(WebCore::Shape::createShape): Rounded rect parameters are now specified with a RoundedRect parameter.
* rendering/shapes/Shape.h:
* rendering/shapes/ShapeInfo.cpp:
(WebCore::::computedShape): Pass style's rounded border to createShape().

LayoutTests:

* fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-001-expected.txt: Added.
* fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-001.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-002-expected.txt: Added.
* fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-002.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSend out the right KVO callbacks when the page title changes
andersca@apple.com [Fri, 22 Nov 2013 19:33:44 +0000 (19:33 +0000)]
Send out the right KVO callbacks when the page title changes
https://bugs.webkit.org/show_bug.cgi?id=124753

Reviewed by Simon Fraser.

* UIProcess/API/mac/WKBrowsingContextController.mm:
(PageLoadStateObserver::PageLoadStateObserver):
New class that sends the right KVO notifications when the load state changes.

(-[WKBrowsingContextController dealloc]):
Remove the observer.

(-[WKBrowsingContextController _initWithPageRef:]):
Allocate the observer and add it.

* UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::~PageLoadState):
Assert that we don't have any observers left.

(WebKit::PageLoadState::addObserver):
Add the observer to the list.

(WebKit::PageLoadState::removeObserver):
Remove the observer from the list.

(WebKit::PageLoadState::reset):
Call title change callbacks.

(WebKit::PageLoadState::setTitle):
Ditto.

(WebKit::PageLoadState::callObserverCallback):
Helper function to dispatch callbacks to observers.

* UIProcess/PageLoadState.h:
Add new members.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoGet rid of CodeBlock::dumpStatistics()
fpizlo@apple.com [Fri, 22 Nov 2013 18:24:04 +0000 (18:24 +0000)]
Get rid of CodeBlock::dumpStatistics()
https://bugs.webkit.org/show_bug.cgi?id=124762

Reviewed by Mark Hahnenberg.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::~CodeBlock):
* bytecode/CodeBlock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r159690.
commit-queue@webkit.org [Fri, 22 Nov 2013 17:46:12 +0000 (17:46 +0000)]
Unreviewed, rolling out r159690.
http://trac.webkit.org/changeset/159690
https://bugs.webkit.org/show_bug.cgi?id=124782

Broke webkitpy tests (Requested by ap on #webkit).

* Scripts/webkitpy/tool/bot/queueengine.py:
(QueueEngine.run):
(QueueEngine._open_work_log):
(QueueEngine._ensure_work_log_closed):
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem.review_patch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSeveral missing/incorrect guards for LOG_DISABLED=0 against Release build (Mac)
commit-queue@webkit.org [Fri, 22 Nov 2013 17:44:03 +0000 (17:44 +0000)]
Several missing/incorrect guards for LOG_DISABLED=0 against Release build (Mac)
https://bugs.webkit.org/show_bug.cgi?id=78735

Patch by Andres Gomez <agomez@igalia.com> on 2013-11-22
Reviewed by Mario Sanchez Prada.

In a "Debug" build the CString.h header comes from another
indirect dependency. Now, we explicitly add this missing include.

* page/CaptionUserPreferencesMediaAF.cpp: Explicitly adding
missing include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoLayout Test editing/deleting/password-delete-performance.html is failing
ap@apple.com [Fri, 22 Nov 2013 17:38:33 +0000 (17:38 +0000)]
Layout Test editing/deleting/password-delete-performance.html is failing
https://bugs.webkit.org/show_bug.cgi?id=124781

* TestExpectations: Skipped it, running a test that almost always times out makes little sense.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r159652.
commit-queue@webkit.org [Fri, 22 Nov 2013 17:34:04 +0000 (17:34 +0000)]
Unreviewed, rolling out r159652.
http://trac.webkit.org/changeset/159652
https://bugs.webkit.org/show_bug.cgi?id=124778

broke fast/dom/gc-attribute-node.html (Requested by ap on
#webkit).

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
* bytecompiler/BytecodeGenerator.h:
(JSC::CallArguments::registerOffset):
(JSC::CallArguments::argumentCountIncludingThis):
* bytecompiler/NodesCodegen.cpp:
(JSC::CallArguments::CallArguments):
(JSC::CallArguments::newArgument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[curl] Fix of SSL certificate chain storage
commit-queue@webkit.org [Fri, 22 Nov 2013 17:27:59 +0000 (17:27 +0000)]
[curl] Fix of SSL certificate chain storage
https://bugs.webkit.org/show_bug.cgi?id=124768

Patch by Robert Sipka <sipka@inf.u-szeged.hu> on 2013-11-22
Reviewed by Brent Fulgham.

Change the certificates storage type into ListHashSet
from HashSet to keep the chain order in each case.
This ensures that there is no difference between the stored
and the recieved certificate chain.

* platform/network/curl/SSLHandle.cpp:
(WebCore::allowsAnyHTTPSCertificateHosts):
(WebCore::sslIgnoreHTTPSCertificate):
(WebCore::pemData):
(WebCore::certVerifyCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] Avoid deadlock when interacting with some AVFoundationCF content
bfulgham@apple.com [Fri, 22 Nov 2013 17:23:21 +0000 (17:23 +0000)]
[Win] Avoid deadlock when interacting with some AVFoundationCF content
<rdar://problem/15482977> and https://bugs.webkit.org/show_bug.cgi?id=124752

Prevent deadlock caused by conflict over the "mapLock" mutex. Notification handling in the file,
which modify assets and make other changes, are required to happen on the main thread. This
patch enforces this requirement.

Reviewed by Eric Carlson.

* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::NotificationCallbackData::NotificationCallbackData): Added
(WebCore::AVFWrapper::processNotification): Moved logic from 'notificationCallback', which was
sometimes happening on a background thread.
(WebCore::AVFWrapper::notificationCallback): Dispatch calls to main thread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoEWS creates 0 byte sized log files
commit-queue@webkit.org [Fri, 22 Nov 2013 16:26:27 +0000 (16:26 +0000)]
EWS creates 0 byte sized log files
https://bugs.webkit.org/show_bug.cgi?id=107606

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-11-22
Reviewed by Ryosuke Niwa.

There was a modification in r138264, that tried to make less log,
because some of the messeges were duplicated. After this the EWS
created the log file (with the same name as the bugID) but doesn't
write anything into it, even if there were errors during the build.
From now only creates the log file only if there is some error.

* Scripts/webkitpy/tool/bot/queueengine.py:
(QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
there is nothing to log. Open the log file only if a ScriptError was raised to
avoid to make empty log files for bugs.
(QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
because of changes in r138264. Teeing is used for locally testing purposes and
this feature is not used anymore.
(QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output
teeing anymore. It is a necessary change because of QueueEngine._open_work_log
change.
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
to be able to handle it in QueueEngine.run. Without this change, the existing
exception handler never run (the process_work_item method never raise ScriptError)
We can get the error message only from the ScriptError at this point.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoImport more W3C tests for parsing template elements
rniwa@webkit.org [Fri, 22 Nov 2013 16:07:31 +0000 (16:07 +0000)]
Import more W3C tests for parsing template elements
https://bugs.webkit.org/show_bug.cgi?id=124763

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Imported more W3c tests for HTML template element at 12a1164ae919f29f6ba2d0c8a63f0eafb6b599aa
after applying fixes proposed at https://github.com/w3c/web-platform-tests/pull/442.

* html-templates/definitions/template-contents-expected.txt: Added.
* html-templates/definitions/template-contents-owner-document-type-expected.txt: Added.
* html-templates/definitions/template-contents-owner-document-type.html: Added.
* html-templates/definitions/template-contents-owner-test-001-expected.txt: Added.
* html-templates/definitions/template-contents-owner-test-001.html: Added.
* html-templates/definitions/template-contents-owner-test-002-expected.txt: Added.
* html-templates/definitions/template-contents-owner-test-002.html: Added.
* html-templates/definitions/template-contents.html: Added.
* html-templates/innerhtml-on-templates/innerhtml-expected.txt: Added.
* html-templates/innerhtml-on-templates/innerhtml.html: Added.
* html-templates/parsing-html-templates/additions-to-foster-parenting/template-is-a-foster-parent-element-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-foster-parenting/template-is-a-foster-parent-element.html: Added.
* html-templates/parsing-html-templates/additions-to-foster-parenting/template-is-not-a-foster-parent-element-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-foster-parenting/template-is-not-a-foster-parent-element.html: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/generating-of-implied-end-tags-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/generating-of-implied-end-tags.html: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-body-token-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-body-token.html: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-frameset-token-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-frameset-token.html: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-head-token-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-head-token.html: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-html-token-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-html-token.html: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/start-tag-body-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/start-tag-body.html: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/start-tag-html-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/start-tag-html.html: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/template-end-tag-without-start-one-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/template-end-tag-without-start-one.html: Added.
* html-templates/parsing-html-templates/additions-to-the-in-frameset-insertion-mode/end-tag-frameset-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-the-in-frameset-insertion-mode/end-tag-frameset.html: Added.
* html-templates/parsing-html-templates/additions-to-the-in-head-insertion-mode/generating-of-implied-end-tags-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-the-in-head-insertion-mode/generating-of-implied-end-tags.html: Added.
* html-templates/parsing-html-templates/additions-to-the-in-head-insertion-mode/template-end-tag-without-start-one-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-the-in-head-insertion-mode/template-end-tag-without-start-one.html: Added.
* html-templates/parsing-html-templates/additions-to-the-in-table-insertion-mode/end-tag-table-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-the-in-table-insertion-mode/end-tag-table.html: Added.
* html-templates/parsing-html-templates/appending-to-a-template/template-child-nodes-expected.txt: Added.
* html-templates/parsing-html-templates/appending-to-a-template/template-child-nodes.html: Added.
* html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-body-context-expected.txt: Added.
* html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-body-context.html: Added.
* html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-context-expected.txt: Added.
* html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-context.html: Added.
* html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-row-context-expected.txt: Added.
* html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-row-context.html: Added.
* html-templates/parsing-html-templates/creating-an-element-for-the-token/template-owner-document-expected.txt: Added.
* html-templates/parsing-html-templates/creating-an-element-for-the-token/template-owner-document.html: Added.

LayoutTests:

Updated the testharness.js/css to bc4639ba51b62158d94bb4fc6884b23453f3f7a1.

* resources/testharness.css:
* resources/testharness.js:
* resources/testharnessreport.js: Use innerText instead of innerHTML to avoid interpreting markup inside
the status and message as HTML.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WinCairo] Compile error when ACCELERATED_COMPOSITING is not used.
commit-queue@webkit.org [Fri, 22 Nov 2013 16:01:48 +0000 (16:01 +0000)]
[WinCairo] Compile error when ACCELERATED_COMPOSITING is not used.
https://bugs.webkit.org/show_bug.cgi?id=124773

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-22
Reviewed by Brent Fulgham.

* rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations): Added USE(ACCELERATED_COMPOSITING) guard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Fri, 22 Nov 2013 15:12:16 +0000 (15:12 +0000)]
Unreviewed GTK gardening.
Rebaselining after r159575 and r159579.

* platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
* platform/gtk/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
* platform/gtk/editing/deleting/delete-by-word-001-expected.txt: Added.
* platform/gtk/editing/deleting/delete-by-word-002-expected.txt: Added.
* platform/gtk/editing/input/option-page-up-down-expected.txt: Added.
* platform/gtk/editing/input/scroll-viewport-page-up-down-expected.txt: Added.
* platform/gtk/editing/undo/undo-deleteWord-expected.txt: Added.
* platform/gtk/fast/block/float/024-expected.txt:
* platform/gtk/fast/block/margin-collapse/025-expected.txt:
* platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Fri, 22 Nov 2013 15:00:39 +0000 (15:00 +0000)]
Unreviewed GTK gardening.
Adding failure expectations for tests that regressed with r159572.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CSS Grid Layout] Improve content-sized track layout
svillar@igalia.com [Fri, 22 Nov 2013 11:03:32 +0000 (11:03 +0000)]
[CSS Grid Layout] Improve content-sized track layout
https://bugs.webkit.org/show_bug.cgi?id=124408

Reviewed by Dean Jackson.

PerformanceTests:

From Blink r156122 by <jchaffraix@chromium.org>

New test to check the performance of layouting grids with content sized tracks.

* Layout/auto-grid-lots-of-data.html: Added.

Source/WebCore:

Test: fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html

From Blink r156122 & r157633 by <jchaffraix@chromium.org>

Added a couple of optimizations to speed up the layout of content
based tracks. The idea is to narrow down the conditions for
relayouting when the height of a grid area changes. We basically
just need to layout tracks with percentage heights as they're the
only ones that change.

A new performance test is attached to demonstrate the effect of
these optimizations. We get a ~1000% improvement on a i7 M620
going from 14.5 runs/s to 165 runs/s.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::logicalContentHeightForChild):
(WebCore::RenderGrid::layoutGridItems):

LayoutTests:

From Blink r157633 by <jchaffraix@chromium.org>

New test to verify that grid items with percentage logical
{min|max}-height resolve their sizes properly.

* fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic-expected.txt: Added.
* fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CSS Grid Layout] Run the content-sized tracks sizing algorithm only when required
svillar@igalia.com [Fri, 22 Nov 2013 09:25:01 +0000 (09:25 +0000)]
[CSS Grid Layout] Run the content-sized tracks sizing algorithm only when required
https://bugs.webkit.org/show_bug.cgi?id=124039

Reviewed by Dean Jackson.

PerformanceTests:

From Blink r156028 and r156168 by <jchaffraix@chromium.org>.

New performance tests for layouts in grids with fixed size tracks.

* Layout/fixed-grid-lots-of-data.html: Added.

Source/WebCore:

The current code runs the content sized track sizing algorithm all
the time, which forces a layout even when the track is not
content-sized. This change improves the situation by applying two
optimizations. In the first one, we bail out the algorithm if we
detect that we don't need to run it. And by the second one we
reduce the amount of recomputations by only iterating over the
content sized tracks instead of all of them. Both changes follow
the ideas introduced in Blink r156028 and r156168 by
<jchaffraix@chromium.org>.

As we changed the way we iterate over children (we use the
GridIterator now) the way they're stored in the RenderGrid changes
too. If a item spans through several "cells" inside the grid, we
will have a reference to it on each of them.

These two changes account for a ~3200% improvement on a i7 M620 in
the test that accompanies this change (15.5 vs 520 run/s).

New perf test: PerformanceTests/Layout/fixed-grid-lots-of-data.html

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks): Keep track
of content sized tracks and only iterate over them.
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
Early return if there are no tracks to pass to the algorithm.
* rendering/RenderGrid.h:
* rendering/style/GridLength.h:
(WebCore::GridLength::isContentSized):
* rendering/style/GridTrackSize.h:
(WebCore::GridTrackSize::isContentSized):

LayoutTests:

From Blink r156028 and r156168 by <jchaffraix@chromium.org>.

Subtle baseline change due to grids triggering less layouts, which
changes the frame rects between 2 subsequent layouts thus changing
the repaint rectangles.

* fast/css-grid-layout/grid-item-change-column-repaint-expected.txt:
* fast/css-grid-layout/grid-item-change-row-repaint-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CSS Regions] Move code after early break in RenderRegion::repaintFlowThreadContentRe...
rego@igalia.com [Fri, 22 Nov 2013 09:22:50 +0000 (09:22 +0000)]
[CSS Regions] Move code after early break in RenderRegion::repaintFlowThreadContentRectangle
https://bugs.webkit.org/show_bug.cgi?id=124743

Reviewed by Mihnea Ovidenie.

No new tests, covered by existing tests.

* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::repaintFlowThreadContentRectangle): Variable
flippedFlowThreadPortionRect is not used before the early break, so we
can move it after and save some unneeded operations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CSS Regions] Use hasOverflowClip() in RenderRegion
rego@igalia.com [Fri, 22 Nov 2013 08:28:26 +0000 (08:28 +0000)]
[CSS Regions] Use hasOverflowClip() in RenderRegion
https://bugs.webkit.org/show_bug.cgi?id=124746

Reviewed by Mihnea Ovidenie.

Implement the suggested FIXME in RenderRegion using hasOverflowClip().

No new tests, covered by existing tests.

* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::overflowRectForFlowThreadPortion): Use
hasOverflowClip().
(WebCore::RenderRegion::rectFlowPortionForBox): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove ANGLEGenerated from Windows build.
commit-queue@webkit.org [Fri, 22 Nov 2013 05:12:47 +0000 (05:12 +0000)]
Remove ANGLEGenerated from Windows build.
https://bugs.webkit.org/show_bug.cgi?id=124759

Patch by Alex Christensen <achristensen@webkit.org> on 2013-11-21
Reviewed by Darin Adler.

Source/ThirdParty/ANGLE:

* ANGLE.vcxproj/ANGLEGenerated.vcxproj: Removed.
* ANGLE.vcxproj/ANGLEGenerated.vcxproj.filters: Removed.

Source/WebKit:

* WebKit.vcxproj/WebKit.sln:
Remove references to ANGLEGenerated.vcxproj.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMap the dir attribute to the CSS direction property.
commit-queue@webkit.org [Fri, 22 Nov 2013 05:03:26 +0000 (05:03 +0000)]
Map the dir attribute to the CSS direction property.
https://bugs.webkit.org/show_bug.cgi?id=124572.

Patch by Frédéric Wang <fred.wang@free.fr> on 2013-11-21
Reviewed by Darin Adler.

Source/WebCore:

Test: mathml/presentation/mstyle-css-attributes.html

* mathml/MathMLElement.cpp:
(WebCore::MathMLElement::isPresentationAttribute): reorder attributes
(WebCore::MathMLElement::collectStyleForPresentationAttribute): reorder tags that accept dir
(WebCore::MathMLElement::isMathMLToken): add an inline function to test that a tag corresponds to a MathML Token Element.
* mathml/MathMLElement.h:

Follow-up work to address Darin's comments.

LayoutTests:

* mathml/presentation/direction-overall-expected.html: test that dir does not apply to msqrt
* mathml/presentation/direction-overall.html:
* mathml/presentation/mstyle-css-attributes-expected.html: Added.
* mathml/presentation/mstyle-css-attributes.html: Added.

Add more tests for presentation attributes on mstyle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove ENABLE_WORKERS
commit-queue@webkit.org [Fri, 22 Nov 2013 05:01:46 +0000 (05:01 +0000)]
Remove ENABLE_WORKERS
https://bugs.webkit.org/show_bug.cgi?id=105784

.:

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

* Source/autotools/SetupWebKitFeatures.m4:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/WebCore:

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

Source/WebKit:

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/efl:

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

* ewk/ewk_settings.cpp:
(ewk_settings_memory_cache_clear):

Source/WebKit/win:

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

* WebWorkersPrivate.cpp:
(WebWorkersPrivate::workerThreadCount):

Source/WTF:

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

* wtf/FeatureDefines.h:
* wtf/nix/FeatureDefinesNix.h:

Tools:

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

* Scripts/webkitperl/FeatureList.pm:

WebKitLibraries:

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

* win/tools/vsprops/FeatureDefines.props:
* win/tools/vsprops/FeatureDefinesCairo.props:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] Unreviewed build fix after r159632.
alex.christensen@flexsim.com [Fri, 22 Nov 2013 04:42:11 +0000 (04:42 +0000)]
[Win] Unreviewed build fix after r159632.

* platform/network/curl/SSLHandle.cpp:
(WebCore::certVerifyCallback):
Fixed template syntax.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix a typo (requriements->requirements).
fpizlo@apple.com [Fri, 22 Nov 2013 04:24:22 +0000 (04:24 +0000)]
Fix a typo (requriements->requirements).

* runtime/StackAlignment.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTry to fix buildbot Dashboard for people who have not hidden anything.
darin@apple.com [Fri, 22 Nov 2013 04:22:49 +0000 (04:22 +0000)]
Try to fix buildbot Dashboard for people who have not hidden anything.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
Add a null check for hidden platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove chrome/chromium related things from webkitpy.
commit-queue@webkit.org [Fri, 22 Nov 2013 04:17:22 +0000 (04:17 +0000)]
Remove chrome/chromium related things from webkitpy.
https://bugs.webkit.org/show_bug.cgi?id=124493

Patch by Peter Szanka <h868064@stud.u-szeged.hu> on 2013-11-21
Reviewed by Darin Adler.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(PortTest.assert_mock_port_works):
* Scripts/webkitpy/port/base.py:
(Port.to.setup_environ_for_server):
* Scripts/webkitpy/port/mac_unittest.py:
(test_tests_for_other_platforms):
* Scripts/webkitpy/port/mock_drt.py:
(MockTestShell.output_for_test):
* Scripts/webkitpy/tool/bot/irc_command.py:
(Restart.execute):
* Scripts/webkitpy/tool/bot/ircbot_unittest.py:
(IRCBotTest.test_help):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL][WK2] Fix build after r159656
commit-queue@webkit.org [Fri, 22 Nov 2013 04:05:13 +0000 (04:05 +0000)]
[EFL][WK2] Fix build after r159656
https://bugs.webkit.org/show_bug.cgi?id=124755

Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-11-21
Reviewed by Gyuyoung Kim.

Page title was moved to page load state.

* UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:
(WebKit::WebInspectorServer::buildPageList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed build fix.
alex.christensen@flexsim.com [Fri, 22 Nov 2013 03:56:50 +0000 (03:56 +0000)]
Unreviewed build fix.

* src/libGLESv2/Constants.h: Added from checkout a60e0805721f62c28a55faf2df74472cc5fc91fc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoIn filereader.py, process_file() should throw instead of exiting directly when the...
commit-queue@webkit.org [Fri, 22 Nov 2013 03:49:50 +0000 (03:49 +0000)]
In filereader.py, process_file() should throw instead of exiting directly when the file doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=124717

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-21
Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/style/filereader.py:
(TextFileReader.process_file):
* Scripts/webkitpy/style/filereader_unittest.py:
(TextFileReaderTest.test_process_file__does_not_exist):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: [CSS Shapes] Refactor highlighting code to decrease Shapes API surface
betravis@adobe.com [Fri, 22 Nov 2013 03:17:15 +0000 (03:17 +0000)]
Web Inspector: [CSS Shapes] Refactor highlighting code to decrease Shapes API surface
https://bugs.webkit.org/show_bug.cgi?id=124737

Reviewed by Timothy Hatcher.

Source/WebCore:

Add a virtual method to Shapes, buildPath, that can be used to build the
path (in the Shape coordinate system) for display in the Inspector. This allows us
to remove methods such as type(), polygon(), and logicalRx/Ry() which exposed the
inner workings of the Shapes classes. Also covers the addition of the BoxShape type.

Refactoring, existing test is inspector-protocol/model/highlight-shape-outside.html.

* inspector/InspectorOverlay.cpp:
(WebCore::appendPathCommandAndPoints): Points need to be translated from shape space
to renderer space using ShapeInfo.
(WebCore::buildObjectForShapeOutside): Add the ShapeOutsideInfo to the path info struct.
* rendering/shapes/BoxShape.cpp:
(WebCore::BoxShape::buildPath): Build the path for a BoxShape.
* rendering/shapes/BoxShape.h:
* rendering/shapes/PolygonShape.cpp:
(WebCore::PolygonShape::buildPath): Build the path for a PolygonShape.
* rendering/shapes/PolygonShape.h:
* rendering/shapes/RasterShape.h:
* rendering/shapes/RectangleShape.cpp:
(WebCore::RectangleShape::buildPath): Build the path for a RectangleShape.
* rendering/shapes/RectangleShape.h:
* rendering/shapes/Shape.h:

LayoutTests:

The shapes paths are now drawn in shape-coordinate space before being translated to
renderer space. With different writing modes, shapes may have their coordinates
translated. For example, a rectangle specified as four points [top left, top right,
bottom right, bottom left] in vertical-lr space would appear as [top left, bottom left,
bottom right, top right] in horizontal-tb space. Adjusting the previous tests, and
adding a test for the new box value.

* inspector-protocol/model/highlight-shape-outside-expected.txt:
* inspector-protocol/model/highlight-shape-outside.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCodeBlock::m_numCalleeRegisters need to honor native stack alignment.
mark.lam@apple.com [Fri, 22 Nov 2013 03:12:13 +0000 (03:12 +0000)]
CodeBlock::m_numCalleeRegisters need to honor native stack alignment.
https://bugs.webkit.org/show_bug.cgi?id=124754.

Reviewed by Filip Pizlo.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::newRegister):
* dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago<https://webkit.org/b/124702> Stop overriding VALID_ARCHS.
mrowe@apple.com [Fri, 22 Nov 2013 03:04:12 +0000 (03:04 +0000)]
<https://webkit.org/b/124702> Stop overriding VALID_ARCHS.

All modern versions of Xcode set it appropriately for our needs.

Reviewed by Alexey Proskuryakov.

Source/JavaScriptCore:

* Configurations/Base.xcconfig:

Source/WebCore:

* Configurations/Base.xcconfig:

Source/WebInspectorUI:

* Configurations/Base.xcconfig:

Source/WebKit/mac:

* Configurations/Base.xcconfig:

Source/WebKit2:

* Configurations/Base.xcconfig:

Tools:

* MiniBrowser/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agowebkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element
commit-queue@webkit.org [Fri, 22 Nov 2013 03:01:55 +0000 (03:01 +0000)]
webkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element
https://bugs.webkit.org/show_bug.cgi?id=124676

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-21
Reviewed by Daniel Bates.

checkForArgumentAndRemoveFromArrayRef functions was removing wrong
elements when there were more then one occurrence of that argument.
E.g: Checking for 'a' in {a, b, a, c}, the resulting array would be
{b, a}, when it should be {b, c}.

* Scripts/webkitdirs.pm:
(checkForArgumentAndRemoveFromArrayRef): bugfix mentioned above.
* Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
Added; Unit tests for webkitdirs::checkForArgumentAndRemoveFromArrayRef function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Unreviewed buildfix after r159614 and r159656.
ryumiel@company100.net [Fri, 22 Nov 2013 03:01:26 +0000 (03:01 +0000)]
[GTK] Unreviewed buildfix after r159614 and r159656.

Source/WebCore:

* bindings/gobject/WebKitDOMCustom.cpp: Add missing header

Source/WebKit2:

* UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
(WebKit::WebInspectorServer::buildPageList): Use the page load state to get page title.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix WinCairo unreachable code warnings in SimpleLineLayout.cpp
commit-queue@webkit.org [Fri, 22 Nov 2013 02:59:45 +0000 (02:59 +0000)]
Fix WinCairo unreachable code warnings in SimpleLineLayout.cpp
https://bugs.webkit.org/show_bug.cgi?id=124704

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-21
Reviewed by Antti Koivisto.

Fix unreachable code warnings using conditional directives.

* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago<https://webkit.org/b/124701> Fix an error in a few Xcode configuration setting files.
mrowe@apple.com [Fri, 22 Nov 2013 02:57:41 +0000 (02:57 +0000)]
<https://webkit.org/b/124701> Fix an error in a few Xcode configuration setting files.

Reviewed by Alexey Proskuryakov.

Source/JavaScriptCore:

* Configurations/Base.xcconfig:

Source/ThirdParty/ANGLE:

* Configurations/Base.xcconfig:

Source/WebCore:

* Configurations/Base.xcconfig:

Source/WebKit/mac:

* Configurations/Base.xcconfig:

Source/WebKit2:

* Configurations/Base.xcconfig:

Source/WTF:

* Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUpdate build-webkit after r159550.
rniwa@webkit.org [Fri, 22 Nov 2013 02:56:22 +0000 (02:56 +0000)]
Update build-webkit after r159550.

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago<https://webkit.org/b/124700> Fix some deprecation warnings.
mrowe@apple.com [Fri, 22 Nov 2013 02:55:19 +0000 (02:55 +0000)]
<https://webkit.org/b/124700> Fix some deprecation warnings.

Reviewed by Anders Carlsson.

Source/WebCore:

* platform/mac/HTMLConverter.mm:
(fileWrapperForURL): Move off a deprecated NSFileWrapper method.

Source/WebKit/mac:

* Plugins/WebNetscapePluginStream.mm:
(WebNetscapePluginStream::startStream): Move off a deprecated NSData method.
* WebView/WebDataSource.mm:
(-[WebDataSource _fileWrapperForURL:]): Move off a deprecated NSFileWrapper method.
* WebView/WebHTMLView.mm:
(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.

Source/WebKit2:

* UIProcess/API/mac/WKView.mm:
(-[WKView namesOfPromisedFilesDroppedAtDestination:]): Move off a deprecated NSFileWrapper method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Layout tests with editing need to be rebaselined.
commit-queue@webkit.org [Fri, 22 Nov 2013 02:53:04 +0000 (02:53 +0000)]
[EFL] Layout tests with editing need to be rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=124751

Unreviewed, EFL rebaseline.

editing/input/reveal-caret-of-multiline-contenteditable.html test is rebaselined after r137239.
editing/selection/5354455-2.html test is rebaselined after r133000.
Rebaseline the expected results to suit editing-related performance in EFL.

Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-21

* platform/efl-wk1/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
* platform/efl/editing/selection/5354455-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUpdate apple builders.
lforschler@apple.com [Fri, 22 Nov 2013 02:38:21 +0000 (02:38 +0000)]
Update apple builders.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoImport some W3C tests for HTML template element
rniwa@webkit.org [Fri, 22 Nov 2013 02:20:08 +0000 (02:20 +0000)]
Import some W3C tests for HTML template element
https://bugs.webkit.org/show_bug.cgi?id=124699

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Imported the shared resources for web-platform-tests/html-templates as well as tests under
serializing-html-templates and template-element at a274ad93ef5dc02ac042e0a5d58327d4135178ac.

* ChangeLog: Added.
* html-templates/resources/end-template-tag-in-body.html: Added.
* html-templates/resources/end-template-tag-in-head.html: Added.
* html-templates/resources/frameset-end-tag.html: Added.
* html-templates/resources/head-template-contents-div-no-end-tag.html: Added.
* html-templates/resources/head-template-contents-table-no-end-tag.html: Added.
* html-templates/resources/html-start-tag.html: Added.
* html-templates/resources/template-child-nodes-div.xhtml: Added.
* html-templates/resources/template-child-nodes-nested.xhtml: Added.
* html-templates/resources/template-contents-attribute.html: Added.
* html-templates/resources/template-contents-body.html: Added.
* html-templates/resources/template-contents-div-no-end-tag.html: Added.
* html-templates/resources/template-contents-empty.html: Added.
* html-templates/resources/template-contents-frameset.html: Added.
* html-templates/resources/template-contents-head.html: Added.
* html-templates/resources/template-contents-html.html: Added.
* html-templates/resources/template-contents-nested.html: Added.
* html-templates/resources/template-contents-table-no-end-tag.html: Added.
* html-templates/resources/template-contents-text.html: Added.
* html-templates/resources/template-contents.html: Added.
* html-templates/resources/template-descendant-body.html: Added.
* html-templates/resources/template-descendant-frameset.html: Added.
* html-templates/resources/template-descendant-head.html: Added.
* html-templates/resources/two-templates.html: Added.
* html-templates/serializing-html-templates/outerhtml-expected.txt: Added.
* html-templates/serializing-html-templates/outerhtml.html: Added.
* html-templates/template-element/content-attribute-expected.txt: Added.
* html-templates/template-element/content-attribute.html: Added.
* html-templates/template-element/node-document-changes-expected.txt: Added.
* html-templates/template-element/node-document-changes.html: Added.
* html-templates/template-element/template-as-a-descendant-expected.txt: Added.
* html-templates/template-element/template-as-a-descendant.html: Added.
* html-templates/template-element/template-content-expected.txt: Added.
* html-templates/template-element/template-content-node-document-expected.txt: Added.
* html-templates/template-element/template-content-node-document.html: Added.
* html-templates/template-element/template-content.html: Added.
* html-templates/template-element/template-descendant-body-expected.txt: Added.
* html-templates/template-element/template-descendant-body.html: Added.
* html-templates/template-element/template-descendant-frameset-expected.txt: Added.
* html-templates/template-element/template-descendant-frameset.html: Added.
* html-templates/template-element/template-descendant-head-expected.txt: Added.
* html-templates/template-element/template-descendant-head.html: Added.
* html-templates/testcommon.js: Added.

LayoutTests:

* imported/w3c/: Added.
* platform/win/TestExpectations: Skip the imported tests since the template element is disabled on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDon't fetch hidden platforms on build.webkit.org/dashboard
dino@apple.com [Fri, 22 Nov 2013 02:12:12 +0000 (02:12 +0000)]
Don't fetch hidden platforms on build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=124750

Reviewed by Tim Horton.

If a platform is hidden, don't fetch its data. If it
becomes unhidden, try to fetch immediately (unless
you've recently fetched).

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159659 268f45cc-cd09-0410-ab3c-d52691b4dbfc