WebKit-https.git
8 years ago[chromium] Don't draw when canDraw() is false
danakj@chromium.org [Thu, 10 May 2012 00:41:28 +0000 (00:41 +0000)]
[chromium] Don't draw when canDraw() is false
https://bugs.webkit.org/show_bug.cgi?id=85829

Reviewed by Adrienne Walker.

Source/WebCore:

This is based on the work of Daniel Sievers in bug
https://bugs.webkit.org/show_bug.cgi?id=82680. When canDraw() is false,
we should not call drawLayers() or prepareToDraw() in both Single- and
Multi-Threaded mode.

drawLayers() is crashing in single threaded mode, and this attempts to
prevent it from being called with invalid state. While making it behave
properly in single-threaded mode, it seems appropriate to unrevert the
parts of 82680 that made threaded mode behave similarly appropriately.

A single-threaded test is not included since LTHTests is unable to run
in single-threaded mode at this time (pending work from Ian Vollick). So
we test in threaded mode only with a note to include a single thread
version.

Tests: CCLayerTreeHostTestCanDrawBlocksDrawing.runMultiThread

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::CCLayerTreeHostImpl::drawLayers):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doComposite):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::CCLayerTreeHostImplTest::CCLayerTreeHostImplTest):
(WebKitTests::TEST_F):
* tests/CCLayerTreeHostTest.cpp:
(WTF):
(CCLayerTreeHostTestCanDrawBlocksDrawing):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::CCLayerTreeHostTestCanDrawBlocksDrawing):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::beginTest):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::didCommitAndDrawFrame):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::afterTest):
(WTF::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Build fix after r116464.
rakuco@webkit.org [Thu, 10 May 2012 00:35:47 +0000 (00:35 +0000)]
[EFL] Build fix after r116464.

`ulong' is a type defined by glibc, so it is not very
portable. Use `unsigned long' instead.

* DumpRenderTree/efl/EventSender.cpp:
(DelayedEvent::DelayedEvent):
(DelayedEvent):
(leapForwardCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Cairo] GLContextGLX releases the context with an uninitialized display
commit-queue@webkit.org [Thu, 10 May 2012 00:34:48 +0000 (00:34 +0000)]
[Cairo] GLContextGLX releases the context with an uninitialized display
https://bugs.webkit.org/show_bug.cgi?id=86039

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-05-09
Reviewed by Philippe Normand.

No new tests. This does not change behavior on most machines, but has
the potential to prevent a pretty nasty crash on others.

Use the shared display to release GLX contexts instead of the uninitialized
m_display member.

* platform/graphics/glx/GLContextGLX.cpp:
(WebCore::GLContextGLX::~GLContextGLX): Release the display with the shared
display.
* platform/graphics/glx/GLContextGLX.h:
(GLContextGLX): Remove the m_display member.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSubresources loaded after a reload completes shouldn't be revalidated.
tonyg@chromium.org [Thu, 10 May 2012 00:32:55 +0000 (00:32 +0000)]
Subresources loaded after a reload completes shouldn't be revalidated.
https://bugs.webkit.org/show_bug.cgi?id=84614

Source/WebCore:

Based on patch by Darin Fisher.

Reviewed by Darin Fisher.

Tests: http/tests/cache/loaded-from-cache-after-reload-within-iframe.html
       http/tests/cache/loaded-from-cache-after-reload.html

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Reset m_loadType after the load completes.

LayoutTests:

Tests by Darin Fisher.

Reviewed by Darin Fisher.

* http/tests/cache/loaded-from-cache-after-reload-expected.txt: Added.
* http/tests/cache/loaded-from-cache-after-reload-within-iframe-expected.txt: Added.
* http/tests/cache/loaded-from-cache-after-reload-within-iframe.html: Added.
* http/tests/cache/loaded-from-cache-after-reload.html: Added.
* http/tests/cache/resources/loaded-from-cache-after-reload-within-iframe-subframe.html: Added.
* http/tests/cache/resources/random-cached.cgi: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIt should be possible to get useful debug logging from the JIT memory allocator
fpizlo@apple.com [Thu, 10 May 2012 00:19:55 +0000 (00:19 +0000)]
It should be possible to get useful debug logging from the JIT memory allocator
https://bugs.webkit.org/show_bug.cgi?id=86042

Reviewed by Geoff Garen.

Source/JavaScriptCore:

* jit/ExecutableAllocator.h:

Source/WTF:

* wtf/MetaAllocator.cpp:
(WTF::MetaAllocator::findAndRemoveFreeSpace):
(WTF::MetaAllocator::addFreeSpace):
(WTF::MetaAllocator::dumpProfile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r116573.
commit-queue@webkit.org [Thu, 10 May 2012 00:18:23 +0000 (00:18 +0000)]
Unreviewed, rolling out r116573.
http://trac.webkit.org/changeset/116573
https://bugs.webkit.org/show_bug.cgi?id=86038

Broke the Chromium Mac compile (Requested by ojan_gardening on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-09

* public/WebPlugin.h:
(WebPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] LayoutTestController should use ENABLE guards for some features
abarth@webkit.org [Thu, 10 May 2012 00:15:11 +0000 (00:15 +0000)]
[Chromium] LayoutTestController should use ENABLE guards for some features
https://bugs.webkit.org/show_bug.cgi?id=86030

Reviewed by Eric Seidel.

These features are disabled on OS(ANDROID) and so shouldn't be compiled
when the feature is off.

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/chromium/TestShell.h:
(TestShell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Fix issue where V8BindingPerContextData could keep the context object alive
arv@chromium.org [Thu, 10 May 2012 00:14:49 +0000 (00:14 +0000)]
[V8] Fix issue where V8BindingPerContextData could keep the context object alive
https://bugs.webkit.org/show_bug.cgi?id=86036

Reviewed by Kentaro Hara.

This is a partial revert of http://trac.webkit.org/changeset/114320/. This keeps
the layout tests that were introduced since it turns out that
http://trac.webkit.org/changeset/114989 fixes the tests too.

Covered by: http/tests/security/isolatedWorld/context-destroy.html

* bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::destroy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSpeed up some parts of TileCache drawing
andersca@apple.com [Thu, 10 May 2012 00:12:48 +0000 (00:12 +0000)]
Speed up some parts of TileCache drawing
https://bugs.webkit.org/show_bug.cgi?id=86033
<rdar://problem/10919373>

Reviewed by Sam Weinig.

* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::tileCoverageRect):
If we can't have scrollbars, there's not much need to extend the tile coverage rect outside of the visible rect, since it's
unlikely that we'll do any form of scrolling here.

(WebCore::TileCache::revalidateTiles):
Don't update the tile layer frame if it's big enough to contain the tile size. Also, if there are no new tiles created,
don't call platformCALayerDidCreateTiles since that will trigger an extra layer flush.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGC race condition in OpaqueJSClass::prototype
barraclough@apple.com [Thu, 10 May 2012 00:04:25 +0000 (00:04 +0000)]
GC race condition in OpaqueJSClass::prototype
https://bugs.webkit.org/show_bug.cgi?id=86034

Build fix.

* API/JSClassRef.cpp:
(OpaqueJSClass::prototype):
    - Eeeep, landed bad version of patch!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGC race condition in OpaqueJSClass::prototype
barraclough@apple.com [Wed, 9 May 2012 23:56:05 +0000 (23:56 +0000)]
GC race condition in OpaqueJSClass::prototype
https://bugs.webkit.org/show_bug.cgi?id=86034

Reviewed by Filip Pizlo.

The bug here is basically:
    if (weakref) weakref->method()
where a GC may occur between the if & the method call.

* API/JSClassRef.cpp:
(OpaqueJSClass::prototype):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agosetPageScaleFactor should setScrollPosition if scale is unchanged
commit-queue@webkit.org [Wed, 9 May 2012 23:44:03 +0000 (23:44 +0000)]
setPageScaleFactor should setScrollPosition if scale is unchanged
https://bugs.webkit.org/show_bug.cgi?id=84400

Patch by Alexandre Elias <aelias@google.com> on 2012-05-09
Reviewed by Adam Barth.

Previously, setPageScaleFactor forgot about its "origin" argument if
the page scale factor is unchanged.  This has proven undesirable in
practice because, for example, a single pinch gesture may zoom in and
back out to the original page scale factor, but at a different scroll
offset.

New test case added to scale-and-scroll-body-expected.txt

* page/Page.cpp:
(WebCore::Page::setPageScaleFactor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Expose WebPluginContainer of WebPlugin to embedder
fsamuel@chromium.org [Wed, 9 May 2012 23:33:57 +0000 (23:33 +0000)]
[Chromium] Expose WebPluginContainer of WebPlugin to embedder
https://bugs.webkit.org/show_bug.cgi?id=85916

Reviewed by Darin Fisher.

The browser plugin needs to access its current guest's  WebPluginContainer
so that it can replace the guest with another guest WebPlugin when navigating
across processes.

* public/WebPlugin.h:
(WebPlugin):
(WebKit::WebPlugin::container):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix overzealous re-opened since blocked by... message
tomz@codeaurora.org [Wed, 9 May 2012 23:22:04 +0000 (23:22 +0000)]
Fix overzealous re-opened since blocked by... message
https://bugs.webkit.org/show_bug.cgi?id=86020

Reviewed by Adam Barth.

Changed CreateBug behavior to only re-open a blocked bug if it
was RESOLVED.  Also had to update the test infrastructure slightly
to allow for distinct mock commit revisions, so one could point
to a RESOLVED bug for testing while another pointed to an OPEN bug.

Also moved default created mock bug to be 60001 instead of 50004
which already exists as a reference mock bug.

* Scripts/webkitpy/common/checkout/checkout_mock.py:
(MockCheckout.__init__):
(MockCheckout.commit_info_for_revision):
* Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
(MockBugzilla.create_bug):
* Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
* Scripts/webkitpy/tool/commands/download_unittest.py:
(test_create_rollout_resolved):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(FailureReasonTest.test_blame_line_for_revision):
* Scripts/webkitpy/tool/steps/createbug.py:
(CreateBug.run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse suitable viewport values on XHTML-MP pages.
commit-queue@webkit.org [Wed, 9 May 2012 23:10:21 +0000 (23:10 +0000)]
Use suitable viewport values on XHTML-MP pages.
https://bugs.webkit.org/show_bug.cgi?id=85425

Patch by Hugo Parente Lima <hugo.lima@openbossa.org> on 2012-05-09
Reviewed by Kenneth Rohde Christiansen.

.:

Add LEGACY_VIEWPORT_ADAPTION use feature to cmake build system,
this feature will enable the use of a suitable viewport size
on legacy XHTML-MP pages.

* Source/cmake/WebKitFeatures.cmake:

Source/WebCore:

Tests: fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype.html
       fast/viewport/viewport-legacy-xhtmlmp-ordering.html
       fast/viewport/viewport-legacy-xhtmlmp.html

Use device-width and device-height as viewport size on
XHTML-MP pages if the use feature LEGACY_VIEWPORT_ADAPTION
is set according as the non normative section of
http://www.w3.org/TR/css-device-adapt/

* dom/Document.cpp:
(WebCore::Document::setDocType):

Tools:

Enable LEGACY_VIEWPORT_ADAPTION on Qt port.

* qmake/mkspecs/features/features.prf:

LayoutTests:

Add tests for legacy viewport adaption and skip them
on all ports but the Qt one.

* fast/viewport/viewport-legacy-xhtmlmp-expected.txt: Added.
* fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype-expected.txt: Added.
* fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype.html: Added.
* fast/viewport/viewport-legacy-xhtmlmp-ordering-expected.txt: Added.
* fast/viewport/viewport-legacy-xhtmlmp-ordering.html: Added.
* fast/viewport/viewport-legacy-xhtmlmp.html: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=86025
bdakin@apple.com [Wed, 9 May 2012 23:06:06 +0000 (23:06 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=86025
RTL and vertical text documents do no scroll properly with the new
tiled scrolling model
-and corresponding-
<rdar://problem/11077589>

Reviewed by Dan Bernstein.

Most of the fix here is just to teach the scrolling tree about the
scroll origin.
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::setScrollParameters):
* page/scrolling/ScrollingCoordinator.h:
(ScrollParameters):
* page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::update):
* page/scrolling/ScrollingTreeNode.h:
(WebCore::ScrollingTreeNode::scrollOrigin):
(ScrollingTreeNode):
* page/scrolling/ScrollingTreeState.cpp:
(WebCore::ScrollingTreeState::setScrollOrigin):
(WebCore):
* page/scrolling/ScrollingTreeState.h:
(WebCore::ScrollingTreeState::scrollOrigin):
(ScrollingTreeState):
* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::scrollPosition):
(WebCore::ScrollingTreeNodeMac::setScrollLayerPosition):
(WebCore::ScrollingTreeNodeMac::minimumScrollPosition):
(WebCore::ScrollingTreeNodeMac::maximumScrollPosition):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidScroll):

Teaching the scrolling tree about the scroll origin revealed this pre-
existing bug. layoutOverflowRect() is not the right rect to use since
it is not writing-mode savvy. unscaledDocumentRect() is the right rect
for the view's bounds.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateCompositedBounds):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCleanup SVGElement.cpp
rwlbuis@webkit.org [Wed, 9 May 2012 22:53:02 +0000 (22:53 +0000)]
Cleanup SVGElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=86004

Reviewed by Eric Seidel.

Remove unneeded includes. We do not need to check attr in SVGElement::attributeChanged,
lower layers assume it is non-null and we do not call attributeChanged in SVG.

* svg/SVGElement.cpp:
(WebCore::SVGElement::attributeChanged):
(WebCore::SVGElement::isAnimatableAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Move clipboard to Platform.h
pilgrim@chromium.org [Wed, 9 May 2012 22:50:48 +0000 (22:50 +0000)]
[Chromium] Move clipboard to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85758

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::clipboard):
* chromium/public/WebClipboard.h: Added.
(WebKit):
(WebClipboard):
(WebKit::WebClipboard::sequenceNumber):
(WebKit::WebClipboard::isFormatAvailable):
(WebKit::WebClipboard::readAvailableTypes):
(WebKit::WebClipboard::readPlainText):
(WebKit::WebClipboard::readHTML):
(WebKit::WebClipboard::readImage):
(WebKit::WebClipboard::readCustomData):
(WebKit::WebClipboard::writePlainText):
(WebKit::WebClipboard::writeHTML):
(WebKit::WebClipboard::writeURL):
(WebKit::WebClipboard::writeImage):
(WebKit::WebClipboard::writeDataObject):
(WebKit::WebClipboard::~WebClipboard):
* chromium/public/WebDragData.h: Added.
(WebKit):
(WebDragData):
(WebKit::WebDragData::~WebDragData):
(WebKit::WebDragData::WebDragData):
(WebKit::WebDragData::operator=):
(WebKit::WebDragData::isNull):
* chromium/public/WebImage.h: Added.
(WebKit):
(WebImage):
(WebKit::WebImage::~WebImage):
(WebKit::WebImage::WebImage):
(WebKit::WebImage::operator=):
(WebKit::WebImage::getSkBitmap):
(WebKit::WebImage::init):
(WebKit::WebImage::getCGImageRef):

Source/WebKit/chromium:

* WebKit.gyp:
* public/platform/WebClipboard.h:
* public/platform/WebDragData.h:
* public/platform/WebImage.h:
* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKitPlatformSupport):
* src/AssertMatchingEnums.cpp:
* src/DragClientImpl.cpp:
* src/PlatformSupport.cpp:
* src/WebDragData.cpp:
* src/WebImageCG.cpp:
* src/WebImageDecoder.cpp:
* src/WebImageSkia.cpp:
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::copy):
* src/WebViewImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCopiedSpace does not add pinned blocks back to the to-space filter
mhahnenberg@apple.com [Wed, 9 May 2012 22:50:42 +0000 (22:50 +0000)]
CopiedSpace does not add pinned blocks back to the to-space filter
https://bugs.webkit.org/show_bug.cgi?id=86011

Reviewed by Geoffrey Garen.

After a collection has finished, we go through the blocks in from-space
and move any of them that are pinned into to-space. At the beginning of
collection, we reset the to-space block filter that is used during
conservative scanning and add back the blocks that are filled during the
collection. However, we neglect to add back those blocks that are moved
from from-space to to-space, which can cause the conservative scan to
think that some pinned items are not actually in CopiedSpace.

* heap/CopiedSpace.cpp:
(JSC::CopiedSpace::doneCopying): Add the pinned blocks back to the
to-space filter. Also added a comment and assert for future readers that
indicates that it's okay that we don't also add the block to the
to-space block set since it was never removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoadd some basic perf-o-matic tests for flexbox
tony@chromium.org [Wed, 9 May 2012 22:45:20 +0000 (22:45 +0000)]
add some basic perf-o-matic tests for flexbox
https://bugs.webkit.org/show_bug.cgi?id=86017

Reviewed by Ryosuke Niwa.

Each of these tests take < 3s on my machine.

* Layout/flexbox-column-nowrap.html: Added.
* Layout/flexbox-column-wrap.html: Added.
* Layout/flexbox-row-nowrap.html: Added.
* Layout/flexbox-row-wrap.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWhen creating a new page during a navigation, prime the initial document with the...
jochen@chromium.org [Wed, 9 May 2012 22:13:12 +0000 (22:13 +0000)]
When creating a new page during a navigation, prime the initial document with the correct referrer policy
https://bugs.webkit.org/show_bug.cgi?id=86001

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/referrer-policy-redirect-link.html

* dom/Document.h:
(WebCore::Document::setReferrerPolicy):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):

Tools:

Store the referrer policy in the request, so the network stack can comply with it.

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::willSendRequest):

LayoutTests:

Skip the test on all but chromium, see https://bugs.webkit.org/show_bug.cgi?id=86000

* http/tests/security/referrer-policy-redirect-link-expected.txt: Added.
* http/tests/security/referrer-policy-redirect-link.html: Added.
* http/tests/security/resources/referrer-policy-postmessage.php: Added.
* http/tests/security/resources/referrer-policy-redirect-link.html: Added.
* platform/efl/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: call abort handler when there are problems committing
commit-queue@webkit.org [Wed, 9 May 2012 22:09:10 +0000 (22:09 +0000)]
IndexedDB: call abort handler when there are problems committing
https://bugs.webkit.org/show_bug.cgi?id=85841

Patch by Alec Flett <alecflett@chromium.org> on 2012-05-09
Reviewed by Ojan Vafai.

No new tests. Every existing test that calls commit() is testing
the success side of this, and this only throws when there are
LevelDB errors, which is exactly what we're trying to diagnose
with this patch.

* Modules/indexeddb/IDBBackingStore.h:
(Transaction):
* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::deleteDatabase):
(WebCore::IDBLevelDBBackingStore::Transaction::commit):
* Modules/indexeddb/IDBLevelDBBackingStore.h:
(Transaction):
* Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::commit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Remove PlatformSupport::loadPlatformImageResource, call loadResource directly
pilgrim@chromium.org [Wed, 9 May 2012 22:06:27 +0000 (22:06 +0000)]
[Chromium] Remove PlatformSupport::loadPlatformImageResource, call loadResource directly
https://bugs.webkit.org/show_bug.cgi?id=84417

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/graphics/chromium/ImageChromium.cpp:
(WebCore::Image::loadPlatformResource):
* platform/graphics/chromium/ImageChromiumMac.mm: Removed.

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate compositing/RTL tests to fail if the root layer is shifted incorrectly
enne@google.com [Wed, 9 May 2012 22:01:09 +0000 (22:01 +0000)]
Update compositing/RTL tests to fail if the root layer is shifted incorrectly
https://bugs.webkit.org/show_bug.cgi?id=85820

Reviewed by James Robinson.

For the Chromium port, if the root layer was shifted incorrectly, the
non-composited red indicator layers would get drawn outside the root
layers bounds, making it impossible to see if the test was failing.

Also turn off overflow:hidden because compositing/ tests have mock
scrollbars. This makes it much easier to debug these tests locally.

* compositing/rtl/rtl-absolute-expected.png:
* compositing/rtl/rtl-absolute-overflow-expected.png:
* compositing/rtl/rtl-absolute-overflow-expected.txt:
* compositing/rtl/rtl-absolute-overflow-scrolled-expected.png:
* compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
* compositing/rtl/rtl-absolute-overflow-scrolled.html:
* compositing/rtl/rtl-absolute-overflow.html:
* compositing/rtl/rtl-absolute.html:
* compositing/rtl/rtl-fixed-expected.png:
* compositing/rtl/rtl-fixed-overflow-expected.png:
* compositing/rtl/rtl-fixed-overflow-expected.txt:
* compositing/rtl/rtl-fixed-overflow-scrolled-expected.png:
* compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
* compositing/rtl/rtl-fixed-overflow-scrolled.html:
* compositing/rtl/rtl-fixed-overflow.html:
* compositing/rtl/rtl-fixed.html:
* compositing/rtl/rtl-iframe-absolute-overflow-expected.png:
* compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
* compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png:
* compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
* compositing/rtl/rtl-iframe-fixed-overflow-expected.png:
* compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
* compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png:
* compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove CYGWIN=tty from environment variable as its no longer supported
commit-queue@webkit.org [Wed, 9 May 2012 21:56:11 +0000 (21:56 +0000)]
Remove CYGWIN=tty from environment variable as its no longer supported
https://bugs.webkit.org/show_bug.cgi?id=85791

The CYGWIN=tty environment variable is no longer supported from Cygwin
version 1.7.10. This fix avoids addition of this environment variable
for Cygwin versions greater than 1.7.9. For supporting older versions
i.e. 1.7.9 or older, the script takes care of retaining the environment
variable.

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-05-09
Reviewed by Adam Roben.

* Scripts/webkitdirs.pm:
(setupAppleWinEnv):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] remove the obsolete WebFrame::referrerPolicy method
jochen@chromium.org [Wed, 9 May 2012 21:27:36 +0000 (21:27 +0000)]
[chromium] remove the obsolete WebFrame::referrerPolicy method
https://bugs.webkit.org/show_bug.cgi?id=86003

Reviewed by Adam Barth.

* public/WebFrame.h:
* src/WebFrameImpl.cpp:
* src/WebFrameImpl.h:
(WebFrameImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove some isSVGFoo methods
commit-queue@webkit.org [Wed, 9 May 2012 21:20:08 +0000 (21:20 +0000)]
Remove some isSVGFoo methods
https://bugs.webkit.org/show_bug.cgi?id=86009

Patch by Rob Buis <rbuis@rim.com> on 2012-05-09
Reviewed by Eric Seidel.

These are not used at the moment and were probably just copy and pasted from
isSVGFoo methods in RenderObject.h.

* rendering/RenderObject.h:
* rendering/svg/RenderSVGEllipse.h:
(RenderSVGEllipse):
* rendering/svg/RenderSVGRect.h:
(RenderSVGRect):
* rendering/svg/RenderSVGShape.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Check whether an active document loader exists before accessing it
jochen@chromium.org [Wed, 9 May 2012 21:17:35 +0000 (21:17 +0000)]
[chromium] Check whether an active document loader exists before accessing it
https://bugs.webkit.org/show_bug.cgi?id=85892

Reviewed by Eric Seidel.

Although FrameLoader::loadInSameDocument which invokes this
method does not have a provisional document loader, we're seeing crashes
where the FrameLoader is in provisional state, and thus
activeDocumentLoader returns 0. Lacking any understanding of how this
can happen, we do this check here to avoid crashing.

* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add impl-thread support for fill-mode and direction css animation properties
commit-queue@webkit.org [Wed, 9 May 2012 20:27:03 +0000 (20:27 +0000)]
[chromium] Add impl-thread support for fill-mode and direction css animation properties
https://bugs.webkit.org/show_bug.cgi?id=77662

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-09
Reviewed by James Robinson.

Source/WebCore:

Adds support for accelerating css animations with -webkit-animation-fill-mode,
and -webkit-animation-direction properties.

Tested in:
  CCActiveAnimationTest.TrimTimeAlternating
  CCLayerAnimationControllerTest.createReversedAnimation
  CCLayerAnimationControllerTest.createAlternatingAnimation
  CCLayerAnimationControllerTest.createReversedAlternatingAnimation

* platform/graphics/chromium/cc/CCActiveAnimation.cpp:
(WebCore::CCActiveAnimation::CCActiveAnimation):
(WebCore::CCActiveAnimation::trimTimeToCurrentIteration):
(WebCore::CCActiveAnimation::cloneForImplThread):
* platform/graphics/chromium/cc/CCActiveAnimation.h:
(CCActiveAnimation):
(WebCore::CCActiveAnimation::alternatesDirection):
(WebCore::CCActiveAnimation::setAlternatesDirection):
* platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

Source/WebKit/chromium:

* tests/CCActiveAnimationTest.cpp:
(WebCore::TEST):
(WebCore):
* tests/CCLayerAnimationControllerTest.cpp:
(WebKitTests::TEST):
(WebKitTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
zandobersek@gmail.com [Wed, 9 May 2012 20:25:15 +0000 (20:25 +0000)]
[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591

Reviewed by Philippe Normand.

Remove all the test expectations for tests that seem to consistently
pass on the Gtk bots but are expected to crash. Any tests that backfire
will have their bug entries updated or closed otherwise.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: --skip-failing-tests should also skip flaky tests
dpranke@chromium.org [Wed, 9 May 2012 19:59:44 +0000 (19:59 +0000)]
nrwt: --skip-failing-tests should also skip flaky tests
https://bugs.webkit.org/show_bug.cgi?id=85941

Reviewed by Ojan Vafai.

This changes --skip-failing-tests so that we skip tests that
are believed to pass sometimes as well as tests that are
believed to always fail.

In addition, in testing this I discovered that we had lousy
test coverage of the details of retrying test failures and
--clobber-old-results, so I wrote some more tests.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.prepare_lists_and_print_output):
* Scripts/webkitpy/layout_tests/port/test.py:
(unit_test_list):
(TestPort.__init__):
(TestDriver.run_test):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_skip_failing_tests):
(MainTest.test_retrying_and_flaky_tests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash from removal of a line break object
commit-queue@webkit.org [Wed, 9 May 2012 19:48:51 +0000 (19:48 +0000)]
Crash from removal of a line break object
https://bugs.webkit.org/show_bug.cgi?id=85997

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-05-09
Reviewed by David Hyatt.

Source/WebCore:

Regression from r115343. That replaced a call to setNeedsLayout()
with a separate call that used a different bit during linebox
invalidation after renderer child removal. There are special cases
where layout isn't marked on parent nodes just from the removal, so
line dirtying needs to explicitly mark ancestors for layout.

* rendering/RenderObject.h:
(WebCore::RenderObject::setAncestorLineBoxDirty):

LayoutTests:

Test case to exercise crashing condition in bug 85997.

* fast/block/line-layout/line-break-removal-near-textarea-crash-expected.txt: Added
* fast/block/line-layout/line-break-removal-near-textarea-crash.html: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] REGRESSION(r113678):After this change fast/text/text-stroke-width-cairo...
alexis.menard@openbossa.org [Wed, 9 May 2012 19:37:24 +0000 (19:37 +0000)]
[Qt][WK2] REGRESSION(r113678):After this change fast/text/text-stroke-width-cairo-dos.html makes the next test crash
https://bugs.webkit.org/show_bug.cgi?id=83582

Unreviewed gardening : I don't observe crashes anymore.

* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix performance regression for floats caused by LayoutUnit change
leviw@chromium.org [Wed, 9 May 2012 19:36:05 +0000 (19:36 +0000)]
Fix performance regression for floats caused by LayoutUnit change
https://bugs.webkit.org/show_bug.cgi?id=85834

Reviewed by Ojan Vafai.

Refactoring FractionalLayout types to alleviate performance issues. Explicitly
inlining constructor and operator functions in FractionalLayoutUnit, as well as
pixelSnappedIntSize and pixelSnappedIntRect (particularly hot code paths). Also
further simplifying round and ceil functions when sub-pixel layout is not enabled.

pixelSnappedIntSize was the only function defined in FractionalLayoutSize.cpp,
so it is removed.

No new tests. No change in functionality.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::FractionalLayoutUnit):
(FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::toInt):
(WebCore::FractionalLayoutUnit::toFloat):
(WebCore::FractionalLayoutUnit::toDouble):
(WebCore::FractionalLayoutUnit::toUnsigned):
(WebCore::FractionalLayoutUnit::operator int):
(WebCore::FractionalLayoutUnit::operator unsigned):
(WebCore::FractionalLayoutUnit::operator float):
(WebCore::FractionalLayoutUnit::operator double):
(WebCore::FractionalLayoutUnit::operator bool):
(WebCore::FractionalLayoutUnit::ceil):
(WebCore::FractionalLayoutUnit::round):
* platform/graphics/FractionalLayoutRect.cpp:
(WebCore):
* platform/graphics/FractionalLayoutRect.h:
(WebCore::FractionalLayoutRect::pixelSnappedSize):
(WebCore::pixelSnappedIntRect):
(WebCore):
* platform/graphics/FractionalLayoutSize.cpp: Removed.
* platform/graphics/FractionalLayoutSize.h:
(WebCore):
* rendering/LayoutTypes.h:
(WebCore::pixelSnappedIntSize):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
ojan@chromium.org [Wed, 9 May 2012 19:01:03 +0000 (19:01 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][DRT] EFL's DRT needs to support LayoutTestController.dumpIconChanges()
commit-queue@webkit.org [Wed, 9 May 2012 18:40:25 +0000 (18:40 +0000)]
[EFL][DRT] EFL's DRT needs to support LayoutTestController.dumpIconChanges()
https://bugs.webkit.org/show_bug.cgi?id=84435

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-09
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Emit a "icon,changed" signal on the frame when its favion changed.
Clarify that the "icon,loaded" signal is only emitted for the main
frame.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveIcon):
(WebCore::FrameLoaderClientEfl::dispatchDidChangeIcons):
* ewk/ewk_frame.cpp:
(ewk_frame_icon_changed):
* ewk/ewk_frame.h:
* ewk/ewk_private.h:

Tools:

Catch the "icon,changed" signal on the frames in EFL's DumpRenderTree
to support LayoutTestController's dumpIconChanges().

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameIconChanged):
(DumpRenderTreeChrome::onFrameCreated):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):

LayoutTests:

Unskip the test checking for DumpRenderTree's support for
LayoutTestController's dumpIconChanges() in EFL port.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Wed, 9 May 2012 18:30:58 +0000 (18:30 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-5.0/fast/text/international/text-spliced-font-expected.png: Added.
* platform/qt-5.0/fast/text/international/text-spliced-font-expected.txt: Added.
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash in ReplaceSelectionCommand::performTrivialReplace
inferno@chromium.org [Wed, 9 May 2012 18:28:39 +0000 (18:28 +0000)]
Crash in ReplaceSelectionCommand::performTrivialReplace
https://bugs.webkit.org/show_bug.cgi?id=85943

Reviewed by Ryosuke Niwa.

Source/WebCore:

RefPtr nodeAfterInsertionPos to guard against mutation events.

Test: editing/inserting/insert-html-crash.html

* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::performTrivialReplace):

LayoutTests:

* editing/inserting/insert-html-crash-expected.txt: Added.
* editing/inserting/insert-html-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Exposes OrientationChangeEvent.
bulach@chromium.org [Wed, 9 May 2012 17:58:47 +0000 (17:58 +0000)]
[chromium] Exposes OrientationChangeEvent.
https://bugs.webkit.org/show_bug.cgi?id=85976

Reviewed by Adam Barth.

This is used by the android port, we need to expose the existing
WebCore API.

* public/WebFrame.h:
(WebFrame):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::sendOrientationChangeEvent):
(WebKit):
* src/WebFrameImpl.h:
(WebFrameImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHit testing is incorrect in some cases with perspective transforms
shawnsingh@chromium.org [Wed, 9 May 2012 17:57:50 +0000 (17:57 +0000)]
Hit testing is incorrect in some cases with perspective transforms
https://bugs.webkit.org/show_bug.cgi?id=79136

Reviewed by Simon Fraser.

Source/WebCore:

Tests: transforms/3d/hit-testing/coplanar-with-camera.html
       transforms/3d/hit-testing/perspective-clipped.html

* platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::projectPoint): Fix a
divide-by-zero error so that values do not become Inf or Nan. Also
fix an overflow error by using a large, but not-too-large constant
to represent infinity.

(WebCore::TransformationMatrix::projectQuad): Fix an error where
incorrect quads were being returned. Incorrect quads can occur
when projectPoint clamped==true after returning.

LayoutTests:

* transforms/3d/hit-testing/coplanar-with-camera-expected.txt: Added.
* transforms/3d/hit-testing/coplanar-with-camera.html: Added.
* transforms/3d/hit-testing/perspective-clipped-expected.txt: Added.
* transforms/3d/hit-testing/perspective-clipped.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTextarea-placeholder-wrapping.html may fail because of scrollbars
commit-queue@webkit.org [Wed, 9 May 2012 17:47:03 +0000 (17:47 +0000)]
Textarea-placeholder-wrapping.html may fail because of scrollbars
https://bugs.webkit.org/show_bug.cgi?id=85989

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-09
Reviewed by Ryosuke Niwa.

Increasing rows to avoid scrollbar single pixel differences
to cause failures of this test.

* fast/forms/textarea-placeholder-wrapping-expected.html:
* fast/forms/textarea-placeholder-wrapping.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Missing WebPreferences for media playback requiring user gestures and inline...
commit-queue@webkit.org [Wed, 9 May 2012 17:23:24 +0000 (17:23 +0000)]
[GTK] Missing WebPreferences for media playback requiring user gestures and inline playback
https://bugs.webkit.org/show_bug.cgi?id=85194

Patch by Simon Pena <spena@igalia.com> on 2012-05-09
Reviewed by Martin Robinson.

Expose WebPreferences for media playback requires user gesture and
media playback allows inline to GTK side.

This adds two properties (mediaPlaybackRequiresUserGesture and
mediaPlaybackAllowsInline) to GTK WebKit WebSettings, and connects
them to the WebKit WebView, so clients can programmatically modify
them.

* webkit/webkitwebsettings.cpp: install new properties and update
setter and getter
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
* webkit/webkitwebsettingsprivate.h: add media playback related
properties
* webkit/webkitwebview.cpp: connect newly added properties
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSimplify CSSParser::parseSimpleLengthValue()
caio.oliveira@openbossa.org [Wed, 9 May 2012 17:06:19 +0000 (17:06 +0000)]
Simplify CSSParser::parseSimpleLengthValue()
https://bugs.webkit.org/show_bug.cgi?id=85910

Reviewed by Alexis Menard.

Various small improvements to this function, mainly:
- Move the check if the property ID accepts a simple length as early as possible;
- Remove the check for the characters{8,16} pointers since they'll be valid (we ASSERT that);
- Use a template to avoid duplicate code for 8 and 16 bit characters.

* css/CSSParser.cpp:
(WebCore):
(WebCore::parseSimpleLength):
(WebCore::parseSimpleLengthValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Support multiple buffered time ranges
fischman@chromium.org [Wed, 9 May 2012 17:02:50 +0000 (17:02 +0000)]
[chromium] Support multiple buffered time ranges
https://bugs.webkit.org/show_bug.cgi?id=85926

Reviewed by Eric Carlson.

Preserve existing rendering of a single rect even in the presence of multiple buffered regions.

No new tests as this change has no functional effects.

* rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaSlider):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEarly-out and avoid any copying when possible for Region operations
danakj@chromium.org [Wed, 9 May 2012 17:01:16 +0000 (17:01 +0000)]
Early-out and avoid any copying when possible for Region operations
https://bugs.webkit.org/show_bug.cgi?id=85260

Reviewed by Anders Carlsson.

Source/WebCore:

For an empty region, any intersection or subtraction will not modify
the region, so we can simply return instead of creating a new Shape
and replacing the current empty Shape.

When a region is united with a region it contains, the orignal
containing region is the result. So, if A.unite(B) and A.contains(B)
then A does not need to change at all and we can return without making
a copy of A's shape. When A is a rect, we can do this test even more
simply.

We also remove redundant checks from trySimpleOperation() methods, where
the test is already done in the Region calling site.

This change improves the performance of the Region overlap testing for
composited layers, and allows us to avoid unnecessary copies of the
Region during unite. With a layout test (attached to bug #81087), that
creates a Region from the union of 225 composited layers, as well as
600 overlapping layers above them, this change decreases the running
time of the test by 3.2% by avoiding a copy of the entire Region for
each insertion that does not change the resulting Region.

Unit tests: RegionTest.unite

* platform/graphics/Region.cpp:
(WebCore::Region::Shape::UnionOperation::trySimpleOperation):
(WebCore::Region::Shape::IntersectOperation::trySimpleOperation):
(WebCore::Region::Shape::SubtractOperation::trySimpleOperation):
(WebCore::Region::intersect):
(WebCore::Region::unite):
(WebCore::Region::subtract):
* platform/graphics/Region.h:
(WebCore::Region::isRect):
(WebCore::Region::Shape::isRect):

Source/WebKit/chromium:

* tests/RegionTest.cpp:
(WebCore::TEST):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkit-patch upload Fails Behind Load-balancing Proxies
commit-queue@webkit.org [Wed, 9 May 2012 16:32:57 +0000 (16:32 +0000)]
webkit-patch upload Fails Behind Load-balancing Proxies
https://bugs.webkit.org/show_bug.cgi?id=85980

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-09
Reviewed by Adam Barth.

Unchecking the login restriction to IP to allow the tool
to function behind load-balancing proxies that use multiple
outgoing IPs.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.authenticate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Enable PAGE_POPUP in make file, and implement required methods
commit-queue@webkit.org [Wed, 9 May 2012 16:31:24 +0000 (16:31 +0000)]
[BlackBerry] Enable PAGE_POPUP in make file, and implement required methods
https://bugs.webkit.org/show_bug.cgi?id=85907

.:

Patch by Crystal Zhang <haizhang@rim.com> on 2012-05-09
Reviewed by Rob Buis.

Enable PAGE_POPUP option in make files.

Internal reviewed by Yong Li.

* Source/cmake/OptionsBlackBerry.cmake:
* Source/cmakeconfig.h.cmake:

Source/WebKit/blackberry:

Patch by Crystal Zhang <haizhang@rim.com> on 2012-05-09
Reviewed by Rob Buis.

Internal reviewed by Yong Li.

Enable PAGE_POPUP so we can use WebCore::PagePopup and WebCore::PagePopupClient interface.
Implement virtual methods in WebCore::ChromeClientBlackBerry that required for the
implementation and add methods in WebKit::WebPage that needed for PagePopupClient.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
(BlackBerry::WebKit::WebPage::initPopupWebView):
(WebKit):
(BlackBerry::WebKit::WebPage::popupOpened):
(BlackBerry::WebKit::WebPage::popupClosed):
(BlackBerry::WebKit::WebPage::hasOpenedPopup):
(BlackBerry::WebKit::WebPage::popup):
(BlackBerry::WebKit::WebPagePrivate::setParentPopup):
* Api/WebPage.h:
(WebCore):
* Api/WebPage_p.h:
(WebCore):
(WebPagePrivate):
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::hasOpenedPopup):
(WebCore::ChromeClientBlackBerry::openPagePopup):
(WebCore):
(WebCore::ChromeClientBlackBerry::closePagePopup):
* WebCoreSupport/ChromeClientBlackBerry.h:
(WebCore):
(ChromeClientBlackBerry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] shared-stylesheet-mutation tests are flaky
commit-queue@webkit.org [Wed, 9 May 2012 16:21:52 +0000 (16:21 +0000)]
[EFL] shared-stylesheet-mutation tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=85901

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-09
Reviewed by Antti Koivisto.

This test is flaky on EFL because the timeout for applying
the style is too short for a Debug build.

* http/tests/css/resources/shared-stylesheet-mutation.js:
(executeTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Split WebKit2 Makefile moving source code listings to GNUmakefile.list.am
carlosgc@webkit.org [Wed, 9 May 2012 16:08:56 +0000 (16:08 +0000)]
[GTK] Split WebKit2 Makefile moving source code listings to GNUmakefile.list.am
https://bugs.webkit.org/show_bug.cgi?id=85985

Reviewed by Gustavo Noronha Silva.

.:

* GNUmakefile.am:

Source/WebKit2:

* GNUmakefile.am:
* GNUmakefile.list.am: Copied from Source/WebKit2/GNUmakefile.am.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Use independent version numbers for public libraries
carlosgc@webkit.org [Wed, 9 May 2012 16:05:13 +0000 (16:05 +0000)]
[GTK] Use independent version numbers for public libraries
https://bugs.webkit.org/show_bug.cgi?id=85984

Reviewed by Gustavo Noronha Silva.

.:

* configure.ac: Define LIBJAVASCRIPTCOREGTK_VERSION and
LIBWEBKIT2GTK_VERSION using the same version as
LIBWEBKITGTK_VERSION for backwards compatibility.

Source/JavaScriptCore:

* GNUmakefile.am: Use LIBJAVASCRIPTCOREGTK_VERSION for library
version.

Source/WebKit2:

* GNUmakefile.am: Use LIBWEBKIT2GTK_VERSION for library version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Do not install JavaScriptCore platform-specific headers
carlosgc@webkit.org [Wed, 9 May 2012 16:02:35 +0000 (16:02 +0000)]
[GTK] Do not install JavaScriptCore platform-specific headers
https://bugs.webkit.org/show_bug.cgi?id=85983

Reviewed by Gustavo Noronha Silva.

JavaScriptCore.h includes JSStringRefCF.h unconditionally. It was
renamed to JavaScript.h in r29234 and it still exists for
compatibility with mac and windows users.

* GNUmakefile.list.am: Remove JavaScriptCore.h, JSStringRefCF.h
and JSStringRefBSTR.h from the sources and headers list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][DRT] Gardening failures and crashes
commit-queue@webkit.org [Wed, 9 May 2012 15:57:21 +0000 (15:57 +0000)]
[EFL][DRT] Gardening failures and crashes
https://bugs.webkit.org/show_bug.cgi?id=85996

Unreviewed, EFL gardening.

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-09

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMediaStream API: SessionDescription::addCandidate should not crash for malformed...
tommyw@google.com [Wed, 9 May 2012 15:55:58 +0000 (15:55 +0000)]
MediaStream API: SessionDescription::addCandidate should not crash for malformed input
https://bugs.webkit.org/show_bug.cgi?id=85988

Reviewed by Adam Barth.

Source/WebCore:

Sending null would crash the browser. Added safeguards in both the bindings and the native code.

Test: fast/mediastream/SessionDescription.html

* Modules/mediastream/SessionDescription.cpp:
(WebCore::SessionDescription::addCandidate):
* Modules/mediastream/SessionDescription.h:
(SessionDescription):
* Modules/mediastream/SessionDescription.idl:

LayoutTests:

* fast/mediastream/SessionDescription-expected.txt: Added.
* fast/mediastream/SessionDescription.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMediaStream API: Adding the possibility of port specific information in MediaStreamDe...
tommyw@google.com [Wed, 9 May 2012 15:49:04 +0000 (15:49 +0000)]
MediaStream API: Adding the possibility of port specific information in MediaStreamDescriptor
https://bugs.webkit.org/show_bug.cgi?id=85794

Reviewed by Adam Barth.

To facilitate for ports I have added an ExtraData field that can be used for whatever purpose is needed.

Source/Platform:

* chromium/public/WebMediaStreamDescriptor.h:
(ExtraData):
(WebKit::WebMediaStreamDescriptor::ExtraData::~ExtraData):
(WebMediaStreamDescriptor):

Source/WebCore:

No behavioral changes.

* platform/chromium/support/WebMediaStreamDescriptor.cpp:
(ExtraDataContainer):
(WebKit::ExtraDataContainer::ExtraDataContainer):
(WebKit::ExtraDataContainer::extraData):
(WebKit):
(WebKit::WebMediaStreamDescriptor::extraData):
(WebKit::WebMediaStreamDescriptor::setExtraData):
* platform/mediastream/MediaStreamDescriptor.h:
(ExtraData):
(WebCore::MediaStreamDescriptor::ExtraData::~ExtraData):
(MediaStreamDescriptor):
(WebCore::MediaStreamDescriptor::extraData):
(WebCore::MediaStreamDescriptor::setExtraData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] MediaStream API: Fixing a memory leak in WebUserMediaRequest
tommyw@google.com [Wed, 9 May 2012 15:45:01 +0000 (15:45 +0000)]
[chromium] MediaStream API: Fixing a memory leak in WebUserMediaRequest
https://bugs.webkit.org/show_bug.cgi?id=85992

Reviewed by Adam Barth.

* src/WebUserMediaRequest.cpp:
(WebKit::WebUserMediaRequest::assign):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash in WebCore::RenderBoxModelObject::paddingLeft
commit-queue@webkit.org [Wed, 9 May 2012 15:37:33 +0000 (15:37 +0000)]
Crash in WebCore::RenderBoxModelObject::paddingLeft
https://bugs.webkit.org/show_bug.cgi?id=83889

Patch by Takashi Sakamoto <tasak@google.com> on 2012-05-09
Reviewed by Abhishek Arya.

Source/WebCore:

RenderScrollbar creates RenderScrollbarPart without any parent
renderers. However, if the scrollbar has percent padding styles,
non-null parent renderer is required. So after creating/destroying
RenderScrollbarPart instances, set owningRenderer(creating)/0
(destroying) as its parent renderer.

Test: scrollbars/scrollbar-percent-padding-crash.html
      scrollbars/scrollbar-percent-padding-crash-expected.txt

* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::updateScrollbarPart):
Added setParent after creating/destroying RenderScrollbarPart.
* rendering/RenderScrollbarPart.cpp:
Made RenderScollbar friend, because setParent is protected and
RenderScrollbar is not inherited from class RenderObject.

LayoutTests:

As just invoking layoutTestController.display() invokes scrollbar's
WebCore::RenderScrollbarPart::paintIntoRect(), adding display() after
invoking layoutTestController.dumpAsText().

* scrollbars/scrollbar-percent-padding-crash.html: Added.
* scrollbars/scrollbar-percent-padding-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium-android] Add unit test for Android layout test script (chromium_android.py)
commit-queue@webkit.org [Wed, 9 May 2012 15:28:01 +0000 (15:28 +0000)]
[Chromium-android] Add unit test for Android layout test script (chromium_android.py)
https://bugs.webkit.org/show_bug.cgi?id=80852

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-05-09
Reviewed by Adam Barth.

Add some tests to ensure that chromium android port works to some
extent. Some methods is hard to test, as they rely on the actual
behavior on device, e.g. pushing files to device.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.get_last_stacktrace): Check if dir exists.
* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidPortTest):
(ChromiumAndroidPortTest.test_attributes):
(ChromiumAndroidPortTest.test_get_last_stacktrace):
(ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_no_dir):
(ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_no_file):
(ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_non_empty):
(ChromiumAndroidDriverTest):
(ChromiumAndroidDriverTest.setUp):
(ChromiumAndroidDriverTest.test_get_drt_return_value):
(ChromiumAndroidDriverTest.test_has_crash_hint):
(ChromiumAndroidDriverTest.test_read_prompt):
(ChromiumAndroidDriverTest.test_test_shell_command):
(ChromiumAndroidDriverTest.test_write_command_and_read_line):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] don't use soup_session_pause_message in webkitdownload
danw@gnome.org [Wed, 9 May 2012 15:23:20 +0000 (15:23 +0000)]
[GTK] don't use soup_session_pause_message in webkitdownload
https://bugs.webkit.org/show_bug.cgi?id=85931

Reviewed by Martin Robinson.

* webkit/webkitdownload.cpp:
(webkit_download_new_with_handle):
(webkit_download_start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSkip failing test http/tests/loading/post-in-iframe-with-back-navigation.html.
antti@apple.com [Wed, 9 May 2012 15:14:54 +0000 (15:14 +0000)]
Skip failing test http/tests/loading/post-in-iframe-with-back-navigation.html.

Not reviewed.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTest from bug 34875 should specify font-size
antti@apple.com [Wed, 9 May 2012 14:40:43 +0000 (14:40 +0000)]
Test from bug 34875 should specify font-size
https://bugs.webkit.org/show_bug.cgi?id=85913

Not reviewed.

Skip fast/block/positioning/offsetLeft-offsetTop-multicolumn.html

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening a timeout failure
commit-queue@webkit.org [Wed, 9 May 2012 13:19:52 +0000 (13:19 +0000)]
[EFL] Gardening a timeout failure
https://bugs.webkit.org/show_bug.cgi?id=85979

Unreviewed, EFL gardening.

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-09

* platform/efl/test_expectations.txt: Adding font-face-download-error.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShadowRoot needs applyAuthorStyles
commit-queue@webkit.org [Wed, 9 May 2012 12:53:42 +0000 (12:53 +0000)]
ShadowRoot needs applyAuthorStyles
https://bugs.webkit.org/show_bug.cgi?id=78472

Patch by Takashi Sakamoto <tasak@google.com> on 2012-05-09
Reviewed by Hajime Morita.

Source/WebCore:

Implemented applyAuthorStyles attribute defined in the following spec:
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#shadow-root-attributes
Since applyAuthorSheets attribute has been already implemented,
renamed all applyAuthorSheets to applyAuthorStyles and
added applyAuthorStyles to ShadowRoot.idl.
Currently, changing dynamically applyAuthorStyles doesn't work. I will fix this isse in bugs:84215: https://bugs.webkit.org/show_bug.cgi?id=84251

Test: fast/dom/shadow/shadow-root-applyAuthorStyles.html
      fast/dom/shadow/shadow-root-applyAuthorStyles-expected.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::applyAuthorStyles):
(WebCore::ShadowRoot::setApplyAuthorStyles):
* dom/ShadowRoot.h:
* dom/TreeScope.cpp:
(WebCore::TreeScope::applyAuthorStyles):
* dom/TreeScope.h:
(TreeScope):
Changed all applyAuthorSheets to applyAuthorSytles.
(ShadowRoot):
* dom/ShadowRoot.idl:
Added a new attribute, boolean applyAuthorStyles.

LayoutTests:

* fast/dom/shadow/shadow-root-applyAuthorStyles.html:
* fast/dom/shadow/shadow-root-applyAuthorStyles-expected.html:
Tested four cases:
case 1: applyAuthorStyles is false,
case 2: applyAuthorStyles is true with <script>..</script>,
case 3: applyAuthorStyles is true with inline script declaration, and
case 4: applyAuthorStyles is true with important UA property.
The case 1, 2 and 3 specify "span { ... }" with author styles and
verify rendering results.
The case 4 specifies '<input type="file" />' with an author style,
text-align: end, and verify rendering result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Tap-to-zoom zooms to wrong area.
commit-queue@webkit.org [Wed, 9 May 2012 12:39:39 +0000 (12:39 +0000)]
[Qt] Tap-to-zoom zooms to wrong area.
https://bugs.webkit.org/show_bug.cgi?id=85982

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-09
Reviewed by Kenneth Rohde Christiansen.

Fix computation and take more care when to use CSS scale and when to use Item scale.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] fast/overflow/scroll-div-hide-show.html testcase does not pass
commit-queue@webkit.org [Wed, 9 May 2012 12:34:01 +0000 (12:34 +0000)]
[EFL] fast/overflow/scroll-div-hide-show.html testcase does not pass
https://bugs.webkit.org/show_bug.cgi?id=85960

Unreviewed. Gardening.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-09

* platform/efl/Skipped: Skipping fast/overflow/scroll-div-hide-show.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] ORWT fails with Qt 5 and WK2.
commit-queue@webkit.org [Wed, 9 May 2012 12:22:17 +0000 (12:22 +0000)]
[Qt] ORWT fails with Qt 5 and WK2.
https://bugs.webkit.org/show_bug.cgi?id=85968

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-09
Reviewed by Csaba Osztrogonác.

The Qt5 binary does not have a -style argument, so avoid using it.

* Scripts/old-run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][DRT] Add baselines for new CSS cases after r116438
commit-queue@webkit.org [Wed, 9 May 2012 12:19:12 +0000 (12:19 +0000)]
[EFL][DRT] Add baselines for new CSS cases after r116438
https://bugs.webkit.org/show_bug.cgi?id=85967

Unreviewed, add EFL baselines for new tests after r116438.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-09

* platform/efl/css2.1/20110323/first-letter-000-expected.png: Added.
* platform/efl/css2.1/20110323/first-letter-000-expected.txt: Added.
* platform/efl/css2.1/20110323/first-letter-001-expected.png: Added.
* platform/efl/css2.1/20110323/first-letter-001-expected.txt: Added.
* platform/efl/css2.1/20110323/first-letter-dynamic-001-expected.png: Added.
* platform/efl/css2.1/20110323/first-letter-dynamic-001-expected.txt: Added.
* platform/efl/css2.1/20110323/first-letter-dynamic-002-expected.png: Added.
* platform/efl/css2.1/20110323/first-letter-dynamic-002-expected.txt: Added.
* platform/efl/css2.1/20110323/first-letter-dynamic-003a-expected.png: Added.
* platform/efl/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Added.
* platform/efl/css2.1/20110323/first-letter-dynamic-003b-expected.png: Added.
* platform/efl/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Added.
* platform/efl/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
* platform/efl/css2.1/20110323/first-letter-inherit-001-expected.txt: Added.
* platform/efl/css2.1/20110323/first-letter-nested-001-expected.png: Added.
* platform/efl/css2.1/20110323/first-letter-nested-001-expected.txt: Added.
* platform/efl/css2.1/20110323/first-letter-nested-002-expected.png: Added.
* platform/efl/css2.1/20110323/first-letter-nested-002-expected.txt: Added.
* platform/efl/css2.1/20110323/first-letter-nested-003-expected.png: Added.
* platform/efl/css2.1/20110323/first-letter-nested-003-expected.txt: Added.
* platform/efl/css2.1/20110323/first-letter-nested-004-expected.png: Added.
* platform/efl/css2.1/20110323/first-letter-nested-004-expected.txt: Added.
* platform/efl/css2.1/20110323/first-letter-nested-005-expected.png: Added.
* platform/efl/css2.1/20110323/first-letter-nested-005-expected.txt: Added.
* platform/efl/css2.1/20110323/first-letter-nested-006-expected.png: Added.
* platform/efl/css2.1/20110323/first-letter-nested-006-expected.txt: Added.
* platform/efl/css2.1/20110323/first-letter-nested-007-expected.png: Added.
* platform/efl/css2.1/20110323/first-letter-nested-007-expected.txt: Added.
* platform/efl/css2.1/20110323/first-letter-quote-001-expected.png: Added.
* platform/efl/css2.1/20110323/first-letter-quote-001-expected.txt: Added.
* platform/efl/css2.1/20110323/first-letter-quote-002-expected.png: Added.
* platform/efl/css2.1/20110323/first-letter-quote-002-expected.txt: Added.
* platform/efl/css2.1/20110323/first-letter-quote-003-expected.png: Added.
* platform/efl/css2.1/20110323/first-letter-quote-003-expected.txt: Added.
* platform/efl/css2.1/20110323/first-letter-quote-004-expected.png: Added.
* platform/efl/css2.1/20110323/first-letter-quote-004-expected.txt: Added.
* platform/efl/css2.1/20110323/first-letter-quote-005-expected.png: Added.
* platform/efl/css2.1/20110323/first-letter-quote-005-expected.txt: Added.
* platform/efl/css2.1/20110323/first-letter-quote-006-expected.png: Added.
* platform/efl/css2.1/20110323/first-letter-quote-006-expected.txt: Added.
* platform/efl/fast/css/first-letter-nested-positioned-expected.png: Added.
* platform/efl/fast/css/first-letter-nested-positioned-expected.txt: Added.
* platform/efl/fast/css/first-letter-quotes-no-content-before-after-expected.png: Added.
* platform/efl/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Define clear split between QtWebPageLoadClient and QQuickWebViewPrivate...
commit-queue@webkit.org [Wed, 9 May 2012 12:11:17 +0000 (12:11 +0000)]
[Qt][WK2] Define clear split between QtWebPageLoadClient and QQuickWebViewPrivate for loading tasks.
https://bugs.webkit.org/show_bug.cgi?id=84527#c3

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-09
Reviewed by Simon Hausmann.

Moving loading related code and signal emission from QtWebPageLoadClient to QQuickWebViewPrivate.
It puts the loading code that implements an API right where the API is defined, including
signal emission as well as translation of WebPageProxy internals to public Qt API with correct types.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::provisionalLoadDidStart):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::didSameDocumentNavigation):
(QQuickWebViewPrivate::titleDidChange):
(QQuickWebViewPrivate::loadProgressDidChange):
(QQuickWebViewPrivate::backForwardListDidChange):
(QQuickWebViewPrivate::loadDidFail):
(QQuickWebViewPrivate::processDidCrash):
(QQuickWebView::loadProgress):
* UIProcess/API/qt/qquickwebview_p_p.h:
(WebKit):
(QQuickWebViewPrivate):
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate::loadProgress):
(QQuickWebViewFlickablePrivate):
* UIProcess/qt/QtWebError.cpp:
(WebKit::QtWebError::isCancellation):
(WebKit):
* UIProcess/qt/QtWebError.h:
* UIProcess/qt/QtWebPageLoadClient.cpp:
(WebKit::QtWebPageLoadClient::QtWebPageLoadClient):
(WebKit):
(WebKit::QtWebPageLoadClient::didStartProvisionalLoad):
(WebKit::QtWebPageLoadClient::didCommitLoad):
(WebKit::QtWebPageLoadClient::didSameDocumentNavigation):
(WebKit::QtWebPageLoadClient::didReceiveTitle):
(WebKit::QtWebPageLoadClient::didChangeProgress):
(WebKit::QtWebPageLoadClient::didChangeBackForwardList):
(WebKit::QtWebPageLoadClient::dispatchLoadFailed):
(WebKit::QtWebPageLoadClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::QtWebPageLoadClient::didFailLoadWithErrorForFrame):
(WebKit::QtWebPageLoadClient::didStartProgress):
(WebKit::QtWebPageLoadClient::didFinishProgress):
* UIProcess/qt/QtWebPageLoadClient.h:
(WebKit):
(QtWebPageLoadClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, add platform specific expected files for new tests.
ossy@webkit.org [Wed, 9 May 2012 11:38:36 +0000 (11:38 +0000)]
[Qt] Unreviewed gardening, add platform specific expected files for new tests.

* platform/qt/css2.1/20110323/first-letter-000-expected.png: Added.
* platform/qt/css2.1/20110323/first-letter-000-expected.txt: Added.
* platform/qt/css2.1/20110323/first-letter-001-expected.png: Added.
* platform/qt/css2.1/20110323/first-letter-001-expected.txt: Added.
* platform/qt/css2.1/20110323/first-letter-dynamic-001-expected.png: Added.
* platform/qt/css2.1/20110323/first-letter-dynamic-001-expected.txt: Added.
* platform/qt/css2.1/20110323/first-letter-dynamic-002-expected.png: Added.
* platform/qt/css2.1/20110323/first-letter-dynamic-002-expected.txt: Added.
* platform/qt/css2.1/20110323/first-letter-dynamic-003a-expected.png: Added.
* platform/qt/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Added.
* platform/qt/css2.1/20110323/first-letter-dynamic-003b-expected.png: Added.
* platform/qt/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Added.
* platform/qt/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
* platform/qt/css2.1/20110323/first-letter-inherit-001-expected.txt: Added.
* platform/qt/css2.1/20110323/first-letter-nested-001-expected.png: Added.
* platform/qt/css2.1/20110323/first-letter-nested-001-expected.txt: Added.
* platform/qt/css2.1/20110323/first-letter-nested-002-expected.png: Added.
* platform/qt/css2.1/20110323/first-letter-nested-002-expected.txt: Added.
* platform/qt/css2.1/20110323/first-letter-nested-003-expected.png: Added.
* platform/qt/css2.1/20110323/first-letter-nested-003-expected.txt: Added.
* platform/qt/css2.1/20110323/first-letter-nested-004-expected.png: Added.
* platform/qt/css2.1/20110323/first-letter-nested-004-expected.txt: Added.
* platform/qt/css2.1/20110323/first-letter-nested-005-expected.png: Added.
* platform/qt/css2.1/20110323/first-letter-nested-005-expected.txt: Added.
* platform/qt/css2.1/20110323/first-letter-nested-006-expected.png: Added.
* platform/qt/css2.1/20110323/first-letter-nested-006-expected.txt: Added.
* platform/qt/css2.1/20110323/first-letter-nested-007-expected.png: Added.
* platform/qt/css2.1/20110323/first-letter-nested-007-expected.txt: Added.
* platform/qt/css2.1/20110323/first-letter-quote-001-expected.png: Added.
* platform/qt/css2.1/20110323/first-letter-quote-001-expected.txt: Added.
* platform/qt/css2.1/20110323/first-letter-quote-002-expected.png: Added.
* platform/qt/css2.1/20110323/first-letter-quote-002-expected.txt: Added.
* platform/qt/css2.1/20110323/first-letter-quote-003-expected.png: Added.
* platform/qt/css2.1/20110323/first-letter-quote-003-expected.txt: Added.
* platform/qt/css2.1/20110323/first-letter-quote-004-expected.png: Added.
* platform/qt/css2.1/20110323/first-letter-quote-004-expected.txt: Added.
* platform/qt/css2.1/20110323/first-letter-quote-005-expected.png: Added.
* platform/qt/css2.1/20110323/first-letter-quote-005-expected.txt: Added.
* platform/qt/css2.1/20110323/first-letter-quote-006-expected.png: Added.
* platform/qt/css2.1/20110323/first-letter-quote-006-expected.txt: Added.
* platform/qt/fast/block/float/avoiding-float-centered-expected.png: Added.
* platform/qt/fast/block/float/avoiding-float-centered-expected.txt: Added.
* platform/qt/fast/css/first-letter-nested-positioned-expected.png: Added.
* platform/qt/fast/css/first-letter-nested-positioned-expected.txt: Added.
* platform/qt/fast/css/first-letter-quotes-no-content-before-after-expected.png: Added.
* platform/qt/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Added.
* platform/qt/fast/html/details-marker-style-expected.png: Added.
* platform/qt/fast/html/details-marker-style-expected.txt: Added.
* platform/qt/fast/images/png-suite/test-expected.txt: Added.
* platform/qt/fast/text/international/text-spliced-font-expected.png: Added.
* platform/qt/fast/text/international/text-spliced-font-expected.txt: Added.
* platform/qt/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
* platform/qt/svg/as-image/image-respects-pageScaleFactor-expected.txt: Added.
* platform/qt/svg/custom/path-zero-strokewidth-expected.png: Added.
* platform/qt/svg/custom/path-zero-strokewidth-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, add a platform specific expected file for a passing test.
ossy@webkit.org [Wed, 9 May 2012 11:13:02 +0000 (11:13 +0000)]
[Qt] Unreviewed gardening, add a platform specific expected file for a passing test.

* platform/qt-5.0-wk2/fast/repaint/focus-ring-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium][Forms] HTMLOptionsCollection doesn't have indexed properties on property...
commit-queue@webkit.org [Wed, 9 May 2012 11:10:53 +0000 (11:10 +0000)]
[Chromium][Forms] HTMLOptionsCollection doesn't have indexed properties on property enumeration
https://bugs.webkit.org/show_bug.cgi?id=85937

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-05-09
Reviewed by Kentaro Hara.

Source/WebCore:

This patch adds numeric indices to properties in enumeration to HTMLOptionsCollection V8 binding
to changes Objects.keys in ECMAScript5 and for-in statement behavior for compatibility with
Firefox 12, IE9, Opera 11, and Safari 5.

Test: fast/forms/select/options-indexed-properties.html

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementationIndexer): Set $hasEnumerator true for interface HTMLOptionsCollection

LayoutTests:

* fast/forms/select/options-indexed-properties-expected.txt: Added.
* fast/forms/select/options-indexed-properties.html: Added.
* platform/chromium/inspector/console/console-format-collections-expected.txt: Changed for HTMLOptionCollection printed output

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] http/tests/loading/post-in-iframe-with-back-navigation.html fails
commit-queue@webkit.org [Wed, 9 May 2012 11:02:29 +0000 (11:02 +0000)]
[EFL] http/tests/loading/post-in-iframe-with-back-navigation.html fails
https://bugs.webkit.org/show_bug.cgi?id=85974

Unreviewed EFL gardening.

Move http/tests/loading/post-in-iframe-with-back-navigation.html to
test_expectations.txt. This test was added in r116473 but fails on all
the bots.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-09

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMediaStream API: Adding a test for constructed from JS MediaStreams
tommyw@google.com [Wed, 9 May 2012 10:49:10 +0000 (10:49 +0000)]
MediaStream API: Adding a test for constructed from JS MediaStreams
https://bugs.webkit.org/show_bug.cgi?id=85883

Reviewed by Kent Tamura.

Also moved shouldNotThrow to js-test-pre, and removed it from all mediastream tests.

* fast/js/resources/js-test-pre.js:
(shouldNotThrow):
* fast/mediastream/MediaStreamConstructor-expected.txt: Added.
* fast/mediastream/MediaStreamConstructor.html: Added.
* fast/mediastream/peerconnection-argument-types-expected.txt:
* fast/mediastream/peerconnection-iceoptions.html:
* fast/mediastream/script-tests/argument-types.js:
* fast/mediastream/script-tests/peerconnection-argument-types.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Test expectation update for media-stream tests
tkent@chromium.org [Wed, 9 May 2012 10:01:17 +0000 (10:01 +0000)]
[Chromium] Test expectation update for media-stream tests
https://bugs.webkit.org/show_bug.cgi?id=85952

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Gardening. Skip a failing test, remove an unnecessary platform specific expected...
ossy@webkit.org [Wed, 9 May 2012 09:37:48 +0000 (09:37 +0000)]
[Qt] Gardening. Skip a failing test, remove an unnecessary platform specific expected file.
https://bugs.webkit.org/show_bug.cgi?id=85969

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-05-09
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:
* platform/qt/fast/forms/form-collection-radio-node-list-expected.txt: Removed after r116491.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPosition should be able to have ShadowRoot as a container.
shinyak@chromium.org [Wed, 9 May 2012 09:26:57 +0000 (09:26 +0000)]
Position should be able to have ShadowRoot as a container.
https://bugs.webkit.org/show_bug.cgi?id=82021

Reviewed by Ryosuke Niwa.

Source/WebCore:

Since Position could not take a shadow root as a container node, pointing the direct children
of a shadow root was difficult.

This patch makes it enabled, and fixes a lot of crashes caused by that limitation.
Also, we confirm that ShadowRoot is not exposed to JavaScript layer.

Currently this change is only enabled if shadow dom flag is enabled, since we cannot
prove this change does not destroy the existing behavior. However, this change is really required
to fix other editing bugs in Shadow DOM. A bunch of patches and tests will be added to
fix other editing bugs and they will check this patch does not break editing.
We will also add a fuzzer to check the stability of editing in Shadow DOM later, and it will
also help to confirm the patch will not break the editing.

Tests: editing/shadow/doubleclick-on-meter-in-shadow-crash.html
       editing/shadow/rightclick-on-meter-in-shadow-crash.html
       editing/shadow/shadow-selection-not-exported.html

* dom/Position.cpp:
(WebCore::Position::Position):
(WebCore::Position::containerNode):
(WebCore::Position::parentAnchoredEquivalent):
(WebCore::Position::previous):
(WebCore::Position::next):
(WebCore::Position::atStartOfTree):
(WebCore::Position::atEndOfTree):
(WebCore::Position::findParent):
* dom/Position.h:
(WebCore):
(WebCore::positionInParentBeforeNode):
(WebCore::positionInParentAfterNode):

LayoutTests:

Skipped non-chromium port since SHADOW_DOM flag is not enabled in those platforms.
We will add bunch of tests for editing in Shadow DOM into editing/shadow later,
so I added the whole directory name to the skipped list.

* editing/shadow/doubleclick-on-meter-in-shadow-crash-expected.txt: Added.
* editing/shadow/doubleclick-on-meter-in-shadow-crash.html: Added.
* editing/shadow/rightclick-on-meter-in-shadow-crash-expected.txt: Added.
* editing/shadow/rightclick-on-meter-in-shadow-crash.html: Added.
* editing/shadow/shadow-selection-not-exported-expected.txt: Added.
* editing/shadow/shadow-selection-not-exported.html: Added.
* platform/efl/Skipped:
* platform/gtk/test_expectations.txt:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Build fix when using libpng version != 1.2
zoltan@webkit.org [Wed, 9 May 2012 09:07:41 +0000 (09:07 +0000)]
[Qt] Build fix when using libpng version != 1.2
https://bugs.webkit.org/show_bug.cgi?id=85614

Reviewed by Eric Seidel.

Don't enforce the version of libpng when passing the option to the linker.

No new tests, no intended functionality change.

* WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][DRT] LayoutTestController addUserScript implementation
commit-queue@webkit.org [Wed, 9 May 2012 09:04:02 +0000 (09:04 +0000)]
[EFL][DRT] LayoutTestController addUserScript implementation
https://bugs.webkit.org/show_bug.cgi?id=84718

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-09
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Added helper functions for adding/clearing of user scripts.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::addUserScript):
(DumpRenderTreeSupportEfl::clearUserScripts):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Added implementation of addUserScript() to LayoutTestController.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues): clear added user scripts
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::addUserScript): added implementation

LayoutTests:

Unskipped corresponding testcases.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Remove delayed loadDidSucceed() signaling and m_deferedUrlToLoad from QQuic...
commit-queue@webkit.org [Wed, 9 May 2012 08:42:14 +0000 (08:42 +0000)]
[Qt][WK2] Remove delayed loadDidSucceed() signaling and m_deferedUrlToLoad from QQuickWebViewPrivate
https://bugs.webkit.org/show_bug.cgi?id=85906

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-09
Reviewed by Kenneth Rohde Christiansen.

Deferred loading activies were introduced to work around the delayed Flickable construction
at onComponentComplete(). QQuickWebView inherits from QQuickFlickable now,
so no need for the workaround anymore.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebView::setUrl):
(QQuickWebView::componentComplete):
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate::onComponentComplete):
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Test expectation update.
tkent@chromium.org [Wed, 9 May 2012 08:34:33 +0000 (08:34 +0000)]
[Chromium] Test expectation update.

* platform/chromium/test_expectations.txt:
video-media-source-seek.html is also SLOW?

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Disable WebViewTest.TextInputType because the test is incomplete.
tkent@chromium.org [Wed, 9 May 2012 07:54:23 +0000 (07:54 +0000)]
[Chromium] Disable WebViewTest.TextInputType because the test is incomplete.

* tests/WebViewTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] http/tests/loading/pdf-commit-load-callbacks.html is failing
commit-queue@webkit.org [Wed, 9 May 2012 07:51:44 +0000 (07:51 +0000)]
[EFL] http/tests/loading/pdf-commit-load-callbacks.html is failing
https://bugs.webkit.org/show_bug.cgi?id=85957

Unreviewed gardening.

Move http/tests/loading/pdf-commit-load-callbacks.html to
test_expectations.txt while Bug 85956 is fixed.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-09

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMade build-webkit copy WebKitLibraries to the right location again after r116257
mitz@apple.com [Wed, 9 May 2012 07:46:28 +0000 (07:46 +0000)]
Made build-webkit copy WebKitLibraries to the right location again after r116257

Reviewed by Mark Rowe.

* Scripts/build-webkit: Pass the built product directory to copy-webkitlibraries-to-product-directory.
* Scripts/copy-webkitlibraries-to-product-directory: Use the first argument, if present, as the
product directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Some of *.runMultiThread tests intermittently crash.
tkent@chromium.org [Wed, 9 May 2012 07:42:52 +0000 (07:42 +0000)]
[Chromium] Some of *.runMultiThread tests intermittently crash.
Mark them flaky.

* tests/CCLayerTreeHostTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Add identifying methods for date/time input types.
commit-queue@webkit.org [Wed, 9 May 2012 07:19:50 +0000 (07:19 +0000)]
Source/WebCore: Add identifying methods for date/time input types.

This patch adds methods isDateField(), isDateTimeField(), isDateTimeLocalField(),
isMonthField(), isTimeField() and isWeekField() to InputType and the appropriate
HTMLInputElement classes, to allow date/time input types to be identified.

The new methods match the existing methods for types such as email, search and number.

https://bugs.webkit.org/show_bug.cgi?id=78746

Patch by Oli Lan <olilan@chromium.org> on 2012-05-09
Reviewed by Kent Tamura.

A new test WebViewTest.TextInputType has been added in WebKit/chromium/tests that calls
through to these methods via WebViewImpl.textInputType().

* html/DateInputType.cpp:
(WebCore::DateInputType::isDateField):
(WebCore):
* html/DateInputType.h:
(DateInputType):
* html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::isDateTimeField):
(WebCore):
* html/DateTimeInputType.h:
(DateTimeInputType):
* html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::isDateTimeLocalField):
(WebCore):
* html/DateTimeLocalInputType.h:
(DateTimeLocalInputType):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isDateField):
(WebCore):
(WebCore::HTMLInputElement::isDateTimeField):
(WebCore::HTMLInputElement::isDateTimeLocalField):
(WebCore::HTMLInputElement::isMonthField):
(WebCore::HTMLInputElement::isTimeField):
(WebCore::HTMLInputElement::isWeekField):
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/InputType.cpp:
(WebCore::InputType::isDateField):
(WebCore):
(WebCore::InputType::isDateTimeField):
(WebCore::InputType::isDateTimeLocalField):
(WebCore::InputType::isMonthField):
(WebCore::InputType::isTimeField):
(WebCore::InputType::isWeekField):
* html/InputType.h:
(InputType):
* html/MonthInputType.cpp:
(WebCore::MonthInputType::isMonthField):
(WebCore):
* html/MonthInputType.h:
(MonthInputType):
* html/TimeInputType.cpp:
(WebCore::TimeInputType::isTimeField):
(WebCore):
* html/TimeInputType.h:
(TimeInputType):
* html/WeekInputType.cpp:
(WebCore::WeekInputType::isWeekField):
(WebCore):
* html/WeekInputType.h:
(WeekInputType):

Source/WebKit/chromium: Adds date/time input types to WebTextInputType, and adds support for these
to WebViewImpl.textInputType().

Adds a new test WebViewTest.TextInputType to test WebViewImpl.textInputType(),
including the new types.

https://bugs.webkit.org/show_bug.cgi?id=78746

Patch by Oli Lan <olilan@chromium.org> on 2012-05-09
Reviewed by Kent Tamura.

* public/WebTextInputType.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::textInputType):
* tests/WebViewTest.cpp:
(WebViewTest):
(WebKit::WebViewTest::testTextInputType):
(WebKit):
(WebKit::TEST_F):
* tests/data/input_field_date.html: Added.
* tests/data/input_field_datetime.html: Added.
* tests/data/input_field_default.html: Added.
* tests/data/input_field_email.html: Added.
* tests/data/input_field_number.html: Added.
* tests/data/input_field_search.html: Added.
* tests/data/input_field_time.html: Added.
* tests/data/input_field_week.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r105057): Infinite loop inside SVGTextLayoutEngine::currentLogicalCharacte...
zimmermann@webkit.org [Wed, 9 May 2012 07:17:09 +0000 (07:17 +0000)]
REGRESSION(r105057): Infinite loop inside SVGTextLayoutEngine::currentLogicalCharacterMetrics
https://bugs.webkit.org/show_bug.cgi?id=83405

Reviewed by Darin Adler.

Source/WebCore:

Dynamically adding tspans carrying position information in the x/y/dx/dy/rotate lists is broken.
To avoid mistakes like this in future, simplify the calling code in RenderSVGInlineText and centralize
the managment of all caches (text positioning element cache / metrics map / layout attributes) in
RenderSVGText. This avoids the hack in SVGRootInlineBox::computePerCharacterLayoutInformation() which
called textRoot->rebuildLayoutAttributes(), which was used to fix previous security issues with this code.
Instead correctly handle destruction of RenderSVGInlineText in RenderSVGText, keeping the m_layoutAttributes
synchronized with the current state of the render tree. Fixes highcharts problems.

Tests: svg/text/add-tspan-position-bug.html
       svg/text/modify-tspan-position-bug.html

* rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::addChild):
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::willBeDestroyed):
(WebCore::RenderSVGInlineText::setTextInternal):
(WebCore::RenderSVGInlineText::styleDidChange):
* rendering/svg/RenderSVGText.cpp:
(WebCore::recursiveUpdateMetrics):
(WebCore::RenderSVGText::subtreeChildAdded):
(WebCore::RenderSVGText::subtreeChildWillBeDestroyed):
(WebCore::recursiveCollectLayoutAttributes):
(WebCore::checkLayoutAttributesConsistency):
(WebCore::RenderSVGText::subtreeChildWasDestroyed):
(WebCore::RenderSVGText::subtreeStyleChanged):
(WebCore::RenderSVGText::subtreeTextChanged):
(WebCore::RenderSVGText::layout):
(WebCore::RenderSVGText::addChild):
(WebCore::RenderSVGText::rebuildAllLayoutAttributes):
(WebCore::RenderSVGText::rebuildLayoutAttributes):
* rendering/svg/RenderSVGText.h:
(WebCore::RenderSVGText::layoutAttributes):
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
* rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributes):

LayoutTests:

Add two new testcases covering the problem.

* svg/text/add-tspan-position-bug-expected.html: Added.
* svg/text/add-tspan-position-bug.html: Added.
* svg/text/modify-tspan-position-bug-expected.html: Added.
* svg/text/modify-tspan-position-bug.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNavigatorRegisterProtocolHandler can call ChromeClient directly.
commit-queue@webkit.org [Wed, 9 May 2012 06:16:39 +0000 (06:16 +0000)]
NavigatorRegisterProtocolHandler can call ChromeClient directly.
https://bugs.webkit.org/show_bug.cgi?id=85944

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-05-08
Reviewed by Adam Barth.

Covered by fast/dom/register-protocol-handler.html

* page/Chrome.cpp: Remove registerProtocolHandler function.
* page/Chrome.h: Remove registerProtocolHandler prototype.
(Chrome):
* page/NavigatorRegisterProtocolHandler.cpp: Call ChromeClient::registerProtocolHandler directly.
(WebCore::NavigatorRegisterProtocolHandler::registerProtocolHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCoding style issues present in RenderFrameSet.cpp
mario@webkit.org [Wed, 9 May 2012 06:14:10 +0000 (06:14 +0000)]
Coding style issues present in RenderFrameSet.cpp
https://bugs.webkit.org/show_bug.cgi?id=85955

Reviewed by Eric Seidel.

Just fixed those coding style issues.

* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::GridAxis::resize):
(WebCore::RenderFrameSet::layOutAxis):
(WebCore::RenderFrameSet::continueResizing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
jochen@chromium.org [Wed, 9 May 2012 05:52:38 +0000 (05:52 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoROLLING OUT r114255
barraclough@apple.com [Wed, 9 May 2012 04:45:22 +0000 (04:45 +0000)]
ROLLING OUT r114255

GC in the middle of JSObject::allocatePropertyStorage can cause badness
https://bugs.webkit.org/show_bug.cgi?id=83839

Reviewed by nobody.

This breaks the world, with COLLECT_ON_EVERY_ALLOCATION enabled.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSObject.cpp:
(JSC::JSObject::allocatePropertyStorage):
* runtime/JSObject.h:
(JSObject):
(JSC::JSObject::isUsingInlineStorage):
(JSC):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::transitionTo):
* runtime/Structure.cpp:
(JSC):
* runtime/Structure.h:
(JSC::Structure::didTransition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix.
jonlee@apple.com [Wed, 9 May 2012 04:33:10 +0000 (04:33 +0000)]
Unreviewed build fix.

* platform/mac/WebCoreSystemInterface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix.
jonlee@apple.com [Wed, 9 May 2012 04:20:50 +0000 (04:20 +0000)]
Unreviewed build fix.

* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h:
(LayerTreeHostCAWin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, a trivial test fix to remove a platform-dependency.
tkent@chromium.org [Wed, 9 May 2012 04:10:05 +0000 (04:10 +0000)]
Unreviewed, a trivial test fix to remove a platform-dependency.
https://bugs.webkit.org/show_bug.cgi?id=81854

* fast/forms/form-collection-radio-node-list-expected.txt:
* fast/forms/form-collection-radio-node-list.html:
Remove form controls from the document before completing the test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Test expectation update
tkent@chromium.org [Wed, 9 May 2012 03:49:17 +0000 (03:49 +0000)]
[Chromium] Test expectation update
Skip post-in-iframe-with-back-navigation.html because it might cause a
failure of the next test, preload-append-scan.php

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Update test expectations.
tkent@chromium.org [Wed, 9 May 2012 03:39:02 +0000 (03:39 +0000)]
[Chromium] Update test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Auth credentials set in private mode are reused in public mode.
commit-queue@webkit.org [Wed, 9 May 2012 03:35:14 +0000 (03:35 +0000)]
[BlackBerry] Auth credentials set in private mode are reused in public mode.
https://bugs.webkit.org/show_bug.cgi?id=84697

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-05-08
Reviewed by Rob Buis.

Add setPrivateMode function for CredentialStorage.

Source/WebCore:

Now, we only save credentials in memory and CredentialBackingStore isn't enabled.
When we set private mode from on to off, we clear all these temporary credentials.

We have to change Private Browsing to test, so have to write a manual test case.
Test: ManualTests/blackberry/http-auth-private-mode-changed.html

* network/CredentialStorage.cpp:
(WebCore::CredentialStorage::setPrivateMode):
(WebCore):
* platform/network/CredentialStorage.h:
(CredentialStorage):

Source/WebKit/blackberry:

We have to change Private Browsing to test, so have to write a manual test case.
Test: ManualTests/blackberry/http-auth-private-mode-changed.html

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRadioNodeList support in HTMLFormElement::elements
commit-queue@webkit.org [Wed, 9 May 2012 03:23:16 +0000 (03:23 +0000)]
RadioNodeList support in HTMLFormElement::elements
https://bugs.webkit.org/show_bug.cgi?id=81854

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-05-08
Reviewed by Ryosuke Niwa.

Source/WebCore:

Implement RadioNodeList support spec'ed at
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#radionodelist

Test: fast/forms/form-collection-radio-node-list.html

* CMakeLists.txt:
Added entries for new files.
* DerivedSources.cpp: Ditto.
* DerivedSources.make: Ditto.
* DerivedSources.pri: Ditto.
* GNUmakefile.list.am: Ditto.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
Modified to create RadioNodeList object when FormControlCollection has more than
one element of same name/id.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
Added code to include Node.h and JSNode.h in JSRadioNodeElement.cpp.
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
Modified to create RadioNodeList object when FormControlCollection has more than
one element of same name/id.
* dom/Node.cpp:
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged):
Invalidate lists even for change in id, type, checked attributes.
(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes):
Invalidate radioNodeList cache.
(WebCore::NodeListsNodeData::isEmpty):
Changes for radioNodeList.
(WebCore::Node::radioNodeList):
Creates if needed a RadioNodeList and adds it to the cache.
(WebCore::Node::removeCachedRadioNodeList):
Removes a cached radioNodeList.
* dom/Node.h: Ditto
* dom/NodeRareData.h:
(WebCore):
(NodeListsNodeData):
Added radioNodeList list.
* html/CollectionType.h:
Added new FormControls type.
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::shouldIncludeChildren):
(WebCore::HTMLCollection::isAcceptableElement):
Handle FormControls collection type.
* html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::HTMLFormCollection):
Contruct collection of FormControls type.
* html/RadioNodeList.cpp: Added.
(WebCore):
(WebCore::RadioNodeList::RadioNodeList):
(WebCore::RadioNodeList::~RadioNodeList):
(WebCore::toRadioButtonInputElement):
(WebCore::RadioNodeList::value):
(WebCore::RadioNodeList::setValue):
(WebCore::RadioNodeList::nodeMatches):
* html/RadioNodeList.h: Added.
(WebCore):
(RadioNodeList):
(WebCore::RadioNodeList::create):
RadioNodeList implementation.
* html/RadioNodeList.idl: Added.
Idl for generating RadioNodeList JS/V8 bindings.

LayoutTests:

* fast/forms/form-collection-radio-node-list-expected.txt: Added.
* fast/forms/form-collection-radio-node-list.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[JSC] Regression: addEventListener() and removeEventListener() raise an exception...
benjamin@webkit.org [Wed, 9 May 2012 03:20:14 +0000 (03:20 +0000)]
[JSC] Regression: addEventListener() and removeEventListener() raise an exception on missing args
https://bugs.webkit.org/show_bug.cgi?id=85928

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-05-08
Reviewed by Geoffrey Garen.

Source/WebCore:

The functions addEventListener() and removeEventListener() raise an exception if there are missin arguments.
This behavior breaks existing content.

This patch change the code generator of JavaScript core to have an exception for addEventListener() and removeEventListener().
For those function, we do not raise an exception on missin argument.

This patch does not modify the V8 code generator because such exceptions are already in place there.

Tests: fast/dom/Window/window-legacy-event-listener.html
       fast/dom/XMLHttpRequest-legacy-event-listener.html
       fast/dom/node-legacy-event-listener.html

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):

LayoutTests:

* fast/dom/Window/window-legacy-event-listener-expected.txt: Added.
* fast/dom/Window/window-legacy-event-listener.html: Added.
* fast/dom/XMLHttpRequest-legacy-event-listener-expected.txt: Added.
* fast/dom/XMLHttpRequest-legacy-event-listener.html: Added.
* fast/dom/node-legacy-event-listener-expected.txt: Added.
* fast/dom/node-legacy-event-listener.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAudioParam should directly be given context in create() method
crogers@google.com [Wed, 9 May 2012 02:48:47 +0000 (02:48 +0000)]
AudioParam should directly be given context in create() method
https://bugs.webkit.org/show_bug.cgi?id=85905

Reviewed by James Robinson.

No new tests.  This is a low-level re-factoring and is covered by existing tests.

* Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
* Modules/webaudio/AudioGain.h:
(WebCore::AudioGain::create):
(WebCore::AudioGain::AudioGain):
* Modules/webaudio/AudioGainNode.cpp:
(WebCore::AudioGainNode::AudioGainNode):
* Modules/webaudio/AudioPannerNode.cpp:
(WebCore::AudioPannerNode::AudioPannerNode):
* Modules/webaudio/AudioParam.h:
(WebCore::AudioParam::create):
(AudioParam):
(WebCore::AudioParam::AudioParam):
* Modules/webaudio/BiquadFilterNode.cpp:
(WebCore::BiquadFilterNode::BiquadFilterNode):
* Modules/webaudio/BiquadProcessor.cpp:
(WebCore::BiquadProcessor::BiquadProcessor):
* Modules/webaudio/BiquadProcessor.h:
* Modules/webaudio/DelayNode.cpp:
(WebCore::DelayNode::DelayNode):
* Modules/webaudio/DelayProcessor.cpp:
(WebCore::DelayProcessor::DelayProcessor):
* Modules/webaudio/DelayProcessor.h:
(DelayProcessor):
* Modules/webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
* Modules/webaudio/Oscillator.cpp:
(WebCore::Oscillator::Oscillator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHeap should not continually allocate new pages in steady state
mhahnenberg@apple.com [Wed, 9 May 2012 02:44:39 +0000 (02:44 +0000)]
Heap should not continually allocate new pages in steady state
https://bugs.webkit.org/show_bug.cgi?id=85936

Reviewed by Geoff Garen.

Currently, in steady state (i.e. a constant amount of live GC
memory with a constant rate of allocation) assuming we've just
finished a collection with X live blocks in CopiedSpace, we
increase our working set by X blocks in CopiedSpace with each
collection we perform. This is due to the fact that we allocate
until we run out of free blocks to use in the Heap before we
consider whether we should run a collection.

In the longer term, this issue will be mostly resolved by
implementing quick release for the CopiedSpace. In the shorter
term, we should change our policy to check whether we should
allocate before trying to use a free block from the Heap. We
can change our policy to something more appropriate once we
have implemented quick release.

This change should also have the convenient side effect of
reducing the variance in GC-heavy tests (e.g. v8-splay) due
to fact that we are doing less VM allocation during copying
collection. Overall, this patch is performance neutral across
the benchmarks we track.

* heap/CopiedSpace.cpp:
(JSC::CopiedSpace::getFreshBlock): Shuffle the request from the BlockAllocator
around so that we only do it if the block request must succeed
i.e. after we've already checked whether we should do a collection.
* heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::allocateSlowCase): Ditto.
(JSC::MarkedAllocator::allocateBlock): We no longer have a failure mode in this
function because by the time we've called it, we've already checked whether we
should run a collection so there's no point in returning null.
* heap/MarkedAllocator.h: Removing old arguments from function declaration.
(MarkedAllocator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShow the chromium non-layout test bots in garden-o-matic
ojan@chromium.org [Wed, 9 May 2012 02:37:56 +0000 (02:37 +0000)]
Show the chromium non-layout test bots in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=85903

Reviewed by Eric Seidel.

This is just a single-line high-level overview of the chromium non-layout test bots.
This means that Chromium WebKit gardeners only need to keep garden-o-matic open in
order to do their job.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
(#chromium-gtests iframe):
(#chromium-gtests):
(#gtest-label):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116483 268f45cc-cd09-0410-ab3c-d52691b4dbfc