WebKit-https.git
9 years agoRename flex-align to flex-item-align.
ojan@chromium.org [Tue, 10 Jan 2012 21:19:55 +0000 (21:19 +0000)]
Rename flex-align to flex-item-align.
https://bugs.webkit.org/show_bug.cgi?id=75929

Reviewed by Darin Adler.

Source/WebCore:

The spec has changed and now flex-align will be set on
the flexbox itself.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexAlign):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyleBitfields::flexItemAlign):
(WebCore::RenderStyleBitfields::setFlexItemAlign):
(WebCore::RenderStyleBitfields::initialFlexItemAlign):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
* rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

* css3/flexbox/css-properties-expected.txt:
* css3/flexbox/flex-align-column.html:
* css3/flexbox/flex-align-vertical-writing-mode.html:
* css3/flexbox/flex-align.html:
* css3/flexbox/line-wrapping.html:
* css3/flexbox/orthogonal-flex-directions.html:
* css3/flexbox/script-tests/css-properties.js:
* fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReplace TextTrackCue "getCueAsSource" method with "text" attribute
eric.carlson@apple.com [Tue, 10 Jan 2012 21:14:23 +0000 (21:14 +0000)]
Replace TextTrackCue "getCueAsSource" method with "text" attribute
https://bugs.webkit.org/show_bug.cgi?id=75646

Reviewed by Darin Adler.

Source/WebCore:

Test: media/track/track-cue-mutable-text.html

* html/HTMLMediaElement.h: getCueAsSource() -> text().

* html/TextTrackCue.cpp:
(WebCore::TextTrackCue::setText): New. Set cue text and clear the document fragment.
(WebCore::TextTrackCue::getCueAsHTML): Allocate the document fragment if it doesn't exist.
* html/TextTrackCue.h:
(WebCore::TextTrackCue::text):
* html/TextTrackCue.idl: getCueAsSource() -> text().

* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::updateTextTrackDisplay): getCueAsSource() -> text().
* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::updateTextTrackDisplay): getCueAsSource() -> text().

* html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::collectCueText): processCueText is dead, long live createNewCue.
(WebCore::WebVTTParser::createDocumentFragmentFromCueText): New, split out of processCueText.
    Create a document fragment from the String argument.
(WebCore::WebVTTParser::createNewCue): Split out of processCueText.
(WebCore::WebVTTParser::constructTreeFromToken): Add a comment pointing to the spec section
    with the rules for DOM construction.
* html/track/WebVTTParser.h:

LayoutTests:

* media/track/track-cue-mutable-text-expected.txt: Added.
* media/track/track-cue-mutable-text.html: Added. New test for mutable cue text.
* media/track/track-cue-nothing-to-render-expected.txt: getCueAsSource() -> text.
* media/track/track-cue-nothing-to-render.html: Ditto.
* media/track/track-cue-rendering-expected.txt: Ditto.
* media/track/track-cue-rendering.html: Ditto.
* media/track/track-webvtt-tc001-utf8-expected.txt: Ditto.
* media/track/track-webvtt-tc001-utf8.html: Ditto.
* media/track/track-webvtt-tc002-bom-expected.txt: Ditto.
* media/track/track-webvtt-tc002-bom.html: Ditto.
* media/track/track-webvtt-tc003-newlines-expected.txt: Ditto.
* media/track/track-webvtt-tc003-newlines.html: Ditto.
* media/track/track-webvtt-tc004-magic-header-expected.txt: Ditto.
* media/track/track-webvtt-tc004-magic-header.html: Ditto.
* media/track/track-webvtt-tc005-header-comment-expected.txt: Ditto.
* media/track/track-webvtt-tc005-header-comment.html: Ditto.
* media/track/track-webvtt-tc006-cue-identifiers-expected.txt: Ditto.
* media/track/track-webvtt-tc006-cue-identifiers.html: Ditto.
* media/track/track-webvtt-tc007-cue-no-id-expected.txt: Ditto.
* media/track/track-webvtt-tc007-cue-no-id.html: Ditto.
* media/track/track-webvtt-tc008-timings-no-hours-expected.txt: Ditto.
* media/track/track-webvtt-tc008-timings-no-hours.html: Ditto.
* media/track/track-webvtt-tc009-timings-hour-expected.txt: Ditto.
* media/track/track-webvtt-tc009-timings-hour.html: Ditto.
* media/track/track-webvtt-tc011-blank-lines-expected.txt: Ditto.
* media/track/track-webvtt-tc011-blank-lines.html: Ditto.
* media/track/track-webvtt-tc028-unsupported-markup-expected.txt: Ditto.
* media/track/track-webvtt-tc028-unsupported-markup.html: Ditto.
* platform/mac/fast/dom/Window/window-properties-expected.txt: Remove getCueAsSource.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDispatchOnConnectionQueue messages should have a Connection parameter
andersca@apple.com [Tue, 10 Jan 2012 21:14:16 +0000 (21:14 +0000)]
DispatchOnConnectionQueue messages should have a Connection parameter
https://bugs.webkit.org/show_bug.cgi?id=75986

Reviewed by Adam Roben.

Message handlers for messages with the DispatchOnConnectionQueue should have a CoreIPC::Connection
parameter, making it easier to send messages back over that connection.

* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
(CoreIPC::handleMessageOnConnectionQueue):
* Scripts/webkit2/messages.py:
(async_case_statement):
(generate_message_handler):
* Scripts/webkit2/messages_unittest.py:
* WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::wheelEvent):
(WebKit::EventDispatcher::gestureEvent):
* WebProcess/WebPage/EventDispatcher.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::pluginProcessCrashed):
* WebProcess/WebProcess.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTurn off the FilterTrigger in WebKit and WebKit2
cmarrin@apple.com [Tue, 10 Jan 2012 21:12:45 +0000 (21:12 +0000)]
Turn off the FilterTrigger in WebKit and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=75914

Reviewed by Simon Fraser.

Source/WebKit/mac:

Implement allowedCompositingTriggers to turn on all compositing triggers except FilterTrigger.

* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::allowedCompositingTriggers):

Source/WebKit2:

Implement allowedCompositingTriggers to turn on all compositing triggers except FilterTrigger.

* WebProcess/WebCoreSupport/WebChromeClient.h:
(WebKit::WebChromeClient::allowedCompositingTriggers):

LayoutTests:

Test to make sure compositing layers are off for filters

* css3/filters/should-not-have-compositing-layer-expected.txt: Added.
* css3/filters/should-not-have-compositing-layer.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake it possible to type data: URLs into MiniBrowser on Windows
aroben@apple.com [Tue, 10 Jan 2012 21:05:59 +0000 (21:05 +0000)]
Make it possible to type data: URLs into MiniBrowser on Windows

Fixes <http://webkit.org/b/75084> Crash when trying to navigate to a data: URL in
MiniBrowser on Windows

Reviewed by Darin Adler.

* MiniBrowser/win/BrowserWindow.cpp:
(BrowserWindow::handleMessage): Instead of checking for an "http://" prefix when deciding
whether to prepend "http://", just look for whether the typed URL contains a colon. If it
does, we assume it already has a scheme and don't modify it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix following https://bugs.webkit.org/show_bug.cgi?id=75935
barraclough@apple.com [Tue, 10 Jan 2012 21:01:01 +0000 (21:01 +0000)]
Build fix following https://bugs.webkit.org/show_bug.cgi?id=75935

Fix 32-bit builds.

* runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::setLength):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r102024): Having the Bing homepage open prevents idle sleep
jer.noble@apple.com [Tue, 10 Jan 2012 20:43:20 +0000 (20:43 +0000)]
REGRESSION (r102024): Having the Bing homepage open prevents idle sleep
https://bugs.webkit.org/show_bug.cgi?id=75972

Reviewed by Oliver Hunt.

No new tests; no testing infrastructure exists to test display sleep assertions.

Only disable idle and display sleep when a video element is not paused, not looping, and
has both a video and audio track.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerRateChanged): Factor into updateDisableSleep() and
    shouldDisplaySleep().
(WebCore::HTMLMediaElement::setLoop): Ditto.
(WebCore::HTMLMediaElement::attributeChanged): Ditto.
(WebCore::HTMLMediaElement::updateDisableSleep):
(WebCore::HTMLMediaElement::shouldDisableSleep):
* html/HTMLMediaElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Rebaseline after r104585
commit-queue@webkit.org [Tue, 10 Jan 2012 20:42:41 +0000 (20:42 +0000)]
[Chromium] Rebaseline after r104585
https://bugs.webkit.org/show_bug.cgi?id=75981

Unreviewed Chromium expectations update.

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-10

* platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
* platform/chromium-linux/svg/custom/shapes-supporting-markers-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/shapes-supporting-markers-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
* platform/chromium-win/svg/custom/shapes-supporting-markers-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Move inspector tests into the inspector test group
noel.gordon@gmail.com [Tue, 10 Jan 2012 20:39:31 +0000 (20:39 +0000)]
[chromium] Move inspector tests into the inspector test group
https://bugs.webkit.org/show_bug.cgi?id=75926

Reviewed by Adam Barth.

And mark http/tests/inspector/resource-tree/resource-tree-document-url.html as flaky.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Mac] Accelerate canvas layers with the same logic as accelerating the canvas itself
mdelaney@apple.com [Tue, 10 Jan 2012 20:30:59 +0000 (20:30 +0000)]
[Mac] Accelerate canvas layers with the same logic as accelerating the canvas itself
https://bugs.webkit.org/show_bug.cgi?id=75921

Reviewed by Simon Fraser.

No new tests. Does not affect detectable behavior.

* rendering/RenderLayerCompositor.cpp: Use canvas's shouldAccelerate to avoid asking
uninitialized canvas's if they're accelerated or not.
(WebCore::RenderLayerCompositor::updateBacking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake MiniBrowser automatically escape invalid URL characters typed in its URL field
aroben@apple.com [Tue, 10 Jan 2012 20:23:48 +0000 (20:23 +0000)]
Make MiniBrowser automatically escape invalid URL characters typed in its URL field

Fixes <http://webkit.org/b/75086> Crash when typing a data: URL containing double-quotes in
MiniBrowser on Windows

Reviewed by Darin Adler.

* MiniBrowser/win/BrowserView.cpp:
(BrowserView::goToURL): Pass the typed string through
CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdding myself (benwells) to committers.py
benwells@chromium.org [Tue, 10 Jan 2012 20:08:55 +0000 (20:08 +0000)]
Adding myself (benwells) to committers.py
https://bugs.webkit.org/show_bug.cgi?id=75971

Reviewed by Ojan Vafai.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChange -[WebHistoryItem copyWithZone:] to not use NSCopyObject()
mitz@apple.com [Tue, 10 Jan 2012 20:01:04 +0000 (20:01 +0000)]
Change -[WebHistoryItem copyWithZone:] to not use NSCopyObject()
https://bugs.webkit.org/show_bug.cgi?id=75980

Reviewed by Mark Rowe.

* History/WebHistoryItem.mm:
(-[WebHistoryItem copyWithZone:]): Replaced NSCopyObject() with
-alloc, -initWithWebCoreHistoryItem:.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix.
barraclough@apple.com [Tue, 10 Jan 2012 19:56:18 +0000 (19:56 +0000)]
Windows build fix.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Do not recreate texture updater for image layer if one exists.
commit-queue@webkit.org [Tue, 10 Jan 2012 19:52:39 +0000 (19:52 +0000)]
[Chromium] Do not recreate texture updater for image layer if one exists.
https://bugs.webkit.org/show_bug.cgi?id=75589

Patch by Daniel Sievers <sievers@chromium.org> on 2012-01-10
Reviewed by James Robinson.

Source/WebCore:

Test: platform/chromium/compositing/img-layer-grow.html

* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::createTextureUpdater):

LayoutTests:

* platform/chromium/compositing/img-layer-grow-expected.png: Added.
* platform/chromium/compositing/img-layer-grow-expected.txt: Added.
* platform/chromium/compositing/img-layer-grow.html: Added.
* platform/chromium/compositing/resources/apple.jpg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[skia] not all convex paths are convex, so recompute convexity for the problematic...
reed@google.com [Tue, 10 Jan 2012 19:50:40 +0000 (19:50 +0000)]
[skia] not all convex paths are convex, so recompute convexity for the problematic ones
https://bugs.webkit.org/show_bug.cgi?id=75960

Reviewed by Stephen White.

No new tests.
See related chrome issue
http://code.google.com/p/chromium/issues/detail?id=108605

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::setPathFromConvexPoints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed gardening.
senorblanco@chromium.org [Tue, 10 Jan 2012 19:47:28 +0000 (19:47 +0000)]
[chromium] Unreviewed gardening.

New baselines for SVG feColorMatrix tests after r104571.

* platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/feColorMatrix-offset-expected.png:
* platform/chromium-mac-snowleopard/svg/filters/feColorMatrix-saturate-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Removed.
* platform/chromium-mac/svg/filters/feColorMatrix-saturate-expected.png: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
* platform/chromium-win/svg/filters/feColorMatrix-offset-expected.png:
* platform/chromium-win/svg/filters/feColorMatrix-saturate-expected.png:
* platform/chromium/test_expectations.txt:
* platform/mac/svg/filters/feColorMatrix-saturate-expected.txt: Added.
* svg/filters/feColorMatrix-saturate-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Remove old WebMimeRegistry.h forwarding header
jamesr@google.com [Tue, 10 Jan 2012 19:45:15 +0000 (19:45 +0000)]
[chromium] Remove old WebMimeRegistry.h forwarding header
https://bugs.webkit.org/show_bug.cgi?id=75979

Reviewed by Ryosuke Niwa.

This isn't needed any more.

* WebKit.gyp:
* public/platform/WebMimeRegistry.h: Removed.
* src/FrameLoaderClientImpl.cpp:
* src/PlatformSupport.cpp:
* src/WebMediaPlayerClientImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImprove keyboard navigation in layout test results
simon.fraser@apple.com [Tue, 10 Jan 2012 19:43:08 +0000 (19:43 +0000)]
Improve keyboard navigation in layout test results
https://bugs.webkit.org/show_bug.cgi?id=75901

Reviewed by Ojan Vafai.

Add support for keyboard shortcuts for navigating the list of tests,
and for flagging tests.

'i', 'k', 'k', and 'l' go foward, back, to first and to last, denoting
the current test with a red expand indicator.

'e', 'c' and 't' expand, collapse and toggle the current test.

'f' toggled a test as "flagged", which adds it to a copyable list
at the bottom of the document. The user can use flagging for whatever they want.

* fast/harness/resources/results-test.js:
(runTests):
(runTests.isCollapsed):
():
* fast/harness/results-expected.txt:
* fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Fix assertion failure in BackingStore::blitContents
commit-queue@webkit.org [Tue, 10 Jan 2012 19:38:09 +0000 (19:38 +0000)]
[BlackBerry] Fix assertion failure in BackingStore::blitContents
https://bugs.webkit.org/show_bug.cgi?id=75976

Prevent an assertion failure in BackingStore::blitContents by
checking that the srcRect of the transformation matrix is non empty.

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-01-10
Reviewed by Adam Treat.

Upstream BlackBerry port is not yet building and testable.

* blackberry/Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::blitContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/JavaScriptCore: Do not allow Array length to be set if it is non-configurable
barraclough@apple.com [Tue, 10 Jan 2012 19:27:46 +0000 (19:27 +0000)]
Source/JavaScriptCore: Do not allow Array length to be set if it is non-configurable
https://bugs.webkit.org/show_bug.cgi?id=75935

Reviewed by Sam Weinig.

Do not allow Array length to be set if it is non-configurable, and if the new
length is less than the old length then intervening properties should removed
in reverse order. Removal of properties should cease if an intervening indexed
property being removed is non-configurable.

* JavaScriptCore.exp:
    - Removed export for setLength.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncConcat):
    - JSArray::setLength now takes an ExecState*
(JSC::arrayProtoFuncSlice):
    - JSArray::setLength now takes an ExecState*
* runtime/JSArray.cpp:
(JSC::JSArray::defineOwnProperty):
    - JSArray::setLength now takes an ExecState*
(JSC::JSArray::put):
    - JSArray::setLength now takes an ExecState*
(JSC::compareKeysForQSort):
    - Keys extracted from the map can be stored as unsigneds.
(JSC::JSArray::getOwnPropertyNames):
    - Keys extracted from the map can be stored as unsigneds.
(JSC::JSArray::setLength):
    - Check lengthIsReadOnly(), rather than copying the entire map to iterate
      over to determine which keys to remove, instead just copy the keys from
      the map to a Vector. When inSparseMode sort the keys in the Vector so
      that we can remove properties in reverse order.
* runtime/JSArray.h:
    - JSArray::setLength now takes an ExecState*

Source/WebCore: Do not allow Array length to be set if it is non-configurable
https://bugs.webkit.org/show_bug.cgi?id=75935

Reviewed by Sam Weinig.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::deserialize):
    - remove unnecessary call to JSArray::setLength.

LayoutTests: rebaselining some canvas images
https://bugs.webkit.org/show_bug.cgi?id=75552

Patch by Elliot Poger <epoger@google.com> on 2012-01-10
Reviewed by Ryosuke Niwa.

* platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.png:
* platform/chromium-gpu-linux/fast/canvas/quadraticCurveTo-expected.png:
* platform/chromium-gpu-mac/fast/canvas/canvas-text-baseline-expected.png: Added.
* platform/chromium-gpu-mac/fast/canvas/quadraticCurveTo-expected.png: Added.
* platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png:
* platform/chromium-gpu-win/fast/canvas/quadraticCurveTo-expected.png:
* platform/chromium-mac-leopard/fast/canvas/quadraticCurveTo-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-lineWidth-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-text-baseline-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/canvas/quadraticCurveTo-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agorebaselining some canvas images
commit-queue@webkit.org [Tue, 10 Jan 2012 19:27:02 +0000 (19:27 +0000)]
rebaselining some canvas images
https://bugs.webkit.org/show_bug.cgi?id=75552

Patch by Elliot Poger <epoger@google.com> on 2012-01-10
Reviewed by Ryosuke Niwa.

* platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.png:
* platform/chromium-gpu-linux/fast/canvas/quadraticCurveTo-expected.png:
* platform/chromium-gpu-mac/fast/canvas/canvas-text-baseline-expected.png: Added.
* platform/chromium-gpu-mac/fast/canvas/quadraticCurveTo-expected.png: Added.
* platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png:
* platform/chromium-gpu-win/fast/canvas/quadraticCurveTo-expected.png:
* platform/chromium-mac-leopard/fast/canvas/quadraticCurveTo-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-lineWidth-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-text-baseline-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/canvas/quadraticCurveTo-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse SameValue to compare property descriptor values
barraclough@apple.com [Tue, 10 Jan 2012 19:22:54 +0000 (19:22 +0000)]
Use SameValue to compare property descriptor values
https://bugs.webkit.org/show_bug.cgi?id=75975

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Rather than strictEqual.

* runtime/JSArray.cpp:
(JSC::JSArray::defineOwnNumericProperty):
    - Missing configurablePresent() check.
* runtime/JSObject.cpp:
(JSC::JSObject::defineOwnProperty):
    - call sameValue.
* runtime/PropertyDescriptor.cpp:
(JSC::sameValue):
    - Moved from JSArray.cpp, fix NaN comparison.
(JSC::PropertyDescriptor::equalTo):
    - call sameValue.
* runtime/PropertyDescriptor.h:
    - Added declaration for sameValue.

LayoutTests:

* fast/js/array-defineOwnProperty-expected.txt:
* fast/js/script-tests/array-defineOwnProperty.js:
    - Add new test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Fix expectations for worker-script-error.html on Mac/Linux
tony@chromium.org [Tue, 10 Jan 2012 19:21:14 +0000 (19:21 +0000)]
[chromium] Fix expectations for worker-script-error.html on Mac/Linux
https://bugs.webkit.org/show_bug.cgi?id=75758

Reviewed by David Levin.

The Win results appear to apply to Mac and Linux as well.

* platform/chromium-win/fast/workers/worker-script-error-expected.txt: Removed.
* platform/chromium/fast/workers/worker-script-error-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Draw debug tile borders on composited layers
enne@google.com [Tue, 10 Jan 2012 18:59:16 +0000 (18:59 +0000)]
[chromium] Draw debug tile borders on composited layers
https://bugs.webkit.org/show_bug.cgi?id=75680

Reviewed by James Robinson.

Source/WebCore:

On tiled layers, draw debug borders on the tiles themselves. By
default, these are one pixel wide and transparent, so should be
unobtrusive but informative. They are triggered when the layer itself
would have a debug border via the existing flags.

Also, fix the drawDebugBorderQuad function to handle arbitrarily
positioned quads, not just full layer quads. Also, fix alpha issue
with debug borders.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawDebugBorderQuad):
* platform/graphics/chromium/cc/CCDebugBorderDrawQuad.cpp:
(WebCore::CCDebugBorderDrawQuad::CCDebugBorderDrawQuad):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::appendDebugBorderQuad):
(WebCore::CCLayerImpl::quadTransform):
(WebCore::CCLayerImpl::hasDebugBorders):
* platform/graphics/chromium/cc/CCLayerImpl.h:
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::appendQuads):

Source/WebKit/chromium:

As debug borders are not a CCSetting and are instead grabbed directly
from each graphics layer, modify the NonCompositedContentHost to say
that its graphics layer has debug borders if the page settings demand
it.

* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setShowDebugBorders):
(WebKit::NonCompositedContentHost::showDebugBorders):
* src/NonCompositedContentHost.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttp/tests/inspector/network-preflight-options.html is flaky on linux
vsevik@chromium.org [Tue, 10 Jan 2012 18:49:36 +0000 (18:49 +0000)]
http/tests/inspector/network-preflight-options.html is flaky on linux
https://bugs.webkit.org/show_bug.cgi?id=75917

Reviewed by Yury Semikhatsky.

* http/tests/inspector/network-preflight-options-expected.txt:
* http/tests/inspector/network-preflight-options.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Missing Implementation of Public InspectorDOMAgent Function
commit-queue@webkit.org [Tue, 10 Jan 2012 18:44:41 +0000 (18:44 +0000)]
Web Inspector: Missing Implementation of Public InspectorDOMAgent Function
https://bugs.webkit.org/show_bug.cgi?id=75759

Follow-up: Remove the unused method. Keep the setter private.

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-01-10
Reviewed by Pavel Feldman.

* inspector/InspectorDOMAgent.cpp:
* inspector/InspectorDOMAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed, follow up to r104586: fix assertion within the loop.
pfeldman@chromium.org [Tue, 10 Jan 2012 18:23:13 +0000 (18:23 +0000)]
Not reviewed, follow up to r104586: fix assertion within the loop.

* inspector/DOMEditor.cpp:
(WebCore::DOMEditor::patchChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAX: support helpText() in DumpRenderTree
mario@webkit.org [Tue, 10 Jan 2012 18:05:45 +0000 (18:05 +0000)]
AX: support helpText() in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=40193

Unreviewed. Remove no longer needed GTK-specific expectation.

* platform/gtk/accessibility/aria-describedby-on-input-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9328684> and https://bugs.webkit.org/show_bug.cgi?id=62764
beidson@apple.com [Tue, 10 Jan 2012 17:57:42 +0000 (17:57 +0000)]
<rdar://problem/9328684> and https://bugs.webkit.org/show_bug.cgi?id=62764
Frequent crashes due to null frame below ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache

Reviewed by Maciej Stachowiak.

This is a non-reproducible high volume crash, so no test :(.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::stopLoading): Don't re-run actual "stop loading" logic if the document loader is already
  stopping loading. Also add an ASSERT that might catch cases where new loads may have been started while old loads
  were being stopped.
(WebCore::DocumentLoader::detachFromFrame): Be conservative and stop loading when we detach a document loader from a frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed: fixing the Mac build.
pfeldman@chromium.org [Tue, 10 Jan 2012 17:49:05 +0000 (17:49 +0000)]
Not reviewed: fixing the Mac build.

* inspector/DOMEditor.cpp:
(WebCore::DOMEditor::patchChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAX: support helpText() in DumpRenderTree
mario@webkit.org [Tue, 10 Jan 2012 17:44:21 +0000 (17:44 +0000)]
AX: support helpText() in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=40193

Reviewed by Chris Fleizach.

Source/WebKit/gtk:

Add support for retrieving WebCore's AccessibilityObject's
helpText from the GTK DumpRenderTree.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::accessibilityHelpText): Returns result
of calling to helpText() over the core accessibility object's.
* WebCoreSupport/DumpRenderTreeSupportGtk.h:

Tools:

* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::helpText): Implemented.

LayoutTests:

Unskip tests now passing.

* accessibility/aria-describedby-on-input-expected.txt: Moved from
LayoutTests/platform/mac/accessibility.
* platform/gtk/Skipped: Unskip tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] platform/gtk/accessibility/unknown-roles-not-exposed.html is flaky
mario@webkit.org [Tue, 10 Jan 2012 17:41:18 +0000 (17:41 +0000)]
[GTK] platform/gtk/accessibility/unknown-roles-not-exposed.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=74493

Unreviewed. Unskipping passing test.

* platform/gtk/test_expectations.txt: Unskip test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoElements can appear over fullscreen video
jer.noble@apple.com [Tue, 10 Jan 2012 17:38:34 +0000 (17:38 +0000)]
Elements can appear over fullscreen video
https://bugs.webkit.org/show_bug.cgi?id=75913

Reviewed by Simon Fraser.

Source/WebCore:

No new tests; updated fullscreen/full-screen-zIndex.html to trigger error condition.

RenderFullScreenPlaceholder inherits the pre-fullscreen element's style, causing a stacking
context to be created.  Instead of making the placeholder the parent of the RenderFullScreen
object, make the two renderers siblings.  Then the stacking context created by the placeholder
will not affect the z-ordering of the RenderFullScreen.

* rendering/RenderFullScreen.cpp:
(RenderFullScreen::wrapRenderer):
(RenderFullScreen::unwrapRenderer):
(RenderFullScreen::createPlaceholder):

LayoutTests:

Update the test to trigger the error condition in the linked bug.

* fullscreen/full-screen-zIndex.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling
jchaffraix@webkit.org [Tue, 10 Jan 2012 17:34:33 +0000 (17:34 +0000)]
REGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling
https://bugs.webkit.org/show_bug.cgi?id=67100

Unreviewed, chromium rebaselining after r104575.

The SL baseline for scroll-with-transform-layer.html is missing some scroll thumbs (http://webkit.org/b/75969).

* platform/chromium-linux/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
* platform/chromium-linux/fast/layers/scroll-with-transform-layer-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/layers/scroll-with-transform-layer-expected.png: Added.
* platform/chromium-win/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
* platform/chromium-win/fast/layers/scroll-with-transform-layer-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Remove png and txt expected files for reftests.
ossy@webkit.org [Tue, 10 Jan 2012 17:19:08 +0000 (17:19 +0000)]
[Qt] Unreviewed gardening. Remove png and txt expected files for reftests.

* platform/qt/css2.1/20110323/border-conflict-element-016-expected.png: Removed.
* platform/qt/css2.1/20110323/border-conflict-element-016-expected.txt: Removed.
* platform/qt/css2.1/20110323/border-conflict-element-017-expected.png: Removed.
* platform/qt/css2.1/20110323/border-conflict-element-017-expected.txt: Removed.
* platform/qt/css2.1/20110323/border-conflict-element-037-expected.png: Removed.
* platform/qt/css2.1/20110323/border-conflict-element-037-expected.txt: Removed.
* platform/qt/css2.1/20110323/border-conflict-element-038-expected.png: Removed.
* platform/qt/css2.1/20110323/border-conflict-element-038-expected.txt: Removed.
* platform/qt/fast/writing-mode/margins-expected.png: Removed.
* platform/qt/fast/writing-mode/margins-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: add "free flow DOM editing" experiment.
pfeldman@chromium.org [Tue, 10 Jan 2012 17:01:05 +0000 (17:01 +0000)]
Web Inspector: add "free flow DOM editing" experiment.
https://bugs.webkit.org/show_bug.cgi?id=75955

This change enables HTML editing from Resources panel experiment.

Reviewed by Yury Semikhatsky.

* CMakeLists.txt:
* English.lproj/localizedStrings.js:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/DOMEditor.cpp: Added.
(WebCore::DOMEditor::DOMEditor):
(WebCore::DOMEditor::~DOMEditor):
(WebCore::DOMEditor::patch):
(WebCore::DOMEditor::NodeDigest::NodeDigest):
(WebCore::DOMEditor::patchElement):
(WebCore::DOMEditor::patchNode):
(WebCore::DOMEditor::patchChildren):
(WebCore::addStringToSHA1):
(WebCore::DOMEditor::createNodeDigest):
* inspector/DOMEditor.h: Added.
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setOuterHTML):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent):
(WebInspector.DOMModelResourceBinding):
(WebInspector.DOMModelResourceBinding.prototype.setContent):
(WebInspector.DOMModelResourceBinding.prototype.canSetContent):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Shift PathSkia to use Skia's new RawIter
commit-queue@webkit.org [Tue, 10 Jan 2012 16:54:29 +0000 (16:54 +0000)]
[Chromium] Shift PathSkia to use Skia's new RawIter
https://bugs.webkit.org/show_bug.cgi?id=75703

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-10
Reviewed by Nikolas Zimmermann.

Source/WebCore:

No new tests required - covered by existing tests.

* platform/graphics/Path.h: Added comments ont he return values from iteration.
* platform/graphics/skia/PathSkia.cpp:
(WebCore::Path::apply): Switched to SkPath::RawIter

LayoutTests:

* platform/chromium/test_expectations.txt: Updated epxectation for
  tests that may change after this modification.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r104572.
ossy@webkit.org [Tue, 10 Jan 2012 16:47:59 +0000 (16:47 +0000)]
Unreviewed, rolling out r104572.
http://trac.webkit.org/changeset/104572
https://bugs.webkit.org/show_bug.cgi?id=75967

It broke zillion tests (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-10

Tools:

* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::EventSender):
(EventSender::sendOrQueueEvent):
(EventSender::replaySavedEvents):
(EventSender::eventFilter):
* DumpRenderTree/qt/EventSenderQt.h:

LayoutTests:

* platform/qt-wk1/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Clean up test expectations for mac.
jknotten@chromium.org [Tue, 10 Jan 2012 16:45:55 +0000 (16:45 +0000)]
[Chromium] Clean up test expectations for mac.
https://bugs.webkit.org/show_bug.cgi?id=75966

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed potential Mac WK2 build fix.
kenneth@webkit.org [Tue, 10 Jan 2012 16:44:01 +0000 (16:44 +0000)]
Unreviewed potential Mac WK2 build fix.

* UIProcess/PageClient.h: forward declare WebGestureEvent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. WebInspector: Remove unnecessary logging from the test.
loislo@chromium.org [Tue, 10 Jan 2012 16:39:10 +0000 (16:39 +0000)]
Unreviewed. WebInspector: Remove unnecessary logging from the test.

* inspector/first-open-resources.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Restore test that was removed during migration from LayoutTests folder.
loislo@chromium.org [Tue, 10 Jan 2012 16:31:28 +0000 (16:31 +0000)]
Unreviewed. Restore test that was removed during migration from LayoutTests folder.

* inspector/first-open-resources.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline fast/text/unicode-variation-selector.html following r104545.
jknotten@chromium.org [Tue, 10 Jan 2012 16:23:54 +0000 (16:23 +0000)]
Rebaseline fast/text/unicode-variation-selector.html following r104545.

* platform/chromium-win/fast/text/unicode-variation-selector-expected.png:
* platform/chromium/fast/text/unicode-variation-selector-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Use SkFontHost::GetUnitsPerEm instead of advanced type
peter@chromium.org [Tue, 10 Jan 2012 16:03:44 +0000 (16:03 +0000)]
[Chromium] Use SkFontHost::GetUnitsPerEm instead of advanced type
metrics for Android in FontPlatformData
https://bugs.webkit.org/show_bug.cgi?id=75702

Reviewed by Stephen White.

Since Skia for Android doesn't implement advanced type metric routines,
use an alternative method to calculate the number of font units for an
em size. This will be exercized by existing layout tests, as it's being
used by the ComplexTextController.

* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::emSizeInFontUnits):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, inspector style fix.
vsevik@chromium.org [Tue, 10 Jan 2012 15:59:16 +0000 (15:59 +0000)]
Unreviewed, inspector style fix.

Web Inspector: elements tree is shifted 12px to the right.
https://bugs.webkit.org/show_bug.cgi?id=75609

* inspector/front-end/elementsPanel.css:
(#elements-content):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix style errors in CSSParser.cpp
zherczeg@webkit.org [Tue, 10 Jan 2012 15:58:31 +0000 (15:58 +0000)]
Fix style errors in CSSParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=75854

Reviewed by Nikolas Zimmermann.

Minor style fixes.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseShadow):
(WebCore::isBorderImageRepeatKeyword):
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::BorderImageQuadParseContext::commitBorderImageQuad):
(WebCore::filterInfoForName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling
jchaffraix@webkit.org [Tue, 10 Jan 2012 15:48:40 +0000 (15:48 +0000)]
REGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling
https://bugs.webkit.org/show_bug.cgi?id=67100

Reviewed by Dan Bernstein.

Source/WebCore:

Tests: fast/layers/scroll-with-transform-composited-layer.html
       fast/layers/scroll-with-transform-layer.html

The regression came from a previous optimization that was wrongly kept after r93614.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
Remove the early return for transformed layer. This change worked as we used
to call updateLayerPositions from scrollTo which would call updateLayerPosition on
all our descendants. After r93614, this is no longer the case and we explicitely need
to call updateLayerPosition on our descendants from updateLayerPositionsAfterScroll.

LayoutTests:

Added 2 tests for scrolling inside a transformed layer (either composited
or not). Unfortunately due to some platform-specifics differences, they are
not ref-tests.

* fast/layers/scroll-with-transform-composited-layer-expected.txt: Added.
* fast/layers/scroll-with-transform-composited-layer.html: Added.
* fast/layers/scroll-with-transform-layer-expected.txt: Added.
* fast/layers/scroll-with-transform-layer.html: Added.
* platform/mac-snowleopard/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
* platform/mac-snowleopard/fast/layers/scroll-with-transform-layer-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Fix compilation with ENABLE_WEB_AUDIO=0
peter@chromium.org [Tue, 10 Jan 2012 15:47:26 +0000 (15:47 +0000)]
[Chromium] Fix compilation with ENABLE_WEB_AUDIO=0
https://bugs.webkit.org/show_bug.cgi?id=75957

Reviewed by Tony Gentilcore.

Revision 104502 broke Chromium compilation for platforms which disable
the Web Audio API. All references to m_audioSourceProvider should be
guarded with the ENABLE(WEB_AUDIO) conditional.

* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::load):
(WebKit::WebMediaPlayerClientImpl::loadInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out an accidental commit r104569.
ossy@webkit.org [Tue, 10 Jan 2012 15:35:59 +0000 (15:35 +0000)]
Unreviewed, rolling out an accidental commit r104569.

* Shared/EditorState.cpp:
(WebKit::EditorState::encode):
(WebKit::EditorState::decode):
* Shared/EditorState.h:
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::inputMethodQuery):
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] fast/events/dont-loose-last-event test fails on WK1
commit-queue@webkit.org [Tue, 10 Jan 2012 15:32:31 +0000 (15:32 +0000)]
[Qt] fast/events/dont-loose-last-event test fails on WK1
https://bugs.webkit.org/show_bug.cgi?id=73894

Patch by Hugo Parente Lima <hugo.lima@openbossa.org> on 2012-01-10
Reviewed by Simon Hausmann.

Tools:

Empty the entire event queue when requested besides using
sendEvent instead of postEvent to make sure all events were
delivered.
This commit also removes not working DRT code to handle drag and drop,
for more refs see: https://bugs.webkit.org/show_bug.cgi?id=31332

* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::EventSender):
(EventSender::sendOrQueueEvent):
(EventSender::replaySavedEvents):
* DumpRenderTree/qt/EventSenderQt.h:

LayoutTests:

Remove fast/events/dont-loose-last-event from qt-wk1 skip list.

* platform/qt-wk1/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Chrome/Mac build.
senorblanco@chromium.org [Tue, 10 Jan 2012 15:32:17 +0000 (15:32 +0000)]
Fix Chrome/Mac build.

Build fix; unreviewed.

* platform/graphics/filters/skia/FEColorMatrixSkia.cpp:
(WebCore::luminanceToAlphaMatrix):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed potential Mac WK2 build fix.
kenneth@webkit.org [Tue, 10 Jan 2012 15:25:20 +0000 (15:25 +0000)]
Unreviewed potential Mac WK2 build fix.

* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::doneWithGestureEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWIP
kenneth@webkit.org [Tue, 10 Jan 2012 15:20:10 +0000 (15:20 +0000)]
WIP

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Added smart pointers to Ewk_View_Paint_Context class and done minor refactoring.
commit-queue@webkit.org [Tue, 10 Jan 2012 15:17:50 +0000 (15:17 +0000)]
[EFL] Added smart pointers to Ewk_View_Paint_Context class and done minor refactoring.
https://bugs.webkit.org/show_bug.cgi?id=75837

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2012-01-10
Reviewed by Ryosuke Niwa.

Changed graphicContext raw pointer to OwnPtr smart pointer.
Renamed cr to cairo and made it a RefPtr.

* ewk/ewk_view.cpp:
(ewk_view_paint_context_new): Adjust to auto pointers use.
(ewk_view_paint_context_free): Removed explicit raw pointers delete.
Adjust to auto pointers use:
(ewk_view_paint_context_save):
(ewk_view_paint_context_restore):
(ewk_view_paint_context_clip):
(ewk_view_paint_context_paint):
(ewk_view_paint_context_paint_contents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Add font-related API tests for QWebPreferences
commit-queue@webkit.org [Tue, 10 Jan 2012 15:14:05 +0000 (15:14 +0000)]
[Qt][WK2] Add font-related API tests for QWebPreferences
https://bugs.webkit.org/show_bug.cgi?id=75739

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-10
Reviewed by Zoltan Herczeg.

* UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:
* UIProcess/API/qt/tests/qmltests/common/font-preferences.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: [Skia] Switch FEColorMatrix to use a skia-based implementation when
senorblanco@chromium.org [Tue, 10 Jan 2012 15:01:07 +0000 (15:01 +0000)]
Source/WebCore: [Skia] Switch FEColorMatrix to use a skia-based implementation when
compiling with USE(SKIA).  This change will also switch the software
implementation of FEGaussianBlur to the skia implementation (ie.,
it removes the acceleration check).
https://bugs.webkit.org/show_bug.cgi?id=75582

Reviewed by Dirk Schulze.

Covered by svg/W3C-SVG-1.1/filters-color-01-b.svg and friends (will
need a rebaseline).

* WebCore.gypi:
Add FEColorMatrixSkia.cpp to the build.
* platform/graphics/filters/FEColorMatrix.h:
Add platformApplySkia().
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplySoftware):
Remove skia-specific code from FEGaussianBlur::platformApplySoftware().
* platform/graphics/filters/FEGaussianBlur.h:
Make platformApplySkia() virtual, and put it behind #if USE(SKIA).
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::apply):
Call out to platformApplySkia(), or fall back to
platformApplySoftware().
* platform/graphics/filters/FilterEffect.h:
Add platformApplySkia().
* platform/graphics/filters/skia/FEColorMatrixSkia.cpp: Added.
(WebCore::saturateMatrix):
(WebCore::hueRotateMatrix):
(WebCore::luminanceToAlphaMatrix):
(WebCore::FEColorMatrix::platformApplySkia):
Process color matrix effect, by calling out to generic matrix
version of SkColorMatrixFilter.
* platform/graphics/filters/skia/FEGaussianBlurSkia.cpp:
(WebCore::FEGaussianBlur::platformApplySkia):
Change the signature of FEGaussianBlur::platformApplySkia to be an
override of the new FilterEffect base class version.

LayoutTests: [chomium] Mark svg FEColorMatrix tests as needing new baselines.
https://bugs.webkit.org/show_bug.cgi?id=75582

Reviewed by Dirk Schulze.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix failing WK2 layout tests after r104557
hausmann@webkit.org [Tue, 10 Jan 2012 14:18:38 +0000 (14:18 +0000)]
[Qt] Fix failing WK2 layout tests after r104557

Reviewed by Kenneth Rohde Christiansen.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent): Add missing break to not
handle mouseDown as gesture event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed buildfix.
kenneth@webkit.org [Tue, 10 Jan 2012 14:13:44 +0000 (14:13 +0000)]
Unreviewed buildfix.

* UIProcess/WebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: fix DebuggerPresentationModel::uiSourceCodes - do not iterate
pfeldman@chromium.org [Tue, 10 Jan 2012 13:49:04 +0000 (13:49 +0000)]
Web Inspector: fix DebuggerPresentationModel::uiSourceCodes - do not iterate
over same raw source code multiple times.
https://bugs.webkit.org/show_bug.cgi?id=75953

Reviewed by Yury Semikhatsky.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Add getter for Ewk_JS_Object::view.
kubo@profusion.mobi [Tue, 10 Jan 2012 13:46:54 +0000 (13:46 +0000)]
[EFL] Add getter for Ewk_JS_Object::view.
https://bugs.webkit.org/show_bug.cgi?id=75868

Reviewed by Andreas Kling.

So far the view associated with a given JS object was a private
property only accessible to ewk itself. This does not make much sense,
as one often needs to know which view a certain method was invoked
from, for example.

* ewk/ewk_js.cpp:
(ewk_js_object_view_get):
* ewk/ewk_js.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
ossy@webkit.org [Tue, 10 Jan 2012 13:44:50 +0000 (13:44 +0000)]
Unreviewed gardening.

* platform/gtk/Skipped: Remove non-existent fast/dom/htmlcollection-zombies.html.
* platform/qt-wk2/Skipped: Skip fast/loader/submit-form-while-parsing-2.html, because it fails intermittently.
* platform/qt/Skipped: Remove non-existent fast/dom/htmlcollection-zombies.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Enable CSS_FILTERS in Qt build
ossy@webkit.org [Tue, 10 Jan 2012 13:44:02 +0000 (13:44 +0000)]
[Qt] Enable CSS_FILTERS in Qt build
https://bugs.webkit.org/show_bug.cgi?id=75777

Source/WebCore:

Enable CSS_FILTERS and unskip the tests.

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2012-01-10
Reviewed by Kenneth Rohde Christiansen.

Filter tests are now unskipped for Qt.

* Target.pri: add missing files to build.

Source/WebKit/qt:

For now, disallow compositing for filters. We will change that trigger when
https://bugs.webkit.org/show_bug.cgi?id=75778 is implemented.

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2012-01-10
Reviewed by Kenneth Rohde Christiansen.

* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::allowedCompositingTriggers):

Tools:

Add the CSS_FILTERS feature flag to Qt.

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2012-01-10
Reviewed by Kenneth Rohde Christiansen.

* qmake/mkspecs/features/features.prf:

LayoutTests:

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2012-01-10
Reviewed by Kenneth Rohde Christiansen.

Platform specific expected results tweaked by Csaba Osztrogonác.

* platform/qt/Skipped: Unskip filter tests that work.
* platform/qt/css3/filters/*: Added Qt specific results.
* platform/qt/fast/dom/Window/window-properties.html: Updated.
* platform/qt/fast/dom/Window/window-property-descriptors.html: Updated.
* platform/qt/fast/dom/prototype-inheritance-2.html: Updated.
* platform/qt/fast/js/global-constructors.html: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed -Werror build fix.
hausmann@webkit.org [Tue, 10 Jan 2012 13:36:26 +0000 (13:36 +0000)]
[Qt] Unreviewed -Werror build fix.

* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Remove dependency to uitools
hausmann@webkit.org [Tue, 10 Jan 2012 13:34:08 +0000 (13:34 +0000)]
[Qt] Remove dependency to uitools
https://bugs.webkit.org/show_bug.cgi?id=75952

Reviewed by Tor Arne Vestbø.

QUiLoader is used for creating QLabel/QProgressBar widgets for
a layout test, to verify some widget embedding feature. Unfortunately
in Qt 5, QUiLoader is part of qttools, which depends on webkit, which
depends on qttools. Since we don't really _need_ QUiLoader for our tests,
let's break the circular dependency.

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::createPlugin):
* QtTestBrowser/QtTestBrowser.pro:
* QtTestBrowser/launcherwindow.h:
* QtTestBrowser/webpage.cpp:
(WebPage::createPlugin):
* qmake/mkspecs/features/minimal_qt.prf:
* qmake/mkspecs/features/uitools.prf: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement the input panel request/close handling
kenneth@webkit.org [Tue, 10 Jan 2012 13:25:27 +0000 (13:25 +0000)]
Implement the input panel request/close handling

Reviewed by Simon Hausmann.

With the current patch we only request the input panel as a
response to a user tap. Close requests, on the other hand,
is always respected.

As multiple show/hide requests can happen while processing
the tap gesture, input panel visibility changes are postponed
until the tap gesture ends.

The input panel will become visible if the WebCore editor is
in canEdit mode and thus work for content-editable, meaning
that it won't close the input panel if you click on a link
(eg. editCommand) while in content-editable mode.

* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleGestureEvent):
(WebKit::WebPageProxy::editorStateChanged):
(WebKit::WebPageProxy::didReceiveEvent):

    Add a new doneWithGestureEvent method to the PageClient
    as well as add a updateTextInputState similar to that of mac.

* UIProcess/WebPageProxy.h:
* UIProcess/qt/QtPageClient.cpp:
(QtPageClient::updateTextInputState):
(QtPageClient::doneWithGestureEvent):

    Propagate the new events to the Qt EventHandler.

* UIProcess/qt/QtPageClient.h:
* UIProcess/qt/QtWebPageEventHandler.cpp:
* UIProcess/qt/QtWebPageEventHandler.h:
(QtWebPageEventHandler::QtWebPageEventHandler):
(QtWebPageEventHandler::handleSingleTapEvent):
(setInputPanelVisible):
(QtWebPageEventHandler::updateTextInputState):
(QtWebPageEventHandler::doneWithGestureEvent):

    Handle postponing of the input method visibility change
    and the actual showing/hiding.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserAppli...
commit-queue@webkit.org [Tue, 10 Jan 2012 13:24:58 +0000 (13:24 +0000)]
[Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication
https://bugs.webkit.org/show_bug.cgi?id=75894

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-10
Reviewed by Tor Arne Vestbø.

* MiniBrowser/qt/MiniBrowserApplication.h:
(MiniBrowserApplication::windowOptions):
* MiniBrowser/qt/main.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, chromium test expectations update.
vsevik@chromium.org [Tue, 10 Jan 2012 13:06:32 +0000 (13:06 +0000)]
Unreviewed, chromium test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: typo: NetworkAgent.canClearBrowserCache -> NetworkAgent.canClearBrowse...
pfeldman@chromium.org [Tue, 10 Jan 2012 13:00:47 +0000 (13:00 +0000)]
Web Inspector: typo: NetworkAgent.canClearBrowserCache -> NetworkAgent.canClearBrowserCookies.
https://bugs.webkit.org/show_bug.cgi?id=75949

Reviewed by Andreas Kling.

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: restore front-end compilation
pfeldman@chromium.org [Tue, 10 Jan 2012 12:57:00 +0000 (12:57 +0000)]
Web Inspector: restore front-end compilation
https://bugs.webkit.org/show_bug.cgi?id=75625

Patch by pfeldman@chomium.org <pavel.feldman@gmail.com> on 2012-01-10
Reviewed by Yury Semikhatsky.

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.replaceSourceFrames):
* inspector/front-end/TabbedPane.js:
* inspector/front-end/externs.js:
(WebInspector.isCompactMode):
* inspector/front-end/treeoutline.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd NULL checks to setting access obtained on frame and document.
commit-queue@webkit.org [Tue, 10 Jan 2012 12:19:42 +0000 (12:19 +0000)]
Add NULL checks to setting access obtained on frame and document.
https://bugs.webkit.org/show_bug.cgi?id=72002

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-01-10
Reviewed by Andreas Kling.

Adds NULL checks to setting object where it's required.
Generally WebCore checks NULL which may be returned from setting object obtained
on frame or document but in some cases these are skipped. These checks are not
needed to setting's access on page object.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::shouldAccelerate):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::scheduleArchiveLoad):
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::requestPlugin):
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::selectCache):
(WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
* page/DragController.cpp:
(WebCore::DragController::draggableNode):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseReleaseEvent):
* page/FocusController.cpp:
(WebCore::FocusController::advanceFocusInDocumentOrder):
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::flattenFrameSet):
* rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::flattenFrame):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):
* rendering/RenderText.cpp:
(WebCore::SecureTextTimer::restartWithNewText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] DRT crashes with Qt 5
hausmann@webkit.org [Tue, 10 Jan 2012 12:11:42 +0000 (12:11 +0000)]
[Qt] DRT crashes with Qt 5
https://bugs.webkit.org/show_bug.cgi?id=75951

Reviewed by Ossy.

* DumpRenderTree/qt/fonts.conf: Add missing last-resort font fallback for Qt 5 where
Qt relies on font-config to define the default font family.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMatched declaration cache should support mapped attribute declarations.
kling@webkit.org [Tue, 10 Jan 2012 11:35:32 +0000 (11:35 +0000)]
Matched declaration cache should support mapped attribute declarations.
<http://webkit.org/b/75948>

Reviewed by Antti Koivisto.

Support caching of matches that include mapped attribute declarations.
To make this possible, let the cache hold references to the matched style declarations.
Otherwise, declarations are assumed to survive until ~CSSStyleSelector, which may not
be the case for CSSMappedAttributeDeclaration.

To avoid hoarding of stale CSSMappedAttributeDeclarations in the cache, do a sweep for
every 100 additions and garbage collect any entries containing a declaration that is
only referenced by the cache.

This increases cache hit rate by up to ~10% on the Alexa top sites.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::sweepMatchedDeclarationCache):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::addToMatchedDeclarationCache):
* css/CSSStyleSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Remove codes to move and resize the clip.
commit-queue@webkit.org [Tue, 10 Jan 2012 11:33:37 +0000 (11:33 +0000)]
[EFL][WK2] Remove codes to move and resize the clip.
https://bugs.webkit.org/show_bug.cgi?id=75428

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-01-10
Reviewed by Andreas Kling.

Remove codes to move and resize the clip because clip is not used now.
We have to show whole area of evas_object_image so we don't have to
clip any area.
In the WebKit1 Efl, the clip is used to clip the area to show during
weak zoom, so we can use codes to manipulate the clip when we want to
implement weak zoom for WebKit2 Efl.

* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_calculate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] REGRESSION(r100130): Clean build feature is broken.
ossy@webkit.org [Tue, 10 Jan 2012 11:30:21 +0000 (11:30 +0000)]
[Qt] REGRESSION(r100130): Clean build feature is broken.
https://bugs.webkit.org/show_bug.cgi?id=75863

Reviewed by Tor Arne Vestbø.

* Scripts/webkitdirs.pm:
(buildQMakeProject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd initial test_expectations.txt for EFL port.
gyuyoung.kim@samsung.com [Tue, 10 Jan 2012 11:20:15 +0000 (11:20 +0000)]
Add initial test_expectations.txt for EFL port.
https://bugs.webkit.org/show_bug.cgi?id=75940

Reviewed by Andreas Kling.

This file only has skip list for now. But, EFL patches will update
this file from now on.

* platform/efl/test_expectations.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
zeno.albisser@nokia.com [Tue, 10 Jan 2012 11:06:52 +0000 (11:06 +0000)]
[Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=75885

In QML events are propagated through parents. But since the
WebView may consume key events, a shortcut might never reach
the top QtQuickItem.
Therefore an application wide event handling function in C++
needs to take care of shortcuts for MiniBrowser.

Reviewed by Kenneth Rohde Christiansen.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::reload):
(BrowserWindow::focusAddressBar):
* MiniBrowser/qt/BrowserWindow.h:
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify):
* MiniBrowser/qt/qml/BrowserWindow.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoComplex path should be used when UVS exists in text run
bashi@chromium.org [Tue, 10 Jan 2012 10:46:31 +0000 (10:46 +0000)]
Complex path should be used when UVS exists in text run
https://bugs.webkit.org/show_bug.cgi?id=75289

Source/WebCore:

Uses complex path when a text run contains UVS. The range from U+180B to U+180D already uses complex path.
Removes unnecessary functions that were added by r102915.

Reviewed by Dan Bernstein.

No new tests. fast/text/unicode-variation-selector.html should take care of this change.

* platform/graphics/Font.cpp:
(WebCore::Font::codePath): Use Complex path when the text run contains UVS.
* platform/graphics/SimpleFontData.h: Removed updateGlyphWithVariationSelector().
* platform/graphics/SurrogatePairAwareTextIterator.cpp: Removed unnecessary static functions.
* platform/graphics/SurrogatePairAwareTextIterator.h: Removed hasTrailingVariationSelector().
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advance): Removed UVS detection code.
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Removed updateGlyphWithVariationSelector().
* platform/graphics/freetype/SimpleFontDataFreeType.cpp: Ditto.
* platform/graphics/harfbuzz/SimpleFontDataSkia.cpp: Ditto.
* platform/graphics/mac/SimpleFontDataMac.mm: Ditto.
* platform/graphics/pango/SimpleFontDataPango.cpp: Ditto.
* platform/graphics/qt/SimpleFontDataQt.cpp: Ditto.
* platform/graphics/win/SimpleFontDataWin.cpp: Ditto.
* platform/graphics/wince/SimpleFontDataWinCE.cpp: Ditto.
* platform/graphics/wx/SimpleFontDataWx.cpp: Ditto.

LayoutTests:

Reviewed by Dan Bernstein.

* platform/chromium/test_expectations.txt: Updates expectation for fast/text/unicode-variation-selector.html. Need rebaselines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd --efl alias for --platform=efl to run-webkit-test
gyuyoung.kim@samsung.com [Tue, 10 Jan 2012 10:34:46 +0000 (10:34 +0000)]
Add --efl alias for --platform=efl to run-webkit-test
https://bugs.webkit.org/show_bug.cgi?id=75937

Reviewed by Andreas Kling.

* Scripts/run-webkit-tests: Add --efl alias.
* Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --efl alias.
(parse_args):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoblock mask overlay test for CSS3 calc
mikelawther@chromium.org [Tue, 10 Jan 2012 10:21:29 +0000 (10:21 +0000)]
block mask overlay test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75896

Reviewed by Ryosuke Niwa.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

* css3/calc/block-mask-overlay-image-outset-expected-mismatch.html: Added.
* css3/calc/block-mask-overlay-image-outset.html: Added.
* css3/calc/resources/mask.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebFonts are re-fetched from the server upon Document::styleSelectorChanged call.
bashi@chromium.org [Tue, 10 Jan 2012 10:13:02 +0000 (10:13 +0000)]
WebFonts are re-fetched from the server upon Document::styleSelectorChanged call.
https://bugs.webkit.org/show_bug.cgi?id=73419

Source/WebCore:

Holds the CachedFont handle in CSSFontFaceSrcValue so that avoiding re-validation during style recalculation.

Reviewed by Dan Bernstein.

Test: http/tests/css/font-face-src-loading.html

* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::cachedFont): Added.
* css/CSSFontFaceSrcValue.h:
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule): Gets the CachedFont from CSSFontFaceSrcValue object. The object will request the resource if it doesn't exist.

LayoutTests:

Reviewed by Dan Bernstein.

Adds a test that ensures re-fetching WebFonts doesn't occur after style recalculation.

* http/tests/css/font-face-src-loading-expected.txt: Added.
* http/tests/css/font-face-src-loading.html: Added.
* http/tests/css/resources/webfont-request.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: introduce experimental setting that makes source files always editable
pfeldman@chromium.org [Tue, 10 Jan 2012 09:58:33 +0000 (09:58 +0000)]
Web Inspector: introduce experimental setting that makes source files always editable
https://bugs.webkit.org/show_bug.cgi?id=75626

Patch by pfeldman@chomium.org <pavel.feldman@gmail.com> on 2012-01-10
Reviewed by Timothy Hatcher.

* English.lproj/localizedStrings.js:
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.setReadOnly):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.NavigatorScriptTreeElement.prototype.onselect):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.get statusBarItems):
(WebInspector.SourceFrame.prototype.setReadOnly):
* inspector/front-end/inspector.js:
(WebInspector.loaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRoll Chromium DEPS from 116979 to 117006.
rniwa@webkit.org [Tue, 10 Jan 2012 09:08:57 +0000 (09:08 +0000)]
Roll Chromium DEPS from 116979 to 117006.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed test fix after r103683.
loislo@chromium.org [Tue, 10 Jan 2012 09:08:06 +0000 (09:08 +0000)]
Unreviewed test fix after r103683.

* inspector/first-open-scripts.html:
* inspector/show-panel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r104507.
commit-queue@webkit.org [Tue, 10 Jan 2012 05:42:38 +0000 (05:42 +0000)]
Unreviewed, rolling out r104507.
http://trac.webkit.org/changeset/104507
https://bugs.webkit.org/show_bug.cgi?id=75936

Broke webkit_unit_tests (Requested by dimich on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-09

Source/WebCore:

* WebCore.gypi:
* platform/graphics/chromium/RenderSurfaceChromium.h:
* platform/graphics/chromium/cc/CCLayerIterator.cpp: Removed.
* platform/graphics/chromium/cc/CCLayerIterator.h: Removed.
* platform/graphics/chromium/cc/CCLayerIteratorPosition.h: Removed.
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::walkLayersAndCalculateVisibleLayerRects):
* platform/graphics/chromium/cc/CCRenderSurface.h:

Source/WebKit/chromium:

* WebKit.gypi:
* tests/CCLayerIteratorTest.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTouch WebView.h in an attempt to clobber Chromium bots on build.webkit.org.
rniwa@webkit.org [Tue, 10 Jan 2012 05:39:34 +0000 (05:39 +0000)]
Touch WebView.h in an attempt to clobber Chromium bots on build.webkit.org.

* public/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed rebaseline, fixing incorrect rebaseline from r104489.
dimich@chromium.org [Tue, 10 Jan 2012 04:44:03 +0000 (04:44 +0000)]
[Chromium] Unreviewed rebaseline, fixing incorrect rebaseline from r104489.

* platform/chromium-gpu-linux/media/media-document-audio-repaint-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed update for test_expectations.txt.
dimich@chromium.org [Tue, 10 Jan 2012 04:12:53 +0000 (04:12 +0000)]
[Chromium] Unreviewed update for test_expectations.txt.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRoll Chromium DEPS from 116459 to 116979.
rniwa@webkit.org [Tue, 10 Jan 2012 04:10:46 +0000 (04:10 +0000)]
Roll Chromium DEPS from 116459 to 116979.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Rebaseline a lot of tests with input controls after r104494
dimich@chromium.org [Tue, 10 Jan 2012 03:00:26 +0000 (03:00 +0000)]
[Chromium] Rebaseline a lot of tests with input controls after r104494
https://bugs.webkit.org/show_bug.cgi?id=75924

Unreviewed.

* platform/chromium-linux-x86/tables/mozilla/bugs/bug4527-expected.png: Removed.
* platform/chromium-mac-leopard/editing/input/caret-at-the-edge-of-input-expected.png:
* platform/chromium-mac-leopard/editing/inserting/before-after-input-element-expected.png:
* platform/chromium-mac-leopard/editing/pasteboard/4806874-expected.png:
* platform/chromium-mac-leopard/editing/pasteboard/drop-text-without-selection-expected.png:
* platform/chromium-mac-leopard/editing/pasteboard/input-field-1-expected.png:
* platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png:
* platform/chromium-mac-leopard/editing/selection/3690703-expected.png:
* platform/chromium-mac-leopard/editing/selection/3690719-expected.png:
* platform/chromium-mac-leopard/editing/selection/4895428-3-expected.png:
* platform/chromium-mac-leopard/editing/selection/4975120-expected.png:
* platform/chromium-mac-leopard/editing/selection/drag-select-1-expected.png:
* platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-1-expected.png:
* platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-2-expected.png:
* platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-3-expected.png:
* platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-4-expected.png:
* platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-5-expected.png:
* platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png:
* platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.png:
* platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
* platform/chromium-mac-leopard/fast/css/line-height-expected.png:
* platform/chromium-mac-leopard/fast/dom/isindex-001-expected.png:
* platform/chromium-mac-leopard/fast/dom/isindex-002-expected.png:
* platform/chromium-mac-leopard/fast/events/autoscroll-expected.png:
* platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.png:
* platform/chromium-mac-leopard/fast/forms/basic-inputs-expected.png:
* platform/chromium-mac-leopard/fast/forms/encoding-test-expected.png:
* platform/chromium-mac-leopard/fast/forms/fieldset-align-expected.png:
* platform/chromium-mac-leopard/fast/forms/floating-textfield-relayout-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-align-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-appearance-default-bkcolor-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-appearance-disabled-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-appearance-focus-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-appearance-height-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-appearance-preventDefault-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-appearance-readonly-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-appearance-selection-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-appearance-visibility-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-appearance-width-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-baseline-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-field-text-truncated-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-readonly-autoscroll-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-readonly-dimmed-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-readonly-empty-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-spaces-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-table-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-text-click-inside-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-text-click-outside-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-text-double-click-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-text-drag-down-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-text-option-delete-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-text-self-emptying-click-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-text-word-wrap-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-type-text-min-width-expected.png:
* platform/chromium-mac-leopard/fast/forms/minWidthPercent-expected.png:
* platform/chromium-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.png:
* platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
* platform/chromium-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
* platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png:
* platform/chromium-mac-leopard/fast/forms/placeholder-pseudo-style-expected.png:
* platform/chromium-mac-leopard/fast/forms/plaintext-mode-2-expected.png:
* platform/chromium-mac-leopard/fast/forms/tabbing-input-iframe-expected.png:
* platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png:
* platform/chromium-mac-leopard/fast/forms/textfield-focus-ring-expected.png:
* platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png:
* platform/chromium-mac-leopard/fast/frames/take-focus-from-iframe-expected.png:
* platform/chromium-mac-leopard/fast/html/details-no-summary4-expected.png:
* platform/chromium-mac-leopard/fast/html/details-open-javascript-expected.png:
* platform/chromium-mac-leopard/fast/html/details-open2-expected.png:
* platform/chromium-mac-leopard/fast/html/details-open4-expected.png:
* platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.png:
* platform/chromium-mac-leopard/fast/replaced/replaced-breaking-mixture-expected.png:
* platform/chromium-mac-leopard/fast/replaced/width100percent-textfield-expected.png:
* platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
* platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
* platform/chromium-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
* platform/chromium-mac-leopard/fast/table/003-expected.png:
* platform/chromium-mac-leopard/fast/table/text-field-baseline-expected.png:
* platform/chromium-mac-leopard/http/tests/navigation/javascriptlink-frames-expected.png:
* platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png:
* platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/45621-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug12384-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug18359-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug24200-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug28928-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug4382-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-1-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-2-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug51037-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug55545-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug59354-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug7342-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug96334-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug99948-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/dom/tableDom-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/other/move_row-expected.png:
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
* platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/4975120-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
* platform/chromium-mac-snowleopard/fast/block/float/032-expected.png: Renamed from LayoutTests/platform/chromium/fast/block/float/032-expected.png.
* platform/chromium-mac-snowleopard/fast/block/margin-collapse/103-expected.png:
* platform/chromium-mac-snowleopard/fast/css/input-search-padding-expected.png:
* platform/chromium-mac-snowleopard/fast/css/line-height-expected.png:
* platform/chromium-mac-snowleopard/fast/dom/isindex-001-expected.png:
* platform/chromium-mac-snowleopard/fast/dom/isindex-002-expected.png:
* platform/chromium-mac-snowleopard/fast/events/autoscroll-expected.png:
* platform/chromium-mac-snowleopard/fast/events/context-no-deselect-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/basic-inputs-expected.txt.
* platform/chromium-mac-snowleopard/fast/forms/encoding-test-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/fieldset-align-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-align-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/input-appearance-disabled-expected.txt.
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/input-appearance-height-expected.txt.
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-selection-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-baseline-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-readonly-empty-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-table-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-click-inside-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-click-outside-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-word-wrap-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-type-text-min-width-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-width-expected.png: Copied from LayoutTests/platform/chromium/fast/forms/input-width-expected.png.
* platform/chromium-mac-snowleopard/fast/forms/minWidthPercent-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/tables/mozilla/bugs/bug55545-expected.png.
* platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
* platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/placeholder-pseudo-style-expected.txt.
* platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/validation-message-appearance-expected.txt.
* platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png:
* platform/chromium-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.png:
* platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.png:
* platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png:
* platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png:
* platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png:
* platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
* platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png:
* platform/chromium-mac-snowleopard/fast/replaced/width100percent-textfield-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
* platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.txt: Renamed from LayoutTests/platform/chromium/fast/speech/input-appearance-numberandspeech-expected.txt.
* platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
* platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.txt: Renamed from LayoutTests/platform/chromium/fast/speech/input-appearance-speechbutton-expected.txt.
* platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
* platform/chromium-mac-snowleopard/fast/table/003-expected.png:
* platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-expected.png: Renamed from LayoutTests/platform/chromium/fast/table/colspanMinWidth-expected.png.
* platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-vertical-expected.png: Renamed from LayoutTests/platform/chromium/fast/forms/input-width-expected.png.
* platform/chromium-mac-snowleopard/fast/table/spanOverlapRepaint-expected.png:
* platform/chromium-mac-snowleopard/fast/table/text-field-baseline-expected.png:
* platform/chromium-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.png:
* platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png:
* platform/chromium-mac-snowleopard/plugins/mouse-click-plugin-clears-selection-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/textfield-overflow-expected.png.
* platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
* platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/45621-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug24200-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug59354-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png: Removed.
* platform/chromium-win-vista/tables/mozilla/bugs/bug4527-expected.png: Removed.
* platform/chromium-win-xp/tables/mozilla/bugs/bug4527-expected.png: Removed.
* platform/chromium/fast/forms/minWidthPercent-expected.png: Removed.
* platform/chromium/fast/replaced/width100percent-textfield-expected.png: Removed.
* platform/chromium/fast/table/colspanMinWidth-vertical-expected.png: Removed.
* platform/chromium/plugins/mouse-click-plugin-clears-selection-expected.png: Removed.
* platform/chromium/tables/mozilla/bugs/bug24200-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-01-09 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Tue, 10 Jan 2012 02:40:36 +0000 (02:40 +0000)]
2012-01-09  Rob Buis  <rbuis@rim.com>

        Upstream change to disable input[color] css rules for BlackBerry port
        https://bugs.webkit.org/show_bug.cgi?id=75719

        Reviewed by Antonio Gomes.

        Do not enable default css color rules for input["color"] for BlackBerry port.

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Implement navigator.startActivity; add IntentRequest object for manag...
commit-queue@webkit.org [Tue, 10 Jan 2012 02:29:38 +0000 (02:29 +0000)]
Source/WebCore: Implement navigator.startActivity; add IntentRequest object for managing web intents callbacks.
Web content will invoke navigator.startActivity to launch a new Web
Intents call. Each such call will map to an IntentRequest broker
object which is used by client code to correlate any return data to
the (optional) callbacks supplied by web content calls.
https://bugs.webkit.org/show_bug.cgi?id=75756

Patch by Greg Billock <gbillock@google.com> on 2012-01-09
Reviewed by Adam Barth.

Test: webintents/web-intents-api.html

* Modules/intents/Intent.cpp: Added.
(WebCore::Intent::identifier):
(WebCore::Intent::setIdentifier):
* Modules/intents/Intent.h: Added.
* Modules/intents/Intent.idl: Added.
* Modules/intents/IntentResultCallback.h: Added.
(WebCore::IntentResultCallback::~IntentResultCallback):
* Modules/intents/IntentResultCallback.idl: Added.
* Modules/intents/IntentsRequest.cpp: Added.
* Modules/intents/IntentsRequest.h: Added.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* bindings/scripts/CodeGeneratorV8.pm:
(GetNativeTypeForCallbacks):
* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::dispatchIntent):

LayoutTests: Implement navigator.startActivity; add IntentsController for managing web intents callbacks.
https://bugs.webkit.org/show_bug.cgi?id=75756

Patch by Greg Billock <gbillock@google.com> on 2012-01-09
Reviewed by Adam Barth.

* webintents/web-intents-api-expected.txt: Added.
* webintents/web-intents-api.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago-[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
mitz@apple.com [Tue, 10 Jan 2012 02:14:33 +0000 (02:14 +0000)]
-[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
https://bugs.webkit.org/show_bug.cgi?id=75920

Reviewed by Darin Adler.

Source/WebCore:

Test: added to TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm

* page/mac/FrameMac.mm:
(WebCore::Frame::rangeImage): Removed the requirement that the start and end positions used
for setting the selection in the render tree be candidates.

Tools:

* TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
(TestWebKitAPI::TEST): Added a test for a range in a
-webkit-user-select: none; block.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Refactoring] Moving between TreeScopes should be done by its own class.
morrita@google.com [Tue, 10 Jan 2012 02:11:30 +0000 (02:11 +0000)]
[Refactoring] Moving between TreeScopes should be done by its own class.
https://bugs.webkit.org/show_bug.cgi?id=75290

Reviewed by Ryosuke Niwa.

This change extracted Node::setTreeScopeRecursively(),
setDocumentRecursively() and a part of setDocument() into a new
class called TreeScopeAdopter. By doing this, the idea of
moving a node from scope to scope, that was originally hidden
behind the forest of Node APIs, has become clearer.

Note that this change is a preparation for Bug 59816.

No new tests. No behavioral change.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/ContainerNode.cpp: Followed the renaming.
(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):
* dom/DOMAllInOne.cpp:
* dom/Document.cpp: Followed te renaming.
(WebCore::Document::setDocType):
(WebCore::Document::adoptNode):
* dom/Element.cpp: Followed te renaming.
(WebCore::Element::removeShadowRoot):
* dom/Node.cpp:
(WebCore::Node::setDocument):
(WebCore::Node::setTreeScope):
(WebCore::Node::didMoveToNewDocument):
* dom/Node.h:
* dom/TreeScope.h:
* dom/TreeScope.cpp:
(WebCore::TreeScope::adoptIfNeeded): moved from setTreeScopeRecursively()
* dom/TreeScopeAdopter.cpp: Added.
(WebCore::TreeScopeAdopter::TreeScopeAdopter):
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveTreeToNewDocument):
(WebCore::TreeScopeAdopter::ensureDidMoveToNewDocumentWasCalled):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):
* dom/TreeScopeAdopter.h: Added.
(WebCore::TreeScopeAdopter::ensureDidMoveToNewDocumentWasCalled):
(WebCore::TreeScopeAdopter::execute):
(WebCore::TreeScopeAdopter::needsScopeChange()):
(WebCore::TreeScopeAdopter::shadowRootFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoError handling : in ISO8601 timezone
barraclough@apple.com [Tue, 10 Jan 2012 02:03:22 +0000 (02:03 +0000)]
Error handling : in ISO8601 timezone
https://bugs.webkit.org/show_bug.cgi?id=75919

Reviewed by Sam Weinig.

Source/JavaScriptCore:

* wtf/DateMath.cpp:
(WTF::parseDateFromNullTerminatedCharacters):
    - need to increment the string position.

LayoutTests:

* fast/js/date-parse-test-expected.txt:
* fast/js/script-tests/date-parse-test.js:
    - added test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agorun-bindings-tests should exercise all the IDL attributes we use
abarth@webkit.org [Tue, 10 Jan 2012 01:56:56 +0000 (01:56 +0000)]
run-bindings-tests should exercise all the IDL attributes we use
https://bugs.webkit.org/show_bug.cgi?id=75900

Reviewed by Eric Seidel.

I just grepped through the code generator script for IDL attributes and
wrote tests for them.

* bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.cpp: Added.
* bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.h: Added.
* bindings/scripts/test/CPP/WebDOMTestEventTarget.cpp: Added.
* bindings/scripts/test/CPP/WebDOMTestEventTarget.h: Added.
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/CPP/WebDOMTestOverridingNameGetter.cpp: Added.
* bindings/scripts/test/CPP/WebDOMTestOverridingNameGetter.h: Added.
* bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp: Added.
* bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h: Added.
* bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObjectPrivate.h: Added.
* bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp: Added.
* bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h: Added.
* bindings/scripts/test/GObject/WebKitDOMTestEventTargetPrivate.h: Added.
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.cpp: Added.
* bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetter.h: Added.
* bindings/scripts/test/GObject/WebKitDOMTestOverridingNameGetterPrivate.h: Added.
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: Added.
* bindings/scripts/test/JS/JSTestActiveDOMObject.h: Added.
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
* bindings/scripts/test/JS/JSTestEventTarget.cpp: Added.
* bindings/scripts/test/JS/JSTestEventTarget.h: Added.
* bindings/scripts/test/JS/JSTestInterface.cpp:
* bindings/scripts/test/JS/JSTestInterface.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/JS/JSTestOverridingNameGetter.cpp: Added.
* bindings/scripts/test/JS/JSTestOverridingNameGetter.h: Added.
* bindings/scripts/test/ObjC/DOMTestActiveDOMObjectInternal.h: Added.
* bindings/scripts/test/ObjC/DOMTestEventTarget.h: Added.
* bindings/scripts/test/ObjC/DOMTestEventTarget.mm: Added.
* bindings/scripts/test/ObjC/DOMTestEventTargetInternal.h: Added.
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
* bindings/scripts/test/ObjC/DOMTestOverridingNameGetter.h: Added.
* bindings/scripts/test/ObjC/DOMTestOverridingNameGetter.mm: Added.
* bindings/scripts/test/ObjC/DOMTestOverridingNameGetterInternal.h: Added.
* bindings/scripts/test/TestDomainSecurity.idl: Added.
* bindings/scripts/test/TestEventConstructor.idl:
* bindings/scripts/test/TestEventTarget.idl: Added.
* bindings/scripts/test/TestInterface.idl:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/TestOverridingNameGetter.idl: Added.
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp: Added.
* bindings/scripts/test/V8/V8TestActiveDOMObject.h: Added.
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
* bindings/scripts/test/V8/V8TestEventTarget.cpp: Added.
* bindings/scripts/test/V8/V8TestEventTarget.h: Added.
* bindings/scripts/test/V8/V8TestInterface.h:
* bindings/scripts/test/V8/V8TestObj.cpp:
* bindings/scripts/test/V8/V8TestOverridingNameGetter.cpp: Added.
* bindings/scripts/test/V8/V8TestOverridingNameGetter.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agobackground position parsing test for CSS3 calc
mikelawther@chromium.org [Tue, 10 Jan 2012 01:54:08 +0000 (01:54 +0000)]
background position parsing test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75823

Reviewed by Daniel Bates.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

* css3/calc/background-position-parsing-expected-mismatch.html: Added.
* css3/calc/background-position-parsing.html: Added.
* css3/calc/resources/diamond.png: Added.
* css3/calc/resources/ring.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing...
dpranke@chromium.org [Tue, 10 Jan 2012 01:32:54 +0000 (01:32 +0000)]
webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win
https://bugs.webkit.org/show_bug.cgi?id=75884

Reviewed by Ryosuke Niwa.

Fix regression introduced (revealed?) in r104340. Chromium file
url syntax is different on win32 and the test results weren't
expecting that.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations._report_errors):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_parse_error_nonfatal):
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockDRTTest.input_line):
(MockChromiumDRTTest.test_pixeltest__fails):
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
(TestRebaseliner.make_rebaseliner):
(TestRebaseliner.test_one_platform):
(TestRebaseliner.test_all_platforms):
(TestRebaseliner.test_png_file_with_comment):
(TestRebaseliner.test_png_file_with_comment_remove_old_checksum):
(TestRebaseliner.test_png_file_with_comment_as_duplicate):
(TestRealMain.test_all_platforms):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttp/tests/inspector-enabled/dedicated-workers-list.html flakey on linux
noel.gordon@gmail.com [Tue, 10 Jan 2012 01:24:13 +0000 (01:24 +0000)]
http/tests/inspector-enabled/dedicated-workers-list.html flakey on linux
https://bugs.webkit.org/show_bug.cgi?id=75186

Reviewed by Adam Barth.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add documentation to updater classes
nduca@chromium.org [Tue, 10 Jan 2012 01:21:14 +0000 (01:21 +0000)]
[chromium] Add documentation to updater classes
https://bugs.webkit.org/show_bug.cgi?id=75866

Reviewed by James Robinson.

* platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
* platform/graphics/chromium/CanvasLayerTextureUpdater.h:
* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h:
* platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104522 268f45cc-cd09-0410-ab3c-d52691b4dbfc