WebKit-https.git
7 years ago[GTK] Wrong ASSERT in AudioDestinationGstreamer::stop
commit-queue@webkit.org [Thu, 14 Mar 2013 13:56:40 +0000 (13:56 +0000)]
[GTK] Wrong ASSERT in AudioDestinationGstreamer::stop
https://bugs.webkit.org/show_bug.cgi?id=112344

Patch by Xan Lopez <xlopez@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.

Correct erroneous ASSERT, we want both member variables to exist.

* platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestinationGStreamer::stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Flame Chart. Support scroll and zoom with help of mouse wheel.
loislo@chromium.org [Thu, 14 Mar 2013 13:36:00 +0000 (13:36 +0000)]
Web Inspector: Flame Chart. Support scroll and zoom with help of mouse wheel.
https://bugs.webkit.org/show_bug.cgi?id=112337

Reviewed by Yury Semikhatsky.

New member variable _xOffset were introduced.

* inspector/front-end/FlameChart.js:
(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._onMouseMove):
(WebInspector.FlameChart.prototype._adjustXOffset):
(WebInspector.FlameChart.prototype._adjustXScale):
(WebInspector.FlameChart.prototype._onMouseWheel):
(WebInspector.FlameChart.prototype._coordinatesToNodeIndex):
(WebInspector.FlameChart.prototype.onResize):
(WebInspector.FlameChart.prototype.draw):
(WebInspector.FlameChart.prototype._scheduleUpdate):
(WebInspector.FlameChart.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Texmap] Synchronize layers only if the layer has been changed.
kbalazs@webkit.org [Thu, 14 Mar 2013 12:29:43 +0000 (12:29 +0000)]
[Texmap] Synchronize layers only if the layer has been changed.
https://bugs.webkit.org/show_bug.cgi?id=112095

Patch by No'am Rosenthal <noam@webkit.org> on 2013-03-14
Reviewed by Allan Sandfeld Jensen.

A regression was introduced in r144787, causing an infinite IPC commitState/renderNextFrame
loop.
This patch fixes this by making sure we only commit layer states that have actual pending
changes.

No new tests, this is an optimization.

* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
(CoordinatedGraphicsLayerState):
(WebCore::CoordinatedGraphicsLayerState::hasPendingChanges):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Improve the handling of mock geolocation, device orientation and motion clients
hausmann@webkit.org [Thu, 14 Mar 2013 11:52:40 +0000 (11:52 +0000)]
[Qt] Improve the handling of mock geolocation, device orientation and motion clients

Reviewed by Tor Arne Vestbø.

The mock versions of these web facing features should be instantiated when
running in DumpRenderTree only. In order for them to work, no extra Qt modules
such as QtLocation are actually needed.

This patch decouples enabling device orientation/motion and geolocation from
the underlying Qt modules and makes them available in developer builds
(!production_build) and backed by mock backends when running in drt.

So if the Qt 5 modules are available, they'll be used (unless drtRun). For
developers the web facing features are always enabled (although requests will
time out) and the mock backends are enabled inside DRT, allowing for the layout
tests to run with less dependencies.

In addition this also enables the mock device motion client, which was
previously never instantiated.

.:

* Source/widgetsapi.pri:

Source/WebCore:

* Target.pri:
* WebCore.pri:

Source/WebKit:

* WebKit1.pri:
* WebKit1.pro:

Source/WebKit/qt:

* WebCoreSupport/QWebFrameAdapter.cpp:
(QWebFrameAdapter::_q_orientationChanged):
* WebCoreSupport/QWebFrameAdapter.h:
* WebCoreSupport/QWebPageAdapter.cpp:
(QWebPageAdapter::initializeWebCorePage):
* WebCoreSupport/QWebPageAdapter.h:
* WidgetApi/qwebframe.cpp:
(QWebFrame::QWebFrame):
* WidgetApi/qwebpage.cpp:
(QWebPage::setFeaturePermission):

Source/WebKit2:

* Target.pri:
* UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
* UIProcess/qt/WebGeolocationProviderQt.cpp:
* WebKit2.pri:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):

Tools:

* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Removing no-ops and simple setters/getters from TestRunnerQt
zeno.albisser@digia.com [Thu, 14 Mar 2013 11:46:06 +0000 (11:46 +0000)]
[Qt] Removing no-ops and simple setters/getters from TestRunnerQt
https://bugs.webkit.org/show_bug.cgi?id=112340

Reviewed by Simon Hausmann.

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(DumpRenderTree::dump):
    Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
(DumpRenderTree::dumpApplicationCacheQuota):
* DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunnerQt::reset):
* DumpRenderTree/qt/TestRunnerQt.h:
(TestRunnerQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[TexMap] Painting into area of composited tile not cleared
allan.jensen@digia.com [Thu, 14 Mar 2013 11:26:39 +0000 (11:26 +0000)]
[TexMap] Painting into area of composited tile not cleared
https://bugs.webkit.org/show_bug.cgi?id=112268

Reviewed by Kenneth Rohde Christiansen.

Clip painting to the area that has been cleared, so we
do not accidentally overpaint other areas.

Can be observed in ManualTests/scrollbars/scrollbars-in-composited-layers.html.

* platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::updateContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Store main world and non-main world templates separately.
commit-queue@webkit.org [Thu, 14 Mar 2013 11:12:22 +0000 (11:12 +0000)]
[V8] Store main world and non-main world templates separately.
https://bugs.webkit.org/show_bug.cgi?id=111724

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-14
Reviewed by Jochen Eisinger.

This is needed for generating specialized bindings for the main
world (bug 110874).

Source/WebCore:

No new tests (updated existing bindings tests).

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateNormalAttrSetter):
(GenerateParametersCheckExpression):
(GenerateParametersCheck):
(GenerateImplementation):
(JSValueToNative):
(CreateCustomSignature):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::Float64ArrayV8Internal::fooMethod):
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):
* bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionMethod):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::dispatchEventMethod):
(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):
* bindings/scripts/test/V8/V8TestException.h:
(V8TestException):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Method):
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):
* bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):
* bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::mutablePointAttrSetter):
(WebCore::TestObjV8Internal::immutablePointAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsMethod):
(WebCore::TestObjV8Internal::longMethodWithArgsMethod):
(WebCore::TestObjV8Internal::objMethodWithArgsMethod):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsMethod):
(WebCore::TestObjV8Internal::overloadedMethod1Method):
(WebCore::TestObjV8Internal::overloadedMethod2Method):
(WebCore::TestObjV8Internal::overloadedMethod8Method):
(WebCore::TestObjV8Internal::overloadedMethodMethod):
(WebCore::TestObjV8Internal::convert1Method):
(WebCore::TestObjV8Internal::convert2Method):
(WebCore::TestObjV8Internal::convert4Method):
(WebCore::TestObjV8Internal::convert5Method):
(WebCore::TestObjV8Internal::variadicNodeMethodMethod):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::TestOverloadedConstructorsV8Internal::constructor1):
(WebCore::TestOverloadedConstructorsV8Internal::constructor2):
(WebCore::TestOverloadedConstructorsV8Internal::constructor3):
(WebCore::TestOverloadedConstructorsV8Internal::constructor):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(V8TestOverloadedConstructors):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
* bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::TestTypedefsV8Internal::funcMethod):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):
* bindings/scripts/test/V8/V8TestTypedefs.h:
(V8TestTypedefs):
* bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::visitNodeWrappers):
* bindings/v8/SerializedScriptValue.cpp:
* bindings/v8/V8AdaptorFunction.cpp:
(WebCore::V8AdaptorFunction::getTemplate):
* bindings/v8/V8Binding.cpp:
(WebCore::toDOMStringList):
(WebCore::toXPathNSResolver):
* bindings/v8/V8Binding.h:
(WebCore):
(WebCore::toRefPtrNativeArray):
* bindings/v8/V8Collection.cpp:
(WebCore::toOptionsCollectionSetter):
* bindings/v8/V8GCController.cpp:
* bindings/v8/V8NPObject.cpp:
(WebCore::npObjectInvokeImpl):
* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::reportMemoryUsage):
(WebCore::V8PerIsolateData::hasPrivateTemplate):
(WebCore::V8PerIsolateData::privateTemplate):
(WebCore::V8PerIsolateData::rawTemplate):
(WebCore::V8PerIsolateData::hasInstance):
* bindings/v8/V8PerIsolateData.h:
(WebCore::V8PerIsolateData::rawTemplateMap):
(V8PerIsolateData):
(WebCore::V8PerIsolateData::templateMap):
* bindings/v8/V8Utilities.cpp:
(WebCore::extractTransferables):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):
* bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:
(WebCore::V8AudioBufferSourceNode::bufferAttrSetterCustom):
* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCustom):
* bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
(WebCore::toCanvasStyle):
* bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::setDragImageMethodCustom):
* bindings/v8/custom/V8CryptoCustom.cpp:
(WebCore::V8Crypto::getRandomValuesMethodCustom):
* bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::constructorCustom):
(WebCore::V8DOMFormData::appendMethodCustom):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::constructorCustom):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateMethodCustom):
* bindings/v8/custom/V8HTMLMediaElementCustom.cpp:
(WebCore::V8HTMLMediaElement::controllerAttrSetterCustom):
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::addMethodCustom):
* bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
(WebCore::removeElement):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::isHTMLAllCollectionMethodCustom):
(WebCore::V8InjectedScriptHost::typeMethodCustom):
(WebCore::V8InjectedScriptHost::getEventListenersMethodCustom):
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::V8Node::insertBeforeMethodCustom):
(WebCore::V8Node::replaceChildMethodCustom):
(WebCore::V8Node::removeChildMethodCustom):
(WebCore::V8Node::appendChildMethodCustom):
* bindings/v8/custom/V8NodeListCustom.cpp:
(WebCore::V8NodeList::opaqueRootForGC):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toWebGLUniformLocation):
(WebCore::V8WebGLRenderingContext::getAttachedShadersMethodCustom):
(WebCore::V8WebGLRenderingContext::getProgramParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getShaderParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getUniformMethodCustom):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::isDocumentType):
(WebCore::V8XMLHttpRequest::sendMethodCustom):

Source/WebKit/chromium:

* src/WebArrayBuffer.cpp:
(WebKit::WebArrayBuffer::createFromV8Value):
* src/WebArrayBufferView.cpp:
(WebKit::WebArrayBufferView::createFromV8Value):
* src/WebBindings.cpp:
(WebKit::getRangeImpl):
(WebKit::getNodeImpl):
(WebKit::getElementImpl):
(WebKit::getArrayBufferImpl):
(WebKit::getArrayBufferViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExplicitly send only one report via XSSAuditorDelegate.
mkwst@chromium.org [Thu, 14 Mar 2013 10:51:25 +0000 (10:51 +0000)]
Explicitly send only one report via XSSAuditorDelegate.
https://bugs.webkit.org/show_bug.cgi?id=111964

Reviewed by Adam Barth.

This patch pulls the XSSAuditor report generation out into a separate
function in XSSAuditorDelegate::generateViolationReport, and moves the
call to that function into the "have we already notified folks about
violations on this page?" block. This both clarifies the flow in
XSSAuditorDelegate::didBlockScript, and ensures that only one violation
report will be sent per page, which regressed in r145695.

Existing tests verify that reports are generated and sent correctly.

We have no tests for the latter condition: the XSSAuditor tests
currently verify that a report showed up, but they can't verify that
no report appeared without sitting around for a few more than a few
seconds on every run.

* html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSAuditorDelegate::generateViolationReport):
    Pull the report generation logic out to this new function.
(WebCore::XSSAuditorDelegate::didBlockScript):
    Move the report generation call into the block that ensures it only
    executes for the first violation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Port DRT to use TestRunner::dumpAsText()
zeno.albisser@digia.com [Thu, 14 Mar 2013 10:07:24 +0000 (10:07 +0000)]
[Qt] Port DRT to use TestRunner::dumpAsText()
https://bugs.webkit.org/show_bug.cgi?id=112260

Reviewed by Benjamin Poulain.

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
(WebCore::methodNameStringForFailedTest):
    Change parameter from type TestRunnerQt* to TestRunner*.
(WebCore::DumpRenderTree::dump):
    TestRunnerQt::shouldDumpPixels() always returned true in our case.
    Instead we should rely on TestRunner::generatePixelResults().
* DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunnerQt::reset):
* DumpRenderTree/qt/TestRunnerQt.h:
(TestRunnerQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
zarvai@inf.u-szeged.hu [Thu, 14 Mar 2013 09:49:05 +0000 (09:49 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-5.0-wk1/TestExpectations: Skip failing tests after r145784.
* platform/qt-5.0-wk2/fast/repaint/focus-ring-expected.txt: Removed.
* platform/qt/fast/repaint/focus-ring-expected.txt: Rebaselining after r145708.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEmpty list items after drag&drop in contentEditable divs
sergio@webkit.org [Thu, 14 Mar 2013 09:43:34 +0000 (09:43 +0000)]
Empty list items after drag&drop in contentEditable divs
https://bugs.webkit.org/show_bug.cgi?id=110610

Reviewed by Ryosuke Niwa.

Source/WebCore:

Perform a cleanup after moving operations. This will mainly prune
extra placeholders left by the editing algorithms. Also do not
leave empty <li> when moving them around inside a list element.

Tests: editing/pasteboard/cleanup-on-move.html
       editing/pasteboard/drag-list-item.html

* editing/MoveSelectionCommand.cpp:
(WebCore::MoveSelectionCommand::doApply): perform
cleanupAfterDeletion().
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::insertAsListItems): do not
insert an empty list item.
* editing/MoveSelectionCommand.cpp:
(WebCore::MoveSelectionCommand::doApply):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::insertAsListItems):

LayoutTests:

Some placeholders should not be left after performing a cleanup in
move operations, this includes the empty list items generated when
moving around list items inside a list.

I'm also moving drag-list-item.html to editing/pasteboard because
it fits much better there than under editing/selection.

* editing/pasteboard/cleanup-on-move-expected.txt: Added.
* editing/pasteboard/cleanup-on-move.html: Added.
* editing/pasteboard/drag-list-item-expected.txt: Renamed from LayoutTests/editing/selection/drag-list-item-expected.txt.
* editing/pasteboard/drag-list-item.html: Renamed from LayoutTests/editing/selection/drag-list-item.html.
* editing/pasteboard/resources/select-and-drag.js: Added.
(selectAndDragToTarget): Selects nodes and drops them after a target node.
* editing/pasteboard/drag-drop-list-expected.txt: Removed an empty <li>.
* editing/pasteboard/paste-list-004-expected.txt: Removed 2 empty <li>.
* editing/pasteboard/paste-list-004.html: Ditto.
* editing/selection/4895428-1-expected.txt: Removed a <br>.
* editing/selection/4895428-4-expected.txt: Ditto.
* fast/events/ondragenter-expected.txt: Removed a blank line.
* platform/chromium/fast/events/ondragenter-expected.txt: Ditto.
* platform/efl/TestExpectations: Added cleanup-on-move.html to the skipped list.
* platform/mac-wk2/TestExpectations: Ditto.
* platform/qt/TestExpectations: Ditto.
* platform/win/fast/events/ondragenter-expected.txt: Removed a blank line.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThreaded HTML Parser should limit speculation to avoid using too much memory
eric@webkit.org [Thu, 14 Mar 2013 09:25:01 +0000 (09:25 +0000)]
Threaded HTML Parser should limit speculation to avoid using too much memory
https://bugs.webkit.org/show_bug.cgi?id=112069

Reviewed by Adam Barth.

Source/WebCore:

This is a speculative fix for memory issues seen in:
https://code.google.com/p/chromium/issues/detail?id=180819

This also fixed https://bugs.webkit.org/show_bug.cgi?id=110546
as a side-effect of simplifying the m_currentChunk handling.

We now tell the background html parser every time we start
a chunk on the main thread (instead of end), which greatly
simplified the checkpoint cleanup code from:
https://trac.webkit.org/changeset/145277

The cost for this is now we have more messages going to the
background thread (and postTask acquires a lock to write to the
message queue).  Chromium has more advanced (lock-less) primatives
for message posting, which we'll hopefully add to WebKit in
furture patches.

The outstanding chunks limit has not been tuned.  But it makes sense that
we should not keeping infinite speculative tokens around for
large documents with slow-to-load scripts.

* html/parser/BackgroundHTMLInputStream.cpp:
(WebCore::BackgroundHTMLInputStream::BackgroundHTMLInputStream):
(WebCore::BackgroundHTMLInputStream::invalidateCheckpointsBefore):
(WebCore):
(WebCore::BackgroundHTMLInputStream::rewindTo):
* html/parser/BackgroundHTMLInputStream.h:
(BackgroundHTMLInputStream):
(WebCore::BackgroundHTMLInputStream::outstandingCheckpointCount):
(Checkpoint):
(WebCore::BackgroundHTMLInputStream::Checkpoint::isNull):
(WebCore::BackgroundHTMLInputStream::Checkpoint::clear):
* html/parser/BackgroundHTMLParser.cpp:
(WebCore):
(WebCore::BackgroundHTMLParser::startedChunkWithCheckpoint):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
* html/parser/BackgroundHTMLParser.h:
(BackgroundHTMLParser):
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::validateSpeculations):
(WebCore::HTMLDocumentParser::discardSpeculationsAndResumeFrom):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
* html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):

LayoutTests:

Test that this fixes https://bugs.webkit.org/show_bug.cgi?id=110546 for the threaded parser.
Ports using the main-thread parser are expected to fail (ASSERT in Debug).

* fast/parser/document-write-partial-entity-before-load-expected.txt: Added.
* fast/parser/document-write-partial-entity-before-load.html: Added.
* fast/parser/external-script-document-write-expected.txt: Added.
* fast/parser/external-script-document-write.html: Added.
* fast/parser/resources/external-script-document-write.js: Added.
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Flame Chart. Minor changes for the popover.
loislo@chromium.org [Thu, 14 Mar 2013 09:00:32 +0000 (09:00 +0000)]
Web Inspector: Flame Chart. Minor changes for the popover.
https://bugs.webkit.org/show_bug.cgi?id=112331

Reviewed by Yury Semikhatsky.

popover timeout needs to be decreased a bit.
hidePopover call in onMouseMove doesn't necessary.
We have to keep anchor element unmodified if the hovered item didn't changed.

* inspector/front-end/FlameChart.js:
(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._onMouseMove):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix detection of Intel Mac OS X platform on Intel Mac 64-bit
commit-queue@webkit.org [Thu, 14 Mar 2013 08:57:27 +0000 (08:57 +0000)]
Fix detection of Intel Mac OS X platform on Intel Mac 64-bit
https://bugs.webkit.org/show_bug.cgi?id=112312

Patch by Jonathan Liu <net147@gmail.com> on 2013-03-14
Reviewed by Simon Hausmann.

Source/WebCore:

* platform/gtk/UserAgentGtk.cpp:
(WebCore::platformVersionForUAString):

Source/WebKit/efl:

* ewk/ewk_settings.cpp:
(_ewk_settings_webkit_os_version_get):

Source/WebKit/wx:

* WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore::agentOS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayout Test plugins/plugin-clip-subframe.html is failing
commit-queue@webkit.org [Thu, 14 Mar 2013 08:38:55 +0000 (08:38 +0000)]
Layout Test plugins/plugin-clip-subframe.html is failing
https://bugs.webkit.org/show_bug.cgi?id=111514

Patch by John Bauman <jbauman@chromium.org> on 2013-03-14
Reviewed by Ryosuke Niwa.

Rebaseline test result due to chromium r185729. Also try to force
layout in test to prevent flakiness on win-dbg.

* platform/chromium-mac/plugins/plugin-clip-subframe-expected.txt:
* platform/chromium/TestExpectations:
* plugins/plugin-clip-subframe.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening. Adding a couple of failure expectations for flaky
zandobersek@gmail.com [Thu, 14 Mar 2013 08:37:33 +0000 (08:37 +0000)]
Unreviewed GTK gardening. Adding a couple of failure expectations for flaky
tests on the debug builder.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] InRegionScrollableArea: fix call to visibleContentRect()
commit-queue@webkit.org [Thu, 14 Mar 2013 08:16:51 +0000 (08:16 +0000)]
[BlackBerry] InRegionScrollableArea: fix call to visibleContentRect()
https://bugs.webkit.org/show_bug.cgi?id=112244

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-14
Reviewed by Rob Buis.

Since r143295 visibleContentRect() receives an enum, not a boolean.

* WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Flame Chart. Rewrite drawing procedure for better performance.
loislo@chromium.org [Thu, 14 Mar 2013 07:38:14 +0000 (07:38 +0000)]
Web Inspector: Flame Chart. Rewrite drawing procedure for better performance.
https://bugs.webkit.org/show_bug.cgi?id=112264

Reviewed by Yury Semikhatsky.

I traverses the profile tree in calculateTimelineData and calculates all the sizes and colors.
Later in draw code we lineary pass the array and draw items.
Also we could easily swap to another format of the profile.

* inspector/front-end/FlameChart.js:
(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._nodeCount):
(WebInspector.FlameChart.prototype._calculateTimelineData.appendReversedArray):
(WebInspector.FlameChart.prototype._calculateTimelineData):
(WebInspector.FlameChart.prototype._getPopoverAnchor):
(WebInspector.FlameChart.prototype._showPopover):
(WebInspector.FlameChart.prototype._hidePopover):
(WebInspector.FlameChart.prototype._onClick):
(WebInspector.FlameChart.prototype._onMouseMove):
(WebInspector.FlameChart.prototype._coordinatesToNodeIndex):
(WebInspector.FlameChart.prototype.onResize):
(WebInspector.FlameChart.prototype.draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd to HistoryItem a way to know if its underlying CachedPage has expired.
alice.liu@apple.com [Thu, 14 Mar 2013 07:30:59 +0000 (07:30 +0000)]
Add to HistoryItem a way to know if its underlying CachedPage has expired.
https://bugs.webkit.org/show_bug.cgi?id=110652

Reviewed by Brady Eidson.

Source/WebCore:

* WebCore.exp.in: Added WebCore::HistoryItem::isInPageCache and hasCachedPageExpired.
* history/CachedPage.cpp: Add a data member, m_expirationTime, and a function, hasExpired().
* history/CachedPage.h:
* history/HistoryItem.cpp:
(WebCore::HistoryItem::hasCachedPageExpired): Added. returns m_cachedPage's expiration state.
* history/HistoryItem.h:
* history/PageCache.cpp:
(WebCore::PageCache::get):  Address the fixme about not using WebKitBackForwardCacheExpirationIntervalKey.
* page/Settings.in: Add backForwardCacheExpirationInterval to the automatically generated setters for Settings.

Source/WebKit/mac:

* History/WebHistoryItem.mm:
(-[WebHistoryItem _isInPageCache]): Added. Just calls and returns core imple's function.
(-[WebHistoryItem _hasCachedPageExpired]): Same thing.
* History/WebHistoryItemPrivate.h:
* WebView/WebPreferences.mm:
(-[WebPreferences _backForwardCacheExpirationInterval]): Address fixme, now that WebCore::Settings
has getters and setters with default value.
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]): call setBackForwardCacheExpirationInterval similar to other settings.

Source/WebKit2:

Hook up hasCachedPageExpired in InjectedBundle's BackForwardListItem.
* WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.cpp:
(WKBundleBackForwardListItemHasCachedPageExpired):
* WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.h:
* WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:
(WebKit::InjectedBundleBackForwardListItem::hasCachedPageExpired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCannot select a canvas element at the beginning or the end of a document
rniwa@webkit.org [Thu, 14 Mar 2013 06:52:33 +0000 (06:52 +0000)]
Cannot select a canvas element at the beginning or the end of a document
https://bugs.webkit.org/show_bug.cgi?id=112319

Reviewed by Eric Seidel.

Source/WebCore:

The bug was caused by the editing code treating canvas element as if an empty inline element.
Treat it as an "atomic" element for the purpose of determining whether selection can have
an end point in it or not.

Test: editing/pasteboard/copy-paste-content-starting-and-ending-canvas.html

* html/HTMLCanvasElement.h:
(WebCore::HTMLCanvasElement::canContainRangeEndPoint): Added.

LayoutTests:

Add a regression test to copy and paste a content with canvas elements.

* editing/pasteboard/copy-paste-content-starting-and-ending-canvas-expected.txt: Added.
* editing/pasteboard/copy-paste-content-starting-and-ending-canvas.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement FontLoader interface
commit-queue@webkit.org [Thu, 14 Mar 2013 05:59:58 +0000 (05:59 +0000)]
Implement FontLoader interface
https://bugs.webkit.org/show_bug.cgi?id=98395

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-03-13
Reviewed by Eric Seidel.

Source/WebCore:

This patch implements the FontLoader interface defined in CSS Font
Load Events Module Level 3.[1] It adds fontloader attribute to
Document, and adds two interfaces, FontLoader and
CSSFontFaceLoadEvent to WebCore.

[1]: http://dev.w3.org/csswg/css-font-load-events-3/

This feature is guarded by FONT_LOAD_EVENTS compiler flag and
RuntimeEnabledFeatures::fontLoadEventsEnabled() runtime flag.

Tests: fast/css/fontloader-download-error.html
       fast/css/fontloader-events.html
       fast/css/fontloader-loadingdone.html
       fast/css/fontloader-multiple-faces-download-error.html
       fast/css/fontloader-multiple-faces.html
       fast/css/fontloader-multiple-families.html
       http/tests/webfont/fontloader-loading-attribute.html

* CMakeLists.txt: Adding FontLoader/CSSFontFaceLoadEvent files.
* DerivedSources.cpp: Ditto.
* DerivedSources.make: Ditto.
* DerivedSources.pri: Ditto.
* GNUmakefile.list.am: Ditto.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.vcxproj/WebCore.vcxproj: Ditto.
* WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue): Add convertValue() for CSSFontFaceRule, DOMError, and VoidCallback.
* bindings/js/JSDictionary.h: Ditto.
* bindings/v8/Dictionary.cpp: Add get() for CSSFontFaceRule, DOMError, and VoidCallback.
(WebCore::Dictionary::get):
* bindings/v8/Dictionary.h: Ditto.
(Dictionary):
* css/CSSFontFace.cpp: Notifies FontLoader as load progresses.
(WebCore::CSSFontFace::fontLoaded):
(WebCore::CSSFontFace::getFontData):
(WebCore::CSSFontFace::notifyFontLoader):
(WebCore::CSSFontFace::notifyLoadingDone):
* css/CSSFontFace.h: Add two member variables. m_rule stores CSSFontFaceRule for the fontface. m_loadState holds current state of the fontface in terms of FontLoader.
(WebCore::CSSFontFace::create): Takes additional parameter of type CSSFontFaceRule.
(WebCore::CSSFontFace::loadState):
(WebCore::CSSFontFace::CSSFontFace):
* css/CSSFontFaceLoadEvent.cpp: Added.
(WebCore::CSSFontFaceLoadEvent::CSSFontFaceLoadEvent):
(WebCore::CSSFontFaceLoadEvent::~CSSFontFaceLoadEvent):
(WebCore::CSSFontFaceLoadEvent::interfaceName):
* css/CSSFontFaceLoadEvent.h: Added.
(CSSFontFaceLoadEventInit):
(CSSFontFaceLoadEvent):
(WebCore::CSSFontFaceLoadEvent::create):
(WebCore::CSSFontFaceLoadEvent::createForFontFaceRule):
(WebCore::CSSFontFaceLoadEvent::createForError):
(WebCore::CSSFontFaceLoadEvent::fontface):
(WebCore::CSSFontFaceLoadEvent::error):
* css/CSSFontFaceLoadEvent.idl: Added.
* css/CSSFontFaceRule.idl: Add JSGenerateToJSObject and JSGenerateToNativeObject as JSC binding needs them.
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::isDecodeError): Added.
(WebCore::CSSFontFaceSource::ensureFontData): Added.
* css/CSSFontFaceSource.h:
(CSSFontFaceSource):
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule): Pass a CSSFontFaceRule to CSSFontFace::create().
(WebCore::CSSFontSelector::getFontData): Moved logic for creating a CSSSegmentedFontFace to a helper function getFontFace().
(WebCore::CSSFontSelector::getFontFace): Added.
* css/CSSFontSelector.h:
* css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::fontLoaded): Fires callbacks when load is completed.
(WebCore::CSSSegmentedFontFace::isLoading): Returns true if any fonts are still loading.
(WebCore::CSSSegmentedFontFace::checkFont): Returns true if all fonts are loaded.
(WebCore::CSSSegmentedFontFace::loadFont): Starts load by calling getFontData().
* css/CSSSegmentedFontFace.h:
(CSSSegmentedFontFace): Declares new functions and a vector to store callbacks.
(LoadFontCallback):
(WebCore::CSSSegmentedFontFace::LoadFontCallback::~LoadFontCallback):
* css/FontLoader.cpp: Added.
(LoadFontCallback): Holds callback functions of FontLoader.loadFont().
(WebCore::LoadFontCallback::create):
(WebCore::LoadFontCallback::createFromParams):
(WebCore::LoadFontCallback::LoadFontCallback):
(WebCore::LoadFontCallback::notifyLoaded):
(WebCore::LoadFontCallback::notifyError):
(WebCore::FontLoader::FontLoader):
(WebCore::FontLoader::~FontLoader):
(WebCore::FontLoader::eventTargetData):
(WebCore::FontLoader::ensureEventTargetData):
(WebCore::FontLoader::interfaceName):
(WebCore::FontLoader::scriptExecutionContext):
(WebCore::FontLoader::didLayout): Fires pending events and callbacks. This is called when layout have completed.
(WebCore::FontLoader::scheduleEvent): Defers event dispatching until layout completes.
(WebCore::FontLoader::firePendingEvents): Dispatches pending events.
(WebCore::FontLoader::beginFontLoading): Schedules loading/loadstart events. This is called from CSSFontFace.
(WebCore::FontLoader::fontLoaded): Schedules load/loadingdone events. This is called from CSSFontFace.
(WebCore::FontLoader::loadError): Schedules error/loadingdone events. This is called from CSSFontFace.
(WebCore::FontLoader::notifyWhenFontsReady): Implements fontloader.notifyWhenFontsReady().
(WebCore::FontLoader::loadingDone): Fires callbacks of notifyWhenFontsReady.
(WebCore::FontLoader::loadFont): Implements fontloader.loadFont().
(WebCore::FontLoader::checkFont): Implements fontloader.checkFont().
(WebCore::FontLoader::resolveFontStyle): Parses the given font parameter using the syntax of CSS 'font' property and creates Font object. The logic is taken from CanvasRenderingContext2D::setFont().
* css/FontLoader.h: Added.
(FontLoader):
(WebCore::FontLoader::create):
(WebCore::FontLoader::loading):
(WebCore::FontLoader::document):
(WebCore::FontLoader::refEventTarget):
(WebCore::FontLoader::derefEventTarget):
* css/FontLoader.idl: Added.
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::fontloader): Added.
* dom/Document.h:
(Document): Add m_fontloader and fontloader().
* dom/Document.idl: Add fontloader attribute.
* dom/EventNames.h: Add loading and loadingdone events.
* dom/EventNames.in: Add CSSFontFaceLoadEvent.
* dom/EventTargetFactory.in: Add FontLoader.
* page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks): Calls FontLoader::didLayout().

Tools:

Enable FontLoadEvents runtime flag for TestShell.

* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):

LayoutTests:

Add tests for document.fontloader. Since the feature is currently enabled
only for chromium, the tests are expected to fail on the other ports.

* fast/css/fontloader-download-error-expected.txt: Added.
* fast/css/fontloader-download-error.html: Added.
* fast/css/fontloader-events-expected.txt: Added.
* fast/css/fontloader-events.html: Added.
* fast/css/fontloader-loadingdone-expected.txt: Added.
* fast/css/fontloader-loadingdone.html: Added.
* fast/css/fontloader-multiple-faces-download-error-expected.txt: Added.
* fast/css/fontloader-multiple-faces-download-error.html: Added.
* fast/css/fontloader-multiple-faces-expected.txt: Added.
* fast/css/fontloader-multiple-faces.html: Added.
* fast/css/fontloader-multiple-families-expected.txt: Added.
* fast/css/fontloader-multiple-families.html: Added.
* http/tests/webfont/fontloader-loading-attribute-expected.txt: Added.
* http/tests/webfont/fontloader-loading-attribute.html: Added.
* platform/chromium/fast/css/fontloader-download-error-expected.txt: Added.
* platform/chromium/fast/css/fontloader-events-expected.txt: Added.
* platform/chromium/fast/css/fontloader-loadingdone-expected.txt: Added.
* platform/chromium/fast/css/fontloader-multiple-faces-download-error-expected.txt: Added.
* platform/chromium/fast/css/fontloader-multiple-faces-expected.txt: Added.
* platform/chromium/fast/css/fontloader-multiple-families-expected.txt: Added.
* platform/chromium/http/tests/webfont/fontloader-loading-attribute-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCompute image background size when testing for background visibility
antti@apple.com [Thu, 14 Mar 2013 05:11:06 +0000 (05:11 +0000)]
Compute image background size when testing for background visibility
https://bugs.webkit.org/show_bug.cgi?id=112313

Reviewed by Simon Fraser.

Source/WebCore:

We can catch more cases where background is fully obscured.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBackground):

    Use early returns.

(WebCore::RenderBox::backgroundPaintedExtent):

    Compute the bounds for image backgrounds.

(WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect):
(WebCore::RenderBox::backgroundIsKnownToBeObscured):

    Rename to make clear that the answers are certain to one direction only.

* rendering/RenderBox.h:
* rendering/RenderImage.cpp:
(WebCore::RenderImage::boxShadowShouldBeAppliedToBackground):
(WebCore::RenderImage::backgroundIsKnownToBeObscured):
* rendering/RenderImage.h:

LayoutTests:

* fast/repaint/obscured-background-no-repaint.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[css3-text] Add support for text-decoration-color
bruno.abinader@basyskom.com [Thu, 14 Mar 2013 04:06:20 +0000 (04:06 +0000)]
[css3-text] Add support for text-decoration-color
https://bugs.webkit.org/show_bug.cgi?id=91638

Reviewed by Julien Chaffraix.

Source/WebCore:

This patch implements the CSS3's 'text-decoration-color' property, with
'-webkit' vendor prefix.

More info about "text-decoration-color" property can be found here:
http://dev.w3.org/csswg/css-text-decor-3/#text-decoration-color-property

Mozilla implementation (using -moz prefix) is described here:
https://developer.mozilla.org/en/CSS/text-decoration-color

Tests: fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color.html
       fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-color.html
       fast/css3-text/css3-text-decoration/text-decoration-color.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::isColorPropertyID):
(WebCore::CSSParser::parseValue):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
Added parsing checks for '-webkit-text-decoration-color' property.

* css/CSSPropertyNames.in:
Added '-webkit-text-decoration-color' property name.

* css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
Set property handler for '-webkit-text-decoration-color'.

* css/StyleResolver.cpp:
(WebCore::isValidVisitedLinkProperty):
(WebCore::StyleResolver::applyProperty):
Added switch case checks for text-decoration-color property on visited
link checks and property appliance.

* rendering/RenderObject.cpp:
(WebCore::decorationColor):
The newly added property needs to checked here when selecting the text
decoration color.

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
(WebCore::RenderStyle::colorIncludingFallback):
(WebCore::RenderStyle::visitedDependentColor):
There is no proper way to check if a property has been set or not, so if
text decoration color fallbacks to default color, it would override the
check for 'text-fill-color' and 'text-stroke-color' properties on
WebCore::decorationColor() static function, changing current behavior,
which can be verified by new failing layout tests (ie.
fast/text/stroking-decorations.html).

* rendering/style/RenderStyle.h:
Added {non-}visited text decoration color getters and setters.

* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
Added {non-}visited text decoration color variables initialization to
copy constructor and operator assignment functions.

* rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
Added here as this property is not used regularly.

LayoutTests:

Added layout tests (paint,repaint and getComputedStyle) for
'text-decoration-color' property, with '-webkit' vendor prefix.

* fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color-expected.txt: Added.
* fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color.html: Added.
* fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-color.js: Added.
Added getComputedStyle-based layout test covering a bunch of valid/invalid values.

* fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-color-expected.png: Added.
* fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-color-expected.txt: Added.
* fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-color.html: Added.
Added cross-platform repaint layout test using 'Ahem' font.

* fast/css3-text/css3-text-decoration/text-decoration-color-expected.html: Added.
* fast/css3-text/css3-text-decoration/text-decoration-color.html: Added.
Added cross-platform reference test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocreate runtime flags for CSS Compositing
commit-queue@webkit.org [Thu, 14 Mar 2013 03:52:55 +0000 (03:52 +0000)]
create runtime flags for CSS Compositing
https://bugs.webkit.org/show_bug.cgi?id=111818

Patch by Rik Cabanier <cabanier@adobe.com> on 2013-03-13
Reviewed by Ryosuke Niwa.

Source/WebCore:

No new tests, no change in functionality.

Added a runtime flags that enables CSS compositing

* WebCore.exp.in:
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setCSSCompositingEnabled):
(WebCore::RuntimeEnabledFeatures::cssCompositingEnabled):
* css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::cssCompositingEnabled):
(WebCore):
* css/CSSParser.h:
* css/CSSParserMode.h:
(CSSParserContext):
* dom/Document.cpp:
(WebCore::Document::cssCompositingEnabled):
(WebCore):
* dom/Document.h:
(Document):

Source/WebKit/chromium:

Added a runtime flags to enable CSS compositing for chromium.

* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableCSSCompositing):
(WebKit):
(WebKit::WebRuntimeFeatures::isCSSCompositingEnabled):

Source/WebKit/mac:

Added a preference to enable CSS compositing.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences cssCompositingEnabled]):
(-[WebPreferences setCSSCompositingEnabled:]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Source/WebKit2:

Added a preference to enable CSS compositing.

* Shared/WebPreferencesStore.h:
(WebKit):
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
(WebKit::InjectedBundle::setCSSCompositingEnabled):
(WebKit):
* WebProcess/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCLeanup: remove unnecessary call to parseParameters.
jparent@chromium.org [Thu, 14 Mar 2013 03:33:47 +0000 (03:33 +0000)]
CLeanup: remove unnecessary call to parseParameters.
https://bugs.webkit.org/show_bug.cgi?id=112309

Reviewed by Ojan Vafai.

We call parseCrossDashboardParameters when the dashboard initially
loads to set the state required for loadBuildersList, and then we
call it again once we are fully done with loading, so there is no
reason to call it in the middle of the loading process here.

* TestResultServer/static-dashboards/loader.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoQuota API: Update IDL to make it match the latest WD
kinuko@chromium.org [Thu, 14 Mar 2013 02:48:19 +0000 (02:48 +0000)]
Quota API: Update IDL to make it match the latest WD
https://bugs.webkit.org/show_bug.cgi?id=88396

Reviewed by Adam Barth.

Source/WebCore:

Add a new interface object (navigator.StorageQuota) and deprecate the old one (window.StorageInfo)
to make the code match with the latest Quota API WD:
http://www.w3.org/TR/quota-api/

Tests: storage/storagequota-query-usage.html
       storage/storagequota-request-quota.html

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Modules/quota/DOMWindowQuota.cpp:
(WebCore::DOMWindowQuota::webkitStorageInfo): Added a deprecate warning message for the old interface.
* Modules/quota/NavigatorStorageQuota.cpp: Added for the new interface.
* Modules/quota/NavigatorStorageQuota.h: Added for the new interface.
* Modules/quota/NavigatorStorageQuota.idl: Added for the new interface.
* Modules/quota/StorageErrorCallback.cpp:
(WebCore::StorageErrorCallback::CallbackTask::CallbackTask):
(WebCore::StorageErrorCallback::CallbackTask::performTask):
* Modules/quota/StorageErrorCallback.h: Renamed from Source/WebCore/Modules/quota/StorageInfoErrorCallback.h.
(WebCore):
(StorageErrorCallback):
(WebCore::StorageErrorCallback::~StorageErrorCallback):
(WebCore::StorageErrorCallback::CallbackTask::create):
* Modules/quota/StorageErrorCallback.idl: Renamed from Source/WebCore/Modules/quota/StorageInfoErrorCallback.idl.
* Modules/quota/StorageInfo.cpp: Added code to relay requests to the new StorageQuota implementation.
* Modules/quota/StorageInfo.h:
* Modules/quota/StorageInfo.idl:
* Modules/quota/StorageQuota.cpp: Added for the new interface.
* Modules/quota/StorageQuota.h:
(WebCore::StorageQuota::create):
* Modules/quota/StorageQuota.idl: Copied from Source/WebCore/Modules/quota/StorageInfo.idl.
* Modules/quota/StorageQuotaCallback.h: Renamed from Source/WebCore/Modules/quota/StorageInfoQuotaCallback.h.
* Modules/quota/StorageQuotaCallback.idl: Renamed from Source/WebCore/Modules/quota/StorageInfoQuotaCallback.idl.
* Modules/quota/StorageUsageCallback.h: Renamed from Source/WebCore/Modules/quota/StorageInfoUsageCallback.h.
* Modules/quota/StorageUsageCallback.idl: Renamed from Source/WebCore/Modules/quota/StorageInfoUsageCallback.idl.
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* page/FeatureObserver.h:

Source/WebKit/chromium:

Add a new interface object (navigator.StorageQuota) and deprecate the old one (window.StorageInfo)
to make the code match with the latest Quota API WD:
http://www.w3.org/TR/quota-api/

* WebKit.gyp:
* src/AssertMatchingEnums.cpp:
* src/StorageQuotaChromium.cpp: Renamed from Source/WebKit/chromium/src/StorageInfoChromium.cpp.
(WebCore):
(WebCore::StorageQuota::queryUsageAndQuota):
(WebCore::StorageQuota::requestQuota):
* src/WebStorageQuotaCallbacksImpl.cpp:
(WebKit::WebStorageQuotaCallbacksImpl::WebStorageQuotaCallbacksImpl):
* src/WebStorageQuotaCallbacksImpl.h:
(WebCore):
(WebStorageQuotaCallbacksImpl):

LayoutTests:

* platform/chromium/TestExpectations:
* storage/storagequota-query-usage-expected.txt: Added.
* storage/storagequota-query-usage.html: Added.
* storage/storagequota-request-quota-expected.txt: Added.
* storage/storagequota-request-quota.html: Added.

Rebaselines:
* platform/chromium/fast/dom/everything-to-string-expected.txt: Added.
* platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
* platform/chromium/fast/js/global-constructors-expected.txt:
* platform/chromium/http/tests/security/isolatedWorld/all-window-properties-expected.txt: Added.
* platform/chromium/http/tests/security/isolatedWorld/all-window-prototypes-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Sort the Xcode project file.
rniwa@webkit.org [Thu, 14 Mar 2013 02:36:15 +0000 (02:36 +0000)]
Unreviewed. Sort the Xcode project file.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WebGL] array-bounds-clamping should use less dramatic numbers
dino@apple.com [Thu, 14 Mar 2013 02:15:00 +0000 (02:15 +0000)]
[WebGL] array-bounds-clamping should use less dramatic numbers
https://bugs.webkit.org/show_bug.cgi?id=112298
<rdar://problem/13415829>

Reviewed by Ken Russell.

Replace Number.MAX_VALUE with a non-infinite number.

* fast/canvas/webgl/array-bounds-clamping.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake lint-test-expectations happy with the Apple-Windows TestExpectations files
timothy_horton@apple.com [Thu, 14 Mar 2013 01:47:53 +0000 (01:47 +0000)]
Make lint-test-expectations happy with the Apple-Windows TestExpectations files

Unreviewed.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix.
michaeln@google.com [Thu, 14 Mar 2013 00:44:31 +0000 (00:44 +0000)]
Unreviewed build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable V8 binding integriy on Android.
commit-queue@webkit.org [Thu, 14 Mar 2013 00:27:34 +0000 (00:27 +0000)]
Enable V8 binding integriy on Android.
https://bugs.webkit.org/show_bug.cgi?id=112297

Patch by Chris Palmer <palmer@google.com> on 2013-03-13
Reviewed by Adam Barth.

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewd build fix.
michaeln@google.com [Thu, 14 Mar 2013 00:23:27 +0000 (00:23 +0000)]
Unreviewd build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[HTMLTemplateElement] EOF should unwind the stack of template insertion modes iteratively
rafaelw@chromium.org [Thu, 14 Mar 2013 00:03:29 +0000 (00:03 +0000)]
[HTMLTemplateElement] EOF should unwind the stack of template insertion modes iteratively
https://bugs.webkit.org/show_bug.cgi?id=111907

Reviewed by Adam Barth.

No behavioral changes. This patch only aligns our parser implementation with the present spec.

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processTemplateEndTag):
(WebCore::HTMLTreeBuilder::processEndOfFileForInTemplateContents):
(WebCore::HTMLTreeBuilder::processEndOfFile):
* html/parser/HTMLTreeBuilder.h:
(HTMLTreeBuilder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: FileSystem mods: Changes to snapshot file creation to reduce dependen...
michaeln@google.com [Thu, 14 Mar 2013 00:01:24 +0000 (00:01 +0000)]
Source/WebCore: FileSystem mods: Changes to snapshot file creation to reduce dependencies on blob URLs.
Adding a new minimal BlobDataHandle class which will be reimplemented/built upon in later CLs. In this
patch, it's just enough to refactor the FileSystem code to not function in terms of blobURLs.
https://bugs.webkit.org/show_bug.cgi?id=108851

Reviewed by Adam Barth.

No new tests. This is strictly a refactoring of the existing code.

* Modules/filesystem/DOMFileSystem.cpp:
(WebCore):
(WebCore::DOMFileSystem::createFile):
* Modules/filesystem/DOMFileSystemSync.cpp:
(WebCore):
* platform/AsyncFileSystemCallbacks.h:
(AsyncFileSystemCallbacks):
(WebCore::AsyncFileSystemCallbacks::didCreateSnapshotFile):
* platform/gtk/AsyncFileSystemGtk.cpp:
(WebCore::AsyncFileSystemGtk::createSnapshotFileAndReadMetadata):
(WebCore):
* platform/network/BlobData.cpp:
(WebCore):
(WebCore::BlobDataHandle::BlobDataHandle):
(WebCore::BlobDataHandle::~BlobDataHandle):
* platform/network/BlobData.h:
(WebCore):
(BlobDataHandle):
(WebCore::BlobDataHandle::create):

Source/WebKit/chromium: [Chromium] FileSystem mods: Changes to snapshot file creation to reduce dependencies on blobs.
No longer send a |blobURL| to the browser process, no longer expect the browser process
to have registered a blob with that url.
https://bugs.webkit.org/show_bug.cgi?id=108851

Reviewed by Adam Barth.

* src/AsyncFileSystemChromium.cpp:
(WebCore):
(WebCore::FileWriterHelperCallbacks::didCreateSnapshotFile):
(WebCore::AsyncFileSystemChromium::createSnapshotFileAndReadMetadata):
* src/AsyncFileSystemChromium.h:
(AsyncFileSystemChromium):
* src/LocalFileSystemChromium.cpp:
(WebCore):
* src/WebFileSystemCallbacksImpl.cpp:
(WebKit::WebFileSystemCallbacksImpl::didCreateSnapshotFile):
(WebKit):
* src/WebFileSystemCallbacksImpl.h:
(WebCore):
(WebFileSystemCallbacksImpl):
* src/WorkerAsyncFileSystemChromium.cpp:
(WebCore::WorkerAsyncFileSystemChromium::createSnapshotFileAndReadMetadata):
(WebCore::WorkerAsyncFileSystemChromium::createWorkerFileSystemCallbacksBridge):
* src/WorkerFileSystemCallbacksBridge.cpp:
(WebKit::MainThreadFileSystemCallbacks::didCreateSnapshotFile):
(MainThreadFileSystemCallbacks):
(WebKit::WorkerFileSystemCallbacksBridge::postCreateSnapshotFileToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::createSnapshotFileOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::didCreateSnapshotFileOnMainThread):
(WebKit):
(WebKit::WorkerFileSystemCallbacksBridge::WorkerFileSystemCallbacksBridge):
(WebKit::WorkerFileSystemCallbacksBridge::didCreateSnapshotFileOnWorkerThread):
* src/WorkerFileSystemCallbacksBridge.h:
(WebCore):
(WebKit):
(WebKit::WorkerFileSystemCallbacksBridge::create):
(WorkerFileSystemCallbacksBridge):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Restrict WebNode::addEventListener and friends to a whitelist of event...
abarth@webkit.org [Wed, 13 Mar 2013 23:16:28 +0000 (23:16 +0000)]
[Chromium] Restrict WebNode::addEventListener and friends to a whitelist of event types
https://bugs.webkit.org/show_bug.cgi?id=112195

Reviewed by Eric Seidel.

Chromium only uses these APIs in extremely narrow ways. In order to
discourage Chromium from using these APIs in broader ways, this patch
restricts the APIs to a small whitelist of event types.

We might want to add some sort of flag to let CEF use expose these APIs
more broadly.

* WebKit.gypi:
* public/WebNode.h:
* src/WebNode.cpp:
(WebKit::WebNode::hasEventListeners):
(WebKit::WebNode::addEventListener):
* tests/EventListenerTest.cpp: Removed.
    - These tests of DOM mutation events are no longer needed because we
      don't support listening for DOM mutation events via the API
      anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Now I'm a reviewer :)
esprehn@chromium.org [Wed, 13 Mar 2013 23:00:39 +0000 (23:00 +0000)]
Unreviewed. Now I'm a reviewer :)

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThreaded HTML Parser is missing feature define flags in all but Chromium port's build...
rniwa@webkit.org [Wed, 13 Mar 2013 22:57:56 +0000 (22:57 +0000)]
Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
https://bugs.webkit.org/show_bug.cgi?id=112277

Reviewed by Adam Barth.

.:

* Source/autotools/SetupWebKitFeatures.m4:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/webkitperl/FeatureList.pm:
* qmake/mkspecs/features/features.pri:

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a test case for flexbox with negative overflow having an out of flow flex item
tony@chromium.org [Wed, 13 Mar 2013 22:56:58 +0000 (22:56 +0000)]
Add a test case for flexbox with negative overflow having an out of flow flex item
https://bugs.webkit.org/show_bug.cgi?id=112294

Reviewed by Ojan Vafai.

* css3/flexbox/negative-overflow-expected.txt:
* css3/flexbox/negative-overflow.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove svn:executable from a file that isn't supposed to be executable.
jberlin@webkit.org [Wed, 13 Mar 2013 22:55:16 +0000 (22:55 +0000)]
Remove svn:executable from a file that isn't supposed to be executable.

Rubber-stamped by Geoff Garen.

* wtf/MediaTime.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Get rid of more function-level static FunctionTemplates and ObjectTemplates...
commit-queue@webkit.org [Wed, 13 Mar 2013 22:50:09 +0000 (22:50 +0000)]
[V8] Get rid of more function-level static FunctionTemplates and ObjectTemplates in bindings
https://bugs.webkit.org/show_bug.cgi?id=112262

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-13
Reviewed by Jochen Eisinger.

In the future we'll create and store function templates for main world
and non-main worlds separately (see bug 111724), having function
templates and object templates as static variables inside functions will
break the functionality.

No new tests (no changes in functionality yet; existing bindings
tests still pass).

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::createContext):
* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::hasPrivateTemplate):
(WebCore):
* bindings/v8/V8PerIsolateData.h:
(V8PerIsolateData):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::wrapInShadowObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agorun-perf-tests should support content_shell
abarth@webkit.org [Wed, 13 Mar 2013 22:34:12 +0000 (22:34 +0000)]
run-perf-tests should support content_shell
https://bugs.webkit.org/show_bug.cgi?id=112291

Reviewed by Eric Seidel.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Do not do scroll position adjustment if selecting in a subframe
commit-queue@webkit.org [Wed, 13 Mar 2013 22:30:50 +0000 (22:30 +0000)]
[BlackBerry] Do not do scroll position adjustment if selecting in a subframe
https://bugs.webkit.org/show_bug.cgi?id=112290

Patch by Iris Wu <shuwu@blackberry.com> on 2013-03-13
Reviewed by Rob Buis.

PR 267394

In SelectionHandler::ensureSelectedTextVisible(), scroll position
animation is based on main frame. If selecting in a subframe, don't
do animation.

Internally Reviewed By Genevieve Mak.

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Grid Layout] Refactor GridCoordinate to hold GridSpans
jchaffraix@webkit.org [Wed, 13 Mar 2013 22:28:10 +0000 (22:28 +0000)]
[CSS Grid Layout] Refactor GridCoordinate to hold GridSpans
https://bugs.webkit.org/show_bug.cgi?id=112211

Reviewed by Tony Chang.

In order to bring more spanning knowledge to RenderGrid without having
duplicated GridSpan resolution, it became needed to store them into
GridCoordinate. Note that this change is needed as we can only resolve
all the positions with enough context in one place: when we place the
item in the grid.

Refactoring, no change in behavior expected.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::GridIterator::nextEmptyGridArea):
Updated to create 2 GridSpans. Also fixed a style violation (PassOwnPtr
as local member, not sure why it wasn't caught earlier).

(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
(WebCore::RenderGrid::gridAreaBreadthForChild):
(WebCore::RenderGrid::findChildLogicalPosition):
Updated the original function after GridCoordinate internal representation change.

(WebCore::RenderGrid::insertItemIntoGrid):
Ditto. Also added a new overloaded function that does resolution after auto-placement.

(WebCore::RenderGrid::resolveGridPositionsFromAutoPlacementPosition):
Removed the extra GridSpan computation, which was wrong.

* rendering/RenderGrid.h:
(WebCore::RenderGrid::GridCoordinate::GridCoordinate):
Updated GridCoordinate to hold 2 GridSpan. Also removed the 2 position
constructor (it would have been a hazard), replaced by a 2 GridSpan constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAlso don't log error messages from the GraphicsContext3D if webGLErrorsToConsoleEnabl...
jochen@chromium.org [Wed, 13 Mar 2013 22:24:08 +0000 (22:24 +0000)]
Also don't log error messages from the GraphicsContext3D if webGLErrorsToConsoleEnabled is false
https://bugs.webkit.org/show_bug.cgi?id=112284

Reviewed by Adam Barth.

When running layout tests in content_shell, we end up logging more information.
Since webGLErrorsToConsoleEnabled is false during layout tests, this change makes
sure we match the baselines.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContextErrorMessageCallback::onErrorMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Record attemps to open a path with non-ascii characters
dgrogan@chromium.org [Wed, 13 Mar 2013 21:59:23 +0000 (21:59 +0000)]
IndexedDB: Record attemps to open a path with non-ascii characters
https://bugs.webkit.org/show_bug.cgi?id=112224

Reviewed by Tony Chang.

We want to see if that's correlated with errors on open.

No new tests, there's no way to test histogramming that I know of. I
ran chrome locally with a non ascii path though.

* Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::open):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSimplify Checked<> multiplication
oliver@apple.com [Wed, 13 Mar 2013 21:51:07 +0000 (21:51 +0000)]
Simplify Checked<> multiplication
https://bugs.webkit.org/show_bug.cgi?id=112286

Reviewed by James Robinson.

Source/WTF:

Trying to correctly identify multiplication by zero complicated the
unsigned * unsigned multiply, and still didn't handle all cases correctly.
Now we just do the normal division based approach to overflow detection
leading to much simpler reasoning.

Would be nice if we could have a jo style intrinsic one day.

* wtf/CheckedArithmetic.h:

Tools:

Add tests for multiplication by zero and max to ensure we don't
mess them up should we ever make changes to Checked<> in future.

* TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
(TestWebKitAPI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Grid Layout] Handle min-width / max-width on the grid element
jchaffraix@webkit.org [Wed, 13 Mar 2013 21:50:11 +0000 (21:50 +0000)]
[CSS Grid Layout] Handle min-width / max-width on the grid element
https://bugs.webkit.org/show_bug.cgi?id=112269

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/css-grid-layout/grid-element-min-max-width.html

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::GridIterator::GridIterator):
Added some sanity checks that the starting indexes are in the grid.

(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
Updated the code to use m_grid to iterate: this is the correct way to
go as it will handle implicit rows / columns properly. Added a comment
about the current way being inefficient and incorrect with spanning grid
items.

(WebCore::RenderGrid::computePreferredLogicalWidths):
Updated the comments.

(WebCore::RenderGrid::gridTrackSize):
* rendering/RenderGrid.h:
Constified gridTrackSize.

LayoutTests:

* fast/css-grid-layout/grid-element-min-max-width-expected.txt: Added.
* fast/css-grid-layout/grid-element-min-max-width.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Add Proximity Detector.
commit-queue@webkit.org [Wed, 13 Mar 2013 21:49:35 +0000 (21:49 +0000)]
[BlackBerry] Add Proximity Detector.
https://bugs.webkit.org/show_bug.cgi?id=112278

Patch by Genevieve Mak <gmak@rim.com> on 2013-03-13
Reviewed by Rob Buis.

Internally Reviewed by Mike Lattanzio.
PR #243385

Source/WebKit:

* PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

* WebKitSupport/ProximityDetector.cpp: Added.
(WebKit):
(BlackBerry::WebKit::getPriorityLevel):
(BlackBerry::WebKit::ProximityDetector::ProximityDetector):
(BlackBerry::WebKit::ProximityDetector::~ProximityDetector):
(BlackBerry::WebKit::ProximityDetector::findBestPoint):
* WebKitSupport/ProximityDetector.h: Added.
(WebCore):
(WebKit):
(ProximityDetector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Prospective trivial build fix after r145744
hausmann@webkit.org [Wed, 13 Mar 2013 21:43:13 +0000 (21:43 +0000)]
[Qt] Prospective trivial build fix after r145744

Add missing closing parentheses.

* xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::parseDtd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAccount for review feedback in https://bugs.webkit.org/show_bug.cgi?id=112279
beidson@apple.com [Wed, 13 Mar 2013 21:41:10 +0000 (21:41 +0000)]
Account for review feedback in https://bugs.webkit.org/show_bug.cgi?id=112279
that I'd mistakenly left out of my commit.

* loader/ResourceLoaderTypes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in CompositeEditCommand::insertNodeAt.
inferno@chromium.org [Wed, 13 Mar 2013 21:38:19 +0000 (21:38 +0000)]
Crash in CompositeEditCommand::insertNodeAt.
https://bugs.webkit.org/show_bug.cgi?id=112280

Reviewed by Ryosuke Niwa.

* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::insertNodeAt): Fix incorrect cast use of toElement.
Subsitute with toContainerNode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSmall ResourceLoader cleanups.
beidson@apple.com [Wed, 13 Mar 2013 21:36:29 +0000 (21:36 +0000)]
Small ResourceLoader cleanups.
https://bugs.webkit.org/show_bug.cgi?id=112279

Reviewed by Geoff Garen.

Source/WebCore:

No new tests (Refactor with no behavior change).

1 - Add "OVERRIDE" to virtual methods in subclasses of ResourceLoader to catch future mistakes.
2 - Replace the "bool allAtOnce" flag with a descriptive enum to make reading code easier.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):

* loader/NetscapePlugInStreamLoader.cpp:
(WebCore::NetscapePlugInStreamLoader::didReceiveData):
* loader/NetscapePlugInStreamLoader.h:

* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::addData):
(WebCore::ResourceLoader::didReceiveData):
* loader/ResourceLoader.h:
* loader/ResourceLoaderTypes.h: Added.

* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveData):
* loader/SubresourceLoader.h:

Source/WebKit2:

Replace the "bool allAtOnce" flag with a descriptive enum to make reading code easier.

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveData):

* WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveData):
(WebKit::WebResourceLoader::didReceiveResource):
* WebProcess/Network/WebResourceLoader.h:
* WebProcess/Network/WebResourceLoader.messages.in: Get rid of the "allAtOnce" flag since it was always false.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agochromium's WebFrameTest.ReplaceNavigationAfterHistoryNavigation failing after r145734
japhet@chromium.org [Wed, 13 Mar 2013 21:27:21 +0000 (21:27 +0000)]
chromium's WebFrameTest.ReplaceNavigationAfterHistoryNavigation failing after r145734
https://bugs.webkit.org/show_bug.cgi?id=112281

Reviewed by Adam Barth.

Fixes the aforementioned chromiun webkit_unit_test

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::maybeFinishLoadingMultipartContent): FrameLoader::isReplacing() is not quite
    synonymous with loading multipart content. Check that it's actually loading multipart before doing
    multipart-specific things.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed attempted build fix for Windows. SchedulePair.cpp -> SchedulePairCF.cpp
dino@apple.com [Wed, 13 Mar 2013 21:26:19 +0000 (21:26 +0000)]
Unreviewed attempted build fix for Windows. SchedulePair.cpp -> SchedulePairCF.cpp

* WTF.vcproj/WTF.vcproj:
* WTF.vcxproj/WTF.vcxproj:
* WTF.vcxproj/WTF.vcxproj.filters:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd the default video poster if it doesn't exist in video tag
commit-queue@webkit.org [Wed, 13 Mar 2013 21:16:50 +0000 (21:16 +0000)]
Add the default video poster if it doesn't exist in video tag
https://bugs.webkit.org/show_bug.cgi?id=110263

Patch by Tao Bai <michaelbai@chromium.org> on 2013-03-13
Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/video-default-poster.html
       media/video-no-default-poster.html

The Android web view application could provide the default poster
for a video that doesn't have the poster attribute.

To provide the default poster, the application must set defaultVideoPosterURL
setting and return the image in the response of that URL.

The way to do this would be:

A) Replace the Element::imageSourceAttributeName function with an
   Element::imageSourceURL function that returns the imageSourceURL as a
   const AtomicString&. The body will be the same as before, it will just also
   include a call to getAttribute. Also will need to revise the four classes
   that override that function.

B) Add a new HTMLVideoElement::posterImageURL function that implements the
   default poster URL logic.

C) Update the four functions that get the poster attribute to handle poster
   loading and display to call posterImageURL.

   1) HTMLVideoElement::imageSourceURL.
   2) HTMLVideoElement::setDisplayMode.
   3) HTMLVideoElement::updateDisplayState.
   4) HTMLMediaElement::getPluginProxyParams. Will need to cast to
      HTMLVideoElement after checking isVideo.

* dom/Element.cpp:
(WebCore::Element::imageSourceURL): Replace imageSourceAttributeName() with imageSourceURL()
* dom/Element.h: Replace imageSourceAttributeName() with imageSourceURL()
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::imageSourceURL): Replace imageSourceAttributeName() with imageSourceURL()
* html/HTMLEmbedElement.h: Replace imageSourceAttributeName() with imageSourceURL()
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::getPluginProxyParams): Change to use posterImageURL
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::imageSourceURL): Replace imageSourceAttributeName() with imageSourceURL()
* html/HTMLObjectElement.h: Replace imageSourceAttributeName with imageSourceURL
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::HTMLVideoElement): set m_defaultPosterURL if there is such settings
(WebCore::HTMLVideoElement::imageSourceURL): Replace imageSourceAttributeName() with imageSourceURL()
(WebCore::HTMLVideoElement::setDisplayMode): Use imageSourceURL()
(WebCore::HTMLVideoElement::updateDisplayState): Use imageSourceURL()
(WebCore::HTMLVideoElement::posterImageURL): Return image source's KURL
* html/HTMLVideoElement.h: Replace imageSourceAttributeName() with imageSourceURL() and add m_defaultPosterURL
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement): Use imageSourceURL()
* page/Settings.in: Add defaultVideoPosterURL setting.
* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeImage): use imageSourceURL()
* platform/gtk/PasteboardGtk.cpp:
(WebCore::getURLForImageNode): use imageSourceURL()
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::absoluteImageURL): use imageSourceURL()
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::imageSourceURL): Replace imageSourceAttributeName() with imageSourceURL()
* svg/SVGImageElement.h: Replace imageSourceAttributeName() with imageSourceURL()
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup): support backup defaultVideoPosterURL.
(WebCore::InternalSettings::Backup::restoreTo): support restore defaultVideoPosterURL.
(WebCore::InternalSettings::setDefaultVideoPosterURL): set defaultVideoPosterURL.
* testing/InternalSettings.h:
(Backup): support backup defaultVideoPosterURL.
(InternalSettings): Add setDefaultVidoePosterURL method.
* testing/InternalSettings.idl: Add setDefaultVideoPosterURL for test purpose.
* testing/Internals.cpp:
(WebCore::Internals::getImageSourceURL): Add getImageSourceURL method.
* testing/Internals.h: Add getImageSourceURL method.
* testing/Internals.idl: Add getImageSourceURL method.

LayoutTests:

The Android web view application could provide the default poster
for a video that doesn't have the poster attribute.

To provide the default poster, the application must set defaultVideoPosterURL
setting and return the image in the response of that URL.

The way to do this would be:

A) Replace the Element::imageSourceAttributeName function with an
   Element::imageSourceURL function that returns the imageSourceURL as a
   const AtomicString&. The body will be the same as before, it will just also
   include a call to getAttribute. Also will need to revise the four classes
   that override that function.

B) Add a new HTMLVideoElement::posterImageURL function that implements the
   default poster URL logic.

C) Update the four functions that get the poster attribute to handle poster
   loading and display to call posterImageURL.

   1) HTMLVideoElement::imageSourceURL.
   2) HTMLVideoElement::setDisplayMode.
   3) HTMLVideoElement::updateDisplayState.
   4) HTMLMediaElement::getPluginProxyParams. Will need to cast to
      HTMLVideoElement after checking isVideo.

* media/video-default-poster-expected.txt: Added.
* media/video-default-poster.html: Added.
* media/video-no-default-poster-expected.txt: Added.
* media/video-no-default-poster.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoForce clip in fast/regions/autoheight-break-after-expected.html to match test
jamesr@google.com [Wed, 13 Mar 2013 20:55:22 +0000 (20:55 +0000)]
Force clip in fast/regions/autoheight-break-after-expected.html to match test
https://bugs.webkit.org/show_bug.cgi?id=112283

Reviewed by David Hyatt.

Regions always set a clip rect when rendering their contents. On Mountain Lion, the Ahem glyphs very slightly
visually overflow their bounds if there's no clip set. This sets a clip in the reference file so we get the same
rendering.

* fast/regions/autoheight-break-after-expected.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[iOS] Add optimized version of StringImpl's equal(LChar*,LChar*) for Apple CPUs
benjamin@webkit.org [Wed, 13 Mar 2013 20:44:08 +0000 (20:44 +0000)]
[iOS] Add optimized version of StringImpl's equal(LChar*,LChar*) for Apple CPUs
https://bugs.webkit.org/show_bug.cgi?id=112202

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-13
Reviewed by Gavin Barraclough.

* Source/WTF/wtf/Platform.h:
Make the macro WTF_ARM_ARCH_VERSION valid on any architecture.
* wtf/text/StringImpl.h:
(WTF::equal):
On ARMv7S, the new version is about 11% percent faster than the simple loop.
On ARMv7 classic, memcmp is a little faster than the simple loop on Apple A5.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed prospective Windows build fix
hausmann@webkit.org [Wed, 13 Mar 2013 20:42:11 +0000 (20:42 +0000)]
[Qt] Unreviewed prospective Windows build fix

Do the usual thing, include the moc generated code in the .cpp file instead
of compiling it standalone, to ensure that config.h is included, too, and
NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.

* DumpRenderTree/qt/EventSenderQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake lint-test-expectations happy with the Apple-Windows TestExpectations files
timothy_horton@apple.com [Wed, 13 Mar 2013 20:38:51 +0000 (20:38 +0000)]
Make lint-test-expectations happy with the Apple-Windows TestExpectations files

Unreviewed.

accessibility/radio-button-checkbox-size.html was moved to platform/mac in http://trac.webkit.org/changeset/138124
fast/css/ignore-text-zoom.html was removed in http://trac.webkit.org/changeset/145168
inspector-protocol/layer-tree.html was removed in http://trac.webkit.org/changeset/144624
Remove a bunch of duplicate entries.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace static_casts with to* functions for document types.
inferno@chromium.org [Wed, 13 Mar 2013 20:29:08 +0000 (20:29 +0000)]
Replace static_casts with to* functions for document types.
https://bugs.webkit.org/show_bug.cgi?id=112225

Reviewed by Ryosuke Niwa.

Source/WebCore:

to* helper functions are preferred over static_cast calls since they
help to catch bad casts easily on the testing infrastructure.

* Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::document):
....lot of files.

Source/WebKit2:

* WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm: Remove the redundant helper.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Handle XHTML entities in XHTML Mobile Profile 1.1 and 1.2. We previou...
commit-queue@webkit.org [Wed, 13 Mar 2013 20:24:51 +0000 (20:24 +0000)]
Source/WebCore: Handle XHTML entities in XHTML Mobile Profile 1.1 and 1.2. We previously only handled them in XHTML Mobile Profile 1.0.
https://bugs.webkit.org/show_bug.cgi?id=112174
RIM PR 309038

Patch by Liam Quinn <lquinn@blackberry.com> on 2013-03-13
Reviewed by Rob Buis.
Internally reviewed by Leo Yang.

Check for the 1.1 and 1.2 doctypes alongside the 1.0 doctype.

Tests: fast/doctypes/xhtml-with-xhtmlmp11-doctype.xhtml
       fast/doctypes/xhtml-with-xhtmlmp12-doctype.xhtml

* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::externalSubsetHandler):
* xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::parseDtd):

LayoutTests: New tests to check that XHTML entities are supported in XHTML Mobile Profile 1.1 and 1.2.
https://bugs.webkit.org/show_bug.cgi?id=112174
RIM PR 309038

Patch by Liam Quinn <lquinn@blackberry.com> on 2013-03-13
Reviewed by Rob Buis.
Internally reviewed by Leo Yang.

* fast/doctypes/xhtml-with-xhtmlmp11-doctype-expected.txt: Added.
* fast/doctypes/xhtml-with-xhtmlmp11-doctype.xhtml: Added.
* fast/doctypes/xhtml-with-xhtmlmp12-doctype-expected.txt: Added.
* fast/doctypes/xhtml-with-xhtmlmp12-doctype.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSchedulePair.cpp is CF-specific
commit-queue@webkit.org [Wed, 13 Mar 2013 20:23:27 +0000 (20:23 +0000)]
SchedulePair.cpp is CF-specific
https://bugs.webkit.org/show_bug.cgi?id=112204

Patch by James Robinson <jamesr@chromium.org> on 2013-03-13
Reviewed by Oliver Hunt.

This renames SchedulePair.cpp SchedulePairCF.cpp, since it depends on CF, and excludes it from chromium's gyp
files.

* WTF.gyp/WTF.gyp:
  Add CF to the exclusion filter for the Chromium port.
* WTF.gypi:
  Add SchedulePairCF.cpp
* WTF.xcodeproj/project.pbxproj:
  Update project file to point to new .cpp location
* wtf/SchedulePairCF.cpp: Renamed from Source/WTF/wtf/SchedulePair.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, fix a path in TestExpectations.
timothy_horton@apple.com [Wed, 13 Mar 2013 20:23:01 +0000 (20:23 +0000)]
Unreviewed, fix a path in TestExpectations.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Better error handling in NetworkStateNotifierEfl
ch.dumez@sisa.samsung.com [Wed, 13 Mar 2013 20:10:05 +0000 (20:10 +0000)]
[EFL] Better error handling in NetworkStateNotifierEfl
https://bugs.webkit.org/show_bug.cgi?id=112184

Reviewed by Kenneth Rohde Christiansen.

Improve error handling in for system calls in NetworkStateNotifierEfl.
- EINTR errors are now properly handled for close() and recv() syscalls
- recv() errors are now correctly detected, for e.g. if the socket was
closed unexpectedly.
- Make sure m_fdHandler is reset when the callback returns
ECORE_CALLBACK_CANCEL to avoid double free in destructor. m_fdHandler
gets destroyed when the callback returns ECORE_CALLBACK_CANCEL.
- Keep netlink socket file descriptor as a class member so that we can
close() it in the class destructor, even if m_fdHandler has already
been destroyed.

No new tests, no behavior change for layout tests.

* platform/network/NetworkStateNotifier.h:
(NetworkStateNotifier):
* platform/network/efl/NetworkStateNotifierEfl.cpp:
(WebCore::NetworkStateNotifier::readSocketCallback):
(WebCore::NetworkStateNotifier::~NetworkStateNotifier):
(WebCore::NetworkStateNotifier::NetworkStateNotifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] MediaStream API: Cleaning away deprecated and unused states
tommyw@google.com [Wed, 13 Mar 2013 19:58:06 +0000 (19:58 +0000)]
[chromium] MediaStream API: Cleaning away deprecated and unused states
https://bugs.webkit.org/show_bug.cgi?id=112258

Reviewed by Adam Barth.

* chromium/public/WebRTCPeerConnectionHandler.h:
(WebRTCPeerConnectionHandler):
* chromium/public/WebRTCPeerConnectionHandlerClient.h:
(WebRTCPeerConnectionHandlerClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd new Skia code suppression flags
schenney@chromium.org [Wed, 13 Mar 2013 19:55:41 +0000 (19:55 +0000)]
Add new Skia code suppression flags

Unreviewed build update.

* skia_webkit.gyp: Add 'SK_DISABLE_BLUR_ROUNDING', 'SK_IGNORE_SUBPIXEL_AXIS_ALIGN_FIX',
    'SK_IGNORE_PICTURE_RECORD_SAVE_LAYER_OPT', 'SK_IGNORE_FAST_RECT_BLUR', 'SK_IGNORE_CUBIC_STROKE_FIX'

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Build fixes after 145552
commit-queue@webkit.org [Wed, 13 Mar 2013 19:46:12 +0000 (19:46 +0000)]
[GTK] Build fixes after 145552
https://bugs.webkit.org/show_bug.cgi?id=112267

Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-03-13
Reviewed by Gustavo Noronha Silva.

Source/Platform:

* GNUmakefile.am: Include the same-level GNUmakefile.list.am.
Fix a typo in the inline visibility compiler flag.

Source/WebKit2:

* GNUmakefile.am: Narrow down the dependency CFLAGS list to only ones that are actually needed
to build the platformgtk_sources into libPlatformGtk2.la. At the moment this means only
GTK+-2.0 CFLAGS are used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClean out some stale chromium TestExpectations entries.
jamesr@google.com [Wed, 13 Mar 2013 19:32:18 +0000 (19:32 +0000)]
Clean out some stale chromium TestExpectations entries.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRegression(r143542): -webkit-align-items: center with overflow: auto/scroll has extra...
tony@chromium.org [Wed, 13 Mar 2013 19:28:59 +0000 (19:28 +0000)]
Regression(r143542): -webkit-align-items: center with overflow: auto/scroll has extra bottom padding
https://bugs.webkit.org/show_bug.cgi?id=112047

Reviewed by Ojan Vafai.

Source/WebCore:

Add a new pass for computing the client bottom edge that runs after we've repositioned children
due to wrap-reverse, flex-end or vertical centering.

Test: css3/flexbox/negative-overflow.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock): Remove the code to use clientLogicalBottom() that was computed before
repositioning. The repositioning can change the edge.
(WebCore::RenderFlexibleBox::clientLogicalBottomAfterRepositioning): Compute the new bottom based on the final position
of flex items.
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):

LayoutTests:

* css3/flexbox/negative-overflow-expected.txt: Added.
* css3/flexbox/negative-overflow.html: Added.
* resources/check-layout.js: Add attributes for checking scroll width and scroll height.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago.: Expose symbols for internals
japhet@chromium.org [Wed, 13 Mar 2013 19:14:31 +0000 (19:14 +0000)]
.: Expose symbols for internals
https://bugs.webkit.org/show_bug.cgi?id=112194

Reviewed by Alexey Proskuryakov.

* Source/autotools/symbols.filter:

Source/WebCore: REGRESSION(r137607): Redirecting a post to a get then reloading triggers resubmit warning
https://bugs.webkit.org/show_bug.cgi?id=112194

Reviewed by Alexey Proskuryakov.

Test: http/tests/navigation/post-redirect-get-reload.php

* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest): Matching urls aren't a reliable way of checking whether
    we are in a redirect. Check redirectResponse.isNull() instead.
* testing/Internals.cpp:
(WebCore::Internals::forceReload): Expose a means of forcing a reload like one a user generates for testing.
    Note that testRunner.queueReload() does this, but is not supported after the initial load completes,
    which makes it unsuitable for this case.
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit/win: Expose symbols for internals
https://bugs.webkit.org/show_bug.cgi?id=112194

Reviewed by Alexey Proskuryakov.

* WebKit.vcproj/WebKitExports.def.in:

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=112194.

Reviewed by Alexey Proskuryakov.

* http/tests/navigation/post-redirect-get-reload-expected.txt: Added.
* http/tests/navigation/post-redirect-get-reload.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMerge MainResourceLoader's didFinishLoading and dataReceived into DocumentLoader
japhet@chromium.org [Wed, 13 Mar 2013 19:11:35 +0000 (19:11 +0000)]
Merge MainResourceLoader's didFinishLoading and dataReceived into DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=109952

Reviewed by Antti Koivisto.

No new tests, refactor only.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::responseReceived):
(WebCore::DocumentLoader::receivedData):
(WebCore::DocumentLoader::maybeLoadEmpty):
* loader/DocumentLoader.h:
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::responseReceived): Move content filtering to
    DocumentLoader.
(WebCore::MainResourceLoader::dataReceived): Mostly moved to DocumentLoader.
(WebCore::MainResourceLoader::didFinishLoading): Mostly moved to DocumentLoader.
* loader/MainResourceLoader.h: Expose some variables that haven't been moved
    to DocumentLoader yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCalling WebInspectorClient::highlight() during a fade-out animation of the PageOverla...
graouts@apple.com [Wed, 13 Mar 2013 18:47:34 +0000 (18:47 +0000)]
Calling WebInspectorClient::highlight() during a fade-out animation of the PageOverlay won't stop its animation
https://bugs.webkit.org/show_bug.cgi?id=112271

Reviewed by Tim Horton.

Add a new stopFadeOutAnimation() on PageOverlay that we call when
WebInspectorClient::highlight() is called and a page overlay
is already available. This ensures that any fade-out animation
is cleared before proceeding with showing the page overlay
for the new highlight.

* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::highlight):
* WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::stopFadeOutAnimation):
(WebKit):
* WebProcess/WebPage/PageOverlay.h:
(PageOverlay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] Break after doesn't work correctly with auto-height regions
abucur@adobe.com [Wed, 13 Mar 2013 18:32:14 +0000 (18:32 +0000)]
[CSS Regions] Break after doesn't work correctly with auto-height regions
https://bugs.webkit.org/show_bug.cgi?id=112241

Reviewed by David Hyatt.

Source/WebCore:

The change correctly returns the break position during the normal layout phase for
auto-height regions. The problem doesn't exist during the constrained layout phase
so it only affects the size of the auto-height regions by incorrectly positioning
the content inside the flow.

Test: fast/regions/autoheight-break-after.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::applyAfterBreak): Include the margin offset in the returned break position.

LayoutTests:

This reference test verifies the correct break positioned is computed when there are auto-height regions during
the normal layout phase.
The test includes an auto-height region, a region with a specified size and an auto-height region. The first
region ends with a paragraph with a forced break after. During the normal layout phase, if the paragraph margin
is not included in the break offset, the next paragraph is incorrectly positioned and it will result in an
incorrectly sized last region.
In the constrained layout phase, the break position is returned correctly, the paragraph is positioned further down
causing overflow in the auto-height region.

* fast/regions/autoheight-break-after-expected.html: Added.
* fast/regions/autoheight-break-after.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: coalesce repeating timeline records
caseq@chromium.org [Wed, 13 Mar 2013 18:14:38 +0000 (18:14 +0000)]
Web Inspector: coalesce repeating timeline records
https://bugs.webkit.org/show_bug.cgi?id=112168

Reviewed by Vsevolod Vlasov.

- coalesce repeating top-level timeline events;
- drive-by: only show categories that actually took time in aggregated stats;

* English.lproj/localizedStrings.js:
* inspector/front-end/TimelineFrameController.js:
(WebInspector.TimelineFrameController.prototype._innerAddRecord):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._highlightRect):
(WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype._innerAddRecord):
(WebInspector.TimelinePresentationModel.prototype._updateAncestorStats):
(WebInspector.TimelinePresentationModel.prototype._findCoalescedParent):
(WebInspector.TimelinePresentationModel.prototype._replaceWithCoalescedRecord):
(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.adoptRecord):
(WebInspector.TimelinePresentationModel.insertRetrospectiveRecord):
(WebInspector.TimelinePresentationModel.Record.prototype.get selfTime):
(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
(WebInspector.TimelinePresentationModel.Record.prototype._getRecordDetails):
(WebInspector.TimelinePresentationModel.Record.prototype.calculateAggregatedStats):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix body background image geometry calculation
pdr@google.com [Wed, 13 Mar 2013 17:01:55 +0000 (17:01 +0000)]
Fix body background image geometry calculation
https://bugs.webkit.org/show_bug.cgi?id=112226

Reviewed by Stephen Chenney.

Source/WebCore:

Images that depend on a container size require a call to set the container size before
rendering, and a call to look up the correct image during painting.

The body's renderer is special in that it may not be the renderer that actually paints its
background. This patch fixes a bug where the correct RenderObject was used for looking up
the image, but not for setting the container size. This fixes SVG background images on body.

Test: svg/as-background-image/svg-as-background-body.html

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

    This change introduces clientForBackgroundImage in the background geometry calculation.
    This is very similar to how the client is looked up in paintFillLayerExtended.

* rendering/RenderBoxModelObject.h:

    The new signature for calculateBackgroundImageGeometry now mirrors
    paintFillLayerExtended, containing a parameter for the correct background renderer.

(RenderBoxModelObject):

LayoutTests:

This test is required to have a repeating background, as we optimize non-repeating
backgrounds so the bug is not hit. A light green color is used so the text is still
readable, and gridlines are present to prove the correct container size is being used.

* svg/as-background-image/svg-as-background-body-expected.html: Added.
* svg/as-background-image/svg-as-background-body.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [CodeMirror] Handle "enter" key in {|} situation
commit-queue@webkit.org [Wed, 13 Mar 2013 16:23:47 +0000 (16:23 +0000)]
Web Inspector: [CodeMirror] Handle "enter" key in {|} situation
https://bugs.webkit.org/show_bug.cgi?id=112153

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-13
Reviewed by Vsevolod Vlasov.

Add a keymap to handle "Enter" key and override it in case of {|}
situation.

No new tests.

* inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.BlockIndentController):
(WebInspector.CodeMirrorTextEditor.BlockIndentController.prototype.Enter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [CodeMirror] bug with LineWidgets
commit-queue@webkit.org [Wed, 13 Mar 2013 15:47:32 +0000 (15:47 +0000)]
Web Inspector: [CodeMirror] bug with LineWidgets
https://bugs.webkit.org/show_bug.cgi?id=111978

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-13
Reviewed by Vsevolod Vlasov.

Implement CodeMirrorTextEditor.beginUpdates and
CodeMirrorTextEditor.endUpdates and surround decoration creation
with the beginUpdates/endUpdates calls.

No new tests.

* inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype.beginUpdates):
(WebInspector.CodeMirrorTextEditor.prototype.endUpdates):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.addMessageToSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][Introspection] Fix of gtk doc annotation warnings
commit-queue@webkit.org [Wed, 13 Mar 2013 15:38:43 +0000 (15:38 +0000)]
[GTK][Introspection] Fix of gtk doc annotation warnings
https://bugs.webkit.org/show_bug.cgi?id=109182

Patch by Tomas Popela <tpopela@redhat.com> on 2013-03-13
Reviewed by Martin Robinson.

Fixed some gtk doc annotation warnings that appears during
compiling. Also some white characters were removed and some restyling
was done - all the g_signal_new in webkit directory have now the same
style.

* webkit/webkitdownload.cpp:
(webkit_download_class_init):
* webkit/webkitfavicondatabase.cpp:
(webkit_favicon_database_class_init):
* webkit/webkitgeolocationpolicydecision.cpp:
* webkit/webkitglobals.cpp:
* webkit/webkithittestresult.h:
* webkit/webkiticondatabase.cpp:
(webkit_icon_database_class_init):
* webkit/webkitsecurityorigin.cpp:
* webkit/webkitsecurityorigin.h:
* webkit/webkitsoupauthdialog.cpp:
* webkit/webkitspellchecker.cpp:
* webkit/webkitviewportattributes.cpp:
(webkit_viewport_attributes_class_init):
* webkit/webkitwebdatabase.cpp:
* webkit/webkitwebframe.cpp:
(webkit_web_frame_class_init):
* webkit/webkitwebframe.h:
* webkit/webkitwebinspector.cpp:
(webkit_web_inspector_class_init):
* webkit/webkitwebnavigationaction.cpp:
(webkit_web_navigation_action_class_init):
* webkit/webkitwebplugindatabase.cpp:
* webkit/webkitwebpolicydecision.cpp:
* webkit/webkitwebresource.cpp:
(webkit_web_resource_class_init):
* webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
* webkit/webkitwebview.cpp:
(webkit_web_view_class_init):
(webkit_web_view_apply_zoom_level):
* webkit/webkitwebwindowfeatures.cpp:
(webkit_web_window_features_equal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCleanup dead MediaSource code now that the Chromium-side refactor is complete.
acolwell@chromium.org [Wed, 13 Mar 2013 15:37:57 +0000 (15:37 +0000)]
Cleanup dead MediaSource code now that the Chromium-side refactor is complete.
https://bugs.webkit.org/show_bug.cgi?id=110371

Reviewed by Adam Barth.

* public/WebMediaPlayer.h:
(WebKit):
(WebMediaPlayer): Remove old MediaSource methods and default MediaSource load() implementation.
* public/WebMediaPlayerClient.h: Remove old MediaSource methods.
* src/WebMediaPlayerClientImpl.cpp: Remove WebMediaSourceClientImpl & WebSourceBufferImpl classes that
                                    are no longer needed.
* src/WebMediaPlayerClientImpl.h: Remove old MediaSource methods.
(WebMediaPlayerClientImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Touch Hold selection does not scroll text area or other subframe until...
commit-queue@webkit.org [Wed, 13 Mar 2013 15:34:34 +0000 (15:34 +0000)]
[BlackBerry] Touch Hold selection does not scroll text area or other subframe until selection reaches bottom of the page.
https://bugs.webkit.org/show_bug.cgi?id=112259

Patch by Iris Wu <shuwu@blackberry.com> on 2013-03-13
Reviewed by Rob Buis.

PR 267394

While selecting in a subframe, check that the selection reaches
the bottom of the current subframe instead of the page.

Internally Reviewed by Genevieve Mak.

* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::updateSelectionScrollView):
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectAtPoint):
(BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
(BlackBerry::WebKit::SelectionHandler::selectionViewportRect):
(WebKit):
(BlackBerry::WebKit::SelectionHandler::expandSelectionToGranularity):
* WebKitSupport/SelectionHandler.h:
(BlackBerry::WebKit::SelectionHandler::setSelectionViewportRect):
(SelectionHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Port TestRunner::findString to shared interface
hausmann@webkit.org [Wed, 13 Mar 2013 15:24:17 +0000 (15:24 +0000)]
[Qt] Port TestRunner::findString to shared interface
https://bugs.webkit.org/show_bug.cgi?id=112147

Reviewed by Jocelyn Turcotte.

Source/WebKit/qt:

Add new find options used by the DRT.

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
* WebCoreSupport/DumpRenderTreeSupportQt.h:
* WebCoreSupport/QWebPageAdapter.cpp:
(QWebPageAdapter::findText):
* WebCoreSupport/QWebPageAdapter.h:
* WidgetApi/qwebpage.cpp:
* WidgetApi/qwebpage.h:

Tools:

This patch also removes DumpRenderTree and some other helper classes from
the WebCore namespace, to which they do not really belong.

* DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(main):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(DumpRenderTree::DumpRenderTree):
(DumpRenderTree::~DumpRenderTree):
(DumpRenderTree::instance):
(DumpRenderTree::setShouldTimeout):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
(DumpRenderTree):
* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::contextClick):
(EventSender::sendEvent):
(EventSender::postEvent):
* DumpRenderTree/qt/EventSenderQt.h:
(EventSender::isGraphicsBased):
* DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunnerQt::TestRunnerQt):
(TestRunner::findString):
(TestRunnerQt::setMockDeviceOrientation):
(TestRunnerQt::setGeolocationPermission):
(TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
(TestRunnerQt::setMockGeolocationPositionUnavailableError):
(TestRunnerQt::setMockGeolocationPosition):
* DumpRenderTree/qt/TestRunnerQt.h:
(TestRunnerQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: get rid of hiddenPanels filter
pfeldman@chromium.org [Wed, 13 Mar 2013 14:17:45 +0000 (14:17 +0000)]
Web Inspector: get rid of hiddenPanels filter
https://bugs.webkit.org/show_bug.cgi?id=112252

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* WebCore.order:
* inspector/InspectorFrontendClient.h:
(InspectorFrontendClient):
* inspector/InspectorFrontendHost.cpp:
* inspector/InspectorFrontendHost.h:
(InspectorFrontendHost):
* inspector/InspectorFrontendHost.idl:
* inspector/front-end/InspectorFrontendHostStub.js:
* inspector/front-end/externs.js:
* inspector/front-end/inspector.js:
(WebInspector._panelDescriptors):
* testing/Internals.cpp:

Source/WebKit/chromium:

* src/InspectorFrontendClientImpl.cpp:
* src/InspectorFrontendClientImpl.h:
(InspectorFrontendClientImpl):

Source/WebKit/efl:

* WebCoreSupport/InspectorClientEfl.cpp:
* WebCoreSupport/InspectorClientEfl.h:
(InspectorFrontendClientEfl):

Source/WebKit/gtk:

* WebCoreSupport/InspectorClientGtk.cpp:
* WebCoreSupport/InspectorClientGtk.h:
(InspectorFrontendClient):

Source/WebKit/mac:

* WebCoreSupport/WebInspectorClient.h:
(WebInspectorFrontendClient):
* WebCoreSupport/WebInspectorClient.mm:
* WebKit.order:

Source/WebKit/qt:

* WebCoreSupport/InspectorClientQt.cpp:
(WebCore):
* WebCoreSupport/InspectorClientQt.h:
(InspectorFrontendClientQt):

Source/WebKit/win:

* WebCoreSupport/WebInspectorClient.cpp:
* WebCoreSupport/WebInspectorClient.h:
(WebInspectorFrontendClient):

Source/WebKit2:

* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
(WebInspectorFrontendClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed: chromium baselines.
pfeldman@chromium.org [Wed, 13 Mar 2013 14:14:22 +0000 (14:14 +0000)]
Not reviewed: chromium baselines.

* platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Removed.
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Removed.
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Rename android_build_type to android_webview_build in .gyp files.
mnaganov@chromium.org [Wed, 13 Mar 2013 14:13:13 +0000 (14:13 +0000)]
[Chromium] Rename android_build_type to android_webview_build in .gyp files.
https://bugs.webkit.org/show_bug.cgi?id=112129

Reviewed by Adam Barth.

Following Chromium
http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
this is being renamed to better explain what it does.

Source/WebKit/chromium:

* WebKitUnitTests.gyp:

Tools:

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: convert workers inspection into capability
pfeldman@chromium.org [Wed, 13 Mar 2013 13:38:33 +0000 (13:38 +0000)]
Web Inspector: convert workers inspection into capability
https://bugs.webkit.org/show_bug.cgi?id=112251

Reviewed by Vsevolod Vlasov.

Source/WebCore:

It should be up to backend

* inspector/Inspector.json:
* inspector/InspectorFrontendClient.h:
(InspectorFrontendClient):
* inspector/InspectorFrontendClientLocal.h:
* inspector/InspectorFrontendHost.cpp:
* inspector/InspectorFrontendHost.h:
(InspectorFrontendHost):
* inspector/InspectorFrontendHost.idl:
* inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::canInspectWorkers):
(WebCore):
* inspector/InspectorWorkerAgent.h:
(InspectorWorkerAgent):
* inspector/front-end/InspectorFrontendHostStub.js:
* inspector/front-end/Settings.js:
* inspector/front-end/externs.js:
* inspector/front-end/inspector.js:
(WebInspector.doLoadedDone):

Source/WebKit/chromium:

* src/InspectorFrontendClientImpl.cpp:
* src/InspectorFrontendClientImpl.h:
(InspectorFrontendClientImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Start using evas object directly in Widget class
mikhail.pozdnyakov@intel.com [Wed, 13 Mar 2013 13:30:05 +0000 (13:30 +0000)]
[EFL] Start using evas object directly in Widget class
https://bugs.webkit.org/show_bug.cgi?id=111858

Reviewed by Antonio Gomes.

Based on a patch by Kenneth Rohde Christiansen.

EFL Widget class should use evas object pointer directly rather
than WidgetPrivate* m_data as platformWidget() is a Mac specific
implementation detail that they are moving away from with WebKit2.

This patch brings: firstly better compliance with other ports,
secondly it makes code cleaner.

Besides, the evasObject is only directly used in the ScrollbarEfl
subclass of Widget and not in Widget or ScrollView or any other subclass,
thus the evas_object code has now been concentrated in ScrollbarEfl.

No new tests as there are no behavioral changes.

* page/efl/EventHandlerEfl.cpp:
* platform/Widget.h:
(Widget):
(WebCore::Widget::evasObject):
* platform/efl/ScrollbarEfl.cpp:
(ScrollbarEfl::~ScrollbarEfl):
(scrollbarEflEdjeMessage):
(ScrollbarEfl::show):
(ScrollbarEfl::hide):
(ScrollbarEfl::setParent):
(ScrollbarEfl::updateThumbPositionAndProportion):
(ScrollbarEfl::frameRectsChanged):
* platform/efl/ScrollbarEfl.h:
(ScrollbarEfl):
* platform/efl/WidgetEfl.cpp:
(WebCore::Widget::Widget):
(WebCore::Widget::~Widget):
(WebCore::Widget::frameRectsChanged):
(WebCore::Widget::show):
(WebCore::Widget::hide):
(WebCore::Widget::setEvasObject):
* plugins/efl/PluginViewEfl.cpp:
(WebCore::PluginView::platformGetValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed trivial typo fix
hausmann@webkit.org [Wed, 13 Mar 2013 13:01:26 +0000 (13:01 +0000)]
[Qt] Unreviewed trivial typo fix

* DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
TextRunner.h. Thanks Zeno :)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Prepare DRT for transition to shared TestRunner interface
hausmann@webkit.org [Wed, 13 Mar 2013 12:48:47 +0000 (12:48 +0000)]
[Qt] Prepare DRT for transition to shared TestRunner interface
https://bugs.webkit.org/show_bug.cgi?id=112144

Reviewed by Benjamin Poulain.

Prepare Qt's DRT for a transition from the QObject based TestRunner to
the JSC C API based one.

This is impplemented by instantiating the QObject based testRunner in
the global object, then instantiating the JSC C based TestRunner
separately and placing it "behind" the QObject based testRunner through
injection of the individual functions through proxies. (prototype
chaining doesn't work due to the this object and Function.prototype.bind
doesn't work due to the native function)

This allows for porting over method by method by removing the method
from the QObject TestRunnerQt and implementing it in the JSC C based
TestRunner.

In order for this to link and run dummy implementations of all the
necessary TestRunner functions are provided.

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeMain.cpp:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
(WebCore::DumpRenderTree::initJSObjects):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
(DumpRenderTree):
* DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunner::~TestRunner):
(TestRunner::addDisallowedURL):
(TestRunner::queueLoad):
(TestRunner::removeAllVisitedLinks):
(TestRunner::setAcceptsEditing):
(TestRunner::simulateLegacyWebNotificationClick):
(TestRunner::setWindowIsKey):
(TestRunner::setAlwaysAcceptCookies):
(TestRunner::addOriginAccessWhitelistEntry):
(TestRunner::setWebViewEditable):
(TestRunner::clearAllApplicationCaches):
(TestRunner::setTextDirection):
(TestRunner::notifyDone):
(TestRunner::numberOfPendingGeolocationPermissionRequests):
(TestRunner::overridePreference):
(TestRunner::pathToLocalResource):
(TestRunner::removeAllWebNotificationPermissions):
(TestRunner::simulateWebNotificationClick):
(TestRunner::closeIdleLocalStorageDatabases):
(TestRunner::focusWebView):
(TestRunner::setBackingScaleFactor):
(TestRunner::removeChromeInputField):
(TestRunner::addChromeInputField):
(TestRunner::originsWithLocalStorage):
(TestRunner::deleteAllLocalStorage):
(TestRunner::deleteLocalStorageForOrigin):
(TestRunner::observeStorageTrackerNotifications):
(TestRunner::syncLocalStorage):
(TestRunner::windowCount):
(TestRunner::setWaitToDump):
(TestRunner::waitForPolicyDelegate):
(TestRunner::webHistoryItemCount):
(TestRunner::showWebInspector):
(TestRunner::closeWebInspector):
(TestRunner::evaluateInWebInspector):
(TestRunner::setSerializeHTTPLoads):
(TestRunner::apiTestNewWindowDataLoadBaseURL):
(TestRunner::setCustomPolicyDelegate):
(TestRunner::setDatabaseQuota):
(TestRunner::setDomainRelaxationForbiddenForURLScheme):
(TestRunner::resetPageVisibility):
(TestRunner::keepWebHistory):
(TestRunner::goBack):
(TestRunner::originsWithApplicationCache):
(TestRunner::applicationCacheDiskUsageForOrigin):
(TestRunner::display):
(TestRunner::dispatchPendingLoadRequests):
(TestRunner::clearPersistentUserStyleSheet):
(TestRunner::callShouldCloseOnWebView):
(TestRunner::copyDecodedHostName):
(TestRunner::clearBackForwardList):
(TestRunner::clearAllDatabases):
(TestRunner::clearApplicationCacheForOrigin):
(TestRunner::apiTestGoToCurrentBackForwardItem):
(TestRunner::authenticateSession):
(TestRunner::abortModal):
(TestRunner::setStorageDatabaseIdleInterval):
(TestRunner::setAsynchronousSpellCheckingEnabled):
(TestRunner::setXSSAuditorEnabled):
(TestRunner::setSpatialNavigationEnabled):
(TestRunner::setScrollbarPolicy):
(TestRunner::setJavaScriptCanAccessClipboard):
(TestRunner::setAutomaticLinkDetectionEnabled):
(TestRunner::setUserStyleSheetEnabled):
(TestRunner::setUserStyleSheetLocation):
(TestRunner::setUseDashboardCompatibilityMode):
(TestRunner::setTabKeyCyclesThroughElements):
(TestRunner::setSmartInsertDeleteEnabled):
(TestRunner::setSelectTrailingWhitespaceEnabled):
(TestRunner::setPrivateBrowsingEnabled):
(TestRunner::setPluginsEnabled):
(TestRunner::setPopupBlockingEnabled):
(TestRunner::setMockSpeechInputDumpRect):
(TestRunner::setPersistentUserStyleSheetLocation):
(TestRunner::setMockGeolocationPosition):
(TestRunner::setMockGeolocationPositionUnavailableError):
(TestRunner::setMockDeviceOrientation):
(TestRunner::setMainFrameIsFirstResponder):
(TestRunner::setIconDatabaseEnabled):
(TestRunner::setGeolocationPermission):
(TestRunner::setDefersLoading):
(TestRunner::setCacheModel):
(TestRunner::setAuthorAndUserStylesEnabled):
(TestRunner::setAllowFileAccessFromFileURLs):
(TestRunner::setAppCacheMaximumSize):
(TestRunner::setAllowUniversalAccessFromFileURLs):
(TestRunner::setApplicationCacheOriginQuota):
(TestRunner::denyWebNotificationPermission):
(TestRunner::grantWebNotificationPermission):
(TestRunner::setValueForUser):
(TestRunner::setViewModeMediaFeature):
(TestRunner::setPageVisibility):
(TestRunner::addMockSpeechInputResult):
(TestRunner::removeOriginAccessWhitelistEntry):
(TestRunner::addUserScript):
(TestRunner::isCommandEnabled):
(TestRunner::evaluateScriptInIsolatedWorld):
(TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
(TestRunner::copyEncodedHostName):
(TestRunner::addUserStyleSheet):
(TestRunner::findString):
(TestRunner::execCommand):
(TestRunner::localStorageDiskUsageForOrigin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [CodeMirror] token highlight still has some problems
commit-queue@webkit.org [Wed, 13 Mar 2013 12:48:28 +0000 (12:48 +0000)]
Web Inspector: [CodeMirror] token highlight still has some problems
https://bugs.webkit.org/show_bug.cgi?id=112173

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-13
Reviewed by Vsevolod Vlasov.

Use pseudo elements with borders to draw token highlight.

No new tests.

* inspector/front-end/cm/cmdevtools.css:
(.cm-token-highlight):
(.cm-token-highlight:before):
(.cm-line-with-selection .cm-column-with-selection:before):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] SimpleFontData: remove duplicate code
commit-queue@webkit.org [Wed, 13 Mar 2013 12:38:08 +0000 (12:38 +0000)]
[BlackBerry] SimpleFontData: remove duplicate code
https://bugs.webkit.org/show_bug.cgi?id=112149

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-13
Reviewed by Carlos Garcia Campos.

smallCapsFontData() and emphasisMarkFontData() were moved from
platform specific files into platform/graphics/SimpleFontData.cpp
in r133362, so the BlackBerry port no longer needs its own
implementation.

* platform/graphics/blackberry/SimpleFontDataBlackBerry.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed: chromium baselines.
pfeldman@chromium.org [Wed, 13 Mar 2013 12:20:46 +0000 (12:20 +0000)]
Not reviewed: chromium baselines.

* platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Removed.
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: throw an exception if the requested lazy loaded script does not exist.
loislo@chromium.org [Wed, 13 Mar 2013 12:18:06 +0000 (12:18 +0000)]
Web Inspector: throw an exception if the requested lazy loaded script does not exist.
https://bugs.webkit.org/show_bug.cgi?id=112237

Reviewed by Pavel Feldman.

* inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLLINT C loop warning fix for GCC
ossy@webkit.org [Wed, 13 Mar 2013 12:13:23 +0000 (12:13 +0000)]
LLINT C loop warning fix for GCC
https://bugs.webkit.org/show_bug.cgi?id=112145

Reviewed by Filip Pizlo.

* llint/LowLevelInterpreter.cpp:
(JSC::CLoop::execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][Qt] Regression(145517) WebProcess asserts in debug build on WebKitTestRunner...
jocelyn.turcotte@digia.com [Wed, 13 Mar 2013 11:27:00 +0000 (11:27 +0000)]
[WK2][Qt] Regression(145517) WebProcess asserts in debug build on WebKitTestRunner start
https://bugs.webkit.org/show_bug.cgi?id=112223

Reviewed by Simon Hausmann.

We need to only enable the cookie jar and the disk cache conditionally
in the web process since we removed default paths and WKTR doesn't provide
them.

* WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformInitializeWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSupport C++11 features in GCC <4.6
allan.jensen@digia.com [Wed, 13 Mar 2013 11:22:15 +0000 (11:22 +0000)]
Support C++11 features in GCC <4.6
https://bugs.webkit.org/show_bug.cgi?id=111553

Reviewed by Simon Hausmann.

Enable support for rvalue references from gcc 4.3, deleted functions
from gcc 4.4, explicit conversion from gcc 4.5, and strongly typed
enums from gcc 4.6.

* wtf/Compiler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd support for convenient conversion from JSStringRef to QString
hausmann@webkit.org [Wed, 13 Mar 2013 10:14:50 +0000 (10:14 +0000)]
Add support for convenient conversion from JSStringRef to QString
https://bugs.webkit.org/show_bug.cgi?id=109694

Reviewed by Allan Sandfeld Jensen.

Add JSStringCopyQString helper function that allows for the convenient
extraction of a QString out of a JSStringRef.

* API/JSStringRefQt.cpp: Added.
(JSStringCopyQString):
* API/JSStringRefQt.h: Added.
* API/OpaqueJSString.h:
(OpaqueJSString):
(OpaqueJSString::qString):
(OpaqueJSString::OpaqueJSString):
* Target.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Unskip now passing compositing tests.
kadam@inf.u-szeged.hu [Wed, 13 Mar 2013 09:58:27 +0000 (09:58 +0000)]
[Qt] Unreviewed gardening. Unskip now passing compositing tests.

* platform/qt-5.0-wk1/TestExpectations:
* platform/qt-5.0-wk2/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Layout Test fast/repaint/japanese-rl-selection-repaint-in-regions.html...
mihnea@adobe.com [Wed, 13 Mar 2013 09:38:06 +0000 (09:38 +0000)]
[chromium] Layout Test fast/repaint/japanese-rl-selection-repaint-in-regions.html is failing
https://bugs.webkit.org/show_bug.cgi?id=106097

Reviewed by Tony Chang.

After http://trac.webkit.org/changeset/138785, the content overflowing the last region in chain is
displayed properly in vertical-rl writing mode. This determined the failure of japanese-rl-selection-repaint-in-regions.html
test due to the overflowing content that now appears when rendered.

I modified the original test by decreasing the font size so that the content is not overflowing, because the purpose
of the original test was not to check the overflowed content anyway. I have generated new expected results for mac and chromium
and unskipped the test on chromium and mac.

* fast/repaint/japanese-rl-selection-repaint-in-regions.html:
* platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
* platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
* platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
* platform/chromium/TestExpectations:
* platform/chromium/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
* platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
* platform/mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
* platform/mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
* platform/mac/TestExpectations:
* platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPass the XSSAuditor's report URL to the XSSAuditorDelegate on the main thread.
mkwst@chromium.org [Wed, 13 Mar 2013 09:32:25 +0000 (09:32 +0000)]
Pass the XSSAuditor's report URL to the XSSAuditorDelegate on the main thread.
https://bugs.webkit.org/show_bug.cgi?id=112179

Reviewed by Adam Barth.

Rather than relying on XSSInfo objects to move the XSSAuditor's report
URL into the XSSAuditorDelegate for reporting, we should be able to grab
the URL directly from XSSAuditor before it moves off the main thread,
and store it on the delegate.

This will enable us to drop the report URL properties from both
XSSAuditor and XSSInfo. Oh, happy day!

* html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::sendTokensToMainThread):
    We no longer need to check whether XSSInfo objects are thread safe,
    as we've dropped the only problematic bit.
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::startBackgroundParser):
* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::init):
    When initializing the XSSAuditor, pass in an XSSAuditorDelegate*
    and assign the report URL directly onto that object.
(WebCore::XSSAuditor::filterToken):
    Drop the report URL parameter from XSSInfo objects we create in the
    Auditor, as they're now handled directly from the delegate.
(WebCore::XSSAuditor::isSafeToSendToAnotherThread):
    Drop the report URL property from XSSAuditor's threadsafeness check,
    as properties that do not exist are automatically thread-safe.
* html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSAuditorDelegate::didBlockScript):
    Use the delegate's own report URL rather than the XSSInfo objects'.
* html/parser/XSSAuditorDelegate.h:
(WebCore::XSSInfo::create):
(WebCore::XSSInfo::XSSInfo):
    Drop the report URL property from XSSInfo.
(WebCore::XSSAuditorDelegate::setReportURL):
(XSSAuditorDelegate):
    Provide a public API for setting a delegate's report URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] http/tests/websocket/tests/hybi/close-on-navigate-new-location.html is failing
ch.dumez@sisa.samsung.com [Wed, 13 Mar 2013 09:26:39 +0000 (09:26 +0000)]
[EFL] http/tests/websocket/tests/hybi/close-on-navigate-new-location.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112231

Reviewed by Kentaro Hara.

close-on-navigate-new-location.html tests that the websocket is closed when navigating
to a new location (handler_map.txt). However, handler_map.txt does not exist so we get
an HTTP 404 error and we end up not navigating. This patch fixes the navigation path
to "../handler_map.txt" since the file is actually in the parent folder.

* http/tests/websocket/tests/hybi/close-on-navigate-new-location.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145694 268f45cc-cd09-0410-ab3c-d52691b4dbfc