WebKit-https.git
6 years agoA lot of code duplication within StringImpl 'equal' functions
mikhail.pozdnyakov@intel.com [Fri, 5 Jul 2013 17:25:08 +0000 (17:25 +0000)]
A lot of code duplication within StringImpl 'equal' functions
https://bugs.webkit.org/show_bug.cgi?id=118415

Reviewed by Anders Carlsson.

There has been a lot of code duplication within StringImpl 'equal' functions:
the whole logic was copied to every overloaded 'equal' function.
Fixed now using templates and std::equal.

* wtf/text/StringImpl.cpp:
(WTF::equalInternal):
(WTF::equal):
* wtf/text/StringImpl.h:
(WTF::arraysEqual):
(WTF::equal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Update TestExpectations with crashing and failing tests
mario@webkit.org [Fri, 5 Jul 2013 16:35:48 +0000 (16:35 +0000)]
[GTK] Update TestExpectations with crashing and failing tests
https://bugs.webkit.org/show_bug.cgi?id=118424

Unreviewed GTK gardening.

Updated TestExpectations with tests crashing and failing.

Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-05

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSegmentation fault occurred when ICU data library doesn't embed the expected encoding.
commit-queue@webkit.org [Fri, 5 Jul 2013 15:02:22 +0000 (15:02 +0000)]
Segmentation fault occurred when ICU data library doesn't embed the expected encoding.
https://bugs.webkit.org/show_bug.cgi?id=118410

Patch by Benjamin Dupont <bdupont@nds.com> on 2013-07-05
Reviewed by Allan Sandfeld Jensen.

* platform/text/TextEncodingRegistry.cpp:
(WebCore::newTextCodec):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove code duplication from StringImpl create()/reallocate() methods
mikhail.pozdnyakov@intel.com [Fri, 5 Jul 2013 11:23:44 +0000 (11:23 +0000)]
Remove code duplication from StringImpl create()/reallocate() methods
https://bugs.webkit.org/show_bug.cgi?id=118355

Reviewed by Andreas Kling.

StringImpl create()/reallocate() methods accepting LChar and UChar used to have
duplicated code. The code duplication is removed now via used templates.

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::constructInternal):
(WTF::LChar):
(WTF::StringImpl::createUninitializedInternal):
(WTF::StringImpl::createUninitialized):
(WTF::StringImpl::reallocateInternal):
(WTF::StringImpl::reallocate):
(WTF::StringImpl::createInternal):
(WTF::StringImpl::create):
* wtf/text/StringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Implement unit test callbacks: onWordLearn and onWordIgnore.
commit-queue@webkit.org [Fri, 5 Jul 2013 10:29:12 +0000 (10:29 +0000)]
[EFL][WK2] Implement unit test callbacks: onWordLearn and onWordIgnore.
https://bugs.webkit.org/show_bug.cgi?id=118392

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-07-05
Reviewed by Christophe Dumez.

Simulate behavior of Learn and Ignore Word in the text field.

* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::mouseDoubleClick):
Select the entire word in the text field.

* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
* UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
(onSpellingForKnownWord):
(onWordLearn):
(onWordIgnore):
(selectLearnSpelling):
(selectIgnoreSpelling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[New multicol] Change test to follow the pattern of the other tests
commit-queue@webkit.org [Fri, 5 Jul 2013 10:26:42 +0000 (10:26 +0000)]
[New multicol] Change test to follow the pattern of the other tests
https://bugs.webkit.org/show_bug.cgi?id=117698

Patch by Mihai Maerean <mmaerean@adobe.com> on 2013-07-05
Reviewed by Andreas Kling.

Test is a ref test against the old multicol code, like all the other tests in LayoutTests/fast/multicol/newmulticol/
This is a follow up of bug 116614, testing that flow threads don't end up being cloned in region based multi
columns with columns:1 where the only child has column-span:all.

* fast/multicol/newmulticol/direct-child-column-span-all-expected.html: Added.
* fast/multicol/newmulticol/direct-child-column-span-all-expected.txt: Removed.
* fast/multicol/newmulticol/direct-child-column-span-all.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent glib
commit-queue@webkit.org [Fri, 5 Jul 2013 10:13:47 +0000 (10:13 +0000)]
[GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent glib
https://bugs.webkit.org/show_bug.cgi?id=111434

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-07-05
Reviewed by Carlos Garcia Campos.

Source/WebKit2:

* UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:
(testNotInitialized):
(testSetDirectory):
(testClearDatabase):
(testGetFavicon):
(testGetFaviconURI): Removed gconstpointer parameter.
(testWebViewFavicon): Fixed to make it work together with the
other tests and removed gconstpointer parameter.
(testFaviconDatabase): Created to call all tests in the proper
order.
(beforeAll): Changed to call only testFaviconDatabase instead of
the separate tests.

Tools:

* Scripts/run-gtk-tests:
(TestRunner): Unskipped TestWebKitFaviconDatabase tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] fast/text/font-kerning.html fails
commit-queue@webkit.org [Fri, 5 Jul 2013 08:52:35 +0000 (08:52 +0000)]
[GTK] fast/text/font-kerning.html fails
https://bugs.webkit.org/show_bug.cgi?id=76048

Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-07-05
Reviewed by Martin Robinson.

Added kerning to the list of features for hb_shade() according to FontDescription::kerning().
Removed font-kerning.html from gtk/TestExpectations, which was failing before this fix.

Source/WebCore:

* platform/graphics/harfbuzz/HarfBuzzFace.cpp:
(WebCore):
* platform/graphics/harfbuzz/HarfBuzzFace.h:
(HarfBuzzFace):
* platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::setFontFeatures):

LayoutTests:

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTestWebKitFaviconDatabase/clear-database is not testing things properly
commit-queue@webkit.org [Fri, 5 Jul 2013 08:41:34 +0000 (08:41 +0000)]
TestWebKitFaviconDatabase/clear-database is not testing things properly
https://bugs.webkit.org/show_bug.cgi?id=118404

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-07-05
Reviewed by Carlos Garcia Campos.

* UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:
(testClearDatabase): Check for an existing icon that can make the
test fail if clear database is not working.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix GTK after r152404.
ch.dumez@sisa.samsung.com [Fri, 5 Jul 2013 07:36:43 +0000 (07:36 +0000)]
Build fix GTK after r152404.
https://bugs.webkit.org/show_bug.cgi?id=118407

Patch by Gwang Yoon Hwang <ryumiel@company100.net> on 2013-07-05
Reviewed by Christophe Dumez.

* GNUmakefile.list.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] DumpRenderTree doesn't run if "opengl_x11" engine is not available
commit-queue@webkit.org [Fri, 5 Jul 2013 06:53:30 +0000 (06:53 +0000)]
[EFL] DumpRenderTree doesn't run if "opengl_x11" engine is not available
https://bugs.webkit.org/show_bug.cgi?id=118370

Patch by Viatcheslav Ostapenko <sl.ostapenko@samsung.com> on 2013-07-04
Reviewed by Christophe Dumez.

Add fallback to software X11 engine if opengl_x11 engine creation fails.

* DumpRenderTree/efl/DumpRenderTree.cpp:
(initEcoreEvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPaint the page background if we haven't received our first update
andersca@apple.com [Thu, 4 Jul 2013 21:17:40 +0000 (21:17 +0000)]
Paint the page background if we haven't received our first update
https://bugs.webkit.org/show_bug.cgi?id=118402
<rdar://problem/13893308>

Reviewed by Simon Fraser.

Make sure that we always paint something when we haven't received our first update from the web process.

* UIProcess/API/mac/WKView.mm:
(-[WKView drawRect:]):
* UIProcess/DrawingAreaProxyImpl.h:
(WebKit::DrawingAreaProxyImpl::hasReceivedFirstUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a method to get unreachable URL from WebFrame.
commit-queue@webkit.org [Thu, 4 Jul 2013 19:53:19 +0000 (19:53 +0000)]
Add a method to get unreachable URL from WebFrame.
https://bugs.webkit.org/show_bug.cgi?id=118399

Normally we could use [[WebFrame dataSource] unreachableURL] to get the failed URL.  However, if the frame has not
loaded (FrameLoader::frameHasLoaded() is false), we will get a nil dataSource and we won't be able to get unreachableURL.
We can add a method to always return the unreachableURL regardless if the frame has loaded or not.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-07-04
Reviewed by Dan Bernstein.

* WebView/WebFrame.mm:
(-[WebFrame _unreachableURL]):
* WebView/WebFramePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoHave SVGTextContentElement inherit SVGGraphicsElement
ch.dumez@sisa.samsung.com [Thu, 4 Jul 2013 18:48:51 +0000 (18:48 +0000)]
Have SVGTextContentElement inherit SVGGraphicsElement
https://bugs.webkit.org/show_bug.cgi?id=118351

Reviewed by Dirk Schulze.

Source/WebCore:

Have SVGTextContentElement inherit SVGGraphicsElement instead of
SVGStyledElement in order to match the latest SVG2 specification:
https://svgwg.org/svg2-draft/text.html#InterfaceSVGTextContentElement

This patch also removes the SVGTransformable and SVGLocatable IDL
interfaces as they are no longer needed (were merged into
SVGGraphicsElement in the latest specification).

This is one step towards getting rid of multiple inheritance in
SVG, and complying with the latest SVG2 specification.

No new tests, covered by existing tests.

* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/scripts/CodeGeneratorJS.pm:
(GetGnuVTableOffsetForType):
* bindings/scripts/CodeGeneratorObjC.pm:
* svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::hasValidAttributeType):
* svg/SVGElement.cpp:
(WebCore::SVGElement::getBoundingBox):
* svg/SVGLocatable.idl: Removed.
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::SVGTextContentElement):
(WebCore::SVGTextContentElement::isSupportedAttribute):
(WebCore::SVGTextContentElement::isPresentationAttribute):
(WebCore::SVGTextContentElement::collectStyleForPresentationAttribute):
(WebCore::SVGTextContentElement::parseAttribute):
(WebCore::SVGTextContentElement::svgAttributeChanged):
* svg/SVGTextContentElement.h:
* svg/SVGTextContentElement.idl:
* svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::SVGTextElement):
(WebCore::SVGTextElement::animatedLocalTransform):
* svg/SVGTextElement.h:
* svg/SVGTextElement.idl:
* svg/SVGTransformable.idl: Removed.

LayoutTests:

Fix conversion to absolute (user agent) coordinates in the svg/text
tests to use SVGGraphicsElement::getScreenCTM() instead of
SVGGraphicsElement::getTransformToElement(). The previous code was
working until now due to a bug in getTransformToElement(), which
was not taking into consideration the CTM of the SVGTextElement (as
it was not recognized as a "locatable" element). Now that
SVGTextElement inherits from SVGGraphicsElement, it is properly
recognized as a "locatable" element by getTransformToElement().

* svg/text/resources/SelectionTestCase.js:
(toAbsoluteCoordinates):
* svg/text/selection-doubleclick.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCrash when createPluginInternal ends up destroying the plug-in
andersca@apple.com [Thu, 4 Jul 2013 18:42:16 +0000 (18:42 +0000)]
Crash when createPluginInternal ends up destroying the plug-in
https://bugs.webkit.org/show_bug.cgi?id=118397
<rdar://problem/14155051>

Reviewed by Simon Fraser.

Keep the WebProcessConnection object alive while calling createPluginInternal and handle
the IPC connection going away.

* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::createPluginAsynchronously):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove PageThrottler::m_activeThrottleBlockers
barraclough@apple.com [Thu, 4 Jul 2013 18:00:01 +0000 (18:00 +0000)]
Remove PageThrottler::m_activeThrottleBlockers
https://bugs.webkit.org/show_bug.cgi?id=118375

Reviewed by Mark Rowe.

This is simply m_activityTokens.size().

Also, fold preventThrottling into addActivityToken & allowThrottling into removeActivityToken
(these should no longer be called directly, and should not be public).

* page/PageThrottler.cpp:
(WebCore::PageThrottler::PageThrottler):
    - removed m_activeThrottleBlockers
(WebCore::PageThrottler::startThrottleHysteresisTimer):
    - m_activeThrottleBlockers -> m_activityTokens.size()
(WebCore::PageThrottler::throttleHysteresisTimerFired):
    - m_activeThrottleBlockers -> m_activityTokens.size()
(WebCore::PageThrottler::addActivityToken):
    - added functionality from preventThrottling
(WebCore::PageThrottler::removeActivityToken):
    - added functionality from allowThrottling
* page/PageThrottler.h:
    - removed preventThrottling, allowThrottling, and m_activeThrottleBlockers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTake document height into account when determining when it is considered visually...
antti@apple.com [Thu, 4 Jul 2013 15:51:44 +0000 (15:51 +0000)]
Take document height into account when determining when it is considered visually non-empy
https://bugs.webkit.org/show_bug.cgi?id=118272

Reviewed by Darin Adler.

The current visually non-empy mechanism takes into account only the amount of contents in renderers.
Add a simple layout dependency so that we don't consider page non-empty until the document height
exceed a (low) height threshold (or the load completes).

* page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):

    Don't send layout callbacks until we have actually some content.

(WebCore::FrameView::qualifiesAsVisuallyNonEmpty):
(WebCore::FrameView::updateIsVisuallyNonEmpty):

    Factor into functions.

* page/FrameView.h:
(WebCore::FrameView::incrementVisuallyNonEmptyCharacterCount):
(WebCore::FrameView::incrementVisuallyNonEmptyPixelCount):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
* rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::RenderHTMLCanvas):

     The size is not known but the estimate provided here is always bigger than the threshold so
     the functionality is unchanged.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix after r152399.
ch.dumez@sisa.samsung.com [Thu, 4 Jul 2013 15:33:32 +0000 (15:33 +0000)]
Unreviewed build fix after r152399.

Add missing header include for SVGNames.h.

* svg/SVGImageElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoChange static_cast<SVGImageElement*> with toSVGImageElement
gyuyoung.kim@samsung.com [Thu, 4 Jul 2013 13:58:13 +0000 (13:58 +0000)]
Change static_cast<SVGImageElement*> with toSVGImageElement
https://bugs.webkit.org/show_bug.cgi?id=118387

Reviewed by Andreas Kling.

As a step to change static_cast with toXXX, static_cast<SVGImageElement*> can
be changed with toSVGImageElement().

Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=153557

* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::updateImageViewport):
(WebCore::RenderSVGImage::layout):
(WebCore::RenderSVGImage::paintForeground):
* svg/SVGImageElement.h:
(WebCore::toSVGImageElement):
* svg/SVGImageLoader.cpp:
(WebCore::SVGImageLoader::dispatchLoadEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Leak: Free PangoFontDescription* in RenderThemeGtk3
commit-queue@webkit.org [Thu, 4 Jul 2013 13:18:13 +0000 (13:18 +0000)]
[GTK] Leak: Free PangoFontDescription* in RenderThemeGtk3
https://bugs.webkit.org/show_bug.cgi?id=118386

Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-04
Reviewed by Carlos Garcia Campos.

Free PangoFontDescription* allocated by gtk_style_context_get (transfer full).

* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::spinButtonArrowSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[ATK] Leak: AtkAttributeSet* should be freed
commit-queue@webkit.org [Thu, 4 Jul 2013 12:10:45 +0000 (12:10 +0000)]
[ATK] Leak: AtkAttributeSet* should be freed
https://bugs.webkit.org/show_bug.cgi?id=118307

Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-04
Reviewed by Christophe Dumez.

Source/WebCore:

Use AtkAttributeSet* instead of GSList*.

* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetObjectLocale):

Tools:

Fixed memory leaks for AtkAttributeSet by calling
atk_attribute_set_free().

* DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
(AccessibilityController::childElementById):
* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(getAtkAttributeSetAsString):
(AccessibilityUIElement::allAttributes):
(AccessibilityUIElement::stringAttributeValue):
* WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
(WTR::childElementById):
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::getAtkAttributeSetAsString):
(WTR::AccessibilityUIElement::allAttributes):
(WTR::AccessibilityUIElement::stringAttributeValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[ATK] Do not expose '\n' for wrapped lines with ATK_TEXT_BOUNDARY_CHAR
mario@webkit.org [Thu, 4 Jul 2013 10:03:42 +0000 (10:03 +0000)]
[ATK] Do not expose '\n' for wrapped lines with ATK_TEXT_BOUNDARY_CHAR
https://bugs.webkit.org/show_bug.cgi?id=118359

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Do not expose a '\n' character for every visual line break.

* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetChar): Removed wrong code.

Source/WebKit/gtk:

Added new unit test to make sure we exposed line breaks properly.

* tests/testatk.c:
(testWebkitAtkGetTextAtOffsetWithWrappedLines): New unit test.
(main): Added new test to the test suite.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CMake] Add generation of JITStubs for x86_64 MSVC
paroga@webkit.org [Thu, 4 Jul 2013 09:12:31 +0000 (09:12 +0000)]
[CMake] Add generation of JITStubs for x86_64 MSVC
https://bugs.webkit.org/show_bug.cgi?id=116666

Reviewed by Laszlo Gombos.

Also move the generation for ARM CPU into the CMakeLists.txt,
since it's compiler specific and not dedicated to Windows CE.

* CMakeLists.txt:
* PlatformWinCE.cmake: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Gardening. Unskip tests related with editing
commit-queue@webkit.org [Thu, 4 Jul 2013 09:05:05 +0000 (09:05 +0000)]
[EFL] Gardening. Unskip tests related with editing
https://bugs.webkit.org/show_bug.cgi?id=118379

Unreviewed gardening.

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2013-07-04

* platform/efl-wk2/TestExpectations:
  Unskip editing/selection/doubleclick-beside-cr-span.html and
  editing/selection/doubleclick-whitespace.html, which are passed after r150289
* platform/efl/editing/style/5065910-expected.txt: Removed (wrong expected result).
* platform/efl/editing/style/5065910-expected.png: Removed (wrong expected result).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CMake] Add STATICALLY_LINKED_WITH_WTF to JavaScriptCore project
paroga@webkit.org [Thu, 4 Jul 2013 08:52:31 +0000 (08:52 +0000)]
[CMake] Add STATICALLY_LINKED_WITH_WTF to JavaScriptCore project
https://bugs.webkit.org/show_bug.cgi?id=118120

Reviewed by Gyuyoung Kim.

Since WTF is a static library linked to JavaScriptCore on all CMake ports
we need to define STATICALLY_LINKED_WITH_WTF for all of them.
This makes only a difference for Windows, since WTF_EXPORT and WTF_IMPORT
are the same on all other platforms.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPort FileSystemWin.cpp to WinCE
paroga@webkit.org [Thu, 4 Jul 2013 08:08:22 +0000 (08:08 +0000)]
Port FileSystemWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=117935

Reviewed by Brent Fulgham.

Add #if !OS(WINCE) around a few lines of the code, so it can be used by the WinCE port too.

* PlatformWinCE.cmake:
* platform/win/FileSystemWin.cpp:
(WebCore::storageDirectory):
* platform/wince/FileSystemWinCE.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GStreamer] support preload="metadata"
kbalazs@webkit.org [Thu, 4 Jul 2013 07:44:16 +0000 (07:44 +0000)]
[GStreamer] support preload="metadata"
https://bugs.webkit.org/show_bug.cgi?id=116817

Reviewed by Eric Carlson.

Source/WebCore:

Add appropriate behavior for preload="metadata". Delay enabling download buffering
until playback is started in this case. This behavior fits with the standard quite
well and this is the most exact match we can get (at least without adding too much
extra complexity). What matters mostly is that we can avoid loading the media
before playback but we have the first frame and the metadata.

Test: media/video-load-preload-metadata.html

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::prepareToPlay): Set |m_preload| to |Auto|
so we will start download buffering if we did not start it yet.
(WebCore::MediaPlayerPrivateGStreamer::play): Ditto.
(MediaPlayerPrivateGStreamer::setDownloadBuffering): Only start download
buffering if |m_preload == Auto|. Also make sure we don't clear the download
flag once we started downloading because it would result in not well defined
behavior and it does not really makes sense.
(MediaPlayerPrivateGStreamer::setPreload): Set download buffering accordingly.

LayoutTests:

* media/video-load-preload-metadata.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Coordinated Graphics] Don't use && operator in ASSERT
commit-queue@webkit.org [Thu, 4 Jul 2013 06:44:59 +0000 (06:44 +0000)]
[Coordinated Graphics] Don't use && operator in ASSERT
https://bugs.webkit.org/show_bug.cgi?id=118377

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-07-03
Reviewed by Noam Rosenthal.

We don't use && opeartor in ASSERT because it's impossible to know which
condition caused the assertion.

* platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp:
(WebCore::CoordinatedBackingStoreTile::swapBuffers):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Support some more editing keyboard events
commit-queue@webkit.org [Thu, 4 Jul 2013 06:20:33 +0000 (06:20 +0000)]
[EFL] Support some more editing keyboard events
https://bugs.webkit.org/show_bug.cgi?id=118346

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2013-07-03
Reviewed by Gyuyoung Kim.

For editable contents, support the shortcuts for copy, page, cut, select all, undo and redo.

* platform/efl/EflKeyboardUtilities.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: Items the img aria role aren't inserting an object replacement character
cfleizach@apple.com [Thu, 4 Jul 2013 05:28:03 +0000 (05:28 +0000)]
AX: Items the img aria role aren't inserting an object replacement character
https://bugs.webkit.org/show_bug.cgi?id=118259

Source/WebCore:

Reviewed by Tim Horton.

VoiceOver relies on object replacement characters being emitted when asking for selected text.
This has worked if a real <img> is used, but if role="img" is used on a <div>, for example,
no emission is performed, which leads to missed elements in text.

Test: platform/mac/accessibility/aria-image-emits-object-replacement.html

* editing/TextIterator.cpp:
(WebCore::isRendererReplacedElement):
(WebCore::TextIterator::advance):

LayoutTests:

Reviewed by Reviewed by Tim Horton.

* accessibility/non-native-image-crash-expected.txt:
* platform/mac/accessibility/aria-image-emits-object-replacement-expected.txt: Added.
* platform/mac/accessibility/aria-image-emits-object-replacement.html: Added.
* platform/mac/accessibility/img-fallsback-to-title-expected.txt:
     Update expected tests where role="img" now emits replacement character.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdopt is/toHTMLMapElement for code cleanup
kangil.han@samsung.com [Thu, 4 Jul 2013 04:31:30 +0000 (04:31 +0000)]
Adopt is/toHTMLMapElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118235

Reviewed by Andreas Kling.

To enhance readability, this patch adopts is/toHTMLMapElement.
This also helps out to reduce duplicated use of static_cast.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getDocumentLinks):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
* dom/DocumentOrderedMap.cpp:
(WebCore::keyMatchesMapName):
(WebCore::keyMatchesLowercasedMapName):
* dom/TreeScope.cpp:
(WebCore::TreeScope::getImageMap):
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::imageElement):
* html/HTMLMapElement.h:
(WebCore::isHTMLMapElement):
(WebCore::toHTMLMapElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Unreviewed build correction after r15283.
bfulgham@apple.com [Thu, 4 Jul 2013 00:47:04 +0000 (00:47 +0000)]
[Windows] Unreviewed build correction after r15283.

* WebCorePrefix.h: Remove include directive for CGFloat.h, as it
is not present in all Windows build environments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Exclude unsupported QuartzCore Features.
bfulgham@apple.com [Thu, 4 Jul 2013 00:39:44 +0000 (00:39 +0000)]
[Windows] Exclude unsupported QuartzCore Features.
https://bugs.webkit.org/show_bug.cgi?id=118374

Reviewed by Anders Carlsson.

* WebCore.vcxproj/WebCoreCG.props: Exclude a few non-Windows
concepts from the QuartzCore headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSimplify PageThrottler ownership.
barraclough@apple.com [Thu, 4 Jul 2013 00:03:10 +0000 (00:03 +0000)]
Simplify PageThrottler ownership.
https://bugs.webkit.org/show_bug.cgi?id=118372

Reviewed by Sam Weinig.

* page/Page.cpp:
(WebCore::Page::~Page):
    - 'clearPage' method removed - just clear the own pointer.
* page/Page.h:
    - make m_pageThrottler an OwnPtr.
* page/PageThrottler.cpp:
(WebCore::PageThrottler::~PageThrottler):
    - moved 'setThrottled(false)' from 'clearPage' (removed).
(WebCore::PageThrottler::throttlePage):
(WebCore::PageThrottler::unthrottlePage):
    - no need to check 'm_page'
* page/PageThrottler.h:
(WebCore::PageThrottler::create):
    - create a PassOwnPtr, not PassRefPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Updates to support changes in CoreGraphics libraries.
bfulgham@apple.com [Thu, 4 Jul 2013 00:01:58 +0000 (00:01 +0000)]
[Windows] Updates to support changes in CoreGraphics libraries.
https://bugs.webkit.org/show_bug.cgi?id=118373

Reviewed by Anders Carlsson.

* WebCorePrefix.h: Include definitions for isnan/round/roundf for versions of
Visual Studio that do not provide them natively.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImplement mechanism to detect (partially) hidden blocked plugins.
commit-queue@webkit.org [Wed, 3 Jul 2013 23:56:23 +0000 (23:56 +0000)]
Implement mechanism to detect (partially) hidden blocked plugins.
https://bugs.webkit.org/show_bug.cgi?id=117998

Patch by Gordon Sheridan <gordon_sheridan@apple.com> on 2013-07-03
Reviewed by Dean Jackson.

Source/WebCore:

* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::replacementTextRect):
Added private method for calculating the size of the replacement text for blocked plugins.

(WebCore::RenderEmbeddedObject::isReplacementObscured):
Added public method to determine if the EMBED element used for a blocked plugin is inaccessible to the user.
* rendering/RenderEmbeddedObject.h:
Declare the two new methods mentioned above.

* WebCore.exp.in:
Export RenderEmbeddedObject::isReplacementObscured().

Source/WebKit2:

* Shared/Plugins/Netscape/PluginInformation.h:
* Shared/Plugins/Netscape/PluginInformation.cpp:
(WebKit::plugInInformationReplacementObscuredKey):
Add key for plugInInformation dictionaries.

(WebKit::createPluginInformationDictionary):
Add boolean parameter identifying whether the replacement for a blocked plugin is obscured, and add it to the dictionary.

* Shared/API/c/WKPluginInformation.h:
* Shared/API/c/WKPluginInformation.cpp:
(WKPluginInformationReplacementObscuredKey):
Provide the C API for the plugInInformationReplacementObscuredKey().

* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):
Add bool replacementObscured parameter to pass on argument to createPluginInformationDictionary().

* UIProcess/WebPageProxy.messages.in:
Add bool replacementObscured parameter to DidBlockInsecurePluginVersion() message.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
Invoke isReplacementObscured() method for blocked plugins.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Unreviewed build correction.
bfulgham@apple.com [Wed, 3 Jul 2013 23:38:27 +0000 (23:38 +0000)]
[Windows] Unreviewed build correction.

* WTF.vcxproj/copy-files.cmd: Limit path (for this file) to DOS-only to avoid
the Cygwin variant of rmdir from being used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGuard remaining calls to decodeURIComponent with a try/catch.
timothy@apple.com [Wed, 3 Jul 2013 23:13:46 +0000 (23:13 +0000)]
Guard remaining calls to decodeURIComponent with a try/catch.

https://bugs.webkit.org/show_bug.cgi?id=118371

Reviewed by Joseph Pecoraro.

* UserInterface/Main.js:
(WebInspector.displayNameForURL):
(WebInspector.updateWindowTitle):
* UserInterface/Utilities.js:
(arrayResult):
(queryString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago <rdar://problem/14271105> Flash Player: deny ipc-posix-sem 59918130
ap@apple.com [Wed, 3 Jul 2013 22:28:42 +0000 (22:28 +0000)]
    <rdar://problem/14271105> Flash Player: deny ipc-posix-sem 59918130
        <rdar://problem/14349560> Flash Player: deny ipc-posix-sem MacromediaSemaphoreDig on many sites

        Reviewed by Sam Weinig.

        * Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:
        semaphore-owner doesn't appear to work the way we need it to, removing it (at least for now).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRan update-webkit-localizable-strings.
jberlin@webkit.org [Wed, 3 Jul 2013 20:19:50 +0000 (20:19 +0000)]
Ran update-webkit-localizable-strings.

Rubber-stamped by Joseph Pecoraro.

* Localizations/en.lproj/localizedStrings.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd Makefile to WebKitLauncher
dfarler@apple.com [Wed, 3 Jul 2013 20:16:07 +0000 (20:16 +0000)]
Add Makefile to WebKitLauncher
https://bugs.webkit.org/show_bug.cgi?id=118365

Reviewed by Mark Rowe.

* WebKitLauncher/Makefile: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[ATK] Leak: more leaks in AccessibilityUIElement
commit-queue@webkit.org [Wed, 3 Jul 2013 18:50:24 +0000 (18:50 +0000)]
[ATK] Leak: more leaks in AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=118362

Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-03
Reviewed by Christophe Dumez.

Free the memory created by g_strdup_printf.

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::language):
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::language):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWebTextCheckerClient doesn't initialize output arguments.
commit-queue@webkit.org [Wed, 3 Jul 2013 18:06:00 +0000 (18:06 +0000)]
WebTextCheckerClient doesn't initialize output arguments.
https://bugs.webkit.org/show_bug.cgi?id=83683

Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-03
Reviewed by Martin Robinson.

Source/WebKit2:

Callers of checkSpellingOfString and checkGrammarOfString expect
certain default values when no misspelled (or bad grammar) string
is found. They try to do that by initialising the reply arguments
that go into the IPC calls, but these values are ultimately ignored (see
HandleMessage.h, where the replyArguments are declared).

In the past, this seems to have led to various issues, (see
TextCheckingHelper::findFirstMisspelling in TextCheckingHelper.cpp),
where these return values are asserted and checked to be in the right range.

This patch initialises the values, so even if no available client
implements the methods (or if the implementation forgets to do it) the callers
will have their expected output.

However, and for a general case, we probably need a way to tell the caller
that any existing value in the output arguments will be ignored.

* UIProcess/WebTextCheckerClient.cpp:
(WebKit::WebTextCheckerClient::checkSpellingOfString):
(WebKit::WebTextCheckerClient::checkGrammarOfString):

LayoutTests:

Unskip editing/pasteboard/pasting-empty-html-falls-back-to-text.html, which no longer
crashes after the fix.

* platform/gtk-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK][WK2] SIGSEV in WebKit::WebPageContextMenuClient::customContextMenuItemSelected
sergio@webkit.org [Wed, 3 Jul 2013 17:35:13 +0000 (17:35 +0000)]
[GTK][WK2] SIGSEV in WebKit::WebPageContextMenuClient::customContextMenuItemSelected
https://bugs.webkit.org/show_bug.cgi?id=116867

Reviewed by Anders Carlsson.

We did not reset the clients on WebPageProxy::close(), so right
clicking on a link after starting the navigation to some other
page was causing crashes because code was trying to access an
already freed m_contextMenuClient.

There were some other clients that could potentially trigger the
same issues. Reset them all to null to prevent this situation.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoXcode often gets in a state where the debugger is completely unresponsive
jer.noble@apple.com [Wed, 3 Jul 2013 17:28:43 +0000 (17:28 +0000)]
Xcode often gets in a state where the debugger is completely unresponsive
https://bugs.webkit.org/show_bug.cgi?id=118157

The GetPointeeData() operations we use to retrieve strings is extremely expensive.
Rather than pull the character data out of the debugger one byte at a time
through the GetPointeeData() API, retrieve the memory contents of the string through
the ReadMemory() API, and convert the retrieved memory into a python string.

Reviewed by Anders Carlsson.

* lldb/lldb_webkit.py:
(__lldb_init_module.lldb_webkit):
(guess_string_length):
(ustring_to_string):
(lstring_to_string):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r152356.
commit-queue@webkit.org [Wed, 3 Jul 2013 17:05:30 +0000 (17:05 +0000)]
Unreviewed, rolling out r152356.
http://trac.webkit.org/changeset/152356
https://bugs.webkit.org/show_bug.cgi?id=118361

Broke JSCore tests (Requested by andersca on #webkit).

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::createUninitialized):
(WTF::StringImpl::reallocate):
(WTF::StringImpl::create):
* wtf/text/StringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoOutput arguments used in IPC calls should be returned initialised
commit-queue@webkit.org [Wed, 3 Jul 2013 16:12:40 +0000 (16:12 +0000)]
Output arguments used in IPC calls should be returned initialised
https://bugs.webkit.org/show_bug.cgi?id=118354

Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-03
Reviewed by Anders Carlsson.

When Download::shouldDecodeSourceDataOfMIMEType and Download::retrieveDestinationWithSuggestedFilename
call DownloadProxy::shouldDecodeSourceDataOfMIMEType and DownloadProxy::decideDestinationWithSuggestedFilename
through IPC, they assume the output arguments result and allowOverwrite have
been initialised.

This patch initialises these arguments also in the unlikely event that a
m_webContext is not available.

* UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::shouldDecodeSourceDataOfMIMEType):
(WebKit::DownloadProxy::decideDestinationWithSuggestedFilename):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove code duplication from StringImpl create()/reallocate() methods
mikhail.pozdnyakov@intel.com [Wed, 3 Jul 2013 15:38:49 +0000 (15:38 +0000)]
Remove code duplication from StringImpl create()/reallocate() methods
https://bugs.webkit.org/show_bug.cgi?id=118355

Reviewed by Anders Carlsson.

StringImpl create()/reallocate() methods accepting LChar and UChar used to have
duplicated code. The code duplication is removed now via used templates.

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::constructInternal):
(WTF::LChar):
(WTF::StringImpl::createUninitializedInternal):
(WTF::StringImpl::createUninitialized):
(WTF::StringImpl::reallocateInternal):
(WTF::StringImpl::reallocate):
(WTF::StringImpl::createInternal):
(WTF::StringImpl::create):
* wtf/text/StringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSpeculative build fix after r152340.
jberlin@webkit.org [Wed, 3 Jul 2013 15:28:28 +0000 (15:28 +0000)]
Speculative build fix after r152340.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2][GTK] Invalid ASSERTs in WebResources loading code
sergio@webkit.org [Wed, 3 Jul 2013 14:52:03 +0000 (14:52 +0000)]
[WK2][GTK] Invalid ASSERTs in WebResources loading code
https://bugs.webkit.org/show_bug.cgi?id=118352

Reviewed by Carlos Garcia Campos.

The WebKitWebView keeps track of the resources being loaded in a
map. A couple of ASSERTs verify that every loaded resource is
stored in that map.

The map that is cleared each time a new load starts so there is a
small chance that we get notifications for resources that
correspond to previous page loads
(and thus are not stored in the map). We should remove the ASSERT
which is not valid anymore.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewGetLoadingWebResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAppend overloading function for isFooElement
kangil.han@samsung.com [Wed, 3 Jul 2013 14:18:34 +0000 (14:18 +0000)]
Append overloading function for isFooElement
https://bugs.webkit.org/show_bug.cgi?id=118334

Reviewed by Antti Koivisto.

Node::hasTagName needs additional isElementNode() check when it is triggered.
So conversion from Element* to Node* in isFooElement should be avoided.
Therefore, to support both Node* and Element* as an argument of isFooElement,
this patch appends overloading inline function.

* css/CSSStyleSheet.cpp:
(WebCore::isAcceptableCSSStyleSheetParent):
* css/StyleScopeResolver.cpp:
(WebCore::StyleScopeResolver::scopeFor):
* dom/Node.cpp:
(WebCore::Node::numberOfScopedHTMLStyleChildren):
* html/HTMLAnchorElement.h:
(WebCore::isHTMLAnchorElement):
* html/HTMLAreaElement.h:
(WebCore::isHTMLAreaElement):
* html/HTMLAudioElement.h:
(WebCore::isHTMLAudioElement):
* html/HTMLFormElement.h:
(WebCore::isHTMLFormElement):
* html/HTMLImageElement.h:
(WebCore::isHTMLImageElement):
* html/HTMLInputElement.h:
(WebCore::isHTMLInputElement):
* html/HTMLLabelElement.h:
(WebCore::isHTMLLabelElement):
* html/HTMLOptGroupElement.h:
(WebCore::isHTMLOptGroupElement):
* html/HTMLOptionElement.h:
(WebCore::isHTMLOptionElement):
* html/HTMLStyleElement.h:
(WebCore::isHTMLStyleElement):
(WebCore::toHTMLStyleElement):
* html/HTMLTextAreaElement.h:
(WebCore::isHTMLTextAreaElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGif: zero filling should use memset instead of setRGBA for every pixel
commit-queue@webkit.org [Wed, 3 Jul 2013 13:54:45 +0000 (13:54 +0000)]
Gif: zero filling should use memset instead of setRGBA for every pixel
https://bugs.webkit.org/show_bug.cgi?id=118350

Patch by Balazs Kelemen <b.kelemen@samsung.com> on 2013-07-03
Reviewed by Allan Sandfeld Jensen.

No new tests. Actually it is not covered by existing tests. Surprisingly we haven't got pixel
tests for animated images. Given that this patch is pretty trivial I don't think it's worth the
cost to start introducing such tests.
I added a manual test: animated-gif-dispose-background.html.

GIFImageDecoder::initializeFrameBuffer use a loop to fill a subrect with tranparent pixels.
This is extremely ineffecient. The use case for this code path is not frequent on the web
but it's still better to fix it.

* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageFrame::zeroFillFrameRect):
* platform/image-decoders/ImageDecoder.h:
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::initFrameBuffer):
Fixed indentation in addition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTextureUnit code optimization
commit-queue@webkit.org [Wed, 3 Jul 2013 12:59:55 +0000 (12:59 +0000)]
TextureUnit code optimization
https://bugs.webkit.org/show_bug.cgi?id=117868

Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2013-07-03
Reviewed by Noam Rosenthal.

According to OpenGL ES 2.0 specification it is not possible to use both
texture2D and textureCubeMap in one texture unit.
This patch reduces amount of code, slightly increases rendering performance
and makes WebKit more consistent with OpenGL.

No new tests. Covered by existing tests:
LayoutTests/webgl/conformance/textures/tex-image-webgl.html
LayoutTests/webgl/conformance/textures/texture-complete.html

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::~WebGLRenderingContext):
(WebCore::WebGLRenderingContext::reshape):
(WebCore::WebGLRenderingContext::bindTexture):
(WebCore::WebGLRenderingContext::deleteTexture):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::handleNPOTTextures):
(WebCore::WebGLRenderingContext::validateTextureBinding):
(WebCore::WebGLRenderingContext::restoreCurrentTexture2D):
* html/canvas/WebGLRenderingContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoStop inheriting SVGFilterPrimitiveStandardAttributes in SVG
ch.dumez@sisa.samsung.com [Wed, 3 Jul 2013 10:50:17 +0000 (10:50 +0000)]
Stop inheriting SVGFilterPrimitiveStandardAttributes in SVG
https://bugs.webkit.org/show_bug.cgi?id=118305

Reviewed by Kentaro Hara.

Stop inheriting SVGFilterPrimitiveStandardAttributes in SVG and use
Web IDL implements instead to get rid of multiple inheritance and
follow the latest specification:
- http://www.w3.org/TR/filter-effects/#DOMInterfaces

No new tests, no behavior change.

* CMakeLists.txt:
* DerivedSources.pri:
* GNUmakefile.list.am:
* svg/SVGFEBlendElement.idl:
* svg/SVGFEColorMatrixElement.idl:
* svg/SVGFEComponentTransferElement.idl:
* svg/SVGFECompositeElement.idl:
* svg/SVGFEConvolveMatrixElement.idl:
* svg/SVGFEDiffuseLightingElement.idl:
* svg/SVGFEDisplacementMapElement.idl:
* svg/SVGFEDropShadowElement.idl:
* svg/SVGFEFloodElement.idl:
* svg/SVGFEGaussianBlurElement.idl:
* svg/SVGFEImageElement.idl:
* svg/SVGFEMergeElement.idl:
* svg/SVGFEMorphologyElement.idl:
* svg/SVGFEOffsetElement.idl:
* svg/SVGFESpecularLightingElement.idl:
* svg/SVGFETileElement.idl:
* svg/SVGFETurbulenceElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix cast-align warnings in FastMalloc.cpp
ossy@webkit.org [Wed, 3 Jul 2013 10:19:14 +0000 (10:19 +0000)]
Fix cast-align warnings in FastMalloc.cpp
https://bugs.webkit.org/show_bug.cgi?id=117991

Reviewed by Mark Hahnenberg.

* wtf/FastMalloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoH&R Block 2010 Help window can not be reopened.
commit-queue@webkit.org [Wed, 3 Jul 2013 10:13:34 +0000 (10:13 +0000)]
H&R Block 2010 Help window can not be reopened.
https://bugs.webkit.org/show_bug.cgi?id=118342

Patch by Zalan Bujtas <zalan@apple.com> on 2013-07-03
Reviewed by Antti Koivisto.

http://trac.webkit.org/changeset/118916 changed the window.focus() behaviour so that
only the opener can (re)focus() a particular window.
H&R Block app relies on the relaxed window.focus() rules.

Source/WebCore:

* WebCore.exp.in:
* platform/RuntimeApplicationChecks.cpp:
(WebCore::applicationIsHRBlock):
* platform/RuntimeApplicationChecks.h:

Source/WebKit/mac:

* WebView/WebView.mm:
(shouldRestrictWindowFocus):
(-[WebView _preferencesChanged:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFurther build fixing for build configurations that disable CSS regions support.
zandobersek@gmail.com [Wed, 3 Jul 2013 10:06:14 +0000 (10:06 +0000)]
Further build fixing for build configurations that disable CSS regions support.

* dom/PseudoElement.h: Wrap shouldMoveToFlowThread override into the ENABLE(CSS_REGIONS) build guard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix after r152320 and r152345 for build configurations that enable
zandobersek@gmail.com [Wed, 3 Jul 2013 10:00:59 +0000 (10:00 +0000)]
Unreviewed build fix after r152320 and r152345 for build configurations that enable
SVG support but disable CSS regions support.

* svg/SVGElement.cpp: Wrap shouldMoveToFlowThread override into the ENABLE(CSS_REGIONS) build guard.
* svg/SVGElement.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] Improve implementation of elements in region being flowed to another...
ossy@webkit.org [Wed, 3 Jul 2013 09:02:43 +0000 (09:02 +0000)]
[CSS Regions] Improve implementation of elements in region being flowed to another flow thread
https://bugs.webkit.org/show_bug.cgi?id=118300

Based on patch by Zoltán Árvai <zarvai@inf.u-szeged.hu>

Patch by Radu Stavila <stavila@adobe.com> on 2013-07-03
Reviewed by Csaba Osztrogonác.

Fixed CSS_REGIONS guard.

* dom/Element.h:
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::elementInsideRegionNeedsRenderer):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Migrate WebKitWebContext to GTask
carlosgc@webkit.org [Wed, 3 Jul 2013 08:43:41 +0000 (08:43 +0000)]
[GTK] Migrate WebKitWebContext to GTask
https://bugs.webkit.org/show_bug.cgi?id=117153

Reviewed by Gustavo Noronha Silva.

* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextGetPluginThread):
(webkit_web_context_get_plugins):
(webkit_web_context_get_plugins_finish):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove SVGTests attributes parsing to SVGGraphicsElement
ch.dumez@sisa.samsung.com [Wed, 3 Jul 2013 08:03:53 +0000 (08:03 +0000)]
Move SVGTests attributes parsing to SVGGraphicsElement
https://bugs.webkit.org/show_bug.cgi?id=118292

Reviewed by Darin Adler.

Move SVGTests attributes parsing to SVGGraphicsElement instead of doing
this in each of its subclasses. SVGGraphicsElement is now the one
subclassing SVGTests after r152167.

No new tests, no behavior change.

* svg/SVGAElement.cpp:
(WebCore::SVGAElement::isSupportedAttribute):
(WebCore::SVGAElement::parseAttribute):
* svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::isSupportedAttribute):
(WebCore::SVGCircleElement::parseAttribute):
(WebCore::SVGCircleElement::svgAttributeChanged):
* svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::isSupportedAttribute):
(WebCore::SVGClipPathElement::parseAttribute):
* svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::isSupportedAttribute):
(WebCore::SVGEllipseElement::parseAttribute):
(WebCore::SVGEllipseElement::svgAttributeChanged):
* svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::isSupportedAttribute):
(WebCore::SVGForeignObjectElement::parseAttribute):
(WebCore::SVGForeignObjectElement::svgAttributeChanged):
* svg/SVGGElement.cpp:
(WebCore::SVGGElement::isSupportedAttribute):
(WebCore::SVGGElement::parseAttribute):
(WebCore::SVGGElement::svgAttributeChanged):
* svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::isSupportedAttribute):
(WebCore::SVGGraphicsElement::parseAttribute):
(WebCore::SVGGraphicsElement::svgAttributeChanged):
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::isSupportedAttribute):
(WebCore::SVGImageElement::parseAttribute):
(WebCore::SVGImageElement::svgAttributeChanged):
* svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::isSupportedAttribute):
(WebCore::SVGLineElement::parseAttribute):
(WebCore::SVGLineElement::svgAttributeChanged):
* svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::isSupportedAttribute):
(WebCore::SVGPathElement::parseAttribute):
(WebCore::SVGPathElement::svgAttributeChanged):
* svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::isSupportedAttribute):
(WebCore::SVGPolyElement::parseAttribute):
(WebCore::SVGPolyElement::svgAttributeChanged):
* svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::isSupportedAttribute):
(WebCore::SVGRectElement::parseAttribute):
(WebCore::SVGRectElement::svgAttributeChanged):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::parseAttribute):
(WebCore::SVGSVGElement::svgAttributeChanged): Fall back to calling
SVGGraphicsElement::svgAttributeChanged() instead of
SVGStyledElement::svgAttributeChanged() as SVGGraphicsElement is the
parent class and it takes care of parsing SVGTests attributes now.
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::isSupportedAttribute):
(WebCore::SVGUseElement::parseAttribute):
(WebCore::SVGUseElement::svgAttributeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Skipping test to paint the debug bot green.
zarvai@inf.u-szeged.hu [Wed, 3 Jul 2013 07:44:23 +0000 (07:44 +0000)]
[Qt] Unreviewed gardening. Skipping test to paint the debug bot green.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-07-03

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Let F5 refresh the page in MiniBrowser
commit-queue@webkit.org [Wed, 3 Jul 2013 07:30:29 +0000 (07:30 +0000)]
[GTK] Let F5 refresh the page in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=117638

Patch by Morten Stenshorne <mstensho@opera.com> on 2013-07-03
Reviewed by Carlos Garcia Campos.

Also use the correct icon for the refresh button that was already there.

* MiniBrowser/gtk/BrowserWindow.c:
(browser_window_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2] Invalidate FontCache before purging MemoryCache upon WebProcess termination...
zandobersek@gmail.com [Wed, 3 Jul 2013 05:54:31 +0000 (05:54 +0000)]
[WK2] Invalidate FontCache before purging MemoryCache upon WebProcess termination/closure
https://bugs.webkit.org/show_bug.cgi?id=118280

Reviewed by Darin Adler.

Invalidate the FontCache before disabling and purging the MemoryCache in WebProcess::didClose
and WebProcess::terminate. This frees up additional references to objects that were held
by the FontCache, reducing the amount of 'LEAK: *' output when exiting MiniBrowser or
WebKitTestRunner in debug builds.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::terminate):
(WebKit::WebProcess::didClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoModernize QualifiedName by wrapping gNameCache in a function and using more early...
rniwa@webkit.org [Wed, 3 Jul 2013 05:07:45 +0000 (05:07 +0000)]
Modernize QualifiedName by wrapping gNameCache in a function and using more early exits
https://bugs.webkit.org/show_bug.cgi?id=118299

Reviewed by Andreas Kling.

Did cleanups.

* dom/QualifiedName.cpp:
(WebCore::qualifiedNameCache): Added to wrap gNameCache.
(WebCore::QualifiedName::QualifiedName):
(WebCore::QualifiedName::QualifiedNameImpl::~QualifiedNameImpl):
(WebCore::QualifiedName::toString): Use early exit and StringBuilder.
(WebCore::QualifiedName::init): Use early exit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDon't set z-index: 0 on lots of elements with -webkit-overflow-scrolling: touch
simon.fraser@apple.com [Wed, 3 Jul 2013 03:19:06 +0000 (03:19 +0000)]
Don't set z-index: 0 on lots of elements with -webkit-overflow-scrolling: touch
https://bugs.webkit.org/show_bug.cgi?id=118337

Reviewed by Benjamin Poulain.

-webkit-overflow-scrolling: touch is an inherited property that, on iOS, controls
the behavior of overflow scrolling content, and causes overflow scrolling elements
to become CSS stacking contexts.

However, the code was too aggressive in setting style->setZIndex(0), doing so
for any element with overflow != hidden. Since the default for overflow is visible,
that meant almost every element.

Previously, this didn't really matter. However, since r125693, any renderer with non-auto
z-index gets a RenderLayer, and that RenderLayer will become a stacking context. The result
was too many RenderLayers and incorrect stacking context behavior.

Fix by ensuring that -webkit-overflow-scrolling: touch  only affects elements which
are actually scrollable.

Also move the code that does this to below the code that adjust overflow style
for different elements.

* css/StyleResolver.cpp:
(WebCore::isScrollableOverflow):
(WebCore::StyleResolver::adjustRenderStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@152334 268f45cc-cd09-0410...
kalyan.kondapally@intel.com [Wed, 3 Jul 2013 02:45:27 +0000 (02:45 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r152318.
commit-queue@webkit.org [Wed, 3 Jul 2013 00:48:43 +0000 (00:48 +0000)]
Unreviewed, rolling out r152318.
http://trac.webkit.org/changeset/152318
https://bugs.webkit.org/show_bug.cgi?id=118333

This patch broke media/track/track-automatic-subtitles.html on
Mac (Requested by dfarler on #webkit).

Source/WebCore:

* page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::textTrackSelectionScore):

LayoutTests:

* media/track/track-legacyapi-with-automatic-mode-expected.txt: Removed.
* media/track/track-legacyapi-with-automatic-mode.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Adding myself to contributors.json.
dfarler@apple.com [Wed, 3 Jul 2013 00:32:26 +0000 (00:32 +0000)]
Unreviewed. Adding myself to contributors.json.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoChange event should not be dispatched by clicking a scrollbar of select listbox
commit-queue@webkit.org [Wed, 3 Jul 2013 00:20:03 +0000 (00:20 +0000)]
Change event should not be dispatched by clicking a scrollbar of select listbox
https://bugs.webkit.org/show_bug.cgi?id=118019
<rdar://problem/14297760>

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-02
Reviewed by Dean Jackson.

Source/WebCore:

Test: fast/forms/select/listbox-click-on-scrollbar.html

Merge the following:
http://src.chromium.org/viewvc/blink?view=revision&revision=151689
https://chromium.googlesource.com/chromium/blink/+/492549b0fcaa58a85aa0797446b62985a263704f

Previously, a select element with the multiple attribute would dispatch
an onChanged event when the scrollbar is clicked. This patch corrects this
issue by only calling listBoxOnChange(), which fires the onChanged event,
when an actual option is clicked.

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::childrenChanged): Updated to clear the list
of selected items when when an <option> element is added to/deleted from its <select> element.
(Without this addition, if a option was selected, and then JavaScript was used to modify
the <select> element, and then the scrollbar was clicked, an onChanged event would fire
because it remembers the previously selected option.)

(WebCore::HTMLSelectElement::listBoxOnChange):

(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updated to
only call listBoxOnChange() if at least one option is selected.

LayoutTests:

Merge the following:
http://src.chromium.org/viewvc/blink?view=revision&revision=151689
https://chromium.googlesource.com/chromium/blink/+/492549b0fcaa58a85aa0797446b62985a263704f

* fast/forms/select/listbox-click-on-scrollbar-expected.txt: Added.
* fast/forms/select/listbox-click-on-scrollbar.html: Added.
Tests that an onChange() event is not fired when the scrollbar of a
<select multiple> element is clicked.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPreparing Windows WebGL build system.
achristensen@apple.com [Wed, 3 Jul 2013 00:18:39 +0000 (00:18 +0000)]
Preparing Windows WebGL build system.
https://bugs.webkit.org/show_bug.cgi?id=118325

Reviewed by Brent Fulgham.

* WebCore.vcxproj/WebCore.vcxproj: Added EGL files, removed unused GraphicsContext3DOpenGL.cpp.
* WebCore.vcxproj/WebCore.vcxproj.filters: Added EGL filter and files, removed unused GraphicsContext3DOpenGL.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoThe callback for WKPageGetPlugInInformation needs info about whether or not there...
jberlin@webkit.org [Wed, 3 Jul 2013 00:06:13 +0000 (00:06 +0000)]
The callback for WKPageGetPlugInInformation needs info about whether or not there are any
non-playing instances of the plug-in on the page
https://bugs.webkit.org/show_bug.cgi?id=118330

Reviewed by Anders Carlsson.

Source/WebCore:

* WebCore.exp.in:
Expose a symbol so it can be used in WebKit2.

Source/WebKit2:

Add another key value pair to the dictionary passed to the callback.

* Shared/API/c/WKPluginInformation.cpp:
(WKPlugInInformationPageContainsNonPlayingInstanceOfPlugInKey):
* Shared/API/c/WKPluginInformation.h:

* Shared/Plugins/Netscape/PluginInformation.cpp:
(WebKit::plugInInformationPageContainsNonPlayingInstanceOfPlugInKey):
(WebKit::createPlugInInformationDictionary):
Add the information about whether or not the page contains a non-playing instance of that
plug-in to the plug-in information dictionary.
* Shared/Plugins/Netscape/PluginInformation.h:

* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::containsPlugInCallback):
Check if any of the MIME types of the plug-in instances that are present on the page but are
not playing match the instance of plug-in being searched for.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::addPlugInMimeTypesFromNodeListForNonPlayingPlugIns):
Based roughly off of addPlugInsFromNodeListMatchingPlugInOrigin in
HTMLPlugInImageElement.cpp.
(WebKit::WebPage::containsPluginViewsWithPluginProcessToken):
Based roughly off of HTMLPlugInImageElement::restartSimilarPlugIns.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdded getProcAddress implementation for Windows in OpenGLShims.
achristensen@apple.com [Tue, 2 Jul 2013 22:18:37 +0000 (22:18 +0000)]
Added getProcAddress implementation for Windows in OpenGLShims.
https://bugs.webkit.org/show_bug.cgi?id=118312

Reviewed by Brent Fulgham.

* platform/graphics/OpenGLShims.cpp:
(WebCore::getProcAddress): Added for Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agomedia/unsupported-rtsp.html is failing
jer.noble@apple.com [Tue, 2 Jul 2013 22:12:18 +0000 (22:12 +0000)]
media/unsupported-rtsp.html is failing
https://bugs.webkit.org/show_bug.cgi?id=118327

Reviewed by Eric Carlson.

Fixes the media/unsupported-rtsp.html test.

Set the contentType field of contentInformationRequest in order to trigger AVFoundation to
notice that loading failed and generate an error.

* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::notifyFinished):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFixed compile error in non-X11 platforms using EGL.
achristensen@apple.com [Tue, 2 Jul 2013 21:58:50 +0000 (21:58 +0000)]
Fixed compile error in non-X11 platforms using EGL.
https://bugs.webkit.org/show_bug.cgi?id=118323

Reviewed by Brent Fulgham.

* platform/graphics/egl/GLContextEGL.cpp:
(WebCore::GLContextEGL::createPixmapContext): Put all X11-specific code into #if PLATFORM(X11).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed rebaseline of media/video-controls-captions-trackmenu-localized after...
dfarler@apple.com [Tue, 2 Jul 2013 21:45:25 +0000 (21:45 +0000)]
Unreviewed rebaseline of media/video-controls-captions-trackmenu-localized after r151697.

* platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt: Removed.
"Unknown SDH" -> "Unknown".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed rebaseline of Mac Lion fast/js/global-constructors-attributes after r151914.
dfarler@apple.com [Tue, 2 Jul 2013 21:24:20 +0000 (21:24 +0000)]
Unreviewed rebaseline of Mac Lion fast/js/global-constructors-attributes after r151914.

* platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
WaveTable -> PeriodicWave

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] Improve implementation of elements in region being flowed to another...
commit-queue@webkit.org [Tue, 2 Jul 2013 20:43:31 +0000 (20:43 +0000)]
[CSS Regions] Improve implementation of elements in region being flowed to another flow thread
https://bugs.webkit.org/show_bug.cgi?id=118300

Patch by Radu Stavila <stavila@adobe.com> on 2013-07-02
Reviewed by David Hyatt.

Source/WebCore:

Methods that must be const have been turned back into const. Code has been better organized.
Performance is better. Tests have been added to.

* dom/Element.cpp:
(WebCore::Element::detach):
(WebCore::Element::setIsInsideRegion):
(WebCore::Element::isInsideRegion):
(WebCore::Element::shouldMoveToFlowThread):
* dom/Element.h:
* dom/ElementRareData.h:
(WebCore::ElementRareData::isInsideRegion):
(WebCore::ElementRareData::setIsInsideRegion):
(WebCore::ElementRareData::ElementRareData):
* dom/Node.cpp:
(WebCore::Node::isRegisteredWithNamedFlow):
* dom/Node.h:
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::shouldCreateRenderer):
(WebCore::NodeRenderingContext::elementInsideRegionNeedsRenderer):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
(WebCore::NodeRenderingContext::createRendererForElementIfNeeded):
* dom/NodeRenderingContext.h:
* dom/PseudoElement.h:
* dom/Text.cpp:
(WebCore::Text::textRendererIsNeeded):
* dom/Text.h:
* rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::unregisterNamedFlowContentNode):
(WebCore::FlowThreadController::isContentNodeRegisteredWithAnyNamedFlow):
* rendering/FlowThreadController.h:
* rendering/RenderObject.h:
* rendering/RenderRegion.h:
* svg/SVGElement.cpp:
(WebCore::SVGElement::shouldMoveToFlowThread):
* svg/SVGElement.h:

LayoutTests:

* fast/regions/flow-body-in-html.html:
* fast/regions/region-content-flown-into-region-expected.html:
* fast/regions/region-content-flown-into-region.html:
* fast/regions/universal-selector-children-to-the-same-region.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSkip cache partitioning tests on Lion.
dfarler@apple.com [Tue, 2 Jul 2013 20:30:22 +0000 (20:30 +0000)]
Skip cache partitioning tests on Lion.

Rubber stamped by Jeffrey Pfau.

* platform/mac-lion/TestExpectations:
http/tests/cache/partitioned-cache.html
http/tests/cache/partitioned-cache-iframe.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] .webkitClosedCaptionsVisible doesn't work with "Automatic" caption mode
eric.carlson@apple.com [Tue, 2 Jul 2013 20:28:57 +0000 (20:28 +0000)]
[Mac] .webkitClosedCaptionsVisible doesn't work with "Automatic" caption mode
https://bugs.webkit.org/show_bug.cgi?id=118319

Reviewed by Darin Adler.

Source/WebCore:

Test: media/track/track-legacyapi-with-automatic-mode.html

* page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::textTrackSelectionScore): Don't apply "automatic"
    logic when captions were enabled with .webkitClosedCaptionsVisible.

LayoutTests:

* media/track/track-legacyapi-with-automatic-mode-expected.txt: Added.
* media/track/track-legacyapi-with-automatic-mode.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago security/block-test.html fails when NetworkProcess is enabled
ap@apple.com [Tue, 2 Jul 2013 20:07:22 +0000 (20:07 +0000)]
    security/block-test.html fails when NetworkProcess is enabled
        https://bugs.webkit.org/show_bug.cgi?id=118320
        <rdar://problem/14309423>

        Reviewed by Geoff Garen.

        * NetworkProcess/NetworkResourceLoader.cpp:
        (WebKit::NetworkResourceLoader::wasBlocked):
        (WebKit::NetworkResourceLoader::cannotShowURL):
        Implemented missing ResourceHandleClient functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix crash when PageBanner::detachFromPage() is called from WebPage::~WebPage().
adachan@apple.com [Tue, 2 Jul 2013 19:51:47 +0000 (19:51 +0000)]
Fix crash when PageBanner::detachFromPage() is called from WebPage::~WebPage().
https://bugs.webkit.org/show_bug.cgi?id=118268

Reviewed by Beth Dakin.

* WebProcess/WebPage/mac/PageBannerMac.mm:
(WebKit::PageBanner::detachFromPage): Add some null checks. m_webPage->corePage()
can be null if this method is called after the web page is closed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAlways flip the coordinate system before drawing NSViews from Widget::paint
andersca@apple.com [Tue, 2 Jul 2013 19:50:24 +0000 (19:50 +0000)]
Always flip the coordinate system before drawing NSViews from Widget::paint
https://bugs.webkit.org/show_bug.cgi?id=118318
<rdar://problem/13895483>

Reviewed by Beth Dakin.

Undo the change that would not flip on 10.9; turns out the bug was in AppKit. Also remove the
_hasCanDrawSubviewsIntoLayerOrAncestor workaround since drawing works correctly now.

Also, pass flipped:NO when creating the NSGraphicsContext to indicate that the graphics context
is unflipped as far as AppKit knows (since we flipped it earlier).

* platform/mac/WidgetMac.mm:
(WebCore::Widget::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReplace RELEASE_ASSERT with ASSERT in CodeBlock:: bytecodeOffsetForCallAtIndex
mhahnenberg@apple.com [Tue, 2 Jul 2013 19:47:53 +0000 (19:47 +0000)]
Replace RELEASE_ASSERT with ASSERT in CodeBlock:: bytecodeOffsetForCallAtIndex
https://bugs.webkit.org/show_bug.cgi?id=118316

Reviewed by Geoffrey Garen.

This is causing some crashiness in release builds. We should replace it with an ASSERT
until we track down all the places that need fixing in bug 118315.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::bytecodeOffsetForCallAtIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoempty inlines should not affect line-wrapping
robert@webkit.org [Tue, 2 Jul 2013 19:30:32 +0000 (19:30 +0000)]
empty inlines should not affect line-wrapping
https://bugs.webkit.org/show_bug.cgi?id=25638

Reviewed by David Hyatt.

Source/WebCore:

Don't break on empty inlines if we're in the middle of a word. I took this opportunity to
refactor the series of checks we perform to establish if we can break at the current position.

Test: fast/text/whitespace/inline-whitespace-wrapping-11.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::textBeginsWithBreakablePosition):
(WebCore::canBreakAtThisPosition):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

* fast/text/whitespace/inline-whitespace-wrapping-11-expected.html: Added.
* fast/text/whitespace/inline-whitespace-wrapping-11.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImplement CoordinatedSurface for Threaded Coordinated Graphics
commit-queue@webkit.org [Tue, 2 Jul 2013 19:17:14 +0000 (19:17 +0000)]
Implement CoordinatedSurface for Threaded Coordinated Graphics
https://bugs.webkit.org/show_bug.cgi?id=109661

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-07-02
Reviewed by Noam Rosenthal.

This is a preparation patch for Threaded Coordianted Graphics.

This patch implements ThreadSafeCoordinatedSurface using ImageBuffer as a
backend. Also, this patch moves common implementation to CoordinatedSurface to
prevent duplication of code.

Source/WebCore:

* platform/graphics/texmap/coordinated/CoordinatedSurface.cpp:
(WebCore::CoordinatedSurface::CoordinatedSurface):
* platform/graphics/texmap/coordinated/CoordinatedSurface.h:
(WebCore::CoordinatedSurface::size):
(WebCore::CoordinatedSurface::flags):
* platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.cpp: Added.
(WebCore::ThreadSafeCoordinatedSurface::create):
(WebCore::ThreadSafeCoordinatedSurface::ThreadSafeCoordinatedSurface):
(WebCore::ThreadSafeCoordinatedSurface::~ThreadSafeCoordinatedSurface):
(WebCore::ThreadSafeCoordinatedSurface::paintToSurface):
(WebCore::ThreadSafeCoordinatedSurface::copyToTexture):
* platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.h: Added.

Source/WebKit2:

* Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:
(WebKit::WebCoordinatedSurface::WebCoordinatedSurface):
* Shared/CoordinatedGraphics/WebCoordinatedSurface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoplainText() is O(N^2)
ggaren@apple.com [Tue, 2 Jul 2013 19:09:44 +0000 (19:09 +0000)]
plainText() is O(N^2)
https://bugs.webkit.org/show_bug.cgi?id=118282
<rdar://problem/14284360>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

* editing/TextIterator.cpp:
(WebCore::plainText): Linear growth for a vector data type is O(N^2).
Don't do that. Luckily, StringBuilder does the right thing automatically,
so we can just delete code.

Source/WTF:

* wtf/text/StringBuilder.cpp:
(WTF::expandCapacity): Factored out this helper function to simplify
some code that was duplicated in four places.

(WTF::StringBuilder::appendUninitializedSlow):
(WTF::StringBuilder::append): Use expandCapacity(). One of the cases
was not doing anything special, and so was O(N^2).

Also, always call expandCapacity() it in a standard way, calling
capacity() first, so it's easy to tell at a glance that you got it right.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoconstrainScrollPositionForOverhang needs to handle scrollOrigin correctly
timothy_horton@apple.com [Tue, 2 Jul 2013 18:14:47 +0000 (18:14 +0000)]
constrainScrollPositionForOverhang needs to handle scrollOrigin correctly
https://bugs.webkit.org/show_bug.cgi?id=118176
<rdar://problem/14301271>

Reviewed by Anders Carlsson.

Test: compositing/geometry/fixed-position-flipped-writing-mode.html

WebCore makes use of constrainScrollPositionForOverhang not only for
constraining fixed- and sticky-positioned elements to the viewport, but
also for clamping the tile cache's visible rect.

Therefore, constrainScrollPositionForOverhang needs to correctly take
the scrollOrigin into account. The easiest way I saw to do this was to
reimplement the function in terms of a pair of rect intersections
between a virtual scrollable "viewport" and the document (with a bit
of complication from headers and footers).

The first intersection is performed, then if the viewport doesn't fit,
it is pushed down and to the right, from the origin. Next, we intersect
again, this time pushing the rect up by the amount it overflowed the document
rect from the bottom right. This performs effectively the same constraint
as previously, but handles the scrollOrigin correctly and is also somewhat
easier to read and understand (with pictures).

* page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):
Subtract the scrollOrigin out of the offset passed to scrollOffsetForFixedPosition,
it's expecting an offset without the origin included.

* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::constrainScrollPositionForOverhang):
Reimplement the function as described above.

Add a test that ensures that fixed position works with a scrollable document
and direction: rtl, which is one case where scrollOrigin is set.

Disable the test on Mac WebKit1 because of https://bugs.webkit.org/show_bug.cgi?id=118269.

* compositing/geometry/fixed-position-flipped-writing-mode-expected.txt: Added.
* compositing/geometry/fixed-position-flipped-writing-mode.html: Added.
* platform/mac/compositing/geometry/fixed-position-flipped-writing-mode-expected.png: Added.
* platform/mac/TestExpectations:
* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Unreviewed build correction for 'DebugSuffix' target.
bfulgham@apple.com [Tue, 2 Jul 2013 17:53:20 +0000 (17:53 +0000)]
[Windows] Unreviewed build correction for 'DebugSuffix' target.

* JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj: Must pass the
DEBUGSUFFIX definition to the nmake instance to be available during script processing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove SVGStyledLocatableElement class
ch.dumez@sisa.samsung.com [Tue, 2 Jul 2013 17:37:32 +0000 (17:37 +0000)]
Remove SVGStyledLocatableElement class
https://bugs.webkit.org/show_bug.cgi?id=118283

Reviewed by Dirk Schulze.

Remove SVGStyledLocatableElement class and have SVGGraphicsElement
inherit SVGStyledElement directly instead. SVGStyledLocatableElement
is no longer needed and according to the specification, SVGGraphicsElement
should inherit SVGStyledElement (actually SVGElement once we merge
SVGStyledElement into SVGElement).

No new tests, no behavior change.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.order:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/scripts/CodeGeneratorJS.pm:
(GetGnuVTableOffsetForType):
* svg/SVGAllInOne.cpp:
* svg/SVGElement.cpp:
(WebCore::SVGElement::getBoundingBox):
* svg/SVGElement.h:
* svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::SVGGraphicsElement):
(WebCore::SVGGraphicsElement::parseAttribute):
(WebCore::SVGGraphicsElement::svgAttributeChanged):
* svg/SVGGraphicsElement.h:
* svg/SVGLocatable.cpp:
(WebCore::SVGLocatable::getTransformToElement):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::localCoordinateSpaceTransform):
* svg/SVGStyledLocatableElement.cpp: Removed.
* svg/SVGStyledLocatableElement.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[ATK] Leak: leaks in AccessibilityUIElement
commit-queue@webkit.org [Tue, 2 Jul 2013 16:50:49 +0000 (16:50 +0000)]
[ATK] Leak: leaks in AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=118297

Fixed memory leak.

Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-02
Reviewed by Christophe Dumez.

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::stringValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Curl] Crash after download.
commit-queue@webkit.org [Tue, 2 Jul 2013 16:26:03 +0000 (16:26 +0000)]
[Curl] Crash after download.
https://bugs.webkit.org/show_bug.cgi?id=118303

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-02
Reviewed by Brent Fulgham.

We need to make sure that the Curl easy handle is removed from the Curl multi handle before it's freed.

* platform/network/curl/CurlDownload.cpp:
(CurlDownloadManager::updateHandleList): Use addToCurl() and removeFromCurl() methods.
(CurlDownloadManager::addToCurl): Add method to add easy handle to multi handle.
(CurlDownloadManager::removeFromCurl): Add method to remove easy handle from multi handle, and then delete the handle.
(CurlDownloadManager::downloadThread): Use removeFromCurl() method.
(CurlDownload::~CurlDownload):
* platform/network/curl/CurlDownload.h: Avoid deleting Curl easy handle in destructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening. Added new common expectations for test after r151665.
mario@webkit.org [Tue, 2 Jul 2013 16:21:36 +0000 (16:21 +0000)]
Unreviewed gardening. Added new common expectations for test after r151665.

* accessibility/box-styled-lists-expected.txt: Added shared expectation.
* platform/efl/TestExpectations: Removed failure expectation.
* platform/gtk/TestExpectations: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix WebKitTestRunner crashes.
bw80.lee@samsung.com [Tue, 2 Jul 2013 16:19:05 +0000 (16:19 +0000)]
Fix WebKitTestRunner crashes.
https://bugs.webkit.org/show_bug.cgi?id=117630

Reviewed by Darin Adler.

Create static function to dump for WebProcess unresponsiveness status,
and use it before calling TestController::runTest().

Accessing TestController::m_currentInvocation before calling
TestController::runTest() can make crash because the invocation
instance will be assigned at the function.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::run):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::dumpWebProcessUnresponsiveness):
* WebKitTestRunner/TestInvocation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening. Added new baselines for GTK after revision r151841 and r151868.
mario@webkit.org [Tue, 2 Jul 2013 16:13:53 +0000 (16:13 +0000)]
Unreviewed gardening. Added new baselines for GTK after revision r151841 and r151868.

* accessibility/listitem-title-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/listitem-title-expected.txt.
* platform/gtk/accessibility/aria-tab-role-on-buttons-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSSRegions] No other SVG elements except the SVGRoot must have RegionInfo objects...
commit-queue@webkit.org [Tue, 2 Jul 2013 15:00:31 +0000 (15:00 +0000)]
[CSSRegions] No other SVG elements except the SVGRoot must have RegionInfo objects attached
https://bugs.webkit.org/show_bug.cgi?id=118295

Patch by Radu Stavila <stavila@adobe.com> on 2013-07-02
Reviewed by Antti Koivisto.

Only the SVGRoot element can be collected in a named flow. As such, no SVG element below the root should
be attached to a RenderBoxRegionInfo object.

A larger patch's test (https://bugs.webkit.org/show_bug.cgi?id=118300) is failing because of this.
This change will be covered by that test.

* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::canHaveBoxInfoInRegion):
* rendering/RenderObject.h:
(WebCore::RenderObject::isRenderSVGBlock):
* rendering/svg/RenderSVGBlock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r152233.
commit-queue@webkit.org [Tue, 2 Jul 2013 14:32:45 +0000 (14:32 +0000)]
Unreviewed, rolling out r152233.
http://trac.webkit.org/changeset/152233
https://bugs.webkit.org/show_bug.cgi?id=118304

hopeful attempt to restore windows buildage (Requested by
kling on #webkit).

* win/tools/vsprops/debugsuffix.props:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening. Rebaseline background blend mode default test result.
abucur@adobe.com [Tue, 2 Jul 2013 14:04:16 +0000 (14:04 +0000)]
Unreviewed gardening. Rebaseline background blend mode default test result.

* platform/mac/css3/compositing/background-blend-mode-default-value-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agois/toHTMLStyleElement should use Element* for its argument
kangil.han@samsung.com [Tue, 2 Jul 2013 13:48:16 +0000 (13:48 +0000)]
is/toHTMLStyleElement should use Element* for its argument
https://bugs.webkit.org/show_bug.cgi?id=118286

Reviewed by Andreas Kling.

To reduce unnecessary call of isElementNode(), this patch replaces argument
of is/toHTMLStyleElement from Node* to Element*. Plus, use Element::hasTagName
in collectActiveStyleSheets function for minor code refactoring since
its cost is cheaper than Node::hasTagName.

* css/CSSStyleSheet.cpp:
(WebCore::isAcceptableCSSStyleSheetParent):
* css/StyleScopeResolver.cpp:
(WebCore::StyleScopeResolver::scopeFor):
* dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
* dom/Node.cpp:
(WebCore::Node::numberOfScopedHTMLStyleChildren):
* html/HTMLStyleElement.h:
(WebCore::isHTMLStyleElement):
(WebCore::toHTMLStyleElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAvoid code duplication inside String::append()
mikhail.pozdnyakov@intel.com [Tue, 2 Jul 2013 13:36:09 +0000 (13:36 +0000)]
Avoid code duplication inside String::append()
https://bugs.webkit.org/show_bug.cgi?id=118290

Reviewed by Anders Carlsson.

The implementation of 'append(UChar)' had been repeated inside 'append(LChar)',
this duplication is obviated now.

* wtf/text/WTFString.cpp:
(WTF::String::appendInternal):
(WTF::String::append):
* wtf/text/WTFString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152289 268f45cc-cd09-0410-ab3c-d52691b4dbfc