WebKit-https.git
8 years ago2011-03-11 Alexis Menard <alexis.menard@openbossa.org>
commit-queue@webkit.org [Fri, 11 Mar 2011 17:09:37 +0000 (17:09 +0000)]
2011-03-11  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Martin Robinson.

        [GStreamer] When seeking webKitWebSrcStop release the frame but should not.
        https://bugs.webkit.org/show_bug.cgi?id=55703

        When calling webKitWebSrcStop in case of a seeking, the frame should not
        be reset (the source hasn't change). The frame may be used to get the network
        context. Some network stack (like Qt) are relaying on the network context
        to work.

        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
        (webKitWebSrcStop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-11 Dean Jackson <dino@apple.com>
dino@apple.com [Fri, 11 Mar 2011 15:08:10 +0000 (15:08 +0000)]
2011-03-11  Dean Jackson  <dino@apple.com>

        Unreviewed.

        Build fixes for GTK and Leopard.

        * bindings/gobject/GNUmakefile.am:
        - add missing WebKitAnimation* generated bindings
        * page/WebKitAnimation.idl:
        - use double in place of float (the core values are double anyway)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate Windows results after r80846
aroben@apple.com [Fri, 11 Mar 2011 15:05:44 +0000 (15:05 +0000)]
Update Windows results after r80846

* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/win/fast/dom/prototype-inheritance-2-expected.txt:
* platform/win/fast/dom/prototype-inheritance-expected.txt:
* platform/win/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRoll out r80848
aroben@apple.com [Fri, 11 Mar 2011 14:56:02 +0000 (14:56 +0000)]
Roll out r80848

It was accidentally committed.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
(LeaksViewer._loadLeaksFromURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSkip a crashing test on Windows
aroben@apple.com [Fri, 11 Mar 2011 14:51:51 +0000 (14:51 +0000)]
Skip a crashing test on Windows

The crash is tracked by <http://webkit.org/b/56185>.

* platform/win/Skipped: Added http/tests/websocket/tests/url-with-credential.html. Grouped
possibly-related websocket crashes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDisable fast/text/large-text-composed-char-dos.html
aroben@apple.com [Fri, 11 Mar 2011 14:51:08 +0000 (14:51 +0000)]
Disable fast/text/large-text-composed-char-dos.html

It is failing on multiple bots. The failure is tracked by <http://webkit.org/b/56140>.

* fast/text/large-text-composed-char-dos.html-disabled: Renamed from LayoutTests/fast/text/large-text-composed-char-dos.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWork on fetching all leaks for a build
aroben@apple.com [Fri, 11 Mar 2011 14:49:25 +0000 (14:49 +0000)]
Work on fetching all leaks for a build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-11 Dean Jackson <dino@apple.com>
dino@apple.com [Fri, 11 Mar 2011 14:19:30 +0000 (14:19 +0000)]
2011-03-11  Dean Jackson  <dino@apple.com>

        Unreviewed build fix for QT.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-11 Dean Jackson <dino@apple.com>
dino@apple.com [Fri, 11 Mar 2011 14:05:12 +0000 (14:05 +0000)]
2011-03-11  Dean Jackson  <dino@apple.com>

        Reviewed by Simon Fraser and Chris Marrin.

        https://bugs.webkit.org/show_bug.cgi?id=54151
        Implement an API to play/pause/scrub animations

        This is Part 1. Adds the new WebKitAnimation and WebKitAnimationList
        APIs, exposed via Element.getWebKitAnimations(). This first pass
        is a read-only API - a subsequent commit will add the ability
        to scrub animations.

        Test: animations/animation-api-1.html

        * Android.derived.jscbindings.mk:
        * Android.derived.v8bindings.mk:
        * Android.mk:
        * Android.v8bindings.mk:
        * CMakeLists.txt:
        * CodeGenerators.pri:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        - All build settings updated for new files
        * bindings/js/JSBindingsAllInOne.cpp:
        - Include new custom files
        * bindings/js/JSWebKitAnimationCustom.cpp: Added.
        (WebCore::JSWebKitAnimation::iterationCount):
        - Custom property getter so that we can return INFINITY
        * bindings/js/JSWebKitAnimationListCustom.cpp: Added.
        (WebCore::JSWebKitAnimationList::markChildren):
        - Make sure WebKitAnimations are marked
        * bindings/v8/custom/V8WebKitAnimationCustom.cpp: Added.
        (WebCore::V8WebkitAnimation::iterationCountAccessorGetter):
        - Custom property getter so that we can return INFINITY
        * dom/Element.cpp:
        (WebCore::Element::webkitGetAnimations):
        * dom/Element.h:
        * dom/Element.idl:
        - New API entry point
        * page/DOMWindow.idl:
        - Constructor definitions for WebKitAnimation and WebKitAnimationList
        * page/animation/AnimationBase.cpp:
        (WebCore::AnimationBase::~AnimationBase):
        - Since AnimationBase can now live longer (if a WebKitAnimation is
        held in Javascript) we need to guard for the renderer having disappeared.
        (WebCore::AnimationBase::setElapsedTime):
        (WebCore::AnimationBase::play):
        (WebCore::AnimationBase::pause):
        - Stub implementations at present
        * page/animation/AnimationBase.h:
        (WebCore::AnimationBase::animation):
        - Expose the Animation properties
        * page/animation/AnimationController.cpp:
        (WebCore::AnimationControllerPrivate::animationsForRenderer):
        (WebCore::AnimationController::animationsForRenderer):
        - Builds the list of WebKitAnimations
        * page/animation/AnimationController.h:
        * page/animation/AnimationControllerPrivate.h:
        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimation::updateKeyframeAnimations):
        - Make sure we clear the renderer if we are removing the animation
        (WebCore::CompositeAnimation::animations):
        * page/animation/CompositeAnimation.h:
        * page/animation/WebKitAnimation.cpp: Added.
        (WebCore::WebKitAnimation::WebKitAnimation):
        (WebCore::WebKitAnimation::name):
        (WebCore::WebKitAnimation::duration):
        (WebCore::WebKitAnimation::elapsedTime):
        (WebCore::WebKitAnimation::setElapsedTime):
        (WebCore::WebKitAnimation::delay):
        (WebCore::WebKitAnimation::iterationCount):
        (WebCore::WebKitAnimation::paused):
        (WebCore::WebKitAnimation::ended):
        (WebCore::WebKitAnimation::direction):
        (WebCore::WebKitAnimation::fillMode):
        (WebCore::WebKitAnimation::pause):
        (WebCore::WebKitAnimation::play):
        - The implementation of the new API. All the read-only parts are
        done, but elapsedTime, play() and pause() are stubs.
        * page/animation/WebKitAnimation.h: Added.
        (WebCore::WebKitAnimation::create):
        (WebCore::WebKitAnimation::~WebKitAnimation):
        * page/animation/WebKitAnimation.idl: Added.
        * page/animation/WebKitAnimationList.cpp: Added.
        * page/animation/WebKitAnimationList.h: Added.
        * page/animation/WebKitAnimationList.idl: Added.
        - Copies NodeList implementation

2011-03-11  Dean Jackson  <dino@apple.com>

        Reviewed by Simon Fraser and Chris Marrin.

        https://bugs.webkit.org/show_bug.cgi?id=54151
        Implement an API to play/pause/scrub animations

        This is Part 1. Adds the new WebKitAnimation and WebKitAnimationList
        APIs, exposed via Element.getWebKitAnimations(). This first pass
        is read-only. One new layout test that examines animation
        properties. Update existing layout tests for the new interfaces
        on Window.

        * animations/animation-api-1-expected.txt: Added.
        * animations/animation-api-1.html: Added.
        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/Window/window-property-descriptors-expected.txt:
        * fast/dom/prototype-inheritance-2-expected.txt:
        * fast/dom/prototype-inheritance-expected.txt:
        * fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-11 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 11 Mar 2011 13:38:07 +0000 (13:38 +0000)]
2011-03-11  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: introduce error argument for all the callbacks on frontend.
        https://bugs.webkit.org/show_bug.cgi?id=56100

        * inspector/CodeGeneratorInspector.pm:
        * inspector/front-end: number of files

2011-03-11  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: introduce error argument for all the callbacks on frontend.
        https://bugs.webkit.org/show_bug.cgi?id=56100

        * http/tests/inspector/extensions-test.js:
        (initialize_ExtensionsTest.InspectorTest.runExtensionTests):
        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.InspectorTest.evaluateInPage.mycallback):
        (initialize_InspectorTest.InspectorTest.evaluateInPage):
        * inspector/console/console-dir-global.html:
        * inspector/elements/dom-agent-query-selector.html:
        * inspector/protocol/console-agent-expected.txt:
        * inspector/protocol/console-agent.html:
        * inspector/protocol/runtime-agent-expected.txt:
        * inspector/protocol/runtime-agent.html:
        * inspector/report-protocol-errors-expected.txt:
        * inspector/report-protocol-errors.html:
        * inspector/styles/styles-new-API.html:
        * inspector/styles/styles-source-offsets.html:
        * inspector/timeline/timeline-test.js:
        (initialize_Timeline.InspectorTest.stopTimeline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-11 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 11 Mar 2011 13:26:56 +0000 (13:26 +0000)]
2011-03-11  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
        https://bugs.webkit.org/show_bug.cgi?id=56173

        * inspector/protocol/console-agent-expected.txt:
        * inspector/protocol/console-agent.html:
2011-03-11  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
        https://bugs.webkit.org/show_bug.cgi?id=56173

        Moved all injected script managing logic into InjectedScriptManager which is owned by InspectorController.

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSInjectedScriptHostCustom.cpp:
        * bindings/js/JSInjectedScriptManager.cpp: Added.
        (WebCore::InjectedScriptManager::createInjectedScript):
        (WebCore::InjectedScriptManager::discardInjectedScript):
        (WebCore::InjectedScriptManager::injectedScriptFor):
        (WebCore::InjectedScriptManager::canAccessInspectedWindow):
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        * bindings/v8/custom/V8InjectedScriptManager.cpp: Copied from Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp.
        (WebCore::WeakReferenceCallback):
        (WebCore::createInjectedScriptHostV8Wrapper):
        (WebCore::InjectedScriptManager::createInjectedScript):
        (WebCore::InjectedScriptManager::discardInjectedScript):
        (WebCore::InjectedScriptManager::injectedScriptFor):
        (WebCore::InjectedScriptManager::canAccessInspectedWindow):
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::addToFrontend):
        * inspector/ConsoleMessage.h:
        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::canAccessInspectedWindow):
        * inspector/InjectedScript.h:
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::create):
        (WebCore::InjectedScriptHost::InjectedScriptHost):
        (WebCore::InjectedScriptHost::~InjectedScriptHost):
        (WebCore::InjectedScriptHost::disconnect):
        (WebCore::InjectedScriptHost::inspectImpl):
        (WebCore::InjectedScriptHost::clearConsoleMessages):
        (WebCore::InjectedScriptHost::databaseIdImpl):
        (WebCore::InjectedScriptHost::storageIdImpl):
        * inspector/InjectedScriptHost.h:
        (WebCore::InjectedScriptHost::init):
        (WebCore::InjectedScriptHost::setFrontend):
        (WebCore::InjectedScriptHost::clearFrontend):
        * inspector/InjectedScriptManager.cpp: Added.
        (WebCore::InjectedScriptManager::create):
        (WebCore::InjectedScriptManager::InjectedScriptManager):
        (WebCore::InjectedScriptManager::~InjectedScriptManager):
        (WebCore::InjectedScriptManager::disconnect):
        (WebCore::InjectedScriptManager::injectedScriptHost):
        (WebCore::InjectedScriptManager::injectedScriptForId):
        (WebCore::InjectedScriptManager::injectedScriptForObjectId):
        (WebCore::InjectedScriptManager::discardInjectedScripts):
        (WebCore::InjectedScriptManager::releaseObjectGroup):
        (WebCore::InjectedScriptManager::injectedScriptSource):
        (WebCore::InjectedScriptManager::injectScript):
        * inspector/InjectedScriptManager.h: Copied from Source/WebCore/inspector/InjectedScriptHost.h.
        * inspector/Inspector.idl:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::inspectedPageDestroyed):
        (WebCore::InspectorAgent::focusNode):
        (WebCore::InspectorAgent::didClearWindowObjectInWorld):
        (WebCore::InspectorAgent::createFrontendLifetimeAgents):
        (WebCore::InspectorAgent::didCommitLoad):
        (WebCore::InspectorAgent::domContentLoadedEventFired):
        * inspector/InspectorAgent.h:
        * inspector/InspectorBrowserDebuggerAgent.cpp:
        * inspector/InspectorConsoleAgent.cpp:
        (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
        (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
        (WebCore::InspectorConsoleAgent::clearConsoleMessages):
        (WebCore::InspectorConsoleAgent::addInspectedNode):
        (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
        (WebCore::InspectorConsoleAgent::addConsoleMessage):
        * inspector/InspectorConsoleAgent.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::disconnectFrontend):
        * inspector/InspectorController.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::InspectorDOMAgent):
        (WebCore::InspectorDOMAgent::discardBindings):
        (WebCore::InspectorDOMAgent::pushNodeToFrontend):
        (WebCore::InspectorDOMAgent::resolveNode):
        * inspector/InspectorDOMAgent.h:
        (WebCore::InspectorDOMAgent::create):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::create):
        (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
        (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
        (WebCore::InspectorDebuggerAgent::currentCallFrames):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/InspectorRuntimeAgent.cpp:
        (WebCore::InspectorRuntimeAgent::create):
        (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
        (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
        (WebCore::InspectorRuntimeAgent::evaluate):
        (WebCore::InspectorRuntimeAgent::evaluateOn):
        (WebCore::InspectorRuntimeAgent::getProperties):
        (WebCore::InspectorRuntimeAgent::setPropertyValue):
        (WebCore::InspectorRuntimeAgent::releaseObject):
        (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
        * inspector/InspectorRuntimeAgent.h:
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
        (WebInspector.ElementsPanel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-11 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Fri, 11 Mar 2011 12:50:07 +0000 (12:50 +0000)]
2011-03-11  Sergio Villar Senin  <svillar@igalia.com>

        [GTK] JSC crashes in 32bit Release bots after r80743
        https://bugs.webkit.org/show_bug.cgi?id=56180

        Skipping a couple of tests until the original issue is fixed.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-11 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Fri, 11 Mar 2011 12:10:55 +0000 (12:10 +0000)]
2011-03-11  Anton Muhin  <antonm@chromium.org>

        Reviewed by Adam Barth.

        [v8] Change the way group id for CSS objects is calculated
        https://bugs.webkit.org/show_bug.cgi?id=56117

        Do not treat CSSStyleDeclarations under not CSSRule as belonging to the same object group
        as they should not be reachable in JavaScript.

        Covered by existing layout tests.  Fact of absence of retention is not trivial to prove.

        * bindings/v8/V8GCController.cpp:
        (WebCore::calculateGroupId):
        (WebCore::DOMObjectGrouperVisitor::visitDOMWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-11 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Fri, 11 Mar 2011 11:56:52 +0000 (11:56 +0000)]
2011-03-11  Sergio Villar Senin  <svillar@igalia.com>

        Added new GTK+ test expectations.

        * platform/gtk/fast/backgrounds/positioned-root-expected.checksum: Added.
        * platform/gtk/fast/backgrounds/positioned-root-expected.png: Added.
        * platform/gtk/fast/backgrounds/positioned-root-expected.txt: Added.
        * platform/gtk/fast/backgrounds/table-root-expected.checksum: Added.
        * platform/gtk/fast/backgrounds/table-root-expected.png: Added.
        * platform/gtk/fast/backgrounds/table-root-expected.txt: Added.
        * platform/gtk/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Added.
        * platform/gtk/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Added.
        * platform/gtk/fast/block/basic/percent-height-inside-anonymous-block-expected.txt: Added.
        * platform/gtk/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Added.
        * platform/gtk/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Added.
        * platform/gtk/fast/block/positioning/static-distance-with-positioned-ancestor-expected.txt: Added.
        * platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added.
        * platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
        * platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-11 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Fri, 11 Mar 2011 11:23:02 +0000 (11:23 +0000)]
2011-03-11  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: hover over elements in Elements panel does not highlight nodes
        https://bugs.webkit.org/show_bug.cgi?id=56121

        In DOM trees with a comment and/or doctype preceding the HTML tag, the tree container right boundary
        is 16px apart from the OL right boundary, and we miss the relevant LI by 4px. The fix is to compensate
        for these 16px when computing the test point coordinates.

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-11 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 11 Mar 2011 10:53:04 +0000 (10:53 +0000)]
2011-03-11  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Roll out r80837.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-11 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 11 Mar 2011 10:47:44 +0000 (10:47 +0000)]
2011-03-11  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewied trivial fix. Leave default state of setMonitoringXHREnabled intact so it doesn't affect other tests.

        * inspector/report-API-errors.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-11 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 11 Mar 2011 10:37:53 +0000 (10:37 +0000)]
2011-03-11  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
        https://bugs.webkit.org/show_bug.cgi?id=56173

        * inspector/protocol/console-agent-expected.txt:
        * inspector/protocol/console-agent.html:
2011-03-11  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: split InjectedScriptHost into InjectedScriptManager and InjectedScriptHost
        https://bugs.webkit.org/show_bug.cgi?id=56173

        Moved all injected script managing logic into InjectedScriptManager which is owned by InspectorController.

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSInjectedScriptHostCustom.cpp:
        * bindings/js/JSInjectedScriptManager.cpp: Added.
        (WebCore::InjectedScriptManager::createInjectedScript):
        (WebCore::InjectedScriptManager::discardInjectedScript):
        (WebCore::InjectedScriptManager::injectedScriptFor):
        (WebCore::InjectedScriptManager::canAccessInspectedWindow):
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        * bindings/v8/custom/V8InjectedScriptManager.cpp: Copied from Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp.
        (WebCore::WeakReferenceCallback):
        (WebCore::createInjectedScriptHostV8Wrapper):
        (WebCore::InjectedScriptManager::createInjectedScript):
        (WebCore::InjectedScriptManager::discardInjectedScript):
        (WebCore::InjectedScriptManager::injectedScriptFor):
        (WebCore::InjectedScriptManager::canAccessInspectedWindow):
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::addToFrontend):
        * inspector/ConsoleMessage.h:
        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::canAccessInspectedWindow):
        * inspector/InjectedScript.h:
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::create):
        (WebCore::InjectedScriptHost::InjectedScriptHost):
        (WebCore::InjectedScriptHost::~InjectedScriptHost):
        (WebCore::InjectedScriptHost::disconnect):
        (WebCore::InjectedScriptHost::inspectImpl):
        (WebCore::InjectedScriptHost::clearConsoleMessages):
        (WebCore::InjectedScriptHost::databaseIdImpl):
        (WebCore::InjectedScriptHost::storageIdImpl):
        * inspector/InjectedScriptHost.h:
        (WebCore::InjectedScriptHost::init):
        (WebCore::InjectedScriptHost::setFrontend):
        (WebCore::InjectedScriptHost::clearFrontend):
        * inspector/InjectedScriptManager.cpp: Added.
        (WebCore::InjectedScriptManager::create):
        (WebCore::InjectedScriptManager::InjectedScriptManager):
        (WebCore::InjectedScriptManager::~InjectedScriptManager):
        (WebCore::InjectedScriptManager::disconnect):
        (WebCore::InjectedScriptManager::injectedScriptHost):
        (WebCore::InjectedScriptManager::injectedScriptForId):
        (WebCore::InjectedScriptManager::injectedScriptForObjectId):
        (WebCore::InjectedScriptManager::discardInjectedScripts):
        (WebCore::InjectedScriptManager::releaseObjectGroup):
        (WebCore::InjectedScriptManager::injectedScriptSource):
        (WebCore::InjectedScriptManager::injectScript):
        * inspector/InjectedScriptManager.h: Copied from Source/WebCore/inspector/InjectedScriptHost.h.
        * inspector/Inspector.idl:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::inspectedPageDestroyed):
        (WebCore::InspectorAgent::focusNode):
        (WebCore::InspectorAgent::didClearWindowObjectInWorld):
        (WebCore::InspectorAgent::createFrontendLifetimeAgents):
        (WebCore::InspectorAgent::didCommitLoad):
        (WebCore::InspectorAgent::domContentLoadedEventFired):
        * inspector/InspectorAgent.h:
        * inspector/InspectorBrowserDebuggerAgent.cpp:
        * inspector/InspectorConsoleAgent.cpp:
        (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
        (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
        (WebCore::InspectorConsoleAgent::clearConsoleMessages):
        (WebCore::InspectorConsoleAgent::addInspectedNode):
        (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
        (WebCore::InspectorConsoleAgent::addConsoleMessage):
        * inspector/InspectorConsoleAgent.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::disconnectFrontend):
        * inspector/InspectorController.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::InspectorDOMAgent):
        (WebCore::InspectorDOMAgent::discardBindings):
        (WebCore::InspectorDOMAgent::pushNodeToFrontend):
        (WebCore::InspectorDOMAgent::resolveNode):
        * inspector/InspectorDOMAgent.h:
        (WebCore::InspectorDOMAgent::create):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::create):
        (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
        (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
        (WebCore::InspectorDebuggerAgent::currentCallFrames):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/InspectorRuntimeAgent.cpp:
        (WebCore::InspectorRuntimeAgent::create):
        (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
        (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
        (WebCore::InspectorRuntimeAgent::evaluate):
        (WebCore::InspectorRuntimeAgent::evaluateOn):
        (WebCore::InspectorRuntimeAgent::getProperties):
        (WebCore::InspectorRuntimeAgent::setPropertyValue):
        (WebCore::InspectorRuntimeAgent::releaseObject):
        (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
        * inspector/InspectorRuntimeAgent.h:
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
        (WebInspector.ElementsPanel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-08 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Fri, 11 Mar 2011 10:26:50 +0000 (10:26 +0000)]
2011-03-08  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] close-web-view emitted on disposed WebView
        https://bugs.webkit.org/show_bug.cgi?id=55932

        * WebCoreSupport/ChromeClientGtk.cpp:
        (ChromeClient::chromeDestroyed): Remove the closeSoonTimer glib
        source before destruction of the ChromeClient.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-11 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Fri, 11 Mar 2011 10:26:03 +0000 (10:26 +0000)]
2011-03-11  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed.

        Skipping two test cases that are failing on GTK debug bots.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Fri, 11 Mar 2011 10:04:35 +0000 (10:04 +0000)]
2011-03-09  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Make IDBBackingStore abstract
        https://bugs.webkit.org/show_bug.cgi?id=56013

        Make IDBBackingStore abstract to allow for multiple implementations.
        Move the SQLite implementation to IDBSQLiteBackingStore.

        No new tests: refactoring only.

        * WebCore.gypi:
        * storage/IDBBackingStore.h:
        (WebCore::IDBBackingStore::~IDBBackingStore):
        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::IDBFactoryBackendImpl::open):
        * storage/IDBSQLiteBackingStore.cpp:
        (WebCore::IDBSQLiteBackingStore::IDBSQLiteBackingStore):
        (WebCore::IDBSQLiteBackingStore::~IDBSQLiteBackingStore):
        (WebCore::runCommands):
        (WebCore::createTables):
        (WebCore::createMetaDataTable):
        (WebCore::getDatabaseSchemaVersion):
        (WebCore::migrateDatabase):
        (WebCore::IDBSQLiteBackingStore::open):
        (WebCore::IDBSQLiteBackingStore::extractIDBDatabaseMetaData):
        (WebCore::IDBSQLiteBackingStore::setIDBDatabaseMetaData):
        (WebCore::IDBSQLiteBackingStore::getObjectStores):
        (WebCore::IDBSQLiteBackingStore::createObjectStore):
        (WebCore::doDelete):
        (WebCore::IDBSQLiteBackingStore::deleteObjectStore):
        (WebCore::whereSyntaxForKey):
        (WebCore::bindKeyToQuery):
        (WebCore::lowerCursorWhereFragment):
        (WebCore::upperCursorWhereFragment):
        (WebCore::IDBSQLiteBackingStore::getObjectStoreRecord):
        (WebCore::bindKeyToQueryWithNulls):
        (WebCore::IDBSQLiteBackingStore::putObjectStoreRecord):
        (WebCore::IDBSQLiteBackingStore::clearObjectStore):
        (WebCore::IDBSQLiteBackingStore::deleteObjectStoreRecord):
        (WebCore::IDBSQLiteBackingStore::nextAutoIncrementNumber):
        (WebCore::IDBSQLiteBackingStore::keyExistsInObjectStore):
        (WebCore::IDBSQLiteBackingStore::forEachObjectStoreRecord):
        (WebCore::IDBSQLiteBackingStore::getIndexes):
        (WebCore::IDBSQLiteBackingStore::createIndex):
        (WebCore::IDBSQLiteBackingStore::deleteIndex):
        (WebCore::IDBSQLiteBackingStore::putIndexDataForRecord):
        (WebCore::IDBSQLiteBackingStore::deleteIndexDataForRecord):
        (WebCore::IDBSQLiteBackingStore::getObjectViaIndex):
        (WebCore::keyFromQuery):
        (WebCore::IDBSQLiteBackingStore::getPrimaryKeyViaIndex):
        (WebCore::IDBSQLiteBackingStore::keyExistsInIndex):
        (WebCore::IDBSQLiteBackingStore::openObjectStoreCursor):
        (WebCore::IDBSQLiteBackingStore::openIndexKeyCursor):
        (WebCore::IDBSQLiteBackingStore::openIndexCursor):
        (WebCore::IDBSQLiteBackingStore::createTransaction):
        * storage/IDBSQLiteBackingStore.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-11 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Fri, 11 Mar 2011 09:44:58 +0000 (09:44 +0000)]
2011-03-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Unreviewed build error fix.

        [EFL] Fix build break when SHARED_CORE is ON
        https://bugs.webkit.org/show_bug.cgi?id=56155

        * platform/efl/ContextMenuEfl.cpp:
        (WebCore::ContextMenu::ContextMenu):
        * platform/efl/ContextMenuItemEfl.cpp:
        (WebCore::ContextMenuItem::nativeMenuItem):
        (WebCore::ContextMenuItem::ContextMenuItem):
        (WebCore::ContextMenuItem::~ContextMenuItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-11 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 11 Mar 2011 09:28:38 +0000 (09:28 +0000)]
2011-03-11  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: resource load cancellation is reported to console as an error
        https://bugs.webkit.org/show_bug.cgi?id=55764

        - mark interruptionForPolicyChangeError as cancellation
        - do not log resource cancelation as an error
        - always push resource to front-end before console message, so front-end can use resource info while formatting message.

        * inspector/InspectorConsoleAgent.cpp:
        (WebCore::InspectorConsoleAgent::didFailLoading):
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
        (WebCore::InspectorInstrumentation::didFailLoadingImpl):
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::stopLoadingForPolicyChange):

2011-03-11  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: resource load cancellation is reported to console as an error
        https://bugs.webkit.org/show_bug.cgi?id=55764

        * http/tests/inspector/console-resource-errors-expected.txt:
        * http/tests/inspector/console-resource-errors.html: Added test for lack of console messages during policy change (at download)
        * http/tests/inspector/console-xhr-logging-expected.txt:
        * http/tests/inspector/console-xhr-logging.html: Added test for reporting of cross-origin XHR errors.
        * http/tests/inspector/resources/empty.zip: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Fri, 11 Mar 2011 09:02:37 +0000 (09:02 +0000)]
2011-03-10  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Get rid of has/add/removeStyleClass() methods on Element.prototype - Step 1
        https://bugs.webkit.org/show_bug.cgi?id=56096

        No new tests, as this is a refactoring.

        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.EventListenerBreakpointsSidebarPane):
        * inspector/front-end/DetailedHeapshotView.js:
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel):
        (WebInspector.BaseStorageTreeElement):
        (WebInspector.BaseStorageTreeElement.prototype.onattach):
        (WebInspector.StorageCategoryTreeElement):
        (WebInspector.FrameTreeElement):
        (WebInspector.FrameResourceTreeElement):
        (WebInspector.DatabaseTreeElement):
        (WebInspector.DatabaseTableTreeElement):
        (WebInspector.DOMStorageTreeElement):
        (WebInspector.CookieTreeElement):
        (WebInspector.ApplicationCacheTreeElement):
        (WebInspector.ResourceRevisionTreeElement):
        * inspector/front-end/utilities.js:
        (Element.prototype.removeStyleClass):
        (Element.prototype.addStyleClass):
        (Element.prototype.hasStyleClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-11 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 11 Mar 2011 08:20:26 +0000 (08:20 +0000)]
2011-03-11  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        kill hung lighttpd processes on the chromium win bot
        https://bugs.webkit.org/show_bug.cgi?id=56152

        Sometimes this process doesn't exit and it holds on to
        a log file that we can't delete or copy, causing the tests
        to go red.

        * BuildSlaveSupport/win/kill-old-processes:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/9120161> WKPageRestoreFromSessionState does not set the pending API...
mrowe@apple.com [Fri, 11 Mar 2011 08:17:05 +0000 (08:17 +0000)]
<rdar://problem/9120161> WKPageRestoreFromSessionState does not set the pending API request URL.

Reviewed by Alice Liu.

* UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::restoreFromSessionStateData): If we're navigating to a back/forward item
as part of the restoration, call setPendingAPIRequestURL. When there's a provisional URL this will
be done by our call to loadURL elsewhere in the function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-11 Ilya Sherman <isherman@chromium.org>
commit-queue@webkit.org [Fri, 11 Mar 2011 08:11:57 +0000 (08:11 +0000)]
2011-03-11  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] missing HTMLInputElement::setValueForUser() to tests
        https://bugs.webkit.org/show_bug.cgi?id=55854

        * platform/chromium/test_expectations.txt: Removed onchange-setvalueforuser.html
2011-03-11  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] missing HTMLInputElement::setValueForUser() to tests
        https://bugs.webkit.org/show_bug.cgi?id=55854

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::setValueForUser): Added.
        * DumpRenderTree/chromium/LayoutTestController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-11 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Fri, 11 Mar 2011 08:10:15 +0000 (08:10 +0000)]
2011-03-11  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip
        tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody.html
        on GTK again after being unskipped by accident in r80738.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-11 Brian Salomon <bsalomon@google.com>
commit-queue@webkit.org [Fri, 11 Mar 2011 08:06:49 +0000 (08:06 +0000)]
2011-03-11  Brian Salomon  <bsalomon@google.com>

        Reviewed by Kenneth Russell.

        Adds GrContext flush call to PlatformContextSkia destructor.
Calls GrContext flush with int parameter instead of bool due to skia
revision.

        No new tests needed.

        * platform/graphics/chromium/DrawingBufferChromium.cpp:
        (WebCore::DrawingBuffer::publishToPlatformLayer):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::~PlatformContextSkia):
        (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Alexey Proskuryakov <ap@apple.com>
ap@apple.com [Fri, 11 Mar 2011 07:54:52 +0000 (07:54 +0000)]
2011-03-10  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Jon Honeycutt.

        WebKit2 UI process crashes if web process crashes while computing page rects for printing
        https://bugs.webkit.org/show_bug.cgi?id=56160
        <rdar://problem/9027410>

        * UIProcess/API/mac/WKPrintingView.mm:
        (-[WKPrintingView _suspendAutodisplay]): Added a null check for page, matching one that
        we have when resuming autodisplay.
        (-[WKPrintingView _delayedResumeAutodisplayTimerFired]): Added a FIXME.
        (pageDidComputePageRects): Sanitize results coming from the web process (and avoid crashing
        when there is a communication error, so results are all null).
        (-[WKPrintingView knowsPageRange:]): If there is no page any more, we can't tell how many
        pages it had.
        (-[WKPrintingView rectForPage:]): Handle the case where we are neither calculating pages
        nor knowing them, as it happens when the web process crashes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Chris Guillory <chris.guillory@google.com>
commit-queue@webkit.org [Fri, 11 Mar 2011 07:45:00 +0000 (07:45 +0000)]
2011-03-10  Chris Guillory  <chris.guillory@google.com>

        Reviewed by James Robinson.

        Fix for Coverity discovered NO_EFFECT (self-assign) defect.
        https://bugs.webkit.org/show_bug.cgi?id=54143

        * platform/graphics/gpu/TilingData.cpp:
        (WebCore::TilingData::setMaxTextureSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Fri, 11 Mar 2011 07:38:07 +0000 (07:38 +0000)]
2011-03-10  Emil A Eklund  <eae@chromium.org>

        Reviewed by Alexey Proskuryakov.

        The web colours palevioletred and mediumpurple are incorrect
        https://bugs.webkit.org/show_bug.cgi?id=46658

        Added test for named colors.

        * fast/css/named-colors-expected.txt: Added.
        * fast/css/named-colors.html: Added.
2011-03-10  Emil A Eklund  <eae@chromium.org>

        Reviewed by Alexey Proskuryakov.

        The web colours palevioletred and mediumpurple are incorrect
        https://bugs.webkit.org/show_bug.cgi?id=46658

        Changed value for the palevioletred and mediumpurple colors to match
        the css3 specification.

        Test: fast/css/named-colors.html

        * inspector/front-end/Color.js:
        * platform/ColorData.gperf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Fri, 11 Mar 2011 07:27:11 +0000 (07:27 +0000)]
2011-03-10  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed: update Chromium test expectations.

        * platform/chromium-linux/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Added.
        * platform/chromium-linux/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Added.
        * platform/chromium-mac/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Added.
        * platform/chromium-mac/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Added.
        * platform/chromium-mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Added.
        * platform/chromium-mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Added.
        * platform/chromium-mac/fast/js/kde/function_length-expected.txt: Removed.
        * platform/chromium-win/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Added.
        * platform/chromium-win/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Added.
        * platform/chromium-win/fast/block/basic/percent-height-inside-anonymous-block-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/static-distance-with-positioned-ancestor-expected.txt: Added.
        * platform/chromium-win/fast/js/kde/function_length-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 11 Mar 2011 07:24:16 +0000 (07:24 +0000)]
2011-03-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        document.compatMode is incorrect for javascript: protocol URLs in IFRAMEs
        https://bugs.webkit.org/show_bug.cgi?id=27845

        This bug was randomly fixed by the HTML5 parser.

        * fast/parser/javascript-url-compat-mode-expected.txt: Added.
        * fast/parser/javascript-url-compat-mode.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Ami Fischman <fischman@google.com>
commit-queue@webkit.org [Fri, 11 Mar 2011 07:13:50 +0000 (07:13 +0000)]
2011-03-10  Ami Fischman  <fischman@google.com>

        Reviewed by David Levin.

        video-controls-in-media-document.html used to silently rely on
        timeupdate firing immediately upon playback start, and before any
        frames changed.  This was (unsurprisingly, in retrospect)
        super-brittle.  This change instead uses an explicit seek to put
        the video in a predictable state.  The expected.png change is only to
        change the "pause" button to "play" (which is part of what's
        required to have the video be in a predictable state for the pixel
        diff).  An equivalent rebaselining needs to happen for chromium
        mac & win.

        * media/video-controls-in-media-document.html:
        * platform/chromium/media/video-controls-in-media-document-expected.checksum:
        * platform/chromium/media/video-controls-in-media-document-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Fri, 11 Mar 2011 07:09:51 +0000 (07:09 +0000)]
2011-03-10  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed: tweak Chromium test_expectations.txt

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 David Boddie <david.boddie@nokia.com>
commit-queue@webkit.org [Fri, 11 Mar 2011 07:02:28 +0000 (07:02 +0000)]
2011-03-10  David Boddie <david.boddie@nokia.com>

        Reviewed by Andreas Kling.

        Fixed a qdoc warning and terminology (WebKit instead of Webkit).
        https://bugs.webkit.org/show_bug.cgi?id=55756

        * Api/qwebhistoryinterface.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Peter Kasting <pkasting@google.com>
commit-queue@webkit.org [Fri, 11 Mar 2011 06:45:31 +0000 (06:45 +0000)]
2011-03-10  Peter Kasting  <pkasting@google.com>

        Reviewed by Dimitri Glazkov.

        Clean up some gross code in TestShellWin.cpp.  No functional change.
        https://bugs.webkit.org/show_bug.cgi?id=56048

        * DumpRenderTree/chromium/TestShellWin.cpp:
        (checkLayoutTestSystemDependencies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Keith Kyzivat <keith.kyzivat@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 11 Mar 2011 06:34:44 +0000 (06:34 +0000)]
2011-03-10  Keith Kyzivat  <keith.kyzivat@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian)

        * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
        (WTR::activateFonts): Guard X11-specific code with Q_WS_X11.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Fri, 11 Mar 2011 05:49:26 +0000 (05:49 +0000)]
2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Unreviewed build fix.

        [WML] Fix build error
        https://bugs.webkit.org/show_bug.cgi?id=56078

        * wml/WMLInputElement.cpp:
        (WebCore::WMLInputElement::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Jeremy Moskovich <jeremy@chromium.org>
jeremy@chromium.org [Fri, 11 Mar 2011 05:36:37 +0000 (05:36 +0000)]
2011-03-10  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Darin Adler.

        Fix navigation menus on a bunch of sites in WebKit.
        https://bugs.webkit.org/show_bug.cgi?id=52535

        Add test to make sure that offsetLeft matches FF/IE for a relatively
        positioned TD and IFRAME elements.
        Testcase is a reduction from doula.co.il.

        * fast/block/positioning/offsetLeft-relative-iframe-expected.txt: Added.
        * fast/block/positioning/offsetLeft-relative-iframe.html: Added.
        * fast/block/positioning/offsetLeft-relative-td-expected.txt: Added.
        * fast/block/positioning/offsetLeft-relative-td.html: Added.
2011-03-10  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Darin Adler.

        Fix navigation menus on a bunch of sites in WebKit.
        https://bugs.webkit.org/show_bug.cgi?id=52535

        WebKit doesn't support position:relative for several table elements and
        overwrites the style internally when position:relative is encountered.
        Unfortunately position:relative affects the choice of nodes returned by
        offsetParent.

        This CL adds a bit to RenderStyle to track whether position:relative was
        overwritten.  The value is then consulted in offsetParent which makes us
        match FF/IE.

        Tests: fast/block/positioning/offsetLeft-relative-iframe.html
               fast/block/positioning/offsetLeft-relative-td.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::adjustRenderStyle):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::isOriginallyRelPositioned):
        (WebCore::RenderObject::offsetParent):
        * rendering/RenderObject.h:
        * rendering/style/RenderStyle.h: Add a bit to track the original value of position:relative.
        (WebCore::InheritedFlags::positionWasRelative):
        (WebCore::InheritedFlags::setPositionWasRelative):
        * rendering/style/StyleRareNonInheritedData.cpp:
        (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
        (WebCore::StyleRareNonInheritedData::operator==):
        * rendering/style/StyleRareNonInheritedData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Fri, 11 Mar 2011 05:23:42 +0000 (05:23 +0000)]
2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Make single backing store the default for EWebLauncher
        https://bugs.webkit.org/show_bug.cgi?id=55753

        Set single backing store the default for EWebLauncher.

        * EWebLauncher/main.c:
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 11 Mar 2011 05:07:31 +0000 (05:07 +0000)]
2011-03-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        REGRESSION (r66428/r71892): Crash after assertion failure (!m_reachedTerminalState) in ResourceLoader::didCancel()
        https://bugs.webkit.org/show_bug.cgi?id=51357

        Test that we don't crash when calling close immedately after print.

        * printing/print-close-crash-expected.txt: Added.
        * printing/print-close-crash.html: Added.
2011-03-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        REGRESSION (r66428/r71892): Crash after assertion failure (!m_reachedTerminalState) in ResourceLoader::didCancel()
        https://bugs.webkit.org/show_bug.cgi?id=51357

        Previously, we would try to print from a callstack that didn't want a
        nested event loop, leading to re-entrancy problems.  In this patch, we
        complete the print call asynchronously, giving us a clean stack on
        which to run the nested event loop.

        Test: printing/print-close-crash.html

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::DOMWindow):
        (WebCore::DOMWindow::print):
        (WebCore::DOMWindow::printTimerFired):
        * page/DOMWindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-11 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Fri, 11 Mar 2011 04:46:23 +0000 (04:46 +0000)]
2011-03-11  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Ryosuke Niwa.

        Bug 55570 - Remove dependency of dom/InputElement.cpp on html/ and wml/
        https://bugs.webkit.org/show_bug.cgi?id=55570

        Add a virtual function toInputElement() to Node that has a default
        implementation of returning 0.
        For HTMLInputElement and WMLInputElement (which derive from InputElement)
        override this to return the object.
        Change all calling sites of the old toInputElement to use the new member
        function. This also allows us to save some casts.

        No new tests. (refactoring)

        * WebCore.exp.in:
        * accessibility/AXObjectCache.cpp:
        (WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::isPasswordField):
        (WebCore::AccessibilityRenderObject::isIndeterminate):
        (WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
        (WebCore::AccessibilityRenderObject::isChecked):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::canShareStyleWithElement):
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
        * dom/CheckedRadioButtons.cpp:
        (WebCore::CheckedRadioButtons::removeButton):
        * dom/InputElement.cpp:
        * dom/InputElement.h:
        * dom/Node.cpp:
        (WebCore::Node::toInputElement):
        * dom/Node.h:
        * html/HTMLInputElement.h:
        (WebCore::HTMLInputElement::toInputElement):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::inputElement):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::isChecked):
        (WebCore::RenderTheme::isIndeterminate):
        * wml/WMLInputElement.h:
        (WebCore::WMLInputElement::toInputElement):
2011-03-11  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Ryosuke Niwa.

        Bug 55570 - Remove dependency of dom/InputElement.cpp on html/ and wml/
        https://bugs.webkit.org/show_bug.cgi?id=55570

        Add a virtual function toInputElement() to Node that has a default
        implementation of returning 0.
        For HTMLInputElement and WMLInputElement (which derive from InputElement)
        override this to return the object.
        Change all calling sites of the old toInputElement to use the new member
        function. This also allows us to save some casts.

        No new tests (refactoring).

        * src/WebInputElement.cpp:
        (WebKit::toWebInputElement):
2011-03-11  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Ryosuke Niwa.

        Bug 55570 - Remove dependency of dom/InputElement.cpp on html/ and wml/
        https://bugs.webkit.org/show_bug.cgi?id=55570

        Add a virtual function toInputElement() to Node that has a default
        implementation of returning 0.
        For HTMLInputElement and WMLInputElement (which derive from InputElement)
        override this to return the object.
        Change all calling sites of the old toInputElement to use the new member
        function. This also allows us to save some casts.

        No new tests (refactoring).

        * src/WebInputElement.cpp:
        (WebKit::toWebInputElement):

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::setValueForUser):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Takayoshi Kochi <kochi@chromium.org>
commit-queue@webkit.org [Fri, 11 Mar 2011 04:44:43 +0000 (04:44 +0000)]
2011-03-10  Takayoshi Kochi  <kochi@chromium.org>

        Reviewed by Tony Chang.

        Remove default parameter declaration for familiForChars(), which is no longer necessary.

        * public/gtk/WebFontInfo.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Fri, 11 Mar 2011 04:31:30 +0000 (04:31 +0000)]
2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] New mediaControl css file for EFL
        https://bugs.webkit.org/show_bug.cgi?id=55460

        Add new mediaControl css file for html5 video UI.

        * CMakeLists.txt:
        * CMakeListsEfl.txt:
        * css/mediaControlsEfl.css: Added.
        (audio):
        (audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
        (video:-webkit-full-page-media::-webkit-media-controls-panel):
        (audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
        (audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
        (audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
        (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
        (audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
        (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
        (audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
        (audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
        (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
        (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
        (audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
        (audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button):
        (audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button):
        (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
        (audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
        * platform/efl/RenderThemeEfl.cpp:
        (WebCore::RenderThemeEfl::extraMediaControlsStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Fri, 11 Mar 2011 04:22:49 +0000 (04:22 +0000)]
2011-03-10  Emil A Eklund  <eae@chromium.org>

        Reviewed by Dimitri Glazkov.

        style.display affecting the initial selectedIndex value of a <select> when it's multiple attribute is set programatically
        https://bugs.webkit.org/show_bug.cgi?id=53860

        Add tests for selectedIndex when changing the multiple property on a select element.

        * fast/dom/HTMLSelectElement/change-multiple-preserve-selection-expected.txt: Added.
        * fast/dom/HTMLSelectElement/change-multiple-preserve-selection.html: Added.
2011-03-10  Emil A Eklund  <eae@chromium.org>

        Reviewed by Dimitri Glazkov.

        style.display affecting the initial selectedIndex value of a <select> when its multiple attribute is set programatically
        https://bugs.webkit.org/show_bug.cgi?id=53860

        Preserve selection when changing between multi-select and single-select
        for <select> boxes even if it has not yet been rendered.

        Test: fast/dom/HTMLSelectElement/change-multiple-preserve-selection.html

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::setMultiple):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 11 Mar 2011 04:16:43 +0000 (04:16 +0000)]
2011-03-10  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        update comment to reference new DOM Core spec
        https://bugs.webkit.org/show_bug.cgi?id=56079

        I'm excising all instances of WRONG_DOCUMENT_ERR from WebKit.
        This is the only one that's actually specified to fire
        in the latest DOM Core spec.

        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::createDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Rik Cabanier <cabanier@gmail.com>
commit-queue@webkit.org [Fri, 11 Mar 2011 04:09:05 +0000 (04:09 +0000)]
2011-03-10  Rik Cabanier  <cabanier@gmail.com>

        Reviewed by Tony Gentilcore.

        Fix that allows fixed length values to be floating point
        https://bugs.webkit.org/show_bug.cgi?id=52699

        Transitions now return matrices in floating point. 2 of the transition tests were failing
        because they expected integer values.

        * transitions/matched-transform-functions.html:
        * transitions/retargetted-transition.html:
2011-03-10  Rik Cabanier  <cabanier@gmail.com>

        Reviewed by Tony Gentilcore.

        Fix that allows fixed length values to be floating point
        https://bugs.webkit.org/show_bug.cgi?id=52699

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSStyleSelector.cpp:
        (WebCore::convertToLength):
        (WebCore::convertToIntLength):
        (WebCore::convertToFloatLength):
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::createTransformOperations):
        * platform/Length.h:
        (WebCore::Length::Length):
        (WebCore::Length::operator==):
        (WebCore::Length::operator!=):
        (WebCore::Length::rawValue):
        (WebCore::Length::type):
        (WebCore::Length::quirk):
        (WebCore::Length::setValue):
        (WebCore::Length::calcFloatValue):
        (WebCore::Length::isZero):
        (WebCore::Length::blend):
        (WebCore::Length::getIntValue):
        (WebCore::Length::getFloatValue):
        * rendering/AutoTableLayout.cpp:
        (WebCore::AutoTableLayout::recalcColumn):
        (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
        * rendering/FixedTableLayout.cpp:
        (WebCore::FixedTableLayout::calcWidthArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 11 Mar 2011 03:52:53 +0000 (03:52 +0000)]
2011-03-10  Ryosuke Niwa  <rniwa@webkit.org>

        Added 3 http tests to Windows port's skipped list.
        Tracked by https://bugs.webkit.org/show_bug.cgi?id=56167

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Sheriff Bot <webkit.review.bot@gmail.com>
rniwa@webkit.org [Fri, 11 Mar 2011 03:03:43 +0000 (03:03 +0000)]
2011-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80800.
        http://trac.webkit.org/changeset/80800
        https://bugs.webkit.org/show_bug.cgi?id=56163

        Caused hundreds of tests to crash on Windows 7 (Requested by
        rniwa on #webkit).

        * page/EventHandler.cpp:
        (WebCore::EventHandler::mouseMoved):
        (WebCore::EventHandler::updateMouseEventTargetNode):
        * page/FocusController.cpp:
        (WebCore::FocusController::setActive):
        * page/FrameView.cpp:
        (WebCore::FrameView::FrameView):
        (WebCore::FrameView::~FrameView):
        * page/FrameView.h:
        * page/Page.cpp:
        * page/Page.h:
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::wheelEvent):
        * platform/ScrollView.h:
        * rendering/RenderDataGrid.cpp:
        (WebCore::RenderDataGrid::RenderDataGrid):
        (WebCore::RenderDataGrid::~RenderDataGrid):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::RenderLayer):
        (WebCore::RenderLayer::~RenderLayer):
        * rendering/RenderLayer.h:
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::RenderListBox):
        (WebCore::RenderListBox::~RenderListBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Alice Boxhall <aboxhall@chromium.org>
commit-queue@webkit.org [Fri, 11 Mar 2011 02:17:14 +0000 (02:17 +0000)]
2011-03-10  Alice Boxhall  <aboxhall@chromium.org>

        Reviewed by Dimitri Glazkov.

        NULL pointer crash when using :empty and :first-line pseudoclass selectors together
        https://bugs.webkit.org/show_bug.cgi?id=53316

        * fast/css/empty-first-line-crash-expected.txt: Added.
        * fast/css/empty-first-line-crash.html: Added.
2011-03-10  Alice Boxhall  <aboxhall@chromium.org>

        Reviewed by Dimitri Glazkov.

        NULL pointer crash when using :empty and :first-line pseudoclass selectors together
        https://bugs.webkit.org/show_bug.cgi?id=53316

        :empty is calculated for each element during parsing, but then not
        recalculated after any child elements are attached. Force style
        re-calculation on elements which have :empty in their style when
        their children are changed.

        Test: fast/css/empty-first-line-crash.html

        * dom/Element.cpp:
        (WebCore::checkForEmptyStyleChange): Pull out empty style checking
        logic from checkForSiblingStyleChanges().
        (WebCore::checkForSiblingStyleChanges): Use new checkForEmptyStyleChanges()
        method.
        (WebCore::Element::childrenChanged):  Call checkForEmptyStyleChanges() when
        called with changedByParser = true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Fri, 11 Mar 2011 02:13:26 +0000 (02:13 +0000)]
2011-03-10  Emil A Eklund  <eae@chromium.org>

        Unreviewed build fix.

        Fix Leopard Release build broken by r80797.

        * html/CollectionCache.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPart of <rdar://problem/8728860> WebKit2 needs to be made localizable
mrowe@apple.com [Fri, 11 Mar 2011 01:58:13 +0000 (01:58 +0000)]
Part of <rdar://problem/8728860> WebKit2 needs to be made localizable

Rubber-stamped by Sam Weinig.

The presence of CFBundleDevelopmentRegion in the application's Info.plist prevents
the default localization that we set during launch from being respected.

* PluginProcess/Info.plist: Remove CFBundleDevelopmentRegion.
* WebProcess/Info.plist: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix for <rdar://problem/8944558> Overlay scrollers in overflow areas need to
bdakin@apple.com [Fri, 11 Mar 2011 01:53:43 +0000 (01:53 +0000)]
Fix for <rdar://problem/8944558> Overlay scrollers in overflow areas need to
send notifications appropriate times (showing up, resizing)
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=56067

Reviewed by Darin Adler.

The general strategy here is to add a HashSet of ScrollableAreas to the page that
can be accessed when necessary to send notifications to all ScrollableAreas.

Find layers for relevant node and if the layers are in the Page's ScrollableArea
set, then send the relevant notification.
* page/EventHandler.cpp:
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::updateMouseEventTargetNode):

When the page is set active or not active, iterate through the Page's
ScrollableAreas to send hide/show notifications.
* page/FocusController.cpp:
(WebCore::FocusController::setActive):

When a FrameView is created, add it to the ScrollableArea set. When it's
destroyed, remove it.
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::~FrameView):

Iterate through the Page's ScrollableAreas to send the paint notification.
(WebCore::FrameView::notifyPageThatContentAreaWillPaint):
* page/FrameView.h:

Add the new ScrollableArea set.
* page/Page.cpp:
(WebCore::Page::addScrollableArea):
(WebCore::Page::removeScrollableArea):
(WebCore::Page::pageContainsScrollableArea):
* page/Page.h:
(WebCore::Page::scrollableAreaSet):

notifyPageThatContentAreaWillPaint() is a dummy function implemented in FrameView.
* platform/ScrollView.cpp:
(WebCore::ScrollView::notifyPageThatContentAreaWillPaint):

Call notifyPageThatContentAreaWillPaint() instead of calling
contentAreaWillPaint() just for the ScrollView.
(WebCore::ScrollView::paint):
* platform/ScrollView.h:

Add/remove ScrollableAreas to the set.
* rendering/RenderDataGrid.cpp:
(WebCore::RenderDataGrid::RenderDataGrid):
(WebCore::RenderDataGrid::~RenderDataGrid):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::~RenderListBox):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):

Should have implemented this ScrollableArea-interface function a while ago.
(WebCore::RenderLayer::currentMousePosition):
* rendering/RenderLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 11 Mar 2011 01:50:27 +0000 (01:50 +0000)]
2011-03-10  Martin Robinson  <mrobinson@igalia.com>

        Rebaseline a test which differs on the bots from my local machine.

        * platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Update results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 takano takumi <takano@apple.com>
commit-queue@webkit.org [Fri, 11 Mar 2011 01:48:36 +0000 (01:48 +0000)]
2011-03-10  takano takumi  <takano@apple.com>

        Reviewed by David Hyatt.

        Crash in RenderCombineText::combineText when running fast/text/international/text-combine-parser-test.html on Windows with full page heap enabled
        https://bugs.webkit.org/show_bug.cgi?id=55069

        * platform/win/Skipped: Removed text-combine-parser-test.html
2011-03-10  takano takumi  <takano@apple.com>

        Reviewed by David Hyatt.

        Crash in RenderCombineText::combineText when running fast/text/international/text-combine-parser-test.html on Windows with full page heap enabled
        https://bugs.webkit.org/show_bug.cgi?id=55069

        No new tests. If the test above runs without crash, the fix should be okay.

        * dom/Node.cpp:
        (WebCore::Node::diff):
        - Changed to return Detach when textCombine style was changed.
        * rendering/RenderCombineText.cpp:
        (WebCore::RenderCombineText::styleDidChange):
        (WebCore::RenderCombineText::setTextInternal):
        (WebCore::RenderCombineText::width):
        (WebCore::RenderCombineText::adjustTextOrigin):
        (WebCore::RenderCombineText::charactersToRender):
        (WebCore::RenderCombineText::combineText):
        - Added assertions to ensure the passed object is RenderCombineText.
        * rendering/RenderCombineText.h:
        (WebCore::RenderCombineText::isCombineText):
        - Added to distinguish plain RenderText and RenderCombineText.
        (WebCore::toRenderCombineText):
        - Added assertions to ensure the passed object is RenderCombineText.
        * rendering/RenderObject.h:
        (WebCore::RenderObject::isCombineText):
        - Added to distinguish plain RenderText and RenderCombineText.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Fri, 11 Mar 2011 01:46:48 +0000 (01:46 +0000)]
2011-03-10  Emil A Eklund  <eae@chromium.org>

        Reviewed by Darin Adler.

        Collection cache not reset when moving base node between documents
        https://bugs.webkit.org/show_bug.cgi?id=55446

        Add tests for accessing elements moved across documents using namedItem.

        * fast/dom/HTMLFormElement/invalid-form-field-expected.txt: Added.
        * fast/dom/HTMLFormElement/invalid-form-field.html: Added.
        * fast/dom/HTMLFormElement/move-option-between-documents-expected.txt: Added.
        * fast/dom/HTMLFormElement/move-option-between-documents.html: Added.
        * fast/dom/collection-nameditem-move-between-documents-expected.txt: Added.
        * fast/dom/collection-nameditem-move-between-documents.html: Added.
2011-03-10  Emil A Eklund  <eae@chromium.org>

        Reviewed by Darin Adler.

        Collection cache not reset when moving base node between documents
        https://bugs.webkit.org/show_bug.cgi?id=55446

        Fix bug where HTMLCollection::resetCollectionInfo does not reset the
        cache when the base node is moved to a different document by making sure
        that the DOMVersion is updated and that it's unique across documents.

        Tests: fast/dom/HTMLFormElement/invalid-form-field.html
               fast/dom/HTMLFormElement/move-option-between-documents.html
               fast/dom/collection-nameditem-move-between-documents.html

        * dom/Document.cpp:
        (WebCore::Document::Document):
        * dom/Document.h:
        (WebCore::Document::incDOMTreeVersion):
        (WebCore::Document::domTreeVersion):
        * dom/Node.cpp:
        (WebCore::Node::setDocumentRecursively):
        * html/FormAssociatedElement.cpp:
        (WebCore::FormAssociatedElement::resetFormOwner):
        * html/HTMLCollection.cpp:
        (WebCore::HTMLCollection::resetCollectionInfo):
        * xml/XPathResult.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
commit-queue@webkit.org [Fri, 11 Mar 2011 01:13:56 +0000 (01:13 +0000)]
2011-03-10  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Text layout is broken on Symbian
        https://bugs.webkit.org/show_bug.cgi?id=56046

        Change integers included into bitfields to be signed by default on RVCT
        compiler as a lot of other compilers do (gcc, msvc, winsc).
        There are a lot of places in webkit where integers included in bitfield
        are assumed to be signed.

        * Source/WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
commit-queue@webkit.org [Fri, 11 Mar 2011 00:56:37 +0000 (00:56 +0000)]
2011-03-10  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Adam Roben.

        Formatted Diff for attachment 23920 is mangled
        https://bugs.webkit.org/show_bug.cgi?id=21222

        The mangled diff files mentioned in the bug were using Mac line
        ending and this was causing problems for String#each_line. Now we
        normalize the line endings in patch data before processing it.

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Fri, 11 Mar 2011 00:56:09 +0000 (00:56 +0000)]
2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Unreviewed build fix.

        [EFL] Fix build break when CROSS_PLATFORM_CONTEXT_MENUS is disabled.
        https://bugs.webkit.org/show_bug.cgi?id=56005

        There are build breaks when CROSS_PLATFORM_CONTEXT_MENUS is disabled.

        * platform/efl/ContextMenuEfl.cpp:
        (WebCore::ContextMenu::ContextMenu):
        * platform/efl/ContextMenuItemEfl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 11 Mar 2011 00:52:53 +0000 (00:52 +0000)]
2011-03-10  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        startOfBlock and endOfBlock may return a position inside hr
        https://bugs.webkit.org/show_bug.cgi?id=56025

        Replaced calls to enclosingBlockFlowElement in startOfBlock and endOfBlock by
        calls to enclosingBlock. Added EditingBoundaryCrossingRule to the argument lists
        of startOfBlock, endOfBlock, and enclosingBlock. Also replaced the last boolean
        argument variable of enclosingNodeOfType by EditingBoundaryCrossingRule.

        Also replaced calls to enclosingBlockFlowElement in inSameBlock by calls to
        enclosingBlock to be consitent with startOfBlock and endOfBlock.

        This patch also replaced calls to deprecatedNode in startOfBlock, endOfBlock,
        and inSameBlock by calls to containerNode because the enclosing block of a position
        should never be before or after the position.

        No tests are added because this change only affects WebCore internally.

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::initializePositionData): Calls enclosingNodeOfType.
        Pass CanCrossEditingBoundary instead of false.
        * editing/htmlediting.cpp:
        (WebCore::unsplittableElementForPosition): Ditto.
        (WebCore::enclosingBlock): Takes EditingBoundaryCrossingRule and passes it to
        enclosingNodeOfType.
        (WebCore::enclosingNodeOfType): Takes EditingBoundaryCrossingRule instead of boolean.
        Fixed a bug that it stops walking the tree when it reached the root editable node
        even when the editing boundary crossing rule is CanCrossEditingBoundary.
        * editing/htmlediting.h: Prototype changes.
        * editing/visible_units.cpp:
        (WebCore::startOfBlock): Calls enclosingBlock instead of enclosingBlockFlowElement.
        Also added an early exit when there's no enclosing block.
        (WebCore::endOfBlock): Ditto. The early exist in this case prevents crash in
        lastPositionInNode.
        (WebCore::inSameBlock): Calls enclosingBlock instead of enclosingBlockFlowElement.
        (WebCore::isStartOfBlock): Calls startOfBlock with CanCrossEditingBoundary because
        we don't care where the start of block is when we're comparing against the given position.
        (WebCore::isEndOfBlock): Ditto.
        * editing/visible_units.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 11 Mar 2011 00:49:01 +0000 (00:49 +0000)]
2011-03-10  Martin Robinson  <mrobinson@igalia.com>

        Build for WebKit2 GTK+ after r80714.

        * GNUmakefile.am: Update source list.
        * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
        (WebKit::x11Display): Add missing semicolon.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Alexey Proskuryakov <ap@apple.com>
ap@apple.com [Fri, 11 Mar 2011 00:48:25 +0000 (00:48 +0000)]
2011-03-10  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Dan Bernstein.

        Backspace deletes all non-BMP symbols at once, and then some
        https://bugs.webkit.org/show_bug.cgi?id=55971
        <rdar://problem/8725312>

        * platform/mac/editing/input/insert-delete-smp-symbol-expected.txt: Added.
        * platform/mac/editing/input/insert-delete-smp-symbol.html: Added.
2011-03-10  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Dan Bernstein.

        Backspace deletes all non-BMP symbols at once, and then some
        https://bugs.webkit.org/show_bug.cgi?id=55971
        <rdar://problem/8725312>

        Test: platform/mac/editing/input/insert-delete-smp-symbol.html

        * rendering/RenderText.cpp:
        (WebCore::isMark): This matches what Core Foundation does for all characters that I tested.
        (WebCore::RenderText::previousOffsetForBackwardDeletion): Changed to use isMark().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (WebKit2): VoiceOver focus no longer follows keyboard focus
cfleizach@apple.com [Fri, 11 Mar 2011 00:40:05 +0000 (00:40 +0000)]
REGRESSION (WebKit2): VoiceOver focus no longer follows keyboard focus
https://bugs.webkit.org/show_bug.cgi?id=55959

Reviewed by Darin Adler.

NSApplication has to return the focused element within the app in order
for NSAccessibilityHandleFocusChanged() to work. The default implementation
relies on keyWindow. Consequently, in WK2, the WebProcess must override that method
to return the appropriate focused element within the WebProcess, since
there is no keyWindow.

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:
(-[AccessibilityWebPageObject accessibilityFocusedUIElement]):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::focusedWebPage):
* WebProcess/WebProcess.h:
* WebProcess/mac/NSApplicationOverride.mm: Added.
(-[NSApplication accessibilityFocusedUIElement]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Chris Evans <cevans@chromium.org>
inferno@chromium.org [Fri, 11 Mar 2011 00:36:29 +0000 (00:36 +0000)]
2011-03-10  Chris Evans  <cevans@chromium.org>

        Reviewed by Adam Barth.

        Error in StyleElement::process with large nodesets
        https://bugs.webkit.org/show_bug.cgi?id=56150

        Test: none due to excessive runtime and CRASH() vs. real crash.

        * dom/StyleElement.cpp:
        (WebCore::StyleElement::process): Handle large node sets better.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=47151
hyatt@apple.com [Fri, 11 Mar 2011 00:34:06 +0000 (00:34 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=47151

Reviewed by Simon Fraser.

Percentage heights should skip anonymous containing blocks when computing the used value.

Added fast/block/basic/percentage-height-inside-anonymous-block.html

Source/WebCore:

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePercentageLogicalHeight):

LayoutTests:

* fast/block/basic/percent-height-inside-anonymous-block.html: Added.
* platform/mac/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Added.
* platform/mac/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Added.
* platform/mac/fast/block/basic/percent-height-inside-anonymous-block-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Nat Duca <nduca@chromium.org>
commit-queue@webkit.org [Fri, 11 Mar 2011 00:32:13 +0000 (00:32 +0000)]
2011-03-10  Nat Duca  <nduca@chromium.org>

        Reviewed by James Robinson.

        [chromium] Make updateAndDrawLayers argumentless.
        https://bugs.webkit.org/show_bug.cgi?id=55985

        Made the TilePainters and viewport parameters for
        LayerRendererChromium member variables instead of arguments on
        updateAndDrawLayers. In a future change, this will allows us to
        draw the layer tree without the WebView's assistance.

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::create):
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::verticalScrollbarRect):
        (WebCore::LayerRendererChromium::horizontalScrollbarRect):
        (WebCore::LayerRendererChromium::invalidateRootLayerRect):
        (WebCore::LayerRendererChromium::updateRootLayerContents):
        (WebCore::LayerRendererChromium::updateRootLayerScrollbars):
        (WebCore::LayerRendererChromium::drawRootLayer):
        (WebCore::LayerRendererChromium::setViewport):
        (WebCore::LayerRendererChromium::updateAndDrawLayers):
        (WebCore::LayerRendererChromium::updateLayers):
        (WebCore::LayerRendererChromium::drawLayers):
        (WebCore::LayerRendererChromium::setRootLayer):
        (WebCore::LayerRendererChromium::getFramebufferPixels):
        (WebCore::LayerRendererChromium::cleanupSharedObjects):
        * platform/graphics/chromium/LayerRendererChromium.h:
        (WebCore::LayerRendererChromium::viewportSize):
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
        (WebCore::CCHeadsUpDisplay::draw):
2011-03-10  Nat Duca  <nduca@chromium.org>

        Reviewed by James Robinson.

        [chromium] Make updateAndDrawLayers argumentless.
        https://bugs.webkit.org/show_bug.cgi?id=55985

        Made the TilePainters and viewport parameters for
        LayerRendererChromium member variables instead of arguments on
        updateAndDrawLayers. In a future change, this will allows us to
        draw the layer tree without the WebView's assistance.

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::resize):
        (WebKit::WebViewImpl::paint):
        (WebKit::WebViewImpl::scrollRootLayerRect):
        (WebKit::WebViewImpl::invalidateRootLayerRect):
        (WebKit::WebViewImplContentPainter::create):
        (WebKit::WebViewImplContentPainter::paint):
        (WebKit::WebViewImplContentPainter::WebViewImplContentPainter):
        (WebKit::WebViewImplScrollbarPainter::create):
        (WebKit::WebViewImplScrollbarPainter::paint):
        (WebKit::WebViewImplScrollbarPainter::WebViewImplScrollbarPainter):
        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
        (WebKit::WebViewImpl::doComposite):
        (WebKit::WebViewImpl::reallocateRenderer):
        (WebKit::WebViewImpl::updateLayerRendererViewport):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Oleg Romashin <romaxa@gmail.com>
commit-queue@webkit.org [Fri, 11 Mar 2011 00:17:12 +0000 (00:17 +0000)]
2011-03-10  Oleg Romashin  <romaxa@gmail.com>

        Reviewed by Andreas Kling.

        Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1, part3
        Solving conflict of Qt and Xlib includes

        * Shared/Plugins/NPIdentifierData.cpp:
        * Shared/Plugins/NPIdentifierData.h:
        * Shared/Plugins/NPObjectProxy.cpp:
        * Shared/Plugins/NPVariantData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-25 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 11 Mar 2011 00:12:35 +0000 (00:12 +0000)]
2011-01-25  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Implement spin buttons for GTK+ 2.x
        https://bugs.webkit.org/show_bug.cgi?id=53098

        Unskip tests which are now passing with the spin button implementation.
        Add results for one test.

        * platform/gtk/Skipped: Unskip passing tests.
        * platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.checksum: Added.
        * platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Added.
        * platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Added.
2011-01-25  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Implement spin buttons for GTK+ 2.x
        https://bugs.webkit.org/show_bug.cgi?id=53098

        Implement spin buttons for GTK+ 2.x. This allows proper render and functioning
        for input type=number. The implementation is based on the one in gtkspinbutton.c
        from the GTK+ sources.

        * platform/gtk/RenderThemeGtk.h: Added new members and getters.
        * platform/gtk/RenderThemeGtk2.cpp:
        (WebCore::RenderThemeGtk::platformInit): Initialize spin button widget.
        (WebCore::RenderThemeGtk::adjustRepaintRect): We need to draw outside the
        spin button area to have proper rendering. There doesn't seem to be any other
        clean way of having spin buttons that are the size of the text input frame.
        (WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle): Added implementation.
        (WebCore::RenderThemeGtk::paintInnerSpinButton): Ditto.
        (WebCore::RenderThemeGtk::gtkSpinButton): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
commit-queue@webkit.org [Fri, 11 Mar 2011 00:05:57 +0000 (00:05 +0000)]
2011-03-10  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Adam Roben.

        PrettyPatch displays last two lines of a git-format-patch diff strangely
        https://bugs.webkit.org/show_bug.cgi?id=29317

        If the diff section has full range information, we parse only enough to cover the
        range. This avoids incorrectly showing trailing lines (like git signature) as part
        of the patch.

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Fri, 11 Mar 2011 00:05:14 +0000 (00:05 +0000)]
2011-03-10  Andreas Kling  <kling@webkit.org>

        Unreviewed build fix after r80774.

        QML property versioning is introduced in Qt 4.7.3, not 4.7.2.
        See also: http://bugreports.qt.nokia.com/browse/QTBUG-13451

        * declarative/plugin.cpp:
        (WebKitQmlPlugin::registerTypes):
        * declarative/qdeclarativewebview.cpp:
        * declarative/qdeclarativewebview_p.h:
        * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Thu, 10 Mar 2011 23:50:56 +0000 (23:50 +0000)]
2011-03-10  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Ryosuke Niwa.

        InsertUnorderedList over a non-editable region and multiple lines enters an infinite loop
        https://bugs.webkit.org/show_bug.cgi?id=53409

        Avoiding crashes and infinite loops when listifying content with mixed-editability

        * editing/execCommand/insert-list-with-noneditable-content-expected.txt: Added.
        * editing/execCommand/insert-list-with-noneditable-content.html: Added.
2011-03-10  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Ryosuke Niwa.

        InsertUnorderedList over a non-editable region and multiple lines enters an infinite loop
        https://bugs.webkit.org/show_bug.cgi?id=53409

        Fixing broken handling of mixed-editability content for InsertListCommand. Previously, if the selection
        spanned non-contenteditable regions, it would get stuck endlessly iterating the same region as the algorithm
        didn't skip the editable boundary.

        Test: editing/execCommand/insert-list-with-noneditable-content.html

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::cleanupAfterDeletion): Changed signature to take the destination
        position for the active editing command. Without this, there are cases when the destination happens
        to be a placeholder, and we remove it.
        (WebCore::CompositeEditCommand::moveParagraphs):
        * editing/CompositeEditCommand.h:
        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::doApply): Added logic to the paragraph iteration loop to handle pockets of
        non-editable content in an editable context. Previously, this could cause an infinite loop.
        * editing/visible_units.cpp:
        (WebCore::startOfParagraph): Added a mode of operation where we'll jump across non-editable
        content in the same paragraph to reach the actual editable paragraph start.
        (WebCore::endOfParagraph): Ditto.
        (WebCore::startOfNextParagraph): Now uses the aforementioned non-editable content skipping mode of
        endOfParagraph.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Berend-Jan Wever <skylined@chromium.org>
commit-queue@webkit.org [Thu, 10 Mar 2011 23:49:24 +0000 (23:49 +0000)]
2011-03-10  Berend-Jan Wever  <skylined@chromium.org>

        Reviewed by Darin Adler.

        Calling focus() on an area element not in a document should not cause a NULL ptr crash
        https://bugs.webkit.org/show_bug.cgi?id=54877

        * fast/dom/HTMLAreaElement: Added.
        * fast/dom/HTMLAreaElement/area-islink-focus-null-ptr-crash-expected.txt: Added.
        * fast/dom/HTMLAreaElement/area-islink-focus-null-ptr-crash.html: Added.
2011-03-10  Berend-Jan Wever  <skylined@chromium.org>

        Reviewed by Darin Adler.

        Calling focus() on an area element not in a document should not cause a NULL ptr crash
        https://bugs.webkit.org/show_bug.cgi?id=54877

        Test: fast/dom/HTMLAreaElement/area-islink-focus-null-ptr-crash.html

        * dom/Element.cpp:
        (WebCore::Element::focus): Check element is in the document before allowing focus
        * html/HTMLAreaElement.cpp:
        (WebCore::HTMLAreaElement::imageElement): Check element has a parent before checking if its parent is a map

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 10 Mar 2011 23:49:01 +0000 (23:49 +0000)]
2011-03-10  Ryosuke Niwa  <rniwa@webkit.org>

        Windows rebaselines for r80755.

        * platform/win/editing/selection/caret-ltr-right-expected.txt:
        * platform/win/editing/selection/caret-rtl-2-left-expected.txt:
        * platform/win/editing/selection/caret-rtl-right-expected.txt:
        * platform/win/fast/forms/file-input-disabled-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Xiyuan Xia <xiyuan@chromium.org>
tony@chromium.org [Thu, 10 Mar 2011 23:46:23 +0000 (23:46 +0000)]
2011-03-10  Xiyuan Xia  <xiyuan@chromium.org>

        Reviewed by Tony Chang.

        [Chromium] Fix default single selection select's popup background on chromium/linux
        https://bugs.webkit.org/show_bug.cgi?id=56023

        * fast/html/select-dropdown-consistent-background-color-expected.txt: Added.
        * fast/html/select-dropdown-consistent-background-color.html: Added.
2011-03-10  Xiyuan Xia  <xiyuan@chromium.org>

        Reviewed by Tony Chang.

        [Chromium] Fix default single selection select's popup background on chromium/linux
        https://bugs.webkit.org/show_bug.cgi?id=56023

        Test: fast/html/select-dropdown-consistent-background-color.html

        * css/themeChromiumLinux.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Kris Jordan <krisjordan@gmail.com>
commit-queue@webkit.org [Thu, 10 Mar 2011 23:43:48 +0000 (23:43 +0000)]
2011-03-10  Kris Jordan  <krisjordan@gmail.com>

        Reviewed by Alexey Proskuryakov.

        Testing the improved Accept header as per bug 27267.
        https://bugs.webkit.org/show_bug.cgi?id=27267

        * http/tests/misc/xhtml-expected.txt: Tests against improved Accept header.
2011-03-10  Kris Jordan  <krisjordan@gmail.com>

        Reviewed by Alexey Proskuryakov.

        Improve default Accept header to give preference to HTML over XML.
        https://bugs.webkit.org/show_bug.cgi?id=27267

        * loader/FrameLoader.cpp:Changed default accept header to match
        FireFox' as per bug 27267.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 10 Mar 2011 23:41:20 +0000 (23:41 +0000)]
2011-03-10  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] [Webkit2] There are no scrollbars visible in the MiniBrowser
        https://bugs.webkit.org/show_bug.cgi?id=56125

        No new tests. This functionality will be tested once we have TestRunner
        implementation for WebKit2 with pixel dumping support.

        * GNUmakefile.am: Add a new define with tracks whether or not we are using
        our specialized GTK+ ScrollView.
        * platform/ScrollView.cpp: Only use the GTK+-specific ScrollView if we are compiling
        WebKit1.
        (WebCore::ScrollView::wheelEvent):
        * platform/gtk/ScrollViewGtk.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Alexis Menard <alexis.menard@openbossa.org>
commit-queue@webkit.org [Thu, 10 Mar 2011 23:36:38 +0000 (23:36 +0000)]
2011-03-10  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] QtDeclarative Webview element has a fixed white background
        https://bugs.webkit.org/show_bug.cgi?id=40918

        Implement a way to change the background color of the WebView QML element.
        This feature is activated for QtWebKit 1.1 version of the plugin.

        * declarative/plugin.cpp:
        (WebKitQmlPlugin::registerTypes):
        * declarative/qdeclarativewebview.cpp:
        (QDeclarativeWebView::backgroundColor):
        (QDeclarativeWebView::setBackgroundColor):
        * declarative/qdeclarativewebview_p.h:
        * tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml: Added.
        * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
        (tst_QDeclarativeWebView::backgroundColor):
        * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 10 Mar 2011 23:32:54 +0000 (23:32 +0000)]
2011-03-10  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Assertion fails by validating a form twice very quickly
        https://bugs.webkit.org/show_bug.cgi?id=56069

        * fast/forms/interactive-validation-assertion-by-validate-twice-expected.txt: Added.
        * fast/forms/interactive-validation-assertion-by-validate-twice.html: Added.
        * fast/forms/interactive-validation-attach-assertion.html: Remove unnecessary offsetLeft trick.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-03-10  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Assertion fails by validating a form twice very quickly
        https://bugs.webkit.org/show_bug.cgi?id=56069

        If the interactive validation is invoked when a form control is in
        needsLayout() state, an assertion in isFocusable() fails. To avoid it,
        Add a call to updateLayoutIgnorePendingStylesheets() before isFocusable().

        Test: fast/forms/interactive-validation-assertion-by-validate-twice.html

        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::validateInteractively):
          Calls updateLayoutIgnorePendingStylesheets().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 10 Mar 2011 23:29:50 +0000 (23:29 +0000)]
2011-03-10  Martin Robinson  <mrobinson@igalia.com>

        Unskipping some crashers on GTK+. These no longer crash locally and we'd
        like to figure out if they still crash on the bots. Move one flaky test
        to the appropriate section.

        * platform/gtk/Skipped: Unskip tests passing locally.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Thu, 10 Mar 2011 23:23:10 +0000 (23:23 +0000)]
2011-03-10  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Limit touch events when only page required touch events.
        https://bugs.webkit.org/show_bug.cgi?id=54857

        Block touch events when ChromeClient::needTouchEvents got false.

        * WebCoreSupport/ChromeClientEfl.cpp:
        (WebCore::ChromeClientEfl::needTouchEvents):
        * WebCoreSupport/ChromeClientEfl.h:
        * ewk/ewk_frame.cpp:
        (ewk_frame_feed_touch_event):
        * ewk/ewk_private.h:
        * ewk/ewk_view.cpp:
        (ewk_view_need_touch_events_set):
        (ewk_view_need_touch_events_get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=47143
hyatt@apple.com [Thu, 10 Mar 2011 23:11:32 +0000 (23:11 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=47143

Reviewed by Beth Dakin.

Static distance computation is wrong when an ancestor is also positioned.  We need to go up the container()
chain (after initially starting with the parent()) when doing this computation, so that we properly skip
intermediate boxes between two positioned blocks.

Added fast/block/positioning/static-distance-with-positioned-ancestor.html.

Source/WebCore:

* rendering/RenderBox.cpp:
(WebCore::computeInlineStaticDistance):
(WebCore::computeBlockStaticDistance):

LayoutTests:

* fast/block/positioning/static-distance-with-positioned-ancestor.html: Added.
* platform/mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Added.
* platform/mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Added.
* platform/mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Stanislav Paltis <Stanislav.Paltis@nokia.com>
commit-queue@webkit.org [Thu, 10 Mar 2011 23:10:58 +0000 (23:10 +0000)]
2011-03-10  Stanislav Paltis  <Stanislav.Paltis@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] MemoryCache deadDecodedDataDeletionInterval is not exposed for client's usage
        https://bugs.webkit.org/show_bug.cgi?id=55945

        Added handling of dynamic/runtime property _q_deadDecodedDataDeletionInterval to
        set interval used to trigger when decoded data in dead list of object cache will
        be purged from object cache.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::dynamicPropertyChangeEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
commit-queue@webkit.org [Thu, 10 Mar 2011 22:54:13 +0000 (22:54 +0000)]
2011-03-10  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Antonio Gomes.

        Simplify how QWebFrame::requestedUrl() is obtained
        https://bugs.webkit.org/show_bug.cgi?id=55842

        When a load starts, store the requested URL until we know that it'll be
        available for us in the document loader -- after load finished.

        The existing auto tests cover the three different code paths in
        requestedUrl() and the new code passes the autotests. In each of those
        cases, we looked for the information in a different place, but in all
        of them, dispatchDidStartProvisionalLoad was called.

        This simplification will be useful to fix bug 32723. The way requestedUrl()
        is implementent, we can't use it as a fallback for url() when the setUrl()
        was called with an invalid URL.

        * Api/qwebframe.cpp:
        (QWebFrame::requestedUrl):
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
        (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
        * WebCoreSupport/FrameLoaderClientQt.h:
        (WebCore::FrameLoaderClientQt::lastRequestedUrl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Adrienne Walker <enne@google.com>
enne@google.com [Thu, 10 Mar 2011 22:47:40 +0000 (22:47 +0000)]
2011-03-10  Adrienne Walker  <enne@google.com>

        Reviewed by Kenneth Russell.

        [chromium] Make tiled compositor data structure more efficient.
        https://bugs.webkit.org/show_bug.cgi?id=54133

        Previously, the compositor had a sparse 2D array of tiles for the
        whole page, most of which were null.  The tiles were implicitly
        located based on their position in the array. This was inefficient
        when the page grew (e.g. infinite scrolling) and caused some bugs
        (e.g. width * height > MAX_INT).  This change modifies tiles to have
        explicit positions so they can be stored in a hash map.

        Tests: LayoutTests/compositing/

        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::reset):
        (WebCore::LayerTilerChromium::createTile):
        (WebCore::LayerTilerChromium::invalidateTiles):
        (WebCore::LayerTilerChromium::contentRectToTileIndices):
        (WebCore::LayerTilerChromium::tileAt):
        (WebCore::LayerTilerChromium::tileContentRect):
        (WebCore::LayerTilerChromium::tileLayerRect):
        (WebCore::LayerTilerChromium::invalidateRect):
        (WebCore::LayerTilerChromium::invalidateEntireLayer):
        (WebCore::LayerTilerChromium::update):
        (WebCore::LayerTilerChromium::updateFromPixels):
        (WebCore::LayerTilerChromium::draw):
        (WebCore::LayerTilerChromium::growLayerToContain):
        * platform/graphics/chromium/LayerTilerChromium.h:
        (WebCore::LayerTilerChromium::Tile::Tile):
        (WebCore::LayerTilerChromium::Tile::i):
        (WebCore::LayerTilerChromium::Tile::j):
        (WebCore::LayerTilerChromium::Tile::moveTo):
        (WebCore::LayerTilerChromium::TileMapKeyTraits::emptyValue):
        (WebCore::LayerTilerChromium::TileMapKeyTraits::constructDeletedValue):
        (WebCore::LayerTilerChromium::TileMapKeyTraits::isDeletedValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 10 Mar 2011 22:39:10 +0000 (22:39 +0000)]
2011-03-10  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed build fix for r80752; Negated the boolean logic.

        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::next):
        (WebCore::VisiblePosition::previous):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago- Fix plugins in release and production builds.
weinig@apple.com [Thu, 10 Mar 2011 22:28:02 +0000 (22:28 +0000)]
- Fix plugins in release and production builds.

Reviewed by Mark Rowe.

* WebKit2.xcodeproj/project.pbxproj:
Make sure to base the PluginProcess target on the correct xcconfig file
in all configurations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake the same change to xheight on Windows for CG.
hyatt@apple.com [Thu, 10 Mar 2011 22:24:41 +0000 (22:24 +0000)]
Make the same change to xheight on Windows for CG.

Reviewed by Adam Roben.

* platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::SimpleFontData::platformInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/9117047>
andersca@apple.com [Thu, 10 Mar 2011 22:17:12 +0000 (22:17 +0000)]
<rdar://problem/9117047>
Don't paint more than 60 times per second even when scrolling

Reviewed by Sam Weinig.

* WebView/WebClipView.mm:
(-[WebClipView _immediateScrollToPoint:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 10 Mar 2011 22:16:35 +0000 (22:16 +0000)]
2011-03-10  Tony Chang  <tony@chromium.org>

        Unreviewed, roll chromium version to r77259 to pick up
        webfontinfo api change.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=47147
hyatt@apple.com [Thu, 10 Mar 2011 22:13:25 +0000 (22:13 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=47147

Reviewed by Simon Fraser.

Fix for repaint issues when the root element is a table and needs to paint a background that
covers the entire canvas.  Remove paintRootBoxDecorations and replace with paintRootBoxFillLayers,
so that it can be called only for fill layer painting.  Make tables and normal boxes both
call this new method.  Fix the dirty check at the start of RenderTable paint to not happen if
the table is the root of the document (this same check exists in RenderBlock painting already).

Source/WebCore:

* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintRootBoxFillLayers):
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::paintBoxDecorationsWithSize):
* rendering/RenderBox.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::paint):
(WebCore::RenderTable::paintBoxDecorations):

LayoutTests:

* fast/backgrounds/positioned-root.html: Added.
* fast/backgrounds/table-root.html: Added.
* platform/mac/fast/backgrounds/positioned-root-expected.checksum: Added.
* platform/mac/fast/backgrounds/positioned-root-expected.png: Added.
* platform/mac/fast/backgrounds/positioned-root-expected.txt: Added.
* platform/mac/fast/backgrounds/table-root-expected.checksum: Added.
* platform/mac/fast/backgrounds/table-root-expected.png: Added.
* platform/mac/fast/backgrounds/table-root-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 10 Mar 2011 22:06:09 +0000 (22:06 +0000)]
2011-03-10  Mihai Parparita  <mihaip@chromium.org>

        Update chromium Snow Leopard expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Sheriff Bot <webkit.review.bot@gmail.com>
tonyg@chromium.org [Thu, 10 Mar 2011 22:00:05 +0000 (22:00 +0000)]
2011-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80749.
        http://trac.webkit.org/changeset/80749
        https://bugs.webkit.org/show_bug.cgi?id=56143

        "Caused at least 3 media tests to be flaky" (Requested by
        tonyg-cr on #webkit).

        * html/parser/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::canTakeNextToken):
        (WebCore::HTMLDocumentParser::pumpTokenizer):
        * html/parser/HTMLParserScheduler.cpp:
        * html/parser/HTMLParserScheduler.h:
        (WebCore::HTMLParserScheduler::checkForYieldBeforeToken):
        * page/FrameView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-10 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Thu, 10 Mar 2011 21:44:56 +0000 (21:44 +0000)]
2011-03-10  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, fixed Efl compilation after r80744.

        * Source/cmake/OptionsEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRegression: Content not drawn when scrolling horizontally in an RTL page
weinig@apple.com [Thu, 10 Mar 2011 21:43:37 +0000 (21:43 +0000)]
Regression: Content not drawn when scrolling horizontally in an RTL page
https://bugs.webkit.org/show_bug.cgi?id=55077

Reviewed by David Hyatt.

* platform/ScrollView.cpp:
(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::calculateOverhangAreasForPainting):
Take the scroll origin into account when calculating overhang.

* platform/ScrollView.h:
* rendering/RenderLayer.h:
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::scrollOrigin):
Move identical scroll origin member from ScrollView and RenderLayer
to shared base ScrollableArea. This is also needed so that the animator
can access it.

* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::pinnedInDirection):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
Account for a scroll origin when doing calculating scroll offsets.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-09 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Thu, 10 Mar 2011 21:41:00 +0000 (21:41 +0000)]
2011-03-09  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Plumb through settings for accelerated drawing for canvas
        https://bugs.webkit.org/show_bug.cgi?id=56039

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        * WebView/WebPreferencesPrivate.h:
2011-03-09  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Plumb through settings for accelerated drawing for canvas
        https://bugs.webkit.org/show_bug.cgi?id=56039

        No new tests. Doesn't affect behavior, just adding a switch to toggle canvas backends.

        * WebCore.exp.in:
        * html/HTMLCanvasElement.cpp:
        * html/canvas/CanvasRenderingContext2D.cpp:
        * page/Settings.cpp:
        * page/Settings.h:
2011-03-09  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Plumb through settings for accelerated drawing for canvas
        https://bugs.webkit.org/show_bug.cgi?id=56039

        * Shared/WebPreferencesStore.h:
        * UIProcess/API/C/WKPreferences.cpp:
        * UIProcess/API/C/WKPreferencesPrivate.h:
        * WebProcess/WebPage/WebPage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=47157
hyatt@apple.com [Thu, 10 Mar 2011 21:27:40 +0000 (21:27 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=47157

Reviewed by Simon Fraser.

CSS2.1 test suite failures because the ex unit is broken with the Ahem font.

Remove the code that tries to also include the maxX of the glyph bounds for the
'x' glyph, since it just causes the x-height to be way too large in cases where the 'x' glyph extends
below the baseline.

Remove the Apple Symbol hack for ex units, since the person who added that was confused by another
issue, namely that CGFontGetXHeight wasn't being properly multiplied by the pointSize.  That's why
the value was too small.  Patched the code to just multiply by pointSize and took out the hack.

Fix causes many tests in the css2.1 directory to progress, so no new tests required.  Many other
layout tests change because the xHeight for Lucida Grande gets smaller by a little bit, and radio
buttons use ex horizontal margins by default.

Source/WebCore:

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):

LayoutTests:

* platform/mac/accessibility/radio-button-group-members-expected.txt:
* platform/mac/css1/box_properties/acid_test-expected.txt:
* platform/mac/css1/font_properties/font_size-expected.txt:
* platform/mac/css1/text_properties/line_height-expected.txt:
* platform/mac/css1/text_properties/text_indent-expected.txt:
* platform/mac/css1/units/length_units-expected.txt:
* platform/mac/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
* platform/mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.txt:
* platform/mac/css2.1/t09-c5526c-display-00-e-expected.txt:
* platform/mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.txt:
* platform/mac/css2.1/t100801-c544-valgn-01-d-ag-expected.txt:
* platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
* platform/mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.txt:
* platform/mac/css2.1/t1507-c526-font-sz-02-b-a-expected.txt:
* platform/mac/css2.1/t1601-c547-indent-00-b-a-expected.txt:
* platform/mac/css2.1/t1604-c541-word-sp-00-b-a-expected.txt:
* platform/mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.txt:
* platform/mac/editing/selection/caret-ltr-2-expected.txt:
* platform/mac/editing/selection/caret-ltr-2-left-expected.txt:
* platform/mac/editing/selection/caret-ltr-expected.txt:
* platform/mac/editing/selection/caret-ltr-right-expected.txt:
* platform/mac/editing/selection/caret-rtl-2-expected.txt:
* platform/mac/editing/selection/caret-rtl-2-left-expected.txt:
* platform/mac/editing/selection/caret-rtl-expected.txt:
* platform/mac/editing/selection/caret-rtl-right-expected.txt:
* platform/mac/fast/block/basic/011-expected.txt:
* platform/mac/fast/block/margin-collapse/103-expected.txt:
* platform/mac/fast/css/ex-after-font-variant-expected.txt:
* platform/mac/fast/css/non-standard-checkbox-size-expected.txt:
* platform/mac/fast/forms/001-expected.txt:
* platform/mac/fast/forms/basic-inputs-expected.txt:
* platform/mac/fast/forms/box-shadow-override-expected.txt:
* platform/mac/fast/forms/checkbox-radio-onchange-expected.txt:
* platform/mac/fast/forms/file-input-disabled-expected.txt:
* platform/mac/fast/forms/form-element-geometry-expected.txt:
* platform/mac/fast/forms/formmove-expected.txt:
* platform/mac/fast/forms/formmove2-expected.txt:
* platform/mac/fast/forms/indeterminate-expected.txt:
* platform/mac/fast/forms/input-appearance-height-expected.txt:
* platform/mac/fast/forms/input-value-expected.txt:
* platform/mac/fast/forms/minWidthPercent-expected.txt:
* platform/mac/fast/forms/radio-attr-order-expected.txt:
* platform/mac/fast/forms/radio-nested-labels-expected.txt:
* platform/mac/fast/forms/radio_checked-expected.txt:
* platform/mac/fast/forms/radio_checked_dynamic-expected.txt:
* platform/mac/fast/inline/positionedLifetime-expected.txt:
* platform/mac/fast/lists/008-expected.txt:
* platform/mac/fast/lists/008-vertical-expected.txt:
* platform/mac/fast/media/mq-relative-constraints-08-expected.txt:
* platform/mac/fast/overflow/overflow-rtl-expected.txt:
* platform/mac/fast/overflow/overflow-rtl-vertical-expected.txt:
* platform/mac/fast/parser/bad-xml-slash-expected.txt:
* platform/mac/fast/replaced/replaced-breaking-expected.txt:
* platform/mac/fast/replaced/width100percent-checkbox-expected.txt:
* platform/mac/fast/replaced/width100percent-radio-expected.txt:
* platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
* platform/mac/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
* platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
* platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/mac/svg/custom/alignment-baseline-modes-expected.txt:
* platform/mac/svg/custom/dominant-baseline-modes-expected.txt:
* platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
* platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
* platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
* platform/mac/tables/mozilla_expected_failures/core/captions2-expected.txt:
* svg/custom/invalid-text-content-expected.png:
* svg/custom/text-zoom-expected.png:
* svg/custom/use-clipped-transform-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSkip a test that sometimes times out in Windows Debug builds
aroben@apple.com [Thu, 10 Mar 2011 21:17:53 +0000 (21:17 +0000)]
Skip a test that sometimes times out in Windows Debug builds

<http://webkit.org/b/56080> tracks the failure.

* platform/win-xp/Skipped: Added jquery/effects.html. (Ideally we'd only skip this in Debug
builds regardless of whether it's XP or Vista or 7, but doing that requires fixing
<http://webkit.org/b/55254>.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKit2: Need a way to clear only the in-memory resource caches
jberlin@webkit.org [Thu, 10 Mar 2011 21:17:46 +0000 (21:17 +0000)]
WebKit2: Need a way to clear only the in-memory resource caches
https://bugs.webkit.org/show_bug.cgi?id=56022

Reviewed by Oliver Hunt and Brian Weinstein.

Add a parameter to WKContextClearResourceCaches to specify whether to clear all the caches
or just the memory caches.

* Shared/ResourceCachesToClear.h: Added.
* UIProcess/API/C/WKAPICast.h:
(WebKit::toResourceCachesToClear):

* UIProcess/API/C/WKContext.cpp:
(WKContextClearResourceCaches):
Add the new parameter.
* UIProcess/API/C/WKContext.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::clearResourceCaches):
Ditto.
* UIProcess/WebContext.h:

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::clearResourceCaches):
Pass the new parameter through to the platform-specific functions.
* WebProcess/WebProcess.h:
Add the new parameter and give it a default of AllResourceCaches.
* WebProcess/WebProcess.messages.in:
Ditto.
* WebProcess/gtk/WebProcessGtk.cpp:
(WebKit::WebProcess::platformClearResourceCaches):
Ditto.
* WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformClearResourceCaches):
Ditto.
* WebProcess/win/WebProcessWin.cpp:
(WebKit::WebProcess::platformClearResourceCaches):
When told to clear only the in-memory caches, return early so as not to clear the CFNetwork
disk cache.
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformClearResourceCaches):
Ditto.

* WebKit2.xcodeproj/project.pbxproj:
Add ResourceCachesToClear.h
* win/WebKit2.vcproj:
Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80753 268f45cc-cd09-0410-ab3c-d52691b4dbfc