WebKit-https.git
11 years ago2009-02-12 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 12 Feb 2009 21:56:13 +0000 (21:56 +0000)]
2009-02-12  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Fixed <rdar://problem/6582048>.

        * wtf/RandomNumber.cpp:
        (WTF::randomNumber): Make only one call to the random number generator
        on platforms where the generator is cryptographically secure. The value
        of randomness over and above cryptographically secure randomness is not
        clear, and it caused some performance problems.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-12 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 12 Feb 2009 21:52:36 +0000 (21:52 +0000)]
2009-02-12  David Hyatt  <hyatt@apple.com>

        Remove calcWidth from RenderObject.  Nobody ever called it on RenderObjects.

        Reviewed by Sam Weinig

        * rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-12 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 12 Feb 2009 21:38:23 +0000 (21:38 +0000)]
2009-02-12  David Hyatt  <hyatt@apple.com>

        Reviewed by Mark Rowe

        Fix for regression where form controls would paint yellow highlights.  The containsComposition check needs to
        null check node() now.

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-12 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 12 Feb 2009 21:34:36 +0000 (21:34 +0000)]
2009-02-12  Simon Fraser  <simon.fraser@apple.com>

        Build fix

        Change Animation::setDirection() to take the new enum value, and fix
        the single caller.

        Fix build error in MediaPlayerPrivateQTKit.h.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::mapAnimationDirection):
        * platform/animation/Animation.h:
        (WebCore::Animation::setDirection):
        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-12 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 12 Feb 2009 21:33:14 +0000 (21:33 +0000)]
2009-02-12  Simon Fraser  <simon.fraser@apple.com>

        No review.

        Remove debugging code which was committed by mistake.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-12 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 12 Feb 2009 21:26:57 +0000 (21:26 +0000)]
2009-02-12  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Adam Roben

        https://bugs.webkit.org/show_bug.cgi?id=23928

        Add detection of accelerated compositing and 3d transforms,
        and add various directories to $ignoredDirectories when these
        features are off.

        * Scripts/run-webkit-tests:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-12 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 12 Feb 2009 21:18:07 +0000 (21:18 +0000)]
2009-02-12  David Hyatt  <hyatt@apple.com>

        Reviewed by Simon Fraser

        Remove the overrideSize methods from RenderObject.  Devirtualize all of the accessors on RenderBox.

        * rendering/RenderBox.h:
        * rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-12 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 12 Feb 2009 21:08:19 +0000 (21:08 +0000)]
2009-02-12  Eric Carlson  <eric.carlson@apple.com>

        Darin Adler, Antti Koivisto, Holger Hans Peter Freyther

        Bug 23797: A platform should be able to use more than one media engine for <video> and <audio>
        https://bugs.webkit.org/show_bug.cgi?id=23797

        * WebCore.xcodeproj/project.pbxproj: add MediaPlayerPrivate.h

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::load): selectMediaURL now also returns a MIME type, pass it to
        MediaPlayer::load so it can choose the right media engine
        (WebCore::HTMLMediaElement::selectMediaURL): renamed from pickMedia. use MIMETypeRegistry
        functions to strip params from the url and extract the codecs parameter. call
        MediaPlayer::supportsType to see if we can open the file since only a media engine can
        answer questions about supported type+codecs.
        * html/HTMLMediaElement.h:

        * platform/MIMETypeRegistry.cpp:
        (WebCore::MIMETypeRegistry::getParameterFromMIMEType): New, find and return a MIME type parameter
        (WebCore::MIMETypeRegistry::stripParametersFromMIMEType): New, strip all parameters from a MIME type
        * platform/MIMETypeRegistry.h:

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::NullMediaPlayerPrivate::NullMediaPlayerPrivate):
        (WebCore::NullMediaPlayerPrivate::load):
        (WebCore::NullMediaPlayerPrivate::cancelLoad):
        (WebCore::NullMediaPlayerPrivate::play):
        (WebCore::NullMediaPlayerPrivate::pause):
        (WebCore::NullMediaPlayerPrivate::naturalSize):
        (WebCore::NullMediaPlayerPrivate::hasVideo):
        (WebCore::NullMediaPlayerPrivate::setVisible):
        (WebCore::NullMediaPlayerPrivate::duration):
        (WebCore::NullMediaPlayerPrivate::currentTime):
        (WebCore::NullMediaPlayerPrivate::seek):
        (WebCore::NullMediaPlayerPrivate::seeking):
        (WebCore::NullMediaPlayerPrivate::setEndTime):
        (WebCore::NullMediaPlayerPrivate::setRate):
        (WebCore::NullMediaPlayerPrivate::paused):
        (WebCore::NullMediaPlayerPrivate::setVolume):
        (WebCore::NullMediaPlayerPrivate::networkState):
        (WebCore::NullMediaPlayerPrivate::readyState):
        (WebCore::NullMediaPlayerPrivate::maxTimeSeekable):
        (WebCore::NullMediaPlayerPrivate::maxTimeBuffered):
        (WebCore::NullMediaPlayerPrivate::dataRate):
        (WebCore::NullMediaPlayerPrivate::totalBytesKnown):
        (WebCore::NullMediaPlayerPrivate::totalBytes):
        (WebCore::NullMediaPlayerPrivate::bytesLoaded):
        (WebCore::NullMediaPlayerPrivate::setRect):
        (WebCore::NullMediaPlayerPrivate::paint):
        (WebCore::createNullMediaPlayer):
        Do nothing media player so MediaPlayer doesn't have to NULL check before calling current engine.

        (WebCore::MediaPlayerFactory::MediaPlayerFactory): New, factory constructor.
        (WebCore::installedMediaEngines): New, returns vector of all installed engines.
        (WebCore::addMediaEngine): New, add a media engine to the cache.
        (WebCore::chooseBestEngineForTypeAndCodecs): New, return an engine that might support a MIME type.
        (WebCore::MediaPlayer::MediaPlayer): create NULL media player so we have a default. Initialize m_currentMediaEngine.
        (WebCore::MediaPlayer::~MediaPlayer): don't need to delete m_private, it is now an OwnPtr.
        (WebCore::MediaPlayer::load): Take MIME type as well as url, since we need it to find the right
          media engine. If no MIME type is provided, try to devine one from the url. Choose a media engine
          based on the MIME type and codecs parameter.
        (WebCore::MediaPlayer::currentTime): Remove excess white space.
        (WebCore::MediaPlayer::supportsType): Take codecs param as well as MIME type. Return enum so we can
        indicate "maybe" condition.
        (WebCore::MediaPlayer::getSupportedTypes): Build up list of MIME types by consulting all engines.
        (WebCore::MediaPlayer::isAvailable): return true if any media engine is installed.

        * platform/graphics/MediaPlayer.h:
        (WebCore::MediaPlayer::):
        (WebCore::MediaPlayer::frameView): accessor function.

        * platform/graphics/MediaPlayerPrivate.h: New, declares abstract interface for media engines.
        (WebCore::MediaPlayerPrivateInterface::~MediaPlayerPrivateInterface):
        (WebCore::MediaPlayerPrivateInterface::totalBytesKnown):

        * platform/graphics/chromium/MediaPlayerPrivateChromium.h: Add support for engine factory

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::create): New, media engine factory function
        (WebCore::MediaPlayerPrivate::registerMediaEngine): Register engine with MediaPlayer factory
        (WebCore::MediaPlayerPrivate::load): URL is a const String.
        (WebCore::MediaPlayerPrivate::duration): Declare const.
        (WebCore::MediaPlayerPrivate::naturalSize): Ditto.
        (WebCore::MediaPlayerPrivate::hasVideo): Ditto.
        (WebCore::MediaPlayerPrivate::networkState): Ditto.
        (WebCore::MediaPlayerPrivate::readyState): Ditto.
        (WebCore::MediaPlayerPrivate::maxTimeBuffered): Ditto.
        (WebCore::MediaPlayerPrivate::maxTimeSeekable): Ditto.
        (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto.
        (WebCore::MediaPlayerPrivate::bytesLoaded): Ditto.
        (WebCore::MediaPlayerPrivate::totalBytesKnown): Ditto.
        (WebCore::MediaPlayerPrivate::totalBytes): Ditto.
        (WebCore::MediaPlayerPrivate::supportsType): Return MediaPlayer::SupportsType enum instead of bool.
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
        (WebCore::MediaPlayerPrivate::isAvailable):

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivateQTKit::create): New, media engine factory function
        (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Register engine with MediaPlayer factory
        (WebCore::MediaPlayerPrivate::createQTMovieView): don't access MediaPlayer->m_frameView directly,
        use accessor function.
        (WebCore::MediaPlayerPrivate::setUpVideoRendering): Ditto.
        (WebCore::MediaPlayerPrivate::paint): Ditto.
        (WebCore::mimeTypeCache): New.
        (WebCore::MediaPlayerPrivate::getSupportedTypes): New, media engine factory function.
        (WebCore::MediaPlayerPrivate::supportsType): return MediaPlayer::SupportsType enum instead of bool
        (-[WebCoreMovieObserver initWithCallback:]): fix formatting

        * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
        (WebCore::MediaPlayerPrivate::create):
        (WebCore::MediaPlayerPrivate::registerMediaEngine):
        (WebCore::MediaPlayerPrivate::supportsType):
        (WebCore::MediaPlayerPrivate::load): URL is a const String.
        * platform/graphics/qt/MediaPlayerPrivatePhonon.h:
        (WebCore::MediaPlayerPrivate::isAvailable):

        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
        (WebCore::MediaPlayerPrivate::create): New, media engine factory function
        (WebCore::MediaPlayerPrivate::registerMediaEngine): New, register engine with MediaPlayer factory
        (WebCore::MediaPlayerPrivate::load): URL is a const String.
        (WebCore::MediaPlayerPrivate::paint): don't access MediaPlayer->m_frameView directly,
        use accessor function.
        (WebCore::mimeTypeCache): New.
        (WebCore::MediaPlayerPrivateQTWin::getSupportedTypes): New, media engine factory function.
        (WebCore::MediaPlayerPrivateQTWin::supportsType): return MediaPlayer::SupportsType enum instead of bool
        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
jchaffraix@webkit.org [Thu, 12 Feb 2009 20:52:02 +0000 (20:52 +0000)]
WebCore:

2009-02-12  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Darin Adler.

        Test: fast/dom/prefixed-image-tag.xhtml

        Bug 23915: Remove setPrefix work-around in Document::createElement(QualifiedName, bool)

        Instead we now directly propage the QualifiedName inside the generated Factory.

        Test: fast/dom/prefixed-image-tag.xhtml

        * dom/Document.cpp:
        (WebCore::Document::createElement): Removed the setPrefix work-around
        and replaced it with an ASSERT to catch mistakes inside the Factory code.
        Remove the unneeded ExceptionCode argument.

        (WebCore::Document::createElementNS): Removed ExceptionCode argument.
        * dom/Document.h: Updated the signature.
        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::XMLTokenizer::startElementNs): Removed ExceptionCode argument.
        * dom/XMLTokenizerQt.cpp: Ditto.
        (WebCore::XMLTokenizer::parseStartElement): Ditto.

        * dom/make_names.pl: Implemented the QualifiedName propogation logic
        in the Factory.

LayoutTests:

2009-02-12  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Darin Adler.

        Bug 23915: Remove setPrefix work-around in Document::createElement(QualifiedName, bool)

        The test validates the <image> special treatment (using <img> tag) and see whether
        it validates the previous behaviour and we do not ASSERT.

        * fast/dom/prefixed-image-tag-expected.txt: Added.
        * fast/dom/prefixed-image-tag.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-12 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 12 Feb 2009 20:47:01 +0000 (20:47 +0000)]
2009-02-12  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=23188

        Define enum values for Animation::direction(), and one for
        IterationCountInfinite to make the code more self-documenting.

        Order the member vars of Animation to optimize packing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Holger Freyther.
christian@webkit.org [Thu, 12 Feb 2009 20:42:03 +0000 (20:42 +0000)]
    Reviewed by Holger Freyther.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::startHttp): Don't use O_CLOEXEC for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
jchaffraix@webkit.org [Thu, 12 Feb 2009 20:31:17 +0000 (20:31 +0000)]
WebCore:

2009-02-12  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Darin Adler.

        Bug 23826: Potential bug with before/after rule while moving element from one document to another

        Moved the document before/after toggle from the constructor to insertedIntoDocument.

        Test: fast/css-generated-content/beforeAfter-interdocument.html

        * html/HTMLQuoteElement.cpp:
        (WebCore::HTMLQuoteElement::HTMLQuoteElement):
        (WebCore::HTMLQuoteElement::insertedIntoDocument):
        * html/HTMLQuoteElement.h:

LayoutTests:

2009-02-12  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Darin Adler.

        Bug 23826: Potential bug with before/after rule while moving element from one document to another

        * fast/css-generated-content/beforeAfter-interdocument.html: Added.
        * platform/mac/fast/css-generated-content/beforeAfter-interdocument-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-12 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 12 Feb 2009 20:30:16 +0000 (20:30 +0000)]
2009-02-12  Brady Eidson  <beidson@apple.com>

        Reviewed by Kevin Decker

        <rdar://problem/6579750> - Crash in WebArchivePrivate in Tiger TextEdit

        NSHTMLReader tries to create a WebArchive from a random chunk of data.  Previously, WebArchive creation would
        fail and return nil and NSHTMLReader would try something else.  When we changed the behavior to return an invalid
        WebArchive object, things started getting weird.

        * WebView/WebArchive.mm:
        (-[WebArchivePrivate setCoreArchive:]): Null check the pointer before calling ->deref()
        (-[WebArchivePrivate dealloc]): Remove the ASSERT which is now invalid, and null check the pointer before ->deref().
        (-[WebArchivePrivate finalize]): Ditto
        (-[WebArchive initWithData:]): If the LegacyWebArchive cannot be created, return nil instead of an invalid object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-12 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 12 Feb 2009 20:18:50 +0000 (20:18 +0000)]
2009-02-12  David Hyatt  <hyatt@apple.com>

        Reviewed by Simon Fraser

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23912

        I have no idea why this broke.  As far as I can tell the old code never should have worked in
        the first place.  Add code to handleWheelEvent that will find an enclosing renderer for a node
        in order to attempt a wheel scroll.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[GTK] API: hovering-over-link and webkit_web_view_open /_load_foo
christian@webkit.org [Thu, 12 Feb 2009 19:44:47 +0000 (19:44 +0000)]
[GTK] API: hovering-over-link and webkit_web_view_open /_load_foo
http://bugs.webkit.org/show_bug.cgi?id=17176

Reviewed by Holger Freyther.

* webkit/webkitwebframe.cpp:
* webkit/webkitwebframe.h:
* webkit/webkitwebview.cpp:
* webkit/webkitwebview.h: Introduce webkit_web_frame_load_uri,
webkit_web_frame_load_string, webkit_web_view_load_uri and
webkit_web_view_load_request and unify implementations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Try to fix dashboard-region-parser
aroben@apple.com [Thu, 12 Feb 2009 19:41:07 +0000 (19:41 +0000)]
    Try to fix dashboard-region-parser

        * platform/mac/fast/css/dashboard-region-parser.html: Fixed relative
        paths now that this test has moved.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-12 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 12 Feb 2009 19:28:24 +0000 (19:28 +0000)]
2009-02-12  David Hyatt  <hyatt@apple.com>

        Move the functions that paint borders, box shadows and border images into RenderBoxModelObject.  drawBorder and drawBorderArc, because they are used
        for outlines as well as borders, need to stay in RenderObject.  Rename them to drawLineForBoxSide and drawArcForBoxSide in order to reflect their
        more generic use.  Rename the BorderSide struct to BoxSide, since the concept of "side" is just a rectangle concept and not a border concept.

        Reviewed by Simon Fraser

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintFillLayer):
        (WebCore::InlineFlowBox::paintBoxShadow):
        (WebCore::InlineFlowBox::paintBoxDecorations):
        (WebCore::InlineFlowBox::paintMask):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintColumns):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintNinePieceImage):
        (WebCore::RenderBoxModelObject::paintBorder):
        (WebCore::RenderBoxModelObject::paintBoxShadow):
        * rendering/RenderBoxModelObject.h:
        * rendering/RenderFieldset.cpp:
        (WebCore::RenderFieldset::paintBorderMinusLegend):
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::paintOutlineForLine):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::drawLineForBoxSide):
        (WebCore::RenderObject::drawArcForBoxSide):
        (WebCore::RenderObject::paintOutline):
        * rendering/RenderObject.h:
        (WebCore::):
        (WebCore::RenderObject::hasBoxDecorations):
        * rendering/RenderTableCell.cpp:
        (WebCore::CollapsedBorders::addBorder):
        (WebCore::RenderTableCell::paintCollapsedBorder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Simon Fraser.
cmarrin@apple.com [Thu, 12 Feb 2009 19:25:03 +0000 (19:25 +0000)]
    Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=23927

        Skip 16 SVG tests that fail on PPC, until problem is resolved

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Simon Fraser.
cmarrin@apple.com [Thu, 12 Feb 2009 19:21:59 +0000 (19:21 +0000)]
    Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=23927

        This fixes one testcase on PPC Mac

        * svg/custom/getTransformToElement.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-12 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 12 Feb 2009 18:43:31 +0000 (18:43 +0000)]
2009-02-12  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser

        Bug 18322: video element should have ui when scripting is disabled
        https://bugs.webkit.org/show_bug.cgi?id=18322

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::controls): always return 'true' when JavaScript is disabled.
        * manual-tests/media-controls-when-javascript-disabled.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* configure.ac: Make soup the default HTTP backend for the Gtk port.
christian@webkit.org [Thu, 12 Feb 2009 18:32:09 +0000 (18:32 +0000)]
* configure.ac: Make soup the default HTTP backend for the Gtk port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-12 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 12 Feb 2009 18:18:11 +0000 (18:18 +0000)]
2009-02-12  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23906
        Add custom V8 bindings for HTMLPlugInElement.

        * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: Added.
        (WebCore::NAMED_PROPERTY_GETTER):
        (WebCore::NAMED_PROPERTY_SETTER):
        (WebCore::CALLBACK_FUNC_DECL):
        (WebCore::INDEXED_PROPERTY_GETTER):
        (WebCore::INDEXED_PROPERTY_SETTER):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago [GTK] Soup backend must handle upload of multiple files
christian@webkit.org [Thu, 12 Feb 2009 18:11:54 +0000 (18:11 +0000)]
    [GTK] Soup backend must handle upload of multiple files
        https://bugs.webkit.org/show_bug.cgi?id=18343

Reviewed by Mark Rowe.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::):
        (WebCore::freeFileMapping):
        (WebCore::ResourceHandle::startHttp): Support multipart request bodies
        mmap'ing files to be uploaded.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Add some tests that fail due to using the wrong font for Hebrew to the Window...
aroben@apple.com [Thu, 12 Feb 2009 17:27:44 +0000 (17:27 +0000)]
    Add some tests that fail due to using the wrong font for Hebrew to the Windows Skipped list

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix lots of Perl warnings when building JavaScriptCoreGenerated on Windows
aroben@apple.com [Thu, 12 Feb 2009 17:10:16 +0000 (17:10 +0000)]
    Fix lots of Perl warnings when building JavaScriptCoreGenerated on Windows

        Reviewed by John Sullivan.

        * JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:
        Create the docs/ directory so that we can write bytecode.html into it.
        This matches what JavaScriptCore.xcodeproj does.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Remove some passing tests from the Windows Skipped list
aroben@apple.com [Thu, 12 Feb 2009 16:48:50 +0000 (16:48 +0000)]
    Remove some passing tests from the Windows Skipped list

        * platform/win/Skipped: Removed two tests in http/tests/incremental
        (one of which had been renamed and so was running anyway).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix Bug 23922: Warning message from run-webkit-tests when Skipped file contai...
aroben@apple.com [Thu, 12 Feb 2009 16:48:40 +0000 (16:48 +0000)]
    Fix Bug 23922: Warning message from run-webkit-tests when Skipped file contains non-existent tests is confusing and is given for disabled tests

        <https://bugs.webkit.org/show_bug.cgi?id=23922>

        We now no longer warn about disabled tests. The warning now reads:

        Skipped list contained '$item', but no file of that name could be
        found

        Reviewed by John Sullivan.

        * Scripts/run-webkit-tests:
        (top level): Pass the list name to processIgnoreTests so it can print
        out a reasonable warning message.
        (processIgnoreTests): Take a list name as a second parameter and use
        it to display a better warning message. Also check for a "-disabled"
        version of the test before warning about it not existing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Add a failing loader test to the Windows Skipped list
aroben@apple.com [Thu, 12 Feb 2009 16:48:28 +0000 (16:48 +0000)]
    Add a failing loader test to the Windows Skipped list

        * platform/win/Skipped: Added fast/loader/frame-creation-removal.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Add another failing drag-n-drop test to the Windows Skipped list
aroben@apple.com [Thu, 12 Feb 2009 16:48:16 +0000 (16:48 +0000)]
    Add another failing drag-n-drop test to the Windows Skipped list

        * platform/win/Skipped: Added editing/selection/drag-in-iframe.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix Bug 23919: Mac-specific test fast/css/dashboard-region-parser is in cross...
aroben@apple.com [Thu, 12 Feb 2009 16:48:03 +0000 (16:48 +0000)]
    Fix Bug 23919: Mac-specific test fast/css/dashboard-region-parser is in cross-platform location

        <https://bugs.webkit.org/show_bug.cgi?id=23919>

        Moved the test and its results to platform/mac.

        Reviewed by Dan Bernstein.

        * platform/mac/fast/css/dashboard-region-parser-expected.txt: Renamed from LayoutTests/fast/css/dashboard-region-parser-expected.txt.
        * platform/mac/fast/css/dashboard-region-parser.html: Renamed from LayoutTests/fast/css/dashboard-region-parser.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix Bug 23918: Mac-specific results for fast/css/computed-style[-without...
aroben@apple.com [Thu, 12 Feb 2009 16:47:38 +0000 (16:47 +0000)]
    Fix Bug 23918: Mac-specific results for fast/css/computed-style[-without-renderer] are sitting in cross-platform location

        <https://bugs.webkit.org/show_bug.cgi?id=23918>

        Move Mac-specific results for
        fast/css/computed-style[-without-renderer] to platform/mac

        Reviewed by John Sullivan.

        * fast/css/computed-style-expected.txt:
        * fast/css/computed-style-without-renderer-expected.txt:
        Made these results correct for non-Mac platforms by removing the
        -webkit-dashboard-region references.

        * platform/mac/fast/css/computed-style-expected.txt: Copied from LayoutTests/fast/css/computed-style-expected.txt.
        * platform/mac/fast/css/computed-style-without-renderer-expected.txt: Copied from LayoutTests/fast/css/computed-style-without-renderer-expected.txt.

        * platform/win/fast/css/computed-style-expected.txt:
        * platform/win/fast/css/computed-style-without-renderer-expected.txt:
        Copied the non-Mac results here, too, since on Windows we first check
        for Mac-specific results before checking for cross-platform results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-12 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Thu, 12 Feb 2009 15:01:15 +0000 (15:01 +0000)]
2009-02-12  Adam Treat  <adam.treat@torchmobile.com>

        Fix the Qt build following r40871 which changed RenderObject::element()
        into RenderObject::node().

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::getMediaElementFromRenderObject):
        (WebCore::RenderThemeQt::getMediaControlForegroundColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-12 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Thu, 12 Feb 2009 10:51:10 +0000 (10:51 +0000)]
2009-02-12  Simon Hausmann  <simon.hausmann@nokia.com>

        Rubber-stamped by Lars.

        Re-enable the JIT in the Qt build with -fno-stack-protector on Linux.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Build fix.
ap@webkit.org [Thu, 12 Feb 2009 10:45:19 +0000 (10:45 +0000)]
    Build fix.

        * platform/graphics/transforms/RotateTransformOperation.cpp: Include <algorithm>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-12 Jian Li <jianli@chromium.org>
ap@webkit.org [Thu, 12 Feb 2009 09:08:37 +0000 (09:08 +0000)]
2009-02-12  Jian Li  <jianli@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Change worker code to use different proxy class pointers.
        https://bugs.webkit.org/show_bug.cgi?id=23859

        This is a step towards using separate proxies in multi-process implementation.

        * bindings/js/WorkerScriptController.cpp:
        (WebCore::WorkerScriptController::evaluate):
        * dom/Worker.cpp:
        (WebCore::Worker::Worker):
        (WebCore::Worker::~Worker):
        (WebCore::Worker::postMessage):
        (WebCore::Worker::terminate):
        (WebCore::Worker::hasPendingActivity):
        (WebCore::Worker::notifyFinished):
        (WebCore::Worker::dispatchMessage):
        * dom/Worker.h:
        * dom/WorkerContext.cpp:
        (WebCore::WorkerContext::~WorkerContext):
        (WebCore::WorkerContext::reportException):
        (WebCore::WorkerContext::addMessage):
        (WebCore::WorkerContext::postMessage):
        (WebCore::WorkerContext::dispatchMessage):
        * dom/WorkerContext.h:
        * dom/WorkerContextProxy.h:
        * dom/WorkerMessagingProxy.cpp:
        (WebCore::MessageWorkerContextTask::performTask):
        (WebCore::MessageWorkerTask::performTask):
        (WebCore::WorkerContextProxy::create):
        (WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
        (WebCore::WorkerMessagingProxy::~WorkerMessagingProxy):
        (WebCore::WorkerMessagingProxy::startWorkerContext):
        (WebCore::postConsoleMessageTask):
        (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
        (WebCore::WorkerMessagingProxy::workerThreadCreated):
        * dom/WorkerMessagingProxy.h:
        * dom/WorkerObjectProxy.h:
        * dom/WorkerThread.cpp:
        (WebCore::WorkerThread::create):
        (WebCore::WorkerThread::WorkerThread):
        (WebCore::WorkerThread::workerThread):
        * dom/WorkerThread.h:
        (WebCore::WorkerThread::workerObjectProxy):
        * loader/WorkerThreadableLoader.cpp:
        (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-12 David Levin <levin@chromium.org>
ap@webkit.org [Thu, 12 Feb 2009 08:32:53 +0000 (08:32 +0000)]
2009-02-12  David Levin  <levin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Bug 23688: ThreadableLoader needs a sync implementation for Workers.
        <https://bugs.webkit.org/show_bug.cgi?id=23688>

        Add ResourceError to ThreadableLoaderClient.

        No observable change in behavior, so no test.

        * loader/DocumentThreadableLoader.cpp:
        (WebCore::DocumentThreadableLoader::create):
        (WebCore::DocumentThreadableLoader::willSendRequest):
        (WebCore::DocumentThreadableLoader::didFail):
        * loader/ThreadableLoaderClient.h:
        (WebCore::ThreadableLoaderClient::didFail):
        (WebCore::ThreadableLoaderClient::didFailWillSendRequestCheck):
        * loader/ThreadableLoaderClientWrapper.h:
        (WebCore::ThreadableLoaderClientWrapper::didFail):
        * loader/WorkerThreadableLoader.cpp:
        (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
        (WebCore::workerContextDidFail):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
        * loader/WorkerThreadableLoader.h:
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::didFail):
        (WebCore::XMLHttpRequest::didFailWillSendRequestCheck):
        * xml/XMLHttpRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-11 Dmitry Titov <dimich@chromium.org>
ap@webkit.org [Thu, 12 Feb 2009 07:58:36 +0000 (07:58 +0000)]
2009-02-11  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=23705
        Fix the UI freeze caused by Worker generating a flood of messages.
        Measure time we spend in executing posted work items. If too much time is spent
        without returning to the run loop, exit and reschedule.

        * wtf/MainThread.h:
        Added initializeMainThreadPlatform() to initialize low-level mechanism for posting
        work items from thread to thread. This removes #ifdefs for WIN and CHROMIUM from platform-independent code.

        * wtf/MainThread.cpp:
        (WTF::initializeMainThread):
        (WTF::dispatchFunctionsFromMainThread):
        Instead of dispatching all work items in the queue, dispatch them one by one
        and measure elapsed time. After a threshold, reschedule and quit.

        (WTF::callOnMainThread):
        (WTF::callOnMainThreadAndWait):
        Only schedule dispatch if the queue was empty - to avoid many posted messages in the run loop queue.

        * wtf/mac/MainThreadMac.mm:
        (WTF::scheduleDispatchFunctionsOnMainThread):
        Use static instance of the mainThreadCaller instead of allocating and releasing it each time.
        (WTF::initializeMainThreadPlatform):
        * wtf/gtk/MainThreadChromium.cpp:
        (WTF::initializeMainThreadPlatform):
        * wtf/gtk/MainThreadGtk.cpp:
        (WTF::initializeMainThreadPlatform):
        * wtf/qt/MainThreadQt.cpp:
        (WTF::initializeMainThreadPlatform):
        * wtf/win/MainThreadWin.cpp:
        (WTF::initializeMainThreadPlatform):
        * wtf/wx/MainThreadWx.cpp:
        (WTF::initializeMainThreadPlatform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-11 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 12 Feb 2009 05:53:06 +0000 (05:53 +0000)]
2009-02-11  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        Fix the build on Leopard with ACCELERATED_COMPOSITING turned on.

        * WebCore.xcodeproj/project.pbxproj:
        FloatPoint3D needs to be a private header, since it's included by GraphicsLayer.h
        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::getTransformFunctionValue):
        (WebCore::caValueFunctionSupported):
        (WebCore::GraphicsLayerCA::setAnchorPoint):
        (WebCore::GraphicsLayerCA::setPreserves3D):
        (WebCore::GraphicsLayerCA::setContentsToImage):
        (WebCore::GraphicsLayerCA::setBasicAnimation):
        (WebCore::GraphicsLayerCA::setKeyframeAnimation):
        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::isRootLayer):
        Fix isRootLayer to return true for the renderView's layer, not the root
        renderer's layer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-11 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 12 Feb 2009 05:48:41 +0000 (05:48 +0000)]
2009-02-11  Brady Eidson  <beidson@apple.com>

        Fix my last checkin for more effect.

        * WebHistoryItem.cpp:
        (WebHistoryItem::initFromDictionaryRepresentation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-11 Adele Peterson <adele@apple.com>
adele@apple.com [Thu, 12 Feb 2009 05:06:02 +0000 (05:06 +0000)]
2009-02-11  Adele Peterson  <adele@apple.com>

        Reviewed by Oliver Hunt.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23910
        <rdar://problem/6160546> REGRESSION: In Full page mode, movie controller hides when I drag the knob if movie is playing

        * rendering/RenderMedia.cpp: (WebCore::RenderMedia::forwardEvent):
        When we get a mouseOut event, consider the mouse as still within the RenderMedia if the relatedTarget is a descendant.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the build.
mrowe@apple.com [Thu, 12 Feb 2009 04:15:16 +0000 (04:15 +0000)]
Fix the build.

* History/WebHistory.mm:
(-[WebHistoryPrivate visitedURL:withTitle:]): Use ASSERT_UNUSED in a manner that makes sense.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows fix for Bug 22239: Implement missing animation & transition APIs on LayoutTes...
aroben@apple.com [Thu, 12 Feb 2009 04:07:18 +0000 (04:07 +0000)]
Windows fix for Bug 22239: Implement missing animation & transition APIs on LayoutTestController for non-mac platforms

WebKit/win:

        Windows fix for Bug 22239: Implement missing animation & transition
        APIs on LayoutTestController for non-mac platforms

        <https://bugs.webkit.org/show_bug.cgi?id=22239>

        Reviewed by Simon Fraser.

        * Interfaces/IWebFramePrivate.idl: Added pauseAnimation,
        pauseTransition, and numberOfActiveAnimations.

        * WebFrame.cpp:
        (WebFrame::pauseAnimation):
        (WebFrame::pauseTransition):
        (WebFrame::numberOfActiveAnimation):
        Added. These all call through to AnimationController.

        * WebFrame.h: Added pauseAnimation, pauseTransition, and
        numberOfActiveAnimations.

WebKitTools:

        Windows fix for Bug 22239: Implement missing animation & transition
        APIs on LayoutTestController for non-mac platforms

        <https://bugs.webkit.org/show_bug.cgi?id=22239>

        Reviewed by Simon Fraser.

        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
        (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
        (LayoutTestController::numberOfActiveAnimations):
        Implemented these by calling through to IWebFramePrivate.

LayoutTests:

        Windows fix for Bug 22239: Implement missing animation & transition
        APIs on LayoutTestController for non-mac platforms

        <https://bugs.webkit.org/show_bug.cgi?id=22239>

        Reviewed by Simon Fraser.

        * platform/win/Skipped: Enable the previously-skipped tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit/mac:
beidson@apple.com [Thu, 12 Feb 2009 02:30:38 +0000 (02:30 +0000)]
WebKit/mac:

2009-02-11  Brady Eidson  <beidson@apple.com>

        Reviewed by Mark Rowe

        <rdar://problem/6570573> Some visit counts in History.plist have insanely high values, can roll over to negative

        Remove the item from the date caches before registering the visit.  Otherwise it might not be successfully removed
        and when we add it back later it will exist in the list twice.  This will cause the entry to be written out twice,
        which would lead to doubling (or more!) the visit count on next launch when these multiple items are merged.

        * History/WebHistory.mm:
        (-[WebHistoryPrivate visitedURL:withTitle:]): Swap the removeItemFromDateCaches and visitedWithTitle calls.
        (-[WebHistoryPrivate addItem:discardDuplicate:]): Add a mode that allows the entry being added to be discarded
          if an entry for the URL already exists.  Use that mode when reading the History.plist so only the most
          recent entry for a given URL will be used.
        (-[WebHistoryPrivate addItems:]):
        (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):

WebKit/win:

2009-02-11  Brady Eidson  <beidson@apple.com>

        Reviewed by Mark Rowe

        <rdar://problem/6570573> Some visit counts in History.plist have insanely high values, can roll over to negative

        Remove the item from the date caches before registering the visit.  Otherwise it might not be successfully removed
        and when we add it back later it will exist in the list twice.  This will cause the entry to be written out twice,
        which would lead to doubling (or more!) the visit count on next launch when these multiple items are merged.

        * WebHistory.cpp:
        (WebHistory::loadHistoryGutsFromURL):
        (WebHistory::addItems):
        (WebHistory::addItem): Add a mode that allows the entry being added to be discarded if an entry for the URL already
          exists.  Use that mode when reading the History.plist so only the most recent entry for a given URL will be used.
        (WebHistory::visitedURL): Swap the removeItemFromDateCaches and visitedWithTitle calls.
        * WebHistory.h:

        * WebHistoryItem.cpp:
        (WebHistoryItem::initFromDictionaryRepresentation):  Add the negative-visit-count-correction-logic as implemented
          for Mac in http://trac.webkit.org/changeset/40851.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-11 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 12 Feb 2009 01:59:47 +0000 (01:59 +0000)]
2009-02-11  David Hyatt  <hyatt@apple.com>

        Remove all of the inline box wrapper functions from RenderObject, since they only apply to RenderBox.  Devirtualize the functions.
        Patch all of the call sites to convert to a RenderBox.

        Reviewed by Simon Fraser

        * dom/Position.cpp:
        (WebCore::nextRenderedEditable):
        (WebCore::previousRenderedEditable):
        (WebCore::Position::getInlineBoxAndOffset):
        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::deleteLine):
        (WebCore::InlineBox::extractLine):
        (WebCore::InlineBox::attachLine):
        * rendering/RenderLineBoxList.cpp:
        (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:
        * rendering/RenderObjectChildList.cpp:
        (WebCore::RenderObjectChildList::removeChildNode):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::textWithHardLineBreaks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-11 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 12 Feb 2009 01:35:08 +0000 (01:35 +0000)]
2009-02-11  David Hyatt  <hyatt@apple.com>

        Eliminate createInlineBox and dirtyLineBoxes from RenderObject.  These functions have been devirtualized.
        The single call site now calls a helper function that just bit checks and casts before calling the correct
        type.  RenderBlock's dirtyLineBoxes function was dead code (caused by the RenderFlow deletion), so it has
        just been removed.

        Reviewed by Eric Seidel

        * rendering/RenderBR.cpp:
        * rendering/RenderBR.h:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::createRootInlineBox):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::createInlineBox):
        * rendering/RenderBox.h:
        * rendering/RenderCounter.cpp:
        * rendering/RenderCounter.h:
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::createInlineFlowBox):
        * rendering/RenderInline.h:
        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:
        * rendering/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::createTextBox):
        * rendering/RenderSVGInlineText.h:
        (WebCore::RenderSVGInlineText::isSVGText):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::createTextBox):
        (WebCore::RenderText::createInlineTextBox):
        * rendering/RenderText.h:
        * rendering/bidi.cpp:
        (WebCore::createInlineBoxForRenderer):
        (WebCore::RenderBlock::createLineBoxes):
        (WebCore::RenderBlock::constructLine):
        (WebCore::RenderBlock::layoutInlineChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-11 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 12 Feb 2009 00:37:35 +0000 (00:37 +0000)]
2009-02-11  Sam Weinig  <sam@webkit.org>

        Reviewed by Gavin Barraclough.

        Style cleanup.

        * assembler/AbstractMacroAssembler.h:
        (JSC::AbstractMacroAssembler::CodeLocationCommon::CodeLocationCommon):
        (JSC::AbstractMacroAssembler::CodeLocationCommon::operator bool):
        (JSC::AbstractMacroAssembler::CodeLocationCommon::reset):
        (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForSwitch):
        (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForExceptionHandler):
        (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForJSR):
        (JSC::AbstractMacroAssembler::CodeLocationLabel::getJumpDestination):
        (JSC::AbstractMacroAssembler::CodeLocationJump::relink):
        (JSC::AbstractMacroAssembler::CodeLocationJump::CodeLocationJump):
        (JSC::AbstractMacroAssembler::CodeLocationCall::relink):
        (JSC::AbstractMacroAssembler::CodeLocationCall::calleeReturnAddressValue):
        (JSC::AbstractMacroAssembler::CodeLocationCall::CodeLocationCall):
        (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::repatch):
        (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::CodeLocationDataLabel32):
        (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::repatch):
        (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::CodeLocationDataLabelPtr):
        (JSC::AbstractMacroAssembler::ProcessorReturnAddress::ProcessorReturnAddress):
        (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToFunction):
        (JSC::AbstractMacroAssembler::ProcessorReturnAddress::operator void*):
        (JSC::AbstractMacroAssembler::PatchBuffer::link):
        (JSC::::CodeLocationCommon::labelAtOffset):
        (JSC::::CodeLocationCommon::jumpAtOffset):
        (JSC::::CodeLocationCommon::callAtOffset):
        (JSC::::CodeLocationCommon::dataLabelPtrAtOffset):
        (JSC::::CodeLocationCommon::dataLabel32AtOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-11 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 12 Feb 2009 00:35:18 +0000 (00:35 +0000)]
2009-02-11  Simon Fraser  <simon.fraser@apple.com>

        No review.

        Fix ACCELERATED_COMPOSITING build.

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::createGraphicsLayer):
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateLayerCompositingState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Dave Hyatt.
cmarrin@apple.com [Thu, 12 Feb 2009 00:09:52 +0000 (00:09 +0000)]
    Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=23905

        Adds support for 3D CSS properties (transform-style-3d, perspective,
        perspective-origin, and backface-visibility) to RenderStyle and friends

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-11 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 11 Feb 2009 23:18:56 +0000 (23:18 +0000)]
2009-02-11  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=23862

        Add a bit on RenderStyle that gets set when running accelerated
        transitions of transform or opacity. These ensure that styles
        compare as different during the transition, so that interruption
        can be detected reliably.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-11 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 11 Feb 2009 22:43:12 +0000 (22:43 +0000)]
2009-02-11  David Hyatt  <hyatt@apple.com>

        Eliminate the virtual position() function from RenderObject.  Rename the position() overrides
        in RenderText and RenderBox to positionLineBox and devirtualize them.

        Patch the one call site to just check for isText() and isBox() and call the methods directly.

        Remove some unnecessary overrides of position() on table sections and rows.

        Reviewed by Simon Fraser

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::positionLineBox):
        * rendering/RenderBox.h:
        * rendering/RenderObject.h:
        * rendering/RenderSVGRoot.cpp:
        * rendering/RenderSVGRoot.h:
        * rendering/RenderTableRow.h:
        (WebCore::RenderTableRow::lineHeight):
        * rendering/RenderTableSection.h:
        (WebCore::RenderTableSection::lineHeight):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::positionLineBox):
        * rendering/RenderText.h:
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::computeVerticalPositionsForLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-11 Scott Violet <sky@google.com>
dglazkov@chromium.org [Wed, 11 Feb 2009 22:41:08 +0000 (22:41 +0000)]
2009-02-11  Scott Violet  <sky@google.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=23805
        The test transitions/transition-end-event-multiple-03.html occasionally fails.

        * transitions/transition-end-event-multiple-03.html: Upped the timeout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-11 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 11 Feb 2009 22:35:19 +0000 (22:35 +0000)]
2009-02-11  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23901
        Add HTML options/collections V8 custom bindings.

        * bindings/v8/custom/V8HTMLCollectionCustom.cpp: Added.
        (WebCore::getNamedItems):
        (WebCore::getItem):
        (WebCore::NAMED_PROPERTY_GETTER):
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8HTMLFormElementCustom.cpp: Added.
        (WebCore::NAMED_PROPERTY_GETTER):
        * bindings/v8/custom/V8HTMLInputElementCustom.cpp:
        (WebCore::ACCESSOR_GETTER):
        (WebCore::ACCESSOR_SETTER):
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        (WebCore::ACCESSOR_SETTER):
        * bindings/v8/custom/V8HTMLSelectElementCustom.cpp: Added.
        (WebCore::CALLBACK_FUNC_DECL):
        (WebCore::removeElement):
        * bindings/v8/custom/V8HTMLSelectElementCustom.h: Added.
        * bindings/v8/custom/V8NamedNodesCollection.cpp: Added.
        (WebCore::V8NamedNodesCollection::item):
        (WebCore::V8NamedNodesCollection::itemWithName):
        * bindings/v8/custom/V8NamedNodesCollection.h: Added.
        (WebCore::V8NamedNodesCollection::V8NamedNodesCollection):
        (WebCore::V8NamedNodesCollection::length):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdded a preference to disable some Inspector's panels.
timothy@apple.com [Wed, 11 Feb 2009 22:20:45 +0000 (22:20 +0000)]
Added a preference to disable some Inspector's panels.

WebCore:

2009-02-11  Dimitri Dupuis-latour  <dupuislatour@apple.com>

        Added a preference to disable some Inspector's panels (rdar://6419624, rdar://6419645).
        This is controlled via the 'WebKitInspectorHiddenPanels' key; if nothing is specified, all panels are shown.

        Reviewed by Timothy Hatcher.

        * inspector/InspectorClient.h:
        * inspector/InspectorController.cpp:
        (WebCore::hiddenPanels):
        (WebCore::InspectorController::hiddenPanels):
        (WebCore::InspectorController::windowScriptObjectAvailable):
        * inspector/InspectorController.h:
        * inspector/front-end/inspector.js:
        (WebInspector.loaded):
        * loader/EmptyClients.h:
        (WebCore::EmptyInspectorClient::hiddenPanels):

WebKit/gtk:

2009-02-11  Dimitri Dupuis-latour  <dupuislatour@apple.com>

        Stub out InspectorClient::hiddenPanels.

        Reviewed by Timothy Hatcher.

        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::InspectorClient::hiddenPanels):
        * WebCoreSupport/InspectorClientGtk.h:

WebKit/mac:

2009-02-11  Dimitri Dupuis-latour  <dupuislatour@apple.com>

        Added a preference to disable some Inspector's panels (rdar://6419624, rdar://6419645).
        This is controlled via the 'WebKitInspectorHiddenPanels' key; if nothing is specified, all panels are shown.

        Reviewed by Timothy Hatcher.

        * WebCoreSupport/WebInspectorClient.h:
        * WebCoreSupport/WebInspectorClient.mm:
        (WebInspectorClient::hiddenPanels):

WebKit/qt:

2009-02-11  Dimitri Dupuis-latour  <dupuislatour@apple.com>

        Stub out InspectorClientQt::hiddenPanels.

        Reviewed by Timothy Hatcher.

        * WebCoreSupport/InspectorClientQt.cpp:
        (WebCore::InspectorClientQt::hiddenPanels):
        * WebCoreSupport/InspectorClientQt.h:

WebKit/win:

2009-02-11  Dimitri Dupuis-latour  <dupuislatour@apple.com>

        Stub out WebInspectorClient::hiddenPanels.

        Reviewed by Timothy Hatcher.

        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorClient::hiddenPanels):
        * WebCoreSupport/WebInspectorClient.h:

WebKit/wx:

2009-02-11  Dimitri Dupuis-latour  <dupuislatour@apple.com>

        Stub out InspectorClientWx::hiddenPanels.

        Reviewed by Timothy Hatcher.

        * WebKitSupport/InspectorClientWx.cpp:
        (WebCore::InspectorClientWx::hiddenPanels):
        * WebKitSupport/InspectorClientWx.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-11 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 11 Feb 2009 22:06:32 +0000 (22:06 +0000)]
2009-02-11  David Hyatt  <hyatt@apple.com>

        Combine RenderObject::element() and RenderObject::node() into a single function.
        node() now has the "anonymous bit" checking behavior of element() and will
        return 0 for anonymous content.  This patch switches all callers of element()
        to node() and patches old callers of node() to deal with situations where they
        did not expect node() to be 0.  A bunch of node() calls were calling stuff on
        Document that they clearly didn't intend, so overall this is a nice improvement.

        Reviewed by Sam Weinig

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::getUpperLeftCorner):
        * dom/Element.cpp:
        (WebCore::Element::offsetParent):
        * dom/Position.cpp:
        (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
        * editing/ModifySelectionListLevel.cpp:
        (WebCore::getStartEndListChildren):
        (WebCore::IncreaseSelectionListLevelCommand::doApply):
        (WebCore::DecreaseSelectionListLevelCommand::doApply):
        * editing/TextIterator.cpp:
        (WebCore::TextIterator::advance):
        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
        (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
        * editing/visible_units.cpp:
        (WebCore::startPositionForLine):
        (WebCore::endPositionForLine):
        * page/AXObjectCache.cpp:
        (WebCore::AXObjectCache::get):
        * page/AccessibilityList.cpp:
        (WebCore::AccessibilityList::isUnorderedList):
        (WebCore::AccessibilityList::isOrderedList):
        (WebCore::AccessibilityList::isDefinitionList):
        * page/AccessibilityListBox.cpp:
        (WebCore::AccessibilityListBox::doAccessibilityHitTest):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::isPasswordField):
        (WebCore::AccessibilityRenderObject::isFileUploadButton):
        (WebCore::AccessibilityRenderObject::isInputImage):
        (WebCore::AccessibilityRenderObject::isMultiSelect):
        (WebCore::AccessibilityRenderObject::isControl):
        (WebCore::AccessibilityRenderObject::getAttribute):
        (WebCore::AccessibilityRenderObject::anchorElement):
        (WebCore::AccessibilityRenderObject::actionElement):
        (WebCore::AccessibilityRenderObject::mouseButtonListener):
        (WebCore::AccessibilityRenderObject::helpText):
        (WebCore::AccessibilityRenderObject::textUnderElement):
        (WebCore::AccessibilityRenderObject::hasIntValue):
        (WebCore::AccessibilityRenderObject::intValue):
        (WebCore::AccessibilityRenderObject::labelElementContainer):
        (WebCore::AccessibilityRenderObject::title):
        (WebCore::AccessibilityRenderObject::accessibilityDescription):
        (WebCore::AccessibilityRenderObject::boundingBoxRect):
        (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
        (WebCore::AccessibilityRenderObject::titleUIElement):
        (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
        (WebCore::AccessibilityRenderObject::text):
        (WebCore::AccessibilityRenderObject::ariaSelectedTextDOMRange):
        (WebCore::AccessibilityRenderObject::accessKey):
        (WebCore::AccessibilityRenderObject::setSelectedTextRange):
        (WebCore::AccessibilityRenderObject::url):
        (WebCore::AccessibilityRenderObject::isFocused):
        (WebCore::AccessibilityRenderObject::setFocused):
        (WebCore::AccessibilityRenderObject::setValue):
        (WebCore::AccessibilityRenderObject::isEnabled):
        (WebCore::AccessibilityRenderObject::visiblePositionRange):
        (WebCore::AccessibilityRenderObject::index):
        (WebCore::AccessibilityRenderObject::activeDescendant):
        (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
        (WebCore::AccessibilityRenderObject::observableObject):
        (WebCore::AccessibilityRenderObject::roleValue):
        (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
        (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
        * page/AccessibilityTable.cpp:
        (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
        (WebCore::AccessibilityTable::title):
        * page/AccessibilityTableCell.cpp:
        (WebCore::AccessibilityTableCell::titleUIElement):
        * page/AccessibilityTableColumn.cpp:
        (WebCore::AccessibilityTableColumn::headerObjectForSection):
        * page/AccessibilityTableRow.cpp:
        (WebCore::AccessibilityTableRow::headerObject):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::dispatchMouseEvent):
        (WebCore::EventHandler::canMouseDownStartSelect):
        (WebCore::EventHandler::canMouseDragExtendSelect):
        (WebCore::EventHandler::shouldDragAutoNode):
        * page/Frame.cpp:
        (WebCore::Frame::searchForLabelsAboveCell):
        (WebCore::Frame::setFocusedNodeIfNeeded):
        * page/FrameView.cpp:
        (WebCore::FrameView::updateOverflowStatus):
        * page/animation/AnimationBase.cpp:
        (WebCore::AnimationBase::updateStateMachine):
        * page/animation/AnimationController.cpp:
        (WebCore::AnimationControllerPrivate::updateAnimationTimer):
        (WebCore::AnimationController::cancelAnimations):
        (WebCore::AnimationController::updateAnimations):
        * page/animation/KeyframeAnimation.cpp:
        (WebCore::KeyframeAnimation::KeyframeAnimation):
        (WebCore::KeyframeAnimation::endAnimation):
        * page/mac/AccessibilityObjectWrapper.mm:
        (blockquoteLevel):
        (AXAttributeStringSetHeadingLevel):
        * page/mac/FrameMac.mm:
        (WebCore::Frame::searchForNSLabelsAboveCell):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::verticallyAlignBoxes):
        (WebCore::InlineFlowBox::paint):
        (WebCore::shouldDrawTextDecoration):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paintDocumentMarkers):
        * rendering/RenderBR.cpp:
        (WebCore::RenderBR::positionForCoordinates):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock):
        (WebCore::RenderBlock::handleRunInChild):
        (WebCore::RenderBlock::paintObject):
        (WebCore::RenderBlock::isSelectionRoot):
        (WebCore::RenderBlock::rightmostPosition):
        (WebCore::RenderBlock::positionForBox):
        (WebCore::RenderBlock::positionForRenderer):
        (WebCore::RenderBlock::positionForCoordinates):
        (WebCore::RenderBlock::hasLineIfEmpty):
        (WebCore::RenderBlock::updateFirstLetter):
        (WebCore::RenderBlock::updateHitTestResult):
        (WebCore::RenderBlock::addFocusRingRects):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::styleWillChange):
        (WebCore::RenderBox::updateBoxModelInfoFromStyle):
        (WebCore::RenderBox::paintRootBoxDecorations):
        (WebCore::RenderBox::positionForCoordinates):
        * rendering/RenderButton.cpp:
        (WebCore::RenderButton::updateFromElement):
        (WebCore::RenderButton::canHaveChildren):
        * rendering/RenderCounter.cpp:
        (WebCore::planCounter):
        * rendering/RenderFieldset.cpp:
        (WebCore::RenderFieldset::findLegend):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutVerticalBox):
        * rendering/RenderForeignObject.cpp:
        (WebCore::RenderForeignObject::translationForAttributes):
        (WebCore::RenderForeignObject::calculateLocalTransform):
        * rendering/RenderFrame.h:
        (WebCore::RenderFrame::element):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paintReplaced):
        (WebCore::RenderImage::imageMap):
        (WebCore::RenderImage::nodeAtPoint):
        (WebCore::RenderImage::updateAltText):
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::cloneInline):
        (WebCore::RenderInline::updateHitTestResult):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::isTransparent):
        (WebCore::RenderLayer::scrollToOffset):
        (WebCore::RenderLayer::resize):
        (WebCore::RenderLayer::createScrollbar):
        (WebCore::RenderLayer::updateOverflowStatus):
        (WebCore::RenderLayer::updateScrollInfoAfterLayout):
        (WebCore::RenderLayer::enclosingElement):
        (WebCore::RenderLayer::updateHoverActiveState):
        (WebCore::RenderLayer::updateScrollCornerStyle):
        (WebCore::RenderLayer::updateResizerStyle):
        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::isRootLayer):
        * rendering/RenderListItem.cpp:
        (WebCore::getParentOfFirstLineBox):
        * rendering/RenderMarquee.cpp:
        (WebCore::RenderMarquee::marqueeSpeed):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::RenderObject):
        (WebCore::RenderObject::isBody):
        (WebCore::RenderObject::isHR):
        (WebCore::RenderObject::isHTMLMarquee):
        (WebCore::RenderObject::isEditable):
        (WebCore::RenderObject::addPDFURLRect):
        (WebCore::RenderObject::showTreeForThis):
        (WebCore::RenderObject::draggableNode):
        (WebCore::RenderObject::hasOutlineAnnotation):
        (WebCore::RenderObject::positionForCoordinates):
        (WebCore::RenderObject::updateDragState):
        (WebCore::RenderObject::updateHitTestResult):
        (WebCore::RenderObject::getUncachedPseudoStyle):
        (WebCore::RenderObject::getTextDecorationColors):
        (WebCore::RenderObject::caretMaxOffset):
        (WebCore::RenderObject::offsetParent):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::isRoot):
        (WebCore::RenderObject::isInlineContinuation):
        (WebCore::RenderObject::node):
        (WebCore::RenderObject::setNode):
        * rendering/RenderObjectChildList.cpp:
        (WebCore::RenderObjectChildList::destroyLeftoverChildren):
        * rendering/RenderPart.cpp:
        (WebCore::RenderPart::updateWidgetPosition):
        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::updateWidget):
        (WebCore::RenderPartObject::viewCleared):
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::calculateLocalTransform):
        (WebCore::RenderPath::layout):
        (WebCore::RenderPath::paint):
        (WebCore::RenderPath::drawMarkersIfNeeded):
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::positionForCoordinates):
        (WebCore::RenderReplaced::isSelected):
        * rendering/RenderSVGGradientStop.cpp:
        (WebCore::RenderSVGGradientStop::gradientElement):
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::calculateLocalTransform):
        * rendering/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::positionForCoordinates):
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::layout):
        (WebCore::RenderSVGRoot::applyContentTransforms):
        (WebCore::RenderSVGRoot::paint):
        (WebCore::RenderSVGRoot::calcViewport):
        (WebCore::RenderSVGRoot::absoluteTransform):
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::calculateLocalTransform):
        (WebCore::RenderSVGText::layout):
        * rendering/RenderSVGTextPath.cpp:
        (WebCore::RenderSVGTextPath::layoutPath):
        (WebCore::RenderSVGTextPath::startOffset):
        (WebCore::RenderSVGTextPath::exactAlignment):
        (WebCore::RenderSVGTextPath::stretchMethod):
        * rendering/RenderSVGTransformableContainer.cpp:
        (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
        * rendering/RenderSVGViewportContainer.cpp:
        (WebCore::RenderSVGViewportContainer::calcViewport):
        (WebCore::RenderSVGViewportContainer::viewportTransform):
        (WebCore::RenderSVGViewportContainer::nodeAtPoint):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::addChild):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::updateFromElement):
        (WebCore::RenderTableCell::calcPrefWidths):
        * rendering/RenderTableCol.cpp:
        (WebCore::RenderTableCol::updateFromElement):
        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::addChild):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::addChild):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::originalText):
        (WebCore::RenderText::positionForCoordinates):
        * rendering/RenderTextControlMultiLine.cpp:
        (WebCore::RenderTextControlMultiLine::nodeAtPoint):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::nodeAtPoint):
        * rendering/RenderTextFragment.cpp:
        (WebCore::RenderTextFragment::originalText):
        (WebCore::RenderTextFragment::previousCharacter):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::isActive):
        (WebCore::RenderTheme::isChecked):
        (WebCore::RenderTheme::isIndeterminate):
        (WebCore::RenderTheme::isEnabled):
        (WebCore::RenderTheme::isFocused):
        (WebCore::RenderTheme::isPressed):
        (WebCore::RenderTheme::isReadOnlyControl):
        (WebCore::RenderTheme::isHovered):
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::updatePressedState):
        (WebCore::RenderThemeMac::paintMediaFullscreenButton):
        (WebCore::RenderThemeMac::paintMediaMuteButton):
        (WebCore::RenderThemeMac::paintMediaPlayButton):
        (WebCore::RenderThemeMac::paintMediaSeekBackButton):
        (WebCore::RenderThemeMac::paintMediaSeekForwardButton):
        (WebCore::RenderThemeMac::paintMediaSliderTrack):
        (WebCore::RenderThemeMac::paintMediaSliderThumb):
        (WebCore::RenderThemeMac::paintMediaTimelineContainer):
        (WebCore::RenderThemeMac::paintMediaCurrentTime):
        (WebCore::RenderThemeMac::paintMediaTimeRemaining):
        * rendering/RenderThemeSafari.cpp:
        (WebCore::RenderThemeSafari::paintMediaMuteButton):
        (WebCore::RenderThemeSafari::paintMediaPlayButton):
        (WebCore::RenderThemeSafari::paintMediaSliderTrack):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::operator<<):
        (WebCore::writeSelection):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::setWidgetGeometry):
        (WebCore::RenderWidget::updateWidgetPosition):
        (WebCore::RenderWidget::nodeAtPoint):
        * rendering/RootInlineBox.cpp:
        (WebCore::isEditableLeaf):
        * rendering/SVGRenderSupport.cpp:
        (WebCore::prepareToRenderSVGContent):
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::write):
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBox::buildLayoutInformation):
        (WebCore::SVGRootInlineBox::layoutInlineBoxes):
        (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
        (WebCore::SVGRootInlineBox::buildTextChunks):
        * rendering/style/SVGRenderStyle.cpp:
        (WebCore::SVGRenderStyle::cssPrimitiveToLength):
        * svg/SVGFont.cpp:
        (WebCore::SVGTextRunWalker::walk):
        (WebCore::floatWidthOfSubStringUsingSVGFont):
        (WebCore::Font::drawTextUsingSVGFont):
        * svg/SVGTextContentElement.cpp:
        (WebCore::findInlineTextBoxInTextChunks):
        * svg/graphics/SVGPaintServer.cpp:
        (WebCore::SVGPaintServer::fillPaintServer):
        (WebCore::SVGPaintServer::strokePaintServer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-11 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 11 Feb 2009 22:01:22 +0000 (22:01 +0000)]
2009-02-11  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        <rdar://problem/3541409> - Further FrameLoader and page cache cleanup

        * history/CachedFrame.cpp:
        (WebCore::CachedFrame::restore): Moved updatePlatformScriptObjects() here.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::commitProvisionalLoad): Rolled opened() into this method.  This method was
          the only caller and - in the future - will benefit from doing parts of opened()'s work differently.
        (WebCore::FrameLoader::open): Split off per-frame logic into open(CachedFrame&) method.
        (WebCore::FrameLoader::closeAndRemoveChild): Added.  Do the non-tree related cleanup that
          FrameTree::removeChild() used to do.
        (WebCore::FrameLoader::detachFromParent): Call ::closeAndRemoveChild() instead.
        (WebCore::FrameLoader::cachePageForHistoryItem): Perform the "can cache page" check here.
        * loader/FrameLoader.h:

        * page/FrameTree.cpp:
        (WebCore::FrameTree::removeChild): Just remove the Frame from the tree.  Closing it and other
          cleanup is the responsibility of the FrameLoader.
        * page/FrameTree.h:
        (WebCore::FrameTree::detachFromParent): Added to just clear a Frame's parent pointer

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-11 Scott Violet <sky@google.com>
eric@webkit.org [Wed, 11 Feb 2009 22:00:55 +0000 (22:00 +0000)]
2009-02-11  Scott Violet  <sky@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23882
        GraphicsContextSkia draws round rects as solid rects

        Fixes two bugs in Skia's GraphicsContext::fillRoundedRect:
        . fillRoundedRect had an extra call to fillRect, resulting in always
          drawing a solid rectangle.
        . if the total radius along a given axis is greater than the size of
          the axis to draw, a solid rect should be drawn.

        The layout tests LayoutTests/fast/css/shadow-multiple.html and
        LayoutTests/fast/box-shadow/basic-shadows.html cover this.

        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::fillRoundedRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-11 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 11 Feb 2009 21:45:28 +0000 (21:45 +0000)]
2009-02-11  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        Add function to RenderStyle to ask whether a background image has been specified.

        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::hasBackgroundImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-11 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 11 Feb 2009 21:45:12 +0000 (21:45 +0000)]
2009-02-11  Sam Weinig  <sam@webkit.org>

        Reviewed by Gavin Barraclough.

        * assembler/AbstractMacroAssembler.h: Fix comments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-11 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Wed, 11 Feb 2009 21:13:33 +0000 (21:13 +0000)]
2009-02-11  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric Seidel.

        Bug 23536: Auto-generate HTMLElementFactory

        Remove the HTMLElementFactory files. Farewell.

        * html/HTMLElementFactory.cpp: Removed.
        * html/HTMLElementFactory.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-11 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Wed, 11 Feb 2009 21:08:55 +0000 (21:08 +0000)]
2009-02-11  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric Seidel.

        Bug 23536: Auto-generate HTMLElementFactory

        Make the platform auto-generate the HTMLElementFactory.

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.scons:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * webcore-base.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-11 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 11 Feb 2009 20:52:37 +0000 (20:52 +0000)]
2009-02-11  Sam Weinig  <sam@webkit.org>

        Reviewed by David Hyatt.

        Remove unneeded ASSERTS.

        * rendering/RenderBox.h:
        (WebCore::RenderBox::width):
        (WebCore::RenderBox::height):
        (WebCore::RenderBox::size):
        (WebCore::RenderBox::frameRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-11 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 11 Feb 2009 20:48:19 +0000 (20:48 +0000)]
2009-02-11  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=23548

        When opacity or transform change on an object which has a compositing layer,
        avoid repainting the layer.

        Added a new StyleDifference value, StyleDifferenceRecompositeLayer, which indicates
        that the only thing styleChanged() has to do is to update composited properties of
        the layer. RenderStyle::diff() now has an out param for a bitmask of "context sensitive"
        properties, currently for opacity and transform. When one of these changes, we need
        to see if we have a compositing layer before we decide whether to layout/repaint,
        or just update the composited layer, via adjustStyleDifference().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Wed, 11 Feb 2009 20:18:13 +0000 (20:18 +0000)]
    Reviewed by Darin Adler.

        <rdar://problem/6562920> Pasted text should be normalized to NFC

        Testing requires putting non-HTML content in pasteboard, so it cannot be done with WebKit alone.

WebCore:
        * platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::plainText): Route the text through
        -[NSString precomposedStringWithCanonicalMapping].

WebKit/mac:
        * Misc/WebNSURLExtras.mm: (-[NSURL _web_userVisibleString]): Route the URL string through
        -[NSString precomposedStringWithCanonicalMapping].

        * WebCoreSupport/WebPasteboardHelper.mm:
        (WebPasteboardHelper::plainTextFromPasteboard): Ditto.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
        Ditto. The affected cases are all plain text ones - RTF, RTFD and HTML are assumed to be
        precomposed already, and the conversion is performed outside WebKit for those anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Simon Fraser.
cmarrin@apple.com [Wed, 11 Feb 2009 20:13:46 +0000 (20:13 +0000)]
    Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=23883

        Added new TransformOperation subclasses and methods to existing ones
        to support 3D.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-11 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 11 Feb 2009 19:43:11 +0000 (19:43 +0000)]
2009-02-11  David Hyatt  <hyatt@apple.com>

        Move createAnonymousBlock() to RenderBlock.  Since anonymous blocks are always parented to some other block,
        we can move this function to RenderBlock.  Fix a couple of call sites as a result of this restriction.

        Reviewed by Simon Fraser

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::createAnonymousBlock):
        * rendering/RenderBlock.h:
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::childBecameNonInline):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::handleDynamicFloatPositionChange):
        * rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-11 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 11 Feb 2009 19:10:55 +0000 (19:10 +0000)]
2009-02-11  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=23895

        Remove two complete nonsense lines that I accidentally added from a cut and paste error.  This
        restores the original logic.

        Reviewed by Simon Fraser

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-11 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 11 Feb 2009 19:02:12 +0000 (19:02 +0000)]
2009-02-11  David Hyatt  <hyatt@apple.com>

        Rename getBaselineOfFirstLineBox to firstLineBoxBaseline.  Rename getBaselineOfLastLineBox to
        lastLineBoxBaseline.  Remove the functions from RenderObject and add them to RenderBox instead.

        Reviewed by Eric Seidel

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::baselinePosition):
        (WebCore::RenderBlock::firstLineBoxBaseline):
        (WebCore::RenderBlock::lastLineBoxBaseline):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.h:
        (WebCore::RenderBox::firstLineBoxBaseline):
        (WebCore::RenderBox::lastLineBoxBaseline):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutHorizontalBox):
        * rendering/RenderObject.h:
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::firstLineBoxBaseline):
        * rendering/RenderTable.h:
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::baselinePosition):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::firstLineBoxBaseline):
        * rendering/RenderTableSection.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-11 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 11 Feb 2009 18:14:20 +0000 (18:14 +0000)]
2009-02-11  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser

        https://bugs.webkit.org/show_bug.cgi?id=23877
        Allow port to disable progress events from <video> and <audio> elements

        * html/HTMLMediaElement.cpp: Initialize m_sendProgressEvents.
        (WebCore::HTMLMediaElement::HTMLMediaElement): Don't post progress events if m_sendProgressEvents is false.
        (WebCore::HTMLMediaElement::initAndDispatchProgressEvent): Ditto.
        (WebCore::HTMLMediaElement::load): Ditto.
        * html/HTMLMediaElement.h: Add m_sendProgressEvents

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix crashes in http/tests/history/redirect-301.pl and friends on Windows
aroben@apple.com [Wed, 11 Feb 2009 17:20:38 +0000 (17:20 +0000)]
Fix crashes in http/tests/history/redirect-301.pl and friends on Windows

WebKit/win:

        Don't release the shared WebHistory instance on quit

        This matches Mac, and prevents a race condition when the process exits
        that depends on the order in which global destructors are invoked.

        Reviewed by Alexey Proskuryakov.

        * WebHistory.cpp:
        (sharedHistoryStorage): Changed to use DEFINE_STATIC_LOCAL so the
        destructor is never called.

WebKitTools:

        Fix crashes in http/tests/history/redirect-301.pl and friends on
        Windows

        Reviewed by Alexey Proskuryakov.

        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::webHistoryItemCount): Null-check the shared
        WebHistory instance before dereferencing it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Windows build fix
aroben@apple.com [Wed, 11 Feb 2009 15:00:28 +0000 (15:00 +0000)]
    Windows build fix

        * DerivedSources.cpp: Removed SVGElementFactory.cpp, since including
        it leads to ambiguities for symbols like "aTag", which exist in both
        the HTMLNames and SVGNames namespaces.

        * WebCore.vcproj/WebCore.vcproj: Added SVGElementFactory.cpp to the
        project directly. VS also decided to reformat this file a little bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Trying to fix wx build.
ap@webkit.org [Wed, 11 Feb 2009 12:04:27 +0000 (12:04 +0000)]
    Trying to fix wx build.

        * bytecode/JumpTable.h: Include "MacroAssembler.h", not <MacroAssembler.h>.
        * jscore.bkl: Added assembler directory to search paths.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-10 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Wed, 11 Feb 2009 08:21:37 +0000 (08:21 +0000)]
2009-02-10  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric Seidel.

        Bug 23536: Auto-generate HTMLElementFactory

        Those are the last auto-generation bits needed to have a working generated HTMLElementFactory:

        - Added a new option mapToTagName that enables a tag to use another's options and tagName (<image>
          uses imgTag for example) and wired the code generation to be consistent with the current factory.

        - Disabled dashboard compatibility check for HTMLElementFactory as it would make at least one test case fail.

        - Pass the QualifiedName down to the Element constructor for shared constructors to make the generated code as
          close as possible to the current one. We will pass the QualifiedName for all Element in a forthcoming patch.

        * dom/make_names.pl: Did all the above points and tweaked the code generation to match the current HTMLElementFactory
          as closely as possible.

        * html/HTMLElementFactory.cpp:
        (WebCore::quoteConstructor):
        * html/HTMLQuoteElement.cpp:
        (WebCore::HTMLQuoteElement::HTMLQuoteElement): Moved setUsesBeforeAfterRules to HTMLQuoteElement' constructor because some
        part of the code creates elements without using the HTMLElementFactory. Also added a FIXME as it is not the right place.

        * html/HTMLTagNames.in: Corrected <image> parameters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-10 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Wed, 11 Feb 2009 06:48:25 +0000 (06:48 +0000)]
2009-02-10  Jon Honeycutt  <jhoneycutt@apple.com>

        Windows build fix after r40837.

        Not reviewed.

        * DerivedSources.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-10 John Sullivan <sullivan@apple.com>
sullivan@apple.com [Wed, 11 Feb 2009 06:38:28 +0000 (06:38 +0000)]
2009-02-10  John Sullivan  <sullivan@apple.com>

        Reviewed by Dan Bernstein

        <https://bugs.webkit.org/show_bug.cgi?id=23889>, <rdar://problem/6572300>
        Negative visit counts stored in History.plist aren't corrected.

        It's not clear how a huge negative visit count ended up in History.plist, but we can't
        trust data read from disk so we can at least reset this to something sane. WebCore has
        no guard against a visit count overflowing an int, but that seems very unlikely to have
        caused this.

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem initFromDictionaryRepresentation:]):
        If a negative visit count is in the dictionary, replace it with 1. If a negative daily or
        weekly visit count is in the dictionary, replace it with 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-10 John Sullivan <sullivan@apple.com>
sullivan@apple.com [Wed, 11 Feb 2009 06:28:29 +0000 (06:28 +0000)]
2009-02-10  John Sullivan  <sullivan@apple.com>

        Reviewed by Dan Bernstein

        <https://bugs.webkit.org/show_bug.cgi?id=23891>
        [WebHistoryItem _setVisitCount:] is unused and should be removed

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem _setVisitCount:]):
        removed this unused method, which is a synonym for setVisitCount: that was introduced
        recently and abandoned even more recently

        * History/WebHistoryItemInternal.h:
        removed declaration of _setVisitCount:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-10 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Wed, 11 Feb 2009 06:06:47 +0000 (06:06 +0000)]
2009-02-10  Gavin Barraclough  <barraclough@apple.com>

        Build
        fix.
        (Narrow
        changelog
        for
        dhyatt).

        * bytecode/Instruction.h:
        (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
        (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-10 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 11 Feb 2009 06:03:33 +0000 (06:03 +0000)]
2009-02-10  David Hyatt  <hyatt@apple.com>

        Fix for pixel test regression in fast/text.  Make sure not to add in
        the borderTop and paddingTop of the block to the baseline when painting
        strict mode text decorations.

        Reviewed by Mark Rowe

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintTextDecorations):
        * rendering/InlineFlowBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-10 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Wed, 11 Feb 2009 05:46:25 +0000 (05:46 +0000)]
2009-02-10  Jon Honeycutt  <jhoneycutt@apple.com>

        <rdar://6349412> REGRESSION(r37204): Page is not repainted during and
        after pan scrolling

        Reviewed by Steve Falkenburg.

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::scrollContents): Don't repaint the pan scroll
        icon rect immediately; we will paint after the view has been scrolled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-10 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Wed, 11 Feb 2009 04:57:08 +0000 (04:57 +0000)]
2009-02-10  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Reduce use of void* / reinterpret_cast in JIT repatching code,
        add strong types for Calls and for the various types of pointers
        we retain into the JIT generated instruction stream.

        No performance impact.

        * assembler/AbstractMacroAssembler.h:
        (JSC::AbstractMacroAssembler::ImmPtr::ImmPtr):
        (JSC::AbstractMacroAssembler::ImmPtr::asIntptr):
        (JSC::AbstractMacroAssembler::Imm32::Imm32):
        (JSC::AbstractMacroAssembler::Label::Label):
        (JSC::AbstractMacroAssembler::DataLabelPtr::DataLabelPtr):
        (JSC::AbstractMacroAssembler::Call::Call):
        (JSC::AbstractMacroAssembler::Call::link):
        (JSC::AbstractMacroAssembler::Call::linkTo):
        (JSC::AbstractMacroAssembler::Jump::Jump):
        (JSC::AbstractMacroAssembler::Jump::linkTo):
        (JSC::AbstractMacroAssembler::CodeLocationCommon::CodeLocationCommon):
        (JSC::AbstractMacroAssembler::CodeLocationCommon::operator bool):
        (JSC::AbstractMacroAssembler::CodeLocationCommon::reset):
        (JSC::AbstractMacroAssembler::CodeLocationLabel::CodeLocationLabel):
        (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForSwitch):
        (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForExceptionHandler):
        (JSC::AbstractMacroAssembler::CodeLocationLabel::addressForJSR):
        (JSC::AbstractMacroAssembler::CodeLocationLabel::getJumpDestination):
        (JSC::AbstractMacroAssembler::CodeLocationJump::CodeLocationJump):
        (JSC::AbstractMacroAssembler::CodeLocationJump::relink):
        (JSC::AbstractMacroAssembler::CodeLocationCall::CodeLocationCall):
        (JSC::AbstractMacroAssembler::CodeLocationCall::relink):
        (JSC::AbstractMacroAssembler::CodeLocationCall::calleeReturnAddressValue):
        (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::CodeLocationDataLabel32):
        (JSC::AbstractMacroAssembler::CodeLocationDataLabel32::repatch):
        (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::CodeLocationDataLabelPtr):
        (JSC::AbstractMacroAssembler::CodeLocationDataLabelPtr::repatch):
        (JSC::AbstractMacroAssembler::ProcessorReturnAddress::ProcessorReturnAddress):
        (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToFunction):
        (JSC::AbstractMacroAssembler::ProcessorReturnAddress::operator void*):
        (JSC::AbstractMacroAssembler::PatchBuffer::entry):
        (JSC::AbstractMacroAssembler::PatchBuffer::trampolineAt):
        (JSC::AbstractMacroAssembler::PatchBuffer::link):
        (JSC::AbstractMacroAssembler::PatchBuffer::linkTailRecursive):
        (JSC::AbstractMacroAssembler::PatchBuffer::patch):
        (JSC::AbstractMacroAssembler::PatchBuffer::locationOf):
        (JSC::AbstractMacroAssembler::PatchBuffer::returnAddressOffset):
        (JSC::AbstractMacroAssembler::differenceBetween):
        (JSC::::CodeLocationCommon::labelAtOffset):
        (JSC::::CodeLocationCommon::jumpAtOffset):
        (JSC::::CodeLocationCommon::callAtOffset):
        (JSC::::CodeLocationCommon::dataLabelPtrAtOffset):
        (JSC::::CodeLocationCommon::dataLabel32AtOffset):
        * assembler/MacroAssemblerX86Common.h:
        (JSC::MacroAssemblerX86Common::call):
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::getCallReturnOffset):
        * bytecode/CodeBlock.h:
        (JSC::CallLinkInfo::CallLinkInfo):
        (JSC::getStructureStubInfoReturnLocation):
        (JSC::getCallLinkInfoReturnLocation):
        * bytecode/Instruction.h:
        (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
        (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
        * bytecode/JumpTable.h:
        (JSC::StringJumpTable::ctiForValue):
        (JSC::SimpleJumpTable::ctiForValue):
        * bytecode/StructureStubInfo.h:
        (JSC::StructureStubInfo::StructureStubInfo):
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::emitCatch):
        (JSC::prepareJumpTableForStringSwitch):
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::cti_op_get_by_id_self_fail):
        (JSC::getPolymorphicAccessStructureListSlot):
        (JSC::Interpreter::cti_op_throw):
        (JSC::Interpreter::cti_op_switch_imm):
        (JSC::Interpreter::cti_op_switch_char):
        (JSC::Interpreter::cti_op_switch_string):
        (JSC::Interpreter::cti_vm_throw):
        * jit/JIT.cpp:
        (JSC::ctiSetReturnAddress):
        (JSC::ctiPatchCallByReturnAddress):
        (JSC::JIT::privateCompile):
        (JSC::JIT::privateCompileCTIMachineTrampolines):
        * jit/JIT.h:
        (JSC::CallRecord::CallRecord):
        (JSC::JIT::compileGetByIdSelf):
        (JSC::JIT::compileGetByIdProto):
        (JSC::JIT::compileGetByIdChain):
        (JSC::JIT::compilePutByIdReplace):
        (JSC::JIT::compilePutByIdTransition):
        (JSC::JIT::compilePatchGetArrayLength):
        (JSC::JIT::emitCTICall):
        * jit/JITCall.cpp:
        (JSC::JIT::unlinkCall):
        (JSC::JIT::linkCall):
        * jit/JITInlineMethods.h:
        (JSC::JIT::emitNakedCall):
        (JSC::JIT::emitCTICall_internal):
        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::compileGetByIdSlowCase):
        (JSC::JIT::compilePutByIdSlowCase):
        (JSC::JIT::privateCompilePutByIdTransition):
        (JSC::JIT::patchGetByIdSelf):
        (JSC::JIT::patchPutByIdReplace):
        (JSC::JIT::privateCompilePatchGetArrayLength):
        (JSC::JIT::privateCompileGetByIdSelf):
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdSelfList):
        (JSC::JIT::privateCompileGetByIdProtoList):
        (JSC::JIT::privateCompileGetByIdChainList):
        (JSC::JIT::privateCompileGetByIdChain):
        (JSC::JIT::privateCompilePutByIdReplace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/6156755> onMouseOver events do not fire properly for cross frame...
oliver@apple.com [Wed, 11 Feb 2009 04:42:46 +0000 (04:42 +0000)]
<rdar://problem/6156755> onMouseOver events do not fire properly for cross frame drag and drop

Reviewed by Adele Peterson.

This problem was caused by incorrectly ignoring whether or not the
default behaviour of the mousedown event was suppressed.  If a
mousedown handler in a frame prevents default handling then the
subsequent mousemove events fired for the drag should not be
captured by that frame, should the mouse move out of its bounds.

Test: fast/events/mouse-drag-from-frame.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fixes for recent changes to TransformationMatrix and DOMElement.
kevino@webkit.org [Wed, 11 Feb 2009 02:00:45 +0000 (02:00 +0000)]
wx build fixes for recent changes to TransformationMatrix and DOMElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 11 Feb 2009 01:44:14 +0000 (01:44 +0000)]
2009-02-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        Clean up "fallbackAnimating" logic in AnimationBase. This flag indicates
        that animation of an accelerated property must run in software for some reason.

        Also remove use of private headers in GraphicsLayerCA related to a case
        where we may have to fall back on software animation of transform.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-10 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 11 Feb 2009 01:36:45 +0000 (01:36 +0000)]
2009-02-10  David Hyatt  <hyatt@apple.com>

        Some renames on line boxes.  xPos()/yPos() -> x()/y().  setXPos()/setYPos() -> setX()/setY().  m_object/object() -> m_renderer/renderer().  textObject() -> textRenderer().

        Reviewed by Sam Weinig

        * dom/Position.cpp:
        (WebCore::Position::upstream):
        (WebCore::Position::downstream):
        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
        (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
        (WebCore::VisiblePosition::localCaretRect):
        * editing/visible_units.cpp:
        (WebCore::startPositionForLine):
        (WebCore::endPositionForLine):
        (WebCore::previousLinePosition):
        (WebCore::nextLinePosition):
        * rendering/EllipsisBox.cpp:
        (WebCore::EllipsisBox::paint):
        (WebCore::EllipsisBox::nodeAtPoint):
        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::showTreeForThis):
        (WebCore::InlineBox::height):
        (WebCore::InlineBox::caretMinOffset):
        (WebCore::InlineBox::caretMaxOffset):
        (WebCore::InlineBox::deleteLine):
        (WebCore::InlineBox::extractLine):
        (WebCore::InlineBox::attachLine):
        (WebCore::InlineBox::adjustPosition):
        (WebCore::InlineBox::paint):
        (WebCore::InlineBox::nodeAtPoint):
        (WebCore::InlineBox::selectionState):
        (WebCore::InlineBox::canAccommodateEllipsis):
        * rendering/InlineBox.h:
        (WebCore::InlineBox::InlineBox):
        (WebCore::InlineBox::renderer):
        (WebCore::InlineBox::setX):
        (WebCore::InlineBox::x):
        (WebCore::InlineBox::setY):
        (WebCore::InlineBox::y):
        (WebCore::InlineBox::topOverflow):
        (WebCore::InlineBox::bottomOverflow):
        (WebCore::InlineBox::leftOverflow):
        (WebCore::InlineBox::rightOverflow):
        (WebCore::InlineBox::visibleToHitTesting):
        (WebCore::InlineBox::boxModelObject):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::height):
        (WebCore::InlineFlowBox::addToLine):
        (WebCore::InlineFlowBox::removeLineBoxFromRenderObject):
        (WebCore::InlineFlowBox::extractLineBoxFromRenderObject):
        (WebCore::InlineFlowBox::attachLineBoxToRenderObject):
        (WebCore::InlineFlowBox::rendererLineBoxes):
        (WebCore::InlineFlowBox::onEndChain):
        (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
        (WebCore::InlineFlowBox::placeBoxesHorizontally):
        (WebCore::InlineFlowBox::verticallyAlignBoxes):
        (WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
        (WebCore::verticalPositionForBox):
        (WebCore::InlineFlowBox::computeLogicalBoxHeights):
        (WebCore::InlineFlowBox::placeBoxesVertically):
        (WebCore::InlineFlowBox::nodeAtPoint):
        (WebCore::InlineFlowBox::paint):
        (WebCore::InlineFlowBox::paintFillLayer):
        (WebCore::InlineFlowBox::paintBoxShadow):
        (WebCore::InlineFlowBox::paintBoxDecorations):
        (WebCore::InlineFlowBox::paintMask):
        (WebCore::InlineFlowBox::paintTextDecorations):
        * rendering/InlineFlowBox.h:
        (WebCore::InlineFlowBox::borderLeft):
        (WebCore::InlineFlowBox::borderRight):
        (WebCore::InlineFlowBox::borderTop):
        (WebCore::InlineFlowBox::borderBottom):
        (WebCore::InlineFlowBox::baseline):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::height):
        (WebCore::InlineTextBox::selectionState):
        (WebCore::InlineTextBox::selectionRect):
        (WebCore::InlineTextBox::deleteLine):
        (WebCore::InlineTextBox::extractLine):
        (WebCore::InlineTextBox::attachLine):
        (WebCore::InlineTextBox::placeEllipsisBox):
        (WebCore::InlineTextBox::isLineBreak):
        (WebCore::InlineTextBox::nodeAtPoint):
        (WebCore::InlineTextBox::paint):
        (WebCore::InlineTextBox::selectionStartEnd):
        (WebCore::InlineTextBox::paintSelection):
        (WebCore::InlineTextBox::paintCompositionBackground):
        (WebCore::InlineTextBox::paintCustomHighlight):
        (WebCore::InlineTextBox::paintDecoration):
        (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
        (WebCore::InlineTextBox::paintTextMatchMarker):
        (WebCore::InlineTextBox::paintDocumentMarkers):
        (WebCore::InlineTextBox::paintCompositionUnderline):
        (WebCore::InlineTextBox::textPos):
        (WebCore::InlineTextBox::offsetForPosition):
        (WebCore::InlineTextBox::positionForOffset):
        * rendering/InlineTextBox.h:
        (WebCore::InlineTextBox::textRenderer):
        * rendering/ListMarkerBox.cpp:
        (WebCore::ListMarkerBox::isText):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintEllipsisBoxes):
        (WebCore::RenderBlock::lowestPosition):
        (WebCore::RenderBlock::rightmostPosition):
        (WebCore::RenderBlock::leftmostPosition):
        (WebCore::RenderBlock::positionForBox):
        (WebCore::RenderBlock::positionForCoordinates):
        (WebCore::RenderBlock::getBaselineOfFirstLineBox):
        (WebCore::RenderBlock::getBaselineOfLastLineBox):
        (WebCore::RenderBlock::adjustForBorderFit):
        (WebCore::RenderBlock::addFocusRingRects):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintCustomHighlight):
        (WebCore::RenderBox::position):
        (WebCore::RenderBox::containingBlockWidthForPositioned):
        (WebCore::RenderBox::calcAbsoluteHorizontalValues):
        (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutVerticalBox):
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::absoluteRects):
        (WebCore::RenderInline::absoluteQuads):
        (WebCore::RenderInline::offsetLeft):
        (WebCore::RenderInline::offsetTop):
        (WebCore::RenderInline::linesBoundingBox):
        (WebCore::RenderInline::relativePositionedInlineOffset):
        (WebCore::RenderInline::addFocusRingRects):
        (WebCore::RenderInline::paintOutline):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::localBoundingBox):
        * rendering/RenderSVGTSpan.cpp:
        (WebCore::RenderSVGTSpan::absoluteRects):
        (WebCore::RenderSVGTSpan::absoluteQuads):
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::absoluteRects):
        (WebCore::RenderSVGText::absoluteQuads):
        (WebCore::RenderSVGText::relativeBBox):
        * rendering/RenderSVGTextPath.cpp:
        (WebCore::RenderSVGTextPath::absoluteRects):
        (WebCore::RenderSVGTextPath::absoluteQuads):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::absoluteRects):
        (WebCore::RenderText::absoluteRectsForRange):
        (WebCore::RenderText::absoluteQuads):
        (WebCore::RenderText::absoluteQuadsForRange):
        (WebCore::RenderText::localCaretRect):
        (WebCore::RenderText::linesBoundingBox):
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::height):
        (WebCore::RootInlineBox::clearTruncation):
        (WebCore::RootInlineBox::placeEllipsis):
        (WebCore::RootInlineBox::paintEllipsisBox):
        (WebCore::RootInlineBox::addHighlightOverflow):
        (WebCore::RootInlineBox::paintCustomHighlight):
        (WebCore::RootInlineBox::paint):
        (WebCore::RootInlineBox::nodeAtPoint):
        (WebCore::RootInlineBox::childRemoved):
        (WebCore::RootInlineBox::fillLineSelectionGap):
        (WebCore::RootInlineBox::block):
        (WebCore::isEditableLeaf):
        (WebCore::RootInlineBox::closestLeafChildForXPos):
        (WebCore::RootInlineBox::setVerticalOverflowPositions):
        * rendering/RootInlineBox.h:
        (WebCore::RootInlineBox::bottomOverflow):
        (WebCore::RootInlineBox::floats):
        (WebCore::RootInlineBox::setHorizontalOverflowPositions):
        (WebCore::RootInlineBox::setVerticalSelectionPositions):
        * rendering/SVGCharacterLayoutInfo.cpp:
        (WebCore::SVGCharacterLayoutInfo::addLayoutInformation):
        * rendering/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::calculateGlyphWidth):
        (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback):
        (WebCore::SVGInlineTextBoxSelectionRectWalker::chunkPortionCallback):
        (WebCore::SVGInlineTextBox::svgCharacterHitsPosition):
        (WebCore::SVGInlineTextBox::nodeAtPoint):
        (WebCore::SVGInlineTextBox::paintCharacters):
        (WebCore::SVGInlineTextBox::paintSelection):
        (WebCore::SVGInlineTextBox::paintDecoration):
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::writeSVGInlineTextBox):
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker):
        (WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback):
        (WebCore::SVGRootInlineBoxPaintWalker::chunkEndCallback):
        (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupFillCallback):
        (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupStrokeCallback):
        (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback):
        (WebCore::SVGRootInlineBox::paint):
        (WebCore::cummulatedWidthOfInlineBoxCharacterRange):
        (WebCore::cummulatedHeightOfInlineBoxCharacterRange):
        (WebCore::svgTextRunForInlineTextBox):
        (WebCore::cummulatedWidthOrHeightOfTextChunk):
        (WebCore::applyTextAnchorToTextChunk):
        (WebCore::SVGRootInlineBox::buildLayoutInformation):
        (WebCore::SVGRootInlineBox::layoutInlineBoxes):
        (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
        (WebCore::SVGRootInlineBox::buildTextChunks):
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::constructLine):
        (WebCore::RenderBlock::computeVerticalPositionsForLine):
        (WebCore::RenderBlock::layoutInlineChildren):
        (WebCore::RenderBlock::checkLinesForTextOverflow):
        * svg/SVGTextContentElement.cpp:
        (WebCore::cumulativeCharacterRangeLength):
        (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback):
        (WebCore::findInlineTextBoxInTextChunks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 11 Feb 2009 01:12:57 +0000 (01:12 +0000)]
2009-02-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        Move enclosingCompositingLayer() from RenderObject to RenderLayer, since it
        relates to the RenderLayer z-order/overflow structure, rather than the render tree
        parent chain. Add a convenience method, ancestorCompositingLayer(), which finds
        the enclosing layer excluding self.

        Fix enclosingCompositingLayer() to correctly look at stacking context and overflow
        lists.

        Check for documentBeingDestroyed() in a few places to avoid work on document
        teardown.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-10 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 11 Feb 2009 01:05:41 +0000 (01:05 +0000)]
2009-02-10  David Hyatt  <hyatt@apple.com>

        Rename xPos() and yPos() on RenderLayer to x() and y() to match RenderBox.  Rename setPos to setLocation.

        Reviewed by Simon Fraser

        * dom/MouseRelatedEvent.cpp:
        (WebCore::MouseRelatedEvent::receivedTarget):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPosition):
        (WebCore::RenderLayer::convertToLayerCoords):
        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::x):
        (WebCore::RenderLayer::y):
        (WebCore::RenderLayer::setLocation):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::write):
        (WebCore::externalRepresentation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-10 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 11 Feb 2009 00:56:01 +0000 (00:56 +0000)]
2009-02-10  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark Rowe.

        <rdar://problem/6573916>
        CrashTracer: [USER] 1 crash in Safari at com.apple.WebKit • WebKit::NetscapePluginInstanceProxy::pluginHostDied + 25.

        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::instantiatePlugin):
        If we failed to instantiate the plug-in, invalidate the instance proxy.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::invalidate):
        Remove the instance from the plug-in host's set.

        (WebKit::NetscapePluginInstanceProxy::destroy):
        Call invalidate().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-10 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 11 Feb 2009 00:17:26 +0000 (00:17 +0000)]
2009-02-10  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23879
        Add missing PLATFORM(SKIA) changes to TransformationMatrix.h

        * platform/graphics/transforms/TransformationMatrix.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
weinig@apple.com [Tue, 10 Feb 2009 23:42:44 +0000 (23:42 +0000)]
WebCore:

2009-02-10  Sam Weinig  <sam@webkit.org>

        Reviewed by David Hyatt.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=15897
        Please implement getBoundingClientRect and getClientRects
        <rdar://problem/6139669>

        Cursory implementation of Element.getBoundingClientRect and
        Element.getClientRects. Adds necessary infrastructure classes
        ClientRect and ClientRectList.

        Tests: fast/dom/getBoundingClientRect.html
               fast/dom/getClientRects.html

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * dom/ClientRect.cpp: Added.
        (WebCore::ClientRect::ClientRect):
        * dom/ClientRect.h: Added.
        (WebCore::ClientRect::create):
        (WebCore::ClientRect::top):
        (WebCore::ClientRect::right):
        (WebCore::ClientRect::bottom):
        (WebCore::ClientRect::left):
        (WebCore::ClientRect::width):
        (WebCore::ClientRect::height):
        * dom/ClientRect.idl: Added.
        * dom/ClientRectList.cpp: Added.
        (WebCore::ClientRectList::ClientRectList):
        (WebCore::ClientRectList::~ClientRectList):
        (WebCore::ClientRectList::length):
        (WebCore::ClientRectList::item):
        * dom/ClientRectList.h: Added.
        (WebCore::ClientRectList::create):
        * dom/ClientRectList.idl: Added.
        * dom/Element.cpp:
        (WebCore::Element::getClientRects):
        (WebCore::Element::getBoundingClientRect):
        * dom/Element.h:
        * dom/Element.idl:
        * page/DOMWindow.idl:
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::absoluteRects):
        (WebCore::RenderInline::absoluteQuads):

LayoutTests:

2009-02-08  Sam Weinig  <sam@webkit.org>

        Reviewed by David Hyatt.

        Tests for https://bugs.webkit.org/show_bug.cgi?id=15897
        Please implement getBoundingClientRect and getClientRects
        <rdar://problem/6139669>

        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/domListEnumeration-expected.txt:
        * fast/dom/getBoundingClientRect-expected.txt: Added.
        * fast/dom/getBoundingClientRect.html: Added.
        * fast/dom/getClientRects-expected.txt: Added.
        * fast/dom/getClientRects.html: Added.
        * fast/dom/resources/domListEnumeration.js:
        * fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-10 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Tue, 10 Feb 2009 23:20:19 +0000 (23:20 +0000)]
2009-02-10  David Hyatt  <hyatt@apple.com>

        Get rid of capsLockStateMayHaveChanged on RenderObject.  It is only implemented by one class (text fields),
        so devirtualize and just query at the single call site.

        Reviewed by Eric Seidel

        * page/EventHandler.cpp:
        (WebCore::EventHandler::capsLockStateMayHaveChanged):
        * rendering/RenderObject.h:
        * rendering/RenderTextControlSingleLine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-10 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Tue, 10 Feb 2009 23:00:37 +0000 (23:00 +0000)]
2009-02-10  David Hyatt  <hyatt@apple.com>

        Shrink the size of all RenderObjects (except for RenderInlines) by 4 bytes.  This patch moves the cached vertical position member to RenderInlines,
        since they were the only objects being queried across multiple lines.

        Reviewed by Sam Weinig

        * rendering/InlineFlowBox.cpp:
        (WebCore::verticalPositionForBox):
        (WebCore::InlineFlowBox::computeLogicalBoxHeights):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::verticalPosition):
        * rendering/RenderBoxModelObject.h:
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::RenderInline):
        (WebCore::RenderInline::verticalPositionFromCache):
        * rendering/RenderInline.h:
        (WebCore::RenderInline::invalidateVerticalPosition):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::RenderObject):
        * rendering/RenderObject.h:
        * rendering/RenderText.cpp:
        * rendering/RenderText.h:
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::layoutInlineChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-10 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 10 Feb 2009 22:26:20 +0000 (22:26 +0000)]
2009-02-10  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=23868
        Fix code style issues: removed 80-col wrapping, incorrect include style, if statement body on same line.

        * bindings/v8/custom/V8HTMLInputElementCustom.cpp:
        * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-10 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 10 Feb 2009 21:47:49 +0000 (21:47 +0000)]
2009-02-10  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23868
        Add HTMLInputElement and HTMLOptionsCollection V8 custom bindings.

        * bindings/v8/custom/V8HTMLInputElementCustom.cpp: Added.
        (WebCore::ACCESSOR_GETTER):
        (WebCore::ACCESSOR_SETTER):
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: Added.
        (WebCore::ACCESSOR_GETTER):
        (WebCore::ACCESSOR_SETTER):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-09 Gustavo Noronha Silva <gns@gnome.org>
aroben@apple.com [Tue, 10 Feb 2009 21:12:42 +0000 (21:12 +0000)]
2009-02-09  Gustavo Noronha Silva  <gns@gnome.org>

        Fix Bug 23851: Add my blog's webkit category to Planet

        <https://bugs.webkit.org/show_bug.cgi?id=23851>

        Reviewed by Mark Rowe.

        * config.ini: Add Gustavo Noronha's blog webkit category.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix Bug 23871: Assertion failure beneath WebCore::openFunc when running http...
aroben@apple.com [Tue, 10 Feb 2009 21:12:32 +0000 (21:12 +0000)]
    Fix Bug 23871: Assertion failure beneath WebCore::openFunc when running http/tests/security/xss-DENIED-xsl-document-redirect.xml

        <https://bugs.webkit.org/show_bug.cgi?id=23871>

        Reviewed by Alexey Proskuryakov.

        Covered by existing tests.

        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::openFunc): Use the two-parameter KURL constructor so that
        the string will be parsed. libxml2 gives us a UTF-8-encoded string
        that needs to be parsed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Add Michael(tm) Smith's blog to Planet WebKit
aroben@apple.com [Tue, 10 Feb 2009 21:10:07 +0000 (21:10 +0000)]
    Add Michael(tm) Smith's blog to Planet WebKit

        Rubberstamped by Alexey Proskuryakov.

        * config.ini:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-10 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Tue, 10 Feb 2009 19:50:00 +0000 (19:50 +0000)]
2009-02-10  David Hyatt  <hyatt@apple.com>

        Shrink the size of all replaced elements (images, form controls, plugins) by 4 bytes by packing the
        overflow boolean into the RenderObject base class.

        Reviewed by Sam Weinig

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::RenderObject):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::replacedHasOverflow):
        (WebCore::RenderObject::setReplacedHasOverflow):
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::RenderReplaced):
        (WebCore::RenderReplaced::~RenderReplaced):
        (WebCore::RenderReplaced::adjustOverflowForBoxShadow):
        (WebCore::RenderReplaced::overflowHeight):
        (WebCore::RenderReplaced::overflowWidth):
        (WebCore::RenderReplaced::overflowLeft):
        (WebCore::RenderReplaced::overflowTop):
        (WebCore::RenderReplaced::overflowRect):
        * rendering/RenderReplaced.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-10 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 10 Feb 2009 19:32:35 +0000 (19:32 +0000)]
2009-02-10  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=23870
        Make it possible for a port to require a user gesture for an <audio> or <video> element
        to load a url.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_loadRestrictions.
        (WebCore::HTMLMediaElement::attributeChanged): Only one attribute can change so put an "else" between tests.
        (WebCore::HTMLMediaElement::load): Return INVALID_STATE_ERR if RequireUserGestureLoadRestriction is set
        and we are not preocessing a user gesture.
        (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): Remove unnecessary white space.
        (WebCore::HTMLMediaElement::play): Ditto.
        (WebCore::HTMLMediaElement::endScrubbing): Remove unnecessary braces added in r40789.
        (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Cache currentTime() in a local instead of calling it
        multiple times.
        (WebCore::HTMLMediaElement::processingUserGesture): New.
        * html/HTMLMediaElement.h:
        (WebCore::HTMLMediaElement::): Define LoadRestrictions, add m_loadRestrictions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-10 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Tue, 10 Feb 2009 19:12:36 +0000 (19:12 +0000)]
2009-02-10  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Sam Weinig.

        Remove the SVG checks from FloatPoint3D as it is used
        by TransformationMatrix.

        * platform/graphics/FloatPoint3D.cpp:
        * platform/graphics/FloatPoint3D.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-10 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Tue, 10 Feb 2009 19:06:48 +0000 (19:06 +0000)]
2009-02-10  David Hyatt  <hyatt@apple.com>

        Remove the m_baseline member variable from all line boxes, since it can easily be computed when needed and did not need to be cached.

        Reviewed by Sam Weinig

        * rendering/EllipsisBox.cpp:
        (WebCore::EllipsisBox::paint):
        (WebCore::EllipsisBox::nodeAtPoint):
        * rendering/EllipsisBox.h:
        (WebCore::EllipsisBox::EllipsisBox):
        * rendering/InlineBox.h:
        (WebCore::InlineBox::InlineBox):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::verticallyAlignBoxes):
        (WebCore::InlineFlowBox::computeLogicalBoxHeights):
        (WebCore::InlineFlowBox::placeBoxesVertically):
        (WebCore::InlineFlowBox::paintTextDecorations):
        * rendering/InlineFlowBox.h:
        (WebCore::InlineFlowBox::marginBorderPaddingLeft):
        (WebCore::InlineFlowBox::marginBorderPaddingRight):
        (WebCore::InlineFlowBox::marginLeft):
        (WebCore::InlineFlowBox::marginRight):
        (WebCore::InlineFlowBox::borderLeft):
        (WebCore::InlineFlowBox::borderRight):
        (WebCore::InlineFlowBox::borderTop):
        (WebCore::InlineFlowBox::borderBottom):
        (WebCore::InlineFlowBox::paddingLeft):
        (WebCore::InlineFlowBox::paddingRight):
        (WebCore::InlineFlowBox::paddingTop):
        (WebCore::InlineFlowBox::paddingBottom):
        (WebCore::InlineFlowBox::includeLeftEdge):
        (WebCore::InlineFlowBox::includeRightEdge):
        (WebCore::InlineFlowBox::baseline):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint):
        (WebCore::InlineTextBox::paintDecoration):
        (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
        (WebCore::InlineTextBox::paintCompositionUnderline):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::getBaselineOfFirstLineBox):
        (WebCore::RenderBlock::getBaselineOfLastLineBox):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::baselinePosition):
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::placeEllipsis):
        * rendering/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::paintDecoration):
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::applyTextAnchorToTextChunk):
        (WebCore::SVGRootInlineBox::layoutInlineBoxes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix Bug 23869: Pixel tests can't be run on Windows
aroben@apple.com [Tue, 10 Feb 2009 17:56:35 +0000 (17:56 +0000)]
    Fix Bug 23869: Pixel tests can't be run on Windows

        <https://bugs.webkit.org/show_bug.cgi?id=23869>

        This patch gets the pixel tests limping along on Windows again.

        Reviewed by Dan Bernstein.

        * DumpRenderTree/DumpRenderTree.sln: Changed to use the new
        Debug_Internal configuration of ImageDiff in the Debug_Internal
        configuration of this solution.

        * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
        (printPNG): Changed to call fwrite in a loop, since this call was
        failing due to the buffer being too large on Windows.
        (dumpWebViewAsPixelsAndCompareWithExpected): Removed an unnecessary
        #if PLATFORM(MAC)/#endif.

        * DumpRenderTree/win/ImageDiff.vcproj: Added a Debug_Internal
        configuration that matches the Debug configuration but also references
        debug_internal.vsprops.

        * DumpRenderTree/win/PixelDumpSupportWin.cpp:
        (createBitmapContextFromWebView): Renamed from
        getBitmapContextFromWebView to match the name used in the
        cross-platform code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40825 268f45cc-cd09-0410-ab3c-d52691b4dbfc