WebKit-https.git
8 years ago2012-02-25 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 25 Feb 2012 09:58:01 +0000 (09:58 +0000)]
2012-02-25  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Rebase SVG text result.

        * svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r108557.
zimmermann@webkit.org [Sat, 25 Feb 2012 09:27:25 +0000 (09:27 +0000)]
Unreviewed, rolling out r108557.
http://trac.webkit.org/changeset/108557
https://bugs.webkit.org/show_bug.cgi?id=77705

Broke svg/zoom/page/zoom-replated-intrinsic-ratio-001.htm.

* rendering/RenderTableCell.cpp:
* rendering/RenderTableCell.h:
(RenderTableCell):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed weekend gardening.
ossy@webkit.org [Sat, 25 Feb 2012 08:45:52 +0000 (08:45 +0000)]
[Qt] Unreviewed weekend gardening.

* platform/qt/Skipped:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHTMLParamElement: Clean up name/value attribute handling.
commit-queue@webkit.org [Sat, 25 Feb 2012 08:25:25 +0000 (08:25 +0000)]
HTMLParamElement: Clean up name/value attribute handling.
<http://webkit.org/b/79559>

Patch by Andreas Kling <awesomekling@apple.com> on 2012-02-25
Reviewed by Anders Carlsson.

Out-of-line name() and value(), and move the logic from parseAttribute()
into them instead. This makes the class a bit simpler and shrinks it by
two AtomicStrings. Also reduced isURLAttribute() to a two-liner.

* html/HTMLParamElement.cpp:
(WebCore::HTMLParamElement::name):
(WebCore::HTMLParamElement::value):
(WebCore::HTMLParamElement::isURLAttribute):
* html/HTMLParamElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r108816.
commit-queue@webkit.org [Sat, 25 Feb 2012 08:10:58 +0000 (08:10 +0000)]
Unreviewed, rolling out r108816.
http://trac.webkit.org/changeset/108816
https://bugs.webkit.org/show_bug.cgi?id=79562

It made many tests crash and timeout on Qt-WK2 (Requested by
ossy__ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-25

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::setIcon):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::loadProgress):
* UIProcess/qt/QtWebPageLoadClient.cpp:
(QtWebPageLoadClient::didCommitLoadForFrame):
(QtWebPageLoadClient::didSameDocumentNavigationForFrame):
(QtWebPageLoadClient::didReceiveTitleForFrame):
(QtWebPageLoadClient::setLoadProgress):
* UIProcess/qt/QtWebPageLoadClient.h:
(QtWebPageLoadClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the CopiedBlock offset alignment in a cross platform fashion
mhahnenberg@apple.com [Sat, 25 Feb 2012 08:07:44 +0000 (08:07 +0000)]
Fix the CopiedBlock offset alignment in a cross platform fashion
https://bugs.webkit.org/show_bug.cgi?id=79556

Reviewed by Filip Pizlo.

Replaced m_payload with a payload() method that calculates the offset
of the payload with the proper alignment. This change allows us to
avoid alignment-related issues in a cross-platform manner.

* heap/CopiedAllocator.h:
(JSC::CopiedAllocator::currentUtilization):
* heap/CopiedBlock.h:
(JSC::CopiedBlock::CopiedBlock):
(JSC::CopiedBlock::payload):
(CopiedBlock):
* heap/CopiedSpace.cpp:
(JSC::CopiedSpace::doneFillingBlock):
* heap/CopiedSpaceInlineMethods.h:
(JSC::CopiedSpace::borrowBlock):
(JSC::CopiedSpace::allocateFromBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Add missing fast/images/rgb-jpeg-with-adobe-marker-only.html results.
noel.gordon@gmail.com [Sat, 25 Feb 2012 07:20:00 +0000 (07:20 +0000)]
Unreviewed. Add missing fast/images/rgb-jpeg-with-adobe-marker-only.html results.

* platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-adobe-marker-only-expected.txt: Removed.
* platform/chromium-win/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Replace RefPtr with OwnPtr for CCLayerImpl tree structure
jamesr@google.com [Sat, 25 Feb 2012 04:09:52 +0000 (04:09 +0000)]
[chromium] Replace RefPtr with OwnPtr for CCLayerImpl tree structure
https://bugs.webkit.org/show_bug.cgi?id=78404

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-02-24
Reviewed by James Robinson.

Source/WebCore:

No new tests. Updated existing test to reflect changes.

* platform/graphics/chromium/CanvasLayerChromium.cpp:
(WebCore::CanvasLayerChromium::createCCLayerImpl):
* platform/graphics/chromium/CanvasLayerChromium.h:
(CanvasLayerChromium):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::createCCLayerImpl):
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
* platform/graphics/chromium/PluginLayerChromium.cpp:
(WebCore::PluginLayerChromium::createCCLayerImpl):
* platform/graphics/chromium/PluginLayerChromium.h:
(PluginLayerChromium):
* platform/graphics/chromium/SolidColorLayerChromium.cpp:
(WebCore::SolidColorLayerChromium::createCCLayerImpl):
* platform/graphics/chromium/SolidColorLayerChromium.h:
(SolidColorLayerChromium):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::createCCLayerImpl):
* platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
* platform/graphics/chromium/TreeSynchronizer.cpp:
(WebCore::TreeSynchronizer::synchronizeTrees):
(WebCore::TreeSynchronizer::collectExistingCCLayerImplRecursive):
(WebCore):
(WebCore::TreeSynchronizer::reuseOrCreateCCLayerImpl):
(WebCore::TreeSynchronizer::synchronizeTreeRecursive):
* platform/graphics/chromium/TreeSynchronizer.h:
(TreeSynchronizer):
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::createCCLayerImpl):
* platform/graphics/chromium/VideoLayerChromium.h:
(VideoLayerChromium):
* platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
(WebCore::CCCanvasLayerImpl::create):
* platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::updateDamageTrackingState):
(WebCore::CCDamageTracker::trackDamageFromActiveLayers):
* platform/graphics/chromium/cc/CCDamageTracker.h:
(CCDamageTracker):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::addChild):
(WebCore::sortLayers):
(WebCore::CCLayerImpl::setMaskLayer):
(WebCore::CCLayerImpl::setReplicaLayer):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::create):
(WebCore::CCLayerImpl::children):
(CCLayerImpl):
(WebCore):
* platform/graphics/chromium/cc/CCLayerIterator.cpp:
(WebCore):
(WebCore::CCLayerIteratorActions::BackToFront::begin):
(WebCore::CCLayerIteratorActions::BackToFront::end):
(WebCore::CCLayerIteratorActions::BackToFront::next):
(WebCore::CCLayerIteratorActions::FrontToBack::begin):
(WebCore::CCLayerIteratorActions::FrontToBack::end):
(WebCore::CCLayerIteratorActions::FrontToBack::next):
(WebCore::CCLayerIteratorActions::FrontToBack::goToHighestInSubtree):
* platform/graphics/chromium/cc/CCLayerIterator.h:
(WebCore):
(CCLayerIterator):
(WebCore::CCLayerIterator::begin):
(WebCore::CCLayerIterator::end):
(WebCore::CCLayerIterator::targetRenderSurfaceLayer):
(WebCore::CCLayerIterator::CCLayerIterator):
(WebCore::CCLayerIterator::getRawPtr):
(WebCore::CCLayerIterator::currentLayer):
(WebCore::CCLayerIterator::targetRenderSurfaceChildren):
(BackToFront):
(FrontToBack):
* platform/graphics/chromium/cc/CCLayerSorter.cpp:
(WebCore::CCLayerSorter::createGraphNodes):
* platform/graphics/chromium/cc/CCLayerSorter.h:
(CCLayerSorter):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
(WebCore::CCLayerTreeHost::reserveTextures):
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
(WebCore::walkLayersAndCalculateVisibleLayerRects):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransformsAndVisibility):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
(CCLayerTreeHostCommon):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::trackDamageForAllSurfaces):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::releaseRootLayer):
(WebCore::CCLayerTreeHostImpl::scrollLayer):
* platform/graphics/chromium/cc/CCPluginLayerImpl.h:
(WebCore::CCPluginLayerImpl::create):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore::CCRenderSurface::layerList):
(CCRenderSurface):
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:
(WebCore::CCSolidColorLayerImpl::create):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(WebCore::CCTiledLayerImpl::create):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(WebCore::CCVideoLayerImpl::create):

Source/WebKit/chromium:

* tests/CCDamageTrackerTest.cpp:
(WebKitTests::executeCalculateDrawTransformsAndVisibility):
(WebKitTests::emulateDrawingOneFrame):
(WebKitTests::createTestTreeWithOneSurface):
(WebKitTests::createTestTreeWithTwoSurfaces):
(WebKitTests::createAndSetUpTestTreeWithOneSurface):
(WebKitTests::createAndSetUpTestTreeWithTwoSurfaces):
(WebKitTests::TEST_F):
* tests/CCLayerImplTest.cpp:
(WebCore::TEST):
* tests/CCLayerIteratorTest.cpp:
* tests/CCLayerSorterTest.cpp:
(WebCore::TEST):
* tests/CCLayerTreeHostCommonTest.cpp:
(WebCore::TEST):
* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::CCLayerTreeHostImplTest::setupScrollAndContentsLayers):
(WebKit::TEST_F):
(WebKit::DidDrawCheckLayer::create):
(WebKit::BlendStateCheckLayer::create):
* tests/CCRenderSurfaceTest.cpp:
(WebCore::TEST):
* tests/CCSolidColorLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
* tests/CCTiledLayerImplTest.cpp:
(CCLayerTestCommon::createLayer):
(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):
* tests/Canvas2DLayerChromiumTest.cpp:
(WebCore::Canvas2DLayerChromiumTest::fullLifecycleTest):
* tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):
* tests/TreeSynchronizerTest.cpp:
(WebKitTests::MockCCLayerImpl::create):
(WebKitTests::MockLayerChromium::createCCLayerImpl):
(WebKitTests::expectTreesAreIdentical):
(WebKitTests::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't pass constant strings to CSSParser for presentation attributes.
kling@webkit.org [Sat, 25 Feb 2012 03:27:12 +0000 (03:27 +0000)]
Don't pass constant strings to CSSParser for presentation attributes.
<http://webkit.org/b/79530>

Reviewed by Anders Carlsson.

"both" -> CSSValueBoth.
"center" -> CSSValueCenter.

* html/HTMLBRElement.cpp:
(WebCore::HTMLBRElement::collectStyleForAttribute):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::collectStyleForAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rename mispelled expectation files.
enne@google.com [Sat, 25 Feb 2012 02:57:09 +0000 (02:57 +0000)]
Unreviewed, rename mispelled expectation files.
https://bugs.webkit.org/show_bug.cgi?id=79457

WebKit is no abode for poor spelling.

* fast/images/rgb-jpeg-with-adobe-marker-only-expected.txt: Renamed from LayoutTests/fast/images/rgb-jpeg-with-abode-marker-only-expected.txt.
* fast/images/rgb-jpeg-with-adobe-marker-only.html: Renamed from LayoutTests/fast/images/rgb-jpeg-with-abode-marker-only.html.
* platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-abode-marker-only-expected.png.
* platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-adobe-marker-only-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-abode-marker-only-expected.txt.
* platform/mac-snowleopard/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png: Renamed from LayoutTests/platform/mac-snowleopard/fast/images/rgb-jpeg-with-abode-marker-only-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Make WebViewImpl depend on WebLayerTreeView instead of CCLayerTreeHost
jamesr@google.com [Sat, 25 Feb 2012 02:55:37 +0000 (02:55 +0000)]
[chromium] Make WebViewImpl depend on WebLayerTreeView instead of CCLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=75591

Reviewed by Kenneth Russell.

This converts WebViewImpl from depending on CCLayerTreeHost to WebLayerTreeView in order to provide better
isolation and allow for future refactorings. The changes to WebViewImpl are mostly mechanical. The
WebLayerTreeView and WebLayerTreeViewClient interfaces have both grown and changed slightly:

- Setup path for WebLayerTreeView changed to expose an initialize() function instead of a create() factory
function. The new model is that a WebLayerTreeView when constructed is in a null state. Calling initialize()
attempts to re-initialize the WLTV, which can either fail or succeed.  All other functions must be called on a
successfully initialized view.

- WebLayerTreeView expanded to include functionality that CCLayerTreeHost exposes but WebLayerTreeView did not.
Some of this is only valid for the single thread case and will be removed when we invert the scheduling control
logic, these bits are commented.

- WebLayerTreeViewClient expanded with some flow-control related APIs.

Refactor only, no change in behavior.

* public/platform/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(WebKit::WebLayerTreeView::isNull):
* public/platform/WebLayerTreeViewClient.h:
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::scheduleCompositingLayerSync):
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::initialize):
(WebKit::WebLayerTreeView::compositorIdentifier):
(WebKit::WebLayerTreeView::setVisible):
(WebKit::WebLayerTreeView::setNeedsAnimate):
(WebKit::WebLayerTreeView::updateAnimations):
(WebKit::WebLayerTreeView::setNeedsRedraw):
(WebKit::WebLayerTreeView::setPageScaleFactorAndLimits):
(WebKit::WebLayerTreeView::startPageScaleAnimation):
(WebKit::WebLayerTreeView::finishAllRendering):
(WebKit::WebLayerTreeView::context):
(WebKit::WebLayerTreeView::loseCompositorContext):
* src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::didRecreateGraphicsContext):
(WebKit::WebLayerTreeViewImpl::didCommitAndDrawFrame):
(WebKit::WebLayerTreeViewImpl::didCompleteSwapBuffers):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::doPixelReadbackToCanvas):
(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::loseCompositorContext):
(WebKit::WebViewImpl::computePageScaleFactorLimits):
(WebKit::WebViewImpl::addPageOverlay):
(WebKit::WebViewImpl::removePageOverlay):
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::scheduleCompositingLayerSync):
(WebKit::WebViewImpl::scrollRootLayerRect):
(WebKit::WebViewImpl::invalidateRootLayerRect):
(WebKit::WebViewImpl::scheduleAnimation):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::createContext3D):
(WebKit::WebViewImpl::applyScrollAndScale):
(WebKit::WebViewImpl::didRebindGraphicsContext):
(WebKit::WebViewImpl::updateLayerTreeViewport):
(WebKit::WebViewImpl::graphicsContext3D):
(WebKit::WebViewImpl::setVisibilityState):
* src/WebViewImpl.h:
* tests/WebLayerTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Texmap] Add const-ness to TextureMapperShaderManager
yael.aharon@nokia.com [Sat, 25 Feb 2012 02:41:41 +0000 (02:41 +0000)]
[Texmap] Add const-ness to TextureMapperShaderManager
https://bugs.webkit.org/show_bug.cgi?id=79545

Reviewed by Noam Rosenthal.

Add const to new methods.
No new tests.

* platform/graphics/texmap/TextureMapperShaderManager.cpp:
(WebCore::TextureMapperShaderProgramSimple::vertexShaderSource):
(WebCore::TextureMapperShaderProgramSimple::fragmentShaderSource):
(WebCore::TextureMapperShaderProgramOpacityAndMask::vertexShaderSource):
(WebCore::TextureMapperShaderProgramOpacityAndMask::fragmentShaderSource):
* platform/graphics/texmap/TextureMapperShaderManager.h:
(WebCore::TextureMapperShaderProgram::matrixVariable):
(WebCore::TextureMapperShaderProgram::sourceMatrixVariable):
(WebCore::TextureMapperShaderProgram::sourceTextureVariable):
(WebCore::TextureMapperShaderProgram::opacityVariable):
(TextureMapperShaderProgram):
(TextureMapperShaderProgramSimple):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskMatrixVariable):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskTextureVariable):
(TextureMapperShaderProgramOpacityAndMask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoXSS Auditor targeting legitimate frames as false positives.
tsepez@chromium.org [Sat, 25 Feb 2012 02:39:10 +0000 (02:39 +0000)]
XSS Auditor targeting legitimate frames as false positives.
https://bugs.webkit.org/show_bug.cgi?id=79397

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xssAuditor/script-tag-safe4.html

* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::filterCharacterToken):
(WebCore::XSSAuditor::filterScriptToken):
(WebCore::XSSAuditor::filterObjectToken):
(WebCore::XSSAuditor::filterEmbedToken):
(WebCore::XSSAuditor::filterAppletToken):
(WebCore::XSSAuditor::filterIframeToken):
(WebCore::XSSAuditor::decodedSnippetForToken):
(WebCore):
(WebCore::XSSAuditor::decodedSnippetForName):
(WebCore::XSSAuditor::decodedSnippetForAttribute):
(WebCore::XSSAuditor::decodedSnippetForJavascript):
(WebCore::XSSAuditor::isContainedInRequest):
(WebCore::XSSAuditor::isSameOriginResource):
* html/parser/XSSAuditor.h:

LayoutTests:

* http/tests/security/xssAuditor/resources/script-tag-safe4-frame.html: Added.
* http/tests/security/xssAuditor/script-tag-safe4-expected.txt: Added.
* http/tests/security/xssAuditor/script-tag-safe4.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Plumb animation started notifications from CCLayerTreeHost to GraphicsLaye...
commit-queue@webkit.org [Sat, 25 Feb 2012 02:19:36 +0000 (02:19 +0000)]
[chromium] Plumb animation started notifications from CCLayerTreeHost to GraphicsLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=77646

Patch by Ian Vollick <vollick@chromium.org> on 2012-02-24
Reviewed by James Robinson.

Source/WebCore:

* WebCore.gypi:
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(std):
(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::mapAnimationNameToId):
(WebCore):
(WebCore::GraphicsLayerChromium::notifyAnimationStarted):
(WebCore::GraphicsLayerChromium::notifyAnimationFinished):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(GraphicsLayerChromium):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setAnimationEvent):
(WebCore):
* platform/graphics/chromium/LayerChromium.h:
(WebCore):
(LayerChromium):
(WebCore::LayerChromium::setLayerAnimationDelegate):
* platform/graphics/chromium/cc/CCAnimationEvents.cpp: Added.
(WebCore):
(WebCore::CCAnimationEvent::CCAnimationEvent):
(WebCore::CCAnimationEvent::~CCAnimationEvent):
(WebCore::CCAnimationEvent::toAnimationStartedEvent):
(WebCore::CCAnimationEvent::toAnimationFinishedEvent):
(WebCore::CCAnimationStartedEvent::create):
(WebCore::CCAnimationStartedEvent::CCAnimationStartedEvent):
(WebCore::CCAnimationStartedEvent::~CCAnimationStartedEvent):
(WebCore::CCAnimationStartedEvent::type):
(WebCore::CCAnimationFinishedEvent::create):
(WebCore::CCAnimationFinishedEvent::CCAnimationFinishedEvent):
(WebCore::CCAnimationFinishedEvent::~CCAnimationFinishedEvent):
(WebCore::CCAnimationFinishedEvent::type):
* platform/graphics/chromium/cc/CCAnimationEvents.h:
(WebCore):
(CCAnimationEvent):
(WebCore::CCAnimationEvent::layerId):
(CCAnimationStartedEvent):
(WebCore::CCAnimationStartedEvent::startTime):
(CCAnimationFinishedEvent):
(WebCore::CCAnimationFinishedEvent::animationId):
* platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.cpp:
(WebCore::CCLayerAnimationControllerImpl::animate):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForNextTick):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForStartTime):
(WebCore::CCLayerAnimationControllerImpl::startAnimationsWaitingForTargetAvailability):
(WebCore::CCLayerAnimationControllerImpl::purgeFinishedAnimations):
(WebCore::CCLayerAnimationControllerImpl::tickAnimations):
* platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.h:
(CCLayerAnimationControllerImpl):
* platform/graphics/chromium/cc/CCLayerAnimationDelegate.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCAnimationEvents.h.
(WebCore):
(CCLayerAnimationDelegate):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setAnimationEvents):
(WebCore::CCLayerTreeHost::setAnimationEventsRecursive):
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

* tests/CCLayerTreeHostTest.cpp:
(TestHooks):
(WTF::TestHooks::notifyAnimationStarted):
(WTF::TestHooks::notifyAnimationFinished):
(WTF::MockLayerTreeHost::create):
(WTF::CCLayerTreeHostTestAddAnimation::CCLayerTreeHostTestAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::animateLayers):
(WTF::CCLayerTreeHostTestAddAnimation::notifyAnimationStarted):
(CCLayerTreeHostTestAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::notifyAnimationFinished):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd watchlist for ChromiumPlatformApi matching Source/Platform/chromium/public/
darin@chromium.org [Sat, 25 Feb 2012 02:19:21 +0000 (02:19 +0000)]
Add watchlist for ChromiumPlatformApi matching Source/Platform/chromium/public/

Reviewed by James Robinson.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRegression(r107477): Crash in StaticNodeList::itemWithName.
inferno@chromium.org [Sat, 25 Feb 2012 02:01:52 +0000 (02:01 +0000)]
Regression(r107477): Crash in StaticNodeList::itemWithName.
https://bugs.webkit.org/show_bug.cgi?id=79532

Reviewed by Andreas Kling.

Source/WebCore:

Make sure that node is an element node before checking its id attribute.

Test: fast/mutation/mutation-callback-non-element-crash.html

* dom/StaticNodeList.cpp:
(WebCore::StaticNodeList::itemWithName):

LayoutTests:

* fast/mutation/mutation-callback-non-element-crash-expected.txt: Added.
* fast/mutation/mutation-callback-non-element-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] WebKit::setColorNames is a client API
jamesr@google.com [Sat, 25 Feb 2012 01:56:53 +0000 (01:56 +0000)]
[chromium] WebKit::setColorNames is a client API
https://bugs.webkit.org/show_bug.cgi?id=79539

Reviewed by Darin Fisher.

Source/Platform:

* Platform.gypi:
* chromium/public/WebColor.h:
(WebKit):

Source/WebKit/chromium:

* WebKit.gyp:
* public/WebColorName.h: Renamed from Source/Platform/chromium/public/WebColorName.h.
(WebKit):
* public/platform/WebColorName.h:
* src/WebColor.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore refactoring in RenderFlexibleBox
tony@chromium.org [Sat, 25 Feb 2012 01:46:27 +0000 (01:46 +0000)]
More refactoring in RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=79533

Reviewed by Ojan Vafai.

No new tests, just refactoring.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutFlexItems): Move the flipping of RTL+column positions to its own method.
This might be a tiny bit slower, but it's clearer since it's not related to alignment.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Move the logical height calculation out of the loop.  We only need the final height.
(WebCore::RenderFlexibleBox::alignChildren):
(WebCore::RenderFlexibleBox::flipForRightToLeftColumn):
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPositioned objects not cleared when moving children
inferno@chromium.org [Sat, 25 Feb 2012 01:31:27 +0000 (01:31 +0000)]
Positioned objects not cleared when moving children
to clone block in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=78416

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/multicol/span/positioned-child-not-removed-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::splitBlocks):

LayoutTests:

* fast/multicol/span/positioned-child-not-removed-crash-expected.txt: Added.
* fast/multicol/span/positioned-child-not-removed-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Unreviewed, Windows build fix. Changed "-1" to newly
msaboff@apple.com [Sat, 25 Feb 2012 01:11:14 +0000 (01:11 +0000)]
    Unreviewed, Windows build fix.  Changed "-1" to newly
        created constant JSC::Yarr::offsetNoMatch added in r108858.

        * platform/text/RegularExpression.cpp:
        (WebCore::RegularExpression::match):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoteam.html (on webkit.org) doesn't recognize codeaurora.org
tomz@codeaurora.org [Sat, 25 Feb 2012 01:10:21 +0000 (01:10 +0000)]
team.html (on webkit.org) doesn't recognize codeaurora.org
https://bugs.webkit.org/show_bug.cgi?id=79529

Reviewed by Ryosuke Niwa.

* team.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate TextTrackCue API
eric.carlson@apple.com [Sat, 25 Feb 2012 00:58:55 +0000 (00:58 +0000)]
Update TextTrackCue API
https://bugs.webkit.org/show_bug.cgi?id=79368

Source/WebCore:

Change TextTrackCue.alignment to .align, TextTrackCue.linePosition and .textPosition to .line
and .position, and TextTrackCue.direction to .vertical. Change direction values "horizontal"
to "","vertical" to "rl", and "vertical-lr" to "lr".

Reviewed by Eric Seidel.

No new tests, updated existing tests for API changes.

* html/track/TextTrackCue.cpp:
(WebCore::horizontalKeyword):
(WebCore::verticalGrowingLeftKeyword):
(WebCore):
(WebCore::verticalGrowingRightKeyword):
(WebCore::verticalKeywordOLD):
(WebCore::verticallrKeywordOLD):
(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::vertical):
(WebCore::TextTrackCue::setVertical):
(WebCore::TextTrackCue::setLine):
(WebCore::TextTrackCue::setPosition):
(WebCore::TextTrackCue::align):
(WebCore::TextTrackCue::setAlign):
(WebCore::TextTrackCue::parseSettings):
* html/track/TextTrackCue.h:
(TextTrackCue):
(WebCore::TextTrackCue::line):
(WebCore::TextTrackCue::position):
* html/track/TextTrackCue.idl:

LayoutTests:

Reviewed by Eric Seidel.

* media/track/track-add-remove-cue-expected.txt:
* media/track/track-add-remove-cue.html:
* media/track/track-cue-mutable-expected.txt:
* media/track/track-cue-mutable.html:
* media/track/track-webvtt-tc013-settings-expected.txt:
* media/track/track-webvtt-tc013-settings.html:
* media/track/track-webvtt-tc014-alignment-expected.txt:
* media/track/track-webvtt-tc014-alignment.html:
* media/track/track-webvtt-tc015-positioning-expected.txt:
* media/track/track-webvtt-tc015-positioning.html:
* media/track/track-webvtt-tc016-align-positioning-expected.txt:
* media/track/track-webvtt-tc016-align-positioning.html:
* media/track/track-webvtt-tc017-line-position-expected.txt:
* media/track/track-webvtt-tc017-line-position.html:
* media/track/track-webvtt-tc018-align-text-line-position-expected.txt:
* media/track/track-webvtt-tc018-align-text-line-position.html:
* media/track/track-webvtt-tc020-cue-size-align-expected.txt:
* media/track/track-webvtt-tc020-cue-size-align.html:
* media/track/track-webvtt-tc021-valign-expected.txt:
* media/track/track-webvtt-tc021-valign.html:
* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix uninitialized variables in HarfBuzzShaperBase
enne@google.com [Sat, 25 Feb 2012 00:54:07 +0000 (00:54 +0000)]
Fix uninitialized variables in HarfBuzzShaperBase
https://bugs.webkit.org/show_bug.cgi?id=79546

Reviewed by Dirk Pranke.

These were introduced in r108733.

* platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:
(WebCore::HarfBuzzShaperBase::HarfBuzzShaperBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] JPEG RGB image with Adode Marker fails to turbo swizzle decode
noel.gordon@gmail.com [Sat, 25 Feb 2012 00:49:47 +0000 (00:49 +0000)]
[chromium] JPEG RGB image with Adode Marker fails to turbo swizzle decode
https://bugs.webkit.org/show_bug.cgi?id=79457

Reviewed by Adam Barth.

Source/WebCore:

If a JPEG has no JFIF marker, the Adode Marker must be used to determine the image
color space for decoding via that markers transform value. Transform 0 images with
3 color components (RGB) fail to decode with libjpeg-turbo when a swizzle decoding
is active. Detect this case and decode using JCS_RGB output color space instead.

Test: fast/images/rgb-jpeg-with-abode-marker-only.html

* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageReader::decode):

LayoutTests:

* fast/images/resources/rgb-jpeg-with-adobe-marker-only.jpg: Added.
* fast/images/rgb-jpeg-with-abode-marker-only-expected.txt: Added.
* fast/images/rgb-jpeg-with-abode-marker-only.html: Added.
* platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-abode-marker-only-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/images/rgb-jpeg-with-abode-marker-only-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* platform/mac-snowleopard/fast/images/rgb-jpeg-with-abode-marker-only-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, Windows build fix. Changed signature in export to match
msaboff@apple.com [Sat, 25 Feb 2012 00:45:57 +0000 (00:45 +0000)]
Unreviewed, Windows build fix.  Changed signature in export to match
change made in r108858.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: changelog_unittest test_fuzzy_reviewer_match is slow
dpranke@chromium.org [Sat, 25 Feb 2012 00:30:36 +0000 (00:30 +0000)]
webkitpy: changelog_unittest test_fuzzy_reviewer_match is slow
https://bugs.webkit.org/show_bug.cgi?id=79258

Reviewed by Ryosuke Niwa.

Split the fuzzy matching into separate functions so that they
can be sharded and run in parallel.

Also, fix a bug in the svn_blame_regexp that was causing us
to require ChangeLog lines to have at least one space after the
author, making the code require trailing whitespace in the
changelog in some places (this was making my life harder because
I have my text editor set to strip trailing whitespace in python
files, and that was causing test_parse_log_entries_from_changelog() to fail
when the whitespace on line 275 was removed).

* Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLog):
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_fuzzy_reviewer_match__none):
(test_fuzzy_reviewer_match_adam_barth):
(test_fuzzy_reviewer_match_darin_adler_et_al):
(test_fuzzy_reviewer_match_dimitri_glazkov):
(test_fuzzy_reviewer_match_george_staikos):
(test_fuzzy_reviewer_match_mark_rowe):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] IndexedDB: IDBTransaction objects leak in Workers
jsbell@chromium.org [Sat, 25 Feb 2012 00:26:48 +0000 (00:26 +0000)]
[V8] IndexedDB: IDBTransaction objects leak in Workers
https://bugs.webkit.org/show_bug.cgi?id=79308

Source/WebCore:

Use a V8RecursionScope whenever Workers call into script, so that
post-script side-effects can be executed.

Reviewed by Tony Chang.

Test: storage/indexeddb/transaction-abort-workers.html

* bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
* bindings/v8/V8WorkerContextErrorHandler.cpp:
(WebCore::V8WorkerContextErrorHandler::callListenerFunction):
* bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::callListenerFunction):
* bindings/v8/WorkerContextExecutionProxy.cpp: Replace custom recursion tracking.
(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::runScript):
* bindings/v8/WorkerContextExecutionProxy.h:
(WorkerContextExecutionProxy):

LayoutTests:

Reviewed by Tony Chang.

* fast/js/resources/js-test-pre.js:
(startWorker): Return Worker object so onerror can be hooked.
* storage/indexeddb/resources/transaction-abort-workers.js: Added.
* storage/indexeddb/transaction-abort-workers-expected.txt: Added.
* storage/indexeddb/transaction-abort-workers.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG support for op_new_regexp should be enabled
fpizlo@apple.com [Sat, 25 Feb 2012 00:23:38 +0000 (00:23 +0000)]
DFG support for op_new_regexp should be enabled
https://bugs.webkit.org/show_bug.cgi?id=79538

Reviewed by Oliver Hunt.

No performance change.

* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGCommon.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r108860.
enne@google.com [Sat, 25 Feb 2012 00:22:15 +0000 (00:22 +0000)]
Unreviewed, rolling out r108860.
http://trac.webkit.org/changeset/108860
https://bugs.webkit.org/show_bug.cgi?id=79544

"Breaks Linux compile" (Requested by enne on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-24

Source/Platform:

* Platform.gypi:
* chromium/public/WebColor.h:
(WebKit):
* chromium/public/WebColorName.h: Renamed from Source/WebKit/chromium/public/WebColorName.h.
(WebKit):

Source/WebKit/chromium:

* WebKit.gyp:
* public/platform/WebColorName.h:
* src/WebColor.cpp: Renamed from Source/WebKit/chromium/src/WebColorName.cpp.
(WebKit):
(WebKit::toCSSValueKeyword):
(WebKit::setNamedColors):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: committers_unittest fuzzy matching is really slow
dpranke@chromium.org [Sat, 25 Feb 2012 00:19:11 +0000 (00:19 +0000)]
webkitpy: committers_unittest fuzzy matching is really slow
https://bugs.webkit.org/show_bug.cgi?id=79179

Reviewed by Ryosuke Niwa.

Break the fuzzy matching tests into individual routines for
each contributor so that the intent is a little clearer, so
that it's easier to test individual names (and identify
duplicate tests), and so that we can eventually run
them in parallel.

Also, mark most of them as 'integration' tests so that they
can be skipped if we want to go fast (we leave a few as
regular tests for functional coverage).

* Scripts/webkitpy/common/config/committers_unittest.py:
(CommittersTest):
(CommittersTest.test_contributors_by_fuzzy_match):
(CommittersTest.integration_test_contributors__none):
(CommittersTest.integration_test_contributors__none_2):
(CommittersTest.integration_test_contributors__none_3):
(CommittersTest.integration_test_contributors_ada_chan):
(CommittersTest.integration_test_contributors_adele_peterson):
(CommittersTest.integration_test_contributors_alexey_proskuryakov):
(CommittersTest.integration_test_contributors_alice_liu):
(CommittersTest.integration_test_contributors_alp_toker):
(CommittersTest.integration_test_contributors_anders_carlsson):
(CommittersTest.integration_test_contributors_antti_koivisto):
(CommittersTest.integration_test_contributors_beth_dakin):
(CommittersTest.integration_test_contributors_brady_eidson):
(CommittersTest.integration_test_contributors_cameron_zwarich):
(CommittersTest.integration_test_contributors_chris_blumenberg):
(CommittersTest.integration_test_contributors_dan_bernstein):
(CommittersTest.integration_test_contributors_dan_bernstein_2):
(CommittersTest.integration_test_contributors_darin_adler):
(CommittersTest.integration_test_contributors_david_harrison):
(CommittersTest.integration_test_contributors_david_harrison_2):
(CommittersTest.integration_test_contributors_david_hyatt):
(CommittersTest.integration_test_contributors_david_kilzer):
(CommittersTest.integration_test_contributors_don_melton):
(CommittersTest.integration_test_contributors_eric_seidel):
(CommittersTest.integration_test_contributors_geoffrey_garen):
(CommittersTest.integration_test_contributors_greg_bolsinga):
(CommittersTest.integration_test_contributors_holger_freyther):
(CommittersTest.integration_test_contributors_jon_sullivan):
(CommittersTest.integration_test_contributors_jon_honeycutt):
(CommittersTest.integration_test_contributors_joseph_pecoraro):
(CommittersTest.integration_test_contributors_ken_kocienda):
(CommittersTest.integration_test_contributors_kenneth_russell):
(CommittersTest.integration_test_contributors_kevin_decker):
(CommittersTest.integration_test_contributors_kevin_mccullough):
(CommittersTest.integration_test_contributors_lars_knoll):
(CommittersTest.integration_test_contributors_lars_weintraub):
(CommittersTest.integration_test_contributors_maciej_stachowiak):
(CommittersTest.integration_test_contributors_mark_rowe):
(CommittersTest.integration_test_contributors_nikolas_zimmermann):
(CommittersTest.integration_test_contributors_oliver_hunt):
(CommittersTest.integration_test_contributors_rniwa):
(CommittersTest.disabled_integration_test_contributors_simon_fraser):
(CommittersTest.integration_test_contributors_steve_falkenburg):
(CommittersTest.integration_test_contributors_sam_weinig):
(CommittersTest.integration_test_contributors_tim_omernick):
(CommittersTest.integration_test_contributors_timothy_hatcher):
(CommittersTest.integration_test_contributors_tor_arne_vestbo):
(CommittersTest.integration_test_contributors_vicki_murley):
(CommittersTest.integration_test_contributors_zack_rusin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: should autoinstall coverage
dpranke@chromium.org [Sat, 25 Feb 2012 00:12:38 +0000 (00:12 +0000)]
webkitpy: should autoinstall coverage
https://bugs.webkit.org/show_bug.cgi?id=79535

Reviewed by Eric Seidel.

We should automatically print the coverage report after the run, too.

* Scripts/webkitpy/test/main.py:
(Tester._run_tests):
* Scripts/webkitpy/thirdparty/__init__.py:
(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_coverage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLimit WebGL Errors in Console to 10 per context
commit-queue@webkit.org [Sat, 25 Feb 2012 00:03:17 +0000 (00:03 +0000)]
Limit WebGL Errors in Console to 10 per context
https://bugs.webkit.org/show_bug.cgi?id=79387

Patch by Gregg Tavares <gman@google.com> on 2012-02-24
Reviewed by Kenneth Russell.

Some apps generated enough errors to overload
the Dev Tools so limit the number of errors.
For a correct app there should never be any
errors so seeing the first few should be enough
to debug.

No new tests as no new functionality

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContextErrorMessageCallback::onErrorMessage):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::printGLErrorToConsole):
(WebCore::WebGLRenderingContext::synthesizeGLError):
* html/canvas/WebGLRenderingContext.h:
(WebGLRenderingContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] WebKit::setColorNames is a client API
jamesr@google.com [Fri, 24 Feb 2012 23:57:36 +0000 (23:57 +0000)]
[chromium] WebKit::setColorNames is a client API
https://bugs.webkit.org/show_bug.cgi?id=79539

Reviewed by Darin Fisher.

Source/Platform:

* Platform.gypi:
* chromium/public/WebColor.h:
(WebKit):

Source/WebKit/chromium:

* WebKit.gyp:
* public/WebColorName.h: Renamed from Source/Platform/chromium/public/WebColorName.h.
(WebKit):
* public/platform/WebColorName.h:
* src/WebColor.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed, mark fast/files/workers tests as flaky crashers
enne@google.com [Fri, 24 Feb 2012 23:57:28 +0000 (23:57 +0000)]
[chromium] Unreviewed, mark fast/files/workers tests as flaky crashers
https://bugs.webkit.org/show_bug.cgi?id=79540

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoASSERT(position < 0) in JSC::Yarr::Interpreter::InputStream::readChecked
msaboff@apple.com [Fri, 24 Feb 2012 23:55:01 +0000 (23:55 +0000)]
ASSERT(position < 0) in JSC::Yarr::Interpreter::InputStream::readChecked
https://bugs.webkit.org/show_bug.cgi?id=73728

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Fixed the mixing of signed and unsigned character indeces in YARR
interpreter.

* runtime/RegExp.cpp:
(JSC::RegExp::match): Added code to check for match longer than 2^31 and
return no match after resetting the offsets.
* yarr/YarrInterpreter.cpp: Changed to use unsigned for all character index
handling except when matching back references.
(JSC::Yarr::Interpreter::InputStream::readChecked):
(JSC::Yarr::Interpreter::InputStream::checkInput):
(JSC::Yarr::Interpreter::InputStream::uncheckInput):
(JSC::Yarr::Interpreter::InputStream::atStart):
(JSC::Yarr::Interpreter::InputStream::atEnd):
(JSC::Yarr::Interpreter::InputStream::isAvailableInput):
(JSC::Yarr::Interpreter::checkCharacter):
(JSC::Yarr::Interpreter::checkCasedCharacter):
(JSC::Yarr::Interpreter::checkCharacterClass):
(JSC::Yarr::Interpreter::tryConsumeBackReference):
(JSC::Yarr::Interpreter::matchAssertionBOL):
(JSC::Yarr::Interpreter::matchAssertionWordBoundary):
(JSC::Yarr::Interpreter::backtrackPatternCharacter):
(JSC::Yarr::Interpreter::backtrackPatternCasedCharacter):
(JSC::Yarr::Interpreter::matchCharacterClass):
(JSC::Yarr::Interpreter::backtrackCharacterClass):
(JSC::Yarr::Interpreter::matchParenthesesOnceBegin):
(JSC::Yarr::Interpreter::matchDisjunction):
(JSC::Yarr::Interpreter::interpret):
(JSC::Yarr::ByteCompiler::assertionBOL):
(JSC::Yarr::ByteCompiler::assertionEOL):
(JSC::Yarr::ByteCompiler::assertionWordBoundary):
(JSC::Yarr::ByteCompiler::atomPatternCharacter):
(JSC::Yarr::ByteCompiler::atomCharacterClass):
(JSC::Yarr::ByteCompiler::atomBackReference):
(JSC::Yarr::ByteCompiler::atomParenthesesOnceBegin):
(JSC::Yarr::ByteCompiler::atomParenthesesTerminalBegin):
(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin):
(JSC::Yarr::ByteCompiler::atomParentheticalAssertionEnd):
(JSC::Yarr::ByteCompiler::emitDisjunction):
* yarr/YarrInterpreter.h:

Source/WebCore:

No new tests, refactored usage of JSC::Yarr interpreter.
Should be covered by existing tests.

Changed WebCore callers of JSC::Yarr:Interpreter::interpret() to match the
new signature with unsigned offsets.

* inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::findMagicComment):
* platform/text/RegularExpression.cpp:
(WebCore::RegularExpression::match):

LayoutTests:

Updated test for change.  Test is from defect.

* fast/regex/overflow-expected.txt:
* fast/regex/script-tests/overflow.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoonclick is not reliable for transformed SVG elements
commit-queue@webkit.org [Fri, 24 Feb 2012 23:49:15 +0000 (23:49 +0000)]
onclick is not reliable for transformed SVG elements
https://bugs.webkit.org/show_bug.cgi?id=34714

Patch by Hans Muller <hmuller@adobe.com> on 2012-02-24
Reviewed by Dirk Schulze.

Source/WebCore:

Use FloatPoints in RenderSVGRoot::nodeAtPoint() when converting the incoming
point to local coordinates.

Test: svg/hittest/svg-small-viewbox.xhtml

* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::nodeAtPoint):

LayoutTests:

New svg-small-viewbox test checks that elementFromPoint() works correctly with SVG
elements defined within a 1x1 viewbox.

Revised select-textLength-spacing-squeeze-2.svg to avoid a corner-case,
removed unnecessary -1 adjustment of absEndPos.x from SelectionTestCase.js.

* platform/chromium/test_expectations.txt:
* platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.png:
* platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
* svg/hittest/svg-small-viewbox-expected.txt: Added.
* svg/hittest/svg-small-viewbox.xhtml: Added.
* svg/text/resources/SelectionTestCase.js:
(selectRange):
* svg/text/select-textLength-spacing-squeeze-2.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, build fix for builds where the DFG is disabled but the LLInt is
fpizlo@apple.com [Fri, 24 Feb 2012 23:35:23 +0000 (23:35 +0000)]
Unreviewed, build fix for builds where the DFG is disabled but the LLInt is
enabled.

* llint/LLIntOfflineAsmConfig.h:
* llint/LowLevelInterpreter.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement limited parsing of -webkit-grid-column and -webkit-grid-row
jchaffraix@webkit.org [Fri, 24 Feb 2012 23:24:46 +0000 (23:24 +0000)]
Implement limited parsing of -webkit-grid-column and -webkit-grid-row
https://bugs.webkit.org/show_bug.cgi?id=79151

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/css-grid-layout/grid-item-column-row-get-set.html

This change implements a subset of the grammar:

-webkit-grid-{row|column} := <integer> | 'auto'

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Added the new files to our build systems.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForGridPosition): Check that we have the right translated grammar
(this function will be more useful once we implement more of the grammar).
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Added handling for the new properties.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
Allow only 'auto' or <integer>.

* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
grid-colum and grid-row are not inherited.

* css/CSSPropertyNames.in:
Added the 2 new properties.

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h:
* rendering/style/StyleGridItemData.cpp: Added.
(WebCore::StyleGridItemData::StyleGridItemData):
* rendering/style/StyleGridItemData.h: Added.
(StyleGridItemData):
(WebCore::StyleGridItemData::create):
(WebCore::StyleGridItemData::copy):
(WebCore::StyleGridItemData::operator==):
(WebCore::StyleGridItemData::operator!=):
Implemented the minimum working class.

* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
Added StyleGridItemData to the class StyleRareNonInheritedData.

LayoutTests:

* fast/css-grid-layout/grid-item-column-row-get-set-expected.txt: Added.
* fast/css-grid-layout/grid-item-column-row-get-set.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed gardening. Remove expectations for nonexistent tests.
enne@google.com [Fri, 24 Feb 2012 23:18:55 +0000 (23:18 +0000)]
[chromium] Unreviewed gardening. Remove expectations for nonexistent tests.

Make --lint-test-files run clean again for Chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix copypasta in build-webkit's --vibration option description
commit-queue@webkit.org [Fri, 24 Feb 2012 23:03:06 +0000 (23:03 +0000)]
Fix copypasta in build-webkit's --vibration option description
https://bugs.webkit.org/show_bug.cgi?id=79528

Patch by Pablo Flouret <pablof@motorola.com> on 2012-02-24
Reviewed by Andreas Kling.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: IDBObjectStore.count() and IDBIndex.count() should accept key argument
jsbell@chromium.org [Fri, 24 Feb 2012 22:56:00 +0000 (22:56 +0000)]
IndexedDB: IDBObjectStore.count() and IDBIndex.count() should accept key argument
https://bugs.webkit.org/show_bug.cgi?id=79422

Reviewed by Tony Chang.

Source/WebCore:

Tests: storage/indexeddb/index-count.html
       storage/indexeddb/objectstore-count.html

* storage/IDBIndex.cpp:
(WebCore::IDBIndex::count):
(WebCore):
* storage/IDBIndex.h:
(WebCore::IDBIndex::count):
(IDBIndex):
* storage/IDBIndex.idl:
* storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::count):
(WebCore):
* storage/IDBObjectStore.h:
(WebCore::IDBObjectStore::count):
(IDBObjectStore):
* storage/IDBObjectStore.idl:

LayoutTests:

* storage/indexeddb/index-count-expected.txt:
* storage/indexeddb/index-count.html:
* storage/indexeddb/objectstore-count-expected.txt:
* storage/indexeddb/objectstore-count.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r108730): Webkit nightlies fails to start due to WKPreferencesGetSuppress...
aestes@apple.com [Fri, 24 Feb 2012 22:54:58 +0000 (22:54 +0000)]
REGRESSION (r108730): Webkit nightlies fails to start due to WKPreferencesGetSuppressIncrementalRendering renaming
https://bugs.webkit.org/show_bug.cgi?id=79515

Reviewed by Alexey Proskuryakov.

Some versions of Safari contain call sites to two functions in WebKit2
that were removed in r108730. Restore these two functions so that these
versions of Safari can be used with WebKit nightly builds.

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetSuppressIncrementalRendering):
(WKPreferencesGetSuppressIncrementalRendering):
* UIProcess/API/C/WKPreferences.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/10805709> and https://bugs.webkit.org/show_bug.cgi?id=79421
beidson@apple.com [Fri, 24 Feb 2012 22:46:35 +0000 (22:46 +0000)]
<rdar://problem/10805709> and https://bugs.webkit.org/show_bug.cgi?id=79421
Need a WK1 Mac API to filter which subframes go into WebArchives as they are created

Reviewed by Sam Weinig (with additional comments by Adam Roben)

Add webArchiveByFilteringSubframes: which takes a callback block:
* DOM/WebDOMOperationsPrivate.h:

Add FrameFilter that adapts the block, and use it to implement the new SPI:
* DOM/WebDOMOperations.mm:
(WebFrameFilter):
(WebFrameFilter::WebFrameFilter):
(WebFrameFilter::~WebFrameFilter):
(WebFrameFilter::shouldIncludeSubframe):
(-[DOMNode webArchiveByFilteringSubframes:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove mediastream into Modules/mediastream
abarth@webkit.org [Fri, 24 Feb 2012 22:39:54 +0000 (22:39 +0000)]
Move mediastream into Modules/mediastream
https://bugs.webkit.org/show_bug.cgi?id=79517

Reviewed by Eric Seidel.

This patch moves the mediastream directory into Modules.  mediastream
is a self-contained feature and is a good candidate for being a module.

* GNUmakefile.am:
* GNUmakefile.list.am:
* Modules/mediastream: Copied from Source/WebCore/mediastream.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* mediastream: Removed.
* mediastream/DOMWindowMediaStream.idl: Removed.
* mediastream/LocalMediaStream.cpp: Removed.
* mediastream/LocalMediaStream.h: Removed.
* mediastream/LocalMediaStream.idl: Removed.
* mediastream/MediaStream.cpp: Removed.
* mediastream/MediaStream.h: Removed.
* mediastream/MediaStream.idl: Removed.
* mediastream/MediaStreamEvent.cpp: Removed.
* mediastream/MediaStreamEvent.h: Removed.
* mediastream/MediaStreamEvent.idl: Removed.
* mediastream/MediaStreamList.cpp: Removed.
* mediastream/MediaStreamList.h: Removed.
* mediastream/MediaStreamList.idl: Removed.
* mediastream/MediaStreamRegistry.cpp: Removed.
* mediastream/MediaStreamRegistry.h: Removed.
* mediastream/MediaStreamTrack.cpp: Removed.
* mediastream/MediaStreamTrack.h: Removed.
* mediastream/MediaStreamTrack.idl: Removed.
* mediastream/MediaStreamTrackList.cpp: Removed.
* mediastream/MediaStreamTrackList.h: Removed.
* mediastream/MediaStreamTrackList.idl: Removed.
* mediastream/NavigatorMediaStream.cpp: Removed.
* mediastream/NavigatorMediaStream.h: Removed.
* mediastream/NavigatorMediaStream.idl: Removed.
* mediastream/NavigatorUserMediaError.h: Removed.
* mediastream/NavigatorUserMediaError.idl: Removed.
* mediastream/NavigatorUserMediaErrorCallback.h: Removed.
* mediastream/NavigatorUserMediaErrorCallback.idl: Removed.
* mediastream/NavigatorUserMediaSuccessCallback.h: Removed.
* mediastream/NavigatorUserMediaSuccessCallback.idl: Removed.
* mediastream/PeerConnection.cpp: Removed.
* mediastream/PeerConnection.h: Removed.
* mediastream/PeerConnection.idl: Removed.
* mediastream/SignalingCallback.h: Removed.
* mediastream/SignalingCallback.idl: Removed.
* mediastream/UserMediaClient.h: Removed.
* mediastream/UserMediaController.cpp: Removed.
* mediastream/UserMediaController.h: Removed.
* mediastream/UserMediaRequest.cpp: Removed.
* mediastream/UserMediaRequest.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Move WebGraphicsContext3D header into the Platform directory
jamesr@google.com [Fri, 24 Feb 2012 22:38:22 +0000 (22:38 +0000)]
[chromium] Move WebGraphicsContext3D header into the Platform directory
https://bugs.webkit.org/show_bug.cgi?id=79301

Reviewed by Adam Barth.

Moves WebGraphicsContext3D and WebNonCopyable (which WGC3D depends on).

Source/Platform:

* Platform.gypi:
* chromium/public/WebGraphicsContext3D.h: Copied from Source/WebKit/chromium/public/platform/WebGraphicsContext3D.h.
(WebKit):
(WebGraphicsContext3D):
(ActiveInfo):
(WebKit::WebGraphicsContext3D::Attributes::Attributes):
(Attributes):
(WebGraphicsContextLostCallback):
(WebKit::WebGraphicsContext3D::WebGraphicsContextLostCallback::~WebGraphicsContextLostCallback):
(WebGraphicsErrorMessageCallback):
(WebKit::WebGraphicsContext3D::WebGraphicsErrorMessageCallback::~WebGraphicsErrorMessageCallback):
(WebGraphicsSwapBuffersCompleteCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::WebGraphicsSwapBuffersCompleteCallbackCHROMIUM::~WebGraphicsSwapBuffersCompleteCallbackCHROMIUM):
(WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::WebGraphicsMemoryAllocationChangedCallbackCHROMIUM::~WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::~WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::setMemoryAllocationChangedCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::setParentContext):
(WebKit::WebGraphicsContext3D::setSwapBuffersCompleteCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::rateLimitOffscreenContextCHROMIUM):
(WebKit::WebGraphicsContext3D::setContextLostCallback):
(WebKit::WebGraphicsContext3D::setErrorMessageCallback):
(WebKit::WebGraphicsContext3D::getGraphicsResetStatusARB):
(WebKit::WebGraphicsContext3D::getTranslatedShaderSourceANGLE):
(WebKit::WebGraphicsContext3D::texImageIOSurface2DCHROMIUM):
(WebKit::WebGraphicsContext3D::texStorage2DEXT):
(WebKit::WebGraphicsContext3D::onCreateGrGLInterface):
* chromium/public/WebNonCopyable.h: Copied from Source/WebKit/chromium/public/platform/WebNonCopyable.h.
(WebKit):
(WebNonCopyable):
(WebKit::WebNonCopyable::WebNonCopyable):
(WebKit::WebNonCopyable::~WebNonCopyable):

Source/WebKit/chromium:

* public/platform/WebGraphicsContext3D.h:
* public/platform/WebNonCopyable.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOverhanging floats not removed from new flex box.
inferno@chromium.org [Fri, 24 Feb 2012 22:24:25 +0000 (22:24 +0000)]
Overhanging floats not removed from new flex box.
https://bugs.webkit.org/show_bug.cgi?id=79522

Reviewed by Ojan Vafai.

Source/WebCore:

Similar to r69476.

Test: fast/flexbox/overhanging-floats-not-removed-crash.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):

LayoutTests:

* fast/flexbox/overhanging-floats-not-removed-crash-expected.txt: Added.
* fast/flexbox/overhanging-floats-not-removed-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename dom*_*attributes.html to dom*-*attributes.html to follow the WebKit convention.
rniwa@webkit.org [Fri, 24 Feb 2012 22:15:49 +0000 (22:15 +0000)]
Rename dom*_*attributes.html to dom*-*attributes.html to follow the WebKit convention.

* Bindings/dom-attributes.html: Copied from PerformanceTests/Bindings/dom_attributes.html.
* Bindings/dom_attributes.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIncrement perf-o-matic version.
rniwa@webkit.org [Fri, 24 Feb 2012 22:09:59 +0000 (22:09 +0000)]
Increment perf-o-matic version.

* Websites/webkit-perf.appspot.com/app.yaml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdding myself to ScrollingCoordinator watchlist
commit-queue@webkit.org [Fri, 24 Feb 2012 21:40:44 +0000 (21:40 +0000)]
Adding myself to ScrollingCoordinator watchlist
https://bugs.webkit.org/show_bug.cgi?id=79525

Patch by Antonio Gomes <agomes@rim.com> on 2012-02-24
Reviewed by Rob Buis.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WinCairo] Compute more acurate font heights.
bfulgham@webkit.org [Fri, 24 Feb 2012 21:38:54 +0000 (21:38 +0000)]
[WinCairo] Compute more acurate font heights.
https://bugs.webkit.org/show_bug.cgi?id=79524

Reviewed by Adam Roben.

Adjust font handling as suggested by Lynn Neir to use the proper
xHeight value for the font, rather than the fall-back guess
used in the current code.

css1/text_properties/line_height.html

* platform/graphics/win/SimpleFontDataCairoWin.cpp:
(WebCore::SimpleFontData::platformInit): Properly initialize a
  few elements.
(WebCore::SimpleFontData::platformWidthForGlyph): Use the Cairo
  cairo_scaled_font_text_extents call, rather than attempting
  to compute the value from ::GetGlyphOutline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG should be able to handle variables getting captured
fpizlo@apple.com [Fri, 24 Feb 2012 21:31:37 +0000 (21:31 +0000)]
DFG should be able to handle variables getting captured
https://bugs.webkit.org/show_bug.cgi?id=79469

Reviewed by Oliver Hunt.

Made captured variables work by placing a Flush on the SetLocal and
forcing the emission of the GetLocal even if copy propagation tells us
who has the value.

Changed the CFA and various prediction codes to understand that we can't
really prove anything about captured variables. Well, we could in the
future by just looking at what side effects are happening, but in this
first cut we just assume that we can't reason about captured variables.

Also added a mode where the DFG pretends that all variables and arguments
got captured. Used this mode to harden the code.

This is performance neutral. Capturing all variables is a slow down, but
not too big of one. This seems to predict that when we add activation
support, the amount of speed benefit we'll get from increased coverage
will far outweigh the pessimism that we'll have to endure for captured
variables.

* bytecode/CodeType.h:
(JSC::codeTypeToString):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::merge):
* dfg/DFGAbstractState.h:
(AbstractState):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::flushArgument):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGCapabilities.h:
(JSC::DFG::mightInlineFunctionForCall):
(JSC::DFG::mightInlineFunctionForConstruct):
* dfg/DFGCommon.h:
* dfg/DFGGraph.h:
(JSC::DFG::Graph::needsActivation):
(Graph):
(JSC::DFG::Graph::argumentIsCaptured):
(JSC::DFG::Graph::localIsCaptured):
(JSC::DFG::Graph::isCaptured):
* dfg/DFGNode.h:
(JSC::DFG::Node::shouldGenerate):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):
* dfg/DFGSpeculativeJIT.cpp:
(DFG):
(JSC::DFG::ValueSource::dump):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(ValueSource):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShould not allow malformed \x escapes
barraclough@apple.com [Fri, 24 Feb 2012 21:10:36 +0000 (21:10 +0000)]
Should not allow malformed \x escapes
https://bugs.webkit.org/show_bug.cgi?id=79462

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

* parser/Lexer.cpp:
(JSC::::parseString):
(JSC::::parseStringSlowCase):
    - Prohibit malformed '\x' escapes
* tests/mozilla/ecma/Array/15.4.5.1-1.js:
* tests/mozilla/ecma/LexicalConventions/7.7.4.js:
* tests/mozilla/ecma_2/RegExp/hex-001.js:
* tests/mozilla/js1_2/regexp/hexadecimal.js:
    - Remove erroneous test cases (correct behaviour is tested by LayoutTests/sputnik).

LayoutTests:

* fast/regex/script-tests/pcre-test-1.js:
    - Fix bad escapes in test case.
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A4.3_T6-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A6.1_T4-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A6.2_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A6.2_T2-expected.txt:
    - Check in passing results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Purge Skia's GPU texture cache using GL_CHROMIUM_gpu_memory_manager
commit-queue@webkit.org [Fri, 24 Feb 2012 21:08:00 +0000 (21:08 +0000)]
[chromium] Purge Skia's GPU texture cache using GL_CHROMIUM_gpu_memory_manager
https://bugs.webkit.org/show_bug.cgi?id=78265

Patch by Michal Mocny <mmocny@google.com> on 2012-02-24
Reviewed by Stephen White.

* src/GraphicsContext3DChromium.cpp:
(GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
(WebCore):
(WebCore::GraphicsContext3DPrivate::grContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix flaky tests by removing call to dumpResourceResponseMIMETypes
enne@google.com [Fri, 24 Feb 2012 21:06:27 +0000 (21:06 +0000)]
Fix flaky tests by removing call to dumpResourceResponseMIMETypes
https://bugs.webkit.org/show_bug.cgi?id=79505

Reviewed by Daniel Bates.

It appears to be a race condition (on Chromium at least) between when
script executes and the style sheet resource response occurs. This
prevents some of the text to be output if the response occurs before
the call to set the flag to dump responses. Since the tests themselves
already test the results of loading stylesheets properly, this extra
text is superfluous and can be removed.

This change modifies all tests using link-load-utilities.js to dump
stylesheet resource responses. Other tests are using
dumpResponseResponseMIMEType, but for things other than stylesheets.

* fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import-expected.txt:
* fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-non-existent-import-expected.txt:
* fast/dom/HTMLLinkElement/link-onload-before-page-load-expected.txt:
* fast/dom/HTMLLinkElement/link-onload-expected.txt:
* fast/dom/HTMLLinkElement/link-onload-stylesheet-with-import-expected.txt:
* fast/dom/HTMLLinkElement/link-onload2-expected.txt:
* fast/dom/HTMLLinkElement/programmatically-add-link-with-onload-handler-expected.txt:
* fast/dom/HTMLLinkElement/resources/link-load-utilities.js:
* fast/dom/HTMLStyleElement/style-onerror-with-existent-and-non-existent-import-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate watchlist for ChromiumPublicApi to include Platform/chromium/public/
darin@chromium.org [Fri, 24 Feb 2012 20:45:39 +0000 (20:45 +0000)]
Update watchlist for ChromiumPublicApi to include Platform/chromium/public/

Reviewed by Adam Barth.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: config_unittest is sensitive to other tests that might've already run
dpranke@chromium.org [Fri, 24 Feb 2012 20:42:07 +0000 (20:42 +0000)]
webkitpy: config_unittest is sensitive to other tests that might've already run
https://bugs.webkit.org/show_bug.cgi?id=79382

Reviewed by Adam Barth.

If another test runs prior to config_unittest and pokes the
cached configuration, the first test in config_unittest might
fail; the tearDown() will then allow subsequent tests to pass.
Clearing the configuration prior to each test makes things
slightly slower but safer.

* Scripts/webkitpy/layout_tests/port/config_unittest.py:
(ConfigTest.setUp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse xcrun to find compiler paths for Generate Derived Sources build phase script
ddkilzer@apple.com [Fri, 24 Feb 2012 20:36:45 +0000 (20:36 +0000)]
Use xcrun to find compiler paths for Generate Derived Sources build phase script
<http://webkit.org/b/79512>

Reviewed by Dan Bernstein.

* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
(Generate Derived Sources): Use xcrun to find the path to the
compiler since that works on both iOS and OS X.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake fast/canvas/canvas-strokePath-shadow.html allow for pixel tolerance
commit-queue@webkit.org [Fri, 24 Feb 2012 20:07:12 +0000 (20:07 +0000)]
Make fast/canvas/canvas-strokePath-shadow.html allow for pixel tolerance
https://bugs.webkit.org/show_bug.cgi?id=79488

Patch by Elliot Poger <epoger@google.com> on 2012-02-24
Reviewed by Adam Barth.

* fast/canvas/script-tests/canvas-strokePath-shadow.js:
(shouldBeAlmost):
* fast/js/resources/js-test-pre.js:
(shouldBeCloseTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInfinite repaint loop with SVGImageCache and deferred repaint timers
timothy_horton@apple.com [Fri, 24 Feb 2012 19:41:12 +0000 (19:41 +0000)]
Infinite repaint loop with SVGImageCache and deferred repaint timers
https://bugs.webkit.org/show_bug.cgi?id=78315
<rdar://problem/10651634>

Reviewed by Dean Jackson.

Only defer image redraw on a timer if we're in layout. This breaks
the repaint loop while still preventing us from drawing inside layout.

No new tests, as the problem only occurs in a nonstandard configuration.

* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::draw):
(WebCore::SVGImage::frameView):
(WebCore):
* svg/graphics/SVGImage.h:
(WebCore):
* svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::redrawTimerFired):
(WebCore):
* svg/graphics/SVGImageCache.h:
(SVGImageCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove deprecated and unused WebGraphicsContext3D::initialize call
jamesr@google.com [Fri, 24 Feb 2012 19:40:00 +0000 (19:40 +0000)]
[chromium] Remove deprecated and unused WebGraphicsContext3D::initialize call
https://bugs.webkit.org/show_bug.cgi?id=79296

Reviewed by Kenneth Russell.

The old way to initialize a WebGraphicsContext3D from inside WebKit was to call initialize() on it with a
WebView*. The new way to do this is via the WebViewClient interface. This deletes the old, unused path.

* public/platform/WebGraphicsContext3D.h:
(WebKit):
* tests/CCLayerTreeHostImplTest.cpp:
* tests/FakeWebGraphicsContext3D.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSVG should be supported in Dashboard compatibility mode
timothy_horton@apple.com [Fri, 24 Feb 2012 19:39:01 +0000 (19:39 +0000)]
SVG should be supported in Dashboard compatibility mode
https://bugs.webkit.org/show_bug.cgi?id=78322
<rdar://problem/5861278>

Reviewed by Dean Jackson.

Enable SVG elements inside Dashboard, more or less reverting r21418.

Tests: http/tests/xmlhttprequest/svg-created-by-xhr-allowed-in-dashboard.html
       svg/custom/embedded-svg-allowed-in-dashboard.xml
       svg/custom/manually-parsed-embedded-svg-allowed-in-dashboard.html
       svg/custom/manually-parsed-svg-allowed-in-dashboard.html
       svg/custom/svg-allowed-in-dashboard-object.html

* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
* dom/Document.cpp:
(WebCore::Document::importNode):
* dom/make_names.pl:
(printFactoryCppFile):

Change tests that ensured that SVG didn't work in Dashboard to instead test that it does!

* http/tests/xmlhttprequest/svg-created-by-xhr-allowed-in-dashboard-expected.txt: Added.
* http/tests/xmlhttprequest/svg-created-by-xhr-allowed-in-dashboard.html: Renamed from LayoutTests/http/tests/xmlhttprequest/svg-created-by-xhr-disallowed-in-dashboard.html.
* http/tests/xmlhttprequest/svg-created-by-xhr-disallowed-in-dashboard-expected.txt: Removed.
* svg/custom/embedded-svg-allowed-in-dashboard-expected.txt: Added.
* svg/custom/embedded-svg-allowed-in-dashboard.xml: Renamed from LayoutTests/svg/custom/embedded-svg-disallowed-in-dashboard.xml.
* svg/custom/embedded-svg-disallowed-in-dashboard-expected.txt: Removed.
* svg/custom/manually-parsed-embedded-svg-allowed-in-dashboard-expected.txt: Added.
* svg/custom/manually-parsed-embedded-svg-allowed-in-dashboard.html: Renamed from LayoutTests/svg/custom/manually-parsed-embedded-svg-disallowed-in-dashboard.html.
* svg/custom/manually-parsed-embedded-svg-disallowed-in-dashboard-expected.txt: Removed.
* svg/custom/manually-parsed-svg-allowed-in-dashboard-expected.txt: Added.
* svg/custom/manually-parsed-svg-allowed-in-dashboard.html: Renamed from LayoutTests/svg/custom/manually-parsed-svg-disallowed-in-dashboard.html.
* svg/custom/manually-parsed-svg-disallowed-in-dashboard-expected.txt: Removed.
* svg/custom/svg-allowed-in-dashboard-object-expected.txt: Added.
* svg/custom/svg-allowed-in-dashboard-object.html: Renamed from LayoutTests/svg/custom/svg-disallowed-in-dashboard-object.html.
* svg/custom/svg-disallowed-in-dashboard-object-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoExpose a setting to exempt media playback from user gesture requirement after a user...
commit-queue@webkit.org [Fri, 24 Feb 2012 19:35:27 +0000 (19:35 +0000)]
Expose a setting to exempt media playback from user gesture requirement after a user gesture is initiated on loading/playing a media
https://bugs.webkit.org/show_bug.cgi?id=79167

Patch by Min Qin <qinmin@google.com> on 2012-02-24
Reviewed by Adam Barth.

Source/WebCore:

Test: media/video-play-require-user-gesture.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::load):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::removeBehaviorsRestrictionsAfterFirstUserGesture):
(WebCore):
* html/HTMLMediaElement.h:
(HTMLMediaElement):
* testing/Internals.cpp:
(WebCore::Internals::setMediaPlaybackRequiresUserGesture):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

LayoutTests:

* media/video-play-require-user-gesture-expected.txt: Added.
* media/video-play-require-user-gesture.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDOMWindow*.idl should have had the same license block as DOMWindow.idl did originally
abarth@webkit.org [Fri, 24 Feb 2012 19:32:43 +0000 (19:32 +0000)]
DOMWindow*.idl should have had the same license block as DOMWindow.idl did originally
https://bugs.webkit.org/show_bug.cgi?id=79507

Reviewed by Alexey Proskuryakov.

In moving pieces of DOMWindow.idl into separate files, we mistakenly
changed some of the license blocks.  All these files should have a
license block that matches the file that originally contained the code.

* Modules/intents/DOMWindowIntents.idl:
* fileapi/DOMWindowFileSystem.idl:
* html/DOMWindowHTML.idl:
* html/canvas/DOMWindowWebGL.idl:
* mediastream/DOMWindowMediaStream.idl:
* storage/DOMWindowSQLDatabase.idl:
* svg/DOMWindowSVG.idl:
* webaudio/DOMWindowWebAudio.idl:
* websockets/DOMWindowWebSocket.idl:
* workers/DOMWindowWorker.idl:
* xml/DOMWindowXML.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Move Web*Layer* headers into Platform
jamesr@google.com [Fri, 24 Feb 2012 19:28:42 +0000 (19:28 +0000)]
[chromium] Move Web*Layer* headers into Platform
https://bugs.webkit.org/show_bug.cgi?id=79425

Reviewed by Adam Barth.

Source/Platform:

This moves the Web*Layer* headers and their dependencies from WebKit/chromium/public/platform/ into
Platform/chromium/public.

* Platform.gypi:
* chromium/public/WebCanvas.h: Copied from Source/WebKit/chromium/public/platform/WebCanvas.h.
(WebKit):
* chromium/public/WebColor.h: Copied from Source/WebKit/chromium/public/platform/WebColor.h.
(WebKit):
* chromium/public/WebColorName.h: Copied from Source/WebKit/chromium/public/platform/WebColorName.h.
(WebKit):
* chromium/public/WebContentLayer.h: Copied from Source/WebKit/chromium/public/platform/WebContentLayer.h.
(WebKit):
(WebContentLayer):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::~WebContentLayer):
(WebKit::WebContentLayer::operator=):
* chromium/public/WebContentLayerClient.h: Copied from Source/WebKit/chromium/public/platform/WebContentLayerClient.h.
(WebKit):
(WebContentLayerClient):
(WebKit::WebContentLayerClient::~WebContentLayerClient):
* chromium/public/WebExternalTextureLayer.h: Copied from Source/WebKit/chromium/public/platform/WebExternalTextureLayer.h.
(WebKit):
(WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::~WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::operator=):
* chromium/public/WebLayer.h: Copied from Source/WebKit/chromium/public/platform/WebLayer.h.
(WebKit):
(WebLayer):
(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::~WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::isNull):
(WebKit::WebLayer::to):
(WebKit::WebLayer::toConst):
(WebKit::WebLayer::unwrap):
(WebKit::WebLayer::constUnwrap):
(WebKit::operator==):
(WebKit::operator!=):
* chromium/public/WebLayerTreeView.h: Copied from Source/WebKit/chromium/public/platform/WebLayerTreeView.h.
(WebCore):
(WebKit):
(WebLayerTreeView):
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):
(WebKit::WebLayerTreeView::WebLayerTreeView):
(WebKit::WebLayerTreeView::~WebLayerTreeView):
(WebKit::WebLayerTreeView::operator=):
(WebKit::operator==):
(WebKit::operator!=):
* chromium/public/WebLayerTreeViewClient.h: Copied from Source/WebKit/chromium/public/platform/WebLayerTreeViewClient.h.
(WebKit):
(WebLayerTreeViewClient):
(WebKit::WebLayerTreeViewClient::~WebLayerTreeViewClient):
* chromium/public/WebPrivatePtr.h: Copied from Source/WebKit/chromium/public/platform/WebPrivatePtr.h.
(WebKit):
(WebPrivatePtr):
(WebKit::WebPrivatePtr::WebPrivatePtr):
(WebKit::WebPrivatePtr::~WebPrivatePtr):
(WebKit::WebPrivatePtr::isNull):
(WebKit::WebPrivatePtr::reset):
(WebKit::WebPrivatePtr::operator=):
(WebKit::WebPrivatePtr::get):
(WebKit::WebPrivatePtr::operator->):
(WebKit::WebPrivatePtr::assign):
* chromium/public/WebSolidColorLayer.h: Copied from Source/WebKit/chromium/public/platform/WebSolidColorLayer.h.
(WebKit):
(WebSolidColorLayer):

Source/WebKit/chromium:

Adds forwarding headers for Web*Layer* APIs and their dependencies.  The forwarding headers for the Web*Layer*
APIs are temporary since Web*Layer* is not exposed in the client interface.  The other headers (such as
WebColor) are exposed in both the client and platform APIs, so the forwarding headers are permanent, although we
might move them back down to public/ at some point.

* public/platform/WebCanvas.h:
* public/platform/WebColor.h:
* public/platform/WebColorName.h:
* public/platform/WebContentLayer.h:
* public/platform/WebContentLayerClient.h:
* public/platform/WebExternalTextureLayer.h:
* public/platform/WebLayer.h:
* public/platform/WebLayerTreeView.h:
* public/platform/WebLayerTreeViewClient.h:
* public/platform/WebPrivatePtr.h:
* public/platform/WebSolidColorLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoVersioning.
lforschler@apple.com [Fri, 24 Feb 2012 19:27:07 +0000 (19:27 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse xcrun to find compiler paths for Generate Derived Sources build phase script
ddkilzer@apple.com [Fri, 24 Feb 2012 19:22:11 +0000 (19:22 +0000)]
Use xcrun to find compiler paths for Generate Derived Sources build phase script
<http://webkit.org/b/79512>

Reviewed by Mark Rowe.

* WebCore.xcodeproj/project.pbxproj:
(Generate Derived Sources): Use xcrun to find the path to the
compiler since that works on both iOS and OS X.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash in TileCache::revalidateTiles
andersca@apple.com [Fri, 24 Feb 2012 19:06:34 +0000 (19:06 +0000)]
Crash in TileCache::revalidateTiles
https://bugs.webkit.org/show_bug.cgi?id=79510
<rdar://problem/10928035>

Reviewed by Sam Weinig.

Handle the tile cache layer's PlatformCALayer going away before the
CALayer itself has been deallocated.

* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::revalidateTiles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCreate a watchlist for ScrollingCoordinator changes
jamesr@google.com [Fri, 24 Feb 2012 19:06:29 +0000 (19:06 +0000)]
Create a watchlist for ScrollingCoordinator changes
https://bugs.webkit.org/show_bug.cgi?id=79511

Reviewed by Anders Carlsson.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove spurious mac-specific tests
commit-queue@webkit.org [Fri, 24 Feb 2012 19:00:17 +0000 (19:00 +0000)]
Remove spurious mac-specific tests
https://bugs.webkit.org/show_bug.cgi?id=75091

Patch by Philip Rogers <pdr@google.com> on 2012-02-24
Reviewed by Daniel Bates.

* platform/mac/svg/text/text-rescale.html: Removed.
* platform/mac/svg/text/text-viewbox-rescale.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agorequestPermission callback not invoked if the WebProcess doesn't have to ask the...
jberlin@webkit.org [Fri, 24 Feb 2012 18:51:25 +0000 (18:51 +0000)]
requestPermission callback not invoked if the WebProcess doesn't have to ask the UI Process
about the permission level.
https://bugs.webkit.org/show_bug.cgi?id=79494

Reviewed by Jon Honeycutt.

Invoke the callback in the case where the permission level is known and no message is sent
to the UI Process.

* WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
(WebKit::NotificationPermissionRequestManager::startRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Have WebFrameImpl::selectionAsMarkup create interchange markup.
commit-queue@webkit.org [Fri, 24 Feb 2012 18:51:11 +0000 (18:51 +0000)]
[chromium] Have WebFrameImpl::selectionAsMarkup create interchange markup.
https://bugs.webkit.org/show_bug.cgi?id=77307

Patch by Peter Collingbourne <peter@pcc.me.uk> on 2012-02-24
Reviewed by Tony Chang.

This function is currently used to build markup in order to
print the selection, and will also be used to build markup for
the clipboard.  Without this change, the markup will refer to
(for example) nonexistent CSS classes and invalid relative
paths and therefore will not be interpreted correctly.

Chromium bug: http://crbug.com/23329

* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::selectionAsMarkup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix change log entry for changeset r108819; add bug URL
dbates@webkit.org [Fri, 24 Feb 2012 18:41:13 +0000 (18:41 +0000)]
Fix change log entry for changeset r108819; add bug URL
https://bugs.webkit.org/show_bug.cgi?id=79504

Changeset r108819 is associated with bug #79504.

* ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSubstitute ENABLE(CLASSIC_INTERPRETER) for ENABLE(INTERPRETER) in Interpreter.cpp
dbates@webkit.org [Fri, 24 Feb 2012 18:37:18 +0000 (18:37 +0000)]
Substitute ENABLE(CLASSIC_INTERPRETER) for ENABLE(INTERPRETER) in Interpreter.cpp

Reviewed by Oliver Hunt.

There are a few places in Interpreter.cpp that need to be updated to use
ENABLE(CLASSIC_INTERPRETER) following the renaming of ENABLE_INTERPRETER to
ENABLE_CLASSIC_INTERPRETER in changeset <http://trac.webkit.org/changeset/108020>
(https://bugs.webkit.org/show_bug.cgi?id=78791).

* interpreter/Interpreter.cpp:
(JSC::getLineNumberForCallFrame):
(JSC::getCallerInfo):
(JSC::getSourceURLFromCallFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't notify the inspector of Node insertions initiated by the parser
adamk@chromium.org [Fri, 24 Feb 2012 18:04:35 +0000 (18:04 +0000)]
Don't notify the inspector of Node insertions initiated by the parser
https://bugs.webkit.org/show_bug.cgi?id=79388

Reviewed by Adam Barth.

This is part of a series of changes to make ContainerNode's
implementation simpler and more internally consistent.

I don't know of a way to break on parser-initiated insertions,
and the code already doesn't notify on parser-initiated removes
(in ContainerNode::parserRemoveChild).

No new tests, should already be covered by
inspector/debugger/dom-breakpoints.html.

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::parserAddChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Signal and property cleanup in QQuickWebView
jocelyn.turcotte@nokia.com [Fri, 24 Feb 2012 17:56:34 +0000 (17:56 +0000)]
[Qt] Signal and property cleanup in QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=78820

Reviewed by Simon Hausmann.

- Remove parameters from property change notify signals:
  titleChanged, urlChanged, iconChanged, loadProgressChanged
- Rename the parameters of linkHovered to prevent shadoing properties of WebView
- Rename navigationStateChanged to navigationHistoryChanged

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::_q_onUrlChanged):
(QQuickWebViewPrivate::setIcon):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::loadProgress):
* UIProcess/qt/QtWebPageLoadClient.cpp:
(QtWebPageLoadClient::didCommitLoadForFrame):
(QtWebPageLoadClient::didSameDocumentNavigationForFrame):
(QtWebPageLoadClient::didReceiveTitleForFrame):
(QtWebPageLoadClient::setLoadProgress):
* UIProcess/qt/QtWebPageLoadClient.h:
(QtWebPageLoadClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] API: Unify the loading properties and signals.
jocelyn.turcotte@nokia.com [Fri, 24 Feb 2012 17:50:43 +0000 (17:50 +0000)]
[Qt] API: Unify the loading properties and signals.
https://bugs.webkit.org/show_bug.cgi?id=79486

Reviewed by Simon Hausmann.

Source/WebKit/qt:

* declarative/plugin.cpp:
(WebKitQmlPlugin::registerTypes):

Source/WebKit2:

- Remove the canReload signal, instead assume that calling reload in those cases
  won't have any effect.
- Replace loadStarted, loadSucceeded and loadFailed by a single signal: loadingChanged.
  The signal carries an argument with a status and error codes giving the intended context.
- Use loadingChanged as the notification signal for the property "loading" instead of
  navigationStateChanged.

Also update all API tests to use the new loading signals and add some utility functions
to track the loading since the new API aims to be more adapted to declarative logic
and the auto tests are using an imperative logic.

* Target.pri:
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::loadDidSucceed):
(QQuickWebViewPrivate::didChangeLoadingState):
(QQuickWebViewPrivate::processDidCrash):
(QQuickWebViewPrivate::didRelaunchProcess):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/API/qt/qwebloadrequest.cpp: Added.
(QWebLoadRequestPrivate):
(QWebLoadRequestPrivate::QWebLoadRequestPrivate):
(QWebLoadRequest::QWebLoadRequest):
(QWebLoadRequest::~QWebLoadRequest):
(QWebLoadRequest::url):
(QWebLoadRequest::status):
(QWebLoadRequest::errorString):
(QWebLoadRequest::errorDomain):
(QWebLoadRequest::errorCode):
* UIProcess/API/qt/qwebloadrequest_p.h: Added.
* UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_itemSelector.qml:
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml:
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml:
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_loadFail.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_loadHtml.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgress.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgressSignal.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_loadUrl.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_navigationHistory.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_properties.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_titleChanged.qml:
* UIProcess/API/qt/tests/qmltests/common/TestWebView.qml: Added.
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::navigationStatusAtStartup):
(LoadStartedCatcher::LoadStartedCatcher):
(LoadStartedCatcher::onLoadingChanged):
(tst_QQuickWebView::stopEnabledAfterLoadStarted):
(tst_QQuickWebView::loadEmptyPageViewHidden):
(tst_QQuickWebView::loadNonexistentFileUrl):
(tst_QQuickWebView::backAndForward):
(tst_QQuickWebView::reload):
(tst_QQuickWebView::stop):
(tst_QQuickWebView::loadProgress):
(tst_QQuickWebView::showWebView):
(tst_QQuickWebView::multipleWebViewWindows):
(tst_QQuickWebView::multipleWebViews):
(tst_QQuickWebView::scrollRequest):
* UIProcess/API/qt/tests/util.cpp:
(LoadSpy):
(LoadSpy::LoadSpy):
(LoadSpy::onLoadingChanged):
(waitForLoadSucceeded):
(waitForLoadFailed):
* UIProcess/API/qt/tests/util.h:
* UIProcess/qt/QtWebError.h:
* UIProcess/qt/QtWebPageLoadClient.cpp:
(QtWebPageLoadClient::didStartProvisionalLoadForFrame):
(QtWebPageLoadClient::dispatchLoadFailed):
* UIProcess/qt/QtWebPageLoadClient.h:
(QtWebPageLoadClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAttempt to fix the Windows and WinCE build after changeset r108809
dbates@webkit.org [Fri, 24 Feb 2012 17:26:10 +0000 (17:26 +0000)]
Attempt to fix the Windows and WinCE build after changeset r108809
<http://trac.webkit.org/changeset/108809> (https://bugs.webkit.org/show_bug.cgi?id=38995)

Substitute styleLoadEventSender() for loadEventSender() in HTMLStyleElement.cpp
and substitute linkLoadEventSender() for loadEventSender() in HTMLLinkElement.cpp.

* html/HTMLLinkElement.cpp:
(WebCore::linkLoadEventSender):
(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::dispatchPendingLoadEvents):
(WebCore::HTMLLinkElement::dispatchPendingEvent):
(WebCore::HTMLLinkElement::notifyLoadedSheetAndAllCriticalSubresources):
* html/HTMLStyleElement.cpp:
(WebCore::styleLoadEventSender):
(WebCore::HTMLStyleElement::~HTMLStyleElement):
(WebCore::HTMLStyleElement::dispatchPendingLoadEvents):
(WebCore::HTMLStyleElement::dispatchPendingEvent):
(WebCore::HTMLStyleElement::notifyLoadedSheetAndAllCriticalSubresources):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUndo the BUILDING_WTF part of r108808
aroben@apple.com [Fri, 24 Feb 2012 17:25:44 +0000 (17:25 +0000)]
Undo the BUILDING_WTF part of r108808

This broke the build, which is obviously worse than the linker warning it was trying to
solve.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Fix Chromium Android build by building HarfBuzzShaperBase.cpp
peter@chromium.org [Fri, 24 Feb 2012 17:21:52 +0000 (17:21 +0000)]
[Chromium] Fix Chromium Android build by building HarfBuzzShaperBase.cpp
https://bugs.webkit.org/show_bug.cgi?id=79497

Reviewed by Tony Gentilcore.

The Chromium Android build was broken by revision r108733, as the
HarfBuzzShaperBase.cpp file also should have been included for Android.
Fix the build by including it.

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK SVG rebaseline (from 64-bit Release bot) and
philn@webkit.org [Fri, 24 Feb 2012 17:02:55 +0000 (17:02 +0000)]
Unreviewed, GTK SVG rebaseline (from 64-bit Release bot) and
skipping one more fast/dom/shadow test.

* platform/gtk/Skipped:
* platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
* platform/gtk/svg/carto.net/scrollbar-expected.txt:
* platform/gtk/svg/carto.net/window-expected.txt:
* platform/gtk/svg/custom/circle-move-invalidation-expected.txt:
* platform/gtk/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
* platform/gtk/svg/custom/js-late-gradient-and-object-creation-expected.txt:
* platform/gtk/svg/custom/js-late-pattern-and-object-creation-expected.txt:
* platform/gtk/svg/custom/use-detach-expected.txt:
* platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Texmap] Consolidate the common parts of TextureMapperGL::drawTexture
yael.aharon@nokia.com [Fri, 24 Feb 2012 17:02:46 +0000 (17:02 +0000)]
[Texmap] Consolidate the common parts of TextureMapperGL::drawTexture
https://bugs.webkit.org/show_bug.cgi?id=79143

Reviewed by Noam Rosenthal.

Combine the two drawTexture methods into one, and extract the part that
could not be combined into its own method.
No new tests. Refactoring only.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore):
(WebCore::TextureMapperGL::drawTexture):
* platform/graphics/texmap/TextureMapperGL.h:
(WebCore):
(BitmapTextureGL):
(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::BitmapTextureGL::id):
(WebCore::BitmapTextureGL::relativeSize):
(WebCore::BitmapTextureGL::setTextureMapper):
(WebCore::BitmapTextureGL::BitmapTextureGL):
* platform/graphics/texmap/TextureMapperShaderManager.cpp:
(WebCore::TextureMapperShaderProgramOpacityAndMask::fragmentShaderSource):
(WebCore):
(WebCore::TextureMapperShaderProgramOpacityAndMask::prepare):
* platform/graphics/texmap/TextureMapperShaderManager.h:
(WebCore):
(WebCore::TextureMapperShaderProgram::prepare):
(WebCore::TextureMapperShaderProgram::matrixVariable):
(WebCore::TextureMapperShaderProgram::sourceMatrixVariable):
(WebCore::TextureMapperShaderProgram::sourceTextureVariable):
(WebCore::TextureMapperShaderProgram::opacityVariable):
(TextureMapperShaderProgram):
(TextureMapperShaderProgramSimple):
(TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskMatrixVariable):
(WebCore::TextureMapperShaderProgramOpacityAndMask::maskTextureVariable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agostyle element and link element for CSS stylesheet should emit load/error event when...
dbates@webkit.org [Fri, 24 Feb 2012 16:50:55 +0000 (16:50 +0000)]
style element and link element for CSS stylesheet should emit load/error event when sheet loads/fails to load
https://bugs.webkit.org/show_bug.cgi?id=38995

Reviewed by Adam Barth and Nate Chapin.

Source/WebCore:

Tests: fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import.html
       fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-non-existent-import.html
       fast/dom/HTMLLinkElement/link-onerror.html
       fast/dom/HTMLLinkElement/link-onload-before-page-load.html
       fast/dom/HTMLLinkElement/link-onload-stylesheet-with-import.html
       fast/dom/HTMLLinkElement/link-onload.html
       fast/dom/HTMLLinkElement/link-onload2.html
       fast/dom/HTMLLinkElement/programmatically-add-link-with-onerror-handler.html
       fast/dom/HTMLLinkElement/programmatically-add-link-with-onload-handler.html
       fast/dom/HTMLStyleElement/programmatically-add-style-with-onerror-handler.html
       fast/dom/HTMLStyleElement/programmatically-add-style-with-onload-handler.html
       fast/dom/HTMLStyleElement/style-onerror-with-existent-and-non-existent-import.html
       fast/dom/HTMLStyleElement/style-onerror.html
       fast/dom/HTMLStyleElement/style-onload-before-page-load.html
       fast/dom/HTMLStyleElement/style-onload.html
       fast/dom/HTMLStyleElement/style-onload2.html

Implements support for firing Load and Error events at HTML Link and HTML Style elements as per
the HTML5 spec. (draft 05/25/2011) section "The link element" <http://www.w3.org/TR/html5/semantics.html#the-link-element>
and "The style element" <http://www.w3.org/TR/html5/semantics.html#the-style-element>, respectively.

* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::setCSSStyleSheet): Modified to call CSSStyleSheet::notifyLoadedSheet()
after the style sheet associated with the @import rule loaded.
* css/CSSStyleSheet.cpp: Added instance variable m_didLoadErrorOccur to track whether a network error
occurred while loading any @import style sheets.
(WebCore::CSSStyleSheet::CSSStyleSheet):
(WebCore::CSSStyleSheet::checkLoaded):
(WebCore):
(WebCore::CSSStyleSheet::notifyLoadedSheet): Added; update m_didLoadErrorOccur to reflect if a network
error occurred while loading a style sheet associated with an @import rule.
* css/CSSStyleSheet.h:
(WebCore):
(CSSStyleSheet):
* dom/Document.cpp:
(WebCore::Document::implicitClose): Call HTML{LinkElement, StyleElement}::dispatchPendingLoadEvents() to
ensure that all pending Load events for link and style elements are dispatched before we fire the Load
event for the window.
* dom/Node.h:
(WebCore::Node::notifyLoadedSheetAndAllCriticalSubresources): Added; as stated in its name, this method is
called once a style sheet and all its critical subresources (@imports) have loaded.
* html/HTMLLinkElement.cpp:
(WebCore::loadEventSender):
(WebCore):
(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::~HTMLLinkElement): Modified to cancel all pending Load events on destruction.
(WebCore::HTMLLinkElement::parseAttribute): Register event listeners for Load and Error events regardless of whether we
built with link prefetch support.
(WebCore::HTMLLinkElement::setCSSStyleSheet):
(WebCore::HTMLLinkElement::dispatchPendingLoadEvents): Added; called from Document::implicitClose() to
ensure that all pending Load events for link elements have been dispatched before we fire the Load event
for the window.
(WebCore::HTMLLinkElement::dispatchPendingEvent): Added; called by EventSender.
(WebCore::HTMLLinkElement::notifyLoadedSheetAndAllCriticalSubresources): Added.
* html/HTMLLinkElement.h:
(WebCore):
(HTMLLinkElement):
* html/HTMLStyleElement.cpp:
(WebCore::loadEventSender):
(WebCore):
(WebCore::HTMLStyleElement::HTMLStyleElement):
(WebCore::HTMLStyleElement::~HTMLStyleElement): Modified to cancel all pending Load events on destruction.
(WebCore::HTMLStyleElement::parseAttribute): Register event listeners for Load and Error events.
(WebCore::HTMLStyleElement::dispatchPendingLoadEvents): Added; called from Document::implicitClose() to
ensure that all pending Load events for link elements have been dispatched before we fire the Load event
for the window.
(WebCore::HTMLStyleElement::dispatchPendingEvent): Added; called by EventSender.
(WebCore::HTMLStyleElement::notifyLoadedSheetAndAllCriticalSubresources): Added.
* html/HTMLStyleElement.h:
(WebCore):
(HTMLStyleElement):

LayoutTests:

Add test cases to ensure we dispatch Load/Error events to HTML Link and HTML Style elements.

* fast/dom/HTMLLinkElement/link-onerror-expected.txt: Added.
* fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import-expected.txt: Added.
* fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import.html: Added.
* fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-non-existent-import-expected.txt: Added.
* fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-non-existent-import.html: Added.
* fast/dom/HTMLLinkElement/link-onerror.html: Added.
* fast/dom/HTMLLinkElement/link-onload-before-page-load-expected.txt: Added.
* fast/dom/HTMLLinkElement/link-onload-before-page-load.html: Added.
* fast/dom/HTMLLinkElement/link-onload-expected.txt: Added.
* fast/dom/HTMLLinkElement/link-onload-stylesheet-with-import-expected.txt: Added.
* fast/dom/HTMLLinkElement/link-onload-stylesheet-with-import.html: Added.
* fast/dom/HTMLLinkElement/link-onload.html: Added.
* fast/dom/HTMLLinkElement/link-onload2-expected.txt: Added.
* fast/dom/HTMLLinkElement/link-onload2.html: Added.
* fast/dom/HTMLLinkElement/programmatically-add-link-with-onerror-handler-expected.txt: Added.
* fast/dom/HTMLLinkElement/programmatically-add-link-with-onerror-handler.html: Added.
* fast/dom/HTMLLinkElement/programmatically-add-link-with-onload-handler-expected.txt: Added.
* fast/dom/HTMLLinkElement/programmatically-add-link-with-onload-handler.html: Added.
* fast/dom/HTMLLinkElement/resources/link-load-utilities.js: Added.
(shouldComputedColorOfElementBeEqualToRGBString):
(createLinkElementWithStylesheet):
(createStyleElementWithString):
(log):
(testPassed):
(testFailed):
(testPassedAndNotifyDone):
(testFailedAndNotifyDone):
(testFinished):
* fast/dom/HTMLLinkElement/resources/stylesheet-with-existent-and-non-existent-import.css: Added.
(#test):
* fast/dom/HTMLLinkElement/resources/stylesheet-with-import.css: Added.
(#test):
* fast/dom/HTMLLinkElement/resources/stylesheet-with-non-existent-import.css: Added.
(#test):
* fast/dom/HTMLLinkElement/resources/stylesheet.css: Added.
(#test):
* fast/dom/HTMLStyleElement/programmatically-add-style-with-onerror-handler-expected.txt: Added.
* fast/dom/HTMLStyleElement/programmatically-add-style-with-onerror-handler.html: Added.
* fast/dom/HTMLStyleElement/programmatically-add-style-with-onload-handler-expected.txt: Added.
* fast/dom/HTMLStyleElement/programmatically-add-style-with-onload-handler.html: Added.
* fast/dom/HTMLStyleElement/style-onerror-expected.txt: Added.
* fast/dom/HTMLStyleElement/style-onerror-with-existent-and-non-existent-import-expected.txt: Added.
* fast/dom/HTMLStyleElement/style-onerror-with-existent-and-non-existent-import.html: Added.
* fast/dom/HTMLStyleElement/style-onerror.html: Added.
* fast/dom/HTMLStyleElement/style-onload-before-page-load-expected.txt: Added.
* fast/dom/HTMLStyleElement/style-onload-before-page-load.html: Added.
* fast/dom/HTMLStyleElement/style-onload-expected.txt: Added.
* fast/dom/HTMLStyleElement/style-onload.html: Added.
* fast/dom/HTMLStyleElement/style-onload2-expected.txt: Added.
* fast/dom/HTMLStyleElement/style-onload2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix linker warnings on Windows
aroben@apple.com [Fri, 24 Feb 2012 16:49:04 +0000 (16:49 +0000)]
Fix linker warnings on Windows

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed symbols that are already
exported via JS_EXPORTDATA.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Define BUILDING_WTF. We
aren't actually building WTF, but we are statically linking it, so we need to define this
symbol so that we export WTF's exports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMac build fix after r108698
aroben@apple.com [Fri, 24 Feb 2012 16:48:53 +0000 (16:48 +0000)]
Mac build fix after r108698

* page/scrolling/mac/ScrollingCoordinatorMac.mm: Added missing #import.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][DRT] Implement setValueForUser and setAutofilled.
commit-queue@webkit.org [Fri, 24 Feb 2012 16:33:51 +0000 (16:33 +0000)]
[EFL][DRT] Implement setValueForUser and setAutofilled.
https://bugs.webkit.org/show_bug.cgi?id=79237

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-02-24
Reviewed by Andreas Kling.

Source/WebKit:

Adds the main directory of WebKit's source to find headers of JavaScriptCore.

* PlatformEfl.cmake:

Source/WebKit/efl:

Adds missing implementation setValueForUser and setAutofilled to EFL's DumpRenderTreeSupport.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setValueForUser):
(DumpRenderTreeSupportEfl::setAutofilled):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
Those implementations are related with input fields and allow to pass following tests:
fast/forms/onchange-setvalueforuser.html
fast/forms/input-autofilled.html
fast/forms/reset-autofilled.html

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setValueForUser):
(LayoutTestController::setAutofilled):

LayoutTests:

Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
Those implementations are related with input fields and allow to pass following tests:
fast/forms/onchange-setvalueforuser.html
fast/forms/input-autofilled.html
fast/forms/reset-autofilled.html

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r108798.
hausmann@webkit.org [Fri, 24 Feb 2012 16:33:19 +0000 (16:33 +0000)]
Unreviewed, rolling out r108798.
http://trac.webkit.org/changeset/108798
https://bugs.webkit.org/show_bug.cgi?id=78047

Broke too many Qt WK2 tests.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::keyPressEvent):
(QQuickWebView::keyReleaseEvent):
(QQuickWebView::inputMethodEvent):
(QQuickWebView::focusInEvent):
(QQuickWebView::focusOutEvent):
(QQuickWebView::touchEvent):
(QQuickWebView::mousePressEvent):
(QQuickWebView::mouseMoveEvent):
(QQuickWebView::mouseReleaseEvent):
(QQuickWebView::mouseDoubleClickEvent):
(QQuickWebView::wheelEvent):
(QQuickWebView::hoverEnterEvent):
(QQuickWebView::hoverMoveEvent):
(QQuickWebView::hoverLeaveEvent):
(QQuickWebView::dragMoveEvent):
(QQuickWebView::dragEnterEvent):
(QQuickWebView::dragLeaveEvent):
(QQuickWebView::dropEvent):
(QQuickWebView::event):
* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::handleEvent):
(QtWebPageEventHandler::handleMouseMoveEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::handleMouseReleaseEvent):
(QtWebPageEventHandler::handleWheelEvent):
(QtWebPageEventHandler::handleHoverLeaveEvent):
(QtWebPageEventHandler::handleHoverMoveEvent):
(QtWebPageEventHandler::handleDragEnterEvent):
(QtWebPageEventHandler::handleDragLeaveEvent):
(QtWebPageEventHandler::handleDragMoveEvent):
(QtWebPageEventHandler::handleDropEvent):
(QtWebPageEventHandler::handleKeyPressEvent):
(QtWebPageEventHandler::handleKeyReleaseEvent):
(QtWebPageEventHandler::handleFocusInEvent):
(QtWebPageEventHandler::handleFocusOutEvent):
(QtWebPageEventHandler::inputMethodEvent):
(QtWebPageEventHandler::touchEvent):
* UIProcess/qt/QtWebPageEventHandler.h:
(QtWebPageEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed speculative buildfix after r108785 for ENABLE(SVG) && !ENABLE(XSLT) case.
ossy@webkit.org [Fri, 24 Feb 2012 16:33:06 +0000 (16:33 +0000)]
Unreviewed speculative buildfix after r108785 for ENABLE(SVG) && !ENABLE(XSLT) case.

* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Eliminate excessive BlackBerry::Platform use in InputHandler
commit-queue@webkit.org [Fri, 24 Feb 2012 16:33:05 +0000 (16:33 +0000)]
[BlackBerry] Eliminate excessive BlackBerry::Platform use in InputHandler
https://bugs.webkit.org/show_bug.cgi?id=79393

Patch by Mike Fenton <mifenton@rim.com> on 2012-02-24
Reviewed by Antonio Gomes.

Cleanup usage of BlackBerry::Platform in InputHandler.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::convertStringToWchar):
(BlackBerry::WebKit::convertStringToWcharVector):
(BlackBerry::WebKit::convertSpannableStringToString):
(BlackBerry::WebKit::InputHandler::learnText):
(BlackBerry::WebKit::InputHandler::setElementUnfocused):
(BlackBerry::WebKit::InputHandler::shouldAcceptInputFocus):
(BlackBerry::WebKit::InputHandler::setElementFocused):
(BlackBerry::WebKit::InputHandler::nodeTextChanged):
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
(BlackBerry::WebKit::InputHandler::frameUnloaded):
(BlackBerry::WebKit::InputHandler::selectionChanged):
(BlackBerry::WebKit::InputHandler::setSelection):
(BlackBerry::WebKit::InputHandler::handleKeyboardInput):
(BlackBerry::WebKit::InputHandler::deleteTextRelativeToCursor):
(BlackBerry::WebKit::InputHandler::deleteText):
(BlackBerry::WebKit::InputHandler::spannableTextInRange):
(BlackBerry::WebKit::InputHandler::setComposingRegion):
(BlackBerry::WebKit::InputHandler::finishComposition):
(BlackBerry::WebKit::InputHandler::setText):
(BlackBerry::WebKit::InputHandler::setTextAttributes):
(BlackBerry::WebKit::InputHandler::setRelativeCursorPosition):
(BlackBerry::WebKit::InputHandler::setSpannableTextAndRelativeCursor):
(BlackBerry::WebKit::InputHandler::setComposingText):
(BlackBerry::WebKit::InputHandler::commitText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNot reviewed: chromium image for inspector status bar button updated.
pfeldman@chromium.org [Fri, 24 Feb 2012 16:00:51 +0000 (16:00 +0000)]
Not reviewed: chromium image for inspector status bar button updated.

Patch by Pavel Feldman <pfeldman@chromium.org> on 2012-02-24

* src/js/Images/segmentSelectedEndChromium.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, skip new failing tests.
ossy@webkit.org [Fri, 24 Feb 2012 15:54:15 +0000 (15:54 +0000)]
[Qt] Unreviewed gardening, skip new failing tests.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Do not show scripts panel navigator automatically more than once to...
vsevik@chromium.org [Fri, 24 Feb 2012 15:54:04 +0000 (15:54 +0000)]
Web Inspector: Do not show scripts panel navigator automatically more than once to the same user.
https://bugs.webkit.org/show_bug.cgi?id=79489

Reviewed by Pavel Feldman.

* inspector/front-end/ScriptsPanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK rebaseline and skip a fast/dom/shadow test.
philn@webkit.org [Fri, 24 Feb 2012 15:51:14 +0000 (15:51 +0000)]
Unreviewed, GTK rebaseline and skip a fast/dom/shadow test.

* platform/gtk/Skipped:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] QQuickWebView::event should lookup faster which events QQuickWebPage can...
hausmann@webkit.org [Fri, 24 Feb 2012 15:48:55 +0000 (15:48 +0000)]
[Qt][WK2] QQuickWebView::event should lookup faster which events QQuickWebPage can handle
https://bugs.webkit.org/show_bug.cgi?id=78047

Reviewed by Kenneth Rohde Christiansen.

Replaced double-dispatch of events with direct forwarding of events from QQuickWebView::*Event to
QtWebPageEventHandler::handle*Event.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::keyPressEvent):
(QQuickWebView::keyReleaseEvent):
(QQuickWebView::inputMethodEvent):
(QQuickWebView::focusInEvent):
(QQuickWebView::focusOutEvent):
(QQuickWebView::touchEvent):
(QQuickWebView::mousePressEvent):
(QQuickWebView::mouseMoveEvent):
(QQuickWebView::mouseReleaseEvent):
(QQuickWebView::mouseDoubleClickEvent):
(QQuickWebView::wheelEvent):
(QQuickWebView::hoverEnterEvent):
(QQuickWebView::hoverMoveEvent):
(QQuickWebView::hoverLeaveEvent):
(QQuickWebView::dragMoveEvent):
(QQuickWebView::dragEnterEvent):
(QQuickWebView::dragLeaveEvent):
(QQuickWebView::dropEvent):
(QQuickWebView::event):
* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::handleMouseMoveEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::handleMouseReleaseEvent):
(QtWebPageEventHandler::handleWheelEvent):
(QtWebPageEventHandler::handleHoverLeaveEvent):
(QtWebPageEventHandler::handleHoverMoveEvent):
(QtWebPageEventHandler::handleDragEnterEvent):
(QtWebPageEventHandler::handleDragLeaveEvent):
(QtWebPageEventHandler::handleDragMoveEvent):
(QtWebPageEventHandler::handleDropEvent):
(QtWebPageEventHandler::handleKeyPressEvent):
(QtWebPageEventHandler::handleKeyReleaseEvent):
(QtWebPageEventHandler::handleFocusInEvent):
(QtWebPageEventHandler::handleFocusOutEvent):
(QtWebPageEventHandler::handleInputMethodEvent):
(QtWebPageEventHandler::handleTouchEvent):
* UIProcess/qt/QtWebPageEventHandler.h:
(QtWebPageEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix GTK WebAudio build for WebKitGTK 1.7.90.
philn@webkit.org [Fri, 24 Feb 2012 15:40:29 +0000 (15:40 +0000)]
Fix GTK WebAudio build for WebKitGTK 1.7.90.

Patch by Priit Laes <plaes@plaes.org> on 2012-02-24
Rubber-stamped by Philippe Normand.

Source/JavaScriptCore:

* GNUmakefile.list.am: Add Complex.h to the list of files so it
gets disted in the tarballs.

Source/WebCore:

* GNUmakefile.list.am: Add AudioBufferCallback.h and
DenormalDisabler.h to the list of files so they get disted in the
tarballs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Eliminate excessive BlackBerry::Platform use in SelectionHandler.
commit-queue@webkit.org [Fri, 24 Feb 2012 15:34:48 +0000 (15:34 +0000)]
[BlackBerry] Eliminate excessive BlackBerry::Platform use in SelectionHandler.
https://bugs.webkit.org/show_bug.cgi?id=79391

Patch by Mike Fenton <mifenton@rim.com> on 2012-02-24
Reviewed by Antonio Gomes.

Clean up usage of BlackBerry::Platform in SelectionHandler and
explicitly define what namespace to use for ambiguous objects like
IntRect and IntPoint.

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::cancelSelection):
(BlackBerry::WebKit::SelectionHandler::getConsolidatedRegionOfTextQuadsForSelection):
(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
(BlackBerry::WebKit::directionOfPointRelativeToRect):
(BlackBerry::WebKit::SelectionHandler::shouldUpdateSelectionOrCaretForPoint):
(BlackBerry::WebKit::SelectionHandler::setCaretPosition):
(BlackBerry::WebKit::directionalVisiblePositionAtExtentOfBox):
(BlackBerry::WebKit::pointIsOutsideOfBoundingBoxInDirection):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
(BlackBerry::WebKit::SelectionHandler::clipPointToFocusNode):
(BlackBerry::WebKit::SelectionHandler::setSelection):
(BlackBerry::WebKit::SelectionHandler::selectAtPoint):
(BlackBerry::WebKit::SelectionHandler::selectObject):
(BlackBerry::WebKit::comparePointsToReferencePoint):
(BlackBerry::WebKit::minXMinYCorner):
(BlackBerry::WebKit::maxXMinYCorner):
(BlackBerry::WebKit::minXMaxYCorner):
(BlackBerry::WebKit::maxXMaxYCorner):
(BlackBerry::WebKit::caretLocationForRect):
(BlackBerry::WebKit::caretComparisonPointForRect):
(BlackBerry::WebKit::adjustCaretRects):
(BlackBerry::WebKit::SelectionHandler::clipRegionToVisibleContainer):
(BlackBerry::WebKit::referencePoint):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
(BlackBerry::WebKit::SelectionHandler::selectionContains):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: show all counters on one graph
yurys@chromium.org [Fri, 24 Feb 2012 15:32:45 +0000 (15:32 +0000)]
Web Inspector: show all counters on one graph
https://bugs.webkit.org/show_bug.cgi?id=79484

Now it is possible to hide any counter. All graphs share the same area.
Current values are displayed above that area.

Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.getDocumentCount):
(WebInspector.MemoryStatistics.getNodeCount):
(WebInspector.MemoryStatistics.getListenerCount):
(WebInspector.MemoryStatistics):
(WebInspector.SwatchCheckbox):
(WebInspector.SwatchCheckbox.prototype.get checked):
(WebInspector.SwatchCheckbox.prototype.set checked):
(WebInspector.SwatchCheckbox.prototype._toggleCheckbox):
(WebInspector.CounterUI):
(WebInspector.CounterUI.prototype._toggleCounterGraph):
(WebInspector.CounterUI.prototype.setRange):
(WebInspector.CounterUI.prototype.updateCurrentValue):
(WebInspector.CounterUI.prototype.clearCurrentValueAndMarker):
(WebInspector.CounterUI.prototype.get visible):
(WebInspector.CounterUI.prototype.saveImageUnderMarker):
(WebInspector.CounterUI.prototype.restoreImageUnderMarker):
(WebInspector.CounterUI.prototype.discardImageUnderMarker):
(WebInspector.MemoryStatistics.prototype._updateSize):
(WebInspector.MemoryStatistics.prototype._draw):
(WebInspector.MemoryStatistics.prototype._onMouseOut):
(WebInspector.MemoryStatistics.prototype._refreshCurrentValues):
(WebInspector.MemoryStatistics.prototype._highlightCurrentPositionOnGraphs):
(WebInspector.MemoryStatistics.prototype._drawGraph):
(WebInspector.MemoryStatistics.prototype._clear):
* inspector/front-end/timelinePanel.css:
(.memory-counter-sidebar-info):
(.memory-counter-sidebar-info .swatch):
(.memory-counter-sidebar-info .title):
(.memory-counter-value):
(#counter-values-bar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: map Ctrl/Cmd +/- to zoom in hosted mode.
pfeldman@chromium.org [Fri, 24 Feb 2012 15:28:51 +0000 (15:28 +0000)]
Web Inspector: map Ctrl/Cmd +/- to zoom in hosted mode.
https://bugs.webkit.org/show_bug.cgi?id=79475

(In remote front-end mode, default zoom actions are working.)

Reviewed by Yury Semikhatsky.

* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::setZoomFactor):
(WebCore):
* inspector/InspectorFrontendHost.h:
(InspectorFrontendHost):
* inspector/InspectorFrontendHost.idl:
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub):
(.WebInspector.InspectorFrontendHostStub.prototype.loadResourceSynchronously):
(.WebInspector.InspectorFrontendHostStub.prototype.setZoomFactor):
* inspector/front-end/Settings.js:
(WebInspector.Settings):
* inspector/front-end/inspector.js:
(WebInspector._initializeCapability):
(WebInspector._zoomIn):
(WebInspector._zoomOut):
(WebInspector._resetZoom):
(WebInspector._requestZoom.set InspectorFrontendHost):
(WebInspector._requestZoom):
(WebInspector._doLoadedDoneWithCapabilities.get if):
(WebInspector.documentKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactor EventHandler::handleGestureEvent.
commit-queue@webkit.org [Fri, 24 Feb 2012 15:03:23 +0000 (15:03 +0000)]
Refactor EventHandler::handleGestureEvent.
https://bugs.webkit.org/show_bug.cgi?id=79476

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-24
Reviewed by Kenneth Rohde Christiansen.

No new tests. No behavior change.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureTap):
(WebCore::EventHandler::handleGestureScrollUpdate):
* page/EventHandler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Allow to use WebCore imagedecoders
zoltan@webkit.org [Fri, 24 Feb 2012 14:48:55 +0000 (14:48 +0000)]
[Qt] Allow to use WebCore imagedecoders
https://bugs.webkit.org/show_bug.cgi?id=32410

Source/WebCore:

Add ENABLE(QT_IMAGE_DECODER) guards around Qt imagedecoders and set it to default.
By passing ENABLE_QT_IMAGE_DECODER=0 define to the build system, WebKit will build
with WebCore's imagedecoders.

I added NO_RETURN attribute and PLATFORM(QT) conditionals to 2 functions of PNG and
JPEG decoders to avoid compiler warnings because in Qt-port we treat warning as errors (-Werror).

I'm continuing the refactoring of this area and try to use Qt imagedecoders only in
cases when WebCore doesn't support the image format.

Reviewed by Simon Hausmann.

No behavior change, no need new tests.

* Target.pri:
* WebCore.pri:
* platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedImageMIMETypesForEncoding):
* platform/image-decoders/ImageDecoder.h:
(WebCore::ImageFrame::getAddr):
(ImageFrame):
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
NO_RETURN has been added to a function to avoid warning message.
* platform/image-decoders/png/PNGImageDecoder.cpp:
NO_RETURN has been added to a function to avoid warning message.
(WebCore):
* platform/image-decoders/qt/ImageFrameQt.cpp:
(WebCore):
(WebCore::ImageFrame::asNewNativeImage):

Tools:

Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.

Reviewed by Simon Hausmann.

* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Windows, WinCairo] Handle indeterminate checkbox state
commit-queue@webkit.org [Fri, 24 Feb 2012 14:46:23 +0000 (14:46 +0000)]
[Windows, WinCairo] Handle indeterminate checkbox state
https://bugs.webkit.org/show_bug.cgi?id=79288

Patch by Lynn Neir <lynn.neir@skype.net> on 2012-02-24
Reviewed by Adam Roben.

Tested by fast/forms/indeterminate.html

* rendering/RenderThemeWin.cpp: Add code to check for indeterminate
  state in CheckBox.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108791 268f45cc-cd09-0410-ab3c-d52691b4dbfc