WebKit-https.git
10 years agoRevert unplanned project file change.
antti.j.koivisto@nokia.com [Mon, 5 Jul 2010 12:31:33 +0000 (12:31 +0000)]
Revert unplanned project file change.

.:

* WebKit.pro:

WebCore:

* WebCore.pri:
* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 5 Jul 2010 12:27:35 +0000 (12:27 +0000)]
2010-07-05  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Darin Adler.

        Memory corruption with SVG <use> element
        https://bugs.webkit.org/show_bug.cgi?id=40994

        Fix race condition in svgAttributeChanged. Never call svgAttributeChanged() from attributeChanged()
        when we're synchronizing SVG attributes. It leads to either unnecessary extra work being done or
        crashes. Especially together with <polyline>/<polygon> which always synchronize the SVGAnimatedPoints
        datastructure with the points attribute, no matter if there are changes are not. This should be
        furhter optimized, but this fix is sane and fixes the root of the evil races.

        Test: svg/custom/use-property-synchronization-crash.svg

        * svg/SVGElement.cpp:
        (WebCore::SVGElement::attributeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Initial WebKit2 implementation
antti.j.koivisto@nokia.com [Mon, 5 Jul 2010 12:26:10 +0000 (12:26 +0000)]
[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Implement ChunkedUpdateDrawingArea + Proxy for Qt. Not built yet.

* UIProcess/ChunkedUpdateDrawingAreaProxy.h:
* UIProcess/qt: Added.
* UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp: Added.
(WebKit::ChunkedUpdateDrawingAreaProxy::page):
(WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore):
(WebKit::ChunkedUpdateDrawingAreaProxy::invalidateBackingStore):
(WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint):
(WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):
* WebProcess/WebPage/qt: Added.
* WebProcess/WebPage/qt/ChunkedUpdateDrawingAreaQt.cpp: Added.
(WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-04 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 5 Jul 2010 10:50:58 +0000 (10:50 +0000)]
2010-07-04  MORITA Hajime  <morrita@google.com>

        rebaseline-chromium-webkit-tests: UnicodeDecodeError
        https://bugs.webkit.org/show_bug.cgi?id=41589

        * run() method can result non-utf-8 bytes, that causes utf-8
          decoding fail.  Fixed to disable decoding.
        * Fixed Git.find_checkout_root() to make a test pass.

        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/common/checkout/scm_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 5 Jul 2010 10:05:44 +0000 (10:05 +0000)]
2010-07-05  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        [v8] Web Inspector: remove v8-specific code dealing with getOwnPropertyNames from InjectedScript.js
        https://bugs.webkit.org/show_bug.cgi?id=41595

        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):
2010-07-05  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        [v8] Web Inspector: remove v8-specific code dealing with getOwnPropertyNames from InjectedScript.js
        https://bugs.webkit.org/show_bug.cgi?id=41595

        * src/js/DebuggerScript.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-04 Rob Buis <rwlbuis@gmail.com>
rwlbuis@webkit.org [Mon, 5 Jul 2010 10:03:35 +0000 (10:03 +0000)]
2010-07-04  Rob Buis  <rwlbuis@gmail.com>

        Reviewed by Dirk Schulze.

        SVG polygons should draw polygons up to the first parsing error
        https://bugs.webkit.org/show_bug.cgi?id=41140

        Render polygons up until the first parsing error.

        Test: svg/custom/poly-parsing-error.html

        * svg/SVGPolyElement.cpp:
        (WebCore::SVGPolyElement::parseMappedAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash reading past end of block in UniscribeController::shapeAndPlaceItem
alice.liu@apple.com [Mon, 5 Jul 2010 07:32:54 +0000 (07:32 +0000)]
Crash reading past end of block in UniscribeController::shapeAndPlaceItem
https://bugs.webkit.org/show_bug.cgi?id=41554

Reviewed by Dan Bernstein.

Test: platform/win/fast/text/uniscribe-item-boundary-crash.html

* platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::shapeAndPlaceItem):
Don't look one past the end of str. Instead look to the next item, if applicable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-23 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 5 Jul 2010 07:18:20 +0000 (07:18 +0000)]
2010-06-23  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Carlson.

        [GStreamer] on Mac OS use a runloop observer to process the glib context iterations
        https://bugs.webkit.org/show_bug.cgi?id=35747

        If VIDEO and GSTREAMER are enabled, make the WebView start a
        runloop observer that will trigger the glib main context
        iterations. Those are needed by the GStreamer player only at the
        moment but could later be used for other GLib-dependant components
        if required.

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
        (-[WebView _close]):
        (-[WebView _clearGlibLoopObserver]):
        (glibContextIterationCallback):
        (-[WebView _scheduleGlibContextIterations]):
        * WebView/WebViewData.h:
        * WebView/WebViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-04 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 5 Jul 2010 06:56:27 +0000 (06:56 +0000)]
2010-07-04  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Mark fast/js/function-apply-many-args.html as
        having wrong output in debug mode.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 5 Jul 2010 04:45:30 +0000 (04:45 +0000)]
2010-07-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add basic "in table body" mode to support <tr> insertion
        https://bugs.webkit.org/show_bug.cgi?id=41587

        * html5lib/runner-expected-html5.txt:
         - <tr> tags now show up, imagine that.
2010-07-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add basic "in table body" mode to support <tr> insertion
        https://bugs.webkit.org/show_bug.cgi?id=41587

        This also adds a (currently untestable?)
        popUntilTableBodyScopeMarker code path.
        Any tags which would be between a tbody a <tr> would end up
        foster parented outside the <table>.  I think the spec was
        just being over-cautious with popUntilTableBodyScopeMarker.

        * html/HTMLElementStack.cpp:
        (WebCore::HTMLNames::isTableScopeMarker):
        (WebCore::HTMLNames::isTableBodyScopeMarker):
        (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
        * html/HTMLElementStack.h:
        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag):
        (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Update Chromium test expectations.
pkasting@chromium.org [Mon, 5 Jul 2010 02:37:57 +0000 (02:37 +0000)]
Unreviewed.  Update Chromium test expectations.

* platform/chromium-mac/html5lib/runner-expected.txt:
* platform/chromium-win/html5lib/runner-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Windows build.
andersca@apple.com [Sun, 4 Jul 2010 23:27:19 +0000 (23:27 +0000)]
Fix Windows build.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd simple command line parser and pass mode argument to the web process
andersca@apple.com [Sun, 4 Jul 2010 23:15:51 +0000 (23:15 +0000)]
Add simple command line parser and pass mode argument to the web process
https://bugs.webkit.org/show_bug.cgi?id=41586

Reviewed by Dan Bernstein.

* Shared/CommandLine.h:
(WebKit::CommandLine::operator[]):
Add CommandLine class.

* Shared/mac/CommandLineMac.cpp:
(WebKit::CommandLine::parse):
Implement Mac version of CommandLine::parse.

* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
Add "legacywebprocess" mode to the posix_spawn call.

* WebKit2.xcodeproj/project.pbxproj:
Add CommandLine to the xcode project.

* WebProcess/Launching/mac/WebProcessMain.mm:
(webProcessMain):
(main):
Parse the command line and check the mode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sun, 4 Jul 2010 22:06:18 +0000 (22:06 +0000)]
2010-07-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        HTMLTreeBuilder needs an adoption agency
        https://bugs.webkit.org/show_bug.cgi?id=41453

        Fix Qt Minimal build.  SVGNames.h should always
        be generated, even when SVG is off, however that's
        not how things currently work.

        * html/HTMLTreeBuilder.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sun, 4 Jul 2010 21:54:59 +0000 (21:54 +0000)]
2010-07-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add a very basic InTable insertion mode
        https://bugs.webkit.org/show_bug.cgi?id=41581

        * html5lib/runner-expected-html5.txt:
         - Update expectations now that we pass 6 more tests.
2010-07-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add a very basic InTable insertion mode
        https://bugs.webkit.org/show_bug.cgi?id=41581

        There is still a bunch of low-hanging fruit left for this
        mode, but even this most-basic support lets us pass 6 more tests. :)

        It's a progression, ship it! :)

        * html/HTMLElementStack.cpp:
        (WebCore::HTMLNames::isScopeMarker):
        (WebCore::HTMLNames::isListItemScopeMarker):
        (WebCore::HTMLNames::isTableScopeMarker):
        (WebCore::HTMLElementStack::popUntilTableScopeMarker):
        * html/HTMLElementStack.h:
        * html/HTMLFormattingElementList.cpp:
        (WebCore::HTMLFormattingElementList::appendMarker):
        * html/HTMLFormattingElementList.h:
        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag):
        * html/HTMLTreeBuilder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sun, 4 Jul 2010 21:15:44 +0000 (21:15 +0000)]
2010-07-02  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        HTMLTreeBuilder needs an adoption agency
        https://bugs.webkit.org/show_bug.cgi?id=41453

        Added new adoption01 suite for testing adoption agency
        bugs.  Right now only the simplest adoption test passes.
        I'll be adding more in future commits.

        * html5lib/resources/adoption01.dat: Added.
        * html5lib/runner-expected-html5.txt:
        * html5lib/runner-expected.txt:
        * html5lib/runner.html:
2010-07-01  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        HTMLTreeBuilder needs an adoption agency
        https://bugs.webkit.org/show_bug.cgi?id=41453

        This changes some test results, but only makes the simplest
        adoption agency cases pass.  I think the code is likely
        very close, but further iteration to make this change larger
        seems counter-productive.  I recommend we check in this
        progression and work from here.

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::addChildCommon):
         - Make sure callers don't assume this will reparent.
        (WebCore::ContainerNode::parserAddChild):
         - Update comment to document lack of reparenting behavior.
        * html/HTMLElementStack.cpp:
        (WebCore::HTMLElementStack::ElementRecord::ElementRecord):
        (WebCore::HTMLElementStack::ElementRecord::~ElementRecord):
        (WebCore::HTMLElementStack::ElementRecord::replaceElement):
        (WebCore::HTMLElementStack::ElementRecord::isAbove):
         - Added for debugging.
        (WebCore::HTMLElementStack::pushHTMLHtmlElement):
        (WebCore::HTMLElementStack::insertAbove):
         - Needed for the adoption agency.
        (WebCore::HTMLElementStack::topRecord):
        (WebCore::HTMLElementStack::bottom):
        (WebCore::HTMLElementStack::removeHTMLHeadElement):
        (WebCore::HTMLElementStack::remove):
        (WebCore::HTMLElementStack::find):
        (WebCore::HTMLElementStack::topmost):
        (WebCore::HTMLElementStack::contains):
        (WebCore::HTMLElementStack::htmlElement):
        (WebCore::HTMLElementStack::headElement):
        (WebCore::HTMLElementStack::bodyElement):
        (WebCore::HTMLElementStack::pushCommon):
        (WebCore::HTMLElementStack::removeNonTopCommon):
         - Fix the name to match top/bottom.
        * html/HTMLElementStack.h:
        (WebCore::HTMLElementStack::ElementRecord::element):
        (WebCore::HTMLElementStack::ElementRecord::next):
        (WebCore::HTMLElementStack::ElementRecord::releaseNext):
        (WebCore::HTMLElementStack::ElementRecord::setNext):
        * html/HTMLFormattingElementList.cpp:
        (WebCore::HTMLFormattingElementList::closestElementInScopeWithName):
        (WebCore::HTMLFormattingElementList::contains):
        (WebCore::HTMLFormattingElementList::find):
        (WebCore::HTMLFormattingElementList::remove):
        * html/HTMLFormattingElementList.h:
        (WebCore::HTMLFormattingElementList::isEmpty):
        (WebCore::HTMLFormattingElementList::size):
        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag):
        (WebCore::HTMLTreeBuilder::furthestBlockForFormattingElement):
         - Part of the Adoption Agency algorithm.
        (WebCore::HTMLTreeBuilder::findFosterParentFor):
         - Used to move mis-nested content out of tables.
           This doesn't seem to work quite right yet.
        (WebCore::HTMLTreeBuilder::reparentChildren):
        (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
         - The ridiculously long/complicated adoption agency algorithm from HTML5.
        (WebCore::HTMLTreeBuilder::processEndTag):
        * html/HTMLTreeBuilder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-04 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Sun, 4 Jul 2010 17:44:55 +0000 (17:44 +0000)]
2010-07-04  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Darin Adler.

        Remove custom src bindings for HTMLFrameElement and HTMLIFrameElement
        https://bugs.webkit.org/show_bug.cgi?id=41578

        Remove bindings obsoleted by: http://trac.webkit.org/changeset/59866
        No new tests because behavior is not changed.

        * Android.jscbindings.mk:
        * Android.v8bindings.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSHTMLFrameElementCustom.cpp:
        * bindings/js/JSHTMLIFrameElementCustom.cpp: Removed.
        * bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
        * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Removed.
        * html/HTMLFrameElement.idl:
        * html/HTMLIFrameElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-04 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Sun, 4 Jul 2010 16:22:23 +0000 (16:22 +0000)]
2010-07-04  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Darin Adler.

        Remove custom src bindings for HTMLFrameElement and HTMLIFrameElement
        https://bugs.webkit.org/show_bug.cgi?id=41578

        Remove bindings obsoleted by: http://trac.webkit.org/changeset/59866
        No new tests because behavior is not changed.

        * Android.jscbindings.mk:
        * Android.v8bindings.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSHTMLFrameElementCustom.cpp:
        * bindings/js/JSHTMLIFrameElementCustom.cpp: Removed.
        * bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
        * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Removed.
        * html/HTMLFrameElement.idl:
        * html/HTMLIFrameElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-04 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sun, 4 Jul 2010 13:38:30 +0000 (13:38 +0000)]
2010-07-04  Robert Hogan  <robert@webkit.org>

        [Qt] Triage failing HTTP tests in Qt Skipped list

        Unreviewed, sorting tests and adding comments to skipped list.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix after r62456.
mrowe@apple.com [Sun, 4 Jul 2010 11:48:04 +0000 (11:48 +0000)]
Build fix after r62456.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute): Be slightly more consistent in using uint32_t to prevent
warnings about comparisons between signed and unsigned types, and attempts to call an overload
of std::min that doesn't exist.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved
robert@webkit.org [Sun, 4 Jul 2010 10:38:31 +0000 (10:38 +0000)]
[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

Unreviewed, accidental omission from r61505

https://bugs.webkit.org/show_bug.cgi?id=36702

Forgot to unskip plugins/reentrant-update-widget-positions.html
as part of http://trac.webkit.org/changeset/61505

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-04 Yury Semikhatsky <yury@yurys-imac.local>
yurys@chromium.org [Sun, 4 Jul 2010 10:16:58 +0000 (10:16 +0000)]
2010-07-04  Yury Semikhatsky  <yury@yurys-imac.local>

        Unreviewed. Update Chromium test expectations.

        * platform/chromium-mac/fast/js/function-apply-expected.txt: Added.
        * platform/chromium-mac/fast/js/function-apply-many-args-expected.txt: Added.
        * platform/chromium-mac/html5lib/runner-expected.txt:
        * platform/chromium-win/fast/js/function-apply-expected.txt: Added.
        * platform/chromium-win/fast/js/function-apply-many-args-expected.txt: Added.
        * platform/chromium-win/html5lib/runner-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-04 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sun, 4 Jul 2010 09:41:06 +0000 (09:41 +0000)]
2010-07-04  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Mark Rowe.

        WebProcess crashes in release for simple layout tests
        https://bugs.webkit.org/show_bug.cgi?id=41575

        * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
        (WKBundlePageCopyRenderTreeExternalRepresentation): ref external representation StringImpl*
        before taking it out of its parent String, to avoid returning freed memory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 4 Jul 2010 05:09:51 +0000 (05:09 +0000)]
2010-07-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        Implement AfterAfterFramesetMode
        https://bugs.webkit.org/show_bug.cgi?id=41561

        Test coverage of this mode was a bit ... lacking, shall we say?  This
        patch adds a test for it.

        * html5lib/resources/webkit01.dat:
        * html5lib/runner-expected-html5.txt:
        * html5lib/runner-expected.txt:
        * html5lib/webkit-resumer-expected.txt:
2010-07-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        Implement AfterAfterFramesetMode
        https://bugs.webkit.org/show_bug.cgi?id=41561

        This mode is almost unobservable.  The main way to observe it seems to
        be seeing where comment nodes get attached to the DOM.

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag):
        (WebCore::HTMLTreeBuilder::processEndTag):
        (WebCore::HTMLTreeBuilder::processComment):
        (WebCore::HTMLTreeBuilder::processCharacter):
        (WebCore::HTMLTreeBuilder::processEndOfFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd stdint.h include to fix WebKitTestRunner build.
mjs@apple.com [Sun, 4 Jul 2010 04:53:02 +0000 (04:53 +0000)]
Add stdint.h include to fix WebKitTestRunner build.

Rubber stamped by Anders Carlsson.

* UIProcess/API/C/WKPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Zhenyao Mo <zmo@google.com>
zmo@google.com [Sun, 4 Jul 2010 01:33:31 +0000 (01:33 +0000)]
2010-07-03  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        WebGLRenderingContext::vertexAttrib* leads to possible out-of-range vector member visit
        https://bugs.webkit.org/show_bug.cgi?id=41572

        * platform/mac-leopard/Skipped: Adding back the program-test.html test since the failure cause is fixed in this patch.
2010-07-03  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        WebGLRenderingContext::vertexAttrib* leads to possible out-of-range vector member visit
        https://bugs.webkit.org/show_bug.cgi?id=41572

        * html/canvas/WebGLRenderingContext.cpp: Fix the out-of-range vector member visit, also refactor the code.
        (WebCore::WebGLRenderingContext::vertexAttrib1f):
        (WebCore::WebGLRenderingContext::vertexAttrib1fv):
        (WebCore::WebGLRenderingContext::vertexAttrib2f):
        (WebCore::WebGLRenderingContext::vertexAttrib2fv):
        (WebCore::WebGLRenderingContext::vertexAttrib3f):
        (WebCore::WebGLRenderingContext::vertexAttrib3fv):
        (WebCore::WebGLRenderingContext::vertexAttrib4f):
        (WebCore::WebGLRenderingContext::vertexAttrib4fv):
        (WebCore::WebGLRenderingContext::vertexAttribfImpl):
        (WebCore::WebGLRenderingContext::vertexAttribfvImpl):
        * html/canvas/WebGLRenderingContext.h: Helper function declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPatch for https://bugs.webkit.org/show_bug.cgi?id=41553
weinig@apple.com [Sun, 4 Jul 2010 00:11:41 +0000 (00:11 +0000)]
Patch for https://bugs.webkit.org/show_bug.cgi?id=41553
Make StringExtras.h versions of snprintf and vsnprintf match the unix versions.

Reviewed by Darin Adler.

- MSVC does not ensure the buffers are null terminated as the unix versions do.

* runtime/JSGlobalObjectFunctions.cpp: Cleanup includes.
* runtime/UString.cpp: Clean up includes.
(JSC::UString::from): Don't pass sizeof(buf) - 1, that is wrong.
* wtf/StringExtras.h:
(snprintf): Ensure null termination of buffer.
(vsnprintf): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Yong Li <yoli@rim.com>
darin@apple.com [Sat, 3 Jul 2010 23:49:59 +0000 (23:49 +0000)]
2010-07-03  Yong Li  <yoli@rim.com>

        Reviewed by Darin Adler.

        Make Arguments::MaxArguments clamping work for numbers >= 0x80000000 in
        the interpreter as well as the JIT.

        https://bugs.webkit.org/show_bug.cgi?id=41351
        rdar://problem/8142141

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::privateExecute): Fix signed integer overflow problem
        in op_load_varargs handling. 0xFFFFFFFF was read as -1.
2010-07-03  Darin Adler  <darin@apple.com>

        Added test cases for edge cases in apply function on arrays.
        https://bugs.webkit.org/show_bug.cgi?id=41351

        * fast/js/function-apply-expected.txt: Updated to expect success.
        * fast/js/script-tests/function-apply.js: Added test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUgh. Have to put the destructor in the .h file since the .ccp isn't compiled yet.
jorlow@chromium.org [Sat, 3 Jul 2010 23:02:24 +0000 (23:02 +0000)]
Ugh.  Have to put the destructor in the .h file since the .ccp isn't compiled yet.

* storage/IDBKey.h:
(WebCore::IDBKey::~IDBKey):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Sat, 3 Jul 2010 23:00:14 +0000 (23:00 +0000)]
2010-07-03  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Simon Hausmann.

        [Qt] Fix DumpRenderTree userStyleSheet handling.
        https://bugs.webkit.org/show_bug.cgi?id=41570

        DumpRenderTree did only set the userStyleSheet at
        layoutTestController.setUserStyleSheetEnabled().

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::reset):
        (LayoutTestController::setUserStyleSheetLocation):
        (LayoutTestController::setUserStyleSheetEnabled):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix. Forgot destructor.
jorlow@chromium.org [Sat, 3 Jul 2010 22:48:29 +0000 (22:48 +0000)]
Build fix.  Forgot destructor.

* storage/IDBKey.cpp:
(WebCore::IDBKey::~IDBKey):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-26 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Sat, 3 Jul 2010 22:18:14 +0000 (22:18 +0000)]
2010-06-26  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Dumitru Daniliuc.

        Support for keys and in-memory storage for IndexedDB
        https://bugs.webkit.org/show_bug.cgi?id=41252

        Set the role to Private.

        * JavaScriptCore.xcodeproj/project.pbxproj:
2010-06-26  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Dumitru Daniliuc.

        Support for keys and in-memory storage for IndexedDB
        https://bugs.webkit.org/show_bug.cgi?id=41252

        It'll take some time to get data persistence working for IndexedDB,
        so until then, we'll just store everything in an in memory tree.
        The tree uses WTF::AVLTree and is a template so that it can be used by
        object stores (IDBKey -> SerializedScriptValue) and indexes (IDBKey ->
        IDBKey).  This class will be used in a subsequent patch.

        Also add an IDBKey type that represents one of these keys.  We use a
        custom toJS function in a way similar to IDBAny to convert from WebCore
        to a JS value.  For converting the other way, we have to teach the code
        generators what to do (unfortunately).  This is done in a way similar
        to serialized script value.  Unlike serialized script value, IDBKey is
        in WebCore and only a helper function is JS engine specific.

        This code is not accessable from layout tests.  (Will fix in
        https://bugs.webkit.org/show_bug.cgi?id=41250)  The bindings tests
        show us that the generated bindings are what we expect.

        * ForwardingHeaders/wtf/AVLTree.h: Added.
        * bindings/js/IDBBindingUtilities.cpp: Added.
        (WebCore::createIDBKeyFromValue):
        * bindings/js/IDBBindingUtilities.h: Added.
        * bindings/js/JSIDBKeyCustom.cpp: Added.
        (WebCore::toJS):
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/scripts/test/CPP/WebDOMTestObj.cpp:
        (WebDOMTestObj::idbKey):
        * bindings/scripts/test/CPP/WebDOMTestObj.h:
        * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
        (webkit_dom_test_obj_idb_key):
        * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
        * bindings/scripts/test/JS/JSTestObj.cpp:
        (WebCore::):
        (WebCore::jsTestObjPrototypeFunctionIdbKey):
        * bindings/scripts/test/JS/JSTestObj.h:
        * bindings/scripts/test/ObjC/DOMTestObj.h:
        * bindings/scripts/test/ObjC/DOMTestObj.mm:
        (-[DOMTestObj idbKey:]):
        * bindings/scripts/test/TestObj.idl:
        * bindings/scripts/test/V8/V8TestObj.cpp:
        (WebCore::TestObjInternal::idbKeyCallback):
        (WebCore::):
        * bindings/v8/IDBBindingUtilities.cpp: Added.
        (WebCore::createIDBKeyFromValue):
        * bindings/v8/IDBBindingUtilities.h: Added.
        * bindings/v8/custom/V8IDBKeyCustom.cpp: Added.
        (WebCore::toV8):
        * storage/IDBCallbacks.h:
        * storage/IDBKey.cpp: Added.
        (WebCore::IDBKey::IDBKey):
        (WebCore::IDBKey::~IDBKey):
        * storage/IDBKey.h: Added.
        (WebCore::IDBKey::create):
        (WebCore::IDBKey::):
        (WebCore::IDBKey::type):
        (WebCore::IDBKey::string):
        (WebCore::IDBKey::number):
        * storage/IDBKey.idl: Added.
        * storage/IDBKeyTree.h: Added.
        (WebCore::IDBKeyTree::create):
        (WebCore::IDBKeyTree::AVLTreeAbstractor::get_less):
        (WebCore::IDBKeyTree::AVLTreeAbstractor::set_less):
        (WebCore::IDBKeyTree::AVLTreeAbstractor::get_greater):
        (WebCore::IDBKeyTree::AVLTreeAbstractor::set_greater):
        (WebCore::IDBKeyTree::AVLTreeAbstractor::get_balance_factor):
        (WebCore::IDBKeyTree::AVLTreeAbstractor::set_balance_factor):
        (WebCore::IDBKeyTree::AVLTreeAbstractor::null):
        (WebCore::IDBKeyTree::AVLTreeAbstractor::compare_key_node):
        (WebCore::IDBKeyTree::AVLTreeAbstractor::compare_node_node):
        (WebCore::::IDBKeyTree):
        (WebCore::::~IDBKeyTree):
        (WebCore::::AVLTreeAbstractor::compare_key_key):
        (WebCore::::get):
        (WebCore::::insert):
        (WebCore::::remove):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoThe missing plug-in indicator should be clickable
jhoneycutt@apple.com [Sat, 3 Jul 2010 21:57:02 +0000 (21:57 +0000)]
The missing plug-in indicator should be clickable

https://bugs.webkit.org/show_bug.cgi?id=41550
<rdar://problem/8132162>

From an original patch by Kevin Decker.

Reviewed by Darin Adler.

WebCore:

* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler):
If the renderer is a RenderEmbeddedWidget showing the missing plug-in
indicator, and the event is a click even, call the ChromeClient's
missingPluginButtonClicked() function.

* page/ChromeClient.h:
(WebCore::ChromeClient::missingPluginButtonClicked):
Declare missingPluginButtonClicked(), and stub the default
implementation.

* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
Initialize m_showsMissingPluginIndicator.
(WebCore::RenderEmbeddedObject::setShowsMissingPluginIndicator):
Assert that we're not currently showing any replacement text. Set
m_showsMissingPluginIndicator after setting the replacement text.
(WebCore::RenderEmbeddedObject::setShowsCrashedPluginIndicator):
Add the same assert as above.

* rendering/RenderEmbeddedObject.h:
(WebCore::RenderEmbeddedObject::showsMissingPluginIndicator):
Getter for m_showsMissingPluginIndicator.

WebKit/mac:

* WebCoreSupport/WebChromeClient.h:
Declare an override of missingPluginButtonClicked().

* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::missingPluginButtonClicked):
Call the UIDelegate's method.

* WebView/WebUIDelegatePrivate.h:
Declare didPressMissingPluginButton.

WebKit/win:

* Interfaces/IWebUIDelegatePrivate.idl:
Added a new delegate interface, and declare a function
didPressMissingPluginButton().

* Interfaces/WebKit.idl:
Touch this file to force interfaces to be rebuilt.

* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::missingPluginButtonClicked):
Get the UI delegate, and query it for IWebUIDelegatePrivate3. Call its
didPressMissingPluginButton() function.

* WebCoreSupport/WebChromeClient.h:
Declare an override of missingPluginButtonClicked().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sat, 3 Jul 2010 21:36:41 +0000 (21:36 +0000)]
2010-07-03  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Return usable property names from DRT's computedStyleIncludingVisitedInfo()

        Unskip fast/history/self-is-visited.html

        https://bugs.webkit.org/show_bug.cgi?id=40445

        * platform/qt/Skipped:
2010-07-03  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Return usable property names from DRT's computedStyleIncludingVisitedInfo()

        Object property names such as 'background-color' need to be returned in camel
        case, i.e. backgroundColor so that JS can reference them. Add support for this
        to DumpRenderTreeSupportQt.

        https://bugs.webkit.org/show_bug.cgi?id=40445

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (convertToPropertyName):
        (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove BOM handling out of the lexer and parser
oliver@apple.com [Sat, 3 Jul 2010 20:30:24 +0000 (20:30 +0000)]
Move BOM handling out of the lexer and parser
https://bugs.webkit.org/show_bug.cgi?id=41539

Reviewed by Geoffrey Garen.

JavaScriptCore:

Doing the BOM stripping in the lexer meant that we could
end up having to strip the BOMs from a source multiple times.
To deal with this we now require all strings provided by
a SourceProvider to already have had the BOMs stripped.
This also simplifies some of the lexer logic.

* parser/Lexer.cpp:
(JSC::Lexer::setCode):
(JSC::Lexer::sourceCode):
* parser/SourceProvider.h:
(JSC::SourceProvider::SourceProvider):
(JSC::UStringSourceProvider::create):
(JSC::UStringSourceProvider::getRange):
(JSC::UStringSourceProvider::UStringSourceProvider):
* wtf/text/StringImpl.h:
(WebCore::StringImpl::copyStringWithoutBOMs):

WebCore:

Update WebCore to ensure that SourceProviders don't
produce strings with BOMs in them.

* bindings/js/ScriptSourceProvider.h:
(WebCore::ScriptSourceProvider::ScriptSourceProvider):
* bindings/js/StringSourceProvider.h:
(WebCore::StringSourceProvider::StringSourceProvider):
* loader/CachedScript.cpp:
(WebCore::CachedScript::CachedScript):
(WebCore::CachedScript::script):
* loader/CachedScript.h:
(WebCore::CachedScript::):
  CachedScript now stores decoded data with the BOMs stripped,
  and caches the presence of BOMs across memory purges.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sat, 3 Jul 2010 19:20:37 +0000 (19:20 +0000)]
2010-07-03  Xan Lopez  <xlopez@igalia.com>

        Include DerivedSources/WebCore before DerivedSources/

        Recently DerivedSources generation was changed, with some files no
        longer being generated in the toplevel DerivedSources
        directory. Since that directory is first in the -I flags the build
        can be broken in some cases by including old files unless a 'make
        clean' is done. Change the -I order to fix the build in the 32 bit
        Release bot.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Erik Arvidsson <arv@chromium.org>
arv@chromium.org [Sat, 3 Jul 2010 14:08:17 +0000 (14:08 +0000)]
2010-07-03  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Ojan Vafai.

        Fix issue where a contextmenu event was reporting the wrong target if
        the context menu was shown due to pressing the context menu key
        (or Shift+F10).

        Split sendContextMenuForEvent into one case for keyboard events and use
        that when the contextmenu event should be dispatched due to a keypress.

        For the keboard case we now use the focused node as the target for the
        event and use the clipped rect to determine the position of the menu.

        https://bugs.webkit.org/show_bug.cgi?id=38129

        Use manual test since DRT does not handle context menu keys.

        * manual-tests/win/contextmenu-key.html: Added.
        * page/EventHandler.cpp:
        (WebCore::EventHandler::sendContextMenuEvent):
        (WebCore::EventHandler::sendContextMenuEventForKey):
        * page/EventHandler.h:
2010-07-03  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Ojan Vafai.

        Fix issue where a contextmenu event was reporting the wrong target
        if the context menu was shown due to pressing the context menu key
        (or Shift+F10).

        https://bugs.webkit.org/show_bug.cgi?id=38129

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::sendContextMenuEvent):
2010-07-03  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Ojan Vafai.

        Fix issue where a contextmenu event was reporting the wrong target
        if the context menu was shown due to pressing the context menu key
        (or Shift+F10).

        * WebView.cpp:
        (WebView::handleContextMenuEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sat, 3 Jul 2010 12:03:13 +0000 (12:03 +0000)]
2010-07-03  Dirk Schulze  <krit@webkit.org>

        Unreviewed sort of XCode project file.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sat, 3 Jul 2010 10:42:50 +0000 (10:42 +0000)]
2010-07-03  Robert Hogan  <robert@webkit.org>

        [Qt] Update Qt expected results after r62444

        Unreviewed, update test results.

        http://trac.webkit.org/changeset/62444
        https://bugs.webkit.org/show_bug.cgi?id=41088

        Qt expected results for various fast/ tests updated to reflect
        support for dumpChildFrameScrollPositions(). Checked against Mac results
        and they are all good.

        I have not updated the .png and .checksum files for the tests. This is
        because I suspect I will not get the same pixel results as the Qt build
        bot.

        * platform/qt/fast/dynamic/anchor-lock-expected.txt:
        * platform/qt/fast/overflow/position-fixed-transform-clipping-expected.txt:
        * platform/qt/fast/repaint/fixed-child-move-after-scroll-expected.txt:
        * platform/qt/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt:
        * platform/qt/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt:
        * platform/qt/fast/repaint/fixed-move-after-scroll-expected.txt:
        * platform/qt/fast/repaint/fixed-tranformed-expected.txt:
        * platform/qt/fast/repaint/repaint-during-scroll-expected.txt:
        * platform/qt/transforms/2d/transform-fixed-container-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sat, 3 Jul 2010 10:00:40 +0000 (10:00 +0000)]
2010-07-03  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] support dumpChildFrameScrollPositions

        https://bugs.webkit.org/show_bug.cgi?id=41088

        Unskip:

        http/tests/navigation/anchor-subframeload.html
        http/tests/navigation/relativeanchor-frames.html

        * platform/qt/Skipped:
2010-07-03  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] support dumpChildFrameScrollPositions

        https://bugs.webkit.org/show_bug.cgi?id=41088

        Unskip:

        http/tests/navigation/anchor-subframeload.html
        http/tests/navigation/relativeanchor-frames.html

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::dumpFrameScrollPosition):
        (WebCore::DumpRenderTree::dump):
        * DumpRenderTree/qt/DumpRenderTreeQt.h:
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::reset):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        (LayoutTestController::shouldDumpChildFrameScrollPositions):
        (LayoutTestController::dumpChildFrameScrollPositions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Sat, 3 Jul 2010 08:45:40 +0000 (08:45 +0000)]
2010-07-03  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Kent Tamura.

        [BREWMP] Port Widget
        https://bugs.webkit.org/show_bug.cgi?id=41538

        Make Widget a dummy class. WebKit Brew MP uses the full screen mode
        and does not use the window system introduced in Brew MP.

        * platform/Widget.h:
        * platform/brew/WidgetBrew.cpp: Added.
        (WebCore::Widget::Widget):
        (WebCore::Widget::~Widget):
        (WebCore::Widget::frameRect):
        (WebCore::Widget::setFrameRect):
        (WebCore::Widget::setFocus):
        (WebCore::Widget::setCursor):
        (WebCore::Widget::show):
        (WebCore::Widget::hide):
        (WebCore::Widget::paint):
        (WebCore::Widget::setIsSelected):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Sat, 3 Jul 2010 08:30:21 +0000 (08:30 +0000)]
2010-07-03  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Kent Tamura.

        [WINCE] Implement Unicode::isAlphanumeric and Unicode::isArabicChar.
        https://bugs.webkit.org/show_bug.cgi?id=41411

        * wtf/unicode/wince/UnicodeWince.cpp:
        (WTF::Unicode::isAlphanumeric):
        * wtf/unicode/wince/UnicodeWince.h:
        (WTF::Unicode::isArabicChar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Sat, 3 Jul 2010 08:17:39 +0000 (08:17 +0000)]
2010-07-03  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Kent Tamura.

        [BREWMP] Change the CRASH() macro to print "WebKit CRASH" log.
        https://bugs.webkit.org/show_bug.cgi?id=41524

        Print "WebKit CRASH" before crashing.

        * wtf/Assertions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 3 Jul 2010 07:17:39 +0000 (07:17 +0000)]
2010-07-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement AfterFramesetMode
        https://bugs.webkit.org/show_bug.cgi?id=41560

        It's somewhat hard to observe this state, so I'm not surprised that the
        diff to the expected results are small.  We still fail this test
        because we don't handle whitespace correctly.

        * html5lib/runner-expected-html5.txt:
2010-07-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement AfterFramesetMode
        https://bugs.webkit.org/show_bug.cgi?id=41560

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag):
        (WebCore::HTMLTreeBuilder::processEndTag):
        (WebCore::HTMLTreeBuilder::processCharacter):
        (WebCore::HTMLTreeBuilder::processEndOfFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 3 Jul 2010 07:03:51 +0000 (07:03 +0000)]
2010-07-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement InFramesetMode
        https://bugs.webkit.org/show_bug.cgi?id=41559

        And the tests keep progressing.

        * html5lib/runner-expected-html5.txt:
2010-07-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement InFramesetMode
        https://bugs.webkit.org/show_bug.cgi?id=41559

        Pretty straighforward.  We still don't handle character tokens
        correctly.

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag):
        (WebCore::HTMLTreeBuilder::processEndTag):
        (WebCore::HTMLTreeBuilder::processCharacter):
        (WebCore::HTMLTreeBuilder::processEndOfFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 3 Jul 2010 06:47:33 +0000 (06:47 +0000)]
2010-07-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Handle <frameset> InBody
        https://bugs.webkit.org/show_bug.cgi?id=41558

        Yay test progression.

        * html5lib/runner-expected-html5.txt:
2010-07-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Handle <frameset> InBody
        https://bugs.webkit.org/show_bug.cgi?id=41558

        Handling the <frameset> tag in the InBody mode is somewhat delicate.

        * html/HTMLElementStack.cpp:
        (WebCore::HTMLElementStack::popHTMLBodyElement):
        (WebCore::HTMLElementStack::popUntil):
        (WebCore::HTMLElementStack::popCommon):
        * html/HTMLElementStack.h:
        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 41565 - Repatching in ARMv7Assembler::repatchLoadPtrToLEA is broken
barraclough@apple.com [Sat, 3 Jul 2010 06:45:47 +0000 (06:45 +0000)]
Bug 41565 - Repatching in ARMv7Assembler::repatchLoadPtrToLEA is broken

Reviewed by Oliver Hunt.

This method tried to repatch a LDR (T2) into an ADD (T3) - but it only
repatches the first instruction word.  The layout of the fields in the
second word is different, and also needs repatching.

* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::repatchLoadPtrToLEA):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 3 Jul 2010 06:32:15 +0000 (06:32 +0000)]
2010-07-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Special handling of <rp> and <rt> tags
        https://bugs.webkit.org/show_bug.cgi?id=41557

        There didn't seem to be test coverage of these cases in the suite, so I
        added a couple tests.

        * html5lib/resources/webkit01.dat:
        * html5lib/runner-expected-html5.txt:
        * html5lib/runner-expected.txt:
        * html5lib/webkit-resumer-expected.txt:
2010-07-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Special handling of <rp> and <rt> tags
        https://bugs.webkit.org/show_bug.cgi?id=41557

        So sayeth the spec.

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 3 Jul 2010 06:20:06 +0000 (06:20 +0000)]
2010-07-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement special optgroup processing
        https://bugs.webkit.org/show_bug.cgi?id=41556

        * html5lib/runner-expected-html5.txt:
2010-07-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement special optgroup processing
        https://bugs.webkit.org/show_bug.cgi?id=41556

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 3 Jul 2010 06:07:52 +0000 (06:07 +0000)]
2010-07-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Handle <image> in new parser
        https://bugs.webkit.org/show_bug.cgi?id=41555

        Test progression.

        * html5lib/runner-expected-html5.txt:
2010-07-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Handle <image> in new parser
        https://bugs.webkit.org/show_bug.cgi?id=41555

        This patch is kind of goofy but apparently how the world works.

        * html/HTMLToken.h:
        (WebCore::AtomicHTMLToken::setName):
        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix test to account for the arg count clamping we do with function.apply
oliver@apple.com [Sat, 3 Jul 2010 05:42:56 +0000 (05:42 +0000)]
Fix test to account for the arg count clamping we do with function.apply

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoClamp the number of arguments supported by function.apply
oliver@apple.com [Sat, 3 Jul 2010 04:52:45 +0000 (04:52 +0000)]
Clamp the number of arguments supported by function.apply
https://bugs.webkit.org/show_bug.cgi?id=41351
<rdar://problem/8142141>

Reviewed by Gavin Barraclough.

JavaScriptCore:

Add clamping logic to function.apply similar to that
enforced by firefox.  We have a smaller clamp than
firefox as our calling convention means that stack
usage is proportional to argument count -- the firefox
limit is larger than you could actually call.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Arguments.h:
(JSC::Arguments::):

LayoutTests:

Testcases.

* fast/js/function-apply-many-args-expected.txt: Added.
* fast/js/function-apply-many-args.html: Added.
* fast/js/script-tests/function-apply-many-args.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Sat, 3 Jul 2010 04:23:11 +0000 (04:23 +0000)]
2010-07-02  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Alexey Proskuryakov.

        Remove extra semicolon at the end of HTMLTreeBuilder::attach
        https://bugs.webkit.org/show_bug.cgi?id=41546

        This is not critical, but the extra semicolon at the end of HTMLTreeBuilder::attach
        causes a warning in RVCT.

        * html/HTMLTreeBuilder.h:
        (WebCore::HTMLTreeBuilder::attach):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Luiz Agostini <luiz.agostini@openbossa.org>
commit-queue@webkit.org [Sat, 3 Jul 2010 04:07:29 +0000 (04:07 +0000)]
2010-07-02  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Wrong method name in file  Connection.h
        https://bugs.webkit.org/show_bug.cgi?id=41536

        Method openConnectionHandler was spelled as openConnection in class Connection.

        * Platform/CoreIPC/Connection.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Sat, 3 Jul 2010 03:53:13 +0000 (03:53 +0000)]
2010-07-02  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Darin Adler.

        Performance::disconnectFrame() needs to disconnect its children
        https://bugs.webkit.org/show_bug.cgi?id=41533

        No new tests because no new functionality.

        * page/Performance.cpp:
        (WebCore::Performance::disconnectFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Luiz Agostini <luiz.agostini@openbossa.org>
commit-queue@webkit.org [Sat, 3 Jul 2010 03:39:19 +0000 (03:39 +0000)]
2010-07-02  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Sam Weinig.

        Adding notification and touch events methods to WebChromeClient
        https://bugs.webkit.org/show_bug.cgi?id=41527

        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::notificationPresenter):
        (WebKit::WebChromeClient::needTouchEvents):
        * WebProcess/WebCoreSupport/WebChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Luiz Agostini <luiz.agostini@openbossa.org>
commit-queue@webkit.org [Sat, 3 Jul 2010 03:08:25 +0000 (03:08 +0000)]
2010-07-02  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Sam Weinig.

        Checking if WTF_USE_JSC is defined before redefining it in config.h
        https://bugs.webkit.org/show_bug.cgi?id=41530

        * config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, test expectation update.
pkasting@chromium.org [Sat, 3 Jul 2010 03:05:40 +0000 (03:05 +0000)]
Unreviewed, test expectation update.

Mark a newly added test as crashing.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Luiz Agostini <luiz.agostini@openbossa.org>
commit-queue@webkit.org [Sat, 3 Jul 2010 02:46:08 +0000 (02:46 +0000)]
2010-07-02  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Sam Weinig.

        Removing CoreFoundation.h include from WKFrame.h
        https://bugs.webkit.org/show_bug.cgi?id=41528

        * UIProcess/API/C/WKFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Sat, 3 Jul 2010 02:18:48 +0000 (02:18 +0000)]
2010-07-02  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Dimitri Glazkov.

        Add vendor prefix to window.performance
        https://bugs.webkit.org/show_bug.cgi?id=41525

        No new tests because window.performance tests not landed yet.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::webkitPerformance):
        * page/DOMWindow.h:
        (WebCore::DOMWindow::optionalWebkitPerformance):
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Zoltan Herczeg <zherczeg@webkit.org>
zherczeg@webkit.org [Sat, 3 Jul 2010 02:02:09 +0000 (02:02 +0000)]
2010-07-02  Zoltan Herczeg  <zherczeg@webkit.org>

        Reviewed by Oliver Hunt.

        Minor fix: Diffuse constant is float (not integer)
        https://bugs.webkit.org/show_bug.cgi?id=10412

        * svg/SVGFEDiffuseLightingElement.cpp:
        (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Chao-ying Fu <fu@mips.com>
commit-queue@webkit.org [Sat, 3 Jul 2010 01:49:03 +0000 (01:49 +0000)]
2010-07-02  Chao-ying Fu  <fu@mips.com>

        Reviewed by Oliver Hunt.

        Re-enable JIT_OPTIMIZE_NATIVE_CALL on MIPS
        https://bugs.webkit.org/show_bug.cgi?id=40179

        Add the MIPS part to re-enable JIT_OPTIMIZE_NATIVE_CALL.

        * jit/JITOpcodes.cpp:
        (JSC::JIT::privateCompileCTINativeCall):
        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 41552 - Clean up ARMv7 vfp code generation
barraclough@apple.com [Sat, 3 Jul 2010 00:28:12 +0000 (00:28 +0000)]
Bug 41552 - Clean up ARMv7 vfp code generation
Emit separate opcode individually, remove magic numbers.

Reviewed by Oliver Hunt.

Also remove invalid assert from JSImmediate (number cells are not CELL_MASK aligned).

* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::):
(JSC::ARMv7Assembler::vadd_F64):
(JSC::ARMv7Assembler::vcmp_F64):
(JSC::ARMv7Assembler::vcvt_F64_S32):
(JSC::ARMv7Assembler::vcvtr_S32_F64):
(JSC::ARMv7Assembler::vdiv_F64):
(JSC::ARMv7Assembler::vldr):
(JSC::ARMv7Assembler::vmov_F64_0):
(JSC::ARMv7Assembler::vmov):
(JSC::ARMv7Assembler::vmrs):
(JSC::ARMv7Assembler::vmul_F64):
(JSC::ARMv7Assembler::vstr):
(JSC::ARMv7Assembler::vsub_F64):
(JSC::ARMv7Assembler::VFPOperand::VFPOperand):
(JSC::ARMv7Assembler::VFPOperand::bits1):
(JSC::ARMv7Assembler::VFPOperand::bits4):
(JSC::ARMv7Assembler::vcvtOp):
(JSC::ARMv7Assembler::ARMInstructionFormatter::vfpOp):
(JSC::ARMv7Assembler::ARMInstructionFormatter::vfpMemOp):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::branchDouble):
* runtime/JSImmediate.h:
(JSC::JSValue::isCell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Sat, 3 Jul 2010 00:11:25 +0000 (00:11 +0000)]
2010-07-02  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed.

        Build fix for GTK+. Try to force a rebuild of the HTMLNames.h
        file first by touching HTMLTagNames.in.

        * html/HTMLTagNames.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Andreas Kling <andreas.kling@nokia.com>
commit-queue@webkit.org [Sat, 3 Jul 2010 00:08:09 +0000 (00:08 +0000)]
2010-07-02  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Oliver Hunt.

        Add test to verify proper clamping of RGB values.
        https://bugs.webkit.org/show_bug.cgi?id=39482

        Also unskip 3 canvas/philip tests that now pass.

        Spec link:
        http://www.whatwg.org/specs/web-apps/current-work/#colors

        * fast/canvas/canvas-color-clamping-expected.txt: Added.
        * fast/canvas/canvas-color-clamping.html: Added.
        * fast/canvas/script-tests/canvas-color-clamping.js: Added.
        * platform/mac/Skipped:
        * platform/qt/Skipped:
2010-07-02  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Oliver Hunt.

        RGB colors should be clamped to the 0-255 range
        https://bugs.webkit.org/show_bug.cgi?id=39482

        Spec link:
        http://www.whatwg.org/specs/web-apps/current-work/#colors

        Test: fast/canvas/canvas-color-clamping.html

        * css/CSSParser.cpp:
        (WebCore::parseColorInt):
        (WebCore::CSSParser::parseColor):
        (WebCore::parseColorIntFromValue):
        (WebCore::CSSParser::parseColorParameters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 2 Jul 2010 23:49:07 +0000 (23:49 +0000)]
2010-07-02  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r62410.
        http://trac.webkit.org/changeset/62410
        https://bugs.webkit.org/show_bug.cgi?id=41549

        accursed last minute changes (Requested by olliej on #webkit).

        * parser/Lexer.cpp:
        (JSC::Lexer::setCode):
        (JSC::Lexer::copyCodeWithoutBOMs):
        (JSC::Lexer::sourceCode):
        * parser/SourceProvider.h:
        (JSC::):
        (JSC::SourceProvider::SourceProvider):
        (JSC::SourceProvider::hasBOMs):
        (JSC::UStringSourceProvider::create):
        (JSC::UStringSourceProvider::getRange):
        (JSC::UStringSourceProvider::UStringSourceProvider):
        * wtf/text/StringImpl.h:
2010-07-02  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r62410.
        http://trac.webkit.org/changeset/62410
        https://bugs.webkit.org/show_bug.cgi?id=41549

        accursed last minute changes (Requested by olliej on #webkit).

        * bindings/js/ScriptSourceProvider.h:
        (WebCore::ScriptSourceProvider::ScriptSourceProvider):
        * bindings/js/StringSourceProvider.h:
        (WebCore::StringSourceProvider::StringSourceProvider):
        * loader/CachedScript.cpp:
        (WebCore::CachedScript::CachedScript):
        (WebCore::CachedScript::script):
        * loader/CachedScript.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename new scripts so that they don't make autocompleting run-webkit-tests annoying.
weinig@apple.com [Fri, 2 Jul 2010 23:46:22 +0000 (23:46 +0000)]
Rename new scripts so that they don't make autocompleting run-webkit-tests annoying.

Reviewed by Anders Carlsson.

* Scripts/debug-test-runner: Copied from Scripts/debug-webkittestrunner.
* Scripts/debug-webkittestrunner: Removed.
* Scripts/run-test-runner: Copied from Scripts/run-webkittestrunner.
* Scripts/run-webkittestrunner: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPatch for https://bugs.webkit.org/show_bug.cgi?id=41548
weinig@apple.com [Fri, 2 Jul 2010 23:26:23 +0000 (23:26 +0000)]
Patch for https://bugs.webkit.org/show_bug.cgi?id=41548
Use snprintf instead of sprintf everywhere in JavaScriptCore

Reviewed by Geoffrey Garen.

* runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::globalFuncEscape):
* runtime/UString.cpp:
(JSC::UString::from):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 2 Jul 2010 23:15:58 +0000 (23:15 +0000)]
2010-07-02  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed.

        Further Build fix for GTK+. Also include HTMLElementFactory.h in
        the list of dependencies.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 2 Jul 2010 23:11:39 +0000 (23:11 +0000)]
2010-07-02  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed.

        Build fix for GTK+. *Names.{cpp,h} targets should now include the
        header files. Also adds the header files to the generated sources list.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: DB clean up.
dumi@chromium.org [Fri, 2 Jul 2010 22:50:39 +0000 (22:50 +0000)]
WebCore: DB clean up.
https://bugs.webkit.org/show_bug.cgi?id=41404

Reviewed by Darin Fisher.

1. Made all DatabaseTasks internal classes of Database and made
   the Database methods called by those tasks private.
2. Removed the Database::stop{ed}() methods.
3. Removed the code that kept track of open databases from
   ScriptExecutionContext (no longer needed).
4. Made minor changes to Database::closeImmediately() to make it
   possible for DatabaseThread to call that method instead of
   close().
5. Minor fix to DatabaseTracker: addOpenDatabase() should call
   OriginQuotaManager::addDatabase() if the origin quota manager
   is not tracking this origin.
6. Removed Database::performPolicyChecks(). We already update the
   DB size after each transaction, and we enforce a max size for
   the DB at the beginning of each transaction.

* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::stopDatabases):
* dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::hasOpenDatabases):
* storage/Database.cpp:
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::markAsDeletedAndClose):
(WebCore::Database::close):
(WebCore::Database::closeImmediately):
* storage/Database.h:
* storage/DatabaseTask.cpp:
(WebCore::DatabaseTask::performTask):
(WebCore::Database::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::Database::DatabaseOpenTask::doPerformTask):
(WebCore::Database::DatabaseOpenTask::debugTaskName):
(WebCore::Database::DatabaseCloseTask::DatabaseCloseTask):
(WebCore::Database::DatabaseCloseTask::doPerformTask):
(WebCore::Database::DatabaseCloseTask::debugTaskName):
(WebCore::Database::DatabaseTransactionTask::DatabaseTransactionTask):
(WebCore::Database::DatabaseTransactionTask::doPerformTask):
(WebCore::Database::DatabaseTransactionTask::debugTaskName):
(WebCore::Database::DatabaseTableNamesTask::DatabaseTableNamesTask):
(WebCore::Database::DatabaseTableNamesTask::doPerformTask):
(WebCore::Database::DatabaseTableNamesTask::debugTaskName):
* storage/DatabaseTask.h:
(WebCore::Database::DatabaseOpenTask::create):
(WebCore::Database::DatabaseCloseTask::create):
(WebCore::Database::DatabaseTransactionTask::create):
(WebCore::Database::DatabaseTableNamesTask::create):
* storage/DatabaseThread.cpp:
(WebCore::DatabaseThread::databaseThread):
* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::addOpenDatabase):
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::executeSQL):
(WebCore::SQLTransaction::checkAndHandleClosedDatabase):

LayoutTests: Minor change to a DB test to make it run correctly with run-webkit-tests --iterations N.
https://bugs.webkit.org/show_bug.cgi?id=41404

Reviewed by Darin Fisher.

* storage/open-database-creation-callback.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 2 Jul 2010 22:31:40 +0000 (22:31 +0000)]
2010-07-02  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Move BOM handling out of the lexer and parser
        https://bugs.webkit.org/show_bug.cgi?id=41539

        Doing the BOM stripping in the lexer meant that we could
        end up having to strip the BOMs from a source multiple times.
        To deal with this we now require all strings provided by
        a SourceProvider to already have had the BOMs stripped.
        This also simplifies some of the lexer logic.

        * parser/Lexer.cpp:
        (JSC::Lexer::setCode):
        (JSC::Lexer::sourceCode):
        * parser/SourceProvider.h:
        (JSC::SourceProvider::SourceProvider):
        (JSC::UStringSourceProvider::create):
        (JSC::UStringSourceProvider::getRange):
        (JSC::UStringSourceProvider::UStringSourceProvider):
        * wtf/text/StringImpl.h:
        (WebCore::StringImpl::copyStringWithoutBOMs):
2010-07-02  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Move BOM handling out of the lexer and parser
        https://bugs.webkit.org/show_bug.cgi?id=41539

        Update WebCore to ensure that SourceProviders don't
        produce strings with BOMs in them.

        * bindings/js/ScriptSourceProvider.h:
        (WebCore::ScriptSourceProvider::ScriptSourceProvider):
        * bindings/js/StringSourceProvider.h:
        (WebCore::StringSourceProvider::StringSourceProvider):
        * loader/CachedScript.cpp:
        (WebCore::CachedScript::CachedScript):
        (WebCore::CachedScript::script):
        * loader/CachedScript.h:
        (WebCore::CachedScript::):
          CachedScript now stores decoded data with the BOMs stripped,
          and caches the presence of BOMs across memory purges.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 2 Jul 2010 22:18:47 +0000 (22:18 +0000)]
2010-07-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, expectations update.

        Provide new expectations for ports that don't handle "Enter-on-select" in the same way as Safari.
        https://bugs.webkit.org/show_bug.cgi?id=39532

        * platform/chromium-win/fast/forms/implicit-submission-expected.txt: Added.
        * platform/gtk/Skipped: Unskipped the test.
        * platform/gtk/fast/forms/implicit-submission-expected.txt: Added.
        * platform/qt/Skipped: Unskipped the test.
        * platform/qt/fast/forms/implicit-submission-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReviewed by David Levin.
zmo@google.com [Fri, 2 Jul 2010 22:03:45 +0000 (22:03 +0000)]
Reviewed by David Levin.

fast/canvas/webgl/program-test.html failed on leopard bot
https://bugs/webkit.org/show_bug.cgi?id=41542

* platform/mac-leopard/Skipped: Skip the failing test for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd missing symbol to exports file.
weinig@apple.com [Fri, 2 Jul 2010 21:58:30 +0000 (21:58 +0000)]
Add missing symbol to exports file.

* WebCore.base.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPatch for https://bugs.webkit.org/show_bug.cgi?id=41540
weinig@apple.com [Fri, 2 Jul 2010 21:54:02 +0000 (21:54 +0000)]
Patch for https://bugs.webkit.org/show_bug.cgi?id=41540
WebKit2: Add InjectedCode API to get a list of subframes

Reviewed by Oliver Hunt.

* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameCopyChildFrames):
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::childFrameRef):
(WebKit::childFrameDeref):
(WebKit::WebFrame::childFrames):
* WebProcess/WebPage/WebFrame.h:
* mac/WebKit2.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[ Updated after rollout. ]
ggaren@apple.com [Fri, 2 Jul 2010 21:34:43 +0000 (21:34 +0000)]
[ Updated after rollout. ]

Patch by Renata Hodovan <reni@inf.u-szeged.hu> on 2010-07-02
Reviewed by Oliver Hunt.

Merged RegExp constructor and RegExp::create methods.
Both functions are called with three parameters and check whether
flags (the third param) is given or not.
Avoid extra hash lookups in RegExpCache::create by passing a pre-computed
iterator parameter.
https://bugs.webkit.org/show_bug.cgi?id=41055

* runtime/RegExp.cpp:
(JSC::RegExp::RegExp):
* runtime/RegExp.h:
* runtime/RegExpCache.cpp:
(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::create):
* runtime/RegExpCache.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoVersioning.
mrowe@apple.com [Fri, 2 Jul 2010 21:31:55 +0000 (21:31 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate some Windows layout test results after r62215 - adding the .dataset
bweinstein@apple.com [Fri, 2 Jul 2010 21:11:44 +0000 (21:11 +0000)]
Update some Windows layout test results after r62215 - adding the .dataset
DOM property.

Rubber-stamped by Anders Carlsson.

* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/win/fast/dom/prototype-inheritance-2-expected.txt:
* platform/win/fast/dom/prototype-inheritance-expected.txt:
* platform/win/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 2 Jul 2010 20:43:47 +0000 (20:43 +0000)]
2010-07-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, expectations update.

        Add fast/forms/implicit-submission.html to Gtk and Qt Skipped list,
        because their behaviors are platform-specific and don't match
        expected results.
        https://bugs.webkit.org/show_bug.cgi?id=39532

        * platform/gtk/Skipped: Added fast/forms/implicit-submission.html.
        * platform/qt/Skipped: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSome http tests fail on Windows with Cygwin 1.7
bweinstein@apple.com [Fri, 2 Jul 2010 20:39:30 +0000 (20:39 +0000)]
Some http tests fail on Windows with Cygwin 1.7
https://bugs.webkit.org/show_bug.cgi?id=41537

Reviewed by Steve Falkenburg.

With Cygwin 1.7, the registry key at SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/
doesn't exist anymore, because the mount points are stored in /etc/fstab. However, we
just need root mount point, which is defined in SOFTWARE\\Cygwin\\setup.

* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(resolveCygwinPath): Fall back to SOFTWARE\\Cygwin\\setup if
    SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/ doesn't work.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Abhishek Arya <inferno@chromium.org>
jschuh@chromium.org [Fri, 2 Jul 2010 19:51:18 +0000 (19:51 +0000)]
2010-07-02  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Darin Fisher.

        Remove the extra setFailed() call in JPEG decoder to prevent
        re-using an already freed object.
        https://bugs.webkit.org/show_bug.cgi?id=41487

        Test: fast/images/large-size-image-crash.html

        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
        (WebCore::JPEGImageReader::decode):
2010-07-02  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Darin Fisher.

        Tests that images with large width and height values do not result in crash.
        Skip layout test for mac and win since it needs to be fixed at image decoder layer for Safari.
        https://bugs.webkit.org/show_bug.cgi?id=41487

        * fast/images/large-size-image-crash-expected.txt: Added.
        * fast/images/large-size-image-crash.html: Added.
        * fast/images/resources/large-size-image-crash.jpeg: Added.
        * platform/mac/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Peter Beverloo <peter@lvp-media.com>
commit-queue@webkit.org [Fri, 2 Jul 2010 19:45:28 +0000 (19:45 +0000)]
2010-07-02  Peter Beverloo  <peter@lvp-media.com>

        Reviewed by Maciej Stachowiak.

        Add the HTML5 <mark> element. Text content of the element will have
        a yellow background color and black text.

        Tests for <p> closing, phrasing child content and residual style.

        * fast/html/mark-element-expected.txt: Added.
        * fast/html/mark-element.html: Added.
        * fast/html/script-tests/mark-element.js: Added.
2010-07-02  Peter Beverloo  <peter@lvp-media.com>

        Reviewed by Maciej Stachowiak.

        Add the HTML5 <mark> element. Text content of the element will have
        a yellow background color and black text.

        Test: fast/html/mark-element.html
        Tests for <p> closing, phrasing child content and residual style.

        * css/html.css:
        (mark):
        * html/HTMLElement.cpp:
        (WebCore::inlineTagList):
        * html/HTMLTagNames.in:
        * html/LegacyHTMLTreeBuilder.cpp:
        (WebCore::LegacyHTMLTreeBuilder::getNode):
        (WebCore::LegacyHTMLTreeBuilder::isInline):
        (WebCore::LegacyHTMLTreeBuilder::isResidualStyleTag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 2 Jul 2010 19:24:08 +0000 (19:24 +0000)]
2010-07-02  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Fix issues in boundary situations for WebGLRenderingContext::drawArrays/drawElements
        https://bugs.webkit.org/show_bug.cgi?id=41473

        * fast/canvas/webgl/draw-arrays-out-of-bounds-expected.txt: Test against overflow, size-0 buffer, and count==0 situations.
        * fast/canvas/webgl/draw-arrays-out-of-bounds.html: Ditto.
        * fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt: Ditto.
        * fast/canvas/webgl/draw-elements-out-of-bounds.html: Ditto.
2010-07-02  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Fix issues in boundary situations for WebGLRenderingContext::drawArrays/drawElements
        https://bugs.webkit.org/show_bug.cgi?id=41473

        * WebCore.gypi: Add CheckedInt.h.
        * WebCore.xcodeproj/project.pbxproj: Add CheckedInt.h.
        * html/canvas/CheckedInt.h: Added support of safe integer operations.
        (mozilla::CheckedInt_internal::integer_type_manually_recorded_info::):
        (mozilla::CheckedInt_internal::is_unsupported_type::):
        (mozilla::CheckedInt_internal::):
        (mozilla::CheckedInt_internal::integer_traits::):
        (mozilla::CheckedInt_internal::integer_traits::min):
        (mozilla::CheckedInt_internal::integer_traits::max):
        (mozilla::CheckedInt_internal::has_sign_bit):
        (mozilla::CheckedInt_internal::binary_complement):
        (mozilla::CheckedInt_internal::is_in_range):
        (mozilla::CheckedInt_internal::is_add_valid):
        (mozilla::CheckedInt_internal::is_sub_valid):
        (mozilla::CheckedInt_internal::is_mul_valid):
        (mozilla::CheckedInt_internal::is_div_valid):
        (mozilla::CheckedInt::CheckedInt):
        (mozilla::CheckedInt::value):
        (mozilla::CheckedInt::valid):
        (mozilla::CheckedInt::operator -):
        (mozilla::CheckedInt::operator ==):
        (mozilla::CheckedInt::operator !=):
        (mozilla::operator /):
        (mozilla::cast_to_CheckedInt_impl::run):
        (mozilla::):
        (mozilla::cast_to_CheckedInt):
        (mozilla::operator ==):
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::validateIndexArrayConservative): Fix a bug against 0-size buffer situation.
        (WebCore::WebGLRenderingContext::drawArrays): Deal with overflows and count==0 situation.
        (WebCore::WebGLRenderingContext::drawElements): Deal with count==0 situation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 2 Jul 2010 19:06:12 +0000 (19:06 +0000)]
2010-07-02  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        linkProgram should fail when vertex/fragment shaders are not both present
        https://bugs.webkit.org/show_bug.cgi?id=41380

        * fast/canvas/webgl/program-test-expected.txt: Added.
        * fast/canvas/webgl/program-test.html: Added.
2010-07-02  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        linkProgram should fail when vertex/fragment shaders are not both present
        https://bugs.webkit.org/show_bug.cgi?id=41380

        Test: fast/canvas/webgl/program-test.html

        * html/canvas/WebGLProgram.cpp: Add flag for link failure due to missing shaders.
        (WebCore::WebGLProgram::WebGLProgram):
        * html/canvas/WebGLProgram.h: Add interface for linkFailure flag.
        (WebCore::WebGLProgram::isLinkFailureFlagSet):
        (WebCore::WebGLProgram::setLinkFailureFlag):
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::getProgramParameter): Intercept when linkFailureFlag is set.
        (WebCore::WebGLRenderingContext::linkProgram): Check if there are missing shaders and don't link if yes.
        * html/canvas/WebGLShader.cpp: Cache shader type.
        (WebCore::WebGLShader::WebGLShader):
        * html/canvas/WebGLShader.h: Ditto.
        (WebCore::WebGLShader::getType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTurn off the Objective-C garbage collection for the WebProcess.
weinig@apple.com [Fri, 2 Jul 2010 19:00:25 +0000 (19:00 +0000)]
Turn off the Objective-C garbage collection for the WebProcess.

Reviewed by Anders Carlsson.

* Configurations/WebProcess.xcconfig:
* WebProcess/Launching/mac/WebProcessMain.mm:
(main): Assert that GC is off.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Qi Zhang <qi.2.zhang@nokia.com>
commit-queue@webkit.org [Fri, 2 Jul 2010 18:47:54 +0000 (18:47 +0000)]
2010-07-02  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt]  Failed on http://philip.html5.org/tests/canvas/suite/tests/2d.drawImage.negativesource.html

        Remove the following test case from Skipped:
        canvas/philip/tests/2d.drawImage.negativedest.html
        canvas/philip/tests/2d.drawImage.negativedir.html
        canvas/philip/tests/2d.drawImage.negativesource.html

        * platform/qt/Skipped:
2010-07-02  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt]  Failed on http://philip.html5.org/tests/canvas/suite/tests/2d.drawImage.negativesource.html

        Support negative width and height in canvas image draw

        * platform/graphics/FloatRect.h:
        * platform/graphics/qt/FloatRectQt.cpp:
        (WebCore::FloatRect::normalized):
        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::BitmapImage::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoThere is no longer a reason to check that the process is valid when posting
weinig@apple.com [Fri, 2 Jul 2010 18:43:46 +0000 (18:43 +0000)]
There is no longer a reason to check that the process is valid when posting
a message to the bundle, the process code will take care of that for us.

Reviewed by Anders Carlsson.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::postMessageToInjectedBundle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse send instead of connection()->send(), now that connections() are created
weinig@apple.com [Fri, 2 Jul 2010 18:42:31 +0000 (18:42 +0000)]
Use send instead of connection()->send(), now that connections() are created
asynchronously it can be null at this point and the message needs to be queued.

Reviewed by Anders Carlsson.

* UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::WebProcessProxy::setUpAcceleratedCompositing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-24 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 2 Jul 2010 18:06:38 +0000 (18:06 +0000)]
2010-06-24  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Alexey Proskuryakov.

        REGRESSION: Enter does not trigger submit of forms when focus is on select.
        https://bugs.webkit.org/show_bug.cgi?id=39532

        * fast/forms/implicit-submission-expected.txt: Updated.
        * fast/forms/implicit-submission.html: Added more test coverage for selects.
2010-06-24  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Alexey Proskuryakov.

        REGRESSION: Enter does not trigger submit of forms when focus is on select.
        https://bugs.webkit.org/show_bug.cgi?id=39532

        Restore behavior where hitting "Enter" on a select element attempts to submit
        form implicitly.

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::menuListDefaultEventHandler): Added htmlForm argument,
            and attempting to submit implicitly.
        (WebCore::SelectElement::listBoxDefaultEventHandler): Ditto.
        (WebCore::SelectElement::defaultEventHandler): Plumbed through htmlForm argument.
        * dom/SelectElement.h: Added htmlForm argument to method declaration.
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::defaultEventHandler): Changed to provide submitting form
            as the argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 2 Jul 2010 17:30:55 +0000 (17:30 +0000)]
2010-07-02  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Support indeterminate checkbox for Linux, and a small fix for Windows
        https://bugs.webkit.org/show_bug.cgi?id=41508

        * platform/chromium/test_expectations.txt:
          fast/forms/indeterminate.html fails temporarily.
2010-07-02  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Support indeterminate checkbox for Linux, and a small fix for Windows
        https://bugs.webkit.org/show_bug.cgi?id=41508

        * rendering/RenderThemeChromiumSkia.cpp:
        (WebCore::RenderThemeChromiumSkia::paintCheckbox):
          Use dedicated images for indeterminate states.
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::determineClassicState):
          Do not use DFCS_CHECKED in a case of indeterminate state in
          order to have consistent appearance of indeterminate checkbox.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 2 Jul 2010 17:21:33 +0000 (17:21 +0000)]
2010-07-02  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed. Build fix for GTK+.

        Build Lexer.lut.h with the rest of the .lut.h files. Later these should
        all probably be moved to DerivedSources.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixes https://bugs.webkit.org/show_bug.cgi?id=41323.
bfulgham@webkit.org [Fri, 2 Jul 2010 17:14:27 +0000 (17:14 +0000)]
Fixes https://bugs.webkit.org/show_bug.cgi?id=41323.
Provides an implementation of the 'squiggle' used for
bad grammar or spelling, based on the Pango logic used
by the GTK builds.

Reviewed by Gustavo Noronha Silva.

No new tests. Covered by LayoutTests/editing/spelling

* WebCore.vcproj/WebCore.vcproj: Add new file holding underline
implementation, set to build only for WinCairo port.
* platform/graphics/cairo/DrawErrorUnderline.cpp: Added.
(drawErrorUnderline): New file containing the squiggle drawing
logic based on the Pango implementation.  Placed in its own file
to isolate licenses.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
Have WinCairo build call new 'drawErrorUnderline' implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-23 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 2 Jul 2010 16:53:06 +0000 (16:53 +0000)]
2010-06-23  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Separate DerivedSources per-project
        https://bugs.webkit.org/show_bug.cgi?id=41109

        Separate WebKitGTK+ DerivedSources into per-project subdirectories to prepare
        for properly building WebKit2.

        * GNUmakefile.am:
2010-06-23  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Separate DerivedSources per-project
        https://bugs.webkit.org/show_bug.cgi?id=41109

        Generate JavaScriptCore derived sources in <builddir>/DerivedSources/JavaScriptCore.

        * GNUmakefile.am:
2010-06-23  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Separate DerivedSources per-project
        https://bugs.webkit.org/show_bug.cgi?id=41109

        Generate WebCore derived sources in <builddir>/DerivedSources/WebCore.

        * GNUmakefile.am:
2010-06-23  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Separate DerivedSources per-project
        https://bugs.webkit.org/show_bug.cgi?id=41109

        Separate WebKitGTK+ DerivedSources into per-project subdirectories to prepare
        for properly building WebKit2.

        * webkitmarshal.list: Touch this file to force a rebuild of the marshaling code.
2010-06-23  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Separate DerivedSources per-project
        https://bugs.webkit.org/show_bug.cgi?id=41109

        The JavaScriptCore cppflags used to include the top-level DerivedSources directory
        allowing the tools to build as a side-effect. Now that the top-level directory
        is no longer in the list of JavaScriptCore includes, include it explicitly.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Peter Varga <pvarga@inf.u-szeged.hu>
ddkilzer@apple.com [Fri, 2 Jul 2010 16:45:41 +0000 (16:45 +0000)]
2010-07-02  Peter Varga  <pvarga@inf.u-szeged.hu>

        Reviewed by Oliver Hunt.

        The alternativeFrameLocation value is wrong in the emitDisjunction function in
        case of PatternTerm::TypeParentheticalAssertion. This value needs to be
        computed from term.frameLocation instead of term.inputPosition. This mistake caused glibc
        memory corruption in some cases.
        Layout test added for checking of TypeParentheticalAssertion case.
        https://bugs.webkit.org/show_bug.cgi?id=41458

        * yarr/RegexInterpreter.cpp:
        (JSC::Yarr::ByteCompiler::emitDisjunction):
2010-07-02  Peter Varga  <pvarga@inf.u-szeged.hu>

        Reviewed by Oliver Hunt.

        The alternativeFrameLocation value is wrong in the emitDisjunction function in
        case of PatternTerm::TypeParentheticalAssertion. This value needs to be
        computed from term.frameLocation instead of term.inputPosition. This mistake caused glibc
        memory corruption in some cases.
        Layout test added for checking of TypeParentheticalAssertion case.
        https://bugs.webkit.org/show_bug.cgi?id=41458

        * fast/js/regexp-look-ahead-expected.txt: Added.
        * fast/js/regexp-look-ahead.html: Added.
        * fast/js/script-tests/regexp-look-ahead.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 2 Jul 2010 16:35:02 +0000 (16:35 +0000)]
2010-07-02  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Implement OpenGL ES 2.0 semantics for vertex attribute 0
        https://bugs.webkit.org/show_bug.cgi?id=41300

        * fast/canvas/webgl/gl-bind-attrib-location-test-expected.txt: Added.
        * fast/canvas/webgl/gl-bind-attrib-location-test.html: Added.
        * fast/canvas/webgl/gl-vertex-attrib-expected.txt: Added.
        * fast/canvas/webgl/gl-vertex-attrib.html: Added.
2010-07-02  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Implement OpenGL ES 2.0 semantics for vertex attribute 0
        https://bugs.webkit.org/show_bug.cgi?id=41300

        Test: fast/canvas/webgl/gl-bind-attrib-location-test.html
              fast/canvas/webgl/gl-vertex-attrib.html

        * html/canvas/WebGLProgram.cpp:
        (WebCore::WebGLProgram::numActiveAttribLocations): const.
        (WebCore::WebGLProgram::getActiveAttribLocation): const.
        (WebCore::WebGLProgram::isUsingVertexAttrib0): Determine whether vertex attrib 0 is used by the program.
        * html/canvas/WebGLProgram.h: Declare isUsingVertexAttrib0.
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::WebGLRenderingContext): Deal with vertex attrib 0.
        (WebCore::WebGLRenderingContext::disableVertexAttribArray): Ditto.
        (WebCore::WebGLRenderingContext::drawArrays): Ditto.
        (WebCore::WebGLRenderingContext::drawElements): Ditto.
        (WebCore::WebGLRenderingContext::getVertexAttrib): Use cached value instead of calling glGetVertexAtrtrib.
        (WebCore::WebGLRenderingContext::vertexAttrib1f): Validate input, deal with vertex attrib 0.
        (WebCore::WebGLRenderingContext::vertexAttrib1fv): Ditto.
        (WebCore::WebGLRenderingContext::vertexAttrib2f): Ditto.
        (WebCore::WebGLRenderingContext::vertexAttrib2fv): Ditto.
        (WebCore::WebGLRenderingContext::vertexAttrib3f): Ditto.
        (WebCore::WebGLRenderingContext::vertexAttrib3fv): Ditto.
        (WebCore::WebGLRenderingContext::vertexAttrib4f): Ditto.
        (WebCore::WebGLRenderingContext::vertexAttrib4fv): Ditto.
        (WebCore::WebGLRenderingContext::vertexAttribPointer): Ditto.
        (WebCore::WebGLRenderingContext::handleNPOTTextures): Move isGLES2Compliant() to caller.
        (WebCore::WebGLRenderingContext::vertexAttribImpl): Helper for vertexAttribNfv.
        (WebCore::WebGLRenderingContext::initVertexAttrib0): Initialize vertex attrib 0.
        (WebCore::WebGLRenderingContext::simulateVertexAttrib0): Simulate vertex attrib 0.
        (WebCore::WebGLRenderingContext::restoreStatesAfterVertexAttrib0Simulation): Restore states after simulating vertex attrib 0.
        * html/canvas/WebGLRenderingContext.h:
        (WebCore::WebGLRenderingContext::VertexAttribState::VertexAttribState): Tracking full vertex attrib states.
        (WebCore::WebGLRenderingContext::VertexAttribState::initValue): Init value to [0,0,0,1].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 2 Jul 2010 16:20:58 +0000 (16:20 +0000)]
2010-07-02  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Need to validate the size of the incoming arrays for uniform* functions
        https://bugs.webkit.org/show_bug.cgi?id=41383

        * fast/canvas/webgl/gl-uniform-arrays-expected.txt: Test against invalid array size.
        * fast/canvas/webgl/gl-uniform-arrays.html: Ditto.
        * fast/canvas/webgl/gl-uniformmatrix4fv-expected.txt: Ditto.
        * fast/canvas/webgl/gl-uniformmatrix4fv.html: Ditto.
2010-07-02  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Need to validate the size of the incoming arrays for uniform* functions
        https://bugs.webkit.org/show_bug.cgi?id=41383

        * html/canvas/WebGLRenderingContext.cpp: Validate input array size.
        (WebCore::WebGLRenderingContext::uniform1fv):
        (WebCore::WebGLRenderingContext::uniform1iv):
        (WebCore::WebGLRenderingContext::uniform2fv):
        (WebCore::WebGLRenderingContext::uniform2iv):
        (WebCore::WebGLRenderingContext::uniform3fv):
        (WebCore::WebGLRenderingContext::uniform3iv):
        (WebCore::WebGLRenderingContext::uniform4fv):
        (WebCore::WebGLRenderingContext::uniform4iv):
        (WebCore::WebGLRenderingContext::uniformMatrix2fv):
        (WebCore::WebGLRenderingContext::uniformMatrix3fv):
        (WebCore::WebGLRenderingContext::uniformMatrix4fv):
        (WebCore::WebGLRenderingContext::validateUniformParameters):
        (WebCore::WebGLRenderingContext::validateUniformMatrixParameters):
        * html/canvas/WebGLRenderingContext.h: Add helper functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Canvas arcTo() should draw straight line to p1 if p0, p1 and p2 are collinear
vestbo@webkit.org [Fri, 2 Jul 2010 15:15:43 +0000 (15:15 +0000)]
[Qt] Canvas arcTo() should draw straight line to p1 if p0, p1 and p2 are collinear

Reviewed by Simon Hausmann.

The implementation of PathQt's addArcTo() was not float-safe and also had
a case where it drew an 'infinite' line, which is not part of the spec.

http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-arcto

We now use qFuzzyCompare() in both cases. The method isPointOnPathBorder()
also had the same problem, and was refactored a bit in the process of fixing
the bug.

Initial patch by Andreas Kling.

https://bugs.webkit.org/show_bug.cgi?id=41412

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
commit-queue@webkit.org [Fri, 2 Jul 2010 14:11:01 +0000 (14:11 +0000)]
2010-07-02  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Simon Hausmann.

        Compilation fix.

        QScriptEnginePrivate::newArray can't be const because it can
        throw an exception.

        [Qt] QScriptEnginePrivate compilation fix
        https://bugs.webkit.org/show_bug.cgi?id=41520

        * api/qscriptengine_p.cpp:
        (QScriptEnginePrivate::newArray):
        * api/qscriptengine_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 2 Jul 2010 13:56:20 +0000 (13:56 +0000)]
2010-07-02  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Rebaseline html5lib/runner.html on Chromium Mac.

        * platform/chromium-mac/html5lib/runner-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62381 268f45cc-cd09-0410-ab3c-d52691b4dbfc