WebKit-https.git
7 years agoTest rebaselines after SK_IGNORE_FAST_BLURRECT has been removed
schenney@chromium.org [Thu, 15 Nov 2012 20:34:33 +0000 (20:34 +0000)]
Test rebaselines after SK_IGNORE_FAST_BLURRECT has been removed

Unreviewed test expectations update.

* fast/box-shadow/single-pixel-shadow-expected.png: Added.
* platform/chromium-linux-x86/fast/box-shadow: Removed.
* platform/chromium-linux-x86/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
* platform/chromium-linux-x86/fast/repaint/transform-replaced-shadows-expected.png: Added.
* platform/chromium-linux-x86/svg/filters/shadow-on-rect-with-filter-expected.png:
* platform/chromium-linux/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
* platform/chromium-linux/fast/repaint/shadow-multiple-horizontal-expected.png:
* platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
* platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.png:
* platform/chromium-linux/fast/repaint/transform-replaced-shadows-expected.png: Added.
* platform/chromium-mac-lion/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-mac-lion/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-mac-lion/fast/box-shadow/box-shadow-transformed-expected.png:
* platform/chromium-mac-lion/fast/canvas/canvas-incremental-repaint-expected.png:
* platform/chromium-mac-lion/fast/repaint/box-shadow-h-expected.png:
* platform/chromium-mac-lion/fast/repaint/box-shadow-v-expected.png:
* platform/chromium-mac-lion/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
* platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
* platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
* platform/chromium-mac-lion/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-mac-lion/fast/repaint/transform-replaced-shadows-expected.png: Added.
* platform/chromium-mac-lion/fast/transforms/shadows-expected.png:
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
* platform/chromium-mac-lion/svg/css/group-with-shadow-expected.png:
* platform/chromium-mac-lion/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-mac-snowleopard/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-transformed-expected.png:
* platform/chromium-mac-snowleopard/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/box-shadow-h-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/box-shadow-v-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-horizontal-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-strict-vertical-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/transform-replaced-shadows-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
* platform/chromium-mac-snowleopard/svg/filters/shadow-on-rect-with-filter-expected.png:
* platform/chromium-mac/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-mac/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png:
* platform/chromium-mac/fast/box-shadow/box-shadow-radius-expected.png:
* platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png:
* platform/chromium-mac/fast/box-shadow/scaled-box-shadow-expected.png:
* platform/chromium-mac/fast/box-shadow/single-pixel-shadow-expected.png:
* platform/chromium-mac/fast/canvas/canvas-incremental-repaint-expected.png:
* platform/chromium-mac/fast/canvas/canvas-shadow-expected.txt: Removed.
* platform/chromium-mac/fast/repaint/box-shadow-h-expected.png:
* platform/chromium-mac/fast/repaint/box-shadow-v-expected.png:
* platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
* platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
* platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
* platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-mac/fast/repaint/transform-replaced-shadows-expected.png: Added.
* platform/chromium-mac/fast/transforms/shadows-expected.png:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
* platform/chromium-mac/svg/css/group-with-shadow-expected.png:
* platform/chromium-mac/svg/filters/shadow-on-rect-with-filter-expected.png:
* platform/chromium-win-xp/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-win-xp/fast/box-shadow: Removed.
* platform/chromium-win-xp/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
* platform/chromium-win-xp/fast/repaint/box-shadow-h-expected.png: Added.
* platform/chromium-win-xp/fast/repaint/box-shadow-v-expected.png: Added.
* platform/chromium-win-xp/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
* platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
* platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
* platform/chromium-win-xp/fast/repaint/shadow-multiple-vertical-expected.png: Added.
* platform/chromium-win-xp/fast/repaint/transform-replaced-shadows-expected.png: Added.
* platform/chromium-win-xp/fast/transforms/shadows-expected.png: Added.
* platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/shadows: Added.
* platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png: Added.
* platform/chromium-win-xp/svg/css/group-with-shadow-expected.png:
* platform/chromium-win-xp/svg/filters/shadow-on-rect-with-filter-expected.png:
* platform/chromium-win/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png:
* platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.png:
* platform/chromium-win/fast/box-shadow/single-pixel-shadow-expected.png:
* platform/chromium-win/fast/canvas/canvas-incremental-repaint-expected.png:
* platform/chromium-win/fast/canvas/canvas-shadow-expected.txt: Added.
* platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
* platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
* platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
* platform/chromium-win/fast/repaint/transform-replaced-shadows-expected.png:
* platform/chromium/TestExpectations:
* platform/chromium/fast/repaint/shadow-multiple-horizontal-expected.png: Removed.
* platform/chromium/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
* platform/chromium/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
* platform/efl-wk1/compositing/shadows: Added.
* platform/efl-wk1/compositing/shadows/shadow-drawing-expected.png: Added.
* platform/efl-wk1/fast/box-shadow: Added.
* platform/efl-wk1/fast/box-shadow/basic-shadows-expected.png: Added.
* platform/efl-wk1/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
* platform/efl-wk1/fast/box-shadow/box-shadow-transformed-expected.png: Added.
* platform/efl-wk1/fast/box-shadow/scaled-box-shadow-expected.png: Added.
* platform/efl-wk1/fast/canvas: Added.
* platform/efl-wk1/fast/canvas/canvas-incremental-repaint-expected.png: Added.
* platform/efl-wk1/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
* platform/efl-wk1/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
* platform/efl-wk1/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
* platform/efl-wk1/fast/repaint/shadow-multiple-vertical-expected.png: Added.
* platform/efl-wk1/fast/transforms: Added.
* platform/efl-wk1/fast/transforms/shadows-expected.png: Added.
* platform/efl-wk1/svg/css: Added.
* platform/efl-wk1/svg/css/group-with-shadow-expected.png: Added.
* platform/efl/compositing/shadows/shadow-drawing-expected.png: Removed.
* platform/efl/fast/box-shadow/basic-shadows-expected.png: Removed.
* platform/efl/fast/box-shadow/box-shadow-clipped-slices-expected.png: Removed.
* platform/efl/fast/box-shadow/box-shadow-transformed-expected.png: Removed.
* platform/efl/fast/box-shadow/scaled-box-shadow-expected.png: Removed.
* platform/efl/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
* platform/efl/fast/canvas/canvas-incremental-repaint-expected.png: Removed.
* platform/efl/fast/repaint/shadow-multiple-horizontal-expected.png: Removed.
* platform/efl/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
* platform/efl/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
* platform/efl/fast/repaint/shadow-multiple-vertical-expected.png: Removed.
* platform/efl/fast/transforms/shadows-expected.png: Removed.
* platform/efl/svg/css/group-with-shadow-expected.png: Removed.
* platform/gtk/fast/box-shadow/single-pixel-shadow-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFurther unreviewed build fix. Add explicit static_casts to avoid implicit precision...
jer.noble@apple.com [Thu, 15 Nov 2012 20:29:44 +0000 (20:29 +0000)]
Further unreviewed build fix. Add explicit static_casts to avoid implicit precision warnings.

* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::fulfillRequestWithResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStructure should be able to easily tell if the prototype chain might intercept a...
fpizlo@apple.com [Thu, 15 Nov 2012 20:20:02 +0000 (20:20 +0000)]
Structure should be able to easily tell if the prototype chain might intercept a store
https://bugs.webkit.org/show_bug.cgi?id=102326

Reviewed by Geoffrey Garen.

This improves our ability to reason about the correctness of the more optimized
prototype chain walk in JSObject::put(), while also making it straight forward to
check if the prototype chain will do strange things to a property store by just
looking at the structure.

* runtime/JSObject.cpp:
(JSC::JSObject::put):
* runtime/Structure.cpp:
(JSC::Structure::prototypeChainMayInterceptStoreTo):
(JSC):
* runtime/Structure.h:
(Structure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix. Avoid implicit precision and unused parameter warnings.
jer.noble@apple.com [Thu, 15 Nov 2012 20:04:21 +0000 (20:04 +0000)]
Unreviewed build fix. Avoid implicit precision and unused parameter warnings.

* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::responseReceived):
(WebCore::WebCoreAVFResourceLoader::fulfillRequestWithResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] We shouldn't call deprecated V8 APIs
abarth@webkit.org [Thu, 15 Nov 2012 20:01:20 +0000 (20:01 +0000)]
[V8] We shouldn't call deprecated V8 APIs
https://bugs.webkit.org/show_bug.cgi?id=102407

Reviewed by Eric Seidel.

This patch was written by Sven Panne on the V8 team. He would prefer
that we not call deprecated V8 APIs. This patch updates these call
sites to more modern idioms.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorGetter):
(GenerateImplementation):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::TestObjConstructorGetter):
* bindings/v8/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::addListener):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::setContextDebugId):
(WebCore::ScriptController::contextDebugId):
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::objectByHeapObjectId):
    - This code doesn't seem to do anything anymore.
* bindings/v8/V8DOMConfiguration.h:
(WebCore::V8DOMConfiguration::configureAttribute):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::setInjectedScriptContextDebugId):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::maybeDOMWrapper):
(WebCore::V8DOMWrapper::isWrapperOfType):
* bindings/v8/V8EventListenerList.h:
(WebCore::V8EventListenerList::doFindWrapper):
(WebCore::V8EventListenerList::findOrCreateWrapper):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initializeIfNeeded):
* bindings/v8/WrapperTypeInfo.h:
(WebCore::WrapperTypeInfo::unwrap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134800 and r134805.
commit-queue@webkit.org [Thu, 15 Nov 2012 19:59:56 +0000 (19:59 +0000)]
Unreviewed, rolling out r134800 and r134805.
http://trac.webkit.org/changeset/134800
http://trac.webkit.org/changeset/134805
https://bugs.webkit.org/show_bug.cgi?id=102417

This patch broke chromium port (Requested by jianli on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-15

Source/Platform:

* chromium/public/WebRTCPeerConnectionHandlerClient.h:
(WebRTCPeerConnectionHandlerClient):

Source/WebCore:

* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::createOffer):
(WebCore::RTCPeerConnection::createAnswer):
(WebCore::RTCPeerConnection::setLocalDescription):
(WebCore::RTCPeerConnection::localDescription):
(WebCore::RTCPeerConnection::setRemoteDescription):
(WebCore::RTCPeerConnection::remoteDescription):
(WebCore::RTCPeerConnection::updateIce):
(WebCore::RTCPeerConnection::addIceCandidate):
(WebCore::RTCPeerConnection::readyState):
(WebCore::RTCPeerConnection::iceState):
(WebCore::RTCPeerConnection::addStream):
(WebCore::RTCPeerConnection::close):
(WebCore::RTCPeerConnection::stop):
(WebCore::RTCPeerConnection::changeReadyState):
(WebCore::RTCPeerConnection::scheduledEventTimerFired):
* Modules/mediastream/RTCPeerConnection.h:
(RTCPeerConnection):
* Modules/mediastream/RTCPeerConnection.idl:
* dom/EventNames.h:
(WebCore):
* platform/mediastream/RTCDataChannelDescriptor.cpp:
(WebCore::RTCDataChannelDescriptor::RTCDataChannelDescriptor):
(WebCore::RTCDataChannelDescriptor::readyStateChanged):
* platform/mediastream/RTCPeerConnectionHandlerClient.h:
(RTCPeerConnectionHandlerClient):
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
(RTCPeerConnectionHandlerChromium):

Source/WebKit/chromium:

* src/AssertMatchingEnums.cpp:

Tools:

* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::openDataChannel):

LayoutTests:

* fast/mediastream/RTCPeerConnection-datachannel-expected.txt:
* fast/mediastream/RTCPeerConnection-datachannel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Do not mark an event (mouse wheel, scroll update) as handled if nothing...
commit-queue@webkit.org [Thu, 15 Nov 2012 19:57:07 +0000 (19:57 +0000)]
[chromium] Do not mark an event (mouse wheel, scroll update) as handled if nothing was scrolled.
https://bugs.webkit.org/show_bug.cgi?id=102246

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-11-15
Reviewed by James Robinson.

* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
* tests/WebCompositorInputHandlerImplTest.cpp:
(MockWebInputHandlerClient):
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Animate changes to viewport due to input focus changes.
commit-queue@webkit.org [Thu, 15 Nov 2012 19:55:12 +0000 (19:55 +0000)]
[BlackBerry] Animate changes to viewport due to input focus changes.
https://bugs.webkit.org/show_bug.cgi?id=102410

Patch by Andrew Lo <anlo@rim.com> on 2012-11-15
Reviewed by Rob Buis.

When changing scroll position or zoom level for input field focus,
animate the change.
Internal PR 231937

Internally reviewed by Mike Fenton.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove Node::aboutToUnload and be more explicit about what it was for
commit-queue@webkit.org [Thu, 15 Nov 2012 19:39:50 +0000 (19:39 +0000)]
Remove Node::aboutToUnload and be more explicit about what it was for
https://bugs.webkit.org/show_bug.cgi?id=102357

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-15
Reviewed by Ryosuke Niwa.

Node::aboutToUnload was confusingly named because it was only called on
the focused node, and it really only existed to support notifying the
embedder that inputs should stop being editable on unload. Instead add
a new method to HTMLInputElement that ends editing and call that
explicitly in the FrameLoader so it's clear what this is about.

No new tests, this is just a refactoring.

* dom/Node.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::endEditing):
    New method that handles finishing editing.
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleBlurEvent):
    Use the new method to reduce code duplication.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading):
    Be explicit about what this check was for.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] MediaStream API: Add missing WebRTCPeerConnectionHandlerClient::didAddRemo...
tommyw@google.com [Thu, 15 Nov 2012 19:22:49 +0000 (19:22 +0000)]
[chromium] MediaStream API: Add missing WebRTCPeerConnectionHandlerClient::didAddRemoteDataChannel
https://bugs.webkit.org/show_bug.cgi?id=102386

Reviewed by Adam Barth.

Source/Platform:

* chromium/public/WebRTCPeerConnectionHandlerClient.h:
(WebRTCPeerConnectionHandlerClient):

Source/WebCore:

Existing tests expanded to cover patch.

* platform/mediastream/RTCDataChannelDescriptor.cpp:
(WebCore::RTCDataChannelDescriptor::RTCDataChannelDescriptor):
(WebCore::RTCDataChannelDescriptor::readyStateChanged):
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
(WebCore::RTCPeerConnectionHandlerChromium::didAddRemoteDataChannel):
(WebCore):
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
(WebKit):
(RTCPeerConnectionHandlerChromium):

Tools:

Adding mock data channel functionality.

* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::openDataChannel):

LayoutTests:

* fast/mediastream/RTCPeerConnection-datachannel.html:
* fast/mediastream/RTCPeerConnection-datachannel-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNo tests for changing mouse cursors
commit-queue@webkit.org [Thu, 15 Nov 2012 19:15:17 +0000 (19:15 +0000)]
No tests for changing mouse cursors
https://bugs.webkit.org/show_bug.cgi?id=100550

Patch by Rick Byers <rbyers@chromium.org> on 2012-11-15
Reviewed by Brent Fulgham.

.:

Add necessary exports for Internals::getCurrentCursorInfo

* Source/autotools/symbols.filter:

Source/WebCore:

Add infrastructure to keep track of the last set mouse cursor,
and then to query it from DumpRenderTree.  Also adds ASSERTs to help ensure
we can reliably detect when an uninitialized Cursor object is used (such as
the one that can be returned from OptionalCursor in the NoCursorChange scenario).

Test: fast/events/mouse-cursor.html

* WebCore.exp.in: Add Cursor copy ctor export
* page/EventHandler.cpp:
(WebCore::OptionalCursor::cursor):
(WebCore::EventHandler::handleMouseMoveEvent): Keep track of last set mouse cursor
* page/EventHandler.h:
(WebCore::EventHandler::currentMouseCursor): New getter for last set mouse cursor
* platform/Cursor.h:
(WebCore::Cursor::Cursor): Mark uninitialized cursor types as invalid.
(WebCore::Cursor::type): Assert cursor type is valid.
* testing/Internals.cpp:
(WebCore::cursorTypeToString): Helper to convert cursor type to enum
(WebCore):
(WebCore::Internals::getCurrentCursorInfo): New function to return a string describing the last set mouse cursor
* testing/Internals.h: Declare getCurrentCursorInfo
* testing/Internals.idl: Declare getCurrentCursorInfo

Source/WebKit2:

Add necessary exports for Internals::getCurrentCursorInfo

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

Add a simple test covering the basic scenarios of changing a mouse
cursor with CSS.  This includes most of the cases currently covered
by ManualTests/*cursor*.

* fast/events/mouse-cursor-expected.txt: Added.
* fast/events/mouse-cursor.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSupport loading of blob URLs in AVFoundation.
jer.noble@apple.com [Thu, 15 Nov 2012 19:08:54 +0000 (19:08 +0000)]
Support loading of blob URLs in AVFoundation.
https://bugs.webkit.org/show_bug.cgi?id=102182

Reviewed by Eric Carlson.

Source/WebCore:

Add support for BLOB (and other non-natively supported schemed) URLs through the AVAssetResourceLoader API.

Test: media/video-src-blob.html

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource): Only go down the encrypted
    media path if the key scheme is skp://.
(WebCore::MediaPlayerPrivateAVFoundationObjC::didCancelLoadingRequest): Added.  Cancel resource loading if
    the media engine requests it.
(WebCore::MediaPlayerPrivateAVFoundationObjC::addKey): Use the new, non-deprecated API.

Use the dispatch_main_queue() as the AVAssetResourceLoadDelegate queue now that <rdar://problem/12362461> is fixed.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForLoadingOfRequestedResource:]):
(-[WebCoreAVFLoaderDelegate resourceLoader:didCancelLoadingRequest:]):

Add a new helper class to manage loading the CachedRawResource and feed the incoming
data to the AVAssetResourceLoader.
* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h: Added.
* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm: Added.
(WebCore::WebCoreAVFResourceLoader::create): Simple factory.
(WebCore::WebCoreAVFResourceLoader::WebCoreAVFResourceLoader): Simple constructor.
(WebCore::WebCoreAVFResourceLoader::~WebCoreAVFResourceLoader): Simple destructor.
(WebCore::WebCoreAVFResourceLoader::startLoading): Tell the cachedResourceLoader to schedule loading.
(WebCore::WebCoreAVFResourceLoader::stopLoading): Remove this as a client of the resource.
(WebCore::WebCoreAVFResourceLoader::responseReceived): Fill in the contentInformation field of the
    AVAssetResourceLoadingRequest.
(WebCore::WebCoreAVFResourceLoader::dataReceived): Call fulfillRequestWithResource.
(WebCore::WebCoreAVFResourceLoader::notifyFinished): Tell the AVAssetResourceLoadingRequest that loading
    has completed.
(WebCore::WebCoreAVFResourceLoader::fulfillRequestWithResource): Fill in (if possible) the dataRequest
    field of the AVAssetResourceLoadingRequest.

Add a MediaPlayerClient method allowing MediaPlayerPrivate subclasses to access the HTMLMediaElement's
document's cachedResourceLoader.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerCachedResourceLoader):
* html/HTMLMediaElement.h:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::cachedResourceLoader):
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerCachedResourceLoader):

Add a convenience method to convert from MIME type -> UTI.
* platform/network/mac/UTIUtilities.h:
* platform/network/mac/UTIUtilities.mm:
(WebCore::UTIFromMIMEType):

Add new files to project.
* WebCore.xcodeproj/project.pbxproj:

LayoutTests:

Add a new test which verifies blob url support in video elements.

* media/video-src-blob-expected.txt: Added.
* media/video-src-blob.html: Added.
* platform/mac/TestExpectations: Add expected failure results for OSX releases where
    custom media loading is not supported.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove initiallyFitToViewport attribute
kenneth@webkit.org [Thu, 15 Nov 2012 19:06:03 +0000 (19:06 +0000)]
Remove initiallyFitToViewport attribute
https://bugs.webkit.org/show_bug.cgi?id=102392

Reviewed by Noam Rosenthal.

Remove the initiallyFitToViewport which shouldn't have been
added in the first place. We now reset userScalable to auto (-1)
in case it was not explicitly set by the web author.

Same behavior, covered by existing tests.

Source/WebCore:

* dom/ViewportArguments.cpp:
(WebCore::ViewportArguments::resolve):
* dom/ViewportArguments.h:
(ViewportAttributes):

Source/WebKit2:

* UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::pageTransitionViewportReady):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::sendViewportAttributesChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream API: Update RTCPeerConnection states to match the latest editors draft
tommyw@google.com [Thu, 15 Nov 2012 19:01:40 +0000 (19:01 +0000)]
MediaStream API: Update RTCPeerConnection states to match the latest editors draft
https://bugs.webkit.org/show_bug.cgi?id=102382

Reviewed by Adam Barth.

Source/Platform:

Adding a callback for the new RTCPeerConnection::iceGatheringState.

* chromium/public/WebRTCPeerConnectionHandlerClient.h:
(WebKit::WebRTCPeerConnectionHandlerClient::didChangeICEGatheringState):

Source/WebCore:

Updating readyState & iceState, and adding iceGatheringState.
Also safeguarding the event timer callback.

Patch covered by existing tests.

* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::createOffer):
(WebCore::RTCPeerConnection::createAnswer):
(WebCore::RTCPeerConnection::setLocalDescription):
(WebCore::RTCPeerConnection::localDescription):
(WebCore::RTCPeerConnection::setRemoteDescription):
(WebCore::RTCPeerConnection::remoteDescription):
(WebCore::RTCPeerConnection::updateIce):
(WebCore::RTCPeerConnection::addIceCandidate):
(WebCore::RTCPeerConnection::readyState):
(WebCore::RTCPeerConnection::iceGatheringState):
(WebCore):
(WebCore::RTCPeerConnection::iceState):
(WebCore::RTCPeerConnection::addStream):
(WebCore::RTCPeerConnection::close):
(WebCore::RTCPeerConnection::didChangeIceGatheringState):
(WebCore::RTCPeerConnection::stop):
(WebCore::RTCPeerConnection::changeReadyState):
(WebCore::RTCPeerConnection::scheduledEventTimerFired):
* Modules/mediastream/RTCPeerConnection.h:
(RTCPeerConnection):
* Modules/mediastream/RTCPeerConnection.idl:
* dom/EventNames.h:
(WebCore):
* platform/mediastream/RTCPeerConnectionHandlerClient.h:
(RTCPeerConnectionHandlerClient):
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
(WebCore::RTCPeerConnectionHandlerChromium::didChangeICEGatheringState):
(WebCore):
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
(RTCPeerConnectionHandlerChromium):

Source/WebKit/chromium:

Updating readyState & iceState, and adding iceGatheringState.

* src/AssertMatchingEnums.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134649 and r134665.
commit-queue@webkit.org [Thu, 15 Nov 2012 19:00:12 +0000 (19:00 +0000)]
Unreviewed, rolling out r134649 and r134665.
http://trac.webkit.org/changeset/134649
http://trac.webkit.org/changeset/134665
https://bugs.webkit.org/show_bug.cgi?id=102413

Broke a ton of downstream chromium tests (Requested by japhet
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-15

Source/WebCore:

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::~DocumentLoader):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::clearMainResourceLoader):
(WebCore::DocumentLoader::isLoadingInAPISense):
(WebCore::DocumentLoader::documentURL):
(WebCore::DocumentLoader::isLoadingMainResource):
(WebCore::DocumentLoader::startLoadingMainResource):
* loader/DocumentLoader.h:
(DocumentLoader):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::init):
* loader/FrameLoaderStateMachine.cpp:
(WebCore::FrameLoaderStateMachine::FrameLoaderStateMachine):
* loader/FrameLoaderStateMachine.h:
* loader/MainResourceLoader.cpp:
(WebCore::shouldLoadAsEmptyDocument):
(WebCore):
(WebCore::MainResourceLoader::continueAfterContentPolicy):
(WebCore::MainResourceLoader::didReceiveResponse):
(WebCore::MainResourceLoader::didFinishLoading):
(WebCore::MainResourceLoader::handleEmptyLoad):
(WebCore::MainResourceLoader::loadNow):
(WebCore::MainResourceLoader::load):
* loader/MainResourceLoader.h:
(MainResourceLoader):

Tools:

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::updateForCommittedLoad):

LayoutTests:

* http/tests/inspector/network/network-iframe-load-and-delete.html:
* http/tests/loading/redirect-methods-expected.txt:
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCorrect syntax of old-style IDL files
haraken@chromium.org [Thu, 15 Nov 2012 18:56:17 +0000 (18:56 +0000)]
Correct syntax of old-style IDL files
https://bugs.webkit.org/show_bug.cgi?id=102335

Reviewed by Adam Barth.

Recently tasak@ corrected an IDL syntax of almost all IDL files.
We should correct the rest of them.

No tests. No change in behavior.

* html/canvas/OESElementIndexUint.idl:
* page/PerformanceMark.idl:
* page/PerformanceMeasure.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWindows Fibers can corrupt the cached StackBounds
mhahnenberg@apple.com [Thu, 15 Nov 2012 18:53:20 +0000 (18:53 +0000)]
Windows Fibers can corrupt the cached StackBounds
https://bugs.webkit.org/show_bug.cgi?id=102411

Reviewed by Geoffrey Garen.

Windows has support for something called fibers, which are like lightweight versions of
threads. Multiple fibers can run within the context of a single thread and they have access
to the same thread local storage but have different stacks. If we create a new JSGlobalContext
on one fiber, then switch to another fiber and create a JSGlobalContext there, we will call
initializeThreading() once for each new JSGlobalContext created. However, since these fibers
are technically running inside the same thread, they will clobber each other's wtfThreadData(),
which is stored using thread local storage. This can lead to corruption of the WTFThreadData
structure for the fibers other than the last one to create a new JSGlobalContext, including
the StackBounds data structure which is used during conservative scanning, among other things.
This can lead to crashes during garbage collection on Windows if fibers are used.

A quick fix would be to always get a fresh StackBounds data structure when asking for it
instead of using the cached version from the thread local storage. There is a larger problem
in that these fibers can corrupt other WebKit data that uses thread local storage. We'll leave
those theoretical fixes for future theoretical bugs.

* wtf/WTFThreadData.h:
(WTF::WTFThreadData::stack): We now refresh the m_stackBounds field whenever somebody asks for
the StackBounds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse correct unscaled document size when calculating scale limits
commit-queue@webkit.org [Thu, 15 Nov 2012 18:41:52 +0000 (18:41 +0000)]
Use correct unscaled document size when calculating scale limits
https://bugs.webkit.org/show_bug.cgi?id=102028

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-11-15
Reviewed by Adam Barth.

Fixes bug http://crbug.com/160581
Using contentsSize / pageScaleFactor as unscaled contents size results
in rounding errors. This can cause scale factor to oscillate indefinitely.

* src/WebViewImpl.cpp:
(WebKit::unscaledContentsSize):
(WebKit):
(WebKit::WebViewImpl::computePageScaleFactorLimits):
* tests/WebFrameTest.cpp:
* tests/data/scale_oscillate.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Don't restore zoom and scroll when leaving an input field.
mifenton@rim.com [Thu, 15 Nov 2012 18:40:35 +0000 (18:40 +0000)]
[BlackBerry] Don't restore zoom and scroll when leaving an input field.
https://bugs.webkit.org/show_bug.cgi?id=102376

Reviewed by Yong Li.

Restoring the zoom causes undesirable behavior when switching between fields.

Reviewed Internally by Andrew Lo.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
* WebKitSupport/InputHandler.h:
(InputHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Remove isHTMLInputElement since it's unused and toInputElement exists
commit-queue@webkit.org [Thu, 15 Nov 2012 18:33:31 +0000 (18:33 +0000)]
Source/WebCore: Remove isHTMLInputElement since it's unused and toInputElement exists
https://bugs.webkit.org/show_bug.cgi?id=102358

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-15
Reviewed by Ojan Vafai.

Remove isHTMLInputElement as no one uses it. Everyone just uses
Node::toInputElement and checks for a 0 return value instead.

toInputElement is also more reliable as there's no requirement that
subclasses of HTMLInputElement have the tag name of inputTag so using
this method in a check could potentially miss future subclasses with
different tag names, though none exist right now.

No new tests, this just deletes dead code.

* html/HTMLInputElement.h:

Source/WebKit/chromium: [chromium] Move allowWebGL query to WebFrameClient
https://bugs.webkit.org/show_bug.cgi?id=102319

Patch by Kenneth Russell <kbr@google.com> on 2012-11-15
Reviewed by Adam Barth.

Moved allowWebGL query to WebFrameClient to avoid polluting
content/ API.

* public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::allowWebGL):
* public/WebPermissionClient.h:
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::allowWebGL):

LayoutTests: Unreviewed: Skipping http/tests/security/sandboxed-iframe-form-top.html
https://bugs.webkit.org/show_bug.cgi?id=102391

This test is leaking state into the following test. Skipping it here,
and will look for a fix in 85522 (oooooold!).

Patch by Mike West <mkwst@chromium.org> on 2012-11-15

* platform/mac/TestExpectations:
    Skip sandboxed-iframe-form-top.html
* platform/max/http/tests/security/sandboxed-iframe-origin-add-expected.txt:
    We're no longer leaking into this test; remove the platform specific
    results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMake] Do not regenerate LLIntAssembly.h on every incremental build
commit-queue@webkit.org [Thu, 15 Nov 2012 18:18:42 +0000 (18:18 +0000)]
[CMake] Do not regenerate LLIntAssembly.h on every incremental build
https://bugs.webkit.org/show_bug.cgi?id=102248

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-15
Reviewed by Kenneth Rohde Christiansen.

Update LLIntAssembly.h's mtime after running asm.rb to make the build
system dependency tracking consistent.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate DOMException name: NotSupportedError
arv@chromium.org [Thu, 15 Nov 2012 18:17:26 +0000 (18:17 +0000)]
Update DOMException name: NotSupportedError
https://bugs.webkit.org/show_bug.cgi?id=102139

Reviewed by Ojan Vafai.

Source/WebCore:

Patch 9 of 25 to update DOMException name to match the spec and Firefox.

Updated existing tests.

* dom/DOMCoreException.cpp:

LayoutTests:

Updated tests and expectations.

* editing/pasteboard/data-transfer-items-expected.txt:
* fast/canvas/canvas-2d-imageData-create-nonfinite-expected.txt:
* fast/canvas/canvas-createImageData-expected.txt:
* fast/canvas/canvas-getImageData-invalid-expected.txt:
* fast/canvas/canvas-putImageData-expected.txt:
* fast/canvas/canvas-putImageData.js:
* fast/canvas/linearGradient-infinite-values-expected.txt:
* fast/canvas/radialGradient-infinite-values-expected.txt:
* fast/canvas/resources/canvas-2d-imageData-create-nonfinite.js:
* fast/canvas/script-tests/canvas-createImageData.js:
* fast/canvas/script-tests/canvas-getImageData-invalid.js:
* fast/canvas/script-tests/linearGradient-infinite-values.js:
* fast/canvas/script-tests/radialGradient-infinite-values.js:
* fast/dom/HTMLMeterElement/script-tests/set-meter-properties.js:
* fast/dom/HTMLMeterElement/set-meter-properties-expected.txt:
* fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js:
* fast/dom/HTMLProgressElement/set-progress-properties-expected.txt:
* fast/dom/Node/initial-values-expected.txt:
* fast/dom/importNode-null-expected.txt:
* fast/dynamic/insertAdjacentText-expected.txt:
* fast/forms/date/input-valueasnumber-date-expected.txt:
* fast/forms/date/input-valueasnumber-date.html:
* fast/forms/datetime/input-valueasnumber-datetime-expected.txt:
* fast/forms/datetime/input-valueasnumber-datetime.html:
* fast/forms/datetimelocal/input-valueasnumber-datetimelocal-expected.txt:
* fast/forms/datetimelocal/input-valueasnumber-datetimelocal.html:
* fast/forms/month/input-valueasnumber-month-expected.txt:
* fast/forms/month/input-valueasnumber-month.html:
* fast/forms/number/number-valueasnumber-expected.txt:
* fast/forms/number/number-valueasnumber.html:
* fast/forms/range/input-valueasnumber-range-expected.txt:
* fast/forms/range/input-valueasnumber-range.html:
* fast/forms/time/time-valueasnumber-expected.txt:
* fast/forms/time/time-valueasnumber.html:
* fast/forms/week/input-valueasnumber-week-expected.txt:
* fast/forms/week/input-valueasnumber-week.html:
* fast/mediastream/RTCPeerConnection-expected.txt:
* fast/mediastream/argument-types-expected.txt:
* fast/mediastream/getusermedia-expected.txt:
* fast/mediastream/script-tests/argument-types.js:
* http/tests/media/media-source/video-media-source-add-and-remove-buffers-expected.txt:
* platform/chromium/canvas/philip/tests/2d.missingargs-expected.txt:
* platform/chromium/dom/xhtml/level3/core/documentsetxmlversion03-expected.txt:
* platform/chromium/fast/dynamic/insertAdjacentElement-expected.txt:
* platform/efl/fast/dynamic/insertAdjacentElement-expected.txt:
* platform/gtk/fast/dynamic/insertAdjacentElement-expected.txt:
* platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:
* platform/mac/fast/dynamic/insertAdjacentElement-expected.txt:
* platform/qt/fast/dynamic/insertAdjacentElement-expected.txt:
* svg/dom/SVGAngle-expected.txt:
* svg/dom/SVGLength-expected.txt:
* svg/dom/SVGLength-px-expected.txt:
* svg/dom/SVGPreserveAspectRatio-expected.txt:
* transforms/cssmatrix-2d-interface-expected.txt:
* transforms/cssmatrix-3d-interface-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix an erroneous comment about the operators required by binarySearch
mjs@apple.com [Thu, 15 Nov 2012 18:15:39 +0000 (18:15 +0000)]
Fix an erroneous comment about the operators required by binarySearch
https://bugs.webkit.org/show_bug.cgi?id=102406

Reviewed by Anders Carlsson.

* wtf/StdLibExtras.h: binarySearch needs '==' and '<', not '--', '<' and '>'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove isHTMLInputElement since it's unused and toInputElement exists
commit-queue@webkit.org [Thu, 15 Nov 2012 18:13:54 +0000 (18:13 +0000)]
Remove isHTMLInputElement since it's unused and toInputElement exists
https://bugs.webkit.org/show_bug.cgi?id=102358

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-15
Reviewed by Ojan Vafai.

Remove isHTMLInputElement as no one uses it. Everyone just uses
Node::toInputElement and checks for a 0 return value instead.

toInputElement is also more reliable as there's no requirement that
subclasses of HTMLInputElement have the tag name of inputTag so using
this method in a check could potentially miss future subclasses with
different tag names, though none exist right now.

No new tests, this just deletes dead code.

* html/HTMLInputElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed: Skipping http/tests/security/sandboxed-iframe-form-top.html
mkwst@chromium.org [Thu, 15 Nov 2012 18:13:15 +0000 (18:13 +0000)]
Unreviewed: Skipping http/tests/security/sandboxed-iframe-form-top.html
https://bugs.webkit.org/show_bug.cgi?id=102391

This test is leaking state into the following test. Skipping it here,
and will look for a fix in 85522 (oooooold!).

* platform/mac/TestExpectations:
    Skip sandboxed-iframe-form-top.html
* platform/max/http/tests/security/sandboxed-iframe-origin-add-expected.txt:
    We're no longer leaking into this test; remove the platform specific
    results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Fix suspend/resume assertion in setCompositor().
jpetsovits@rim.com [Thu, 15 Nov 2012 17:57:42 +0000 (17:57 +0000)]
[BlackBerry] Fix suspend/resume assertion in setCompositor().
https://bugs.webkit.org/show_bug.cgi?id=102397
RIM PR 244701

Reviewed by Adam Treat.

If a compositor is used but no surface pool is ever
allocated (which is a perfectly valid use case), initial
suspension of the backingstore is skipped because of an
early return. This will cause an assertion to be triggered
and a bug. Fix this by suspending it before the return.

With Adam Treat's recent change to split suspension of
screen and backingstore into two different functions,
this can now be reduced to a mere screen (blitting)
suspension. That was the original intention of this code.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setCompositor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Thu, 15 Nov 2012 17:37:23 +0000 (17:37 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-15

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate my e-mail address.
akling@apple.com [Thu, 15 Nov 2012 17:16:56 +0000 (17:16 +0000)]
Update my e-mail address.

Rubber-stamped by Anders Koivisto.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate DOMException name: NoModificationAllowedError
arv@chromium.org [Thu, 15 Nov 2012 17:08:49 +0000 (17:08 +0000)]
Update DOMException name: NoModificationAllowedError
https://bugs.webkit.org/show_bug.cgi?id=102134

Reviewed by Ojan Vafai.

Source/WebCore:

Patch 7 of 25 to update DOMException name to match the spec and Firefox.

Updated existing tests.

* dom/DOMCoreException.cpp:

LayoutTests:

Updated tests and expectations.

* dom/xhtml/level1/core/hc_nodevalue03-expected.txt:
* fast/dom/EntityReference/readonly-exceptions-expected.txt:
* fast/dom/HTMLElement/insertAdjacentHTML-errors-expected.txt:
* fast/dom/HTMLElement/script-tests/insertAdjacentHTML-errors.js:
* fast/dom/computed-style-set-property-expected.txt:
* fast/dom/insertAdjacentHTML-DocumentFragment-crash-expected.txt:
* fast/dom/outerText-no-element-expected.txt:
* fast/dom/setPrimitiveValue-exceptions-expected.txt:
* fast/dom/setPrimitiveValue-expected.txt:
* fast/dynamic/outerHTML-no-element-expected.txt:
* fast/frames/out-of-document-iframe-has-child-frame-expected.txt:
* platform/chromium-mac/fast/dom/setPrimitiveValue-exceptions-expected.txt:
* platform/chromium-win/fast/dom/setPrimitiveValue-exceptions-expected.txt:
* platform/chromium-win/svg/custom/baseval-animval-equality-expected.txt:
* platform/chromium/fast/dom/insertAdjacentHTML-DocumentFragment-crash-expected.txt:
* platform/chromium/fast/frames/out-of-document-iframe-has-child-frame-expected.txt:
* platform/chromium/svg/custom/baseval-animval-equality-expected.txt:
* platform/gtk/svg/custom/baseval-animval-equality-expected.txt:
* platform/mac/svg/custom/baseval-animval-equality-expected.txt:
* platform/qt/svg/custom/baseval-animval-equality-expected.txt:
* platform/qt/svg/dom/altGlyph-dom-expected.txt:
* svg/animations/animate-gradient-transform-expected.txt:
* svg/dom/SVGColor-expected.txt:
* svg/dom/SVGLengthList-basics-expected.txt:
* svg/dom/SVGNumberList-basics-expected.txt:
* svg/dom/SVGPaint-expected.txt:
* svg/dom/SVGTransformList-basics-expected.txt:
* svg/dom/SVGViewSpec-defaults-expected.txt:
* svg/dom/altGlyph-dom-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unnecesary dependencies INPUT_TYPE_COLOR
commit-queue@webkit.org [Thu, 15 Nov 2012 17:06:49 +0000 (17:06 +0000)]
Remove unnecesary dependencies INPUT_TYPE_COLOR
https://bugs.webkit.org/show_bug.cgi?id=102379

Patch by Miguel Garcia <miguelg@chromium.org> on 2012-11-15
Reviewed by Darin Adler.

Platforms should be able to enable INPUT_TYPE_COLOR without enabling
CALENDAR_PICKER and DATALIST_ELEMENT. Before this patch however there would be
compile errors in such configuration.

No new tests since this is not adding any extra functionality.

* WebCore.gyp/WebCore.gyp:
* html/ColorInputType.cpp:
(WebCore::ColorInputType::shouldShowSuggestions):
* make-file-arrays.py:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate computed line position algorithm
eric.carlson@apple.com [Thu, 15 Nov 2012 17:05:29 +0000 (17:05 +0000)]
Update computed line position algorithm
https://bugs.webkit.org/show_bug.cgi?id=93779

Reviewed by Philippe Normand.

Compute the position of a text track relative to rendered tracks. This is needed to position
cues correctly when there is more than one text track.

Source/WebCore:

Test: media/track/track-cue-container-rendering-position.html

* html/track/TextTrack.cpp:
(WebCore::TextTrack::invalidateTrackIndex): Invalidate both cached track indices.
(WebCore::TextTrack::trackIndexRelativeToRenderedTracks): Return the index of the track relative
    to other rendered tracks.
* html/track/TextTrack.h:

* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::calculateComputedLinePosition): Use trackIndexRelativeToRenderedTracks()
    instead of trackIndex() so cues are positioned correctly.

* html/track/TextTrackList.cpp:
(TextTrackList::getTrackIndex): Change return type from unsigned to int.
(TextTrackList::getTrackIndexRelativeToRenderedTracks): New.
* html/track/TextTrackList.h:

LayoutTests:

* media/track/track-cue-container-rendering-position-expected.txt: Added.
* media/track/track-cue-container-rendering-position.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Leave surface resizing to the client.
jpetsovits@rim.com [Thu, 15 Nov 2012 17:02:27 +0000 (17:02 +0000)]
[BlackBerry] Leave surface resizing to the client.
https://bugs.webkit.org/show_bug.cgi?id=102280
RIM PR 235034
RIM PR 160619

Reviewed by Adam Treat.

Now that we always blit on the user interface thread and
use the client's userInterfaceViewportAccessor() to determine
the destination rectangle for blitting, changing the viewport
size does not affect the window or target surface directly.
The only way that blitted output is affected is through
layout, scroll position or scale changes. None of these
require us to synchronize with the UI thread to resize its
target surface.

This commit simplifies setViewportSize() and removes a
blocking message dispatch by simply offloading all surface
resizing responsibilities to the client. This is safer,
cleaner and easier.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPage::setScreenOrientation):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
* Api/WebPage.h:
* Api/WebPageClient.h:
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Bump Harfbuzz to allow fixing bug 101009 on EFL
dominik.rottsches@intel.com [Thu, 15 Nov 2012 16:59:27 +0000 (16:59 +0000)]
[EFL] Bump Harfbuzz to allow fixing bug 101009 on EFL
https://bugs.webkit.org/show_bug.cgi?id=101323

Reviewed by Martin Robinson.

Source/WebCore:

Removing ifdef since we bumped Harfbuzz dependency. This is the
real fix replacing the previous workaround of having a Chromium
specific ifdef here, since Chromium uses a newer HarfBuzz version
already.

No new tests, covered by css3/flexbox/inline-flex-crash.html
which will not crash anymore even with the ifdef removed.

* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):

Tools:

Bumping Harfbuzz to newer version so that we can remove the
ifdef round the fix for bug 101009 for EFL, too.
We're using the zip snapshot since jhbuild can fallback to the previously
downloaded blob in case of network failures which leads to better
buildbot robustness. This zip snapshot currently needs to be locally
patched to fix ICU detection on systems that don't have icu pkg-config files.
The patch is suggested for merging into HarfBuzz. We can remove it locally
once it's accepted into HarfBuzz upstream.

* efl/patches/harfbuzz-icu-detection-fix.patch: Applied after retrieving source to fix harfbuzz detection on systems that don't have pkg-config files for it.
* efl/jhbuild.modules: Bumping harfbuzz version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] Implement WTR --no-timeout-at-all option
ap@apple.com [Thu, 15 Nov 2012 16:50:57 +0000 (16:50 +0000)]
[Mac] Implement WTR --no-timeout-at-all option
https://bugs.webkit.org/show_bug.cgi?id=102251

Reviewed by Eric Carlson.

* WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformRunUntil):
Just do it, and convert to Objective C on the way for simplicity.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r134408): Heap-use-after-free in WebCore::HTMLConstructionSite::mergeAttri...
kling@webkit.org [Thu, 15 Nov 2012 16:35:30 +0000 (16:35 +0000)]
REGRESSION(r134408): Heap-use-after-free in WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement().
<http://webkit.org/b/102304>

Reviewed by Anders Carlsson.

Source/WebCore:

Test: fast/dom/cloneNode-below-body-attribute-merging.html

* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):

    Use Element::fastHasAttribute() to determine if a given attribute is already present on the element
    we're merging attributes into.

* dom/ElementAttributeData.h:
(ElementAttributeData):

    Remove a now-unnecessary friend declaration.

LayoutTests:

* fast/dom/cloneNode-below-body-attribute-merging-expected.txt: Added.
* fast/dom/cloneNode-below-body-attribute-merging.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Move SK_DISABLE_FAST_AA_STROKE_RECT to skia_webkit.gyp
schenney@chromium.org [Thu, 15 Nov 2012 16:11:02 +0000 (16:11 +0000)]
[Chromium] Move SK_DISABLE_FAST_AA_STROKE_RECT to skia_webkit.gyp

Unreviewed non-funtional, behavior-neutral change

* skia_webkit.gyp: Add SK_DISABLE_FAST_AA_STROKE_RECT=1 so that it can be removed from Chromium's skia.gyp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCleanup test expectations after rebaseline r134668
junov@google.com [Thu, 15 Nov 2012 15:48:56 +0000 (15:48 +0000)]
Cleanup test expectations after rebaseline r134668
https://bugs.webkit.org/show_bug.cgi?id=101974

Unreviewed

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening.
rakuco@webkit.org [Thu, 15 Nov 2012 15:46:01 +0000 (15:46 +0000)]
[EFL] Gardening.

Move some expectations from efl-wk1/ to efl/ since they should
work for both ports (and were originally there).

Skip an additional HiDPI test.

* platform/efl-wk1/fast/borders: Removed.
* platform/efl-wk1/fast/borders/border-radius-wide-border-01-expected.png: Removed.
* platform/efl-wk1/fast/borders/borderRadiusInset01-expected.png: Removed.
* platform/efl-wk1/fast/css: Removed.
* platform/efl-wk1/fast/css/text-overflow-ellipsis-bidi-expected.png: Removed.
* platform/efl-wk1/fast/css/text-overflow-ellipsis-expected.png: Removed.
* platform/efl-wk1/fast/css/text-overflow-ellipsis-strict-expected.png: Removed.
* platform/efl-wk1/fast/css/text-overflow-ellipsis-text-align-center-expected.png: Removed.
* platform/efl-wk1/fast/css/text-overflow-input-expected.png: Removed.
* platform/efl-wk1/fast/css/text-overflow-input-expected.txt: Removed.
* platform/efl-wk1/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png: Removed.
* platform/efl-wk1/fast/forms/menulist-clip-expected.png: Removed.
* platform/efl-wk1/fast/forms/menulist-option-wrap-expected.png: Removed.
* platform/efl-wk1/fast/forms/select-empty-option-height-expected.png: Removed.
* platform/efl-wk1/fast/media: Removed.
* platform/efl-wk1/fast/media/mq-js-media-except-01-expected.png: Removed.
* platform/efl-wk1/fast/media/mq-js-media-except-01-expected.txt: Removed.
* platform/efl-wk1/fast/repaint/control-clip-expected.png: Removed.
* platform/efl-wk1/svg/dom: Removed.
* platform/efl-wk1/svg/dom/SVGLengthList-appendItem-expected.png: Removed.
* platform/efl-wk1/svg/dom/SVGLengthList-basics-expected.png: Removed.
* platform/efl-wk1/svg/dom/SVGLengthList-getItem-expected.png: Removed.
* platform/efl-wk1/svg/dom/SVGLengthList-initialize-expected.png: Removed.
* platform/efl-wk1/svg/dom/SVGLengthList-insertItemBefore-expected.png: Removed.
* platform/efl-wk1/svg/dom/SVGLengthList-removeItem-expected.png: Removed.
* platform/efl-wk1/svg/dom/SVGLengthList-replaceItem-expected.png: Removed.
* platform/efl-wk1/svg/dom/SVGNumberList-basics-expected.png: Removed.
* platform/efl-wk1/svg/dom/SVGTransformList-basics-expected.png: Removed.
* platform/efl/TestExpectations:
* platform/efl/fast/borders/border-radius-wide-border-01-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/borders/border-radius-wide-border-01-expected.png.
* platform/efl/fast/borders/border-radius-wide-border-05-expected.png: Added.
* platform/efl/fast/borders/borderRadiusInset01-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/borders/borderRadiusInset01-expected.png.
* platform/efl/fast/css/text-overflow-ellipsis-bidi-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/css/text-overflow-ellipsis-bidi-expected.png.
* platform/efl/fast/css/text-overflow-ellipsis-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/css/text-overflow-ellipsis-expected.png.
* platform/efl/fast/css/text-overflow-ellipsis-strict-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/css/text-overflow-ellipsis-strict-expected.png.
* platform/efl/fast/css/text-overflow-ellipsis-text-align-center-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/css/text-overflow-ellipsis-text-align-center-expected.png.
* platform/efl/fast/css/text-overflow-input-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/css/text-overflow-input-expected.png.
* platform/efl/fast/css/text-overflow-input-expected.txt: Copied from LayoutTests/platform/efl-wk1/fast/css/text-overflow-input-expected.txt.
* platform/efl/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png.
* platform/efl/fast/forms/menulist-clip-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/forms/menulist-clip-expected.png.
* platform/efl/fast/forms/menulist-option-wrap-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/forms/menulist-option-wrap-expected.png.
* platform/efl/fast/forms/select-empty-option-height-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/forms/select-empty-option-height-expected.png.
* platform/efl/fast/forms/zoomed-controls-expected.png: Added.
* platform/efl/fast/media/mq-js-media-except-01-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/media/mq-js-media-except-01-expected.png.
* platform/efl/fast/media/mq-js-media-except-01-expected.txt: Copied from LayoutTests/platform/efl-wk1/fast/media/mq-js-media-except-01-expected.txt.
* platform/efl/fast/repaint/control-clip-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/repaint/control-clip-expected.png.
* platform/efl/svg/dom/SVGLengthList-appendItem-expected.png: Copied from LayoutTests/platform/efl-wk1/svg/dom/SVGLengthList-appendItem-expected.png.
* platform/efl/svg/dom/SVGLengthList-basics-expected.png: Copied from LayoutTests/platform/efl-wk1/svg/dom/SVGLengthList-basics-expected.png.
* platform/efl/svg/dom/SVGLengthList-getItem-expected.png: Copied from LayoutTests/platform/efl-wk1/svg/dom/SVGLengthList-getItem-expected.png.
* platform/efl/svg/dom/SVGLengthList-initialize-expected.png: Copied from LayoutTests/platform/efl-wk1/svg/dom/SVGLengthList-initialize-expected.png.
* platform/efl/svg/dom/SVGLengthList-insertItemBefore-expected.png: Copied from LayoutTests/platform/efl-wk1/svg/dom/SVGLengthList-insertItemBefore-expected.png.
* platform/efl/svg/dom/SVGLengthList-removeItem-expected.png: Copied from LayoutTests/platform/efl-wk1/svg/dom/SVGLengthList-removeItem-expected.png.
* platform/efl/svg/dom/SVGLengthList-replaceItem-expected.png: Copied from LayoutTests/platform/efl-wk1/svg/dom/SVGLengthList-replaceItem-expected.png.
* platform/efl/svg/dom/SVGNumberList-basics-expected.png: Copied from LayoutTests/platform/efl-wk1/svg/dom/SVGNumberList-basics-expected.png.
* platform/efl/svg/dom/SVGTransformList-basics-expected.png: Copied from LayoutTests/platform/efl-wk1/svg/dom/SVGTransformList-basics-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPrevent creation of detached frames in ShadowRoot
commit-queue@webkit.org [Thu, 15 Nov 2012 15:42:48 +0000 (15:42 +0000)]
Prevent creation of detached frames in ShadowRoot
https://bugs.webkit.org/show_bug.cgi?id=102333

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-15
Reviewed by Dimitri Glazkov.

Source/WebCore:

Similar to Bug 94717 you can create a loaded iframe in a detached
subtree using ShadowRoot. To fix this we just need to make
SubframeLoadingDisabler traverse through shadow boundaries.

Test: fast/frames/detached-shadow-frame.html

* html/HTMLFrameOwnerElement.h:
(WebCore::SubframeLoadingDisabler::canLoadFrame):

LayoutTests:

Test that you cannot create a detached frame using a ShadowRoot
and iframe unload handlers.

* fast/frames/detached-shadow-frame-expected.txt: Added.
* fast/frames/detached-shadow-frame.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChanging pseudoClass (:visited) should cause distribution.
shinyak@chromium.org [Thu, 15 Nov 2012 15:28:52 +0000 (15:28 +0000)]
Changing pseudoClass (:visited) should cause distribution.
https://bugs.webkit.org/show_bug.cgi?id=101700

Reviewed by Dimitri Glazkov.

Source/WebCore:

When href attribute of an anchor or area element is changed, we have to invalidate distribution.

Since we would like to check a few pseudoClasses at once, we make the argument of
SelectRuleFeatureSet::hasSelectorFor int.

Tests: fast/dom/shadow/pseudoclass-update-visited-anchor.html
       fast/dom/shadow/pseudoclass-update-visited-area.html

* dom/ElementShadow.cpp:
(WebCore::invalidateParentDistributionIfNecessary):
* dom/ElementShadow.h:
(WebCore):
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parseAttribute):
* html/shadow/SelectRuleFeatureSet.h:
(WebCore::SelectRuleFeatureSet::hasSelectorFor):

LayoutTests:

* fast/dom/shadow/pseudoclass-update-visited-anchor-expected.html: Added.
* fast/dom/shadow/pseudoclass-update-visited-anchor.html: Added.
* fast/dom/shadow/pseudoclass-update-visited-area-expected.html: Added.
* fast/dom/shadow/pseudoclass-update-visited-area.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix attempt after r134765.
zandobersek@gmail.com [Thu, 15 Nov 2012 15:28:10 +0000 (15:28 +0000)]
Unreviewed build fix attempt after r134765.

* webkit/webkitviewportattributes.cpp:
(webkitViewportAttributesRecompute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCoordinated Graphics: support the "freeze animations" API
kbalazs@webkit.org [Thu, 15 Nov 2012 15:27:15 +0000 (15:27 +0000)]
Coordinated Graphics: support the "freeze animations" API
https://bugs.webkit.org/show_bug.cgi?id=100703

Reviewed by Noam Rosenthal.

Source/WebCore:

Make animations resumable in Coordinated Graphics.
Pausing was already implemented.

Tested with animations and transitions tests. No tests to be
unskipped because these tests has been working without this API
as well (although this is the preferred way).

* platform/graphics/GraphicsLayerAnimation.cpp:
(WebCore::GraphicsLayerAnimation::apply):
(WebCore::GraphicsLayerAnimation::computeTotalRunningTime):
Do not consider the time while we was suspended as part of
the total running time.
(WebCore):
(WebCore::GraphicsLayerAnimation::resume):
(WebCore::GraphicsLayerAnimations::suspend):
(WebCore::GraphicsLayerAnimations::resume):
* platform/graphics/GraphicsLayerAnimation.h:
(GraphicsLayerAnimation):
(GraphicsLayerAnimations):

Source/WebKit2:

Implement suspendAnimations and resumeAnimations in CoordinatedGraphicsLayer.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::suspendAnimations):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::resumeAnimations):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Disable SK_IGNORE_FAST_BLURRECT
schenney@chromium.org [Thu, 15 Nov 2012 15:06:47 +0000 (15:06 +0000)]
[Chromium] Disable SK_IGNORE_FAST_BLURRECT

Source/WebKit/chromium:

Unreviewed test update.

This flag is enabled purely to simplify rebaselining. I am now
removing it and doing the rebaslining.

* skia_webkit.gyp: Remove the line for SK_IGNORE_FAST_BLURRECT

LayoutTests:

Unreviewed test expectations update

* platform/chromium-linux/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-linux/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-linux/fast/box-shadow/box-shadow-clipped-slices-expected.png:
* platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.png:
* platform/chromium-linux/fast/box-shadow/single-pixel-shadow-expected.png:
* platform/chromium-linux/fast/canvas/canvas-incremental-repaint-expected.png:
* platform/chromium-linux/fast/repaint/box-shadow-h-expected.png:
* platform/chromium-linux/fast/repaint/box-shadow-v-expected.png:
* platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-linux/fast/transforms/shadows-expected.png:
* platform/chromium-linux/svg/css/group-with-shadow-expected.png:
* platform/chromium-linux/svg/filters/shadow-on-rect-with-filter-expected.png:
* platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png:
* platform/chromium-win/fast/box-shadow/scaled-box-shadow-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline after r134736
schenney@chromium.org [Thu, 15 Nov 2012 14:18:41 +0000 (14:18 +0000)]
Rebaseline after r134736

Unreviewed expectations update.

Very minor changes, not entirely clear why but not a problem at all.
Probably due to animation cauising an initial valeue to differ
slightly.

* platform/chromium-linux/compositing/checkerboard-expected.png:
* platform/chromium-mac/compositing/checkerboard-expected.png:
* platform/chromium-win/compositing/checkerboard-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Update pixel test expectation for datalist tests
commit-queue@webkit.org [Thu, 15 Nov 2012 14:13:23 +0000 (14:13 +0000)]
[EFL] Update pixel test expectation for datalist tests
https://bugs.webkit.org/show_bug.cgi?id=102365

Unreviewed EFL gardening.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-11-15

* platform/efl/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
* platform/efl/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r134495): It made svg/custom/use-instanceRoot-event-listeners.xhtml fail...
ossy@webkit.org [Thu, 15 Nov 2012 13:59:24 +0000 (13:59 +0000)]
REGRESSION(r134495): It made svg/custom/use-instanceRoot-event-listeners.xhtml fail and fast/events/attribute-listener-deletion-crash.html timeout
https://bugs.webkit.org/show_bug.cgi?id=102183

Unreviewed gardening, unskip now passing tests after r134666.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRelocate the ARM NEON SVG filter optimizations
rgabor@webkit.org [Thu, 15 Nov 2012 13:42:28 +0000 (13:42 +0000)]
Relocate the ARM NEON SVG filter optimizations
https://bugs.webkit.org/show_bug.cgi?id=102214

Reviewed by Zoltan Herczeg.

Relocate the ARM filter optimizations into platform/graphics/cpu/arm
to keep them together with the others.
From now all graphics optimization for ARM NEON should go here.

* CMakeLists.txt:
* GNUmakefile.am:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pri:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/cpu/arm/filters/FEBlendNEON.h: Renamed from Source/WebCore/platform/graphics/filters/arm/FEBlendNEON.h.
(WebCore):
(FEBlendUtilitiesNEON):
(WebCore::FEBlendUtilitiesNEON::div255):
(WebCore::FEBlendUtilitiesNEON::normal):
(WebCore::FEBlendUtilitiesNEON::multiply):
(WebCore::FEBlendUtilitiesNEON::screen):
(WebCore::FEBlendUtilitiesNEON::darken):
(WebCore::FEBlendUtilitiesNEON::lighten):
(WebCore::FEBlend::platformApplyNEON):
* platform/graphics/cpu/arm/filters/FECompositeArithmeticNEON.h: Renamed from Source/WebCore/platform/graphics/filters/arm/FECompositeArithmeticNEON.h.
(WebCore):
(WebCore::FEComposite::computeArithmeticPixelsNeon):
(WebCore::FEComposite::platformArithmeticNeon):
* platform/graphics/cpu/arm/filters/FEGaussianBlurNEON.h: Renamed from Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.h.
(WebCore):
(WebCore::boxBlurNEON):
* platform/graphics/cpu/arm/filters/FELightingNEON.cpp: Renamed from Source/WebCore/platform/graphics/filters/arm/FELightingNEON.cpp.
(WebCore):
(WebCore::feLightingConstantsForNeon):
(WebCore::FELighting::platformApplyNeonWorker):
(WebCore::FELighting::getPowerCoefficients):
* platform/graphics/cpu/arm/filters/FELightingNEON.h: Renamed from Source/WebCore/platform/graphics/filters/arm/FELightingNEON.h.
(WebCore):
(FELightingFloatArgumentsForNeon):
(FELightingPaintingDataForNeon):
(WebCore::FELighting::platformApplyNeon):
* platform/graphics/cpu/arm/filters/NEONHelpers.h: Renamed from Source/WebCore/platform/graphics/filters/arm/NEONHelpers.h.
(WebCore):
(WebCore::loadRGBA8AsFloat):
(WebCore::storeFloatAsRGBA8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWe should trigger a console warning when we encounter invalid sandbox flags.
mkwst@chromium.org [Thu, 15 Nov 2012 13:04:54 +0000 (13:04 +0000)]
We should trigger a console warning when we encounter invalid sandbox flags.
https://bugs.webkit.org/show_bug.cgi?id=101956

Reviewed by Adam Barth.

Source/WebCore:

A developer who writes '<iframe sandbox="allowScripts">' probably has
something in mind other than what the browser interprets. In these
situations, we should log a console warning that notes 'allowScripts'
is an invalid sandbox flag ('allow-scripts' is probably what she
meant).

This patch does the simplest thing possible: it throws a warning that
lists the invalid flags encountered for sandbox attributes on iframes,
and for sandbox Content Security Policy directives.

Tests: http/tests/security/contentSecurityPolicy/sandbox-invalid-header.html
       http/tests/security/sandboxed-iframe-invalid.html

* dom/SecurityContext.cpp:
(WebCore::SecurityContext::parseSandboxPolicy):
* dom/SecurityContext.h:
(SecurityContext):
    Accept a new out parameter, invalidTokensErrorMessage. If invalid
    tokens are encountered, build an error message string, and pass it
    back to the caller through this parameter.
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseAttribute):
* page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::applySandboxPolicy):
    When applying a sandbox policy, pass a string into
    SecurityContext::parseSandboxPolicy to grab any errors that might
    be encountered, and log a warning in that event.
(WebCore::ContentSecurityPolicy::reportInvalidSandboxFlags):
(WebCore):
* page/ContentSecurityPolicy.h:
    Adding a new method to report invalid sandbox flags.

LayoutTests:

* http/tests/security/contentSecurityPolicy/sandbox-invalid-header-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/sandbox-invalid-header.html: Added.
* http/tests/security/sandboxed-iframe-invalid-expected.txt: Added.
* http/tests/security/sandboxed-iframe-invalid.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename member vars in ViewportArgument to match css-device-adapt
kenneth@webkit.org [Thu, 15 Nov 2012 13:00:33 +0000 (13:00 +0000)]
Rename member vars in ViewportArgument to match css-device-adapt
https://bugs.webkit.org/show_bug.cgi?id=102355

Reviewed by Gyuyoung Kim.

Source/WebCore:

No behavior change, thus no new tests.

* dom/ViewportArguments.cpp:
(WebCore::ViewportArguments::resolve):
(WebCore::setViewportFeature):
* dom/ViewportArguments.h:
(WebCore::ViewportArguments::ViewportArguments):
(ViewportArguments):
(WebCore::ViewportArguments::operator==):

Source/WebKit/efl:

* ewk/ewk_view.cpp:
(_ewk_view_priv_new): Update to reflect name change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Add tests for month suggestion picker
keishi@webkit.org [Thu, 15 Nov 2012 12:46:23 +0000 (12:46 +0000)]
[Chromium] Add tests for month suggestion picker
https://bugs.webkit.org/show_bug.cgi?id=102040

Reviewed by Kent Tamura.

Adding tests for <input type=date> with datalist.

* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-appearance-expected.png: Added.
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png: Added.
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-key-operations-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/month-suggestion-appearance-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/month-suggestion-appearance.html: Added.
* platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl.html: Added.
* platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar.html: Added.
* platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-key-operations-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-key-operations.html: Added.
* platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-min-max-attribute-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-min-max-attribute.html: Added.
* platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-mouse-operations-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-mouse-operations.html: Added.
* platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-reset-value-after-reload-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-reset-value-after-reload.html: Added.
* platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-step-attribute-expected.txt: Added.
* platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-step-attribute.html: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix compiler warnings about signed/unsigned comparison on i386
commit-queue@webkit.org [Thu, 15 Nov 2012 12:45:53 +0000 (12:45 +0000)]
Fix compiler warnings about signed/unsigned comparison on i386
https://bugs.webkit.org/show_bug.cgi?id=102249

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-15
Reviewed by Kenneth Rohde Christiansen.

Add casting to unsigned to shut up gcc warnings. Build was broken on
JSVALUE32_64 ports compiling with -Werror.

* llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening after r134628
commit-queue@webkit.org [Thu, 15 Nov 2012 12:36:43 +0000 (12:36 +0000)]
[EFL] Gardening after r134628
https://bugs.webkit.org/show_bug.cgi?id=102368

Unreviewed gardening.

Skip test compositing/overflow/scrolling-without-painting.html added at r134628
and which does not pass on EFL.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-15

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [WebGL] cloneNode for images with revoked Blob URIs fails
commit-queue@webkit.org [Thu, 15 Nov 2012 12:23:42 +0000 (12:23 +0000)]
Web Inspector: [WebGL] cloneNode for images with revoked Blob URIs fails
https://bugs.webkit.org/show_bug.cgi?id=102366

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-15
Reviewed by Vsevolod Vlasov.

* inspector/InjectedScriptCanvasModuleSource.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add APIs to get/set whether scripts can open new windows.
commit-queue@webkit.org [Thu, 15 Nov 2012 12:13:27 +0000 (12:13 +0000)]
[EFL][WK2] Add APIs to get/set whether scripts can open new windows.
https://bugs.webkit.org/show_bug.cgi?id=102054

Patch by Yuni Jeong <yhnet.jung@samsung.com> on 2012-11-15
Reviewed by Gyuyoung Kim.

Added setting APIs make it possible to allow or prevent scripts from opening new windows automatically.

* UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_scripts_can_open_windows_set):
(ewk_settings_scripts_can_open_windows_get):
* UIProcess/API/efl/ewk_settings.h:
* UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix tests after r134637.
rniwa@webkit.org [Thu, 15 Nov 2012 11:35:34 +0000 (11:35 +0000)]
Fix tests after r134637.

* fast/harness/perftests/runs-per-second-iterations.html:
* fast/harness/perftests/runs-per-second-log.html:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Rebase fast/media/mq-js-media-except-01.html after r134618
commit-queue@webkit.org [Thu, 15 Nov 2012 11:34:17 +0000 (11:34 +0000)]
[EFL][WK2] Rebase fast/media/mq-js-media-except-01.html after r134618
https://bugs.webkit.org/show_bug.cgi?id=102362

Unreviewed rebaseline.

Rebased fast/media/mq-js-media-except-01.html after r134618.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-15

* platform/efl-wk2/fast/media/mq-js-media-except-01-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix build break when using --no-tiled-backing-store option.
gyuyoung.kim@samsung.com [Thu, 15 Nov 2012 11:01:22 +0000 (11:01 +0000)]
Unreviewed. Fix build break when using --no-tiled-backing-store option.

* ewk/ewk_frame_private.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, skip new failing tests.
ossy@webkit.org [Thu, 15 Nov 2012 10:55:41 +0000 (10:55 +0000)]
[Qt] Unreviewed gardening, skip new failing tests.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix.
mrowe@apple.com [Thu, 15 Nov 2012 10:07:57 +0000 (10:07 +0000)]
Build fix.

Disable deprecation warnings in a few places that need it.

* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::drawRepaintCounter):
* platform/graphics/mac/FontMac.mm:
(WebCore::showGlyphsWithAdvances):
* platform/graphics/mac/WebLayer.mm:
(drawLayerContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Rebaseline after r134649.
kkristof@inf.u-szeged.hu [Thu, 15 Nov 2012 10:04:50 +0000 (10:04 +0000)]
[Qt] Unreviewed gardening. Rebaseline after r134649.

* platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
* platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
* platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSupport stand-alone month names in calendar picker
tkent@chromium.org [Thu, 15 Nov 2012 09:47:46 +0000 (09:47 +0000)]
Support stand-alone month names in calendar picker
https://bugs.webkit.org/show_bug.cgi?id=102196

Reviewed by Kentaro Hara.

.:

* ManualTests/forms/calendar-picker.html:
- Remove monthLabels arguments.
- Add a mock implementation of pagePopupController.formatMonth.

Source/WebCore:

We have showed non stand-alone month names in any locales. However
we should show stand-alone month names in some locales such as
Russian.

This patch introduce PagePopupController::formatMonth. It is
exposed to page-popups, and format year-month pairs in the same
way as input[type=month].

No new tests. Affects platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru.html.

* Resources/pagepopups/calendarPicker.js:
(Month.prototype.toLocaleString):
Calls pagePopupController.formatMonth except Japanese locale.
(handleArgumentsTimeout):
Remove unnecessary default monthLabels.
* page/PagePopupController.cpp:
(WebCore::PagePopupController::formatMonth): Added.
* page/PagePopupController.h:
(PagePopupController): Declare formatMonth.
* page/PagePopupController.idl: Add formatMonth.

Source/WebKit/chromium:

* src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument):
We don't need to pass monthLabels any more.

LayoutTests:

Update a pixel result for Russian calendar picker. Now it contains
a stand-alone month name.

* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rebaselined images.
haraken@chromium.org [Thu, 15 Nov 2012 09:08:14 +0000 (09:08 +0000)]
Unreviewed. Rebaselined images.

* platform/chromium-win/fast/forms/zoomed-controls-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Fix new JS compiler warnings.
commit-queue@webkit.org [Thu, 15 Nov 2012 08:55:01 +0000 (08:55 +0000)]
Web Inspector: Fix new JS compiler warnings.
https://bugs.webkit.org/show_bug.cgi?id=102341

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-15
Reviewed by Yury Semikhatsky.

New version of compiler finds new inconsistencies.

* inspector/front-end/DOMAgent.js: Replaced 2 simiar cases with loop.
* inspector/front-end/DOMBreakpointsSidebarPane.js:
Declared instance property on WebInspector.
* inspector/front-end/Script.js: Normalized parameter notation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix.
kenneth@webkit.org [Thu, 15 Nov 2012 08:53:50 +0000 (08:53 +0000)]
Unreviewed build fix.

* dom/ViewportArguments.cpp:
(WebCore::convertToUserSpace): Add static

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactor ViewportArguments to only use CSS units
kenneth@webkit.org [Thu, 15 Nov 2012 08:20:25 +0000 (08:20 +0000)]
Refactor ViewportArguments to only use CSS units
https://bugs.webkit.org/show_bug.cgi?id=102287

Reviewed by Noam Rosenthal.

Refactor the ViewportArgument code to use a member method for
resolving the viewport. This new method only uses arguments in
CSS units.

This is preparation for adding the CSS Device Adaptation support.

Tested by existing tests fast/viewport.

* dom/ViewportArguments.cpp:
(WebCore::clampLengthValue):
(WebCore::clampScaleValue): New utility functions.
(WebCore::ViewportArguments::resolve):
(WebCore::convertToUserSpace): Added until everyone provides arguments
only in CSS units and not device ones.
(WebCore::computeViewportAttributes):
(WebCore::computeMinimumScaleFactorForContentContained):
(WebCore):
(WebCore::restrictMinimumScaleFactorToViewportSize):
* dom/ViewportArguments.h:
(ViewportArguments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChanging pseudoClass (:disabled) should cause distribution.
shinyak@chromium.org [Thu, 15 Nov 2012 07:41:33 +0000 (07:41 +0000)]
Changing pseudoClass (:disabled) should cause distribution.
https://bugs.webkit.org/show_bug.cgi?id=101901

Reviewed by Hajime Morita.

Source/WebCore:

We have to invalidate distribution when pseudo-class (:disabled) is changed.

According to the HTML5 spec, :disabled will match button, input, select, textarea, optgroup,
option, command, li, and fieldset. However, command is not implemented yet, we skip li and command. li might
have 'disabled' state, but we need a command element to make it 'disabled' state.

Tests: fast/dom/shadow/pseudoclass-update-disabled-button.html
       fast/dom/shadow/pseudoclass-update-disabled-fieldset.html
       fast/dom/shadow/pseudoclass-update-disabled-input.html
       fast/dom/shadow/pseudoclass-update-disabled-optgroup.html
       fast/dom/shadow/pseudoclass-update-disabled-option.html
       fast/dom/shadow/pseudoclass-update-disabled-select.html
       fast/dom/shadow/pseudoclass-update-disabled-textarea.html

* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::disabledAttributeChanged):
* html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::parseAttribute):
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::parseAttribute):

LayoutTests:

* fast/dom/shadow/pseudoclass-update-disabled-button-expected.html: Added.
* fast/dom/shadow/pseudoclass-update-disabled-button.html: Added.
* fast/dom/shadow/pseudoclass-update-disabled-fieldset-expected.html: Added.
* fast/dom/shadow/pseudoclass-update-disabled-fieldset.html: Added.
* fast/dom/shadow/pseudoclass-update-disabled-input-expected.html: Added.
* fast/dom/shadow/pseudoclass-update-disabled-input.html: Added.
* fast/dom/shadow/pseudoclass-update-disabled-optgroup-expected.txt: Added.
* fast/dom/shadow/pseudoclass-update-disabled-optgroup.html: Added.
* fast/dom/shadow/pseudoclass-update-disabled-option-expected.txt: Added.
* fast/dom/shadow/pseudoclass-update-disabled-option.html: Added.
* fast/dom/shadow/pseudoclass-update-disabled-select-expected.html: Added.
* fast/dom/shadow/pseudoclass-update-disabled-select.html: Added.
* fast/dom/shadow/pseudoclass-update-disabled-textarea-expected.html: Added.
* fast/dom/shadow/pseudoclass-update-disabled-textarea.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134691, r134703, r134715, r134716,
commit-queue@webkit.org [Thu, 15 Nov 2012 07:34:30 +0000 (07:34 +0000)]
Unreviewed, rolling out r134691, r134703, r134715, r134716,
and r134733.
http://trac.webkit.org/changeset/134691
http://trac.webkit.org/changeset/134703
http://trac.webkit.org/changeset/134715
http://trac.webkit.org/changeset/134716
http://trac.webkit.org/changeset/134733
https://bugs.webkit.org/show_bug.cgi?id=102342

"Broke the Apple Windows Debug and GTK builds." (Requested by
dydx on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-14

Source/WebCore:

* WebCore.exp.in:
* bindings/js/SerializedScriptValue.h:
* testing/Internals.cpp:
* testing/Internals.h:
(WebCore):
* testing/Internals.idl:

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

* platform/chromium/fast/storage/serialized-script-value-expected.txt: Removed.
* platform/chromium/fast/storage/serialized-script-value.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rebaselined images.
haraken@chromium.org [Thu, 15 Nov 2012 07:12:19 +0000 (07:12 +0000)]
Unreviewed. Rebaselined images.

* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: Added.
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Added.
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: Added.
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed: fixing inspector tests under Qt.
pfeldman@chromium.org [Thu, 15 Nov 2012 06:57:37 +0000 (06:57 +0000)]
Not reviewed: fixing inspector tests under Qt.

* inspector/front-end/TestController.js:
* inspector/front-end/utilities.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r134741.
commit-queue@webkit.org [Thu, 15 Nov 2012 06:51:10 +0000 (06:51 +0000)]
Unreviewed, rolling out r134741.
http://trac.webkit.org/changeset/134741
https://bugs.webkit.org/show_bug.cgi?id=102337

"Change is incorrect." (Requested by dydx on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-14

.:

* Source/autotools/symbols.filter:

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Port tiled backing store
commit-queue@webkit.org [Thu, 15 Nov 2012 06:44:33 +0000 (06:44 +0000)]
[EFL] Port tiled backing store
https://bugs.webkit.org/show_bug.cgi?id=71352

Patch by Ryuan Choi <ryuan.choi@gmail.com> on 2012-11-14
Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

Added ewk_view_setting_tiled_backing_store_enabled_{get|set} to give possibility
to use WebCore's tiled backing store in WebKit/Efl port. This makes WebKit/Efl
compliant with WebKit's generic solution of tiled backing store.

* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::invalidateRootView):
(WebCore):
(WebCore::ChromeClientEfl::visibleRectForTiledBackingStore):
* WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):
* ewk/ewk_frame_private.h:
Declared missing classes which used in this file.
* ewk/ewk_paint_context.cpp:
(ewk_paint_context_paint): Implemented to paint tiled backing store
* ewk/ewk_view.cpp:
(ewk_view_setting_tiled_backing_store_enabled_set):
Added API to enable/disable the WebCore's tiled backing store.
(ewk_view_setting_tiled_backing_store_enabled_get):
Added API to query if the WebCore's tiled backing store is enabled.
(ewk_view_tiled_backing_store_invalidate):
* ewk/ewk_view.h:
* ewk/ewk_view_private.h:
* ewk/ewk_view_single.cpp:
(_ewk_view_single_smart_repaints_process):
Implemented to update visible area of tiled backing store.
* tests/test_ewk_view.cpp: Added test case of ewk_view_setting_tiled_backing_store.
(TEST_F):

Tools:

* EWebLauncher/main.c: Added option to test the WebCore's tiled backing store.
(_User_Arguments):
(windowCreate):
(parseUserArguments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Thu, 15 Nov 2012 06:42:21 +0000 (06:42 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-14

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAttempt to fix the Apple Windows Debug and GTK builds after <http://trac.webkit.org...
dbates@webkit.org [Thu, 15 Nov 2012 06:37:43 +0000 (06:37 +0000)]
Attempt to fix the Apple Windows Debug and GTK builds after <trac.webkit.org/changeset/134691>
(https://bugs.webkit.org/show_bug.cgi?id=96818)

.:

Export symbols similar to the ones we added to WebCore.exp.in in
<http://trac.webkit.org/changeset/134691>.

* Source/autotools/symbols.filter:

Source/WebKit2:

Export symbols of the form:
?deserializeBuffer@Internals@WebCore[...]
?serializeObject@Internals@WebCore[...]

* win/WebKit2.def:
* win/WebKit2CFLite.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rebaselined run-bindings-tests.
haraken@chromium.org [Thu, 15 Nov 2012 05:48:35 +0000 (05:48 +0000)]
Unreviewed. Rebaselined run-bindings-tests.

* bindings/scripts/test/V8/V8TestNode.h:
(WebCore::toV8Fast):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't use temporary clip rects when hit testing
simon.fraser@apple.com [Thu, 15 Nov 2012 05:47:01 +0000 (05:47 +0000)]
Don't use temporary clip rects when hit testing
https://bugs.webkit.org/show_bug.cgi?id=102329

Reviewed by Beth Dakin.

We now cache clip rects separately for painting, hit testing etc. Hit testing
clip rects are always shrunk to exclude scrollbars (so that hit testing on
the scrollbars works), so we no longer every need to use temporary clip rects
during hit testing.

Added an assertion that the scrollbar relevancy when we computed the clip rects
is the same as that when using them.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::updateClipRects):
* rendering/RenderLayer.h:
(WebCore::ClipRectsCache::ClipRectsCache):
(ClipRectsCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSupport animation of basic shape 'polygon'
krit@webkit.org [Thu, 15 Nov 2012 05:33:41 +0000 (05:33 +0000)]
Support animation of basic shape 'polygon'
https://bugs.webkit.org/show_bug.cgi?id=102080

Reviewed by Daniel Bates.

Source/WebCore:

The basic shapes 'circle', 'rectangle' and 'ellipse' are animatable with the committed
patch http://trac.webkit.org/changeset/134352.
This is a follow-up patch to make 'polygon' animatable as well, as long as the number
of vertices between start and end polygon is the same.

Added polygon animation test to existing test:
    fast/exclusions/shape-inside/shape-inside-animation.html
    css3/masking/clip-path-animation.html

* page/animation/CSSPropertyAnimation.cpp: Forgot to add copyright with last commits.
* rendering/style/BasicShapes.cpp:
(WebCore::BasicShape::canBlend): Polygons are allowed now.
(WebCore::BasicShapePolygon::blend): Interpolate polygon shapes.

LayoutTests:

Added animation test for basic shape 'polygon' to existing test
css3/masking/clip-path-animation.html and
fast/exclusions/shape-inside/shape-inside-animation.html.

* animations/resources/animation-test-helpers.js:
(parseBasicShape):
* css3/masking/clip-path-animation-expected.txt:
* css3/masking/clip-path-animation.html:
* fast/exclusions/shape-inside/shape-inside-animation-expected.txt:
* fast/exclusions/shape-inside/shape-inside-animation.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix code generator warnings.
haraken@chromium.org [Thu, 15 Nov 2012 05:27:08 +0000 (05:27 +0000)]
Unreviewed. Fix code generator warnings.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallback):
(GenerateImplementation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix windows build exports (again)
alecflett@chromium.org [Thu, 15 Nov 2012 04:53:22 +0000 (04:53 +0000)]
Fix windows build exports (again)
https://bugs.webkit.org/show_bug.cgi?id=102324

Unreviewed windows-only build fix.

Add one more export that was causing unit tests to fail to link.

* win/WebKit2.def:
* win/WebKit2CFLite.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChanging pseudoClass (:checked) should cause distribution.
shinyak@chromium.org [Thu, 15 Nov 2012 04:29:21 +0000 (04:29 +0000)]
Changing pseudoClass (:checked) should cause distribution.
https://bugs.webkit.org/show_bug.cgi?id=101902

Reviewed by Dimitri Glazkov.

Source/WebCore:

When the 'checked' state is changed, we have to invalidate distribution.

According to the HTML5 spec, :checked should match a checked input[type="checkbox"],
a checked input[type="radio"], a selected option, and commands. However, we don't have a command element yet.

Tests: fast/dom/shadow/pseudoclass-update-checked-input.html
       fast/dom/shadow/pseudoclass-update-checked-option.html

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setChecked):
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::setSelectedState):

LayoutTests:

Since an option element does not create a renderer, we cannot make its test a reftest.

* fast/dom/shadow/pseudoclass-update-checked-input-expected.html: Added.
* fast/dom/shadow/pseudoclass-update-checked-input.html: Added.
* fast/dom/shadow/pseudoclass-update-checked-option-expected.txt: Added.
* fast/dom/shadow/pseudoclass-update-checked-option.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd tests for week picker
keishi@webkit.org [Thu, 15 Nov 2012 03:52:52 +0000 (03:52 +0000)]
Add tests for week picker
https://bugs.webkit.org/show_bug.cgi?id=101555

Reviewed by Kent Tamura.

Adding tests for month picker.

* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: Added.
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Added.
* platform/chromium/fast/forms/calendar-picker/resources/calendar-picker-common.js:
(selectedWeek): Returns value of selected week.
* platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step.html: Added.
* platform/chromium/fast/forms/calendar-picker/week-picker-appearance.html: Added.
* platform/chromium/fast/forms/calendar-picker/week-picker-key-operations-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html: Added.
* platform/chromium/fast/forms/calendar-picker/week-picker-mouse-operations-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/week-picker-mouse-operations.html: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Kill $implClassName from CodeGeneratorV8.pm
haraken@chromium.org [Thu, 15 Nov 2012 03:45:37 +0000 (03:45 +0000)]
[V8] Kill $implClassName from CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=102312

Reviewed by Adam Barth.

$implClassName and $interfaceName are the same.
Sometimes we are passing both $implClassName and $interfaceName to
subroutines. We can kill $implClassName.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateOpaqueRootForGC):
(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateDomainSafeFunctionSetter):
(GenerateConstructorGetter):
(GenerateNormalAttrGetter):
(GenerateReplaceableAttrSetter):
(GenerateNormalAttrSetter):
(GenerateEventListenerCallback):
(GenerateOverloadedFunctionCallback):
(GenerateFunctionCallback):
(GenerateParametersCheck):
(GenerateOverloadedConstructorCallback):
(GenerateSingleConstructorCallback):
(GenerateConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateTypedArrayConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
(GenerateFunctionCallString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] We can shave one instruction off toV8Fast
abarth@webkit.org [Thu, 15 Nov 2012 03:41:21 +0000 (03:41 +0000)]
[V8] We can shave one instruction off toV8Fast
https://bugs.webkit.org/show_bug.cgi?id=102297

Reviewed by Kentaro Hara.

There's no reason to store info.Holder in a local variable. Calling
Holder() is essentially free because it's inlined to an offset read.

I doubt this patch moves the performance needle in any measurable way,
but it makes the code slightly prettier.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/scripts/test/V8/V8TestNode.h:
(WebCore::toV8Fast):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Get rid of a redundant branch in JSValueToNative()
haraken@chromium.org [Thu, 15 Nov 2012 03:31:45 +0000 (03:31 +0000)]
[V8] Get rid of a redundant branch in JSValueToNative()
https://bugs.webkit.org/show_bug.cgi?id=102311

Reviewed by Adam Barth.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(JSValueToNative):
(NativeToJSValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChanging pseudoClass (:link) should cause distribution
shinyak@chromium.org [Thu, 15 Nov 2012 03:17:57 +0000 (03:17 +0000)]
Changing pseudoClass (:link) should cause distribution
https://bugs.webkit.org/show_bug.cgi?id=101698

Reviewed by Hajime Morita.

Source/WebCore:

CSSSelector :link matches anchor element with href attribute. When href attribute of an anchor element is changed,
we have to invalidate distribution.

According to the HTML spec, :link matches a link element having href attribute, currently we have not implemented it yet.

Tests: fast/dom/shadow/pseudoclass-update-link-anchor.html
       fast/dom/shadow/pseudoclass-update-link-area.html

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parseAttribute):

LayoutTests:

* fast/dom/shadow/pseudoclass-update-link-anchor-expected.html: Added.
* fast/dom/shadow/pseudoclass-update-link-anchor.html: Added.
* fast/dom/shadow/pseudoclass-update-link-area-expected.html: Added.
* fast/dom/shadow/pseudoclass-update-link-area.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unused functions from CodeGenerator.pm
haraken@chromium.org [Thu, 15 Nov 2012 03:16:09 +0000 (03:16 +0000)]
Remove unused functions from CodeGenerator.pm
https://bugs.webkit.org/show_bug.cgi?id=102316

Reviewed by Adam Barth.

No tests. No change in behavior.

* bindings/scripts/CodeGenerator.pm:
(GenerateCompileTimeCheckForEnumsIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Clamp negative sizes to zero when converting to gfx:: types
danakj@chromium.org [Thu, 15 Nov 2012 03:05:54 +0000 (03:05 +0000)]
[chromium] Clamp negative sizes to zero when converting to gfx:: types
https://bugs.webkit.org/show_bug.cgi?id=102159

Reviewed by James Robinson.

Here we clamp Rect, RectF and Size types to not have negative widths or
heights. WebSizes that you want to keep their negative values, because
they are vectors, should be converted to Vector2d instead.

* chromium/public/WebFloatRect.h:
(WebKit::WebFloatRect::operator gfx::RectF):
* chromium/public/WebRect.h:
(WebKit::WebRect::operator gfx::Rect):
* chromium/public/WebSize.h:
(WebKit::WebSize::operator gfx::Size):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Update BB10 form theme.
commit-queue@webkit.org [Thu, 15 Nov 2012 02:59:21 +0000 (02:59 +0000)]
[BlackBerry] Update BB10 form theme.
https://bugs.webkit.org/show_bug.cgi?id=100760

Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-11-14
Reviewed by Rob Buis.

RIM PR 225755
Internally Reviewed by Eli Fidler.
Update checkbox, radio and menulist button style. Adjust border width
and line height.

* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::adjustMenuListButtonStyle):
* platform/blackberry/RenderThemeBlackBerry.h:
(RenderThemeBlackBerry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rebaselined images.
haraken@chromium.org [Thu, 15 Nov 2012 02:56:01 +0000 (02:56 +0000)]
Unreviewed. Rebaselined images.

* platform/chromium-mac-lion/fast/forms/menulist-clip-expected.png:
* platform/chromium-mac-lion/fast/forms/menulist-option-wrap-expected.png:
* platform/chromium-mac-lion/fast/repaint/control-clip-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/menulist-clip-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/menulist-option-wrap-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/control-clip-expected.png:
* platform/chromium-mac/fast/forms/menulist-clip-expected.png:
* platform/chromium-mac/fast/forms/menulist-option-wrap-expected.png:
* platform/chromium-mac/fast/repaint/control-clip-expected.png:
* platform/efl-wk1/fast/forms/menulist-clip-expected.png: Renamed from LayoutTests/platform/efl/fast/forms/menulist-clip-expected.png.
* platform/efl-wk1/fast/forms/menulist-option-wrap-expected.png: Renamed from LayoutTests/platform/efl/fast/forms/menulist-option-wrap-expected.png.
* platform/efl-wk1/fast/repaint/control-clip-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/control-clip-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviwed. Rebaselined images.
haraken@chromium.org [Thu, 15 Nov 2012 02:53:15 +0000 (02:53 +0000)]
Unreviwed. Rebaselined images.

* platform/chromium-mac/fast/forms/select-empty-option-height-expected.png:
* platform/efl-wk1/fast/forms/select-empty-option-height-expected.png: Renamed from LayoutTests/platform/efl/fast/forms/select-empty-option-height-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rebaselined images.
haraken@chromium.org [Thu, 15 Nov 2012 02:51:17 +0000 (02:51 +0000)]
Unreviewed. Rebaselined images.

* platform/chromium-linux/fast/forms/zoomed-controls-expected.png: Added.
* platform/chromium-mac-lion/fast/forms/zoomed-controls-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/zoomed-controls-expected.png: Added.
* platform/chromium-mac/fast/forms/zoomed-controls-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate DOMException name: InvalidModificationError
arv@chromium.org [Thu, 15 Nov 2012 02:33:07 +0000 (02:33 +0000)]
Update DOMException name: InvalidModificationError
https://bugs.webkit.org/show_bug.cgi?id=102281

Reviewed by Kentaro Hara.

Patch 13 of 25 to update DOMException name to match the spec and Firefox.

DOMExcecption INVALID_MODIFICATION_ERR is not used in our code.

* dom/DOMCoreException.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows, WinCairo] Unreviewed build fix.
bfulgham@webkit.org [Thu, 15 Nov 2012 02:31:46 +0000 (02:31 +0000)]
[Windows, WinCairo] Unreviewed build fix.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Missed one of the exports that was part of the WebKit2.def.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the build.
aestes@apple.com [Thu, 15 Nov 2012 02:19:39 +0000 (02:19 +0000)]
Fix the build.

* TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Build correction after r134703.
bfulgham@webkit.org [Thu, 15 Nov 2012 02:18:06 +0000 (02:18 +0000)]
[WinCairo] Build correction after r134703.

* win/WebKit2CFLite.def: Add exports to CFLite version of
Windows build to match Alec's last update.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows, WinCairo] Correct build failure.
bfulgham@webkit.org [Thu, 15 Nov 2012 02:14:05 +0000 (02:14 +0000)]
[Windows, WinCairo] Correct build failure.
https://bugs.webkit.org/show_bug.cgi?id=102302

WebCore symbols were mistakenly added to the JavaScriptCore
library definition file.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove
WebCore symbols that were incorrectly added to the export file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agodocument variable in Document::axObjectCache is actually the topDocument
abarth@webkit.org [Thu, 15 Nov 2012 02:11:52 +0000 (02:11 +0000)]
document variable in Document::axObjectCache is actually the topDocument
https://bugs.webkit.org/show_bug.cgi?id=101966

Reviewed by Chris Fleizach.

Name change requested by Darin Adler.

* dom/Document.cpp:
(WebCore::Document::axObjectCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix Windows exports for TestWebKit
alecflett@chromium.org [Thu, 15 Nov 2012 01:37:58 +0000 (01:37 +0000)]
Fix Windows exports for TestWebKit
https://bugs.webkit.org/show_bug.cgi?id=102302

Unreviewed, fixing Safari Win build.

Add missing exports.

* win/WebKit2.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CF]: XMLHttpRequest "timeout" events firing as "error" events
commit-queue@webkit.org [Thu, 15 Nov 2012 01:30:31 +0000 (01:30 +0000)]
[CF]: XMLHttpRequest "timeout" events firing as "error" events
https://bugs.webkit.org/show_bug.cgi?id=102271

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-11-14
Reviewed by David Kilzer.

Initialize the tiemout flag if the error results from a timeout
in the USE(CFNETWORK) cases.

No new tests. This is covered by http/tests/xmlhttprequest/timeout
tests on ports that USE(CFNETWORK).

* platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::ResourceError):
* platform/network/mac/ResourceErrorMac.mm:
(WebCore::ResourceError::ResourceError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkitpy: consolidate webkit-base-finding code
dpranke@chromium.org [Thu, 15 Nov 2012 01:28:46 +0000 (01:28 +0000)]
webkitpy: consolidate webkit-base-finding code
https://bugs.webkit.org/show_bug.cgi?id=102007

Reviewed by Eric Seidel.

This patch creates a new "WebKitFinder" class that other
modules can use to find the top of the WebKit tree and
commonly used subdirectories. This logic was in the
webkitpy.layout_test.port classes but wasn't specific to those
classes and now can be used by other modules without needing a port
(e.g., by the check-webkit-style python linter).

This code is somewhat redundant with the code for find_checkout_root()
in the scm modules, but it does not rely on the presence of a version
control system to work. This is a requirement for some uses of the
tree (e.g., Chromium tester checkouts).

This patch removes most of the logic from the layout_tests.port.config
module and makes that as private as possible. Now we just need to move
the default_configuration and flag_from_configuration logic into
DeprecatedPort (or someplace else appropriate) and we can finish
getting rid of the Config class (but that is a separate patch).

* Scripts/webkitpy/common/webkit_finder.py: Added.
(WebKitFinder):
(WebKitFinder.__init__):
(WebKitFinder.webkit_base):
(WebKitFinder.path_from_webkit_base):
(WebKitFinder.path_to_script):
(WebKitFinder.layout_tests_dir):
(WebKitFinder.perf_tests_dir):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.__init__):
(Port):
(Port.webkit_base):
(Port.path_from_webkit_base):
(Port.path_to_script):
(Port.layout_tests_dir):
(Port.perf_tests_dir):
(Port.set_option_default):
(Port._run_script):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_diff_text):
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort._determine_driver_path_statically):
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
* Scripts/webkitpy/layout_tests/port/config.py:
(Config.__init__):
(Config.build_directory):
(Config.default_configuration):
(Config._read_configuration):
* Scripts/webkitpy/layout_tests/port/config_mock.py: Removed.
* Scripts/webkitpy/layout_tests/port/config_unittest.py:
(ConfigTest.test_default_configuration__standalone):
(ConfigTest.test_default_configuration__scripterror):
* Scripts/webkitpy/layout_tests/port/driver_unittest.py:
(DriverTest.make_port):
(DriverTest.test_no_timeout):
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.setup_environ_for_server):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.show_results_html_file):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(TestWebKitPort.__init__):
(PortTestCase.make_port):
* Scripts/webkitpy/layout_tests/port/win_unittest.py:
(WinPortTest.test_expectations_files):
* Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
(XvfbDriverTest.make_driver):
(XvfbDriverTest.test_stop):
* Scripts/webkitpy/style/checkers/python.py:
(Pylinter.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Test conversions batch 4
dgrogan@chromium.org [Thu, 15 Nov 2012 01:19:01 +0000 (01:19 +0000)]
IndexedDB: Test conversions batch 4
https://bugs.webkit.org/show_bug.cgi?id=102267

Reviewed by Tony Chang.

These are tests that don't have the js file in resources. The only
interesting bit is that lazy-index-population uncovered a potential bug.

I think tutorial.html has outlived its usefulness now that there are
more tutorials on the web. It was very outdated. It is deleted in
this patch.

* storage/indexeddb/deletedatabase-transaction-expected.txt:
* storage/indexeddb/deletedatabase-transaction.html:
* storage/indexeddb/dont-commit-on-blocked-expected.txt:
* storage/indexeddb/dont-commit-on-blocked.html:
* storage/indexeddb/lazy-index-population-expected.txt:
* storage/indexeddb/lazy-index-population.html:
* storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
* storage/indexeddb/mozilla/index-prev-no-duplicate.html:
* storage/indexeddb/mozilla/resources/object-identity.js:
  Test added here to replace test covered in tutorial.html

* storage/indexeddb/noblobs-expected.txt:
* storage/indexeddb/noblobs.html:
* storage/indexeddb/resources/dont-commit-on-blocked-worker.js:
(onSetVersionSuccess):
* storage/indexeddb/structured-clone-expected.txt:
* storage/indexeddb/structured-clone.html:
* storage/indexeddb/transaction-complete-with-js-recursion-cross-frame-expected.txt:
* storage/indexeddb/transaction-complete-with-js-recursion-cross-frame.html:
* storage/indexeddb/transaction-complete-with-js-recursion-expected.txt:
* storage/indexeddb/transaction-complete-with-js-recursion.html:
* storage/indexeddb/tutorial-expected.txt: Removed.
* storage/indexeddb/tutorial.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134700 268f45cc-cd09-0410-ab3c-d52691b4dbfc