WebKit-https.git
8 years ago[chromium] Need a way to test lost compositor context recovery
jamesr@google.com [Wed, 24 Aug 2011 01:33:12 +0000 (01:33 +0000)]
[chromium] Need a way to test lost compositor context recovery
https://bugs.webkit.org/show_bug.cgi?id=66820

Reviewed by Kenneth Russell.

Source/WebCore:

Adds support for recreating a context as if it was lost, and fixes
compositeAndReadback() to attempt context recovery.

Test: platform/chromium/compositing/lost-compositor-context.html

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::loseCompositorContext):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:

Source/WebKit/chromium:

Adds a testing-only API to simulate a lost compositor context.

* public/WebView.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::loseCompositorContext):
* src/WebViewImpl.h:

Tools:

Exposes a LayoutTestController interface in chromium to simulate a
lost compositor context.

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::loseCompositorContext):
* DumpRenderTree/chromium/LayoutTestController.h:

LayoutTests:

Adds a simple test for losing the compositor context in a recoverable
way on a composited page. Tests that we recover without crashing and
render the updated content on the next frame.

* platform/chromium/compositing/lost-compositor-context.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Implement CCThread in terms of WebThread
nduca@chromium.org [Wed, 24 Aug 2011 01:22:22 +0000 (01:22 +0000)]
[chromium] Implement CCThread in terms of WebThread
https://bugs.webkit.org/show_bug.cgi?id=66610

Reviewed by Darin Fisher.

Source/WebCore:

* WebCore.gypi:
* platform/graphics/chromium/cc/CCCompletionEvent.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::client):
* platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:
(WebCore::CCLayerTreeHostImplProxy::CCLayerTreeHostImplProxy):
* platform/graphics/chromium/cc/CCThread.h:
(WebCore::CCThread::~CCThread):

Source/WebKit/chromium:

* WebKit.gyp:
* public/WebThread.h:
(WebKit::WebThread::~WebThread):
* src/CCThreadImpl.cpp: Added.
(WebKit::GetThreadIDTask::GetThreadIDTask):
(WebKit::GetThreadIDTask::~GetThreadIDTask):
(WebKit::GetThreadIDTask::run):
(WebKit::CCThreadTaskAdapter::CCThreadTaskAdapter):
(WebKit::CCThreadTaskAdapter::~CCThreadTaskAdapter):
(WebKit::CCThreadTaskAdapter::run):
(WebKit::CCThreadImpl::create):
(WebKit::CCThreadImpl::~CCThreadImpl):
(WebKit::CCThreadImpl::postTask):
(WebKit::CCThreadImpl::threadID):
(WebKit::CCThreadImpl::CCThreadImpl):
* src/CCThreadImpl.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::createCompositorThread):
* src/WebViewImpl.h:
* tests/CCThreadTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Renderer crashes when about:gpucrash is loaded
commit-queue@webkit.org [Wed, 24 Aug 2011 01:18:00 +0000 (01:18 +0000)]
[chromium] Renderer crashes when about:gpucrash is loaded
https://bugs.webkit.org/show_bug.cgi?id=66814

Source/WebCore:

WebViewImpl::didRecreateGraphicsContext() was calling
setRootLayer() on the CC layer tree, but the root layer
doesn't actually change and the code wasn't defensive
against this. This CL adds some asserts to catch tree
corruption and removes the unnecessary calls.

Patch by Iain Merrick <husky@google.com> on 2011-08-23
Reviewed by James Robinson.

* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::setParent):
* platform/graphics/GraphicsLayer.h:
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setParent):
(WebCore::LayerChromium::hasAncestor):
* platform/graphics/chromium/LayerChromium.h:

Source/WebKit/chromium:

WebViewImpl::didRecreateGraphicsContext() was calling
setRootLayer() on the CC layer tree, but the root layer
doesn't actually change and the code wasn't defensive
against this. This CL adds some asserts to catch tree
corruption and removes the unnecessary calls.

Patch by Iain Merrick <husky@google.com> on 2011-08-23
Reviewed by James Robinson.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::didRecreateGraphicsContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r93645.
commit-queue@webkit.org [Wed, 24 Aug 2011 01:00:07 +0000 (01:00 +0000)]
Unreviewed, rolling out r93645.
http://trac.webkit.org/changeset/93645
https://bugs.webkit.org/show_bug.cgi?id=66828

Broke webkit_unit_tests on chromium mac (Requested by jamesr
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-23

* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPrepare WKTextInputWindowController for the new text input model
andersca@apple.com [Wed, 24 Aug 2011 00:29:47 +0000 (00:29 +0000)]
Prepare WKTextInputWindowController for the new text input model
https://bugs.webkit.org/show_bug.cgi?id=66826

Reviewed by Sam Weinig.

Add -[WKTextInputWindowController hasMarkedText] and make interpretKeyEvent take an
additional usingLegacyCocoaTextInput flag. No functionality change.

* UIProcess/API/mac/WKTextInputWindowController.h:
* UIProcess/API/mac/WKTextInputWindowController.mm:
(-[WKTextInputPanel _interpretKeyEvent:usingLegacyCocoaTextInput:string:]):
(-[WKTextInputPanel _hasMarkedText]):
(-[WKTextInputWindowController hasMarkedText]):
(-[WKTextInputWindowController interpretKeyEvent:usingLegacyCocoaTextInput:string:]):
* UIProcess/API/mac/WKView.mm:
(-[WKView keyDown:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=66244
bdakin@apple.com [Wed, 24 Aug 2011 00:29:27 +0000 (00:29 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=66244
Cached pages don't fully update when going back after changing the display scale
factor
-and corresponding-
<rdar://problem/9955656>

Reviewed by Darin Adler.

This patch adds a generalized concept of needing a full style recalc to the
BackForwardController. So when the display scale factor is changed, the
BackForwardController can be informed that all pages will need a full style recalc
when they come out of the cache. This same mechanism is also used to fix a long-
standing bug with full-page/text zoom.

Iterate through the HistoryItems and mark all CachedPages as needing a full style
recalc.
* history/BackForwardController.cpp:
(WebCore::BackForwardController::markPagesForFullStyleRecalc):
* history/BackForwardController.h:

ChachedPage has a new bool -- m_needsFullStyleRecalc -- to track whether a full
style recalc is needed when the CachedPage is restored.
* history/CachedPage.cpp:
(WebCore::CachedPage::CachedPage):
(WebCore::CachedPage::restore):
(WebCore::CachedPage::clear):
* history/CachedPage.h:
(WebCore::CachedPage::markForFullStyleRecalc):

HistoryItem actually takes care of calling into CachedPage.
* history/HistoryItem.cpp:
(WebCore::HistoryItem::markForFullStyleRecalc):
* history/HistoryItem.h:

Fix style recalc issues for full-page/text zoom by calling our new function on
PageCache.
* page/Frame.cpp:
(WebCore::Frame::setPageAndTextZoomFactors):

Fix style recalc issues for display scale factor changes by calling our new
function on PageCache.
* page/Page.cpp:
(WebCore::Page::setDeviceScaleFactor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix baselines for fast/block/float/fit_line_below_floats.html. I forgot Windows...
abarth@webkit.org [Wed, 24 Aug 2011 00:13:51 +0000 (00:13 +0000)]
Fix baselines for fast/block/float/fit_line_below_floats.html.  I forgot Windows in my previous patch.

* platform/chromium-linux/fast/block/float/fit_line_below_floats-expected.txt: Removed.
* platform/chromium-win/fast/block/float/fit_line_below_floats-expected.png: Added.
* platform/chromium-win/fast/block/float/fit_line_below_floats-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove comments formerly associated with now-rebaselined tests.
pkasting@chromium.org [Tue, 23 Aug 2011 23:59:33 +0000 (23:59 +0000)]
[chromium] Remove comments formerly associated with now-rebaselined tests.

Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChange garden-o-matic frontend builder array to be a configuration map.
dglazkov@chromium.org [Tue, 23 Aug 2011 23:33:57 +0000 (23:33 +0000)]
Change garden-o-matic frontend builder array to be a configuration map.
https://bugs.webkit.org/show_bug.cgi?id=66816

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Made kBuilders a map, with value being a configuration object.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Adjusted callsites to expect a map.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Ditto.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Ditto.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix build.
andersca@apple.com [Tue, 23 Aug 2011 23:32:34 +0000 (23:32 +0000)]
Fix build.

* inspector/InstrumentingAgents.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded support for momentarily revealing last typed character in password input.
commit-queue@webkit.org [Tue, 23 Aug 2011 23:31:44 +0000 (23:31 +0000)]
Added support for momentarily revealing last typed character in password input.
Code change was partially based on Apple's iOS code and Samuel Nevala's work.
https://bugs.webkit.org/show_bug.cgi?id=32509

Patch by Chang Shu <cshu@webkit.org> on 2011-08-23
Reviewed by Alexey Proskuryakov.

Source/WebCore:

* editing/InsertIntoTextNodeCommand.cpp:
(WebCore::InsertIntoTextNodeCommand::doApply):
* rendering/RenderText.cpp:
(WebCore::SecureTextTimer::SecureTextTimer):
(WebCore::SecureTextTimer::restartWithNewText):
(WebCore::SecureTextTimer::invalidate):
(WebCore::SecureTextTimer::lastTypedCharacterOffset):
(WebCore::SecureTextTimer::fired):
(WebCore::RenderText::willBeDestroyed):
(WebCore::RenderText::setTextInternal):
(WebCore::RenderText::secureText):
(WebCore::RenderText::momentarilyRevealLastTypedCharacter):
* rendering/RenderText.h:
(WebCore::RenderText::isSecure):
* testing/Internals.cpp:
(WebCore::Internals::setPasswordEchoEnabled): Fixed some silly coding in Internals.
(WebCore::Internals::setPasswordEchoDurationInSeconds):
(WebCore::Internals::reset):

LayoutTests:

Updated failed expected files.

* editing/input/password-echo-passnode-expected.txt:
* editing/input/password-echo-passnode2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaselines for bug 66442 (skia webkit-transform breaks webkit-mask)
commit-queue@webkit.org [Tue, 23 Aug 2011 23:24:44 +0000 (23:24 +0000)]
Rebaselines for bug 66442 (skia webkit-transform breaks webkit-mask)
https://bugs.webkit.org/show_bug.cgi?id=66757

Patch by Ben Wells <benwells@chromium.org> on 2011-08-23
Reviewed by Kenneth Russell.

* platform/chromium-gpu-win/compositing/masks/multiple-masks-expected.png: Added.
* platform/chromium-gpu-win/compositing/masks/multiple-masks-expected.txt: Added.
* platform/chromium-linux/fast/backgrounds/mask-composite-expected.png: Added.
* platform/chromium-win/fast/backgrounds/mask-composite-expected.png: Added.
* platform/chromium-win/fast/backgrounds/mask-composite-expected.txt: Added.
* platform/chromium-win/fast/css/transformed-mask-expected.png: Added.
* platform/chromium-win/fast/css/transformed-mask-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/css/transformed-mask-expected.txt.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=66751
commit-queue@webkit.org [Tue, 23 Aug 2011 23:22:19 +0000 (23:22 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=66751
[Chromium]WebWorkerClientImpl should always invoke
InspectorIntrumentation on main thread.
The fix moves calls to InspectorInstrumentation from
WebWorkerClientImpl to unedrlying WorkerMessagingProxy.

Patch by Dmitry Lomov <Dmitry Lomov (dslomov@google.com)> on 2011-08-23
Reviewed by Pavel Feldman.

Source/WebCore:

Covered by existing tests.

* inspector/InstrumentingAgents.cpp:
(WebCore::instrumentationForPage):
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::workerContextDestroyedInternal):
(WebCore::WorkerMessagingProxy::terminateWorkerContext):

Source/WebKit/chromium:

* src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::terminateWorkerContext):
(WebKit::WebWorkerClientImpl::workerContextDestroyed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTurn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
caryclark@google.com [Tue, 23 Aug 2011 23:18:34 +0000 (23:18 +0000)]
Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
https://bugs.webkit.org/show_bug.cgi?id=66803

This fixes the WebKit Canaries, in particular avoids a crash on tests
like css1/basic/comments.html.

Reviewed by James Robinson.

* DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
(WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
The NSGraphicsContext call graphicsContextWithGraphicsPort takes a void*
parameter, so it took a WebCanvas* (mapped to SkCanvas* in Skia-land)
and treated it as if it were a CGContextRef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Button text is invisible when mobile theme is in use and application palette...
commit-queue@webkit.org [Tue, 23 Aug 2011 23:12:27 +0000 (23:12 +0000)]
[Qt] Button text is invisible when mobile theme is in use and application palette set to use light text color.
https://bugs.webkit.org/show_bug.cgi?id=66635

When mobile theme is in use and application palette is using light
color to display text button text becomes invisible. The reason for
that is that in RenderThemeQt::systemFont() we are using application
pallete while when are painting buttons lightGrayPalette is used.
Calling setPaletteFromPageClientIfExists() takes care of the issue.

Patch by Misha Tyutyunik <michael.tyutyunik@nokia.com> on 2011-08-23
Reviewed by Andreas Kling.

Covered by existing tests.

* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::systemColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd handling of mix-width and max-width for flexitems
tony@chromium.org [Tue, 23 Aug 2011 23:10:45 +0000 (23:10 +0000)]
Add handling of mix-width and max-width for flexitems
https://bugs.webkit.org/show_bug.cgi?id=66723

Reviewed by David Hyatt.

Source/WebCore:

If we flex past a min/max width value, we need to mark the flexitem as
a fixed width and re-start the flexing algorithm.  We use a HashMap to
keep track of fixed width items.

This patch also split out the size computation from the actual layout
to avoid unnecessary layouts caused by restarting the flexing algorithm.

Test: css3/flexbox/003.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutHorizontalBlock):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm):
* rendering/RenderFlexibleBox.h:

LayoutTests:

* css3/flexbox/003-expected.txt: Added.
* css3/flexbox/003.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate expectations for pkasting. The rebaseline script is having
abarth@webkit.org [Tue, 23 Aug 2011 23:08:31 +0000 (23:08 +0000)]
Update expectations for pkasting.  The rebaseline script is having
trouble on Cygwin, so I ran the script as instructed by Peter.

* platform/chromium-cg-mac-leopard/fast/block/float/fit_line_below_floats-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/block/float/floats-and-text-indent-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/block/float/floats-and-text-indent-rl-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
* platform/chromium-cg-mac/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
* platform/chromium-linux-x86/fast/css: Removed.
* platform/chromium-linux-x86/svg/dynamic-updates: Removed.
* platform/chromium-linux/fast/block/float/fit_line_below_floats-expected.png: Added.
* platform/chromium-linux/fast/block/float/fit_line_below_floats-expected.txt: Added.
* platform/chromium-linux/fast/block/float/floats-and-text-indent-expected.png: Added.
* platform/chromium-linux/fast/block/float/floats-and-text-indent-rl-expected.png: Added.
* platform/chromium-linux/fast/block/positioning/058-expected.png:
* platform/chromium-linux/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
* platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-win-vista/svg/dynamic-updates: Removed.
* platform/chromium-win/fast/block/float/floats-and-text-indent-expected.png: Added.
* platform/chromium-win/fast/block/float/floats-and-text-indent-expected.txt: Added.
* platform/chromium-win/fast/block/float/floats-and-text-indent-rl-expected.png: Added.
* platform/chromium-win/fast/block/float/floats-and-text-indent-rl-expected.txt: Added.
* platform/chromium-win/fast/block/positioning/058-expected.png:
* platform/chromium-win/fast/block/positioning/058-expected.txt:
* platform/chromium-win/fast/css/border-radius-non-negative-expected.png: Added.
* platform/chromium-win/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
* platform/chromium-win/fast/multicol/span/span-as-nested-inline-block-child-expected.txt: Added.
* platform/chromium-win/svg/custom/image-small-width-height-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium/test_expectations.txt:
* platform/gtk/svg/custom/image-small-width-height-expected.txt: Removed.
* platform/qt/svg/custom/image-small-width-height-expected.txt: Removed.
* svg/custom/image-small-width-height-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix mergeChangeLogs test on native windows
paroga@webkit.org [Tue, 23 Aug 2011 23:07:20 +0000 (23:07 +0000)]
Fix mergeChangeLogs test on native windows
https://bugs.webkit.org/show_bug.cgi?id=66797

Reviewed by Adam Roben.

Windows has no /tmp/ directory and the "TMPDIR" environment variable isn't set in the default setup.
Add the "TEMP" environment variable as additional source for the temporary directory used in writeTempFile.

* Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
(writeTempFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoResourceRequest::setStorageSession should update NSURLRequest as well
psolanki@apple.com [Tue, 23 Aug 2011 23:05:10 +0000 (23:05 +0000)]
ResourceRequest::setStorageSession should update NSURLRequest as well
https://bugs.webkit.org/show_bug.cgi?id=66811

Reviewed by Darin Adler.

* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::setStorageSession): Update the m_nsRequest field as well since we
have a new CFURLRequestRef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove obsolete child context list from LayerRendererChromium
commit-queue@webkit.org [Tue, 23 Aug 2011 23:01:08 +0000 (23:01 +0000)]
[chromium] Remove obsolete child context list from LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=66743

Patch by James Robinson <jamesr@chromium.org> on 2011-08-23
Reviewed by Kenneth Russell.

Before we had proper semantics for flush() in the command buffer, we
used a scheme of latches across contexts to ensure consistent frames
were presented for WebGL and canvas. We no longer have latches and
flush is a proper synchronization primative, so the child context list
no longer does anything. Canvas2DLayerChromium and
WebGLLayerChromium's implementations of updateCompositorResources() do
flushes on the appropriate context already - canvas layers via
DrawingBuffer::publishToPlatformLayer(), and WebGL layers via the call
to prepareTexture().

No new tests since the code being removed doesn't do anything.

* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::setDrawingBuffer):
* platform/graphics/chromium/Canvas2DLayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayers):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::~WebGLLayerChromium):
(WebCore::WebGLLayerChromium::setContext):
* platform/graphics/chromium/WebGLLayerChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium Mac: Use a custom pattern image for rubber banding overhang area
commit-queue@webkit.org [Tue, 23 Aug 2011 22:59:34 +0000 (22:59 +0000)]
Chromium Mac: Use a custom pattern image for rubber banding overhang area
https://bugs.webkit.org/show_bug.cgi?id=66707

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-23
Reviewed by Dimitri Glazkov.

No new tests since its just changing the Chromium-specific overhang pattern.

* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Prepare to paint slider thumb separately.
commit-queue@webkit.org [Tue, 23 Aug 2011 22:57:49 +0000 (22:57 +0000)]
Source/WebCore: Prepare to paint slider thumb separately.
Provide proper size values for vertical SliderThumb.
https://bugs.webkit.org/show_bug.cgi?id=66732

Patch by Tatiana Meshkova <tatiana.meshkova@nokia.com> on 2011-08-23
Reviewed by Kenneth Rohde Christiansen.

* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::adjustSliderThumbSize):
Swap length and thickness for sliderthumb-vertical.

LayoutTests: Swap width and height for sliderthumb-vertical.
https://bugs.webkit.org/show_bug.cgi?id=66732

Patch by Tatiana Meshkova <tatiana.meshkova@nokia.com> on 2011-08-23
Reviewed by Kenneth Rohde Christiansen.

* platform/qt/fast/forms/range/thumbslider-no-parent-slider-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Typo fix.
pkasting@chromium.org [Tue, 23 Aug 2011 22:35:00 +0000 (22:35 +0000)]
[chromium] Typo fix.

Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Revert unintentional changes to test expectations in r93638.
pkasting@chromium.org [Tue, 23 Aug 2011 22:22:24 +0000 (22:22 +0000)]
[chromium] Revert unintentional changes to test expectations in r93638.

Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogarden-o-matic relative time is wrong and updates too frequently.
dglazkov@chromium.org [Tue, 23 Aug 2011 22:10:26 +0000 (22:10 +0000)]
garden-o-matic relative time is wrong and updates too frequently.
https://bugs.webkit.org/show_bug.cgi?id=66802

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Fix potential nullptr deref in TiledLayerChromium::pushPropertiesTo
enne@google.com [Tue, 23 Aug 2011 22:09:23 +0000 (22:09 +0000)]
[chromium] Fix potential nullptr deref in TiledLayerChromium::pushPropertiesTo
https://bugs.webkit.org/show_bug.cgi?id=66808

Reviewed by James Robinson.

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::pushPropertiesTo):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r93452.
pkasting@chromium.org [Tue, 23 Aug 2011 21:51:57 +0000 (21:51 +0000)]
Unreviewed, rolling out r93452.
http://trac.webkit.org/changeset/93452
https://bugs.webkit.org/show_bug.cgi?id=66423

Broke Leopard, Snowleopard, and Chromium bots

Source/WebCore:

* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):

LayoutTests:

* fast/parser/innerhtml-with-prefixed-elements.xhtml: Removed.
* platform/chromium/test_expectations.txt:
* platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.png: Removed.
* platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebKit: Patch by Jonas M. Gastal <jgastal@profusion.mobi> on 2011-08-23
demarchi@webkit.org [Tue, 23 Aug 2011 21:01:52 +0000 (21:01 +0000)]
Source/WebKit: Patch by Jonas M. Gastal <jgastal@profusion.mobi> on 2011-08-23
Reviewed by Antonio Gomes.

[EFL] Exporting JavaScript objects for EFL port
https://bugs.webkit.org/show_bug.cgi?id=43446

This patch allows to export objects to JavaScript API,
just like qt does, but it uses the netscape api
to do the convertion to javascript object.

* CMakeLists.txt:
Adding necessary files for the patch.

Source/WebKit/efl: [EFL] Exporting JavaScript objects for EFL port
https://bugs.webkit.org/show_bug.cgi?id=43446

Patch by Jonas M. Gastal <jgastal@profusion.mobi> on 2011-08-23
Reviewed by Antonio Gomes.

This patch allows to export objects to JavaScript API,
just like qt does, but it uses the netscape api
to do the convertion to javascript object.

* CMakeLists.txt:
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):
* ewk/EWebKit.h:
* ewk/ewk_js.cpp: Added.
(ewk_js_variant_to_npvariant):
(ewk_js_npvariant_to_variant):
(ewk_js_property_has):
(ewk_js_property_get):
(ewk_js_property_set):
(ewk_js_property_remove):
(ewk_js_properties_enumerate):
(ewk_js_method_has):
(ewk_js_method_invoke):
(ewk_js_class_new):
(ewk_js_class_free):
(ewk_js_object_new):
(ewk_js_object_free):
(ewk_js_object_properties_get):
(ewk_js_object_name_get):
(ewk_js_variant_free):
* ewk/ewk_js.h: Added.
* ewk/ewk_main.cpp:
(ewk_init):
* ewk/ewk_private.h:
* ewk/ewk_view.cpp:
(ewk_view_js_window_object_clear):
(ewk_view_js_object_add):
* ewk/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unnecessary folders in WebKit2.
andreas.kling@nokia.com [Tue, 23 Aug 2011 20:48:48 +0000 (20:48 +0000)]
[Qt] Unnecessary folders in WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=66583

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-08-23
Reviewed by Benjamin Poulain.

Remove empty autotest folders that were left over from QGraphicsWKView times.

* UIProcess/API/qt/tests/qgraphicswkview: Removed.
* UIProcess/API/qt/tests/qwkhistory: Removed.
* UIProcess/API/qt/tests/qwkpage: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Move result images into correct subdirectory.
pkasting@chromium.org [Tue, 23 Aug 2011 20:40:10 +0000 (20:40 +0000)]
[chromium] Move result images into correct subdirectory.
https://bugs.webkit.org/show_bug.cgi?id=66618

Unreviewed, file misplacement fix.

* platform/chromium-cg-mac/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Copied from platform/chromium-cg-mac/scroll-absolute-layer-with-reflection-expected.png.
* platform/chromium-cg-mac/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Copied from platform/chromium-cg-mac/scroll-fixed-layer-with-reflection-expected.png.
* platform/chromium-cg-mac/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Copied from platform/chromium-cg-mac/scroll-fixed-layer-with-transformed-parent-layer-expected.png.
* platform/chromium-cg-mac/fast/repaint/scroll-fixed-reflected-layer-expected.png: Copied from platform/chromium-cg-mac/scroll-fixed-reflected-layer-expected.png.
* platform/chromium-cg-mac/fast/repaint/scroll-in-clipped-layer-expected.png: Copied from platform/chromium-cg-mac/scroll-in-clipped-layer-expected.png.
* platform/chromium-cg-mac/fast/repaint/scroll-in-fixed-layer-expected.png: Copied from platform/chromium-cg-mac/scroll-in-fixed-layer-expected.png.
* platform/chromium-cg-mac/fast/repaint/scroll-in-transformed-layer-expected.png: Copied from platform/chromium-cg-mac/scroll-in-transformed-layer-expected.png.
* platform/chromium-cg-mac/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Copied from platform/chromium-cg-mac/scroll-with-transformed-parent-layer-expected.png.
* platform/chromium-cg-mac/scroll-absolute-layer-with-reflection-expected.png: Removed.
* platform/chromium-cg-mac/scroll-fixed-layer-with-reflection-expected.png: Removed.
* platform/chromium-cg-mac/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Removed.
* platform/chromium-cg-mac/scroll-fixed-reflected-layer-expected.png: Removed.
* platform/chromium-cg-mac/scroll-in-clipped-layer-expected.png: Removed.
* platform/chromium-cg-mac/scroll-in-fixed-layer-expected.png: Removed.
* platform/chromium-cg-mac/scroll-in-transformed-layer-expected.png: Removed.
* platform/chromium-cg-mac/scroll-with-transformed-parent-layer-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove a few FIXME #defines in API headers
adamk@chromium.org [Tue, 23 Aug 2011 20:19:09 +0000 (20:19 +0000)]
[chromium] Remove a few FIXME #defines in API headers
https://bugs.webkit.org/show_bug.cgi?id=66791

Reviewed by James Robinson.

* DEPS:
Roll chromium_rev to r97891.
* public/WebFileSystem.h:
#define made obsolete in http://crrev.com/97520.
* public/WebKitClient.h:
#define made obsolete in http://crrev.com/97524 and
http://crrev.com/97891.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixed warnings produced by gcc-4.6.0.
commit-queue@webkit.org [Tue, 23 Aug 2011 20:10:46 +0000 (20:10 +0000)]
Fixed warnings produced by gcc-4.6.0.
https://bugs.webkit.org/show_bug.cgi?id=62168

Patch by Ahmad Sharif <asharif@chromium.org> on 2011-08-23
Reviewed by Adam Barth.

* dom/Element.cpp:
(WebCore::Element::recalcStyle):
* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::PerAxisData::curveAt):
(WebCore::ScrollAnimatorNone::PerAxisData::curveDerivativeAt):
* thirdparty: Copied from Source/WebCore/thirdparty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd missing quotes around filenames in mergeChangeLogs
paroga@webkit.org [Tue, 23 Aug 2011 20:08:09 +0000 (20:08 +0000)]
Add missing quotes around filenames in mergeChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=66794

Reviewed by Adam Roben.

* Scripts/VCSUtils.pm:
(mergeChangeLogs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Attempt to make test expectations more accurate.
pkasting@chromium.org [Tue, 23 Aug 2011 19:58:33 +0000 (19:58 +0000)]
[chromium] Attempt to make test expectations more accurate.

Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoText overlaps with the floats
commit-queue@webkit.org [Tue, 23 Aug 2011 19:54:28 +0000 (19:54 +0000)]
Text overlaps with the floats
https://bugs.webkit.org/show_bug.cgi?id=66671

Source/WebCore:

The problem was that LineWidth::fitBelowFloats is not updating the m_left and m_right fields.
Next time LineWidth::shrinkAvailableWidthForNewFloatIfNeeded was called the width was recalculated
using the old values, making the line bigger.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-23
Reviewed by David Hyatt.

Test: fast/block/float/fit_line_below_floats.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::fitBelowFloats):

LayoutTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-23
Reviewed by David Hyatt.

* fast/block/float/fit_line_below_floats.html: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/fast/block/float/fit_line_below_floats-expected.png: Added.
* platform/mac/fast/block/float/fit_line_below_floats-expected.txt: Added.
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSSRegions] RenderFlowThread layout should use the attached region sizes
commit-queue@webkit.org [Tue, 23 Aug 2011 19:44:43 +0000 (19:44 +0000)]
[CSSRegions] RenderFlowThread layout should use the attached region sizes
https://bugs.webkit.org/show_bug.cgi?id=66143

Source/WebCore:

When RenderFlowThread is doing the layout it also sets the current RenderFlowThread on
the RenderView. RenderFlowThread cannot be nested inside a single RenderView, so there's no
need to put that on the LayoutState.

The right offset used to layout the inlines inside a RenderFlowThread
is now adjusted to fit inside the current region.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-23
Reviewed by David Hyatt.

Tests: fast/regions/webkit-flow-floats-inside-regions-bounds.html
       fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl.html
       fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical.html
       fast/regions/webkit-flow-inlines-inside-regions-bounds.html

* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::adjustForRegionFittingIfNeeded):
(WebCore::RenderBlock::logicalRightOffsetForLine):
* rendering/RenderBlock.h:
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
(WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::renderRegionForLine):
(WebCore::RenderFlowThread::regionLogicalWidthForLine):
* rendering/RenderFlowThread.h:
(WebCore::RegionFittingDisabler::RegionFittingDisabler):
(WebCore::RegionFittingDisabler::~RegionFittingDisabler):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::layout):
* rendering/RenderRegion.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
* rendering/RenderView.h:
(WebCore::RenderView::hasRenderFlowThread):
(WebCore::RenderView::currentRenderFlowThread):
(WebCore::RenderView::setCurrentRenderFlowThread):
(WebCore::RenderView::pushLayoutState):

LayoutTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-23
Reviewed by David Hyatt.

* fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
* fast/regions/webkit-flow-floats-inside-regions-bounds.html: Added.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Added.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl.html: Added.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical.html: Added.
* fast/regions/webkit-flow-inlines-inside-regions-bounds.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoText-indent and floats push the text out of the container box
commit-queue@webkit.org [Tue, 23 Aug 2011 19:38:05 +0000 (19:38 +0000)]
Text-indent and floats push the text out of the container box
https://bugs.webkit.org/show_bug.cgi?id=66662

Source/WebCore:

Text indent was not propagated when a new float was pushed on the line.
It was only calculated when the logicalLeft/RightOffsetForLine was called.
Because of that RenderBlock::LineBreaker::nextLineBreak used a bigger width
than actually available and made the line render on top of the borders.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-23
Reviewed by David Hyatt.

Tests: fast/block/float/floats-and-text-indent-rl.html
       fast/block/float/floats-and-text-indent.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::textIndentOffset):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):

LayoutTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-23
Reviewed by David Hyatt.

* fast/block/float/floats-and-text-indent-rl.html: Added.
* fast/block/float/floats-and-text-indent.html: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/fast/block/float/floats-and-text-indent-expected.png: Added.
* platform/mac/fast/block/float/floats-and-text-indent-expected.txt: Added.
* platform/mac/fast/block/float/floats-and-text-indent-rl-expected.png: Added.
* platform/mac/fast/block/float/floats-and-text-indent-rl-expected.txt: Added.
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd shareResources flag to 3D graphics context attributes
commit-queue@webkit.org [Tue, 23 Aug 2011 19:30:52 +0000 (19:30 +0000)]
Add shareResources flag to 3D graphics context attributes
https://bugs.webkit.org/show_bug.cgi?id=66516

Patch by Al Patrick <apatrick@chromium.org> on 2011-08-23
Reviewed by James Robinson.

Source/WebCore:

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::create):
* platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::Attributes::Attributes):
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::create):

Source/WebKit/chromium:

* public/WebGraphicsContext3D.h:
(WebKit::WebGraphicsContext3D::Attributes::Attributes):
* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DInternal::initialize):
* src/WebViewImpl.cpp:
(std::getCompositorContextAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=55347
barraclough@apple.com [Tue, 23 Aug 2011 19:28:23 +0000 (19:28 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=55347
"name" and "message" enumerable on *Error.prototype

Reviewed by Sam Weinig.

Source/JavaScriptCore:

The default value of a NativeErrorPrototype's message
property is "", not the name of the error.

* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::NativeErrorConstructor):
* runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::create):
(JSC::NativeErrorConstructor::constructorBody):
* runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::NativeErrorPrototype):
(JSC::NativeErrorPrototype::constructorBody):
* runtime/NativeErrorPrototype.h:
(JSC::NativeErrorPrototype::create):
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::StringPrototype):
* runtime/StringPrototype.h:
(JSC::StringPrototype::create):

LayoutTests:

* fast/js/exception-properties-expected.txt:
* fast/js/script-tests/exception-properties.js:
    - Add tests for value of RangeError.__proto__.{name|message}

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
paroga@webkit.org [Tue, 23 Aug 2011 19:27:32 +0000 (19:27 +0000)]
webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
https://bugs.webkit.org/show_bug.cgi?id=49080

Reviewed by Adam Roben.

Use the string form of pipe open instead (like we do at all other places).

* Scripts/VCSUtils.pm:
(mergeChangeLogs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNew MainFrame views should inherit fixed layout settings from existing MainFrame...
fsamuel@chromium.org [Tue, 23 Aug 2011 19:21:05 +0000 (19:21 +0000)]
New MainFrame views should inherit fixed layout settings from existing MainFrame view in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=66780

Fixed layout mode is set from WebViewImpl, but new main FrameViews are created on loading new pages. The new page's FrameView should get its
fixed layout settings from the current page.

Reviewed by Darin Fisher.

* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFrameView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r93616.
commit-queue@webkit.org [Tue, 23 Aug 2011 19:07:59 +0000 (19:07 +0000)]
Unreviewed, rolling out r93616.
http://trac.webkit.org/changeset/93616
https://bugs.webkit.org/show_bug.cgi?id=66796

"causes fast/css/absolute-child-with-percent-height-inside-
relative-parent.html to fail" (Requested by mwenge2 on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-23

Source/WebCore:

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustPositionedBlock):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::setStaticPositions):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):

LayoutTests:

* fast/inline/absolute-positioned-block-in-centred-block-expected.png: Removed.
* fast/inline/absolute-positioned-block-in-centred-block-expected.txt: Removed.
* fast/inline/absolute-positioned-block-in-centred-block.html: Removed.
* fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Removed.
* fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Removed.
* fast/inline/absolute-positioned-inline-in-centred-block.html: Removed.
* platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
* platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Fix an awful memory leak introduced in r92376.
jocelyn.turcotte@nokia.com [Tue, 23 Aug 2011 18:46:33 +0000 (18:46 +0000)]
[Qt][WK2] Fix an awful memory leak introduced in r92376.
https://bugs.webkit.org/show_bug.cgi?id=65528

Reviewed by Benjamin Poulain.

The non-virtual destructor would create a leak of the tile update buffer because
the NodeUpdateSetTexture's QImage member destructor wouldn't be called.

* UIProcess/qt/SGAgent.h:
(WebKit::NodeUpdate::~NodeUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Update WebSettings to support per-script font settings
commit-queue@webkit.org [Tue, 23 Aug 2011 18:30:33 +0000 (18:30 +0000)]
[chromium] Update WebSettings to support per-script font settings
https://bugs.webkit.org/show_bug.cgi?id=66220

Patch by Matt Falkenhagen <falken@chromium.org> on 2011-08-23
Reviewed by Tony Chang.

* WebKit.gyp:
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setStandardFontFamily):
(WebKit::WebSettingsImpl::setFixedFontFamily):
(WebKit::WebSettingsImpl::setSerifFontFamily):
(WebKit::WebSettingsImpl::setSansSerifFontFamily):
(WebKit::WebSettingsImpl::setCursiveFontFamily):
(WebKit::WebSettingsImpl::setFantasyFontFamily):
* src/WebSettingsImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Do not treat valid cases in ewk_frame_child_add() as failures.
commit-queue@webkit.org [Tue, 23 Aug 2011 18:27:51 +0000 (18:27 +0000)]
[EFL] Do not treat valid cases in ewk_frame_child_add() as failures.
https://bugs.webkit.org/show_bug.cgi?id=66692

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-23
Rubber-stamped by Kenneth Rohde Christiansen.

Frame::page() and FrameTree::parent() returning 0 were being considered
failure cases, however it is possible for them to return 0 when some
arbitrary JavaScript is run.

The function's return type has been changed to make it easier to convey
these cases to the caller (which is only ewk_view_frame_create).

This should make tests like
fast/dom/null-page-show-modal-dialog-crash.html stop outputting
erroneous messages to stderr.

* ewk/ewk_frame.cpp:
(ewk_frame_child_add):
* ewk/ewk_private.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agodiv align="center" rendering problem
robert@webkit.org [Tue, 23 Aug 2011 18:11:44 +0000 (18:11 +0000)]
div align="center" rendering problem
https://bugs.webkit.org/show_bug.cgi?id=4860

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/inline/absolute-positioned-block-in-centred-block.html
       fast/inline/absolute-positioned-inline-in-centred-block.html

When an element with absolute position was the sole or first child of a render block with
centred alignment, it wasn't obeying its parent's alignment. However it would obey the
alignment if it was preceded by some text. The problem was that the element's render object
was getting skipped as leading white space, so it was not included in a normal line block in
a bidi run. Instead, its position was getting set by RenderBlockLineLayout::setStaticPositions()
which does not pay attention to alignment. Preceding the element with some text allowed the object
to get included in a Bidi run and so get a linebox which would get properly aligned.

The fix is to get RenderBlockLineLayout::setStaticPositions() to obey the alignment specified by
the object's container. This allows WebKit to get the same result on the test as Firefox and IE.
Opera has the same bug as unpatched WebKit.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustPositionedBlock): use startAlignedOffsetForBlock
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::updateLogicalWidthForAlignment):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Move the alignment check to updateLogicalWidthForAlignment.
(WebCore::setStaticPositions): use startAlignedOffsetForLine and use startAlignedOffsetForBlock
(WebCore::RenderBlock::LineBreaker::nextLineBreak): use startAlignedOffsetForLine
(WebCore::RenderBlock::startAlignedOffsetForBlock): New function, find the aligned offset using updateLogicalWidthForAlignment
(WebCore::RenderBlock::startAlignedOffsetForLine): ditto

* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::updateLogicalWidthForAlignment):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Move the alignment check to updateLogicalWidthForAlignment.
(WebCore::setStaticPositions): use startAlignedOffsetForLine.
(WebCore::RenderBlock::startAlignedOffsetForLine): New function, find the aligned offset using updateLogicalWidthForAlignment

LayoutTests:

* fast/inline/absolute-positioned-block-in-centred-block-expected.png: Added.
* fast/inline/absolute-positioned-block-in-centred-block-expected.txt: Added.
* fast/inline/absolute-positioned-block-in-centred-block.html: Added.
* fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
* fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
* fast/inline/absolute-positioned-inline-in-centred-block.html: Added.
* platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
* platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
  Both of these two tests were based on the incorrect behaviour of ignoring the alignment specified
  by the container of an element absolute position when there was no text preceding the element.
  The updated results agree with Firefox and IE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove LayerRendererChromium references from TiledLayerChromium
enne@google.com [Tue, 23 Aug 2011 18:08:46 +0000 (18:08 +0000)]
[chromium] Remove LayerRendererChromium references from TiledLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=66433

Reviewed by James Robinson.

Covered by existing tests.

Updated TiledLayerChromium and the texture updater classes to not
access LayerRendererChromium or cache GraphicsContext3D. Some settings
like max texture size were moved from LayerRendererChromium to
CCLayerTreeHost in order to facilitate this refactoring.

LayerTextureUpdaterSkPicture has been #ifdef'd to only work when the
compositor is not threaded. It will need to be refactored more in
order to not own graphics resources from the main thread.

* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::paintContentsIfDirty):
(WebCore::ContentLayerChromium::createTextureUpdater):
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::create):
(WebCore::ImageLayerTextureUpdater::updateTextureRect):
(WebCore::ImageLayerTextureUpdater::ImageLayerTextureUpdater):
(WebCore::ImageLayerChromium::paintContentsIfDirty):
(WebCore::ImageLayerChromium::createTextureUpdater):
* platform/graphics/chromium/ImageLayerChromium.h:
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setLayerRenderer):
(WebCore::LayerChromium::setLayerTreeHost):
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/LayerTextureUpdater.h:
(WebCore::LayerTextureUpdater::LayerTextureUpdater):
* platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
(WebCore::LayerTextureUpdaterCanvas::LayerTextureUpdaterCanvas):
(WebCore::LayerTextureUpdaterBitmap::create):
(WebCore::LayerTextureUpdaterBitmap::LayerTextureUpdaterBitmap):
(WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::create):
(WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
* platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
(WebCore::LayerTextureUpdaterSkPicture::context):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::invalidateRect):
(WebCore::TiledLayerChromium::prepareToUpdate):
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::layerRenderer):
(WebCore::CCLayerTreeHost::contextSupportsMapSub):
(WebCore::CCLayerTreeHost::maxTextureSize):
(WebCore::CCLayerTreeHost::bestTextureFormat):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReduce the amount of RenderLayer rectangles' update when scrolling
jchaffraix@webkit.org [Tue, 23 Aug 2011 18:02:43 +0000 (18:02 +0000)]
Reduce the amount of RenderLayer rectangles' update when scrolling
https://bugs.webkit.org/show_bug.cgi?id=66618

Reviewed by David Hyatt.

Source/WebCore:

This patch avoids recomputing the RenderLayers rectangles if not needed.

The current code path for scrolling would update RenderLayers' repaint rectangles
twice. However we do need to update only children of a fixed element as they are
the only type of layers that move during a scroll.

We just change a call to updateLayerPositions for a call to updateLayerPositionsAfterScroll.
updateLayerPositions being pessimist about the layer's state - because it is called after layout -
it is missing some optimization that can be done during scrolling.

Tests: fast/repaint/scroll-absolute-layer-with-reflection.html
       fast/repaint/scroll-fixed-layer-with-reflection.html
       fast/repaint/scroll-fixed-layer-with-transformed-parent-layer.html
       fast/repaint/scroll-fixed-reflected-layer.html
       fast/repaint/scroll-in-clipped-layer.html
       fast/repaint/scroll-in-fixed-layer.html
       fast/repaint/scroll-in-transformed-layer.html
       fast/repaint/scroll-with-transformed-parent-layer.html

* rendering/RenderLayer.h:
* page/FrameView.cpp:
(WebCore::FrameView::repaintFixedElementsAfterScrolling):
Updated those 2 call sites after updateRepaintRectsAfterScroll renaming.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositionsAfterScroll): Beefed up the method
to take care of also updating the layer's position (that sounded like a bug in
the previous code that is covered by the tests above). Note that we don't care
if one of our ancestor has a fixed position as we are scrolling *inside* this
ancestor.

(WebCore::RenderLayer::scrollTo): Call updateLayerPositionsAfterScroll instead of
updateLayerPositions.

LayoutTests:

* fast/repaint/resources/default.css:
Added more shortcuts.

* fast/repaint/scroll-absolute-layer-with-reflection-expected.txt: Added.
* fast/repaint/scroll-absolute-layer-with-reflection.html: Added.
* fast/repaint/scroll-fixed-layer-with-reflection-expected.txt: Added.
* fast/repaint/scroll-fixed-layer-with-reflection.html: Added.
* fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.txt: Added.
* fast/repaint/scroll-fixed-layer-with-transformed-parent-layer.html: Added.
* fast/repaint/scroll-fixed-reflected-layer-expected.txt: Added.
* fast/repaint/scroll-fixed-reflected-layer.html: Added.
* fast/repaint/scroll-in-clipped-layer-expected.txt: Added.
* fast/repaint/scroll-in-clipped-layer.html: Added.
* fast/repaint/scroll-in-fixed-layer-expected.txt: Added.
* fast/repaint/scroll-in-fixed-layer.html: Added.
* fast/repaint/scroll-in-transformed-layer-expected.txt: Added.
* fast/repaint/scroll-in-transformed-layer.html: Added.
* fast/repaint/scroll-with-transformed-parent-layer-expected.txt: Added.
* fast/repaint/scroll-with-transformed-parent-layer.html: Added.
Those are a variation on the same theme: scrolling inside a layers (sometimes the layer is itself scrolled)
to show that we are still doing the right thing.

* platform/chromium-cg-mac/scroll-absolute-layer-with-reflection-expected.png: Added.
* platform/chromium-cg-mac/scroll-fixed-layer-with-reflection-expected.png: Added.
* platform/chromium-cg-mac/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Added.
* platform/chromium-cg-mac/scroll-fixed-reflected-layer-expected.png: Added.
* platform/chromium-cg-mac/scroll-in-clipped-layer-expected.png: Added.
* platform/chromium-cg-mac/scroll-in-fixed-layer-expected.png: Added.
* platform/chromium-cg-mac/scroll-in-transformed-layer-expected.png: Added.
* platform/chromium-cg-mac/scroll-with-transformed-parent-layer-expected.png: Added.
* platform/chromium-win/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Added.
* platform/chromium-win/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Added.
* platform/chromium-win/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Added.
* platform/chromium-win/fast/repaint/scroll-fixed-reflected-layer-expected.png: Added.
* platform/chromium-win/fast/repaint/scroll-in-clipped-layer-expected.png: Added.
* platform/chromium-win/fast/repaint/scroll-in-fixed-layer-expected.png: Added.
* platform/chromium-win/fast/repaint/scroll-in-transformed-layer-expected.png: Added.
* platform/chromium-win/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Added.
* platform/mac/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Added.
* platform/mac/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Added.
* platform/mac/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Added.
* platform/mac/fast/repaint/scroll-fixed-reflected-layer-expected.png: Added.
* platform/mac/fast/repaint/scroll-in-clipped-layer-expected.png: Added.
* platform/mac/fast/repaint/scroll-in-fixed-layer-expected.png: Added.
* platform/mac/fast/repaint/scroll-in-transformed-layer-expected.png: Added.
* platform/mac/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Added.
Baseline for Chromium and Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNew XML parser: pretty XML tree viewer
jpfau@apple.com [Tue, 23 Aug 2011 17:47:55 +0000 (17:47 +0000)]
New XML parser: pretty XML tree viewer
https://bugs.webkit.org/show_bug.cgi?id=66489

Reviewed by Adam Barth.

* xml/parser/NewXMLDocumentParser.cpp:
(WebCore::NewXMLDocumentParser::finish):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-08-23 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Tue, 23 Aug 2011 17:41:19 +0000 (17:41 +0000)]
2011-08-23  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Disabled inspector/extensions/extensions-resources.html.
        https://bugs.webkit.org/show_bug.cgi?id=66786

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix after r66685.
leandro@webkit.org [Tue, 23 Aug 2011 17:08:21 +0000 (17:08 +0000)]
Unreviewed build fix after r66685.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):
Assert using the right variable name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-08-23 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Tue, 23 Aug 2011 16:31:32 +0000 (16:31 +0000)]
2011-08-23  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed test fix following r93605.

        * http/tests/inspector/resources/extension-main.js:
        (trimURL):
        * inspector/extensions/extensions-resources-expected.txt:
        * inspector/extensions/extensions-resources.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewd, roll chromium reverse DEPS 97698:97834
nduca@chromium.org [Tue, 23 Aug 2011 16:25:36 +0000 (16:25 +0000)]
Unreviewd, roll chromium reverse DEPS 97698:97834
https://bugs.webkit.org/show_bug.cgi?id=66781

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix.
jberlin@webkit.org [Tue, 23 Aug 2011 16:20:06 +0000 (16:20 +0000)]
Build fix.

* inspector/InspectorDOMAgent.h:
HighlightData is a struct, not a class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogarden-o-matic summary should be able to examine failures
abarth@webkit.org [Tue, 23 Aug 2011 16:02:41 +0000 (16:02 +0000)]
garden-o-matic summary should be able to examine failures
https://bugs.webkit.org/show_bug.cgi?id=66748

Reviewed by Dimitri Glazkov.

This patch refactors a bunch of code from summary.js to independent
controllers in controllers.js.  This patch also contains the first
iteration of binding the "examine" event to a the behavior showing the
details view for the tests.  There's more work to do here to make this
work properly (and elegantly), but this patch is a start.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Treat the case of WebCore::History->currentItem() returning NULL.
commit-queue@webkit.org [Tue, 23 Aug 2011 15:48:55 +0000 (15:48 +0000)]
[EFL] Treat the case of WebCore::History->currentItem() returning NULL.
https://bugs.webkit.org/show_bug.cgi?id=66698

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-23
Reviewed by Kenneth Rohde Christiansen.

WebCore::History->currentItem() may return NULL, and we'd better treat
it in ewk_history_history_item_current_get itself than propagate the
issue to _ewk_history_item_new.

* ewk/ewk_history.cpp:
(ewk_history_history_item_current_get):
* ewk/ewk_history.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Extensions API] provide access to page resources
caseq@chromium.org [Tue, 23 Aug 2011 15:35:58 +0000 (15:35 +0000)]
Web Inspector: [Extensions API] provide access to page resources
https://bugs.webkit.org/show_bug.cgi?id=66767

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/extensions/extensions-resources.html

* inspector/front-end/ExtensionAPI.js:
(WebInspector.injectedExtensionAPI.EventSinkImpl.prototype.addListener):
(WebInspector.injectedExtensionAPI):
(WebInspector.injectedExtensionAPI.RequestImpl.prototype.getContent):
(WebInspector.injectedExtensionAPI.InspectedWindow.resourceDispatch):
(WebInspector.injectedExtensionAPI.InspectedWindow.resourceContentDispatch):
(WebInspector.injectedExtensionAPI.InspectedWindow):
(WebInspector.injectedExtensionAPI.InspectedWindow.prototype.eval):
(WebInspector.injectedExtensionAPI.InspectedWindow.prototype.getResources):
(WebInspector.injectedExtensionAPI.InspectedWindow.prototype.getResources.callbackWrapper):
(WebInspector.injectedExtensionAPI.ResourceImpl.prototype.get url):
(WebInspector.injectedExtensionAPI.ResourceImpl.prototype.get type):
(WebInspector.injectedExtensionAPI.ResourceImpl.prototype.getContent):
(WebInspector.injectedExtensionAPI.ResourceImpl.prototype.setContent):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._notifyResourceAdded):
(WebInspector.ExtensionServer.prototype.notifyResourceContentCommitted):
(WebInspector.ExtensionServer.prototype._makeResource):
(WebInspector.ExtensionServer.prototype._onGetPageResources):
(WebInspector.ExtensionServer.prototype._getResourceContent):
(WebInspector.ExtensionServer.prototype._onGetRequestContent):
(WebInspector.ExtensionServer.prototype._onGetResourceContent):
(WebInspector.ExtensionServer.prototype._onSetResourceContent):
(WebInspector.ExtensionServer.prototype.initExtensions):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.addRevision):

LayoutTests:

* http/tests/inspector/resources/extension-main.js:
(trimURL):
* inspector/extensions/extensions-api-expected.txt:
* inspector/extensions/extensions-network-expected.txt:
* inspector/extensions/extensions-network.html:
* inspector/extensions/extensions-resources-expected.txt: Added.
* inspector/extensions/extensions-resources.html: Added.
* inspector/extensions/resources/Ahem.ttf:
* inspector/extensions/resources/test-script.js: Added.
(__test_function):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-08-23 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 23 Aug 2011 15:08:14 +0000 (15:08 +0000)]
2011-08-23  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: fixing build. One line drive-by typo fix in the inspector shortcut (Esc -> Backspace).

        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::highlightFrame):
        * inspector/front-end/treeoutline.js:
        (TreeOutline.prototype._treeKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: differentiate element highlight colors for margin and padding
apavlov@chromium.org [Tue, 23 Aug 2011 14:38:07 +0000 (14:38 +0000)]
Web Inspector: differentiate element highlight colors for margin and padding
https://bugs.webkit.org/show_bug.cgi?id=37768

The highlighting WIP API is slightly changed: clients will specify colors for certain elements of the highlighted objects,
rather than a generic "highlighting mode". This allows to:
- use entirely custom colors for highlighting (and vary them over time);
- display any combination of fill/outline for the highlighted area;
- highlight any combinations of element parts.

Reviewed by Pavel Feldman.

* inspector/DOMNodeHighlighter.cpp:
(WebCore::DOMNodeHighlighter::drawHighlight):
* inspector/DOMNodeHighlighter.h:
* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::parseColor):
(WebCore::parseConfigColor):
(WebCore::InspectorDOMAgent::~InspectorDOMAgent):
(WebCore::InspectorDOMAgent::clearFrontend):
(WebCore::InspectorDOMAgent::highlightedNode):
(WebCore::InspectorDOMAgent::handleMousePress):
(WebCore::InspectorDOMAgent::mouseDidMoveOverElement):
(WebCore::InspectorDOMAgent::setSearchingForNode):
(WebCore::InspectorDOMAgent::setInspectModeEnabled):
(WebCore::InspectorDOMAgent::setHighlightDataFromConfig):
(WebCore::InspectorDOMAgent::highlight):
(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::highlightNode):
(WebCore::InspectorDOMAgent::highlightFrame):
(WebCore::InspectorDOMAgent::hideHighlight):
(WebCore::InspectorDOMAgent::drawHighlight):
* inspector/InspectorDOMAgent.h:
* inspector/front-end/Color.js:
(WebInspector.Color.fromRGBA):
(WebInspector.Color.prototype.toProtocolRGBA):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.setSearchingForNode):
* inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype._highlightDOMNode.handleMouseOver):
(WebInspector.MetricsSidebarPane.prototype._highlightDOMNode.handleMouseOut):
(WebInspector.MetricsSidebarPane.prototype._highlightDOMNode):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameTreeElement.prototype.set hovered):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._highlightRect):
* inspector/front-end/inspector.css:
* inspector/front-end/inspector.js:
(WebInspector.buildHighlightConfig):
(WebInspector.highlightDOMNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Add auxiliary history functions for DRT
commit-queue@webkit.org [Tue, 23 Aug 2011 13:37:39 +0000 (13:37 +0000)]
[EFL] Add auxiliary history functions for DRT
https://bugs.webkit.org/show_bug.cgi?id=66700

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-23
Reviewed by Kent Tamura.

EFL's DumpRenderTree implementation needs some private, auxiliary
functions in ewk in order to iterate and dump the history tree when
necessary.

* ewk/ewk_history.cpp:
(ewk_history_item_target_get):
(ewk_history_item_target_is):
(ewk_history_item_children_get):
* ewk/ewk_private.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r93579.
commit-queue@webkit.org [Tue, 23 Aug 2011 13:36:35 +0000 (13:36 +0000)]
Unreviewed, rolling out r93579.
http://trac.webkit.org/changeset/93579
https://bugs.webkit.org/show_bug.cgi?id=66774

"ASSERTION FAILED: m_purgePreventCount" (Requested by tonyg-cr
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-23

* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::getFontDataForCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Fix build on Lion
vestbo@webkit.org [Tue, 23 Aug 2011 13:26:26 +0000 (13:26 +0000)]
[Qt] Fix build on Lion

https://bugs.webkit.org/show_bug.cgi?id=66770

Reviewed by Andreas Kling.

We were mistakenly picking up mac/WebCoreSystemInterface.h instead of
the Qt one, and building on Lion revealed this when a typedef for
IOSurfaceRef was wrapped in PLATFORM(MAC).

For now we fix this by including WebCoreSystemInterface using
brackets, so that we'll pick up the right file based on the
include paths. This also means exposing a few missing enums
in our own version of the file, so those were added.

Lasty, we need to link against the right system interface library
on Lion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Add auxiliary ewk_util functions for DRT.
commit-queue@webkit.org [Tue, 23 Aug 2011 13:19:40 +0000 (13:19 +0000)]
[EFL] Add auxiliary ewk_util functions for DRT.
https://bugs.webkit.org/show_bug.cgi?id=66702

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-23
Reviewed by Kenneth Rohde Christiansen.

Add some auxiliary functions needed by EFL's DRT implementation. They
all revolve around talking to the garbage collector and counting the
worker threads.

* ewk/ewk_private.h:
* ewk/ewk_util.cpp:
(ewk_util_javascript_gc_collect):
(ewk_util_javascript_gc_alternate_thread_collect):
(ewk_util_javascript_gc_object_count_get):
(ewk_util_worker_thread_count):
(ewk_util_dpi_get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Remove a non-existent test from the skipped list.
ossy@webkit.org [Tue, 23 Aug 2011 13:12:28 +0000 (13:12 +0000)]
[Qt] Unreviewed gardening. Remove a non-existent test from the skipped list.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove last occurrences of PLATFORM(ANDROID)
steveblock@google.com [Tue, 23 Aug 2011 13:07:19 +0000 (13:07 +0000)]
Remove last occurrences of PLATFORM(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=66763

Reviewed by Tony Gentilcore.

Source/JavaScriptCore:

* wtf/Platform.h:

Source/WebCore:

No new tests, removing dead code only.

* bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::checkMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove Android-specific modifications to non-client-based Geolocation
steveblock@google.com [Tue, 23 Aug 2011 12:45:59 +0000 (12:45 +0000)]
Remove Android-specific modifications to non-client-based Geolocation
https://bugs.webkit.org/show_bug.cgi?id=66759

Reviewed by Tony Gentilcore.

No new tests, removing dead code only.

* page/Geolocation.cpp:
* page/Geolocation.h:
* platform/GeolocationService.h:
* platform/efl/GeolocationServiceEfl.cpp:
* platform/efl/GeolocationServiceEfl.h:
* platform/gtk/GeolocationServiceGtk.cpp:
* platform/gtk/GeolocationServiceGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: switch to using BreakpointManager.
podivilov@chromium.org [Tue, 23 Aug 2011 12:43:31 +0000 (12:43 +0000)]
Web Inspector: switch to using BreakpointManager.
https://bugs.webkit.org/show_bug.cgi?id=66225

Reviewed by Pavel Feldman.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addScript.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
(WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.PresentationBreakpoint.prototype.loadSnippet):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove all mention of removed Android files from build scripts
steveblock@google.com [Tue, 23 Aug 2011 12:40:59 +0000 (12:40 +0000)]
Remove all mention of removed Android files from build scripts
https://bugs.webkit.org/show_bug.cgi?id=66755

Reviewed by Tony Gentilcore.

.:

* Source/cmake/WebKitPackaging.cmake:

Source/JavaScriptCore:

* JavaScriptCore.gyp/JavaScriptCore.gyp:
* JavaScriptCore.gypi:
* gyp/JavaScriptCore.gyp:

Source/WebCore:

No new tests, removing dead code only.

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* gyp/WebCore.gyp:

Source/WebKit2:

* Scripts/generate-forwarding-headers.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=66651
tkent@chromium.org [Tue, 23 Aug 2011 12:39:55 +0000 (12:39 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=66651
Move <input type=range> tests to fast/forms/range/

Reviewed by Tony Chang.

* fast/forms/ValidityState-stepMismatch-expected.txt: Removed 'range' part.
* fast/forms/input-appearance-range-rtl-expected.html: Removed.
* fast/forms/input-appearance-range-rtl.html: Removed.
* fast/forms/input-appearance-range.html: Removed.
* fast/forms/input-stepup-stepdown-expected.txt: Removed 'range' part.
* fast/forms/input-stepup-stepdown-from-renderer-expected.txt: Removed 'range' part.
* fast/forms/input-valueasnumber-range-expected.txt: Removed.
* fast/forms/input-valueasnumber-range.html: Removed.
* fast/forms/range: Added.
* fast/forms/range-default-value-expected.txt: Removed.
* fast/forms/range-default-value.html: Removed.
* fast/forms/range-drag-expected.txt: Removed.
* fast/forms/range-drag.html: Removed.
* fast/forms/range-input-dynamic-oninput-expected.txt: Removed.
* fast/forms/range-input-dynamic-oninput.html: Removed.
* fast/forms/range-keyoperation-expected.txt: Removed.
* fast/forms/range-keyoperation.html: Removed.
* fast/forms/range-reset-expected.txt: Removed.
* fast/forms/range-reset.html: Removed.
* fast/forms/range-set-attribute-expected.txt: Removed.
* fast/forms/range-set-attribute.html: Removed.
* fast/forms/range-thumb-height-percentage.html: Removed.
* fast/forms/range/ValidityState-stepMismatch-range-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-stepMismatch-expected.txt.
* fast/forms/range/ValidityState-stepMismatch-range.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js.
* fast/forms/range/input-appearance-range-rtl-expected.html: Copied from LayoutTests/fast/forms/input-appearance-range-rtl-expected.html.
* fast/forms/range/input-appearance-range-rtl.html: Copied from LayoutTests/fast/forms/input-appearance-range-rtl.html.
* fast/forms/range/input-appearance-range.html: Copied from LayoutTests/fast/forms/input-appearance-range.html.
* fast/forms/range/input-valueasnumber-range-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-range-expected.txt.
* fast/forms/range/input-valueasnumber-range.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-range.js.
* fast/forms/range/range-default-value-expected.txt: Copied from LayoutTests/fast/forms/range-default-value-expected.txt.
* fast/forms/range/range-default-value.html: Copied from LayoutTests/fast/forms/range-default-value.html.
* fast/forms/range/range-drag-expected.txt: Copied from LayoutTests/fast/forms/range-drag-expected.txt.
* fast/forms/range/range-drag.html: Copied from LayoutTests/fast/forms/range-drag.html.
* fast/forms/range/range-input-dynamic-oninput-expected.txt: Copied from LayoutTests/fast/forms/range-input-dynamic-oninput-expected.txt.
* fast/forms/range/range-input-dynamic-oninput.html: Copied from LayoutTests/fast/forms/range-input-dynamic-oninput.html.
* fast/forms/range/range-keyoperation-expected.txt: Copied from LayoutTests/fast/forms/range-keyoperation-expected.txt.
* fast/forms/range/range-keyoperation.html: Copied from LayoutTests/fast/forms/range-keyoperation.html.
* fast/forms/range/range-reset-expected.txt: Copied from LayoutTests/fast/forms/range-reset-expected.txt.
* fast/forms/range/range-reset.html: Copied from LayoutTests/fast/forms/range-reset.html.
* fast/forms/range/range-set-attribute-expected.txt: Copied from LayoutTests/fast/forms/range-set-attribute-expected.txt.
* fast/forms/range/range-set-attribute.html: Copied from LayoutTests/fast/forms/range-set-attribute.html.
* fast/forms/range/range-stepup-stepdown-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-expected.txt.
* fast/forms/range/range-stepup-stepdown-from-renderer-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt.
* fast/forms/range/range-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js.
* fast/forms/range/range-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js.
* fast/forms/range/range-thumb-height-percentage.html: Copied from LayoutTests/fast/forms/range-thumb-height-percentage.html.
* fast/forms/range/slider-delete-while-dragging-thumb-expected.txt: Copied from LayoutTests/fast/forms/slider-delete-while-dragging-thumb-expected.txt.
* fast/forms/range/slider-delete-while-dragging-thumb.html: Copied from LayoutTests/fast/forms/slider-delete-while-dragging-thumb.html.
* fast/forms/range/slider-hit-testing-expected.txt: Copied from LayoutTests/fast/forms/slider-hit-testing-expected.txt.
* fast/forms/range/slider-hit-testing.html: Copied from LayoutTests/fast/forms/slider-hit-testing.html.
* fast/forms/range/slider-mouse-events-expected.txt: Copied from LayoutTests/fast/forms/slider-mouse-events-expected.txt.
* fast/forms/range/slider-mouse-events.html: Copied from LayoutTests/fast/forms/slider-mouse-events.html.
* fast/forms/range/slider-onchange-event-expected.txt: Copied from LayoutTests/fast/forms/slider-onchange-event-expected.txt.
* fast/forms/range/slider-onchange-event.html: Copied from LayoutTests/fast/forms/slider-onchange-event.html.
* fast/forms/range/slider-padding.html: Copied from LayoutTests/fast/forms/slider-padding.html.
* fast/forms/range/slider-thumb-shared-style.html: Copied from LayoutTests/fast/forms/slider-thumb-shared-style.html.
* fast/forms/range/slider-thumb-stylability.html: Copied from LayoutTests/fast/forms/slider-thumb-stylability.html.
* fast/forms/range/slider-transformed-expected.txt: Copied from LayoutTests/fast/forms/slider-transformed-expected.txt.
* fast/forms/range/slider-transformed.html: Copied from LayoutTests/fast/forms/slider-transformed.html.
* fast/forms/range/slider-zoomed-expected.txt: Copied from LayoutTests/fast/forms/slider-zoomed-expected.txt.
* fast/forms/range/slider-zoomed.html: Copied from LayoutTests/fast/forms/slider-zoomed.html.
* fast/forms/range/thumbslider-crash-expected.txt: Copied from LayoutTests/fast/forms/thumbslider-crash-expected.txt.
* fast/forms/range/thumbslider-crash.html: Copied from LayoutTests/fast/forms/thumbslider-crash.html.
* fast/forms/range/thumbslider-no-parent-slider.html: Copied from LayoutTests/fast/forms/thumbslider-no-parent-slider.html.
* fast/forms/script-tests/ValidityState-stepMismatch.js: Removed 'range' part.
* fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Removed 'range' part.
* fast/forms/script-tests/input-stepup-stepdown.js: Removed 'range' part.
* fast/forms/script-tests/input-valueasnumber-range.js: Removed.
* fast/forms/slider-delete-while-dragging-thumb-expected.txt: Removed.
* fast/forms/slider-delete-while-dragging-thumb.html: Removed.
* fast/forms/slider-hit-testing-expected.txt: Removed.
* fast/forms/slider-hit-testing.html: Removed.
* fast/forms/slider-mouse-events-expected.txt: Removed.
* fast/forms/slider-mouse-events.html: Removed.
* fast/forms/slider-onchange-event-expected.txt: Removed.
* fast/forms/slider-onchange-event.html: Removed.
* fast/forms/slider-padding.html: Removed.
* fast/forms/slider-thumb-shared-style.html: Removed.
* fast/forms/slider-thumb-stylability.html: Removed.
* fast/forms/slider-transformed-expected.txt: Removed.
* fast/forms/slider-transformed.html: Removed.
* fast/forms/slider-zoomed-expected.txt: Removed.
* fast/forms/slider-zoomed.html: Removed.
* fast/forms/thumbslider-crash-expected.txt: Removed.
* fast/forms/thumbslider-crash.html: Removed.
* fast/forms/thumbslider-no-parent-slider.html: Removed.
* platform/chromium-cg-mac-leopard/fast/forms/input-appearance-range-expected.png: Removed.
* platform/chromium-cg-mac-leopard/fast/forms/range: Added.
* platform/chromium-cg-mac-leopard/fast/forms/range/input-appearance-range-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/input-appearance-range-expected.png.
* platform/chromium-cg-mac-leopard/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/slider-padding-expected.png.
* platform/chromium-cg-mac-leopard/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/slider-thumb-shared-style-expected.png.
* platform/chromium-cg-mac-leopard/fast/forms/range/slider-thumb-stylability-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/slider-thumb-stylability-expected.png.
* platform/chromium-cg-mac-leopard/fast/forms/range/thumbslider-no-parent-slider-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/thumbslider-no-parent-slider-expected.png.
* platform/chromium-cg-mac-leopard/fast/forms/slider-padding-expected.png: Removed.
* platform/chromium-cg-mac-leopard/fast/forms/slider-thumb-shared-style-expected.png: Removed.
* platform/chromium-cg-mac-leopard/fast/forms/slider-thumb-stylability-expected.png: Removed.
* platform/chromium-cg-mac-leopard/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
* platform/chromium-linux/fast/forms/input-appearance-range-expected.png: Removed.
* platform/chromium-linux/fast/forms/input-appearance-range-expected.txt: Removed.
* platform/chromium-linux/fast/forms/range: Added.
* platform/chromium-linux/fast/forms/range-thumb-height-percentage-expected.png: Removed.
* platform/chromium-linux/fast/forms/range/input-appearance-range-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-appearance-range-expected.png.
* platform/chromium-linux/fast/forms/range/input-appearance-range-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/input-appearance-range-expected.txt.
* platform/chromium-linux/fast/forms/range/range-thumb-height-percentage-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/range-thumb-height-percentage-expected.png.
* platform/chromium-linux/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/slider-padding-expected.png.
* platform/chromium-linux/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/slider-thumb-shared-style-expected.png.
* platform/chromium-linux/fast/forms/range/thumbslider-no-parent-slider-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/thumbslider-no-parent-slider-expected.png.
* platform/chromium-linux/fast/forms/slider-padding-expected.png: Removed.
* platform/chromium-linux/fast/forms/slider-thumb-shared-style-expected.png: Removed.
* platform/chromium-linux/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
* platform/chromium-win/fast/forms/input-appearance-range-expected.png: Removed.
* platform/chromium-win/fast/forms/input-appearance-range-expected.txt: Removed.
* platform/chromium-win/fast/forms/range: Added.
* platform/chromium-win/fast/forms/range-thumb-height-percentage-expected.png: Removed.
* platform/chromium-win/fast/forms/range-thumb-height-percentage-expected.txt: Removed.
* platform/chromium-win/fast/forms/range/input-appearance-range-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-range-expected.png.
* platform/chromium-win/fast/forms/range/input-appearance-range-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/input-appearance-range-expected.txt.
* platform/chromium-win/fast/forms/range/range-thumb-height-percentage-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/range-thumb-height-percentage-expected.png.
* platform/chromium-win/fast/forms/range/range-thumb-height-percentage-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/range-thumb-height-percentage-expected.txt.
* platform/chromium-win/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/slider-padding-expected.png.
* platform/chromium-win/fast/forms/range/slider-padding-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/slider-padding-expected.txt.
* platform/chromium-win/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/slider-thumb-shared-style-expected.png.
* platform/chromium-win/fast/forms/range/slider-thumb-shared-style-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/slider-thumb-shared-style-expected.txt.
* platform/chromium-win/fast/forms/range/slider-thumb-stylability-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/slider-thumb-stylability-expected.png.
* platform/chromium-win/fast/forms/range/thumbslider-no-parent-slider-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.png.
* platform/chromium-win/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.txt.
* platform/chromium-win/fast/forms/slider-padding-expected.png: Removed.
* platform/chromium-win/fast/forms/slider-padding-expected.txt: Removed.
* platform/chromium-win/fast/forms/slider-thumb-shared-style-expected.png: Removed.
* platform/chromium-win/fast/forms/slider-thumb-shared-style-expected.txt: Removed.
* platform/chromium-win/fast/forms/slider-thumb-stylability-expected.png: Removed.
* platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
* platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/gtk/fast/forms/input-appearance-range-expected.txt: Removed.
* platform/gtk/fast/forms/range: Added.
* platform/gtk/fast/forms/range-thumb-height-percentage-expected.png: Removed.
* platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt: Removed.
* platform/gtk/fast/forms/range/input-appearance-range-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/input-appearance-range-expected.txt.
* platform/gtk/fast/forms/range/range-thumb-height-percentage-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/range-thumb-height-percentage-expected.png.
* platform/gtk/fast/forms/range/range-thumb-height-percentage-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt.
* platform/gtk/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/slider-padding-expected.png.
* platform/gtk/fast/forms/range/slider-padding-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/slider-padding-expected.txt.
* platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/slider-thumb-shared-style-expected.png.
* platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt.
* platform/gtk/fast/forms/range/slider-thumb-stylability-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/slider-thumb-stylability-expected.png.
* platform/gtk/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/slider-thumb-stylability-expected.txt.
* platform/gtk/fast/forms/range/slider-transformed-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/slider-transformed-expected.txt.
* platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt.
* platform/gtk/fast/forms/slider-padding-expected.png: Removed.
* platform/gtk/fast/forms/slider-padding-expected.txt: Removed.
* platform/gtk/fast/forms/slider-thumb-shared-style-expected.png: Removed.
* platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt: Removed.
* platform/gtk/fast/forms/slider-thumb-stylability-expected.png: Removed.
* platform/gtk/fast/forms/slider-thumb-stylability-expected.txt: Removed.
* platform/gtk/fast/forms/slider-transformed-expected.txt: Removed.
* platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt: Removed.
* platform/mac-leopard/fast/forms/range: Added.
* platform/mac-leopard/fast/forms/range-thumb-height-percentage-expected.png: Removed.
* platform/mac-leopard/fast/forms/range/range-thumb-height-percentage-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/range-thumb-height-percentage-expected.png.
* platform/mac-leopard/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/slider-padding-expected.png.
* platform/mac-leopard/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/slider-thumb-shared-style-expected.png.
* platform/mac-leopard/fast/forms/range/slider-thumb-stylability-expected.png: Copied from LayoutTests/platform/mac-leopard/fast/forms/slider-thumb-stylability-expected.png.
* platform/mac-leopard/fast/forms/slider-padding-expected.png: Removed.
* platform/mac-leopard/fast/forms/slider-thumb-shared-style-expected.png: Removed.
* platform/mac-leopard/fast/forms/slider-thumb-stylability-expected.png: Removed.
* platform/mac/fast/forms/input-appearance-range-expected.png: Removed.
* platform/mac/fast/forms/input-appearance-range-expected.txt: Removed.
* platform/mac/fast/forms/range: Added.
* platform/mac/fast/forms/range-thumb-height-percentage-expected.png: Removed.
* platform/mac/fast/forms/range-thumb-height-percentage-expected.txt: Removed.
* platform/mac/fast/forms/range/input-appearance-range-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-range-expected.png.
* platform/mac/fast/forms/range/input-appearance-range-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-range-expected.txt.
* platform/mac/fast/forms/range/range-thumb-height-percentage-expected.png: Copied from LayoutTests/platform/mac/fast/forms/range-thumb-height-percentage-expected.png.
* platform/mac/fast/forms/range/range-thumb-height-percentage-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/range-thumb-height-percentage-expected.txt.
* platform/mac/fast/forms/range/slider-padding-expected.png: Copied from LayoutTests/platform/mac/fast/forms/slider-padding-expected.png.
* platform/mac/fast/forms/range/slider-padding-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/slider-padding-expected.txt.
* platform/mac/fast/forms/range/slider-thumb-shared-style-expected.png: Copied from LayoutTests/platform/mac/fast/forms/slider-thumb-shared-style-expected.png.
* platform/mac/fast/forms/range/slider-thumb-shared-style-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/slider-thumb-shared-style-expected.txt.
* platform/mac/fast/forms/range/slider-thumb-stylability-expected.png: Copied from LayoutTests/platform/mac/fast/forms/slider-thumb-stylability-expected.png.
* platform/mac/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/slider-thumb-stylability-expected.txt.
* platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.png: Copied from LayoutTests/platform/mac/fast/forms/thumbslider-no-parent-slider-expected.png.
* platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/thumbslider-no-parent-slider-expected.txt.
* platform/mac/fast/forms/slider-padding-expected.png: Removed.
* platform/mac/fast/forms/slider-padding-expected.txt: Removed.
* platform/mac/fast/forms/slider-thumb-shared-style-expected.png: Removed.
* platform/mac/fast/forms/slider-thumb-shared-style-expected.txt: Removed.
* platform/mac/fast/forms/slider-thumb-stylability-expected.png: Removed.
* platform/mac/fast/forms/slider-thumb-stylability-expected.txt: Removed.
* platform/mac/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
* platform/mac/fast/forms/thumbslider-no-parent-slider-expected.txt: Removed.
* platform/qt-mac/Skipped:
* platform/qt/Skipped:
* platform/qt/fast/forms/range: Added.
* platform/qt/fast/forms/range-thumb-height-percentage-expected.txt: Removed.
* platform/qt/fast/forms/range/range-thumb-height-percentage-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/range-thumb-height-percentage-expected.txt.
* platform/qt/fast/forms/range/slider-thumb-shared-style-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/slider-thumb-shared-style-expected.txt.
* platform/qt/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/slider-thumb-stylability-expected.txt.
* platform/qt/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/thumbslider-no-parent-slider-expected.txt.
* platform/qt/fast/forms/slider-thumb-shared-style-expected.txt: Removed.
* platform/qt/fast/forms/slider-thumb-stylability-expected.txt: Removed.
* platform/qt/fast/forms/thumbslider-no-parent-slider-expected.txt: Removed.
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] ViewportInteractionEngine: the position of the content is not corrected...
benjamin.poulain@nokia.com [Tue, 23 Aug 2011 12:38:23 +0000 (12:38 +0000)]
[Qt][WK2] ViewportInteractionEngine: the position of the content is not corrected when scaling the page manually
https://bugs.webkit.org/show_bug.cgi?id=66672

Reviewed by Kenneth Rohde Christiansen.

Add the method animateContentIntoBoundariesIfNeeded() to move the content back into both scale and position boundaries.
This method is now used as the entry point for animations in order to avoid bugs regarding scale or position.

The existing animation methods were renamed accordingly for clarity and consistency with the updateContent methods.

* UIProcess/qt/ViewportInteractionEngine.cpp:
(WebKit::ViewportInteractionEngine::panGestureEnded):
(WebKit::ViewportInteractionEngine::pinchGestureEnded):
(WebKit::ViewportInteractionEngine::animateContentIntoBoundariesIfNeeded):
(WebKit::ViewportInteractionEngine::animateContentPositionIntoBoundariesIfNeeded):
(WebKit::ViewportInteractionEngine::animateContentScaleIntoBoundariesIfNeeded):
* UIProcess/qt/ViewportInteractionEngine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Chromium] Fix handling of aggregate names in profiler.
mnaganov@chromium.org [Tue, 23 Aug 2011 12:21:01 +0000 (12:21 +0000)]
Web Inspector: [Chromium] Fix handling of aggregate names in profiler.
https://bugs.webkit.org/show_bug.cgi?id=66753

Reviewed by Pavel Feldman.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._buildAggregates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove WebCore/editing/android and other Android-specific directories
abarth@webkit.org [Tue, 23 Aug 2011 10:34:28 +0000 (10:34 +0000)]
Remove WebCore/editing/android and other Android-specific directories
https://bugs.webkit.org/show_bug.cgi?id=66739

Reviewed by Steve Block.

Now that Android shares more code with Chromium, we don't need these
Android-specific files.

Source/JavaScriptCore:

* wtf/android: Removed.
* wtf/android/AndroidThreading.h: Removed.
* wtf/android/MainThreadAndroid.cpp: Removed.

Source/WebCore:

* editing/android: Removed.
* editing/android/EditorAndroid.cpp: Removed.
* history/android: Removed.
* history/android/AndroidWebHistoryBridge.h: Removed.
* history/android/HistoryItemAndroid.cpp: Removed.
* page/android: Removed.
* page/android/DragControllerAndroid.cpp: Removed.
* page/android/EventHandlerAndroid.cpp: Removed.
* platform/network/android: Removed.
* platform/network/android/AuthenticationChallenge.h: Removed.
* platform/network/android/CookieJarAndroid.cpp: Removed.
* platform/network/android/ProxyServerAndroid.cpp: Removed.
* platform/network/android/ResourceError.h: Removed.
* platform/network/android/ResourceHandleAndroid.cpp: Removed.
* platform/network/android/ResourceLoaderAndroid.h: Removed.
* platform/network/android/ResourceRequest.h: Removed.
* platform/network/android/ResourceRequestAndroid.cpp: Removed.
* platform/network/android/ResourceResponse.h: Removed.
* platform/text/android: Removed.
* platform/text/android/HyphenationAndroid.cpp: Removed.
* platform/text/android/TextBreakIteratorInternalICU.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove WebCore/platform/android
abarth@webkit.org [Tue, 23 Aug 2011 09:59:48 +0000 (09:59 +0000)]
Remove WebCore/platform/android
https://bugs.webkit.org/show_bug.cgi?id=66734

Reviewed by Steve Block.

This directory is not needed now that Android shares more code with
Chromium.

* platform/android: Removed.
* platform/android/ClipboardAndroid.cpp: Removed.
* platform/android/ClipboardAndroid.h: Removed.
* platform/android/CursorAndroid.cpp: Removed.
* platform/android/DragDataAndroid.cpp: Removed.
* platform/android/EventLoopAndroid.cpp: Removed.
* platform/android/FileSystemAndroid.cpp: Removed.
* platform/android/GeolocationServiceAndroid.cpp: Removed.
* platform/android/GeolocationServiceAndroid.h: Removed.
* platform/android/GeolocationServiceBridge.cpp: Removed.
* platform/android/GeolocationServiceBridge.h: Removed.
* platform/android/KeyEventAndroid.cpp: Removed.
* platform/android/LanguageAndroid.cpp: Removed.
* platform/android/LocalizedStringsAndroid.cpp: Removed.
* platform/android/PlatformBridge.h: Removed.
* platform/android/PlatformTouchEventAndroid.cpp: Removed.
* platform/android/PlatformTouchPointAndroid.cpp: Removed.
* platform/android/PopupMenuAndroid.cpp: Removed.
* platform/android/RenderThemeAndroid.cpp: Removed.
* platform/android/RenderThemeAndroid.h: Removed.
* platform/android/SSLKeyGeneratorAndroid.cpp: Removed.
* platform/android/ScreenAndroid.cpp: Removed.
* platform/android/ScrollViewAndroid.cpp: Removed.
* platform/android/SearchPopupMenuAndroid.cpp: Removed.
* platform/android/SharedTimerAndroid.cpp: Removed.
* platform/android/SoundAndroid.cpp: Removed.
* platform/android/SystemTimeAndroid.cpp: Removed.
* platform/android/TemporaryLinkStubs.cpp: Removed.
* platform/android/WidgetAndroid.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy/common/config/build.py shouldn't mention non-existant Android directory
abarth@webkit.org [Tue, 23 Aug 2011 09:52:26 +0000 (09:52 +0000)]
webkitpy/common/config/build.py shouldn't mention non-existant Android directory
https://bugs.webkit.org/show_bug.cgi?id=66737

Reviewed by Steve Block.

This directory doesn't exist anymore now that the Android port shares
more code with Chromium.

* Scripts/webkitpy/common/config/build.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-08-23 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 23 Aug 2011 09:47:50 +0000 (09:47 +0000)]
2011-08-23  Pavel Feldman  <pfeldman@google.com>

        Not reviewed. Adding a file that slipped from r93586.

        * inspector/generate-protocol-externs: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: generate protocol externs API for the front-end compilation.
pfeldman@chromium.org [Tue, 23 Aug 2011 09:33:54 +0000 (09:33 +0000)]
Web Inspector: generate protocol externs API for the front-end compilation.
https://bugs.webkit.org/show_bug.cgi?id=66677

Reviewed by Tony Gentilcore.

Source/WebCore:

* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setAttributesText):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
* inspector/InspectorDebuggerAgent.h:
* inspector/compile-front-end.sh: Added.
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.setAttribute):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.setBreakpoint):
* inspector/front-end/externs.js: Added.
(console.warn):

LayoutTests:

* inspector/debugger/debugger-set-breakpoint-regex.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-08-23 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 23 Aug 2011 09:32:42 +0000 (09:32 +0000)]
2011-08-23  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed build fix for compile error on Windows for r93560.

        * runtime/SamplingCounter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Prepare utilities.js for compilation.
pfeldman@chromium.org [Tue, 23 Aug 2011 09:23:31 +0000 (09:23 +0000)]
Web Inspector: Prepare utilities.js for compilation.
https://bugs.webkit.org/show_bug.cgi?id=66656

Removes "this" usage in functions, does not define getters for offsets.

Reviewed by Tony Gentilcore.

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleMessage.prototype._format):
(WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.valueFormatter):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.appropriateSelectorFor):
(WebInspector.DOMNode.prototype.isAncestor):
(WebInspector.DOMNode.prototype.isDescendant):
(WebInspector.DOMNode.prototype.isWhitespace):
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype._resizerDragging):
(WebInspector.DataGridNode.prototype.isEventWithinDisclosureTriangle):
* inspector/front-end/Drawer.js:
(WebInspector.Drawer.prototype.get savedHeight):
(WebInspector.Drawer.prototype.onResize):
(WebInspector.Drawer.prototype._startStatusBarDragging):
(WebInspector.Drawer.prototype._statusBarDragging):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.updateModifiedNodes):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
(WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes.crumbsAreSmallerThanContainer):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.findTreeElement):
(WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
():
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject):
* inspector/front-end/ResourceTimingView.js:
(WebInspector.ResourceTimingView.createTimingTable):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.BaseStorageTreeElement.prototype.isEventWithinDisclosureTriangle):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._startSidebarResizeDrag):
* inspector/front-end/SoftContextMenu.js:
(.WebInspector.SoftContextMenu.prototype.show):
* inspector/front-end/Toolbar.js:
(WebInspector.ToolbarDropdown.prototype.show):
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype._updateHoveredElement):
* inspector/front-end/inspector.js:
(Number.secondsToString):
(Number.bytesToString):
* inspector/front-end/treeoutline.js:
(TreeElement.prototype.isEventWithinDisclosureTriangle):
* inspector/front-end/utilities.js:
(setupPrototypeUtilities.Element.prototype.totalOffsetLeft):
(setupPrototypeUtilities.Element.prototype.totalOffsetTop):
(setupPrototypeUtilities.Element.prototype.offsetRelativeToWindow):
(setupPrototypeUtilities):
(setupPrototypeUtilities.):
():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. Remove Windows style new lines from the test introduced in...
ossy@webkit.org [Tue, 23 Aug 2011 08:50:59 +0000 (08:50 +0000)]
Unreviewed gardening. Remove Windows style new lines from the test introduced in r93521.

* fast/loader/document-destruction-within-unload-expected.txt:
* fast/loader/document-destruction-within-unload.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] Unreviewed gardening.
ossy@webkit.org [Tue, 23 Aug 2011 08:43:18 +0000 (08:43 +0000)]
[WK2] Unreviewed gardening.

* platform/wk2/Skipped: Skip fast/frames/focus-controller-crash-change-event.html, because eventSender.keyDown is unimplemented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] REGRESSION after r93567.
reni@webkit.org [Tue, 23 Aug 2011 08:25:17 +0000 (08:25 +0000)]
[Qt] REGRESSION after r93567.
https://bugs.webkit.org/show_bug.cgi?id=66749

Three tests have assertion failed error in debug mode on x86-32 Linux Qt. They are skipped.
Unreviewed gardening.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplemented skia support for caching resizes of cropped images.
commit-queue@webkit.org [Tue, 23 Aug 2011 05:45:49 +0000 (05:45 +0000)]
Implemented skia support for caching resizes of cropped images.
https://bugs.webkit.org/show_bug.cgi?id=65587

Patch by John Bates <jbates@google.com> on 2011-08-22
Reviewed by Darin Fisher.

Previously, resizes of cropped images would not be cached. This causes various websites to have janky CSS animations in software compositing mode.

* platform/graphics/skia/ImageSkia.cpp:
(WebCore::drawResampledBitmap): Changed to use new APIs for subset caching.
(WebCore::Image::drawPattern): Added allowCaching parameter.
* platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::NativeImageSkia):
(WebCore::NativeImageSkia::CachedImageInfo::CachedImageInfo):
(WebCore::NativeImageSkia::CachedImageInfo::isEqual):
(WebCore::NativeImageSkia::CachedImageInfo::set):
(WebCore::NativeImageSkia::hasResizedBitmap): Changed this method so that it does not modify caching data. Added a second version used for cropped image resizes.
(WebCore::NativeImageSkia::resizedBitmap): Added parameter to let caller specify whether caching is allowed.
(WebCore::NativeImageSkia::shouldCacheResampling): Added a second version used for cropped image resizes.
(WebCore::NativeImageSkia::shouldCacheResamplingInternal): Both shouldCacheResampling methods call down to this for the shared logic.
* platform/graphics/skia/NativeImageSkia.h: Added CachedImageInfo to uniquely identify the cached or requested image resize operation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Fonts returned by FontCache::getFontDataForCharacters() are never released
tonyg@chromium.org [Tue, 23 Aug 2011 04:09:07 +0000 (04:09 +0000)]
[chromium] Fonts returned by FontCache::getFontDataForCharacters() are never released
https://bugs.webkit.org/show_bug.cgi?id=66673

Reviewed by James Robinson.

This was fixed for other ports in http://trac.webkit.org/changeset/88260.
However, it was missed in FontCacheLinux likely due to similar param in the nested call to getCachedFontPlatformData().

No new tests because no directly observable change in behavior.

* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::getFontDataForCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r93565.
commit-queue@webkit.org [Tue, 23 Aug 2011 03:55:42 +0000 (03:55 +0000)]
Unreviewed, rolling out r93565.
http://trac.webkit.org/changeset/93565
https://bugs.webkit.org/show_bug.cgi?id=66745

Breaks layout tests (Requested by koz2 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-22

Source/WebCore:

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaLabeledByElements):
(WebCore::AccessibilityRenderObject::ariaLabeledByAttribute):
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::hasTextAlternative):
* accessibility/AccessibilityRenderObject.h:

LayoutTests:

* accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt: Removed.
* accessibility/aria-labelledby-overrides-aria-labeledby.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r93575.
commit-queue@webkit.org [Tue, 23 Aug 2011 02:53:26 +0000 (02:53 +0000)]
Unreviewed, rolling out r93575.
http://trac.webkit.org/changeset/93575
https://bugs.webkit.org/show_bug.cgi?id=66744

Does not compile on chromium canaries (Requested by jamesr on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-22

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setStandardFontFamily):
(WebKit::WebSettingsImpl::setFixedFontFamily):
(WebKit::WebSettingsImpl::setSerifFontFamily):
(WebKit::WebSettingsImpl::setSansSerifFontFamily):
(WebKit::WebSettingsImpl::setCursiveFontFamily):
(WebKit::WebSettingsImpl::setFantasyFontFamily):
* src/WebSettingsImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Update WebSettings to support per-script font settings
commit-queue@webkit.org [Tue, 23 Aug 2011 02:15:22 +0000 (02:15 +0000)]
[chromium] Update WebSettings to support per-script font settings
https://bugs.webkit.org/show_bug.cgi?id=66220

Patch by Matt Falkenhagen <falken@chromium.org> on 2011-08-22
Reviewed by Tony Chang.

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setStandardFontFamily):
(WebKit::WebSettingsImpl::setFixedFontFamily):
(WebKit::WebSettingsImpl::setSerifFontFamily):
(WebKit::WebSettingsImpl::setSansSerifFontFamily):
(WebKit::WebSettingsImpl::setCursiveFontFamily):
(WebKit::WebSettingsImpl::setFantasyFontFamily):
* src/WebSettingsImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRange::setEnd(const Position&, ExceptionCode) calls setStart() instead of setEnd()
commit-queue@webkit.org [Tue, 23 Aug 2011 02:07:03 +0000 (02:07 +0000)]
Range::setEnd(const Position&, ExceptionCode) calls setStart() instead of setEnd()
https://bugs.webkit.org/show_bug.cgi?id=66638

Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-08-22
Reviewed by Ryosuke Niwa.

Relevant layout test coming in a future patch (see https://bugs.webkit.org/show_bug.cgi?id=65900)

* dom/Range.cpp:
(WebCore::Range::setEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove PLATFORM(ANDROID)
abarth@webkit.org [Tue, 23 Aug 2011 02:05:48 +0000 (02:05 +0000)]
Remove PLATFORM(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=66741

Reviewed by Darin Adler.

PLATFORM(CHROMIUM) && OS(ANDROID) is the new hotness.  These special
cases can be removed now that Android shares more code with Chromium.

* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::supportsRichSourceInfo):
* bindings/v8/ScriptCachedFrameData.cpp:
* bindings/v8/ScriptCachedFrameData.h:
* bindings/v8/V8GCController.cpp:
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::invokeMethod):
* history/HistoryItem.cpp:
(WebCore::HistoryItem::~HistoryItem):
(WebCore::HistoryItem::setDocumentState):
(WebCore::HistoryItem::clearDocumentState):
(WebCore::HistoryItem::setIsTargetItem):
(WebCore::HistoryItem::addChildItem):
(WebCore::HistoryItem::setFormInfoFromRequest):
* history/HistoryItem.h:
* loader/cache/CachedFont.cpp:
* platform/DragImage.h:
* platform/PlatformTouchEvent.h:
* platform/PlatformTouchPoint.h:
(WebCore::PlatformTouchPoint::PlatformTouchPoint):
* platform/Widget.h:
* platform/network/NetworkStateNotifier.cpp:
* platform/network/NetworkStateNotifier.h:
* platform/network/NetworkingContext.h:
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleInternal.h:
* platform/network/ResourceRequestBase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Implement FrameLoaderClient::dispatchDidClearWindowObjectInWorld
commit-queue@webkit.org [Tue, 23 Aug 2011 02:02:35 +0000 (02:02 +0000)]
[EFL] Implement FrameLoaderClient::dispatchDidClearWindowObjectInWorld
https://bugs.webkit.org/show_bug.cgi?id=66685

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-22
Reviewed by Kent Tamura.

Implement dispatchDidClearWindowObjectInWorld, as it is needed by
DumpRenderTree to, among other things, properly install the event
sender in the window object.

This implementation works by emitting a "window,object,cleared" signal
with a private struct containing the required information (context,
window object and frame).

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):
* WebCoreSupport/FrameLoaderClientEfl.h:
* ewk/ewk_private.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove compositing assertions about creating layers when painting
enne@google.com [Tue, 23 Aug 2011 01:35:48 +0000 (01:35 +0000)]
[chromium] Remove compositing assertions about creating layers when painting
https://bugs.webkit.org/show_bug.cgi?id=66731

Reviewed by James Robinson.

The trigger for this assertion would cause a real rendering issue, but
it is both intermittent and in the wrong place in the codebase to
catch the source of the problem.

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::~LayerChromium):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayers):
* platform/graphics/chromium/LayerRendererChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Mark some tests on Mac as flakily crashing.
pkasting@chromium.org [Tue, 23 Aug 2011 01:07:33 +0000 (01:07 +0000)]
[chromium] Mark some tests on Mac as flakily crashing.

Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Mark some tests on Windows as flaky.
pkasting@chromium.org [Tue, 23 Aug 2011 00:49:58 +0000 (00:49 +0000)]
[chromium] Mark some tests on Windows as flaky.

Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago showModalDialog does not correctly return the defined returnValue in case...
ap@apple.com [Tue, 23 Aug 2011 00:43:32 +0000 (00:43 +0000)]
    showModalDialog does not correctly return the defined returnValue in case domain relaxing is used
        https://bugs.webkit.org/show_bug.cgi?id=53191
        <rdar://problem/8629478>

        Reviewed by Geoff Garen.

        Cannot test domain relaxing, we only have 127.0.0.1 and localhost.

        * bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlot):
        Added a FIXME about a difference with Firefox.

        (WebCore::DialogHandler::DialogHandler):
        (WebCore::DialogHandler::dialogCreated):
        (WebCore::DialogHandler::returnValue):
        Changed to fetch returnValue from the global object that's in the frame when the dialog is
        dismissed. A dialog can navigate itself, and it also creates a new JSDOMWindow on first load
        if the origin doesn't match opener origin (which the case with domain relaxing).
        Re-added a security check for returnValue that got lost in r73829, so that we don't send the
        result across origins. This matches Firefox.

        * bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::setWindow): Added an assertion
        against a very confusing case that should no longer occur.

        * page/Frame.cpp: (WebCore::Frame::pageDestroyed): Don't clear the window shell, it doesn't
        seem necessary, but prevents DialogHandler from fetching the return value. Added a keepAlive
        call to avoid changing life support timer behavior in this patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] WebViewImpl should not reshape the 3D context
commit-queue@webkit.org [Tue, 23 Aug 2011 00:37:15 +0000 (00:37 +0000)]
[chromium] WebViewImpl should not reshape the 3D context
https://bugs.webkit.org/show_bug.cgi?id=66704

Patch by Iain Merrick <husky@google.com> on 2011-08-22
Reviewed by James Robinson.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::createLayerTreeHostContext3D):
(WebKit::WebViewImpl::graphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPatch by Alice Boxhall <aboxhall@chromium.org> on 2011-08-22
commit-queue@webkit.org [Tue, 23 Aug 2011 00:24:30 +0000 (00:24 +0000)]
Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-08-22
Reviewed by Chris Fleizach.

aria-labelledby should be used in preference to aria-labeledby
https://bugs.webkit.org/show_bug.cgi?id=62351

Source/WebCore:

Test: accessibility/aria-labelledby-overrides-aria-labeledby.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaLabelledByElements): Renamed from ariaLabeledByElements.
(WebCore::AccessibilityRenderObject::ariaLabelledByAttribute): Renamed from ariaLabeledByAttribute,
and re-ordered to prefer the standard spelling.
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::hasTextAlternative):
* accessibility/AccessibilityRenderObject.h:

LayoutTests:

* accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt: Added.
* accessibility/aria-labelledby-overrides-aria-labeledby.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake GraphicsContext3D::isResourceSafe a function and, on Chromium, determine its...
nduca@chromium.org [Tue, 23 Aug 2011 00:14:13 +0000 (00:14 +0000)]
Make GraphicsContext3D::isResourceSafe a function and, on Chromium, determine its value lazily
https://bugs.webkit.org/show_bug.cgi?id=66708

Reviewed by Kenneth Russell.

Source/WebCore:

* platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::texImage2DResourceSafe):
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/gtk/GraphicsContext3DGtk.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
* platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D):
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::isResourceSafe):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):

Source/WebKit/chromium:

* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::isResourceSafe):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::isResourceSafe):
* src/GraphicsContext3DInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
eric@webkit.org [Tue, 23 Aug 2011 00:05:10 +0000 (00:05 +0000)]
Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
I won't have ssh access to the bot again for a couple days, so
attempting to fix by changing this script.  If this doesn't
work we'll just live with the it hung for now.

Unreviewed.

* EWSTools/start-queue.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkit-patch rebaseline-expectations command should not rearrange the entire test_exp...
dglazkov@chromium.org [Mon, 22 Aug 2011 23:53:19 +0000 (23:53 +0000)]
webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file.
https://bugs.webkit.org/show_bug.cgi?id=66727

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter,
    in which case the serializer treats all expectations as unparsed.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHTMLSourceTracker crashes when network packets break poorly
abarth@webkit.org [Mon, 22 Aug 2011 23:52:37 +0000 (23:52 +0000)]
HTMLSourceTracker crashes when network packets break poorly
https://bugs.webkit.org/show_bug.cgi?id=66728

Reviewed by Darin Adler.

Source/WebCore:

If there is a network packet boundary in the middle of an attribute
that begins with the letters "on", then the HTMLSourceTracker will get
confused and try to extract too many characters from future input.  If
the future input is small enough, that will walk off the end of the
input and crash.

Test: http/tests/security/xssAuditor/crash-while-loading-tag-with-pause.html

* html/parser/HTMLSourceTracker.cpp:
(WebCore::HTMLSourceTracker::sourceForToken):

LayoutTests:

Test that we don't crash when we get a bad network packet boundary.

* http/tests/security/xssAuditor/crash-while-loading-tag-with-pause-expected.txt: Added.
* http/tests/security/xssAuditor/crash-while-loading-tag-with-pause.html: Added.
* http/tests/security/xssAuditor/resources/tag-with-pause.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSampling counter support is in the bytecode directory
fpizlo@apple.com [Mon, 22 Aug 2011 23:41:20 +0000 (23:41 +0000)]
Sampling counter support is in the bytecode directory
https://bugs.webkit.org/show_bug.cgi?id=66724

Reviewed by Darin Adler.

Moved SamplingCounter to a separate header in runtime/.

* GNUmakefile.list.am:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/SamplingTool.cpp:
* bytecode/SamplingTool.h:
* runtime/SamplingCounter.cpp: Added.
(JSC::AbstractSamplingCounter::dump):
* runtime/SamplingCounter.h: Added.
(JSC::AbstractSamplingCounter::count):
(JSC::AbstractSamplingCounter::addressOfCounter):
(JSC::AbstractSamplingCounter::init):
(JSC::SamplingCounter::SamplingCounter):
(JSC::GlobalSamplingCounter::name):
(JSC::DeletableSamplingCounter::DeletableSamplingCounter):
(JSC::DeletableSamplingCounter::~DeletableSamplingCounter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93560 268f45cc-cd09-0410-ab3c-d52691b4dbfc