WebKit-https.git
7 years agoSource/WebCore: [Win] Implement the media controls in JavaScript
bfulgham@apple.com [Tue, 1 Oct 2013 20:33:59 +0000 (20:33 +0000)]
Source/WebCore: [Win] Implement the media controls in JavaScript
https://bugs.webkit.org/show_bug.cgi?id=122166

Reviewed by Jer Noble.

* DerivedSources.make: Uncomment feature flag test.
* WebCore.vcxproj/WebCore.vcxproj: Add new media control implementation files.
Also cleaned up some misplaced files in the project tree.
* WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
* WebCore.vcxproj/WebCoreCommon.props: Add missing include path for the
mediacontrols path.
* WebCore.vcxproj/copyForwardingHeaders.cmd: Add Modules/mediacontrols to copied headers.
* rendering/RenderThemeWin.cpp: Add missing include for UserAgentScripts.

WebKitLibraries: [Win] Implement the media controls in JavaScript.
https://bugs.webkit.org/show_bug.cgi?id=122166

Reviewed by Jer Noble.

* win/tools/vsprops/FeatureDefines.props: Activate the
ENABLE_MEDIA_CONTROLS_SCRIPT flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Added adoptCOM to COMPtr on Windows.
commit-queue@webkit.org [Tue, 1 Oct 2013 20:20:02 +0000 (20:20 +0000)]
Source/WebCore: Added adoptCOM to COMPtr on Windows.
https://bugs.webkit.org/show_bug.cgi?id=122069

Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-01
Reviewed by Brent Fulgham.

* platform/win/COMPtr.h:
(adoptCOM): Added.

Source/WebKit/win: Implemented createWebViewWithRequest in WinLauncher.
https://bugs.webkit.org/show_bug.cgi?id=122069

Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-01
Reviewed by Brent Fulgham.

* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::createWindow):
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchCreatePage):
Pass request url from the NavigationAction to createWebViewWithRequest.

Tools: Implemented createWebViewWithRequest in WinLauncher.
https://bugs.webkit.org/show_bug.cgi?id=122069

Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-01
Reviewed by Brent Fulgham.

* WinLauncher/PrintWebUIDelegate.cpp:
(PrintWebUIDelegate::createWebViewWithRequest): Added.
* WinLauncher/PrintWebUIDelegate.h:
Removed createWebViewWithRequest stub.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: evaluate and show a popover for selected text in JS source when paused
graouts@apple.com [Tue, 1 Oct 2013 19:55:21 +0000 (19:55 +0000)]
Web Inspector: evaluate and show a popover for selected text in JS source when paused
https://bugs.webkit.org/show_bug.cgi?id=122151

Reviewed by Joseph Pecoraro.

Identify if the hovered token is contained within the text selection (if any) and use
the selection as the hovered expression to allow the user to select text and hover it
to see what it evaluates to.

* UserInterface/CodeMirrorTokenTrackingController.js:
(WebInspector.CodeMirrorTokenTrackingController.prototype.highlightRange):
Check we're trying to highlight a different range before removing the highlight
and applying the new one, this prevents the marked text from flashing if it's
being re-hovered which would easily happen when hovering multiple tokens within
the same selection.

(WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):
In the case where there is selected text, check whether the hovered token is at least
partially contained within the selection, and if so use the selection text as the
hovered expression to evaluate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConsole buttons don’t show after page reload
graouts@apple.com [Tue, 1 Oct 2013 19:32:09 +0000 (19:32 +0000)]
Console buttons don’t show after page reload
https://bugs.webkit.org/show_bug.cgi?id=116515

Reviewed by Darin Adler.

The correct display of navigation items in the ContentBrowser is contingent on
the ContentViewContainer's _backForwardList being up-to-date when the navigation
items are retrieved from it. However, when the main resource changes (in this case
the user refreshes the browser), calls are made to ContentViewContainer's
closeAllContentViewsOfPrototype() which may modify the _backForwardList but doesn't
necessarily notify of a change to the currentContentView since we may be still showing
the same view in case it wasn't directly related to the main resource, for instance
the console log.

We now check if the _backForwardList is changed as a result of calling
closeAllContentViewsOfPrototype() and in that case also dispatch the
CurrentContentViewDidChange event which will restore the correct state
for the back/forward buttons and navigation items of the navigation bar.

* UserInterface/ContentViewContainer.js:
(WebInspector.ContentViewContainer.prototype.closeAllContentViewsOfPrototype):
Track changes to the _backForwardList and dispatch the CurrentContentViewDidChange
event in case such changes happened.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix; The addedFunction and removedFunction arguments to determineCha...
jer.noble@apple.com [Tue, 1 Oct 2013 19:31:13 +0000 (19:31 +0000)]
Unreviewed build fix; The addedFunction and removedFunction arguments to determineChangedTracksFromNewTracksAndOldItems
were reversed, exposing an underlying, existing bug in AudioTrackPrivate and VideoTrack private. Give a default (null)
value to AudioTrackPrivate::m_client and VideoTrackPrivate::m_client and fix the ordering of arguments in
determineChangedTracksFromNewTracksAndOldItems.

* platform/graphics/AudioTrackPrivate.h:
(WebCore::AudioTrackPrivate::AudioTrackPrivate):
* platform/graphics/VideoTrackPrivate.h:
(WebCore::VideoTrackPrivate::VideoTrackPrivate):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::determineChangedTracksFromNewTracksAndOldItems):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
timothy_horton@apple.com [Tue, 1 Oct 2013 18:50:12 +0000 (18:50 +0000)]
[wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
https://bugs.webkit.org/show_bug.cgi?id=122006
<rdar://problem/15095197>

Reviewed by Dean Jackson.

* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
Layer-back the root view in WebKitTestRunner's window, to work around a bug
where the window server snapshot API returns blank snapshots.

Re-landing after r156724, this should not break everything now.

Add a test that ensures that WebKitTestRunner's snapshots are not
completely blank with tiled drawing enabled.

* platform/mac-wk2/tiled-drawing/window-server-snapshots-work-expected-mismatch.html: Added.
* platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[mac] 1x emulation on Retina hardware shouldn't use SPI
timothy_horton@apple.com [Tue, 1 Oct 2013 18:46:50 +0000 (18:46 +0000)]
[mac] 1x emulation on Retina hardware shouldn't use SPI
https://bugs.webkit.org/show_bug.cgi?id=122152
<rdar://problem/15119384>

Reviewed by Anders Carlsson.

* DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
(main):
* DumpRenderTree/mac/DumpRenderTreeWindow.h:
* DumpRenderTree/mac/DumpRenderTreeWindow.mm:
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
* WebKitTestRunner/mac/main.mm:
(main):
Register for AppleMagnifiedMode instead of using _setWindowResolution:displayIfChanged:.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSpeculativeJIT::m_arguments/m_variables are vestiges of a time long gone
fpizlo@apple.com [Tue, 1 Oct 2013 18:45:42 +0000 (18:45 +0000)]
SpeculativeJIT::m_arguments/m_variables are vestiges of a time long gone
https://bugs.webkit.org/show_bug.cgi?id=122140

Reviewed by Darin Adler.

Just killing code.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::recordSetLocal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] Add support for VideoTrack to MediaPlayerPrivateAVFObjC
jer.noble@apple.com [Tue, 1 Oct 2013 18:24:06 +0000 (18:24 +0000)]
[Mac] Add support for VideoTrack to MediaPlayerPrivateAVFObjC
https://bugs.webkit.org/show_bug.cgi?id=122122

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/video-track.html

Refactor the methods which query AVAssetTrack and AVPlayerItemTrack into an Impl class, and
use that class to reset the properties of both AudioTrackAVFObjC and the new VideoTrackAVFObjC.

Add new files to project:
* WebCore.xcodeproj/project.pbxproj:

Add the new implementation class, shared by AudioTrackAVFObjC and VideoTrackAVFObjC:
* platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.h: Added.
(WebCore::AVTrackPrivateAVFObjCImpl::create): Simple factory.
(WebCore::AVTrackPrivateAVFObjCImpl::playerItemTrack): Simple getter.
* platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm: Added.
(WebCore::AVTrackPrivateAVFObjCImpl::AVTrackPrivateAVFObjCImpl): Simple constructor.
(WebCore::AVTrackPrivateAVFObjCImpl::enabled): Pass to AVPlayerItemTrack.
(WebCore::AVTrackPrivateAVFObjCImpl::setEnabled): Ditto.
(WebCore::AVTrackPrivateAVFObjCImpl::audioKind): Distinguish between Alternative and Main content.
(WebCore::AVTrackPrivateAVFObjCImpl::videoKind): Distinguish between Alternative, Main, Caption,
    and Description content.
(WebCore::AVTrackPrivateAVFObjCImpl::id): Pass to AVAssetTrack.
(WebCore::AVTrackPrivateAVFObjCImpl::label): Retrieve the Title metadata in the user's preferred
    language.
(WebCore::AVTrackPrivateAVFObjCImpl::language): Pass to languageForAVAssetTrack.
(WebCore::AVTrackPrivateAVFObjCImpl::languageForAVAssetTrack): Moved from AudioTrackPrivateAVFObjC.
* platform/graphics/avfoundation/VideoTrackPrivateAVF.h: Copied from Source/WebCore/platform/graphics/avfoundation/AudioTrackPrivateAVF.h.
(WebCore::VideoTrackPrivateAVF::kind): Simple getter.
(WebCore::VideoTrackPrivateAVF::id): Ditto.
(WebCore::VideoTrackPrivateAVF::label): Ditto.
(WebCore::VideoTrackPrivateAVF::language): Ditto.
(WebCore::VideoTrackPrivateAVF::setKind): Simple setter.
(WebCore::VideoTrackPrivateAVF::setId): Ditto.
(WebCore::VideoTrackPrivateAVF::setLabel): Ditto.
(WebCore::VideoTrackPrivateAVF::setLanguage): Ditto.
(WebCore::VideoTrackPrivateAVF::VideoTrackPrivateAVF): Simple constructor.
* platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.h:
* platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
(WebCore::AudioTrackPrivateAVFObjC::AudioTrackPrivateAVFObjC): Create a AVTrackPrivateAVFObjCImpl.
(WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack): Retrieve properties from m_impl.
(WebCore::AudioTrackPrivateAVFObjC::setPlayerItemTrack): Create a new AVTrackPrivateAVFObjCImpl.
(WebCore::AudioTrackPrivateAVFObjC::playerItemTrack): Pass to m_impl.
(WebCore::AudioTrackPrivateAVFObjC::setEnabled): Ditto.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Refactor implementation into
    template method determineChangedTracksFromNewTracksAndOldItems().
(WebCore::determineChangedTracksFromNewTracksAndOldItems): Refactored.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateAudioTracks): Pass to determineChangedTracksFromNewTracksAndOldItems.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Changed class hosting
    languageForAVAssetTrack.
* platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.cpp: Added.
(WebCore::VideoTrackPrivateAVFObjC::VideoTrackPrivateAVFObjC): Create a AVTrackPrivateAVFObjCImpl.
(WebCore::VideoTrackPrivateAVFObjC::resetPropertiesFromTrack): Retrieve properties from m_impl.
(WebCore::VideoTrackPrivateAVFObjC::setPlayerItemTrack): Create a new AVTrackPrivateAVFObjCImpl.
(WebCore::VideoTrackPrivateAVFObjC::playerItemTrack): Pass to m_impl.
(WebCore::VideoTrackPrivateAVFObjC::setSelected): Ditto.
* platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h: Added.
(WebCore::VideoTrackPrivateAVFObjC::create): Simple factory.

LayoutTests:

* media/track/video-track-expected.txt: Added.
* media/track/video-track.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLeaf EventTarget subclasses should be FINAL.
akling@apple.com [Tue, 1 Oct 2013 17:20:06 +0000 (17:20 +0000)]
Leaf EventTarget subclasses should be FINAL.
<https://webkit.org/b/122141>

Reviewed by Darin Adler.

Clear out a slew of FIXMEs now that HasMemoryCostMemberFunction
works on classes marked FINAL (fixed in bug 121747.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename URL type variables in Curl network backend.
commit-queue@webkit.org [Tue, 1 Oct 2013 17:03:58 +0000 (17:03 +0000)]
Rename URL type variables in Curl network backend.
https://bugs.webkit.org/show_bug.cgi?id=122158

Patch by Szabolcs Dávid <davidsz@inf.u-szeged.hu> on 2013-10-01
Reviewed by Darin Adler.

I changed the name of the URL objects to match with the new class name.

* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::getProtectionSpace):
(WebCore::ResourceHandleManager::initializeHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCenter misspelling dots across width of word
commit-queue@webkit.org [Tue, 1 Oct 2013 16:59:59 +0000 (16:59 +0000)]
Center misspelling dots across width of word
https://bugs.webkit.org/show_bug.cgi?id=122046

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-01
Reviewed by Darin Adler.

Source/WebCore:

Test: editing/spelling/spelling.html

* platform/graphics/GraphicsContext.h:
* platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawLineForDocumentMarker):

LayoutTests:

This patch only rebaselines a single test. I would have rebaselined
the rest of the tests, but they seem to be affected by
webkit.org/b/122146. I don't want to commit incorrect expected results.

* platform/mac/editing/spelling/spelling-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[iOS] WebCore fails to build with newer versions of clang
dbates@webkit.org [Tue, 1 Oct 2013 16:40:22 +0000 (16:40 +0000)]
[iOS] WebCore fails to build with newer versions of clang
https://bugs.webkit.org/show_bug.cgi?id=122161

Reviewed by Darin Adler.

* editing/FrameSelection.cpp: Add ENABLE(TEXT_CARET)-guard around shouldStopBlinkingDueToTypingCommand().
* page/EventHandler.cpp: Add !PLATFORM(IOS)-guard around constants cursorUpdateInterval and maximumCursorSize;
also add touch event/gesture event guard around shouldGesturesTriggerActive().
* platform/network/cf/ResourceResponseCFNet.cpp: Remove unused function filenameHasSaneExtension.
* platform/network/mac/ResourceResponseMac.mm: Only define static variables commonHeaderFields when building
without CFNetwork; also remove variable numCommonHeaderFields, instead use WTF_ARRAY_LENGTH(commonHeaderFields)
to compute the size of the fixed-sized array commonHeaderFields.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[iOS] JavaScriptCore fails to build with newer versions of clang
dbates@webkit.org [Tue, 1 Oct 2013 16:39:32 +0000 (16:39 +0000)]
[iOS] JavaScriptCore fails to build with newer versions of clang
https://bugs.webkit.org/show_bug.cgi?id=122162

Reviewed by Darin Adler.

* runtime/GCActivityCallback.cpp: Add !PLATFORM(IOS)-guard around constant pagingTimeOut
as we don't compile the code that uses it on iOS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GStreamer] Support "chapter" text tracks
commit-queue@webkit.org [Tue, 1 Oct 2013 16:26:52 +0000 (16:26 +0000)]
[GStreamer] Support "chapter" text tracks
https://bugs.webkit.org/show_bug.cgi?id=122000

Patch by Brendan Long <b.long@cablelabs.com> on 2013-10-01
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/in-band/track-in-band-mkv-chapters.html

* platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h: New class, needed for cues that aren't associated with GstPads.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Check for table of contents messages.
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContents): Parse table of contents messages into text tracks.
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContentsEntry): Recursive method for parsing all of the TOC entries.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Add the processTableOfContents functions.

LayoutTests:

* media/content/counting-subtitled-srt.mkv: Added chapters metadata.
* media/track/in-band/track-in-band-mkv-chapters-expected.txt: New test, similar to cues-added-one, but uses "chapters" track.
* media/track/in-band/track-in-band-mkv-chapters.html: Same.
* media/in-band-cues.js: Updated tests to handle the new "chapters" track.
* media/track/in-band/track-in-band-kate-ogg-cues-added-once-expected.txt: Same.
* media/track/in-band/track-in-band-kate-ogg-cues-added-once.html: Same.
* media/track/in-band/track-in-band-kate-ogg-mode-expected.txt: Same.
* media/track/in-band/track-in-band-kate-ogg-mode.html: Same.
* media/track/in-band/track-in-band-kate-ogg-style-expected.txt: Same.
* media/track/in-band/track-in-band-kate-ogg-track-order-expected.txt: Same.
* media/track/in-band/track-in-band-kate-ogg-track-order.html: Same.
* media/track/in-band/track-in-band-srt-mkv-cues-added-once-expected.txt: Same.
* media/track/in-band/track-in-band-srt-mkv-cues-added-once.html: Same.
* media/track/in-band/track-in-band-srt-mkv-kind-expected.txt: Same.
* media/track/in-band/track-in-band-srt-mkv-kind.html: Same.
* media/track/in-band/track-in-band-srt-mkv-language-expected.txt: Same.
* media/track/in-band/track-in-band-srt-mkv-language.html: Same.
* media/track/in-band/track-in-band-srt-mkv-mode-expected.txt: Same.
* media/track/in-band/track-in-band-srt-mkv-mode.html: Same.
* media/track/in-band/track-in-band-srt-mkv-style-expected.txt: Same.
* media/track/in-band/track-in-band-srt-mkv-track-order-expected.txt: Same.
* media/track/in-band/track-in-band-srt-mkv-track-order.html: Same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTry to get another Windows test to pass.
darin@apple.com [Tue, 1 Oct 2013 16:14:29 +0000 (16:14 +0000)]
Try to get another Windows test to pass.

* platform/win/js/dom/global-constructors-attributes-expected.txt: Removed one
more class (Notification) for a feature turned off for the Windows platform.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTry to get another Windows test to pass.
darin@apple.com [Tue, 1 Oct 2013 15:02:13 +0000 (15:02 +0000)]
Try to get another Windows test to pass.

* platform/win/js/dom/global-constructors-attributes-expected.txt: Added.
Copy of the platform-independent results file, with items deleted for features
that are currently turned off for the Windows platform.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Texmap] CSS filter not working on software composited layers
allan.jensen@digia.com [Tue, 1 Oct 2013 14:58:32 +0000 (14:58 +0000)]
[Texmap] CSS filter not working on software composited layers
https://bugs.webkit.org/show_bug.cgi?id=122159

Reviewed by Noam Rosenthal.

Tell the rendering layer we do not support CSS filters when we do not. This
will make RenderLayer fall back to using its own software implementation.

* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::setFilters):
* platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::applyFilters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTry to fix assertion failures seem on bots.
darin@apple.com [Tue, 1 Oct 2013 12:34:39 +0000 (12:34 +0000)]
Try to fix assertion failures seem on bots.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::createFilterOperations): Rearrange code so this
won't try ot call toCSSPrimitiveValue on a non-primitive-value in the
DROP_SHADOW case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the 'InexedDB' typo in the ChangeLog that I failed to address prior to landing...
zandobersek@gmail.com [Tue, 1 Oct 2013 12:09:15 +0000 (12:09 +0000)]
Fix the 'InexedDB' typo in the ChangeLog that I failed to address prior to landing r156701.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening. Adding failure expectations for currently failing tests.
zandobersek@gmail.com [Tue, 1 Oct 2013 11:57:27 +0000 (11:57 +0000)]
Unreviewed GTK gardening. Adding failure expectations for currently failing tests.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Fix build after r156688.
commit-queue@webkit.org [Tue, 1 Oct 2013 11:38:52 +0000 (11:38 +0000)]
[Qt][WK2] Fix build after r156688.
https://bugs.webkit.org/show_bug.cgi?id=122153

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-10-01
Reviewed by Allan Sandfeld Jensen.

* Shared/qt/ShareableBitmapQt.cpp:
(WebKit::ShareableBitmap::createGraphicsContext):
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::createDrawingAreaProxy):
* UIProcess/API/qt/qquickwebview_p_p.h:
* UIProcess/API/qt/raw/qrawwebview.cpp:
(QRawWebViewPrivate::createDrawingAreaProxy):
* UIProcess/API/qt/raw/qrawwebview_p_p.h:
* UIProcess/qt/QtPageClient.cpp:
(WebKit::QtPageClient::createDrawingAreaProxy):
* UIProcess/qt/QtPageClient.h:
* WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp:
(WebKit::convertQPixmapToShareableBitmap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGenerate toCSSFooValue for CSSPrimitiveValue
gyuyoung.kim@samsung.com [Tue, 1 Oct 2013 10:50:47 +0000 (10:50 +0000)]
Generate toCSSFooValue for CSSPrimitiveValue
https://bugs.webkit.org/show_bug.cgi?id=122101

Reviewed by Antti Koivisto.

As a step of clean-up static_cast<> in CSSValues, this patch generates
toCSSFooPrimitiveValue() in order to detect bad casts as well as improves
code readability.

No new tests, no behavior changes.

* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
* css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::subimageIsPending):
(WebCore::CSSImageGeneratorValue::cachedImageForCSSValue):
* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::fillImageSet):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::parse3ValuesFillPosition):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
(WebCore::CSSParser::parseRadialGradient):
* css/CSSPrimitiveValue.h:
* css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapFillAttachment):
(WebCore::CSSToStyleMap::mapFillClip):
(WebCore::CSSToStyleMap::mapFillComposite):
(WebCore::CSSToStyleMap::mapFillBlendMode):
(WebCore::CSSToStyleMap::mapFillOrigin):
(WebCore::CSSToStyleMap::mapFillRepeatX):
(WebCore::CSSToStyleMap::mapFillRepeatY):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
(WebCore::CSSToStyleMap::mapFillMaskSourceType):
(WebCore::CSSToStyleMap::mapAnimationDelay):
(WebCore::CSSToStyleMap::mapAnimationDirection):
(WebCore::CSSToStyleMap::mapAnimationDuration):
(WebCore::CSSToStyleMap::mapAnimationFillMode):
(WebCore::CSSToStyleMap::mapAnimationIterationCount):
(WebCore::CSSToStyleMap::mapAnimationName):
(WebCore::CSSToStyleMap::mapAnimationPlayState):
(WebCore::CSSToStyleMap::mapAnimationProperty):
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
(WebCore::CSSToStyleMap::mapNinePieceImageRepeat):
* css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
* css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyMarqueeIncrement::applyValue):
(WebCore::ApplyPropertyMarqueeRepetition::applyValue):
(WebCore::ApplyPropertyMarqueeSpeed::applyValue):
(WebCore::ApplyPropertyTextUnderlinePosition::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyLineHeightForIOSTextAutosizing::applyValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
(WebCore::ApplyPropertyTextIndent::applyValue):
* css/MediaList.cpp:
(WebCore::reportMediaQueryWarningIfNeeded):
* css/MediaQueryEvaluator.cpp:
(WebCore::numberValue):
(WebCore::orientationMediaFeatureEval):
(WebCore::evalResolution):
(WebCore::device_pixel_ratioMediaFeatureEval):
(WebCore::resolutionMediaFeatureEval):
(WebCore::computeLength):
(WebCore::view_modeMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):
* css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getLayeredShorthandValue):
* css/StyleResolver.cpp:
(WebCore::createGridTrackSize):
(WebCore::createGridTrackList):
(WebCore::createGridPosition):
(WebCore::hasVariableReference):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::parseCustomFilterArrayParameter):
(WebCore::StyleResolver::parseCustomFilterColorParameter):
(WebCore::StyleResolver::parseCustomFilterNumberParameter):
(WebCore::StyleResolver::parseCustomFilterParameter):
(WebCore::StyleResolver::parseCustomFilterParameterList):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):
* css/TransformFunctions.cpp:
(WebCore::transformsForValue):
* css/ViewportStyleResolver.cpp:
(WebCore::ViewportStyleResolver::getViewportArgumentValue):
* css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::computedFontSize):
* editing/EditingStyle.cpp:
(WebCore::identifierForStyleProperty):
(WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
(WebCore::cssValueToRGBA):
(WebCore::EditingStyle::extractFontSizeDelta):
(WebCore::EditingStyle::textDirection):
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::EditingStyle::legacyFontSize):
(WebCore::EditingStyle::textDirectionForSelection):
(WebCore::StyleChange::extractTextStyles):
(WebCore::fontWeightIsBold):
(WebCore::isTransparentColorValue):
* editing/markup.cpp:
(WebCore::propertyMissingOrEqualToNone):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove platform-specific test results from js to js/dom to match moves in r156066.
darin@apple.com [Tue, 1 Oct 2013 10:36:56 +0000 (10:36 +0000)]
Move platform-specific test results from js to js/dom to match moves in r156066.

I see multiple check-ins with people doing this for some files, but these seem to have been missed.
Maybe some of these are unneeded and can be removed.

My hope is that this might help with some failures seen on the Windows bot.

* platform/blackberry/js/dom/constructor-length-expected.txt: Renamed from LayoutTests/platform/blackberry/js/constructor-length-expected.txt.
* platform/efl/js/dom/constructor-length-expected.txt: Renamed from LayoutTests/platform/efl/js/constructor-length-expected.txt.
* platform/efl/js/dom/dom-static-property-for-in-iteration-expected.txt: Renamed from LayoutTests/platform/efl/js/dom-static-property-for-in-iteration-expected.txt.
* platform/efl/js/dom/exception-linenums-in-html-3-expected.png: Renamed from LayoutTests/platform/efl/js/exception-linenums-in-html-3-expected.png.
* platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Renamed from LayoutTests/platform/efl/js/global-constructors-attributes-dedicated-worker-expected.txt.
* platform/efl/js/dom/global-constructors-attributes-shared-worker-expected.txt: Renamed from LayoutTests/platform/efl/js/global-constructors-attributes-shared-worker-expected.txt.
* platform/efl/js/dom/missing-style-end-tag-js-expected.png: Renamed from LayoutTests/platform/efl/js/missing-style-end-tag-js-expected.png.
* platform/efl/js/dom/missing-title-end-tag-js-expected.png: Renamed from LayoutTests/platform/efl/js/missing-title-end-tag-js-expected.png.
* platform/gtk/js/dom/constructor-length-expected.txt: Renamed from LayoutTests/platform/gtk/js/constructor-length-expected.txt.
* platform/gtk/js/dom/exception-linenums-in-html-3-expected.png: Renamed from LayoutTests/platform/gtk/js/exception-linenums-in-html-3-expected.png.
* platform/gtk/js/dom/missing-style-end-tag-js-expected.png: Renamed from LayoutTests/platform/gtk/js/missing-style-end-tag-js-expected.png.
* platform/gtk/js/dom/missing-title-end-tag-js-expected.png: Renamed from LayoutTests/platform/gtk/js/missing-title-end-tag-js-expected.png.
* platform/mac/js/dom/exception-linenums-in-html-3-expected.png: Renamed from LayoutTests/platform/mac/js/exception-linenums-in-html-3-expected.png.
* platform/mac/js/dom/missing-style-end-tag-js-expected.png: Renamed from LayoutTests/platform/mac/js/missing-style-end-tag-js-expected.png.
* platform/mac/js/dom/missing-title-end-tag-js-expected.png: Renamed from LayoutTests/platform/mac/js/missing-title-end-tag-js-expected.png.
* platform/qt/js/dom/constructor-length-expected.txt: Renamed from LayoutTests/platform/qt/js/constructor-length-expected.txt.
* platform/qt/js/dom/date-DST-time-cusps-expected.txt: Renamed from LayoutTests/platform/qt/js/date-DST-time-cusps-expected.txt.
* platform/qt/js/dom/dom-static-property-for-in-iteration-expected.txt: Renamed from LayoutTests/platform/qt/js/dom-static-property-for-in-iteration-expected.txt.
* platform/qt/js/dom/exception-linenums-in-html-3-expected.png: Renamed from LayoutTests/platform/qt/js/exception-linenums-in-html-3-expected.png.
* platform/qt/js/dom/missing-style-end-tag-js-expected.png: Renamed from LayoutTests/platform/qt/js/missing-style-end-tag-js-expected.png.
* platform/qt/js/dom/missing-title-end-tag-js-expected.png: Renamed from LayoutTests/platform/qt/js/missing-title-end-tag-js-expected.png.
* platform/qt/js/dom/switch-behaviour-expected.txt: Renamed from LayoutTests/platform/qt/js/switch-behaviour-expected.txt.
* platform/win/js/dom/dom-static-property-for-in-iteration-expected.txt: Renamed from LayoutTests/platform/win/js/dom-static-property-for-in-iteration-expected.txt.
* platform/win/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Renamed from LayoutTests/platform/win/js/global-constructors-attributes-dedicated-worker-expected.txt.
* platform/win/js/dom/global-constructors-attributes-shared-worker-expected.txt: Renamed from LayoutTests/platform/win/js/global-constructors-attributes-shared-worker-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTry to fix AVFoundation crashes seen on Lion bot.
darin@apple.com [Tue, 1 Oct 2013 09:59:31 +0000 (09:59 +0000)]
Try to fix AVFoundation crashes seen on Lion bot.

* platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
Four AVFoundation string constants used in this file were new to 10.8.
For older versions of OS X, use hard-coded string constants instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening. Rebaselining after r156527, moving baselines specific to...
zandobersek@gmail.com [Tue, 1 Oct 2013 09:37:56 +0000 (09:37 +0000)]
Unreviewed GTK gardening. Rebaselining after r156527, moving baselines specific to GTK WK1
under the platform/gtk-wk1 directory.

* platform/gtk-wk1/js: Added.
* platform/gtk-wk1/js/dom: Added.
* platform/gtk-wk1/js/dom/function-length-expected.txt: Added.
* platform/gtk-wk1/scrollingcoordinator: Added.
* platform/gtk-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added.
* platform/gtk-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added.
* platform/gtk/js/dom/function-length-expected.txt: Removed.
* platform/gtk/scrollingcoordinator: Removed.
* platform/gtk/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Removed.
* platform/gtk/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Removed.
* platform/gtk/svg/custom/SVGPoint-matrixTransform-expected.txt:
* platform/gtk/svg/custom/getTransformToElement-expected.txt:
* platform/gtk/svg/custom/text-ctm-expected.txt:
* platform/gtk/svg/custom/text-hit-test-expected.txt:
* platform/gtk/svg/text/append-text-node-to-tspan-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[InexedDB] Interfaces inheriting from EventTarget should generate JSC (un)wrapping...
zandobersek@gmail.com [Tue, 1 Oct 2013 08:12:57 +0000 (08:12 +0000)]
[InexedDB] Interfaces inheriting from EventTarget should generate JSC (un)wrapping functions
https://bugs.webkit.org/show_bug.cgi?id=122114

Reviewed by Darin Adler.

After r156590, four IndexedDB interfaces are inheriting from the EventTarget interface. Because of that,
they're now required to have interface-specific JSC wrapping and unwrapping functions generated since the
JSC wrapping and unwrapping functions for the EventTarget interface delegate these operations to these
interface-specific functions. If the functions are not generated and accessible, the EventTarget functions
end up recursively calling themselves.

* Modules/indexeddb/IDBDatabase.idl:
* Modules/indexeddb/IDBOpenDBRequest.idl:
* Modules/indexeddb/IDBRequest.idl:
* Modules/indexeddb/IDBTransaction.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for EFL, Qt, Gtk port after r156688
ryuan.choi@samsung.com [Tue, 1 Oct 2013 06:37:32 +0000 (06:37 +0000)]
Build fix for EFL, Qt, Gtk port after r156688
https://bugs.webkit.org/show_bug.cgi?id=122139

Reviewed by Anders Carlsson.

Get rid of more uses of OwnPtr and PassOwnPtr.

Source/WebCore:

* platform/graphics/surfaces/GraphicsSurface.cpp:
(WebCore::GraphicsSurface::beginPaint):
* platform/graphics/surfaces/GraphicsSurface.h:
* platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp:
(WebCore::GraphicsSurface::platformBeginPaint):
* platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurface::platformBeginPaint):
* platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp:
(WebCore::GraphicsSurface::platformBeginPaint):

Source/WebKit2:

* Shared/API/c/cairo/WKImageCairo.cpp:
(WKImageCreateFromCairoSurface):
* Shared/API/c/qt/WKImageQt.cpp:
(WKImageCreateFromQImage):
* Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:
(WebKit::WebCoordinatedSurface::createGraphicsContext):
(WebKit::WebCoordinatedSurface::paintToSurface):
* Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
* Shared/cairo/ShareableBitmapCairo.cpp:
(WebKit::ShareableBitmap::createGraphicsContext):
* Shared/gtk/ArgumentCodersGtk.cpp:
(CoreIPC::encodeImage):
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::createDrawingAreaProxy):
* UIProcess/API/gtk/PageClientImpl.h:
* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::createDrawingAreaProxy):
* UIProcess/CoordinatedGraphics/WebView.h:
* WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
(WebKit::convertCairoSurfaceToShareableBitmap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayout Test media/click-volume-bar-not-pausing.html is flaky
ap@apple.com [Tue, 1 Oct 2013 06:12:55 +0000 (06:12 +0000)]
Layout Test media/click-volume-bar-not-pausing.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122126

Reviewed by Darin Adler.

Speculative partial fix.

I'm not sure if it's possible to make this test completely controlled without
DOMFrameContentLoaded support - we need to do work when the <video> element is
already present, but playback hasn't started yet. As media documents use autoplay,
there is a race between load and playing events.

* media/click-volume-bar-not-pausing-expected.txt:
* media/click-volume-bar-not-pausing.html:
  - Add video URL after initial content fully loads to avoid races with that.
  - Added some state logging for clarity.
  - Only listen for "playing" event once. If playback already started, we have a
  playing event already queued, and would add another one with pause()/play().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: Expose ARIA Busy Notifications
commit-queue@webkit.org [Tue, 1 Oct 2013 05:58:10 +0000 (05:58 +0000)]
AX: Expose ARIA Busy Notifications
https://bugs.webkit.org/show_bug.cgi?id=121451

Patch by Sam White <samuel_white@apple.com> on 2013-09-30
Reviewed by Chris Fleizach.

Source/WebCore:

Added AXElementBusyChanged notification that posts when aria-busy is toggled. This
enables screen readers to detect busy states without polling the focused element.

Test: platform/mac/accessibility/element-busy-changed.html

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChanged):
* accessibility/AXObjectCache.h:
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):

LayoutTests:

Added test to verify that elements post AXElementBusyChanged notifications when aria-busy is toggled.

* platform/mac/accessibility/element-busy-changed-expected.txt: Added.
* platform/mac/accessibility/element-busy-changed.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the build.
weinig@apple.com [Tue, 1 Oct 2013 05:16:57 +0000 (05:16 +0000)]
Fix the build.

* ewk/ewk_settings.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFixing the build.
weinig@apple.com [Tue, 1 Oct 2013 05:10:21 +0000 (05:10 +0000)]
Fixing the build.

* GNUmakefile.list.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMore build fixing.
weinig@apple.com [Tue, 1 Oct 2013 04:59:55 +0000 (04:59 +0000)]
More build fixing.

* GNUmakefile.list.am:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* inspector/InspectorAllInOne.cpp:
* inspector/InstrumentingAgents.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocheck-webkit-style should not warn about use of C++11 “>>” instead of “> >"
commit-queue@webkit.org [Tue, 1 Oct 2013 04:57:53 +0000 (04:57 +0000)]
check-webkit-style should not warn about use of C++11 “>>”  instead of “> >"
https://bugs.webkit.org/show_bug.cgi?id=116474

Patch by Sam Weinig <sam@webkit.org> on 2013-09-30
Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/style/checkers/cpp.py:
* Scripts/webkitpy/style/checkers/cpp_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the Efl and Gtk builds.
weinig@apple.com [Tue, 1 Oct 2013 04:47:21 +0000 (04:47 +0000)]
Fix the Efl and Gtk builds.

* GNUmakefile.list.am:
* PlatformEfl.cmake:
* PlatformGTK.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove support for DOMFileSystem
weinig@apple.com [Tue, 1 Oct 2013 04:33:34 +0000 (04:33 +0000)]
Remove support for DOMFileSystem
https://bugs.webkit.org/show_bug.cgi?id=122137

Reviewed by Anders Carlsson.

.:

* Source/autotools/SetupWebKitFeatures.m4:
* Source/cmake/OptionsBlackBerry.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Files elided *

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::clearWebFileSystem):
* WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/efl:

* ewk/ewk_settings.cpp:
(ewk_settings_file_system_path_set):

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

* wtf/FeatureDefines.h:

Tools:

* Scripts/webkitperl/FeatureList.pm:
* Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_spacing_for_binary_ops):
* qmake/mkspecs/features/features.pri:

LayoutTests:

* fast/dom/MutationObserver/filesystem-callback-delivery-expected.txt: Removed.
* fast/dom/MutationObserver/filesystem-callback-delivery.html: Removed.
* fast/filesystem: Removed.
* fast/filesystem/async-operations-expected.txt: Removed.
* fast/filesystem/async-operations.html: Removed.
* fast/filesystem/cross-filesystem-op-expected.txt: Removed.
* fast/filesystem/cross-filesystem-op.html: Removed.
* fast/filesystem/directory-entry-to-uri-expected.txt: Removed.
* fast/filesystem/directory-entry-to-uri.html: Removed.
* fast/filesystem/entry-points-missing-arguments-expected.txt: Removed.
* fast/filesystem/entry-points-missing-arguments.html: Removed.
* fast/filesystem/file-after-reload-crash-expected.txt: Removed.
* fast/filesystem/file-after-reload-crash.html: Removed.
* fast/filesystem/file-entry-to-uri-expected.txt: Removed.
* fast/filesystem/file-entry-to-uri.html: Removed.
* fast/filesystem/file-from-file-entry-expected.txt: Removed.
* fast/filesystem/file-from-file-entry.html: Removed.
* fast/filesystem/file-metadata-after-write-expected.txt: Removed.
* fast/filesystem/file-metadata-after-write.html: Removed.
* fast/filesystem/file-writer-abort-continue-expected.txt: Removed.
* fast/filesystem/file-writer-abort-continue.html: Removed.
* fast/filesystem/file-writer-abort-depth-expected.txt: Removed.
* fast/filesystem/file-writer-abort-depth.html: Removed.
* fast/filesystem/file-writer-abort-expected.txt: Removed.
* fast/filesystem/file-writer-abort.html: Removed.
* fast/filesystem/file-writer-empty-blob-expected.txt: Removed.
* fast/filesystem/file-writer-empty-blob.html: Removed.
* fast/filesystem/file-writer-events-expected.txt: Removed.
* fast/filesystem/file-writer-events.html: Removed.
* fast/filesystem/file-writer-gc-blob-expected.txt: Removed.
* fast/filesystem/file-writer-gc-blob.html: Removed.
* fast/filesystem/file-writer-truncate-extend-expected.txt: Removed.
* fast/filesystem/file-writer-truncate-extend.html: Removed.
* fast/filesystem/file-writer-write-overlapped-expected.txt: Removed.
* fast/filesystem/file-writer-write-overlapped.html: Removed.
* fast/filesystem/filesystem-missing-arguments-expected.txt: Removed.
* fast/filesystem/filesystem-missing-arguments.html: Removed.
* fast/filesystem/filesystem-no-callback-null-ptr-crash-expected.txt: Removed.
* fast/filesystem/filesystem-no-callback-null-ptr-crash.html: Removed.
* fast/filesystem/filesystem-reference-expected.txt: Removed.
* fast/filesystem/filesystem-reference.html: Removed.
* fast/filesystem/filesystem-unserializable-expected.txt: Removed.
* fast/filesystem/filesystem-unserializable.html: Removed.
* fast/filesystem/filesystem-uri-origin-expected.txt: Removed.
* fast/filesystem/filesystem-uri-origin.html: Removed.
* fast/filesystem/flags-passing-expected.txt: Removed.
* fast/filesystem/flags-passing.html: Removed.
* fast/filesystem/input-access-entries-expected.txt: Removed.
* fast/filesystem/input-access-entries.html: Removed.
* fast/filesystem/not-enough-arguments-expected.txt: Removed.
* fast/filesystem/not-enough-arguments.html: Removed.
* fast/filesystem/op-copy-expected.txt: Removed.
* fast/filesystem/op-copy.html: Removed.
* fast/filesystem/op-get-entry-expected.txt: Removed.
* fast/filesystem/op-get-entry.html: Removed.
* fast/filesystem/op-get-metadata-expected.txt: Removed.
* fast/filesystem/op-get-metadata.html: Removed.
* fast/filesystem/op-get-parent-expected.txt: Removed.
* fast/filesystem/op-get-parent.html: Removed.
* fast/filesystem/op-move-expected.txt: Removed.
* fast/filesystem/op-move.html: Removed.
* fast/filesystem/op-read-directory-expected.txt: Removed.
* fast/filesystem/op-read-directory.html: Removed.
* fast/filesystem/op-remove-expected.txt: Removed.
* fast/filesystem/op-remove.html: Removed.
* fast/filesystem/op-restricted-chars-expected.txt: Removed.
* fast/filesystem/op-restricted-chars.html: Removed.
* fast/filesystem/op-restricted-names-expected.txt: Removed.
* fast/filesystem/op-restricted-names.html: Removed.
* fast/filesystem/op-restricted-unicode-expected.txt: Removed.
* fast/filesystem/op-restricted-unicode.html: Removed.
* fast/filesystem/read-directory-expected.txt: Removed.
* fast/filesystem/read-directory.html: Removed.
* fast/filesystem/resources: Removed.
* fast/filesystem/resources/async-operations.js: Removed.
* fast/filesystem/resources/directory-entry-to-uri.js: Removed.
* fast/filesystem/resources/file-entry-to-uri-sync.js: Removed.
* fast/filesystem/resources/file-entry-to-uri.js: Removed.
* fast/filesystem/resources/file-from-file-entry-sync.js: Removed.
* fast/filesystem/resources/file-from-file-entry.js: Removed.
* fast/filesystem/resources/file-writer-abort-continue.js: Removed.
* fast/filesystem/resources/file-writer-abort-depth.js: Removed.
* fast/filesystem/resources/file-writer-abort.js: Removed.
* fast/filesystem/resources/file-writer-empty-blob.js: Removed.
* fast/filesystem/resources/file-writer-events.js: Removed.
* fast/filesystem/resources/file-writer-gc-blob.js: Removed.
* fast/filesystem/resources/file-writer-sync-truncate-extend.js: Removed.
* fast/filesystem/resources/file-writer-sync-write-overlapped.js: Removed.
* fast/filesystem/resources/file-writer-truncate-extend.js: Removed.
* fast/filesystem/resources/file-writer-utils.js: Removed.
* fast/filesystem/resources/file-writer-write-overlapped.js: Removed.
* fast/filesystem/resources/fs-test-util.js: Removed.
* fast/filesystem/resources/fs-worker-common.js: Removed.
* fast/filesystem/resources/op-copy.js: Removed.
* fast/filesystem/resources/op-get-entry.js: Removed.
* fast/filesystem/resources/op-get-metadata.js: Removed.
* fast/filesystem/resources/op-get-parent.js: Removed.
* fast/filesystem/resources/op-move.js: Removed.
* fast/filesystem/resources/op-read-directory.js: Removed.
* fast/filesystem/resources/op-remove.js: Removed.
* fast/filesystem/resources/op-restricted-chars.js: Removed.
* fast/filesystem/resources/op-restricted-names.js: Removed.
* fast/filesystem/resources/op-restricted-unicode.js: Removed.
* fast/filesystem/resources/op-tests-helper.js: Removed.
* fast/filesystem/resources/shared-worker-stub.js: Removed.
* fast/filesystem/resources/simple-persistent-sync.js: Removed.
* fast/filesystem/resources/simple-persistent.js: Removed.
* fast/filesystem/resources/simple-readonly.js: Removed.
* fast/filesystem/resources/simple-required-arguments-getdirectory.js: Removed.
* fast/filesystem/resources/simple-required-arguments-getfile.js: Removed.
* fast/filesystem/resources/simple-required-arguments-getmetadata.js: Removed.
* fast/filesystem/resources/simple-required-arguments-remove.js: Removed.
* fast/filesystem/resources/simple-temporary-sync.js: Removed.
* fast/filesystem/resources/simple-temporary.js: Removed.
* fast/filesystem/resources/sync-operations.js: Removed.
* fast/filesystem/script-tests: Removed.
* fast/filesystem/script-tests/TEMPLATE.html: Removed.
* fast/filesystem/script-tests/filesystem-reference.js: Removed.
* fast/filesystem/script-tests/filesystem-unserializable.js: Removed.
* fast/filesystem/script-tests/flags-passing.js: Removed.
* fast/filesystem/script-tests/read-directory.js: Removed.
* fast/filesystem/simple-persistent-expected.txt: Removed.
* fast/filesystem/simple-persistent.html: Removed.
* fast/filesystem/simple-readonly-expected.txt: Removed.
* fast/filesystem/simple-readonly-file-object-expected.txt: Removed.
* fast/filesystem/simple-readonly-file-object.html: Removed.
* fast/filesystem/simple-readonly.html: Removed.
* fast/filesystem/simple-required-arguments-getdirectory-expected.txt: Removed.
* fast/filesystem/simple-required-arguments-getdirectory.html: Removed.
* fast/filesystem/simple-required-arguments-getfile-expected.txt: Removed.
* fast/filesystem/simple-required-arguments-getfile.html: Removed.
* fast/filesystem/simple-required-arguments-getmetadata-expected.txt: Removed.
* fast/filesystem/simple-required-arguments-getmetadata.html: Removed.
* fast/filesystem/simple-required-arguments-remove-expected.txt: Removed.
* fast/filesystem/simple-required-arguments-remove.html: Removed.
* fast/filesystem/simple-temporary-expected.txt: Removed.
* fast/filesystem/simple-temporary.html: Removed.
* fast/filesystem/workers: Removed.
* fast/filesystem/workers/async-operations-expected.txt: Removed.
* fast/filesystem/workers/async-operations.html: Removed.
* fast/filesystem/workers/detached-frame-crash-expected.txt: Removed.
* fast/filesystem/workers/detached-frame-crash.html: Removed.
* fast/filesystem/workers/file-entry-to-uri-sync-expected.txt: Removed.
* fast/filesystem/workers/file-entry-to-uri-sync.html: Removed.
* fast/filesystem/workers/file-from-file-entry-expected.txt: Removed.
* fast/filesystem/workers/file-from-file-entry-sync-expected.txt: Removed.
* fast/filesystem/workers/file-from-file-entry-sync.html: Removed.
* fast/filesystem/workers/file-from-file-entry.html: Removed.
* fast/filesystem/workers/file-writer-empty-blob-expected.txt: Removed.
* fast/filesystem/workers/file-writer-empty-blob.html: Removed.
* fast/filesystem/workers/file-writer-events-expected.txt: Removed.
* fast/filesystem/workers/file-writer-events-shared-worker-expected.txt: Removed.
* fast/filesystem/workers/file-writer-events-shared-worker.html: Removed.
* fast/filesystem/workers/file-writer-events.html: Removed.
* fast/filesystem/workers/file-writer-gc-blob-expected.txt: Removed.
* fast/filesystem/workers/file-writer-gc-blob.html: Removed.
* fast/filesystem/workers/file-writer-sync-truncate-extend-expected.txt: Removed.
* fast/filesystem/workers/file-writer-sync-truncate-extend.html: Removed.
* fast/filesystem/workers/file-writer-sync-write-overlapped-expected.txt: Removed.
* fast/filesystem/workers/file-writer-sync-write-overlapped.html: Removed.
* fast/filesystem/workers/file-writer-truncate-extend-expected.txt: Removed.
* fast/filesystem/workers/file-writer-truncate-extend.html: Removed.
* fast/filesystem/workers/file-writer-write-overlapped-expected.txt: Removed.
* fast/filesystem/workers/file-writer-write-overlapped.html: Removed.
* fast/filesystem/workers/resources: Removed.
* fast/filesystem/workers/resources/detached-frame-crash-frame.html: Removed.
* fast/filesystem/workers/resources/detached-frame-crash-worker.js: Removed.
* fast/filesystem/workers/simple-persistent-expected.txt: Removed.
* fast/filesystem/workers/simple-persistent-sync-expected.txt: Removed.
* fast/filesystem/workers/simple-persistent-sync.html: Removed.
* fast/filesystem/workers/simple-persistent.html: Removed.
* fast/filesystem/workers/simple-temporary-expected.txt: Removed.
* fast/filesystem/workers/simple-temporary-sync-expected.txt: Removed.
* fast/filesystem/workers/simple-temporary-sync.html: Removed.
* fast/filesystem/workers/simple-temporary.html: Removed.
* fast/filesystem/workers/sync-operations-expected.txt: Removed.
* fast/filesystem/workers/sync-operations.html: Removed.
* fast/forms/file/input-file-entries-expected.txt: Removed.
* fast/forms/file/input-file-entries.html: Removed.
* http/tests/filesystem: Removed.
* http/tests/filesystem/no-cache-filesystem-url-expected.txt: Removed.
* http/tests/filesystem/no-cache-filesystem-url.html: Removed.
* http/tests/filesystem/resolve-uri-expected.txt: Removed.
* http/tests/filesystem/resolve-uri.html: Removed.
* http/tests/filesystem/resources: Removed.
* http/tests/filesystem/resources/fs-test-util.js: Removed.
* http/tests/filesystem/resources/fs-worker-common.js: Removed.
* http/tests/filesystem/resources/fs-worker-test-util.js: Removed.
* http/tests/filesystem/script-tests: Removed.
* http/tests/filesystem/script-tests/TEMPLATE.html: Removed.
* http/tests/filesystem/script-tests/resolve-uri.js: Removed.
* http/tests/filesystem/workers: Removed.
* http/tests/filesystem/workers/resolve-url-expected.txt: Removed.
* http/tests/filesystem/workers/resolve-url-sync-expected.txt: Removed.
* http/tests/filesystem/workers/resolve-url-sync.html: Removed.
* http/tests/filesystem/workers/resolve-url.html: Removed.
* http/tests/filesystem/workers/script-tests: Removed.
* http/tests/filesystem/workers/script-tests/TEMPLATE.html: Removed.
* http/tests/filesystem/workers/script-tests/resolve-url-sync.js: Removed.
* http/tests/inspector/filesystem: Removed.
* http/tests/inspector/filesystem/delete-entry-expected.txt: Removed.
* http/tests/inspector/filesystem/delete-entry.html: Removed.
* http/tests/inspector/filesystem/directory-tree-expected.txt: Removed.
* http/tests/inspector/filesystem/directory-tree.html: Removed.
* http/tests/inspector/filesystem/filesystem-test.js: Removed.
* http/tests/inspector/filesystem/request-directory-content-expected.txt: Removed.
* http/tests/inspector/filesystem/request-directory-content.html: Removed.
* http/tests/inspector/filesystem/request-file-content-expected.txt: Removed.
* http/tests/inspector/filesystem/request-file-content.html: Removed.
* http/tests/inspector/filesystem/request-filesystem-root-expected.txt: Removed.
* http/tests/inspector/filesystem/request-filesystem-root.html: Removed.
* http/tests/inspector/filesystem/request-metadata-expected.txt: Removed.
* http/tests/inspector/filesystem/request-metadata.html: Removed.
* http/tests/security/contentSecurityPolicy/filesystem-urls-match-self-expected.txt: Removed.
* http/tests/security/contentSecurityPolicy/filesystem-urls-match-self.html: Removed.
* http/tests/security/filesystem-iframe-from-remote-expected.txt: Removed.
* http/tests/security/filesystem-iframe-from-remote.html: Removed.
* http/tests/security/mixedContent/filesystem-url-in-iframe-expected.txt: Removed.
* http/tests/security/mixedContent/filesystem-url-in-iframe.html: Removed.
* http/tests/websocket/tests/hybi/send-file-blob-expected.txt: Removed.
* http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt: Removed.
* http/tests/websocket/tests/hybi/send-file-blob-fail.html: Removed.
* http/tests/websocket/tests/hybi/send-file-blob.html: Removed.
* http/tests/workers/resources/sync-operations.js:
(onmessage):
* http/tests/workers/terminate-during-sync-operation-expected.txt: Removed.
* http/tests/workers/terminate-during-sync-operation.html: Removed.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Build fix afer r156688.
bfulgham@apple.com [Tue, 1 Oct 2013 01:47:42 +0000 (01:47 +0000)]
[Windows] Build fix afer r156688.

* fileapi/ThreadableBlobRegistry.cpp:
(WebCore::ThreadableBlobRegistry::registerBlobURL): Switch to std::unique_ptr in
method implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix build.
andersca@apple.com [Tue, 1 Oct 2013 01:37:33 +0000 (01:37 +0000)]
Fix build.

* NetworkProcess/mac/RemoteNetworkingContext.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMore build fixage for builds with SDKs.
mrowe@apple.com [Tue, 1 Oct 2013 01:24:00 +0000 (01:24 +0000)]
More build fixage for builds with SDKs.

* WebKitTestRunner/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/BaseTarget.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGet rid of more uses of OwnPtr and PassOwnPtr
andersca@apple.com [Tue, 1 Oct 2013 00:59:12 +0000 (00:59 +0000)]
Get rid of more uses of OwnPtr and PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=122136

Reviewed by Antti Koivisto.

Source/WebCore:

* Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::didReceiveBinaryData):
* WebCore.exp.in:
* fileapi/Blob.cpp:
(WebCore::Blob::Blob):
(WebCore::Blob::slice):
* fileapi/Blob.h:
(WebCore::Blob::create):
* fileapi/File.cpp:
(WebCore::createBlobDataForFileWithType):
(WebCore::createBlobDataForFile):
(WebCore::createBlobDataForFileWithName):
* fileapi/ThreadableBlobRegistry.cpp:
(WebCore::BlobRegistryContext::BlobRegistryContext):
(WebCore::registerBlobURLTask):
(WebCore::ThreadableBlobRegistry::registerBlobURL):
* fileapi/ThreadableBlobRegistry.h:
* fileapi/WebKitBlobBuilder.cpp:
(WebCore::BlobBuilder::getBlob):
* platform/network/BlobData.cpp:
(WebCore::BlobDataHandle::BlobDataHandle):
* platform/network/BlobData.h:
(WebCore::BlobData::BlobData):
(WebCore::BlobDataHandle::create):
* platform/network/BlobRegistry.h:
* platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::registerBlobURL):
* platform/network/BlobRegistryImpl.h:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseBlob):

Source/WebKit2:

* NetworkProcess/AsynchronousNetworkLoaderClient.h:
* NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
(WebKit::NetworkBlobRegistry::registerBlobURL):
* NetworkProcess/FileAPI/NetworkBlobRegistry.h:
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::NetworkResourceLoader):
* NetworkProcess/NetworkResourceLoader.h:
* NetworkProcess/SynchronousNetworkLoaderClient.h:
* NetworkProcess/mac/RemoteNetworkingContext.mm:
* Platform/CoreIPC/ArgumentDecoder.h:
* Platform/CoreIPC/ArgumentEncoder.h:
* Platform/CoreIPC/MessageDecoder.cpp:
(CoreIPC::MessageDecoder::setImportanceAssertion):
* Platform/CoreIPC/MessageDecoder.h:
* Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::receiveSourceEventHandler):
* Platform/CoreIPC/mac/ImportanceAssertion.h:
(CoreIPC::ImportanceAssertion::ImportanceAssertion):
* Platform/mac/LayerHostingContext.h:
* Platform/mac/LayerHostingContext.mm:
(WebKit::LayerHostingContext::createForPort):
(WebKit::LayerHostingContext::createForWindowServer):
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::paint):
* PluginProcess/PluginControllerProxy.h:
* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::addPluginControllerProxy):
(WebKit::WebProcessConnection::removePluginControllerProxy):
(WebKit::WebProcessConnection::createPluginInternal):
* PluginProcess/WebProcessConnection.h:
* Shared/API/c/cg/WKImageCG.cpp:
(WKImageCreateFromCGImage):
* Shared/BlockingResponseMap.h:
(BlockingResponseMap::waitForResponse):
(BlockingResponseMap::didReceiveResponse):
* Shared/Downloads/Download.cpp:
* Shared/Downloads/Download.h:
* Shared/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startDownload):
(WebKit::DownloadManager::convertHandleToDownload):
* Shared/FileAPI/BlobRegistrationData.cpp:
(WebKit::BlobRegistrationData::BlobRegistrationData):
(WebKit::BlobRegistrationData::releaseData):
(WebKit::BlobRegistrationData::decode):
* Shared/FileAPI/BlobRegistrationData.h:
* Shared/Plugins/NPObjectMessageReceiver.cpp:
* Shared/Plugins/NPObjectMessageReceiver.h:
* Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::registerNPObject):
* Shared/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::NetscapePluginModule::tryLoad):
* Shared/Plugins/Netscape/NetscapePluginModule.h:
* Shared/ShareableBitmap.h:
* Shared/WebURL.h:
(WebKit::WebURL::create):
(WebKit::WebURL::WebURL):
(WebKit::WebURL::parseURLIfNecessary):
* Shared/cg/ShareableBitmapCG.cpp:
(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::makeCGImageCopy):
* Shared/mac/SecItemShim.cpp:
(WebKit::sendSecItemRequest):
(WebKit::webSecItemCopyMatching):
(WebKit::webSecItemAdd):
(WebKit::webSecItemUpdate):
(WebKit::webSecItemDelete):
(WebKit::SecItemShim::secItemResponse):
* UIProcess/API/mac/FindIndicatorWindow.h:
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::createDrawingAreaProxy):
* UIProcess/API/mac/WKView.mm:
(-[WKView std::WebKit::]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/BackingStore.cpp:
* UIProcess/BackingStore.h:
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::incorporateUpdate):
* UIProcess/DrawingAreaProxyImpl.h:
* UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.h:
* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
* WebProcess/FileAPI/BlobRegistryProxy.cpp:
(WebKit::BlobRegistryProxy::registerBlobURL):
* WebProcess/FileAPI/BlobRegistryProxy.h:
* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
* WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.mm:
(WKBundlePageBannerCreateBannerWithCALayer):
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::imageForRect):
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::scheduleTimer):
(WebKit::NetscapePlugin::unscheduleTimer):
(WebKit::NetscapePlugin::snapshot):
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::snapshot):
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::update):
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::convertImageToBitmap):
* WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):
* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::display):
* WebProcess/WebPage/DrawingAreaImpl.h:
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::getFindIndicatorBitmapAndRect):
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createWithCoreMainFrame):
(WebKit::WebFrame::createSubframe):
(WebKit::WebFrame::create):
(WebKit::WebFrame::WebFrame):
* WebProcess/WebPage/WebFrame.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::scaledSnapshotWithOptions):
(WebKit::WebPage::drawRectToImage):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/LayerTreeHostMac.h:
* WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
* WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMessage sending functions should only accept rvalues
andersca@apple.com [Tue, 1 Oct 2013 00:48:34 +0000 (00:48 +0000)]
Message sending functions should only accept rvalues
https://bugs.webkit.org/show_bug.cgi?id=122041

Reviewed by Andreas Kling.

In order to safely encode move-only types, make all send variants accept rvalues only, except
for the "send to all processes" ones. For them, copy the message before sending. This ensures that trying
to send a move-only type in a message will fail to compile.

* NetworkProcess/NetworkResourceLoader.h:
(WebKit::NetworkResourceLoader::sendAbortingOnFailure):
* Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):
* Platform/CoreIPC/MessageSender.h:
(CoreIPC::MessageSender::sendSync):
* Shared/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::send):
(WebKit::ChildProcessProxy::sendSync):
* UIProcess/WebContext.h:
(WebKit::WebContext::sendToNetworkingProcess):
(WebKit::WebContext::sendToNetworkingProcessRelaunchingIfNecessary):
(WebKit::WebContext::sendToAllProcesses):
(WebKit::WebContext::sendToAllProcessesRelaunchingThemIfNecessary):
(WebKit::WebContext::sendToOneProcess):
* UIProcess/WebPageGroup.h:
(WebKit::WebPageGroup::sendToAllProcessesInGroup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd initial version of a new Buildbot dashboard view.
timothy@apple.com [Mon, 30 Sep 2013 23:13:55 +0000 (23:13 +0000)]
Add initial version of a new Buildbot dashboard view.

https://bugs.webkit.org/show_bug.cgi?id=122131

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BaseObject.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/15114974> Assertion failure under -[JSObjCClassInfo allocateConstruct...
mitz@apple.com [Mon, 30 Sep 2013 22:52:39 +0000 (22:52 +0000)]
<rdar://problem/15114974> Assertion failure under -[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:] if no classes conform to JSExport
https://bugs.webkit.org/show_bug.cgi?id=122124

Reviewed by Darin Adler.

* API/JSWrapperMap.mm: Defined an empty class that conforms to the JSExport protocol, to
ensure that the protocol is always registered with the runtime by the time
getJSExportProtocol() is called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove the code guarded by STYLE_SCOPED
benjamin@webkit.org [Mon, 30 Sep 2013 22:43:47 +0000 (22:43 +0000)]
Remove the code guarded by STYLE_SCOPED
https://bugs.webkit.org/show_bug.cgi?id=122123

Reviewed by Anders Carlsson.

.:

* Source/autotools/SetupWebKitFeatures.m4:
* Source/cmake/OptionsBlackBerry.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Start cleaning the code related to <style scoped>. This patch
only removes the code with #ifdef guards.

* Configurations/FeatureDefines.xcconfig:
* WebCore.exp.in:
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
* bindings/generic/RuntimeEnabledFeatures.h:
* css/DocumentRuleSets.cpp:
(WebCore::DocumentRuleSets::appendAuthorStyleSheets):
* css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::matchScopedAuthorRules):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::locateCousinList):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):
* css/StyleResolver.h:
(WebCore::StyleResolver::ensureScopeResolver):
* css/StyleScopeResolver.cpp:
* css/StyleScopeResolver.h:
* dom/Node.cpp:
* dom/Node.h:
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
* dom/ShadowRoot.h:
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::HTMLStyleElement):
(WebCore::HTMLStyleElement::parseAttribute):
(WebCore::HTMLStyleElement::insertedInto):
(WebCore::HTMLStyleElement::removedFrom):
* html/HTMLStyleElement.h:
* html/HTMLStyleElement.idl:
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
* testing/InternalSettings.h:
* testing/InternalSettings.idl:
* testing/Internals.cpp:
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit:

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/gtk:

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
* WebCoreSupport/DumpRenderTreeSupportGtk.h:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

* wtf/FeatureDefines.h:

Tools:

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
* Scripts/webkitperl/FeatureList.pm:
* qmake/mkspecs/features/features.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoASSERT(!m_hasBadParent) in InlineBox::parent() should be ASSERT_WITH_SECURITY_IMPLICATION
commit-queue@webkit.org [Mon, 30 Sep 2013 21:56:02 +0000 (21:56 +0000)]
ASSERT(!m_hasBadParent) in InlineBox::parent() should be ASSERT_WITH_SECURITY_IMPLICATION
https://bugs.webkit.org/show_bug.cgi?id=122032

Patch by Drew Yao <ayao@apple.com> on 2013-09-30
Reviewed by Andreas Kling.

Convert assertion to ASSERT_WITH_SECURITY_IMPLICATION to help catch use after free bugs.

No new tests needed.

* rendering/InlineBox.h:
(WebCore::InlineBox::parent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't attempt to destroy decoded frame if a BitmapImage doesn't have encoded raw...
commit-queue@webkit.org [Mon, 30 Sep 2013 21:54:17 +0000 (21:54 +0000)]
Don't attempt to destroy decoded frame if a BitmapImage doesn't have encoded raw data.
https://bugs.webkit.org/show_bug.cgi?id=122115

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-09-30
Reviewed by Daniel Bates.

With BitmapImage::create(PassNativeImagePtr, ImageObserver*), a BitmapImage could be created by
passing a native image.  If this image is added to memory cache, we shouldn't attempt to destroy
its decoded frames since there is no encoded raw data and we won't be able to reconstruct the image again.

No new tests for now. Currently there isn't a code path to add to the memory cache a BitmapImage
that was created by adopting a native image. We'll add such a code path in a subsequent patch.

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::destroyDecodedDataIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPass VM instead of ExecState to ObjectPrototype constructor.
akling@apple.com [Mon, 30 Sep 2013 21:42:05 +0000 (21:42 +0000)]
Pass VM instead of ExecState to ObjectPrototype constructor.
<https://webkit.org/b/122116>

Reviewed by Geoffrey Garen.

The ObjectPrototype constructor was only using the ExecState to get
to the VM.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPass VM instead of JSGlobalObject to MathObject constructor.
akling@apple.com [Mon, 30 Sep 2013 21:41:04 +0000 (21:41 +0000)]
Pass VM instead of JSGlobalObject to MathObject constructor.
<https://webkit.org/b/122119>

Reviewed by Geoffrey Garen.

The MathObject constructor was only using the global object to get
to the VM. finishCreation() still uses it to set up functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove timeout from shouldBecome* functions in js-test-pre
ap@apple.com [Mon, 30 Sep 2013 20:47:43 +0000 (20:47 +0000)]
Remove timeout from shouldBecome* functions in js-test-pre
https://bugs.webkit.org/show_bug.cgi?id=122121

Reviewed by Ryosuke Niwa.

Removed timeout. A 0.5 sec timeout never makes sense, and if something is stuck,
a test should just time out normally.

* resources/js-test-pre.js:
(_waitForCondition):
(shouldBecomeEqual):
(shouldBecomeEqualToString):
(shouldBecomeDifferent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGet rid of the AlreadyInJSStack recoveries since they are totally redundant with...
fpizlo@apple.com [Mon, 30 Sep 2013 20:38:46 +0000 (20:38 +0000)]
Get rid of the AlreadyInJSStack recoveries since they are totally redundant with the DisplacedInJSStack recoveries
https://bugs.webkit.org/show_bug.cgi?id=122065

Reviewed by Mark Hahnenberg.

This mostly just kills a bunch of code.

But incidentaly while killing that code, I uncovered a bug in our FTL OSR entrypoint
creation phase. The phase inserts a sequence of SetLocal(ExtractOSREntryLocal) nodes.
If we hoist some type check into the local, then we might inject a conversion node
between the ExtractOSREntryLocal and the SetLocal - for example we might put in a
Int32ToDouble node. But currently the FixupPhase will make all conversion nodes placed
on an edge of a SetLocal use forward exit. This then confuses the OSR exit machinery.
When OSR exit sees a forward exit, it tries to "roll forward" execution from the exiting
node to the first node that has a different CodeOrigin. This only works if the nodes
after the forward exit are MovHints or other tnings that the OSR exit compiler can
forward-execute. But here, it will see a bunch of SetLocal and ExtractOSREntryLocal
nodes for the same bytecode index. Two possible solutions exist. We could teach the
forward-execution logic how to deal with multiple SetLocals and ExtractOSREntryLocals.
This would be a lot of complexity; right now it just needs to deal with exactly one
SetLocal-like operation. The alternative is to make sure that the conversion node that
we inject ends up exiting *backward* rather than forward.

But making the conversion nodes exit backward is somewhat tricky. Before this patch,
conversion nodes always exit forward for SetLocals and backwards otherwise. It turns out
that the solution is to rationalize how we choose the speculation direciton for a
conversion node. The conversion node's speculation direction should be the same as the
speculation direction of the node for which it is doing a conversion. Since SetLocal's
already exit forward by default, this policy preserves our previous behavior. But it
also allows the OSR entrypoint creation phase to make its SetLocals exit backward
instead.

Of course, if the SetLocal(ExtractOSREntryLocal) sequences exit backward, then we need
to make sure that the OSR exit machine knows that the local variables are indeed live.
Consider that if we have:

    a: ExtractOSREntryLocal(loc1)
    b: SetLocal(@a, loc1)
    c: ExtractOSRentryLocal(loc2)
    d: SetLocal(@c, loc2)

Without additional magic, the exit at @b will think that loc2 is dead and the OSR exit
compiler will clobber loc2 with Undefined. So we need to make sure that we actually
emit code like:

    a: ExtractOSREntryLocal(loc1)
    b: ExtractOSREntryLocal(loc2)
    c: SetLocal(@a, loc1)
    d: SetLocal(@b, loc2)
    e: SetLocal(@a, loc1)
    f: SetLocal(@b, loc2)

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/CodeOrigin.h:
* bytecode/ValueRecovery.cpp: Added.
(JSC::ValueRecovery::recover):
(JSC::ValueRecovery::dumpInContext):
(JSC::ValueRecovery::dump):
* bytecode/ValueRecovery.h:
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupSetLocalsInBlock):
(JSC::DFG::FixupPhase::fixEdge):
* dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::reconstruct):
* dfg/DFGNode.h:
(JSC::DFG::Node::speculationDirection):
(JSC::DFG::Node::setSpeculationDirection):
* dfg/DFGOSREntrypointCreationPhase.cpp:
(JSC::DFG::OSREntrypointCreationPhase::run):
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* dfg/DFGValueSource.h:
(JSC::DFG::ValueSource::valueRecovery):
* dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStream::reconstruct):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateMachineInt):
* interpreter/Register.h:
(JSC::Register::unboxedStrictInt52):
* runtime/Arguments.cpp:
(JSC::Arguments::tearOff):
* runtime/Arguments.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove IDBTracing.h.
beidson@apple.com [Mon, 30 Sep 2013 20:32:21 +0000 (20:32 +0000)]
Remove IDBTracing.h.
https://bugs.webkit.org/show_bug.cgi?id=122118

Reviewed by Alexey Proskuryakov.

Global replace of "IDB_TRACE" with "LOG(StorageAPI)", and remove all notions of this header.

* GNUmakefile.list.am:

* Modules/indexeddb/IDBCursor.cpp:
* Modules/indexeddb/IDBDatabase.cpp:
* Modules/indexeddb/IDBDatabaseBackendInterface.h:
* Modules/indexeddb/IDBFactory.cpp:
* Modules/indexeddb/IDBIndex.cpp:
* Modules/indexeddb/IDBObjectStore.cpp:
* Modules/indexeddb/IDBOpenDBRequest.cpp:
* Modules/indexeddb/IDBRequest.cpp:
* Modules/indexeddb/IDBTracing.h: Removed.
* Modules/indexeddb/IDBTransaction.cpp:
* Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
* Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp:
* Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:
* Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
* Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp:
* Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/IDBBindingUtilities.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: rows in the Layer sidebar panel may have the incorrect background...
graouts@apple.com [Mon, 30 Sep 2013 20:10:14 +0000 (20:10 +0000)]
Web Inspector: rows in the Layer sidebar panel may have the incorrect background color
https://bugs.webkit.org/show_bug.cgi?id=122108

Reviewed by Darin Adler.

The LayerTreeDataGrid is a custom DataGrid subclass which exposes a .setChildren() method
used to sort chidren without DOM order manipulation, for performance reason. However, since
the way the alternating background color is usually implemented is based on the built-in
CSS pseudo-classes working with DOM order, the background colors of nodes in the LayerTreeDataGrid
can be incorrect depending on the sort order and the number of nodes. To fix this, we now manually
set "even" and "odd" CSS classes on those nodes when they're sorted such that we have a chance
to style them as intended.

* UserInterface/LayerTreeDataGrid.js:
(WebInspector.LayerTreeDataGrid.prototype._updateChildren):
Check if the data grid node index is even or odd and reflect this via an exclusive "even"
or "odd" CSS class name.

* UserInterface/LayerTreeSidebarPanel.css:
(.layer-tree.panel .data-container tbody > tr.even):
(.layer-tree.panel .data-container tbody > tr.odd):
Apply alternating colors based on the exclusive "even" and "odd" CSS class names as applied in
WebInspector.LayerTreeDataGrid.prototype._updateChildren().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Unreviewed build fix for Win64.
alex.christensen@flexsim.com [Mon, 30 Sep 2013 20:07:35 +0000 (20:07 +0000)]
[Windows] Unreviewed build fix for Win64.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Added correct 64-bit BitmapImage::create symbol.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Popover displaying "reasons for compositing" may remain on screen...
graouts@apple.com [Mon, 30 Sep 2013 20:07:10 +0000 (20:07 +0000)]
Web Inspector: Popover displaying "reasons for compositing" may remain on screen after selected layer is removed
https://bugs.webkit.org/show_bug.cgi?id=117575

Ensure the popover attached to the selected data grid node is updated when the
content or sort order of the Layer sidebar panel is updated.

Reviewed by Darin Adler.

* UserInterface/LayerTreeSidebarPanel.js:
(WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: nodes can be dragged from the console log
graouts@apple.com [Mon, 30 Sep 2013 20:06:06 +0000 (20:06 +0000)]
Web Inspector: nodes can be dragged from the console log
https://bugs.webkit.org/show_bug.cgi?id=122105

Reviewed by Darin Adler.

Catch "dragstart" events targeting nodes hosted in a DOMTreeOutline within the console
log view and prevent the default logic to trigger so that these nodes can't be dragged
off the console as it wouldn't make sense to.

* UserInterface/DOMTreeOutline.js:
(WebInspector.DOMTreeOutline):
Create a class property to allow the CSS class name to be used in WebInspector.LogContentView.

* UserInterface/LogContentView.js:
(WebInspector.LogContentView):
(WebInspector.LogContentView.prototype._ondragstart):
Track the "dragstart" events in their capture phase such that, if the event target is
a DOM node hosted in a DOMTreeOutline, we can prevent the event from propagating and
cancel its default behavior such that no dragging at all is performed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWin64 compile fix after r1256490.
alex.christensen@flexsim.com [Mon, 30 Sep 2013 19:51:43 +0000 (19:51 +0000)]
Win64 compile fix after r1256490.
https://bugs.webkit.org/show_bug.cgi?id=122117

Patch by Alex Christensen <alex.christensen@flexsim.com> on 2013-09-30
Reviewed by Michael Saboff.

* jit/JITStubsMSVC64.asm:
Implemented getHostCallReturnValue for Windows x86_64 processors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNetworkResourceLoader.messages.in should be ENABLE(NETWORK_PROCESS) guarded
ossy@webkit.org [Mon, 30 Sep 2013 19:44:51 +0000 (19:44 +0000)]
NetworkResourceLoader.messages.in should be ENABLE(NETWORK_PROCESS) guarded
https://bugs.webkit.org/show_bug.cgi?id=122110

Reviewed by Darin Adler.

* NetworkProcess/NetworkResourceLoader.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Build fix after r156622. Build RenderLayerModelObject.cpp in a separate...
bfulgham@apple.com [Mon, 30 Sep 2013 19:35:54 +0000 (19:35 +0000)]
[Windows] Build fix after r156622. Build RenderLayerModelObject.cpp in a separate compilation unit
from the RenderLayerAllnOne file so that the scalar and vector destructors are visible to other
elements of WebCore during the build.

* WebCore.vcxproj/WebCore.vcxproj: Compile RenderLayerModelObject outside of the all-in-one file.
* WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
* rendering/RenderingAllInOne.cpp: Remove RenderLayerModelObject.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPass VM instead of JSGlobalObject to RegExp constructor.
akling@apple.com [Mon, 30 Sep 2013 18:58:51 +0000 (18:58 +0000)]
Pass VM instead of JSGlobalObject to RegExp constructor.
<https://webkit.org/b/122113>

Reviewed by Darin Adler.

RegExps don't need anything from the global object during their
construction and only use it to get to the VM. Reduce loads by
simply passing the VM around instead.

JSC release binary size -= 120 bytes(!)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Win] Compile errors in WebKit (via peavo@outlook.com).
bfulgham@apple.com [Mon, 30 Sep 2013 18:13:27 +0000 (18:13 +0000)]
[Win] Compile errors in WebKit (via peavo@outlook.com).
https://bugs.webkit.org/show_bug.cgi?id=122106

Reviewed by Darin Adler.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add link
declarations missed in r156655.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the build when building against an SDK.
mrowe@apple.com [Mon, 30 Sep 2013 18:09:55 +0000 (18:09 +0000)]
Fix the build when building against an SDK.

Xcode helpfully prepends $(SDKROOT) to the paths in FRAMEWORK_SEARCH_PATHS when generating
the compiler command lines. It can't know to do this for the system framework search paths
we add manually via OTHER_CFLAGS though, so we need to prefix them with $(SDKROOT) ourself.

Source/WebCore:

* Configurations/WebCore.xcconfig:

Source/WebKit/mac:

* Configurations/WebKit.xcconfig:

Source/WebKit2:

* Configurations/BaseTarget.xcconfig:

Tools:

* DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
* WebKitTestRunner/Configurations/BaseTarget.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Unreviewed build fix.
bfulgham@apple.com [Mon, 30 Sep 2013 17:58:27 +0000 (17:58 +0000)]
[Windows] Unreviewed build fix.

* WebCore.vcxproj/WebCore.vcxproj.filters: Correct malformed XML in project files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, roll back in r156546 with rebaselined tests.
jer.noble@apple.com [Mon, 30 Sep 2013 17:56:35 +0000 (17:56 +0000)]
Unreviewed, roll back in r156546 with rebaselined tests.
https://bugs.webkit.org/show_bug.cgi?id=122111

Source/WebCore:

* Modules/mediacontrols/mediaControlsApple.js:
(Controller):
(Controller.prototype.addVideoListeners):
(Controller.prototype.removeVideoListeners):
(Controller.prototype.updateHasAudio):

LayoutTests:

* platform/mac/TestExpectations:
* platform/mac/fast/hidpi/video-controls-in-hidpi-expected.png:
* platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt:
* platform/mac/fast/layers/video-layer-expected.png:
* platform/mac/fast/layers/video-layer-expected.txt:
* platform/mac/media/media-controls-clone-expected.png:
* platform/mac/media/media-controls-clone-expected.txt:
* platform/mac/media/video-no-audio-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoediting/execCommand/findString-diacriticals.html expects to fail
commit-queue@webkit.org [Mon, 30 Sep 2013 17:38:02 +0000 (17:38 +0000)]
editing/execCommand/findString-diacriticals.html expects to fail
https://bugs.webkit.org/show_bug.cgi?id=122100

Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-09-30
Reviewed by Alexey Proskuryakov.

Since all major platforms pass editing/execCommand/findString-diacriticals.html,
the test now globally expects "PASS" instead of "FAIL" rendering the individual
platform expectation files obsolete.

* editing/execCommand/findString-diacriticals-expected.txt: "PASS" -> "FAIL"
* platform/efl/TestExpectations: EFL passes editing/execCommand/findString-diacriticals.
* platform/gtk/editing/execCommand/findString-diacriticals-expected.txt: Removed.
* platform/mac/editing/execCommand/findString-diacriticals-expected.txt: Removed.
* platform/qt/editing/execCommand/findString-diacriticals-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Unreviewed test fix. Prevent crash when changing URL paths during testing.
bfulgham@apple.com [Mon, 30 Sep 2013 17:36:54 +0000 (17:36 +0000)]
[Windows] Unreviewed test fix. Prevent crash when changing URL paths during testing.

A shared BSTR value (_bstr_t) was being reallocated outside the smart pointer, causing
it to be double-freed.

* WinLauncher/WinLauncher.cpp:
(EditProc): Be explicit about type passed to loadURL.
(loadURL): Create a shallow copy of the BSTR so we only allocate memory if needed. Use _bstr_t so
that reallocating the BSTR is done with the knowledge of the smart pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r156656.
commit-queue@webkit.org [Mon, 30 Sep 2013 16:59:35 +0000 (16:59 +0000)]
Unreviewed, rolling out r156656.
http://trac.webkit.org/changeset/156656
https://bugs.webkit.org/show_bug.cgi?id=122111

Broke several media tests (Requested by ap on #webkit).

Source/WebCore:

* Modules/mediacontrols/mediaControlsApple.js:
(Controller):
(Controller.prototype.addVideoListeners):
(Controller.prototype.removeVideoListeners):

LayoutTests:

* platform/mac/TestExpectations:
* platform/mac/media/video-no-audio-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert a bunch of OwnPtrs on Page to std::unique_ptrs
weinig@apple.com [Mon, 30 Sep 2013 16:50:34 +0000 (16:50 +0000)]
Convert a bunch of OwnPtrs on Page to std::unique_ptrs
https://bugs.webkit.org/show_bug.cgi?id=122086

Reviewed by Darin Adler.

* loader/ProgressTracker.cpp:
* loader/ProgressTracker.h:
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::setGroupName):
(WebCore::Page::initGroup):
* page/Page.h:
* page/PageGroup.cpp:
(WebCore::PageGroup::PageGroup):
* page/PageGroup.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Changed expectation for accessibility/file-upload-button-stringvalue.html after...
commit-queue@webkit.org [Mon, 30 Sep 2013 16:32:07 +0000 (16:32 +0000)]
[EFL] Changed expectation for accessibility/file-upload-button-stringvalue.html after r156532
https://bugs.webkit.org/show_bug.cgi?id=122103

Unreviewed EFL gardening.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-30

* platform/efl-wk1/TestExpectations: file-upload-button-stringvalue.html fails on efl-wk1.
Unskipped accessibility/heading-level.html. It passes after r156551.
* platform/efl-wk2/accessibility/file-upload-button-stringvalue-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix force_static_libs_as_shared in WebKit2
allan.jensen@digia.com [Mon, 30 Sep 2013 16:30:46 +0000 (16:30 +0000)]
[Qt] Fix force_static_libs_as_shared in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=121961

Reviewed by Csaba Osztrogonác.

Get rid of the unused WebKit2QML library

.:

* Source/api.pri:

Source/WebKit2:

* Target.pri:
* WebKit2.pro:
* WebKit2QML.pri: Removed.

Tools:

* qmake/mkspecs/features/webkit_modules.prf:
* qmake/mkspecs/modules/webkit2qml.prf: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove FontTranscoder
antti@apple.com [Mon, 30 Sep 2013 16:21:54 +0000 (16:21 +0000)]
Remove FontTranscoder
https://bugs.webkit.org/show_bug.cgi?id=122088

Reviewed by Andreas Kling.

This overly generic class just implements mapping of backslash to yen symbol for some legacy Japanese fonts.

* CMakeLists.txt:
* GNUmakefile.am:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.pri:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/Font.cpp:
(WebCore::useBackslashAsYenSignForFamily):

    Move the family set to Font.cpp.

(WebCore::Font::Font):
(WebCore::Font::operator=):
(WebCore::Font::update):

    Keep the cached boolean up to date.

* platform/graphics/Font.h:
(WebCore::Font::useBackslashAsYenSymbol):

    Use descriptive name instead of talking about "transcoding".

* platform/text/transcoder: Removed.
* platform/text/transcoder/FontTranscoder.cpp: Removed.
* platform/text/transcoder/FontTranscoder.h: Removed.
* rendering/RenderText.cpp:
(WebCore::RenderText::RenderText):
(WebCore::RenderText::computeUseBackslashAsYenSymbol):

    Rename for clarity.
    Avoid unnecessary hash lookup, just check the cached bit in Font.

(WebCore::RenderText::styleDidChange):
(WebCore::RenderText::setTextInternal):

    "Transcoding" here was just a simple character replacement.

(WebCore::RenderText::textWithoutConvertingBackslashToYenSymbol):

    Renamed.

* rendering/RenderText.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r156546): media/video-no-audio.html broken
jer.noble@apple.com [Mon, 30 Sep 2013 16:09:37 +0000 (16:09 +0000)]
REGRESSION(r156546): media/video-no-audio.html broken
https://bugs.webkit.org/show_bug.cgi?id=122049

Reviewed by Eric Carlson.

Source/WebCore:

Now that our video elements have audio tracks, use their presence or
absense to show or hide the volume controls.

* Modules/mediacontrols/mediaControlsApple.js:
(Controller):
(Controller.prototype.addVideoListeners): Listen for audioTrack changes.
(Controller.prototype.removeVideoListeners): Stop listening to same.
(Controller.prototype.handleAudioTrackChange): Call this.updateHasAudio()
(Controller.prototype.handleAudioTrackAdd): Ditto.
(Controller.prototype.handleAudioTrackRemove): Ditto.
(Controller.prototype.updateHasAudio): Hide the volume controls if no
    audioTracks are present, and vice versa.

LayoutTests:

* platform/mac/TestExpectations:
* platform/mac/media/video-no-audio-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTry to fix the Windows build.
akling@apple.com [Mon, 30 Sep 2013 15:43:34 +0000 (15:43 +0000)]
Try to fix the Windows build.

* WebFrame.cpp:
(WebFrame::pauseAnimation):
(WebFrame::pauseTransition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix compilation for COMPILER(MSVC) && !CPU(X86) after r156490.
paroga@webkit.org [Mon, 30 Sep 2013 15:42:49 +0000 (15:42 +0000)]
Fix compilation for COMPILER(MSVC) && !CPU(X86) after r156490.
https://bugs.webkit.org/show_bug.cgi?id=122102

Reviewed by Geoffrey Garen.

_AddressOfReturnAddress() is supported for all platforms of
ths Microsoft compiler, so we can use it for !CPU(X86) too.

* jit/JITOperationWrappers.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Mac-Lion build fix.
jer.noble@apple.com [Mon, 30 Sep 2013 15:39:10 +0000 (15:39 +0000)]
Unreviewed Mac-Lion build fix.

Use metadataItemsFromArray:withLocale: instead of
metadataItemsFromArray:filteredAndSortedAccordingToPreferredLanguages:
on Lion and earlier.

* platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
(WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] Add AudioTrack support to MediaPlayerPrivateAVFObC.
jer.noble@apple.com [Mon, 30 Sep 2013 15:17:28 +0000 (15:17 +0000)]
[Mac] Add AudioTrack support to MediaPlayerPrivateAVFObC.
https://bugs.webkit.org/show_bug.cgi?id=122043

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/audio-track.html

Add a new class AudioTrackPrivateAVF and subclass AudioTrackPrivateAVFObjC
which are backed by a AVPlayerItemTrack. Create one of these tracks when
we are notified that the list of available tracks has changed.

* WebCore.xcodeproj/project.pbxproj:
* html/track/AudioTrack.cpp:
(WebCore::AudioTrack::setEnabled): Pass through to the AudioTrackPrivate
    so that the underlying media track can be (dis|en)abled.
* platform/graphics/avfoundation/AudioTrackPrivateAVF.h: Added.
(WebCore::AudioTrackPrivateAVF::kind): Simple getter.
(WebCore::AudioTrackPrivateAVF::id): Ditto.
(WebCore::AudioTrackPrivateAVF::label): Ditto.
(WebCore::AudioTrackPrivateAVF::language): Ditto.
(WebCore::AudioTrackPrivateAVF::setKind): Simple Setter.
(WebCore::AudioTrackPrivateAVF::setId): Ditto.
(WebCore::AudioTrackPrivateAVF::setLabel): Ditto.
(WebCore::AudioTrackPrivateAVF::setLanguage): Ditto.
(WebCore::AudioTrackPrivateAVF::AudioTrackPrivateAVF): Simple constructor.
* platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.h: Added.
(WebCore::AudioTrackPrivateAVFObjC::create): Simple factory.
(WebCore::AudioTrackPrivateAVFObjC::playerItemTrack): Simple getter.
* platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm: Added.
(WebCore::AudioTrackPrivateAVFObjC::AudioTrackPrivateAVFObjC): Call resetPropertiesFromTrack.
(WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack): Fill out the values from
    the associated AVPlayerItemTrack and its AVAssetTrack.
(WebCore::AudioTrackPrivateAVFObjC::setPlayerItemTrack): Call resetPropertiesFromTrack.
(WebCore::AudioTrackPrivateAVFObjC::setEnabled): (En|Dis)able the AVPlayerItemTrack.
(WebCore::AudioTrackPrivateAVFObjC::languageForAVAssetTrack): Refactored from
    MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Determine which tracks
    have been added or removed and notify the clients accordingly.
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Refactor into
    AudioTrackPrivateAVFObjC::languageForAVAssetTrack.

LayoutTests:

* media/track/audio-track-expected.txt: Added.
* media/track/audio-track.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Added passing expectation for fast/forms/textarea-metrics.html
commit-queue@webkit.org [Mon, 30 Sep 2013 14:57:23 +0000 (14:57 +0000)]
[EFL] Added passing expectation for fast/forms/textarea-metrics.html
https://bugs.webkit.org/show_bug.cgi?id=122107

Unreviewed EFL gardening.

fast/forms/textarea-metrics.html fails in WebKitTestRunner but returns expected
results in MiniBrowser. Since GTK uses platform dependent expectation file to
migitate this identical discrepancy, the same solution has been applied to EFL.

Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-09-30

* platform/efl/TestExpectations:
* platform/efl/fast/forms/textarea-metrics-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed WinCE build fix after r153927.
paroga@webkit.org [Mon, 30 Sep 2013 14:05:46 +0000 (14:05 +0000)]
Unreviewed WinCE build fix after r153927.

* WebView.cpp:
(WebView::WebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed WinCE build fix after r155289.
paroga@webkit.org [Mon, 30 Sep 2013 13:58:00 +0000 (13:58 +0000)]
Unreviewed WinCE build fix after r155289.

* WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForResponse):
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNewWindowAction):
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNavigationAction):
(WebKit::FrameLoaderClientWinCE::dispatchWillSubmitForm):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed WinCE build fix after r154178.
paroga@webkit.org [Mon, 30 Sep 2013 13:57:41 +0000 (13:57 +0000)]
Unreviewed WinCE build fix after r154178.

* WebView.cpp:
(WebView::wndProc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Fix incorrect click counting in EventSenderProxy
commit-queue@webkit.org [Mon, 30 Sep 2013 13:15:31 +0000 (13:15 +0000)]
[EFL] Fix incorrect click counting in EventSenderProxy
https://bugs.webkit.org/show_bug.cgi?id=122098

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-09-30
Reviewed by Gyuyoung Kim.

Tools:

Previously used two types of recording time, which conflicted with each other.

* WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
(WTR::EventSenderProxy::mouseUp):

LayoutTests:

After fixing EventSenderProxy extend-selection-after-double-click.html runs correctly.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening after the resolution of bug 84835
commit-queue@webkit.org [Mon, 30 Sep 2013 11:49:19 +0000 (11:49 +0000)]
[EFL] Gardening after the resolution of bug 84835
https://bugs.webkit.org/show_bug.cgi?id=122096

Unreviewed EFL gardening.

Removed expected failures for bug 84835.
editing/pasteboard/copy-inside-h1-preserves-h1 and
editing/pasteboard/copy-without-selection are still failing due to bug 86623
and have been marked accordingly.

Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-09-30

* platform/efl-wk1/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening. Two tests are passing in WK2 after r156541.
mario@webkit.org [Mon, 30 Sep 2013 10:56:08 +0000 (10:56 +0000)]
Unreviewed GTK gardening. Two tests are passing in WK2 after r156541.

* platform/gtk-wk2/TestExpectations: Removed passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Accessibility tests pass after r156532 and r156551
commit-queue@webkit.org [Mon, 30 Sep 2013 10:46:52 +0000 (10:46 +0000)]
[EFL] Accessibility tests pass after r156532 and r156551
https://bugs.webkit.org/show_bug.cgi?id=122090

Unreviewed EFL gardening.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-30

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] New test accessibility/table-with-hidden-head-section.html failing on EFL port
commit-queue@webkit.org [Mon, 30 Sep 2013 10:44:57 +0000 (10:44 +0000)]
[EFL] New test accessibility/table-with-hidden-head-section.html failing on EFL port
https://bugs.webkit.org/show_bug.cgi?id=111850

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-30
Reviewed by Mario Sanchez Prada.

Test passes after r156532.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGenerate toCSSCalcValue instead of using manual cast function
gyuyoung.kim@samsung.com [Mon, 30 Sep 2013 10:39:08 +0000 (10:39 +0000)]
Generate toCSSCalcValue instead of using manual cast function
https://bugs.webkit.org/show_bug.cgi?id=122055

Reviewed by Antti Koivisto.

Generated type cast function supports more plenty functions rather than manual functions.
To use CSS_VALUE_TYPE_CAST, isCalculationValue() needs to be changed with isCalcValue().

No new tests, no behavior changes.

* css/CSSCalculationValue.h:
* css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
* css/CSSValue.h:
(WebCore::CSSValue::isCalcValue):
* css/StyleResolver.cpp:
(WebCore::hasVariableReference):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Build fix for DEBUG_VERBOSE mode after r156511.
rgabor@webkit.org [Mon, 30 Sep 2013 09:33:34 +0000 (09:33 +0000)]
Unreviewed. Build fix for DEBUG_VERBOSE mode after r156511.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[webkitpy] Make the Xvfb screen depth overridable
zandobersek@gmail.com [Mon, 30 Sep 2013 08:26:47 +0000 (08:26 +0000)]
[webkitpy] Make the Xvfb screen depth overridable
https://bugs.webkit.org/show_bug.cgi?id=122089

Reviewed by Gyuyoung Kim.

Make the Xvfb screen depth overridable by checking if the XVFB_SCREEN_DEPTH environment variable
was set. The default value that's used if the variable wasn't set is 24.

* Scripts/webkitpy/port/xvfbdriver.py:
(XvfbDriver._xvfb_screen_depth):
(XvfbDriver._start):
* Scripts/webkitpy/port/xvfbdriver_unittest.py:
(XvfbDriverTest.make_driver):
(XvfbDriverTest.test_start_no_pixel_tests):
(XvfbDriverTest.test_start_pixel_tests):
(XvfbDriverTest.test_start_arbitrary_worker_number):
(XvfbDriverTest.test_next_free_display):
(XvfbDriverTest.test_start_next_worker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGet rid of static map for marking ancestor line boxes dirty
antti@apple.com [Mon, 30 Sep 2013 08:21:34 +0000 (08:21 +0000)]
Get rid of static map for marking ancestor line boxes dirty
https://bugs.webkit.org/show_bug.cgi?id=122080

Reviewed by Andreas Kling.

This is ugly and shows up in profiles too. Use a bit in RenderElement instead.

* rendering/RenderBlock.h:
* rendering/RenderBlockFlow.h:

    Move dirtyLinesFromChangedChild down to RenderBlockFlow. It wouldn't do anything on other RenderBlocks.

* rendering/RenderElement.cpp:
(WebCore::RenderElement::RenderElement):
* rendering/RenderElement.h:

    Add m_ancestorLineBoxDirty bit. We have 32 unused bits here on 64bit systems.

(WebCore::RenderElement::dirtyLinesFromChangedChild):
(WebCore::RenderElement::ancestorLineBoxDirty):
(WebCore::RenderElement::setAncestorLineBoxDirty):
(WebCore::RenderObject::setNeedsLayout):
* rendering/RenderInline.h:
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):

    Tighten the interface.

* rendering/RenderLineBoxList.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed):
* rendering/RenderObject.h:

    Remove the static map.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Grid Layout] Implement the grid-area shorthand
svillar@igalia.com [Mon, 30 Sep 2013 08:14:41 +0000 (08:14 +0000)]
[CSS Grid Layout] Implement the grid-area shorthand
https://bugs.webkit.org/show_bug.cgi?id=103334

Reviewed by Andreas Kling.

Source/WebCore:

Based on Blink r151684 by <jchaffraix@chromium.org>

Test: fast/css-grid-layout/grid-item-area-get-set.html

Added support to specify grid positions using the
'-webkit-grid-area' shorthand. Named grid areas are still not
allowed, to be done in a follow up patch as it likely requires
'-webkit-grid-template' support.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridItemPositionShorthand):
* css/CSSPropertyNames.in:
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
* css/StylePropertyShorthand.cpp:
(WebCore::webkitGridAreaShorthand):
(WebCore::shorthandForProperty):
* css/StylePropertyShorthand.h:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):

LayoutTests:

From Blink r151684 by <jchaffraix@chromium.org>

* fast/css-grid-layout/grid-item-area-get-set-expected.txt: Added.
* fast/css-grid-layout/grid-item-area-get-set.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Speculative build fix on ARMv7 Thumb2 after r156490.
rgabor@webkit.org [Mon, 30 Sep 2013 08:10:12 +0000 (08:10 +0000)]
Unreviewed. Speculative build fix on ARMv7 Thumb2 after r156490.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::fmodAsDFGOperation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGenerate toCSSFooValue for CSSGradientValue, CSSLinearGradientValue and CSSRadialGradient
gyuyoung.kim@samsung.com [Mon, 30 Sep 2013 07:35:29 +0000 (07:35 +0000)]
Generate toCSSFooValue for CSSGradientValue, CSSLinearGradientValue and CSSRadialGradient
https://bugs.webkit.org/show_bug.cgi?id=122060

Reviewed by Antti Koivisto.

As a step to generate toCSSFooValue, toCSSGradientValuem toCSSLinearGradientValue and
toCSSRadialGradient are generated. isLinearGradient() and isRadialGradient() are moved
from each class to CSSValue in order to generate toCSSFooValue.

No new tests, no behavior change.

* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::image):
(WebCore::CSSGradientValue::gradientWithStylesResolved):
* css/CSSGradientValue.h:
* css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseDeprecatedGradient):
* css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
* css/CSSValue.h:
(WebCore::CSSValue::isLinearGradient):
(WebCore::CSSValue::isRadialGradient):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agouser-select: none cursor turns to I-beam on mouse dragging
commit-queue@webkit.org [Mon, 30 Sep 2013 07:12:44 +0000 (07:12 +0000)]
user-select: none cursor turns to I-beam on mouse dragging
https://bugs.webkit.org/show_bug.cgi?id=90159

Patch by Vani Hegde <vani.hegde@samsung.com> on 2013-09-30
Reviewed by Ryosuke Niwa.

Source/WebCore:

When tried to select some text in an area that has style
cursor:default set, cursor type changes to text cursor ignoring
the cursor style that is explicitly set.

When the cursor style is explicitly set as default (or something else),
we should not change it to text cursor no matter what we are over
or what operation we are performing (be it hovering over the text
or selecting the text).

During text selection, changing the cursor type to text only when
there is no explicit cursor type set fixes the issue.

Test: editing/caret/selection-with-caret-type-progress.html

* page/EventHandler.cpp:
(WebCore::EventHandler::selectCursor):
During selection, set the cursor style to text only if there is no
explicit cursor style set.

LayoutTests:

Test case added to verify that explicitly set cursor style
is retained on performing text selection.

* editing/caret/selection-with-caret-type-progress-expected.txt: Added.
* editing/caret/selection-with-caret-type-progress.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFTL: refactor compileAdd and compileArithSub into one function.
commit-queue@webkit.org [Mon, 30 Sep 2013 06:32:59 +0000 (06:32 +0000)]
FTL: refactor compileAdd and compileArithSub into one function.
https://bugs.webkit.org/show_bug.cgi?id=122081

Patch by Nadav Rotem <nrotem@apple.com> on 2013-09-29
Reviewed by Geoffrey Garen.

* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileAddSub):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGenerate toCSSFooValue() for CSSCanvasValue
gyuyoung.kim@samsung.com [Mon, 30 Sep 2013 05:40:57 +0000 (05:40 +0000)]
Generate toCSSFooValue() for CSSCanvasValue
https://bugs.webkit.org/show_bug.cgi?id=122058

Reviewed by Antti Koivisto.

Generate toCSSFooValue() for CSSCanvasValue, and use it.
This type cast function will help to detect bad-casts.
isCanvasValue() is added in order to generate toCSSCanvasValue.

No new tests, no behavior change.

* css/CSSCanvasValue.h:
* css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):
* css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
* css/CSSValue.h:
(WebCore::CSSValue::isCanvasValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTake some Xcode advice about turning on additional warnings in ANGLE and gtest
darin@apple.com [Mon, 30 Sep 2013 05:38:32 +0000 (05:38 +0000)]
Take some Xcode advice about turning on additional warnings in ANGLE and gtest
https://bugs.webkit.org/show_bug.cgi?id=122087

Reviewed by Mark Rowe.

Source/ThirdParty:

* gtest/xcode/Config/General.xcconfig: Added some warnings that Xcode 5 suggested.

Source/ThirdParty/ANGLE:

* Configurations/Base.xcconfig: Add some of the warnings that Xcode 5 suggested.
* src/compiler/preprocessor/Tokenizer.l: Defined YY_NO_INPUT so we don't compile
an unused function and get a warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the Lion build.
mrowe@apple.com [Mon, 30 Sep 2013 05:30:50 +0000 (05:30 +0000)]
Fix the Lion build.

Ensure that C++ and Objective-C++ files build with the right compiler flags.

Source/WebCore:

* Configurations/WebCore.xcconfig:

Source/WebKit/mac:

* Configurations/WebKit.xcconfig:

Source/WebKit2:

* Configurations/BaseTarget.xcconfig:

Tools:

* DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
* WebKitTestRunner/Configurations/BaseTarget.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGenerate toCSSFooValue() for CSSLineBoxContainValue
gyuyoung.kim@samsung.com [Mon, 30 Sep 2013 05:28:58 +0000 (05:28 +0000)]
Generate toCSSFooValue() for CSSLineBoxContainValue
https://bugs.webkit.org/show_bug.cgi?id=122054

Reviewed by Darin Adler.

As a step to use toCSSFooValue, toCSSLineBoxContainValue is generated by using
CSS_VALUE_TYPE_CASTS. To use it, isCSSLineBoxContainValue() is changed to
isLineBoxContatinValue(). Unnecessary local variable is removed by this patch.

No new tests, no behavior changes.

* css/CSSLineBoxContainValue.h:
* css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
* css/CSSValue.h:
(WebCore::CSSValue::isLineBoxContainValue):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGenerate toCSSCrossfadeValue() instead of using manual function
gyuyoung.kim@samsung.com [Mon, 30 Sep 2013 05:26:17 +0000 (05:26 +0000)]
Generate toCSSCrossfadeValue() instead of using manual function
https://bugs.webkit.org/show_bug.cgi?id=122057

Reviewed by Antti Koivisto.

Generated toCSSFooValue() supports more plenty functions rather than
to use manual cast function.

No new tests, no behavior changes.

* css/CSSCrossfadeValue.h:
* css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):
* css/CSSValue.cpp:
(WebCore::CSSValue::destroy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGenerate toCSSFooValue() for CSSFilterImageValue and CSSInitialValue
gyuyoung.kim@samsung.com [Mon, 30 Sep 2013 05:22:22 +0000 (05:22 +0000)]
Generate toCSSFooValue() for CSSFilterImageValue and CSSInitialValue
https://bugs.webkit.org/show_bug.cgi?id=122056

Reviewed by Antti Koivisto.

Generate toCSSFooValue() for CSSFilterImageValue and CSSInitialValue, and use it.
This type cast function will help to detect bad-casts.

No new tests, no behavior changes.

* css/CSSFilterImageValue.h:
* css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):
* css/CSSInitialValue.h:
* css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::generatedOrPendingFromValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago Fix crashes caused by my recent attempt at a Windows build fix.
darin@apple.com [Mon, 30 Sep 2013 04:57:41 +0000 (04:57 +0000)]
    Fix crashes caused by my recent attempt at a Windows build fix.

        * bindings/js/WebCoreTypedArrayController.cpp:
        (WebCore::WebCoreTypedArrayController::toJS): Added back the prefix for the call to
        WebCore::toJS, otherwise this function just calls itself infinitely recursively.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@156627 268f45cc-cd09-0410-ab3c-d52691b4dbfc