WebKit-https.git
8 years agoDevirtualize CSSValue.
andreas.kling@nokia.com [Tue, 8 Nov 2011 18:27:07 +0000 (18:27 +0000)]
Devirtualize CSSValue.
<http://webkit.org/b/71666>

Reviewed by Antti Koivisto.

Make the CSSValue destructor non-virtual (along with all the subclasses.)
This removes the vtables, and the pointers thereto in each value instance,
shrinking each object by one CPU word (4 or 8 bytes.)

We use the same trick as CSSRule to implement destruction; providing our
own deref() instead of RefCounted's, and performing a statically typed
delete in a destroy() method called when the ref count reaches 0.

Also made all the empty subclass destructors inline.

* css/CSSAspectRatioValue.cpp:
* css/CSSAspectRatioValue.h:
(WebCore::CSSAspectRatioValue::~CSSAspectRatioValue):
* css/CSSBorderImageSliceValue.cpp:
* css/CSSBorderImageSliceValue.h:
(WebCore::CSSBorderImageSliceValue::~CSSBorderImageSliceValue):
* css/CSSBorderImageValue.cpp:
* css/CSSBorderImageValue.h:
(WebCore::CSSBorderImageValue::~CSSBorderImageValue):
* css/CSSCanvasValue.h:
* css/CSSCrossfadeValue.cpp:
* css/CSSCrossfadeValue.h:
(WebCore::CSSCrossfadeValue::~CSSCrossfadeValue):
* css/CSSCursorImageValue.h:
* css/CSSFlexValue.cpp:
* css/CSSFlexValue.h:
(WebCore::CSSFlexValue::~CSSFlexValue):
* css/CSSFontFaceSrcValue.cpp:
* css/CSSFontFaceSrcValue.h:
(WebCore::CSSFontFaceSrcValue::~CSSFontFaceSrcValue):
* css/CSSFunctionValue.cpp:
* css/CSSFunctionValue.h:
(WebCore::CSSFunctionValue::~CSSFunctionValue):
* css/CSSImageGeneratorValue.h:
* css/CSSImageValue.h:
* css/CSSMutableValue.h:
(WebCore::CSSMutableValue::~CSSMutableValue):
* css/CSSParserValues.h:
* css/CSSPrimitiveValue.h:
* css/CSSUnicodeRangeValue.cpp:
* css/CSSUnicodeRangeValue.h:
(WebCore::CSSUnicodeRangeValue::~CSSUnicodeRangeValue):
* css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
* css/CSSValue.h:
(WebCore::CSSValue::deref):
(WebCore::CSSValue::~CSSValue):
* css/CSSValueList.cpp:
* css/CSSValueList.h:
(WebCore::CSSValueList::~CSSValueList):
* css/WebKitCSSFilterValue.cpp:
* css/WebKitCSSFilterValue.h:
(WebCore::WebKitCSSFilterValue::~WebKitCSSFilterValue):
* css/WebKitCSSTransformValue.cpp:
* css/WebKitCSSTransformValue.h:
(WebCore::WebKitCSSTransformValue::~WebKitCSSTransformValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSpeculative fix for crashes seen in DocumentWriter::deprecatedFrameEncoding
darin@apple.com [Tue, 8 Nov 2011 18:25:31 +0000 (18:25 +0000)]
Speculative fix for crashes seen in DocumentWriter::deprecatedFrameEncoding
https://bugs.webkit.org/show_bug.cgi?id=71828

Reviewed by Nate Chapin.

No new tests; not sure how to reproduce this, but crash traces indicate it
is an otherwise-harmless null dereference.

* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::deprecatedFrameEncoding):
Handle null document the same as a document without a URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove regressions from V8 roll to from the downstream expectations file.
ojan@chromium.org [Tue, 8 Nov 2011 18:24:29 +0000 (18:24 +0000)]
Move regressions from V8 roll to from the downstream expectations file.
Add regressions from http://trac.webkit.org/changeset/99561.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r95720.
commit-queue@webkit.org [Tue, 8 Nov 2011 18:23:30 +0000 (18:23 +0000)]
Unreviewed, rolling out r95720.
http://trac.webkit.org/changeset/95720
https://bugs.webkit.org/show_bug.cgi?id=71831

This has made the menulists on WebKit patch reviews much less
usable (Requested by mrobinson on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-08

* platform/gtk/GtkPopupMenu.cpp:
(WebCore::GtkPopupMenu::menuPositionFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove 6 exit time destructors and 6 static initializers
thakis@chromium.org [Tue, 8 Nov 2011 18:20:18 +0000 (18:20 +0000)]
[chromium] Remove 6 exit time destructors and 6 static initializers
https://bugs.webkit.org/show_bug.cgi?id=71760

Reviewed by Nate Chapin.

Do this by moving global statics into function-local statics, and using
DEFINE_LOCAL_STATIC to leak them. Since this code is accessed on a single
thread, this is a safe change to make.

No behavior change, so no new tests.

* bindings/v8/ScriptGCEvent.cpp:
(WebCore::sEventListeners):
(WebCore::ScriptGCEvent::addEventListener):
(WebCore::ScriptGCEvent::removeEventListener):
(WebCore::ScriptGCEvent::gcEpilogueCallback):
* bindings/v8/ScriptGCEvent.h:
* bindings/v8/V8NPObject.cpp:
(WebCore::staticTemplateMap):
(WebCore::weakTemplateCallback):
(WebCore::npObjectGetProperty):
(WebCore::staticNPObjectMap):
(WebCore::weakNPObjectCallback):
(WebCore::createV8ObjectForNPObject):
(WebCore::forgetV8ObjectForNPObject):
* bindings/v8/V8Proxy.cpp:
(WebCore::staticExtensionsList):
(WebCore::V8Proxy::registeredExtensionWithV8):
(WebCore::V8Proxy::registerExtension):
(WebCore::V8Proxy::extensions):
* bindings/v8/V8Proxy.h:
* bindings/v8/npruntime.cpp:
* plugins/chromium/PluginDataChromium.cpp:
(WebCore::pluginCache):
(WebCore::PluginData::initPlugins):
(WebCore::PluginData::refresh):
(WebCore::getPluginMimeTypeFromExtension):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] broaden test failure for zoom-animator-scale-test2.html to include cg...
tony@chromium.org [Tue, 8 Nov 2011 18:17:47 +0000 (18:17 +0000)]
[chromium] broaden test failure for zoom-animator-scale-test2.html to include cg-gpu.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNew tests results after r99539.
ojan@chromium.org [Tue, 8 Nov 2011 18:10:31 +0000 (18:10 +0000)]
New tests results after r99539.

zoom-replaced-intrinsic-ratio-001-expected.png is just minor antialiasing differences.
The rest are all changing to a size that matched the pngs in platform/mac.

* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-background-images-expected.png:
* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-background-images-expected.txt: Removed.
* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png:
* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.txt: Removed.
* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
* platform/chromium-cg-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Removed.
* platform/chromium-cg-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
* platform/chromium-linux-x86/svg/zoom/page/zoom-background-images-expected.png: Removed.
* platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.txt: Removed.
* platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Removed.
* platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
* platform/chromium-win-vista/svg/zoom/page/zoom-background-images-expected.png: Removed.
* platform/chromium-win-vista/svg/zoom/page/zoom-background-images-expected.txt: Removed.
* platform/chromium-win-xp/svg/zoom/page/zoom-background-images-expected.png: Removed.
* platform/chromium-win-xp/svg/zoom/page/zoom-background-images-expected.txt: Removed.
* platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-background-images-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt:
* platform/chromium/svg/zoom/page/zoom-background-images-expected.txt: Removed.
* platform/chromium/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAutofocus inputs don't always honor selector input:focus.
commit-queue@webkit.org [Tue, 8 Nov 2011 18:04:11 +0000 (18:04 +0000)]
Autofocus inputs don't always honor selector input:focus.
https://bugs.webkit.org/show_bug.cgi?id=24093

Already fixed and works on TOT. Adding layout test case for the same.

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-11-08
Reviewed by Kent Tamura.

* fast/forms/autofocus-input-css-style-change-expected.txt: Added.
* fast/forms/autofocus-input-css-style-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Start using the onSuccessWithContinuation() callback
hans@chromium.org [Tue, 8 Nov 2011 17:51:06 +0000 (17:51 +0000)]
IndexedDB: Start using the onSuccessWithContinuation() callback
https://bugs.webkit.org/show_bug.cgi?id=71565

Reviewed by Tony Chang.

Source/WebCore:

This is a follow-up to r99169 where we start using this new
callback for cursors.

* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::continueFunctionInternal):
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::setCursor):

LayoutTests:

The cursor-inconsistency.html test now passes completely.

* storage/indexeddb/cursor-inconsistency-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSkip some ECMAScript tests that fail on Linux in some time zones.
commit-queue@webkit.org [Tue, 8 Nov 2011 17:49:37 +0000 (17:49 +0000)]
Skip some ECMAScript tests that fail on Linux in some time zones.
https://bugs.webkit.org/show_bug.cgi?id=71371

Patch by Andy Wingo <wingo@igalia.com> on 2011-11-08
Reviewed by Martin Robinson.

* Scripts/run-javascriptcore-tests: Skip some more tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDocument::loader should use documentLoader(), not activeDocumentLoader()
jschuh@chromium.org [Tue, 8 Nov 2011 17:42:29 +0000 (17:42 +0000)]
Document::loader should use documentLoader(), not activeDocumentLoader()
https://bugs.webkit.org/show_bug.cgi?id=65895

Reviewed by Brady Eidson.

Source/WebCore:

Test: fast/loader/stateobjects/replacestate-in-onunload.html

* dom/Document.cpp:
(WebCore::Document::loader):

LayoutTests:

* fast/loader/stateobjects/replacestate-in-onunload-expected.txt: Added.
* fast/loader/stateobjects/replacestate-in-onunload.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK][GTK] Application cache directory is incorrectly set
commit-queue@webkit.org [Tue, 8 Nov 2011 17:36:04 +0000 (17:36 +0000)]
[WK][GTK] Application cache directory is incorrectly set
https://bugs.webkit.org/show_bug.cgi?id=71769

Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-11-08
Reviewed by Martin Robinson.

Set the application cache directory to be placed in current user's
cache directory and update documentation for
webkit_application_cache_get_database_directory_path after these
changes and changes in r80715;

* webkit/webkitapplicationcache.cpp:
* webkit/webkitglobals.cpp:
(webkitInit): Switch one string formation to use GOwnPtr<gchar>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSSImageGeneratorValue: Devirtualize image(), isFixedSize() and fixedSize().
andreas.kling@nokia.com [Tue, 8 Nov 2011 17:33:07 +0000 (17:33 +0000)]
CSSImageGeneratorValue: Devirtualize image(), isFixedSize() and fixedSize().
<http://webkit.org/b/71824>

Reviewed by Darin Adler.

Redirect the calls to the appropriate subclass in CSSImageGeneratorValue.cpp.

* css/CSSCanvasValue.h:
(WebCore::CSSCanvasValue::isFixedSize):
* css/CSSCrossfadeValue.h:
(WebCore::CSSCrossfadeValue::isFixedSize):
* css/CSSGradientValue.h:
(WebCore::CSSGradientValue::isFixedSize):
(WebCore::CSSGradientValue::fixedSize):
* css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::isFixedSize):
(WebCore::CSSImageGeneratorValue::fixedSize):
* css/CSSImageGeneratorValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling...
commit-queue@webkit.org [Tue, 8 Nov 2011 17:09:17 +0000 (17:09 +0000)]
[GTK] fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=71774

Patch by Philippe Normand <pnormand@igalia.com> on 2011-11-08
Reviewed by Martin Robinson.

* fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html:
Trigger the test when the iframe loaded to avoid potential
flakyness.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Extension API][Chromium] injected extension API needs to return an...
caseq@chromium.org [Tue, 8 Nov 2011 17:06:33 +0000 (17:06 +0000)]
Web Inspector: [Extension API][Chromium] injected extension API needs to return an object
https://bugs.webkit.org/show_bug.cgi?id=71822

Reviewed by Pavel Feldman.

* inspector/front-end/ExtensionAPI.js:
(buildExtensionAPIInjectedScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSSImageValue: Devirtualize cachedImage(CachedResourceLoader*).
andreas.kling@nokia.com [Tue, 8 Nov 2011 16:46:15 +0000 (16:46 +0000)]
CSSImageValue: Devirtualize cachedImage(CachedResourceLoader*).
<http://webkit.org/b/71814>

Reviewed by Antti Koivisto.

Defer to CSSCursorImageValue (the only CSSImageValue subclass)
when appropriate in CSSImageValue::cachedImage(CachedResourceLoader*).

* css/CSSCursorImageValue.h:
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedImage):
* css/CSSImageValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: add "Evaluate in console" as a shortcut and context menu items to...
caseq@chromium.org [Tue, 8 Nov 2011 16:38:04 +0000 (16:38 +0000)]
Web Inspector: add "Evaluate in console" as a shortcut and context menu items to scripts panel
https://bugs.webkit.org/show_bug.cgi?id=71817

Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.evaluate):
(WebInspector.ConsoleView.prototype._enterKeyPressed):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._evaluateSelectionInConsole):
* inspector/front-end/ShortcutsScreen.js:
(WebInspector.ShortcutsSection.prototype.addRelatedKeys):
(WebInspector.ShortcutsSection.prototype.addAlternateKeys):
* inspector/front-end/externs.js:
(WebInspector.evaluateInConsole):
* inspector/front-end/inspector.js:
(WebInspector.evaluateInConsole):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 8 Nov 2011 16:26:26 +0000 (16:26 +0000)]
2011-11-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Rebaseline qt results after the recent SVGImage changes.

        * platform/qt/Skipped:
        * platform/qt/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
        * platform/qt/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
        * platform/qt/svg/zoom/page/zoom-background-images-expected.png: Added.
        * platform/qt/svg/zoom/page/zoom-background-images-expected.txt: Added.
        * platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
        * platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
        * platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Use qmake's builtin rules for copying framework headers on Mac OS
vestbo@webkit.org [Tue, 8 Nov 2011 16:22:16 +0000 (16:22 +0000)]
[Qt] Use qmake's builtin rules for copying framework headers on Mac OS

Now that we generate the forwarding headers eiher as part of QtWebKit.pro
(for Qt 4.8), or as part of the root project file (for Qt 5), we can assume
that the files are there and use $$files() to list the files to be copied.

Reviewed by Csaba Osztrogonác.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Workaround some problems in QML API tests
caio.oliveira@openbossa.org [Tue, 8 Nov 2011 16:21:26 +0000 (16:21 +0000)]
[Qt] Workaround some problems in QML API tests
https://bugs.webkit.org/show_bug.cgi?id=71818

Reviewed by Tor Arne Vestbø.

This commit workaround the issue of QML's QtTest crashing when we run tests after
"windowShown". We delay to the next run of the mainloop. This workaround is not
pretty but shouldn't affect the semantics of the tests. And we benefit more from
having working tests right now.

This patch also improves Download to: wait for the load before emitting click, and
properly identifying the "succeeded" signal of the downloadItem object.

* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_download.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_navigationPolicyForUrl.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed trivial fix after build system refactoring.
ossy@webkit.org [Tue, 8 Nov 2011 15:40:33 +0000 (15:40 +0000)]
[Qt] Unreviewed trivial fix after build system refactoring.

* Scripts/run-qtwebkit-tests: Fix path of QtWebProcess for QML tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClean up QtViewportInteractionEngine
kenneth@webkit.org [Tue, 8 Nov 2011 15:34:07 +0000 (15:34 +0000)]
Clean up QtViewportInteractionEngine

Reviewed by Simon Hausmann.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::setItemRectVisible):

    Rename the method to make it more obvious what it does. Avoid implicit
    conversion to/from QVariant.

(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::itemSizeChanged):

    Only call this method on item size changes, and not for every interaction
    with the viewport item. Before this change it was even being called during
    animations.

* UIProcess/qt/QtViewportInteractionEngine.h:
(WebKit::QtViewportInteractionEngine::scaleAnimationValueChanged):

    Rename to make it clean that this is called from the animator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSSValue: Devirtualize cssText().
andreas.kling@nokia.com [Tue, 8 Nov 2011 15:29:58 +0000 (15:29 +0000)]
CSSValue: Devirtualize cssText().
<http://webkit.org/b/71813>

Reviewed by Antti Koivisto.

Rename all subclass implementations to customCssText() and add
a CSSValue::cssText() that defers to the appropriate subclass
based on the type info.

The rename is both for clarity, and to ensure that calling
cssText() will always end up in the correct method.

* css/CSSAspectRatioValue.cpp:
(WebCore::CSSAspectRatioValue::customCssText):
* css/CSSAspectRatioValue.h:
* css/CSSBorderImageSliceValue.cpp:
(WebCore::CSSBorderImageSliceValue::customCssText):
* css/CSSBorderImageSliceValue.h:
* css/CSSBorderImageValue.cpp:
(WebCore::CSSBorderImageValue::customCssText):
* css/CSSBorderImageValue.h:
* css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::customCssText):
* css/CSSCanvasValue.h:
* css/CSSCrossfadeValue.cpp:
(WebCore::CSSCrossfadeValue::customCssText):
* css/CSSCrossfadeValue.h:
* css/CSSFlexValue.cpp:
(WebCore::CSSFlexValue::customCssText):
* css/CSSFlexValue.h:
* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::customCssText):
* css/CSSFontFaceSrcValue.h:
* css/CSSFunctionValue.cpp:
(WebCore::CSSFunctionValue::customCssText):
* css/CSSFunctionValue.h:
* css/CSSGradientValue.cpp:
(WebCore::CSSLinearGradientValue::customCssText):
(WebCore::CSSRadialGradientValue::customCssText):
* css/CSSGradientValue.h:
* css/CSSInheritedValue.cpp:
(WebCore::CSSInheritedValue::customCssText):
* css/CSSInheritedValue.h:
* css/CSSInitialValue.cpp:
(WebCore::CSSInitialValue::customCssText):
* css/CSSInitialValue.h:
* css/CSSLineBoxContainValue.cpp:
(WebCore::CSSLineBoxContainValue::customCssText):
* css/CSSLineBoxContainValue.h:
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::customCssText):
* css/CSSPrimitiveValue.h:
* css/CSSReflectValue.cpp:
(WebCore::CSSReflectValue::customCssText):
* css/CSSReflectValue.h:
* css/CSSTimingFunctionValue.cpp:
(WebCore::CSSLinearTimingFunctionValue::customCssText):
(WebCore::CSSCubicBezierTimingFunctionValue::customCssText):
(WebCore::CSSStepsTimingFunctionValue::customCssText):
* css/CSSTimingFunctionValue.h:
(WebCore::CSSLinearTimingFunctionValue::CSSLinearTimingFunctionValue):
* css/CSSUnicodeRangeValue.cpp:
(WebCore::CSSUnicodeRangeValue::customCssText):
* css/CSSUnicodeRangeValue.h:
* css/CSSValue.cpp:
(WebCore::CSSValue::cssText):
* css/CSSValue.h:
* css/CSSValueList.cpp:
(WebCore::CSSValueList::customCssText):
* css/CSSValueList.h:
* css/FontFamilyValue.cpp:
(WebCore::FontFamilyValue::customCssText):
* css/FontFamilyValue.h:
* css/FontFeatureValue.cpp:
(WebCore::FontFeatureValue::customCssText):
* css/FontFeatureValue.h:
* css/FontValue.cpp:
(WebCore::FontValue::customCssText):
* css/FontValue.h:
* css/ShadowValue.cpp:
(WebCore::ShadowValue::customCssText):
* css/ShadowValue.h:
* css/WebKitCSSFilterValue.cpp:
(WebCore::WebKitCSSFilterValue::customCssText):
* css/WebKitCSSFilterValue.h:
* css/WebKitCSSTransformValue.cpp:
(WebCore::WebKitCSSTransformValue::customCssText):
* css/WebKitCSSTransformValue.h:
* svg/SVGColor.cpp:
(WebCore::SVGColor::customCssText):
* svg/SVGColor.h:
* svg/SVGPaint.cpp:
(WebCore::SVGPaint::customCssText):
* svg/SVGPaint.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 8 Nov 2011 15:16:16 +0000 (15:16 +0000)]
2011-11-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        [Qt] 4 new tests fail introduced in r98852
        https://bugs.webkit.org/show_bug.cgi?id=71253

        Reviewed by Rob Buis.

        Address some problems seen on Qt/Chromium:
        - Remove the scaled png which is the source of the problem in zoom-background-images.html, we really only want to test zooming in the SVGImage there.
        - Don't zoom out more than three times, otherwise its ignored on Mac/DRT, where the minimum zoom factor is clamped to 0.5f.
          Qt doesn't have this limit, and currently zooms more than Mac does. There's no need to zoom out that often, three times is enough.

        * platform/mac/svg/zoom/page/zoom-background-images-expected.png: Updated.
        * platform/mac/svg/zoom/page/zoom-background-images-expected.txt: Update.
        * svg/zoom/page/zoom-background-image-tiled.html: Don't set shouldZoomOut to false, it's the default.
        * svg/zoom/page/zoom-background-images.html: Don't zoom out more than three times.
        * svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm: Ditto.
        * svg/zoom/page/zoom-svg-as-background-with-relative-size.html: Ditto.
        * svg/zoom/page/zoom-svg-as-image.html: There is no shouldZoomIn, just remove it, zooming in is the default.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix width of m_type in CachedResource
gavinp@chromium.org [Tue, 8 Nov 2011 14:42:25 +0000 (14:42 +0000)]
Fix width of m_type in CachedResource
https://bugs.webkit.org/show_bug.cgi?id=71727

Reviewed by Nate Chapin.

Source/WebCore:

Test: fast/dom/HTMLLinkElement/cachedresource-types.html

* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
* loader/cache/CachedResource.h:

LayoutTests:

* fast/dom/HTMLLinkElement/cachedresource-types-expected.txt: Added.
* fast/dom/HTMLLinkElement/cachedresource-types.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Don't set OBJECTS_DIR and DEFINES in default_pre
vestbo@webkit.org [Tue, 8 Nov 2011 14:40:46 +0000 (14:40 +0000)]
[Qt] Don't set OBJECTS_DIR and DEFINES in default_pre

If a pro file needs to access the OBJECTS_DIR it should use the
form ${QMAKE_VAR_OBJECTS_DIR} to ensure the value is evaluated
after defaults_post has been processed.

Setting DEFINES in defaults_pre is also bad, as any DEFINES=foo on
the command line will override whatever we set in defaults_pre.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: add JavaScript keywords to the autocomplete.
pfeldman@chromium.org [Tue, 8 Nov 2011 14:36:47 +0000 (14:36 +0000)]
Web Inspector: add JavaScript keywords to the autocomplete.
https://bugs.webkit.org/show_bug.cgi?id=71782

Reviewed by Yury Semikhatsky.

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._completions.receivedPropertyNames):
(WebInspector.ConsoleView.prototype._completions):
(WebInspector.ConsoleView.prototype._reportCompletions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 8 Nov 2011 14:19:40 +0000 (14:19 +0000)]
2011-11-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        [Chromium] SVG test failures after r99539
        https://bugs.webkit.org/show_bug.cgi?id=71793

        Reviewed by Zoltan Herczeg.

        It turns out that some of these tests are flakey. Replace <animate> elements with <set>.
        That still tests repaint, but there's no need to run a 100ms animation, and then sample it after 400ms.
        That cries for problems if the machine is slow or loaded.

        I left the 400ms sample snapshot for now, we can still relax it later.

        * fast/backgrounds/resources/animated-rect-relative-size.svg:
        * svg/as-background-image/resources/animated-rect-relative-size.svg:
        * svg/as-image/resources/animated-rect-fixed-size.svg:
        * svg/as-image/resources/animated-rect-relative-size.svg:
        * svg/as-image/resources/animated-rect-same-image.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 8 Nov 2011 14:14:35 +0000 (14:14 +0000)]
2011-11-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Introduce SVGLengthContext, to allow to resolve relative units to arbitary viewports
        https://bugs.webkit.org/show_bug.cgi?id=71780

        Reviewed by Zoltan Herczeg.

        Introduce SVGLengthContext to cleanup SVGLength, by moving all conversion of relative units that depend on style or viewport
        out of SVGLength, into SVGLengthContext. Pass SVGLengthContext& to SVGLength::value/setValue/... functions instead of a pure
        "const SVGElement* context", which was previously used to determine the viewport when resolving percentage units.
        SVGLengthContext carries an additional FloatRect of the custom viewport, to which percentages are resolved, if specified.

        This allows us to kill several duplicates of the same code, which handles objectBoundingBox mode for gradients/patterns/masks/etc..
        A follow-up patch will convert filters to use the new SVGLengthContext::resolveRectangle code as well.

        This is a preparation for bug 10430, to fix feImage + objectBoundingBox support when rendering referenced elements, instead of files.

        Doesn't affect any tests yet.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * Target.pri:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/svg/RenderSVGResourceGradient.cpp:
        (WebCore::RenderSVGResourceGradient::applyResource):
        * rendering/svg/RenderSVGResourceGradient.h:
        * rendering/svg/RenderSVGResourceLinearGradient.h:
        (WebCore::RenderSVGResourceLinearGradient::gradientUnits):
        * rendering/svg/RenderSVGResourcePattern.cpp:
        (WebCore::RenderSVGResourcePattern::applyResource):
        (WebCore::calculatePatternBoundaries):
        (WebCore::RenderSVGResourcePattern::buildTileImageTransform):
        (WebCore::RenderSVGResourcePattern::createTileImage):
        * rendering/svg/RenderSVGResourceRadialGradient.h:
        (WebCore::RenderSVGResourceRadialGradient::gradientUnits):
        * rendering/svg/SVGRenderTreeAsText.cpp:
        (WebCore::writeCommonGradientProperties):
        (WebCore::writeSVGResourceContainer):
        * svg/GradientAttributes.h:
        (WebCore::GradientAttributes::GradientAttributes):
        (WebCore::GradientAttributes::gradientUnits):
        (WebCore::GradientAttributes::setGradientUnits):
        (WebCore::GradientAttributes::hasGradientUnits):
        * svg/PatternAttributes.h:
        (WebCore::PatternAttributes::PatternAttributes):
        (WebCore::PatternAttributes::patternUnits):
        (WebCore::PatternAttributes::patternContentUnits):
        (WebCore::PatternAttributes::setPatternUnits):
        (WebCore::PatternAttributes::setPatternContentUnits):
        (WebCore::PatternAttributes::hasPatternUnits):
        (WebCore::PatternAttributes::hasPatternContentUnits):
        * svg/SVGAllInOne.cpp:
        * svg/SVGElement.h:
        (WebCore::SVGElement::operator SVGLengthContext):
        * svg/SVGFilterElement.cpp:
        (WebCore::SVGFilterElement::filterBoundingBox):
        * svg/SVGLength.cpp:
        (WebCore::SVGLength::SVGLength):
        (WebCore::SVGLength::unitMode):
        (WebCore::SVGLength::value):
        (WebCore::SVGLength::setValue):
        (WebCore::SVGLength::convertToSpecifiedUnits):
        * svg/SVGLength.h:
        (WebCore::SVGLength::blend):
        * svg/SVGLengthContext.cpp: Added.
        (WebCore::SVGLengthContext::SVGLengthContext):
        (WebCore::SVGLengthContext::resolveRectangle):
        (WebCore::SVGLengthContext::resolvePoint):
        (WebCore::SVGLengthContext::resolveLength):
        (WebCore::SVGLengthContext::convertValueToUserUnits):
        (WebCore::SVGLengthContext::convertValueFromUserUnits):
        (WebCore::SVGLengthContext::convertValueFromUserUnitsToPercentage):
        (WebCore::SVGLengthContext::convertValueFromPercentageToUserUnits):
        (WebCore::SVGLengthContext::convertValueFromUserUnitsToEMS):
        (WebCore::SVGLengthContext::convertValueFromEMSToUserUnits):
        (WebCore::SVGLengthContext::convertValueFromUserUnitsToEXS):
        (WebCore::SVGLengthContext::convertValueFromEXSToUserUnits):
        (WebCore::SVGLengthContext::determineViewport):
        * svg/SVGLengthContext.h: Added.
        (WebCore::SVGLengthContext::resolveRectangle):
        * svg/SVGLinearGradientElement.cpp:
        (WebCore::SVGLinearGradientElement::collectGradientAttributes):
        (WebCore::SVGLinearGradientElement::calculateStartEndPoints):
        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::maskBoundingBox):
        * svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::collectPatternAttributes):
        * svg/SVGRadialGradientElement.cpp:
        (WebCore::SVGRadialGradientElement::collectGradientAttributes):
        (WebCore::SVGRadialGradientElement::calculateFocalCenterPointsAndRadius):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSSValue: Devirtualize addSubresourceStyleURLs().
andreas.kling@nokia.com [Tue, 8 Nov 2011 14:01:27 +0000 (14:01 +0000)]
CSSValue: Devirtualize addSubresourceStyleURLs().
<http://webkit.org/b/71805>

Reviewed by Antti Koivisto.

Make addSubresourceStyleURLs() non-virtual and call the appropriate
subclass implementation based on the subclass type info.

* css/CSSBorderImageValue.h:
* css/CSSFontFaceSrcValue.h:
* css/CSSPrimitiveValue.h:
* css/CSSReflectValue.h:
* css/CSSValue.cpp:
(WebCore::CSSValue::addSubresourceStyleURLs):
* css/CSSValue.h:
(WebCore::CSSValue::addSubresourceStyleURLs):
* css/CSSValueList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnable DFG JIT by default on X86 Linux and Mac platforms
yuqiang.xian@intel.com [Tue, 8 Nov 2011 13:46:50 +0000 (13:46 +0000)]
Enable DFG JIT by default on X86 Linux and Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=71686

Reviewed by Filip Pizlo.

.:

Remove the DFG cmake option for Efl port as we'll determine whether to
switch on DFG or not based on build target platforms.

* Source/cmake/OptionsEfl.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

We can get 9% on SunSpider, 89% on Kraken and 37% on V8, on Linux X86.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: do not show object popover when selection is active
caseq@chromium.org [Tue, 8 Nov 2011 13:38:13 +0000 (13:38 +0000)]
Web Inspector: do not show object popover when selection is active
https://bugs.webkit.org/show_bug.cgi?id=71804

Reviewed by Yury Semikhatsky.

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._shouldShowPopover):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Do not hide SuggestBox if typed-in string in the middle of input equal...
apavlov@chromium.org [Tue, 8 Nov 2011 13:34:38 +0000 (13:34 +0000)]
Web Inspector: Do not hide SuggestBox if typed-in string in the middle of input equals one of suggestions
https://bugs.webkit.org/show_bug.cgi?id=71797

Reviewed by Yury Semikhatsky.

* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.prototype.complete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSSGradientValue: Devirtualize createGradient().
andreas.kling@nokia.com [Tue, 8 Nov 2011 13:23:24 +0000 (13:23 +0000)]
CSSGradientValue: Devirtualize createGradient().
<http://webkit.org/b/71800>

Reviewed by Antti Koivisto.

Make createGradient() non-virtual and call the appropriate subclass
implementation in image() based on is{Linear,Radial}Gradient().

* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::image):
* css/CSSGradientValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSSCanvasValue: Remove inheritance from CanvasObserver.
andreas.kling@nokia.com [Tue, 8 Nov 2011 13:22:03 +0000 (13:22 +0000)]
CSSCanvasValue: Remove inheritance from CanvasObserver.
<http://webkit.org/b/71796>

Reviewed by Antti Koivisto.

To completely devirtualize all the CSSValues, we need to remove
CSSCanvasValue's inheritance from CanvasObserver, as that is forcing
a vptr into the class.

Use the same approach as CSSImportRule and make a simple proxying
CanvasObserver subclass and put that as a member variable of the value.

* css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::~CSSCanvasValue):
(WebCore::CSSCanvasValue::element):
* css/CSSCanvasValue.h:
(WebCore::CSSCanvasValue::CSSCanvasValue):
(WebCore::CSSCanvasValue::CanvasObserverProxy::CanvasObserverProxy):
(WebCore::CSSCanvasValue::CanvasObserverProxy::~CanvasObserverProxy):
(WebCore::CSSCanvasValue::CanvasObserverProxy::canvasChanged):
(WebCore::CSSCanvasValue::CanvasObserverProxy::canvasResized):
(WebCore::CSSCanvasValue::CanvasObserverProxy::canvasDestroyed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: display notification in the front-end when inspected worker terminates
yurys@chromium.org [Tue, 8 Nov 2011 13:06:11 +0000 (13:06 +0000)]
Web Inspector: display notification in the front-end when inspected worker terminates
https://bugs.webkit.org/show_bug.cgi?id=71770

Source/WebCore:

When inspected worker terminates we will show a notification similar to the help
screen. The notification disappears when the worker restarts or the user closes it
manually.

Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* inspector/front-end/ScriptsPanel.js:
* inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager.loaded):
(WebInspector.WorkerManager.showWorkerTerminatedScreen):
(WebInspector.WorkerTerminatedScreen):
* inspector/front-end/inspector.js:
(WebInspector.disconnectFromBackend):
(WebInspector.frontendReused):

Source/WebKit/chromium:

Exposed an API for the browser to notify inspector front-end when inspeced instance
terminates. It is used now for tracking shared workers termination.

Reviewed by Pavel Feldman.

* public/WebDevToolsAgent.h:
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgent::createFrontendDisconnectedEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, add three more CG-only failures.
yutak@chromium.org [Tue, 8 Nov 2011 13:03:20 +0000 (13:03 +0000)]
[Chromium] Unreviewed, add three more CG-only failures.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Mark fast/backgrounds/svg-as-mask.html as IMAGE on MAC.
yutak@chromium.org [Tue, 8 Nov 2011 12:48:49 +0000 (12:48 +0000)]
[Chromium] Mark fast/backgrounds/svg-as-mask.html as IMAGE on MAC.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Improve the animation time constant
kenneth@webkit.org [Tue, 8 Nov 2011 12:40:54 +0000 (12:40 +0000)]
[Qt] Improve the animation time constant
https://bugs.webkit.org/show_bug.cgi?id=71790

Reviewed by Simon Hausmann.

Use 250 milliseconds instead of 400, which feels a lot more natural
and makes the mini browser feel more responsive.

* UIProcess/qt/QtViewportInteractionEngine.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed fix of expectation conflict in test_expectations.txt.
yutak@chromium.org [Tue, 8 Nov 2011 12:37:33 +0000 (12:37 +0000)]
[Chromium] Unreviewed fix of expectation conflict in test_expectations.txt.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 8 Nov 2011 12:29:38 +0000 (12:29 +0000)]
2011-11-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Fold ImageBySizeCache again into CSSImageGeneratorValue
        https://bugs.webkit.org/show_bug.cgi?id=71785

        Reviewed by Zoltan Herczeg.

        Remove ImageBySizeCache, and fold it into CSSImageGeneratorValue, as it used to be.
        CachedImage has switched to SVGImageCache and no longer needs it.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * Target.pri:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSImageGeneratorValue.cpp:
        (WebCore::CSSImageGeneratorValue::addClient):
        (WebCore::CSSImageGeneratorValue::removeClient):
        (WebCore::CSSImageGeneratorValue::getImage):
        (WebCore::CSSImageGeneratorValue::putImage):
        * css/CSSImageGeneratorValue.h:
        (WebCore::SizeAndCount::SizeAndCount):
        (WebCore::CSSImageGeneratorValue::clients):
        * rendering/ImageBySizeCache.cpp: Removed.
        * rendering/ImageBySizeCache.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Avoid automatic Console suggestions with empty expression
apavlov@chromium.org [Tue, 8 Nov 2011 12:22:13 +0000 (12:22 +0000)]
Web Inspector: Avoid automatic Console suggestions with empty expression
https://bugs.webkit.org/show_bug.cgi?id=71783

Reviewed by Yury Semikhatsky.

* inspector/front-end/ConsoleView.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Prevent duplicated sources in SOURCES/OBJECTIVE_SOURCES
vestbo@webkit.org [Tue, 8 Nov 2011 12:14:55 +0000 (12:14 +0000)]
[Qt] Prevent duplicated sources in SOURCES/OBJECTIVE_SOURCES

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Web Inspector: add sanity test for automatic reattach to a page which...
yurys@chromium.org [Tue, 8 Nov 2011 12:00:26 +0000 (12:00 +0000)]
[Chromium] Web Inspector: add sanity test for automatic reattach to a page which is reloaded after crash
https://bugs.webkit.org/show_bug.cgi?id=71786

Added a test function that checks if console evaluation works after crashed tab reloading.

Reviewed by Pavel Feldman.

* src/js/Tests.js:
(.TestSuite.prototype.testReattachAfterCrash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, trying to update test_expectations.txt for the tests which
yutak@chromium.org [Tue, 8 Nov 2011 11:58:16 +0000 (11:58 +0000)]
[Chromium] Unreviewed, trying to update test_expectations.txt for the tests which
started to fail after r99539.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 8 Nov 2011 11:54:55 +0000 (11:54 +0000)]
2011-11-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Fix build, by removing an unused variable.

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::isOriginClean):
        (WebCore::CanvasRenderingContext2D::createPattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 8 Nov 2011 11:46:40 +0000 (11:46 +0000)]
2011-11-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Switch SVGImage cache to store ImageBuffers instead of whole SVGImages, including a DOM/Render tree
        https://bugs.webkit.org/show_bug.cgi?id=71368

        Reviewed by Zoltan Herczeg.

        When determining whether the canvas would be tainted, we need access to the SVGImage, not its cached BitmapImage.
        Otherwhise wrong assumptions are mode, leading to regressions.

        Fixes http/tests/security/canvas-remote-read-svg-image.html and related tests on the bots.

        * html/canvas/CanvasRenderingContext.cpp:
        (WebCore::CanvasRenderingContext::wouldTaintOrigin): Forgot to switch them back to use cachedImage->image().
        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::isOriginClean): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Ensure forwarding headers are generated before generating install rules
vestbo@webkit.org [Tue, 8 Nov 2011 11:30:47 +0000 (11:30 +0000)]
[Qt] Ensure forwarding headers are generated before generating install rules

The install rule for headers depends on qmake being able to walk the list of
headers in the $build_root/include/QtWebKit directory, but this directory is
empty until we've generated the forwarding headers. So we need to make sure
the forwarding headers are generated _before_ we run qmake on the api project
file. This applies to Qt 4.8 only, as Qt 5 will run synqt as part of the
root project file (due to the sync.profile file).

https://bugs.webkit.org/show_bug.cgi?id=71697

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Console should be scrolled to bottom when shown for the first time.
vsevik@chromium.org [Tue, 8 Nov 2011 11:22:27 +0000 (11:22 +0000)]
Web Inspector: Console should be scrolled to bottom when shown for the first time.
https://bugs.webkit.org/show_bug.cgi?id=71781

Reviewed by Pavel Feldman.

* inspector/front-end/ConsoleView.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Merge QtDesktopWebPageProxy and QtTouchWebPageProxy into QtWebPageProxy. https...
hausmann@webkit.org [Tue, 8 Nov 2011 09:34:04 +0000 (09:34 +0000)]
[Qt] Merge QtDesktopWebPageProxy and QtTouchWebPageProxy into QtWebPageProxy. https://bugs.webkit.org/show_bug.cgi?id=71355

Patch by Alexis Menard <alexis.menard@openbossa.org> on 2011-11-08
Reviewed by Simon Hausmann.

As we try to unify our public API offer we need to merge our double
WebPageProxy implementations first into a common class. That will help
to merge our TouchWebView and DesktopWebView views into one class later.
This commit just merge stuff around and doesn't contain any functional changes.

* Target.pri:
* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::init):
* UIProcess/API/qt/qtouchwebpage.cpp:
(QTouchWebPagePrivate::paintToCurrentGLContext):
* UIProcess/API/qt/qtouchwebpage.h:
* UIProcess/API/qt/qtouchwebpage_p.h:
* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::init):
(QTouchWebViewPrivate::_q_viewportUpdated):
(QTouchWebViewPrivate::_q_viewportTrajectoryVectorChanged):
* UIProcess/API/qt/qtouchwebview_p.h:
* UIProcess/qt/QtDesktopWebPageProxy.cpp: Removed.
* UIProcess/qt/QtDesktopWebPageProxy.h: Removed.
* UIProcess/qt/QtTouchWebPageProxy.cpp: Removed.
* UIProcess/qt/QtTouchWebPageProxy.h: Removed.
* UIProcess/qt/QtWebPageProxy.cpp:
(dragOperationToDropAction):
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::handleEvent):
(QtWebPageProxy::handleMouseMoveEvent):
(QtWebPageProxy::handleMousePressEvent):
(QtWebPageProxy::handleMouseReleaseEvent):
(QtWebPageProxy::handleMouseDoubleClickEvent):
(QtWebPageProxy::handleWheelEvent):
(QtWebPageProxy::handleHoverLeaveEvent):
(QtWebPageProxy::handleHoverMoveEvent):
(QtWebPageProxy::handleDragEnterEvent):
(QtWebPageProxy::handleDragLeaveEvent):
(QtWebPageProxy::handleDragMoveEvent):
(QtWebPageProxy::handleDropEvent):
(QtWebPageProxy::timerEvent):
(QtWebPageProxy::processDidCrash):
(QtWebPageProxy::didReceiveDownloadResponse):
(QtWebPageProxy::paintContent):
(QtWebPageProxy::createDrawingAreaProxy):
(QtWebPageProxy::renderToCurrentGLContext):
(QtWebPageProxy::doneWithTouchEvent):
(QtWebPageProxy::setVisibleContentRectAndScale):
(QtWebPageProxy::setVisibleContentRectTrajectoryVector):
(QtWebPageProxy::touchEvent):
(QtWebPageProxy::findZoomableAreaForPoint):
* UIProcess/qt/QtWebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 8 Nov 2011 09:32:52 +0000 (09:32 +0000)]
2011-11-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Switch SVGImage cache to store ImageBuffers instead of whole SVGImages, including a DOM/Render tree
        https://bugs.webkit.org/show_bug.cgi?id=71368

        Reviewed by Antti Koivisto.

        Add some layout tests covering repainting of embedded SVG documents triggered by SMIL animations.

        * platform/chromium/test_expectations.txt: Fix test expectations, as described in bug 71226.
        * platform/mac/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
        * platform/mac/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
        * platform/mac/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
        * platform/mac/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
        * svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size.html: Added.
        * svg/as-image/animated-svg-as-image-same-image.html: Added.
        * svg/as-image/resources/animated-rect-same-image.svg: Copied from LayoutTests/svg/as-image/resources/animated-rect-fixed-size.svg.
        * svg/zoom/page/zoom-coords-viewattr-01-b.svg: Add comment, why scrollbars shouldn't appear anymore here.

2011-11-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Switch SVGImage cache to store ImageBuffers instead of whole SVGImages, including a DOM/Render tree
        https://bugs.webkit.org/show_bug.cgi?id=71368

        Reviewed by Antti Koivisto.

        Fix regressions/races introduced by r98852. SVGImage repainting didn't work under certain circumstances.
        The problem was hard to reproduce on Mac ports, but easily visible on Chromium, when opening two files
        that shared the same animated SVG image. The problem of sharing a single ImageObserver across multiple
        instances of the same SVGImage, leads to nasty problems, that are timing dependant. changedInRect() calls
        that should only by received in one document, are received in the other as well, due the shared nature
        of CachedImage. To avoid these problems alltogether, a new approach is needed, that was initially suggested
        by Antti.

        Avoid creating multiple SVGImages and caching them for different sizes/zoom levels. Introduce SVGImageCache
        which holds rendered versions of the SVGImage at certain sizes/zoom levels. It holds (ImageBuffer, Image) pairs
        for each renderer, associated with a size and zoom level.

        This is a major change to the cache as introduced some weeks ago. Instead of holding multiple SVGImages, each containing
        a whole DOM/render tree, we now create bitmap images rendered at the requested sizes/zoom levels and cache them.

        Revert ImageBySizeCache changes that were needed to make it usable wih SVGImage. Its now used only in CSSImageGeneratorValue and
        thus the extra information that CSSImageGeneratorValue doesn't need can be removed again (desired/actual size differentations, and the zoom level).

        Tests: svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size.html
               svg/as-image/animated-svg-as-image-same-image.html

        * CMakeLists.txt: Add svg/graphics/SVGImageCache.* to build.
        * GNUmakefile.list.am: Ditto.
        * Target.pri: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.vcproj/copyForwardingHeaders.cmd: Copy headers from svg/graphics, as SVGImageCache is needed by CachedImage in SVG enabled builds.
        * WebCore.xcodeproj/project.pbxproj: Add svg/graphics/SVGImageCache.* to build.
        * css/CSSImageGeneratorValue.cpp: Remove zoom parameter from addClient/getImage, no need to pass 1 default values anymore.
        (WebCore::CSSImageGeneratorValue::addClient):
        (WebCore::CSSImageGeneratorValue::getImage):
        * loader/cache/CachedImage.cpp: Stop using ImageBySizeCache, and switch to the new SVGImageCache.
        (WebCore::CachedImage::removeClientForRenderer):
        (WebCore::CachedImage::lookupOrCreateImageForRenderer):
        (WebCore::CachedImage::setContainerSizeForRenderer):
        (WebCore::CachedImage::imageSizeForRenderer):
        (WebCore::CachedImage::clear):
        (WebCore::CachedImage::createImage):
        (WebCore::CachedImage::destroyDecodedData):
        (WebCore::CachedImage::decodedSizeChanged):
        (WebCore::CachedImage::didDraw):
        (WebCore::CachedImage::shouldPauseAnimation):
        (WebCore::CachedImage::animationAdvanced):
        (WebCore::CachedImage::changedInRect):
        * loader/cache/CachedImage.h:
        * page/DragController.cpp: Stop using imageForRenderer(), as it may return cached BitmapImages, that don't carry a filename extension anymore, which is required here.
        (WebCore::getImage):
        * rendering/ImageBySizeCache.cpp: Revert changes to ImageBySizeCache, which were needed to make it usable for SVGImages. CSSImageGenerator doesn't need it.
        (WebCore::ImageBySizeCache::addClient):
        (WebCore::ImageBySizeCache::removeClient):
        (WebCore::ImageBySizeCache::getImage):
        * rendering/ImageBySizeCache.h: Ditto.
        (WebCore::SizeAndCount::SizeAndCount):
        * rendering/RenderImage.cpp: Stop using imageForRenderer(), use cachedImage()->image(), which is guaranteed to be a SVGImage for svg images, and not a cached bitmap copy.
        (WebCore::RenderImage::embeddedContentBox):
        * rendering/RenderReplaced.cpp: Simplify logic to figure out the intrinsic size - the special logic for the old SVGImage cache can go away now.
        (WebCore::RenderReplaced::computeIntrinsicLogicalWidth):
        (WebCore::RenderReplaced::computeIntrinsicLogicalHeight):
        * rendering/style/StyleCachedImage.cpp: Call removeClientForRenderer(), which takes care of clearing SVGImageCache entries as well.
        (WebCore::StyleCachedImage::removeClient): This change is needed, as we don't want to make removeClient() virtual in CachedResource.
        * rendering/svg/RenderSVGRoot.cpp: Rename isEmbeddedThroughImageElement to isEmbeddedThroughSVGImage, as this is what it actually checks.
        (WebCore::RenderSVGRoot::isEmbeddedThroughSVGImage):
        * rendering/svg/RenderSVGRoot.h:
        * svg/SVGSVGElement.cpp: Fix bug that's visible now with the SVGImageCache, which was already there before, but hard to trigger.
        (WebCore::SVGSVGElement::currentViewBoxRect): The viewBox depends on who's asking for it: the host document or the embedded document? Take that into account.
        * svg/SVGSVGElement.h:
        * svg/graphics/SVGImage.cpp: Cleanup some code. Add new logic that draws a SVGImage into an ImageBuffer at a desired size & zoom.
        (WebCore::SVGImage::setContainerSize):
        (WebCore::SVGImage::size):
        (WebCore::SVGImage::drawSVGToImageBuffer):
        * svg/graphics/SVGImage.h:
        * svg/graphics/SVGImageCache.cpp: Added. SVGImageCache caches Image/ImageBuffer pairs for each _renderer_ and size/zoom level. The ImageBySizeCache only cared about size.
        (WebCore::SVGImageCache::SVGImageCache):
        (WebCore::SVGImageCache::~SVGImageCache):
        (WebCore::SVGImageCache::removeRendererFromCache):
        (WebCore::SVGImageCache::setRequestedSizeAndZoom):
        (WebCore::SVGImageCache::getRequestedSizeAndZoom):
        (WebCore::SVGImageCache::imageContentChanged):
        (WebCore::SVGImageCache::redrawTimerFired):
        (WebCore::SVGImageCache::lookupOrCreateBitmapImageForRenderer):
        * svg/graphics/SVGImageCache.h: Added.
        (WebCore::SVGImageCache::create):
        (WebCore::SVGImageCache::CachedSizeAndZoom::CachedSizeAndZoom):
        (WebCore::SVGImageCache::CachedImageData::CachedImageData):

2011-11-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Switch SVGImage cache to store ImageBuffers instead of whole SVGImages, including a DOM/Render tree
        https://bugs.webkit.org/show_bug.cgi?id=71368

        Reviewed by Antti Koivisto.

        * CMakeLists.txt: Add svg/graphics include, for SVGImageCache.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, skip flaky crasher on GTK.
philn@webkit.org [Tue, 8 Nov 2011 09:13:04 +0000 (09:13 +0000)]
Unreviewed, skip flaky crasher on GTK.

* platform/gtk/Skipped: Skip fast/css/webkit-mask-crash-fieldset-legend.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2][GTK] Application cache directory is incorrectly set
commit-queue@webkit.org [Tue, 8 Nov 2011 09:07:29 +0000 (09:07 +0000)]
[WK2][GTK] Application cache directory is incorrectly set
https://bugs.webkit.org/show_bug.cgi?id=70680

Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-11-08
Reviewed by Philippe Normand.

Correctly set application cache directory to be in current
user's default cache directory.

* UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::applicationCacheDirectory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Some tests are flaky with NRWT
ossy@webkit.org [Tue, 8 Nov 2011 09:04:45 +0000 (09:04 +0000)]
[Qt] Some tests are flaky with NRWT
https://bugs.webkit.org/show_bug.cgi?id=64002
There can be found the skipped tests:
https://bugs.webkit.org/show_bug.cgi?id=71693
https://bugs.webkit.org/show_bug.cgi?id=71695

These 2 tests caused 7 tests timeouting.

Patch by Nándor Huszka <huszka.nandor@stud.u-szeged.hu> on 2011-11-08
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped: Skip culprit tests
- http/tests/notifications/icon-does-not-exist.html
- http/tests/xmlhttprequest/workers/abort-exception-assert.html
* platform/qt/test_expectations.txt: Unskip passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Removing qwebkitglobal.h inclusion from qwebkitplatformplugin.h
commit-queue@webkit.org [Tue, 8 Nov 2011 09:01:39 +0000 (09:01 +0000)]
[Qt] Removing qwebkitglobal.h inclusion from qwebkitplatformplugin.h
https://bugs.webkit.org/show_bug.cgi?id=71759

Patch by Luiz Agostini <luiz.agostini@palm.com> on 2011-11-08
Reviewed by Simon Hausmann.

qwebkitplatformplugin.h must not depend on qwebkitglobal.h.

* Api/qwebkitplatformplugin.h:

Updating the copy of qwebkitplatformplugin.h that is used by the example plugin. The previous
one was very outdated.

* examples/platformplugin/qwebkitplatformplugin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreivewed gardening. Reset test results.
ossy@webkit.org [Tue, 8 Nov 2011 08:57:20 +0000 (08:57 +0000)]
[Qt] Unreivewed gardening. Reset test results.

Patch by Fehér Zsolt <feherzs@inf.u-szeged.hu> on 2011-11-08

* platform/qt-5.0/fast/css/child-style-can-override-visited-style-expected.txt: Added.
* platform/qt-5.0/fast/multicol/block-axis-horizontal-bt-expected.txt: Added.
* platform/qt-5.0/fast/multicol/block-axis-horizontal-tb-expected.txt: Added.
* platform/qt-5.0/fast/multicol/block-axis-vertical-lr-expected.txt: Added.
* platform/qt-5.0/fast/multicol/block-axis-vertical-rl-expected.txt: Added.
* platform/qt-5.0/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
* platform/qt-5.0/svg/as-image/same-image-two-instances-expected.txt: Added.
* platform/qt-5.0/svg/as-image/svg-image-change-content-size-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: refactor shortcuts and settings screens
yurys@chromium.org [Tue, 8 Nov 2011 08:55:51 +0000 (08:55 +0000)]
Web Inspector: refactor shortcuts and settings screens
https://bugs.webkit.org/show_bug.cgi?id=71773

Keep pointer to the visible screen and hide it automatically when new one is going
to be displayed.

Reviewed by Pavel Feldman.

* inspector/front-end/HelpScreen.js:
(WebInspector.HelpScreen.prototype.show):
(WebInspector.HelpScreen.prototype.hide):
* inspector/front-end/ShortcutsScreen.js:
(WebInspector.ShortcutsScreen): ShortcutsScreen is now a descendant of HelpScreen.
(WebInspector.ShortcutsScreen.prototype.show):
* inspector/front-end/inspector.js:
(WebInspector._hideSettingsScreen):
(WebInspector.documentKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG 32_64 - update make lists for efl, gtk, and Qt ports with DFG change r99519
yuqiang.xian@intel.com [Tue, 8 Nov 2011 08:52:25 +0000 (08:52 +0000)]
DFG 32_64 - update make lists for efl, gtk, and Qt ports with DFG change r99519
https://bugs.webkit.org/show_bug.cgi?id=71768

Reviewed by Geoffrey Garen.

Also includes a fix to make the newly introduced AssemblyHelpers
friend of JSValue as we need the Tag definitions.

* CMakeListsEfl.txt:
* GNUmakefile.list.am:
* Target.pri:
* runtime/JSValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, mark 2 tests flaky in GTK.
philn@webkit.org [Tue, 8 Nov 2011 08:52:25 +0000 (08:52 +0000)]
Unreviewed, mark 2 tests flaky in GTK.

* platform/gtk/test_expectations.txt:
fast/forms/password-placeholder-text-security.html and
fast/lists/inlineBoxWrapperNullCheck.html are flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 8 Nov 2011 08:43:25 +0000 (08:43 +0000)]
2011-11-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Fix Snow Leopard 32bit builds.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseAspectRatio): CSSParserValue::fValue is a double, use narrowPrecisionToFloat() to convert double->float.
        * platform/ClockGeneric.cpp: Remove unneeded variable out of 32bit integer value range.
        * webaudio/BiquadDSPKernel.cpp:
        (WebCore::BiquadDSPKernel::getFrequencyResponse): Use narrowPrecisionTofloat() to convert double->float.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed gardening.
yutak@chromium.org [Tue, 8 Nov 2011 08:14:55 +0000 (08:14 +0000)]
[Chromium] Unreviewed gardening.

Rebaseline tests after r99454. Mark one SVG test as flaky.

* platform/chromium-cg-mac-snowleopard/fast/borders/outline-alpha-block-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/borders/outline-alpha-block-expected.png.
* platform/chromium-mac-leopard/fast/borders/outline-alpha-block-expected.png:
* platform/chromium-mac-snowleopard/fast/borders/outline-alpha-block-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-radius-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/layers/self-painting-outline-expected.png: Added.
* platform/chromium-mac/fast/borders/outline-alpha-block-expected.png: Removed.
* platform/chromium-mac/fast/box-shadow/box-shadow-radius-expected.png: Removed.
* platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png:
* platform/chromium-win/fast/layers/self-painting-outline-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTouch the pro file to trigger a proper (re)build of the Makefile on
hausmann@webkit.org [Tue, 8 Nov 2011 08:10:27 +0000 (08:10 +0000)]
Touch the pro file to trigger a proper (re)build of the Makefile on
the bot (removed redundant line)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] MiniBrowser should use urlFromUserInput()
hausmann@webkit.org [Tue, 8 Nov 2011 07:49:53 +0000 (07:49 +0000)]
[Qt][WK2] MiniBrowser should use urlFromUserInput()
https://bugs.webkit.org/show_bug.cgi?id=71680

Use urlFromUserInput() / QUrl::fromUserInput() to automatically
complete urls in MiniBrowser.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-11-07
Reviewed by Tor Arne Vestbø.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::load):
* MiniBrowser/qt/qml/BrowserWindow.qml:
* MiniBrowser/qt/utils.cpp:
(Utils::urlFromUserInput):
* MiniBrowser/qt/utils.h:
(Utils::Utils):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded myself as a committer.
yuqiang.xian@intel.com [Tue, 8 Nov 2011 07:32:44 +0000 (07:32 +0000)]
Added myself as a committer.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix gcc 4.4 compilation warnings in DFG 32_64
yuqiang.xian@intel.com [Tue, 8 Nov 2011 06:51:43 +0000 (06:51 +0000)]
Fix gcc 4.4 compilation warnings in DFG 32_64
https://bugs.webkit.org/show_bug.cgi?id=71762

Reviewed by Filip Pizlo.

* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::registersMatched):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Layout Test platform/chromium-cg-mac/editing/input/ime-candidate-window...
bashi@chromium.org [Tue, 8 Nov 2011 06:49:51 +0000 (06:49 +0000)]
[Chromium] Layout Test platform/chromium-cg-mac/editing/input/ime-candidate-window-position.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=71653

Reviewed by Kent Tamura.

* platform/chromium-cg-mac/editing/input/ime-candidate-window-position.html: Calls doTest() after iframe is loaded.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd CredentialStorage.cpp to WebCore/CMakeLists.txt
dbates@webkit.org [Tue, 8 Nov 2011 06:40:26 +0000 (06:40 +0000)]
Add CredentialStorage.cpp to WebCore/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=71748

Reviewed by Martin Robinson.

Adds CredentialStorage.cpp to WebCore/CMakeLists.txt since its provides a
base implementation of this feature.

Also adds a stub implementation of CredentialStorage to the WinCE port.

* CMakeLists.txt: Added source file CredentialStorage.cpp.
* CMakeListsEfl.txt: Added source file CredentialStorageCurl.cpp when building
  with the Curl networking backend.
* CMakeListsWinCE.txt: Added source file CredentialStorageWin.cpp.
* platform/network/win/CredentialStorageWin.cpp: Added.
(WebCore::Credential::getFromPersistentStorage): Stub implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed morning gardening, skip a failing new test: svg/custom/getBBox-path...
ossy@webkit.org [Tue, 8 Nov 2011 06:27:20 +0000 (06:27 +0000)]
[Qt] Unreviewed morning gardening, skip a failing new test: svg/custom/getBBox-path.svg.
https://bugs.webkit.org/show_bug.cgi?id=71766

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdding myself to the committer script.
ravi.kasibhatla@motorola.com [Tue, 8 Nov 2011 06:12:33 +0000 (06:12 +0000)]
Adding myself to the committer script.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed webkitpy test fix after r99512.
ossy@webkit.org [Tue, 8 Nov 2011 06:03:17 +0000 (06:03 +0000)]
Unreviewed webkitpy test fix after r99512.

* Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
Xianzhu Wang is now a committer, so we can't nominate him as a committer anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG code base should allow for classes not related to DFG::JITCompiler
fpizlo@apple.com [Tue, 8 Nov 2011 05:48:09 +0000 (05:48 +0000)]
DFG code base should allow for classes not related to DFG::JITCompiler
to use DFG idioms
https://bugs.webkit.org/show_bug.cgi?id=71746

Reviewed by Gavin Barraclough.

* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGAssemblyHelpers.cpp: Added.
(JSC::DFG::AssemblyHelpers::decodedCodeMapFor):
(JSC::DFG::AssemblyHelpers::emitCount):
(JSC::DFG::AssemblyHelpers::setSamplingFlag):
(JSC::DFG::AssemblyHelpers::clearSamplingFlag):
(JSC::DFG::AssemblyHelpers::jitAssertIsInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSNumber):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSDouble):
(JSC::DFG::AssemblyHelpers::jitAssertIsCell):
* dfg/DFGAssemblyHelpers.h: Added.
* dfg/DFGJITCompiler.cpp:
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::graph):
* dfg/DFGJITCompiler32_64.cpp:
* dfg/DFGOSRExit.h: Added.
(JSC::DFG::SpeculationRecovery::SpeculationRecovery):
(JSC::DFG::SpeculationRecovery::type):
(JSC::DFG::SpeculationRecovery::dest):
(JSC::DFG::SpeculationRecovery::src):
(JSC::DFG::OSRExit::numberOfRecoveries):
(JSC::DFG::OSRExit::valueRecovery):
(JSC::DFG::OSRExit::isArgument):
(JSC::DFG::OSRExit::isVariable):
(JSC::DFG::OSRExit::argumentForIndex):
(JSC::DFG::OSRExit::variableForIndex):
(JSC::DFG::OSRExit::operandForArgument):
(JSC::DFG::OSRExit::operandForIndex):
* dfg/DFGSpeculativeJIT.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Need to replace api's object parameter with proper name.
gyuyoung.kim@samsung.com [Tue, 8 Nov 2011 04:44:07 +0000 (04:44 +0000)]
[EFL] Need to replace api's object parameter with proper name.
https://bugs.webkit.org/show_bug.cgi?id=71553

Fix wrong parameter names in tiled backing store functions and ewk_view_xxx files.

Reviewed by Filip Pizlo.

* ewk/ewk_tiled_backing_store.cpp:
* ewk/ewk_view_single.cpp:
* ewk/ewk_view_tiled.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd layout test for locale-based font selection
commit-queue@webkit.org [Tue, 8 Nov 2011 04:31:10 +0000 (04:31 +0000)]
Add layout test for locale-based font selection
https://bugs.webkit.org/show_bug.cgi?id=67019

This test relies on overridePreference("WebKit*FontMap"...) which is
implemented only on Chromium DumpRenderTree so far.

Patch by Matt Falkenhagen <falken@chromium.org> on 2011-11-07
Reviewed by Kent Tamura.

* fast/text/international/locale-sensitive-fonts.html: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped: Added skip for non-Chromium ports.
* platform/gtk-wk2/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSwitch back to 1+1 value profiling buckets, since it didn't help on arewefastyet,
fpizlo@apple.com [Tue, 8 Nov 2011 03:02:19 +0000 (03:02 +0000)]
Switch back to 1+1 value profiling buckets, since it didn't help on arewefastyet,
but it appears to help on other benchmarks.

Rubber stamped by Oliver Hunt.

* bytecode/ValueProfile.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove [CustomGetter] IDL for window.Image of V8
haraken@chromium.org [Tue, 8 Nov 2011 02:41:53 +0000 (02:41 +0000)]
Remove [CustomGetter] IDL for window.Image of V8
https://bugs.webkit.org/show_bug.cgi?id=71739

Reviewed by Adam Barth.

Currently, window.Image uses a custom getter to get the template
of 'HTMLImageElementConstructor'. However, this getter does not need to
be custom and can use a default getter
'DOMWindowInternal::DOMWindowConstructorGetter'.

Tests: fast/js/custom-constructors.html
       fast/dom/image-object.html
       fast/dom/gc-image-element.html
       fast/dom/Window/custom-constructors.html

* bindings/v8/custom/V8DOMWindowCustom.cpp: Removed a custom getter.
* page/DOMWindow.idl: Removed [CustomGetter] IDL from window.Image of V8. Renamed 'HTMLImageElementConstructor' to 'HTMLImageElementConstructorConstructor' in order to make window.Image use the template of (not 'HTMLImageElement' but) 'HTMLImageElementConstructor'. Note that CodeGenerator*.pm strips /Constructor$/ from the IDL type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r99025-r99037): platform/mac/accessibility/select-element-selection-with...
cfleizach@apple.com [Tue, 8 Nov 2011 02:25:59 +0000 (02:25 +0000)]
REGRESSION(r99025-r99037): platform/mac/accessibility/select-element-selection-with-optgroups.html is asserting
https://bugs.webkit.org/show_bug.cgi?id=71421

Reviewed by Ryosuke Niwa.

Source/WebCore:

Remove an assert that was added by r99035. It was added based on a comment in the code, but not tested.

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::selectOption):

LayoutTests:

Re-enable test after removing an erroneous assert.

* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago"use strict" can not contain escape sequences or line continuation
ariya@webkit.org [Tue, 8 Nov 2011 02:25:20 +0000 (02:25 +0000)]
"use strict" can not contain escape sequences or line continuation
https://bugs.webkit.org/show_bug.cgi?id=71532

Reviewed by Darin Adler.

Source/JavaScriptCore:

Store the actual literal length (before the escapes and line
continuation are encoded) while parsing the directive and use it
for the directive comparison.

* parser/Parser.cpp:
(JSC::Parser::parseSourceElements):
(JSC::Parser::parseStatement):
* parser/Parser.h:

LayoutTests:

* fast/js/basic-strict-mode-expected.txt:
* fast/js/script-tests/basic-strict-mode.js:
(testLineContinuation): Added.
(testEscapeSequence): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd myself as a committer.
wangxianzhu@chromium.org [Tue, 8 Nov 2011 02:14:56 +0000 (02:14 +0000)]
Add myself as a committer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRevert platform and scrolling to ints
eae@chromium.org [Tue, 8 Nov 2011 02:11:06 +0000 (02:11 +0000)]
Revert platform and scrolling to ints
https://bugs.webkit.org/show_bug.cgi?id=71585

Reviewed by Eric Seidel.

Replace all uses of LayoutUnit and related types with ints in platform
and scrolling code.

Source/WebCore:

No new tests.

* page/FrameView.cpp:
* page/FrameView.h:
* platform/PopupMenuClient.h:
* platform/ScrollAnimatorNone.cpp:
* platform/ScrollAnimatorNone.h:
* platform/ScrollView.cpp:
* platform/ScrollView.h:
* platform/ScrollableArea.h:
* rendering/RenderLayer.cpp:
* rendering/RenderLayer.h:
* rendering/RenderListBox.cpp:
* rendering/RenderListBox.h:
* rendering/RenderMenuList.cpp:
* rendering/RenderMenuList.h:
* rendering/RenderTextControlSingleLine.cpp:
* rendering/RenderTextControlSingleLine.h:

Source/WebKit/chromium:

* tests/ScrollAnimatorNoneTest.cpp:
(MockScrollableArea::visibleHeight):
(MockScrollableArea::visibleWidth):

Source/WebKit2:

* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::invalidateScrollbarRect):
(WebKit::BuiltInPDFView::visibleHeight):
(WebKit::BuiltInPDFView::visibleWidth):
* WebProcess/Plugins/PDF/BuiltInPDFView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixed wrong test results of fast/js/custom-constructors.html
haraken@chromium.org [Tue, 8 Nov 2011 02:08:06 +0000 (02:08 +0000)]
Fixed wrong test results of fast/js/custom-constructors.html
https://bugs.webkit.org/show_bug.cgi?id=71669

Reviewed by Darin Adler.

According to the HTMLOptionElement spec
(http://dev.w3.org/html5/spec/the-button-element.html#the-option-element),
'text', 'label' and 'value' have neither [TreatUndefinedAs=EmptyString]
nor [TreatNullAs=EmptyString]. Thus, an undefined value should be
converted to a string "undefined" and a null value should be
converted to a string "null", following the step 3 of the IDL
conversion spec (http://dev.w3.org/2006/webapi/WebIDL/#es-DOMString).

Source/WebCore:

* bindings/js/JSOptionConstructor.cpp:
(WebCore::constructHTMLOptionElement): Removed isUndefined() check from 'text' and 'value' since the spec does not have [TreatUndefinedAs=EmptyString].
* bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
(WebCore::v8HTMLOptionElementConstructorCallback): Ditto.
* html/HTMLOptionElement.idl: Removed [ConvertNullToNullString] from 'text', 'label' and 'value' since the spec does not have [TreatNullAs=EmptyString].

LayoutTests:

* fast/dom/element-attribute-js-null-expected.txt: Fixed the test result.
* fast/dom/element-attribute-js-null.html: Ditto.
* fast/js/custom-constructors-expected.txt: Ditto.
* fast/js/script-tests/custom-constructors.js: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove DomainRelaxationForbidden scheme registry to SchemeRegistry
abarth@webkit.org [Tue, 8 Nov 2011 01:37:47 +0000 (01:37 +0000)]
Move DomainRelaxationForbidden scheme registry to SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=71750

Reviewed by Eric Seidel.

Source/WebCore:

As stated in the FIXME, scheme registries belong in SchemeRegistry, not
in SecurityOrigin.

* WebCore.exp.in:
* dom/Document.cpp:
(WebCore::Document::setDomain):
* page/SecurityOrigin.cpp:
* page/SecurityOrigin.h:
* platform/SchemeRegistry.cpp:
(WebCore::schemesForbiddenFromDomainRelaxation):
(WebCore::SchemeRegistry::setDomainRelaxationForbiddenForURLScheme):
(WebCore::SchemeRegistry::isDomainRelaxationForbiddenForURLScheme):
* platform/SchemeRegistry.h:

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setDomainRelaxationForbidden):

Source/WebKit/mac:

* WebView/WebView.mm:
(+[WebView _setDomainRelaxationForbidden:forURLScheme:]):

Source/WebKit/qt:

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setDomainRelaxationForbiddenForURLScheme):

Source/WebKit/win:

* WebView.cpp:
(WebView::setDomainRelaxationForbiddenForURLScheme):

Source/WebKit2:

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setDomainRelaxationForbiddenForURLScheme):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/10405215> REGRESSION (r98178): World of Warcraft Launcher crashes...
mitz@apple.com [Tue, 8 Nov 2011 01:16:35 +0000 (01:16 +0000)]
<rdar://problem/10405215> REGRESSION (r98178): World of Warcraft Launcher crashes in FrameView::isOnActivePage()
https://bugs.webkit.org/show_bug.cgi?id=71743

Reviewed by Beth Dakin.

* page/FrameView.cpp:
(WebCore::FrameView::isOnActivePage): Added a check for a null m_frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=71534
dslomov@google.com [Tue, 8 Nov 2011 00:59:33 +0000 (00:59 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=71534
[V8] On neutering TypedArrayViews, V8 should be notified to drain code generation cache.

Reviewed by David Levin.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
* html/canvas/DataView.cpp:
* html/canvas/DataView.h:
* html/canvas/Float32Array.h:
* html/canvas/Float64Array.h:
* html/canvas/Int16Array.h:
* html/canvas/Int32Array.h:
* html/canvas/Int8Array.h:
* html/canvas/TypedArrayBase.h:
* html/canvas/Uint16Array.h:
* html/canvas/Uint32Array.h:
* html/canvas/Uint8Array.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoaddMessage's last few arguments should be optional
abarth@webkit.org [Tue, 8 Nov 2011 00:57:10 +0000 (00:57 +0000)]
addMessage's last few arguments should be optional
https://bugs.webkit.org/show_bug.cgi?id=70946

Reviewed by Darin Adler.

As requested by Darin Adler.  I wanted to call this method addMessage,
but the compiler was unhappy locating the overload on
ScriptExecutionContext when Document had an override too.  Changing the
name to addConsoleMessage made all the code happier.

* dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::addMessage):
* dom/ScriptExecutionContext.h:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::getImageData):
* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::filterToken):
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::notifyFinished):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation):
(WebCore::ContentSecurityPolicy::logUnrecognizedDirective):
* page/EventSource.cpp:
(WebCore::EventSource::didReceiveResponse):
* webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::looping):
(WebCore::AudioBufferSourceNode::setLooping):
* webaudio/AudioContext.cpp:
(WebCore::AudioContext::createLowPass2Filter):
(WebCore::AudioContext::createHighPass2Filter):
* xml/XMLHttpRequest.cpp:
(WebCore::reportUnsafeUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebWorkers fail with document.domain set when accessing from subdomain
abarth@webkit.org [Tue, 8 Nov 2011 00:51:28 +0000 (00:51 +0000)]
WebWorkers fail with document.domain set when accessing from subdomain
https://bugs.webkit.org/show_bug.cgi?id=67978

Reviewed by Sam Weinig.

Source/WebCore:

Workers should ignore document.domain when deciding which URLs a
document can request, just like XMLHttpRequest and every other API.

Test: http/tests/workers/worker-document-domain-security.html

* workers/AbstractWorker.cpp:
(WebCore::AbstractWorker::resolveURL):

LayoutTests:

Test that a document can still create same-origin workers after setting
document.domain.

* http/tests/workers/worker-document-domain-security-expected.txt: Added.
* http/tests/workers/worker-document-domain-security.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG operationCreateThis slow path may get the wrong callee in case of inlining
fpizlo@apple.com [Tue, 8 Nov 2011 00:37:33 +0000 (00:37 +0000)]
DFG operationCreateThis slow path may get the wrong callee in case of inlining
https://bugs.webkit.org/show_bug.cgi?id=71647

Reviewed by Oliver Hunt.

No new tests because I only saw this manifest itself when I had other bugs
leading to spurious slow path executions.

* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix chromium cg results for css2.1/20110323/block-non-replaced-width-008.html
tony@chromium.org [Tue, 8 Nov 2011 00:33:20 +0000 (00:33 +0000)]
Fix chromium cg results for css2.1/20110323/block-non-replaced-width-008.html

* platform/chromium-cg-mac-leopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/css2.1/20110323/block-non-replaced-width-008-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAllow gamepad API to be enabled at runtime
commit-queue@webkit.org [Tue, 8 Nov 2011 00:27:44 +0000 (00:27 +0000)]
Allow gamepad API to be enabled at runtime
https://bugs.webkit.org/show_bug.cgi?id=71736

Part of full patch, found at
https://bugs.webkit.org/show_bug.cgi?id=69451

Patch by Scott Graham <scottmg@chromium.org> on 2011-11-07
Reviewed by Adam Barth.

No new tests. No new functionality.

* bindings/generic/RuntimeEnabledFeatures.cpp:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setGamepadsEnabled):
(WebCore::RuntimeEnabledFeatures::gamepadsEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove [CustomGetter] IDL for window.Option of V8
haraken@chromium.org [Tue, 8 Nov 2011 00:10:42 +0000 (00:10 +0000)]
Remove [CustomGetter] IDL for window.Option of V8
https://bugs.webkit.org/show_bug.cgi?id=71735

Reviewed by Nate Chapin.

Currently, window.Option uses a custom getter to get the template
of 'HTMLOptionElementConstructor'. However, this getter does not need to
be custom and can use a default getter
'DOMWindowInternal::DOMWindowConstructorGetter'.

Tests: fast/js/custom-constructors.html
       fast/forms/option-index.html
       fast/forms/add-and-remove-option.html
       fast/dom/dom-add-optionelement.html

* bindings/v8/custom/V8DOMWindowCustom.cpp: Removed a custom getter.
* page/DOMWindow.idl: Removed [CustomGetter] IDL from window.Option of V8. Renamed 'HTMLOptionElementConstructor' to 'HTMLOptionElementConstructorConstructor' in order to make window.Option use the template of (not 'HTMLOptionElement' but) 'HTMLOptionElementConstructor'. Note that CodeGenerator*.pm strips /Constructor$/ from the IDL type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDe-virtualize JSObject::putWithAttributes
mhahnenberg@apple.com [Mon, 7 Nov 2011 23:57:37 +0000 (23:57 +0000)]
De-virtualize JSObject::putWithAttributes
https://bugs.webkit.org/show_bug.cgi?id=71716

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added putWithAttributes to the MethodTable, changed all the virtual
implementations of putWithAttributes to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* API/JSObjectRef.cpp:
(JSObjectSetProperty):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::putWithAttributes):
* debugger/DebuggerActivation.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
* runtime/ClassInfo.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::putWithAttributes):
* runtime/JSActivation.h:
* runtime/JSCell.cpp:
(JSC::JSCell::putWithAttributes):
* runtime/JSCell.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::putWithAttributes):
* runtime/JSGlobalObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::putWithAttributes):
(JSC::putDescriptor):
* runtime/JSObject.h:
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::putWithAttributes):
* runtime/JSStaticScopeObject.h:
* runtime/JSVariableObject.cpp:
(JSC::JSVariableObject::putWithAttributes):
* runtime/JSVariableObject.h:

Source/WebCore:

No new tests.

Added putWithAttributes to the MethodTable, changed all the virtual
implementations of putWithAttributes to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::putWithAttributes):
* bindings/js/JSDOMWindowShell.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] restore original expectation for fast/frames/sandboxed-iframe-navigation...
tony@chromium.org [Mon, 7 Nov 2011 23:53:04 +0000 (23:53 +0000)]
[chromium] restore original expectation for fast/frames/sandboxed-iframe-navigation-targetlink.html

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Release build fix.
dslomov@google.com [Mon, 7 Nov 2011 23:49:17 +0000 (23:49 +0000)]
Unreviewed. Release build fix.

* parser/Lexer.cpp:
(JSC::assertCharIsIn8BitRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r99470.
commit-queue@webkit.org [Mon, 7 Nov 2011 23:46:08 +0000 (23:46 +0000)]
Unreviewed, rolling out r99470.
http://trac.webkit.org/changeset/99470
https://bugs.webkit.org/show_bug.cgi?id=71740

"Broke test-webkitpy" (Requested by eseidel2 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-07

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=71490
bdakin@apple.com [Mon, 7 Nov 2011 23:45:23 +0000 (23:45 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=71490
Support uiStateTransitionProgress for scrollbars
-and corresponding-
<rdar://problem/9849612>

Reviewed by Sam Weinig.

Source/WebCore:

Step 1 of supporting uiStateTransitionProgress is knowing when the mouse has
entered or exited a scrollbar. These changes to Scrollbar pass that information
on to the ScrollAnimator. Also, Scrollbar::mouseUp() now takes a
PlatformMouseEvent as a parameter. This is necessary because m_hoveredNode is not
always up to date on a mouseUp, so mouseUp must hitTest the scrollbar to see if
the mouse has exited the scrollbar.
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::mouseMoved):
(WebCore::Scrollbar::mouseExited):
(WebCore::Scrollbar::mouseUp):
* platform/Scrollbar.h:

These changes are required now that Scrollbar::mouseUp() takes a parameter.
* WebCore.exp.in:
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
* platform/chromium/PopupListBox.cpp:
(WebCore::PopupListBox::handleMouseReleaseEvent):
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::wndProc):

ScrollAnimator passes the information on to AppKit.
* platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::mouseEnteredScrollbar):
(WebCore::ScrollAnimator::mouseExitedScrollbar):
* platform/mac/ScrollAnimatorMac.h:
(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):

There are several new pieces of AppKit api we must call into.
* platform/mac/NSScrollerImpDetails.h:

This is a temporary function that is needed for the time being since there is new
AppKit api required for this to work.
* platform/mac/ScrollAnimatorMac.mm:
(supportsUIStateTransitionProgress):

I refactored WebScrollbarPartAnimation so that it can handle the
uiStateTransitionProgress animation as well as the alpha animations it already
handled. This mostly involved re-naming things and making use of a new enum called
FeatureToAnimate which keeps track of what the instance of
WebScrollbarPartAnimation is animating.
(-[WebScrollbarPartAnimation initWithScrollbarPainter:animate:scrollAnimator:animateFrom:animateTo:duration:]):
(-[WebScrollbarPartAnimation setScrollbarPainter:]):
(-[WebScrollbarPartAnimation setStartValue:]):
(-[WebScrollbarPartAnimation setEndValue:]):
(-[WebScrollbarPartAnimation setCurrentProgress:]):

WebScrollbarPainterDelegate has two new animations,
_verticalUIStateTransitionAnimation, and _horizontalUIStateTransitionAnimation. It
also responds to a few new delegate calls.
(-[WebScrollbarPainterDelegate cancelAnimations]):

This is a new delegate call needed for uiStateTransitionProgress.
(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):

I re-named setUpAnimation to setUpAlphaAnimation since it does a lot of things
that are specific to the alpha animation and I chose not to re-use it for
uiStateTransition.
(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):

New delegate call for the uiStateTransition animation that sets up that animation
and kicks it off.
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
(-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]):

Source/WebKit/chromium:

Scrollbar::mouseUp() now takes a PlatformMouseEvent as a parameter.
* src/WebScrollbarImpl.cpp:
(WebKit::WebScrollbarImpl::onMouseUp):

Source/WebKit/win:

Scrollbar::mouseUp() now takes a PlatformMouseEvent as a parameter.
* WebScrollBar.cpp:
(WebScrollBar::handleMouseEvent):

Source/WebKit2:

Scrollbar::mouseUp() now takes a PlatformMouseEvent as a parameter.
* UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::onLButtonUp):
* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::handleMouseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unnecessary use of function pointer in FrameSelection::modify()
aboxhall@chromium.org [Mon, 7 Nov 2011 23:43:21 +0000 (23:43 +0000)]
Remove unnecessary use of function pointer in FrameSelection::modify()
https://bugs.webkit.org/show_bug.cgi?id=71646

Reviewed by Ryosuke Niwa.

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::modify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed Windows build fix after r99468.
andreas.kling@nokia.com [Mon, 7 Nov 2011 23:39:29 +0000 (23:39 +0000)]
Unreviewed Windows build fix after r99468.

* css/CSSPrimitiveValue.h: Unmark single-argument constructors
as explicit, since this conflicts with the template constructors
in CSSPrimitiveValueMappings.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix due to a erroneous search-and-replace.
jer.noble@apple.com [Mon, 7 Nov 2011 23:25:52 +0000 (23:25 +0000)]
Build fix due to a erroneous search-and-replace.

Unreviewed build fix.

Replace all instances of GenericClock with ClockGeneric.

* WebCore.xcodeproj/project.pbxproj:
* platform/ClockGeneric.cpp:
(ClockGeneric::ClockGeneric):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove parseSandboxPolicy to SecurityContext
abarth@webkit.org [Mon, 7 Nov 2011 23:20:18 +0000 (23:20 +0000)]
Move parseSandboxPolicy to SecurityContext
https://bugs.webkit.org/show_bug.cgi?id=71732

Reviewed by Eric Seidel.

As requested by Eric, this patch resolves a layering inversion.  Now
that we have SecurityContext to hold the sandbox bits and the origin,
it's a logical place to put the parser for sandbox policies.

* dom/SecurityContext.cpp:
(WebCore::SecurityContext::parseSandboxPolicy):
* dom/SecurityContext.h:
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseMappedAttribute):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::applySandboxPolicy):
* page/SecurityOrigin.cpp:
* page/SecurityOrigin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename PlatformClockPOSIX -> ClockGeneric, and use WTF::currentTime() for its timing...
jer.noble@apple.com [Mon, 7 Nov 2011 23:17:42 +0000 (23:17 +0000)]
Rename PlatformClockPOSIX -> ClockGeneric, and use WTF::currentTime() for its timing source.
https://bugs.webkit.org/show_bug.cgi?id=71702

Reviewed by Sam Weinig.

No new tests; covered by existing tests.

* platform/Clock.cpp:
(Clock::create):
* platform/ClockGeneric.cpp: Renamed from Source/WebCore/platform/posix/PlatformClockPOSIX.cpp.
(ClockGeneric::GenericClock):
(ClockGeneric::setCurrentTime):
(ClockGeneric::currentTime):
(ClockGeneric::setPlayRate):
(ClockGeneric::start):
(ClockGeneric::stop):
* platform/ClockGeneric.h: Renamed from Source/WebCore/platform/posix/PlatformClockPOSIX.h.
(WebCore::ClockGeneric::playRate):
(WebCore::ClockGeneric::isRunning):

Boilerplate project file changes:
* CMakeLists.txt:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] disable 2 tests that are slow in debug
tony@chromium.org [Mon, 7 Nov 2011 23:16:47 +0000 (23:16 +0000)]
[chromium] disable 2 tests that are slow in debug

* platform/chromium/test_expectations.txt: only run
    fast/frames/lots-of-iframes.html and fast/frames/lots-of-objects.html
    in release builds

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99487 268f45cc-cd09-0410-ab3c-d52691b4dbfc