WebKit-https.git
13 years ago Reviewed by Adele.
aroben [Thu, 12 Oct 2006 23:02:08 +0000 (23:02 +0000)]
    Reviewed by Adele.

        Move popup menu code out of rendering/ and into platform/.
        RenderPopupMenu becomes PopupMenu, the
        RenderPopupMenuMac/RenderPopupMenuWin subclasses and all the associated
        virtual methods go away, RenderTheme gets to stop worrying about popup
        menus, PopupMenu becomes ref-counted, and everyone becomes happy.

        * WebCore.vcproj/WebCore/WebCore.vcproj: Move files within project.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * html/HTMLSelectElement.cpp: Remove unnecessary #include.
        * platform/PopupMenu.cpp: Moved from rendering/RenderPopupMenu.cpp.
        Also renamed showPopup()/hidePopup() to show()/hide() to disambiguate
        from RenderMenuList::showPopup/hidePopup.
        (WebCore::PopupMenu::create): New static creation method to hand back a
        PassRefPtr<PopupMenu>.
        (WebCore::PopupMenu::addItems): This platform-independent method should
        be called by PopupMenu::populate when the platform-specific
        implementation is ready to receive the menu items. Fixed an ASSERT
        while I was at it.
        * platform/PopupMenu.h: Moved from rendering/RenderPopupMenu.h. No more
        need for virtual methods.
        (WebCore::PopupMenu::wasClicked):
        (WebCore::PopupMenu::setWasClicked):
        (WebCore::PopupMenu::popupHandle):
        * platform/mac/PopupMenuMac.mm: Moved from
        rendering/RenderPopupMenuMac.mm. Much renaming ensues.
        (WebCore::PopupMenu::PopupMenu):
        (WebCore::PopupMenu::~PopupMenu):
        (WebCore::PopupMenu::clear):
        (WebCore::PopupMenu::populate):
        (WebCore::PopupMenu::show):
        (WebCore::PopupMenu::hide):
        (WebCore::PopupMenu::addSeparator):
        (WebCore::PopupMenu::addGroupLabel): Since we don't have our own
        RenderStyle anymore, just pick up the style from our RenderMenuList.
        (WebCore::PopupMenu::addOption): Ditto.
        * platform/win/TemporaryLinkStubs.cpp: Rename-fest.
        (PopupMenu::PopupMenu):
        (PopupMenu::~PopupMenu):
        (PopupMenu::clear):
        (PopupMenu::populate):
        (PopupMenu::show):
        (PopupMenu::hide):
        (PopupMenu::addSeparator):
        (PopupMenu::addGroupLabel):
        (PopupMenu::addOption):
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::~RenderMenuList):
        (WebCore::RenderMenuList::showPopup): Use nice new simple
        PopupMenu::create to make the popup.
        (WebCore::RenderMenuList::hidePopup):
        * rendering/RenderMenuList.h: Hold a RefPtr<PopupMenu> instead of a
        RenderPopupMenu*.
        (WebCore::RenderMenuList::popup):
        * rendering/RenderPopupMenu.cpp: Removed.
        * rendering/RenderPopupMenu.h: Removed.
        * rendering/RenderPopupMenuMac.h: Removed.
        * rendering/RenderPopupMenuMac.mm: Removed.
        * rendering/RenderPopupMenuWin.h: Removed.
        * rendering/RenderTheme.cpp: Get rid of createPopupMenu() method.
        * rendering/RenderTheme.h: Ditto.
        * rendering/RenderThemeMac.h: Ditto.
        * rendering/RenderThemeMac.mm: Ditto.
        * rendering/RenderThemeWin.cpp: Ditto.
        * rendering/RenderThemeWin.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Dave Harrison.
adele [Thu, 12 Oct 2006 21:44:16 +0000 (21:44 +0000)]
    Reviewed by Dave Harrison.

        - Fixed <rdar://problem/4650813> REGRESSION: typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)

        * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout):
        Make subtree layouts work for textareas as well as text fields.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
ggaren [Thu, 12 Oct 2006 20:42:56 +0000 (20:42 +0000)]
    Reviewed by Maciej.

        Removed JSObjectMakeWithPrototype, clarified some comments. We really
        don't want people to manage their own prototypes, so we don't want an
        extra function in the API devoted to just that. People can still manage
        their own prototypes if they really want by using JSObjectSetPrototype.

        * API/JSClassRef.cpp:
        (OpaqueJSClass::createNoAutomaticPrototype):
        (OpaqueJSClass::create):
        * API/JSClassRef.h:
        * API/JSObjectRef.cpp:
        (JSClassCreate):
        (JSObjectMake):
        * API/JSObjectRef.h:
        * API/testapi.c:
        (main):
        * JavaScriptCore.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by MacDome.
rwlbuis [Thu, 12 Oct 2006 20:29:31 +0000 (20:29 +0000)]
    Reviewed by MacDome.

        Finally found a way to remove our begin() trickery in FrameQt.
        The (probably misnamed) Frame::setEncoding() function automatically
        calls Frame::receivedFirstData() which calls being on the working
        url, which has been passed to didOpenUrl(). Took me some hours
        to figure out that the missing charset logic, forced us to do hacks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
kmccullo [Thu, 12 Oct 2006 20:19:32 +0000 (20:19 +0000)]
    Reviewed by Adam.

        Build breakage fix

        * kjs/DateMath.cpp:
        (KJS::msToTM):
        * kjs/date_object.cpp:
        (KJS::gmtoffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt.
aroben [Thu, 12 Oct 2006 19:22:37 +0000 (19:22 +0000)]
    Reviewed by Hyatt.

        Bandaid-ing a null-dereference crash until a real fix is made.

        * page/FrameView.cpp:
        (WebCore::FrameView::windowClipRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-12 MorganL <morganl.webkit@yahoo.com>
aroben [Thu, 12 Oct 2006 18:34:52 +0000 (18:34 +0000)]
2006-10-12  MorganL  <morganl.webkit@yahoo.com>

        Reviewed/landed by Adam.

        Fixes http://bugs.webkit.org/show_bug.cgi?id=11264
        Windows build busted

        * COM/WebFrame.cpp:
        (WebFrame::receivedResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
kmccullo [Thu, 12 Oct 2006 17:58:09 +0000 (17:58 +0000)]
    Reviewed by Geoff.

        Added our own tm struct to have a consistent set of fields, which lets us display the DST offset and timezone strings correctly.  Also there is some code cleanup.

        * kjs/DateMath.cpp:
        (KJS::timeToMS):
        (KJS::getUTCOffset):
        (KJS::getDSTOffsetSimple):
        (KJS::dateToMS):
        (KJS::msToTM):
        (KJS::tmToKJStm):
        (KJS::KJStmToTm):
        * kjs/DateMath.h:
        * kjs/date_object.cpp:
        (KJS::gmtoffset):
        (KJS::formatTime):
        (KJS::DateProtoFunc::callAsFunction):
        (KJS::DateObjectImp::construct):
        (KJS::DateObjectImp::callAsFunction):
        (KJS::DateObjectFuncImp::callAsFunction):
        (KJS::parseDate):
        * kjs/date_object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
rwlbuis [Thu, 12 Oct 2006 15:07:55 +0000 (15:07 +0000)]
    Reviewed by Mitz.

        http://bugs.webkit.org/show_bug.cgi?id=11217
        Cleanup svg coding style

        Cleanup coding style in svg text classes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
rwlbuis [Thu, 12 Oct 2006 12:44:16 +0000 (12:44 +0000)]
WebCore:
        Reviewed by Maciej.

        Specialization of alert() for DumpRenderTree - just log the output, don't show any message box.

WebKitTools:
        Reviewed by Maciej.

        Specialization of alert() for DumpRenderTree - just log the output, don't show any message box.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric.
mjs [Thu, 12 Oct 2006 11:50:09 +0000 (11:50 +0000)]
    Reviewed by Eric.

        - move m_responseMIMEType out of ResourceRequest, where it doesn't belong

        * page/FramePrivate.h: Add m_responseMIMEType
        * page/ResourceRequest.h: Remove m_responseMIMEType
        * page/Frame.cpp:
        (WebCore::Frame::setResponseMIMEType): added
        (WebCore::Frame::responseMIMEType): added
        (WebCore::Frame::begin): get MIME type from the right place
        (WebCore::Frame::write): ditto
        * page/Frame.h:
        * bindings/js/kjs_window.cpp:
        (KJS::createNewWindow): updated to use new Frame methods
        (KJS::WindowFunc::callAsFunction): ditto
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): ditto
        (-[WebCoreFrameBridge canProvideDocumentSource]): ditto
        * loader/PluginDocument.cpp:
        (WebCore::PluginTokenizer::createDocumentStructure): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric.
mjs [Thu, 12 Oct 2006 10:36:32 +0000 (10:36 +0000)]
    Reviewed by Eric.

        <rdar://problem/4774321> REGRESSION: "Can't find the server" error page contains unstyled text and missing image

        We really need some way to test loadHTMLString since it keeps breaking!

        * loader/mac/WebFrameLoader.mm:
        (-[WebFrameLoader commitProvisionalLoad:]): Set stuff up on the proper data source.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric.
rwlbuis [Thu, 12 Oct 2006 10:22:46 +0000 (10:22 +0000)]
    Reviewed by Eric.

        Fix Qt/Linux build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-12 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
bdash [Thu, 12 Oct 2006 09:36:24 +0000 (09:36 +0000)]
2006-10-12  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>

        Reviewed by Maciej.

        Update Gdk\Linux build for recent changes, based on Qt code

        * platform/gdk/FrameGdk.cpp:
        (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
        (WebCore::FrameGdkClientDefault::~FrameGdkClientDefault):
        (WebCore::FrameGdkClientDefault::setFrame):
        (WebCore::FrameGdkClientDefault::openURL):
        (WebCore::FrameGdkClientDefault::submitForm):
        (WebCore::FrameGdkClientDefault::receivedResponse):
        (WebCore::FrameGdkClientDefault::receivedData):
        (WebCore::FrameGdkClientDefault::receivedAllData):
        (WebCore::FrameGdk::FrameGdk):
        (WebCore::FrameGdk::openURL):
        (WebCore::FrameGdk::submitForm):
        (WebCore::FrameGdk::urlSelected):
        * platform/gdk/FrameGdk.h:
        * platform/gdk/TemporaryLinkStubs.cpp:
        (FrameGdk::createJavaAppletWidget):
        (FileChooser::create):

2006-10-12  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>

        Reviewed by Maciej.

        Also regenerate GdkLauncher makefiles, since not doing that might
        lead to mismatch between WebCore and GdkLauncher compiler settings.

        * Scripts/regenerate-makefiles:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd more clipping retrieval functionality for widgets.
hyatt [Thu, 12 Oct 2006 09:01:58 +0000 (09:01 +0000)]
Add more clipping retrieval functionality for widgets.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
darin [Thu, 12 Oct 2006 00:54:14 +0000 (00:54 +0000)]
    Reviewed by Adele.

        - preparations for making more code C++

        * WebKitPrefix.h: Fixed ifdef so that C++ files get all the precompiled stuff
        that non-C++ files get.

        * Misc/WebKitLogging.h:
        * Misc/WebKitSystemBits.h:
        * Misc/WebLocalizableStrings.h:
        * WebCoreSupport/WebSystemInterface.h:
        Added extern "C".

        * Misc/WebNSViewExtras.h:
        * WebView/WebDataSource.m: (addTypesFromClass):
        * WebView/WebFrameView.m: (addTypesFromClass):
        Eliminated use of the identifier "class".

        * WebView/WebView.m: (-[WebView _goToItem:withLoadType:]): Added a type cast.

        * Plugins/WebBaseNetscapePluginView.m: Added lots of type casts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John.
darin [Thu, 12 Oct 2006 00:40:02 +0000 (00:40 +0000)]
    Reviewed by John.

        - some changes to prepare for converting more code to C++

        * bridge/mac/WebCoreFrameBridge.h: Added import of <Cocoa/Cocoa.h> so this header is
        self-sufficient.

        * bridge/mac/WebCoreViewFactory.h: Added forward declaration of the NSMenu class.
        Needed since the class is used in this header (for some work I have not landed yet).

        * loader/mac/LoaderNSURLExtras.h:
        * loader/mac/WebFormDataStream.h:
        Added extern "C" so this code can be used from C++.

        * loader/mac/LoaderNSURLExtras.m:
        * loader/mac/WebDataProtocol.mm:
        * loader/mac/WebDocumentLoader.mm:
        * loader/mac/WebFormDataStream.m:
        * loader/mac/WebLoader.mm:
        * loader/mac/WebMainResourceLoader.mm:
        * loader/mac/WebNetscapePlugInStreamLoader.mm:
        * loader/mac/WebPolicyDecider.mm:
        * loader/mac/WebSubresourceLoader.mm:
        Added missing includes of config.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John Sullivan.
darin [Wed, 11 Oct 2006 23:18:21 +0000 (23:18 +0000)]
    Reviewed by John Sullivan.

        * WebKitSystemInterface.h: Updated to a C++-compatible version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Darin wrote this code; we tested it; I give it the thumbs up.
sullivan [Wed, 11 Oct 2006 23:15:18 +0000 (23:15 +0000)]
    Darin wrote this code; we tested it; I give it the thumbs up.

        - fixed regression from svn revision 16982 that was generating the wrong Obj-C classes

        The hash table to look up an element class given a QualifiedName was
        not working at all.

        * dom/QualifiedName.h:
        (WebCore::QualifiedName::impl):
        Added. This new accessor method for impl is needed if we want to use
        a QualifiedName as a hash table key without doing the kind of specialization
        we do for String. Maybe later we can do the String thing.

        * bindings/objc/DOM.mm:
        (WebCore::addElementClass):
        Use QualifiedName.impl instead of the QualifiedName pointer itself.
        The QualifiedName pointer is *not* unique so almost nothing would be found
        in this hash table!
        (WebCore::elementClass):
        ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubberstamped by Anders.
aroben [Wed, 11 Oct 2006 21:09:30 +0000 (21:09 +0000)]
    Rubberstamped by Anders.

        Clean up FileChooser::create and Icon::newIconForFile.

        * WebCore.xcodeproj/project.pbxproj:
        * platform/mac/FileChooserMac.mm:
        (WebCore::FileChooser::create):
        * platform/mac/IconMac.mm:
        (WebCore::Icon::newIconForFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
kmccullo [Wed, 11 Oct 2006 20:39:34 +0000 (20:39 +0000)]
    Reviewed by Darin.

        These test DST behavior on the cusp of a change (i.e. spring forward, fall back)

        * fast/js/date-DST-time-cusps-expected.txt: Added.
        * fast/js/date-DST-time-cusps.html: Added.
        * fast/js/resources/date-DST-time-cusps.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-11 Oliver Hunt <oliver@apple.com>
oliver [Wed, 11 Oct 2006 18:45:18 +0000 (18:45 +0000)]
2006-10-11  Oliver Hunt  <oliver@apple.com>

        Reviewed by Brady.

        Fix svg text related layout tests

        * svg/custom/getsvgdocument-expected.txt:
        * svg/hixie/viewbox/003-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-11 Oliver Hunt <oliver@apple.com>
oliver [Wed, 11 Oct 2006 18:27:49 +0000 (18:27 +0000)]
2006-10-11  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=11251
        Corrects canvas tag to not throw JS exception when drawing
        zero sized rects, arcs, etc

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::arcTo):
        (WebCore::CanvasRenderingContext2D::arc):
        (WebCore::CanvasRenderingContext2D::rect):
        (WebCore::CanvasRenderingContext2D::clearRect):
        (WebCore::CanvasRenderingContext2D::fillRect):
        (WebCore::CanvasRenderingContext2D::strokeRect):

        Reviewed by Geoff.

        Test case for http://bugs.webkit.org/show_bug.cgi?id=11251

        * fast/canvas/zero-size-fill-rect-expected.checksum: Added.
        * fast/canvas/zero-size-fill-rect-expected.png: Added.
        * fast/canvas/zero-size-fill-rect-expected.txt: Added.
        * fast/canvas/zero-size-fill-rect.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
rwlbuis [Wed, 11 Oct 2006 18:19:34 +0000 (18:19 +0000)]
    Reviewed by Mitz.

        http://bugs.webkit.org/show_bug.cgi?id=11221
        REGRESSION: iExploder crash due to style="cursor: url()"

        Take better care of empty cursor lists.

        Test: fast/css/invalid-cursor-property-crash.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fixing Windows for real this time.
aroben [Wed, 11 Oct 2006 17:56:16 +0000 (17:56 +0000)]
    Fixing Windows for real this time.

        * platform/win/TemporaryLinkStubs.cpp:
        (FileChooser::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix Windows build.
aroben [Wed, 11 Oct 2006 17:30:17 +0000 (17:30 +0000)]
    Fix Windows build.

        * platform/win/TemporaryLinkStubs.cpp:
        (FileChooser::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
antti [Wed, 11 Oct 2006 15:04:01 +0000 (15:04 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        Test for http://bugs.webkit.org/show_bug.cgi?id=4377

        * fast/layers/layer-visibility-expected.checksum: Added.
        * fast/layers/layer-visibility-expected.png: Added.
        * fast/layers/layer-visibility-expected.txt: Added.
        * fast/layers/layer-visibility.html: Added.

WebCore:

        Reviewed by Hyatt.

        http://bugs.webkit.org/show_bug.cgi?id=4377

        Respect css visibility semantics for layers too

        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::removeChildNode):
        (WebCore::RenderContainer::appendChildNode):
        (WebCore::RenderContainer::insertChildNode):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::RenderLayer):
        (WebCore::RenderLayer::updateLayerPositions):
        (WebCore::RenderLayer::setHasVisibleContent):
        (WebCore::RenderLayer::dirtyVisibleContentStatus):
        (WebCore::RenderLayer::childVisibilityChanged):
        (WebCore::RenderLayer::dirtyVisibleDescendantStatus):
        (WebCore::RenderLayer::updateVisibilityStatus):
        (WebCore::RenderLayer::addChild):
        (WebCore::RenderLayer::removeChild):
        (WebCore::RenderLayer::updateZOrderLists):
        (WebCore::RenderLayer::collectLayers):
        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::hasVisibleContent):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::setStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver.
mjs [Wed, 11 Oct 2006 07:15:20 +0000 (07:15 +0000)]
    Reviewed by Oliver.

        - added RetainPtr, smart pointer for refcounted ObjC objects and CFTypes

        * WebCore.xcodeproj/project.pbxproj:
        * platform/cf/RetainPtr.h: Added.
        (WTF::):
        (WTF::RetainPtr::RetainPtr):
        (WTF::RetainPtr::~RetainPtr):
        (WTF::RetainPtr::get):
        (WTF::RetainPtr::operator*):
        (WTF::RetainPtr::operator->):
        (WTF::RetainPtr::operator!):
        (WTF::RetainPtr::operator UnspecifiedBoolType):
        (WTF::::operator):
        (WTF::::swap):
        (WTF::swap):
        (WTF::operator==):
        (WTF::operator!=):
        (WTF::static_pointer_cast):
        (WTF::const_pointer_cast):
        (WTF::getPtr):

        - use it in WidgetMac so it gets tested in at least one place

        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::Widget):
        (WebCore::Widget::~Widget):
        (WebCore::Widget::setEnabled):
        (WebCore::Widget::isEnabled):
        (WebCore::Widget::setCursor):
        (WebCore::Widget::getView):
        (WebCore::Widget::setView):
        (WebCore::Widget::getOuterView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
beidson [Wed, 11 Oct 2006 06:35:47 +0000 (06:35 +0000)]
WebCore:

        Reviewed by Maciej.

        Moved WebFrameLoader from WebFrameBridge into WebCoreFrameBridge

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge initMainFrameWithPage:]):
        (-[WebCoreFrameBridge initSubframeWithOwnerElement:]):
        (-[WebCoreFrameBridge dealloc]):
        (-[WebCoreFrameBridge close]):
        (-[WebCoreFrameBridge setFrameLoaderClient:]):
        (-[WebCoreFrameBridge frameLoader]):
        * loader/mac/WebFrameLoader.h:
        * loader/mac/WebFrameLoader.mm:
        (-[WebFrameLoader initWithFrameBridge:]):
        (-[WebFrameLoader setFrameLoaderClient:]):

WebKit:

        Reviewed by Maciej.

        Moved WebFrameLoader into WebCoreFrameBridge

        * WebCoreSupport/WebFrameBridge.h:
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
        (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
        (-[WebFrameBridge dealloc]):
        (-[WebFrameBridge setTitle:]):
        (-[WebFrameBridge receivedData:textEncodingName:]):
        (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
        (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
        (-[WebFrameBridge objectLoadedFromCacheWithURL:response:data:]):
        (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
        (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
        (-[WebFrameBridge reportClientRedirectCancelled:]):
        (-[WebFrameBridge close]):
        (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
        (-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
        (-[WebFrameBridge tokenizerProcessedData]):
        (-[WebFrameBridge frameDetached]):
        (-[WebFrameBridge didFirstLayout]):
        (-[WebFrameBridge notifyIconChanged:]):
        (-[WebFrameBridge originalRequestURL]):
        (-[WebFrameBridge isLoadTypeReload]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
thatcher [Wed, 11 Oct 2006 04:39:44 +0000 (04:39 +0000)]
    Reviewed by Tim H.

        Bug 11246: Minor Drosera code cleanup
        http://bugs.webkit.org/show_bug.cgi?id=11246

        * Drosera/debugger.js: Change [has, add, remove]StyleClass to be a function on Element rather than taking an Element as an argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
thatcher [Wed, 11 Oct 2006 04:35:41 +0000 (04:35 +0000)]
    Reviewed by Tim H.

        Bug 9778: http://bugs.webkit.org/show_bug.cgi?id=9778

        * ChangeLog:
        * Drosera/Drosera.xcodeproj/project.pbxproj: Added files
        * Drosera/English.lproj/Debugger.nib/info.nib: Resized the main window and WebView
        * Drosera/English.lproj/Debugger.nib/keyedobjects.nib: Resized the main window and WebView
        * Drosera/Images/SourceArrowOpen.png: Added.
        * Drosera/Images/fileIcon.jpg: Added.
        * Drosera/Images/siteCollapsed.tif: Added.
        * Drosera/Images/siteExpanded.tif: Added.
        * Drosera/Images/siteIcon.tif: Added.
        * Drosera/debugger.css: Added File Browser styles
        * Drosera/debugger.html: Added File Browser UI
        * Drosera/debugger.js: Added File Browser functionality

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver.
aroben [Wed, 11 Oct 2006 04:33:24 +0000 (04:33 +0000)]
    Reviewed by Oliver.

        Make FileChooser ref-counted.

        * platform/FileChooser.h:
        * platform/mac/FileChooserMac.mm:
        (WebCore::FileChooser::create):
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::RenderFileUploadControl):
        (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
        * rendering/RenderFileUploadControl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
weinig [Wed, 11 Oct 2006 03:46:36 +0000 (03:46 +0000)]
    Reviewed by Tim H.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=11248
        Even More auto-generated Objective-C DOM bindings changes

        - Auto-generate DOMSVGPathElement.

        - Auto-generate the internal interfaces even for classes that have
          custom internal implementations.  Change IDL property from ObjCNoInternal
          to ObjCCustomInternalImpl to indicate the change.

        - Add SVG classes to DOMNode and DOMEvent internal interfaces.

        - Add isSVGZoomEvent() method to Event class to match other Event subclasses
          and make DOM binding possible.

        - Assorted cleanups.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOM.mm:
        (WebCore::addElementClass):
        (WebCore::createElementClassMap):
        (WebCore::elementClass):
        (-[DOMNode description]):
        (+[DOMNode _nodeWith:WebCore::]):
        (-[DOMNode addEventListener:listener:useCapture:]):
        (-[DOMNode removeEventListener:listener:useCapture:]):
        (-[DOMElement _NPObject]):
        (WebCore::ObjCEventListener::handleEvent):
        * bindings/objc/DOMEvents.mm:
        (+[DOMEvent _eventWith:WebCore::]):
        * bindings/objc/DOMInternal.h:
        * bindings/objc/DOMRGBColor.mm:
        (-[DOMRGBColor WebCore::]):
        * bindings/objc/DOMSVGPathSegInternal.h: Removed.
        * bindings/scripts/CodeGeneratorObjC.pm:
        * css/CSSRule.idl:
        * css/CSSValue.idl:
        * css/StyleSheet.idl:
        * dom/Event.cpp:
        (WebCore::Event::isSVGZoomEvent):
        * dom/Event.h:
        * dom/Event.idl:
        * dom/Node.idl:
        * ksvg2/events/SVGZoomEvent.cpp:
        (WebCore::SVGZoomEvent::isSVGZoomEvent):
        * ksvg2/events/SVGZoomEvent.h:
        * ksvg2/svg/SVGAnimatedAngle.idl:
        * ksvg2/svg/SVGCircleElement.idl:
        * ksvg2/svg/SVGClipPathElement.idl:
        * ksvg2/svg/SVGPathElement.idl:
        * ksvg2/svg/SVGPathSeg.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-10 Oliver Hunt <oliver@apple.com>
oliver [Wed, 11 Oct 2006 02:22:40 +0000 (02:22 +0000)]
2006-10-10  Oliver Hunt  <oliver@apple.com>

        rubber stamped by Anders.

        More buildbot bustage

        * kcanvas/SVGInlineFlowBox.cpp:
        (WebCore::placeBoxesVerticallyWithAbsBaseline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-10 Oliver Hunt <oliver@apple.com>
oliver [Wed, 11 Oct 2006 02:12:38 +0000 (02:12 +0000)]
2006-10-10  Oliver Hunt  <oliver@apple.com>

        Reviewed by Anders

        Unbreak build bots

        * dom/Text.cpp:
        * kcanvas/RenderSVGText.cpp:
        (WebCore::RenderSVGText::layout):
        * kcanvas/SVGInlineFlowBox.cpp:
        (WebCore::placePositionedBoxesHorizontally):
        (WebCore::placeBoxesVerticallyWithAbsBaseline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-10 Oliver Hunt <set EMAIL_ADDRESS environment variable>
oliver [Wed, 11 Oct 2006 01:28:02 +0000 (01:28 +0000)]
2006-10-10  Oliver Hunt  <set EMAIL_ADDRESS environment variable>

        Reviewed by hyatt.

        Fixes bugs #6423, #6559, #10380 and #10839

        * WebCore.xcodeproj/project.pbxproj:
        * css/svg.css:
        * dom/Text.cpp:
        (WebCore::Text::createRenderer):
        * kcanvas/RenderSVGInline.cpp: Added.
        (WebCore::RenderSVGInline::RenderSVGInline):
        (WebCore::RenderSVGInline::createInlineBox):
        * kcanvas/RenderSVGInline.h: Added.
        (WebCore::RenderSVGInline::renderName):
        (WebCore::RenderSVGInline::requiresLayer):
        * kcanvas/RenderSVGInlineText.cpp: Added.
        (WebCore::RenderSVGInlineText::RenderSVGInlineText):
        (WebCore::RenderSVGInlineText::absoluteRects):
        (WebCore::RenderSVGInlineText::selectionRect):
        * kcanvas/RenderSVGInlineText.h: Added.
        (WebCore::RenderSVGInlineText::renderName):
        (WebCore::RenderSVGInlineText::requiresLayer):
        * kcanvas/RenderSVGTSpan.cpp: Added.
        (WebCore::RenderSVGTSpan::RenderSVGTSpan):
        (WebCore::RenderSVGTSpan::absoluteRects):
        * kcanvas/RenderSVGTSpan.h: Added.
        (WebCore::RenderSVGTSpan::renderName):
        * kcanvas/RenderSVGText.cpp:
        (WebCore::RenderSVGText::RenderSVGText):
        (WebCore::RenderSVGText::computeAbsoluteRepaintRect):
        (WebCore::RenderSVGText::layout):
        (WebCore::RenderSVGText::createInlineBox):
        (WebCore::RenderSVGText::nodeAtPoint):
        (WebCore::RenderSVGText::absoluteRects):
        (WebCore::RenderSVGText::paint):
        (WebCore::RenderSVGText::relativeBBox):
        * kcanvas/RenderSVGText.h:
        (WebCore::RenderSVGText::renderName):
        * kcanvas/SVGInlineFlowBox.cpp: Added.
        (WebCore::SVGInlineFlowBox::paint):
        (WebCore::SVGInlineFlowBox::placeBoxesHorizontally):
        (WebCore::SVGInlineFlowBox::verticallyAlignBoxes):
        (WebCore::paintSVGInlineFlow):
        (WebCore::translateBox):
        (WebCore::placePositionedBoxesHorizontally):
        (WebCore::placeSVGFlowHorizontally):
        (WebCore::placeBoxesVerticallyWithAbsBaseline):
        (WebCore::placeSVGFlowVertically):
        * kcanvas/SVGInlineFlowBox.h: Added.
        (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
        * kcanvas/SVGRootInlineBox.cpp: Added.
        (WebCore::SVGRootInlineBox::paint):
        (WebCore::SVGRootInlineBox::placeBoxesHorizontally):
        (WebCore::SVGRootInlineBox::verticallyAlignBoxes):
        * kcanvas/SVGRootInlineBox.h: Added.
        (WebCore::SVGRootInlineBox::SVGRootInlineBox):
        * ksvg2/svg/SVGTRefElement.cpp:
        (SVGTRefElement::createRenderer):
        * ksvg2/svg/SVGTSpanElement.cpp:
        (SVGTSpanElement::createRenderer):
        * rendering/InlineFlowBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-10 Oliver Hunt <ohunt@apple.com>
oliver [Wed, 11 Oct 2006 01:26:57 +0000 (01:26 +0000)]
2006-10-10  Oliver Hunt  <ohunt@apple.com>

        Rubber stamped by Anders.

        Updated to deal with new svg text renderers, and
        updated result.

        custom/text-clip testcase was incorrect, and has been fixed

        * svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
        * svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
        * svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-22-b-expected.checksum:
        * svg/W3C-SVG-1.1/animate-elem-22-b-expected.png:
        * svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-27-t-expected.checksum:
        * svg/W3C-SVG-1.1/animate-elem-27-t-expected.png:
        * svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
        * svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
        * svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
        * svg/W3C-SVG-1.1/color-prop-02-f-expected.txt:
        * svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
        * svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
        * svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
        * svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
        * svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
        * svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
        * svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
        * svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
        * svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
        * svg/W3C-SVG-1.1/coords-units-03-b-expected.txt:
        * svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
        * svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
        * svg/W3C-SVG-1.1/extend-namespace-01-f-expected.checksum:
        * svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
        * svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
        * svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
        * svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
        * svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
        * svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
        * svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
        * svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
        * svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
        * svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
        * svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
        * svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
        * svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
        * svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
        * svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
        * svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
        * svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
        * svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
        * svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
        * svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
        * svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
        * svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
        * svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
        * svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
        * svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
        * svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
        * svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
        * svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
        * svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
        * svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
        * svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
        * svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
        * svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
        * svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
        * svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
        * svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
        * svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
        * svg/W3C-SVG-1.1/filters-turb-01-f-expected.checksum:
        * svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
        * svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
        * svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
        * svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
        * svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
        * svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
        * svg/W3C-SVG-1.1/interact-cursor-01-f-expected.checksum:
        * svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
        * svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
        * svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt:
        * svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
        * svg/W3C-SVG-1.1/interact-order-01-b-expected.txt:
        * svg/W3C-SVG-1.1/interact-order-02-b-expected.txt:
        * svg/W3C-SVG-1.1/interact-order-03-b-expected.txt:
        * svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
        * svg/W3C-SVG-1.1/linking-a-01-b-expected.txt:
        * svg/W3C-SVG-1.1/linking-a-02-b-expected.txt:
        * svg/W3C-SVG-1.1/linking-a-03-b-expected.txt:
        * svg/W3C-SVG-1.1/linking-a-04-t-expected.txt:
        * svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
        * svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
        * svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt:
        * svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
        * svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt:
        * svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
        * svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
        * svg/W3C-SVG-1.1/masking-path-03-b-expected.txt:
        * svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
        * svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
        * svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
        * svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt:
        * svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
        * svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt:
        * svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt:
        * svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
        * svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
        * svg/W3C-SVG-1.1/painting-render-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
        * svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
        * svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt:
        * svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt:
        * svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt:
        * svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
        * svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
        * svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
        * svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
        * svg/W3C-SVG-1.1/paths-data-04-t-expected.txt:
        * svg/W3C-SVG-1.1/paths-data-05-t-expected.txt:
        * svg/W3C-SVG-1.1/paths-data-06-t-expected.txt:
        * svg/W3C-SVG-1.1/paths-data-07-t-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
        * svg/W3C-SVG-1.1/render-elems-01-t-expected.txt:
        * svg/W3C-SVG-1.1/render-elems-02-t-expected.txt:
        * svg/W3C-SVG-1.1/render-elems-03-t-expected.txt:
        * svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
        * svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
        * svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
        * svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
        * svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
        * svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
        * svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
        * svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
        * svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
        * svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
        * svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
        * svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
        * svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt:
        * svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
        * svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
        * svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt:
        * svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt:
        * svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
        * svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt:
        * svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
        * svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt:
        * svg/W3C-SVG-1.1/struct-group-01-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-group-02-b-expected.txt:
        * svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
        * svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-image-05-b-expected.txt:
        * svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
        * svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
        * svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
        * svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
        * svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
        * svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
        * svg/W3C-SVG-1.1/text-align-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/text-align-01-b-expected.png:
        * svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-02-b-expected.checksum:
        * svg/W3C-SVG-1.1/text-align-02-b-expected.png:
        * svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-03-b-expected.checksum:
        * svg/W3C-SVG-1.1/text-align-03-b-expected.png:
        * svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-04-b-expected.checksum:
        * svg/W3C-SVG-1.1/text-align-04-b-expected.png:
        * svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-05-b-expected.checksum:
        * svg/W3C-SVG-1.1/text-align-05-b-expected.png:
        * svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-06-b-expected.checksum:
        * svg/W3C-SVG-1.1/text-align-06-b-expected.png:
        * svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
        * svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-deco-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
        * svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-fonts-01-t-expected.checksum:
        * svg/W3C-SVG-1.1/text-fonts-01-t-expected.png:
        * svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
        * svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
        * svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
        * svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-tselect-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/text-tselect-01-b-expected.png:
        * svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-tspan-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/text-tspan-01-b-expected.png:
        * svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
        * svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
        * svg/custom/baseval-animval-equality-expected.checksum:
        * svg/custom/baseval-animval-equality-expected.png:
        * svg/custom/coords-relative-units-transforms-expected.checksum:
        * svg/custom/coords-relative-units-transforms-expected.png:
        * svg/custom/coords-relative-units-transforms-expected.txt:
        * svg/custom/createelement-expected.txt:
        * svg/custom/feComponentTransfer-Discrete-expected.txt:
        * svg/custom/feComponentTransfer-Gamma-expected.txt:
        * svg/custom/feComponentTransfer-Linear-expected.txt:
        * svg/custom/feComponentTransfer-Table-expected.txt:
        * svg/custom/foreign-object-skew-expected.txt:
        * svg/custom/gradient-stroke-width-expected.txt:
        * svg/custom/image-with-transform-clip-filter-expected.txt:
        * svg/custom/invalid-css-expected.txt:
        * svg/custom/invalid-fill-expected.txt:
        * svg/custom/invalid-viewbox1-expected.txt:
        * svg/custom/invalid-viewbox2-expected.txt:
        * svg/custom/junk-data-expected.txt:
        * svg/custom/marker-overflow-clip-expected.txt:
        * svg/custom/missing-xlink-expected.txt:
        * svg/custom/non-opaque-filters-expected.txt:
        * svg/custom/pointer-events-path-expected.txt:
        * svg/custom/svg-overflow-types-expected.txt:
text-clip was an incorrect test, rather than an incorrect result
        * svg/custom/text-clip-expected.txt:
        * svg/custom/text-clip.svg:
        * svg/custom/text-filter-expected.txt:
        * svg/custom/text-gradient-no-content-expected.txt:
        * svg/custom/text-hit-test-expected.txt:
        * svg/custom/text-image-opacity-expected.txt:
        * svg/custom/tref-update-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
aroben [Tue, 10 Oct 2006 21:57:14 +0000 (21:57 +0000)]
    Reviewed by Adele.

        Improve popup menu behavior.

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::HTMLSelectElement): Cache
        m_lastOnChangeIndex so we know when to fire onChange.
        (WebCore::HTMLSelectElement::setSelectedIndex): Added parameter to
        specify whether we should fire onChange.
        (WebCore::HTMLSelectElement::dispatchBlurEvent): Fire onChange on blur.
        (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Fire
        onChange when using the Enter key to change the selection.
        * html/HTMLSelectElement.h:
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::updateFromElement): Extract setText logic
        into its own method.
        (WebCore::RenderMenuList::setTextFromOption): New method.
        (WebCore::RenderMenuList::valueChanged): Let setSelectedIndex call
        onChange instead of calling it directly here.
        * rendering/RenderMenuList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
adele [Tue, 10 Oct 2006 21:18:03 +0000 (21:18 +0000)]
WebCore:

        Reviewed by Beth.

        - Fix for <rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type=text>
          and <rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea

        Moved autoscroll code to the Frame class

        * bridge/mac/FrameMac.h: Moved _mouseDownMayStartDrag and _mouseDownMayStartAutoscroll flags to the frame.
        * bridge/mac/FrameMac.mm: Use new getters and setters for drag and autoscroll flags.  Moved autoscroll code to Frame::handleMouseMoveEvent.
        (WebCore::FrameMac::FrameMac):
        (WebCore::FrameMac::handleMousePressEvent):
        (WebCore::FrameMac::eventMayStartDrag):
        (WebCore::FrameMac::handleMouseMoveEvent):
        (WebCore::FrameMac::mouseDown):

        * bridge/mac/WebCoreFrameBridge.h: Removed handleAutoscrollForMouseDragged, which called over the bridge for AppKit to do autoscroll for us.
        Now we scroll our views in WebCore.

        * page/Frame.cpp:
        (WebCore::Frame::handleMousePressEvent): Initialize the mouseDownMayStartAutoscroll flag.
        (WebCore::Frame::handleMouseMoveEvent): Now kicks off autoscroll if appropriate.  Moved from FrameMac.
        (WebCore::Frame::updateSelectionForMouseDragOverPosition): Factored code out from handleMouseMoveEvent so we can update the selection from autoscroll too.
        (WebCore::Frame::mouseDownMayStartAutoscroll): Added.
        (WebCore::Frame::setMouseDownMayStartAutoscroll): Added.
        (WebCore::Frame::mouseDownMayStartDrag): Added.
        (WebCore::Frame::setMouseDownMayStartDrag): Added.
        (WebCore::Frame::autoscrollRenderer): Added
        (WebCore::Frame::setAutoscrollRenderer): Added.
        (WebCore::Frame::handleAutoscroll): Updated to use autoscrollRenderer getter and setter.
        (WebCore::Frame::autoscrollTimerFired): ditto.
        (WebCore::Frame::stopAutoscrollTimer): ditto.
        * page/Frame.h: Made autoscrollRenderer and stopAutoscrollTimer public, so the renderer being autoscrolled can kill the timer when it dies.

        * page/FramePrivate.h:
        (WebCore::FramePrivate::FramePrivate): Added mouseDownMayStartDrag and mouseDownMayStartAutoscroll flags.  Moved from FrameMac.

        * page/FrameView.cpp: Store the current mouse position in window coordinates.  The callers can convert to their own coordinate space.
        (WebCore::FrameView::handleMousePressEvent):
        (WebCore::FrameView::handleMouseDoubleClickEvent):
        (WebCore::FrameView::handleMouseMoveEvent):
        (WebCore::FrameView::handleMouseReleaseEvent):

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::autoscroll): Rewrote this to scroll recursively, and to scroll based on the mouse position (not the selection).
         We also need to update the selection here, since autoscroll can occur without a mouseMove event, and the selection needs to get reset as we scroll.

        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::autoscroll): Convert the mouse coordinates to the right space.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::shouldAutoscroll): Also return true if the renderer is a root (so we know to autoscroll views too)
        (WebCore::RenderObject::destroy): If this renderer is being autoscrolled, stop the frame's autoscroll timer.

WebKit:

        Reviewed by Beth.

        Removed handleAutoscrollForMouseDragged.  Except for autoscroll caused by drag and drop, all other
        autoscrolling should be done in WebCore instead of in AppKit.

        * WebCoreSupport/WebFrameBridge.m:
        * WebView/WebHTMLView.m:
        * WebView/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber stamped by Maciej.
darin [Tue, 10 Oct 2006 21:00:58 +0000 (21:00 +0000)]
    Rubber stamped by Maciej.

        - convert many of the loader source files to Objective-C++ to prepare
          to convert some of them to C++

        * WebCore.xcodeproj/project.pbxproj:
        * loader/mac/WebDataProtocol.m: Removed.
        * loader/mac/WebDocumentLoader.m: Removed.
        * loader/mac/WebFormState.m: Removed.
        * loader/mac/WebFrameLoader.m: Removed.
        * loader/mac/WebLoader.m: Removed.
        * loader/mac/WebMainResourceLoader.m: Removed.
        * loader/mac/WebNetscapePlugInStreamLoader.m: Removed.
        * loader/mac/WebPolicyDecider.m: Removed.
        * loader/mac/WebSubresourceLoader.m: Removed.
        * loader/mac/WebDataProtocol.mm: Added.
        * loader/mac/WebDocumentLoader.mm: Added.
        * loader/mac/WebFormState.mm: Added.
        * loader/mac/WebFrameLoader.mm: Added.
        * loader/mac/WebLoader.mm: Added.
        * loader/mac/WebMainResourceLoader.mm: Added.
        * loader/mac/WebNetscapePlugInStreamLoader.mm: Added.
        * loader/mac/WebPolicyDecider.mm: Added.
        * loader/mac/WebSubresourceLoader.mm: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * Scripts/do-file-rename: Added.
darin [Tue, 10 Oct 2006 21:00:39 +0000 (21:00 +0000)]
    * Scripts/do-file-rename: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
mjs [Tue, 10 Oct 2006 20:10:15 +0000 (20:10 +0000)]
    Reviewed by Mitz.

        - fixed REGRESSION (r16960): crash on navigating to site
        http://www.zoominfo.com/Search/CompanyDetail.aspx?CompanyID=62948057&cs=QGDwILZIE

        * loader/mac/WebFrameLoader.m:
        (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
        Add back a mistakenly removed retain.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - corrected an archive regression caused by loader refactoring
darin [Tue, 10 Oct 2006 17:01:12 +0000 (17:01 +0000)]
    - corrected an archive regression caused by loader refactoring
          (pointed out by Graham Dennis)

        * WebView/WebFrame.m: (-[WebFrame _deliverArchivedResourcesAfterDelay]):
        Fix selector name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Not reviewed, build fix.
mjs [Tue, 10 Oct 2006 11:03:26 +0000 (11:03 +0000)]
    Not reviewed, build fix.

        - fixed release build

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mjs [Tue, 10 Oct 2006 10:48:28 +0000 (10:48 +0000)]
WebCore:

        Rubber stamped by Eric.

        - moved a big honkin' pile of code over from WebKit; made minimal needed changes to compile

        * WebCore.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * loader/mac/LoaderNSURLExtras.m: Added.
        * loader/mac/WebDataProtocol.m: Added.
        * loader/mac/WebDocumentLoader.m: Added.
        * loader/mac/WebFormDataStream.m: Added.
        * loader/mac/WebFrameLoader.m: Added.
        * loader/mac/WebLoader.m: Added.
        (-[NSURLProtocol didReceiveResponse:]):
        (-[NSURLProtocol didReceiveData:lengthReceived:allAtOnce:]):
        * loader/mac/WebMainResourceLoader.m: Added.
        (-[WebMainResourceLoader didReceiveResponse:]):
        * loader/mac/WebPolicyDecider.m: Added.
        * loader/mac/WebSubresourceLoader.h: Added.
        * loader/mac/WebSubresourceLoader.m: Added.

WebKit:

        Rubber stamped by Eric.

        - moved a whole bunch of stuff over to WebCore - updated includes appropriately

        * Loader/LoaderNSURLExtras.h: Removed.
        * Loader/LoaderNSURLExtras.m: Removed.
        * Loader/WebDataProtocol.h: Removed.
        * Loader/WebDataProtocol.m: Removed.
        * Loader/WebDocumentLoader.h: Removed.
        * Loader/WebDocumentLoader.m: Removed.
        * Loader/WebFormDataStream.h: Removed.
        * Loader/WebFormDataStream.m: Removed.
        * Loader/WebFormState.h: Removed.
        * Loader/WebFormState.m: Removed.
        * Loader/WebFrameLoader.h: Removed.
        * Loader/WebFrameLoader.m: Removed.
        * Loader/WebFrameLoaderClient.h: Removed.
        * Loader/WebLoader.h: Removed.
        * Loader/WebLoader.m: Removed.
        * Loader/WebMainResourceLoader.h: Removed.
        * Loader/WebMainResourceLoader.m: Removed.
        * Loader/WebNetscapePlugInStreamLoader.h: Removed.
        * Loader/WebNetscapePlugInStreamLoader.m: Removed.
        * Loader/WebPlugInStreamLoaderDelegate.h: Removed.
        * Loader/WebPolicyDecider.h: Removed.
        * Loader/WebPolicyDecider.m: Removed.
        * Loader/WebSubresourceLoader.h: Removed.
        * Loader/WebSubresourceLoader.m: Removed.
        * Misc/WebNSURLExtras.m:
        * Plugins/WebBaseNetscapePluginStream.h:
        * Plugins/WebBaseNetscapePluginView.m:
        * Plugins/WebNetscapePluginStream.m:
        * Plugins/WebPluginContainerCheck.m:
        * Plugins/WebPluginController.m:
        * WebCoreSupport/WebFrameBridge.m:
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebDataSource.m:
        * WebView/WebDocumentLoaderMac.h:
        * WebView/WebFrame.m:
        * WebView/WebFrameInternal.h:
        * WebView/WebHTMLView.m:
        * WebView/WebPolicyDeciderMac.h:
        * WebView/WebPolicyDelegate.m:
        * WebView/WebView.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-10 Mark Rowe <bdash@webkit.org>
bdash [Tue, 10 Oct 2006 10:38:53 +0000 (10:38 +0000)]
2006-10-10  Mark Rowe  <bdash@webkit.org>

        Reviewed by Maciej.

        Fix crash on launch in nightly builds after r16965.

        Safari will sometimes call through to -[NSURL _webkit_canonicalize] before creating a WebView.  If this happens,
        InitWebCoreSystemInterface has not yet been called so the call to wkNSURLProtocolClassForReqest is via a garbage
        pointer.

        * Misc/WebNSURLExtras.m:
        (-[NSURL _webkit_canonicalize]): Ensure InitWebCoreSystemInterface is called prior to canonicalURL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver (sort of?)
mjs [Tue, 10 Oct 2006 09:49:12 +0000 (09:49 +0000)]
    Reviewed by Oliver (sort of?)

        - WebCore part of moving down NSURL extras

        * WebCore.exp:
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver.
mjs [Tue, 10 Oct 2006 09:44:50 +0000 (09:44 +0000)]
    Reviewed by Oliver.

        - split out some NSURL extras to be moved to WebCore

        * Loader/LoaderNSURLExtras.h: Added.
        * Loader/LoaderNSURLExtras.m: Added.
        (urlByRemovingComponent):
        (urlByRemovingFragment):
        (urlOriginalDataAsString):
        (urlOriginalData):
        (urlWithData):
        (WebCFAutorelease):
        (urlWithDataRelativeToURL):
        (urlByRemovingResourceSpecifier):
        (urlIsFileURL):
        (stringIsFileURL):
        (urlIsEmpty):
        (canonicalURL):
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader shouldReloadForCurrent:andDestination:]):
        (setHTTPReferrer):
        (-[WebFrameLoader commitProvisionalLoad:]):
        (-[WebFrameLoader _notifyIconChanged:]):
        (-[WebFrameLoader didChangeTitleForDocument:]):
        (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
        (-[WebFrameLoader safeLoadURL:]):
        * Misc/WebNSURLExtras.m:
        (+[NSURL _web_URLWithData:]):
        (+[NSURL _web_URLWithData:relativeToURL:]):
        (-[NSURL _web_originalData]):
        (-[NSURL _web_originalDataAsString]):
        (-[NSURL _web_isEmpty]):
        (-[NSURL _webkit_canonicalize]):
        (-[NSURL _webkit_URLByRemovingComponent:]):
        (-[NSURL _webkit_URLByRemovingFragment]):
        (-[NSURL _webkit_URLByRemovingResourceSpecifier]):
        (-[NSURL _webkit_isFileURL]):
        (-[NSString _webkit_isFileURL]):
        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface):
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
rwlbuis [Tue, 10 Oct 2006 08:42:18 +0000 (08:42 +0000)]
    Reviewed by Mitz.

        http://bugs.webkit.org/show_bug.cgi?id=11217
        Cleanup svg coding style

        Cleanup coding style in svg animation classes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver.
mjs [Tue, 10 Oct 2006 08:06:57 +0000 (08:06 +0000)]
    Reviewed by Oliver.

        - added isMainFrame and frameLoader to WebCoreFrameBridge for ease of future code motion

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge isMainFrame]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
mjs [Tue, 10 Oct 2006 06:51:49 +0000 (06:51 +0000)]
    Reviewed by Anders.

        - sever final WebFrame dependencies

        * Loader/WebFrameLoader.h:
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader initWithFrame:client:]):
        (-[WebFrameLoader defersCallbacksChanged]):
        (-[WebFrameLoader subframeIsLoading]):
        (-[WebFrameLoader transitionToCommitted:]):
        (-[WebFrameLoader detachChildren]):
        (-[WebFrameLoader checkLoadComplete]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady.
mjs [Tue, 10 Oct 2006 06:12:56 +0000 (06:12 +0000)]
    Reviewed by Brady.

        - convert more WebFrameLoader stuff to be independent of WebFrame

        * Loader/WebFrameLoader.h:
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader stopLoadingSubframes]):
        (-[WebFrameLoader _receivedMainResourceError:complete:]):
        (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
        (-[WebFrameLoader closeOldDataSources]):
        (-[WebFrameLoader isHostedByObjectElement]):
        (-[WebFrameLoader isLoadingMainFrame]):
        (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
        (-[WebFrameLoader transitionToCommitted:]):
        (-[WebFrameLoader checkLoadCompleteForThisFrame]):
        (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
        (-[WebFrameLoader loadRequest:inFrameNamed:]):
        (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
        (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]):
        (-[WebFrameLoader client]):
        * Loader/WebFrameLoaderClient.h:
        * WebView/WebDataSource.m:
        (-[WebDataSource _webView]):
        (-[WebDataSource webFrame]):
        * WebView/WebFrame.m:
        (-[WebFrame _dispatchCreateWebViewWithRequest:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders and Oliver.
mjs [Tue, 10 Oct 2006 05:14:44 +0000 (05:14 +0000)]
    Reviewed by Anders and Oliver.

        - move a bunch of WebFrame methods from the Internal category to the WebFrameLoader protocol

        * Loader/WebFrameLoader.h:
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader loadRequest:]):
        (-[WebFrameLoader loadRequest:inFrameNamed:]):
        * Loader/WebFrameLoaderClient.h:
        * WebView/WebFrame.m:
        (-[WebFrame loadRequest:]):
        (-[WebFrame _dispatchDidCommitLoadForFrame]):
        (-[WebFrame _hasFrameView]):
        (-[WebFrame _frameLoadCompleted]):
        (-[WebFrame _restoreScrollPositionAndViewState]):
        (-[WebFrame _setTitle:forURL:]):
        (-[WebFrame _createDocumentLoaderWithRequest:]):
        (-[WebFrame _prepareForDataSourceReplacement]):
        (-[WebFrame _didFinishLoad]):
        (-[WebFrame _addHistoryItemForFragmentScroll]):
        (-[WebFrame _shouldTreatURLAsSameAsCurrent:]):
        (-[WebFrame _provisionalLoadStarted]):
        * WebView/WebFrameInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Not reviewed, build fix.
mjs [Tue, 10 Oct 2006 03:16:24 +0000 (03:16 +0000)]
    Not reviewed, build fix.

        - added forgotten files

        * Loader/WebPolicyDecider.h: Added.
        * Loader/WebPolicyDecider.m: Added.
        (-[WebPolicyDecider invalidate]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady.
mjs [Tue, 10 Oct 2006 02:41:03 +0000 (02:41 +0000)]
    Reviewed by Brady.

        - add wrapper for WebPolicyDecisionListener so we can remove the dependency from WebFrameLoader.

        * Loader/WebFrameLoader.h:
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]):
        (-[WebFrameLoader cancelContentPolicy]):
        (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]):
        (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
        (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
        (-[WebFrameLoader continueAfterWillSubmitForm:]):
        (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
        * Loader/WebFrameLoaderClient.h:
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebFrame.m:
        (-[WebFrame _createPolicyDeciderWithTarget:action:]):
        (decisionListener):
        (-[WebFrame _dispatchDecidePolicyForMIMEType:request:decider:]):
        (-[WebFrame _dispatchDecidePolicyForNewWindowAction:request:newFrameName:decider:]):
        (-[WebFrame _dispatchDecidePolicyForNavigationAction:request:decider:]):
        (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
        * WebView/WebPolicyDeciderMac.h: Added.
        * WebView/WebPolicyDeciderMac.m: Added.
        (-[WebPolicyDeciderMac initWithTarget:action:]):
        (-[WebPolicyDeciderMac dealloc]):
        (-[WebPolicyDeciderMac decisionListener]):
        (-[WebPolicyDeciderMac invalidate]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John
beidson [Tue, 10 Oct 2006 02:10:48 +0000 (02:10 +0000)]
    Reviewed by John

        http://bugs.webkit.org/show_bug.cgi?id=11195
        Added the WebIconDatabaseDelegate.  This allows the ability to allow customization of
        IconDatabase behavior in the future, starting now with the ability to override the
        default icon fairly flexibly

        * Misc/WebIconDatabase.h: Added setIconDatabaseDelegate:
        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase iconForURL:withSize:cache:]): Call the delegate for the default icon if delegate is set
        (-[WebIconDatabase defaultIconForURL:withSize:]): Get the default icon through the delegate if available, built-in if not
        (-[WebIconDatabase setDelegate:]):
        (-[WebIconDatabase delegate]):
        * Misc/WebIconDatabaseDelegate.h: Added.
        * Misc/WebIconDatabasePrivate.h: Added the delegate, nuked an unused class definition
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Backing out accidental commit.
aroben [Tue, 10 Oct 2006 01:52:20 +0000 (01:52 +0000)]
    Backing out accidental commit.

        * page/Frame.cpp:
        (WebCore::Frame::finishedParsing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
aroben [Tue, 10 Oct 2006 01:49:26 +0000 (01:49 +0000)]
    Reviewed by Darin.

        Add ASSERTs to RefPtr to make sure we don't ref within a destructor, as
        this could cause recursive calls to the destructor. RefPtr now also
        inherits from Noncopyable.

        * dom/NodeFilter.h:
        * dom/Traversal.h:
        * page/DOMWindow.h:
        * page/Frame.cpp:
        (WebCore::Frame::finishedParsing):
        * page/Frame.h:
        * page/Plugin.h:
        * platform/FontFallbackList.h:
        * platform/Icon.h:
        * platform/Shared.h:
        (WebCore::Shared::Shared):
        (WebCore::Shared::ref):
        (WebCore::Shared::deref):
        (WebCore::Shared::hasOneRef):
        (WebCore::Shared::refCount):
        * platform/StringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
darin [Tue, 10 Oct 2006 01:30:35 +0000 (01:30 +0000)]
    Reviewed by Maciej.

        - eliminated uses of WebResource and WebView from WebFrameLoader

        * Loader/WebFrameLoader.h:
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader setDefersCallbacks:]):
        (-[WebFrameLoader stopLoading]):
        (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
        (-[WebFrameLoader archiveLoadPendingForLoader:]):
        (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
        (-[WebFrameLoader _canShowMIMEType:]):
        (-[WebFrameLoader _representationExistsForURLScheme:]):
        (-[WebFrameLoader _generatedMIMETypeForURLScheme:]):
        (-[WebFrameLoader loadDocumentLoader:]):
        (-[WebFrameLoader continueAfterNavigationPolicy:]):
        (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
        (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]):
        * Loader/WebFrameLoaderClient.h:
        * Loader/WebMainResourceLoader.m:
        (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
        (-[WebMainResourceLoader loadWithRequestNow:]):
        * WebView/WebFrame.m:
        (-[WebFramePrivate dealloc]):
        (-[WebFrame loadRequest:]):
        (-[WebFrame loadArchive:]):
        (-[WebFrame _canUseResourceForRequest:]):
        (-[WebFrame _canUseResourceWithResponse:]):
        (-[WebFrame _deliverArchivedResourcesAfterDelay]):
        (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]):
        (-[WebFrame _archiveLoadPendingForLoader:]):
        (-[WebFrame _cancelPendingArchiveLoadForLoader:]):
        (-[WebFrame _clearArchivedResources]):
        (-[WebFrame _deliverArchivedResources]):
        (-[WebFrame _setDefersCallbacks:]):
        (-[WebFrame _canHandleRequest:]):
        (-[WebFrame _canShowMIMEType:]):
        (-[WebFrame _representationExistsForURLScheme:]):
        (-[WebFrame _generatedMIMETypeForURLScheme:]):
        (-[WebFrame _elementForEvent:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-09 Oliver Hunt <ohunt@apple.com>
oliver [Tue, 10 Oct 2006 01:09:52 +0000 (01:09 +0000)]
2006-10-09  Oliver Hunt <ohunt@apple.com>

        Reviewed by Anders.

        Correcting ifdef's

        * html/CanvasGradient.cpp:
        (WebCore::CanvasGradient::CanvasGradient):
        (WebCore::CanvasGradient::~CanvasGradient):
        (WebCore::CanvasGradient::addColorStop):
        * html/CanvasGradient.h:
        * html/CanvasPattern.cpp:
        (WebCore::CanvasPattern::CanvasPattern):
        (WebCore::CanvasPattern::~CanvasPattern):
        * html/CanvasPattern.h:
        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::fill):
        (WebCore::CanvasRenderingContext2D::stroke):
        (WebCore::CanvasRenderingContext2D::fillRect):
        (WebCore::CanvasRenderingContext2D::setShadow):
        (WebCore::CanvasRenderingContext2D::applyShadow):
        (WebCore::CanvasRenderingContext2D::drawImage):
        (WebCore::CanvasRenderingContext2D::createPattern):
        (WebCore::CanvasRenderingContext2D::applyStrokePattern):
        (WebCore::CanvasRenderingContext2D::applyFillPattern):
        * html/CanvasRenderingContext2D.h:
        * html/CanvasStyle.cpp:
        (WebCore::CanvasStyle::applyStrokeColor):
        (WebCore::CanvasStyle::applyFillColor):
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::paint):
        (WebCore::HTMLCanvasElement::createDrawingContext):
        * html/HTMLCanvasElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
mjs [Tue, 10 Oct 2006 01:04:22 +0000 (01:04 +0000)]
    Reviewed by Darin.

        - do all the stuff that setting the referrer should

        * Loader/WebFrameLoader.m:
        (setHTTPReferrer):
        (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
        (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
mjs [Tue, 10 Oct 2006 00:53:10 +0000 (00:53 +0000)]
    Reviewed by Darin.

        - test case that ensures Referer[sic] header is sent

        * http/tests/misc/referrer-expected.txt: Added.
        * http/tests/misc/referrer.html: Added.
        * http/tests/misc/resources/referrer-result.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
aroben [Mon, 9 Oct 2006 23:57:55 +0000 (23:57 +0000)]
    Reviewed by Maciej.

        Fix a possible recursive destructor call.

        * page/Frame.cpp:
        (WebCore::Frame::~Frame): Add a FIXME about cleaning up the destructor.
        (WebCore::Frame::finishedParsing): Don't create a protector RefPtr if
        we're already being destroyed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
weinig [Mon, 9 Oct 2006 23:49:21 +0000 (23:49 +0000)]
    Reviewed by Tim H.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=11234
        Assorted Objective-C bindings changes

        - Auto-generate DOMSVGPathSegArcAbs, DOMSVGPathSegArcRel, DOMSVGPathSegClosePath,
          DOMSVGPathSegCurvetoCubicAbs, DOMSVGPathSegCurvetoCubicRel,
          DOMSVGPathSegCurvetoCubicSmoothAbs, DOMSVGPathSegCurvetoCubicSmoothRel,
          DOMSVGPathSegCurvetoQuadraticAbs, DOMSVGPathSegCurvetoQuadraticRel,
          DOMSVGPathSegCurvetoQuadraticSmoothAbs, DOMSVGPathSegCurvetoQuadraticSmoothRel,
          DOMSVGPathSegLinetoAbs, DOMSVGPathSegLinetoHorizontalAbs,
          DOMSVGPathSegLinetoHorizontalRel, DOMSVGPathSegLinetoRel,
          DOMSVGPathSegLinetoVerticalAbs, DOMSVGPathSegLinetoVerticalRel,
          DOMSVGPathSegMovetoAbs, DOMSVGPathSegMovetoRel and DOMSVGSVGElement.

        - Auto-generate absoluteImageURL method for DOMHTMLInputElement and
          DOMHTMLObjectElement.

        - Auto-generate the internal methods for classes with ivars (notably
          DOMNodeIterator and DOMTreeWalker)

        - Put more methods in the WebCore namespace and factor out the
          displayString method into DOMInternal.h as done by Darin in his
          patch for http://bugs.webkit.org/show_bug.cgi?id=11219.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOM.mm:
        (-[DOMNode _initWithNode:WebCore::]):
        (+[DOMNode _nodeWith:WebCore::]):
        (-[DOMNode addEventListener:listener:useCapture:]):
        (-[DOMNode removeEventListener:listener:useCapture:]):
        (-[DOMNode dispatchEvent:]):
        (-[DOMElement _imageTIFFRepresentation]):
        (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
        (+[DOMNodeFilter _nodeFilterWith:WebCore::]):
        (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
        (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
        * bindings/objc/DOMCSS.mm:
        (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
        (+[DOMStyleSheet _styleSheetWith:WebCore::]):
        (-[DOMCSSRule _initWithCSSRule:WebCore::]):
        (+[DOMCSSRule _CSSRuleWith:WebCore::]):
        (-[DOMCSSValue _initWithCSSValue:WebCore::]):
        (+[DOMCSSValue _CSSValueWith:WebCore::]):
        * bindings/objc/DOMEvents.mm:
        (-[DOMEvent _initWithEvent:WebCore::]):
        (+[DOMEvent _eventWith:WebCore::]):
        * bindings/objc/DOMExtensions.h:
        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
        * bindings/objc/DOMInternal.h:
        (-[DOMNodeFilter WebCore::]):
        * bindings/objc/DOMInternal.mm:
        (-[WebScriptObject _init]):
        (-[WebScriptObject _initializeScriptDOMNodeImp]):
        (WebCore::displayString):
        * bindings/objc/DOMObject.mm:
        (-[DOMObject dealloc]):
        (-[DOMObject finalize]):
        * bindings/objc/DOMRGBColor.mm:
        (-[DOMRGBColor dealloc]):
        (-[DOMRGBColor finalize]):
        (-[DOMRGBColor color]):
        (-[DOMRGBColor _initWithRGB:WebCore::]):
        (+[DOMRGBColor _RGBColorWithRGB:WebCore::]):
        * bindings/objc/DOMSVG.h:
        * bindings/objc/DOMSVGPathSegInternal.h: Added.
        * bindings/objc/DOMSVGPathSegInternal.mm: Added.
        (-[DOMSVGPathSeg WebCore::]):
        (-[DOMSVGPathSeg _initWithSVGPathSeg:WebCore::]):
        (+[DOMSVGPathSeg _SVGPathSegWith:WebCore::]):
        * bindings/objc/DOMXPath.mm:
        (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
        (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]):
        * bindings/objc/PublicDOMInterfaces.h:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * dom/NodeIterator.idl:
        * dom/TreeWalker.idl:
        * html/HTMLInputElement.idl:
        * html/HTMLObjectElement.idl:
        * ksvg2/svg/SVGDocument.idl:
        * ksvg2/svg/SVGElement.idl:
        * ksvg2/svg/SVGPathSeg.idl:
        * ksvg2/svg/SVGPathSegArcAbs.idl:
        * ksvg2/svg/SVGPathSegArcRel.idl:
        * ksvg2/svg/SVGPathSegClosePath.idl:
        * ksvg2/svg/SVGPathSegCurvetoCubicAbs.idl:
        * ksvg2/svg/SVGPathSegCurvetoCubicRel.idl:
        * ksvg2/svg/SVGPathSegCurvetoCubicSmoothAbs.idl:
        * ksvg2/svg/SVGPathSegCurvetoCubicSmoothRel.idl:
        * ksvg2/svg/SVGPathSegCurvetoQuadraticAbs.idl:
        * ksvg2/svg/SVGPathSegCurvetoQuadraticRel.idl:
        * ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl:
        * ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl:
        * ksvg2/svg/SVGPathSegLinetoAbs.idl:
        * ksvg2/svg/SVGPathSegLinetoHorizontalAbs.idl:
        * ksvg2/svg/SVGPathSegLinetoHorizontalRel.idl:
        * ksvg2/svg/SVGPathSegLinetoRel.idl:
        * ksvg2/svg/SVGPathSegLinetoVerticalAbs.idl:
        * ksvg2/svg/SVGPathSegLinetoVerticalRel.idl:
        * ksvg2/svg/SVGPathSegMovetoAbs.idl:
        * ksvg2/svg/SVGPathSegMovetoRel.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-09 Don Gibson <dgibson77@gmail.com>
bdash [Mon, 9 Oct 2006 23:28:47 +0000 (23:28 +0000)]
2006-10-09  Don Gibson  <dgibson77@gmail.com>

        Unreviewed build fix.

        Fix windows build bustage.

        * platform/win/TemporaryLinkStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-09 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
bdash [Mon, 9 Oct 2006 23:08:47 +0000 (23:08 +0000)]
2006-10-09  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>

        Reviewed by Geoff.

        Improve gdk build compiler flags (show warning, no rtti and exceptions).

        * jscore.bkl:

2006-10-09  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>

        Reviewed by Geoff.

        Improve gdk build compiler options.

        * Bakefiles.bkgen:
        * presets.bkl:

2006-10-09  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>

        Reviewed by Geoff.

        Fix memory leaks discovered via valgrind. Gdk build fixes.

        * Projects/gdk/webcore-gdk.bkl:
        * make-generated-sources.sh:
        * platform/cairo/ImageCairo.cpp:
        (WebCore::Image::draw):
        * platform/gdk/FrameGdk.cpp:
        (WebCore::FrameGdk::handleGdkEvent):
        * platform/gdk/FrameGdk.h:
        * platform/gdk/PlatformScrollBar.h:
        (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
        (WebCore::PlatformScrollbar::verticalScrollbarWidth):

2006-10-09  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>

        Reviewed by Geoff.

        Add -exit-after-loading option to make gdklauncher quit after fully loading and rendering
        a page. This allows automatic testing via e.g. valgrind.

        * GdkLauncher/gdklauncher.bkl:
        * GdkLauncher/main.cpp:
        (LauncherFrameGdk::LauncherFrameGdk):
        (LauncherFrameGdk::setExitAfterLoading):
        (LauncherFrameGdk::handledOnloadEvents):
        (handle_event):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-09 Nikolas Zimmermann <zimmermann@kde.org>
bdash [Mon, 9 Oct 2006 22:36:46 +0000 (22:36 +0000)]
2006-10-09  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by Beth.

        Fix LayoutTests/fast/css/case-transform.html with Qt - the last crashing layout test.

        * platform/qt/GlyphMapQt.cpp: Handle UTF-16 characters properly
        (WebCore::GlyphMap::fillPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-09 Nikolas Zimmermann <zimmermann@kde.org>
bdash [Mon, 9 Oct 2006 22:34:45 +0000 (22:34 +0000)]
2006-10-09  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by Oliver.

        Use log() instead of alert() just like in all other tests.

        * editing/selection/move-begin-end.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-09 Nikolas Zimmermann <zimmermann@kde.org>
bdash [Mon, 9 Oct 2006 22:30:40 +0000 (22:30 +0000)]
2006-10-09  Nikolas Zimmermann  <zimmermann@kde.org>

        Unreviewed build fix.

        Fix for Qt/Linux build, based on fixes to the Win32 build in r16928 and r16929.

        * platform/qt/FrameQt.cpp:
        (WebCore::FrameQt::createJavaAppletWidget):
        * platform/qt/FrameQt.h:
        * platform/qt/TemporaryLinkStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
beidson [Mon, 9 Oct 2006 22:24:19 +0000 (22:24 +0000)]
WebCore:

        Reviewed by Maciej

        Tiny changes to help reorganize WebFrameLoader code in WebKit

        * bridge/mac/WebCoreIconDatabaseBridge.h: Added "createInstance"
        * bridge/mac/WebCoreIconDatabaseBridge.mm:
        (+[WebCoreIconDatabaseBridge sharedInstance]): Added, uses createInstance from WebKit side

WebKit:

        Reviewed by Maciej

        Fix to elminate WebIconDatabaseBridge.h from WebFrameLoader

        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader _notifyIconChanged:]):
        * WebCoreSupport/WebIconDatabaseBridge.m:
        (+[WebIconDatabaseBridge createInstance]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
mjs [Mon, 9 Oct 2006 21:44:55 +0000 (21:44 +0000)]
    Reviewed by Darin.

        (Was reviewed as part of a larger patch but it looks like Darin already did the rest of it)

        - avoid a needless use of WebFrame

        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago A *real* fake fix for the layouttest problem until the real fix
beidson [Mon, 9 Oct 2006 20:27:44 +0000 (20:27 +0000)]
    A *real* fake fix for the layouttest problem until the real fix

        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader _notifyIconChanged:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Quick layouttest fix until I make the real fix
beidson [Mon, 9 Oct 2006 20:15:10 +0000 (20:15 +0000)]
    Quick layouttest fix until I make the real fix

        * Loader/WebFrameLoader.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
mjs [Mon, 9 Oct 2006 20:06:26 +0000 (20:06 +0000)]
    Reviewed by Darin.

        - wean WebFrameLoader from WebDataSource private stuff

        (actually just tweaks tot he above to make merging my future
        patches easier since Darin did a lot of the same stuff)

        * Loader/WebDocumentLoader.h:
        * Loader/WebDocumentLoader.m:
        (-[WebDocumentLoader URLForHistory]):
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader _loadRequest:archive:]):
        (-[WebFrameLoader revertToProvisionalWithDocumentLoader:]):
        (-[WebFrameLoader documentLoader:setMainDocumentError:]):
        (-[WebFrameLoader finalSetupForReplaceWithDocumentLoader:]):
        (-[WebFrameLoader didChangeTitleForDocument:]):
        (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
        * Loader/WebFrameLoaderClient.h:
        * WebView/WebDataSource.m:
        (-[WebDataSource _URLForHistory]):
        * WebView/WebFrame.m:
        (-[WebFrame _addDocumentLoader:toUnarchiveState:]):
        (-[WebFrame _revertToProvisionalStateForDocumentLoader:]):
        (-[WebFrame _setMainDocumentError:forDocumentLoader:]):
        (-[WebFrame _clearUnarchivingStateForLoader:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady.
darin [Mon, 9 Oct 2006 19:31:27 +0000 (19:31 +0000)]
    Reviewed by Brady.

        - eliminated WebFrameLoader dependency on WebDataSourceInternal.h,
          WebIconDatabasePrivate.h, and WebKitErrorsPrivate.h, along with
          most but not all references to WebView

        * Loader/WebFrameLoader.h:
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader removePlugInStreamLoader:]):
        (-[WebFrameLoader _receivedMainResourceError:complete:]):
        (-[WebFrameLoader _notifyIconChanged:]):
        (-[WebFrameLoader cancelledErrorWithRequest:]):
        (-[WebFrameLoader fileDoesNotExistErrorWithResponse:]):
        (-[WebFrameLoader handleUnimplementablePolicyWithError:]):
        (-[WebFrameLoader cannotShowMIMETypeWithResponse:]):
        (-[WebFrameLoader interruptForPolicyChangeErrorWithRequest:]):
        (-[WebFrameLoader _loadRequest:archive:]):
        (-[WebFrameLoader finishedLoadingDocument:]):
        (-[WebFrameLoader committedLoadWithDocumentLoader:data:]):
        (-[WebFrameLoader revertToProvisionalWithDocumentLoader:]):
        (-[WebFrameLoader documentLoader:setMainDocumentError:]):
        (-[WebFrameLoader finalSetupForReplaceWithDocumentLoader:]):
        (-[WebFrameLoader didChangeTitleForDocument:]):
        (-[WebFrameLoader continueAfterNavigationPolicy:]):
        (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
        (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
        (-[WebFrameLoader transitionToCommitted:]):
        (-[WebFrameLoader checkLoadCompleteForThisFrame]):
        (-[WebFrameLoader requestFromDelegateForRequest:identifier:error:]):
        (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
        (-[WebFrameLoader checkLoadComplete]):
        * Loader/WebFrameLoaderClient.h:
        * Loader/WebMainResourceLoader.m:
        (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
        * WebView/WebFrame.m:
        (-[WebFrame _addDocumentLoader:toUnarchiveState:]):
        (-[WebFrame _formDelegate]):
        (-[WebFrame _finishedLoadingDocument:]):
        (-[WebFrame _committedLoadWithDocumentLoader:data:]):
        (-[WebFrame _revertToProvisionalWithDocumentLoader:]):
        (-[WebFrame _documentLoader:setMainDocumentError:]):
        (-[WebFrame _finalSetupForReplaceWithDocumentLoader:]):
        (-[WebFrame _URLForHistoryForDocumentLoader:]):
        (-[WebFrame _cancelledErrorWithRequest:]):
        (-[WebFrame _cannotShowURLErrorWithRequest:]):
        (-[WebFrame _interruptForPolicyChangeErrorWithRequest:]):
        (-[WebFrame _cannotShowMIMETypeErrorWithResponse:]):
        (-[WebFrame _fileDoesNotExistErrorWithResponse:]):
        (-[WebFrame _shouldFallBackForError:]):
        (-[WebFrame _hasWebView]):
        (-[WebFrame _mainFrameURL]):
        * WebView/WebFrameInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix.
thatcher [Mon, 9 Oct 2006 18:41:35 +0000 (18:41 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
aroben [Mon, 9 Oct 2006 18:29:40 +0000 (18:29 +0000)]
    Reviewed by Adele.

        Remove redundant call to Frame::cancelAndClear from ~Frame, since it's
        already called frome ~FrameMac.

        * page/Frame.cpp:
        (WebCore::Frame::~Frame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed, landed, tweaked a bit by Darin.
darin [Mon, 9 Oct 2006 18:29:20 +0000 (18:29 +0000)]
    Reviewed, landed, tweaked a bit by Darin.

        - removed most uses of WebFrameBridge from WebFrameLoader
          (WebCoreFrameBridge use is OK)

        * Loader/WebDocumentLoader.m:
        (-[WebDocumentLoader bridge]):
        * Loader/WebFrameLoader.h:
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader initWithFrame:client:]):
        (-[WebFrameLoader defersCallbacksChanged]):
        (-[WebFrameLoader defersCallbacks]):
        (-[WebFrameLoader provisionalLoadStarted]):
        (-[WebFrameLoader stopLoadingSubframes]):
        (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]):
        (-[WebFrameLoader _receivedMainResourceError:complete:]):
        (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
        (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
        (-[WebFrameLoader closeOldDataSources]):
        (-[WebFrameLoader commitProvisionalLoad:]):
        (-[WebFrameLoader bridge]):
        (-[WebFrameLoader _handleFallbackContent]):
        (-[WebFrameLoader _finishedLoading]):
        (-[WebFrameLoader reload]):
        (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
        (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
        (-[WebFrameLoader transitionToCommitted:]):
        (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
        (-[WebFrameLoader loadRequest:inFrameNamed:]):
        (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
        (-[WebFrameLoader detachFromParent]):
        (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
        (-[WebFrameLoader safeLoadURL:]):
        (-[WebFrameLoader actionInformationForLoadType:isFormSubmission:event:originalURL:]):
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
        (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
        * WebView/WebFrame.m:
        (-[WebFrame _atMostOneFrameHasSelection]):
        * WebView/WebFrameInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady.
darin [Mon, 9 Oct 2006 18:04:35 +0000 (18:04 +0000)]
    Reviewed by Brady.

        - removed almost all direct use of WebView from WebFrameLoader

        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader defersCallbacksChanged]):
        (-[WebFrameLoader defersCallbacks]):
        (-[WebFrameLoader clearProvisionalLoad]):
        (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]):
        (-[WebFrameLoader _didReceiveResponse:forResource:]):
        (-[WebFrameLoader _didReceiveData:contentLength:forResource:]):
        (-[WebFrameLoader _didFinishLoadingForResource:]):
        (-[WebFrameLoader _didFailLoadingWithError:forResource:]):
        (-[WebFrameLoader closeOldDataSources]):
        (-[WebFrameLoader _notifyIconChanged:]):
        (-[WebFrameLoader prepareForLoadStart]):
        (-[WebFrameLoader willChangeTitleForDocument:]):
        (-[WebFrameLoader didChangeTitleForDocument:]):
        (-[WebFrameLoader continueAfterNewWindowPolicy:]):
        (-[WebFrameLoader continueAfterNavigationPolicy:]):
        (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
        (-[WebFrameLoader didFirstLayout]):
        (-[WebFrameLoader transitionToCommitted:]):
        (-[WebFrameLoader checkLoadCompleteForThisFrame]):
        (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
        * Loader/WebFrameLoaderClient.h:
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebFrame.m:
        (-[WebFrame _currentBackForwardListItemToResetTo]):
        (-[WebFrame _hasBackForwardList]):
        (-[WebFrame _resetBackForwardList]):
        (-[WebFrame _dispatchDidReceiveIcon:]):
        (-[WebFrame _dispatchDidStartProvisionalLoadForFrame]):
        (-[WebFrame _dispatchDidCommitLoadForFrame]):
        (-[WebFrame _dispatchDidFailProvisionalLoadWithError:]):
        (-[WebFrame _dispatchDidFailLoadWithError:]):
        (-[WebFrame _dispatchDidFinishLoadForFrame]):
        (-[WebFrame _progressStarted]):
        (-[WebFrame _progressCompleted]):
        (-[WebFrame _incrementProgressForIdentifier:response:]):
        (-[WebFrame _incrementProgressForIdentifier:data:]):
        (-[WebFrame _completeProgressForIdentifier:]):
        (-[WebFrame _setMainFrameDocumentReady:]):
        (-[WebFrame _willChangeTitleForDocument:]):
        (-[WebFrame _didChangeTitleForDocument:]):
        (-[WebFrame _startDownloadWithRequest:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-09 Anders Carlsson <acarlsson@apple.com>
andersca [Mon, 9 Oct 2006 17:47:49 +0000 (17:47 +0000)]
2006-10-09  Anders Carlsson  <acarlsson@apple.com>

        * bridge/win/FrameWin.h:
        Add function declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-09 Anders Carlsson <acarlsson@apple.com>
andersca [Mon, 9 Oct 2006 17:35:24 +0000 (17:35 +0000)]
2006-10-09  Anders Carlsson  <acarlsson@apple.com>

        * platform/win/TemporaryLinkStubs.cpp:
        (FrameWin::createJavaAppletWidget):
        Try fixing the Win32 build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-09 Anders Carlsson <acarlsson@apple.com>
andersca [Mon, 9 Oct 2006 17:21:08 +0000 (17:21 +0000)]
2006-10-09  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Adam.

        Move applet widget creation to Frame and get rid of JavaAppletWidget.
        * WebCore.xcodeproj/project.pbxproj:
        * bridge/JavaAppletWidget.h: Removed.
        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::createJavaAppletWidget):
        * bridge/mac/JavaAppletWidget.mm: Removed.
        * page/Frame.h:
        * rendering/RenderApplet.cpp:
        (WebCore::RenderApplet::createWidgetIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Alice.
mjs [Mon, 9 Oct 2006 09:53:40 +0000 (09:53 +0000)]
    Reviewed by Alice.

        - moved WebFormState into Loader directory and tweaked to void WebKit dependencies

        * Loader/WebDocumentLoader.h:
        * Loader/WebFormState.h: Added.
        * Loader/WebFormState.m: Added.
        (-[WebFormState initWithForm:values:sourceFrame:]):
        (-[WebFormState dealloc]):
        (-[WebFormState form]):
        (-[WebFormState values]):
        (-[WebFormState sourceFrame]):
        * Loader/WebFrameLoader.h:
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
        (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
        (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebFrame.m:
        * WebView/WebFrameInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-09 Mitz Pettel <mitz@webkit.org>
bdash [Mon, 9 Oct 2006 09:29:21 +0000 (09:29 +0000)]
2006-10-09  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - http://bugs.webkit.org/show_bug.cgi?id=11220
          Fix manual test for http://bugs.webkit.org/show_bug.cgi?id=8276

        Subversion does not support resource forks and HFS metadata, so
        the resources for this test need to be on a disk image.

        * manual-tests/plain-text-paste.html: Changed instructions to refer to the disk image.
        * manual-tests/resources/plain-text-paste.dmg: Added.
        * manual-tests/resources/plain-text-paste/._1.textClipping: Removed.
        * manual-tests/resources/plain-text-paste/._2.textClipping: Removed.
        * manual-tests/resources/plain-text-paste/._4.txt: Removed.
        * manual-tests/resources/plain-text-paste/._5.webloc: Removed.
        * manual-tests/resources/plain-text-paste/1.textClipping: Removed.
        * manual-tests/resources/plain-text-paste/2.textClipping: Removed.
        * manual-tests/resources/plain-text-paste/3.gif: Removed.
        * manual-tests/resources/plain-text-paste/4.txt: Removed.
        * manual-tests/resources/plain-text-paste/5.webloc: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver.
mjs [Mon, 9 Oct 2006 09:09:14 +0000 (09:09 +0000)]
    Reviewed by Oliver.

        - remove dependency on WebNSURLRequestExtras.h

        * Loader/WebFrameLoader.h:
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
        (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
        (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver.
mjs [Mon, 9 Oct 2006 08:59:55 +0000 (08:59 +0000)]
    Reviewed by Oliver.

        - removed unneeded logging code so I can take WebKitLogging.h out and remove a WebKit dependency

        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader setState:]):
        (-[WebFrameLoader clientRedirectCancelledOrFinished:]):
        (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
        (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
        (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
        (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
        (-[WebFrameLoader checkLoadCompleteForThisFrame]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver.
mjs [Mon, 9 Oct 2006 08:44:58 +0000 (08:44 +0000)]
    Reviewed by Oliver.

        - remove WebDataSource from the WebFrameLoader interface (and thereby from a lot of internal use)

        * Loader/WebDocumentLoader.h:
        * Loader/WebDocumentLoader.m:
        (-[WebDocumentLoader dealloc]):
        (-[WebDocumentLoader initialRequest]):
        (-[WebDocumentLoader URL]):
        (-[WebDocumentLoader unreachableURL]):
        * Loader/WebFrameLoader.h:
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader setState:]):
        (-[WebFrameLoader startLoading]):
        (-[WebFrameLoader startProvisionalLoad:]):
        (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
        (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
        (-[WebFrameLoader opened]):
        (-[WebFrameLoader commitProvisionalLoad:]):
        (-[WebFrameLoader initialRequest]):
        (-[WebFrameLoader _finishedLoading]):
        (-[WebFrameLoader _notifyIconChanged:]):
        (-[WebFrameLoader _URL]):
        (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
        (-[WebFrameLoader _checkNavigationPolicyForRequest:andCall:withSelector:]):
        (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]):
        (-[WebFrameLoader _loadRequest:archive:]):
        (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
        (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
        (-[WebFrameLoader reload]):
        (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
        (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
        (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
        (-[WebFrameLoader frameLoadCompleted]):
        (-[WebFrameLoader transitionToCommitted:]):
        (-[WebFrameLoader checkLoadCompleteForThisFrame]):
        (-[WebFrameLoader safeLoadURL:]):
        * Loader/WebFrameLoaderClient.h:
        * Plugins/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge originalRequestURL]):
        * WebView/WebDataSource.m:
        (-[WebDataSource _URL]):
        (-[WebDataSource dealloc]):
        (-[WebDataSource initialRequest]):
        (-[WebDataSource unreachableURL]):
        * WebView/WebFrame.m:
        (-[WebFrame _loadItem:withLoadType:]):
        (-[WebFrame _prepareForDataSourceReplacement]):
        (-[WebFrame provisionalDataSource]):
        (-[WebFrame dataSource]):
        (-[WebFrame _makeDocumentView]):
        (-[WebFrame _updateHistoryForReload]):
        (-[WebFrame _updateHistoryForStandardLoad]):
        (-[WebFrame _updateHistoryForInternalLoad]):
        (-[WebFrame _forceLayoutForNonHTML]):
        (-[WebFrame _clearLoadingFromPageCacheForDocumentLoader:]):
        (-[WebFrame _isDocumentLoaderLoadingFromPageCache:]):
        (-[WebFrame _archivedSubresourceForURL:fromDocumentLoader:]):
        (-[WebFrame _makeRepresentationForDocumentLoader:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
rwlbuis [Mon, 9 Oct 2006 07:40:41 +0000 (07:40 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=11217
        Cleanup svg coding style

        Cleanup coding style in filter classes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by olliej.
rwlbuis [Mon, 9 Oct 2006 07:36:45 +0000 (07:36 +0000)]
    Reviewed by olliej.

        http://bugs.webkit.org/show_bug.cgi?id=11217
        Cleanup svg coding style

        Cleanup coding style in SVGPath* classes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
mjs [Mon, 9 Oct 2006 07:32:58 +0000 (07:32 +0000)]
    Reviewed by Darin.

        - removed need for WebFrameLoader to now about WebDocumentLoaderMac

        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader loadDataSource:withLoadType:formState:]):
        * WebView/WebDocumentLoaderMac.h:
        * WebView/WebDocumentLoaderMac.m:
        (-[WebDocumentLoaderMac setFrameLoader:]):
        (-[WebDocumentLoaderMac detachFromFrameLoader]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by aroben.
rwlbuis [Mon, 9 Oct 2006 07:27:36 +0000 (07:27 +0000)]
    Reviewed by aroben.

        http://bugs.webkit.org/show_bug.cgi?id=11217
        Cleanup svg coding style

        Cleanup coding style in svg shape classes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
darin [Mon, 9 Oct 2006 07:23:47 +0000 (07:23 +0000)]
    Reviewed by Maciej.

        - passed calls that require WebScriptDebugServer across the client interface

        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader _finishedLoading]):
        (-[WebFrameLoader documentLoader:mainReceivedCompleteError:]):
        * Loader/WebFrameLoaderClient.h:
        * WebView/WebFrame.m:
        (-[WebFrame _dispatchDidLoadMainResourceForDocumentLoader:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
darin [Mon, 9 Oct 2006 07:03:11 +0000 (07:03 +0000)]
    Reviewed by Maciej.

        - passed calls that require WebHTMLView or WebFrameView calls across
          the client interface

        * Loader/WebFrameLoader.h:
        * Loader/WebFrameLoader.m:
        (isCaseInsensitiveEqual):
        (isBackForwardLoadType):
        (-[WebFrameLoader opened]):
        (-[WebFrameLoader cancelledErrorWithRequest:]):
        (-[WebFrameLoader fileDoesNotExistErrorWithResponse:]):
        (-[WebFrameLoader reload]):
        (-[WebFrameLoader transitionToCommitted:]):
        * Loader/WebFrameLoaderClient.h:
        * WebView/WebFrame.m:
        (-[WebFrame _forceLayout]):
        (-[WebFrame _setDocumentViewFromPageCache:]):
        (-[WebFrame _setCopiesOnScroll]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
mjs [Mon, 9 Oct 2006 06:46:15 +0000 (06:46 +0000)]
    Reviewed by Darin.

        - pass remaining delegate methods across client interface

        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]):
        (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
        (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
        (-[WebFrameLoader handleUnimplementablePolicyWithErrorCode:forURL:]):
        (-[WebFrameLoader didFirstLayout]):
        (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
        * Loader/WebFrameLoaderClient.h:
        * WebView/WebFrame.m:
        (-[WebFrame _dispatchDidFirstLayoutInFrame]):
        (-[WebFrame _dispatchCreateWebViewWithRequest:]):
        (-[WebFrame _dispatchShow]):
        (-[WebFrame _dispatchDecidePolicyForMIMEType:request:decisionListener:]):
        (-[WebFrame _dispatchDecidePolicyForNewWindowAction:request:newFrameName:decisionListener:]):
        (-[WebFrame _dispatchDecidePolicyForNavigationAction:request:decisionListener:]):
        (-[WebFrame _dispatchUnableToImplementPolicyWithError:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin [Mon, 9 Oct 2006 06:30:55 +0000 (06:30 +0000)]
WebCore:

        Reviewed by Maciej.

        - added a bit more WebCoreSystemInterface

            wkGetNSURLResponseCalculatedExpiration
            wkGetNSURLResponseLastModifiedDate
            wkGetNSURLResponseMustRevalidate

        * WebCore.exp: Added the new symbols.
        * platform/mac/WebCoreSystemInterface.h: Ditto.
        * platform/mac/WebCoreSystemInterface.mm: Ditto.

        - quiet down the code generation script

        * bindings/scripts/CodeGenerator.pm:

WebKit:

        Reviewed by Maciej.

        - use WebCoreSystemInterface instead of WebSystemInterface in Loader directory

        * Loader/WebFrameLoader.m: Update includes.
        (-[WebFrameLoader commitProvisionalLoad:]): Use wk calls istead of WK.
        (-[WebFrameLoader _canUseResourceWithResponse:]): Ditto.

        * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
        Added the three new symbols, and resorted the list.

        * Loader/WebDataProtocol.m:
        * Loader/WebLoader.m:
        * Loader/WebMainResourceLoader.h:
        * Loader/WebMainResourceLoader.m:
        * Loader/WebNetscapePlugInStreamLoader.h:
        * Loader/WebNetscapePlugInStreamLoader.m:
        * Loader/WebSubresourceLoader.h:
        * Loader/WebSubresourceLoader.m:
        Changed import statements to consistently use the "" format.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Not reviewed.
mjs [Mon, 9 Oct 2006 06:19:50 +0000 (06:19 +0000)]
    Not reviewed.

        - fix accidental build break due to editing while committing

        * Loader/WebFrameLoader.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
mjs [Mon, 9 Oct 2006 06:17:56 +0000 (06:17 +0000)]
    Reviewed by Darin.

        - move all WebFrameLoadDelegate methods across client interface

        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader clientRedirectCancelledOrFinished:]):
        (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
        (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
        (-[WebFrameLoader closeOldDataSources]):
        (-[WebFrameLoader _notifyIconChanged:]):
        (-[WebFrameLoader prepareForLoadStart]):
        (-[WebFrameLoader didChangeTitleForDocument:]):
        (-[WebFrameLoader transitionToCommitted:]):
        (-[WebFrameLoader checkLoadCompleteForThisFrame]):
        * Loader/WebFrameLoaderClient.h:
        * WebView/WebFrame.m:
        (-[WebFrame _dispatchDidCancelClientRedirectForFrame]):
        (-[WebFrame _dispatchWillPerformClientRedirectToURL:delay:fireDate:]):
        (-[WebFrame _dispatchDidChangeLocationWithinPageForFrame]):
        (-[WebFrame _dispatchWillCloseFrame]):
        (-[WebFrame _dispatchDidReceiveIcon:]):
        (-[WebFrame _dispatchDidStartProvisionalLoadForFrame]):
        (-[WebFrame _dispatchDidReceiveTitle:]):
        (-[WebFrame _dispatchDidCommitLoadForFrame]):
        (-[WebFrame _dispatchDidFailProvisionalLoadWithError:]):
        (-[WebFrame _dispatchDidFailLoadWithError:]):
        (-[WebFrame _dispatchDidFinishLoadForFrame]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
darin [Mon, 9 Oct 2006 05:44:32 +0000 (05:44 +0000)]
    Reviewed by Maciej.

        - removed some of the WebKit dependencies in WebFrameLoader

        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
        (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]):
        (-[WebFrameLoader reload]):
        (-[WebFrameLoader didChangeTitleForDocument:]):
        * Loader/WebFrameLoaderClient.h:
        * WebView/WebFrame.m:
        (-[WebFrame _loadItem:withLoadType:]):
        (-[WebFrame _loadURL:referrer:intoChild:]):
        (-[WebFrame _setTitle:forURL:]):
        (-[WebFrame _downloadWithLoadingConnection:request:response:proxy:]):
        * WebView/WebFrameInternal.h:

        - some other tweaks

        * Misc/WebNSURLRequestExtras.m:
        (-[NSMutableURLRequest _web_setHTTPReferrer:]):
        (-[NSMutableURLRequest _web_setHTTPUserAgent:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
mjs [Mon, 9 Oct 2006 05:42:55 +0000 (05:42 +0000)]
    Reviewed by Darin.

        - pass all WebResourceLoadDelegate methods across client, removing need to include related headers

        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]):
        (-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]):
        (-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]):
        (-[WebFrameLoader _didReceiveResponse:forResource:]):
        (-[WebFrameLoader _didReceiveData:contentLength:forResource:]):
        (-[WebFrameLoader _didFinishLoadingForResource:]):
        (-[WebFrameLoader _didFailLoadingWithError:forResource:]):
        (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
        (-[WebFrameLoader requestFromDelegateForRequest:identifier:error:]):
        * Loader/WebFrameLoaderClient.h:
        * WebView/WebFrame.m:
        (-[WebFrame _dispatchDidHandleOnloadEventsForFrame]):
        (-[WebFrame _dispatchDidReceiveServerRedirectForProvisionalLoadForFrame]):
        (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]):
        (-[WebFrame _dispatchResource:willSendRequest:redirectResponse:fromDocumentLoader:]):
        (-[WebFrame _dispatchDidReceiveAuthenticationChallenge:forResource:fromDocumentLoader:]):
        (-[WebFrame _dispatchDidCancelAuthenticationChallenge:forResource:fromDocumentLoader:]):
        (-[WebFrame _dispatchResource:didReceiveResponse:fromDocumentLoader:]):
        (-[WebFrame _dispatchResource:didReceiveContentLength:fromDocumentLoader:]):
        (-[WebFrame _dispatchResource:didFinishLoadingFromDocumentLoader:]):
        (-[WebFrame _dispatchResource:didFailLoadingWithError:fromDocumentLoader:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
mjs [Mon, 9 Oct 2006 05:23:24 +0000 (05:23 +0000)]
    Reviewed by Darin.

        - started adding some _dispatch methods to WebFrameLoaderClient for delegate dispatch

        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader startLoading]):
        (-[WebFrameLoader didReceiveServerRedirectForProvisionalLoadForFrame]):
        * Loader/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge handledOnloadEvents]):
        * WebView/WebFrame.m:
        (dataSource):
        (-[WebFrame _dataSourceForDocumentLoader:]):
        (-[WebFrame _dispatchDidHandleOnloadEventsForFrame]):
        (-[WebFrame _dispatchDidReceiveServerRedirectForProvisionalLoadForFrame]):
        (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]):
        * WebView/WebFrameInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16909 268f45cc-cd09-0410-ab3c-d52691b4dbfc