oliver@apple.com [Sun, 14 Sep 2008 08:18:49 +0000 (08:18 +0000)]
Bug 20821: Cache property transitions to speed up object initialization
https://bugs.webkit.org/show_bug.cgi?id=20821
Reviewed by Cameron Zwarich.
Implement a transition cache to improve the performance of new properties
being added to objects. This is extremely beneficial in constructors and
shows up as a 34% improvement on access-binary-trees in SunSpider (0.8%
overall)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36401
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sun, 14 Sep 2008 05:29:13 +0000 (05:29 +0000)]
Fix Qt bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36400
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sun, 14 Sep 2008 05:05:31 +0000 (05:05 +0000)]
Fix Windows bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36399
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sun, 14 Sep 2008 04:53:47 +0000 (04:53 +0000)]
Fix Mac build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36398
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jmalonzo@webkit.org [Sun, 14 Sep 2008 01:57:13 +0000 (01:57 +0000)]
2008-09-13 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix, not reviewed.
* platform/gtk/PlatformScrollBarGtk.cpp:
(PlatformScrollbar::PlatformScrollbar):
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::updateScrollbars):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36397
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sun, 14 Sep 2008 01:26:22 +0000 (01:26 +0000)]
Eliminate Scrollbar's setRect method. Clients can now just use the Widget base class method, setFrameGeometry instead.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36396
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sun, 14 Sep 2008 01:06:57 +0000 (01:06 +0000)]
Remove setEnabled from all Scrollbar subclasses that were just using their Widget base class methods.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36395
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sun, 14 Sep 2008 00:58:29 +0000 (00:58 +0000)]
Remove width()/height() from Scrollbar and subclasses that just need to use the Widget method.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36394
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sun, 14 Sep 2008 00:50:24 +0000 (00:50 +0000)]
Remove now unused methods from GTK scrollbars.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36393
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sun, 14 Sep 2008 00:49:52 +0000 (00:49 +0000)]
Remove now unused methods from GTK scrollbars.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36392
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sun, 14 Sep 2008 00:32:19 +0000 (00:32 +0000)]
Move stopTimerIfNeeded out of PlatformScrollbar destructors and into Scrollbar's destructor.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36391
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sun, 14 Sep 2008 00:22:45 +0000 (00:22 +0000)]
Fix Qt build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36390
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 13 Sep 2008 23:57:08 +0000 (23:57 +0000)]
2008-09-13 David Hyatt <hyatt@apple.com>
Move maximum() from Qt's PlatformScrollbar to be a cross-platform
function on Scrollbar. Fixes Qt build bustage.
Reviewed by Sam Weinig
* platform/ScrollBar.h:
(WebCore::Scrollbar::orientation):
(WebCore::Scrollbar::value):
(WebCore::Scrollbar::maximum):
* platform/qt/PlatformScrollBar.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36389
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 13 Sep 2008 23:47:09 +0000 (23:47 +0000)]
Fix Qt bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36388
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 13 Sep 2008 23:34:36 +0000 (23:34 +0000)]
Fix wx bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36387
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 13 Sep 2008 23:32:37 +0000 (23:32 +0000)]
Fix Qt bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36386
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 13 Sep 2008 23:21:39 +0000 (23:21 +0000)]
Fix Qt, Gtk, and Mac build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36385
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 13 Sep 2008 23:10:40 +0000 (23:10 +0000)]
Fix Qt bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36384
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 13 Sep 2008 23:08:35 +0000 (23:08 +0000)]
Fix Mac bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36383
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 13 Sep 2008 23:06:59 +0000 (23:06 +0000)]
WebCore:
Reviewed by Sam Weinig.
- use the LastResort font for missing glyphs instead of showing the
primary font's missing glyph
Test: platform/mac/fast/text/last-resort-font.html
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getFontDataForCharacters): Changed to return the
last resort font if a substitute font cannot be found.
(WebCore::FontCache::getLastResortFallbackFont): Removed an outdated
comment (the user's preferred standard font is included in the search
thanks to code in FontCache::getFontData()) and changed to return the
LastResort font.
LayoutTests:
Reviewed by Sam Weinig.
- test that the LastResort font is used for missing glyphs rather than
the primary font's missing glyph
* platform/mac/fast/text/last-resort-font-expected.checksum: Added.
* platform/mac/fast/text/last-resort-font-expected.png: Added.
* platform/mac/fast/text/last-resort-font-expected.txt: Added.
* platform/mac/fast/text/last-resort-font.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36382
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 13 Sep 2008 22:59:55 +0000 (22:59 +0000)]
Add ScrollbarTheme to control scrollbar metrics (and eventually hit testing and rendering.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36381
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 13 Sep 2008 22:59:05 +0000 (22:59 +0000)]
Add ScrollbarTheme to control scrollbar metrics (and eventually hit testing and rendering.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36380
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jmalonzo@webkit.org [Sat, 13 Sep 2008 21:30:38 +0000 (21:30 +0000)]
2008-09-13 Adrien Nader <camaradetux@gmail.com>
Gtk build fix, not reviewed.
* webkit/webkitwebview.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36379
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Sat, 13 Sep 2008 21:05:18 +0000 (21:05 +0000)]
<rdar://problem/5060439> Web elements should have an AXTopLevelUIElement
expose AXTopLevelUIElement as an attribute
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36378
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 13 Sep 2008 20:51:53 +0000 (20:51 +0000)]
Fix Qt build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36377
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 13 Sep 2008 20:37:16 +0000 (20:37 +0000)]
Fix wx build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36376
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 13 Sep 2008 20:33:44 +0000 (20:33 +0000)]
Fix Qt build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36375
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 13 Sep 2008 20:27:37 +0000 (20:27 +0000)]
Reviewed by Timothy Hatcher.
- fix <rdar://problem/6171280> REGRESSION (r35667): Assertion failure in WebCore::FrameView::scheduleRelayout() when releasing a page with counters from the b/f cache
No regression test because the back/forward cache is disabled in DumpRenderTree
* rendering/RenderContainer.cpp:
(WebCore::RenderContainer::invalidateCounters): Bail out if the document
is being destroyed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36374
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 13 Sep 2008 19:14:49 +0000 (19:14 +0000)]
Fix Mac build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36373
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 13 Sep 2008 18:52:44 +0000 (18:52 +0000)]
Fix Qt build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36372
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Sat, 13 Sep 2008 18:48:39 +0000 (18:48 +0000)]
wx build fixes for new methods recently introduced.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36371
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 13 Sep 2008 18:41:47 +0000 (18:41 +0000)]
more scrollbar refactoring.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36370
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 13 Sep 2008 18:39:58 +0000 (18:39 +0000)]
More scrollbar refactoring.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36369
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Sat, 13 Sep 2008 04:57:35 +0000 (04:57 +0000)]
2008-09-12 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Bug 20819: JSValue::isObject() is slow
<https://bugs.webkit.org/show_bug.cgi?id=20819>
Optimize JSCell::isObject() and JSCell::isString() by making them
non-virtual calls that rely on the StructureID type information.
This is a 0.7% speedup on SunSpider and a 1.0% speedup on the V8
benchmark suite.
* JavaScriptCore.exp:
* kjs/JSCell.cpp:
* kjs/JSCell.h:
(JSC::JSCell::isObject):
(JSC::JSCell::isString):
* kjs/JSObject.cpp:
* kjs/JSObject.h:
* kjs/JSString.cpp:
* kjs/JSString.h:
(JSC::JSString::JSString):
* kjs/StructureID.h:
(JSC::StructureID::type):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36368
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Sat, 13 Sep 2008 02:59:00 +0000 (02:59 +0000)]
Fix Mac build.
* css/CSSStyleSelector.cpp:
(WebCore::getTransformOperationType):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36367
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 13 Sep 2008 01:10:42 +0000 (01:10 +0000)]
Fix Windows build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36366
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Sat, 13 Sep 2008 00:47:45 +0000 (00:47 +0000)]
Cleaning up LayoutTests/ChangeLog.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36365
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Sat, 13 Sep 2008 00:45:39 +0000 (00:45 +0000)]
Cleaning up WebCore/ChangeLog
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36364
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 13 Sep 2008 00:41:15 +0000 (00:41 +0000)]
Roll out r36360 as it broke all non-Mac builds.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36363
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Sat, 13 Sep 2008 00:33:23 +0000 (00:33 +0000)]
2008-09-12 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt.
Make transform animation behavior match spec
https://bugs.webkit.org/show_bug.cgi?id=20770
Tests: transitions/transform-op-list-match.html
transitions/transform-op-list-no-match.html
* css/CSSStyleSelector.cpp:
* css/CSSStyleSelector.h:
* page/animation/AnimationBase.cpp:
* page/animation/AnimationBase.h:
* page/animation/ImplicitAnimation.cpp:
* page/animation/ImplicitAnimation.h:
* page/animation/KeyframeAnimation.cpp:
* page/animation/KeyframeAnimation.h:
* rendering/RenderLayer.cpp:
* rendering/style/RenderStyle.cpp:
* rendering/style/RenderStyle.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36362
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Fri, 12 Sep 2008 23:30:12 +0000 (23:30 +0000)]
2008-09-12 John Sullivan <sullivan@apple.com>
Fixed <rdar://problem/6110941> Clicking the print button in PDF content does nothing
Reviewed by Darin Adler
* WebView/WebPDFView.mm:
(-[WebPDFView PDFViewPerformPrint:]):
Implemented PDFKit delegate method that's called after a Print action in the PDF content
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36361
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Fri, 12 Sep 2008 23:27:22 +0000 (23:27 +0000)]
<rdar://problem/4003789> Expose lists as AXList
<rdar://problem/5707399> VO: Definition lists not announced in Safari
Exposes <ol>, <ul> and <dl> lists as AXLists through accessibility
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36360
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Fri, 12 Sep 2008 22:43:38 +0000 (22:43 +0000)]
Properly escape contents of links added to the inspector.
For now, just build the link with the DOM and get the
outerHTML. Eventually, we probably just want to do
this entirely with the DOM.
Reviewed by Timothy Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=20684
* manual-tests/inspector/escape-links.html: Added.
* page/inspector/StylesSidebarPane.js:
* page/inspector/inspector.js:
* page/inspector/utilities.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36359
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Fri, 12 Sep 2008 22:14:13 +0000 (22:14 +0000)]
2008-09-12 Adele Peterson <adele@apple.com>
Reviewed by John Sullivan and Kevin McCullough.
Fix for <rdar://problem/6216951> REGRESSION (r36000?): Crash due to infinite recursion into EventHandler::hitTestResultAtPoint() with disconnected frames
* page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint):
Hit testing again on the main frame will only work if we aren't already on the main frame. If we are already on the main frame, that will
cause infinite recursion. This change checks that we're not already on the main frame before hit testing again.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36358
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Fri, 12 Sep 2008 22:08:56 +0000 (22:08 +0000)]
WebCore:
2008-09-12 Kevin McCullough <kmccullough@apple.com>
RS by Tim .
Re-introducing the code since it was not the cause of the crash.
See r36343.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::canBeProgramaticallyScrolled):
* rendering/RenderObject.h:
LayoutTests:
2008-09-12 Kevin McCullough <kmccullough@apple.com>
RS by Tim.
Re-introducing the code since it was not the cause of the crash.
See r36343.
* fast/events/autoscroll-with-non-scrollable-parent.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36357
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Fri, 12 Sep 2008 21:54:57 +0000 (21:54 +0000)]
2008-09-12 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt.
When changing one animation in a list, don't reset other animations
https://bugs.webkit.org/show_bug.cgi?id=20675
Test: animations/change-one-anim.html
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::getNumProperties):
* page/animation/AnimationBase.h:
* page/animation/AnimationController.cpp:
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateKeyframeAnimations):
* page/animation/CompositeAnimation.h:
* page/animation/ImplicitAnimation.cpp:
* page/animation/KeyframeAnimation.cpp:
* page/animation/KeyframeAnimation.h:
(WebCore::KeyframeAnimation::setIndex):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36356
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 12 Sep 2008 21:43:21 +0000 (21:43 +0000)]
Fix Gtk build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36355
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 12 Sep 2008 21:42:11 +0000 (21:42 +0000)]
Fix Qtbuild bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36354
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 12 Sep 2008 18:40:03 +0000 (18:40 +0000)]
2008-09-12 Brady Eidson <beidson@apple.com>
Reviewed by Mitz Pettel
Fix the ASSERT and failure in webarchive/archive-empty-frame-source.html
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::mainResource): Further restoration of original WebArchive behavior.
Subresources can never be created from nil data, but there is always a MainResource, whether
or not there's any data. So in the case where the main resource has no data, fake it for the
sake of creating the ArchiveResource.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36353
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 12 Sep 2008 18:37:23 +0000 (18:37 +0000)]
Make Scrollbar derive from Widget. Remove isWidget guards on Scrollbars.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36352
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 12 Sep 2008 18:22:07 +0000 (18:22 +0000)]
Reviewed by Sam Weinig.
- https://bugs.webkit.org/show_bug.cgi?id=20793 clean up page/animation
* page/animation/AnimationController.cpp:
* page/animation/AnimationController.h:
* page/animation/CompositeAnimation.cpp:
* page/animation/CompositeAnimation.h:
* page/animation/ImplicitAnimation.cpp:
* page/animation/ImplicitAnimation.h:
* page/animation/KeyframeAnimation.cpp:
* page/animation/KeyframeAnimation.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36351
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 12 Sep 2008 17:58:28 +0000 (17:58 +0000)]
Reviewed by John Sullivan.
- fix a crash in -visibleRect when it is called during WebFrameView deallocation
* WebView/WebFrameView.mm:
(-[WebFrameView visibleRect]): Added an early return if _private is 0.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36350
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Fri, 12 Sep 2008 04:44:40 +0000 (04:44 +0000)]
Add a renderedImage method to DOMNode to get an image
of the rendering for the node and it's descendants.
<rdar://problem/5849349> Would like API to create
an image for a DOM node
Reviewed by Oliver Hunt.
* bindings/objc/DOM.mm:
(-[DOMNode renderedImage]): Call Frame::nodeImage.
* bindings/objc/DOMPrivate.h:
* page/Frame.h:
* page/mac/FrameMac.mm:
(WebCore::Frame::nodeImage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36349
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Fri, 12 Sep 2008 01:25:09 +0000 (01:25 +0000)]
2008-09-11 Dean Jackson <dino@apple.com>
Unfortunately the fix for
https://bugs.webkit.org/show_bug.cgi?id=20680
didn't update the relevant test
* css3/keyframes-rule-expected.txt:
* css3/keyframes-rule.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36348
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Fri, 12 Sep 2008 00:36:31 +0000 (00:36 +0000)]
2008-09-08 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt
Need to support comma separated list of key times in keyframes selectors
https://bugs.webkit.org/show_bug.cgi?id=20680
Test: animations/keyframes-comma-separated.html
* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore::CSSParser::createKeyframeRule):
* css/CSSParser.h:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::addKeyframeStyle):
* css/WebKitCSSKeyframeRule.cpp:
(WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule):
(WebCore::WebKitCSSKeyframeRule::cssText):
(WebCore::WebKitCSSKeyframeRule::parseKeyString):
* css/WebKitCSSKeyframeRule.h:
(WebCore::WebKitCSSKeyframeRule::keyText):
(WebCore::WebKitCSSKeyframeRule::setKeyText):
(WebCore::WebKitCSSKeyframeRule::getKeys):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::append):
(WebCore::WebKitCSSKeyframesRule::insertRule):
(WebCore::WebKitCSSKeyframesRule::deleteRule):
(WebCore::WebKitCSSKeyframesRule::findRule):
(WebCore::WebKitCSSKeyframesRule::findRuleIndex):
* css/WebKitCSSKeyframesRule.h:
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::blendProperties):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36347
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Thu, 11 Sep 2008 22:57:09 +0000 (22:57 +0000)]
WebCore:
2008-09-11 Kevin McCullough <kmccullough@apple.com>
RS by Tim.
Reverting because this caused a crash.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::canBeProgramaticallyScrolled):
(WebCore::RenderObject::hasScrollableView):
* rendering/RenderObject.h:
LayoutTests:
2008-09-11 Kevin McCullough <kmccullough@apple.com>
RS = Tim.
Reverted because this caused a crash.
* fast/events/autoscroll-with-non-scrollable-parent.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36343
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Thu, 11 Sep 2008 22:32:12 +0000 (22:32 +0000)]
2008-09-11 Stephanie Lewis <slewis@apple.com>
Reviewed by Oliver Hunt.
Turn off PGO Optimization on CTI.cpp -> <rdar://problem/6207709>. Fixes
crash on CNN and on Dromaeo.
Fix Missing close tag in vcproj.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36342
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Thu, 11 Sep 2008 21:59:08 +0000 (21:59 +0000)]
2008-09-11 Dean Jackson <dino@apple.com>
Reviewed by Dan Bernstein.
Fix assertion on transition property "none"
https://bugs.webkit.org/show_bug.cgi?id=20751
Test: transitions/transition-end-event-set-none.html
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateTransitions):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36341
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dsmith@webkit.org [Thu, 11 Sep 2008 21:54:30 +0000 (21:54 +0000)]
2008-09-11 David Smith <catfish.man@gmail.com>
Rubber-stamped by mitzpettel.
Remove an accidentally added extra file.
* WebCore: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36340
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dsmith@webkit.org [Thu, 11 Sep 2008 21:41:33 +0000 (21:41 +0000)]
2008-09-11 David Smith <catfish.man@gmail.com>
Reviewed by Darin
https://bugs.webkit.org/show_bug.cgi?id=20180
This speeds up :nth-child matching as tested by querySelectorAll by around 10% by inlining the common case of Node::renderStyle(). Many thanks to mitzpettel and othermaciej for suggestions and help.
* WebCore.xcodeproj/project.pbxproj: Add NodeRenderStyle.h
* css/CSSStyleSelector.cpp: include NodeRenderStyle.h
* dom/Element.cpp: include NodeRenderStyle.h
* dom/Node.cpp: Remove the definition of renderStyle()
(WebCore::Node::nonRendererRenderStyle):
* dom/Node.h: Make renderStyle() nonvirtual and add nonRendererRenderStyle()
* dom/NodeRenderStyle.h: Added.
(WebCore::Node::renderStyle): Inline the common case of this, call nonRendererRenderStyle for the part that needed to be virtual
* html/HTMLOptGroupElement.cpp: include NodeRenderStyle.h
* html/HTMLOptGroupElement.h:
(WebCore::HTMLOptGroupElement::nonRendererRenderStyle): override to return m_style
* html/HTMLOptionElement.cpp: include NodeRenderStyle.h
* html/HTMLOptionElement.h:
(WebCore::HTMLOptionElement::nonRendererRenderStyle): override to return m_style
* rendering/RenderListBox.cpp: include NodeRenderStyle.h
* rendering/RenderMenuList.cpp: include NodeRenderStyle.h
* svg/SVGUseElement.cpp: include NodeRenderStyle.h
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36339
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Thu, 11 Sep 2008 21:15:57 +0000 (21:15 +0000)]
2008-09-11 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Not reviewed.
Correct an SVN problem with the last commit and actually add the new
files.
* wrec/CharacterClassConstructor.cpp: Added.
(JSC::):
(JSC::getCharacterClassNewline):
(JSC::getCharacterClassDigits):
(JSC::getCharacterClassSpaces):
(JSC::getCharacterClassWordchar):
(JSC::getCharacterClassNondigits):
(JSC::getCharacterClassNonspaces):
(JSC::getCharacterClassNonwordchar):
(JSC::CharacterClassConstructor::addSorted):
(JSC::CharacterClassConstructor::addSortedRange):
(JSC::CharacterClassConstructor::put):
(JSC::CharacterClassConstructor::flush):
(JSC::CharacterClassConstructor::append):
* wrec/CharacterClassConstructor.h: Added.
(JSC::CharacterClassConstructor::CharacterClassConstructor):
(JSC::CharacterClassConstructor::isUpsideDown):
(JSC::CharacterClassConstructor::charClass):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36338
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Thu, 11 Sep 2008 21:13:01 +0000 (21:13 +0000)]
2008-09-11 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Bug 20788: Split CharacterClassConstructor into its own file
<https://bugs.webkit.org/show_bug.cgi?id=20788>
Split CharacterClassConstructor into its own file and clean up some
style issues.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wrec/CharacterClassConstructor.cpp: Added.
(JSC::):
(JSC::getCharacterClassNewline):
(JSC::getCharacterClassDigits):
(JSC::getCharacterClassSpaces):
(JSC::getCharacterClassWordchar):
(JSC::getCharacterClassNondigits):
(JSC::getCharacterClassNonspaces):
(JSC::getCharacterClassNonwordchar):
(JSC::CharacterClassConstructor::addSorted):
(JSC::CharacterClassConstructor::addSortedRange):
(JSC::CharacterClassConstructor::put):
(JSC::CharacterClassConstructor::flush):
(JSC::CharacterClassConstructor::append):
* wrec/CharacterClassConstructor.h: Added.
(JSC::CharacterClassConstructor::CharacterClassConstructor):
(JSC::CharacterClassConstructor::isUpsideDown):
(JSC::CharacterClassConstructor::charClass):
* wrec/WREC.cpp:
(JSC::WRECParser::parseCharacterClass):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36337
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 11 Sep 2008 20:29:08 +0000 (20:29 +0000)]
Reviewed by John Sullivan.
- eliminate excessive repainting when a clipped iframe is moved (noticed in <rdar://problem/6204032>)
* WebView/WebFrame.mm:
(-[WebFrame _getVisibleRect:]): Added. If the frame is in a RenderPart
and has layout, gets the visible rect of the RenderPart and returns
YES. Returns NO otherwise.
* WebView/WebFrameInternal.h:
* WebView/WebFrameView.mm:
(-[WebFrameView visibleRect]): Added. Overrides this NSView method to
take clipping in the render tree into account.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36336
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Thu, 11 Sep 2008 17:39:12 +0000 (17:39 +0000)]
WebCore:
2008-09-11 Kevin McCullough <kmccullough@apple.com>
Reviewed by Adele and Tim.
<rdar://problem/6100597> REGRESSION: clicking on search results in Web
Inspector does not scroll to the line of the results (20167)
- This was put in by Max to fix auto scrolling but is not correct for
the whole web: rdar://problem/6213098
* rendering/RenderObject.cpp:
(WebCore::RenderObject::canBeProgramaticallyScrolled):
* rendering/RenderObject.h:
LayoutTests:
2008-09-11 Kevin McCullough <kmccullough@apple.com>
Reviewed by Adele and Tim.
<rdar://problem/6100597> REGRESSION: clicking on search results in Web
Inspector does not scroll to the line of the results (20167)
- This was put in by Max to fix some auto scroll behavior but is not
correct for the whole web: rdar://problem/6213098
* fast/events/autoscroll-with-non-scrollable-parent.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36335
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Thu, 11 Sep 2008 16:24:09 +0000 (16:24 +0000)]
<rdar://problem/6210511> AX: if a frame has a title, that should be reported as the AXWebArea's title
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36334
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Thu, 11 Sep 2008 10:50:36 +0000 (10:50 +0000)]
2008-09-11 Tor Arne Vestbø <tavestbo@trolltech.com>
Rubber-stamped by Simon.
Prevent leaking pages and frames in QWebKit autotest
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36333
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Thu, 11 Sep 2008 09:53:13 +0000 (09:53 +0000)]
2008-09-11 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon
Fix QtWebKit autotest
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36332
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 11 Sep 2008 08:03:07 +0000 (08:03 +0000)]
2008-09-11 Dirk Schulze <vbs85@gmx.de>
Reviewed by Simon.
Fixed stroke() and strokeRect() to support gradients
and patterns on Qt.
[Qt] Canvas stroke don't work for gradients and patterns
[https://bugs.webkit.org/show_bug.cgi?id=20749]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36331
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 11 Sep 2008 07:37:42 +0000 (07:37 +0000)]
2008-09-11 Dirk Schulze <vbs85@gmx.de>
Reviewed by Simon.
https://bugs.webkit.org/show_bug.cgi?id=20729
Fixed canvas gradients for Qt
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36330
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 11 Sep 2008 07:34:42 +0000 (07:34 +0000)]
2008-09-11 Dirk Schulze <vbs85@gmx.de>
Reviewed by Simon.
https://bugs.webkit.org/show_bug.cgi?id=20568
Add support for patterns to Qt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36329
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 11 Sep 2008 07:09:41 +0000 (07:09 +0000)]
2008-09-10 Simon Hausmann <hausmann@webkit.org>
Not reviewed but trivial one-liner for yet unused macro.
Changed PLATFORM(WINCE) to PLATFORM(WIN_CE) as requested by Mark.
(part of https://bugs.webkit.org/show_bug.cgi?id=20746)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36328
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Thu, 11 Sep 2008 05:28:04 +0000 (05:28 +0000)]
2008-09-10 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Rubber-stamped by Oliver Hunt.
Fix a typo by renaming the overloaded orl_rr that takes an immediate to
orl_i32r.
* VM/CTI.cpp:
(JSC::CTI::emitFastArithPotentiallyReTagImmediate):
* masm/X86Assembler.h:
(JSC::X86Assembler::orl_i32r):
* wrec/WREC.cpp:
(JSC::WRECGenerator::generatePatternCharacter):
(JSC::WRECGenerator::generateCharacterClassInverted):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36327
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 11 Sep 2008 04:01:44 +0000 (04:01 +0000)]
2008-09-10 Sam Weinig <sam@webkit.org>
Rubber-stamped by David Hyatt.
Add additional test by Feng Qian.
* fast/dom/StyleSheet/ownerNode-lifetime-2-expected.txt: Added.
* fast/dom/StyleSheet/ownerNode-lifetime-2.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36326
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 11 Sep 2008 02:42:18 +0000 (02:42 +0000)]
2008-09-10 Sam Weinig <sam@webkit.org>
Reviewed by Geoff Garen.
Add inline property storage for JSObject.
1.2% progression on Sunspider. .5% progression on the v8 test suite.
* JavaScriptCore.exp:
* VM/CTI.cpp:
(JSC::CTI::privateCompileGetByIdProto):
(JSC::CTI::privateCompileGetByIdChain):
* kjs/JSObject.cpp:
(JSC::JSObject::mark): There is no reason to check storageSize now that
we start from 0.
(JSC::JSObject::allocatePropertyStorage): Allocates/reallocates heap storage.
* kjs/JSObject.h:
(JSC::JSObject::offsetForLocation): m_propertyStorage is not an OwnArrayPtr
now so there is no reason to .get()
(JSC::JSObject::usingInlineStorage):
(JSC::JSObject::JSObject): Start with m_propertyStorage pointing to the
inline storage.
(JSC::JSObject::~JSObject): Free the heap storage if not using the inline
storage.
(JSC::JSObject::putDirect): Switch to the heap storage only when we know
we know that we are about to add a property that will overflow the inline
storage.
* kjs/PropertyMap.cpp:
(JSC::PropertyMap::createTable): Don't allocate the propertyStorage, that is
now handled by JSObject.
(JSC::PropertyMap::rehash): PropertyStorage is not a OwnArrayPtr anymore.
* kjs/PropertyMap.h:
(JSC::PropertyMap::storageSize): Rename from markingCount.
* kjs/StructureID.cpp:
(JSC::StructureID::addPropertyTransition): Don't resize the property storage
if we are using inline storage.
* kjs/StructureID.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36325
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 11 Sep 2008 02:10:47 +0000 (02:10 +0000)]
Inline immediate number version of op_mul.
Reviewed by Geoff Garen
Renamed mull_rr to imull_rr as that's what it's
actually doing, and added imull_i32r for the constant
case immediate multiply.
1.1% improvement to SunSpider.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36324
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 10 Sep 2008 20:30:18 +0000 (20:30 +0000)]
2008-09-10 Alp Toker <alp@nuanti.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=17267
[GTK] Primary selection/clipboard support
Implement primary selection support (copying only, no paste yet).
* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::clipboard_get_contents_cb):
(WebKit::clipboard_clear_contents_cb):
(WebKit::EditorClient::respondToChangedSelection):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36323
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 10 Sep 2008 18:21:14 +0000 (18:21 +0000)]
Reviewed by Sam Weinig.
- clean up AnimationBase
* page/animation/AnimationBase.cpp:
* page/animation/AnimationBase.h:
* page/animation/CompositeAnimation.cpp:
* page/animation/ImplicitAnimation.cpp:
* page/animation/ImplicitAnimation.h:
* page/animation/KeyframeAnimation.cpp:
* page/animation/KeyframeAnimation.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36322
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 10 Sep 2008 18:19:39 +0000 (18:19 +0000)]
Revert erroneous checkin
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36321
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 10 Sep 2008 18:17:14 +0000 (18:17 +0000)]
Reviewed by Sam Weinig.
- clean up AnimationBase
* page/animation/AnimationBase.cpp:
* page/animation/AnimationBase.h:
* page/animation/CompositeAnimation.cpp:
* page/animation/ImplicitAnimation.cpp:
* page/animation/ImplicitAnimation.h:
* page/animation/KeyframeAnimation.cpp:
* page/animation/KeyframeAnimation.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36320
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Wed, 10 Sep 2008 16:42:10 +0000 (16:42 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=20741
REGRESSION: ISO-8859-8-I encoding is registered incorrectly
Turns out that there were no real behavior changes for 8859-8, as it was only a debug-only
check to ignore this specific registration that was failing. Yet, I decided to add a bunch of
tests for ISO-8859-8 encoding aliases, as we handle them in a quite complicated manner.
I also found and fixed a potential crasher for non-Mac ports.
Tests: fast/encoding/hebrew/8859-8-e.html
fast/encoding/hebrew/8859-8-i.html
fast/encoding/hebrew/8859-8.html
fast/encoding/hebrew/csISO88598I.html
fast/encoding/hebrew/hebrew.html
fast/encoding/hebrew/iso-ir-138.html
fast/encoding/hebrew/logical.html
* platform/text/TextEncodingRegistry.cpp: (WebCore::checkExistingName): Check for iso-8859-8
(case-insensitively, because different versions of ICU report this MIME name in different
case).
* platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::registerExtendedEncodingNames): Updated some comments.
(WebCore::TextCodecICU::registerExtendedCodecs): Try both MIME and IANA names here, too.
There are four names in ICU that only have MIME names (x-mac-* ones), so we could end up
with an encoding map entry, but no codec for these. This was not an issue on the Mac, as
we also support these via TEC (which we should stop doing), but on Windows, this would
likely crash.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36319
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Wed, 10 Sep 2008 10:15:38 +0000 (10:15 +0000)]
2008-09-10 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Not reviewed.
Mac build fix.
* JavaScriptCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36318
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Wed, 10 Sep 2008 09:23:35 +0000 (09:23 +0000)]
Add optimised access to known properties on the global object.
Reviewed by Maciej Stachowiak
Improve cross scope access to the global object by emitting
code to access it directly rather than by walking the scope chain.
This is a 0.8% win in SunSpider and a 1.7% win in the v8 benchmarks.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36317
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Wed, 10 Sep 2008 08:42:43 +0000 (08:42 +0000)]
2008-09-10 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver.
- enable polymorphic inline caching of properties of primitives
1.012x speedup on SunSpider.
We create special structure IDs for JSString and
JSNumberCell. Unlike normal structure IDs, these cannot hold the
true prototype. Due to JS autoboxing semantics, the prototype used
when looking up string or number properties depends on the lexical
global object of the call site, not the creation site. Thus we
enable StructureIDs to handle this quirk for primitives.
Everything else should be straightforward.
* VM/CTI.cpp:
(JSC::CTI::privateCompileGetByIdProto):
(JSC::CTI::privateCompileGetByIdChain):
* VM/CTI.h:
(JSC::CTI::compileGetByIdProto):
(JSC::CTI::compileGetByIdChain):
* VM/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
* VM/Machine.cpp:
(JSC::Machine::Machine):
(JSC::cachePrototypeChain):
(JSC::Machine::tryCachePutByID):
(JSC::Machine::tryCacheGetByID):
(JSC::Machine::privateExecute):
(JSC::Machine::tryCTICachePutByID):
(JSC::Machine::tryCTICacheGetByID):
* kjs/GetterSetter.h:
(JSC::GetterSetter::GetterSetter):
* kjs/JSCell.h:
* kjs/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* kjs/JSGlobalData.h:
* kjs/JSGlobalObject.h:
(JSC::StructureID::prototypeForLookup):
* kjs/JSNumberCell.h:
(JSC::JSNumberCell::JSNumberCell):
(JSC::jsNumberCell):
* kjs/JSObject.h:
(JSC::JSObject::prototype):
* kjs/JSString.cpp:
(JSC::jsString):
(JSC::jsSubstring):
(JSC::jsOwnedString):
* kjs/JSString.h:
(JSC::JSString::JSString):
(JSC::JSString::):
(JSC::jsSingleCharacterString):
(JSC::jsSingleCharacterSubstring):
(JSC::jsNontrivialString):
* kjs/SmallStrings.cpp:
(JSC::SmallStrings::createEmptyString):
(JSC::SmallStrings::createSingleCharacterString):
* kjs/StructureID.cpp:
(JSC::StructureID::StructureID):
(JSC::StructureID::addPropertyTransition):
(JSC::StructureID::getterSetterTransition):
(JSC::StructureIDChain::StructureIDChain):
* kjs/StructureID.h:
(JSC::StructureID::create):
(JSC::StructureID::storedPrototype):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36316
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 10 Sep 2008 08:09:58 +0000 (08:09 +0000)]
2008-09-09 Joerg Bornemann <joerg.bornemann@trolltech.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=20746
Added WINCE platform macro.
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36315
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 10 Sep 2008 07:03:20 +0000 (07:03 +0000)]
2008-09-09 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Remove unnecessary override of getOffset.
Sunspider reports this as a .6% progression.
* JavaScriptCore.exp:
* kjs/JSObject.h:
(JSC::JSObject::getDirectLocation):
(JSC::JSObject::getOwnPropertySlotForWrite):
(JSC::JSObject::putDirect):
* kjs/PropertyMap.cpp:
* kjs/PropertyMap.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36314
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 10 Sep 2008 05:29:46 +0000 (05:29 +0000)]
Resurrect PlatformScrollbarWin.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36313
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Wed, 10 Sep 2008 03:43:38 +0000 (03:43 +0000)]
2008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Rubber-stamped by Maciej Stachowiak.
The bleeding edge branch of V8 now supports passing fileanmes after
'-f', so the SunSpider script should be changed to do this again.
This allows all 3 major JavaScript engines to be used with the
unmodified SunSpider script.
* sunspider:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36312
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Wed, 10 Sep 2008 03:22:04 +0000 (03:22 +0000)]
2008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Bug 20759: Remove MacroAssembler
<https://bugs.webkit.org/show_bug.cgi?id=20759>
Remove MacroAssembler and move its functionality to X86Assembler.
JavaScriptCore:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* VM/CTI.cpp:
(JSC::CTI::emitGetArg):
(JSC::CTI::emitGetPutArg):
(JSC::CTI::emitPutArg):
(JSC::CTI::emitPutCTIParam):
(JSC::CTI::emitGetCTIParam):
(JSC::CTI::emitPutToCallFrameHeader):
(JSC::CTI::emitGetFromCallFrameHeader):
(JSC::CTI::emitPutResult):
(JSC::CTI::emitDebugExceptionCheck):
(JSC::CTI::emitJumpSlowCaseIfNotImm):
(JSC::CTI::emitJumpSlowCaseIfNotImms):
(JSC::CTI::emitFastArithDeTagImmediate):
(JSC::CTI::emitFastArithReTagImmediate):
(JSC::CTI::emitFastArithPotentiallyReTagImmediate):
(JSC::CTI::emitFastArithImmToInt):
(JSC::CTI::emitFastArithIntToImmOrSlowCase):
(JSC::CTI::emitFastArithIntToImmNoCheck):
(JSC::CTI::compileOpCall):
(JSC::CTI::emitSlowScriptCheck):
(JSC::CTI::privateCompileMainPass):
(JSC::CTI::privateCompileSlowCases):
(JSC::CTI::privateCompile):
(JSC::CTI::privateCompileGetByIdSelf):
(JSC::CTI::privateCompileGetByIdProto):
(JSC::CTI::privateCompileGetByIdChain):
(JSC::CTI::privateCompilePutByIdReplace):
(JSC::CTI::privateArrayLengthTrampoline):
(JSC::CTI::privateStringLengthTrampoline):
(JSC::CTI::compileRegExp):
* VM/CTI.h:
(JSC::CallRecord::CallRecord):
(JSC::JmpTable::JmpTable):
(JSC::SlowCaseEntry::SlowCaseEntry):
(JSC::CTI::JSRInfo::JSRInfo):
* masm/MacroAssembler.h: Removed.
* masm/MacroAssemblerWin.cpp: Removed.
* masm/X86Assembler.h:
(JSC::X86Assembler::emitConvertToFastCall):
(JSC::X86Assembler::emitRestoreArgumentReference):
* wrec/WREC.h:
(JSC::WRECGenerator::WRECGenerator):
(JSC::WRECParser::WRECParser):
WebCore:
* ForwardingHeaders/masm/IA32MacroAsm.h: Removed.
* ForwardingHeaders/masm/MacroAssembler.h: Removed.
* ForwardingHeaders/masm/X86Assembler.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36311
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 10 Sep 2008 02:36:47 +0000 (02:36 +0000)]
2008-09-09 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Don't waste the first item in the PropertyStorage.
- Fix typo (makingCount -> markingCount)
- Remove undefined method declaration.
No change on Sunspider.
* kjs/JSObject.cpp:
(JSC::JSObject::mark):
* kjs/PropertyMap.cpp:
(JSC::PropertyMap::put):
(JSC::PropertyMap::remove):
(JSC::PropertyMap::getOffset):
(JSC::PropertyMap::insert):
(JSC::PropertyMap::rehash):
(JSC::PropertyMap::resizePropertyStorage):
(JSC::PropertyMap::checkConsistency):
* kjs/PropertyMap.h:
(JSC::PropertyMap::markingCount): Fix typo.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36310
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 10 Sep 2008 01:26:20 +0000 (01:26 +0000)]
2008-09-09 Alp Toker <alp@nuanti.com>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=16792
[GTK] Fails to render Japanese/Chinese text with simple path
https://bugs.webkit.org/show_bug.cgi?id=16942
[GTK] Oddities in font selection and fall back
https://bugs.webkit.org/show_bug.cgi?id=16862
[GTK] Custom fonts hard-coded to use grayscale antialiasing and no hinting
GTK+ font fixes and enhancements.
Implement font fallback for the simple FontConfig-based text path and
improve the Pango-based complex text path to make use of requested
font properties and available font selection.
Add text shadow support to the complex path.
* platform/graphics/gtk/FontCacheGtk.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
* platform/graphics/gtk/FontGtk.cpp:
(WebCore::setPangoAttributes):
(WebCore::Font::drawComplexText):
(WebCore::getDefaultPangoLayout):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
* platform/graphics/gtk/FontPlatformData.h:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::hash):
* platform/graphics/gtk/FontPlatformDataGtk.cpp:
(WebCore::FontPlatformData::FontPlatformData):
* platform/graphics/gtk/SimpleFontDataGtk.cpp:
(WebCore::SimpleFontData::platformDestroy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36309
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Wed, 10 Sep 2008 01:21:36 +0000 (01:21 +0000)]
2008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Not reviewed.
Speculative Windows build fix.
* masm/MacroAssemblerWin.cpp:
(JSC::MacroAssembler::emitConvertToFastCall):
(JSC::MacroAssembler::emitRestoreArgumentReference):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36308
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Wed, 10 Sep 2008 01:11:55 +0000 (01:11 +0000)]
2008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Bug 20755: Create an X86 namespace for register names and other things
<https://bugs.webkit.org/show_bug.cgi?id=20755>
Create an X86 namespace to put X86 register names. Perhaps I will move
opcode names here later as well.
* VM/CTI.cpp:
(JSC::CTI::emitGetArg):
(JSC::CTI::emitGetPutArg):
(JSC::CTI::emitPutArg):
(JSC::CTI::emitPutArgConstant):
(JSC::CTI::emitPutCTIParam):
(JSC::CTI::emitGetCTIParam):
(JSC::CTI::emitPutToCallFrameHeader):
(JSC::CTI::emitGetFromCallFrameHeader):
(JSC::CTI::emitPutResult):
(JSC::CTI::emitDebugExceptionCheck):
(JSC::CTI::emitJumpSlowCaseIfNotImms):
(JSC::CTI::compileOpCall):
(JSC::CTI::emitSlowScriptCheck):
(JSC::CTI::privateCompileMainPass):
(JSC::CTI::privateCompileSlowCases):
(JSC::CTI::privateCompile):
(JSC::CTI::privateCompileGetByIdSelf):
(JSC::CTI::privateCompileGetByIdProto):
(JSC::CTI::privateCompileGetByIdChain):
(JSC::CTI::privateCompilePutByIdReplace):
(JSC::CTI::privateArrayLengthTrampoline):
(JSC::CTI::privateStringLengthTrampoline):
(JSC::CTI::compileRegExp):
* VM/CTI.h:
* masm/X86Assembler.h:
(JSC::X86::):
(JSC::X86Assembler::emitModRm_rm):
(JSC::X86Assembler::emitModRm_rm_Unchecked):
(JSC::X86Assembler::emitModRm_rmsib):
* wrec/WREC.cpp:
(JSC::WRECGenerator::generateNonGreedyQuantifier):
(JSC::WRECGenerator::generateGreedyQuantifier):
(JSC::WRECGenerator::generateParentheses):
(JSC::WRECGenerator::generateBackreference):
(JSC::WRECGenerator::gernerateDisjunction):
* wrec/WREC.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36307
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 10 Sep 2008 00:07:27 +0000 (00:07 +0000)]
2008-09-09 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Remove unnecessary friend declaration.
* kjs/PropertyMap.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36306
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 9 Sep 2008 23:51:46 +0000 (23:51 +0000)]
Fix the classic look on Windows by resolving the constants conflict between slider parts and buttons/checkboxes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36305
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 9 Sep 2008 23:42:47 +0000 (23:42 +0000)]
2008-09-09 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Replace uses of PropertyMap::get and PropertyMap::getLocation with
PropertyMap::getOffset.
Sunspider reports this as a .6% improvement.
* JavaScriptCore.exp:
* kjs/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::getPropertyAttributes):
* kjs/JSObject.h:
(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectLocation):
(JSC::JSObject::locationForOffset):
* kjs/PropertyMap.cpp:
(JSC::PropertyMap::remove):
(JSC::PropertyMap::getOffset):
* kjs/PropertyMap.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36304
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Tue, 9 Sep 2008 23:36:56 +0000 (23:36 +0000)]
2008-09-05 Chris Marrin <cmarrin@apple.com>
Reviewed by Sam Weinig.
Need to handle the case when 0% or 100% keyframe is omitted
https://bugs.webkit.org/show_bug.cgi?id=20679
Tests: animations/keyframes-from-missing.html
animations/keyframes-to-missing.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::addKeyframeStyle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36303
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 9 Sep 2008 23:11:14 +0000 (23:11 +0000)]
Resurrect RenderThemeWin and bring it up to ToT.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36302
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Tue, 9 Sep 2008 22:35:29 +0000 (22:35 +0000)]
2008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Sam Weinig.
Bug 20754: Remove emit prefix from assembler opcode methods
<https://bugs.webkit.org/show_bug.cgi?id=20754>
* VM/CTI.cpp:
(JSC::CTI::emitGetArg):
(JSC::CTI::emitGetPutArg):
(JSC::CTI::emitPutArg):
(JSC::CTI::emitPutArgConstant):
(JSC::CTI::emitPutCTIParam):
(JSC::CTI::emitGetCTIParam):
(JSC::CTI::emitPutToCallFrameHeader):
(JSC::CTI::emitGetFromCallFrameHeader):
(JSC::CTI::emitPutResult):
(JSC::CTI::emitDebugExceptionCheck):
(JSC::CTI::emitCall):
(JSC::CTI::emitJumpSlowCaseIfNotImm):
(JSC::CTI::emitJumpSlowCaseIfNotImms):
(JSC::CTI::emitFastArithDeTagImmediate):
(JSC::CTI::emitFastArithReTagImmediate):
(JSC::CTI::emitFastArithPotentiallyReTagImmediate):
(JSC::CTI::emitFastArithImmToInt):
(JSC::CTI::emitFastArithIntToImmOrSlowCase):
(JSC::CTI::emitFastArithIntToImmNoCheck):
(JSC::CTI::compileOpCall):
(JSC::CTI::emitSlowScriptCheck):
(JSC::CTI::privateCompileMainPass):
(JSC::CTI::privateCompileSlowCases):
(JSC::CTI::privateCompile):
(JSC::CTI::privateCompileGetByIdSelf):
(JSC::CTI::privateCompileGetByIdProto):
(JSC::CTI::privateCompileGetByIdChain):
(JSC::CTI::privateCompilePutByIdReplace):
(JSC::CTI::privateArrayLengthTrampoline):
(JSC::CTI::privateStringLengthTrampoline):
(JSC::CTI::compileRegExp):
* masm/MacroAssemblerWin.cpp:
(JSC::MacroAssembler::emitConvertToFastCall):
(JSC::MacroAssembler::emitRestoreArgumentReference):
* masm/X86Assembler.h:
(JSC::X86Assembler::pushl_r):
(JSC::X86Assembler::pushl_m):
(JSC::X86Assembler::popl_r):
(JSC::X86Assembler::popl_m):
(JSC::X86Assembler::movl_rr):
(JSC::X86Assembler::addl_rr):
(JSC::X86Assembler::addl_i8r):
(JSC::X86Assembler::addl_i32r):
(JSC::X86Assembler::addl_mr):
(JSC::X86Assembler::andl_rr):
(JSC::X86Assembler::andl_i32r):
(JSC::X86Assembler::cmpl_i8r):
(JSC::X86Assembler::cmpl_rr):
(JSC::X86Assembler::cmpl_rm):
(JSC::X86Assembler::cmpl_i32r):
(JSC::X86Assembler::cmpl_i32m):
(JSC::X86Assembler::cmpw_rm):
(JSC::X86Assembler::orl_rr):
(JSC::X86Assembler::subl_rr):
(JSC::X86Assembler::subl_i8r):
(JSC::X86Assembler::subl_i32r):
(JSC::X86Assembler::subl_mr):
(JSC::X86Assembler::testl_i32r):
(JSC::X86Assembler::testl_rr):
(JSC::X86Assembler::xorl_i8r):
(JSC::X86Assembler::xorl_rr):
(JSC::X86Assembler::sarl_i8r):
(JSC::X86Assembler::sarl_CLr):
(JSC::X86Assembler::shl_i8r):
(JSC::X86Assembler::shll_CLr):
(JSC::X86Assembler::mull_rr):
(JSC::X86Assembler::idivl_r):
(JSC::X86Assembler::cdq):
(JSC::X86Assembler::movl_mr):
(JSC::X86Assembler::movzwl_mr):
(JSC::X86Assembler::movl_rm):
(JSC::X86Assembler::movl_i32r):
(JSC::X86Assembler::movl_i32m):
(JSC::X86Assembler::leal_mr):
(JSC::X86Assembler::ret):
(JSC::X86Assembler::jmp_r):
(JSC::X86Assembler::jmp_m):
(JSC::X86Assembler::call_r):
* wrec/WREC.cpp:
(JSC::WRECGenerator::generateBacktrack1):
(JSC::WRECGenerator::generateBacktrackBackreference):
(JSC::WRECGenerator::generateBackreferenceQuantifier):
(JSC::WRECGenerator::generateNonGreedyQuantifier):
(JSC::WRECGenerator::generateGreedyQuantifier):
(JSC::WRECGenerator::generatePatternCharacter):
(JSC::WRECGenerator::generateCharacterClassInvertedRange):
(JSC::WRECGenerator::generateCharacterClassInverted):
(JSC::WRECGenerator::generateCharacterClass):
(JSC::WRECGenerator::generateParentheses):
(JSC::WRECGenerator::gererateParenthesesResetTrampoline):
(JSC::WRECGenerator::generateAssertionBOL):
(JSC::WRECGenerator::generateAssertionEOL):
(JSC::WRECGenerator::generateAssertionWordBoundary):
(JSC::WRECGenerator::generateBackreference):
(JSC::WRECGenerator::gernerateDisjunction):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36301
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Tue, 9 Sep 2008 20:44:00 +0000 (20:44 +0000)]
2008-09-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Clean up the WREC code some more.
* VM/CTI.cpp:
(JSC::CTI::compileRegExp):
* wrec/WREC.cpp:
(JSC::getCharacterClassNewline):
(JSC::getCharacterClassDigits):
(JSC::getCharacterClassSpaces):
(JSC::getCharacterClassWordchar):
(JSC::getCharacterClassNondigits):
(JSC::getCharacterClassNonspaces):
(JSC::getCharacterClassNonwordchar):
(JSC::WRECGenerator::generateBacktrack1):
(JSC::WRECGenerator::generateBacktrackBackreference):
(JSC::WRECGenerator::generateBackreferenceQuantifier):
(JSC::WRECGenerator::generateNonGreedyQuantifier):
(JSC::WRECGenerator::generateGreedyQuantifier):
(JSC::WRECGenerator::generatePatternCharacter):
(JSC::WRECGenerator::generateCharacterClassInvertedRange):
(JSC::WRECGenerator::generateCharacterClassInverted):
(JSC::WRECGenerator::generateCharacterClass):
(JSC::WRECGenerator::generateParentheses):
(JSC::WRECGenerator::gererateParenthesesResetTrampoline):
(JSC::WRECGenerator::generateAssertionBOL):
(JSC::WRECGenerator::generateAssertionEOL):
(JSC::WRECGenerator::generateAssertionWordBoundary):
(JSC::WRECGenerator::generateBackreference):
(JSC::WRECGenerator::gernerateDisjunction):
(JSC::WRECParser::parseCharacterClass):
(JSC::WRECParser::parseEscape):
(JSC::WRECParser::parseTerm):
* wrec/WREC.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36300
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Tue, 9 Sep 2008 19:50:25 +0000 (19:50 +0000)]
2008-09-09 Dean Jackson <dino@apple.com>
Reviewed by Sam Weinig.
Document::createEvent missing cases for animation and
transition events.
https://bugs.webkit.org/show_bug.cgi?id=20734
Test: transitions/transition-end-event-create.html
Test: animations/animation-events-create.html
* dom/Document.cpp:
(WebCore::Document::createEvent):
- add the two cases
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36299
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log