WebKit-https.git
7 years agoMove WebReferrerPolicy.h from WebKit to Platform
gavinp@chromium.org [Wed, 25 Apr 2012 14:02:08 +0000 (14:02 +0000)]
Move WebReferrerPolicy.h from WebKit to Platform
https://bugs.webkit.org/show_bug.cgi?id=84539

Reviewed by Adam Barth.

Source/Platform:

* Platform.gypi:
* chromium/public/WebReferrerPolicy.h: Copied from Source/WebKit/chromium/public/WebReferrerPolicy.h.
(WebKit):

Source/WebKit/chromium:

* WebKit.gyp:
* public/WebContextMenuData.h:
* public/WebFrame.h:
* public/WebReferrerPolicy.h:
* public/WebSecurityPolicy.h:
* public/platform/WebReferrerPolicy.h: Copied from Source/WebKit/chromium/public/WebReferrerPolicy.h.
* src/AssertMatchingEnums.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago Unfortunately http://trac.webkit.org/changeset/115055 was landed using webkit...
alexis.menard@openbossa.org [Wed, 25 Apr 2012 13:59:20 +0000 (13:59 +0000)]
    Unfortunately trac.webkit.org/changeset/115055 was landed using webkit-patch
        land-from bug but didn't do the right thing, we lost the history.

        This commit is merging back CSSStyleApplyProperty.* and their history, rename the files
        to StyleBuilder and re-apply the two patches on trunk that were apply after the rename.

        Rename CSSStyleSelector class to StyleResolver.
        https://bugs.webkit.org/show_bug.cgi?id=84734

        The name CSSStyleSelector is confusing as it conflicts a bit with
        the CSS concept of selectors. One could think it's an encapsulation
        of the CSS selectors but it's not, in fact this class is responsible
        of finding the RenderStyle for a given element. This is the first patch
        as I will later rename the files, and then rename the local variables.

        Replace occurences of style selector from variables and methods names by style resolver.
        https://bugs.webkit.org/show_bug.cgi?id=84765

        Rename methods and variables to follow the new name StyleResolver. It requires to update the
        local variables, methods parameters, and function names to match the new name and to remove
        the concept of "selector" to avoid clashing with the CSS concept. The next and last patch
        will be to rename CSSStyleSelector file and update the includes.

        Source/WebCore:

        * css/StyleBuilder.cpp: Replaced with Source/WebCore/css/CSSStyleApplyProperty.cpp.
        (WebCore::ApplyPropertyExpanding::applyInheritValue):
        (WebCore::ApplyPropertyExpanding::applyInitialValue):
        (WebCore::ApplyPropertyExpanding::applyValue):
        (WebCore::ApplyPropertyDefaultBase::applyInheritValue):
        (WebCore::ApplyPropertyDefaultBase::applyInitialValue):
        (WebCore::ApplyPropertyDefaultBase::applyValue):
        (WebCore::ApplyPropertyDefault::applyValue):
        (WebCore::ApplyPropertyNumber::applyValue):
        (WebCore::ApplyPropertyStyleImage::applyValue):
        (WebCore::ApplyPropertyAuto::applyInheritValue):
        (WebCore::ApplyPropertyAuto::applyInitialValue):
        (WebCore::ApplyPropertyAuto::applyValue):
        (WebCore::ApplyPropertyClip::convertToLength):
        (WebCore::ApplyPropertyClip::applyInheritValue):
        (WebCore::ApplyPropertyClip::applyInitialValue):
        (WebCore::ApplyPropertyClip::applyValue):
        (WebCore::ApplyPropertyColor::applyInheritValue):
        (WebCore::ApplyPropertyColor::applyInitialValue):
        (WebCore::ApplyPropertyColor::applyValue):
        (WebCore::ApplyPropertyColor::applyColorValue):
        (WebCore::ApplyPropertyDirection::applyValue):
        (WebCore::ApplyPropertyLength::applyValue):
        (WebCore::ApplyPropertyString::applyValue):
        (WebCore::ApplyPropertyBorderRadius::applyValue):
        (WebCore::ApplyPropertyFillLayer::applyInheritValue):
        (WebCore::ApplyPropertyFillLayer::applyInitialValue):
        (WebCore::ApplyPropertyFillLayer::applyValue):
        (WebCore::ApplyPropertyComputeLength::applyValue):
        (WebCore::ApplyPropertyFont::applyInheritValue):
        (WebCore::ApplyPropertyFont::applyInitialValue):
        (WebCore::ApplyPropertyFont::applyValue):
        (WebCore::ApplyPropertyFontSize::applyInheritValue):
        (WebCore::ApplyPropertyFontSize::applyInitialValue):
        (WebCore::ApplyPropertyFontSize::applyValue):
        (WebCore::ApplyPropertyFontWeight::applyValue):
        (WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue):
        (WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue):
        (WebCore::ApplyPropertyFontVariantLigatures::applyValue):
        (WebCore::ApplyPropertyBorderImage::applyValue):
        (WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
        (WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
        (WebCore::ApplyPropertyBorderImageModifier::applyValue):
        (WebCore::ApplyPropertyBorderImageSource::applyValue):
        (WebCore::ApplyPropertyCounter::emptyFunction):
        (WebCore::ApplyPropertyCounter::applyInheritValue):
        (WebCore::ApplyPropertyCounter::applyValue):
        (WebCore::ApplyPropertyCursor::applyInheritValue):
        (WebCore::ApplyPropertyCursor::applyInitialValue):
        (WebCore::ApplyPropertyCursor::applyValue):
        (WebCore::ApplyPropertyTextAlign::applyValue):
        (WebCore::ApplyPropertyTextDecoration::applyValue):
        (WebCore::ApplyPropertyUnicodeBidi::applyValue):
        (WebCore::ApplyPropertyLineHeight::applyValue):
        (WebCore::ApplyPropertyPageSize::applyInheritValue):
        (WebCore::ApplyPropertyPageSize::applyInitialValue):
        (WebCore::ApplyPropertyPageSize::applyValue):
        (WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
        (WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
        (WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
        (WebCore):
        (WebCore::ApplyPropertyAnimation::map):
        (WebCore::ApplyPropertyAnimation::applyInheritValue):
        (WebCore::ApplyPropertyAnimation::applyInitialValue):
        (WebCore::ApplyPropertyAnimation::applyValue):
        (WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
        (WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
        (WebCore::ApplyPropertyOutlineStyle::applyValue):
        (WebCore::ApplyPropertyResize::applyValue):
        (WebCore::ApplyPropertyVerticalAlign::applyValue):
        (WebCore::ApplyPropertyAspectRatio::applyInheritValue):
        (WebCore::ApplyPropertyAspectRatio::applyInitialValue):
        (WebCore::ApplyPropertyAspectRatio::applyValue):
        (WebCore::ApplyPropertyZoom::resetEffectiveZoom):
        (WebCore::ApplyPropertyZoom::applyInheritValue):
        (WebCore::ApplyPropertyZoom::applyInitialValue):
        (WebCore::ApplyPropertyZoom::applyValue):
        (WebCore::ApplyPropertyDisplay::isValidDisplayValue):
        (WebCore::ApplyPropertyDisplay::applyInheritValue):
        (WebCore::ApplyPropertyDisplay::applyInitialValue):
        (WebCore::ApplyPropertyDisplay::applyValue):
        (WebCore::ApplyPropertyFlex::applyInheritValue):
        (WebCore::ApplyPropertyFlex::applyInitialValue):
        (WebCore::ApplyPropertyFlex::applyValue):
        (WebCore::StyleBuilder::StyleBuilder):
        * css/StyleBuilder.h: Replaced with Source/WebCore/css/CSSStyleApplyProperty.h.
        (WebCore):
        (PropertyHandler):
        (WebCore::PropertyHandler::applyInheritValue):
        (WebCore::PropertyHandler::applyInitialValue):
        (WebCore::PropertyHandler::applyValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed, fix Windows build after r115165.
eric.carlson@apple.com [Wed, 25 Apr 2012 13:57:20 +0000 (13:57 +0000)]
Not reviewed, fix Windows build after r115165.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayers): Initialize logging variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK test_expectations update.
philn@webkit.org [Wed, 25 Apr 2012 13:48:55 +0000 (13:48 +0000)]
Unreviewed, GTK test_expectations update.

* platform/gtk/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
Rebaseline after r115187.
* platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
Rebaseline after r115091.
* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Coverity] Uninitialized fields in RenderSVGShape constructors
fmalita@chromium.org [Wed, 25 Apr 2012 13:45:14 +0000 (13:45 +0000)]
[Coverity] Uninitialized fields in RenderSVGShape constructors
https://bugs.webkit.org/show_bug.cgi?id=84749

Reviewed by Darin Adler.

Removing unused RenderSVGShape constructor and field.

No new tests - no behavior change.

* rendering/svg/RenderSVGShape.cpp:
* rendering/svg/RenderSVGShape.h:
(RenderSVGShape):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed: follow up to r115194, removed debug output.
pfeldman@chromium.org [Wed, 25 Apr 2012 13:36:58 +0000 (13:36 +0000)]
Not reviewed: follow up to r115194, removed debug output.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Web Inspector: extract Linkifier from DebuggerPresentationModel.
pfeldman@chromium.org [Wed, 25 Apr 2012 13:34:06 +0000 (13:34 +0000)]
Source/WebCore: Web Inspector: extract Linkifier from DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=84855

Reviewed by Yury Semikhatsky.

There is nothing Linkifier needs from the model, extracting as a top-level class.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/ConsoleMessage.js:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
* inspector/front-end/DebuggerPresentationModel.js:
* inspector/front-end/EventListenersSidebarPane.js:
* inspector/front-end/Linkifier.js: Added.
(WebInspector.LinkifierFormatter):
(WebInspector.LinkifierFormatter.prototype.formatLiveAnchor):
(WebInspector.Linkifier):
(WebInspector.Linkifier.prototype.linkifyLocation):
(WebInspector.Linkifier.prototype.linkifyRawLocation):
(WebInspector.Linkifier.prototype.reset):
(WebInspector.Linkifier.prototype._updateAnchor):
(WebInspector.Linkifier.DefaultFormatter):
(WebInspector.Linkifier.DefaultFormatter.prototype.formatLiveAnchor):
* inspector/front-end/NetworkPanel.js:
* inspector/front-end/ObjectPopoverHelper.js:
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover.showObjectPopover.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
* inspector/front-end/ProfileView.js:
* inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchResultsPane):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

Source/WebKit2: [Qt] Make the web view's url property follow the active url

https://bugs.webkit.org/show_bug.cgi?id=77554

The url property of the webview now reflects the 'active' url of the
page, which maps to either the currently loading url, in the case of
an ongoing load, or the result of a load, even when the load failed.

In practice this means that setting the url though QML, or navigating
to a new url in the page by e.g clicking, will both instantly change
the url-property of the webview to the target url. This differs from
earlier behavior, where we would update the url when the load
committed.

An optional argument is added to loadHtml(), to allow setting
the unreachable url when providing replacement content for failed
loads.

A slight change in the activeUrl() implementation is also done,
where we now favour the url of an pending API request, even when
we don't have a mainframe yet.

Finally, the location bar in the minibrowser is updated to behave
a bit more like normal browsers in terms of when the url will change
and how active focus is handled.

Patch by Tor Arne Vestbø <tor.arne.vestbo@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::onComponentComplete):
(QQuickWebView::reload):
(QQuickWebView::url):
(QQuickWebView::setUrl):
(QQuickWebView::loadHtml):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro:
* UIProcess/API/qt/tests/qmltests/WebView.pro:
* UIProcess/API/qt/tests/qmltests/WebView/tst_loadUrl.qml:
* UIProcess/API/qt/tests/qmltests/common/link.html: Added.
* UIProcess/API/qt/tests/qmltests/common/redirect.html: Added.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::activeURL):
* UIProcess/qt/QtWebPageLoadClient.cpp:
(QtWebPageLoadClient::QtWebPageLoadClient):
(QtWebPageLoadClient::didStartProvisionalLoadForFrame):
(QtWebPageLoadClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(QtWebPageLoadClient::didCommitLoadForFrame):
(QtWebPageLoadClient::dispatchLoadFailed):
(QtWebPageLoadClient::didFailProvisionalLoadWithErrorForFrame):
(QtWebPageLoadClient::didFailLoadWithErrorForFrame):
* UIProcess/qt/QtWebPageLoadClient.h:
(QtWebPageLoadClient):

LayoutTests: Web Inspector: extract Linkifier from DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=84855

Reviewed by Yury Semikhatsky.

* inspector/debugger/linkifier.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Zoom back can overscroll document edges.
commit-queue@webkit.org [Wed, 25 Apr 2012 13:32:19 +0000 (13:32 +0000)]
[Qt] Zoom back can overscroll document edges.
https://bugs.webkit.org/show_bug.cgi?id=84851

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-25
Reviewed by Kenneth Rohde Christiansen.

.:

Manual test for overscroll on zoom-back. Needs to be manual since we do not yet
have automatic testing for this type of UI-side behaviour.

* ManualTests/qt/double-tap-overscroll.html: Added.

Source/WebKit2:

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: move sourcemap-agnostic part of the debugger presentation model into...
pfeldman@chromium.org [Wed, 25 Apr 2012 13:31:15 +0000 (13:31 +0000)]
Web Inspector: move sourcemap-agnostic part of the debugger presentation model into the raw debugger.
https://bugs.webkit.org/show_bug.cgi?id=84852

Reviewed by Yury Semikhatsky.

Source/WebCore:

There is no need to keep that much debugging functionality in the debugger presentation model.
It all perfectly applies to the raw script debugger. Methods for selecting call frames, activating breakpoints
and paused details were moved to the WebInspector.DebuggerModel.

* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._removeBreakpointFromUI):
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane):
(WebInspector.CallStackSidebarPane.prototype.update):
(WebInspector.CallStackSidebarPane.prototype.setSelectedCallFrame):
(WebInspector.CallStackSidebarPane.prototype._selectedCallFrameIndex):
(WebInspector.CallStackSidebarPane.prototype._placardSelected):
(WebInspector.CallStackSidebarPane.Placard):
(WebInspector.CallStackSidebarPane.Placard.prototype._update):
* inspector/front-end/ConsoleView.js:
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype._globalObjectCleared):
(WebInspector.DebuggerModel.prototype._didEditScriptSource):
(WebInspector.DebuggerModel.prototype._setDebuggerPausedDetails):
(WebInspector.DebuggerModel.prototype._pausedScript):
(WebInspector.DebuggerModel.prototype._resumedScript):
(WebInspector.DebuggerModel.prototype.isPaused):
(WebInspector.DebuggerModel.prototype.setSelectedCallFrame.updateExecutionLine):
(WebInspector.DebuggerModel.prototype.setSelectedCallFrame):
(WebInspector.DebuggerModel.prototype.selectedCallFrame):
(WebInspector.DebuggerModel.prototype.evaluateOnSelectedCallFrame):
(WebInspector.DebuggerModel.prototype.getSelectedCallFrameVariables.propertiesCollected):
(WebInspector.DebuggerModel.prototype.getSelectedCallFrameVariables):
(WebInspector.DebuggerModel.prototype.setBreakpointsActive):
(WebInspector.DebuggerModel.prototype.breakpointsActive):
(WebInspector.DebuggerModel.CallFrame):
(WebInspector.DebuggerModel.CallFrame.prototype.get script):
(WebInspector.DebuggerModel.CallFrame.prototype.get type):
(WebInspector.DebuggerModel.CallFrame.prototype.get scopeChain):
(WebInspector.DebuggerModel.CallFrame.prototype.get this):
(WebInspector.DebuggerModel.CallFrame.prototype.get functionName):
(WebInspector.DebuggerModel.CallFrame.prototype.get location):
(WebInspector.DebuggerModel.CallFrame.prototype.evaluate):
(WebInspector.DebuggerModel.CallFrame.prototype.createLiveLocation):
(WebInspector.DebuggerModel.CallFrame.prototype.dispose):
(WebInspector.DebuggerPausedDetails):
(WebInspector.DebuggerPausedDetails.prototype.dispose):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.createLiveLocation):
(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._callFrameSelected):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource.prototype.setBreakpoint):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover):
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.setSourceMapping):
(WebInspector.Script.prototype.createLiveLocation):
(WebInspector.Script.Location.prototype.update):
* inspector/front-end/ScriptMapping.js:
(WebInspector.LiveLocation):
(WebInspector.LiveLocation.prototype.update):
(WebInspector.LiveLocation.prototype.dispose):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._consoleCommandEvaluatedInSelectedCallFrame):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
(WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
* inspector/front-end/UISourceCode.js:

LayoutTests:

* http/tests/inspector/debugger-test.js:
* inspector/debugger/callstack-placards-discarded.html:
* inspector/debugger/debugger-breakpoints-not-activated-on-reload.html:
* inspector/debugger/live-edit-expected.txt:
* inspector/debugger/scripts-panel.html:
* inspector/debugger/selected-call-frame-after-formatting-source.html:
* inspector/debugger/set-breakpoint.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Make the web view's url property follow the active url
vestbo@webkit.org [Wed, 25 Apr 2012 13:29:00 +0000 (13:29 +0000)]
[Qt] Make the web view's url property follow the active url

https://bugs.webkit.org/show_bug.cgi?id=77554

The url property of the webview now reflects the 'active' url of the
page, which maps to either the currently loading url, in the case of
an ongoing load, or the result of a load, even when the load failed.

In practice this means that setting the url though QML, or navigating
to a new url in the page by e.g clicking, will both instantly change
the url-property of the webview to the target url. This differs from
earlier behavior, where we would update the url when the load
committed.

An optional argument is added to loadHtml(), to allow setting
the unreachable url when providing replacement content for failed
loads.

A slight change in the activeUrl() implementation is also done,
where we now favour the url of an pending API request, even when
we don't have a mainframe yet.

Finally, the location bar in the minibrowser is updated to behave
a bit more like normal browsers in terms of when the url will change
and how active focus is handled.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update
mnaganov@chromium.org [Wed, 25 Apr 2012 13:15:06 +0000 (13:15 +0000)]
[Chromium] Unreviewed test expectations update
https://bugs.webkit.org/show_bug.cgi?id=84854

Mark the following tests as flaky on Linux 32-bit:

    svg/batik/text/textOnPath.svg
    svg/batik/text/verticalTextOnPath.svg

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: use composite node provider for diff nodes in heap profiler
yurys@chromium.org [Wed, 25 Apr 2012 12:32:01 +0000 (12:32 +0000)]
Web Inspector: use composite node provider for diff nodes in heap profiler
https://bugs.webkit.org/show_bug.cgi?id=84849

Inroduced HeapSnapshotDiffNodesProvider which is basically a composite provider
combining providers for added and deleted nodes. This allowed to remove custom
implementation of HeapSnapshotGridNode.prototype.populateChildren.

Source/WebCore:

Reviewed by Pavel Feldman.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNodesProvider.prototype.sort.sortByNodeField): moved index assignment to sortByComparator
so that it is done only once.
(WebInspector.HeapSnapshotNodesProvider.prototype.sort.sortByComparator):
(WebInspector.HeapSnapshotNodesProvider.prototype.sort):
* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved.notify):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotDiffNodesProvider):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.dispose):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.isEmpty):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.serializeNextItems):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.serializeNextItems.didReceiveDeletedItems):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.serializeNextItems.didReceiveAddedItems):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.sortAndRewind.afterSort):
(WebInspector.HeapSnapshotDiffNodesProvider.prototype.sortAndRewind):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode._createProvider):
(WebInspector.HeapSnapshotDiffNode.prototype._createChildNode):

LayoutTests:

       Reviewed by Pavel Feldman.

* inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html:
* inspector/profiler/heap-snapshot-comparison-show-all.html:
* inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Gardening. Skipped a failing test.
ossy@webkit.org [Wed, 25 Apr 2012 12:25:13 +0000 (12:25 +0000)]
[Qt] Gardening. Skipped a failing test.
https://bugs.webkit.org/show_bug.cgi?id=84566

Removed a test from test_expectations after r115171.

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-04-25
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:
* platform/qt/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactor to/from/animatedType creation, to share more code between animators
zimmermann@webkit.org [Wed, 25 Apr 2012 11:57:39 +0000 (11:57 +0000)]
Refactor to/from/animatedType creation, to share more code between animators
https://bugs.webkit.org/show_bug.cgi?id=84846

Reviewed by Antti Koivisto.

Source/WebCore:

Share more code bewteen animators, doesn't change functionality yet, except for one bug in SVGAnimatedString.
SVGAnimatedString used to mutate the from/to values during animation, leading to problems in animate-element-31-t.svg.
It now needs a rebaseline, now that this bug is fixed as side-effect.

* svg/SVGAnimateColorElement.cpp:
(WebCore::attributeValueIsCurrentColor):
(WebCore::SVGAnimateColorElement::determinePropertyValueTypes):
(WebCore):
* svg/SVGAnimateColorElement.h:
(SVGAnimateColorElement):
* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::SVGAnimateElement):
* svg/SVGAnimateElement.h:
(SVGAnimateElement):
* svg/SVGAnimatedAngle.cpp:
(WebCore::SVGAnimatedAngleAnimator::calculateAnimatedValue):
* svg/SVGAnimatedBoolean.cpp:
(WebCore::SVGAnimatedBooleanAnimator::calculateAnimatedValue):
* svg/SVGAnimatedColor.cpp:
(WebCore::adjustForCurrentColor):
(WebCore):
(WebCore::parseColorFromString):
(WebCore::SVGAnimatedColorAnimator::calculateAnimatedValue):
* svg/SVGAnimatedEnumeration.cpp:
(WebCore::SVGAnimatedEnumerationAnimator::calculateAnimatedValue):
* svg/SVGAnimatedInteger.cpp:
(WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedInteger):
(WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedValue):
* svg/SVGAnimatedIntegerOptionalInteger.cpp:
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::calculateAnimatedValue):
* svg/SVGAnimatedLength.cpp:
(WebCore::parseLengthFromString):
(WebCore):
(WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):
* svg/SVGAnimatedLengthList.cpp:
(WebCore::parseLengthListFromString):
(WebCore):
(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
* svg/SVGAnimatedNumber.cpp:
(WebCore::parseNumberFromString):
(WebCore):
(WebCore::SVGAnimatedNumberAnimator::calculateAnimatedValue):
* svg/SVGAnimatedNumberList.cpp:
(WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue):
* svg/SVGAnimatedNumberOptionalNumber.cpp:
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::calculateAnimatedValue):
* svg/SVGAnimatedPointList.cpp:
(WebCore::SVGAnimatedPointListAnimator::calculateAnimatedValue):
* svg/SVGAnimatedPreserveAspectRatio.cpp:
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateAnimatedValue):
* svg/SVGAnimatedRect.cpp:
(WebCore::SVGAnimatedRectAnimator::calculateAnimatedValue):
* svg/SVGAnimatedString.cpp:
(WebCore::parseStringFromString):
(WebCore):
(WebCore::SVGAnimatedStringAnimator::calculateAnimatedValue):
* svg/SVGAnimatedTransformList.cpp:
(WebCore::SVGAnimatedTransformListAnimator::calculateAnimatedValue):
* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::SVGAnimationElement):
(WebCore::SVGAnimationElement::adjustForInheritance):
(WebCore):
(WebCore::inheritsFromProperty):
(WebCore::SVGAnimationElement::determinePropertyValueTypes):
* svg/SVGAnimationElement.h:
(WebCore::SVGAnimationElement::fromPropertyValueType):
(WebCore::SVGAnimationElement::toPropertyValueType):
(SVGAnimationElement):
(WebCore::SVGAnimationElement::adjustForInheritance):
(WebCore::SVGAnimationElement::adjustFromToValues):
(WebCore::SVGAnimationElement::adjustFromToListValues):

LayoutTests:

Rebaseline one test result, which shows a progression.
(At the initial time when we capture the result, only two circles should be visible.)

* platform/chromium/test_expectations.txt:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update
mnaganov@chromium.org [Wed, 25 Apr 2012 11:54:46 +0000 (11:54 +0000)]
[Chromium] Unreviewed test expectations update
https://bugs.webkit.org/show_bug.cgi?id=84847

Mark inspector/timeline/timeline-start-time.html as flaky on Windows.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update
mnaganov@chromium.org [Wed, 25 Apr 2012 11:46:23 +0000 (11:46 +0000)]
[Chromium] Unreviewed test expectations update

Unmark the following CSS pseudo-class tests:

    fast/css/empty-pseudo-class.html
    fast/css/first-child-pseudo-class.html
    fast/css/first-of-type-pseudo-class.html
    fast/css/last-child-pseudo-class.html
    fast/css/last-of-type-pseudo-class.html
    fast/css/only-child-pseudo-class.html
    fast/css/only-of-type-pseudo-class.html

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebkit build fails due to missing gstreamer include file on Kubuntu 8.04
commit-queue@webkit.org [Wed, 25 Apr 2012 11:36:22 +0000 (11:36 +0000)]
Webkit build fails due to missing gstreamer include file on Kubuntu 8.04
https://bugs.webkit.org/show_bug.cgi?id=81913

Patch by Philippe Normand <pnormand@igalia.com> on 2012-04-25
Reviewed by Tor Arne Vestbø.

Source/WTF:

* WTF.pri: GStreamer build support implies GLib support, as it's
done in WebCore.pri.

Tools:

* qmake/mkspecs/features/features.prf: Check for gstreamer-0.10
and gstreamer-plugins-base >= 0.10.30 just like the GTK port
does. 0.10.27 is unfortunately not recent enough to get the media
player working reliably.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update
mnaganov@chromium.org [Wed, 25 Apr 2012 11:17:44 +0000 (11:17 +0000)]
[Chromium] Unreviewed test expectations update

Remove expectation for a passing test:
    fast/dom/error-to-string-stack-overflow.html

Add an expectation for a passing test:
    fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Run tests in '/http/tests/local' with local URI
commit-queue@webkit.org [Wed, 25 Apr 2012 11:01:42 +0000 (11:01 +0000)]
[BlackBerry] Run tests in '/http/tests/local' with local URI
https://bugs.webkit.org/show_bug.cgi?id=84820

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-04-25
Reviewed by Nikolas Zimmermann.

Currently we run all tests under folder "/http/tests/" as HTTP
tests (http://...). However in WebKit ORWT and NRWT scripts, tests in
'http/tests/local' are run with local path (like '/developer/LayoutTests
/http/tests/local/absolute-url-strip-whitespace.html').
With this patch we can keep the same behaviour as other portings.

* DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::isHTTPTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update
mnaganov@chromium.org [Wed, 25 Apr 2012 10:44:33 +0000 (10:44 +0000)]
[Chromium] Unreviewed test expectations update

Unmark these tests as failing on Windows:
    fast/repaint/moving-shadow-on-container.html
    fast/repaint/moving-shadow-on-path.html

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update
mnaganov@chromium.org [Wed, 25 Apr 2012 10:40:51 +0000 (10:40 +0000)]
[Chromium] Unreviewed test expectations update
https://bugs.webkit.org/show_bug.cgi?id=84813

Mark these tests as failing only on Mac and Windows:

    css3/filters/custom/custom-filter-shader-cache.html
    css3/filters/custom/effect-custom-combined-missing.html
    css3/filters/custom/effect-custom.html

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update
mnaganov@chromium.org [Wed, 25 Apr 2012 10:34:52 +0000 (10:34 +0000)]
[Chromium] Unreviewed test expectations update

Unmark html5lib/runner.html -- changes that broke it were reverted in r115149.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShare single calculateFromToValues/calculateFromByValues between all SVGAnimatedTypeA...
zimmermann@webkit.org [Wed, 25 Apr 2012 10:05:06 +0000 (10:05 +0000)]
Share single calculateFromToValues/calculateFromByValues between all SVGAnimatedTypeAnimators
https://bugs.webkit.org/show_bug.cgi?id=84832

Reviewed by Antti Koivisto.

calculateFromAndToValues / calculateFromAndByValues don't need to be spread across all SVGAnimatedTypeAnimators.
Centralize these new implementations in SVGAnimatedTypeAnimator.h. Refactored addAnimatedTypes() from constructFromAndByValues.

calculateFromAndToValues:
    from = constructFromString(fromString)
    to = constructFromString(toString)

calculateFromAndByValues:
    from = constructFromString(fromString)
    to = constructFromString(byString)
    addAnimatedTypes(from, to)

Doesn't affect any tests, just refactors code.

* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::calculateFromAndToValues):
(WebCore::SVGAnimateElement::calculateFromAndByValues):
* svg/SVGAnimatedAngle.cpp:
(WebCore::SVGAnimatedAngleAnimator::addAnimatedTypes):
* svg/SVGAnimatedAngle.h:
(SVGAnimatedAngleAnimator):
* svg/SVGAnimatedBoolean.cpp:
(WebCore::SVGAnimatedBooleanAnimator::addAnimatedTypes):
* svg/SVGAnimatedBoolean.h:
(SVGAnimatedBooleanAnimator):
* svg/SVGAnimatedColor.cpp:
(WebCore::SVGAnimatedColorAnimator::addAnimatedTypes):
* svg/SVGAnimatedColor.h:
(SVGAnimatedColorAnimator):
* svg/SVGAnimatedEnumeration.cpp:
(WebCore::SVGAnimatedEnumerationAnimator::addAnimatedTypes):
* svg/SVGAnimatedEnumeration.h:
(SVGAnimatedEnumerationAnimator):
* svg/SVGAnimatedInteger.cpp:
(WebCore::SVGAnimatedIntegerAnimator::addAnimatedTypes):
* svg/SVGAnimatedInteger.h:
(SVGAnimatedIntegerAnimator):
* svg/SVGAnimatedIntegerOptionalInteger.cpp:
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::addAnimatedTypes):
* svg/SVGAnimatedIntegerOptionalInteger.h:
(SVGAnimatedIntegerOptionalIntegerAnimator):
* svg/SVGAnimatedLength.cpp:
(WebCore::SVGAnimatedLengthAnimator::addAnimatedTypes):
* svg/SVGAnimatedLength.h:
(SVGAnimatedLengthAnimator):
* svg/SVGAnimatedLengthList.cpp:
(WebCore::SVGAnimatedLengthListAnimator::addAnimatedTypes):
* svg/SVGAnimatedLengthList.h:
(SVGAnimatedLengthListAnimator):
* svg/SVGAnimatedNumber.cpp:
(WebCore::SVGAnimatedNumberAnimator::addAnimatedTypes):
* svg/SVGAnimatedNumber.h:
(SVGAnimatedNumberAnimator):
* svg/SVGAnimatedNumberList.cpp:
(WebCore::SVGAnimatedNumberListAnimator::addAnimatedTypes):
* svg/SVGAnimatedNumberList.h:
(SVGAnimatedNumberListAnimator):
* svg/SVGAnimatedNumberOptionalNumber.cpp:
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::addAnimatedTypes):
* svg/SVGAnimatedNumberOptionalNumber.h:
(SVGAnimatedNumberOptionalNumberAnimator):
* svg/SVGAnimatedPath.cpp:
(WebCore::SVGAnimatedPathAnimator::constructFromString):
(WebCore::SVGAnimatedPathAnimator::addAnimatedTypes):
* svg/SVGAnimatedPath.h:
(SVGAnimatedPathAnimator):
* svg/SVGAnimatedPointList.cpp:
(WebCore::SVGAnimatedPointListAnimator::addAnimatedTypes):
* svg/SVGAnimatedPointList.h:
(SVGAnimatedPointListAnimator):
* svg/SVGAnimatedPreserveAspectRatio.cpp:
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::addAnimatedTypes):
* svg/SVGAnimatedPreserveAspectRatio.h:
(SVGAnimatedPreserveAspectRatioAnimator):
* svg/SVGAnimatedRect.cpp:
(WebCore::SVGAnimatedRectAnimator::addAnimatedTypes):
* svg/SVGAnimatedRect.h:
(SVGAnimatedRectAnimator):
* svg/SVGAnimatedString.cpp:
(WebCore::SVGAnimatedStringAnimator::addAnimatedTypes):
* svg/SVGAnimatedString.h:
(SVGAnimatedStringAnimator):
* svg/SVGAnimatedTransformList.cpp:
(WebCore::SVGAnimatedTransformListAnimator::SVGAnimatedTransformListAnimator):
(WebCore::SVGAnimatedTransformListAnimator::constructFromString):
(WebCore::SVGAnimatedTransformListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedTransformListAnimator::calculateDistance):
* svg/SVGAnimatedTransformList.h:
(SVGAnimatedTransformListAnimator):
* svg/SVGAnimatedTypeAnimator.h:
(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::calculateFromAndToValues):
(WebCore::SVGAnimatedTypeAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedTypeAnimator::setContextElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShrink RenderText by 8 bytes on 64-bit.
kling@webkit.org [Wed, 25 Apr 2012 08:18:52 +0000 (08:18 +0000)]
Shrink RenderText by 8 bytes on 64-bit.
<http://webkit.org/b/84828>

Reviewed by Maciej Stachowiak.

Reorder the members so that the bits in RenderText falls into the padding at
the end of RenderObject on 64-bit. Updated the compile-time size assertion to
account for the new object structure.

This shrinks RenderText from 104 to 96 bytes on 64-bit release builds.

* rendering/RenderText.cpp:
(SameSizeAsRenderText):
(WebCore::RenderText::RenderText):
* rendering/RenderText.h:
(RenderText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Unskipped 28 http tests passing on all the GTK+ bots.
sergio@webkit.org [Wed, 25 Apr 2012 08:09:40 +0000 (08:09 +0000)]
Unreviewed. Unskipped 28 http tests passing on all the GTK+ bots.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-04-25 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 25 Apr 2012 07:56:24 +0000 (07:56 +0000)]
2012-04-25  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Update pixel test baseline on Lion. All color space changes when painting images.
        I noticed that svg/custom/focus-ring.svg is flakey, the result may be off by two 1px changes.

        * platform/mac/svg/as-background-image/svg-as-background-4-expected.png:
        * platform/mac/svg/as-border-image/svg-as-border-image-2-expected.png:
        * platform/mac/svg/carto.net/window-expected.png:
        * platform/mac/svg/custom/createImageElement-expected.png:
        * platform/mac/svg/custom/createImageElement2-expected.png:
        * platform/mac/svg/custom/deep-dynamic-updates-expected.png:
        * platform/mac/svg/custom/focus-ring-expected.png:
        * platform/mac/svg/custom/image-parent-translation-expected.png:
        * platform/mac/svg/custom/image-small-width-height-expected.png:
        * platform/mac/svg/custom/image-with-prefix-in-webarchive-expected.png:
        * platform/mac/svg/custom/image-with-transform-clip-filter-expected.png:
        * platform/mac/svg/custom/js-update-image-and-display-expected.png:
        * platform/mac/svg/custom/js-update-image-and-display2-expected.png:
        * platform/mac/svg/custom/js-update-image-and-display3-expected.png:
        * platform/mac/svg/custom/js-update-image-expected.png:
        * platform/mac/svg/custom/pointer-events-image-css-transform-expected.png:
        * platform/mac/svg/custom/pointer-events-image-expected.png:
        * platform/mac/svg/custom/text-image-opacity-expected.png:
        * platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
        * platform/mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
        * platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
        * platform/mac/svg/wicd/test-rightsizing-b-expected.png:
        * platform/mac/svg/zoom/page/zoom-background-images-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNo audio from MediaElementAudioSourceNode
commit-queue@webkit.org [Wed, 25 Apr 2012 07:55:46 +0000 (07:55 +0000)]
No audio from MediaElementAudioSourceNode
https://bugs.webkit.org/show_bug.cgi?id=84669

MediaElementAudioSourceNode needs custom propagatesSilence() to
return false to indicate the node never propagates silence.

Patch by Raymond Toy <rtoy@google.com> on 2012-04-25
Reviewed by Chris Rogers.

* Modules/webaudio/MediaElementAudioSourceNode.h:
(MediaElementAudioSourceNode): Add propagatesSilence().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Reset DRT settings to their default values after a testcase was executed.
commit-queue@webkit.org [Wed, 25 Apr 2012 07:39:19 +0000 (07:39 +0000)]
[EFL][DRT] Reset DRT settings to their default values after a testcase was executed.
https://bugs.webkit.org/show_bug.cgi?id=84709

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-04-25
Reviewed by Eric Seidel.

Not all the settings that can be changed by layout testcases through a JS API were
reset in DumpRenderTreeChrome::resetDefaultsToConsistentValues().

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(defaultEditingBehavior): returns editing behavior depending on current platform.
(DumpRenderTreeChrome::resetDefaultsToConsistentValues): reset some missed DRT settings

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Web Inspector: Incorrect highlight position of inspected element...
wangxianzhu@chromium.org [Wed, 25 Apr 2012 07:11:21 +0000 (07:11 +0000)]
Source/WebCore: Web Inspector: Incorrect highlight position of inspected element in a scrolled page
https://bugs.webkit.org/show_bug.cgi?id=84755

Reviewed by Pavel Feldman.

Test: inspector/elements/highlight-node-scroll.html

* inspector/DOMNodeHighlighter.cpp: Ensures the highlight position is in page coordinates.

LayoutTests: Web Inspector: REGRESSION: Incorrect highlight position of inspected element in scrolled page
https://bugs.webkit.org/show_bug.cgi?id=84755

Reviewed by Pavel Feldman.

* http/tests/inspector/elements-test.js: Extracted common function dumpInspectorHighlightRects() into here with a small bug fixed (x and y inversed).
* inspector/elements/highlight-node-scaled-expected.txt: Corrected the wrong inversed x and y.
* inspector/elements/highlight-node-scaled.html: Extracted out dumpInspectorHighlightRects().
* inspector/elements/highlight-node-scroll-expected.txt: Added. Expectation of the new test case.
* inspector/elements/highlight-node-scroll.html: Added. The new test case.
* inspector/elements/highlight-node.html: Extracted out dumpInspectorHighlightRects(). Expectation not changed because the x and y happened to be the same in the original expectation.
* inspector/elements/highlight-svg-root.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed morning gardening after r115091.
ossy@webkit.org [Wed, 25 Apr 2012 07:08:18 +0000 (07:08 +0000)]
[Qt] Unreviewed morning gardening after r115091.

* platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
* platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed morning gardening after r115085.
ossy@webkit.org [Wed, 25 Apr 2012 07:02:01 +0000 (07:02 +0000)]
[Qt] Unreviewed morning gardening after r115085.

* platform/qt/Skipped: Unskip a non-existing test.
* platform/qt/svg/custom/embedding-external-svgs-expected.txt:
* platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
* platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
* platform/qt/svg/custom/use-clipped-hit-expected.txt:
* platform/qt/svg/custom/use-modify-target-symbol-expected.txt:
* platform/qt/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
* platform/qt/svg/custom/use-setAttribute-crash-expected.txt:
* platform/qt/svg/custom/use-symbol-overflow-expected.txt:
* platform/wk2/Skipped: Unskip a non-existing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Skip inspector/profiler/heap-snapshot-comparison-dom-groups-change.html
yurys@chromium.org [Wed, 25 Apr 2012 07:00:56 +0000 (07:00 +0000)]
Unreviewed. Skip inspector/profiler/heap-snapshot-comparison-dom-groups-change.html
on Win and Win Cairo in addition to Mac and Qt(JSC doesn't support heap profiling and
the test doesn't make sense there).

* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK svg rebaseline after r115085.
philn@webkit.org [Wed, 25 Apr 2012 06:52:37 +0000 (06:52 +0000)]
Unreviewed, GTK svg rebaseline after r115085.

* platform/gtk/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
* platform/gtk/svg/carto.net/button-expected.txt:
* platform/gtk/svg/carto.net/colourpicker-expected.txt:
* platform/gtk/svg/carto.net/slider-expected.txt:
* platform/gtk/svg/carto.net/window-expected.txt:
* platform/gtk/svg/custom/embedding-external-svgs-expected.txt:
* platform/gtk/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
* platform/gtk/svg/custom/relative-sized-use-on-symbol-expected.txt:
* platform/gtk/svg/custom/use-clipped-hit-expected.txt:
* platform/gtk/svg/custom/use-modify-target-symbol-expected.txt:
* platform/gtk/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
* platform/gtk/svg/custom/use-on-g-containing-symbol-expected.txt:
* platform/gtk/svg/custom/use-on-symbol-expected.txt:
* platform/gtk/svg/custom/use-recalcStyle-crash-expected.txt:
* platform/gtk/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
* platform/gtk/svg/custom/use-setAttribute-crash-expected.txt:
* platform/gtk/svg/custom/use-symbol-overflow-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-04-24 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 25 Apr 2012 06:37:02 +0000 (06:37 +0000)]
2012-04-24  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Revert part of the change r115063 which commented out
        real worker creation. It was commited by mistake.

        * inspector/front-end/HeapSnapshotProxy.js:
        (WebInspector.HeapSnapshotWorker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNew Notification constructor do not take into account security origin permissions
jonlee@apple.com [Wed, 25 Apr 2012 05:52:46 +0000 (05:52 +0000)]
New Notification constructor do not take into account security origin permissions
https://bugs.webkit.org/show_bug.cgi?id=84825
<rdar://problem/11315405>

Reviewed by Darin Adler.

Tests requires support for notifications on Mac (see 79492).

When the task timer fires, we should check to see that the notification has permission
to show. If not, we fire the onError event.

* notifications/Notification.cpp:
(WebCore::Notification::Notification): Since the timer may show, or call the onerror event,
we rename it from m_showTaskTimer. to m_taskTimer.
(WebCore::Notification::dispatchErrorEvent): The default constructor of ErrorEvent doesn't
create the proper event object. Create it using Event::create().
(WebCore::Notification::taskTimerFired): Check to see that we have permission first.
* notifications/Notification.h:
(Notification):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a logging channel and some ouput for compositing
simon.fraser@apple.com [Wed, 25 Apr 2012 04:30:13 +0000 (04:30 +0000)]
Add a logging channel and some ouput for compositing
https://bugs.webkit.org/show_bug.cgi?id=84817

Reviewed by Darin Adler.

Add a logging channel called "Compositing".

Output useful information to this channel, including
a line for each composited layer, its composited bounds,
the reason it was composited, the backing store megapixels,
and a count of total composited layers and total backing
store megapixels.

* platform/Logging.cpp:
(WebCore):
(WebCore::getChannelFromName):
* platform/Logging.h:
(WebCore):
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::backingStoreArea):
* platform/graphics/GraphicsLayer.h:
(GraphicsLayer):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::backingStoreArea):
(WebCore):
* platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
* platform/mac/LoggingMac.mm:
(WebCore::initializeLoggingChannelsIfNecessary):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::nameForLayer):
(WebCore::RenderLayerBacking::backingStoreArea):
(WebCore):
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):
* rendering/RenderLayerCompositor.cpp:
(WebCore):
(WebCore::compositingLogEnabled):
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::logCompositingInfo):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
(WebCore::RenderLayerCompositor::reasonForCompositing):
* rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agogetMatchedCSSRules() should return null when the second argument is an unrecognized...
commit-queue@webkit.org [Wed, 25 Apr 2012 03:25:14 +0000 (03:25 +0000)]
getMatchedCSSRules() should return null when the second argument is an unrecognized pseudo-element name
https://bugs.webkit.org/show_bug.cgi?id=83298

Patch by Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org> on 2012-04-24
Reviewed by Ojan Vafai.

Source/WebCore:

I couldn't find any specification or any meaningful discussion on this API, but I
assume that it shouldn't be any different from window.getComputedStyle()
as far as the parameters are concerned.

Test: fast/dom/Window/getMatchedCSSRules-with-invalid-pseudo-elements.html

* page/DOMWindow.cpp:
(WebCore::DOMWindow::getMatchedCSSRules):
* page/DOMWindow.idl:

LayoutTests:

* fast/dom/Window/getMatchedCSSRules-with-invalid-pseudo-elements-expected.txt: Added.
* fast/dom/Window/getMatchedCSSRules-with-invalid-pseudo-elements.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agooverflow: hidden on the main frame is broken with threaded scrolling
andersca@apple.com [Wed, 25 Apr 2012 03:02:38 +0000 (03:02 +0000)]
overflow: hidden on the main frame is broken with threaded scrolling
https://bugs.webkit.org/show_bug.cgi?id=84819
<rdar://problem/10920677>

Reviewed by Darin Adler.

Pass along the horizontal and vertical scrollbar modes to the scrolling tree and use it
to determine if wheel events should be handled or not. This matches what we do for non-threaded scrolling.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::setScrollParameters):
* page/scrolling/ScrollingCoordinator.h:
(ScrollParameters):
* page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::ScrollingTreeNode):
(WebCore::ScrollingTreeNode::update):
* page/scrolling/ScrollingTreeNode.h:
(WebCore::ScrollingTreeNode::canHaveScrollbars):
(ScrollingTreeNode):
* page/scrolling/ScrollingTreeState.cpp:
(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::setHorizontalScrollbarMode):
(WebCore):
(WebCore::ScrollingTreeState::setVerticalScrollbarMode):
* page/scrolling/ScrollingTreeState.h:
(WebCore::ScrollingTreeState::horizontalScrollbarMode):
(ScrollingTreeState):
(WebCore::ScrollingTreeState::verticalScrollbarMode):
* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::handleWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Don't call calculateRenderPasses in CCLayerTreeHostImpl::scrollBegin()
enne@google.com [Wed, 25 Apr 2012 02:58:04 +0000 (02:58 +0000)]
[chromium] Don't call calculateRenderPasses in CCLayerTreeHostImpl::scrollBegin()
https://bugs.webkit.org/show_bug.cgi?id=84807

Reviewed by James Robinson.

Instead of calculate render passes and quads and tracking damage,
simply calculate the updated render layer list, which is what is
needed for scrolling.  This prevents a willDraw/didDraw mismatch on
layers.

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::ensureMostRecentRenderSurfaceLayerList):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unbounded draws should use clip to limit their damage to opaque tracking
danakj@chromium.org [Wed, 25 Apr 2012 02:46:46 +0000 (02:46 +0000)]
[chromium] Unbounded draws should use clip to limit their damage to opaque tracking
https://bugs.webkit.org/show_bug.cgi?id=84494

Reviewed by Adrienne Walker.

Source/WebCore:

Unit test: PlatformContextSkiaTest.UnboundedDrawsAreClipped

* platform/graphics/skia/OpaqueRegionSkia.cpp:
(WebCore::OpaqueRegionSkia::didDrawRect):
(WebCore::OpaqueRegionSkia::didDrawPath):
(WebCore::OpaqueRegionSkia::didDrawPoints):
(WebCore::OpaqueRegionSkia::didDrawBounded):
(WebCore::OpaqueRegionSkia::didDrawUnbounded):
* platform/graphics/skia/OpaqueRegionSkia.h:
(OpaqueRegionSkia):

Source/WebKit/chromium:

* tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement createTBody for table element.
alexis.menard@openbossa.org [Wed, 25 Apr 2012 02:11:26 +0000 (02:11 +0000)]
Implement createTBody for table element.
https://bugs.webkit.org/show_bug.cgi?id=84465

Reviewed by Ojan Vafai.

Source/WebCore:

Implement createTBody of table element to allow creating tbodies from JS.
It's following the specification http://dev.w3.org/html5/spec/the-table-element.html#dom-table-createtbody.

Tests: fast/table/table-create-tbody-existing-tbody.html
       fast/table/table-create-tbody-multiple-tbody.html
       fast/table/table-create-tbody.html

* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::createTBody):
(WebCore):
* html/HTMLTableElement.h:
(HTMLTableElement):
* html/HTMLTableElement.idl:

LayoutTests:

Add test to cover the new createTBody method.

* fast/table/table-create-tbody-existing-tbody-expected.txt: Added.
* fast/table/table-create-tbody-existing-tbody.html: Added.
* fast/table/table-create-tbody-expected.txt: Added.
* fast/table/table-create-tbody-multiple-tbody-expected.txt: Added.
* fast/table/table-create-tbody-multiple-tbody.html: Added.
* fast/table/table-create-tbody.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoScrollingCoordinator::setScrollParameters should take a single struct
andersca@apple.com [Wed, 25 Apr 2012 02:07:58 +0000 (02:07 +0000)]
ScrollingCoordinator::setScrollParameters should take a single struct
https://bugs.webkit.org/show_bug.cgi?id=84816

Reviewed by Andreas Kling.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::setScrollParameters):
* page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
(ScrollParameters):
* page/scrolling/ScrollingCoordinatorNone.cpp:
(WebCore::ScrollingCoordinator::setScrollParameters):
* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinator::setScrollParameters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unused undefined() method from ScriptValue
adamk@chromium.org [Wed, 25 Apr 2012 02:05:46 +0000 (02:05 +0000)]
Remove unused undefined() method from ScriptValue
https://bugs.webkit.org/show_bug.cgi?id=84751

Reviewed by Kentaro Hara.

* bindings/js/ScriptValue.h:
(ScriptValue):
* bindings/v8/ScriptValue.h:
(ScriptValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoASSERT failure in RenderLayer::computeRepaintRects
commit-queue@webkit.org [Wed, 25 Apr 2012 01:59:08 +0000 (01:59 +0000)]
ASSERT failure in RenderLayer::computeRepaintRects
https://bugs.webkit.org/show_bug.cgi?id=84480

Patch by Yong Li <yoli@rim.com> on 2012-04-24
Reviewed by Simon Fraser.

Source/WebCore:

Update visibility status if necessary before updating
compositing state in RenderLayer::styleChanged().

No new tests because this is obviously right thing to do
and creating new test seems too much for this small change.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::styleChanged):

LayoutTests:

Add a layout test for it.

* compositing/visibility/compositing-and-visibility-turned-off-together-expected.txt: Added.
* compositing/visibility/compositing-and-visibility-turned-off-together.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGC Activity Callback timer should be based on how much has been allocated since the...
mhahnenberg@apple.com [Wed, 25 Apr 2012 01:29:42 +0000 (01:29 +0000)]
GC Activity Callback timer should be based on how much has been allocated since the last collection
https://bugs.webkit.org/show_bug.cgi?id=84763

Reviewed by Geoffrey Garen.

The desired behavior for the GC timer is to collect at some point in the future,
regardless of how little we've allocated. A secondary goal, which is almost if not
as important, is for the timer to collect sooner if there is the potential to
collect a greater amount of memory. Conversely, as we allocate more memory we'd
like to reduce the delay to the next collection. If we're allocating quickly enough,
the timer should be preempted in favor of a normal allocation-triggered collection.
If allocation were to slow or stop, we'd like the timer to be able to opportunistically
run a collection without us having to allocate to the hard limit set by the Heap.

This type of policy can be described in terms of the amount of CPU we are willing
to dedicate to reclaim a single MB of memory. For example, we might be willing to
dedicate 1% of our CPU to reclaim 1 MB. We base our CPU usage off of the length of
the last collection, e.g. if our last collection took 1ms, we would want to wait about
100ms before running another collection to reclaim 1 MB. These constants should be
tune-able, e.g. 0.1% CPU = 1 MB vs. 1% CPU = 1 MB vs. 10% CPU = 1 MB.

* API/JSBase.cpp: Use the new reportAbandonedObjectGraph.
(JSGarbageCollect):
* API/JSContextRef.cpp: Ditto.
* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::reportAbandonedObjectGraph): Similar to reportExtraMemoryCost. Clients call
this function to notify the Heap that some unknown number of JSC objects might have just
been abandoned and are now garbage. The Heap might schedule a new collection timer based
on this notification.
(JSC):
(JSC::Heap::collect): Renamed m_lastFullGCSize to the less confusing m_sizeAfterLastCollect.
* heap/Heap.h:
(Heap):
* heap/MarkedAllocator.h:
(JSC::MarkedAllocator::zapFreeList): Fixed a bug in zapFreeList that failed to nullify the
current allocator's FreeList once zapping was complete.
* runtime/GCActivityCallback.cpp: Removed didAbandonObjectGraph because it was replaced by
Heap::reportAbandonedObjectGraph.
(JSC):
* runtime/GCActivityCallback.h:
(JSC::GCActivityCallback::willCollect):
(DefaultGCActivityCallback):
* runtime/GCActivityCallbackCF.cpp: Refactored the GC timer code so that we now schedule the
timer based on how much we have allocated since the last collection up to a certain amount.
We use the length of the previous GC to try to keep our total cost of opportunistic timer-triggered
collections around 1% of the CPU per MB of garbage we expect to reclaim up to a maximum of 5 MB.
(DefaultGCActivityCallbackPlatformData):
(JSC):
(JSC::DefaultGCActivityCallback::~DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::commonConstructor):
(JSC::scheduleTimer):
(JSC::cancelTimer):
(JSC::DefaultGCActivityCallback::didAllocate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCalendar Picker: Open a calendar picker by keyboard operation
tkent@chromium.org [Wed, 25 Apr 2012 01:17:55 +0000 (01:17 +0000)]
Calendar Picker: Open a calendar picker by keyboard operation
https://bugs.webkit.org/show_bug.cgi?id=84680

Reviewed by Kentaro Hara.

Source/WebCore:

- Open a calendar picker by the down arrow key.
- Remove stepping down/up by keyboard and wheel operations.
  This behavior was for text fields with spin buttons. Because the date
type doesn't have spin buttons, we should remove this behavior.

No new tests for opening a calendar picker. This behavior is not
testable by DRT yet. For removal of stepping up/down,
fast/forms/date/date-stepup-stepdown-from-renderer.html is updated.

* html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::handleKeydownEvent):
Check shouldHaveSpinButton() before spin button key operations.
(WebCore::BaseDateAndTimeInputType::handleWheelEvent):
Check shouldHaveSpinButton() before spin button wheel operations.
* html/BaseDateAndTimeInputType.h:
(BaseDateAndTimeInputType):
Make handleKeydownEvent() protected because a subclass overrides it.
* html/DateInputType.cpp:
(WebCore::DateInputType::handleKeydownEvent):
Open a calendar picker by the down arrow key.
* html/DateInputType.h:
(DateInputType): Add handleKeydownEvent() declaration.
* html/shadow/CalendarPickerElement.h:
(CalendarPickerElement): Make openPopup() public because DateInputType calls it.

LayoutTests:

* fast/forms/date/date-stepup-stepdown-from-renderer-expected.txt:
* fast/forms/date/date-stepup-stepdown-from-renderer.html:
Stepping up/down by kerboard was removed. Update the test to confirm it doesn't work.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed test expectations update.
hclam@chromium.org [Wed, 25 Apr 2012 01:11:24 +0000 (01:11 +0000)]
[chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84813

Suppress test image mismatch due to r115123. Rebaseline is coming soon.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Move notification icon download out of WebCore
yael.aharon@nokia.com [Wed, 25 Apr 2012 01:10:09 +0000 (01:10 +0000)]
[Qt] Move notification icon download out of WebCore
https://bugs.webkit.org/show_bug.cgi?id=80700

Reviewed by Jian Li.

Remove http/tests/notifications after the code the tests were testing has been removed.

* http/tests/notifications: Removed.
* http/tests/notifications/icon-does-not-exist-expected.txt: Removed.
* http/tests/notifications/icon-does-not-exist.html: Removed.
* http/tests/notifications/icon-exists-cancel-expected.txt: Removed.
* http/tests/notifications/icon-exists-cancel.html: Removed.
* http/tests/notifications/icon-exists-expected.txt: Removed.
* http/tests/notifications/icon-exists-show-alert-during-load-expected.txt: Removed.
* http/tests/notifications/icon-exists-show-alert-during-load.html: Removed.
* http/tests/notifications/icon-exists.html: Removed.
* http/tests/notifications/icon-requires-auth-expected.txt: Removed.
* http/tests/notifications/icon-requires-auth.html: Removed.
* http/tests/notifications/resources: Removed.
* http/tests/notifications/resources/icon-exists.png: Removed.
* http/tests/notifications/resources/icon-requires-auth.php: Removed.
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/test_expectations.txt:
* platform/mac/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Perform spellcheck before handling TouchRelease event
commit-queue@webkit.org [Wed, 25 Apr 2012 01:02:47 +0000 (01:02 +0000)]
[BlackBerry] Perform spellcheck before handling TouchRelease event
https://bugs.webkit.org/show_bug.cgi?id=84744

After rebasing to master_35, it appears as though some code had been moved around.
Here, we were handling the TouchReleased event before calling spellcheck.  This
meant that when we finally got the call to spellcheck, the fatFinger result had been
reset and the spelling markers had been removed.

In addition, based on https://bugs.webkit.org/show_bug.cgi?id=66330
I am also updating the BlackBerry specific documentMarkerContainingPoint to use
LayoutPoint instead of IntPoint.

Internally reviewed by Mike Fenton.

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-04-24
Reviewed by Antonio Gomes.

* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
(BlackBerry::WebKit::TouchEventHandler::spellCheck):
* dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::markerContainingPoint):
* dom/DocumentMarkerController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoobjectProtoFuncToString creates new string every invocation
msaboff@apple.com [Wed, 25 Apr 2012 00:58:17 +0000 (00:58 +0000)]
objectProtoFuncToString creates new string every invocation
https://bugs.webkit.org/show_bug.cgi?id=84781

Reviewed by Geoffrey Garen.

Cache the results of object toString() in the attached Structure.

* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncToString):
* runtime/Structure.cpp:
(JSC::Structure::visitChildren): visit new m_hasObjectToStringValue.
* runtime/Structure.h: Added new member m_hasObjectToStringValue
(JSC):
(JSC::Structure::objectToStringValue):
(Structure):
(JSC::Structure::setObjectToStringValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed rebaseline after r115134.
yael.aharon@nokia.com [Wed, 25 Apr 2012 00:49:05 +0000 (00:49 +0000)]
Unreviewed rebaseline after r115134.

* platform/qt/fast/block/positioning/016-expected.txt:
* platform/qt/fast/block/positioning/025-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r115099, r115102, and r115127.
commit-queue@webkit.org [Wed, 25 Apr 2012 00:47:16 +0000 (00:47 +0000)]
Unreviewed, rolling out r115099, r115102, and r115127.
http://trac.webkit.org/changeset/115099
http://trac.webkit.org/changeset/115102
http://trac.webkit.org/changeset/115127
https://bugs.webkit.org/show_bug.cgi?id=84809

Made html5lib/runner.html crash, spot fix didn't help so
rolling out so original author can do over. (Requested by
kling on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-24

* dom/Element.cpp:
(WebCore::Element::parserSetAttributes):
(WebCore::Element::normalizeAttributes):
* dom/Element.h:
(Element):
* dom/ElementAttributeData.cpp:
(WebCore::AttributeVector::removeAttribute):
(WebCore):
* dom/ElementAttributeData.h:
(AttributeVector):
(WebCore::AttributeVector::AttributeVector):
(WebCore):
(WebCore::AttributeVector::getAttributeItem):
(WebCore::AttributeVector::getAttributeItemIndex):
(WebCore::AttributeVector::insertAttribute):
(WebCore::ElementAttributeData::getAttributeItem):
(WebCore::ElementAttributeData::getAttributeItemIndex):
(WebCore::ElementAttributeData::attributeVector):
(WebCore::ElementAttributeData::clonedAttributeVector):
(ElementAttributeData):
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):
* html/parser/HTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
* html/parser/HTMLTreeBuilder.h:
* html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::insertFakePreElement):
* xml/XMLErrors.cpp:
(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):
* xml/parser/MarkupTokenBase.h:
(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::getAttributeItem):
(WebCore::AtomicMarkupTokenBase::attributes):
(AtomicMarkupTokenBase):
(WebCore::::initializeAttributes):
* xml/parser/XMLToken.h:
(WebCore::AtomicXMLToken::AtomicXMLToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPrevent drag and drop from setting file URLs
jpfau@apple.com [Wed, 25 Apr 2012 00:43:31 +0000 (00:43 +0000)]
Prevent drag and drop from setting file URLs
https://bugs.webkit.org/show_bug.cgi?id=76596

Reviewed by Enrica Casucci.

Source/WebCore:

Blacklisted file URLs from being set via dataTransfer.setData for specific types.

* platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::setData):

LayoutTests:

Updated tests to reflect new expectations.

* http/tests/security/dataTransfer-set-data-file-url.html:
* platform/mac/editing/pasteboard/dataTransfer-set-data-file-url.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed test expectations update.
hclam@chromium.org [Wed, 25 Apr 2012 00:33:25 +0000 (00:33 +0000)]
[chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84810

Mark svg/carto.net/window.svg as fail due to changes in r115085.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: add ASAN handling to chromium crash logs
dpranke@chromium.org [Wed, 25 Apr 2012 00:28:14 +0000 (00:28 +0000)]
nrwt: add ASAN handling to chromium crash logs
https://bugs.webkit.org/show_bug.cgi?id=84664

Reviewed by Ojan Vafai.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort._get_crash_log):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r109022) Safari not placing service data on pasteboard.
enrica@apple.com [Wed, 25 Apr 2012 00:25:55 +0000 (00:25 +0000)]
REGRESSION (r109022) Safari not placing service data on pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=84766
<rdar://problem/11085756>

The support for OS X services requires that the write operations to
the pasteboard occur synchronously. This behavior was changed with r109022.
This change removes the original synchronous call to the WebProcess to perform
the pasteboard write that had become asynchronous after r109022.
It implements instead a synchronous call to retrive the content to be placed
in the pasteboard.

Reviewed by Alexey Proskuryakov.

Source/WebCore:

* WebCore.exp.in:
* editing/Editor.h:
* editing/mac/EditorMac.mm:
(WebCore::Editor::writeSelectionToPasteboard):
(WebCore::Editor::stringSelectionForPasteboard): Added.
(WebCore::Editor::dataSelectionForPasteboard): Added.
* platform/Pasteboard.h:
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::getStringSelection): Added.
(WebCore::Pasteboard::getDataSelection): Added.
(WebCore::Pasteboard::writeSelectionForTypes):
(WebCore::Pasteboard::writeSelection):

Source/WebKit2:

* UIProcess/API/mac/WKView.mm:
(-[WKView writeSelectionToPasteboard:types:]): Uses new methods.
* UIProcess/WebPageProxy.h:
* UIProcess/mac/WebPageProxyMac.mm: Removed writeSelectionToPasteboard.
(WebKit::WebPageProxy::getStringSelectionForPasteboard): Added.
(WebKit::WebPageProxy::getBufferSelectionForPasteboard): Added.
* WebProcess/WebPage/WebPage.h: Added support for the new messages and
removed old message.
* WebProcess/WebPage/WebPage.messages.in: Ditto.
* WebProcess/WebPage/mac/WebPageMac.mm: Ditto.
(WebKit::WebPage::readSelectionFromPasteboard): Added.
(WebKit::WebPage::getBufferSelectionForPasteboard): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPatch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2012-04-24
commit-queue@webkit.org [Wed, 25 Apr 2012 00:12:23 +0000 (00:12 +0000)]
Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2012-04-24
Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=84727.
Fix build when ENABLE_JIT_CONSTANT_BLINDING enabled.

* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::or32):
(JSC::MacroAssemblerSH4::and32):
(JSC::MacroAssemblerSH4::lshift32):
(JSC::MacroAssemblerSH4::xor32):
(JSC::MacroAssemblerSH4::branchSub32):
(JSC::MacroAssemblerSH4::urshift32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed test expectations update.
hclam@chromium.org [Wed, 25 Apr 2012 00:11:26 +0000 (00:11 +0000)]
[chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84806

html5lib/runner.html fails after r115099 and r115127, mark it so.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkit-patch rebaseline-test is retrieving stale expectations
dpranke@chromium.org [Wed, 25 Apr 2012 00:10:48 +0000 (00:10 +0000)]
webkit-patch rebaseline-test is retrieving stale expectations
https://bugs.webkit.org/show_bug.cgi?id=84762

Reviewed by Ojan Vafai.

webkit-patch rebaseline-expectations is fetching files directly
from the layout-test-results directory on the buildbots, rather
than fetching them from the archive. This is problematic because
we don't clobber the directory after each run and so you can end
up fetching stale failing results.

This change temporarily changes the code to fetch the zip file
instead -- making things much slower -- until I can confer w/
abarth and ojan over the best way to fix this for the long-term.

* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest.__init__):
(RebaselineTest._zip_file_set):
(RebaselineTest):
(RebaselineTest._fetch_baseline):
(RebaselineTest._rebaseline_test):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.stub_rebaseline_test_command_and_tool):
(TestRebaseline.stub_rebaseline_test_command_and_tool.FakeZipFileSet):
(TestRebaseline.stub_rebaseline_test_command_and_tool.FakeZipFileSet.read):
(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_test):
(test_rebaseline_and_copy_test):
(test_rebaseline_and_copy_test_no_existing_result):
(test_rebaseline_and_copy_test_with_lion_result):
(test_rebaseline_and_copy_no_overwrite_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd explicit patchableBranchPtrWithPatch/patchableJump methods
barraclough@apple.com [Wed, 25 Apr 2012 00:06:04 +0000 (00:06 +0000)]
Add explicit patchableBranchPtrWithPatch/patchableJump methods
https://bugs.webkit.org/show_bug.cgi?id=84498

Reviewed by Filip Pizlo.

Don't rely on inUninterruptedSequence to distinguish which jumps we need to be able to repatch.

* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::PatchableJump::PatchableJump):
(PatchableJump):
(JSC::AbstractMacroAssembler::PatchableJump::operator Jump&):
(AbstractMacroAssembler):
(JSC::AbstractMacroAssembler::AbstractMacroAssembler):
    - Added PatchableJump type, removed inUninterruptedSequence.
* assembler/LinkBuffer.h:
(LinkBuffer):
(JSC::LinkBuffer::locationOf):
    - Only allow the location to be taken of patchable branches
* assembler/MacroAssembler.h:
(MacroAssembler):
(JSC::MacroAssembler::patchableBranchPtrWithPatch):
(JSC::MacroAssembler::patchableJump):
(JSC::MacroAssembler::shouldBlind):
    - Added default implementation of patchableBranchPtrWithPatch, patchableJump.
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::MacroAssemblerARMv7):
(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::patchableBranchPtrWithPatch):
(JSC::MacroAssemblerARMv7::patchableJump):
(JSC::MacroAssemblerARMv7::jump):
(JSC::MacroAssemblerARMv7::makeBranch):
    - Added ARMv7 implementation of patchableBranchPtrWithPatch, patchableJump.
* dfg/DFGCorrectableJumpPoint.h:
(DFG):
(JSC::DFG::CorrectableJumpPoint::switchToLateJump):
    - Late jumps are PatchableJumps.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
    - replace use of inUninterruptedSequence
* dfg/DFGJITCompiler.h:
(JSC::DFG::PropertyAccessRecord::PropertyAccessRecord):
(PropertyAccessRecord):
    - replace use of inUninterruptedSequence
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
    - replace use of inUninterruptedSequence
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
    - replace use of inUninterruptedSequence
* jit/JIT.h:
(PropertyStubCompilationInfo):
    - replace use of inUninterruptedSequence
* jit/JITInlineMethods.h:
(JSC::JIT::beginUninterruptedSequence):
(JSC::JIT::endUninterruptedSequence):
    - replace use of inUninterruptedSequence
* jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetByIdHotPath):
    - replace use of inUninterruptedSequence
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::compileGetByIdHotPath):
    - replace use of inUninterruptedSequence

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix layout test failures for Oscillator because WaveTable now normalizes to 0dBFS...
crogers@google.com [Tue, 24 Apr 2012 23:59:14 +0000 (23:59 +0000)]
Fix layout test failures for Oscillator because WaveTable now normalizes to 0dBFS instead of -6dbFS
https://bugs.webkit.org/show_bug.cgi?id=84799

Reviewed by James Robinson.

This fixes failures caused by: http://trac.webkit.org/changeset/115111
We need to adjust the layout test itself to scale by 1/2 to compensate for the new WaveTable normalization.
The reason we don't change the audio .wav file baselines themselves is because audio values can potentially
clip past full scale, and we need to be able to avoid this "overshoot".

* webaudio/resources/oscillator-testing.js:
(generateExponentialOscillatorSweep):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Image masks are considered opaque incorrectly
danakj@chromium.org [Tue, 24 Apr 2012 23:58:04 +0000 (23:58 +0000)]
[chromium] Image masks are considered opaque incorrectly
https://bugs.webkit.org/show_bug.cgi?id=84275

Reviewed by Adrienne Walker.

Source/WebCore:

Match the behaviour of SkCanvas layers more closely while tracking
opaque paints. SkCanvas layers actually act as a separate device
(ie. pixels) and when the layer is popped off, the pixels are copied
down to the layer below.

While we can use the total clip to decide what pixels the the
drawing operation will affect in the final device, the blending
down through layers needs to consider each layer carefully.

In this case the image mask is drawn into a layer which is copied
down using the DestinationIn operation. Since the layer contains
non-opaque pixels, the DestinationIn copy can destroy opaque
areas in the next layer. We add OpaqueRegionSkia::FillByCopy to
distinguish the case where we are copying a block of pixels, and the
alpha values are essentially unknown.

Unit test: PlatformContextSkiaTest.trackImageMask
           PlatformContextSkiaTest.trackImageMaskWithOpaqueRect

* platform/graphics/skia/OpaqueRegionSkia.cpp:
(WebCore::paintIsOpaque):
(WebCore::OpaqueRegionSkia::applyOpaqueRegionFromLayer):
(WebCore::OpaqueRegionSkia::pushCanvasLayer):
(WebCore::OpaqueRegionSkia::popCanvasLayer):
(WebCore::OpaqueRegionSkia::didDrawRect):
(WebCore::OpaqueRegionSkia::didDrawPath):
(WebCore::OpaqueRegionSkia::didDrawPoints):
(WebCore::OpaqueRegionSkia::didDrawBounded):
(WebCore::OpaqueRegionSkia::didDraw):
(WebCore::OpaqueRegionSkia::didDrawUnbounded):
(WebCore::OpaqueRegionSkia::markRectAsOpaque):
(WebCore::OpaqueRegionSkia::markRectAsNonOpaque):
(WebCore::OpaqueRegionSkia::markAllAsNonOpaque):
* platform/graphics/skia/OpaqueRegionSkia.h:
(OpaqueRegionSkia):
(CanvasLayerState):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::restoreLayer):

Source/WebKit/chromium:

* tests/PlatformContextSkiaTest.cpp:
(WebCore):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSS Shaders: Repainting the FECustomFilter requires full source image
achicu@adobe.com [Tue, 24 Apr 2012 23:55:50 +0000 (23:55 +0000)]
CSS Shaders: Repainting the FECustomFilter requires full source image
https://bugs.webkit.org/show_bug.cgi?id=76689

Source/WebCore:

Reviewed by Dean Jackson..

When a pixel of a filtered layer changes we need to update the whole bounding box of the layer and
not just the dirty rectangle. That's because the shader might change the color of any of the pixels inside the box.

Added tests where a shader is moving and rotating the contents and the actual
dirty box of the source image is not the same as the output dirty rectangle.

Tests: css3/filters/custom/filter-repaint-custom-clipped.html
       css3/filters/custom/filter-repaint-custom-rotated.html
       css3/filters/custom/filter-repaint-custom.html

* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::build):
(WebCore::FilterEffectRenderer::computeSourceImageRectForDirtyRect):
* rendering/FilterEffectRenderer.h:
(FilterEffectRenderer):
(WebCore::FilterEffectRenderer::hasCustomShaderFilter):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):

LayoutTests:

Reviewed by Dean Jackson.

* css3/filters/custom/filter-repaint-custom-clipped-expected.png: Added.
* css3/filters/custom/filter-repaint-custom-clipped-expected.txt: Added.
* css3/filters/custom/filter-repaint-custom-clipped.html: Added.
* css3/filters/custom/filter-repaint-custom-expected.png: Added.
* css3/filters/custom/filter-repaint-custom-expected.txt: Added.
* css3/filters/custom/filter-repaint-custom-rotated-expected.png: Added.
* css3/filters/custom/filter-repaint-custom-rotated-expected.txt: Added.
* css3/filters/custom/filter-repaint-custom-rotated.html: Added.
* css3/filters/custom/filter-repaint-custom.html: Added.
* css3/filters/resources/color-add.fs: Added.
* css3/filters/resources/vertex-horizontal-offset.vs: Added.
* css3/filters/resources/vertex-rotate.vs: Added.
* platform/chromium-mac/css3/filters/custom/filter-repaint-custom-clipped-expected.png: Added.
* platform/chromium-mac/css3/filters/custom/filter-repaint-custom-expected.png: Added.
* platform/chromium-mac/css3/filters/custom/filter-repaint-custom-rotated-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed test expectations update.
hclam@chromium.org [Tue, 24 Apr 2012 23:52:44 +0000 (23:52 +0000)]
[chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84802

New test added in r115096 is failing on Chromium, mark it so.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace occurences of style selector from variables and methods names by style resolver.
alexis.menard@openbossa.org [Tue, 24 Apr 2012 23:51:22 +0000 (23:51 +0000)]
Replace occurences of style selector from variables and methods names by style resolver.
https://bugs.webkit.org/show_bug.cgi?id=84765

Reviewed by Andreas Kling.

Rename methods and variables to follow the new name StyleResolver. It requires to update the
local variables, methods parameters, and function names to match the new name and to remove
the concept of "selector" to avoid clashing with the CSS concept. The next and last patch
will be to rename CSSStyleSelector file and update the includes.

Source/WebCore:

No new tests : just renaming the variables and method names. No behavior changes expected.

* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::addStops):
* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::setSelectorText):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):
* css/CSSStyleSheet.cpp:
(WebCore::StyleSheetInternal::styleSheetChanged):
* css/MediaQueryEvaluator.cpp:
(WebCore::MediaQueryEvaluator::eval):
* css/MediaQueryMatcher.cpp:
(WebCore::MediaQueryMatcher::prepareEvaluator):
(WebCore::MediaQueryMatcher::styleResolverChanged):
* css/MediaQueryMatcher.h:
(MediaQueryMatcher):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::StyleRuleCSSStyleDeclaration::setNeedsStyleRecalc):
* css/StyleBuilder.cpp:
(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyDefaultBase::applyInheritValue):
(WebCore::ApplyPropertyDefaultBase::applyInitialValue):
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyClip::applyInheritValue):
(WebCore::ApplyPropertyClip::applyInitialValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::applyColorValue):
(WebCore::ApplyPropertyDirection::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFillLayer::applyInheritValue):
(WebCore::ApplyPropertyFillLayer::applyInitialValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyInheritValue):
(WebCore::ApplyPropertyFont::applyInitialValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontSize::applyInheritValue):
(WebCore::ApplyPropertyFontSize::applyInitialValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyBorderImage::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::ApplyPropertyBorderImageModifier::applyValue):
(WebCore::ApplyPropertyBorderImageSource::applyValue):
(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyInheritValue):
(WebCore::ApplyPropertyCursor::applyInitialValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyUnicodeBidi::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
(WebCore::ApplyPropertyOutlineStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyInheritValue):
(WebCore::ApplyPropertyAspectRatio::applyInitialValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyZoom::resetEffectiveZoom):
(WebCore::ApplyPropertyZoom::applyInheritValue):
(WebCore::ApplyPropertyZoom::applyInitialValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::isValidDisplayValue):
(WebCore::ApplyPropertyDisplay::applyInheritValue):
(WebCore::ApplyPropertyDisplay::applyInitialValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyFlex::applyInheritValue):
(WebCore::ApplyPropertyFlex::applyInitialValue):
(WebCore::ApplyPropertyFlex::applyValue):
* css/StyleBuilder.h:
(WebCore::PropertyHandler::applyInheritValue):
(WebCore::PropertyHandler::applyInitialValue):
(WebCore::PropertyHandler::applyValue):
* css/StyleMedia.cpp:
(WebCore::StyleMedia::matchMedium):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::setDocType):
(WebCore::Document::childrenChanged):
(WebCore::Document::setContentLanguage):
(WebCore::Document::recalcStyle):
(WebCore::Document::updateLayoutIgnorePendingStylesheets):
(WebCore::Document::styleForElementIgnoringPendingStylesheets):
(WebCore::Document::styleForPage):
(WebCore::Document::combineCSSFeatureFlags):
(WebCore::Document::resetCSSFeatureFlags):
(WebCore::Document::createStyleResolver):
(WebCore::Document::clearStyleResolver):
(WebCore::Document::clearPageUserSheet):
(WebCore::Document::updatePageUserSheet):
(WebCore::Document::clearPageGroupUserSheets):
(WebCore::Document::updatePageGroupUserSheets):
(WebCore::Document::addUserSheet):
(WebCore::Document::processHttpEquiv):
(WebCore::Document::setSelectedStylesheetSet):
(WebCore::Document::removePendingSheet):
(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::styleResolverChanged):
(WebCore::Document::analyzeStylesheetChange):
(WebCore::Document::updateActiveStylesheets):
* dom/Document.h:
(WebCore::Document::styleResolverIfExists):
(WebCore::Document::styleResolver):
(Document):
* dom/Element.cpp:
(WebCore::StyleResolverParentPusher::StyleResolverParentPusher):
(WebCore::StyleResolverParentPusher::push):
(WebCore::StyleResolverParentPusher::~StyleResolverParentPusher):
(StyleResolverParentPusher):
(WebCore::Element::attributeChanged):
(WebCore::Element::attach):
(WebCore::Element::styleForRenderer):
(WebCore::Element::recalcStyle):
(WebCore::Element::beginParsingChildren):
(WebCore::Element::finishParsingChildren):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::removedFrom):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::attach):
* dom/ShadowTree.cpp:
(WebCore::ShadowTree::recalcShadowTreeStyle):
* dom/StyleElement.cpp:
(WebCore::StyleElement::removedFromDocument):
* editing/EditingStyle.cpp:
(WebCore::styleFromMatchedRulesForElement):
* history/CachedPage.cpp:
(WebCore::CachedPage::restore):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::styleResolver):
* html/HTMLCanvasElement.h:
(HTMLCanvasElement):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setDisabledState):
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::removedFrom):
(WebCore::HTMLLinkElement::removePendingSheet):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::registerWithScopingNode):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::recalcStyleForPseudoStateIfNeeded):
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):
(WebCore::InspectorCSSAgent::clearPseudoState):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::updateViewMetrics):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::getMatchedCSSRules):
* page/Frame.cpp:
(WebCore::Frame::setPrinting):
* page/FrameView.cpp:
(WebCore::FrameView::layout):
* page/Page.cpp:
(WebCore::Page::setViewMode):
(WebCore::Page::setNeedsRecalcStyleInAllFrames):
(WebCore::Page::allVisitedStateChanged):
(WebCore::Page::visitedStateChanged):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::KeyframeAnimation):
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::adjustSliderTrackStyle):
(WebCore::RenderThemeEfl::adjustSliderThumbStyle):
(WebCore::RenderThemeEfl::adjustCheckboxStyle):
(WebCore::RenderThemeEfl::adjustRadioStyle):
(WebCore::RenderThemeEfl::adjustButtonStyle):
(WebCore::RenderThemeEfl::adjustMenuListStyle):
(WebCore::RenderThemeEfl::adjustMenuListButtonStyle):
(WebCore::RenderThemeEfl::adjustTextFieldStyle):
(WebCore::RenderThemeEfl::adjustTextAreaStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldStyle):
(WebCore::RenderThemeEfl::adjustProgressBarStyle):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::adjustButtonStyle):
(WebCore::RenderThemeGtk::adjustMenuListStyle):
(WebCore::RenderThemeGtk::adjustMenuListButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldStyle):
(WebCore::RenderThemeGtk::adjustSliderThumbStyle):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::adjustSliderThumbStyle):
(WebCore::RenderThemeQt::adjustSearchFieldStyle):
(WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeQt::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQt::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
* platform/qt/RenderThemeQtMobile.cpp:
(WebCore::RenderThemeQtMobile::adjustButtonStyle):
(WebCore::RenderThemeQtMobile::adjustMenuListStyle):
* platform/wx/RenderThemeWx.cpp:
(WebCore::RenderThemeWx::adjustButtonStyle):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::fontSelector):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::getUncachedPseudoStyle):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::styleDidChange):
(WebCore::RenderRegion::computeStyleInRegion):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::fontSelector):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::adjustInputFieldSpeechButtonStyle):
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::adjustMenuListStyle):
(WebCore::RenderThemeChromiumSkia::adjustMenuListButtonStyle):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustMenuListStyle):
(WebCore::RenderThemeMac::adjustSliderThumbStyle):
(WebCore::RenderThemeMac::adjustSearchFieldStyle):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::setFontFromControlSize):
(WebCore::RenderThemeSafari::adjustButtonStyle):
(WebCore::RenderThemeSafari::adjustMenuListStyle):
(WebCore::RenderThemeSafari::adjustMenuListButtonStyle):
(WebCore::RenderThemeSafari::adjustSliderThumbStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldResultsButtonStyle):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeWin::adjustMenuListStyle):
(WebCore::RenderThemeWin::adjustMenuListButtonStyle):
(WebCore::RenderThemeWin::adjustSearchFieldStyle):
(WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeWin::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle):
* rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::adjustMenuListStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeWinCE::adjustMenuListButtonStyle):
* rendering/style/StyleGeneratedImage.cpp:
(WebCore::StyleGeneratedImage::image):
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):
* svg/SVGElement.cpp:
(WebCore::SVGElement::customStyleForRenderer):
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::rebuildFontFace):
(WebCore::SVGFontFaceElement::removedFrom):
* xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::transformDocumentToTreeView):
* xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::end):
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::doEnd):
* xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::doEnd):
* WebCore.exp.in:

Source/WebKit/chromium:

* src/AutofillPopupMenuClient.cpp:
(WebKit::AutofillPopupMenuClient::fontSelector):
(WebKit::AutofillPopupMenuClient::initialize):
* src/WebDevToolsAgentImpl.cpp:
(WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth):
(WebKit::DeviceMetricsSupport::applySizeOverrideInternal):

Source/WebKit/mac:

* WebView/WebHTMLView.mm:
(-[WebHTMLView reapplyStyles]):
(-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):

Source/WebKit/qt:

* Api/qwebelement.cpp:
(QWebElement::styleProperty):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setMediaType):
* WebCoreSupport/RenderThemeQStyle.cpp:
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] setUserViewportArguments not always respected.
commit-queue@webkit.org [Tue, 24 Apr 2012 23:45:37 +0000 (23:45 +0000)]
[BlackBerry] setUserViewportArguments not always respected.
https://bugs.webkit.org/show_bug.cgi?id=84738

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-04-24
Reviewed by Antonio Gomes.

Remove the unnecessary logic in
WebPagePrivate::recomputeVirtualViewportFromViewportArguments().
Instead it is much simpler to just set the m_viewportArguments to
m_userViewportArguments on LoadCommitted. If there is a viewport
tag in the content, m_viewportArguments will be replaced with it
as usual during normal page load.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFixed background is scrolling in http://www.nieuwecode.nl/ in Qt webkit2
yael.aharon@nokia.com [Tue, 24 Apr 2012 23:43:46 +0000 (23:43 +0000)]
Fixed background is scrolling in nieuwecode.nl/ in Qt webkit2
https://bugs.webkit.org/show_bug.cgi?id=83980

Reviewed by Simon Fraser.

.:

* ManualTests/fixed-position-no-z-index.html: Added.

Source/WebCore:

When a fixed position element does not have z-index explicitly specified, it does not create a
stacking context. This results in fixed elements scrolling with the content layer.
This patch creates a stacking context for fixed positioned elements for the Qt port, by enabling
the flag ENABLE_FIXED_POSITION_CREATES_STACKING_CONTEXT.
Added a manual test because this patch takes effect only during scrolling.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImprove code for embedding flakiness dashboard as an iframe
ojan@chromium.org [Tue, 24 Apr 2012 23:43:13 +0000 (23:43 +0000)]
Improve code for embedding flakiness dashboard as an iframe
https://bugs.webkit.org/show_bug.cgi?id=84782

Reviewed by Dirk Pranke.

-Include the horizontal scrollbar height in the measured height of the page.
-Post a message everytime the height changes instead of in response to a queryContentHeight message.
This way, the embedder doesn't need to poll.

No new tests. This is hard to test because it involves postMessage and iframes.
Once we switch the dashboard tests over to qunit, we should be able to write an
asyncTest for this.

* TestResultServer/static-dashboards/flakiness_dashboard.js:
(generatePage):
(appendHTML):
(appendExpectations):
(postHeightChangedMessage):
(generatePageForIndividualTests.if):
(generatePageForIndividualTests):
* TestResultServer/static-dashboards/flakiness_dashboard_embedded.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGeneralize the single character optimization of r114072
benjamin@webkit.org [Tue, 24 Apr 2012 23:41:32 +0000 (23:41 +0000)]
Generalize the single character optimization of r114072
https://bugs.webkit.org/show_bug.cgi?id=83961

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-24
Reviewed by Eric Seidel.

Source/JavaScriptCore:

Use the regular String::find(StringImpl*) in all cases now that it has been made faster.

* runtime/StringPrototype.cpp:
(JSC::replaceUsingStringSearch):

Source/WTF:

This patch makes some improvment over String::find() in the case of lookup for a single
character.

The two function find(UChar|LChar) are replaced by a template.

The case of searching a UChar in a 8bit string has a shortcut if the UChar cannot
possibly match any character in the range of the type LChar.

The slow case StringImpl::find(StringImpl*) is modified to
-Do not allocate in the fast case if only one string is 8bit.
-Use the shortcut for searching UChar in LChar.

This speed up the function by about 7% when avoiding string conversion.

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::find):
* wtf/text/StringImpl.h:
(StringImpl):
(WTF):
(WTF::find):
(WTF::StringImpl::find):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace garden-o-matic accordion UI with a panel UI
ojan@chromium.org [Tue, 24 Apr 2012 23:33:40 +0000 (23:33 +0000)]
Replace garden-o-matic accordion UI with a panel UI
https://bugs.webkit.org/show_bug.cgi?id=84081

Reviewed by Dimitri Glazkov.

This is a nicer UI to work with and makes it easier to embed the flakiness dashboard,
since we can reuse the same iframe without moving it in the DOM.

Also, excise unnecessary jquery-isms.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r115083-r115087): 6 tests failing on Lion Release (WebKit2 Tests)
rwlbuis@webkit.org [Tue, 24 Apr 2012 23:16:03 +0000 (23:16 +0000)]
REGRESSION (r115083-r115087): 6 tests failing on Lion Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=84783

Reviewed by Dirk Schulze.

Fix struct-use-09-b.svg missing test result by converting to a reftest.

* platform/chromium-linux/svg/custom/struct-use-09-b-expected.png: Removed.
* platform/chromium-mac-leopard/svg/custom/struct-use-09-b-expected.png: Removed.
* platform/chromium-mac/svg/custom/struct-use-09-b-expected.png: Removed.
* platform/chromium-mac/svg/custom/struct-use-09-b-expected.txt: Removed.
* platform/chromium-win/svg/custom/struct-use-09-b-expected.png: Removed.
* platform/chromium-win/svg/custom/struct-use-09-b-expected.txt: Removed.
* platform/gtk/svg/custom/struct-use-09-b-expected.png: Removed.
* platform/gtk/svg/custom/struct-use-09-b-expected.txt: Removed.
* platform/mac-leopard/svg/custom/struct-use-09-b-expected.png: Removed.
* platform/mac/svg/custom/struct-use-09-b-expected.png: Removed.
* platform/qt/svg/custom/struct-use-09-b-expected.png: Removed.
* platform/qt/svg/custom/struct-use-09-b-expected.txt: Removed.
* svg/custom/struct-use-09-b-expected.svg:
* svg/custom/struct-use-09-b.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewd test expectations update.
hclam@chromium.org [Tue, 24 Apr 2012 23:08:48 +0000 (23:08 +0000)]
[chromium] Unreviewd test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84790

Adding expectations for new tests added in r115091.

* platform/chromium-mac/fast/css/table-rules-attribute-groups-with-frame-expected.png: Added.
* platform/chromium-mac/fast/css/table-rules-attribute-with-frame1-expected.png: Added.
* platform/chromium-mac/fast/css/table-rules-attribute-with-frame2-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix Windows build.
beidson@apple.com [Tue, 24 Apr 2012 23:00:10 +0000 (23:00 +0000)]
Fix Windows build.

* WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.h:
(~InjectedBundleDOMWindowExtension): VS doesn't like OVERRIDE on d'tor's

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r115099): html5lib/runner.html crashes.
kling@webkit.org [Tue, 24 Apr 2012 22:55:53 +0000 (22:55 +0000)]
REGRESSION(r115099): html5lib/runner.html crashes.
<http://webkit.org/b/84791>

Reviewed by Anders Carlsson.

Unbreak and simplify the code that filters attributes on isindex elements.
It's perfectly safe to remove elements from a Vector while iterating over it.

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] DumpRenderTree should depend on base.gyp:test_support_base
peter@chromium.org [Tue, 24 Apr 2012 22:55:34 +0000 (22:55 +0000)]
[Chromium] DumpRenderTree should depend on base.gyp:test_support_base
https://bugs.webkit.org/show_bug.cgi?id=84729

Reviewed by Dirk Pranke.

This dependency is necessary for Android since it'll soon be
calling InitAndroidOSPathStub() in it's platform support. The
TestWebKitAPI and webkit_unit_tests already have this dependency.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExtra display logic for the media control panel element
commit-queue@webkit.org [Tue, 24 Apr 2012 22:50:05 +0000 (22:50 +0000)]
Extra display logic for the media control panel element
https://bugs.webkit.org/show_bug.cgi?id=82476

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-04-24
Reviewed by Eric Carlson.

Source/WebCore:

This patch fixes a bug which caused the controls to be displayed
when they should remain hidden. Added an extra variable to the
panel elements which properly keeps the state of the panel (visible or not).

Test: media/video-controls-toggling.html

* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::MediaControlPanelElement): Added the
variable m_isDisplayed to hold the state whether the panel is visible or not.
(WebCore::MediaControlPanelElement::makeOpaque): Showing the panel only if it
is visible.
(WebCore::MediaControlPanelElement::makeTransparent): Enabled the transition
timer which sets the display:none property on the controls.
(WebCore::MediaControlPanelElement::setIsDisplayed): Setter for the state variable.
(WebCore):
* html/shadow/MediaControlElements.h:
(MediaControlPanelElement):
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::show): Updated the panel visibility state.
(WebCore::MediaControlRootElement::hide): Updated the panel visibility state.
* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::show): Updated the panel visibility state.
(WebCore::MediaControlRootElementChromium::hide): Updated the panel visibility state.

LayoutTests:

Added test to ensure that controls are not displayed when
the controls attribute is not set.

* media/video-controls-toggling-expected.txt: Added.
* media/video-controls-toggling.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace vague informative statement with the list of builders where the test isn...
ojan@chromium.org [Tue, 24 Apr 2012 22:46:32 +0000 (22:46 +0000)]
Replace vague informative statement with the list of builders where the test isn't listed
https://bugs.webkit.org/show_bug.cgi?id=84779

Reviewed by Dirk Pranke.

This is more informative and more likely to be noticed. With the old UI, people never
read the line and if they did, they didn't really understand what it meant. Hopefully
have the list of builders will be more clear.

* TestResultServer/static-dashboards/flakiness_dashboard.js:
* TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSS Shaders: Custom filters painting is broken
achicu@adobe.com [Tue, 24 Apr 2012 22:44:43 +0000 (22:44 +0000)]
CSS Shaders: Custom filters painting is broken
https://bugs.webkit.org/show_bug.cgi?id=82803

Reviewed by Kenneth Russell.

Source/WebCore:

In this patch I moved CSS Shaders file loading notifications from FilterEffectRenderer to the new RenderLayerFilterInfo.
That's because FilterEffectRenderer is only used when running the filters in the software pipeline
and has a very short lifetime. Due to a recent change FilterEffectRenderer actually
gets deleted if the shader is not loaded, so it doesn't live that much to be notified when the shader
was actually loaded.

Also removed the FilterEffectObserver, that was only used to notify the RenderLayer about the loaded shader.

No new tests. This is making existing CSS Shaders tests pass again.
Cannot un-skip on Mac for now because the feature is compile time disabled.

* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/filters/CustomFilterOperation.h:
(WebCore::CustomFilterOperation::affectsOpacity):
(WebCore::CustomFilterOperation::movesPixels):
* platform/graphics/filters/FilterOperations.cpp:
(WebCore):
(WebCore::FilterOperations::hasCustomFilter):
* platform/graphics/filters/FilterOperations.h:
(FilterOperations):
* platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::applyFilters):
* rendering/FilterEffectObserver.h: Removed.
* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::~FilterEffectRenderer):
(WebCore::FilterEffectRenderer::build):
* rendering/FilterEffectRenderer.h:
(WebCore):
(WebCore::FilterEffectRenderer::create):
(FilterEffectRenderer):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateOrRemoveFilterEffect):
* rendering/RenderLayer.h:
* rendering/RenderLayerFilterInfo.cpp:
(WebCore::RenderLayerFilterInfo::~RenderLayerFilterInfo):
(WebCore::RenderLayerFilterInfo::notifyCustomFilterProgramLoaded):
(WebCore):
(WebCore::RenderLayerFilterInfo::updateCustomFilterClients):
(WebCore::RenderLayerFilterInfo::removeCustomFilterClients):
* rendering/RenderLayerFilterInfo.h:
(WebCore):
(RenderLayerFilterInfo):

LayoutTests:

* platform/chromium/test_expectations.txt: Un-skipping related tests on Chromium.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[SVG] convert use-css-events.svg to be a reftest
rwlbuis@webkit.org [Tue, 24 Apr 2012 22:30:41 +0000 (22:30 +0000)]
[SVG] convert use-css-events.svg to be a reftest
https://bugs.webkit.org/show_bug.cgi?id=84788

Reviewed by Andreas Kling.

* platform/chromium-linux/svg/custom/use-css-events-expected.png: Removed.
* platform/chromium-mac/svg/custom/use-css-events-expected.png: Removed.
* platform/chromium-mac/svg/custom/use-css-events-expected.txt: Removed.
* platform/chromium-win/svg/custom/use-css-events-expected.png: Removed.
* platform/chromium-win/svg/custom/use-css-events-expected.txt: Removed.
* platform/gtk/svg/custom/use-css-events-expected.png: Removed.
* platform/gtk/svg/custom/use-css-events-expected.txt: Removed.
* platform/mac-leopard/svg/custom/use-css-events-expected.png: Removed.
* platform/mac-snowleopard/svg/custom/use-css-events-expected.png: Removed.
* platform/mac/svg/custom/use-css-events-expected.png: Removed.
* platform/mac/svg/custom/use-css-events-expected.txt: Removed.
* platform/qt/svg/custom/use-css-events-expected.png: Removed.
* platform/qt/svg/custom/use-css-events-expected.txt: Removed.
* platform/win/svg/custom/use-css-events-expected.txt: Removed.
* svg/custom/use-css-events-expected.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother build fix.
antti@apple.com [Tue, 24 Apr 2012 22:14:22 +0000 (22:14 +0000)]
Another build fix.

Not reviewed.

* css/MediaList.cpp:
(WebCore::MediaQuerySet::MediaQuerySet):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::StylePropertySet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r115083-r115087): 6 tests failing on Lion Release (WebKit2 Tests)
rwlbuis@webkit.org [Tue, 24 Apr 2012 22:12:53 +0000 (22:12 +0000)]
REGRESSION (r115083-r115087): 6 tests failing on Lion Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=84783

Reviewed by Andreas Kling.

This regression was caused because the test results from an old patch were
blindly taken, rebaseline these against trunk.

* svg/custom/use-in-symbol-with-offset-expected.txt:
* svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt:
* svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed test expectations update.
hclam@chromium.org [Tue, 24 Apr 2012 22:06:43 +0000 (22:06 +0000)]
[chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84785

Updating test expectation changes due to r115085.

* platform/chromium-linux-x86/svg/custom/use-setAttribute-crash-expected.txt: Removed.
* platform/chromium-linux/svg/custom/use-setAttribute-crash-expected.txt: Removed.
* platform/chromium-mac-leopard/svg/custom/use-setAttribute-crash-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/custom/use-setAttribute-crash-expected.txt: Removed.
* platform/chromium-mac/svg/custom/struct-use-09-b-expected.txt: Added.
* platform/chromium-win-vista/svg/custom/use-setAttribute-crash-expected.txt: Removed.
* platform/chromium-win-xp/svg/custom/use-setAttribute-crash-expected.txt: Removed.
* platform/chromium-win/svg/custom/embedding-external-svgs-expected.txt:
* platform/chromium-win/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
* platform/chromium-win/svg/custom/relative-sized-use-on-symbol-expected.txt:
* platform/chromium-win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
* platform/chromium-win/svg/custom/struct-use-09-b-expected.txt:
* platform/chromium-win/svg/custom/use-setAttribute-crash-expected.txt:
* platform/chromium/svg/custom/use-in-symbol-with-offset-expected.txt: Added.
* platform/chromium/svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt: Renamed from LayoutTests/platform/qt/svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt.
* platform/chromium/svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt: Renamed from LayoutTests/platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTry to fix Qt build.
antti@apple.com [Tue, 24 Apr 2012 22:03:34 +0000 (22:03 +0000)]
Try to fix Qt build.

Not reviewed.

* css/StyleRule.h:
(WebCore::StyleRuleBase::StyleRuleBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Implement WebCore::dateFormat{DayInMonth,Month,Year}Text()
tkent@chromium.org [Tue, 24 Apr 2012 21:58:42 +0000 (21:58 +0000)]
[Chromium] Implement WebCore::dateFormat{DayInMonth,Month,Year}Text()
https://bugs.webkit.org/show_bug.cgi?id=84683

Reviewed by Dimitri Glazkov.

* public/platform/WebLocalizedString.h:
Add DateFormat{DayInMonth,Month,Year}Label
* src/LocalizedStrings.cpp:
(WebCore::dateFormatYearText): Implemented.
(WebCore::dateFormatMonthText): ditto.
(WebCore::dateFormatDayInMonthText): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement StyleRule copying
antti@apple.com [Tue, 24 Apr 2012 21:56:48 +0000 (21:56 +0000)]
Implement StyleRule copying
https://bugs.webkit.org/show_bug.cgi?id=84752

Reviewed by Andreas Kling.

We'll need this for copy-on-write when style sheet data is shared between documents.

Implement copy() and copy constructor for style rules their children as needed.

The code is not yet used.

* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::CSSSelectorList):
(WebCore):
* css/CSSSelectorList.h:
(CSSSelectorList):
* css/MediaList.h:
(WebCore::MediaQuerySet::copy):
(MediaQuerySet):
* css/MediaQuery.cpp:
(WebCore::MediaQuery::MediaQuery):
(WebCore):
* css/MediaQuery.h:
(MediaQuery):
(WebCore::MediaQuery::copy):
* css/MediaQueryExp.h:
(WebCore::MediaQueryExp::copy):
(MediaQueryExp):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::StylePropertySet):
(WebCore):
(WebCore::StylePropertySet::copy):
* css/StylePropertySet.h:

    Make this copy parse mode too. As a result ElementAttributeData no longer needs to set it explicitly after copying.

(StylePropertySet):
* css/StyleRule.cpp:
(WebCore::StyleRuleBase::copy):
(WebCore):
(WebCore::StyleRule::StyleRule):
(WebCore::StyleRulePage::StyleRulePage):
(WebCore::StyleRuleFontFace::StyleRuleFontFace):
(WebCore::StyleRuleBlock::StyleRuleBlock):
(WebCore::StyleRuleMedia::StyleRuleMedia):
(WebCore::StyleRuleRegion::StyleRuleRegion):
* css/StyleRule.h:
(StyleRuleBase):
(WebCore::StyleRuleBase::StyleRuleBase):
(WebCore::StyleRule::copy):
(StyleRule):
(WebCore::StyleRuleFontFace::copy):
(StyleRuleFontFace):
(WebCore::StyleRulePage::copy):
(StyleRulePage):
(StyleRuleBlock):
(WebCore::StyleRuleMedia::copy):
(StyleRuleMedia):
(WebCore::StyleRuleRegion::copy):
(StyleRuleRegion):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore):
(WebCore::StyleRuleKeyframes::StyleRuleKeyframes):
* css/WebKitCSSKeyframesRule.h:
(WebCore):
(WebCore::StyleRuleKeyframes::copy):
(StyleRuleKeyframes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRevert r115009; It doesn't make necessary changes to NodeRareData and Node.
rniwa@webkit.org [Tue, 24 Apr 2012 21:24:50 +0000 (21:24 +0000)]
Revert r115009; It doesn't make necessary changes to NodeRareData and Node.

Source/WebCore:

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
* html/CollectionType.h:
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::shouldIncludeChildren):
(WebCore::HTMLCollection::isAcceptableElement):
* html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::HTMLFormCollection):
* html/RadioNodeList.cpp: Removed.
* html/RadioNodeList.h: Removed.
* html/RadioNodeList.idl: Removed.

LayoutTests:

* fast/forms/form-collection-radio-node-list-expected.txt: Removed.
* fast/forms/form-collection-radio-node-list.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWaveTable should normalize to 0dbFS instead of -6dbFS
crogers@google.com [Tue, 24 Apr 2012 21:20:09 +0000 (21:20 +0000)]
WaveTable should normalize to 0dbFS instead of -6dbFS
https://bugs.webkit.org/show_bug.cgi?id=84644

Reviewed by Kenneth Russell.

No new tests. Oscillator tests will be rebaselined after landing, since several platforms are affected.

* Modules/webaudio/WaveTable.cpp:
(WebCore::WaveTable::createBandLimitedTables):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Test expectations updates to make lint happy.
hclam@chromium.org [Tue, 24 Apr 2012 21:15:55 +0000 (21:15 +0000)]
Unreviewed. Test expectations updates to make lint happy.

Some test files are removed or moved so update test expectations accordingly.

* platform/chromium/test_expectations.txt:
* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream API: Create a new flag for PeerConnection
tommyw@google.com [Tue, 24 Apr 2012 21:14:21 +0000 (21:14 +0000)]
MediaStream API: Create a new flag for PeerConnection
https://bugs.webkit.org/show_bug.cgi?id=84723

Reviewed by Dimitri Glazkov.

To allow Chrome to make the GetUserMedia functionality available by default we
need another flag for the PeerConnection related parts. This new flag is in
addition to the general media stream flag, and both need to be enabled for
PeerConnection object creation.

Source/WebCore:

No code behavior changes.

* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::peerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::setPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitDeprecatedPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitPeerConnection00Enabled):

Source/WebKit/chromium:

* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enablePeerConnection):
(WebKit):
(WebKit::WebRuntimeFeatures::isPeerConnectionEnabled):

Tools:

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline 2 tests after r115091
robert@webkit.org [Tue, 24 Apr 2012 21:13:59 +0000 (21:13 +0000)]
Rebaseline 2 tests after r115091

Unreviewed.

* platform/mac/accessibility/table-detection-expected.txt:
* platform/mac/accessibility/table-with-rules-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Rebaseline and enable the background-blur layout tests
danakj@chromium.org [Tue, 24 Apr 2012 21:10:54 +0000 (21:10 +0000)]
[chromium] Rebaseline and enable the background-blur layout tests
https://bugs.webkit.org/show_bug.cgi?id=84654

Unreviewed.

* platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt: Removed.
* platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Added.
* platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, 32-bit build fix.
fpizlo@apple.com [Tue, 24 Apr 2012 21:01:19 +0000 (21:01 +0000)]
Unreviewed, 32-bit build fix.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Revert broken changes to authentication dialog
commit-queue@webkit.org [Tue, 24 Apr 2012 20:52:51 +0000 (20:52 +0000)]
[BlackBerry] Revert broken changes to authentication dialog
https://bugs.webkit.org/show_bug.cgi?id=80135

Patch by Joe Mason <jmason@rim.com> on 2012-04-24
Reviewed by Antonio Gomes.

The previous patches from this bug caused an infinite loop when using digest auth;
apparently they were only tested with basic.

Source/WebCore:

* platform/blackberry/PageClientBlackBerry.h:
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleAuthHeader):
(WebCore::NetworkJob::sendRequestWithCredentials):

Source/WebKit/blackberry:

* Api/DumpRenderTreeClient.h:
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
* Api/WebPageClient.h:
* Api/WebPage_p.h:
(WebPagePrivate):

Tools:

* DumpRenderTree/blackberry/DumpRenderTree.cpp:
* DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG performs incorrect DCE on (some?) intrinsics
fpizlo@apple.com [Tue, 24 Apr 2012 20:43:01 +0000 (20:43 +0000)]
DFG performs incorrect DCE on (some?) intrinsics
https://bugs.webkit.org/show_bug.cgi?id=84746
<rdar://problem/11310772>

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::setIntrinsicResult):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

LayoutTests:

Rubber stamped by Oliver Hunt.

* fast/js/dfg-dead-min-one-arg-expected.txt: Added.
* fast/js/dfg-dead-min-one-arg.html: Added.
* fast/js/dfg-dead-min-two-args-expected.txt: Added.
* fast/js/dfg-dead-min-two-args.html: Added.
* fast/js/script-tests/dfg-dead-min-one-arg.js: Added.
(foo):
(.x.f.valueOf):
* fast/js/script-tests/dfg-dead-min-two-args.js: Added.
(foo):
(bar):
(.x.f.valueOf):
(.y.f.valueOf):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix wrong ASSERT() in findAttributeInVector()
caio.oliveira@openbossa.org [Tue, 24 Apr 2012 20:23:27 +0000 (20:23 +0000)]
Fix wrong ASSERT() in findAttributeInVector()
https://bugs.webkit.org/show_bug.cgi?id=84756

Unreviewed build fix.

* dom/ElementAttributeData.h:
(WebCore::findAttributeInVector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate the scroll layer position on the main thread when viewing full-frame images
andersca@apple.com [Tue, 24 Apr 2012 20:15:02 +0000 (20:15 +0000)]
Update the scroll layer position on the main thread when viewing full-frame images
https://bugs.webkit.org/show_bug.cgi?id=84754
<rdar://problem/11193304>

Reviewed by Andreas Kling.

Showing really big images can be slow sometimes and in that case it's better to update the scroll layer position on
the main thread, which will avoid flashing white.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline mac rendertree output for svg/custom/use-css-events.svg.
kling@webkit.org [Tue, 24 Apr 2012 20:01:45 +0000 (20:01 +0000)]
Rebaseline mac rendertree output for svg/custom/use-css-events.svg.

* platform/mac/svg/custom/use-css-events-expected.txt: Updated for custom ellipse renderer changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse Vector<Attribute> directly instead of encapsulating it in AttributeVector
caio.oliveira@openbossa.org [Tue, 24 Apr 2012 19:59:02 +0000 (19:59 +0000)]
Use Vector<Attribute> directly instead of encapsulating it in AttributeVector
https://bugs.webkit.org/show_bug.cgi?id=84413

Reviewed by Andreas Kling.

As commented in https://bugs.webkit.org/show_bug.cgi?id=79963#c16 we do not
usually subclass basic types like Vector. This patch changes code to use
Vector<Attribute> directly and move around the functionality of the former
methods to more specific helper functions or inline code at the callers.

* dom/Element.cpp:
(WebCore::Element::parserSetAttributes):
(WebCore::Element::normalizeAttributes):
* dom/Element.h:
(Element):
* dom/ElementAttributeData.cpp:
* dom/ElementAttributeData.h:
(WebCore::getAttributeFromVector):
(WebCore::ElementAttributeData::getAttributeItem):
(ElementAttributeData):
(WebCore::ElementAttributeData::attributeVector):
(WebCore::ElementAttributeData::clonedAttributeVector):
(WebCore::ElementAttributeData::getAttributeItemIndex):
(WebCore):
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):
* html/parser/HTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
* html/parser/HTMLTreeBuilder.h:
* html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::insertFakePreElement):
* xml/XMLErrors.cpp:
(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):
* xml/parser/MarkupTokenBase.h:
(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::getAttributeItem):
(WebCore::AtomicMarkupTokenBase::attributes):
(AtomicMarkupTokenBase):
(WebCore::::initializeAttributes):
* xml/parser/XMLToken.h:
(WebCore::AtomicXMLToken::AtomicXMLToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream API: Moving LT/fast/dom/MediaStream/* to LT/fast/mediastream
tommyw@google.com [Tue, 24 Apr 2012 19:47:10 +0000 (19:47 +0000)]
MediaStream API: Moving LT/fast/dom/MediaStream/* to LT/fast/mediastream
https://bugs.webkit.org/show_bug.cgi?id=82870

Reviewed by Dimitri Glazkov.

* fast/dom/MediaStream/script-tests/argument-types.js: Removed.
* fast/mediastream/argument-types-expected.txt: Renamed from LayoutTests/fast/dom/MediaStream/argument-types-expected.txt.
* fast/mediastream/argument-types.html: Renamed from LayoutTests/fast/dom/MediaStream/argument-types.html.
* fast/mediastream/enabled-expected.txt: Renamed from LayoutTests/fast/dom/MediaStream/enabled-expected.txt.
* fast/mediastream/enabled.html: Renamed from LayoutTests/fast/dom/MediaStream/enabled.html.
* fast/mediastream/no-interface-object-expected.txt: Renamed from LayoutTests/fast/dom/MediaStream/no-interface-object-expected.txt.
* fast/mediastream/no-interface-object.html: Renamed from LayoutTests/fast/dom/MediaStream/no-interface-object.html.
* fast/mediastream/peerconnection-Attributes.html:
* fast/mediastream/peerconnection-argument-types.html:
* fast/mediastream/script-tests/argument-types.js:
(test):
* fast/mediastream/script-tests/enabled.js: Renamed from LayoutTests/fast/dom/MediaStream/script-tests/enabled.js.
(hasGetUserMediaProperty):
* fast/mediastream/script-tests/no-interface-object.js: Renamed from LayoutTests/fast/dom/MediaStream/script-tests/no-interface-object.js.
(shouldThrowReferenceError):
(test):
* fast/mediastream/script-tests/peerconnection-Attributes.js: Renamed from LayoutTests/fast/mediastream/script-tests/Attributes.js.
(shouldNotThrow):
(test):
(shouldBeA):
(shouldBeTrueA):
(emptyFunction):
(ObjectThrowingException.prototype.toString):
(gotStream):
(gotStreamFailed):
* fast/mediastream/script-tests/peerconnection-argument-types.js: Copied from LayoutTests/fast/mediastream/script-tests/argument-types.js.
(shouldNotThrow):
(test):
(emptyFunction):
(ObjectThrowingException.prototype.toString):
* platform/efl/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename CSSStyleSelector class to StyleResolver.
alexis.menard@openbossa.org [Tue, 24 Apr 2012 19:46:29 +0000 (19:46 +0000)]
Rename CSSStyleSelector class to StyleResolver.
https://bugs.webkit.org/show_bug.cgi?id=84734

Reviewed by Andreas Kling.

The name CSSStyleSelector is confusing as it conflicts a bit with
the CSS concept of selectors. One could think it's an encapsulation
of the CSS selectors but it's not, in fact this class is responsible
of finding the RenderStyle for a given element. This is the first patch
as I will later rename the files, and then rename the local variables.

Source/WebCore:

No new tests : renaming, no behavior changes should appear.

* css/CSSCalculationValue.cpp:
(WebCore::CSSCalcPrimitiveValue::toCalcValue):
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseSizeParameter):
* css/CSSStyleSelector.cpp:
(RuleSet):
(WebCore::RuleSet::features):
(WebCore):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addAuthorRulesAndCollectUserRulesFromSheets):
(WebCore::makeRuleSet):
(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::determineScope):
(WebCore::StyleResolver::ruleSetForScope):
(WebCore::StyleResolver::appendAuthorStylesheets):
(WebCore::StyleResolver::setupScopeStack):
(WebCore::StyleResolver::pushScope):
(WebCore::StyleResolver::popScope):
(WebCore::StyleResolver::pushParentElement):
(WebCore::StyleResolver::popParentElement):
(WebCore::StyleResolver::pushParentShadowRoot):
(WebCore::StyleResolver::popParentShadowRoot):
(WebCore::StyleResolver::addKeyframeStyle):
(WebCore::StyleResolver::~StyleResolver):
(WebCore::StyleResolver::sweepMatchedPropertiesCache):
(WebCore::StyleResolver::Features::Features):
(WebCore::StyleResolver::Features::~Features):
(WebCore::StyleResolver::Features::add):
(WebCore::StyleResolver::Features::clear):
(WebCore::StyleResolver::addMatchedProperties):
(WebCore::StyleResolver::addElementStyleProperties):
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/CSSStyleSelector.h:
(StyleResolver):
(Features):
* css/MediaQueryEvaluator.cpp:
(WebCore::MediaQueryEvaluator::eval):
* css/MediaQueryEvaluator.h:
(WebCore):
(MediaQueryEvaluator):
* css/MediaQueryMatcher.cpp:
(WebCore::MediaQueryMatcher::prepareEvaluator):
* css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
* css/StyleBuilder.cpp:
(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyDefaultBase::applyInheritValue):
(WebCore::ApplyPropertyDefaultBase::applyInitialValue):
(WebCore::ApplyPropertyDefaultBase::applyValue):
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyClip::applyInheritValue):
(WebCore::ApplyPropertyClip::applyInitialValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::applyColorValue):
(WebCore::ApplyPropertyDirection::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFillLayer::applyInheritValue):
(WebCore::ApplyPropertyFillLayer::applyInitialValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyInheritValue):
(WebCore::ApplyPropertyFont::applyInitialValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontSize::applyInheritValue):
(WebCore::ApplyPropertyFontSize::applyInitialValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyBorderImage::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::ApplyPropertyBorderImageModifier::applyValue):
(WebCore::ApplyPropertyBorderImageSource::applyValue):
(WebCore::ApplyPropertyCounter::emptyFunction):
(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyInheritValue):
(WebCore::ApplyPropertyCursor::applyInitialValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyUnicodeBidi::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::applyInheritValue):
(WebCore::ApplyPropertyPageSize::applyInitialValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
(WebCore::ApplyPropertyOutlineStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyInheritValue):
(WebCore::ApplyPropertyAspectRatio::applyInitialValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyZoom::resetEffectiveZoom):
(WebCore::ApplyPropertyZoom::applyInheritValue):
(WebCore::ApplyPropertyZoom::applyInitialValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::isValidDisplayValue):
(WebCore::ApplyPropertyDisplay::applyInheritValue):
(WebCore::ApplyPropertyDisplay::applyInitialValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyFlex::applyInheritValue):
(WebCore::ApplyPropertyFlex::applyInitialValue):
(WebCore::ApplyPropertyFlex::applyValue):
(WebCore::StyleBuilder::StyleBuilder):
* css/StyleBuilder.h:
(WebCore):
(PropertyHandler):
(WebCore::PropertyHandler::applyInheritValue):
(WebCore::PropertyHandler::applyInitialValue):
(WebCore::PropertyHandler::applyValue):
* css/StyleMedia.cpp:
(WebCore::StyleMedia::matchMedium):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::setName):
* css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
* dom/Document.cpp:
(WebCore::Document::recalcStyle):
(WebCore::Document::createStyleSelector):
(WebCore::Document::testAddedStylesheetRequiresStyleRecalc):
* dom/Document.h:
(WebCore):
(WebCore::Document::styleSelectorIfExists):
(WebCore::Document::styleSelector):
(Document):
* dom/Element.cpp:
(StyleSelectorParentPusher):
(WebCore::Element::attributeChanged):
(WebCore::Element::beginParsingChildren):
(WebCore::Element::finishParsingChildren):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::attach):
* dom/ShadowTree.cpp:
(WebCore::ShadowTree::recalcShadowTreeStyle):
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::mergeStyleFromRules):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
(WebCore::EditingStyle::removePropertiesInElementDefaultStyle):
(WebCore::legacyFontSizeFromCSSValue):
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::focusedOrActiveStateChanged):
* history/CachedPage.cpp:
(WebCore::CachedPage::restore):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::styleSelector):
* html/HTMLCanvasElement.h:
(HTMLCanvasElement):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::getMatchedCSSRules):
* page/Page.cpp:
(WebCore::Page::allVisitedStateChanged):
(WebCore::Page::visitedStateChanged):
* page/animation/AnimationController.cpp:
(WebCore::AnimationController::updateAnimations):
* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::adjustButtonStyle):
(WebCore::RenderThemeBlackBerry::adjustTextAreaStyle):
(WebCore::RenderThemeBlackBerry::adjustTextFieldStyle):
(WebCore::RenderThemeBlackBerry::adjustSearchFieldStyle):
(WebCore::RenderThemeBlackBerry::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeBlackBerry::adjustMenuListButtonStyle):
(WebCore::RenderThemeBlackBerry::adjustMenuListStyle):
(WebCore::RenderThemeBlackBerry::adjustCheckboxStyle):
(WebCore::RenderThemeBlackBerry::adjustRadioStyle):
* platform/blackberry/RenderThemeBlackBerry.h:
(RenderThemeBlackBerry):
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::adjustSliderTrackStyle):
(WebCore::RenderThemeEfl::adjustSliderThumbStyle):
(WebCore::RenderThemeEfl::adjustCheckboxStyle):
(WebCore::RenderThemeEfl::adjustRadioStyle):
(WebCore::RenderThemeEfl::adjustButtonStyle):
(WebCore::RenderThemeEfl::adjustMenuListStyle):
(WebCore::RenderThemeEfl::adjustMenuListButtonStyle):
(WebCore::RenderThemeEfl::adjustTextFieldStyle):
(WebCore::RenderThemeEfl::adjustTextAreaStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldStyle):
(WebCore::RenderThemeEfl::adjustProgressBarStyle):
* platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::adjustButtonStyle):
(WebCore::RenderThemeGtk::adjustMenuListStyle):
(WebCore::RenderThemeGtk::adjustMenuListButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldStyle):
(WebCore::RenderThemeGtk::adjustSliderTrackStyle):
(WebCore::RenderThemeGtk::adjustSliderThumbStyle):
(WebCore::RenderThemeGtk::adjustProgressBarStyle):
* platform/gtk/RenderThemeGtk.h:
(RenderThemeGtk):
* platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::adjustTextAreaStyle):
(WebCore::RenderThemeQt::adjustMenuListStyle):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::adjustProgressBarStyle):
(WebCore::RenderThemeQt::adjustSliderTrackStyle):
(WebCore::RenderThemeQt::adjustSliderThumbStyle):
(WebCore::RenderThemeQt::adjustSearchFieldStyle):
(WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeQt::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQt::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
* platform/qt/RenderThemeQt.h:
(RenderThemeQt):
* platform/qt/RenderThemeQtMobile.cpp:
(WebCore::RenderThemeQtMobile::adjustButtonStyle):
(WebCore::RenderThemeQtMobile::adjustTextFieldStyle):
(WebCore::RenderThemeQtMobile::adjustMenuListStyle):
* platform/qt/RenderThemeQtMobile.h:
(RenderThemeQtMobile):
* platform/wx/RenderThemeWx.cpp:
(RenderThemeWx):
(WebCore::RenderThemeWx::adjustButtonStyle):
(WebCore::RenderThemeWx::adjustTextFieldStyle):
(WebCore::RenderThemeWx::adjustMenuListStyle):
(WebCore::RenderThemeWx::adjustMenuListButtonStyle):
* rendering/RenderInputSpeech.cpp:
(WebCore::RenderInputSpeech::adjustInputFieldSpeechButtonStyle):
* rendering/RenderInputSpeech.h:
(RenderInputSpeech):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::adjustCheckboxStyle):
(WebCore::RenderTheme::adjustRadioStyle):
(WebCore::RenderTheme::adjustButtonStyle):
(WebCore::RenderTheme::adjustInnerSpinButtonStyle):
(WebCore::RenderTheme::adjustTextFieldStyle):
(WebCore::RenderTheme::adjustTextAreaStyle):
(WebCore::RenderTheme::adjustMenuListStyle):
(WebCore::RenderTheme::adjustInputFieldSpeechButtonStyle):
(WebCore::RenderTheme::adjustMeterStyle):
(WebCore::RenderTheme::adjustProgressBarStyle):
(WebCore::RenderTheme::adjustMenuListButtonStyle):
(WebCore::RenderTheme::adjustSliderTrackStyle):
(WebCore::RenderTheme::adjustSliderThumbStyle):
(WebCore::RenderTheme::adjustSearchFieldStyle):
(WebCore::RenderTheme::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderTheme::adjustSearchFieldDecorationStyle):
(WebCore::RenderTheme::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderTheme::adjustSearchFieldResultsButtonStyle):
* rendering/RenderTheme.h:
(RenderTheme):
* rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::adjustInnerSpinButtonStyle):
* rendering/RenderThemeChromiumAndroid.h:
(RenderThemeChromiumAndroid):
* rendering/RenderThemeChromiumLinux.cpp:
(WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle):
* rendering/RenderThemeChromiumLinux.h:
(RenderThemeChromiumLinux):
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::adjustButtonStyle):
(WebCore::RenderThemeChromiumSkia::adjustSearchFieldStyle):
(WebCore::RenderThemeChromiumSkia::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeChromiumSkia::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeChromiumSkia::adjustMenuListStyle):
(WebCore::RenderThemeChromiumSkia::adjustMenuListButtonStyle):
* rendering/RenderThemeChromiumSkia.h:
(RenderThemeChromiumSkia):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore):
(WebCore::RenderThemeChromiumWin::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeChromiumWin::adjustProgressBarStyle):
* rendering/RenderThemeChromiumWin.h:
(RenderThemeChromiumWin):
* rendering/RenderThemeMac.h:
(RenderThemeMac):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::setFontFromControlSize):
(WebCore::RenderThemeMac::adjustTextFieldStyle):
(WebCore::RenderThemeMac::adjustTextAreaStyle):
(WebCore::RenderThemeMac::adjustProgressBarStyle):
(WebCore::RenderThemeMac::adjustMenuListStyle):
(WebCore::RenderThemeMac::adjustMenuListButtonStyle):
(WebCore::RenderThemeMac::adjustSliderTrackStyle):
(WebCore::RenderThemeMac::adjustSliderThumbStyle):
(WebCore::RenderThemeMac::adjustSearchFieldStyle):
(WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::setFontFromControlSize):
(WebCore::RenderThemeSafari::adjustButtonStyle):
(WebCore::RenderThemeSafari::adjustTextFieldStyle):
(WebCore::RenderThemeSafari::adjustTextAreaStyle):
(WebCore::RenderThemeSafari::adjustMenuListStyle):
(WebCore::RenderThemeSafari::adjustMenuListButtonStyle):
(WebCore::RenderThemeSafari::adjustSliderThumbStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldResultsButtonStyle):
* rendering/RenderThemeSafari.h:
(RenderThemeSafari):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeWin::adjustMenuListStyle):
(WebCore::RenderThemeWin::adjustMenuListButtonStyle):
(WebCore::RenderThemeWin::adjustSearchFieldStyle):
(WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeWin::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle):
* rendering/RenderThemeWin.h:
(RenderThemeWin):
(WebCore::RenderThemeWin::adjustButtonStyle):
(WebCore::RenderThemeWin::adjustTextFieldStyle):
(WebCore::RenderThemeWin::adjustTextAreaStyle):
* rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::adjustMenuListStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeWinCE::adjustMenuListButtonStyle):
* rendering/RenderThemeWinCE.h:
(RenderThemeWinCE):
(WebCore::RenderThemeWinCE::adjustButtonStyle):
(WebCore::RenderThemeWinCE::adjustTextFieldStyle):
(WebCore::RenderThemeWinCE::adjustTextAreaStyle):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::isStyleAvailable):
* rendering/style/RenderStyle.h:
(WebCore):
* rendering/style/StyleRareNonInheritedData.h:
(WebCore):
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::isOverflowHidden):

Source/WebKit/qt:

* WebCoreSupport/RenderThemeQStyle.cpp:
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
* WebCoreSupport/RenderThemeQStyle.h:
(RenderThemeQStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115097 268f45cc-cd09-0410-ab3c-d52691b4dbfc