WebKit-https.git
7 years agoUse after free in JSC::DFG::ByteCodeParser::processPhiStack
fpizlo@apple.com [Wed, 23 May 2012 23:12:59 +0000 (23:12 +0000)]
Use after free in JSC::DFG::ByteCodeParser::processPhiStack
https://bugs.webkit.org/show_bug.cgi?id=87312
<rdar://problem/11518848>

Reviewed by Oliver Hunt.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::parse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Turn ENABLE(OVERFLOW_SCROLLING) off for Chromium port
jamesr@google.com [Wed, 23 May 2012 23:06:30 +0000 (23:06 +0000)]
[chromium] Turn ENABLE(OVERFLOW_SCROLLING) off for Chromium port
https://bugs.webkit.org/show_bug.cgi?id=87177

Reviewed by Eric Seidel.

Source/WebKit/chromium:

Removes ENABLE(OVERFLOW_SCROLLING) from the set of enables set by Chromium. This guards a new non-standard
CSS property, -webkit-overflow-scrolling, that was introduced by iOS5 intended for mobile browsers. This
property is very partially implemented in Chromium but the way it's implemented does cause new stacking contexts
to be created that otherwise would not be, breaking "desktop" pages.

This turns the feature off until we can figure out how to deal with the compatibility issues.

* features.gypi:

LayoutTests:

Mark test depending on ENABLE(OVERFLOW_SCROLLING) as an expected failure since the define is off.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Provides a way to cancel an external popup menu before it is shown.
jcivelli@chromium.org [Wed, 23 May 2012 22:28:24 +0000 (22:28 +0000)]
[chromium] Provides a way to cancel an external popup menu before it is shown.
https://bugs.webkit.org/show_bug.cgi?id=83474

Reviewed by Kent Tamura.

* src/ExternalPopupMenu.cpp:
(WebKit::ExternalPopupMenu::show):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIt should be possible to make C function calls from DFG code on ARM in debug mode
fpizlo@apple.com [Wed, 23 May 2012 22:25:21 +0000 (22:25 +0000)]
It should be possible to make C function calls from DFG code on ARM in debug mode
https://bugs.webkit.org/show_bug.cgi?id=87313

Reviewed by Gavin Barraclough.

* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] fast/url/path.html with Qt5 differ results on both WK1 and WK2
commit-queue@webkit.org [Wed, 23 May 2012 22:22:16 +0000 (22:22 +0000)]
[Qt] fast/url/path.html with Qt5 differ results on both WK1 and WK2
https://bugs.webkit.org/show_bug.cgi?id=77380

Patch by Hugo Parente Lima <hugo.lima@openbossa.org> on 2012-05-23
Reviewed by Kenneth Rohde Christiansen.

The test pass on qt5-wk2, but not on qt5-wk1.

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: [chromium] DomStorage events handling needs TLC (3)
michaeln@google.com [Wed, 23 May 2012 22:04:51 +0000 (22:04 +0000)]
Source/WebCore: [chromium] DomStorage events handling needs TLC (3)
https://bugs.webkit.org/show_bug.cgi?id=87031
https://code.google.com/p/chromium/issues/detail?id=128482
Create WebCore::Storage instances as a side effect of attaching storage event handlers.
This allows storage events in chromium to be propagated with less IPC chatter.

Worth noting that in non-chromium ports, creation of the localStorage instance can have
an additional side effect of scheduling a background task to read the area's values
from disk, which given the interest in events is probably a beneficial side effect.

Reviewed by Adam Barth.

No new tests. Existing tests cover this.

* page/DOMWindow.cpp:
(WebCore::didAddStorageEventListener):
(WebCore::DOMWindow::addEventListener):

Source/WebKit/chromium: [chromium] DomStorage events handling needs TLC (3)
https://bugs.webkit.org/show_bug.cgi?id=87031
https://code.google.com/p/chromium/issues/detail?id=128482
Only queue storage events for Documents which have allocated
a WebCore::Storage instance since pages that have attached onstorage
event handlers must have a non-null Storage instance.

Reviewed by Adam Barth.

* src/StorageAreaProxy.cpp:
(WebCore::StorageAreaProxy::dispatchLocalStorageEvent):
(WebCore::StorageAreaProxy::dispatchSessionStorageEvent):
(WebCore::StorageAreaProxy::isEventSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in fast/files/read tests during Garbage Collection
msaboff@apple.com [Wed, 23 May 2012 21:59:44 +0000 (21:59 +0000)]
Crash in fast/files/read tests during Garbage Collection
https://bugs.webkit.org/show_bug.cgi?id=87165

Reviewed by Alexey Proskuryakov.

Changed hasPendingActivity() processing to use ActiveDOMObject::hasPendingActivity()
and associated setPendingActivity() / unsetPendingActivity().

Fixed two existing tests with change.

* Modules/filesystem/FileWriter.cpp:
(WebCore::FileWriter::stop):
(WebCore::FileWriter::write):
(WebCore::FileWriter::truncate):
(WebCore::FileWriter::signalCompletion):
* Modules/filesystem/FileWriter.h:
* fileapi/FileReader.cpp:
(WebCore::FileReader::readInternal):
(WebCore::FileReader::doAbort):
(WebCore::FileReader::didFinishLoading):
(WebCore::FileReader::didFail):
* fileapi/FileReader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r118218.
jsbell@chromium.org [Wed, 23 May 2012 21:59:29 +0000 (21:59 +0000)]
Unreviewed, rolling out r118218.
http://trac.webkit.org/changeset/118218
https://bugs.webkit.org/show_bug.cgi?id=87299

breaks webkit win builder (Requested by pilgrim_google__ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-23

Source/Platform:

* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
(Platform):
* chromium/public/WebLocalizedString.h: Removed.

Source/WebKit/chromium:

* WebKit.gyp:
* public/platform/WebKitPlatformSupport.h:
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::queryLocalizedString):
* public/platform/WebLocalizedString.h:
(WebKit):
* src/LocalizedStrings.cpp:
(WebCore::query):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebgl/context-lost failing on Lion
kbr@google.com [Wed, 23 May 2012 21:56:41 +0000 (21:56 +0000)]
webgl/context-lost failing on Lion
https://bugs.webkit.org/show_bug.cgi?id=81284

Unreviewed test expectations update. The fix for Bug 87136 fixed
the underlying bug here; adjusting test expectations.

* platform/mac-snowleopard/fast/canvas/webgl/context-lost-expected.txt: Removed.
* platform/mac/fast/canvas/webgl/context-lost-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd vollick to list of contributors.
commit-queue@webkit.org [Wed, 23 May 2012 21:54:56 +0000 (21:54 +0000)]
Add vollick to list of contributors.
https://bugs.webkit.org/show_bug.cgi?id=87305

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-23
Reviewed by Adam Barth.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in run-ins with continuations while moving back to original position.
inferno@chromium.org [Wed, 23 May 2012 21:51:06 +0000 (21:51 +0000)]
Crash in run-ins with continuations while moving back to original position.
https://bugs.webkit.org/show_bug.cgi?id=87264

Reviewed by Julien Chaffraix.

Source/WebCore:

Run-in that are now placed in sibling block can break up into continuation
chains when new children are added to it. We cannot easily send them back to their
original place since that requires writing integration logic with RenderInline::addChild
and all other places that might cause continuations to be created (without blowing away
|this|). Disabling this feature for now to prevent crashes.

Test: fast/runin/runin-continuations-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::moveRunInToOriginalPosition):

LayoutTests:

* fast/runin/runin-continuations-crash-expected.txt: Added.
* fast/runin/runin-continuations-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in RenderInline::linesVisualOverflowBoundingBox.
inferno@chromium.org [Wed, 23 May 2012 21:47:51 +0000 (21:47 +0000)]
Crash in RenderInline::linesVisualOverflowBoundingBox.
https://bugs.webkit.org/show_bug.cgi?id=85804

Reviewed by Dave Hyatt.

Source/WebCore:

Defer layout of replaced elements to the next line break function.
We shouldn't do it while we are clearing our inline chilren
lineboxes in full layout mode.

Test: fast/block/inline-children-root-linebox-crash.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):

LayoutTests:

* fast/block/inline-children-root-linebox-crash-expected.txt: Added.
* fast/block/inline-children-root-linebox-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: AudioParam must support fan-in (multiple audio connections) (take 2)
crogers@google.com [Wed, 23 May 2012 21:46:15 +0000 (21:46 +0000)]
Source/WebCore: AudioParam must support fan-in (multiple audio connections) (take 2)
https://bugs.webkit.org/show_bug.cgi?id=83610

Reviewed by Kenneth Russell.

This re-lands bug: https://bugs.webkit.org/show_bug.cgi?id=83610
Now that a fix has been landed: http://trac.webkit.org/changeset/118099

Test: webaudio/audioparam-summingjunction.html

* Modules/webaudio/AudioParam.cpp:
* Modules/webaudio/AudioParam.h:
(WebCore::AudioParam::calculateSampleAccurateValues):
(WebCore::AudioParam::calculateAudioRateSignalValues):
Sums intrinsic parameter value with all audio-rate connections.

(WebCore::AudioParam::connect):
(WebCore::AudioParam::disconnect):
Support multiple connections.

(WebCore::AudioParam::hasSampleAccurateValues):
If we have one or more audio-rate connections.

(WebCore::AudioParam::AudioParam):
AudioParam now sub-classes AudioSummingJunction.

LayoutTests: AudioParam must support fan-in (multiple audio connections)
https://bugs.webkit.org/show_bug.cgi?id=83610

Reviewed by Kenneth Russell.

* webaudio/audioparam-connect-audioratesignal.html:
* webaudio/audioparam-summingjunction-expected.txt: Added.
* webaudio/audioparam-summingjunction.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThere are no shared worker filesystem tests
ericu@chromium.org [Wed, 23 May 2012 21:37:04 +0000 (21:37 +0000)]
There are no shared worker filesystem tests
https://bugs.webkit.org/show_bug.cgi?id=83828

Reviewed by David Levin.

* fast/filesystem/resources/file-writer-events.js:
Minor tweak to prevent double-import of js-test-pre.js
* fast/filesystem/resources/shared-worker-stub.js: Added.
Stub that imports js-test-pre.js for shared workers, so that we don't
actually import the test script until postMessage has somewhere to go.
* fast/filesystem/workers/file-writer-events-shared-worker-expected.txt: Added.
* fast/filesystem/workers/file-writer-events-shared-worker.html: Added.
The new test, running the same old file-writer-events.js that runs in
document and worker context.
* fast/js/resources/js-test-pre.js:
Previously it looked like startWorker supported creating shared workers;
there was an option, but it was a lie.  If you used it, it was
completely broken.  This adds a functional minimal implementation.
(startWorker.worker.port.onmessage):
(startWorker):
(.self.onconnect.workerPort.onmessage):
(.self.onconnect):
(.description):
(.testFailed):
(.testPassed):
(.finishJSTest):
(.debug):
* platform/chromium/test_expectations.txt:
DumpRenderTree and test_shell don't support shared workers; you have to
run this by hand in Chrome.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (117623) - Entering/exiting fullscreen HTML5 videos, there is a quick...
jer.noble@apple.com [Wed, 23 May 2012 21:15:21 +0000 (21:15 +0000)]
REGRESSION (117623) - Entering/exiting fullscreen HTML5 videos, there is a quick animated fade
https://bugs.webkit.org/show_bug.cgi?id=87294

Reviewed by Darin Adler.

When setting the sublayers array on the layer hosting view, wrap the call in a CATransaction which disables
animations.

* UIProcess/API/mac/WKView.mm:
(-[WKView _updateAcceleratedCompositingMode:WebKit::]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium-Android] Fix chromium_android_unittest
wangxianzhu@chromium.org [Wed, 23 May 2012 21:13:51 +0000 (21:13 +0000)]
[Chromium-Android] Fix chromium_android_unittest
https://bugs.webkit.org/show_bug.cgi?id=87196

Reviewed by Tony Chang.

Update unit tests after ChromiumAndroidPort supported apk based
DumpRenderTree.

* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidPortTest):
(ChromiumAndroidPortTest.mock_run_command_fn): Moved out from test_get_last_stacktrace so that other tests can use it as a common command line handler.
(ChromiumAndroidPortTest.test_get_last_stacktrace):
(ChromiumAndroidPortTest.test_get_crash_log): Added to test our overridden _get_crash_log()
(ChromiumAndroidDriverTest):
(ChromiumAndroidDriverTest.setUp):
(ChromiumAndroidDriverTest.test_cmd_line): Added to test our overridden cmd_line()
(ChromiumAndroidDriverTest.test_write_command_and_read_line): Added test of unexpected EOF (indicating crash on Android)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[watchlist] Add myself and create a watch rule to catch Attribute related patches
caio.oliveira@openbossa.org [Wed, 23 May 2012 21:02:33 +0000 (21:02 +0000)]
[watchlist] Add myself and create a watch rule to catch Attribute related patches
https://bugs.webkit.org/show_bug.cgi?id=87303

Reviewed by Alexis Menard.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] webintents/web-intents-delivery-reuse.html is failing on EFL port
commit-queue@webkit.org [Wed, 23 May 2012 20:58:48 +0000 (20:58 +0000)]
[EFL] webintents/web-intents-delivery-reuse.html is failing on EFL port
https://bugs.webkit.org/show_bug.cgi?id=87092

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-23
Reviewed by Adam Barth.

Source/WebCore:

Remove readonly keyword from the webkitIntent attribute. This is
needed otherwise the [Replaceable] extended attribute has not effect
with JSC. This is tested by webintents/web-intents-delivery-reuse.html
test case.

* Modules/intents/DOMWindowIntents.idl:

LayoutTests:

Remove webintents/web-intents-delivery-reuse.html from test
expectations now that window.webkitIntent is really replaceable and
now that the test is passing.

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG should be able to inline functions that use arguments reflectively
fpizlo@apple.com [Wed, 23 May 2012 20:52:42 +0000 (20:52 +0000)]
DFG should be able to inline functions that use arguments reflectively
https://bugs.webkit.org/show_bug.cgi?id=86132

Reviewed by Oliver Hunt.

Merged r116838 from dfgopt.

This turns on inlining of functions that use arguments reflectively, but it
does not do any of the obvious optimizations that this exposes. I'll save that
for another patch - the important thing for now is that this contains all of
the plumbing necessary to make this kind of inlining sound even in bizarro
cases like an inline callee escaping the arguments object to parts of the
inline caller where the arguments are otherwise dead. Or even more fun cases
like where you've inlined to an inline stack that is three-deep, and the
function on top of the inline stack reflectively accesses the arguments of a
function that is in the middle of the inline stack. Any subsequent
optimizations that we do for the obvious cases of arguments usage in inline
functions will have to take care not to break the baseline functionality that
this patch plumbs together.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::dump):
* bytecode/CodeBlock.h:
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::argumentsRegisterFor):
(AssemblyHelpers):
* dfg/DFGByteCodeParser.cpp:
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):
* dfg/DFGCapabilities.h:
(JSC::DFG::canInlineOpcode):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* interpreter/CallFrame.cpp:
(JSC):
(JSC::CallFrame::someCodeBlockForPossiblyInlinedCode):
* interpreter/CallFrame.h:
(ExecState):
(JSC::ExecState::someCodeBlockForPossiblyInlinedCode):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::retrieveArgumentsFromVMCode):
* runtime/Arguments.cpp:
(JSC::Arguments::tearOff):
(JSC):
(JSC::Arguments::tearOffForInlineCallFrame):
* runtime/Arguments.h:
(Arguments):
(JSC::Arguments::create):
(JSC::Arguments::finishCreation):
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEvery OSR exit on ARM results in a crash
fpizlo@apple.com [Wed, 23 May 2012 20:51:21 +0000 (20:51 +0000)]
Every OSR exit on ARM results in a crash
https://bugs.webkit.org/show_bug.cgi?id=87307

Reviewed by Geoffrey Garen.

* dfg/DFGThunks.cpp:
(JSC::DFG::osrExitGenerationThunkGenerator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactored heap tear-down to use normal value semantics (i.e., destructors)
ggaren@apple.com [Wed, 23 May 2012 20:47:46 +0000 (20:47 +0000)]
Refactored heap tear-down to use normal value semantics (i.e., destructors)
https://bugs.webkit.org/show_bug.cgi?id=87302

Reviewed by Oliver Hunt.

This is a step toward incremental DOM finalization.

* heap/CopiedSpace.cpp:
(JSC::CopiedSpace::~CopiedSpace):
* heap/CopiedSpace.h:
(CopiedSpace): Just use our destructor, instead of relying on the heap
to send us a special message at a special time.

* heap/Heap.cpp:
(JSC::Heap::Heap): Use OwnPtr for m_markListSet because this is not Sparta.

(JSC::Heap::~Heap): No need for delete or freeAllBlocks because normal
destructors do this work automatically now.

(JSC::Heap::lastChanceToFinalize): Just call lastChanceToFinalize on our
sub-objects, and assume it does the right thing. This improves encapsulation,
so we can add items requiring finalization to our sub-objects.

* heap/Heap.h: Moved m_blockAllocator to get the right destruction order.

* heap/MarkedSpace.cpp:
(Take):
(JSC):
(JSC::Take::Take):
(JSC::Take::operator()):
(JSC::Take::returnValue): Moved to the top of the file so it can be used
in another function.

(JSC::MarkedSpace::~MarkedSpace): Delete all outstanding memory, like a good
destructor should.

(JSC::MarkedSpace::lastChanceToFinalize): Moved some code here from the heap,
since it pertains to our internal implementation details.

* heap/MarkedSpace.h:
(MarkedSpace):
* heap/WeakBlock.cpp:
(JSC::WeakBlock::lastChanceToFinalize):
* heap/WeakBlock.h:
(WeakBlock):
* heap/WeakSet.cpp:
(JSC::WeakSet::lastChanceToFinalize):
* heap/WeakSet.h:
(WeakSet): Stop using a special freeAllBlocks() callback and just implement
lastChanceToFinalize.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Move themeEngine to Platform.h
pilgrim@chromium.org [Wed, 23 May 2012 20:43:20 +0000 (20:43 +0000)]
[Chromium] Move themeEngine to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=87268

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::themeEngine):
* chromium/public/android: Added.
* chromium/public/android/WebThemeEngine.h: Added.
(WebKit):
(WebThemeEngine):
(ScrollbarTrackExtraParams):
(ButtonExtraParams):
(TextFieldExtraParams):
(MenuListExtraParams):
(SliderExtraParams):
(InnerSpinButtonExtraParams):
(ProgressBarExtraParams):
(WebKit::WebThemeEngine::getSize):
(WebKit::WebThemeEngine::paint):
* chromium/public/linux: Added.
* chromium/public/linux/WebThemeEngine.h: Added.
(WebKit):
(WebThemeEngine):
(ScrollbarTrackExtraParams):
(ButtonExtraParams):
(TextFieldExtraParams):
(MenuListExtraParams):
(SliderExtraParams):
(InnerSpinButtonExtraParams):
(ProgressBarExtraParams):
(WebKit::WebThemeEngine::getSize):
(WebKit::WebThemeEngine::paint):
* chromium/public/mac: Added.
* chromium/public/mac/WebThemeEngine.h: Added.
(WebKit):
(WebThemeEngine):
(ScrollbarInfo):
(WebKit::WebThemeEngine::paintScrollbarThumb):
* chromium/public/win: Added.
* chromium/public/win/WebThemeEngine.h: Added.
(WebKit):
(WebThemeEngine):
(WebKit::WebThemeEngine::paintSpinButton):
(WebKit::WebThemeEngine::paintProgressBar):

Source/WebKit/chromium:

* WebKit.gyp:
* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKit::WebKitPlatformSupport::sandboxSupport):
* public/platform/android/WebThemeEngine.h:
* public/platform/linux/WebThemeEngine.h:
* public/platform/mac/WebThemeEngine.h:
* public/platform/win/WebThemeEngine.h:
* src/AssertMatchingEnums.cpp:
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::paintButton):
(WebCore::PlatformSupport::paintMenuList):
(WebCore::PlatformSupport::paintScrollbarArrow):
(WebCore::PlatformSupport::paintScrollbarThumb):
(WebCore::PlatformSupport::paintScrollbarTrack):
(WebCore::PlatformSupport::paintSpinButton):
(WebCore::PlatformSupport::paintTextField):
(WebCore::PlatformSupport::paintTrackbar):
(WebCore::PlatformSupport::paintProgressBar):
(WebCore::PlatformSupport::getThemePartSize):
(WebCore::PlatformSupport::paintThemePart):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoASSERT failure toRenderProgress in HTMLProgressElement::didElementStateChange
inferno@chromium.org [Wed, 23 May 2012 20:41:11 +0000 (20:41 +0000)]
ASSERT failure toRenderProgress in HTMLProgressElement::didElementStateChange
https://bugs.webkit.org/show_bug.cgi?id=87274

Reviewed by Darin Adler.

Source/WebCore:

Progress bar can't run-in. Prevent it from becoming a run-in, leading to an
unworkable RenderInline.

Test: fast/runin/progress-run-in-crash.html

* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::didElementStateChange):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::moveRunInUnderSiblingBlockIfNeeded):

LayoutTests:

* fast/runin/progress-run-in-crash-expected.txt: Added.
* fast/runin/progress-run-in-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agogarden-o-matic should not fetch from debug bots if it also knows about the release...
dpranke@chromium.org [Wed, 23 May 2012 20:35:48 +0000 (20:35 +0000)]
garden-o-matic should not fetch from debug bots if it also knows about the release bots
https://bugs.webkit.org/show_bug.cgi?id=86916

Reviewed by Adam Barth.

This change pushes all of the logic for rebaselining a cluster
of failures (a list of tests failing a list of suffixes on a
list of bots) onto the server, so there is a single call from
the web page; we will then be able to optimize the performance
of the rebaselining better.

Also remove the 'optimizebaseline' entry point on garden-o-matic
(and the client-side call) since we don't need it any more.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
* Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningHTTPRequestHandler.rebaselineall):
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove minimum and maximum scroll position as they are no
commit-queue@webkit.org [Wed, 23 May 2012 20:30:24 +0000 (20:30 +0000)]
Remove minimum and maximum scroll position as they are no
longer required due to changes in ScrollViewBase.
https://bugs.webkit.org/show_bug.cgi?id=87298

Patch by Genevieve Mak <gmak@rim.com> on 2012-05-23
Reviewed by Antonio Gomes.

* WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
* WebKitSupport/InRegionScrollableArea.h:
(InRegionScrollableArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMac DRT should be able to load external URLs for replay performance tests
rniwa@webkit.org [Wed, 23 May 2012 20:21:45 +0000 (20:21 +0000)]
Mac DRT should be able to load external URLs for replay performance tests
https://bugs.webkit.org/show_bug.cgi?id=86191

Reviewed by Alexey Proskuryakov.

Let external URL requests go through if the test file is not a local file or hosted at localhost.
e.g. "DumpRenderTree http://webkit.org/" as supposed to "DumpRenderTree test.html" or
"DumpRenderTree http://localhost:8000/".

* DumpRenderTree/mac/ResourceLoadDelegate.mm:
(isLocalhost):
(hostIsUsedBySomeTestsToGenerateError):
(-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] UI thread unnecessarily blocks on WebKit thread when servicing requestAn...
commit-queue@webkit.org [Wed, 23 May 2012 20:12:34 +0000 (20:12 +0000)]
[BlackBerry] UI thread unnecessarily blocks on WebKit thread when servicing requestAnimationFrames
https://bugs.webkit.org/show_bug.cgi?id=87289

Patch by Andrew Lo <anlo@rim.com> on 2012-05-23
Reviewed by Antonio Gomes.

requestAnimationFrame already covered by tests in LayoutTests/fast/animation.

If UI thread cannot acquire DisplayRefreshMonitor mutex immediately,
avoid blocking on the mutex, it can trigger the frame change on the next
animation tick instead.

* platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp:
(WebCore::DisplayRefreshMonitor::displayLinkFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Wk2] Assertion failure when selecting an option in select list with size attribu...
commit-queue@webkit.org [Wed, 23 May 2012 19:43:57 +0000 (19:43 +0000)]
[Qt][Wk2] Assertion failure when selecting an option in select list with size attribute greater than one
https://bugs.webkit.org/show_bug.cgi?id=86974

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-05-23
Reviewed by Simon Hausmann.

Select list with size attribute greater than one will not initially have any
item in selected state (if no option has 'selected' tag), resulting in
m_selectedModelIndex in WebPopupMenuProxyQt to be invalid. Hence, need to check
whether the old index is invalid before accessing the item at that index.

* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_itemSelector.qml: Added new test that
  tests selection in a select list with size attribute value of 2.
* UIProcess/API/qt/tests/qmltests/common/selectwithsize.html: Added.
* UIProcess/qt/WebPopupMenuProxyQt.cpp:
(WebKit::PopupMenuItemModel::select): Check whether old index is valid before accessing
  the item at that index.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement DOM4 DOMError
commit-queue@webkit.org [Wed, 23 May 2012 19:38:55 +0000 (19:38 +0000)]
Implement DOM4 DOMError
https://bugs.webkit.org/show_bug.cgi?id=87055

Patch by Alec Flett <alecflett@chromium.org> on 2012-05-23
Reviewed by Adam Barth.

Implement the DOMError class and it's IDL interface.

No new tests. Not testable yet, as it's not used.

* WebCore.gypi:
* dom/DOMError.cpp: Added.
(WebCore):
(WebCore::DOMError::DOMError):
* dom/DOMError.h: Added.
(WebCore):
(DOMError):
(WebCore::DOMError::create):
(WebCore::DOMError::name):
* dom/DOMError.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(117918) - 4 webgl/tex-iomage-and-sub-image-2d-with-image tests failing...
kbr@google.com [Wed, 23 May 2012 19:22:03 +0000 (19:22 +0000)]
REGRESSION(117918) - 4 webgl/tex-iomage-and-sub-image-2d-with-image tests failing on Mac bots.
https://bugs.webkit.org/show_bug.cgi?id=87136

Reviewed by Stephen White.

Source/WebCore:

Fixed longstanding bug in GraphicsContext3D constructor in Mac
port, and logic error in tracking of texture bound to unit 0. Also
fixed up Cairo port's constructor by code inspection. This code is
ripe for cleanup; Bug 87198 filed for this.

Covered by existing tests.

* platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
    Initialize missing members.
* platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D):
    Correctly initialize m_activeTexture.
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::bindTexture):
    Fix logic error in tracking of texture bound to unit 0.

LayoutTests:

Unskipped tests.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChange acceptMIMETypes member to acceptTypes now that file extensions are legal accep...
commit-queue@webkit.org [Wed, 23 May 2012 19:09:40 +0000 (19:09 +0000)]
Change acceptMIMETypes member to acceptTypes now that file extensions are legal accept types
https://bugs.webkit.org/show_bug.cgi?id=87271

Patch by Raymes Khoury <raymes@chromium.org> on 2012-05-23
Reviewed by Darin Fisher.

* public/WebFileChooserParams.h:
(WebFileChooserParams):
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::runOpenPanel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Layers on main thread should get a RenderSurface for animating transform...
danakj@chromium.org [Wed, 23 May 2012 18:57:36 +0000 (18:57 +0000)]
[chromium] Layers on main thread should get a RenderSurface for animating transform only if masksToBounds is true also
https://bugs.webkit.org/show_bug.cgi?id=87184

Reviewed by James Robinson.

Source/WebCore:

Layers on main thread get a RenderSurface if their impl counterpart may
have a RenderSurface due to its animating transform. We currently create
a RenderSurface for all layers with an animating transform and
a descendant that drawsContents. But a RenderSurface on impl also
implies that the layer masksToBounds. So only make a RenderSurface on
main thread when the layer also masksToBounds.

Modified unit test CCLayerTreeHostCommonTest.verifyAnimationsForRenderSurfaceHierarchy.

* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::subtreeShouldRenderToSeparateSurface):

Source/WebKit/chromium:

* tests/CCLayerTreeHostCommonTest.cpp:
(WebKitTests::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Move queryLocalizedString to Platform.h
pilgrim@chromium.org [Wed, 23 May 2012 18:53:26 +0000 (18:53 +0000)]
[Chromium] Move queryLocalizedString to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85762

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::queryLocalizedString):
* chromium/public/WebLocalizedString.h: Added.
(WebKit):

Source/WebKit/chromium:

* WebKit.gyp:
* public/platform/WebKitPlatformSupport.h:
(WebKit::WebKitPlatformSupport::getPluginList):
* public/platform/WebLocalizedString.h:
* src/LocalizedStrings.cpp:
(WebCore::query):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Regression(r112694): Crash in WebCore::AXObjectCache::postNotification
cfleizach@apple.com [Wed, 23 May 2012 18:45:15 +0000 (18:45 +0000)]
Source/WebCore: Regression(r112694): Crash in WebCore::AXObjectCache::postNotification
https://bugs.webkit.org/show_bug.cgi?id=86029

Reviewed by Abhishek Arya.

Test: accessibility/content-changed-notification-causes-crash.html

* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isDetached):
(AccessibilityObject):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::contentChanged):

LayoutTests: Regression(r112694): Crash in WebCore::AXObjectCache::postNotification
https://bugs.webkit.org/show_bug.cgi?id=86029

Reviewed by Abhishek Arya.

* accessibility/content-changed-notification-causes-crash-expected.txt: Added.
* accessibility/content-changed-notification-causes-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r116188): After exiting full screen, Safari window is frozen, then inline...
jer.noble@apple.com [Wed, 23 May 2012 18:31:23 +0000 (18:31 +0000)]
REGRESSION (r116188): After exiting full screen, Safari window is frozen, then inline video speeds through frames as it catches up with audio
https://bugs.webkit.org/show_bug.cgi?id=87206

Reviewed by Darin Adler.

When re-enabling the Safari window's autodisplay flag, also force the window to re-display.
Otherwise, the window will not repaint itself until it is forced to by user interaction.

* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController completeFinishExitFullScreenAnimationAfterRepaint]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEncapsulated some calculations for whether portions of the heap are empty
ggaren@apple.com [Wed, 23 May 2012 18:29:55 +0000 (18:29 +0000)]
Encapsulated some calculations for whether portions of the heap are empty
https://bugs.webkit.org/show_bug.cgi?id=87210

Reviewed by Gavin Barraclough.

This is a step toward incremental DOM finalization.

* heap/Heap.cpp:
(JSC::Heap::~Heap): Explicitly call freeAllBlocks() instead of relying
implicitly on all blocks thinking they're empty. In future, we may
choose to tear down the heap without first setting all data structures
to "empty".

* heap/MarkedBlock.h:
(JSC::MarkedBlock::isEmpty):
(JSC::MarkedBlock::gatherDirtyCells): Renamed markCountIsZero to isEmpty,
in preparation for making it check for outstanding finalizers in addition
to marked cells.

* heap/MarkedSpace.cpp:
(Take):
(JSC::Take::Take):
(JSC::Take::operator()):
(JSC::Take::returnValue):
(JSC::MarkedSpace::shrink):
(JSC::MarkedSpace::freeAllBlocks): Refactored the "Take" functor to support
a conditional isEmpty check, so it dould be shared by shrink() and freeAllBlocks().

* heap/WeakBlock.cpp:
(JSC::WeakBlock::WeakBlock):
(JSC::WeakBlock::visitLiveWeakImpls):
(JSC::WeakBlock::visitDeadWeakImpls):
* heap/WeakBlock.h:
(WeakBlock):
(JSC::WeakBlock::isEmpty):
* heap/WeakSet.cpp:
(JSC::WeakSet::sweep):
(JSC::WeakSet::shrink): Use isEmpty(), in preparation for changes in
its implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[wx] Fix memory leak in FontHolder.
kevino@webkit.org [Wed, 23 May 2012 18:24:39 +0000 (18:24 +0000)]
[wx] Fix memory leak in FontHolder.
https://bugs.webkit.org/show_bug.cgi?id=87281

Reviewed by Kevin Ollivier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening - one more media/track test is crashy.
jsbell@chromium.org [Wed, 23 May 2012 18:23:29 +0000 (18:23 +0000)]
Unreviewed gardening - one more media/track test is crashy.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[wx] Make sure we do not create a substitute font if the facename is not found.
kevino@webkit.org [Wed, 23 May 2012 18:22:04 +0000 (18:22 +0000)]
[wx] Make sure we do not create a substitute font if the facename is not found.
https://bugs.webkit.org/show_bug.cgi?id=87280

Reviewed by Kevin Ollivier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[wx] Implement transparency layer support.
kevino@webkit.org [Wed, 23 May 2012 18:17:43 +0000 (18:17 +0000)]
[wx] Implement transparency layer support.
https://bugs.webkit.org/show_bug.cgi?id=87279

Reviewed by Kevin Ollivier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGenericClock loses precision due to float->double conversion.
jer.noble@apple.com [Wed, 23 May 2012 18:11:55 +0000 (18:11 +0000)]
GenericClock loses precision due to float->double conversion.
https://bugs.webkit.org/show_bug.cgi?id=87227

Reviewed by Darin Adler.

No new tests; fixes media/media-controller-time.html on Chromium.

Only narrow to float after the entire calculation is complete. This requires now() and m_offset
to be double-precision.

* platform/ClockGeneric.cpp:
(ClockGeneric::currentTime):
(ClockGeneric::now): Make double-precision.
* platform/ClockGeneric.h:
(ClockGeneric): Make m_offset double-precision.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPlatformClockCM has uninitialized m_rate member.
jer.noble@apple.com [Wed, 23 May 2012 18:11:48 +0000 (18:11 +0000)]
PlatformClockCM has uninitialized m_rate member.
https://bugs.webkit.org/show_bug.cgi?id=87217

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-controller-time.html

Initialize the m_rate member to a default of 1 (second-per-second), matching the implementation
of ClockGeneric.

* platform/mac/PlatformClockCM.mm:
(PlatformClockCM::PlatformClockCM):

LayoutTests:

* media/media-controller-time-expected.txt: Added.
* media/media-controller-time.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r118096.
commit-queue@webkit.org [Wed, 23 May 2012 18:02:50 +0000 (18:02 +0000)]
Unreviewed, rolling out r118096.
http://trac.webkit.org/changeset/118096
https://bugs.webkit.org/show_bug.cgi?id=87285

caused multiple crashes on the mac bots (Requested by
jessieberlin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-23

* dom/ContainerNodeAlgorithms.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix.
antti@apple.com [Wed, 23 May 2012 18:00:24 +0000 (18:00 +0000)]
Build fix.

Not reviewed.

* src/WebDocument.cpp:
(WebKit::WebDocument::insertUserStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Reset JS state for each test
commit-queue@webkit.org [Wed, 23 May 2012 17:46:30 +0000 (17:46 +0000)]
[BlackBerry] Reset JS state for each test
https://bugs.webkit.org/show_bug.cgi?id=86899

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-05-23
Reviewed by Nikolas Zimmermann.

* DumpRenderTree/blackberry/DumpRenderTree.cpp:
 (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/sub-pixel/layout-boxes-with-zoom.html fails at 166% zoom on Windows only
leviw@chromium.org [Wed, 23 May 2012 17:41:58 +0000 (17:41 +0000)]
fast/sub-pixel/layout-boxes-with-zoom.html fails at 166% zoom on Windows only
https://bugs.webkit.org/show_bug.cgi?id=87282

Unreviewed. Marking fast/sub-pixel/layout-boxes-with-zoom.html as failing on Chromium Windows.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSpeed up traverseNextNode when called on a ContainerNode or Element
darin@apple.com [Wed, 23 May 2012 17:33:06 +0000 (17:33 +0000)]
Speed up traverseNextNode when called on a ContainerNode or Element
https://bugs.webkit.org/show_bug.cgi?id=87224

Reviewed by Geoffrey Garen.

* dom/ContainerNode.h: Added overrides of traverseNextNode for ContainerNode.
That way, when we know at compile time something is ContainerNode, we can
skip a branch at the start of this hot function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[wx] In wxWebKit release builds on MSW, keep release settings but also build the
kevino@webkit.org [Wed, 23 May 2012 17:32:29 +0000 (17:32 +0000)]
[wx] In wxWebKit release builds on MSW, keep release settings but also build the
debug symbols for easier debugging.
https://bugs.webkit.org/show_bug.cgi?id=87151

Reviewed by Kevin Ollivier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse PluginDataNone.cpp always when NETSCAPE_PLUGIN_API is OFF
commit-queue@webkit.org [Wed, 23 May 2012 17:31:26 +0000 (17:31 +0000)]
Use PluginDataNone.cpp always when NETSCAPE_PLUGIN_API is OFF
https://bugs.webkit.org/show_bug.cgi?id=87096

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-23
Reviewed by Andy Estes.

Fix a build error by adding an extra check in PluginData.cpp to use
PluginStrategy only when NETSCAPE_PLUGIN_API is ON.

No new tests. This is only a build fix.

* plugins/PluginData.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[wx] Fix scrollbar drawing under wxGTK.
kevino@webkit.org [Wed, 23 May 2012 17:29:46 +0000 (17:29 +0000)]
[wx] Fix scrollbar drawing under wxGTK.
https://bugs.webkit.org/show_bug.cgi?id=87150

Reviewed by Kevin Ollivier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening - inspector/profiler/heap-snapshot-summary-show-ranges.html
jsbell@chromium.org [Wed, 23 May 2012 17:21:59 +0000 (17:21 +0000)]
Unreviewed gardening - inspector/profiler/heap-snapshot-summary-show-ranges.html
flakes on non-debug test runs too.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename StyleSheetInternal to StyleSheetContents
antti@apple.com [Wed, 23 May 2012 17:17:43 +0000 (17:17 +0000)]
Rename StyleSheetInternal to StyleSheetContents
https://bugs.webkit.org/show_bug.cgi?id=87272

Reviewed by Andreas Kling.

The name is more descriptive and the code reads better.

Plain "StyleSheet" would be good too but that is a CSSOM type and the name can't be used without
changing idl code generation and resolving bunch of other issues.

* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::addSubresourceStyleURLs):
* css/CSSFontFaceSrcValue.h:
(CSSFontFaceSrcValue):
* css/CSSImportRule.cpp:
(WebCore::StyleRuleImport::setCSSStyleSheet):
(WebCore::StyleRuleImport::requestStyleSheet):
* css/CSSImportRule.h:
(WebCore):
(WebCore::StyleRuleImport::parentStyleSheet):
(WebCore::StyleRuleImport::setParentStyleSheet):
(WebCore::StyleRuleImport::styleSheet):
(StyleRuleImport):
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::insertRule):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseSheet):
(WebCore::CSSParser::parseRule):
(WebCore::CSSParser::parseKeyframeRule):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseSelector):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::setStyleSheet):
(WebCore::CSSParser::parseFlowThread):
* css/CSSParser.h:
(WebCore):
(CSSParser):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::addSubresourceStyleURLs):
* css/CSSPrimitiveValue.h:
(CSSPrimitiveValue):
* css/CSSReflectValue.cpp:
(WebCore::CSSReflectValue::addSubresourceStyleURLs):
* css/CSSReflectValue.h:
(CSSReflectValue):
* css/CSSRule.cpp:
(WebCore::CSSRule::parserContext):
* css/CSSStyleSheet.cpp:
(WebCore::StyleSheetContents::estimatedSizeInBytes):
(WebCore::StyleSheetContents::StyleSheetContents):
(WebCore::StyleSheetContents::~StyleSheetContents):
(WebCore::StyleSheetContents::isCacheable):
(WebCore::StyleSheetContents::parserAppendRule):
(WebCore::StyleSheetContents::ruleAt):
(WebCore::StyleSheetContents::ruleCount):
(WebCore::StyleSheetContents::clearCharsetRule):
(WebCore::StyleSheetContents::clearRules):
(WebCore::StyleSheetContents::parserSetEncodingFromCharsetRule):
(WebCore::StyleSheetContents::wrapperInsertRule):
(WebCore::StyleSheetContents::wrapperDeleteRule):
(WebCore::StyleSheetContents::parserAddNamespace):
(WebCore::StyleSheetContents::determineNamespace):
(WebCore::StyleSheetContents::parseAuthorStyleSheet):
(WebCore::StyleSheetContents::parseString):
(WebCore::StyleSheetContents::parseStringAtLine):
(WebCore::StyleSheetContents::isLoading):
(WebCore::StyleSheetContents::checkLoaded):
(WebCore::StyleSheetContents::notifyLoadedSheet):
(WebCore::StyleSheetContents::startLoadingDynamicSheet):
(WebCore::StyleSheetContents::rootStyleSheet):
(WebCore::StyleSheetContents::singleOwnerNode):
(WebCore::StyleSheetContents::singleOwnerDocument):
(WebCore::StyleSheetContents::completeURL):
(WebCore::StyleSheetContents::addSubresourceStyleURLs):
(WebCore::StyleSheetContents::parentStyleSheet):
(WebCore::StyleSheetContents::registerClient):
(WebCore::StyleSheetContents::unregisterClient):
(WebCore::StyleSheetContents::addedToMemoryCache):
(WebCore::StyleSheetContents::removedFromMemoryCache):
(WebCore::CSSStyleSheet::createInline):
(WebCore::CSSStyleSheet::CSSStyleSheet):
(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::willMutateRules):
(WebCore::CSSStyleSheet::didMutateRules):
(WebCore::CSSStyleSheet::reattachChildRuleCSSOMWrappers):
(WebCore::CSSStyleSheet::length):
(WebCore::CSSStyleSheet::item):
(WebCore::CSSStyleSheet::rules):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::deleteRule):
(WebCore::CSSStyleSheet::cssRules):
* css/CSSStyleSheet.h:
(WebCore::StyleSheetContents::create):
(StyleSheetContents):
(WebCore::StyleSheetContents::copy):
(WebCore::CSSStyleSheet::create):
(WebCore::CSSStyleSheet::contents):
(CSSStyleSheet):
* css/CSSValue.cpp:
(WebCore::CSSValue::addSubresourceStyleURLs):
* css/CSSValue.h:
(WebCore):
(CSSValue):
* css/CSSValueList.cpp:
(WebCore::CSSValueList::addSubresourceStyleURLs):
* css/CSSValueList.h:
(CSSValueList):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::contextStyleSheet):
* css/PropertySetCSSStyleDeclaration.h:
(WebCore):
(PropertySetCSSStyleDeclaration):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addSubresourceStyleURLs):
* css/StylePropertySet.h:
(WebCore):
(StylePropertySet):
* css/StyleResolver.cpp:
(RuleSet):
(WebCore):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addAuthorRulesAndCollectUserRulesFromSheets):
(WebCore::StyleResolver::appendAuthorStylesheets):
(WebCore::parseUASheet):
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/StyleResolver.h:
(StyleResolver):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::insertRule):
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createCSSStyleSheet):
* dom/Document.cpp:
(WebCore::Document::recalcStyle):
(WebCore::Document::updateBaseURL):
(WebCore::Document::pageUserSheet):
(WebCore::Document::pageGroupUserSheets):
(WebCore::Document::addUserSheet):
(WebCore::Document::testAddedStylesheetRequiresStyleRecalc):
(WebCore::Document::analyzeStylesheetChange):
(WebCore::styleSheetsUseRemUnits):
* dom/Document.h:
(WebCore):
(Document):
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::updateInlineStyleAvoidingMutation):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::setCSSStyleSheet):
(WebCore::ProcessingInstruction::parseStyleSheet):
* dom/StyleElement.cpp:
(WebCore::StyleElement::createSheet):
* dom/StyledElement.cpp:
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::addSubresourceAttributeURLs):
(WebCore::StyledElement::addPropertyToAttributeStyle):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setCSSStyleSheet):
(WebCore::HTMLLinkElement::styleSheetIsLoading):
(WebCore::HTMLLinkElement::addSubresourceAttributeURLs):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::addSubresourceAttributeURLs):
* inspector/InspectorStyleSheet.cpp:
(WebCore::fillMediaListChain):
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyleSheet::styleSheetURL):
(WebCore::InspectorStyleSheet::reparseStyleSheet):
(WebCore::InspectorStyleSheet::ensureSourceData):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::restoreParsedStyleSheet):
(WebCore::CachedCSSStyleSheet::saveParsedStyleSheet):
* loader/cache/CachedCSSStyleSheet.h:
(WebCore):
(CachedCSSStyleSheet):
* page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeCSSStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening - add timeout and crash expectations for a few tests.
jsbell@chromium.org [Wed, 23 May 2012 17:16:30 +0000 (17:16 +0000)]
Unreviewed gardening - add timeout and crash expectations for a few tests.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse ContainerNode instead of Node where possible
darin@apple.com [Wed, 23 May 2012 16:56:33 +0000 (16:56 +0000)]
Use ContainerNode instead of Node where possible
https://bugs.webkit.org/show_bug.cgi?id=87220

Reviewed by Geoffrey Garen.

It's better to use a more specific type; in some cases we even generate
more efficient code if we have a more specific type. Also, we want any
type casts to be as close as possible to the corresponding type checks,
so eliminating these uses of toContainerNode is a plus, also.

* dom/ContainerNodeAlgorithms.h: Changed insertionPoint to be a ContainerNode
instead of a Node. Fixed spelling error "inseretions". Changed
(WebCore::ChildFrameDisconnector::Target::Target): Changed type of frame owner
element to HTMLFrameOwnerElement from Node.

* dom/DocumentType.cpp:
(WebCore::DocumentType::insertedInto):
(WebCore::DocumentType::removedFrom):
* dom/DocumentType.h:
* dom/Element.cpp:
(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
* dom/Element.h:
* dom/Node.cpp:
(WebCore::Node::insertedInto):
(WebCore::Node::removedFrom):
* dom/Node.h:
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::insertedInto):
(WebCore::ProcessingInstruction::removedFrom):
* dom/ProcessingInstruction.h:
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::insertedInto):
* dom/ScriptElement.h:
* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::insertedInto):
(WebCore::FormAssociatedElement::removedFrom):
* html/FormAssociatedElement.h:
* html/HTMLBaseElement.cpp:
(WebCore::HTMLBaseElement::insertedInto):
(WebCore::HTMLBaseElement::removedFrom):
* html/HTMLBaseElement.h:
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::insertedInto):
(WebCore::HTMLBodyElement::didNotifyDescendantInsertions):
* html/HTMLBodyElement.h:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::insertedInto):
(WebCore::HTMLFormControlElement::removedFrom):
* html/HTMLFormControlElement.h:
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::insertedInto):
(WebCore::HTMLFormElement::didNotifyDescendantInsertions):
(WebCore::HTMLFormElement::removedFrom):
* html/HTMLFormElement.h:
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::insertedInto):
(WebCore::HTMLFrameElementBase::didNotifyDescendantInsertions):
* html/HTMLFrameElementBase.h:
* html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::insertedInto):
(WebCore::HTMLFrameSetElement::removedFrom):
* html/HTMLFrameSetElement.h:
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::insertedInto):
(WebCore::HTMLIFrameElement::removedFrom):
* html/HTMLIFrameElement.h:
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::insertedInto):
(WebCore::HTMLImageElement::removedFrom):
* html/HTMLImageElement.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::insertedInto):
(WebCore::HTMLInputElement::removedFrom):
* html/HTMLInputElement.h:
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::insertedInto):
(WebCore::HTMLLinkElement::removedFrom):
* html/HTMLLinkElement.h:
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::insertedInto):
(WebCore::HTMLMapElement::removedFrom):
* html/HTMLMapElement.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::insertedInto):
(WebCore::HTMLMediaElement::removedFrom):
* html/HTMLMediaElement.h:
* html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::insertedInto):
* html/HTMLMetaElement.h:
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::insertedInto):
(WebCore::HTMLObjectElement::removedFrom):
* html/HTMLObjectElement.h:
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::insertedInto):
* html/HTMLOptionElement.h:
* html/HTMLQuoteElement.cpp:
(WebCore::HTMLQuoteElement::insertedInto):
* html/HTMLQuoteElement.h:
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::insertedInto):
* html/HTMLScriptElement.h:
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::insertedInto):
* html/HTMLSelectElement.h:
* html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::insertedInto):
(WebCore::HTMLSourceElement::removedFrom):
* html/HTMLSourceElement.h:
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::insertedInto):
(WebCore::HTMLStyleElement::removedFrom):
* html/HTMLStyleElement.h:
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::insertedInto):
* html/HTMLTextFormControlElement.h:
* html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::insertedInto):
(WebCore::HTMLTitleElement::removedFrom):
* html/HTMLTitleElement.h:
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedInto):
(WebCore::HTMLTrackElement::removedFrom):
* html/HTMLTrackElement.h:
* mathml/MathMLMathElement.cpp:
(WebCore::MathMLMathElement::insertedInto):
* mathml/MathMLMathElement.h:
* svg/SVGElement.cpp:
(WebCore::SVGElement::removedFrom):
* svg/SVGElement.h:
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::insertedInto):
(WebCore::SVGFEImageElement::removedFrom):
* svg/SVGFEImageElement.h:
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::insertedInto):
(WebCore::SVGFontFaceElement::removedFrom):
* svg/SVGFontFaceElement.h:
* svg/SVGFontFaceUriElement.cpp:
(WebCore::SVGFontFaceUriElement::insertedInto):
* svg/SVGFontFaceUriElement.h:
* svg/SVGGlyphElement.cpp:
(WebCore::SVGGlyphElement::insertedInto):
(WebCore::SVGGlyphElement::removedFrom):
* svg/SVGGlyphElement.h:
* svg/SVGHKernElement.cpp:
(WebCore::SVGHKernElement::insertedInto):
(WebCore::SVGHKernElement::removedFrom):
* svg/SVGHKernElement.h:
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::insertedInto):
* svg/SVGImageElement.h:
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::insertedInto):
(WebCore::SVGSVGElement::removedFrom):
* svg/SVGSVGElement.h:
* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::insertedInto):
* svg/SVGScriptElement.h:
* svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::insertedInto):
(WebCore::SVGStyleElement::removedFrom):
* svg/SVGStyleElement.h:
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::insertedInto):
(WebCore::SVGStyledElement::removedFrom):
* svg/SVGStyledElement.h:
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::insertedInto):
(WebCore::SVGTRefElement::removedFrom):
* svg/SVGTRefElement.h:
* svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::insertedInto):
* svg/SVGTextPathElement.h:
* svg/SVGTitleElement.cpp:
(WebCore::SVGTitleElement::insertedInto):
(WebCore::SVGTitleElement::removedFrom):
* svg/SVGTitleElement.h:
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::insertedInto):
(WebCore::SVGUseElement::removedFrom):
* svg/SVGUseElement.h:
* svg/SVGVKernElement.cpp:
(WebCore::SVGVKernElement::insertedInto):
(WebCore::SVGVKernElement::removedFrom):
* svg/SVGVKernElement.h:
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::insertedInto):
(WebCore::SVGSMILElement::removedFrom):
* svg/animation/SVGSMILElement.h:
Changed arguments of insertedInto and removedFrom to ContainerNode instead of Node.
Did the same with didNotifyDescendantInsertions, while fixing the typo in its name.

* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply): Put a typecast toHTMLElement here.
The check for isListElement and isLegacyAppleStyleSpan takes care of the type checking.
(WebCore::ReplaceSelectionCommand::insertAsListItems): Changed this function to take
an HTMLElement instead of a Node, then we can drop use of the toContainerNode function.
* editing/ReplaceSelectionCommand.h:

* editing/TextIterator.cpp: Fixed a typo in a comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOptimize iteration of empty hash tables
darin@apple.com [Wed, 23 May 2012 16:32:56 +0000 (16:32 +0000)]
Optimize iteration of empty hash tables
https://bugs.webkit.org/show_bug.cgi?id=87215

Reviewed by Geoffrey Garen.

Iteration of empty hash tables was showing up on simple page loading
profiles due to the use of hash tables in the
NodeListsNodeData::invalidateCaches and
NodeListsNodeData::invalidateCachesThatDependOnAttributes functions.
It's worth optimizing the case of an empty table.

* wtf/HashTable.h:
(WTF::HashTable::begin): Return the known-good end iterator when the
table is empty. This makes iterating an empty table faster because we
avoid skipping empty and deleted buckets.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd crashing expectation for more media/track tests:
jsbell@chromium.org [Wed, 23 May 2012 16:30:00 +0000 (16:30 +0000)]
Add crashing expectation for more media/track tests:
track-language-preference.html, track-load-from-element-readyState.html, and
track-webvtt-tc019-cue-size.html - tracked in http://webkit.org/b/87258

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnskip sub-pixel tests on chromium now that they flag has been turned on (in r 117815).
eae@chromium.org [Wed, 23 May 2012 16:20:51 +0000 (16:20 +0000)]
Unskip sub-pixel tests on chromium now that they flag has been turned on (in r 117815).

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd test for subpixel precision in DOM APIs
eae@chromium.org [Wed, 23 May 2012 16:17:19 +0000 (16:17 +0000)]
Add test for subpixel precision in DOM APIs
https://bugs.webkit.org/show_bug.cgi?id=85534

Reviewed by Eric Seidel.

Add test for increased precision due to subpixel support in the
getBoundingClientRect api. Also test that clientWidth returns the pixel
snapped value.

* fast/sub-pixel/client-rect-has-subpixel-precision-expected.html: Added.
* fast/sub-pixel/client-rect-has-subpixel-precision.html: Added.
* platform/efl/Skipped:
* platform/gtk-wk2/Skipped:
* platform/mac-lion/Skipped:
* platform/mac-snowleopard/Skipped:
* platform/mac-wk2/Skipped:
* platform/mac/Skipped:
* platform/qt-4.8/Skipped:
* platform/qt/Skipped:
* platform/win-wk2/Skipped:
* platform/win-xp/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:
Mark as skipped on all platforms but chromium for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] [WebKit2] Add an API to enable and disable composited layer indicators
commit-queue@webkit.org [Wed, 23 May 2012 16:07:06 +0000 (16:07 +0000)]
[GTK] [WebKit2] Add an API to enable and disable composited layer indicators
https://bugs.webkit.org/show_bug.cgi?id=87053

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-05-23
Reviewed by Carlos Garcia Campos.

Add a WebKitSetting that allows the client to enable and disable debug
borders and repaint counters for accelerated content.

* UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsSetProperty): Added.
(webKitSettingsGetProperty): Added.
(webkit_settings_class_init): Add the new property.
(webkit_settings_set_draw_compositing_indicators): Added.
(webkit_settings_get_draw_compositing_indicators): Added.
* UIProcess/API/gtk/WebKitSettings.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add the new API points to the
documentation.
* UIProcess/API/gtk/test/TestWebKitSettings.h: Add a new unit test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: filter out debugging stuff from the heap class view
commit-queue@webkit.org [Wed, 23 May 2012 16:02:22 +0000 (16:02 +0000)]
Web Inspector: filter out debugging stuff from the heap class view
https://bugs.webkit.org/show_bug.cgi?id=86723

Source/WebCore:

We mark objects that are accessible from user roots (e.g. Window)
with pageObject attribute. This fix filters out all non-pageObjects
from the classes view.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-05-23
Reviewed by Yury Semikhatsky.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.isPageObject):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._calculateClassesRetainedSize):
(WebInspector.HeapSnapshot.prototype._buildPostOrderIndex):
(WebInspector.HeapSnapshot.prototype._markPageOwnedNodes):
(WebInspector.HeapSnapshot.prototype.createNodesProviderForClass):

LayoutTests:

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-05-23
Reviewed by Yury Semikhatsky.

* inspector/profiler/heap-snapshot-comparison-dom-groups-change.html:
* inspector/profiler/heap-snapshot-comparison-show-all.html:
* inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting.html:
* inspector/profiler/heap-snapshot-containment-show-all.html:
* inspector/profiler/heap-snapshot-containment-show-next.html:
* inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting.html:
* inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting.html:
* inspector/profiler/heap-snapshot-dominators-show-all.html:
* inspector/profiler/heap-snapshot-dominators-show-next.html:
* inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting.html:
* inspector/profiler/heap-snapshot-dominators-sorting.html:
* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockObject):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockRaw):
(initialize_HeapSnapshotTest):
(initialize_HeapSnapshotTest.):
* inspector/profiler/heap-snapshot.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Move myself to reviewers.
carlosgc@webkit.org [Wed, 23 May 2012 15:50:37 +0000 (15:50 +0000)]
Unreviewed. Move myself to reviewers.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Today's ingredients for a green bot
commit-queue@webkit.org [Wed, 23 May 2012 15:32:47 +0000 (15:32 +0000)]
[EFL][DRT] Today's ingredients for a green bot
https://bugs.webkit.org/show_bug.cgi?id=87244

Unreviewed, EFL gardening.

Some rebaselines, and moving out a set of new crashes that
need more investigation.

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-23

* platform/efl/fast/css-generated-content/inline-display-types-expected.png:
* platform/efl/fast/css-generated-content/inline-display-types-expected.txt:
* platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png:
* platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
* platform/efl/fast/inline-block/001-expected.png:
* platform/efl/fast/inline-block/001-expected.txt:
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd crashing expectation for media/video-src-invalid-remove.html
steveblock@google.com [Wed, 23 May 2012 14:29:41 +0000 (14:29 +0000)]
Add crashing expectation for media/video-src-invalid-remove.html

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSSRegions]Implement NamedFlow::name attribute
commit-queue@webkit.org [Wed, 23 May 2012 14:26:29 +0000 (14:26 +0000)]
[CSSRegions]Implement NamedFlow::name attribute
https://bugs.webkit.org/show_bug.cgi?id=79645

Source/WebCore:

Implementation for the NamedFlow::name attribute per the CSS Regions WD 3-May-2012 recommendation:
http://www.w3.org/TR/2012/WD-css3-regions-20120503/

Patch by Andrei Bucur <abucur@adobe.com> on 2012-05-23
Reviewed by Andreas Kling.

Test: fast/regions/webkit-named-flow-name.html

* dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::name):
(WebCore):
* dom/WebKitNamedFlow.h:
(WebKitNamedFlow):
* dom/WebKitNamedFlow.idl:

LayoutTests:

Test for the NamedFlow::name attribute per the CSS Regions WD 3-May-2012 recommendation:
http://www.w3.org/TR/2012/WD-css3-regions-20120503/

Patch by Andrei Bucur <abucur@adobe.com> on 2012-05-23
Reviewed by Andreas Kling.

* fast/regions/webkit-named-flow-name-expected.txt: Added.
* fast/regions/webkit-named-flow-name.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLet the compiler generate FontFamily's copy ctor and assignment operator.
kling@webkit.org [Wed, 23 May 2012 14:16:20 +0000 (14:16 +0000)]
Let the compiler generate FontFamily's copy ctor and assignment operator.

Blindly rubberstamped by the brave Antti Koivisto.

* platform/graphics/FontFamily.cpp:
* platform/graphics/FontFamily.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSSParser: Simplify StylePropertySet creation.
kling@webkit.org [Wed, 23 May 2012 14:08:41 +0000 (14:08 +0000)]
CSSParser: Simplify StylePropertySet creation.
<http://webkit.org/b/87259>

Reviewed by Alexis Menard.

Turn CSSParser's filteredProperties() into createStylePropertySet() which filters the parsed
properties and creates a new StylePropertySet, adopting the vector to avoid the Vector copy we
were previously incurring.

Added a StylePropertyVector typedef for Vector<CSSProperty, 4> since we need to pass this type
to the constructor for Vector::swap() to work.

And thus StylePropertySet::create(const Vector<CSSProperty>&, CSSParserMode) became
StylePropertySet::adopt(StylePropertyVector&, CSSParserMode).

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):
* css/CSSParser.cpp:
(WebCore::CSSParser::createStylePropertySet):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframe):
* css/CSSParser.h:
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::copyPropertiesInSet):
(SameSizeAsStylePropertySet):
* css/StylePropertySet.h:
(WebCore::StylePropertySet::adopt):
(StylePropertySet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoKill some frivolous null-checking of Element::m_attributeData.
kling@webkit.org [Wed, 23 May 2012 14:05:02 +0000 (14:05 +0000)]
Kill some frivolous null-checking of Element::m_attributeData.
<http://webkit.org/b/87248>

Reviewed by Antti Koivisto.

Replace unnecessary Element::m_attributeData with assertions where it makes sense.
Others are flat out removed because it should be obvious from context that it's non-null.
E.g if an attribute has changed, we're obviously storing it somewhere.

Also added a short-circuit to Element::normalize() if there are no Attr objects
associated with the element.

* dom/Element.cpp:
(WebCore::Element::~Element):
(WebCore::Element::attributeChanged):
(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::normalizeAttributes):
* dom/StyledElement.cpp:
(WebCore::StyledElement::classAttributeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLet Element::detachAttribute() handle removal of the attribute.
kling@webkit.org [Wed, 23 May 2012 13:54:54 +0000 (13:54 +0000)]
Let Element::detachAttribute() handle removal of the attribute.
<http://webkit.org/b/87242>

Reviewed by Antti Koivisto.

All the call sites were removing the attribute after detaching it, so move
that into detachAttribute(). The function name already made it sound like it
removes the attribute anyway.

Also sprinkle some assertions wrt being called with guaranteed presence of
attributeData() and the provided index in the attribute vector.

* dom/Element.cpp:
(WebCore::Element::detachAttribute):
(WebCore::Element::removeAttributeNode):
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::removeNamedItemNS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStreamline Element teardown for the no-Attr-objects case.
kling@webkit.org [Wed, 23 May 2012 13:50:06 +0000 (13:50 +0000)]
Streamline Element teardown for the no-Attr-objects case.
<http://webkit.org/b/87228>

Reviewed by Antti Koivisto.

Dodge one function call in ~Element() if the element has no Attr objects
associated (the typical case.)

Renamed detachAttributes to detachAttrObjectsFromElement to reduce ambiguity.

* dom/Element.cpp:
(WebCore::Element::~Element):
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::detachAttrObjectsFromElement):
(WebCore::ElementAttributeData::clearAttributes):
* dom/ElementAttributeData.h:
(ElementAttributeData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r118157.
g.czajkowski@samsung.com [Wed, 23 May 2012 13:48:58 +0000 (13:48 +0000)]
Unreviewed, rolling out r118157.
http://trac.webkit.org/changeset/118157
https://bugs.webkit.org/show_bug.cgi?id=87100

Newly added tests are not connected to 8483 bug.
editing/style directory should be unskiped first.

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Rebaseline test results for BUG 86355
commit-queue@webkit.org [Wed, 23 May 2012 13:39:18 +0000 (13:39 +0000)]
[EFL][DRT] Rebaseline test results for BUG 86355
https://bugs.webkit.org/show_bug.cgi?id=86956

Unreviewed, EFL gardening.

Updated test results for BUG 86355.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-05-23

* platform/efl/compositing/animation/state-at-end-event-transform-layer-expected.png:
* platform/efl/compositing/animation/state-at-end-event-transform-layer-expected.txt:
* platform/efl/compositing/bounds-in-flipped-writing-mode-expected.txt: Added.
* platform/efl/compositing/color-matching/image-color-matching-expected.png:
* platform/efl/compositing/color-matching/image-color-matching-expected.txt:
* platform/efl/compositing/color-matching/pdf-image-match-expected.png:
* platform/efl/compositing/color-matching/pdf-image-match-expected.txt:
* platform/efl/compositing/compositing-visible-descendant-expected.png:
* platform/efl/compositing/compositing-visible-descendant-expected.txt:
* platform/efl/compositing/direct-image-compositing-expected.png:
* platform/efl/compositing/direct-image-compositing-expected.txt:
* platform/efl/compositing/generated-content-expected.png:
* platform/efl/compositing/generated-content-expected.txt:
* platform/efl/compositing/geometry/abs-position-inside-opacity-expected.png:
* platform/efl/compositing/geometry/abs-position-inside-opacity-expected.txt:
* platform/efl/compositing/geometry/clipping-foreground-expected.png:
* platform/efl/compositing/geometry/clipping-foreground-expected.txt:
* platform/efl/compositing/geometry/composited-html-size-expected.png:
* platform/efl/compositing/geometry/composited-html-size-expected.txt:
* platform/efl/compositing/geometry/fixed-in-composited-expected.png:
* platform/efl/compositing/geometry/fixed-in-composited-expected.txt:
* platform/efl/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
* platform/efl/compositing/geometry/layer-due-to-layer-children-deep-expected.txt:
* platform/efl/compositing/geometry/layer-due-to-layer-children-expected.png:
* platform/efl/compositing/geometry/layer-due-to-layer-children-expected.txt:
* platform/efl/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt:
* platform/efl/compositing/geometry/outline-change-expected.png:
* platform/efl/compositing/geometry/outline-change-expected.txt:
* platform/efl/compositing/geometry/partial-layout-update-expected.png:
* platform/efl/compositing/geometry/partial-layout-update-expected.txt:
* platform/efl/compositing/geometry/root-layer-update-expected.png:
* platform/efl/compositing/geometry/root-layer-update-expected.txt:
* platform/efl/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png:
* platform/efl/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt:
* platform/efl/compositing/geometry/video-fixed-scrolling-expected.png:
* platform/efl/compositing/geometry/video-fixed-scrolling-expected.txt:
* platform/efl/compositing/geometry/video-opacity-overlay-expected.png:
* platform/efl/compositing/geometry/video-opacity-overlay-expected.txt:
* platform/efl/compositing/iframes/composited-iframe-alignment-expected.png:
* platform/efl/compositing/iframes/composited-iframe-alignment-expected.txt:
* platform/efl/compositing/iframes/composited-iframe-scroll-expected.txt: Added.
* platform/efl/compositing/iframes/iframe-content-flipping-expected.txt: Added.
* platform/efl/compositing/iframes/iframe-copy-on-scroll-expected.png:
* platform/efl/compositing/iframes/iframe-copy-on-scroll-expected.txt:
* platform/efl/compositing/iframes/leave-compositing-iframe-expected.txt: Added.
* platform/efl/compositing/images/direct-image-background-color-expected.png:
* platform/efl/compositing/images/direct-image-background-color-expected.txt:
* platform/efl/compositing/layers-inside-overflow-scroll-expected.png:
* platform/efl/compositing/layers-inside-overflow-scroll-expected.txt:
* platform/efl/compositing/masks/direct-image-mask-expected.png:
* platform/efl/compositing/masks/direct-image-mask-expected.txt:
* platform/efl/compositing/masks/masked-ancestor-expected.png:
* platform/efl/compositing/masks/masked-ancestor-expected.txt:
* platform/efl/compositing/masks/multiple-masks-expected.png:
* platform/efl/compositing/masks/multiple-masks-expected.txt:
* platform/efl/compositing/masks/simple-composited-mask-expected.png:
* platform/efl/compositing/masks/simple-composited-mask-expected.txt:
* platform/efl/compositing/overflow/ancestor-overflow-expected.png:
* platform/efl/compositing/overflow/ancestor-overflow-expected.txt:
* platform/efl/compositing/overflow/fixed-position-ancestor-clip-expected.png:
* platform/efl/compositing/overflow/fixed-position-ancestor-clip-expected.txt:
* platform/efl/compositing/overflow/overflow-compositing-descendant-expected.png:
* platform/efl/compositing/overflow/overflow-compositing-descendant-expected.txt:
* platform/efl/compositing/overflow/overflow-positioning-expected.png:
* platform/efl/compositing/overflow/overflow-positioning-expected.txt:
* platform/efl/compositing/overflow/overflow-scroll-expected.png:
* platform/efl/compositing/overflow/overflow-scroll-expected.txt:
* platform/efl/compositing/overflow/parent-overflow-expected.png:
* platform/efl/compositing/overflow/parent-overflow-expected.txt:
* platform/efl/compositing/overflow/scroll-ancestor-update-expected.png:
* platform/efl/compositing/overflow/scroll-ancestor-update-expected.txt:
* platform/efl/compositing/overflow/scrollbar-painting-expected.png:
* platform/efl/compositing/overflow/scrollbar-painting-expected.txt:
* platform/efl/compositing/overflow/theme-affects-visual-overflow-expected.png: Added.
* platform/efl/compositing/overflow/theme-affects-visual-overflow-expected.txt: Added.
* platform/efl/compositing/plugins/1x1-composited-plugin-expected.txt: Added.
* platform/efl/compositing/plugins/composited-plugin-expected.png:
* platform/efl/compositing/plugins/composited-plugin-expected.txt:
* platform/efl/compositing/plugins/large-to-small-composited-plugin-expected.txt: Added.
* platform/efl/compositing/reflections/animation-inside-reflection-expected.png:
* platform/efl/compositing/reflections/animation-inside-reflection-expected.txt:
* platform/efl/compositing/reflections/compositing-change-inside-reflection-expected.png:
* platform/efl/compositing/reflections/compositing-change-inside-reflection-expected.txt:
* platform/efl/compositing/reflections/deeply-nested-reflections-expected.png:
* platform/efl/compositing/reflections/deeply-nested-reflections-expected.txt:
* platform/efl/compositing/reflections/load-video-in-reflection-expected.png:
* platform/efl/compositing/reflections/load-video-in-reflection-expected.txt:
* platform/efl/compositing/reflections/masked-reflection-on-composited-expected.png:
* platform/efl/compositing/reflections/masked-reflection-on-composited-expected.txt:
* platform/efl/compositing/reflections/nested-reflection-anchor-point-expected.png:
* platform/efl/compositing/reflections/nested-reflection-anchor-point-expected.txt:
* platform/efl/compositing/reflections/nested-reflection-animated-expected.png:
* platform/efl/compositing/reflections/nested-reflection-animated-expected.txt:
* platform/efl/compositing/reflections/nested-reflection-expected.png:
* platform/efl/compositing/reflections/nested-reflection-expected.txt:
* platform/efl/compositing/reflections/nested-reflection-mask-change-expected.png:
* platform/efl/compositing/reflections/nested-reflection-mask-change-expected.txt:
* platform/efl/compositing/reflections/nested-reflection-on-overflow-expected.png:
* platform/efl/compositing/reflections/nested-reflection-on-overflow-expected.txt:
* platform/efl/compositing/reflections/nested-reflection-opacity-expected.png:
* platform/efl/compositing/reflections/nested-reflection-opacity-expected.txt:
* platform/efl/compositing/reflections/nested-reflection-size-change-expected.png:
* platform/efl/compositing/reflections/nested-reflection-size-change-expected.txt:
* platform/efl/compositing/reflections/nested-reflection-transformed-expected.png:
* platform/efl/compositing/reflections/nested-reflection-transformed-expected.txt:
* platform/efl/compositing/reflections/nested-reflection-transformed2-expected.png:
* platform/efl/compositing/reflections/nested-reflection-transformed2-expected.txt:
* platform/efl/compositing/reflections/nested-reflection-transition-expected.png:
* platform/efl/compositing/reflections/nested-reflection-transition-expected.txt:
* platform/efl/compositing/reflections/reflection-in-composited-expected.png:
* platform/efl/compositing/reflections/reflection-in-composited-expected.txt:
* platform/efl/compositing/reflections/reflection-opacity-expected.png:
* platform/efl/compositing/reflections/reflection-opacity-expected.txt:
* platform/efl/compositing/reflections/reflection-ordering-expected.png:
* platform/efl/compositing/reflections/reflection-ordering-expected.txt:
* platform/efl/compositing/reflections/reflection-positioning-expected.png:
* platform/efl/compositing/reflections/reflection-positioning-expected.txt:
* platform/efl/compositing/reflections/reflection-positioning2-expected.png:
* platform/efl/compositing/reflections/reflection-positioning2-expected.txt:
* platform/efl/compositing/reflections/simple-composited-reflections-expected.png:
* platform/efl/compositing/reflections/simple-composited-reflections-expected.txt:
* platform/efl/compositing/reflections/transform-inside-reflection-expected.png:
* platform/efl/compositing/reflections/transform-inside-reflection-expected.txt:
* platform/efl/compositing/repaint/become-overlay-composited-layer-expected.png:
* platform/efl/compositing/repaint/become-overlay-composited-layer-expected.txt:
* platform/efl/compositing/repaint/composited-document-element-expected.png:
* platform/efl/compositing/repaint/composited-document-element-expected.txt:
* platform/efl/compositing/repaint/layer-repaint-expected.png:
* platform/efl/compositing/repaint/layer-repaint-expected.txt:
* platform/efl/compositing/repaint/layer-repaint-rects-expected.png:
* platform/efl/compositing/repaint/layer-repaint-rects-expected.txt:
* platform/efl/compositing/repaint/opacity-between-absolute-expected.png:
* platform/efl/compositing/repaint/opacity-between-absolute-expected.txt:
* platform/efl/compositing/repaint/opacity-between-absolute2-expected.png:
* platform/efl/compositing/repaint/opacity-between-absolute2-expected.txt:
* platform/efl/compositing/self-painting-layers-expected.png:
* platform/efl/compositing/self-painting-layers-expected.txt:
* platform/efl/compositing/shadows/shadow-drawing-expected.png:
* platform/efl/compositing/shadows/shadow-drawing-expected.txt:
* platform/efl/compositing/sibling-positioning-expected.png:
* platform/efl/compositing/sibling-positioning-expected.txt:
* platform/efl/compositing/text-on-large-layer-expected.png:
* platform/efl/compositing/text-on-large-layer-expected.txt:
* platform/efl/compositing/transitions/scale-transition-no-start-expected.png:
* platform/efl/compositing/transitions/scale-transition-no-start-expected.txt:
* platform/efl/compositing/transitions/singular-scale-transition-expected.png:
* platform/efl/compositing/transitions/singular-scale-transition-expected.txt:
* platform/efl/compositing/video/video-background-color-expected.png:
* platform/efl/compositing/video/video-background-color-expected.txt:
* platform/efl/compositing/visibility/visibility-composited-expected.png: Added.
* platform/efl/compositing/visibility/visibility-composited-expected.txt: Added.
* platform/efl/compositing/visibility/visibility-composited-transforms-expected.png: Copied from LayoutTests/platform/efl/mathml/presentation/fenced-expected.png.
* platform/efl/compositing/visibility/visibility-composited-transforms-expected.txt: Added.
* platform/efl/mathml/presentation/attributes-expected.png:
* platform/efl/mathml/presentation/attributes-expected.txt:
* platform/efl/mathml/presentation/fenced-expected.png:
* platform/efl/mathml/presentation/fenced-expected.txt:
* platform/efl/mathml/presentation/fenced-mi-expected.png:
* platform/efl/mathml/presentation/fenced-mi-expected.txt:
* platform/efl/mathml/presentation/fractions-expected.png:
* platform/efl/mathml/presentation/fractions-expected.txt:
* platform/efl/mathml/presentation/fractions-vertical-alignment-expected.png:
* platform/efl/mathml/presentation/fractions-vertical-alignment-expected.txt:
* platform/efl/mathml/presentation/mo-stretch-expected.png: Added.
* platform/efl/mathml/presentation/mo-stretch-expected.txt: Added.
* platform/efl/mathml/presentation/mroot-pref-width-expected.png: Added.
* platform/efl/mathml/presentation/mroot-pref-width-expected.txt: Added.
* platform/efl/mathml/presentation/sub-expected.png:
* platform/efl/mathml/presentation/sub-expected.txt:
* platform/efl/mathml/presentation/subsup-expected.png:
* platform/efl/mathml/presentation/subsup-expected.txt:
* platform/efl/mathml/presentation/sup-expected.png:
* platform/efl/mathml/presentation/sup-expected.txt:
* platform/efl/mathml/presentation/tables-expected.png:
* platform/efl/mathml/presentation/tables-expected.txt:
* platform/efl/mathml/presentation/tokenElements-expected.png:
* platform/efl/mathml/presentation/tokenElements-expected.txt:
* platform/efl/mathml/presentation/under-expected.png:
* platform/efl/mathml/presentation/under-expected.txt:
* platform/efl/mathml/presentation/underover-expected.png:
* platform/efl/mathml/presentation/underover-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Implements the registerProtocolHandler method and option.
commit-queue@webkit.org [Wed, 23 May 2012 13:37:31 +0000 (13:37 +0000)]
[EFL] Implements the registerProtocolHandler method and option.
https://bugs.webkit.org/show_bug.cgi?id=73638

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-05-23
Reviewed by Andreas Kling.

* Scripts/webkitperl/FeatureList.pm: Turn on the ENABLE_REGISTER_PROTOCOL_HANDLER option as default on EFL port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix crashing expectation for several media/ LayoutTests
steveblock@google.com [Wed, 23 May 2012 13:31:53 +0000 (13:31 +0000)]
Fix crashing expectation for several media/ LayoutTests

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSet crashing expectation for several media/ LayoutTests
steveblock@google.com [Wed, 23 May 2012 13:23:47 +0000 (13:23 +0000)]
Set crashing expectation for several media/ LayoutTests

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix incomplete switch statement in CSSParser after r118082
jochen@chromium.org [Wed, 23 May 2012 13:09:01 +0000 (13:09 +0000)]
Fix incomplete switch statement in CSSParser after r118082
https://bugs.webkit.org/show_bug.cgi?id=87250

Reviewed by Alexis Menard.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r118105.
commit-queue@webkit.org [Wed, 23 May 2012 13:05:16 +0000 (13:05 +0000)]
Unreviewed, rolling out r118105.
http://trac.webkit.org/changeset/118105
https://bugs.webkit.org/show_bug.cgi?id=87255

New LayoutTest is causing several cookie tests to fail on
numerous bots (Requested by steveblock on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-23

Source/WebCore:

* platform/blackberry/CookieJarBlackBerry.cpp:
(WebCore::setCookies):
* platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::setCookies):
(WebCore::CookieManager::checkAndTreatCookie):
(WebCore::CookieManager::addCookieToMap):
(WebCore::CookieManager::setPrivateMode):
(WebCore):
* platform/blackberry/CookieManager.h:
* platform/blackberry/CookieMap.cpp:
(WebCore::CookieMap::addOrReplaceCookie):
(WebCore::CookieMap::removeCookie):
* platform/blackberry/CookieMap.h:
(CookieMap):

LayoutTests:

* http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Removed.
* http/tests/cookies/js-get-and-set-http-only-cookie.php: Removed.
* http/tests/cookies/script-tests/js-get-and-set-http-only-cookie.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Small refactoring WebPage::confirmComposition.
commit-queue@webkit.org [Wed, 23 May 2012 13:04:15 +0000 (13:04 +0000)]
[Qt][WK2] Small refactoring WebPage::confirmComposition.
https://bugs.webkit.org/show_bug.cgi?id=87243

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-05-23
Reviewed by Kenneth Rohde Christiansen.

Change nested if into an early return to reduce complexity.

* WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::confirmComposition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] EventSender should properly handle (left|right)(control|shift|alt) after r118001
zandobersek@gmail.com [Wed, 23 May 2012 13:00:08 +0000 (13:00 +0000)]
[Gtk] EventSender should properly handle (left|right)(control|shift|alt) after r118001
https://bugs.webkit.org/show_bug.cgi?id=87221

Reviewed by Martin Robinson.

Source/WebCore:

No new tests - covered by fast/events/keydown-leftright-keys.html.

Windows key code for shift, control and alt keys should respect the
left or right position of that key. This way the DOM location code of
a key event is properly determined for these keys.

* platform/gtk/PlatformKeyboardEventGtk.cpp:
(WebCore::PlatformKeyboardEvent::windowsKeyCodeForGdkKeyCode):

Tools:

Convert leftAlt, leftControl, leftShift, rightAlt, rightControl and
rightShift key names into proper GDK key symbols.

* DumpRenderTree/gtk/EventSender.cpp:
(createKeyPressEvent):

LayoutTests:

Remove failing test expectations for fast/events/keydown-leftright-keys.html,
the test should pass now.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Missing tests for the evaluateJavaScript API
ahf@0x90.dk [Wed, 23 May 2012 12:15:13 +0000 (12:15 +0000)]
[Qt] Missing tests for the evaluateJavaScript API
https://bugs.webkit.org/show_bug.cgi?id=86351

Reviewed by Kenneth Rohde Christiansen.

* UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml:
* UIProcess/API/qt/tests/qmltests/common/evaluatejavascript.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: eliminate getters from HeapSnapshot.js
loislo@chromium.org [Wed, 23 May 2012 12:08:35 +0000 (12:08 +0000)]
Web Inspector: eliminate getters from HeapSnapshot.js
https://bugs.webkit.org/show_bug.cgi?id=87241

getters can't be inlined by engine at the moment.
I found that conversion getters into functions gives us about 600 ms

RESULT heap-snapshot: switch-to-containment-view= 1920 ms
vs
RESULT heap-snapshot: switch-to-containment-view= 1367 ms

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotEdge.prototype.hasStringName):
(WebInspector.HeapSnapshotEdge.prototype.isElement):
(WebInspector.HeapSnapshotEdge.prototype.isHidden):
(WebInspector.HeapSnapshotEdge.prototype.isWeak):
(WebInspector.HeapSnapshotEdge.prototype.isInternal):
(WebInspector.HeapSnapshotEdge.prototype.isInvisible):
(WebInspector.HeapSnapshotEdge.prototype.isShortcut):
(WebInspector.HeapSnapshotEdge.prototype.name):
(WebInspector.HeapSnapshotEdge.prototype.node):
(WebInspector.HeapSnapshotEdge.prototype.nodeIndex):
(WebInspector.HeapSnapshotEdge.prototype.rawEdges):
(WebInspector.HeapSnapshotEdge.prototype.toString):
(WebInspector.HeapSnapshotEdge.prototype.type):
(WebInspector.HeapSnapshotEdge.prototype._hasStringName):
(WebInspector.HeapSnapshotEdge.prototype._name):
(WebInspector.HeapSnapshotEdge.prototype._nameOrIndex):
(WebInspector.HeapSnapshotEdgeIterator.prototype.index):
(WebInspector.HeapSnapshotEdgeIterator.prototype.setIndex):
(WebInspector.HeapSnapshotEdgeIterator.prototype.item):
(WebInspector.HeapSnapshotRetainerEdge):
(WebInspector.HeapSnapshotRetainerEdge.prototype.clone):
(WebInspector.HeapSnapshotRetainerEdge.prototype.hasStringName):
(WebInspector.HeapSnapshotRetainerEdge.prototype.isElement):
(WebInspector.HeapSnapshotRetainerEdge.prototype.isHidden):
(WebInspector.HeapSnapshotRetainerEdge.prototype.isInternal):
(WebInspector.HeapSnapshotRetainerEdge.prototype.isInvisible):
(WebInspector.HeapSnapshotRetainerEdge.prototype.isShortcut):
(WebInspector.HeapSnapshotRetainerEdge.prototype.isWeak):
(WebInspector.HeapSnapshotRetainerEdge.prototype.name):
(WebInspector.HeapSnapshotRetainerEdge.prototype.node):
(WebInspector.HeapSnapshotRetainerEdge.prototype.nodeIndex):
(WebInspector.HeapSnapshotRetainerEdge.prototype.retainerIndex):
(WebInspector.HeapSnapshotRetainerEdge.prototype.setRetainerIndex):
(WebInspector.HeapSnapshotRetainerEdge.prototype._node):
(WebInspector.HeapSnapshotRetainerEdge.prototype._edge):
(WebInspector.HeapSnapshotRetainerEdge.prototype.toString):
(WebInspector.HeapSnapshotRetainerEdge.prototype.type):
(WebInspector.HeapSnapshotRetainerEdgeIterator.prototype.first):
(WebInspector.HeapSnapshotRetainerEdgeIterator.prototype.hasNext):
(WebInspector.HeapSnapshotRetainerEdgeIterator.prototype.index):
(WebInspector.HeapSnapshotRetainerEdgeIterator.prototype.setIndex):
(WebInspector.HeapSnapshotRetainerEdgeIterator.prototype.item):
(WebInspector.HeapSnapshotRetainerEdgeIterator.prototype.next):
(WebInspector.HeapSnapshotNode.prototype.canBeQueried):
(WebInspector.HeapSnapshotNode.prototype.distanceToWindow):
(WebInspector.HeapSnapshotNode.prototype.className):
(WebInspector.HeapSnapshotNode.prototype.dominatorIndex):
(WebInspector.HeapSnapshotNode.prototype.edges):
(WebInspector.HeapSnapshotNode.prototype.edgesCount):
(WebInspector.HeapSnapshotNode.prototype.flags):
(WebInspector.HeapSnapshotNode.prototype.id):
(WebInspector.HeapSnapshotNode.prototype.isHidden):
(WebInspector.HeapSnapshotNode.prototype.isNative):
(WebInspector.HeapSnapshotNode.prototype.isSynthetic):
(WebInspector.HeapSnapshotNode.prototype.isWindow):
(WebInspector.HeapSnapshotNode.prototype.isDetachedDOMTreesRoot):
(WebInspector.HeapSnapshotNode.prototype.isDetachedDOMTree):
(WebInspector.HeapSnapshotNode.prototype.isRoot):
(WebInspector.HeapSnapshotNode.prototype.name):
(WebInspector.HeapSnapshotNode.prototype.rawEdges):
(WebInspector.HeapSnapshotNode.prototype.retainedSize):
(WebInspector.HeapSnapshotNode.prototype.retainers):
(WebInspector.HeapSnapshotNode.prototype.selfSize):
(WebInspector.HeapSnapshotNode.prototype.type):
(WebInspector.HeapSnapshotNode.prototype._name):
(WebInspector.HeapSnapshotNode.prototype._edgeIndexesEnd):
(WebInspector.HeapSnapshotNode.prototype._nextNodeIndex):
(WebInspector.HeapSnapshotNode.prototype._type):
(WebInspector.HeapSnapshotNodeIterator):
(WebInspector.HeapSnapshotNodeIterator.prototype.hasNext):
(WebInspector.HeapSnapshotNodeIterator.prototype.index):
(WebInspector.HeapSnapshotNodeIterator.prototype.setIndex):
(WebInspector.HeapSnapshotNodeIterator.prototype.item):
(WebInspector.HeapSnapshotNodeIterator.prototype.next):
(WebInspector.HeapSnapshot.prototype._allNodes):
(WebInspector.HeapSnapshot.prototype.rootNode):
(WebInspector.HeapSnapshot.prototype.get totalSize):
(WebInspector.HeapSnapshot.prototype._dominatedNodesOfNode):
(WebInspector.HeapSnapshot.prototype.aggregatesForDiff):
(WebInspector.HeapSnapshot.prototype._calculateObjectToWindowDistance):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._calculateClassesRetainedSize):
(WebInspector.HeapSnapshot.prototype._sortAggregateIndexes):
(WebInspector.HeapSnapshot.prototype._markInvisibleEdges):
(WebInspector.HeapSnapshot.prototype._markDetachedDOMTreeNodes):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):
(WebInspector.HeapSnapshot.prototype._calculateDiffForClass):
(WebInspector.HeapSnapshot.prototype._nodeForSnapshotObjectId):
(WebInspector.HeapSnapshot.prototype.nodeClassName):
(WebInspector.HeapSnapshot.prototype.dominatorIdsForNode):
(WebInspector.HeapSnapshot.prototype.createEdgesProvider):
(WebInspector.HeapSnapshot.prototype.createRetainingEdgesProvider):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype._createIterationOrder):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.isEmpty):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.item):
(WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.serializeItemsRange):
(WebInspector.HeapSnapshotEdgesProvider.prototype.serializeItem):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareEdgeFieldName):
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareNodeField):
(WebInspector.HeapSnapshotNodesProvider):
(WebInspector.HeapSnapshotNodesProvider.prototype.nodePosition):
(WebInspector.HeapSnapshotNodesProvider.prototype.serializeItem):
(WebInspector.HeapSnapshotNodesProvider.prototype.sort.sortByNodeField):
* inspector/front-end/HeapSnapshotGridNodes.js:
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotProviderProxy.prototype.isEmpty):

LayoutTests:

* inspector/profiler/heap-snapshot.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Debugger should correctly show catch scope
yurys@chromium.org [Wed, 23 May 2012 12:00:57 +0000 (12:00 +0000)]
Web Inspector: Debugger should correctly show catch scope
https://bugs.webkit.org/show_bug.cgi?id=87197

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* bindings/v8/DebuggerScript.js: In case of Catch scope the scope object
is a synthetic one which means that it contains all standard object properties.
When passing this object further we need to leave only properties available in
the catch block(only variable thar stores the exception in fact).

LayoutTests:

Added test for "catch" block to the debugger test.

* inspector/debugger/debugger-expand-scope-expected.txt:
* inspector/debugger/debugger-expand-scope.html:
* platform/chromium/inspector/debugger/debugger-expand-scope-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening of failing tests
commit-queue@webkit.org [Wed, 23 May 2012 11:34:22 +0000 (11:34 +0000)]
[EFL] Gardening of failing tests
https://bugs.webkit.org/show_bug.cgi?id=87233

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-23

* platform/efl/Skipped:
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] FloatSize Qt Support
commit-queue@webkit.org [Wed, 23 May 2012 11:19:40 +0000 (11:19 +0000)]
[Qt] FloatSize Qt Support
https://bugs.webkit.org/show_bug.cgi?id=87237

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-23
Reviewed by Andreas Kling.

Source/WebCore:

No new functionality. No new tests.

* Target.pri:
* platform/graphics/FloatSize.h:
(FloatSize):
* platform/graphics/qt/FloatSizeQt.cpp: Added.
(WebCore::FloatSize::FloatSize):
(WebCore::FloatSize::operator QSizeF):

Source/WebKit2:

Basic cleanup possible to new Qt support in FloatSize.

* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::updateSize):
* UIProcess/API/qt/qwebkittest.cpp:
(QWebKitTest::layoutSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Make the web view's url property follow the active url
vestbo@webkit.org [Wed, 23 May 2012 11:03:11 +0000 (11:03 +0000)]
[Qt] Make the web view's url property follow the active url

https://bugs.webkit.org/show_bug.cgi?id=77554

The url property of the webview now reflects the 'active' url of the
page, which maps to either the currently loading url, in the case of
an ongoing load, or the result of a load, even when the load failed.

In practice this means that setting the url though QML, or navigating
to a new url in the page by e.g clicking, will both instantly change
the url-property of the webview to the target url. This differs from
earlier behavior, where we would update the url when the load
committed.

An optional argument is added to loadHtml(), to allow setting
the unreachable url when providing replacement content for failed
loads.

Finally, the location bar in the minibrowser is updated to behave
a bit more like normal browsers in terms of when the url will change
and how active focus is handled.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening editing/style tests, missing baselines.
commit-queue@webkit.org [Wed, 23 May 2012 10:56:14 +0000 (10:56 +0000)]
[EFL] Gardening editing/style tests, missing baselines.
https://bugs.webkit.org/show_bug.cgi?id=87100

Unreviewed EFL gardening.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-05-23

* platform/efl/test_expectations.txt: added tests regarding 84839 bug, missing baselines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Race condition in LayerTreeHost/Proxy can cause blank rendering
hausmann@webkit.org [Wed, 23 May 2012 10:54:01 +0000 (10:54 +0000)]
[Qt] Race condition in LayerTreeHost/Proxy can cause blank rendering
https://bugs.webkit.org/show_bug.cgi?id=87239

Reviewed by Kenneth Rohde Christiansen.

On the UI process side the WebLayerTreeRenderer/LayerTreeHostProxy pair is
created with m_active = false, which makes it ignore any incoming layer updates.
It remains inactive until the ContentsSGNode is created and setActive(true) is called.

On the web process side the LayerTreeHost is created with m_waitingForUIProcess = false.

Those two variables must be in sync, otherwise a race condition can
happen: The web process sends updates to the ui process before the
ContentsSGNode is created. This can happen for example when re-using an
existing WebProcess to create a QQuickWebView and load a page very fast
from the disk cache. The update arrives on the ui process side, but it
is discarded because setActive(true) hasn't been called yet. As a
result any updates that would for example create and populate the tiles
required for rendering are ignored.

This patch ensures that the variables are initialized with the same values and that calling
setActive(true) will trigger the rendering of the next frame.

* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::setActive):
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::LayerTreeHostQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Remove references to $$QT_SOURCE_TREE
vestbo@webkit.org [Wed, 23 May 2012 10:50:53 +0000 (10:50 +0000)]
[Qt] Remove references to $$QT_SOURCE_TREE

With a modularized Qt, it's ambigious. What we really want is qtbase,
which qtcore is a proxy for (we assume it will always live in qtbase).

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-05-23
Reviewed by Tor Arne Vestbø.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Enable HeapSnapshotRealWorker in production mode.
commit-queue@webkit.org [Wed, 23 May 2012 10:49:46 +0000 (10:49 +0000)]
Web Inspector: Enable HeapSnapshotRealWorker in production mode.
https://bugs.webkit.org/show_bug.cgi?id=87240

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-05-23
Reviewed by Yury Semikhatsky.

* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotWorker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix qmake conditional for c++-11 compat warnings
vestbo@webkit.org [Wed, 23 May 2012 10:39:06 +0000 (10:39 +0000)]
[Qt] Fix qmake conditional for c++-11 compat warnings

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-05-23
Reviewed by Tor Arne Vestbø.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed: inspector's Find is not consuming event as of r117974.
pfeldman@chromium.org [Wed, 23 May 2012 10:08:46 +0000 (10:08 +0000)]
Not reviewed: inspector's Find is not consuming event as of r117974.

* inspector/front-end/AdvancedSearchController.js:
(WebInspector.AdvancedSearchController.prototype.handleShortcut):
* inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype.handleShortcut):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: enable drag-an-drop from the navigator panel.
pfeldman@chromium.org [Wed, 23 May 2012 09:55:29 +0000 (09:55 +0000)]
Web Inspector: enable drag-an-drop from the navigator panel.
https://bugs.webkit.org/show_bug.cgi?id=87238

Reviewed by Vsevolod Vlasov.

Making tree item draggable.

* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorSourceTreeElement.prototype.onattach):
(WebInspector.NavigatorSourceTreeElement.prototype._onmousedown.callback):
(WebInspector.NavigatorSourceTreeElement.prototype._onmousedown):
(WebInspector.NavigatorSourceTreeElement.prototype._ondragstart):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebKit spends ~20% of time in HTMLTextAreaElement::defaultValue() when opening a...
rniwa@webkit.org [Wed, 23 May 2012 08:50:09 +0000 (08:50 +0000)]
WebKit spends ~20% of time in HTMLTextAreaElement::defaultValue() when opening a review page
https://bugs.webkit.org/show_bug.cgi?id=86813

Reviewed by Eric Seidel.

Replace String and calls to String::operator+= by StringBuilder and calls to append respectively.
While there are other optimizations we can implement such as not replacing all nodes in the shadow DOM,
or not serializing the value when detecting whether the value had changed, they require considerable
amount of refactoring and this change alone seems to buy us a lot so let us defer those 'til later time.

Also avoid the redundant call to setValue in childrenChanged when the value is dirty.
This should halve the time we spend in setting the value.

* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::childrenChanged):
(WebCore::HTMLTextAreaElement::defaultValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Make QtWebError return the failing URL as a QString instead of QUrl
vestbo@webkit.org [Wed, 23 May 2012 08:32:20 +0000 (08:32 +0000)]
[Qt] Make QtWebError return the failing URL as a QString instead of QUrl

We don't want to use QUrl inside QtWebKit (only in the API layer), due
to how QUrl normalizes the url.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Webarchives tests gardening
commit-queue@webkit.org [Wed, 23 May 2012 08:25:58 +0000 (08:25 +0000)]
[EFL][DRT] Webarchives tests gardening
https://bugs.webkit.org/show_bug.cgi?id=87225

Unreviewed. The EFL port has no support for webarchives, so the related testcases should
be put to test_expectations as expected to fail.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-23

* platform/efl/Skipped:
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add inspector API to WebKit2 GTK+
carlosgc@webkit.org [Wed, 23 May 2012 07:56:41 +0000 (07:56 +0000)]
[GTK] Add inspector API to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=87113

Reviewed by Martin Robinson.

* GNUmakefile.list.am: Add new files to compilation.
* UIProcess/API/C/gtk/WKInspectorClientGtk.cpp: Added.
(WKInspectorSetInspectorClientGtk):
* UIProcess/API/C/gtk/WKInspectorClientGtk.h: Added.
* UIProcess/API/gtk/WebKitPrivate.h:
* UIProcess/API/gtk/WebKitWebInspector.cpp: Added.
(webkitWebInspectorFinalize):
(webkit_web_inspector_init):
(webkit_web_inspector_class_init):
(openWindow): Emit WebKitWebInspector::open-window singal.
(didClose): Emit WebKitWebInspector::closed signal.
(bringToFront): Emit WebKitWebInspector::bring-to-front singal.
(inspectedURLChanged): Set the inspected URI and emit
GObject::notify signal if it changed.
(attach): Emit WebKitWebInspector::attach signal.
(detach): Emit WebKitWebInspector::detach signal.
(didChangeAttachedHeight): Set the attached height and emit
GObject::notify signal if it changed.
(webkitWebInspectorCreate): Ceate a new WebKitWebInspector object
for the given WKInspector. Also initialize and set the inspector
client.
(webkit_web_inspector_get_web_view): Return the web view used to
render the inspector.
(webkit_web_inspector_get_inspected_uri): Return the URI that is
being inspected.
(webkit_web_inspector_is_attached): Whether the inspector view is
currently attached.
(webkit_web_inspector_attach): Request to attach the inspector.
(webkit_web_inspector_detach): Request to detach the inspector.
(webkit_web_inspector_show): Request to show the inspector.
(webkit_web_inspector_close): Request to close the inspector.
(webkit_web_inspector_get_attached_height): Return the height that
the inspector view should have when attached.
* UIProcess/API/gtk/WebKitWebInspector.h: Added.
* UIProcess/API/gtk/WebKitWebInspectorPrivate.h: Added.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_get_inspector): Return the WebKitWebInspector
associated to the web view.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for
WebKitWebInspector.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Ad new symbols.
* UIProcess/API/gtk/docs/webkit2gtk.types: Add
webkit_web_inspector_get_type.
* UIProcess/API/gtk/tests/GNUmakefile.am: Add new test for the
inspector API.
* UIProcess/API/gtk/tests/TestInspector.cpp: Added.
(testInspectorDefault):
(testInspectorCustom):
(testInspectorWindowDestroyed):
(beforeAll):
(afterAll):
* UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::showInWindowAndWaitUntilMapped): Add optional
parameter to create a toplevel or popup window.
(WebViewTest::resizeView): Helper function to set the widget
allocation to a given size.
* UIProcess/API/gtk/tests/WebViewTest.h:
* UIProcess/API/gtk/webkit2.h: Include WebKitWebInspector.h
* UIProcess/WebInspectorProxy.h:
(WebKit::WebInspectorProxy::inspectorView): Return the view used
to render the inspector.
* UIProcess/gtk/WebInspectorClientGtk.cpp: Added.
(WebKit::WebInspectorClientGtk::openWindow):
(WebKit::WebInspectorClientGtk::didClose):
(WebKit::WebInspectorClientGtk::bringToFront):
(WebKit::WebInspectorClientGtk::inspectedURLChanged):
(WebKit::WebInspectorClientGtk::attach):
(WebKit::WebInspectorClientGtk::detach):
(WebKit::WebInspectorClientGtk::didChangeAttachedHeight):
* UIProcess/gtk/WebInspectorClientGtk.h: Added.
* UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::inspectorViewDestroyed): Close the inspector page when
the inspector view is destroyed, instead of when the inspector
window is deleted, because the inspector view can now be inside a
window created by the user.
(WebKit::WebInspectorProxy::initializeInspectorClientGtk):
Initialze the inspector client.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Add a
weak pointer to the inspector view to make sure it's NULL when
destroyed.
(WebKit::WebInspectorProxy::createInspectorWindow): Call
openWindow on the inspector client, and return early if the
callback was handled.
(WebKit::WebInspectorProxy::platformOpen): Connect to destroy
signal of the inspector view to close the page when the view is
destroyed.
(WebKit::WebInspectorProxy::platformDidClose): Call didClose on
the inspector client.
(WebKit::WebInspectorProxy::platformBringToFront): Call
bringToFront on the inspector client, and return early if the
callback was handled.
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Call
inspectedURLChanged on the inspector client.
(WebKit::WebInspectorProxy::platformAttach): Call attach on the
inspector client and return if the callback was handled.
(WebKit::WebInspectorProxy::platformDetach): Call detach on the
inspector client and return if the callback was handled.
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight): Call
didChangeAttachedHeight on the inspector client.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix ChangeLog entry to indicate that the last commit was merged from the dfgopt branch.
fpizlo@apple.com [Wed, 23 May 2012 07:55:12 +0000 (07:55 +0000)]
Fix ChangeLog entry to indicate that the last commit was merged from the dfgopt branch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG should allow inlining in case of certain arity mismatches
fpizlo@apple.com [Wed, 23 May 2012 07:53:44 +0000 (07:53 +0000)]
DFG should allow inlining in case of certain arity mismatches
https://bugs.webkit.org/show_bug.cgi?id=86059

Reviewed by Geoff Garen.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleInlining):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: Contenteditable tables should always be exposed as data tables
aboxhall@chromium.org [Wed, 23 May 2012 07:45:29 +0000 (07:45 +0000)]
AX: Contenteditable tables should always be exposed as data tables
https://bugs.webkit.org/show_bug.cgi?id=87052

Reviewed by Chris Fleizach.

Source/WebCore:

Tested in accessibility/table-detection.html.

* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isDataTable): Return true if the node is contenteditable.

LayoutTests:

* accessibility/table-detection.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages
commit-queue@webkit.org [Wed, 23 May 2012 07:43:03 +0000 (07:43 +0000)]
[EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages
https://bugs.webkit.org/show_bug.cgi?id=85956

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-23
Reviewed by Gustavo Noronha Silva.

Source/WebKit/efl:

Add new "load,provisional,failed" signal on the frame and the view to
complement the "load,provisional" one.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidFailProvisionalLoad):
* ewk/ewk_frame.cpp:
(ewk_frame_load_provisional_failed):
* ewk/ewk_frame.h:
* ewk/ewk_frame_private.h:
* ewk/ewk_view.cpp:
(ewk_view_load_provisional_failed):
* ewk/ewk_view.h:
* ewk/ewk_view_private.h:

Tools:

Catch new "load,provisional,failed" signal and print
didFailProvisionalLoadWithError messages when LayoutTestController's
dumpFrameLoadCallbacks() returns true. Also make sure the
didFailLoadWithError message is not printed in case of provisional
load failure.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameProvisionalLoadFailed):
(DumpRenderTreeChrome::onFrameLoadError):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):

LayoutTests:

Unskip test cases which expect the DumpRenderTree to print
didFailProvisionalLoadWithError messages.
Add EFL expectation for
http/tests/loading/pdf-commit-load-callbacks.html.

* platform/efl/Skipped:
* platform/efl/http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.
Use same expectation as for Qt.
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] EFL's DRT needs to call Settings::setValidationMessageTimerMagnification(-1)
commit-queue@webkit.org [Wed, 23 May 2012 07:37:45 +0000 (07:37 +0000)]
[EFL] EFL's DRT needs to call Settings::setValidationMessageTimerMagnification(-1)
https://bugs.webkit.org/show_bug.cgi?id=86366

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-23
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Add helper function to DumpRenderTreeSupportEfl to set the validation
message timer magnification.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setValidationMessageTimerMagnification):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Call Settings::setValidationMessageTimerMagnification(-1) between the tests.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

LayoutTests:

Unskip fast/forms/validation-message-appearance.html and add EFL
expectation.

* platform/efl/Skipped:
* platform/efl/fast/forms/validation-message-appearance-expected.png: Added.
* platform/efl/fast/forms/validation-message-appearance-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118140 268f45cc-cd09-0410-ab3c-d52691b4dbfc