WebKit-https.git
12 years ago2008-07-03 Alex Mathews <possessedpenguinbob@gmail.com>
oliver@apple.com [Fri, 4 Jul 2008 01:10:08 +0000 (01:10 +0000)]
2008-07-03  Alex Mathews  <possessedpenguinbob@gmail.com>

        Reviewed by Oliver Hunt.

        Bug 19835: WebKit needs cross-platform filter system
        <https://bugs.webkit.org/show_bug.cgi?id=19835>

        More class refactoring in preparation for cross-platform filter
        implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFollow-up to the 64-bit build fix. Use intptr_t rather than ssize_t as the latter...
mrowe@apple.com [Fri, 4 Jul 2008 00:06:11 +0000 (00:06 +0000)]
Follow-up to the 64-bit build fix.  Use intptr_t rather than ssize_t as the latter is non-standard and does not exist on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the 64-bit build.
mrowe@apple.com [Thu, 3 Jul 2008 23:22:06 +0000 (23:22 +0000)]
Fix the 64-bit build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Thu, 3 Jul 2008 21:37:53 +0000 (21:37 +0000)]
WebCore:

        Reviewed by John Sullivan.

        - fix <rdar://problem/6020930> Bidi Problem When Resizing Window

        Test: fast/text/international/bidi-AN-after-empty-run.html

        * platform/text/BidiResolver.h:
        (WebCore::::appendRun): Changed to reset the current direction and
        "end of run" direction even in the empty run case.
        * rendering/bidi.cpp:
        (WebCore::BidiState::appendRun): Ditto.

LayoutTests:

        Reviewed by John Sullivan.

        - test for <rdar://problem/6020930> Bidi Problem When Resizing Window

        * fast/text/international/bidi-AN-after-empty-run.html: Added.
        * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum: Added.
        * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png: Added.
        * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://5983747> Safari crashes trying to load the SilverLight plugin
jhoneycutt@apple.com [Thu, 3 Jul 2008 20:52:56 +0000 (20:52 +0000)]
<rdar://5983747> Safari crashes trying to load the SilverLight plugin

If a plug-in returned an error code from NPP_NewStream, we would call
NPP_DestroyStream while cleaning up the request. We now only call
NPP_DestroyStream if NPP_NewStream was successful, matching Firefox.

Reviewed by Anders.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-03 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 3 Jul 2008 19:35:40 +0000 (19:35 +0000)]
2008-07-03  David Hyatt  <hyatt@apple.com>

        Revise Dan's fix for an assert on Windows, since layoutIfNeededRecursive doesn't exist on the
        Mac.  Revert updateControlTints and add the layout call outside of it in the already-existing
        !PLATFORM(MAC) ifdef in FocusController's setActive method.

        Reviewed by ggaren, weinig

        * page/FocusController.cpp:
        (WebCore::FocusController::setActive):
        * page/FrameView.cpp:
        (WebCore::FrameView::updateControlTints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap@webkit.org [Thu, 3 Jul 2008 19:13:37 +0000 (19:13 +0000)]
    Reviewed by Darin.

        https://bugs.webkit.org/show_bug.cgi?id=19884
        Locating a store at www.366.ru doesn't work

        Test: fast/forms/submit-with-base.html

        * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Treat empty action the same
        as missing one - ignore base URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-03 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 3 Jul 2008 19:06:52 +0000 (19:06 +0000)]
2008-07-03  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Removed checking for the array get/put fast case from the array code.
        Callers who want the fast case should call getIndex and/or setIndex
        instead. (get_by_val and put_by_val already do this.)

        SunSpider reports no change overall, but a 1.4% speedup on fannkuch and
        a 3.6% speedup on nsieve.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by John Sullivan.
mitz@apple.com [Thu, 3 Jul 2008 18:51:14 +0000 (18:51 +0000)]
    Reviewed by John Sullivan.

        - fix <rdar://problem/6048904> Assert in WebCore::Frame::paint in Windows

        * page/FrameView.cpp:
        (WebCore::FrameView::updateControlTints): Changed to update layout
        recursively and not just for the top-level frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWindows build fix
mitz@apple.com [Thu, 3 Jul 2008 18:26:29 +0000 (18:26 +0000)]
Windows build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-03 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Thu, 3 Jul 2008 18:13:29 +0000 (18:13 +0000)]
2008-07-03  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Geoff.

        Bug 19853: REGRESSION (r34838): Crash when visiting http://www.thewebsiteisdown.com/salesguy.html
        https://bugs.webkit.org/show_bug.cgi?id=19853

        Remove the body of _NPN_SetException(), because it was simply calling
        throwError(), which sets an exception on an ExecState but does not
        actually handle it. The presence of an exception on the global ExecState
        causes assertions that there is no exception set on that ExecState to
        fail, as well as causing Machine::execute() to mistakingly return 0 in
        some cases, as it assumes the presence of an exception implies that it
        has run out of memory.

        * bridge/NP_jsobject.cpp:
        (_NPN_SetException):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders Carlsson.
mitz@apple.com [Thu, 3 Jul 2008 17:57:44 +0000 (17:57 +0000)]
    Reviewed by Anders Carlsson.

        - Windows build fix

        * VM/Machine.cpp:
        (KJS::Machine::Machine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-03 Maciej Katafiasz <mathrick@gmail.com>
jmalonzo@webkit.org [Thu, 3 Jul 2008 13:01:42 +0000 (13:01 +0000)]
2008-07-03  Maciej Katafiasz  <mathrick@gmail.com>

        Gtk build fix with SVG filters enabled

        * GNUmakefile.am: Include missing SVG filter sources

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-03 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Thu, 3 Jul 2008 08:06:24 +0000 (08:06 +0000)]
2008-07-03  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Fix the non-threaded build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Qt build
hausmann@webkit.org [Thu, 3 Jul 2008 07:54:04 +0000 (07:54 +0000)]
Fix the Qt build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoff.
ap@webkit.org [Thu, 3 Jul 2008 07:44:43 +0000 (07:44 +0000)]
    Reviewed by Geoff.

        Don't create unnecessary JSGlobalData instances.

        * kjs/JSGlobalData.h:
        * kjs/JSGlobalData.cpp:
        (KJS::JSGlobalData::threadInstanceExists):
        (KJS::JSGlobalData::sharedInstanceExists):
        (KJS::JSGlobalData::threadInstance):
        (KJS::JSGlobalData::sharedInstance):
        (KJS::JSGlobalData::threadInstanceInternal):
        (KJS::JSGlobalData::sharedInstanceInternal):
        Added methods to query instance existence.

        * kjs/InitializeThreading.cpp:
        (KJS::initializeThreadingOnce):
        Initialize thread instance static in a new way.

        * API/JSBase.cpp:
        (JSGarbageCollect):
        * kjs/collector.cpp:
        (KJS::Heap::collect):
        Check for instance existence before accessing it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-03 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 3 Jul 2008 07:10:58 +0000 (07:10 +0000)]
2008-07-03  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Mark Rowe.

        Updated this test result to match our new, smaller recursion limit.
        With the new limit, an exception is thrown on entry to the document.write
        script, which is why you see an exception logged to the console, instead
        of caught inside the script.

        * fast/js/global-recursion-on-full-stack-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-02 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 3 Jul 2008 06:58:28 +0000 (06:58 +0000)]
2008-07-02  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Mark Rowe.

        Updated this test to match our lower recursion limit, and to signal
        failure as failure.

        * fast/js/deep-recursion-test.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-02 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 3 Jul 2008 06:48:01 +0000 (06:48 +0000)]
2008-07-02  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Fixed https://bugs.webkit.org/show_bug.cgi?id=19862
        REGRESSION (r34907): Gmail crashes in JavaScriptCore code while editing drafts

        I was never able to reproduce this issue, but Cameron could, and he says
        that this patch fixes it.

        The crash seems tied to a timer or event handler callback. In such a case,
        the sole reference to the global object may be in the current call frame,
        so we can't depend on the global object to mark the call frame area in
        the register file.

        The new GC marking rule is: the global object is not responsible for
        marking the whole register file -- it's just responsible for the globals
        section it's tied to. The heap is responsible for marking the call frame area.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReduce test runtime to avoid timeout on slow hardware with debug builds.
oliver@apple.com [Thu, 3 Jul 2008 06:40:00 +0000 (06:40 +0000)]
Reduce test runtime to avoid timeout on slow hardware with debug builds.

RS=Mark Rowe

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
beidson@apple.com [Thu, 3 Jul 2008 06:10:47 +0000 (06:10 +0000)]
WebCore:

2008-07-02  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitz Pettel and John Sullivan

        Fix for <rdar://problem/5549871> - Crash when calling [WebView stopLoading:] or [WebFrame stopLoading]
        inside of the frame load delegate method -webView:didStartProvisionalLoadForFrame:.

        Test: fast/loader/stop-provisional-loads.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): Since the provisionalDocumentLoader may have been cleared
          by the prepareForLoadStart() call, null check it again.

WebKitTools:

2008-07-02  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitz Pettel and John Sullivan

        Add the ability to tell DRT to call stopLoading on a WebFrame inside of a didStartProvisionalLoadForFrame
        load delegate.

        Required to add a layout test for the fix for <rdar://problem/5549871>

        * DumpRenderTree/mac/FrameLoadDelegate.mm:
        (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): If stopProvisionalFrameLoads is set, call
          [WebFrame stopLoading] to test for the crash reflected in 5549871

        All of the following are infrastructure to add the layoutTestController.setStopProvisionalFrameLoads() call:
        * DumpRenderTree/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (setStopProvisionalFrameLoadsCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        (LayoutTestController::stopProvisionalFrameLoads):
        (LayoutTestController::setStopProvisionalFrameLoads):

LayoutTests:

2008-07-02  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitz Pettel and John Sullivan

        Fix for <rdar://problem/5549871> - Crash when calling [WebView stopLoading:] or [WebFrame stopLoading]
        inside of the frame load delegate method -webView:didStartProvisionalLoadForFrame:.

        * fast/loader/stop-provisional-loads-expected.txt: Added.
        * fast/loader/stop-provisional-loads.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-01 Alex Mathews <possessedpenguinbob@gmail.com>
oliver@apple.com [Thu, 3 Jul 2008 05:55:50 +0000 (05:55 +0000)]
2008-07-01  Alex Mathews  <possessedpenguinbob@gmail.com>

        Reviewed by Oliver Hunt.

        Renaming of class SVGFEBlend to FEBlend as well as removing
        a little bit of antiquated code. This includes the removal of
        SVGFEBlendCg.mm; the feBlend element will now no longer
        render.

        * WebCore.xcodeproj/project.pbxproj:
        * svg/FilterBuilder.h:
        (WebCore::FilterBuilder::add):
        (WebCore::FilterBuilder::getEffectById):
        * svg/SVGFEBlendElement.cpp:
        (WebCore::SVGFEBlendElement::SVGFEBlendElement):
        (WebCore::SVGFEBlendElement::parseMappedAttribute):
        (WebCore::SVGFEBlendElement::filterEffect):
        (WebCore::SVGFEBlendElement::build):
        * svg/SVGFEBlendElement.h:
        * svg/SVGFilterPrimitiveStandardAttributes.h:
        * svg/graphics/filters/SVGFEBlend.cpp:
        (WebCore::FEBlend::FEBlend):
        (WebCore::FEBlend::create):
        (WebCore::FEBlend::in2):
        (WebCore::FEBlend::setIn2):
        (WebCore::FEBlend::blendMode):
        (WebCore::FEBlend::setBlendMode):
        (WebCore::FEBlend::apply):
        (WebCore::FEBlend::dump):
        * svg/graphics/filters/SVGFEBlend.h:
        (WebCore::):
        * svg/graphics/filters/cg/SVGFEBlendCg.mm: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate a URL that was out of date.
mrowe@apple.com [Thu, 3 Jul 2008 04:55:25 +0000 (04:55 +0000)]
Update a URL that was out of date.

* building/checkout.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd the ability to trace JavaScriptCore garabge collections using dtrace.
mrowe@apple.com [Thu, 3 Jul 2008 04:55:22 +0000 (04:55 +0000)]
Add the ability to trace JavaScriptCore garabge collections using dtrace.

Reviewed by Sam Weinig.

* JavaScriptCore.xcodeproj/project.pbxproj: Generate the dtrace probe header
file when building on a new enough version of Mac OS X.
* JavaScriptCorePrefix.h: Add our standard Mac OS X version detection macros.
* kjs/Tracing.d: Declare three dtrace probes.
* kjs/Tracing.h: Include the generated dtrace macros if dtrace is available,
otherwise provide versions that do nothing.
* kjs/collector.cpp:
(KJS::Heap::collect): Fire dtrace probes when starting a collection, after the
mark phase has completed, and when the collection is complete.
* wtf/Platform.h: Define HAVE_DTRACE when building on a new enough version of Mac OS X.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoA single tear rolling down my cheek, I fix a performance measurement that was skewed...
ggaren@apple.com [Thu, 3 Jul 2008 04:54:14 +0000 (04:54 +0000)]
A single tear rolling down my cheek, I fix a performance measurement that was skewed due to a locally modified test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoChangeLog fixup
ggaren@apple.com [Thu, 3 Jul 2008 04:37:10 +0000 (04:37 +0000)]
ChangeLog fixup

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-02 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 3 Jul 2008 04:37:01 +0000 (04:37 +0000)]
2008-07-02  Geoffrey Garen  <ggaren@apple.com>

        Rubber stamped by Oliver Hunt.

        Reduced the max register file size from 8MB to 2MB.

        We still allow about 20,000 levels of recursion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-02 Alp Toker <alp@nuanti.com>
alp@webkit.org [Thu, 3 Jul 2008 03:31:13 +0000 (03:31 +0000)]
2008-07-02  Alp Toker  <alp@nuanti.com>

        Build fix for r34960. Add TreeProfile.cpp to build.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-02 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 3 Jul 2008 00:47:00 +0000 (00:47 +0000)]
2008-07-02  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Optimized a[n] get for cases where a is an array or a string, and a[n]
        put for cases where a is an array.

        SunSpider says 9.0% faster.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
bdakin@apple.com [Thu, 3 Jul 2008 00:10:13 +0000 (00:10 +0000)]
WebCore:

2008-07-02  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin.

        Fix for <rdar://problem/6015523> Implement ARIA ranges/sliders
        and
        <rdar://problem/5934355> Need to implement ARIA role="spinbutton"

        * page/AccessibilityObject.h:
        (WebCore::AccessibilityObject::isSlider):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::isSlider):
        (WebCore::AccessibilityRenderObject::valueForRange):
        (WebCore::AccessibilityRenderObject::maxValueForRange):
        (WebCore::AccessibilityRenderObject::minValueForRange):
        (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): We
        were addressing the generic has-an-ARIA-role case too early here.
        (WebCore::AccessibilityRenderObject::focusedUIElement): This is a
        bug I ran into while testing role='spinbutton', spinbutton is a
        role that can have an active descendant. But we were always trying
        to forward focus to the active descendant, even if one was not
        specified.
        (WebCore::AccessibilityRenderObject::shouldFocusActiveDescendant):
        'spinbutton' maps to ProgressIndicatorRole.
        (WebCore::RoleEntry::):
        (WebCore::AccessibilityRenderObject::canSetValueAttribute):
        * page/AccessibilityRenderObject.h:
        * page/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

2008-07-02  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin.

        Tests for <rdar://problem/6015523> Implement ARIA ranges/sliders
        and
        <rdar://problem/5934355> Need to implement ARIA role="spinbutton"

        * accessibility/aria-range-expected.txt: Added.
        * accessibility/aria-range.html: Added.
        * accessibility/aria-slider-expected.txt: Added.
        * accessibility/aria-slider.html: Added.
        * accessibility/aria-spinbutton-expected.txt: Added.
        * accessibility/aria-spinbutton.html: Added.

        This test used to have a section for slider. It was a mistake for
        that to be checked in since slider was not implemented until not.
        * accessibility/aria-roles-expected.txt:
        * accessibility/aria-roles.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-02 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Thu, 3 Jul 2008 00:05:26 +0000 (00:05 +0000)]
2008-07-02  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Darin.

        -Small cleanup in preparation for implementing Bottom-up.

        * profiler/CallIdentifier.h: Rename debug function to make it clear of
        its output and intention to be debug only.
        (KJS::CallIdentifier::operator const char* ): Implement in terms of
        c_str.
        (KJS::CallIdentifier::c_str):
        * profiler/ProfileNode.cpp: Impelment findChild() which will be needed
        by the bottom-up implementation.
        (KJS::ProfileNode::findChild):
        * profiler/ProfileNode.h: Added comments to make the collections of
        functions more clear.
        (KJS::ProfileNode::operator==):
        (KJS::ProfileNode::c_str):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-02 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Thu, 3 Jul 2008 00:04:19 +0000 (00:04 +0000)]
2008-07-02  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Darin.

        Bug 19776: Number.toExponential() is incorrect for numbers between 0.1 and 1
        <https://bugs.webkit.org/show_bug.cgi?id=19776>

        Perform the sign check for the exponent on the actual exponent value,
        which is 1 less than the value of decimalPoint, instead of on the value
        of decimalPoint itself.

        JavaScriptCore:

        * kjs/NumberPrototype.cpp:
        (KJS::exponentialPartToString):

        LayoutTests:

        * fast/js/number-toExponential-expected.txt:
        * fast/js/resources/number-toExponential.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-02 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Wed, 2 Jul 2008 22:50:17 +0000 (22:50 +0000)]
2008-07-02  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Darin.

        <rdar://problem/5951532> JSProfiler: Implement Bottom-Up view (19228)
        - Subclass TreeProfile as I prepare for a HeavyProfile to be comming
        later.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * profiler/Profile.cpp: By default we create a TreeProfile.
        (KJS::Profile::create):
        * profiler/Profile.h: Changes to the Profile class to make it amenable
        to be inherited from.
        (KJS::Profile::~Profile):
        * profiler/TreeProfile.cpp: Added.
        (KJS::TreeProfile::create):
        (KJS::TreeProfile::TreeProfile):
        (KJS::TreeProfile::heavyProfile):
        * profiler/TreeProfile.h: Added.
        (KJS::TreeProfile::treeProfile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - try to fix the Windows build
mitz@apple.com [Wed, 2 Jul 2008 22:37:54 +0000 (22:37 +0000)]
    - try to fix the Windows build

        * WebScriptCallFrame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
mitz@apple.com [Wed, 2 Jul 2008 22:05:22 +0000 (22:05 +0000)]
    Reviewed by Adam Roben.

        - Windows build fix

        Renamed the ERROR token in the XPath grammar to XPATH_ERROR, because
        the ERROR macro is defined in <wingdi.h>.

        * xml/XPathGrammar.y:
        * xml/XPathParser.cpp:
        (WebCore::XPath::Parser::lexString):
        (WebCore::XPath::Parser::nextTokenInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-02 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Wed, 2 Jul 2008 17:40:29 +0000 (17:40 +0000)]
2008-07-02  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Dan.

        Broke CallIdentifier out into its own file. I did this because it's
        going to grow a lot soon and I wanted this to be a separate patch.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * profiler/CallIdentifier.h: Added.
        (KJS::CallIdentifier::CallIdentifier):
        (KJS::CallIdentifier::operator==):
        (KJS::CallIdentifier::operator!=):
        (KJS::CallIdentifier::operator const char* ):
        (KJS::CallIdentifier::toString):
        * profiler/ProfileNode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Inspired and reviewed by Mark Rowe.
ap@webkit.org [Wed, 2 Jul 2008 12:00:11 +0000 (12:00 +0000)]
    Inspired and reviewed by Mark Rowe.

        Change non-API includes from JavaScriptCore/ to kjs/ and wtf/ to match prevalent style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Gtk build
hausmann@webkit.org [Wed, 2 Jul 2008 11:42:15 +0000 (11:42 +0000)]
Fix the Gtk build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fixes
vestbo@webkit.org [Wed, 2 Jul 2008 11:28:43 +0000 (11:28 +0000)]
Build fixes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix https://bugs.webkit.org/show_bug.cgi?id=19850
mrowe@apple.com [Wed, 2 Jul 2008 11:18:29 +0000 (11:18 +0000)]
Fix https://bugs.webkit.org/show_bug.cgi?id=19850
Bug 19850: REGRESSION (r34887): SVGEllipseElement-dom-cx-attr.html and SVGEllipseElement-svgdom-cx-prop.html are failing

Rubber-stamped by Oliver Hunt.

Update the coordinates used when clicking to initiate the test so that the test does not fail on Tiger.

* svg/dynamic-updates/resources/SVGEllipseElement-dom-cx-attr.js:
* svg/dynamic-updates/resources/SVGEllipseElement-svgdom-cx-prop.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-02 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Wed, 2 Jul 2008 10:08:22 +0000 (10:08 +0000)]
2008-07-02  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Add a test for a situation mentioned in:

        Bug 19523: delete does not work in javascript
        <https://bugs.webkit.org/show_bug.cgi?id=19523>

        * fast/js/delete-multiple-global-blocks-expected.txt: Added.
        * fast/js/delete-multiple-global-blocks.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix.
ap@webkit.org [Wed, 2 Jul 2008 09:23:35 +0000 (09:23 +0000)]
    Build fix.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::start):
        (WebCore::getString):
        (WebCore::PluginView::performRequest):
        (WebCore::PluginView::bindingInstance):
        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginView::dispatchNPEvent):
        (WebCore::PluginView::setNPWindowRect):
        (WebCore::PluginView::stop):
        Pass false to JSLock and JSLock::DropAllLocks constructors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Another non-AllInOne build fix.
ap@webkit.org [Wed, 2 Jul 2008 07:57:56 +0000 (07:57 +0000)]
    Another non-AllInOne build fix.

        * kjs/JSGlobalObject.cpp: Include JSLock.h here, too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/5974306> CanvasRenderingContext2D becomes invalid when source canvas...
oliver@apple.com [Wed, 2 Jul 2008 07:35:27 +0000 (07:35 +0000)]
<rdar://problem/5974306> CanvasRenderingContext2D becomes invalid when source canvas element is collected

Reviewed by Geoff Garen.

In order to fix this we now make the rendering context and the canvas element
share the same reference count, ensuring that references to the rendering
context will force the canvas element to remain live as well.

Test: fast/canvas/canvas-longlived-context.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Non-AllInOne build fix.
ap@webkit.org [Wed, 2 Jul 2008 07:33:38 +0000 (07:33 +0000)]
    Non-AllInOne build fix.

        * kjs/interpreter.cpp: Include JSLock.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap@webkit.org [Wed, 2 Jul 2008 07:00:53 +0000 (07:00 +0000)]
    Reviewed by Darin.

        Disable JSLock for per-thread contexts.

        No change on SunSpider.

        * kjs/JSGlobalData.h:
        * kjs/JSGlobalData.cpp:
        (KJS::JSGlobalData::JSGlobalData):
        (KJS::JSGlobalData::sharedInstance):
        Added isSharedInstance as a better way to tell whether the instance is shared (legacy).

        * kjs/JSLock.cpp:
        (KJS::createJSLockCount):
        (KJS::JSLock::lockCount):
        (KJS::setLockCount):
        (KJS::JSLock::JSLock):
        (KJS::JSLock::lock):
        (KJS::JSLock::unlock):
        (KJS::JSLock::currentThreadIsHoldingLock):
        (KJS::JSLock::DropAllLocks::DropAllLocks):
        (KJS::JSLock::DropAllLocks::~DropAllLocks):
        * kjs/JSLock.h:
        (KJS::JSLock::JSLock):
        (KJS::JSLock::~JSLock):
        Made JSLock and JSLock::DropAllLocks constructors take a parameter to decide whether to
        actually lock a mutex, or only to increment recursion count. We cannot turn it into no-op
        if we want to keep existing assertions working.
        Made recursion count per-thread, now that locks may not lock.

        * API/JSBase.cpp:
        (JSEvaluateScript): Take JSLock after casting JSContextRef to ExecState* (which doesn't need
        locking in any case), so that a decision whether to actually lock can be made.
        (JSCheckScriptSyntax): Ditto.
        (JSGarbageCollect): Only lock while collecting the shared heap, not the per-thread one.

        * API/JSObjectRef.cpp:
        (JSClassCreate): Don't lock, as there is no reason to.
        (JSClassRetain): Ditto.
        (JSClassRelease): Ditto.
        (JSPropertyNameArrayRetain): Ditto.
        (JSPropertyNameArrayRelease): Only lock while deleting the array, as that may touch
        identifier table.
        (JSPropertyNameAccumulatorAddName): Adding a string also involves an identifier table
        lookup, and possibly modification.

        * API/JSStringRef.cpp:
        (JSStringCreateWithCharacters):
        (JSStringCreateWithUTF8CString):
        (JSStringRetain):
        (JSStringRelease):
        (JSStringGetUTF8CString):
        (JSStringIsEqual):
        * API/JSStringRefCF.cpp:
        (JSStringCreateWithCFString):
        JSStringRef operations other than releasing do not need locking.

        * VM/Machine.cpp: Don't include unused JSLock.h.

        * kjs/CollectorHeapIntrospector.cpp: (KJS::CollectorHeapIntrospector::statistics):
        Don't take the lock for real, as heap introspection pauses the process anyway. It seems that
        the existing code could cause deadlocks.

        * kjs/Shell.cpp:
        (functionGC):
        (main):
        (jscmain):
        The test tool uses a per-thread context, so no real locking is required.

        * kjs/collector.h:
        (KJS::Heap::setGCProtectNeedsLocking): Optionally protect m_protectedValues access with a
        per-heap mutex. This is only needed for WebCore Database code, which violates the "no data
        migration between threads" by using ProtectedPtr on a background thread.
        (KJS::Heap::isShared): Keep a shared flag here, as well.

        * kjs/protect.h:
        (KJS::::ProtectedPtr):
        (KJS::::~ProtectedPtr):
        (KJS::::operator):
        (KJS::operator==):
        (KJS::operator!=):
        ProtectedPtr is ony used from WebCore, so it doesn't need to take JSLock. An assertion in
        Heap::protect/unprotect guards agains possible future unlocked uses of ProtectedPtr in JSC.

        * kjs/collector.cpp:
        (KJS::Heap::Heap): Initialize m_isShared.
        (KJS::Heap::~Heap): No need to lock for real during destruction, but must keep assertions
        in sweep() working.
        (KJS::destroyRegisteredThread): Registered thread list is only accessed for shared heap,
        so locking is always needed here.
        (KJS::Heap::registerThread): Ditto.
        (KJS::Heap::markStackObjectsConservatively): Use m_isShared instead of comparing to a shared
        instance for a small speedup.
        (KJS::Heap::setGCProtectNeedsLocking): Create m_protectedValuesMutex. There is currently no
        way to undo this - and ideally, Database code will be fixed to lo longer require this quirk.
        (KJS::Heap::protect): Take m_protectedValuesMutex (if it exists) while accessing
        m_protectedValues.
        (KJS::Heap::unprotect): Ditto.
        (KJS::Heap::markProtectedObjects): Ditto.
        (KJS::Heap::protectedGlobalObjectCount): Ditto.
        (KJS::Heap::protectedObjectCount): Ditto.
        (KJS::Heap::protectedObjectTypeCounts): Ditto.

        * kjs/ustring.cpp:
        * kjs/ustring.h:
        Don't include JSLock.h, which is no longer used here. As a result, an explicit include had
        to be added to many files in JavaScriptGlue, WebCore and WebKit.

        * kjs/JSGlobalObject.cpp:
        (KJS::JSGlobalObject::init):
        * API/JSCallbackConstructor.cpp:
        (KJS::constructJSCallback):
        * API/JSCallbackFunction.cpp:
        (KJS::JSCallbackFunction::call):
        * API/JSCallbackObjectFunctions.h:
        (KJS::::init):
        (KJS::::getOwnPropertySlot):
        (KJS::::put):
        (KJS::::deleteProperty):
        (KJS::::construct):
        (KJS::::hasInstance):
        (KJS::::call):
        (KJS::::getPropertyNames):
        (KJS::::toNumber):
        (KJS::::toString):
        (KJS::::staticValueGetter):
        (KJS::::callbackGetter):
        * API/JSContextRef.cpp:
        (JSGlobalContextCreate):
        (JSGlobalContextRetain):
        (JSGlobalContextRelease):
        * API/JSValueRef.cpp:
        (JSValueIsEqual):
        (JSValueIsStrictEqual):
        (JSValueIsInstanceOfConstructor):
        (JSValueMakeNumber):
        (JSValueMakeString):
        (JSValueToNumber):
        (JSValueToStringCopy):
        (JSValueToObject):
        (JSValueProtect):
        (JSValueUnprotect):
        * JavaScriptCore.exp:
        * kjs/PropertyNameArray.h:
        (KJS::PropertyNameArray::globalData):
        * kjs/interpreter.cpp:
        (KJS::Interpreter::checkSyntax):
        (KJS::Interpreter::evaluate):
        Pass a parameter to JSLock/JSLock::DropAllLocks to decide whether the lock needs to be taken.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap@webkit.org [Wed, 2 Jul 2008 06:35:03 +0000 (06:35 +0000)]
    Reviewed by Darin.

        https://bugs.webkit.org/show_bug.cgi?id=19834
        Failed assertion in JavaScriptCore/VM/SegmentedVector.h:82

        Creating a global object with a custom prototype resets it twice (wasteful!).
        So, addStaticGlobals() was called twice, but JSGlobalObject::reset() didn't reset
        the register array.

        * kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::reset): Call setRegisterArray(0, 0).

        * kjs/JSVariableObject.h: Changed registerArray to OwnArrayPtr. Also, added private copy
        constructor and operator= to ensure that no one attempts to copy this object (for whatever
        reason, I couldn't make Noncopyable work).

        * kjs/JSGlobalObject.h: (KJS::JSGlobalObject::addStaticGlobals): Allocate registerArray
        with new[].

        * kjs/JSVariableObject.cpp:
        (KJS::JSVariableObject::copyRegisterArray): Allocate registerArray with new[].
        (KJS::JSVariableObject::setRegisterArray): Avoid hitting an assertion in OwnArrayPtr when
        "changing" the value from 0 to 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-01 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 2 Jul 2008 05:39:23 +0000 (05:39 +0000)]
2008-07-01  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Removed and/or reordered exception checks in array-style a[n] access.

        SunSpider says 1.4% faster.

        * VM/Machine.cpp:
        (KJS::Machine::privateExecute): No need to check for exceptions before
        calling toString, toNumber and/or get. If the call ends up being observable
        through toString, valueOf, or a getter, we short-circuit it there, instead.
        In the op_del_by_val case, I removed the incorrect comment without actually
        removing the code, since I didn't want to tempt the GCC fates!

        * kjs/JSObject.cpp:
        (KJS::callDefaultValueFunction): Added exception check to prevent
        toString and valueOf functions from observing execution after an exception
        has been thrown. This removes some of the burden of exception checking
        from the machine.

        (KJS::JSObject::defaultValue): Removed redundant exception check here.

        * kjs/PropertySlot.cpp:
        (KJS::PropertySlot::functionGetter): Added exception check to prevent
        getter functions from observing execution after an exception has been
        thrown. This removes some of the burden of exception checking from the
        machine.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver Hunt.
mitz@apple.com [Wed, 2 Jul 2008 04:28:11 +0000 (04:28 +0000)]
    Reviewed by Oliver Hunt.

        - fix a CSSParserValueList leak seen on the build bot

        * css/CSSParser.cpp:
        (WebCore::BorderImageParseContext::commitBorderImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-01 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 2 Jul 2008 04:21:43 +0000 (04:21 +0000)]
2008-07-01  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Optimized a[n] get and put for cases where n is an immediate unsigned
        value.

        SunSpider says 3.5% faster.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-01 Alex Mathews <possessedpenguinbob@gmail.com>
oliver@apple.com [Wed, 2 Jul 2008 03:27:42 +0000 (03:27 +0000)]
2008-07-01  Alex Mathews  <possessedpenguinbob@gmail.com>

Reviewed by Oliver Hunt.

Prep for more Filter class name changes. Added the first few files for
the new Filter architecture to come.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate the path to the configuration file.
mrowe@apple.com [Wed, 2 Jul 2008 02:12:59 +0000 (02:12 +0000)]
Update the path to the configuration file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-01 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Wed, 2 Jul 2008 01:08:30 +0000 (01:08 +0000)]
2008-07-01  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Darin.

        Bug 19844: JavaScript Switch statement modifies "this"
        <https://bugs.webkit.org/show_bug.cgi?id=19844>

        Use a temporary when generating code for switch clauses to avoid
        overwriting 'this' or a local variable.

        JavaScriptCore:

        * kjs/nodes.cpp:
        (KJS::CaseBlockNode::emitCodeForBlock):

        LayoutTests:

        * fast/js/codegen-temporaries-expected.txt:
        * fast/js/resources/codegen-temporaries.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Bump version numbers.
sfalken@apple.com [Wed, 2 Jul 2008 00:11:45 +0000 (00:11 +0000)]
    Bump version numbers.

        Reviewed by Mark Rowe.

        * win/tools/scripts/PRODUCTVERSION:
        * win/tools/scripts/VERSION:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoGtk+ build fix.
christian@webkit.org [Wed, 2 Jul 2008 00:08:03 +0000 (00:08 +0000)]
Gtk+ build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
kmccullough@apple.com [Tue, 1 Jul 2008 23:46:05 +0000 (23:46 +0000)]
JavaScriptCore:

2008-07-01  Kevin McCullough  <kmccullough@apple.com>

        Build fix.

        * JavaScriptCore.xcodeproj/project.pbxproj:

WebKit/mac:

2008-07-01  Kevin McCullough  <kmccullough@apple.com>

        Build fix.

        * WebView/WebView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca@apple.com [Tue, 1 Jul 2008 23:44:00 +0000 (23:44 +0000)]
WebCore:

2008-07-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Add PluginMainThreadScheduler.{cpp|h} to build.

        * WebCore.base.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * plugins/PluginMainThreadScheduler.cpp:

WebKit/mac:

2008-07-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Use the PluginMainThreadScheduler, and implement NPN_PluginThreadAsyncCall.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView _createPlugin]):
        Register the plug-in instance.

        (-[WebBaseNetscapePluginView _destroyPlugin]):
        Unegister the plug-in instance.

        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage load]):
        Set NPN_PluginThreadAsyncCall.

        * Plugins/npapi.mm:
        (NPN_PluginThreadAsyncCall):
        Implement this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Tue, 1 Jul 2008 22:34:44 +0000 (22:34 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - move the method to set the base writing direction from Frame to Editor

        * WebCore.base.exp: Updated.
        * editing/Editor.cpp:
        (WebCore::Editor::setBaseWritingDirection): Changed the parameter to a
        WritingDirection enum value and added the special behavior when the
        focused node is a text field or a text area.
        * editing/Editor.h:
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected): Changed back
        to call the Editor method.
        * page/Frame.cpp: Removed setSelectionBaseWritingDirection().
        * page/Frame.h:

WebKit/mac:

        Reviewed by Darin Adler.

        - WebKit part of moving the method to set the base writing direction from Frame to Editor

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView toggleBaseWritingDirection:]): Changed back to call the
        Editor method.
        (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
        (-[WebHTMLView _changeBaseWritingDirectionTo:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-01 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 1 Jul 2008 22:21:12 +0000 (22:21 +0000)]
2008-07-01  Darin Adler  <darin@apple.com>

        Reviewed by Oliver.

        - slight tweak of the setHash fix

        * bindings/js/JSLocationCustom.cpp:
        (WebCore::JSLocation::setHash): Use oldRef instead of recomputing url.ref().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
mitz@apple.com [Tue, 1 Jul 2008 22:19:01 +0000 (22:19 +0000)]
JavaScriptCore:

        Reviewed by Anders Carlsson.

        - Mac release build fix

        * JavaScriptCore.exp:

WebCore:

        Reviewed by Anders Carlsson.

        - Mac release build fix

        * page/Console.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders Carlsson.
mitz@apple.com [Tue, 1 Jul 2008 21:20:04 +0000 (21:20 +0000)]
    Reviewed by Anders Carlsson.

        - fix <rdar://problem/6045896> REGRESSION: Leak in WebCore::StringImpl::create

        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::cleanup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-01 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 1 Jul 2008 21:11:32 +0000 (21:11 +0000)]
2008-07-01  Sam Weinig  <sam@webkit.org>

        Try and fix mac builds.

        * JavaScriptCore.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-01 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 1 Jul 2008 21:06:30 +0000 (21:06 +0000)]
2008-07-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Jon.

        Don't add the Mozilla user agent quirk for Flash 10.

        * plugins/win/PluginPackageWin.cpp:
        (WebCore::PluginPackage::isPluginBlacklisted):
        (WebCore::PluginPackage::determineQuirks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Move data: URL parsing code in HTMLObjectElement to KURL
ddkilzer@apple.com [Tue, 1 Jul 2008 20:06:29 +0000 (20:06 +0000)]
    Move data: URL parsing code in HTMLObjectElement to KURL

        Reviewed by Ada and Darin.

        No test cases added since there is no change in behavior.

        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::isImageType): Extracted data: URL
        parsing code into WebCore::mimeTypeFromDataURL() in KURL.cpp.
        * platform/KURL.cpp:
        (WebCore::mimeTypeFromDataURL): Added.
        * platform/KURL.h:
        (WebCore::mimeTypeFromDataURL): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Dave Hyatt.
mitz@apple.com [Tue, 1 Jul 2008 19:08:15 +0000 (19:08 +0000)]
    Reviewed by Dave Hyatt.

        - fix <rdar://problem/6045890> REGRESSION: Leak in WebCore::CSSParser::createFloatingValueList()

        * css/CSSParser.cpp:
        (WebCore::CSSParser::addUnresolvedProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-01 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Tue, 1 Jul 2008 19:05:23 +0000 (19:05 +0000)]
2008-07-01  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Brady Eidson.

        Bug 19822: REGRESSION (r30243): setting location.hash to "#" causes a reload
        <https://bugs.webkit.org/show_bug.cgi?id=19822>

        Change JSLocation::setHash() to not schedule navigation in the case
        where the old fragment is the null String and the new fragment is an
        empty String.

        WebCore:

        * bindings/js/JSLocationCustom.cpp:
        (WebCore::JSLocation::setHash):

        LayoutTests:

        * http/tests/loading/location-hash-reload-cycle-expected.txt: Added.
        * http/tests/loading/location-hash-reload-cycle.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 1 Jul 2008 18:31:22 +0000 (18:31 +0000)]
2008-06-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Add PluginMainThreadScheduler, a singleton which is responsible for scheduling plug-in
        callbacks on the main thread. Use this to implement NPN_PluginThreadAsyncCall on Windows.

        * WebCore.vcproj/WebCore.vcproj:
        Add PluginMainThreadScheduler.{cpp|h}

        * plugins/PluginMainThreadScheduler.cpp: Added.
        * plugins/PluginMainThreadScheduler.h: Added.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::start):
        Register with the thread scheduler.

        * plugins/npapi.cpp:
        (NPN_PluginThreadAsyncCall):
        Call the thread scheduler.

        * plugins/win/PluginPackageWin.cpp:
        (WebCore::PluginPackage::load):
        Initialize the NPN_PluginThreadAsyncCall callback.

        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginView::stop):
        Unregister with the scheduler. This makes sure that we won't try to deliver callbacks
        after the plug-in has been destroyed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRoll out r34913, as it broke the Windows build due to bad casting
aroben@apple.com [Tue, 1 Jul 2008 18:02:55 +0000 (18:02 +0000)]
Roll out r34913, as it broke the Windows build due to bad casting

WebCore:

        Roll out r34913, as it broke the Windows build due to bad casting

        r34913 introduced code that assigned pointers-to-member from a derived
        class into a base class pointer-to-member type (e.g., assigned a void
        (SVGUseElement::*)() into a void (SVGElement::*)()). This is bad
        because it could allow us to call SVGUseElement member functions on a
        different SVGElement-derived class. MSVC rightly flagged this as an
        error.

        Rubberstamped by Anders Carlsson.

LayoutTests:

        Roll out r34913, as it broke the Windows build due to bad casting

        Rubberstamped by Anders Carlsson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-01 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 1 Jul 2008 17:56:47 +0000 (17:56 +0000)]
2008-07-01  Darin Adler  <darin@apple.com>

        - fix build

        * bindings/scripts/CodeGeneratorJS.pm: Fix warnings that indicate this was
        not working propertly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
mitz@apple.com [Tue, 1 Jul 2008 17:46:35 +0000 (17:46 +0000)]
    Reviewed by Darin Adler.

        - fix <rdar://problem/6045893> REGRESSION: Leak in WebCore::HTMLCanvasElement::createPlatformImage() const

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::createPattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-01 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 1 Jul 2008 17:39:46 +0000 (17:39 +0000)]
2008-07-01  Sam Weinig  <sam@webkit.org>

        Fix non-AllInOne builds.

        * kjs/DateMath.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
weinig@apple.com [Tue, 1 Jul 2008 17:32:44 +0000 (17:32 +0000)]
JavaScriptCore:

2008-07-01  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Split JSCell and JSNumberCell class declarations out of JSValue.h

        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:
        * VM/JSPropertyNameIterator.h:
        * kjs/AllInOneFile.cpp:
        * kjs/JSCell.cpp: Copied from JavaScriptCore/kjs/JSValue.cpp.
        * kjs/JSCell.h: Copied from JavaScriptCore/kjs/JSValue.h.
        (KJS::JSValue::getJSNumber):
        * kjs/JSNumberCell.cpp:
        * kjs/JSNumberCell.h: Copied from JavaScriptCore/kjs/JSValue.h.
        * kjs/JSObject.h:
        * kjs/JSString.cpp:
        (KJS::jsString):
        (KJS::jsOwnedString):
        * kjs/JSString.h:
        (KJS::JSValue::toThisJSString):
        * kjs/JSValue.cpp:
        * kjs/JSValue.h:

WebCore:

2008-07-01  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Split JSCell and JSNumberCell class declarations out of JSValue.h

        * ForwardingHeaders/kjs/JSNumberCell.h: Added.
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/c/c_instance.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/6041580> REGRESSION: AX: AXSize of radio buttons is 0,0
cfleizach@apple.com [Tue, 1 Jul 2008 17:27:37 +0000 (17:27 +0000)]
<rdar://problem/6041580> REGRESSION: AX: AXSize of radio buttons is 0,0

Fixed incorrect AXSize of radio buttons and checkboxes when they don't have labels

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-01 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 1 Jul 2008 16:42:31 +0000 (16:42 +0000)]
2008-07-01  Anders Carlsson  <andersca@apple.com>

        Build fixes.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * kjs/JSGlobalObject.h:
        (KJS::JSGlobalObject::addStaticGlobals):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Antti Koivisto.
mitz@apple.com [Tue, 1 Jul 2008 14:40:49 +0000 (14:40 +0000)]
    Reviewed by Antti Koivisto.

        - fix SVG pointer-events layout test failures

        * css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-01 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Tue, 1 Jul 2008 14:29:52 +0000 (14:29 +0000)]
2008-07-01  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon.

        Don't show the tooltip instantly in the QtLauncher.

        Let the QWebView handle tooltips by itself, so we get
        the expected delay as everywhere else.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Antti.
zimmermann@webkit.org [Tue, 1 Jul 2008 12:21:28 +0000 (12:21 +0000)]
Reviewed by Antti.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=19841
Fix two small problems in the gradient & pattern code.

Added 12 new layout tests: svg/dynamic-updates/SVGLinearGradientElement*.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-01 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Tue, 1 Jul 2008 12:15:54 +0000 (12:15 +0000)]
2008-07-01  Simon Hausmann  <hausmann@webkit.org>

        Fix the build, include SVGTransformList.h instead of
        SVGTransformlist.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Antti.
ap@webkit.org [Tue, 1 Jul 2008 12:01:38 +0000 (12:01 +0000)]
    Reviewed by Antti.

        <rdar://problem/6033080> REGRESSION: Some CH characters display as garbage on webpage for
        the first time.

        Test: fast/encoding/preload-encoding.html

        * html/PreloadScanner.cpp:
        (WebCore::PreloadScanner::tokenize): Reset charset when entering a tag, not just when
        starting a load.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Antti & Eric.
zimmermann@webkit.org [Tue, 1 Jul 2008 11:33:57 +0000 (11:33 +0000)]
Reviewed by Antti & Eric.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=17779 (SVG 1.1 Errata demands "SVG JavaScript Liveness" support)

SVG Errata states: "All SVG DOM objects that directly correspond to an
attribute, e.g. the SVGAnimatedLength 'ry' in an SVGRectElement, are live. This
means that any changes made to the attribute are immediately reflected in the
corresponding SVG DOM object." (see linked URL on bug report)

Until now only XML -> SVG DOM changes took affect, aka. changing the 'rx' attribute of a <rect>
element resuted in changes when accessing 'rx' through SVG DOM (rx.baseVal.value).

Add a new synchronization layer to handle SVG DOM -> XML changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoClass name changes for SVG Light Effect files.
oliver@apple.com [Tue, 1 Jul 2008 11:10:45 +0000 (11:10 +0000)]
Class name changes for SVG Light Effect files.

Reviewed by Nikolas Zimmermann.

The class names that changed :

SVGLightSource -> LightSource
SVGDistantLightSource -> DistantLightSource
SVGPointLightSource -> PointLightSource
SVGSpotLightSource -> SpotLightSource

Every other file that is changed is just propagating the class name changes to
dependent files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-01 Alp Toker <alp@nuanti.com>
alp@webkit.org [Tue, 1 Jul 2008 08:39:30 +0000 (08:39 +0000)]
2008-07-01  Alp Toker  <alp@nuanti.com>

        Rubber-stamped by Holger.

        autotools cleanup: move some GTK+-specific sources from libwebcore to
        libwebcoregtk.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver Hunt.
mitz@apple.com [Tue, 1 Jul 2008 08:19:03 +0000 (08:19 +0000)]
    Reviewed by Oliver Hunt.

        - fix the non-SVG build

        * css/CSSValueKeywords.in: Added 'all'.
        * css/SVGCSSValueKeywords.in: Removed 'all'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-07-01 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 1 Jul 2008 07:09:23 +0000 (07:09 +0000)]
2008-07-01  Geoffrey Garen  <ggaren@apple.com>

        Build fix: forgot to check in this file.

        * WebView/WebScriptDebugger.mm:
        (WebScriptDebugger::WebScriptDebugger):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fixes, include OwnPtr.h and DateInstance.h
hausmann@webkit.org [Tue, 1 Jul 2008 07:07:06 +0000 (07:07 +0000)]
Build fixes, include OwnPtr.h and DateInstance.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-30 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 1 Jul 2008 07:01:51 +0000 (07:01 +0000)]
2008-06-30  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Fixed a global object leak caused by the switch to one register file.

        Don't unconditionally mark the register file, since that logically
        makes all global variables GC roots, even when their global object is
        no longer reachable.

        Instead, make the global object associated with the register file
        responsible for marking the register file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-30 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 1 Jul 2008 05:45:21 +0000 (05:45 +0000)]
2008-06-30  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Removed the "registerBase" abstraction. Since the register file never
        reallocates, we can keep direct pointers into it, instead of
        <registerBase, offset> tuples.

        SunSpider says 0.8% faster.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
adele@apple.com [Tue, 1 Jul 2008 02:49:31 +0000 (02:49 +0000)]
WebCore:

2008-06-30  Adele Peterson  <adele@apple.com>

        Reviewed by Oliver.

        Fix for <rdar://problem/5882050> clicking in hidden close box area of empty searchfield causes mousedown to stop firing

        Test: fast/forms/search-hidden-cancel-button.html

        * html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler):
          Don't start capturing mouse events if the cancel button isn't visible.  This was causing the button to start but never stop capturing mouse events.

LayoutTests:

2008-06-30  Adele Peterson  <adele@apple.com>

        Reviewed by Oliver.

        Test for <rdar://problem/5882050> clicking in hidden close box area of empty searchfield causes mousedown to stop firing

        * fast/forms/search-hidden-cancel-button-expected.txt: Added.
        * fast/forms/search-hidden-cancel-button.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix build by adding all (hopefully) the missing includes.
oliver@apple.com [Tue, 1 Jul 2008 02:21:51 +0000 (02:21 +0000)]
Fix build by adding all (hopefully) the missing includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-30 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Tue, 1 Jul 2008 01:56:16 +0000 (01:56 +0000)]
2008-06-30  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Bug 19830: REGRESSION (r34883): Google Reader doesn't show up feed list on sidebar
        <https://bugs.webkit.org/show_bug.cgi?id=19830>

        Ensure that we do not eliminate a write to a local register when doing
        peephole optimizations.

        JavaScriptCore:

        * VM/CodeGenerator.cpp:
        (KJS::CodeGenerator::emitJumpIfTrue):
        (KJS::CodeGenerator::emitJumpIfFalse):

        LayoutTests:

        * fast/js/codegen-peephole-locals-expected.txt: Added.
        * fast/js/codegen-peephole-locals.html: Added.
        * fast/js/resources/codegen-peephole-locals.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixing * placement
adele@apple.com [Tue, 1 Jul 2008 01:18:32 +0000 (01:18 +0000)]
Fixing * placement

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
weinig@apple.com [Tue, 1 Jul 2008 01:11:22 +0000 (01:11 +0000)]
JavaScriptCore:

2008-06-30  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Darin Alder.

        Split InternalFunction into its own header file.

        * API/JSCallbackFunction.h:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/ArrayConstructor.h:
        * kjs/BooleanConstructor.h:
        * kjs/DateConstructor.h:
        * kjs/ErrorConstructor.h:
        * kjs/FunctionConstructor.h:
        * kjs/FunctionPrototype.h:
        * kjs/InternalFunction.h: Copied from kjs/JSFunction.h.
        * kjs/JSFunction.h:
        * kjs/NativeErrorConstructor.h:
        * kjs/NumberConstructor.h:
        * kjs/ObjectConstructor.h:
        * kjs/RegExpConstructor.h:
        * kjs/StringConstructor.h:
        * profiler/Profiler.cpp:

WebCore:

2008-06-30  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Darin Adler.

        Split InternalFunction into its own header file.

        * ForwardingHeaders/kjs/InternalFunction.h: Added.
        * bridge/runtime_method.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
adele@apple.com [Tue, 1 Jul 2008 00:47:01 +0000 (00:47 +0000)]
WebCore:

2008-06-30  Adele Peterson  <adele@apple.com>

        Reviewed by Anders.

        Fix for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas

        Test: editing/selection/select-all-textarea.html

        * dom/Node.cpp:
        (WebCore::Node::shadowAncestorNode): Break out code to find the root of the shadow tree into a new helper function.
        (WebCore::Node::shadowTreeRootNode): Added helper function.
        * dom/Node.h:
        * dom/Range.cpp: (WebCore::Range::shadowTreeRootNode): Added helper function.
        * dom/Range.h:
        * editing/Selection.cpp: (WebCore::Selection::shadowTreeRootNode): ditto.
        * editing/Selection.h:
        * editing/SelectionController.h: (WebCore::SelectionController::shadowTreeRootNode): ditto.
        * editing/SelectionController.cpp: (WebCore::SelectionController::selectAll):
        If the selection is in a shadow tree, only select the contents of that shadow tree, not the whole document.
        * page/Frame.cpp:
        (WebCore::Frame::findString): Use the new shadowTreeRootNode helper functions.
        (WebCore::Frame::markAllMatchesForText): ditto.

LayoutTests:

2008-06-30  Adele Peterson  <adele@apple.com>

        Reviewed by Anders.

        Test for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas

        * editing/selection/select-all-textarea-expected.txt: Added.
        * editing/selection/select-all-textarea.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/4180780> Add attribute to get all the radio buttons in a set
cfleizach@apple.com [Mon, 30 Jun 2008 23:05:44 +0000 (23:05 +0000)]
<rdar://problem/4180780> Add attribute to get all the radio buttons in a set

Adds ability for radio buttons to return an array of the other radio buttons in its radio group.
Updates DumpRenderTree to support the linked ui elements attribute

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-30 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 30 Jun 2008 22:52:55 +0000 (22:52 +0000)]
2008-06-30  Sam Weinig  <sam@webkit.org>

        Reviewed by Kevin McCullough.

        Remove empty files Instruction.cpp, LabelID.cpp, Register.cpp and RegisterID.cpp.

        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:
        * VM/Instruction.cpp: Removed.
        * VM/LabelID.cpp: Removed.
        * VM/Register.cpp: Removed.
        * VM/RegisterID.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-30 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 30 Jun 2008 22:43:07 +0000 (22:43 +0000)]
2008-06-30  Sam Weinig  <sam@webkit.org>

        Rubber-stamped (reluctantly) by Kevin McCullough.

        Rename date_object.h/cpp to DateInstance.h/cpp

        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:
        * kjs/AllInOneFile.cpp:
        * kjs/DateConstructor.cpp:
        * kjs/DateInstance.cpp: Copied from kjs/date_object.cpp.
        * kjs/DateInstance.h: Copied from kjs/date_object.h.
        * kjs/DatePrototype.cpp:
        * kjs/DatePrototype.h:
        * kjs/date_object.cpp: Removed.
        * kjs/date_object.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Mon, 30 Jun 2008 22:10:08 +0000 (22:10 +0000)]
WebCore:

        Reviewed by Adele Peterson.

        - WebCore part of <rdar://problem/3881497> Writing direction context menu item has no effect on text typed in Safari

        * WebCore.base.exp: Removed Editor::setBaseWritingDirection() and added
        Frame::setSelectionBaseWritingDirection().
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected): Changed to
        call Frame::setSelectionBaseWritingDirection().
        * page/Frame.cpp:
        (WebCore::Frame::setSelectionBaseWritingDirection): Added. If the
        focused node is a text field or text area, changes its 'dir' attribute.
        This is what IE does when the user changes the writing direction in a
        text control. Otherwise, calls down to Editor::setBaseWritingDirection().
        * page/Frame.h:

WebKit/mac:

        Reviewed by Adele Peterson.

        - WebKit/mac part of <rdar://problem/3881497> Writing direction context menu item has no effect on text typed in Safari

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView toggleBaseWritingDirection:]): Changed to call
        WebCore::Frame::setSelectionBaseWritingDirection() instead of
        WebCore::Editor::setBaseWritingDirection().
        (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
        (-[WebHTMLView _changeBaseWritingDirectionTo:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Improve HTMLObjectElement data encapsulation
ddkilzer@apple.com [Mon, 30 Jun 2008 21:12:55 +0000 (21:12 +0000)]
    Improve HTMLObjectElement data encapsulation

        Reviewed by Dave Hyatt.

        HTMLObjectElement has some public member variables that should be
        private with accessor methods.

        No test cases added since there is no change in behavior.

        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::HTMLObjectElement): Reorder
        initialization of member variables to match defined order in header.
        * html/HTMLObjectElement.h:
        (WebCore::HTMLObjectElement::classId): Added.
        (WebCore::HTMLObjectElement::url): Added.
        (WebCore::HTMLObjectElement::serviceType): Added.
        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::updateWidget): Use new accessor methods
        in HTMLObjectElement now that its member variables are private.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders Carlsson.
mitz@apple.com [Mon, 30 Jun 2008 21:09:14 +0000 (21:09 +0000)]
    Reviewed by Anders Carlsson.

        - remove unused member variable

        * page/Page.h: Removed Page::m_focusedNode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-06-30 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 30 Jun 2008 20:52:03 +0000 (20:52 +0000)]
2008-06-30  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Darin Adler.

        Remove internal.cpp and move its contents to there own .cpp files.

        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:
        * kjs/AllInOneFile.cpp:
        * kjs/GetterSetter.cpp: Copied from kjs/internal.cpp.
        * kjs/InternalFunction.cpp: Copied from kjs/internal.cpp.
        * kjs/JSNumberCell.cpp: Copied from kjs/internal.cpp.
        * kjs/JSString.cpp: Copied from kjs/internal.cpp.
        * kjs/JSString.h:
        * kjs/LabelStack.cpp: Copied from kjs/internal.cpp.
        * kjs/NumberConstructor.cpp:
        * kjs/NumberObject.cpp:
        (KJS::constructNumber):
        (KJS::constructNumberFromImmediateNumber):
        * kjs/internal.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34893 268f45cc-cd09-0410-ab3c-d52691b4dbfc