darin@apple.com [Tue, 3 Feb 2009 00:07:22 +0000 (00:07 +0000)]
2009-02-02 Darin Adler <darin@apple.com>
Reviewed by Anders Carlsson.
Bug 23694: REGRESSION: Running svg/custom tests crashes, randomly, depending on the order of tests
https://bugs.webkit.org/show_bug.cgi?id=23694
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::insertedIntoDocument): Added back the call through to EventTargetNode.
(WebCore::ContainerNode::removedFromDocument): Ditto.
* dom/EventTargetNode.cpp:
(WebCore::EventTargetNode::insertedIntoDocument): Changed this to not call through to Node.
(WebCore::EventTargetNode::removedFromDocument): Ditto.
* dom/Node.cpp:
(WebCore::Node::insertedIntoDocument): Updated comment.
(WebCore::Node::removedFromDocument): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40499
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 2 Feb 2009 23:57:41 +0000 (23:57 +0000)]
2009-02-02 Anders Carlsson <andersca@apple.com>
Build fix.
* WebView/WebHTMLView.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40498
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 2 Feb 2009 23:48:20 +0000 (23:48 +0000)]
WebCore:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
More plug-in cleanup.
* WebCore.NPAPI.exp:
Add new symbols.
* bindings/objc/DOM.mm:
* bindings/objc/DOMPrivate.h:
Remove methods that WebKit doesn't use anymore.
WebKit:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Remove WebKitPluginContainerView.{h|mm}, they aren't used anywhere.
* WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Make WebBaseNetscapePluginView hold a reference to a HTMLPlugInElement instead of a DOMElement.
* Plugins/Hosted/WebHostedNetscapePluginView.h:
* Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
* Plugins/WebBaseNetscapePluginView.h:
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
(-[WebBaseNetscapePluginView _windowClipRect]):
(-[WebBaseNetscapePluginView visibleRect]):
(-[WebBaseNetscapePluginView dataSource]):
* Plugins/WebKitPluginContainerView.h: Removed.
* Plugins/WebKitPluginContainerView.mm: Removed.
* Plugins/WebNetscapePluginView.h:
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
(-[WebNetscapePluginView getVariable:value:]):
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40497
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 2 Feb 2009 23:44:23 +0000 (23:44 +0000)]
2009-02-02 Anders Carlsson <andersca@apple.com>
Build fix.
* WebCoreSupport/FrameLoaderClientGtk.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40496
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 2 Feb 2009 23:30:00 +0000 (23:30 +0000)]
2009-02-02 Anders Carlsson <andersca@apple.com>
Fix build.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createPlugin):
* WebCoreSupport/WebFrameLoaderClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40495
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 2 Feb 2009 23:07:53 +0000 (23:07 +0000)]
2009-02-02 Jay Campan <jcampan@chromium.org>
Reviewed by Eric Seidel.
Clean up PopupMenuChromium a little.
https://bugs.webkit.org/show_bug.cgi?id=23653
No functional changes, only code cleanup, thus no tests.
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::):
(WebCore::PopupListBox::PopupListBox):
(WebCore::PopupContainer::create):
(WebCore::PopupContainer::PopupContainer):
(WebCore::PopupContainer::showPopup):
(WebCore::PopupListBox::handleKeyEvent):
(WebCore::PopupListBox::isSelectableItem):
(WebCore::PopupListBox::selectNextRow):
(WebCore::PopupListBox::selectPreviousRow):
(WebCore::PopupMenu::show):
* platform/chromium/PopupMenuChromium.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40494
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 2 Feb 2009 22:36:17 +0000 (22:36 +0000)]
WebCore:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Change createPlugin to take a HTMLPlugInElement, and createJavaAppletWidget to take a HTMLAppletElement.
* WebCore.xcodeproj/project.pbxproj:
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::createPlugin):
(WebCore::EmptyFrameLoaderClient::createJavaAppletWidget):
* loader/FrameLoader.cpp:
(WebCore::toPlugInElement):
(WebCore::FrameLoader::loadPlugin):
(WebCore::FrameLoader::loadItem):
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
WebKit/gtk:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Update for changes to WebCore.
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::createPlugin):
(WebKit::FrameLoaderClient::createJavaAppletWidget):
* WebCoreSupport/FrameLoaderClientGtk.h:
WebKit/mac:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Update for changes to WebCore.
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin):
WebKit/qt:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Update for changes to WebCore.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createPlugin):
(WebCore::FrameLoaderClientQt::createJavaAppletWidget):
* WebCoreSupport/FrameLoaderClientQt.h:
WebKit/win:
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Update for changes to WebCore.
* WebFrame.cpp:
(WebFrame::createJavaAppletWidget):
* WebFrame.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40493
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Mon, 2 Feb 2009 22:10:54 +0000 (22:10 +0000)]
Adding bug URL for a recent check-in.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40492
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos@webkit.org [Mon, 2 Feb 2009 21:48:30 +0000 (21:48 +0000)]
Fix shouldLoadAsEmptyDocument() to return a blank page for an empty
url or about:blank
Applies to Torch Mobile platform only right now, as per request.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40491
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Mon, 2 Feb 2009 21:35:02 +0000 (21:35 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40490
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
christian@webkit.org [Mon, 2 Feb 2009 21:15:53 +0000 (21:15 +0000)]
2009-02-02 Christian Dywan <christian@twotoasts.de>
Rubber-stamped by Holger Freyther.
Don't require Geolocation by default.
* configure.ac:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40489
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 2 Feb 2009 20:59:42 +0000 (20:59 +0000)]
2009-02-02 Darin Adler <darin@apple.com>
Try to fix Wx build, and maybe Chromium build too.
* WebCore.scons: Added IdentifierRep.cpp.
* WebCoreSources.bkl: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40488
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 2 Feb 2009 20:55:02 +0000 (20:55 +0000)]
2009-02-02 Darin Adler <darin@apple.com>
Try to fix Wx build.
* html/HTMLAreaElement.cpp: Added missing include of "Path.h".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40487
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Mon, 2 Feb 2009 20:46:48 +0000 (20:46 +0000)]
2009-02-02 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Nikolas Zimmermann.
https://bugs.webkit.org/show_bug.cgi?id=23587
Refactor HitTestRequest to eliminate all the ugly boolean arguments and
use an enum bitflag instead. Cleanup all the code that constructs the
various HitTestRequests to make the code more readable.
* dom/Document.cpp:
(WebCore::Document::elementFromPoint):
(WebCore::Document::prepareMouseEvent):
* editing/SelectionController.cpp:
(WebCore::SelectionController::contains):
* page/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::visiblePositionForPoint):
(WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
* page/EventHandler.cpp:
(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::updateSelectionForMouseDrag):
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::hoverTimerFired):
(WebCore::EventHandler::handleDrag):
* page/EventHandler.h:
* rendering/HitTestRequest.h:
(WebCore::HitTestRequest::):
(WebCore::HitTestRequest::HitTestRequest):
(WebCore::HitTestRequest::readOnly):
(WebCore::HitTestRequest::active):
(WebCore::HitTestRequest::mouseMove):
(WebCore::HitTestRequest::mouseUp):
(WebCore::HitTestRequest::ignoreClipping):
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::nodeAtPoint):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::updateHoverActiveState):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40486
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos@webkit.org [Mon, 2 Feb 2009 20:41:08 +0000 (20:41 +0000)]
Fix the WML build by including the inlined renderStyle().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40485
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 2 Feb 2009 20:11:08 +0000 (20:11 +0000)]
2009-02-02 Darin Adler <darin@apple.com>
Reviewed by Niko Zimmermann.
Bug 23686: REGRESSION (r40475): Failure in fast/xpath/4XPath/Core/test_core_functions.html
https://bugs.webkit.org/show_bug.cgi?id=23686
rdar://problem/6547971
Also fix other XPath tests that are crashing.
* xml/XPathFunctions.cpp:
(WebCore::XPath::FunLang::evaluate): Fix order of arguments when creating QualifiedName.
* xml/XPathStep.cpp:
(WebCore::XPath::Step::nodesInAxis): Use createAttrIfNeeded() rather than attr() since we
need to make Attr nodes here. Yuck!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40484
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 2 Feb 2009 19:53:51 +0000 (19:53 +0000)]
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Oliver Hunt.
When a new Web View was not created, report back to the plug-in host.
* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::performRequest):
* Plugins/Hosted/WebKitPluginHost.defs:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40483
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos@webkit.org [Mon, 2 Feb 2009 19:29:04 +0000 (19:29 +0000)]
Implement WML specific attributes of WMLInputElement.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40482
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 2 Feb 2009 19:14:04 +0000 (19:14 +0000)]
2009-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Draw the regular missing plug-in icon instead of a red rect when a plug-in has crashed.
* Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView drawRect:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40481
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Mon, 2 Feb 2009 19:12:46 +0000 (19:12 +0000)]
2009-01-29 Scott Violet <sky@google.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23633
The test transitions/transition-end-event-nested.html occasionally fails
Ups the timeout of the test transitions/transition-end-event-nested.html
and makes the test exit as soon as all events received.
* transitions/transition-end-event-helpers.js:
(recordTransitionEndEvent):
(runTransitionTest.startTest._endFunction):
(runTransitionTest.startTest):
(runTransitionTest):
* transitions/transition-end-event-nested.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40480
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Mon, 2 Feb 2009 19:10:34 +0000 (19:10 +0000)]
Forgot to update ChangeLog in my last commit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40479
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Mon, 2 Feb 2009 19:03:00 +0000 (19:03 +0000)]
Correct build regression.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40478
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Mon, 2 Feb 2009 18:45:29 +0000 (18:45 +0000)]
Not reviewed. Fix WML enabled builds.
FrameLoader::urlSelected() got a new parameter: lockBackForwardList. Pass 'false', as HTMLAnchorElement does.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40477
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Mon, 2 Feb 2009 18:12:18 +0000 (18:12 +0000)]
Reviewed by Darin Adler.
<rdar://problem/6451610> Reloading a AppCache page doesn't ever hit the server
Not easily testable.
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::createResourceHandle): A new method that creates a resource
handle in a manner that is closer to what CachedResource does. We now make conditional
requests for better performance, and set max-age to ensure that stale responses are not used.
(WebCore::ApplicationCacheGroup::update): Use the new createResourceHandle() method.
(WebCore::ApplicationCacheGroup::didReceiveResponse): If the response code for the resource
is 304, take it from the newest cache.
(WebCore::ApplicationCacheGroup::didFail): Pre-compute request URL.
(WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Don't create a resource for
the manifest if the response code was 304 - it won't be needed.
(WebCore::ApplicationCacheGroup::didReceiveManifestData): Replaced an assertion that
m_manifestResource is not null with a check.
(WebCore::ApplicationCacheGroup::didFinishLoadingManifest): Treat null m_manifestResource as
an indication that the response was 304.
(WebCore::ApplicationCacheGroup::startLoadingEntry): Use createResourceHandle().
* loader/appcache/ApplicationCacheGroup.h: Added createResourceHandle().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40476
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 2 Feb 2009 17:29:54 +0000 (17:29 +0000)]
2009-02-01 Darin Adler <darin@apple.com>
Reviewed by Dave Hyatt.
Bug 23674: Speed up some things based on profiling the page load test
https://bugs.webkit.org/show_bug.cgi?id=23674
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement): Use the newly named cssTarget instead
of the old name, getCSSTarget.
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::insertedIntoDocument): Moved code from Node in here rather than
calling through to EventTargetNode::insertedIntoDocument.
(WebCore::ContainerNode::removedFromDocument): Ditto.
(WebCore::ContainerNode::insertedIntoTree): Tweaked a bit.
(WebCore::ContainerNode::removedFromTree): Ditto.
* dom/ContainerNode.h: Moved the constructor definition here and made it inline.
* dom/Document.cpp:
(WebCore::Document::removeAllEventListenersFromAllNodes): Iterate the document element and
its contents only to avoid the document type node. This allows us to remove the virtual
function call to isEventTargetNode from the loop.
(WebCore::Document::setCSSTarget): Changed argument to be an Element rather than Node.
* dom/Document.h: Changed CSS target to be an Element rather than a Node. Renamed
getCSSTarget to cssTarget.
* dom/EventTargetNode.cpp:
(WebCore::EventTargetNode::removeAllEventListenersSlowCase): Renamed and turned the
rare data check into an assertion.
* dom/EventTargetNode.h: Made the fast case of removeAllEventListeners be inline.
Also moved the constructor definition here and made it inline. And added toEventTargetNode,
matching the design of the render tree checked casts. Later we can migrate all callers
from EventTargetNodeCast to toEventTargetNode.
* dom/NamedAttrMap.cpp:
(WebCore::NamedAttrMap::detachAttributesFromElement): Added. Factored out from
clearAttributes, so we could use this loop in cases where we're not clearing the attributes.
(WebCore::NamedAttrMap::~NamedAttrMap): Call detachAttributesFromElement instead of
clearAttributes here.
(WebCore::NamedAttrMap::clearAttributes): Call detachAttributesFromElement here.
(WebCore::NamedAttrMap::detachFromElement): Call detachAttributesFromElement instead of
clearAttributes. We don't need to clear the attributes array just because the element is
going away, so don't.
(WebCore::NamedAttrMap::virtualLength): Added.
* dom/NamedAttrMap.h: Made all the virtual functions inherited from NamedNodeMap be private.
These are all unnecessarily inefficient for use outside the DOM. Changed length to be a
non-virtual function. This was a fairly hot function.
* dom/NamedMappedAttrMap.cpp:
(WebCore::NamedMappedAttrMap::setClass): Changed to use element() function now that the
m_element data member is private.
* dom/NamedMappedAttrMap.h: Made a few functions private. Made the
hasMappedAttributes function non-virtual.
* dom/NamedNodeMap.h: Made length a non-virtual inline function that calls a virtual
function, name virtualLength. This lets NamedAttrMap::length be a non-virtual function.
* dom/Node.cpp:
(WebCore::Node::insertedIntoDocument): Removed call to insertedIntoTree, since it's
only non-empty in subclasses of ContainerNode.
(WebCore::Node::removedFromDocument): Ditto. Also removed setCSSTarget. Since a CSS
target has to be an Element, this can be moved down to ContainerNode (or it could be
moved down to Element for that matter).
* dom/QualifiedName.cpp:
(WebCore::QualifiedName::QualifiedName): Removed double initialization of m_impl.
* dom/QualifiedName.h: Moved the destructor, copy constructor, assignment operator, and
setPrefix function definitions into the header and made them inline.
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::mapMouseEvent): Updated since the stored region is now
an OwnPtr.
(WebCore::HTMLAreaElement::accessKey): Use AtomicString.
(WebCore::HTMLAreaElement::setAccessKey): Ditto.
(WebCore::HTMLAreaElement::alt): Ditto.
(WebCore::HTMLAreaElement::setAlt): Ditto.
(WebCore::HTMLAreaElement::coords): Ditto.
(WebCore::HTMLAreaElement::setCoords): Ditto.
(WebCore::HTMLAreaElement::setHref): Ditto.
(WebCore::HTMLAreaElement::shape): Ditto.
(WebCore::HTMLAreaElement::setShape): Ditto.
(WebCore::HTMLAreaElement::setTarget): Ditto.
* html/HTMLAreaElement.h: Use AtomicString in the getter and setter DOM operations.
Change the region data member to be an OwnPtr<Path> instead of a Path to optimize
the common case where an area element is parsed but never hit-tested. This could
also have been done by changing the Path class's null case to be more efficient,
but this seems fine.
* html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::createContainingTable): Use addAttribute instead
of insertAttribute.
(WebCore::HTMLViewSourceDocument::addSpanWithClassName): Ditto.
(WebCore::HTMLViewSourceDocument::addLine): Ditto.
(WebCore::HTMLViewSourceDocument::addLink): Ditto.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::gotoAnchor): Use cssTarget under its new name instead
of its old name getCSSTarget.
* platform/graphics/GlyphWidthMap.cpp:
(WebCore::GlyphWidthMap::locatePageSlowCase): Refactored from locatePage.
* platform/graphics/GlyphWidthMap.h: Made most of this class inline.
Changed m_pages to use OwnPtr.
* platform/text/PlatformString.h: Remove include no longer needed since
StringImpl.h includes it.
* platform/text/StringImpl.cpp:
(WebCore::StringImpl::createStrippingNullCharactersSlowCase): Refactored
from createStrippingNullCharacters.
* platform/text/StringImpl.h: Moved the definition of
createStrippingNullCharacters here and made it inline.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::firstLineStyleSlowCase): Refactored from
firstLineStyle.
* rendering/RenderObject.h: Moved the definition of the firstLineStyle
function here and made it inline. Moved the definition of the
documentBeingDestroyed function here and made it inline.
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::getCTM): Use getAttributeItem instead of
getNamedItem here since it accomplishes the same thing but is more efficient.
(WebCore::SVGSVGElement::getScreenCTM): Ditto.
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::getPresentationAttribute): Ditto.
* xml/XPathFunctions.cpp:
(WebCore::XPath::FunLang::evaluate): Use getAttributeItem instead of
getNamedItemNS.
* xml/XPathStep.cpp:
(WebCore::XPath::Step::nodesInAxis): Use attributeItem instead of item here.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40475
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Mon, 2 Feb 2009 15:29:53 +0000 (15:29 +0000)]
2009-02-02 Adam Treat <adam.treat@torchmobile.com>
Fix the Qt build to call forceLayout on the view instead.
* Api/qwebpage.cpp:
(QWebPage::setFixedLayoutSize):
(QWebPage::setUseFixedLayout):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40474
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Mon, 2 Feb 2009 13:16:57 +0000 (13:16 +0000)]
Move Frame::forceLayout, Frame::adjustPageHeight and Frame::forceLayoutWithPageWidthRange to FrameView
https://bugs.webkit.org/show_bug.cgi?id=23428
FrameView::forceLayout could be killed but the comment might
contain a value over the the plain FrameView::layout...
Adjust the WebCore/WebKit consumers of these methods.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40473
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sun, 1 Feb 2009 20:30:30 +0000 (20:30 +0000)]
Reviewed by John Sullivan.
- fix <rdar://problem/6546625> REGRESSION (r40432): iframes added to global history at haaretz.co.il
Fixes http/tests/navigation/multiple-back-forward-entries.html
r40432 added a parameter to FrameLoader::scheduleLocationChange() and
failed to update all call sites.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::createWindow): Pass the lockBackForwardHistory parameter,
giving it the same value as the lockHistory parameter.
(windowProtoFuncOpen): Ditto.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setLocation): Ditto.
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::setLocation): Ditto.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::requestFrame): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40472
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sun, 1 Feb 2009 06:23:39 +0000 (06:23 +0000)]
Reviewed by Oliver Hunt.
- fix <rdar://problem/6546549> Eliminate some RenderText::width() overhead from findNextLineBreak()
On the PLT, this results in 0.36x the number of virtual function calls
to RenderText::width() and 0.69x the number of calls to
Font::isFixedPitch(), but makes 1.0004x the number of calls to
Font::width().
* rendering/RenderText.cpp:
(WebCore::RenderText::width): Replaced bounds checks on 'from' and 'len'
with an assertion.
* rendering/bidi.cpp:
(WebCore::textWidth): Added this inlined helper function which calls
Font::width() directly in the non-fixed-pitch, non-full-range case, and
otherwise calls RenderText::width().
(WebCore::RenderBlock::findNextLineBreak): Cache whether the font has
fixed pitch (in which case RenderText::width() will be called in order
to take advantage of the widthFromCache() optimization for fixed-pitch
fonts). Replaced all calls to RenderText::width() with calls to the
textWidth() helper function.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40471
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pewtermoose@webkit.org [Sun, 1 Feb 2009 05:07:13 +0000 (05:07 +0000)]
2009-01-31 Matt Lilek <webkit@mattlilek.com>
Not reviewed, build fixes.
* WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::searchWithGoogle):
* WebFrame.cpp:
(WebFrame::setInPrintingMode):
(WebFrame::isFrameSet):
* WebView.cpp:
(WebView::notifyPreferencesChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40470
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sun, 1 Feb 2009 01:30:23 +0000 (01:30 +0000)]
2009-01-31 David Hyatt <hyatt@apple.com>
Inline all of the setNeedsLayout method and its associated functions. Also inline setChildNeedsLayout
and setNeedsPositionedMovementLayout.
Reviewed by Dan Bernstein
* rendering/RenderObject.cpp:
(WebCore::RenderObject::setLayerNeedsFullRepaint):
* rendering/RenderObject.h:
(WebCore::RenderObject::setNeedsLayout):
(WebCore::RenderObject::setChildNeedsLayout):
(WebCore::RenderObject::setNeedsPositionedMovementLayout):
(WebCore::objectIsRelayoutBoundary):
(WebCore::RenderObject::markContainingBlocksForLayout):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40469
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Sun, 1 Feb 2009 00:59:19 +0000 (00:59 +0000)]
2009-01-31 John Sullivan <sullivan@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=23665
Cleaned up code to add/remove NSNotification observers, to avoid performance hit
of calling removeObserver with unspecified notifications, or calling removeObserver
multiple times for the same notification.
Reviewed by Darin Adler
* WebView/WebHTMLView.mm:
added observingMouseMovedNotifications, observingSuperviewNotifications, and
observingWindowNotifications as BOOL ivars of _private object
(-[WebHTMLView _removeMouseMovedObserverUnconditionally]):
moved to file-internal section of file, added leading underscore, now bails out
if we aren't observing the relevant notifications, now records that we are no longer
observing the relevant notifications
(-[WebHTMLView _removeSuperviewObservers]):
ditto, also stores [NSNoticationCenter defaultCenter] in local var to avoid objc dispatch
(-[WebHTMLView _removeWindowObservers]):
ditto
(-[WebHTMLView close]):
replace general removeObserver: call with three specific calls for all the notifications
that this class actually observes
(-[WebHTMLView addMouseMovedObserver]):
bail out if already observing relevant notifications, now records that we are observing
the relevant notifications
(-[WebHTMLView removeMouseMovedObserver]):
updated for name change
(-[WebHTMLView addSuperviewObservers]):
bail out if already observing relevant notifications, now records that we are observing
the relevant notifications; also stores [NSNoticationCenter defaultCenter] in local var
to avoid objc dispatch
(-[WebHTMLView addWindowObservers]):
ditto
(-[WebHTMLView viewWillMoveToSuperview:]):
updated for name change
(-[WebHTMLView viewWillMoveToWindow:]):
updated for name changes
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40468
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 1 Feb 2009 00:55:03 +0000 (00:55 +0000)]
2009-01-31 Darin Adler <darin@apple.com>
Fix Mac build.
* loader/FrameLoader.cpp: Moved FrameLoaderClient::hasHTMLView in here.
We need it to not be an inline. Sadly, FrameLoaderClient.cpp was prematurely
deleted and I don't want to bring it back just to fix the build.
* loader/FrameLoaderClient.h: Rearrange virtual functions and corrected
a possibly-confusing comment.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40467
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sun, 1 Feb 2009 00:52:34 +0000 (00:52 +0000)]
Fix WIndows bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40466
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 1 Feb 2009 00:14:12 +0000 (00:14 +0000)]
2009-01-31 Darin Adler <darin@apple.com>
Reviewed by Mark Rowe.
Fix code that assumes all command selectors end in colons.
rdar://problem/6545874
* WebView/WebHTMLView.mm:
(commandNameForSelector): Don't assert, just return a null string, when
the selector doesn't end in a colon.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40465
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Sat, 31 Jan 2009 23:55:57 +0000 (23:55 +0000)]
2009-01-31 Adam Treat <adam.treat@torchmobile.com>
Reviewed by David Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=23664
Remove unused dead code from RenderTable class. The dead code includes
two enums and the associated member variables as well as one getter function.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::RenderTable):
* rendering/RenderTable.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40464
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 31 Jan 2009 22:03:31 +0000 (22:03 +0000)]
Update layout test results for 11363.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40463
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 31 Jan 2009 21:40:18 +0000 (21:40 +0000)]
Add RenderObjectChildList.cpp to all projects.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40462
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 31 Jan 2009 21:38:13 +0000 (21:38 +0000)]
2009-01-31 David Hyatt <hyatt@apple.com>
More removal of code from RenderContainer. Move removeLeftoverAnonymousBlock down into RenderBlock.
Move destroyLeftoverChildren into the RenderObjectChildList. Convert all containers to use the
RenderObjectChildList.
Reviewed by Sam Weinig
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::destroy):
(WebCore::RenderBlock::addChild):
(WebCore::RenderBlock::removeLeftoverAnonymousBlock):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::childBecameNonInline):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::layout):
* rendering/RenderBox.h:
(WebCore::RenderBox::firstChildBox):
(WebCore::RenderBox::lastChildBox):
* rendering/RenderContainer.cpp:
(WebCore::RenderContainer::addChild):
(WebCore::RenderContainer::removeChildNode):
(WebCore::RenderContainer::updateBeforeAfterContentForContainer):
(WebCore::RenderContainer::appendChildNode):
(WebCore::RenderContainer::insertChildNode):
(WebCore::RenderContainer::positionForCoordinates):
(WebCore::RenderContainer::addLineBoxRects):
(WebCore::RenderContainer::collectAbsoluteLineBoxQuads):
* rendering/RenderContainer.h:
(WebCore::RenderContainer::virtualChildren):
(WebCore::RenderContainer::children):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::destroy):
* rendering/RenderInline.h:
(WebCore::RenderInline::layout):
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::destroy):
(WebCore::RenderMedia::children):
* rendering/RenderMedia.h:
(WebCore::RenderMedia::virtualChildren):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::destroy):
(WebCore::RenderObject::layout):
* rendering/RenderObject.h:
(WebCore::RenderObject::firstChild):
(WebCore::RenderObject::lastChild):
(WebCore::RenderObject::virtualChildren):
(WebCore::RenderObject::canHaveChildren):
* rendering/RenderObjectChildList.cpp: Added.
(WebCore::RenderObjectChildList::destroyLeftoverChildren):
* rendering/RenderObjectChildList.h:
* rendering/RenderReplaced.h:
(WebCore::RenderReplaced::canHaveChildren):
* rendering/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::RenderSVGContainer):
(WebCore::RenderSVGContainer::destroy):
(WebCore::RenderSVGContainer::removeChildNode):
(WebCore::RenderSVGContainer::appendChildNode):
(WebCore::RenderSVGContainer::insertChildNode):
* rendering/RenderSVGContainer.h:
(WebCore::RenderSVGContainer::virtualChildren):
(WebCore::RenderSVGContainer::children):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40461
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 31 Jan 2009 21:34:28 +0000 (21:34 +0000)]
Update layout test results for 11363.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40460
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 31 Jan 2009 21:34:17 +0000 (21:34 +0000)]
Update layout test results for 11363.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40459
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 31 Jan 2009 21:30:07 +0000 (21:30 +0000)]
Update layout test results for 11363.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40458
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 31 Jan 2009 21:28:36 +0000 (21:28 +0000)]
Update layout test results for 11363.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40457
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 31 Jan 2009 21:28:10 +0000 (21:28 +0000)]
Update layout test results for 11363.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40456
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 31 Jan 2009 21:26:59 +0000 (21:26 +0000)]
Update layout test results for 11363.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40455
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 31 Jan 2009 21:23:16 +0000 (21:23 +0000)]
Update layout test results for 11363.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40454
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 31 Jan 2009 21:20:17 +0000 (21:20 +0000)]
2009-01-31 David Hyatt <hyatt@apple.com>
Fix for https://bugs.webkit.org/show_bug.cgi?id=11363
Remove the hacks in table code around the DeleteButtonController and fix tables so that positioned children don't get wrapped in anonymous objects.
With the removal of a non-positioned DeleteButtonController renderer, table layout can be tightened up to only lay out table sections. Table section
layout is tightened up to ignore non-table rows. When a table has multiple captions, only the real one will do a layout now. The other ones will
be properly ignored.
Reviewed by Oliver Hunt
* editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
(WebCore::RenderTable::layout):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layout):
* rendering/RenderTableSection.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40453
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Sat, 31 Jan 2009 18:07:37 +0000 (18:07 +0000)]
2009-01-31 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23663
Add a void toRenderBox() method which catches unnecessary casts at compile
time and also fix the four cases where this was happening.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::determineHorizontalPosition):
* rendering/RenderBox.h:
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::updateHitTestResult):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40452
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 31 Jan 2009 16:02:16 +0000 (16:02 +0000)]
2009-01-31 Darin Adler <darin@apple.com>
Build fix.
* WebView.cpp:
(wxWebView::OnSize): call sendResizeEvent on EventHandler.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40451
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jmalonzo@webkit.org [Sat, 31 Jan 2009 09:36:45 +0000 (09:36 +0000)]
2009-01-30 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Nikolas Zimmermann.
[Gtk] Refactor autoconf/configure.ac in preparation for jsc and webkit build splits
https://bugs.webkit.org/show_bug.cgi?id=22136
* GNUmakefile.am:
* acinclude.m4: Removed.
* autogen.sh:
* autotools/acinclude.m4: Added.
* autotools/dolt.m4: Added.
* autotools/symbols.filter: Renamed from symbols.filter.
* autotools/webkit.m4: Added.
* configure.ac:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40450
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 31 Jan 2009 08:42:29 +0000 (08:42 +0000)]
WebCore:
2009-01-30 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Add a pref to disable web security.
* WebCore.base.exp:
* dom/Document.cpp:
(WebCore::Document::initSecurityContext):
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::canAccess):
(WebCore::SecurityOrigin::canRequest):
(WebCore::SecurityOrigin::grantUniversalAccess):
* page/SecurityOrigin.h:
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setWebSecurityEnabled):
* page/Settings.h:
(WebCore::Settings::isWebSecurityEnabled):
WebKit/win:
2009-01-30 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Add a pref to disable web security.
* Interfaces/IWebPreferencesPrivate.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::isWebSecurityEnabled):
(WebPreferences::setWebSecurityEnabled):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):
WebKit/mac:
2009-01-30 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Add a pref to disable web security.
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferencesPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences isWebSecurityEnabled]):
(-[WebPreferences setWebSecurityEnabled:]):
* WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40449
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 31 Jan 2009 06:24:58 +0000 (06:24 +0000)]
Reviewed by Timothy Hatcher.
- <rdar://problem/6545912> expose the build number in autoversion.h
* win/tools/scripts/auto-version.sh: Added a #define __BUILD_NUMBER__
with the full build number.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40448
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Sat, 31 Jan 2009 05:12:03 +0000 (05:12 +0000)]
2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
Build fix.
Move the inline virtual destructor after a non-inline virtual
function so that the symbol for the vtable is not marked as a
weakly exported symbol.
This trick was previously used at revision 36122 in JSObject.h
* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::~FrameLoaderClient):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40447
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sat, 31 Jan 2009 04:43:47 +0000 (04:43 +0000)]
Inline SimpleFontData::widthForGlyph for a minor page load improvement.
Reviewed by Stephanie Lewis
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40446
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Sat, 31 Jan 2009 04:40:02 +0000 (04:40 +0000)]
Build fix for WX and maybe even Windows.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40445
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Sat, 31 Jan 2009 04:12:51 +0000 (04:12 +0000)]
Move Frame::sendResizeEvent and Frame::sendScrollEvent to EventHandler
Carry out the move and catch up in two call sites.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40444
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Sat, 31 Jan 2009 03:51:37 +0000 (03:51 +0000)]
Move Frame::isFrameSet to Document::isFrameSet
Changed the FrameLoader callsite. I assume that as this
point m_frame.document() might return a null pointer. Change
the condition to either not having a document or not having a
frame set. This should be semantically equivalent to the
old code.
Make Document::body() const to be able to call it from within
Document::isFrameSet. Leave the isHTMLDocument() check as this
is a stronger condition than simply having a HTMLElement in the
DOM.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40443
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Sat, 31 Jan 2009 03:51:13 +0000 (03:51 +0000)]
[GTK] Logic fixes and build fixes
https://bugs.webkit.org/show_bug.cgi?id=22022
Catch up with the internal GeoLocation API and fix the logic of
the previous version.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40442
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Sat, 31 Jan 2009 03:51:00 +0000 (03:51 +0000)]
[GTK] Implement GeolocationService using the Geoclue library
https://bugs.webkit.org/show_bug.cgi?id=22022
Untested implementation of the GeolocationService using the geoclue
library. Velocity handling is completely missing and the accuracy
handling might be wrong.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40441
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 31 Jan 2009 03:48:15 +0000 (03:48 +0000)]
Build fix. Declare preferredSize as static.
* platform/text/cf/StringImplCF.cpp:
(WebCore::StringWrapperCFAllocator::preferredSize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40440
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 31 Jan 2009 03:11:39 +0000 (03:11 +0000)]
<rdar://problem/6391501> Enable the JIT on Mac OS X x86_64 as it passes all tests.
Rubber-stamped by Oliver Hunt.
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40439
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 31 Jan 2009 02:31:32 +0000 (02:31 +0000)]
2009-01-30 Darin Adler <darin@apple.com>
Reviewed by Mark Rowe.
Bug 23622: create CFString and NSString objects from WebCore::String without copying the characters
https://bugs.webkit.org/show_bug.cgi?id=23622
* platform/text/cf/StringImplCF.cpp:
(WebCore::StringWrapperCFAllocator::allocator): Added. Returns the allocator.
(WebCore::StringWrapperCFAllocator::retain): Added. Callback for allocator.
(WebCore::StringWrapperCFAllocator::release): Ditto.
(WebCore::StringWrapperCFAllocator::copyDescription): Ditto.
(WebCore::StringWrapperCFAllocator::allocate): Ditto.
(WebCore::StringWrapperCFAllocator::reallocate): Ditto.
(WebCore::StringWrapperCFAllocator::deallocate): Ditto.
(WebCore::StringWrapperCFAllocator::preferredSize): Ditto.
(WebCore::StringWrapperCFAllocator::create): Added. Creates the allocator, but
returns 0 if garbage collection is enabled.
(WebCore::StringImpl::createCFString): Use StringWrapperCFAllocator if possible.
* platform/text/mac/StringImplMac.mm:
(WebCore::StringImpl::operator NSString *): Use CFString and toll-free bridging,
rather than using NSString directly. This lets NSString benefit from the above.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40438
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 31 Jan 2009 02:31:26 +0000 (02:31 +0000)]
2009-01-30 Darin Adler <darin@apple.com>
* page/Frame.cpp:
(WebCore::Frame::createView): Fix debug build by removing get() from assert.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40437
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sat, 31 Jan 2009 02:13:35 +0000 (02:13 +0000)]
WebKit/gtk:
2009-01-30 Geoffrey Garen <ggaren@apple.com>
Build fix.
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::createFrame):
WebKit/mac:
2009-01-30 Geoffrey Garen <ggaren@apple.com>
Build fix.
* WebView/WebFramePrivate.h:
WebKit/qt:
2009-01-30 Geoffrey Garen <ggaren@apple.com>
Build fix.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createFrame):
WebKit/win:
2009-01-30 Geoffrey Garen <ggaren@apple.com>
Build fix.
* Interfaces/IWebFramePrivate.idl:
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::loadURLIntoChild):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40436
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Sat, 31 Jan 2009 01:57:18 +0000 (01:57 +0000)]
Kill FrameLoaderClient.cpp, move the code over to Frame::createView
FrameLoaderClient is supposed to be an interface, move the
to be shared code to Frame which is a controller and is
allowed to create a FrameView.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40435
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Sat, 31 Jan 2009 01:47:49 +0000 (01:47 +0000)]
2009-01-30 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt
https://bugs.webkit.org/show_bug.cgi?id=23357
New files to support accelerated compositing at the RenderLayer
level.
* WebCore.xcodeproj/project.pbxproj:
New files added to project, and run through the sort script.
* rendering/RenderLayerBacking.cpp: Added.
* rendering/RenderLayerBacking.h: Added.
New object to store compositing-related data for a single
RenderLayer.
* rendering/RenderLayerCompositor.cpp: Added.
* rendering/RenderLayerCompositor.h: Added.
Per-RenderView controller object for compositing hierarchy
maintenance.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40434
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Sat, 31 Jan 2009 01:42:01 +0000 (01:42 +0000)]
2009-01-30 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt
https://bugs.webkit.org/show_bug.cgi?id=23356
Add new files related to accelerated compositing.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40433
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sat, 31 Jan 2009 01:28:33 +0000 (01:28 +0000)]
WebCore:
2009-01-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Split "lockHistory" into "lockHistory" and "lockBackForwardList" in
preparation for setting them differently during a redirect.
* WebCore.base.exp:
* bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::submit):
* bindings/js/JSLocationCustom.cpp:
(WebCore::navigateIfAllowed):
(WebCore::JSLocation::setHref):
(WebCore::JSLocation::setProtocol):
(WebCore::JSLocation::setHost):
(WebCore::JSLocation::setHostname):
(WebCore::JSLocation::setPort):
(WebCore::JSLocation::setPathname):
(WebCore::JSLocation::setSearch):
(WebCore::JSLocation::setHash):
(WebCore::JSLocation::replace):
(WebCore::JSLocation::assign):
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::defaultEventHandler):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::submit):
* html/HTMLFormElement.h:
* loader/FrameLoader.cpp:
(WebCore::FormSubmission::FormSubmission):
(WebCore::ScheduledRedirection::ScheduledRedirection):
(WebCore::isBackForwardLoadType):
(WebCore::FrameLoader::createWindow):
(WebCore::FrameLoader::changeLocation):
(WebCore::FrameLoader::urlSelected):
(WebCore::FrameLoader::submitFormAgain):
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::restoreDocumentState):
(WebCore::FrameLoader::scheduleHTTPRedirection):
(WebCore::FrameLoader::scheduleLocationChange):
(WebCore::FrameLoader::scheduleRefresh):
(WebCore::FrameLoader::redirectionTimerFired):
(WebCore::FrameLoader::loadURLIntoChildFrame):
(WebCore::FrameLoader::startRedirectionTimer):
(WebCore::FrameLoader::loadFrameRequestWithFormAndValues):
(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::clientRedirected):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::loadItem):
* loader/FrameLoader.h:
* loader/FrameLoaderTypes.h:
(WebCore::):
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
* svg/SVGAElement.cpp:
(WebCore::SVGAElement::defaultEventHandler):
WebKit/mac:
2009-01-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Split "lockHistory" into "lockHistory" and "lockBackForwardList" in
preparation for setting them differently during a redirect.
* WebView/WebPDFView.mm:
(-[WebPDFView PDFViewWillClickOnLink:withURL:]):
WebKit/qt:
2009-01-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Split "lockHistory" into "lockHistory" and "lockBackForwardList" in
preparation for setting them differently during a redirect.
* Api/qwebpage.cpp:
(QWebPage::triggerAction):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40432
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 31 Jan 2009 00:42:12 +0000 (00:42 +0000)]
WebCore:
2009-01-30 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Fix for <rdar://problem/6545095>
ASSERTION FAILED: RenderBlock.h:519: !o || o->isRenderBlock()
Test: fast/block/float/crash-replaced-display-block.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChildren): Move RenderBlock only code into
isRenderBlock if-statement.
LayoutTests:
2009-01-30 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Test for <rdar://problem/6545095>
ASSERTION FAILED: RenderBlock.h:519: !o || o->isRenderBlock()
* fast/block/float/crash-replaced-display-block-expected.txt: Added.
* fast/block/float/crash-replaced-display-block.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40431
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Fri, 30 Jan 2009 23:46:19 +0000 (23:46 +0000)]
Bug 23656: AX hierarchy for iFrames is incorrect
https://bugs.webkit.org/show_bug.cgi?id=23656
The AX hierarchy when an iFrame was present was incorrect. A different scroll area was returned when going down compared to when going up.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40430
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Fri, 30 Jan 2009 23:43:35 +0000 (23:43 +0000)]
2009-01-30 Adam Treat <adam.treat@torchmobile.com>
Fix Qt build to include new class IdentifierRep introduced in revision 40412.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40429
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 30 Jan 2009 23:32:52 +0000 (23:32 +0000)]
2009-01-30 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Fix <rdar://problem/6544048>
Have NetscapePluginInstanceProxy keep track of all the ProxyInstance objects associated.
When the plug-in instance is destroyed, invalidate all proxy instances.
* Plugins/Hosted/NetscapePluginInstanceProxy.h:
* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::destroy):
(WebKit::NetscapePluginInstanceProxy::addInstance):
(WebKit::NetscapePluginInstanceProxy::removeInstance):
* Plugins/Hosted/ProxyInstance.h:
* Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::ProxyInstance):
(WebKit::ProxyInstance::~ProxyInstance):
(WebKit::ProxyInstance::invalidate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40428
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 30 Jan 2009 23:16:33 +0000 (23:16 +0000)]
2009-01-30 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Make IdentifierRep.h a private header, and add symbols needed by WebKit to WebCore.LP64.exp.
* WebCore.LP64.exp:
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40427
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Fri, 30 Jan 2009 23:13:59 +0000 (23:13 +0000)]
[Gtk+] Use AccessibilityObject::stringValue for the AtkObject name
https://bugs.webkit.org/show_bug.cgi?id=21546
The API documentation at http://library.gnome.org/devel/atk/stable/AtkText.html
states that: "AtkObjects whose text content is simple, unattributed, and very
brief may expose that content via atk_object_get_name instead"
As we are currently not able to always provide a AtkTextInterface
implementation this will make the whole content available to accerciser,
and other tools.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40426
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 30 Jan 2009 23:11:17 +0000 (23:11 +0000)]
2009-01-30 Sam Weinig <sam@webkit.org>
Commit files I forgot to in the previous commit.
* page/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::layoutCount):
* page/Frame.cpp:
(WebCore::Frame::contentRenderer):
(WebCore::Frame::forceLayoutWithPageWidthRange):
* page/FrameView.cpp:
(WebCore::FrameView::layout):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):
(WebCore::RenderObject::view):
(WebCore::RenderObject::scheduleRelayout):
(WebCore::RenderObject::maximalOutlineSize):
* rendering/SVGRenderSupport.cpp:
(WebCore::clampImageBufferSizeToViewport):
* svg/SVGLength.cpp:
(WebCore::SVGLength::PercentageOfViewport):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40425
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 30 Jan 2009 23:09:43 +0000 (23:09 +0000)]
WebCore:
2009-01-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
More scaffolding for redirect tracking. No behavior change yet.
* bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::submit): Added scaffolding necessary for
redirect checking in a form submission through JS. (Currently, we
just specify "no redirect.")
* bindings/js/ScriptController.h:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::processingUserGesture):
(WebCore::ScriptController::processingUserGestureEvent):
(WebCore::ScriptController::isJavaScriptAnchorNavigation): Refactored
user gesture check to make it more clear.
(WebCore::ScriptController::pageIsProcessingUserGesture): Added a helper
for checking if there's a user gesture in any frame on the page (a more
relaxed rule than our popup blocking rule, which requires the user
gesture to occur in the frame that's executing JavaScript.)
* html/HTMLFormElement.h:
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::submit): Added scaffolding necessary for
redirect checking in a form submission through the DOM. (Currently, we
just specify "no redirect.")
* html/HTMLFormElement.idl: Made submit custom so it can participate
in redirect checking.
* loader/FrameLoader.h:
* loader/FrameLoader.cpp:
(WebCore::FormSubmission::FormSubmission): Clarified some names, and
added a "lockHistory" parameter to form submissions, to match other
navigations.
(WebCore::FrameLoader::submitFormAgain):
(WebCore::FrameLoader::submitForm): Use the lockHistory parameter.
(WebCore::FrameLoader::userGestureHint): Refactored this function for
clarity, and added a FIXME for a change I was too scared to make myself.
(Really, we should just get rid of this function.)
(WebCore::FrameLoader::loadFrameRequestWithFormAndValues): Refactored
to pass a FrameLoadType to form posts, too, so they can participate in
redirect tracking.
(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::loadItem): Use the lockHistory parameter.
LayoutTests:
2009-01-30 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
More redirect layout test work.
Added tests (expected to fail) for form submission via JavaScript:
* http/tests/history/redirect-js-form-submit-0-seconds-expected.txt: Added.
* http/tests/history/redirect-js-form-submit-0-seconds.html: Added.
* http/tests/history/redirect-js-form-submit-2-seconds-expected.txt: Added.
* http/tests/history/redirect-js-form-submit-2-seconds.html: Added.
* http/tests/history/redirect-js-form-submit-before-load-expected.txt: Added.
* http/tests/history/redirect-js-form-submit-before-load.html: Added.
Updated these tests to dump their back/forward lists, to check for
back/forward regressions, and to use # instead of ? to communicate between
URLs, since, to my surprise, form submissions can't use query strings.
* http/tests/history/redirect-200-refresh-0-seconds-expected.txt:
* http/tests/history/redirect-200-refresh-0-seconds.pl:
* http/tests/history/redirect-200-refresh-2-seconds-expected.txt:
* http/tests/history/redirect-200-refresh-2-seconds.pl:
* http/tests/history/redirect-301-expected.txt:
* http/tests/history/redirect-301.pl:
* http/tests/history/redirect-302-expected.txt:
* http/tests/history/redirect-302.pl:
* http/tests/history/redirect-303-expected.txt:
* http/tests/history/redirect-303.pl:
* http/tests/history/redirect-307-expected.txt:
* http/tests/history/redirect-307.pl:
* http/tests/history/redirect-js-document-location-0-seconds-expected.txt:
* http/tests/history/redirect-js-document-location-0-seconds.html:
* http/tests/history/redirect-js-document-location-2-seconds-expected.txt:
* http/tests/history/redirect-js-document-location-2-seconds.html:
* http/tests/history/redirect-js-document-location-before-load-expected.txt:
* http/tests/history/redirect-js-document-location-before-load.html:
* http/tests/history/redirect-js-location-0-seconds-expected.txt:
* http/tests/history/redirect-js-location-0-seconds.html:
* http/tests/history/redirect-js-location-2-seconds-expected.txt:
* http/tests/history/redirect-js-location-2-seconds.html:
* http/tests/history/redirect-js-location-assign-0-seconds-expected.txt:
* http/tests/history/redirect-js-location-assign-0-seconds.html:
* http/tests/history/redirect-js-location-assign-2-seconds-expected.txt:
* http/tests/history/redirect-js-location-assign-2-seconds.html:
* http/tests/history/redirect-js-location-assign-before-load-expected.txt:
* http/tests/history/redirect-js-location-assign-before-load.html:
* http/tests/history/redirect-js-location-before-load-expected.txt:
* http/tests/history/redirect-js-location-before-load.html:
* http/tests/history/redirect-js-location-href-0-seconds-expected.txt:
* http/tests/history/redirect-js-location-href-0-seconds.html:
* http/tests/history/redirect-js-location-href-2-seconds-expected.txt:
* http/tests/history/redirect-js-location-href-2-seconds.html:
* http/tests/history/redirect-js-location-href-before-load-expected.txt:
* http/tests/history/redirect-js-location-href-before-load.html:
* http/tests/history/redirect-js-location-replace-0-seconds-expected.txt:
* http/tests/history/redirect-js-location-replace-0-seconds.html:
* http/tests/history/redirect-js-location-replace-2-seconds-expected.txt:
* http/tests/history/redirect-js-location-replace-2-seconds.html:
* http/tests/history/redirect-js-location-replace-before-load-expected.txt:
* http/tests/history/redirect-js-location-replace-before-load.html:
* http/tests/history/redirect-meta-refresh-0-seconds-expected.txt:
* http/tests/history/redirect-meta-refresh-0-seconds.html:
* http/tests/history/redirect-meta-refresh-2-seconds-expected.txt:
* http/tests/history/redirect-meta-refresh-2-seconds.html:
* http/tests/history/resources/redirect-target.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40424
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pol@apple.com [Fri, 30 Jan 2009 23:00:59 +0000 (23:00 +0000)]
2009-01-30 Pierre-Olivier Latour <pol@apple.com>
Updated the references images for the media layout tests on Tiger since they now differ from Leopard after installing QuickTime 7.6.
* platform/mac-tiger/media: Added.
* platform/mac-tiger/media/video-aspect-ratio-expected.checksum: Added.
* platform/mac-tiger/media/video-aspect-ratio-expected.png: Added.
* platform/mac-tiger/media/video-controls-rendering-expected.checksum: Added.
* platform/mac-tiger/media/video-controls-rendering-expected.png: Added.
* platform/mac-tiger/media/video-display-toggle-expected.checksum: Added.
* platform/mac-tiger/media/video-display-toggle-expected.png: Added.
* platform/mac-tiger/media/video-layer-crash-expected.checksum: Added.
* platform/mac-tiger/media/video-layer-crash-expected.png: Added.
* platform/mac-tiger/media/video-transformed-expected.checksum: Added.
* platform/mac-tiger/media/video-transformed-expected.png: Added.
* platform/mac-tiger/media/video-zoom-expected.checksum: Added.
* platform/mac-tiger/media/video-zoom-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40423
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 30 Jan 2009 22:57:07 +0000 (22:57 +0000)]
2009-01-30 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Fix <rdar://problem/6490778>.
Change the NPRuntime related functions to use IdentifierRep directly, and make sure to always
validate IdentifierReps before dereferencing them.
* Plugins/Hosted/NetscapePluginHostProxy.mm:
(WKPCEvaluate):
(WKPCGetStringIdentifier):
(WKPCGetIntIdentifier):
(identifierFromIdentifierRep):
(WKPCInvoke):
(WKPCGetProperty):
(WKPCSetProperty):
(WKPCRemoveProperty):
(WKPCHasProperty):
(WKPCHasMethod):
(WKPCIdentifierInfo):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40422
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 30 Jan 2009 22:42:27 +0000 (22:42 +0000)]
2009-01-30 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Seidel.
Correct mis-applied http://trac.webkit.org/changeset/40413 by actually
removing the test file.
* fast/dom/Window/timeout-released-on-close.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40421
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Fri, 30 Jan 2009 22:19:37 +0000 (22:19 +0000)]
Build fix for Gtk+
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40420
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 30 Jan 2009 22:16:33 +0000 (22:16 +0000)]
Finally fix load() to propagate exceptions correctly.
Reviewed by Mark Rowe and Sam Weinig.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40419
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 30 Jan 2009 22:02:04 +0000 (22:02 +0000)]
2009-01-30 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23618
Templated worker tasks should be more error proof to use.
Fix Chromium build.
* wtf/TypeTraits.h:
(WTF::IsConvertibleToInteger::IsConvertibleToDouble):
Avoid "possible loss of data" warning when using Microsoft's C++ compiler
by avoiding an implicit conversion of int types to doubles.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40418
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 30 Jan 2009 21:57:37 +0000 (21:57 +0000)]
2009-01-30 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Add toRenderView methods for casting RenderObjects to RenderViews. The methods will assert if the object
is not a RenderView.
* dom/Document.cpp:
(WebCore::Document::renderView):
* editing/SelectionController.cpp:
(WebCore::SelectionController::nodeWillBeRemoved):
(WebCore::SelectionController::recomputeCaretRect):
(WebCore::SelectionController::invalidateCaretRect):
(WebCore::SelectionController::focusedOrActiveStateChanged):
* editing/mac/SelectionControllerMac.mm:
(WebCore::SelectionController::notifyAccessibilityForSelectionChange):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::repaintLayerRectsForImage):
(WebCore::RenderBox::availableHeightUsing):
* rendering/RenderView.h:
(WebCore::toRenderView):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40417
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 30 Jan 2009 21:48:23 +0000 (21:48 +0000)]
2009-01-30 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt
https://bugs.webkit.org/show_bug.cgi?id=23360
Really use the container-relative repaint rect methods
for repaint during layout
* rendering/RenderObject.h:
(WebCore::RenderObject::LayoutRepainter::LayoutRepainter):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40416
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 30 Jan 2009 21:47:29 +0000 (21:47 +0000)]
2009-01-30 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Get rid of PrivateIdentifier and use IdentifierRep instead.
* bridge/NP_jsobject.cpp:
(_NPN_Invoke):
(_NPN_GetProperty):
(_NPN_SetProperty):
(_NPN_RemoveProperty):
(_NPN_HasProperty):
(_NPN_HasMethod):
* bridge/c/c_instance.cpp:
(JSC::Bindings::CInstance::getPropertyNames):
* bridge/c/c_utility.cpp:
(JSC::Bindings::convertNPStringToUTF16):
* bridge/c/c_utility.h:
* bridge/npruntime.cpp:
(_NPN_GetStringIdentifier):
(_NPN_GetStringIdentifiers):
(_NPN_GetIntIdentifier):
(_NPN_IdentifierIsString):
(_NPN_UTF8FromIdentifier):
(_NPN_IntFromIdentifier):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40415
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 30 Jan 2009 21:25:27 +0000 (21:25 +0000)]
2009-01-30 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig and Darin Adler.
Make IdentifierRep a real class, add necessary class methods.
* bridge/IdentifierRep.cpp:
(WebCore::identifierSet):
Returns a set of all identifiers.
(WebCore::IdentifierRep::isValid):
Return whether an identifier is valid, meaning that it's present in the
set of identifiers.
* bridge/IdentifierRep.h:
(WebCore::IdentifierRep::isString):
(WebCore::IdentifierRep::number):
(WebCore::IdentifierRep::string):
(WebCore::IdentifierRep::IdentifierRep):
(WebCore::IdentifierRep::):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40414
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Fri, 30 Jan 2009 20:17:34 +0000 (20:17 +0000)]
2009-01-30 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23650
LayoutTests/fast/dom/Window/timeout-released-on-close.html fails intermittently.
Disable this test to keep buildbots green. Need more time to investigate the cause.
* fast/dom/Window/timeout-released-on-close.html: Removed.
* fast/dom/Window/timeout-released-on-close.html-disabled: Copied from LayoutTests/fast/dom/Window/timeout-released-on-close.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40413
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 30 Jan 2009 19:57:33 +0000 (19:57 +0000)]
2009-01-30 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add IdentifierRep which will be used by both plug-in implementations.
* GNUmakefile.am:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bridge/IdentifierRep.cpp: Added.
(WebCore::IdentifierRep::IdentifierRep):
(WebCore::IdentifierRep::):
(WebCore::intIdentifierMap):
(WebCore::identifierRep):
(WebCore::stringIdentifierMap):
* bridge/IdentifierRep.h: Added.
* bridge/c/c_utility.h:
* platform/text/PlatformString.h:
* platform/text/String.cpp:
(WebCore::String::fromUTF8WithLatin1Fallback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40412
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 30 Jan 2009 19:55:45 +0000 (19:55 +0000)]
2009-01-30 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Add toRenderInline methods for casting RenderObjects to RenderInlines. The methods will assert if the object
is not a RenderInline.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::removeLineBoxFromRenderObject):
(WebCore::InlineFlowBox::extractLineBoxFromRenderObject):
(WebCore::InlineFlowBox::attachLineBoxToRenderObject):
(WebCore::InlineFlowBox::rendererLineBoxes):
(WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
(WebCore::InlineFlowBox::paint):
* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::addFocusRingRects):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::containingBlockWidthForPositioned):
(WebCore::RenderBox::containingBlockHeightForPositioned):
(WebCore::RenderBox::calcAbsoluteHorizontalValues):
(WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
* rendering/RenderContainer.cpp:
(WebCore::RenderContainer::updateBeforeAfterContentForContainer):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::inlineContinuation):
(WebCore::nextContinuation):
(WebCore::RenderInline::splitInlines):
* rendering/RenderInline.h:
(WebCore::toRenderInline):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition):
(WebCore::RenderLayer::boundingBox):
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
* rendering/RenderText.h:
* rendering/RenderTreeAsText.cpp:
(WebCore::operator<<):
* rendering/bidi.cpp:
(WebCore::RenderBlock::createLineBoxes):
(WebCore::RenderBlock::layoutInlineChildren):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40411
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Fri, 30 Jan 2009 18:20:38 +0000 (18:20 +0000)]
2009-01-30 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23647
Fix PLATFORM(SKIA)'s ImageSource::clear method to match other ports
* platform/graphics/skia/ImageSourceSkia.cpp:
(WebCore::ImageSource::clear):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40410
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 30 Jan 2009 18:16:03 +0000 (18:16 +0000)]
2009-01-30 David Hyatt <hyatt@apple.com>
Add toRenderBlock methods for casting RenderObjects to RenderBlocks. The methods will assert if the object
is not a RenderBlock. Also add a toRenderBlock method that takes a RenderBlock but returns void and that
is unimplemented. This method will catch anyone trying to do a cast when the object is already a RenderBlock.
Making this change caught a bad cast in RenderBlock::layoutBlockChildren, so that is also fixed by this
patch with a containsFloats() check.
Reviewed by Darin Adler
* dom/PositionIterator.cpp:
(WebCore::PositionIterator::isCandidate):
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
* editing/Editor.cpp:
(WebCore::Editor::hasBidiSelection):
* page/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::anchorElement):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleWillChange):
(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::fillBlockSelectionGaps):
(WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
(WebCore::RenderBlock::firstLineBlock):
(WebCore::getLineAtIndex):
(WebCore::getHeightForLineCount):
(WebCore::RenderBlock::lineCount):
(WebCore::RenderBlock::adjustForBorderFit):
(WebCore::RenderBlock::clearTruncation):
* rendering/RenderBlock.h:
(WebCore::toRenderBlock):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::calcReplacedHeightUsing):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::inlineContinuation):
(WebCore::nextContinuation):
(WebCore::RenderInline::positionForCoordinates):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
* rendering/RenderListItem.cpp:
(WebCore::getParentOfFirstLineBox):
(WebCore::RenderListItem::positionListMarker):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
(WebCore::RenderObject::computeRectForRepaint):
(WebCore::RenderObject::removeFromObjectLists):
(WebCore::RenderObject::getTextDecorationColors):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
(WebCore::RenderTable::recalcSections):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::styleDidChange):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::block):
* rendering/bidi.cpp:
(WebCore::RenderBlock::createLineBoxes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40409
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 30 Jan 2009 17:30:47 +0000 (17:30 +0000)]
WebCore:
2009-01-30 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
- Let CachedFrame handle the suspending/resuming of active DOM objects itself instead of
relying on some outside force.
- Clear the previous history item inside FrameLoader instead of relying on multiple
FrameLoaderClients to do it.
* history/CachedFrame.cpp:
(WebCore::CachedFrame::CachedFrame): Suspend active DOM objects here.
(WebCore::CachedFrame::restore): Resume those DOM objects here.
* history/CachedFrame.h:
(WebCore::CachedFrame::domWindow):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad): Let CachedFrame creation handle the
suspending of active DOM objects.
(WebCore::FrameLoader::open): Let CachedFrame::restore() handle resuming those DOM objects.
(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Call frameLoadCompleted() instead
of performing a client call by itself.
(WebCore::FrameLoader::frameLoadCompleted):
WebKit/mac:
2009-01-30 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
Remove FrameLoaderClient code that is now handled by FrameLoader itself
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::frameLoadCompleted):
WebKit/qt:
2009-01-30 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
Remove FrameLoaderClient code that is now handled by FrameLoader itself
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::frameLoadCompleted):
WebKit/win:
2009-01-30 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
Remove FrameLoaderClient code that is now handled by FrameLoader itself
* WebFrame.cpp:
(WebFrame::frameLoadCompleted):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40408
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 30 Jan 2009 17:13:29 +0000 (17:13 +0000)]
Reviewed by Darin Adler.
Test that documents loaded from application cache cannot load local resources.
* http/tests/appcache/local-content-expected.txt: Added.
* http/tests/appcache/local-content.html: Added.
* http/tests/appcache/resources/local-content.manifest: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40407
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 30 Jan 2009 17:11:38 +0000 (17:11 +0000)]
Reviewed by Darin Adler.
<rdar://problem/6448823> Application Cache is kept after a private browsing session
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::selectCache):
(WebCore::ApplicationCacheGroup::update):
Cache update will not be started if private browsing is enabled. Existing cache version
from disk database will be used.
* loader/appcache/ApplicationCacheGroup.h: Made postListenerTask() static, in order to call
it when refusing to update from selectCache().
* loader/appcache/ApplicationCache.cpp:
(WebCore::ApplicationCache::addDynamicEntry):
(WebCore::ApplicationCache::removeDynamicEntry):
Added reminders about private browsing to unimplemented methods.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40406
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Fri, 30 Jan 2009 17:06:44 +0000 (17:06 +0000)]
2009-01-30 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=23615
Try to make this test reliable on buildbots.
* fast/dom/Window/resources/long_timeout.html:
Allocate more objects to make detection more reliable.
* fast/dom/Window/timeout-released-on-close.html:
Use threshold to account for objects allocated by the running scripts.
Add debug output in case of failure to help understand possible failures.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40405
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 30 Jan 2009 15:17:35 +0000 (15:17 +0000)]
2009-01-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Simon Hausmann.
Bug 23580: GNU mode RVCT compilation support
<https://bugs.webkit.org/show_bug.cgi?id=23580>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40404
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 30 Jan 2009 15:17:08 +0000 (15:17 +0000)]
2009-01-30 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Hide the Offline Web Application Cache path API from the public API
for now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40403
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 30 Jan 2009 13:15:12 +0000 (13:15 +0000)]
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=23639
Test that appcache ignores Cache-Control: no-store
* http/tests/resources/network-simulator.php: Send no-store with all responses.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40402
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 30 Jan 2009 13:13:28 +0000 (13:13 +0000)]
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=23640
Test that non-HTML main resources work with application cache correctly
* http/tests/appcache/non-html-expected.txt: Added.
* http/tests/appcache/non-html.xhtml: Added.
* http/tests/appcache/resources/abe.png: Added.
* http/tests/appcache/resources/non-html.manifest: Added.
* http/tests/resources/network-simulator.php: Support more file extensions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40401
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 30 Jan 2009 08:38:19 +0000 (08:38 +0000)]
2009-01-30 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Bug 23618: Templated worker tasks should be more error proof to use
<https://bugs.webkit.org/show_bug.cgi?id=23618>
Add the type traits needed for the generic worker tasks
and compile asserts for them.
Add a summary header to the TypeTraits.h file to explain what is in there.
Add a note to explain IsPod's deficiencies.
* wtf/TypeTraits.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40400
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log