WebKit-https.git
10 months agoSkip css-dark-mode tests on older macOS platforms
timothy@apple.com [Tue, 6 Nov 2018 23:57:39 +0000 (23:57 +0000)]
Skip css-dark-mode tests on older macOS platforms
https://bugs.webkit.org/show_bug.cgi?id=191334

Reviewed by Brian Burg.

* platform/mac-highsierra/css-dark-mode/prefers-color-scheme-expected.txt: Removed.
* platform/mac-highsierra/css-dark-mode/supported-color-schemes-expected.txt: Removed.
* platform/mac-sierra/css-dark-mode/prefers-color-scheme-expected.txt: Removed.
* platform/mac-sierra/css-dark-mode/supported-color-schemes-expected.txt: Removed.
* platform/mac/TestExpectations: Skip css-dark-mode for Sierra and HighSierra.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoAdd missing iOS availability macro to _WKAutomationSessionConfiguration
bburg@apple.com [Tue, 6 Nov 2018 23:54:00 +0000 (23:54 +0000)]
Add missing iOS availability macro to _WKAutomationSessionConfiguration
https://bugs.webkit.org/show_bug.cgi?id=191320

Reviewed by Tim Horton.

* UIProcess/API/Cocoa/_WKAutomationSessionConfiguration.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[ews-app] Fix Invalid HTTP_HOST header
aakash_jain@apple.com [Tue, 6 Nov 2018 23:24:12 +0000 (23:24 +0000)]
[ews-app] Fix Invalid HTTP_HOST header
https://bugs.webkit.org/show_bug.cgi?id=191325

Reviewed by Lucas Forschler.

Changing ALLOWED_HOSTS to * as the landing page should be publicly accessible.

* BuildSlaveSupport/ews-app/ews-app/settings.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[ews-app] Rename EWS_app to ews-app - part 2
aakash_jain@apple.com [Tue, 6 Nov 2018 23:16:38 +0000 (23:16 +0000)]
[ews-app] Rename EWS_app to ews-app - part 2
https://bugs.webkit.org/show_bug.cgi?id=191317

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-app/EWS_app: Removed.
* BuildSlaveSupport/ews-app/ews-app: Moved from BuildSlaveSupport/ews-app/EWS_app.
* BuildSlaveSupport/ews-app/ews-app/settings.py:
* BuildSlaveSupport/ews-app/ews-app/urls.py:
* BuildSlaveSupport/ews-app/ews-app/wsgi.py:
* BuildSlaveSupport/ews-app/manage.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoResource Load Statistics: Remove cap on partitioned cache max age if it matches a...
wilander@apple.com [Tue, 6 Nov 2018 23:10:36 +0000 (23:10 +0000)]
Resource Load Statistics: Remove cap on partitioned cache max age if it matches a network reload (redirect-only)
https://bugs.webkit.org/show_bug.cgi?id=189760
<rdar://problem/44612242>

Reviewed by Youenn Fablet and Antti Koivisto.

Source/WebCore:

No new tests. Existing test fleshed out.

* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::isRedirection const):
* platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::isRedirection const): Deleted.
    Moved to the implementation file so that I can export it without warning.

Source/WebKit:

When a redirect cache entry for a prevalent resource reaches its max
age cap, it is loaded again from the network and the network response
is compared with what's in the cache. If it's a match, the cache entry
is fully accepted. If not, a new capped cache entry is created.

This feature is still off by default.

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::canUseCachedRedirect const):
    Now checks the new member m_cacheEntryForMaxAgeCapValidation.
(WebKit::NetworkResourceLoader::retrieveCacheEntry):
    New case handled for entry->hasReachedPrevalentResourceAgeCap().
(WebKit::NetworkResourceLoader::validateCacheEntryForMaxAgeCapValidation):
    This is where the new logic compares the incoming redirect with the
    cached one. If they match, an uncapped entry is allowed to be stored.
    If they don't match, a new capped entry will be stored.
(WebKit::NetworkResourceLoader::willSendRedirectedRequest):
    Now calls the new
    NetworkResourceLoader::validateCacheEntryForMaxAgeCapValidation()
    function.
* NetworkProcess/NetworkResourceLoader.h:
    Added the m_cacheEntryForMaxAgeCapValidation member.
* NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::makeUseDecision):
    Restored to previous behavior which means
    UseDecision::NoDueToPrevalentResourceAgeCap was removed.
(WebKit::NetworkCache::Cache::retrieve):
    Restored to previous behavior.
(WebKit::NetworkCache::Cache::storeRedirect):
    Now takes the optional maxAgeCap and caps the entry's max age if it's set.
(WebKit::NetworkCache::hasReachedPrevalentResourceAgeCap): Deleted.
* NetworkProcess/cache/NetworkCache.h:
* NetworkProcess/cache/NetworkCacheEntry.cpp:
(WebKit::NetworkCache::Entry::encodeAsStorageRecord const):
    Now encodes m_maxAgeCap.
(WebKit::NetworkCache::Entry::decodeStorageRecord):
    Now decodes m_maxAgeCap.
(WebKit::NetworkCache::Entry::hasReachedPrevalentResourceAgeCap const):
    Added.
(WebKit::NetworkCache::Entry::capMaxAge):
    Added.
* NetworkProcess/cache/NetworkCacheEntry.h:
    Added the optional m_maxAgeCap.
* NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:
(WebKit::NetworkCache::SpeculativeLoad::willSendRedirectedRequest):
    Now gets the optional max age cap from the NetworkStorageSession and sends it
    to Cache::storeRedirect().
* NetworkProcess/cache/NetworkCacheStatistics.cpp:
(WebKit::NetworkCache::cachedEntryReuseFailureToDiagnosticKey):
    Removed handling of UseDecision::NoDueToPrevalentResourceAgeCap.

LayoutTests:

* http/tests/resourceLoadStatistics/cap-cache-max-age-for-prevalent-resource-expected.txt:
* http/tests/resourceLoadStatistics/cap-cache-max-age-for-prevalent-resource.html:
    The test now performs:
    - an initial Fetch request with a permanent redirect to ID 1234. Capped max age.
    - a second Fetch request with a permanent redirect to ID 4321. Capped max age.
    - a third Fetch request with a permanent redirect to and empty ID. Capped max age.
    - a fourth Fetch request with a permanent redirect to and empty ID. Max age cap removed.
    - a fifth Fetch request with a permanent redirect to and empty ID. Regular cache hit.
* http/tests/resourceLoadStatistics/resources/cached-permanent-redirect.php:
    Now returns an HTTP 500 if the request contains validation headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[ews-app] Rename EWS_app to ews-app - part 1
aakash_jain@apple.com [Tue, 6 Nov 2018 23:08:51 +0000 (23:08 +0000)]
[ews-app] Rename EWS_app to ews-app - part 1
https://bugs.webkit.org/show_bug.cgi?id=191317

Reviewed by Lucas Forschler.

* BuildSlaveSupport/EWS_app: Removed.
* BuildSlaveSupport/ews-app: Moved from BuildSlaveSupport/EWS_app.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoSpelling dots are drawn in the wrong place
mmaxfield@apple.com [Tue, 6 Nov 2018 23:06:37 +0000 (23:06 +0000)]
Spelling dots are drawn in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=190764

Reviewed by Dean Jackson.

Source/WebCore:

- Dots should not be clipped.
- Dots should be horizontally centered.
- Dots should be drawn behind the text.
- Distance from the baseline to the top of the dot should be 11.035% of font size.
- Dot diameter should be 13.247% of the font size.
- Distance between the dots (right side of the left dot to left side of the right dot) should be 9.457% of the font size.
- The "font size" used in these calculations should be clamped so it's 10px <= font size <= 40px.

Tests: editing/spelling/spelling-dots-position-2.html
       editing/spelling/spelling-dots-position-3.html
       editing/spelling/spelling-dots-position.html
       editing/spelling/spelling-dots-repaint.html

* platform/graphics/cocoa/GraphicsContextCocoa.mm:
(WebCore::colorForMarkerLineStyle): Align iOS and macOS implementations.
(WebCore::GraphicsContext::drawDotsForDocumentMarker): Place the dots correctly.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addToLine): The KnownToHaveNoOverflow flag should be cleared if the element has spelling dots,
    because there is no guarantee the spelling dots will lie inside the layout rect of the element.
(WebCore::InlineFlowBox::addTextBoxVisualOverflow): Update the repaint rects to include splling dot positions.
* rendering/InlineFlowBox.h: Comments should explain why, not say what.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint): Draw the dots behind the text.
(WebCore::InlineTextBox::hasMarkers const): Convenience.
(WebCore::InlineTextBox::paintPlatformDocumentMarkers): Refactor bounds information into a helper function.
(WebCore::InlineTextBox::calculateUnionOfAllDocumentMarkerBounds const): Use for repaint rect calculation.
(WebCore::InlineTextBox::calculateDocumentMarkerBounds const): Place the dots correctly.
(WebCore::InlineTextBox::paintPlatformDocumentMarker): Call the helper method.
(WebCore::InlineTextBox::collectMarkedTextsForDocumentMarkers const):
(WebCore::InlineTextBox::collectMarkedTextsForDocumentMarkers): Deleted.
* rendering/InlineTextBox.h: Declare the helper methods.
* rendering/SimpleLineLayout.cpp: Simple line layout doesn't know how to paint spelling dots, so make the presence of
    spelling dots opt us out of SLL.
(WebCore::SimpleLineLayout::canUseForWithReason):
* rendering/SimpleLineLayoutCoverage.cpp:
(WebCore::SimpleLineLayout::printReason):
* rendering/SimpleLineLayoutCoverage.h: Add a new opt-out reason.

Tools:

Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
dots to be drawn.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):
(WTR::TestController::platformResetStateToConsistentValues):
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::hasSameInitializationOptions const):
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::cocoaResetStateToConsistentValues):
* WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
* WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::platformResetStateToConsistentValues):
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::platformResetStateToConsistentValues):

LayoutTests:

* editing/spelling/resources/VerySmallDescentAhem.ttf: Added. In order to test repaint rects,
      this is a version of Ahem with a very small descent, so that the dots don't intersect
      with the text itself.
* editing/spelling/spelling-dots-position-2-expected-mismatch.html: Added.
* editing/spelling/spelling-dots-position-2.html: Added. Make sure dots are painted in the
      correct vertical place.
* editing/spelling/spelling-dots-position-3-expected-mismatch.html: Added.
* editing/spelling/spelling-dots-position-3.html: Added. Make sure dots are painted in the
      correct vertical place.
* editing/spelling/spelling-dots-position-expected.html: Added.
* editing/spelling/spelling-dots-position.html: Added. Make sure dots are not painted in
      the wrong place.
* editing/spelling/spelling-dots-repaint-expected.html: Added.
* editing/spelling/spelling-dots-repaint.html: Added. Test repaint by drawing an element
      with spelling dots, and then deleting the element from the document. The spelling
      dots should be removed too.
* fast/writing-mode/english-bt-text-with-spelling-marker-expected.html:
* fast/writing-mode/english-bt-text-with-spelling-marker.html: Update the test to compensate
      for new spelling dot positions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[WinCairo] Unreviewed layout test gardening.
ross.kirsling@sony.com [Tue, 6 Nov 2018 22:49:01 +0000 (22:49 +0000)]
[WinCairo] Unreviewed layout test gardening.

* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoFeature flags not present for Visual Studio when using build-webkit
don.olmstead@sony.com [Tue, 6 Nov 2018 22:10:30 +0000 (22:10 +0000)]
Feature flags not present for Visual Studio when using build-webkit
https://bugs.webkit.org/show_bug.cgi?id=191288

Reviewed by Fujii Hironori.

Passes feature flags to Visual studio builds within build-webkit.
Removes cmakeBasedPortArguments as it is no longer in use.

* Scripts/build-jsc:
* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
(cmakeBasedPortArguments): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoREGRESSION (r230523): Caps lock indicator not shown in password field
pvollan@apple.com [Tue, 6 Nov 2018 21:58:29 +0000 (21:58 +0000)]
REGRESSION (r230523): Caps lock indicator not shown in password field
https://bugs.webkit.org/show_bug.cgi?id=190056

Reviewed by Ryosuke Niwa.

Source/WebCore:

When WindowServer access is blocked, GetCurrentModifiers() always returns 0. Instead of calling
GetCurrentModifiers(), store the current modifiers from the key event argument in the method
WebKit::WebPage::keyEvent, and use the stored value to detect if Caps lock is on. Additionally,
the modifiers needs to be updated when the window becomes active.

Test: fast/events/detect-caps-lock.html

* Sources.txt:
* platform/PlatformKeyboardEvent.h:
* platform/graphics/FontTaggedSettings.cpp:
* platform/mac/KeyEventMac.mm:
(WebCore::PlatformKeyboardEvent::currentCapsLockState):
(WebCore::PlatformKeyboardEvent::getCurrentModifierState):
* testing/Internals.cpp:
(WebCore::Internals::capsLockIsOn):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit:

Update cached modifier state in the WebProcess when WebKit::WebPage::keyEvent is called, and
when the window becomes active.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::dispatchActivityStateChange):
(WebKit::WebPageProxy::updateCurrentModifierState):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::keyEvent):
(WebKit::WebPage::updateCurrentModifierState):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

Tools:

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::toggleCapsLock):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::toggleCapsLock):

LayoutTests:

* TestExpectations:
* fast/events/detect-caps-lock-expected.txt: Added.
* fast/events/detect-caps-lock.html: Added.
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoAdd ObjC SPI equivalent of WKContextHandlesSafeBrowsing
achristensen@apple.com [Tue, 6 Nov 2018 21:53:21 +0000 (21:53 +0000)]
Add ObjC SPI equivalent of WKContextHandlesSafeBrowsing
https://bugs.webkit.org/show_bug.cgi?id=191329

Reviewed by Tim Horton.

Like WKContextHandlesSafeBrowsing, this is so I can make one change in WebKit and enable safe browsing
in WKWebView and disable it in Safari at the same time without broken revisions between landing two changes
in two repositories.

* UIProcess/API/Cocoa/WKWebView.mm:
(+[WKWebView handlesSafeBrowsing]):
* UIProcess/API/Cocoa/WKWebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoCSS grid elements with justify-content: space-around have extra whitespace, sometimes...
jfernandez@igalia.com [Tue, 6 Nov 2018 21:45:40 +0000 (21:45 +0000)]
CSS grid elements with justify-content: space-around have extra whitespace, sometimes a lot
https://bugs.webkit.org/show_bug.cgi?id=191308

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Imported WPT to cover the behavior changes added in this patch.

* resources/import-expectations.json:
* web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-001-expected.txt: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-001.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-002-expected.txt: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-002.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-003-expected.txt: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-003.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-004-expected.txt: Added.
* web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-004.html: Added.
* web-platform-tests/css/css-grid/layout-algorithm/w3c-import.log:

Source/WebCore:

The CSS WG resolved [1] that Content Alignment should account to the
track sizing algorithm.

The sizing algorithm has been modified so that two new steps (1.5
and 2.5) were added to compute the Content Alignment offsets after
resolving the columns' and rows' sizes respectively.

This change decouples the Content Alignment logic from the tracks
position, so that we can use it as part of the track sizing algorithm.

I also had to store the whole ContentAlignmentData structure in two
class attributes. We need both, position and distribution offsets, to
be used in different parts of the layout logic.

[1] https://github.com/w3c/csswg-drafts/issues/2557

Tests: imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-001.html
       imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-002.html
       imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-003.html
       imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-004.html
       imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-filled-shrinkwrap-001.html
       imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-spanned-shrinkwrap-001.html
       imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-filled-shrinkwrap-001.html
       imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-spanned-shrinkwrap-001.html

* rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::gridAreaBreadthForChild const):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::repeatTracksSizingIfNeeded):
(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::gridItemOffset const):
(WebCore::RenderGrid::trackSizesForComputedStyle const):
(WebCore::RenderGrid::populateGridPositionsForDirection):
(WebCore::RenderGrid::gridAreaBreadthForOutOfFlowChild):
(WebCore::contentDistributionOffset):
(WebCore::RenderGrid::computeContentPositionAndDistributionOffset):
(WebCore::RenderGrid::nonCollapsedTracks const):
* rendering/RenderGrid.h:
(WebCore::ContentAlignmentData::isValid):
(WebCore::ContentAlignmentData::defaultOffsets):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoREGRESSION: Web Inspector: Popovers drawing incorrectly in Network Tab (clicking...
commit-queue@webkit.org [Tue, 6 Nov 2018 21:34:27 +0000 (21:34 +0000)]
REGRESSION: Web Inspector: Popovers drawing incorrectly in Network Tab (clicking between a few items)
https://bugs.webkit.org/show_bug.cgi?id=191323

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2018-11-06
Reviewed by Devin Rousso.

* UserInterface/Views/Popover.js:
(WI.Popover.prototype._drawBackground):
Save and restore the context state between updates. Something
was affecting the clearRect, making it so that it didn't actually
clear the entire rect each time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoIndexedDB: WAL file keeps growing
sihui_liu@apple.com [Tue, 6 Nov 2018 20:56:54 +0000 (20:56 +0000)]
IndexedDB: WAL file keeps growing
https://bugs.webkit.org/show_bug.cgi?id=191294
<rdar://problem/41333493>

Reviewed by Chris Dumez.

Source/WebCore:

When we quit apps, the database connection may not be shut down properly, and WAL file will be retained on disk.
On the next open of database connection, new logs will be appended to the original WAL file, which keeps
increasing size of the WAL file. We should do a manual checkpoint when we open a IndexedDB to make sure previous
log is written to database and truncate WAL file.

Test: IndexedDB.IndexedDBTempFileSize

* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::open):

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-1.html: Added.
* TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-2.html: Added.
* TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm: Added.
(-[IndexedDBFileSizeMessageHandler userContentController:didReceiveScriptMessage:]):
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoAdjust handling of Include paths that need quoting
krollin@apple.com [Tue, 6 Nov 2018 20:54:55 +0000 (20:54 +0000)]
Adjust handling of Include paths that need quoting
https://bugs.webkit.org/show_bug.cgi?id=191314
<rdar://problem/45849143>

Reviewed by Dan Bernstein.

There are several places in the JavaScriptCore Xcode project where the
paths defined in HEADER_SEARCH_PATHS are quoted. That is, the
definitions look like:

    HEADER_SEARCH_PATHS = (
        "\"${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore\"",
        "\"${BUILT_PRODUCTS_DIR}/LLIntOffsets/${ARCHS}\"",
        "\"$(JAVASCRIPTCORE_FRAMEWORKS_DIR)/JavaScriptCore.framework/PrivateHeaders\"",
        "$(inherited)",
    );

The idea here is presumably to have the resulting $(CPP) command have
-I options where the associated paths are themselves quoted,
protecting against space characters in the paths.

This approach to quote management can break under Xcode 9. If
.xcfilelist files are added to the project, the 'objectVersion' value
in the Xcode project file is changed from 46 to 51. If a project with
objectVersion=51 is presented to Xcode 9 (as can happen when we build
for older OS's), it produces build lines where the quotes are escaped,
thereby becoming part of the path. The build then fails because a
search for a file normally found in a directory called "Foo" will be
looked for in "\"Foo\"", which doesn't exist.

Simply removing the escaped quotes from the HEADER_SEARCH_PATHS
definition doesn't work, leading to paths that need quoting due to
space characters but that don't get this quoting (the part of the path
after the space appears to simply go missing).

Removing the escaped quotes from the HEADER_SEARCH_PATHS and moving
the definitions to the .xcconfig fixes this problem.

* Configurations/ToolExecutable.xcconfig:
* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoIntersectionObserver doesn't keep target's JS wrapper alive
ajuma@chromium.org [Tue, 6 Nov 2018 20:52:51 +0000 (20:52 +0000)]
IntersectionObserver doesn't keep target's JS wrapper alive
https://bugs.webkit.org/show_bug.cgi?id=190235

Reviewed by Ryosuke Niwa.

Source/WebCore:

Retain JS wrappers of targets in queued entries using a vector of GCReachableRef owned by
IntersectionObserver, which gets cleared after the entries have been delivered.

Make IntersectionObserver::takeRecords return a struct which has both the vector of GCReachableRefs
for targets and the vector of intersection observer entries, so that the GCReachableRefs survive
until the creation of JS wrappers for the entries.

Modify IntersectionObserver::hasPendingActivity to keep the observer alive while it has
entries to deliver.

Tests: intersection-observer/intersection-observer-entry-keeps-js-wrapper-of-target-alive.html
       intersection-observer/intersection-observer-keeps-js-wrapper-of-target-alive.html
       intersection-observer/target-deleted.html

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSIntersectionObserverEntryCustom.cpp:
(WebCore::JSIntersectionObserverEntry::visitAdditionalChildren): Keep the target element's wrapper alive while the
IntersectionObserverEntry's wrapper is alive.
* page/IntersectionObserver.cpp:
(WebCore::IntersectionObserver::takeRecords): Change return type to include GCReachableRefs for each record's target, so that
each target can be kept until a JS wrapper is constructed for its IntersectionObserverEntry.
(WebCore::IntersectionObserver::appendQueuedEntry):
(WebCore::IntersectionObserver::notify): Erase GCReachableRefs for targets after delivering the corresponding records.
(WebCore::IntersectionObserver::hasPendingActivity const): Keep the IntersectionObserver alive until queued entries are delivered.
(WebCore::IntersectionObserver::stop):
* page/IntersectionObserver.h:
* page/IntersectionObserver.idl:
* page/IntersectionObserverEntry.h:
(WebCore::IntersectionObserverEntry::target const): Make this return a raw pointer instead of a RefPtr so that it
can be called in JSIntersectionObserverEntry::visitAdditionalChildren, which runs on the GC thread (it's illegal to ref a Node
on a non-main thread).
* page/IntersectionObserverEntry.idl:

LayoutTests:

Add test coverage.

Update test that depends on a target getting GC'd to call takeRecords() since
targets with pending entries are no logner GC'd.

* intersection-observer/intersection-observer-entry-keeps-js-wrapper-of-target-alive-expected.txt: Added.
* intersection-observer/intersection-observer-entry-keeps-js-wrapper-of-target-alive.html: Added.
* intersection-observer/intersection-observer-keeps-js-wrapper-of-target-alive-expected.txt: Added.
* intersection-observer/intersection-observer-keeps-js-wrapper-of-target-alive.html: Added.
* intersection-observer/root-element-deleted.html:
* intersection-observer/target-deleted-expected.txt: Added.
* intersection-observer/target-deleted.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[MediaStream] User should not be prompted again after denying getDisplayMedia request
eric.carlson@apple.com [Tue, 6 Nov 2018 20:12:41 +0000 (20:12 +0000)]
[MediaStream] User should not be prompted again after denying getDisplayMedia request
https://bugs.webkit.org/show_bug.cgi?id=191227
<rdar://problem/45784512>

Reviewed by Youenn Fablet.

Source/WebKit:

* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasDenied):
(WebKit::UserMediaPermissionRequestManagerProxy::wasRequestDenied):
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
* UIProcess/UserMediaPermissionRequestManagerProxy.h:

LayoutTests:

* TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
(-[GetDisplayMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
(TestWebKitAPI::GetDisplayMediaTest::promptForCapture):
(TestWebKitAPI::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago<picture> container doesn't update when prefers-color-scheme media query changes
timothy@apple.com [Tue, 6 Nov 2018 19:53:13 +0000 (19:53 +0000)]
<picture> container doesn't update when prefers-color-scheme media query changes
https://bugs.webkit.org/show_bug.cgi?id=190913
rdar://problem/45608456

Reviewed by Dean Jackson.

Source/WebCore:

Test: css-dark-mode/prefers-color-scheme-picture-element.html

* css/MediaQueryEvaluator.cpp:
(WebCore::isAppearanceDependent): Added.
(WebCore::MediaQueryEvaluator::evaluate const): Keep track of appearanceDependentResults.
* css/MediaQueryEvaluator.h:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::addAppearanceDependentMediaQueryResult): Added.
(WebCore::StyleResolver::hasMediaQueriesAffectedByAppearanceChange const): Added.
* css/StyleResolver.h:
(WebCore::StyleResolver::hasAppearanceDependentMediaQueries const): Added.
* dom/Document.cpp:
(WebCore::Document::evaluateMediaQueryList): Call checkAppearanceDependentPictures.
(WebCore::Document::checkAppearanceDependentPictures): Added.
(WebCore::Document::addAppearanceDependentPicture): Added.
(WebCore::Document::removeAppearanceDependentPicture): Added.
* dom/Document.h:
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::bestFitSourceFromPictureElement): Call addAppearanceDependentPicture.
* html/HTMLPictureElement.cpp:
(WebCore::HTMLPictureElement::~HTMLPictureElement): Call removeAppearanceDependentPicture.
(WebCore::HTMLPictureElement::didMoveToNewDocument): Ditto.
(WebCore::HTMLPictureElement::appearanceChangeAffectedPicture const): Added.
* html/HTMLPictureElement.h:
* page/Page.cpp:
(WebCore::Page::appearanceDidChange): Added.
(WebCore::Page::setUseSystemAppearance): Call appearanceDidChange.
(WebCore::Page::setUseDarkAppearance): Call appearanceDidChange.
* page/Page.h:
* style/StyleScope.cpp:
(WebCore::Style::Scope::evaluateMediaQueriesForAppearanceChange): Added.
* style/StyleScope.h:

LayoutTests:

* css-dark-mode/prefers-color-scheme-picture-element-expected.txt: Added.
* css-dark-mode/prefers-color-scheme-picture-element.html: Added.
* platform/mac-highsierra/css-dark-mode/prefers-color-scheme-picture-element-expected.txt: Added.
* platform/mac-sierra/css-dark-mode/prefers-color-scheme-picture-element-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoMultiple stress/regexp-compile-oom.js tests are failing on High Sierra Debug and...
msaboff@apple.com [Tue, 6 Nov 2018 19:19:06 +0000 (19:19 +0000)]
Multiple stress/regexp-compile-oom.js tests are failing on High Sierra Debug and Release JSC testers.
https://bugs.webkit.org/show_bug.cgi?id=191271

Reviewed by Saam Barati.

JSTests:

Added more test cases and made all test cases run with the same deeply recursive stack
instead of finding that same point for each test case.

* stress/regexp-compile-oom.js:
(prototype.runTest):
(recurseAndTest):
(testList.push.new.TestAndExpectedException):

Source/JavaScriptCore:

Fixed use of ThrowScope my adding release() calls.  Found a few places where we needed
RETURN_IF_EXCEPTION().  After some code inspections determined that we need to cover the
exception bubbling for String.match() with a global RegExp as well as String.replace()
and String.search().

* runtime/RegExpObjectInlines.h:
(JSC::RegExpObject::matchInline):
(JSC::collectMatches):
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncSearchFast):
* runtime/StringPrototype.cpp:
(JSC::removeUsingRegExpSearch):
(JSC::replaceUsingRegExpSearch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoFix tests after r237863
achristensen@apple.com [Tue, 6 Nov 2018 19:03:45 +0000 (19:03 +0000)]
Fix tests after r237863
https://bugs.webkit.org/show_bug.cgi?id=191315

Reviewed by Chris Dumez.

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
With the timing change of r237863, the WKWebView progressed further than before when loading main.html so it completed before main2.html.
This test was meant to test that main2.html does eventually load, and it doesn't matter if main.html loads before it.  I updated the test
to verify that main2.html eventually loads, making this test less timing dependent.

LayoutTests:

* platform/mac-wk2/http/tests/navigation: Added.
* platform/mac-wk2/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt: Copied from LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt.
This test is timing related, and I need to update its WK2 expectations every time I enable or disable safe browsing checks during navigation.
See r237149.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoUnreviewed, rolling out r237834.
ryanhaddad@apple.com [Tue, 6 Nov 2018 18:23:37 +0000 (18:23 +0000)]
Unreviewed, rolling out r237834.

Tests for this change crash on iOS Simulator

Reverted changeset:

"Spelling dots are drawn in the wrong place"
https://bugs.webkit.org/show_bug.cgi?id=190764
https://trac.webkit.org/changeset/237834

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[Web Animations] transitions/remove-transition-style.html crashes with GuardMalloc on
graouts@webkit.org [Tue, 6 Nov 2018 17:44:40 +0000 (17:44 +0000)]
[Web Animations] transitions/remove-transition-style.html crashes with GuardMalloc on
https://bugs.webkit.org/show_bug.cgi?id=191304
<rdar://problem/45819476>

Reviewed by Dean Jackson.

Ensure we remove animations from the m_allAnimations ListHashSet upon destruction.

* animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::forgetAnimation):
(WebCore::AnimationTimeline::cancelDeclarativeAnimation):
* animation/AnimationTimeline.h:
* animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::getAnimations const):
* animation/WebAnimation.cpp:
(WebCore::WebAnimation::~WebAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoRealtimeOutgoingAudioSourceCocoa should unobserve its source at destruction time
youenn@apple.com [Tue, 6 Nov 2018 16:14:27 +0000 (16:14 +0000)]
RealtimeOutgoingAudioSourceCocoa should unobserve its source at destruction time
https://bugs.webkit.org/show_bug.cgi?id=191295

Reviewed by Eric Carlson.

Make RealtimeOutgoingAudioSource subclasses unobserve their source
inside their destructor instead of RealtimeOutgoingAudioSource.
This is consistent with how starting to observe works.
Covered by existing tests.

* platform/mediastream/RealtimeOutgoingAudioSource.cpp:
(WebCore::RealtimeOutgoingAudioSource::unobserveSource):
* platform/mediastream/RealtimeOutgoingAudioSource.h:
* platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.cpp:
(WebCore::RealtimeOutgoingAudioSourceLibWebRTC::~RealtimeOutgoingAudioSourceLibWebRTC):
* platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.cpp:
(WebCore::RealtimeOutgoingAudioSourceCocoa::RealtimeOutgoingAudioSourceCocoa):
(WebCore::RealtimeOutgoingAudioSourceCocoa::~RealtimeOutgoingAudioSourceCocoa):
* platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoMake sure RTCIceCandidateStats address is undefined for host and peer reflexive case
youenn@apple.com [Tue, 6 Nov 2018 15:56:59 +0000 (15:56 +0000)]
Make sure RTCIceCandidateStats address is undefined for host and peer reflexive case
https://bugs.webkit.org/show_bug.cgi?id=191263

Reviewed by Eric Carlson.

Source/WebCore:

Test: webrtc/datachannel/getStats-no-prflx-remote-candidate.html

* Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp:
(WebCore::fillRTCIceCandidateStats):

LayoutTests:

* webrtc/datachannel/getStats-no-prflx-remote-candidate-expected.txt: Added.
* webrtc/datachannel/getStats-no-prflx-remote-candidate.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[GStreamer][WebRTC] Handle setting max number of frame between keyframes
commit-queue@webkit.org [Tue, 6 Nov 2018 15:54:34 +0000 (15:54 +0000)]
[GStreamer][WebRTC] Handle setting max number of frame between keyframes
https://bugs.webkit.org/show_bug.cgi?id=190682

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-06
Reviewed by Philippe Normand.

That has been manually checked.

* platform/mediastream/libwebrtc/GStreamerVideoEncoder.cpp:
(gst_webrtc_video_encoder_get_property):
(gst_webrtc_video_encoder_set_property):
(register_known_encoder):
(gst_webrtc_video_encoder_class_init):
* platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:
(WebCore::GStreamerVideoEncoder::InitEncode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoLayout Test imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescrip...
youenn@apple.com [Tue, 6 Nov 2018 15:46:13 +0000 (15:46 +0000)]
Layout Test imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=191278

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Updating test according upstreamed WPT.
Rebased test accordingly.

* web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https-expected.txt:
* web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html:

LayoutTests:

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[Mac] Implement safe browsing in WebKit
achristensen@apple.com [Tue, 6 Nov 2018 15:26:08 +0000 (15:26 +0000)]
[Mac] Implement safe browsing in WebKit
https://bugs.webkit.org/show_bug.cgi?id=188871

Reviewed by Tim Horton.

Source/WebCore:

* en.lproj/Localizable.strings:

Source/WebKit:

* Platform/spi/Cocoa/SafeBrowsingSPI.h:
* Resources/SafeBrowsing.xcassets: Added.
* Resources/SafeBrowsing.xcassets/Contents.json: Added.
* Resources/SafeBrowsing.xcassets/WKSafeBrowsingWarningBackground.colorset: Added.
* Resources/SafeBrowsing.xcassets/WKSafeBrowsingWarningBackground.colorset/Contents.json: Added.
* Resources/SafeBrowsing.xcassets/WKSafeBrowsingWarningText.colorset: Added.
* Resources/SafeBrowsing.xcassets/WKSafeBrowsingWarningText.colorset/Contents.json: Added.
* Resources/SafeBrowsing.xcassets/WKSafeBrowsingWarningTitle.colorset: Added.
* Resources/SafeBrowsing.xcassets/WKSafeBrowsingWarningTitle.colorset/Contents.json: Added.
* Shared/WebPreferences.yaml:
* Shared/WebPreferencesDefaultValues.h:
* UIProcess/API/C/mac/WKContextPrivateMac.mm:
(WKContextHandlesSafeBrowsing):
* UIProcess/Cocoa/SafeBrowsingResultCocoa.mm:
(WebKit::malwareDetailsBase):
(WebKit::learnMore):
(WebKit::reportAnErrorBase):
(WebKit::localizedProvider):
(WebKit::SafeBrowsingResult::SafeBrowsingResult):
* UIProcess/Cocoa/WKSafeBrowsingWarning.h: Added.
* UIProcess/Cocoa/WKSafeBrowsingWarning.mm: Added.
(confirmMalwareSentinel):
(visitUnsafeWebsiteSentinel):
(colorNamed):
(replace):
(addLinkAndReplace):
(-[WKSafeBrowsingExclamationPoint drawRect:]):
(-[WKSafeBrowsingExclamationPoint intrinsicContentSize]):
(reportAnErrorURL):
(malwareDetailsURL):
(titleText):
(warningText):
(detailsText):
(-[WKSafeBrowsingWarning initWithFrame:safeBrowsingResult:completionHandler:]):
(-[WKSafeBrowsingWarning dealloc]):
(-[WKSafeBrowsingWarning goBackClicked]):
(-[WKSafeBrowsingWarning clickedOnLink:]):
(-[WKSafeBrowsingWarning showDetailsClicked]):
(+[WKSafeBrowsingTextView viewWithAttributedString:linkTarget:]):
(+[WKSafeBrowsingTextView viewWithString:]):
(-[WKSafeBrowsingTextView intrinsicContentSize]):
(-[WKSafeBrowsingTextView clickedOnLink:atIndex:]):
* UIProcess/Cocoa/WebViewImpl.h:
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::showSafeBrowsingWarning):
(WebKit::WebViewImpl::clearSafeBrowsingWarning):
(WebKit::WebViewImpl::setFrameSize):
* UIProcess/PageClient.h:
(WebKit::PageClient::showSafeBrowsingWarning):
(WebKit::PageClient::clearSafeBrowsingWarning):
* UIProcess/SafeBrowsingResult.h:
(WebKit::SafeBrowsingResult::url const):
(WebKit::SafeBrowsingResult::provider const):
(WebKit::SafeBrowsingResult::localizedProviderName const):
(WebKit::SafeBrowsingResult::malwareDetailsURLBase const):
(WebKit::SafeBrowsingResult::reportAnErrorURLBase const):
(WebKit::SafeBrowsingResult::learnMoreURL const):
(WebKit::SafeBrowsingResult::needsSafeBrowsingWarning const):
(WebKit::SafeBrowsingResult::isKnownToBeUnsafe const): Deleted.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::showSafeBrowsingWarning):
(WebKit::PageClientImpl::clearSafeBrowsingWarning):
* UIProcess/mac/PageClientImplMac.h:
* UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::setImpl):
(WebKit::PageClientImpl::showSafeBrowsingWarning):
(WebKit::PageClientImpl::clearSafeBrowsingWarning):
* WebKit.xcodeproj/project.pbxproj:

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
(-[SafeBrowsingNavigationDelegate webView:didCommitNavigation:]):
(+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:]):
(-[TestLookupContext lookUpURL:completionHandler:]):
(simpleURL):
(safeBrowsingView):
(TEST):
(-[SafeBrowsingNavigationDelegate webView:didFinishNavigation:]): Deleted.
(+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:knownToBeUnsafe:]): Deleted.
(-[TestServiceLookupResult isKnownToBeUnsafe]): Deleted.
* TestWebKitAPI/Utilities.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[IntersectionObserver] Account for CSS zoom when computing client rects
ajuma@chromium.org [Tue, 6 Nov 2018 14:59:12 +0000 (14:59 +0000)]
[IntersectionObserver] Account for CSS zoom when computing client rects
https://bugs.webkit.org/show_bug.cgi?id=191282

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Update expectation for test case that now passes.

* web-platform-tests/intersection-observer/bounding-box-expected.txt:

Source/WebCore:

When computing rects for an IntersectionObserverEntry, account for the effective zoom when
converting from absolute to client coordinates.

Test: web-platform-tests/intersection-observer/bounding-box.html

* dom/Document.cpp:
(WebCore::Document::updateIntersectionObservations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[GStreamer][WebRTC] Implement black frame generation
commit-queue@webkit.org [Tue, 6 Nov 2018 14:47:37 +0000 (14:47 +0000)]
[GStreamer][WebRTC] Implement black frame generation
https://bugs.webkit.org/show_bug.cgi?id=190684

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-06
Reviewed by Xabier Rodriguez-Calvar.

Avoiding webrtc/video-mute-vp8.html to crash but it still fails because
we are missing the canvas bridging code.

Source/WebCore:

* platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceLibWebRTC.cpp:
(WebCore::RealtimeOutgoingVideoSourceLibWebRTC::createBlackFrame):
* platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceLibWebRTC.h:

LayoutTests:

* platform/gtk/TestExpectations:
* platform/wpe/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[GStreamer][WebRTC] Do not try to handle framerate modulation in the encoder
commit-queue@webkit.org [Tue, 6 Nov 2018 14:23:24 +0000 (14:23 +0000)]
[GStreamer][WebRTC] Do not try to handle framerate modulation in the encoder
https://bugs.webkit.org/show_bug.cgi?id=190683

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-06
Reviewed by Philippe Normand.

This has to already be handled in capturing pipeline or in libwebrtc itself.

No other encoder implementation do that, and libwebrtc is not happy with encoder that do not output the exact number of frames that have been passed in.

No regressions detected and libwebrtc is happier this way, less warning output and no more frame corruption in H264 streams found.

* platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:
(WebCore::GStreamerVideoEncoder::InitEncode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoUnreviewed, follow-up of previous commit.
fred.wang@free.fr [Tue, 6 Nov 2018 11:37:05 +0000 (11:37 +0000)]
Unreviewed, follow-up of previous commit.

Actually move OptionSet in the header since it's used there too.

Patch by Frederic Wang <fwang@igalia.com> on 2018-11-06

* page/WindowFeatures.cpp:
* page/WindowFeatures.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoUnreviewed build fix.
fred.wang@free.fr [Tue, 6 Nov 2018 11:30:09 +0000 (11:30 +0000)]
Unreviewed build fix.

Patch by Frederic Wang <fwang@igalia.com> on 2018-11-06

* page/WindowFeatures.cpp: Add missing header for OptionSet.
* platform/graphics/FontTaggedSettings.cpp: Add missing header for IntegerHash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[Web Animations] Update all tests to match the latest API changes
graouts@webkit.org [Tue, 6 Nov 2018 11:16:48 +0000 (11:16 +0000)]
[Web Animations] Update all tests to match the latest API changes
https://bugs.webkit.org/show_bug.cgi?id=191302
<rdar://problem/41000438>

Reviewed by Dean Jackson.

LayoutTests/imported/mozilla:

* css-animations/test_animation-computed-timing.html:
* css-animations/test_effect-target.html:
* css-animations/test_keyframeeffect-getkeyframes-expected.txt:
* css-animations/test_keyframeeffect-getkeyframes.html:
* css-animations/test_pseudoElement-get-animations.html:
* css-transitions/test_effect-target.html:
* css-transitions/test_keyframeeffect-getkeyframes-expected.txt:
* css-transitions/test_keyframeeffect-getkeyframes.html:

LayoutTests/imported/w3c:

* web-platform-tests/css-timing-1/cubic-bezier-timing-functions-output.html:
* web-platform-tests/web-animations/META.yml: Added.
* web-platform-tests/web-animations/README.md: Added.
* web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property.html:
* web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/addition-per-property.html:
* web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property.html:
* web-platform-tests/web-animations/animation-model/animation-types/property-list.js:
* web-platform-tests/web-animations/animation-model/animation-types/property-types.js:
* web-platform-tests/web-animations/animation-model/combining-effects/applying-the-composited-result-expected.txt: Added.
* web-platform-tests/web-animations/animation-model/combining-effects/applying-the-composited-result.html: Added.
* web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-interval-distance-expected.txt: Added.
* web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-interval-distance.html: Added.
* web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-iteration-composite-operation.html:
* web-platform-tests/web-animations/interfaces/Animatable/animate-expected.txt:
* web-platform-tests/web-animations/interfaces/Animatable/animate.html:
* web-platform-tests/web-animations/interfaces/Animatable/getAnimations.html:
* web-platform-tests/web-animations/interfaces/Animation/cancel.html:
* web-platform-tests/web-animations/interfaces/Animation/constructor.html:
* web-platform-tests/web-animations/interfaces/Animation/effect.html:
* web-platform-tests/web-animations/interfaces/Animation/finish-expected.txt: Removed.
* web-platform-tests/web-animations/interfaces/Animation/finish.html: Removed.
* web-platform-tests/web-animations/interfaces/Animation/finished.html:
* web-platform-tests/web-animations/interfaces/Animation/idlharness-expected.txt: Removed.
* web-platform-tests/web-animations/interfaces/Animation/idlharness.html: Removed.
* web-platform-tests/web-animations/interfaces/Animation/idlharness.window.js: Added.
* web-platform-tests/web-animations/interfaces/Animation/onfinish.html:
* web-platform-tests/web-animations/interfaces/Animation/playbackRate-expected.txt: Removed.
* web-platform-tests/web-animations/interfaces/Animation/playbackRate.html: Removed.
* web-platform-tests/web-animations/interfaces/Animation/ready.html:
* web-platform-tests/web-animations/interfaces/AnimationEffect/getComputedTiming-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/AnimationEffectTiming/getComputedTiming-expected.txt.
* web-platform-tests/web-animations/interfaces/AnimationEffect/getComputedTiming.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/AnimationEffectTiming/getComputedTiming.html.
* web-platform-tests/web-animations/interfaces/AnimationEffect/updateTiming-expected.txt: Added.
* web-platform-tests/web-animations/interfaces/AnimationEffect/updateTiming.html: Added.
* web-platform-tests/web-animations/interfaces/AnimationEffectTiming/delay-expected.txt: Removed.
* web-platform-tests/web-animations/interfaces/AnimationEffectTiming/delay.html: Removed.
* web-platform-tests/web-animations/interfaces/AnimationEffectTiming/direction-expected.txt: Removed.
* web-platform-tests/web-animations/interfaces/AnimationEffectTiming/direction.html: Removed.
* web-platform-tests/web-animations/interfaces/AnimationEffectTiming/duration-expected.txt: Removed.
* web-platform-tests/web-animations/interfaces/AnimationEffectTiming/duration.html: Removed.
* web-platform-tests/web-animations/interfaces/AnimationEffectTiming/easing-expected.txt: Removed.
* web-platform-tests/web-animations/interfaces/AnimationEffectTiming/easing.html: Removed.
* web-platform-tests/web-animations/interfaces/AnimationEffectTiming/endDelay-expected.txt: Removed.
* web-platform-tests/web-animations/interfaces/AnimationEffectTiming/endDelay.html: Removed.
* web-platform-tests/web-animations/interfaces/AnimationEffectTiming/fill-expected.txt: Removed.
* web-platform-tests/web-animations/interfaces/AnimationEffectTiming/fill.html: Removed.
* web-platform-tests/web-animations/interfaces/AnimationEffectTiming/idlharness-expected.txt: Removed.
* web-platform-tests/web-animations/interfaces/AnimationEffectTiming/idlharness.html: Removed.
* web-platform-tests/web-animations/interfaces/AnimationEffectTiming/iterationStart-expected.txt: Removed.
* web-platform-tests/web-animations/interfaces/AnimationEffectTiming/iterationStart.html: Removed.
* web-platform-tests/web-animations/interfaces/AnimationEffectTiming/iterations-expected.txt: Removed.
* web-platform-tests/web-animations/interfaces/AnimationEffectTiming/iterations.html: Removed.
* web-platform-tests/web-animations/interfaces/AnimationPlaybackEvent/idlharness-expected.txt: Removed.
* web-platform-tests/web-animations/interfaces/AnimationPlaybackEvent/idlharness.html: Removed.
* web-platform-tests/web-animations/interfaces/AnimationPlaybackEvent/idlharness.window.js: Added.
* web-platform-tests/web-animations/interfaces/Document/getAnimations-expected.txt:
* web-platform-tests/web-animations/interfaces/Document/getAnimations.html:
* web-platform-tests/web-animations/interfaces/DocumentTimeline/idlharness-expected.txt: Removed.
* web-platform-tests/web-animations/interfaces/DocumentTimeline/idlharness.html: Removed.
* web-platform-tests/web-animations/interfaces/DocumentTimeline/idlharness.window.js: Added.
* web-platform-tests/web-animations/interfaces/KeyframeEffect/composite.html:
* web-platform-tests/web-animations/interfaces/KeyframeEffect/constructor-expected.txt:
* web-platform-tests/web-animations/interfaces/KeyframeEffect/constructor.html:
* web-platform-tests/web-animations/interfaces/KeyframeEffect/copy-constructor-expected.txt:
* web-platform-tests/web-animations/interfaces/KeyframeEffect/copy-constructor.html:
* web-platform-tests/web-animations/interfaces/KeyframeEffect/idlharness-expected.txt: Removed.
* web-platform-tests/web-animations/interfaces/KeyframeEffect/idlharness.html: Removed.
* web-platform-tests/web-animations/interfaces/KeyframeEffect/idlharness.window.js: Added.
* web-platform-tests/web-animations/interfaces/KeyframeEffect/iterationComposite.html:
* web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001-expected.txt:
* web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html:
* web-platform-tests/web-animations/interfaces/KeyframeEffect/setKeyframes-expected.txt:
* web-platform-tests/web-animations/interfaces/KeyframeEffect/setKeyframes.html:
* web-platform-tests/web-animations/resources/keyframe-tests.js:
* web-platform-tests/web-animations/resources/timing-tests.js: Added.
* web-platform-tests/web-animations/resources/timing-utils.js: Added.
* web-platform-tests/web-animations/testcommon.js:
* web-platform-tests/web-animations/timing-model/animation-effects/phases-and-states.html:
* web-platform-tests/web-animations/timing-model/animations/canceling-an-animation-expected.txt:
* web-platform-tests/web-animations/timing-model/animations/canceling-an-animation.html:
* web-platform-tests/web-animations/timing-model/animations/finishing-an-animation-expected.txt:
* web-platform-tests/web-animations/timing-model/animations/finishing-an-animation.html:
* web-platform-tests/web-animations/timing-model/animations/pausing-an-animation-expected.txt:
* web-platform-tests/web-animations/timing-model/animations/pausing-an-animation.html:
* web-platform-tests/web-animations/timing-model/animations/play-states-expected.txt:
* web-platform-tests/web-animations/timing-model/animations/play-states.html:
* web-platform-tests/web-animations/timing-model/animations/playing-an-animation-expected.txt:
* web-platform-tests/web-animations/timing-model/animations/playing-an-animation.html:
* web-platform-tests/web-animations/timing-model/animations/reversing-an-animation-expected.txt:
* web-platform-tests/web-animations/timing-model/animations/reversing-an-animation.html:
* web-platform-tests/web-animations/timing-model/animations/seamlessly-updating-the-playback-rate-of-an-animation-expected.txt: Added.
* web-platform-tests/web-animations/timing-model/animations/seamlessly-updating-the-playback-rate-of-an-animation.html: Added.
* web-platform-tests/web-animations/timing-model/animations/setting-the-current-time-of-an-animation-expected.txt: Added.
* web-platform-tests/web-animations/timing-model/animations/setting-the-current-time-of-an-animation.html: Added.
* web-platform-tests/web-animations/timing-model/animations/setting-the-playback-rate-of-an-animation-expected.txt: Added.
* web-platform-tests/web-animations/timing-model/animations/setting-the-playback-rate-of-an-animation.html: Added.
* web-platform-tests/web-animations/timing-model/animations/setting-the-start-time-of-an-animation-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/set-the-animation-start-time-expected.txt.
* web-platform-tests/web-animations/timing-model/animations/setting-the-start-time-of-an-animation.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/set-the-animation-start-time.html.
* web-platform-tests/web-animations/timing-model/animations/setting-the-target-effect-of-an-animation-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/set-the-target-effect-of-an-animation-expected.txt.
* web-platform-tests/web-animations/timing-model/animations/setting-the-target-effect-of-an-animation.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/set-the-target-effect-of-an-animation.html.
* web-platform-tests/web-animations/timing-model/animations/setting-the-timeline-of-an-animation-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/set-the-timeline-of-an-animation-expected.txt.
* web-platform-tests/web-animations/timing-model/animations/setting-the-timeline-of-an-animation.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/set-the-timeline-of-an-animation.html.
* web-platform-tests/web-animations/timing-model/animations/the-current-time-of-an-animation-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/current-time-expected.txt.
* web-platform-tests/web-animations/timing-model/animations/the-current-time-of-an-animation.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/current-time.html.
* web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state-expected.txt:
* web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state.html:
* web-platform-tests/web-animations/timing-model/timelines/document-timelines.html:
* web-platform-tests/web-animations/timing-model/timelines/update-and-send-events-expected.txt: Added.
* web-platform-tests/web-animations/timing-model/timelines/update-and-send-events.html: Added.

LayoutTests:

* TestExpectations:
* platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
* platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
* platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
* platform/mac-sierra/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
* platform/mac-sierra/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
* platform/mac-sierra/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
* platform/mac/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
* platform/mac/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
* platform/mac/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
* webanimations/css-animations.html:
* webanimations/left-and-opacity-animation-yields-no-compositing.html:
* webanimations/opacity-animation-no-longer-composited-upon-completion.html:
* webanimations/width-and-opacity-separate-animation-yields-no-compositing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[Web Animations] Don't reset pending tasks when setting a null effect
graouts@webkit.org [Tue, 6 Nov 2018 11:15:47 +0000 (11:15 +0000)]
[Web Animations] Don't reset pending tasks when setting a null effect
https://bugs.webkit.org/show_bug.cgi?id=191301
<rdar://problem/45838422>

Reviewed by Dean Jackson.

The issue https://github.com/w3c/csswg-drafts/issues/2077 has changed the Web Animations API such that
we no longer reset pending tasks when setting a null effect on an animation.

* animation/WebAnimation.cpp:
(WebCore::WebAnimation::setEffect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[Web Animations] Update the API to allow the "auto" composite value
graouts@webkit.org [Tue, 6 Nov 2018 11:15:43 +0000 (11:15 +0000)]
[Web Animations] Update the API to allow the "auto" composite value
https://bugs.webkit.org/show_bug.cgi?id=191300
<rdar://problem/45838373>

Reviewed by Dean Jackson.

The Web Animations API has been changed such that the various "composite" properties are no longer optional and instead
allow an "auto" value in their enumeration.

* CMakeLists.txt:
* DerivedSources.make:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* animation/CompositeOperationOrAuto.h: Copied from Source/WebCore/animation/KeyframeEffect.idl.
* animation/CompositeOperationOrAuto.idl: Copied from Source/WebCore/animation/KeyframeEffect.idl.
* animation/KeyframeEffect.cpp:
(WebCore::processKeyframeLikeObject):
(WebCore::processIterableKeyframes):
(WebCore::processPropertyIndexedKeyframes):
(WebCore::KeyframeEffect::getKeyframes):
* animation/KeyframeEffect.h:
* animation/KeyframeEffect.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[Web Animations] Update the API to implement Animation.updatePlaybackRate()
graouts@webkit.org [Tue, 6 Nov 2018 11:15:35 +0000 (11:15 +0000)]
[Web Animations] Update the API to implement Animation.updatePlaybackRate()
https://bugs.webkit.org/show_bug.cgi?id=186510
<rdar://problem/41000641>

Reviewed by Dean Jackson.

The Web Animations API has been changed to allow for changes to an animation's playback rate both synchronously,
with the existing "playbackRate" property, and asynchronously, with the new updatePlaybackRate() method. In this
patch we update the various procedures to account for pending playback rate changes and the notion of an "effective
playback rate".

* animation/WebAnimation.cpp:
(WebCore::WebAnimation::setEffect):
(WebCore::WebAnimation::setTimeline):
(WebCore::WebAnimation::setStartTime):
(WebCore::WebAnimation::setCurrentTime):
(WebCore::WebAnimation::effectivePlaybackRate const):
(WebCore::WebAnimation::setPlaybackRate):
(WebCore::WebAnimation::updatePlaybackRate):
(WebCore::WebAnimation::applyPendingPlaybackRate):
(WebCore::WebAnimation::playState const):
(WebCore::WebAnimation::resetPendingTasks):
(WebCore::WebAnimation::finish):
(WebCore::WebAnimation::play):
(WebCore::WebAnimation::runPendingPlayTask):
(WebCore::WebAnimation::reverse):
(WebCore::WebAnimation::runPendingPauseTask):
* animation/WebAnimation.h:
(WebCore::WebAnimation::playbackRate const):
* animation/WebAnimation.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[Web Animations] Implement getTiming() and updateTiming()
graouts@webkit.org [Tue, 6 Nov 2018 11:15:30 +0000 (11:15 +0000)]
[Web Animations] Implement getTiming() and updateTiming()
https://bugs.webkit.org/show_bug.cgi?id=186511
<rdar://problem/41000677>

Reviewed by Dean Jackson.

The Web Animations API has been further simplified by removing the AnimationEffectTiming and AnimationEffectTimingReadOnly
interfaces, removing the "timing" property on AnimationEffect replacing it with getTiming() and updateTiming() methods. This
does not change the features of the API but simply how they are exposed.

* CMakeLists.txt:
* DerivedSources.make:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* animation/AnimationEffect.cpp:
(WebCore::AnimationEffect::AnimationEffect):
(WebCore::AnimationEffect::~AnimationEffect):
(WebCore::AnimationEffect::phase const):
(WebCore::AnimationEffect::activeTime const):
(WebCore::AnimationEffect::overallProgress const):
(WebCore::AnimationEffect::simpleIterationProgress const):
(WebCore::AnimationEffect::currentIteration const):
(WebCore::AnimationEffect::currentDirection const):
(WebCore::AnimationEffect::transformedProgress const):
(WebCore::AnimationEffect::getTiming):
(WebCore::AnimationEffect::getComputedTiming):
(WebCore::AnimationEffect::updateTiming):
(WebCore::AnimationEffect::setIterationStart):
(WebCore::AnimationEffect::setIterations):
(WebCore::AnimationEffect::endTime const):
(WebCore::AnimationEffect::setDelay):
(WebCore::AnimationEffect::setEndDelay):
(WebCore::AnimationEffect::setFill):
(WebCore::AnimationEffect::setIterationDuration):
(WebCore::AnimationEffect::setDirection):
(WebCore::AnimationEffect::setTimingFunction):
(WebCore::AnimationEffect::activeDuration const):
* animation/AnimationEffect.h:
(WebCore::AnimationEffect::delay const):
(WebCore::AnimationEffect::endDelay const):
(WebCore::AnimationEffect::fill const):
(WebCore::AnimationEffect::iterationStart const):
(WebCore::AnimationEffect::iterations const):
(WebCore::AnimationEffect::iterationDuration const):
(WebCore::AnimationEffect::direction const):
(WebCore::AnimationEffect::timingFunction const):
* animation/AnimationEffect.idl:
* animation/AnimationEffectTiming.idl: Removed.
* animation/AnimationEffectTimingReadOnly.cpp: Removed.
* animation/AnimationEffectTimingReadOnly.h: Removed.
* animation/AnimationEffectTimingReadOnly.idl: Removed.
* animation/CSSAnimation.cpp:
(WebCore::CSSAnimation::syncPropertiesWithBackingAnimation):
* animation/CSSTransition.cpp:
(WebCore::CSSTransition::setTimingProperties):
* animation/DeclarativeAnimation.cpp:
(WebCore::DeclarativeAnimation::invalidateDOMEvents):
* animation/DocumentTimeline.cpp:
* animation/EffectTiming.idl:
* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::create):
(WebCore::KeyframeEffect::KeyframeEffect):
(WebCore::KeyframeEffect::copyPropertiesFromSource):
(WebCore::KeyframeEffect::setAnimatedPropertiesInStyle):
(WebCore::KeyframeEffect::applyPendingAcceleratedActions):
(WebCore::KeyframeEffect::backingAnimationForCompositedRenderer const):
* animation/KeyframeEffect.h:
* animation/OptionalEffectTiming.h: Renamed from Source/WebCore/animation/AnimationEffectTiming.h.
* animation/OptionalEffectTiming.idl: Renamed from Source/WebCore/animation/AnimationEffectTiming.cpp.
* animation/WebAnimation.cpp:
(WebCore::WebAnimation::effectTimingDidChange):
(WebCore::WebAnimation::updatePlaybackRate):
* animation/WebAnimation.h:
(WebCore::WebAnimation::isRelevant const):
* bindings/js/JSAnimationEffectTimingReadOnlyCustom.cpp: Removed.
* bindings/js/WebCoreBuiltinNames.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[Web Animations] Update the Web Animations API to remove all the ReadOnly interfaces
graouts@webkit.org [Tue, 6 Nov 2018 11:15:15 +0000 (11:15 +0000)]
[Web Animations] Update the Web Animations API to remove all the ReadOnly interfaces
https://bugs.webkit.org/show_bug.cgi?id=186512
<rdar://problem/41000691>

Reviewed by Dean Jackson.

The Web Animations API has been simplified by removing its various ReadOnly interfaces. In this patch,
we make the following changes, not adding code but merely merging and renaming files:

- AnimationEffectReadOnly and AnimationEffect are now a single AnimationEffect interface
- KeyframeEffectReadOnly and KeyframeEffect are now a single KeyframeEffect interface
- ComputedTimingProperties is now named ComputedEffectTiming
- AnimationEffectTimingProperties is now named EffectTiming

* CMakeLists.txt:
* DerivedSources.make:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* animation/AnimationEffect.cpp: Renamed from Source/WebCore/animation/AnimationEffectReadOnly.cpp.
(WebCore::AnimationEffect::~AnimationEffect):
(WebCore::AnimationEffect::timingDidChange):
(WebCore::AnimationEffect::localTime const):
(WebCore::AnimationEffect::phase const):
(WebCore::AnimationEffect::activeTime const):
(WebCore::AnimationEffect::overallProgress const):
(WebCore::AnimationEffect::simpleIterationProgress const):
(WebCore::AnimationEffect::currentIteration const):
(WebCore::AnimationEffect::currentDirection const):
(WebCore::AnimationEffect::directedProgress const):
(WebCore::AnimationEffect::transformedProgress const):
(WebCore::AnimationEffect::iterationProgress const):
(WebCore::AnimationEffect::getComputedTiming):
* animation/AnimationEffect.h: Renamed from Source/WebCore/animation/AnimationEffectReadOnly.h.
(WebCore::AnimationEffect::isKeyframeEffect const):
* animation/AnimationEffect.idl: Renamed from Source/WebCore/animation/AnimationEffectReadOnly.idl.
* animation/AnimationEffectTimingReadOnly.cpp:
* animation/AnimationEffectTimingReadOnly.h:
(WebCore::AnimationEffectTimingReadOnly::setEffect):
* animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::removeAnimation):
(WebCore::AnimationTimeline::cssAnimationForElementAndProperty):
* animation/CSSTransition.cpp:
* animation/ComputedEffectTiming.h: Renamed from Source/WebCore/animation/ComputedTimingProperties.h.
* animation/ComputedEffectTiming.idl: Renamed from Source/WebCore/animation/ComputedTimingProperties.idl.
* animation/DeclarativeAnimation.cpp:
(WebCore::DeclarativeAnimation::initialize):
(WebCore::DeclarativeAnimation::flushPendingStyleChanges const):
(WebCore::DeclarativeAnimation::phaseWithoutEffect const):
(WebCore::DeclarativeAnimation::invalidateDOMEvents):
* animation/DeclarativeAnimation.h:
* animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::getAnimations const):
(WebCore::DocumentTimeline::transitionDidComplete):
(WebCore::DocumentTimeline::computeExtentOfAnimation const):
(WebCore::DocumentTimeline::isRunningAnimationOnRenderer const):
(WebCore::DocumentTimeline::isRunningAcceleratedAnimationOnRenderer const):
(WebCore::DocumentTimeline::animatedStyleForRenderer):
(WebCore::DocumentTimeline::animationAcceleratedRunningStateDidChange):
(WebCore::DocumentTimeline::updateListOfElementsWithRunningAcceleratedAnimationsForElement):
(WebCore::DocumentTimeline::applyPendingAcceleratedAnimations):
(WebCore::DocumentTimeline::resolveAnimationsForElement):
* animation/EffectTiming.h: Renamed from Source/WebCore/animation/AnimationEffectTimingProperties.h.
* animation/EffectTiming.idl: Renamed from Source/WebCore/animation/AnimationEffectTimingProperties.idl.
* animation/KeyframeEffect.cpp:
(WebCore::invalidateElement):
(WebCore::CSSPropertyIDToIDLAttributeName):
(WebCore::IDLAttributeNameToAnimationPropertyName):
(WebCore::computeMissingKeyframeOffsets):
(WebCore::processKeyframeLikeObject):
(WebCore::processIterableKeyframes):
(WebCore::processPropertyIndexedKeyframes):
(WebCore::KeyframeEffect::create):
(WebCore::KeyframeEffect::KeyframeEffect):
(WebCore::KeyframeEffect::copyPropertiesFromSource):
(WebCore::KeyframeEffect::getKeyframes):
(WebCore::KeyframeEffect::processKeyframes):
(WebCore::KeyframeEffect::updateBlendingKeyframes):
(WebCore::KeyframeEffect::forceLayoutIfNeeded):
(WebCore::KeyframeEffect::setBlendingKeyframes):
(WebCore::KeyframeEffect::checkForMatchingTransformFunctionLists):
(WebCore::KeyframeEffect::checkForMatchingFilterFunctionLists const):
(WebCore::KeyframeEffect::checkForMatchingFilterFunctionLists):
(WebCore::KeyframeEffect::checkForMatchingBackdropFilterFunctionLists):
(WebCore::KeyframeEffect::checkForMatchingColorFilterFunctionLists):
(WebCore::KeyframeEffect::computeDeclarativeAnimationBlendingKeyframes):
(WebCore::KeyframeEffect::computeCSSAnimationBlendingKeyframes):
(WebCore::KeyframeEffect::computeCSSTransitionBlendingKeyframes):
(WebCore::KeyframeEffect::computedNeedsForcedLayout):
(WebCore::KeyframeEffect::computeStackingContextImpact):
(WebCore::KeyframeEffect::setTarget):
(WebCore::KeyframeEffect::apply):
(WebCore::KeyframeEffect::invalidate):
(WebCore::KeyframeEffect::computeShouldRunAccelerated):
(WebCore::KeyframeEffect::getAnimatedStyle):
(WebCore::KeyframeEffect::setAnimatedPropertiesInStyle):
(WebCore::KeyframeEffect::timingFunctionForKeyframeAtIndex):
(WebCore::KeyframeEffect::updateAcceleratedAnimationState):
(WebCore::KeyframeEffect::addPendingAcceleratedAction):
(WebCore::KeyframeEffect::animationDidSeek):
(WebCore::KeyframeEffect::animationSuspensionStateDidChange):
(WebCore::KeyframeEffect::applyPendingAcceleratedActions):
(WebCore::KeyframeEffect::backingAnimationForCompositedRenderer const):
(WebCore::KeyframeEffect::renderer const):
(WebCore::KeyframeEffect::currentStyle const):
(WebCore::KeyframeEffect::computeExtentOfTransformAnimation const):
(WebCore::containsRotation):
(WebCore::KeyframeEffect::computeTransformedExtentViaTransformList const):
(WebCore::KeyframeEffect::computeTransformedExtentViaMatrix const):
* animation/KeyframeEffect.h:
(WebCore::KeyframeEffect::ParsedKeyframe::ParsedKeyframe):
(WebCore::KeyframeEffect::target const):
(WebCore::KeyframeEffect::iterationComposite const):
(WebCore::KeyframeEffect::composite const):
(WebCore::KeyframeEffect::isRunningAccelerated const):
(WebCore::KeyframeEffect::hasPendingAcceleratedAction const):
(WebCore::KeyframeEffect::hasBlendingKeyframes const):
(WebCore::KeyframeEffect::animatedProperties const):
* animation/KeyframeEffect.idl:
* animation/KeyframeEffectOptions.h:
* animation/KeyframeEffectOptions.idl:
* animation/KeyframeEffectReadOnly.cpp: Removed.
* animation/KeyframeEffectReadOnly.h: Removed.
* animation/KeyframeEffectReadOnly.idl: Removed.
* animation/WebAnimation.cpp:
(WebCore::WebAnimation::create):
(WebCore::WebAnimation::setEffect):
(WebCore::WebAnimation::setEffectInternal):
(WebCore::WebAnimation::setTimeline):
(WebCore::WebAnimation::applyPendingAcceleratedActions):
(WebCore::WebAnimation::computeRelevance):
* animation/WebAnimation.h:
(WebCore::WebAnimation::effect const):
* animation/WebAnimation.idl:
* bindings/js/JSAnimationEffectCustom.cpp: Renamed from Source/WebCore/bindings/js/JSAnimationEffectReadOnlyCustom.cpp.
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
* bindings/js/JSWebAnimationCustom.cpp:
(WebCore::constructJSWebAnimation):
* bindings/js/WebCoreBuiltinNames.h:
* dom/Document.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoUnreviewed WPE gardening. Handle a bunch of test failures under the
zandobersek@gmail.com [Tue, 6 Nov 2018 10:26:13 +0000 (10:26 +0000)]
Unreviewed WPE gardening. Handle a bunch of test failures under the
directories containing imported W3C wpt tests. A few test expectations
are added, but mostly the corresponding baselines are provided.

* platform/wpe/TestExpectations:
* platform/wpe/http/tests/dom: Added.
* platform/wpe/http/tests/dom/same-origin-detached-window-properties-expected.txt: Added.
* platform/wpe/http/wpt: Added.
* platform/wpe/http/wpt/mediarecorder: Added.
* platform/wpe/http/wpt/mediarecorder/MediaRecorder-dataavailable-expected.txt: Added.
* platform/wpe/http/wpt/mediarecorder/MediaRecorder-mock-dataavailable-expected.txt: Added.
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-generate-request-disallowed-input.https-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear.https-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-reset-src-after-setmediakeys.https-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/idlharness.https-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element: Added.
* platform/wpe/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/hidden-expected.txt: Added.
* platform/wpe/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/text-expected.txt: Added.
* platform/wpe/imported/w3c/web-platform-tests/mimesniff: Added.
* platform/wpe/imported/w3c/web-platform-tests/mimesniff/mime-types: Added.
* platform/wpe/imported/w3c/web-platform-tests/mimesniff/mime-types/charset-parameter.window-expected.txt: Added.
* platform/wpe/imported/w3c/web-platform-tests/pointerevents: Added.
* platform/wpe/imported/w3c/web-platform-tests/pointerevents/extension: Added.
* platform/wpe/imported/w3c/web-platform-tests/pointerevents/extension/pointerevent_touch-action-verification-expected.txt: Added.
* platform/wpe/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-illegal-expected.txt: Added.
* platform/wpe/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-verification-expected.txt: Added.
* platform/wpe/imported/w3c/web-platform-tests/service-workers: Added.
* platform/wpe/imported/w3c/web-platform-tests/service-workers/service-worker: Added.
* platform/wpe/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-within-sw-manual.https-expected.txt: Added.
* platform/wpe/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-frame-resource.https-expected.txt: Added.
* platform/wpe/imported/w3c/web-platform-tests/shadow-dom: Added.
* platform/wpe/imported/w3c/web-platform-tests/shadow-dom/input-element-list-expected.txt: Added.
* platform/wpe/imported/w3c/web-platform-tests/xhr/formdata-blob-expected.txt: Added.
* platform/wpe/imported/w3c/web-platform-tests/xhr/formdata-expected.txt: Added.
* platform/wpe/imported/w3c/web-platform-tests/xhr/getallresponseheaders-expected.txt: Added.
* platform/wpe/imported/w3c/web-platform-tests/xhr/getresponseheader.any-expected.txt: Added.
* platform/wpe/imported/w3c/web-platform-tests/xhr/getresponseheader.any.worker-expected.txt: Added.
* platform/wpe/imported/w3c/web-platform-tests/xhr/setrequestheader-content-type-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoSome minor X-Content-Type-Options parsing issues
commit-queue@webkit.org [Tue, 6 Nov 2018 09:44:16 +0000 (09:44 +0000)]
Some minor X-Content-Type-Options parsing issues
https://bugs.webkit.org/show_bug.cgi?id=191107

Patch by Rob Buis <rbuis@igalia.com> on 2018-11-06
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Update improved result.

* web-platform-tests/fetch/nosniff/parsing-nosniff-expected.txt:

Source/WebCore:

Implement new parsing rules for X-Content-Type-Options [1]:
https://github.com/whatwg/fetch/pull/818

[1] https://fetch.spec.whatwg.org/#x-content-type-options-header

Test: web-platform-tests/fetch/nosniff/parsing-nosniff.html

* platform/network/HTTPParsers.cpp:
(WebCore::isHTTPTabOrSpace):
(WebCore::parseContentTypeOptionsHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoOverlay with -webkit-overflow-scrolling:touch doesn't become scrollable after added...
fred.wang@free.fr [Tue, 6 Nov 2018 08:19:47 +0000 (08:19 +0000)]
Overlay with -webkit-overflow-scrolling:touch doesn't become scrollable after added text makes it taller
https://bugs.webkit.org/show_bug.cgi?id=158342

Patch by Frederic Wang <fwang@igalia.com> on 2018-11-06
Reviewed by Simon Fraser.

Source/WebCore:

Resizing the content of a -webkit-overflow-scrolling:touch overflow node on iOS may make it
scrollable. However, the RenderLayerBacking's scrolling layer is not properly created
when RenderLayerCompositor::updateScrollCoordinatedLayer is called and hence the UIProcess
receives a null UIScrollView pointer when ScrollingTreeScrollingNodeDelegateIOS performs the
associated update. In debug mode this hits an ASSERT and in release mode the overflow node
remains unscrollable from the user's point of view. This patch fixes this issue by ensuring
the RenderLayerBacking's scrolling layer is created during updateScrollCoordinatedStatus.

Test: fast/scrolling/ios/update-scroll-coordinated-status.html

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateScrollCoordinatedStatus): Call updateConfiguration()
to ensure the scrolling layer is present and indicate whether a rebuild is necessary.

LayoutTests:

Add a test to ensure the change of scrolling status is reflected in the layer and scrolling
trees. This test should also ASSERT in debug mode without the associated code change.

* fast/scrolling/ios/update-scroll-coordinated-status-expected.txt: Added.
* fast/scrolling/ios/update-scroll-coordinated-status.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[WPE] Remove BackingStore, BackingStoreCairo implementation files from build
zandobersek@gmail.com [Tue, 6 Nov 2018 07:11:58 +0000 (07:11 +0000)]
[WPE] Remove BackingStore, BackingStoreCairo implementation files from build
https://bugs.webkit.org/show_bug.cgi?id=191269

Reviewed by Michael Catanzaro.

* SourcesWPE.txt: Drop the BackingStore.cpp and BackingStoreCairo.cpp
files from the WPE build. These are not used at all in WPE configuration
as they are only used by the GTK+ port for non-AC functionality.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoPlace Fontconfig-specific RefPtr specializations in RefPtrFontconfig.h
zandobersek@gmail.com [Tue, 6 Nov 2018 07:09:27 +0000 (07:09 +0000)]
Place Fontconfig-specific RefPtr specializations in RefPtrFontconfig.h
https://bugs.webkit.org/show_bug.cgi?id=191267

Reviewed by Michael Catanzaro.

Move the Fontconfig-specific RefPtr specialization declarations from
RefPtrCairo.h to RefPtrFontconfig.h, with definitions moved to the new
RefPtrFontconfig.cpp implementation file. These specializations are
not tied to Cairo in any way.

* platform/FreeType.cmake:
* platform/graphics/FontPlatformData.h:
* platform/graphics/cairo/RefPtrCairo.cpp:
* platform/graphics/cairo/RefPtrCairo.h:
* platform/graphics/freetype/FontCacheFreeType.cpp:
* platform/graphics/freetype/RefPtrFontconfig.cpp: Added.
(WTF::refIfNotNull):
(WTF::derefIfNotNull):
* platform/graphics/freetype/RefPtrFontconfig.h: Copied from Source/WebCore/platform/graphics/cairo/RefPtrCairo.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[CMake] Fix WebCore/Modules includes
don.olmstead@sony.com [Tue, 6 Nov 2018 07:01:41 +0000 (07:01 +0000)]
[CMake] Fix WebCore/Modules includes
https://bugs.webkit.org/show_bug.cgi?id=191287

Reviewed by Fujii Hironori.

No new tests. No change in behavior.

Add in applicationmanifest to the list of includes and sort the
modules directory.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoCache glyph paths and share underline skipping code between all the ports
mmaxfield@apple.com [Tue, 6 Nov 2018 04:35:50 +0000 (04:35 +0000)]
Cache glyph paths and share underline skipping code between all the ports
https://bugs.webkit.org/show_bug.cgi?id=191239

Reviewed by Alex Christensen.

PerformanceTests:

Measures the performance of drawing a whole lot of underlines

* Layout/underline.html: Added.

Source/WebCore:

I was hoping that caching the glyph paths was going to be a performance progression,
but it turns out that the additional overhead of WebCore::Path compensated for it.
In total, the performance is the same (my testing says that this patch is a 1%
progression, but that's within the noise).

Because the ink skipping logic is now shared among all ports, Windows now gets it for
free.

Test: PerformanceTests/Layout/underline.html

* platform/graphics/Font.cpp:
(WebCore::Font::pathForGlyph const):
* platform/graphics/Font.h:
* platform/graphics/FontCascade.cpp:
(WebCore::computeUnderlineType):
(WebCore::GlyphIterationState::GlyphIterationState):
(WebCore::findIntersectionPoint):
(WebCore::updateX):
(WebCore::findPathIntersections):
(WebCore::GlyphToPathTranslator::GlyphToPathTranslator):
(WebCore::GlyphToPathTranslator::containsMorePaths):
(WebCore::GlyphToPathTranslator::path):
(WebCore::GlyphToPathTranslator::extents):
(WebCore::GlyphToPathTranslator::underlineType):
(WebCore::GlyphToPathTranslator::advance):
(WebCore::FontCascade::dashesForIntersectionsWithRect const):
* platform/graphics/FontCascade.h:
* platform/graphics/GlyphMetricsMap.h:
(WebCore::GlyphMetricsMap::existingMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::existingMetricsForGlyph const):
(WebCore::GlyphMetricsMap<std::optional<Path>>::unknownMetrics):
* platform/graphics/TextRun.h:
* platform/graphics/cairo/FontCairo.cpp:
(WebCore::Font::platformPathForGlyph const):
(WebCore::GlyphIterationState::GlyphIterationState): Deleted.
(WebCore::findIntersectionPoint): Deleted.
(WebCore::updateX): Deleted.
(WebCore::findPathIntersections): Deleted.
(): Deleted.
(WebCore::CairoGlyphToPathTranslator::path): Deleted.
(WebCore::CairoGlyphToPathTranslator::extents): Deleted.
(WebCore::CairoGlyphToPathTranslator::underlineType): Deleted.
(WebCore::CairoGlyphToPathTranslator::advance): Deleted.
(WebCore::FontCascade::dashesForIntersectionsWithRect const): Deleted.
* platform/graphics/cocoa/FontCascadeCocoa.mm:
(WebCore::GlyphIterationState::GlyphIterationState): Deleted.
(WebCore::findIntersectionPoint): Deleted.
(WebCore::updateX): Deleted.
(WebCore::findPathIntersections): Deleted.
(): Deleted.
(WebCore::MacGlyphToPathTranslator::path): Deleted.
(WebCore::MacGlyphToPathTranslator::extents): Deleted.
(WebCore::MacGlyphToPathTranslator::underlineType): Deleted.
(WebCore::MacGlyphToPathTranslator::advance): Deleted.
(WebCore::FontCascade::dashesForIntersectionsWithRect const): Deleted.
* platform/graphics/cocoa/FontCocoa.mm:
(WebCore::Font::platformPathForGlyph const):
* rendering/TextDecorationPainter.cpp:
(WebCore::drawSkipInkUnderline):
(WebCore::TextDecorationPainter::paintTextDecoration):

Source/WTF:

Remove CSS3_TEXT_DECORATION_SKIP_INK. It's now interoperable and part of the Web Platform.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoClean up text decoration drawing code
mmaxfield@apple.com [Tue, 6 Nov 2018 04:32:44 +0000 (04:32 +0000)]
Clean up text decoration drawing code
https://bugs.webkit.org/show_bug.cgi?id=191245

Reviewed by Zalan Bujtas.

This is some general clean up of the text decorations code. There is no behavior change.

This patch modifies GraphicsContext::drawLineForText() & friends to accept a FloatRect instead of a FloatPoint + float width.
This is helpful because it allows for easier bounding box calculations.
This patch also removes some redundant computations that the skip:ink codepath was performing.
This patch also refactors the wavy decoration parameters to not use out params.

No new tests because there is no behavior change.

* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::computeUnderlineBoundsForText):
(WebCore::GraphicsContext::computeLineBoundsAndAntialiasingModeForText):
* platform/graphics/GraphicsContext.h:
* platform/graphics/GraphicsContextImpl.h:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawLinesForText):
* platform/graphics/displaylists/DisplayListItems.cpp:
(WebCore::DisplayList::DrawLinesForText::apply const):
(WebCore::DisplayList::DrawLinesForText::localBounds const):
(WebCore::DisplayList::operator<<):
* platform/graphics/displaylists/DisplayListItems.h:
(WebCore::DisplayList::DrawLinesForText::create):
(WebCore::DisplayList::DrawLinesForText::thickness const):
(WebCore::DisplayList::DrawLinesForText::DrawLinesForText):
* platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::drawLinesForText):
* platform/graphics/displaylists/DisplayListRecorder.h:
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintMarkedTextDecoration):
(WebCore::InlineTextBox::paintCompositionUnderline const):
* rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::paintFlow):
* rendering/TextDecorationPainter.cpp:
(WebCore::strokeWavyTextDecoration):
(WebCore::translateIntersectionPointsToSkipInkBoundaries):
(WebCore::TextDecorationPainter::TextDecorationPainter):
(WebCore::TextDecorationPainter::paintTextDecoration):
(WebCore::drawSkipInkUnderline): Deleted.
* rendering/TextDecorationPainter.h:
(WebCore::TextDecorationPainter::setInlineTextBox):
(WebCore::TextDecorationPainter::setWidth):
(WebCore::TextDecorationPainter::setFont): Deleted.
(WebCore::TextDecorationPainter::setBaseline): Deleted.
* style/InlineTextBoxStyle.cpp:
(WebCore::getWavyStrokeParameters):
(WebCore::visualOverflowForDecorations):
* style/InlineTextBoxStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoFix the Windows build after r237835
mmaxfield@apple.com [Tue, 6 Nov 2018 04:30:35 +0000 (04:30 +0000)]
Fix the Windows build after r237835
https://bugs.webkit.org/show_bug.cgi?id=191242

Reviewed by Simon Fraser.

* rendering/style/TextDecorationThickness.h:
(WebCore::TextDecorationThickness::operator== const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[iOS] Swatch appears squished and off-center in inputs of type color
wenson_hsieh@apple.com [Tue, 6 Nov 2018 04:07:36 +0000 (04:07 +0000)]
[iOS] Swatch appears squished and off-center in inputs of type color
https://bugs.webkit.org/show_bug.cgi?id=191279
<rdar://problem/45816319>

Reviewed by Tim Horton.

Source/WebCore:

This patch makes some small adjustments to color inputs on iOS to bring them closer to the intended design.
See comments below for more details.

Tests:  fast/forms/color/color-input-uses-color-well-appearance.html
        fast/forms/color/input-appearance-color.html

* css/html.css:

Adjust the UA stylesheet for color inputs on iOS.

* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paintDecorations):

When painting decorations for `ColorWellPart`, treat it as a standard button instead of the square button
appearance.

(WebCore::RenderTheme::colorInputStyleSheet const):

Add `-webkit-appearance: color-well;` to the stylesheet for color inputs. Previously, this was special-cased on
iOS, where color input elements had appearances of `textfield`; however, this patch makes some adjustments to
RenderThemeIOS, allowing us to use `color-well` on iOS.

* rendering/RenderTheme.h:
(WebCore::RenderTheme::platformUsesColorWellAppearance const): Deleted.

Remove this from RenderTheme. This is no longer necessary, since all platforms now use
`-webkit-appearance: color-well;`.

* rendering/RenderThemeIOS.h:
* rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::adjustButtonStyle const):

When painting buttons for color inputs, don't add rounded corners that are present by default for regular
buttons.

LayoutTests:

* fast/forms/color/color-input-uses-color-well-appearance-expected-mismatch.html: Added.
* fast/forms/color/color-input-uses-color-well-appearance.html: Added.

Add a test to verify that setting `-webkit-appearance: textfield;` on a color input causes the color input to
render differently from a color input with a default appearance.

* platform/ios-wk1/TestExpectations:
* platform/ios/TestExpectations:

In the WebKit2 port of iOS, enable a handful of color input tests that are currently disabled.

* platform/ios/fast/forms/color/input-appearance-color-expected.txt:

Rebaseline an existing test on iOS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[MediaStream] An audio track should be muted when capture is interrupted by the OS.
jer.noble@apple.com [Tue, 6 Nov 2018 00:45:01 +0000 (00:45 +0000)]
[MediaStream] An audio track should be muted when capture is interrupted by the OS.
Source/WebCore:

https://bugs.webkit.org/show_bug.cgi?id= 191283
 <rdar://problem/45773103>

Patch by Eric Carlson <eric.carlson@apple.com> on 2018-11-05
Reviewed by Jon Lee.

Test: fast/mediastream/media-stream-track-interrupted.html

* platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::RealtimeMediaSource::setInterruptedForTesting):
* platform/mediastream/RealtimeMediaSource.h:
* platform/mediastream/mac/CoreAudioCaptureSource.cpp:
(WebCore::CoreAudioCaptureSource::beginInterruption):
(WebCore::CoreAudioCaptureSource::endInterruption):
* testing/Internals.cpp:
(WebCore::Internals::setMediaStreamSourceInterrupted):
* testing/Internals.h:
* testing/Internals.idl:

LayoutTests:

https://bugs.webkit.org/show_bug.cgi?id=191283
 <rdar://problem/45773103>

Patch by Eric Carlson <eric.carlson@apple.com> on 2018-11-05
Reviewed by Jon Lee.

* fast/mediastream/media-stream-track-interrupted-expected.txt: Added.
* fast/mediastream/media-stream-track-interrupted.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agowebkitpy: Generalize trailing SDK specifier (Part 1)
jbedard@apple.com [Tue, 6 Nov 2018 00:21:36 +0000 (00:21 +0000)]
webkitpy: Generalize trailing SDK specifier (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=191275
<rdar://problem/45703660>

Reviewed by Lucas Forschler.

* Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo.available_sdks): List all installed SDKs with version numbers stripped out.
* Scripts/webkitpy/common/system/platforminfo_unittest.py:
(TestPlatformInfo):
(TestPlatformInfo.test_available_sdks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoParsing support for text-underline-offset and text-decoration-thickness
mmaxfield@apple.com [Tue, 6 Nov 2018 00:11:15 +0000 (00:11 +0000)]
Parsing support for text-underline-offset and text-decoration-thickness
https://bugs.webkit.org/show_bug.cgi?id=191242

Reviewed by Simon Fraser.

Source/WebCore:

Before we can implement the properties properly, we have to parse them.

https://github.com/w3c/csswg-drafts/issues/3118#issuecomment-432297480 describes the grammar:
text-underline-position: auto | [ [ under | from-font] || [ left | right ] ]
text-underline-offset: auto | <length>
text-decoration-thickness: auto | from-font | <length>

This patch also takes the opportunity to update the grammar of text-underline-position to match the spec,
and to add an alias to the unprefixed version.

We still don't support the left and right values on text-underline-position. We should add those eventually.

Tests: fast/css3-text/css3-text-decoration/text-decoration-thickness-parse.html
       fast/css3-text/css3-text-decoration/text-underline-offset-parse.html

* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::textUnderlineOffsetToCSSValue):
(WebCore::textDecorationThicknessToCSSValue):
(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextUnderlinePosition const):
(WebCore::CSSPrimitiveValue::operator OptionSet<TextUnderlinePosition> const): Deleted.
* css/CSSProperties.json:
* css/CSSValueKeywords.in:
* css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertTextUnderlinePosition):
(WebCore::StyleBuilderConverter::convertTextUnderlineOffset):
(WebCore::StyleBuilderConverter::convertTextDecorationThickness):
* css/StyleResolver.cpp:
(WebCore::shouldApplyPropertyInParseOrder):
* css/parser/CSSPropertyParser.cpp:
(WebCore::consumeTextUnderlineOffset):
(WebCore::consumeTextDecorationThickness):
(WebCore::CSSPropertyParser::parseSingleValue):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::textUnderlinePosition const):
(WebCore::RenderStyle::textUnderlineOffset const):
(WebCore::RenderStyle::textDecorationThickness const):
(WebCore::RenderStyle::setTextUnderlinePosition):
(WebCore::RenderStyle::setTextUnderlineOffset):
(WebCore::RenderStyle::setTextDecorationThickness):
(WebCore::RenderStyle::initialTextUnderlinePosition):
(WebCore::RenderStyle::initialTextUnderlineOffset):
(WebCore::RenderStyle::initialTextDecorationThickness):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):
* rendering/style/StyleRareInheritedData.h:
* rendering/style/TextDecorationThickness.h: Added.
(WebCore::TextDecorationThickness::createWithAuto):
(WebCore::TextDecorationThickness::createFromFont):
(WebCore::TextDecorationThickness::createWithLength):
(WebCore::TextDecorationThickness::isAuto const):
(WebCore::TextDecorationThickness::isFromFont const):
(WebCore::TextDecorationThickness::isLength const):
(WebCore::TextDecorationThickness::setLengthValue):
(WebCore::TextDecorationThickness::lengthValue const):
(WebCore::TextDecorationThickness::operator== const):
(WebCore::TextDecorationThickness::operator!= const):
(WebCore::TextDecorationThickness::TextDecorationThickness):
(WebCore::operator<<):
* rendering/style/TextUnderlineOffset.h: Added.
(WebCore::TextUnderlineOffset::createWithAuto):
(WebCore::TextUnderlineOffset::createWithLength):
(WebCore::TextUnderlineOffset::isAuto const):
(WebCore::TextUnderlineOffset::isLength const):
(WebCore::TextUnderlineOffset::setLengthValue):
(WebCore::TextUnderlineOffset::lengthValue const):
(WebCore::TextUnderlineOffset::lengthOr const):
(WebCore::TextUnderlineOffset::operator== const):
(WebCore::TextUnderlineOffset::operator!= const):
(WebCore::TextUnderlineOffset::TextUnderlineOffset):
(WebCore::operator<<):
* style/InlineTextBoxStyle.cpp:
(WebCore::computeUnderlineOffset):
* style/InlineTextBoxStyle.h:

LayoutTests:

* fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt:
* fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position.html: Update the
test for the new grammar of text-underline-position
* fast/css3-text/css3-text-decoration/text-decoration-thickness-parse-expected.txt: Added.
* fast/css3-text/css3-text-decoration/text-decoration-thickness-parse.html: Added.
* fast/css3-text/css3-text-decoration/text-underline-offset-parse-expected.txt: Added.
* fast/css3-text/css3-text-decoration/text-underline-offset-parse.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoSpelling dots are drawn in the wrong place
mmaxfield@apple.com [Tue, 6 Nov 2018 00:09:08 +0000 (00:09 +0000)]
Spelling dots are drawn in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=190764

Reviewed by Dean Jackson.

Source/WebCore:

- Dots should not be clipped.
- Dots should be horizontally centered.
- Dots should be drawn behind the text.
- Distance from the baseline to the top of the dot should be 11.035% of font size.
- Dot diameter should be 13.247% of the font size.
- Distance between the dots (right side of the left dot to left side of the right dot) should be 9.457% of the font size.
- The "font size" used in these calculations should be clamped so it's 10px <= font size <= 40px.

Tests: editing/spelling/spelling-dots-position-2.html
       editing/spelling/spelling-dots-position-3.html
       editing/spelling/spelling-dots-position.html
       editing/spelling/spelling-dots-repaint.html

* platform/graphics/cocoa/GraphicsContextCocoa.mm:
(WebCore::colorForMarkerLineStyle): Align iOS and macOS implementations.
(WebCore::GraphicsContext::drawDotsForDocumentMarker): Place the dots correctly.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addToLine): The KnownToHaveNoOverflow flag should be cleared if the element has spelling dots,
    because there is no guarantee the spelling dots will lie inside the layout rect of the element.
(WebCore::InlineFlowBox::addTextBoxVisualOverflow): Update the repaint rects to include splling dot positions.
* rendering/InlineFlowBox.h: Comments should explain why, not say what.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint): Draw the dots behind the text.
(WebCore::InlineTextBox::hasMarkers const): Convenience.
(WebCore::InlineTextBox::paintPlatformDocumentMarkers): Refactor bounds information into a helper function.
(WebCore::InlineTextBox::calculateUnionOfAllDocumentMarkerBounds const): Use for repaint rect calculation.
(WebCore::InlineTextBox::calculateDocumentMarkerBounds const): Place the dots correctly.
(WebCore::InlineTextBox::paintPlatformDocumentMarker): Call the helper method.
(WebCore::InlineTextBox::collectMarkedTextsForDocumentMarkers const):
(WebCore::InlineTextBox::collectMarkedTextsForDocumentMarkers): Deleted.
* rendering/InlineTextBox.h: Declare the helper methods.
* rendering/SimpleLineLayout.cpp: Simple line layout doesn't know how to paint spelling dots, so make the presence of
    spelling dots opt us out of SLL.
(WebCore::SimpleLineLayout::canUseForWithReason):
* rendering/SimpleLineLayoutCoverage.cpp:
(WebCore::SimpleLineLayout::printReason):
* rendering/SimpleLineLayoutCoverage.h: Add a new opt-out reason.

Tools:

Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
dots to be drawn.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):
(WTR::TestController::platformResetStateToConsistentValues):
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::hasSameInitializationOptions const):
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::cocoaResetStateToConsistentValues):
* WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
* WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::platformResetStateToConsistentValues):
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::platformResetStateToConsistentValues):

LayoutTests:

* editing/spelling/resources/VerySmallDescentAhem.ttf: Added. In order to test repaint rects,
      this is a version of Ahem with a very small descent, so that the dots don't intersect
      with the text itself.
* editing/spelling/spelling-dots-position-2-expected-mismatch.html: Added.
* editing/spelling/spelling-dots-position-2.html: Added. Make sure dots are painted in the
      correct vertical place.
* editing/spelling/spelling-dots-position-3-expected-mismatch.html: Added.
* editing/spelling/spelling-dots-position-3.html: Added. Make sure dots are painted in the
      correct vertical place.
* editing/spelling/spelling-dots-position-expected.html: Added.
* editing/spelling/spelling-dots-position.html: Added. Make sure dots are not painted in
      the wrong place.
* editing/spelling/spelling-dots-repaint-expected.html: Added.
* editing/spelling/spelling-dots-repaint.html: Added. Test repaint by drawing an element
      with spelling dots, and then deleting the element from the document. The spelling
      dots should be removed too.
* fast/writing-mode/english-bt-text-with-spelling-marker-expected.html:
* fast/writing-mode/english-bt-text-with-spelling-marker.html: Update the test to compensate
      for new spelling dot positions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoLayout Test imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescrip...
ryanhaddad@apple.com [Mon, 5 Nov 2018 23:11:31 +0000 (23:11 +0000)]
Layout Test imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=191278

Unreviewed test gardening.

* TestExpectations: Mark test as flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoWeb Inspector: Audit: turn off Start button when all tests are removed
drousso@apple.com [Mon, 5 Nov 2018 22:03:47 +0000 (22:03 +0000)]
Web Inspector: Audit: turn off Start button when all tests are removed
https://bugs.webkit.org/show_bug.cgi?id=191235

Reviewed by Matt Baker.

* UserInterface/Views/AuditNavigationSidebarPanel.js:
(WI.AuditNavigationSidebarPanel.prototype._handleAuditTestRemoved):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoUse same limit for page cache and suspended pages
cdumez@apple.com [Mon, 5 Nov 2018 21:38:05 +0000 (21:38 +0000)]
Use same limit for page cache and suspended pages
https://bugs.webkit.org/show_bug.cgi?id=191266

Reviewed by Geoffrey Garen.

Source/WebKit:

Use same limit for page cache and suspended pages as they serve the same purpose.

* UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _maximumSuspendedPageCount]):
* UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::updateMaxSuspendedPageCount):
(WebKit::WebProcessPool::setCacheModel):
(WebKit::WebProcessPool::addSuspendedPageProxy):
* UIProcess/WebProcessPool.h:

Tools:

Update API tests accordingly.

* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[IntersectionObserver] Update WPTs to the latest upstream version
ajuma@chromium.org [Mon, 5 Nov 2018 20:43:09 +0000 (20:43 +0000)]
[IntersectionObserver] Update WPTs to the latest upstream version
https://bugs.webkit.org/show_bug.cgi?id=191274

Reviewed by Simon Fraser.

* web-platform-tests/intersection-observer/bounding-box-expected.txt:
* web-platform-tests/intersection-observer/bounding-box.html:
* web-platform-tests/intersection-observer/target-in-different-window-expected.txt: Added.
* web-platform-tests/intersection-observer/target-in-different-window.html: Added.
* web-platform-tests/intersection-observer/w3c-import.log:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoAnother attempted build fix.
dino@apple.com [Mon, 5 Nov 2018 20:36:21 +0000 (20:36 +0000)]
Another attempted build fix.

* dom/messageports/MessagePortChannelRegistry.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoAttempted build fix.
dino@apple.com [Mon, 5 Nov 2018 20:26:56 +0000 (20:26 +0000)]
Attempted build fix.

* dom/messageports/MessagePortChannelRegistry.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[style] Exclude style check for auto generated files.
Basuke.Suzuki@sony.com [Mon, 5 Nov 2018 20:03:19 +0000 (20:03 +0000)]
[style] Exclude style check for auto generated files.
https://bugs.webkit.org/show_bug.cgi?id=191118

Reviewed by Eric Carlson.

Some files checked in to the repository are generated by other tools. In this patch,
"MiniBrowserLibResource.h" is the file generated and managed by resource editor of
VisualStudio.

There's no need to check these files because it's not practical to fix the style errors
or it's hard to maintain those fixes.

* Scripts/webkitpy/style/checkers/cpp.py:
(is_generated_file):
(CppChecker.check):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoCrash under DOMWindow::postMessageTimerFired()
cdumez@apple.com [Mon, 5 Nov 2018 19:58:05 +0000 (19:58 +0000)]
Crash under DOMWindow::postMessageTimerFired()
https://bugs.webkit.org/show_bug.cgi?id=191217
<rdar://problem/40888466>

Reviewed by Geoffrey Garen.

Source/WebCore:

Protect the frame in DOMWindow::postMessageTimerFired() before calling dispatchEvent() as dispatching the
event may cause JS to run and this JS may cause the frame to be destroyed, in which case we will crash
when trying to use the frame on the next line.

Test: fast/dom/Window/remove-frame-in-message-event-handler.html

* page/DOMWindow.cpp:
(WebCore::DOMWindow::postMessageTimerFired):

LayoutTests:

Add layout test coverage.

* fast/dom/Window/remove-frame-in-message-event-handler-expected.txt: Added.
* fast/dom/Window/remove-frame-in-message-event-handler.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[Flatpak] Build libx264 as it is the h264 encoder we support in WebRTC
commit-queue@webkit.org [Mon, 5 Nov 2018 19:38:57 +0000 (19:38 +0000)]
[Flatpak] Build libx264 as it is the h264 encoder we support in WebRTC
https://bugs.webkit.org/show_bug.cgi?id=190680

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

* flatpak/org.webkit.WebKit.yaml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoFix typos in closing ENABLE guards
don.olmstead@sony.com [Mon, 5 Nov 2018 19:35:51 +0000 (19:35 +0000)]
Fix typos in closing ENABLE guards
https://bugs.webkit.org/show_bug.cgi?id=191273

Reviewed by Keith Miller.

* ftl/FTLForOSREntryJITCode.h:
* ftl/FTLJITCode.h:
* jsc.cpp:
* wasm/WasmMemoryInformation.h:
* wasm/WasmPageCount.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[lldb-webkit] Fix formatting nits in Document and Frame summary strings
dbates@webkit.org [Mon, 5 Nov 2018 19:35:47 +0000 (19:35 +0000)]
[lldb-webkit] Fix formatting nits in Document and Frame summary strings
https://bugs.webkit.org/show_bug.cgi?id=191094

Reviewed by Andy Estes.

Format boolean as 1/0 when printing Frame summary to be consistent with the formatting of
booleans in other summary strings, substitute "inMainFrame" for "isMainFrame" in the printed
Document summary and add closing brace '}' to both Frame and Document summary strings to make
them look pretty.

* lldb/lldb_webkit.py:
(WebCoreFrame_SummaryProvider):
(WebCoreDocument_SummaryProvider):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoMake static_asserts in APICast into bitwise_cast
keith_miller@apple.com [Mon, 5 Nov 2018 19:21:36 +0000 (19:21 +0000)]
Make static_asserts in APICast into bitwise_cast
https://bugs.webkit.org/show_bug.cgi?id=191272

Reviewed by Filip Pizlo.

* API/APICast.h:
(toJS):
(toJSForGC):
(toRef):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[iOS] Allow WKWebView clients to customize bar button item groups in the accessory...
wenson_hsieh@apple.com [Mon, 5 Nov 2018 19:18:05 +0000 (19:18 +0000)]
[iOS] Allow WKWebView clients to customize bar button item groups in the accessory view when editing
https://bugs.webkit.org/show_bug.cgi?id=191240
<rdar://problem/44872806>

Reviewed by Tim Horton.

Source/WebKit:

Allow WKWebView clients to override WKContentView's default input assistant item by plumbing the call to
`-inputAssistantItem` through `-[WKWebView inputAssistantItem]`, such that if a client asks WKWebView for its
input assistant item and changes its leading or trailing bar button groups, the changes will be reflected by
WKContentView; additionally, this allows clients to achieve the same effect by overriding `-inputAssistantItem`
on WKWebView.

Test:   KeyboardInputTests.ModifyInputAssistantItemBarButtonGroups
        KeyboardInputTests.OverrideInputAssistantItemBarButtonGroups

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView inputAssistantItem]):
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView inputAssistantItem]):

Route the call to `[super inputAssistantItem]` through `-[WKWebView inputAssistantItem]`, so that the input
assistant item may be overridden via WKWebView.

(-[WKContentView inputAssistantItemForWebView]):

Tools:

Add new API tests to verify that setting leading and trailing bar button groups on WKWebView sets the first
responder's (i.e. WKContentView's) leading and trailing bar button groups, and that this can also be achieved by
overriding `-[WKWebView inputAssistantItem]`.

* TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
(-[InputAssistantItemTestingWebView fakeLeadingBarButtonItemAction]):
(-[InputAssistantItemTestingWebView fakeTrailingBarButtonItemAction]):
(+[InputAssistantItemTestingWebView barButtonIcon]):
(+[InputAssistantItemTestingWebView leadingItemsForWebView:]):
(+[InputAssistantItemTestingWebView trailingItemsForWebView:]):
(-[InputAssistantItemTestingWebView inputAssistantItem]):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[GStreamer] Fix EncodedImage timestamps to match what libWebRTC expects
commit-queue@webkit.org [Mon, 5 Nov 2018 19:15:14 +0000 (19:15 +0000)]
[GStreamer] Fix EncodedImage timestamps to match what libWebRTC expects
https://bugs.webkit.org/show_bug.cgi?id=190035

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

We can't rely on GStreamer timestamps to pass to EncodedImages after encoding
because libWebRTC doesn't use the timestamp we fed it but does
some computation on the input timestamp in the images we pass in before it passes
them back to the encoder. Then internally LibWebRTC relies on those exact timestamps
passed into the encoder to do checks and compute RTP timestamps so we need to carefully
pass the exact timestamps to LibWebRTC (in practice we still use GStreamer timestamps in
all the GStreamer processing pipelines as the WebRTC object basically wraps the "same"
`GstSample` all around, but we are not synced on the clock anyway).

* platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
* platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.cpp:
(WebCore::LibWebRTCVideoFrameFromGStreamerSample):
* platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.h:
* platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp:
(WebCore::GStreamerVideoDecoder::newSampleCallback):
* platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:
(WebCore::GStreamerVideoEncoder::GStreamerVideoEncoder):
(WebCore::GStreamerVideoEncoder::newSampleCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[iOS] Changing view scale sometimes does not zoom the page to the new initial scale...
wenson_hsieh@apple.com [Mon, 5 Nov 2018 19:12:38 +0000 (19:12 +0000)]
[iOS] Changing view scale sometimes does not zoom the page to the new initial scale when the page is zoomed in when ignoring meta viewport
https://bugs.webkit.org/show_bug.cgi?id=191226
<rdar://problem/45781765>

Reviewed by Tim Horton.

Source/WebCore:

When `_setViewScale:` SPI is used to adjust the layout scale factor of the page, we multiply minimum, initial
and maximum scales by the given layout scale factor to adjust for a larger or smaller minimum layout size.
However, in the case where the layout size scale factor is greater than 1 and we're also forcing the viewport to
be scalable, we override the default minimum scale with 1 (i.e. `forceAlwaysUserScalableMinimumScale`). This
means that the might be off by a small margin due to rounding error when computing the content width and view
width (see: r237743).

This means that in the case where (1) the viewport is forced to be user-scalable, and (2) we're ignoring meta
viewport parameters, and (3) `_viewScale` exceeds 1, we may end up computing a slightly different minimum scale
than the default minimum scale multiplied by the layout size scale factor; subsequently, the page scale factor
will be slightly different from initial scale, such that we'll no longer zoom to the new initial scale when
changing view scale.

This patch adjusts `forceAlwaysUserScalableMinimumScale` and `forceAlwaysUserScalableMaximumScale` to take the
current layout scale factor into account when computing min and max scales when the viewport is forced to be
always scalable.

Test: fast/viewport/ios/minimum-scale-after-changing-view-scale.html

* page/ViewportConfiguration.cpp:
(WebCore::ViewportConfiguration::minimumScale const):
* page/ViewportConfiguration.h:
(WebCore::ViewportConfiguration::maximumScale const):
(WebCore::ViewportConfiguration::forceAlwaysUserScalableMaximumScale const):
(WebCore::ViewportConfiguration::forceAlwaysUserScalableMinimumScale const):

Turn these from constant values to const functions on ViewportConfiguration, which factor in the current
viewport layout size scale factor.

Tools:

Add a missing check for `shouldIgnoreMetaViewport` when comparing TestOptions, to ensure that "ignore meta
viewport" state doesn't unexpectedly persist after running a layout test that ignores meta viewport.

* WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::hasSameInitializationOptions const):

LayoutTests:

Add a new layout test that sets the view scale to several values greater than or equal to 1 and verifies that
the minimum scale and resulting scroll view scale are exactly the same as the view scale, when (1) the "ignores
meta viewport" preference is enabled, and (2) the viewport is forced to be always scalable.

* fast/viewport/ios/minimum-scale-after-changing-view-scale-expected.txt: Added.
* fast/viewport/ios/minimum-scale-after-changing-view-scale.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoWeb Inspector: Table selection should not require that rows be in the cache
mattbaker@apple.com [Mon, 5 Nov 2018 19:01:30 +0000 (19:01 +0000)]
Web Inspector: Table selection should not require that rows be in the cache
https://bugs.webkit.org/show_bug.cgi?id=190993
<rdar://problem/45613812>

Reviewed by Devin Rousso.

Source/WebInspectorUI:

Deselecting a table row shouldn't depend on it being in the cache. This
allows us to implement select all, and other kinds of bulk selection
actions that affect rows that haven't been revealed.

* UserInterface/Views/Table.js:
(WI.Table.prototype.deselectRow):

LayoutTests:

Add a test that a table row that is not in the cache can be selected/deselected.

* inspector/table/table-selection-expected.txt:
* inspector/table/table-selection.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoExpose a constructor for PointerEvent from PlatformTouchEvent
dino@apple.com [Mon, 5 Nov 2018 18:37:43 +0000 (18:37 +0000)]
Expose a constructor for PointerEvent from PlatformTouchEvent
https://bugs.webkit.org/show_bug.cgi?id=191238
<rdar://problem/45795682>

Reviewed by Antoine Quint.

Implement a constructor that takes a PlatformTouchEvent to
create a PointerEvent. At the moment the code to call this
constructor will live in WebKitAdditions, so no new tests
yet.

* SourcesCocoa.txt: Add PointerEventIOS.cpp.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* dom/EventNames.h: Add macros for pointerdown, pointermove,
     pointerup, pointercancel.
* dom/PointerEvent.cpp: Remove JSC namespace.
* dom/PointerEvent.h: Add create and constructor that takes
     a PlatformTouchEvent.
* dom/ios/PointerEventIOS.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoUnreviewed, rolling out r237785.
ryanhaddad@apple.com [Mon, 5 Nov 2018 18:07:06 +0000 (18:07 +0000)]
Unreviewed, rolling out r237785.

Introduced layout test and API test failures on macOS and iOS.

Reverted changeset:

"[iOS] Issue initial paint soon after the visuallyNonEmpty
milestone is fired."
https://bugs.webkit.org/show_bug.cgi?id=191078
https://trac.webkit.org/changeset/237785

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoUnreviewed, rolling out r237784 and r237788.
commit-queue@webkit.org [Mon, 5 Nov 2018 18:03:14 +0000 (18:03 +0000)]
Unreviewed, rolling out r237784 and r237788.
https://bugs.webkit.org/show_bug.cgi?id=191270

Caused mediastream layout test failures (Requested by
ryanhaddad on #webkit).

Reverted changesets:

"[MediaStream] User should not be prompted again after denying
getDisplayMedia request"
https://bugs.webkit.org/show_bug.cgi?id=191227
https://trac.webkit.org/changeset/237784

"[MediaStream] User should not be prompted again after denying
getDisplayMedia request"
https://bugs.webkit.org/show_bug.cgi?id=191227
https://trac.webkit.org/changeset/237788

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoResync html/browsers/the-window-object/apis-for-creating-and-navigating-browsing...
cdumez@apple.com [Mon, 5 Nov 2018 17:54:22 +0000 (17:54 +0000)]
Resync html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name WPT tests
https://bugs.webkit.org/show_bug.cgi?id=191214

Reviewed by Geoff Garen.

Resync html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name WPT tests from
upstream c583bcd7eb.

* web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/creating_browsing_context_test_01-expected.txt:
* web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/creating_browsing_context_test_01.html:
* web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/no_window_open_when_term_nesting_level_nonzero.window-expected.txt: Added.
* web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/no_window_open_when_term_nesting_level_nonzero.window.html: Added.
* web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/no_window_open_when_term_nesting_level_nonzero.window.js: Added.
(test.frame.contentWindow.onpagehide):
(test.frame.contentDocument.onvisibilitychange):
(test.frame.contentWindow.onbeforeunload):
(test.frame.contentWindow.onunload):
(test):
(async_test):
* web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/non_automated/w3c-import.log:
* web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noopener-expected.txt:
* web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noopener.html:
* web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/resources/message-opener.html:
* web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/resources/w3c-import.log:
* web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/w3c-import.log:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agohttps://bugs.webkit.org/show_bug.cgi?id=191268
lforschler@apple.com [Mon, 5 Nov 2018 17:47:42 +0000 (17:47 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=191268
Remove unused bots.

rubber-stamped by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoUnreviewed build fix for linux.
msaboff@apple.com [Mon, 5 Nov 2018 17:43:40 +0000 (17:43 +0000)]
Unreviewed build fix for linux.

* stress/regexp-compile-oom.js: Disabled for non-darwin OSes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoWeb Inspector: show save/restore stack for recorded 2D Canvases
drousso@apple.com [Mon, 5 Nov 2018 17:34:48 +0000 (17:34 +0000)]
Web Inspector: show save/restore stack for recorded 2D Canvases
https://bugs.webkit.org/show_bug.cgi?id=175283
<rdar://problem/34040756>

Reviewed by Matt Baker.

Source/WebInspectorUI:

Instead of using plain objects for holding the `WI.Recording`'s state, use a model object
so that more data can be passed around. When visualizing the state, show any previously
saved states in a `WI.DetailsSection` underneath the current state. If there are no saved
states (meaning there is only the current state), don't use a `WI.DetailsSection`.

* UserInterface/Models/RecordingState.js: Added.
(WI.RecordingState):
(WI.RecordingState.fromContext):
(WI.RecordingState.async swizzleInitialState):
(WI.RecordingState.prototype.get source):
(WI.RecordingState.prototype.has):
(WI.RecordingState.prototype.get return):
(WI.RecordingState.prototype.toJSON):
(WI.RecordingState.prototype.[Symbol.iterator]):

* UserInterface/Models/Recording.js:
(WI.Recording.prototype.async _process):
(WI.Recording.prototype.async _swizzleState): Deleted.

* UserInterface/Models/RecordingAction.js:
(WI.RecordingAction.prototype.process):
(WI.RecordingAction.deriveCurrentState): Deleted.

* UserInterface/Views/RecordingContentView.js:
(WI.RecordingContentView.prototype._generateContentCanvas2D):

* UserInterface/Views/RecordingStateDetailsSidebarPanel.js:
(WI.RecordingStateDetailsSidebarPanel):
(WI.RecordingStateDetailsSidebarPanel.prototype.get scrollElement):
(WI.RecordingStateDetailsSidebarPanel.prototype.sizeDidChange): Added.
(WI.RecordingStateDetailsSidebarPanel.prototype._generateDetailsCanvas2D):
(WI.RecordingStateDetailsSidebarPanel.prototype._generateDetailsCanvas2D.isColorProperty): Deleted.
(WI.RecordingStateDetailsSidebarPanel.prototype._generateDetailsCanvas2D.createInlineSwatch): Deleted.
* UserInterface/Views/RecordingStateDetailsSidebarPanel.css:
(.sidebar > .panel.details.recording-state > .content .details-section > .header .source): Added.
(.sidebar > .panel.details.recording-state > .content .data-grid tr.modified): Added.
(.sidebar > .panel.details.recording-state > .content .data-grid tr:not(.selected).non-standard .name-column): Added.
(.sidebar > .panel.details.recording-state > .content .data-grid tr:not(.selected) .unavailable): Added.
(.sidebar > .panel.details.recording-state > .content .data-grid .inline-swatch): Added.
(.sidebar > .panel.details.recording-state > .content > .data-grid tr.modified): Deleted.
(.sidebar > .panel.details.recording-state > .content > .data-grid tr:not(.selected).non-standard): Deleted.
(.sidebar > .panel.details.recording-state > .content > .data-grid tr:not(.selected) .unavailable): Deleted.
(.sidebar > .panel.details.recording-state > .content > .data-grid .inline-swatch): Deleted.

* UserInterface/Main.html:
* UserInterface/Test.html:

* Localizations/en.lproj/localizedStrings.js:

LayoutTests:

* inspector/canvas/recording-2d.html:
* inspector/canvas/resources/recording-utilities.js:
(TestPage.registerInitializer.log):
(TestPage.registerInitializer.async logRecording):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[WPE][GTK] API test runner fails to respect default build type
mcatanzaro@igalia.com [Mon, 5 Nov 2018 16:45:20 +0000 (16:45 +0000)]
[WPE][GTK] API test runner fails to respect default build type
https://bugs.webkit.org/show_bug.cgi?id=190247

Reviewed by Carlos Garcia Campos.

Problem is it's looking for a release build, even though I've run set-webkit-configuration
--debug. It should look for a debug build unless I explicitly pass --release.

* glib/api_test_runner.py:
(TestRunner.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[GStreamer][WebRTC] Error out when simulcast is activated
commit-queue@webkit.org [Mon, 5 Nov 2018 16:08:12 +0000 (16:08 +0000)]
[GStreamer][WebRTC] Error out when simulcast is activated
https://bugs.webkit.org/show_bug.cgi?id=190678

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

Implementing it is not for now yet.
Source/WebCore:

Tests for simulcast have been disabled as they now fail (instead of crashing).

* platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:
(WebCore::GStreamerVideoEncoder::InitEncode):

LayoutTests:

Tests for simulcast have been disabled as they now fail (instead of crashing).

* platform/gtk/TestExpectations:
* platform/wpe/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoEnable LLInt on ARMv7/Linux
dinfuehr@igalia.com [Mon, 5 Nov 2018 16:07:40 +0000 (16:07 +0000)]
Enable LLInt on ARMv7/Linux
https://bugs.webkit.org/show_bug.cgi?id=191190

Reviewed by Yusuke Suzuki.

After enabling the new bytecode format in r237547, C_LOOP was
forced on all 32-bit platforms. Now enable LLInt again on
.:

ARMv7-Thumb2/Linux by default.

* Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

ARMv7-Thumb2/Linux.

This adds a callee-saved register in ARMv7/Linux for the metadataTable and
stores/restores it on LLInt function calls. It also introduces the globaladdr-
instruction for the ARM-offlineasm to access the opcode-table.

* jit/GPRInfo.h:
* jit/RegisterSet.cpp:
(JSC::RegisterSet::llintBaselineCalleeSaveRegisters):
* llint/LowLevelInterpreter.asm:
* llint/LowLevelInterpreter32_64.asm:
* offlineasm/arm.rb:
* offlineasm/asm.rb:
* offlineasm/instructions.rb:

Source/WTF:

ARMv7-Thumb2/Linux by default.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoRealtimeOutgoingAudioSource subclasses should observe its source when fully constructed
youenn@apple.com [Mon, 5 Nov 2018 15:32:03 +0000 (15:32 +0000)]
RealtimeOutgoingAudioSource subclasses should observe its source when fully constructed
https://bugs.webkit.org/show_bug.cgi?id=191241

Reviewed by Eric Carlson.

Moving the logic to observe the audio source to the point where the
RealtimeOutgoingAudioSource subclass is fully initialized.
Covered by existing tests.

* platform/mediastream/RealtimeOutgoingAudioSource.cpp:
(WebCore::RealtimeOutgoingAudioSource::RealtimeOutgoingAudioSource):
(WebCore::RealtimeOutgoingAudioSource::observeSource):
* platform/mediastream/RealtimeOutgoingAudioSource.h:
* platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.cpp:
(WebCore::RealtimeOutgoingAudioSourceLibWebRTC::RealtimeOutgoingAudioSourceLibWebRTC):
* platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.cpp:
(WebCore::RealtimeOutgoingAudioSourceCocoa::RealtimeOutgoingAudioSourceCocoa):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[GStreamer][WebRTC] Add webrtcencoder bin to cleanup and refactor the way we set...
commit-queue@webkit.org [Mon, 5 Nov 2018 15:09:54 +0000 (15:09 +0000)]
[GStreamer][WebRTC] Add webrtcencoder bin to cleanup and refactor the way we set encoders
https://bugs.webkit.org/show_bug.cgi?id=190674

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

webrtcencoder is a simple GstBin with a set of well known GStreamer encoders which
it can use to implement encoding for different formats exposing a trimmed down unified API.

It also adds proper handling of H264 profiles.

The added files follow GStreamer coding style as we aim at upstreaming the element
in the future.

Source/WebCore:

This is a refactoring so current tests already cover it.

* platform/GStreamer.cmake:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::initializeGStreamerAndRegisterWebKitElements):
* platform/mediastream/libwebrtc/GStreamerVideoEncoder.cpp: Added.
(gst_webrtc_video_encoder_get_property):
(gst_webrtc_video_encoder_set_bitrate):
(gst_webrtc_video_encoder_set_format):
(gst_webrtc_video_encoder_set_property):
(register_known_encoder):
(setup_x264enc):
(setup_vp8enc):
(setup_openh264enc):
(set_bitrate_kbit_per_sec):
(set_bitrate_bit_per_sec):
(gst_webrtc_video_encoder_class_init):
(gst_webrtc_video_encoder_init):
* platform/mediastream/libwebrtc/GStreamerVideoEncoder.h: Added.
* platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:
(WebCore::GStreamerVideoEncoder::GStreamerVideoEncoder):
(WebCore::GStreamerVideoEncoder::InitEncode):
(WebCore::GStreamerVideoEncoder::createEncoder):
(WebCore::GStreamerVideoEncoder::AddCodecIfSupported):
(WebCore::GStreamerVideoEncoder::ImplementationName const):
(WebCore::GStreamerVideoEncoder::SetRestrictionCaps):

Tools:

Reviewed by Philippe Normand.

* Scripts/webkitpy/style/checker.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[GStreamer][WebRTC] properly mark H.264 stream type in the "decoder"
commit-queue@webkit.org [Mon, 5 Nov 2018 15:05:39 +0000 (15:05 +0000)]
[GStreamer][WebRTC] properly mark H.264 stream type in the "decoder"
https://bugs.webkit.org/show_bug.cgi?id=190676

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

Avoiding to have h264parse make assumption (which might be wrong at some
point).

* platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp:
(WebCore::GStreamerVideoDecoder::GetCapsForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[GStreamer] Do not sync libwerbtc stream on the clock
commit-queue@webkit.org [Mon, 5 Nov 2018 14:50:28 +0000 (14:50 +0000)]
[GStreamer] Do not sync libwerbtc stream on the clock
https://bugs.webkit.org/show_bug.cgi?id=190677

The approach here is basically to let libwebrtc do all the
synchronisation for us, and the same way as it is done in apple ports,
we basically try to display what libwebrtc outputs as fast as possible.

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

Manually tested

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::setSyncOnSink):
(WebCore::MediaPlayerPrivateGStreamer::syncOnClock):
(WebCore::MediaPlayerPrivateGStreamer::loadFull):
(WebCore::MediaPlayerPrivateGStreamer::load):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[IntersectionObserver] Fix isIntersecting computation when 0 is not a threshold
ajuma@chromium.org [Mon, 5 Nov 2018 14:47:40 +0000 (14:47 +0000)]
[IntersectionObserver] Fix isIntersecting computation when 0 is not a threshold
https://bugs.webkit.org/show_bug.cgi?id=191210

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Update expectation for test that now passes.

* web-platform-tests/intersection-observer/initial-observation-with-threshold-expected.txt:

Source/WebCore:

isIntersecting should be false if the intersection ratio is smaller than the
smallest threshold value. Update the computation of isIntersecting to depend on
the current thresholdIndex.

Test: imported/w3c/web-platform-tests/intersection-observer/initial-observation-with-threshold-expected.html

* dom/Document.cpp:
(WebCore::Document::updateIntersectionObservations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoRemove some virtual methods in CachedRawResource
commit-queue@webkit.org [Mon, 5 Nov 2018 13:55:21 +0000 (13:55 +0000)]
Remove some virtual methods in CachedRawResource
https://bugs.webkit.org/show_bug.cgi?id=191251

Patch by Rob Buis <rbuis@igalia.com> on 2018-11-05
Reviewed by Frédéric Wang.

Since CachedRawResource is final no need to introduce new virtual
methods in CachedRawResource. This patch also removes an outdated
comment and forward declaration.

No new tests since no change in functionality.

* loader/cache/CachedRawResource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
mcatanzaro@igalia.com [Mon, 5 Nov 2018 12:19:47 +0000 (12:19 +0000)]
[WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
https://bugs.webkit.org/show_bug.cgi?id=191221

Reviewed by Carlos Garcia Campos.

This test ensures that MSE is disabled by default, but we now enable it by default, so
reverse the semantics of the test.

* TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
(testWebKitSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoREGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
mcatanzaro@igalia.com [Mon, 5 Nov 2018 10:46:38 +0000 (10:46 +0000)]
REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
https://bugs.webkit.org/show_bug.cgi?id=191225

Reviewed by Alejandro G. Castro.

Fix a memory leak causing this test to fail.

* TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
(WebViewTest::initializeWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[GStreamer] Move elements registration to GStreamerCommon
philn@webkit.org [Mon, 5 Nov 2018 10:00:19 +0000 (10:00 +0000)]
[GStreamer] Move elements registration to GStreamerCommon
https://bugs.webkit.org/show_bug.cgi?id=191189

Reviewed by Xabier Rodriguez-Calvar.

It was a bit odd to have this in the base player class and to have
sub-classes calling a static function of the super-class.

Covered by existing tests.

* platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::initializeGStreamerAndRegisterWebKitElements):
* platform/graphics/gstreamer/GStreamerCommon.h:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::isAvailable):
(WebCore::MediaPlayerPrivateGStreamer::loadFull):
(WebCore::MediaPlayerPrivateGStreamer::getSupportedTypes):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
* platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::registerMediaEngine):
(WebCore::MediaPlayerPrivateGStreamerMSE::load):
(WebCore::MediaPlayerPrivateGStreamerMSE::trackDetected):
(WebCore::MediaPlayerPrivateGStreamerMSE::supportsType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[Win][Clang][JSC] JIT::is64BitType reports "warning: explicit specialization cannot...
Hironori.Fujii@sony.com [Mon, 5 Nov 2018 09:34:01 +0000 (09:34 +0000)]
[Win][Clang][JSC] JIT::is64BitType reports "warning: explicit specialization cannot have a storage class"
https://bugs.webkit.org/show_bug.cgi?id=191146

Reviewed by Yusuke Suzuki.

* jit/JIT.h: Changed is64BitType from a template class method to a
template inner class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoUnreviewed WPE gardening. Updating or adding various baselines. Also
zandobersek@gmail.com [Mon, 5 Nov 2018 09:08:47 +0000 (09:08 +0000)]
Unreviewed WPE gardening. Updating or adding various baselines. Also
adding new failure expectations for tests that need a closer look.

* platform/wpe/TestExpectations:
* platform/wpe/fast/block/basic/child-block-level-box-with-height-percent-expected.txt: Added.
* platform/wpe/fast/block/basic/height-percentage-simple-expected.txt: Added.
* platform/wpe/fast/block/basic/inline-content-with-floating-image-expected.txt: Added.
* platform/wpe/fast/block/basic/inline-content-with-floating-images2-expected.txt: Added.
* platform/wpe/fast/block/basic/quirk-mode-percent-height-expected.txt: Added.
* platform/wpe/fast/history: Added.
* platform/wpe/fast/history/page-cache-webdatabase-pending-transaction-expected.txt: Added.
* platform/wpe/fast/inline-block/14498-positionForCoordinates-expected.txt:
* platform/wpe/fast/inline/simple-inline-block-expected.txt: Added.
* platform/wpe/fast/inline/simple-intruding-float1-expected.txt: Added.
* platform/wpe/fast/inline/simple-intruding-floats2-expected.txt: Added.
* platform/wpe/fast/inline/simple-intruding-floats3-expected.txt: Added.
* platform/wpe/fast/inline/simple-shrink-to-fit-inline-block-expected.txt: Added.
* platform/wpe/webgl/2.0.0/conformance/canvas/drawingbuffer-test-expected.txt: Added.
* platform/wpe/webgl/2.0.0/conformance/context/context-attributes-alpha-depth-stencil-antialias-expected.txt:
* platform/wpe/webgl/2.0.0/conformance/context/context-hidden-alpha-expected.txt:
* platform/wpe/webgl/2.0.0/conformance/extensions/get-extension-expected.txt:
* platform/wpe/webgl/2.0.0/conformance/extensions/oes-texture-half-float-with-image-data-expected.txt: Added.
* platform/wpe/webgl/2.0.0/conformance/glsl/misc/shaders-with-invariance-expected.txt:
* platform/wpe/webgl/2.0.0/conformance/rendering/multisample-corruption-expected.txt:
* platform/wpe/webgl/2.0.0/conformance2/buffers/bound-buffer-size-change-test-expected.txt:
* platform/wpe/webgl/2.0.0/conformance2/extensions/promoted-extensions-in-shaders-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[WPE][GTK] Expose ENABLE_MEDIA_SOURCE as public option
mcatanzaro@igalia.com [Mon, 5 Nov 2018 08:03:30 +0000 (08:03 +0000)]
[WPE][GTK] Expose ENABLE_MEDIA_SOURCE as public option
https://bugs.webkit.org/show_bug.cgi?id=191223

Reviewed by Xabier Rodriguez-Calvar.

This option should be public because it needs to be disabled to build with GStreamer older
than 1.14.4.

* Source/cmake/GStreamerDefinitions.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[webkitpy] Support WPE in the run-web-platform-tests script
zandobersek@gmail.com [Mon, 5 Nov 2018 06:50:12 +0000 (06:50 +0000)]
[webkitpy] Support WPE in the run-web-platform-tests script
https://bugs.webkit.org/show_bug.cgi?id=191183

Reviewed by Alex Christensen.

* Scripts/webkitpy/w3c/wpt_runner.py:
(parse_args): Support `--wpe` as an argument that specifies WPE as the
target port. Additionally, the `--display-server` flag now accepts
`headless` as a valid value, enabling the WPE WebDriver to run in
headless mode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[Win] Use C++14, not C++17
Hironori.Fujii@sony.com [Mon, 5 Nov 2018 04:38:32 +0000 (04:38 +0000)]
[Win] Use C++14, not C++17
https://bugs.webkit.org/show_bug.cgi?id=191101

Reviewed by Alex Christensen.

.:

Based on the webkit-dev discussion, this change switches Windows
port from C++17 to C++14.
<https://lists.webkit.org/pipermail/webkit-dev/2018-September/030186.html>

* Source/cmake/OptionsMSVC.cmake: Replaced /std:c++17 with /std:c++14 switch.

Source/WTF:

* wtf/StdLibExtras.h: Use _MSVC_LANG to check C++ language version
instead of _MSC_FULL_VER.

Tools:

std::basic_string::data() returns a read-only const buffer in
C++14.

* MiniBrowser/win/WebKitBrowserWindow.cpp:
(createString): Use std::vector instead of std::wstring.
(createUTF8String): Use std::vector instead of std::string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[MediaStream] User should not be prompted again after denying getDisplayMedia request
Hironori.Fujii@sony.com [Mon, 5 Nov 2018 04:29:02 +0000 (04:29 +0000)]
[MediaStream] User should not be prompted again after denying getDisplayMedia request
https://bugs.webkit.org/show_bug.cgi?id=191227
<rdar://problem/45784512>

Unreviewed build fix of ports not ENABLE(MEDIA_STREAM).

* UIProcess/UserMediaPermissionRequestManagerProxy.cpp: Define getRequestAction only if ENABLE(MEDIA_STREAM).
* UIProcess/UserMediaPermissionRequestManagerProxy.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoRemove ENABLE_OPENCL fully
commit-queue@webkit.org [Mon, 5 Nov 2018 02:15:48 +0000 (02:15 +0000)]
Remove ENABLE_OPENCL fully
https://bugs.webkit.org/show_bug.cgi?id=191172

Patch by Rob Buis <rbuis@igalia.com> on 2018-11-04
Reviewed by Yusuke Suzuki.

Forgot to simplify this, no need for applyAll anymore
since it just calls apply.

No new tests since no change in functionality.

* platform/graphics/filters/FilterEffect.h:
(WebCore::FilterEffect::applyAll): Deleted.
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::postApplyResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptCo...
wenson_hsieh@apple.com [Sun, 4 Nov 2018 21:19:44 +0000 (21:19 +0000)]
[Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptControllerCocoa.mm
https://bugs.webkit.org/show_bug.cgi?id=191231

Reviewed by Simon Fraser.

Moves some UIScriptController method implementations specific to iOS and macOS into UIScriptControllerCocoa, so
it can be shared between iOS-family and macOS platforms. See below for more details.

No change in behavior.

* DumpRenderTree/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::overridePreference):

Add a method stub for DumpRenderTree.

* TestRunnerShared/UIScriptContext/UIScriptController.cpp:
* WebKitTestRunner/UIScriptControllerCocoa.mm:
(WTR::UIScriptController::doAsyncTask):
(WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):

Unify these method implementations.

(WTR::UIScriptController::removeViewFromWindow):
(WTR::UIScriptController::addViewToWindow):

Move the macOS implementation to UIScriptControllerCocoa. On iOS, this method currently only adds the web view
to the window, and does not attempt to invoke the given completion block; additionally, invoking the completion
block after a presentation update (as done on macOS) causes pageoverlay/overlay-remove-reinsert-view.html to
begin failing consistently. This patch does not attempt to change behavior, but adds a FIXME describing this.

(WTR::UIScriptController::overridePreference):
(WTR::UIScriptController::findString):
(WTR::UIScriptController::contentsOfUserInterfaceItem const):

Move these from UIScriptControllerMac to UIScriptControllerCocoa, so that it is now implemented on iOS as well.

* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::doAsyncTask): Deleted.
(WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
(WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
(WTR::UIScriptController::findString): Deleted.
(WTR::UIScriptController::removeViewFromWindow): Deleted.
(WTR::UIScriptController::addViewToWindow): Deleted.
* WebKitTestRunner/mac/UIScriptControllerMac.mm:
(WTR::UIScriptController::doAsyncTask): Deleted.
(WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
(WTR::UIScriptController::overridePreference): Deleted.
(WTR::UIScriptController::findString): Deleted.
(WTR::UIScriptController::removeViewFromWindow): Deleted.
(WTR::UIScriptController::addViewToWindow): Deleted.
(WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[iOS] Issue initial paint soon after the visuallyNonEmpty milestone is fired.
zalan@apple.com [Sun, 4 Nov 2018 16:38:36 +0000 (16:38 +0000)]
[iOS] Issue initial paint soon after the visuallyNonEmpty milestone is fired.
https://bugs.webkit.org/show_bug.cgi?id=191078
<rdar://problem/45736178>

Reviewed by Antti Koivisto.

Source/WebCore:

1. Improve visuallyNonEmpty milestone confidence level.
    Ignore whitespace and non visible text content.
    Parsing the main document should not necessarily fire the milestone. Check if there's any pending scripts/css/font loading.
    Check if the html/body is actually visible.

2. Issue initial paint soon after the milestone fires.
    Use a 0ms timer to flush the initial paint.
    Throttle additional flushes for 500ms (remove the non-initial 1.5 throttling)

3. Suspend optional style recalcs and layouts while painting is being throttled.
   When parsing yields we initiate a 0ms style recalc/layout timer.
   These optional layouts produce content that we have no intention to paint.

* dom/Document.cpp:
(WebCore::Document::scheduleStyleRecalc):
(WebCore::Document::shouldScheduleLayout):
* page/ChromeClient.h:
* page/FrameView.cpp:
(WebCore::FrameView::resetLayoutMilestones):
(WebCore::FrameView::qualifiesAsVisuallyNonEmpty const):
(WebCore::FrameView::updateSignificantRenderedTextMilestoneIfNeeded):
(WebCore::FrameView::updateIsVisuallyNonEmpty):
* page/FrameView.h:
(WebCore::FrameView::incrementVisuallyNonEmptyCharacterCount): Ignore whitespace characters. Some pages start with plenty of whitespace only content.
* platform/graphics/FontCascade.h:
* rendering/RenderText.cpp: Check whether the text is actually visible at this point.
(WebCore::RenderText::RenderText):

Source/WebKit:

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::layerFlushThrottlingIsActive const):
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebPage/AcceleratedDrawingArea.cpp:
(WebKit::AcceleratedDrawingArea::scheduleInitialDeferredPaint):
* WebProcess/WebPage/AcceleratedDrawingArea.h:
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::layerFlushThrottlingIsActive const):
* WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:
* WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::setLayerTreeStateIsFrozen):
(WebKit::RemoteLayerTreeDrawingArea::initialDeferredPaint):
(WebKit::RemoteLayerTreeDrawingArea::scheduleInitialDeferredPaint):
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scheduleInitialDeferredPaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[MediaStream] User should not be prompted again after denying getDisplayMedia request
eric.carlson@apple.com [Sun, 4 Nov 2018 16:04:19 +0000 (16:04 +0000)]
[MediaStream] User should not be prompted again after denying getDisplayMedia request
https://bugs.webkit.org/show_bug.cgi?id=191227
<rdar://problem/45784512>

Reviewed by Youenn Fablet.

Source/WebKit:

* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasDenied):
(WebKit::UserMediaPermissionRequestManagerProxy::wasRequestDenied):
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
* UIProcess/UserMediaPermissionRequestManagerProxy.h:

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
(-[GetDisplayMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
(TestWebKitAPI::GetDisplayMediaTest::promptForCapture):
(TestWebKitAPI::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[LFC][BFC] Add support for percentage height in quirks mode.
zalan@apple.com [Sun, 4 Nov 2018 15:46:38 +0000 (15:46 +0000)]
[LFC][BFC] Add support for percentage height in quirks mode.
https://bugs.webkit.org/show_bug.cgi?id=191232

Reviewed by Antti Koivisto.

Source/WebCore:

In quirks mode, we go and travers the containing block chain to find a block level
box with fixed height value to resolve the percentage value.

Test: fast/block/basic/quirk-mode-percent-height.html

* layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::computedHeightValue):
* layout/Verification.cpp:
(WebCore::Layout::LayoutState::verifyAndOutputMismatchingLayoutTree const):

Tools:

* LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

* fast/block/basic/quirk-mode-percent-height-expected.txt: Added.
* fast/block/basic/quirk-mode-percent-height.html: Added.
* platform/ios/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[LFC][BCF] Add support for block level non-replaced inflow height percentage
zalan@apple.com [Sun, 4 Nov 2018 15:44:57 +0000 (15:44 +0000)]
[LFC][BCF] Add support for block level non-replaced inflow height percentage
https://bugs.webkit.org/show_bug.cgi?id=191229

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/block/basic/child-block-level-box-with-height-percent.html

* layout/FormattingContext.h:
* layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::computedHeightValue):
(WebCore::Layout::computedHeightValue): Deleted.
* layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):

Tools:

* LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

* fast/block/basic/child-block-level-box-with-height-percent-expected.txt: Added.
* fast/block/basic/child-block-level-box-with-height-percent.html: Added.
* platform/ios/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoRealtimeOutgoingAudioSource should use DestructionThread::Main
youenn@apple.com [Sun, 4 Nov 2018 15:30:31 +0000 (15:30 +0000)]
RealtimeOutgoingAudioSource should use DestructionThread::Main
https://bugs.webkit.org/show_bug.cgi?id=191230

Reviewed by Eric Carlson.

Covered by imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-replaceTrack.https.html
that should no longer crash in debug.

* platform/mediastream/RealtimeOutgoingAudioSource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237781 268f45cc-cd09-0410-ab3c-d52691b4dbfc