WebKit-https.git
7 years agoAdjust test expectations for fast/js/toString-overrides.html and fast/js/eval-cross...
commit-queue@webkit.org [Thu, 23 Aug 2012 22:50:05 +0000 (22:50 +0000)]
Adjust test expectations for fast/js/toString-overrides.html and fast/js/eval-cross-window.html
https://bugs.webkit.org/show_bug.cgi?id=94824

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-08-23
Reviewed by Kentaro Hara.

Add a bug number for tracking failing cases in fast/js/toString-overrides.html.
Upload Chromium specific test expectations for fast/js/eval-cross-window.html.

Failing tests in eval-cross-window swap the eval() function in the main window and the frame.
This behaviour is not specified in ECMA-262 and is probably implementation dependent.
Both Firefox and Chromium produce the same result for this test.

* platform/chromium/TestExpectations:
* platform/chromium/fast/js/eval-cross-window-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTrailing spaces in CSP source lists should not generate console warnings.
commit-queue@webkit.org [Thu, 23 Aug 2012 22:48:25 +0000 (22:48 +0000)]
Trailing spaces in CSP source lists should not generate console warnings.
https://bugs.webkit.org/show_bug.cgi?id=94847

Patch by Mike West <mkwst@chromium.org> on 2012-08-23
Reviewed by Adam Barth.

Trailing space after a valid source in a Content Security Policy source
list was accidentally generating console warnings about an invalid
(empty) source. This patch silently ignores trailing whitespace instead.

Source/WebCore:

A test-case has been added to 'source-list-parsing-02.html' to cover
this case.

* page/ContentSecurityPolicy.cpp:
(WebCore::CSPSourceList::parse):
    Return early if we reach the end of the source list after skipping
    leading whitespace.

LayoutTests:

* http/tests/security/contentSecurityPolicy/source-list-parsing-02-expected.txt:
* http/tests/security/contentSecurityPolicy/source-list-parsing-02.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] LayoutTests: css3/selector3/xml tests are flaky / have wrong expectations...
kbr@google.com [Thu, 23 Aug 2012 22:37:38 +0000 (22:37 +0000)]
[Chromium] LayoutTests: css3/selector3/xml tests are flaky / have wrong expectations on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=82122

Unreviewed Chromium gardening. Expanded expectations from Snow Leopard to Mac.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove some unneeded cruft from WebCore.xcodeproj.
mrowe@apple.com [Thu, 23 Aug 2012 22:17:54 +0000 (22:17 +0000)]
Remove some unneeded cruft from WebCore.xcodeproj.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Replace the three different rendering mechanisms for clearing the render...
commit-queue@webkit.org [Thu, 23 Aug 2012 21:53:37 +0000 (21:53 +0000)]
[BlackBerry] Replace the three different rendering mechanisms for clearing the render queue
https://bugs.webkit.org/show_bug.cgi?id=94837

Patch by Adam Treat <atreat@rim.com> on 2012-08-23
Reviewed by George Staikos.

PR 197738

Currently, we have three different mechanisms for clearing the render queue.
The first mechanism is render on idle.  Whenever the webkit thread becomes idle
(read: no more events in its queue) we render the next job in the render queue.
 This is the primary means we use for clearing the render queue.  However, this
mechanism has a flaw, it is such a low priority mechanism that sometimes the
queue grows so fast due to higher priority events adding rects to the queue
that this mechanism can't possibly keep up.  That is what leads to the second
mechanism: rendering right before a timer is fired when we discover that the
render queue is under pressure and rendering on idle can't keep up.  However,
there are still degenerate cases where even this mechanism does not allow us to
keep up.  That brings us to the third mechanism: rendering based on a timer
that is a catch-all.

The second and third mechanisms lead to very large render jobs as they try and
clear the queue faster when it comes under pressure.  These very large render
jobs end up keeping the webkit thread busy with a message that can take large
fractions of a second to resolve.

These three mechanisms were put in place when the backingstore had a different
overall design that was not truly asynchronous.  This patch replaces these
three mechanisms with a single one that uses the platform messaging classes to
full purpose - a uniquely coalescing message that has a higher priority level
than timers making sure the render queue can never come under pressure.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(WebKit):
(RenderJobMessage):
(BlackBerry::WebKit::RenderJobMessage::RenderJobMessage):
(BlackBerry::WebKit::BackingStorePrivate::dispatchRenderJob):
(BlackBerry::WebKit::BackingStorePrivate::renderJob):
(BlackBerry::WebKit::BackingStore::blitContents):
* Api/BackingStore.h:
* Api/BackingStore_p.h:
(BackingStorePrivate):
* Api/WebPage.cpp:
* Api/WebPage.h:
* WebKitSupport/RenderQueue.cpp:
(BlackBerry::WebKit::RenderQueue::reset):
(BlackBerry::WebKit::RenderQueue::addToRegularQueue):
(BlackBerry::WebKit::RenderQueue::addToScrollZoomQueue):
(BlackBerry::WebKit::RenderQueue::clear):
(BlackBerry::WebKit::RenderQueue::clearVisibleZoom):
(BlackBerry::WebKit::RenderQueue::render):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] OwnHandle is a bit of a misnomer
abarth@webkit.org [Thu, 23 Aug 2012 21:45:42 +0000 (21:45 +0000)]
[V8] OwnHandle is a bit of a misnomer
https://bugs.webkit.org/show_bug.cgi?id=94841

Reviewed by Eric Seidel.

You don't really own the handle in the same way that you own a pointer
with OwnPtr. This class is more correctly called ScopedPersistent
because it just forces you to balance New() and Dispose() calls.

* WebCore.gypi:
* bindings/v8/JavaScriptCallFrame.h:
(JavaScriptCallFrame):
* bindings/v8/OwnHandle.h: Removed.
* bindings/v8/ScheduledAction.h:
(ScheduledAction):
* bindings/v8/ScopedPersistent.h: Copied from Source/WebCore/bindings/v8/OwnHandle.h.
(ScopedPersistent):
(WebCore::ScopedPersistent::ScopedPersistent):
(WebCore::ScopedPersistent::~ScopedPersistent):
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::compileScript):
(WebCore::ScriptDebugServer::runScript):
* bindings/v8/ScriptDebugServer.h:
(ScriptDebugServer):
* bindings/v8/ScriptInstance.h:
(V8ScriptInstance):
* bindings/v8/V8PerContextData.h:
(V8PerContextData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoProgressTracker never completes if iframe detached during parsing
japhet@chromium.org [Thu, 23 Aug 2012 21:26:07 +0000 (21:26 +0000)]
ProgressTracker never completes if iframe detached during parsing
https://bugs.webkit.org/show_bug.cgi?id=92272

Reviewed by Adam Barth.

Add a simple helper class to FrameLoader to ensure progressStarted/progressCompleted calls are matched,
and balance the calls when the Frame is detached.

No new tests, as this behavior has only been producing reliably by setting a breakpoint in a specific place.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::init):
(WebCore::FrameLoader::FrameProgressTracker::progressStarted):
(WebCore::FrameLoader::FrameProgressTracker::progressCompleted):
(WebCore::FrameLoader::FrameProgressTracker::~FrameProgressTracker):
(WebCore::FrameLoader::prepareForLoadStart):
(WebCore::FrameLoader::clearProvisionalLoad):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::detachFromParent):
* loader/FrameLoader.h:
(FrameProgressTracker):
(WebCore::FrameLoader::FrameProgressTracker::create):
(WebCore::FrameLoader::FrameProgressTracker::FrameProgressTracker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Create sharedQuadState at same time as creating quads and give them to...
danakj@chromium.org [Thu, 23 Aug 2012 21:01:27 +0000 (21:01 +0000)]
[chromium] Create sharedQuadState at same time as creating quads and give them to the quadSink
https://bugs.webkit.org/show_bug.cgi?id=94752

Reviewed by Adrienne Walker.

Source/WebCore:

Previously, CCRenderPass would create a sharedQuadState for a layer,
and pass it in to the layer. Then the layer would point all its quads
at the sharedQuadState.

After this change, the layer creates its own sharedQuadState, gives it
to the RenderPass (via CCQuadSink), and points its quads at it.

This approach allows a layer to generate more than one sharedQuadState
with different quads pointing to different shared states. Also, this
will allow the layer representing a delegating renderer (via ubercomp)
to copy sharedQuadStates from the delegating renderer in order to
merge its quads into the RenderPass for the current renderer.

Covered by existing tests, no change in behaviour.

* platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:
(WebCore::CCHeadsUpDisplayLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.h:
(CCHeadsUpDisplayLayerImpl):
* platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
(WebCore::CCIOSurfaceLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.h:
(CCIOSurfaceLayerImpl):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::createSharedQuadState):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
(WebCore::CCLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::CCQuadCuller::CCQuadCuller):
(WebCore::CCQuadCuller::append):
(WebCore::CCQuadCuller::useSharedQuadState):
(WebCore):
* platform/graphics/chromium/cc/CCQuadCuller.h:
(WebCore):
(CCQuadCuller):
* platform/graphics/chromium/cc/CCQuadSink.h:
(WebCore):
(CCQuadSink):
* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsForLayer):
(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):
(WebCore::CCRenderPass::appendQuadsToFillScreen):
* platform/graphics/chromium/cc/CCRenderPass.h:
(WebCore):
(CCRenderPass):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::appendQuads):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
(WebCore::CCScrollbarLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
(CCScrollbarLayerImpl):
* platform/graphics/chromium/cc/CCSharedQuadState.cpp:
(WebCore::CCSharedQuadState::create):
(WebCore::CCSharedQuadState::CCSharedQuadState):
* platform/graphics/chromium/cc/CCSharedQuadState.h:
(CCSharedQuadState):
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:
(WebCore::CCSolidColorLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:
(CCSolidColorLayerImpl):
* platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
(WebCore::CCTextureLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCTextureLayerImpl.h:
(CCTextureLayerImpl):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(CCVideoLayerImpl):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:
* tests/CCLayerTreeHostTest.cpp:
(WTF::EvictionTestLayerImpl::appendQuads):
* tests/CCQuadCullerTest.cpp:
* tests/CCRenderSurfaceTest.cpp:
* tests/CCSolidColorLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
* tests/CCTiledLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):
(CCLayerTestCommon::coverageVisibleRectOnTileBoundaries):
(CCLayerTestCommon::coverageVisibleRectIntersectsTiles):
(CCLayerTestCommon::coverageVisibleRectIntersectsBounds):
* tests/MockCCQuadCuller.h:
(WebCore::MockCCQuadCuller::MockCCQuadCuller):
(MockCCQuadCuller):
(WebCore::MockCCQuadCuller::quadList):
(WebCore::MockCCQuadCuller::sharedQuadStateList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRoll out part of r126475 that breaks the build with older versions of Clang.
mrowe@apple.com [Thu, 23 Aug 2012 20:57:47 +0000 (20:57 +0000)]
Roll out part of r126475 that breaks the build with older versions of Clang.

* wtf/FastMalloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed - fixing input list for timeline inspector module.
pfeldman@chromium.org [Thu, 23 Aug 2012 20:56:54 +0000 (20:56 +0000)]
Not reviewed - fixing input list for timeline inspector module.
https://bugs.webkit.org/show_bug.cgi?id=94829

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake gtest build with the latest version of clang.
mrowe@apple.com [Thu, 23 Aug 2012 20:50:31 +0000 (20:50 +0000)]
Make gtest build with the latest version of clang.

Reviewed by Dan Bernstein.

* gtest/src/gtest-internal-inl.h:
(GTestFlagSaver): Remove an unused member.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake WebKit2 build with the latest version of clang.
mrowe@apple.com [Thu, 23 Aug 2012 20:50:27 +0000 (20:50 +0000)]
Make WebKit2 build with the latest version of clang.

Reviewed by Dan Bernstein.

* Configurations/Base.xcconfig: Ensure that operator new isn't exported as a weak external symbol.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake WebCore build with the latest version of clang.
mrowe@apple.com [Thu, 23 Aug 2012 20:50:23 +0000 (20:50 +0000)]
Make WebCore build with the latest version of clang.

Reviewed by Dan Bernstein.

* html/shadow/MediaControlRootElement.h: Remove m_textTrackDisplay as it is unused.
* platform/audio/mac/AudioFileReaderMac.cpp:
(WebCore::AudioFileReader::AudioFileReader): Remove m_filePath as it is unused.
* platform/audio/mac/AudioFileReaderMac.h:
(AudioFileReader): Ditto.
* platform/graphics/ImageSource.h:
(ImageSource): Guard m_alphaOption and m_gammaAndColorProfileOption with !USE(CG)
as they're unused on platforms using CG.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
(MediaPlayerPrivateAVFoundationObjC): Remove m_player as it is unused.
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::ImageSource): Don't initialize the m_alphaOption and
m_gammaAndColorProfileOption members since we never use them.
* platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate): Remove m_graphicsContext3D
as it is unused.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake JavaScriptCore build with the latest version of clang.
mrowe@apple.com [Thu, 23 Aug 2012 20:50:18 +0000 (20:50 +0000)]
Make JavaScriptCore build with the latest version of clang.

Reviewed by Dan Bernstein.

* heap/MachineStackMarker.cpp:
(JSC::MachineThreads::MachineThreads): The m_heap member is only used within
assertions, so guard its initialization with !ASSERT_DISABLED.
* heap/MachineStackMarker.h:
(MachineThreads): Ditto for its declaration.
* jit/JITStubCall.h:
(JSC::JITStubCall::JITStubCall): The m_returnType member is only used within
assertions or if we're using JSVALUE32_64, so guard its uses with the appropriate
(JITStubCall): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake WTF build with the latest version of clang.
mrowe@apple.com [Thu, 23 Aug 2012 20:50:13 +0000 (20:50 +0000)]
Make WTF build with the latest version of clang.

Reviewed by Dan Bernstein.

* wtf/FastMalloc.cpp:
(WTF): Disable the -Wunused-private-field warning around the declaration of
TCMalloc_Central_FreeListPadded since the padding is intentionally unused.
(WTF::AdminRegionRecorder): Remove the unused m_reader member.
(WTF::FastMallocZone::enumerate): Don't pass in the RemoteMemoryReader since
it is no longer needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Unify slow and fast in-region scrolling code paths
tonikitoo@webkit.org [Thu, 23 Aug 2012 20:39:11 +0000 (20:39 +0000)]
[BlackBerry] Unify slow and fast in-region scrolling code paths
https://bugs.webkit.org/show_bug.cgi?id=94834
PR #197662

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>
Internally reviewed by Arvid Nilsson.

In order to be able to remove a bunch of obsolete code from
InRegionScroller.cpp, we need to unify the codepaths for slow
and fast in-region scrolling.

This patch caches the root scrollable node of each scrollable block
in InRegionScrollableArea also for the non-composited-scrolling case now too
(analogly to the way we cache LayerWebKitThread for the composited scrolling case).

Now the client (libwebview) can dispatch an in-region scrolling with one single code path,
making use of a boolean (argh!) to inform if the scroll of the given
layer supports compositing or not. Later on, this boolean is used to casting the proper element.

* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScroller::setScrollPositionWebKitThread):
(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionWebKitThread):
* Api/InRegionScroller.h:
* Api/InRegionScroller_p.h:
(InRegionScrollerPrivate):
* WebKitSupport/InRegionScrollableArea.cpp:
(WebKit):
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
(BlackBerry::WebKit::enclosingLayerNode):
* WebKitSupport/InRegionScrollableArea.h:
(WebCore):
(InRegionScrollableArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Rename LayerRendererChromium to GL-specific name
aelias@chromium.org [Thu, 23 Aug 2012 20:31:46 +0000 (20:31 +0000)]
[chromium] Rename LayerRendererChromium to GL-specific name
https://bugs.webkit.org/show_bug.cgi?id=94835

Reviewed by James Robinson.

Over time, LayerRendererChromium has evolved to be a GL-specific
subclass of CCRenderer that has no awareness of layers (as it operates
only with drawQuads).

This patch renames LayerRendererChromium to CCRendererGL, replaces all
instances of "layerRenderer" with just "renderer", and removes a
few unnecessary includes of LayerRendererChromium.h.

Source/WebCore:

No new tests (no-op refactoring).

* WebCore.gypi:
* platform/graphics/chromium/Canvas2DLayerBridge.cpp:
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):
* platform/graphics/chromium/GeometryBinding.cpp:
* platform/graphics/chromium/HeadsUpDisplayLayerChromium.cpp:
(WebCore::HeadsUpDisplayLayerChromium::update):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::createTextureUpdaterIfNeeded):
* platform/graphics/chromium/LayerTextureSubImage.cpp:
* platform/graphics/chromium/ProgramBinding.cpp:
* platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore):
* platform/graphics/chromium/ScrollbarLayerChromium.cpp:
(WebCore::ScrollbarLayerChromium::createTextureUpdaterIfNeeded):
* platform/graphics/chromium/TextureCopier.cpp:
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
* platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:
* platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::sortLayers):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initializeRenderer):
(WebCore::CCLayerTreeHost::deleteContentsTexturesOnImplThread):
(WebCore::CCLayerTreeHost::finishAllRendering):
(WebCore::CCLayerTreeHost::rendererCapabilities):
(WebCore::CCLayerTreeHost::initializeRendererIfNeeded):
(WebCore::CCLayerTreeHost::updateLayers):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::RendererCapabilities::RendererCapabilities):
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::canDraw):
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::finishAllRendering):
(WebCore::CCLayerTreeHostImpl::isContextLost):
(WebCore::CCLayerTreeHostImpl::rendererCapabilities):
(WebCore::CCLayerTreeHostImpl::swapBuffers):
(WebCore::CCLayerTreeHostImpl::readback):
(WebCore::CCLayerTreeHostImpl::setVisible):
(WebCore::CCLayerTreeHostImpl::initializeRenderer):
(WebCore::CCLayerTreeHostImpl::setViewportSize):
(WebCore::CCLayerTreeHostImpl::ensureRenderSurfaceLayerList):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore):
(WebCore::CCLayerTreeHostImpl::renderer):
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCPrioritizedTexture.cpp:
* platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:
* platform/graphics/chromium/cc/CCPriorityCalculator.cpp:
* platform/graphics/chromium/cc/CCProxy.h:
(WebCore):
(CCProxy):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
* platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore):
* platform/graphics/chromium/cc/CCRenderer.h:
(CCRenderer):
* platform/graphics/chromium/cc/CCRendererGL.cpp: Renamed from Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp.
(WebCore::CCRendererGL::create):
(WebCore):
(WebCore::CCRendererGL::CCRendererGL):
(WebCore::CCRendererGL::initialize):
(WebCore::CCRendererGL::~CCRendererGL):
(WebCore::CCRendererGL::context):
(WebCore::CCRendererGL::debugGLCall):
(WebCore::CCRendererGL::setVisible):
(WebCore::CCRendererGL::releaseRenderPassTextures):
(WebCore::CCRendererGL::viewportChanged):
(WebCore::CCRendererGL::clearFramebuffer):
(WebCore::CCRendererGL::beginDrawingFrame):
(WebCore::CCRendererGL::doNoOp):
(WebCore::CCRendererGL::drawQuad):
(WebCore::CCRendererGL::drawCheckerboardQuad):
(WebCore::CCRendererGL::drawDebugBorderQuad):
(WebCore::applyFilters):
(WebCore::CCRendererGL::drawBackgroundFilters):
(WebCore::CCRendererGL::drawRenderPassQuad):
(WebCore::CCRendererGL::drawSolidColorQuad):
(TileProgramUniforms):
(WebCore::tileUniformLocation):
(WebCore::CCRendererGL::drawTileQuad):
(WebCore::CCRendererGL::drawYUVVideoQuad):
(WebCore::CCRendererGL::drawStreamVideoQuad):
(WebCore::TextureProgramBinding::set):
(TextureProgramBinding):
(WebCore::TexTransformTextureProgramBinding::set):
(TexTransformTextureProgramBinding):
(WebCore::CCRendererGL::drawTextureQuad):
(WebCore::CCRendererGL::drawIOSurfaceQuad):
(WebCore::CCRendererGL::finishDrawingFrame):
(WebCore::CCRendererGL::toGLMatrix):
(WebCore::CCRendererGL::setShaderFloatQuad):
(WebCore::CCRendererGL::setShaderOpacity):
(WebCore::CCRendererGL::drawQuadGeometry):
(WebCore::CCRendererGL::copyTextureToFramebuffer):
(WebCore::CCRendererGL::finish):
(WebCore::CCRendererGL::swapBuffers):
(WebCore::CCRendererGL::onSwapBuffersComplete):
(WebCore::CCRendererGL::onMemoryAllocationChanged):
(WebCore::CCRendererGL::onMemoryAllocationChangedOnImplThread):
(WebCore::CCRendererGL::discardFramebuffer):
(WebCore::CCRendererGL::ensureFramebuffer):
(WebCore::CCRendererGL::onContextLost):
(WebCore::CCRendererGL::getFramebufferPixels):
(WebCore::CCRendererGL::getFramebufferTexture):
(WebCore::CCRendererGL::useScopedTexture):
(WebCore::CCRendererGL::bindFramebufferToOutputSurface):
(WebCore::CCRendererGL::bindFramebufferToTexture):
(WebCore::CCRendererGL::enableScissorTestRect):
(WebCore::CCRendererGL::disableScissorTest):
(WebCore::CCRendererGL::setDrawViewportSize):
(WebCore::CCRendererGL::makeContextCurrent):
(WebCore::CCRendererGL::initializeSharedObjects):
(WebCore::CCRendererGL::tileCheckerboardProgram):
(WebCore::CCRendererGL::solidColorProgram):
(WebCore::CCRendererGL::renderPassProgram):
(WebCore::CCRendererGL::renderPassProgramAA):
(WebCore::CCRendererGL::renderPassMaskProgram):
(WebCore::CCRendererGL::renderPassMaskProgramAA):
(WebCore::CCRendererGL::tileProgram):
(WebCore::CCRendererGL::tileProgramOpaque):
(WebCore::CCRendererGL::tileProgramAA):
(WebCore::CCRendererGL::tileProgramSwizzle):
(WebCore::CCRendererGL::tileProgramSwizzleOpaque):
(WebCore::CCRendererGL::tileProgramSwizzleAA):
(WebCore::CCRendererGL::textureProgram):
(WebCore::CCRendererGL::textureProgramFlip):
(WebCore::CCRendererGL::textureIOSurfaceProgram):
(WebCore::CCRendererGL::videoYUVProgram):
(WebCore::CCRendererGL::videoStreamTextureProgram):
(WebCore::CCRendererGL::cleanupSharedObjects):
(WebCore::CCRendererGL::isContextLost):
* platform/graphics/chromium/cc/CCRendererGL.h: Renamed from Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h.
(WebKit):
(WebCore):
(CCRendererGL):
(WebCore::CCRendererGL::sharedGeometryQuad):
(WebCore::CCRendererGL::sharedGeometry):
(WebCore::CCRendererGL::isFramebufferDiscarded):
* platform/graphics/chromium/cc/CCResourceProvider.cpp:
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::initializeRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):
(WebCore::CCSingleThreadProxy::rendererCapabilities):
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::forceSerializeOnSwapBuffers):
(WebCore::CCSingleThreadProxy::commitAndComposite):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::initializeRenderer):
(WebCore::CCThreadProxy::recreateContext):
(WebCore::CCThreadProxy::rendererCapabilities):
(WebCore::CCThreadProxy::forceSerializeOnSwapBuffersOnImplThread):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):
(WebCore::CCThreadProxy::initializeRendererOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/CCLayerTreeHostImplTest.cpp:
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):
(WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::drawLayersOnCCThread):
* tests/CCRendererGLTest.cpp: Renamed from Source/WebKit/chromium/tests/LayerRendererChromiumTest.cpp.
(FrameCountingMemoryAllocationSettingContext):
(FrameCountingMemoryAllocationSettingContext::FrameCountingMemoryAllocationSettingContext):
(FrameCountingMemoryAllocationSettingContext::prepareTexture):
(FrameCountingMemoryAllocationSettingContext::setMemoryAllocationChangedCallbackCHROMIUM):
(FrameCountingMemoryAllocationSettingContext::getString):
(FrameCountingMemoryAllocationSettingContext::frameCount):
(FrameCountingMemoryAllocationSettingContext::setMemoryAllocation):
(FakeCCRendererClient):
(FakeCCRendererClient::FakeCCRendererClient):
(FakeCCRendererClient::setFullRootLayerDamageCount):
(FakeCCRendererClient::rootRenderPass):
(FakeCCRendererClient::renderPassesInDrawOrder):
(FakeCCRendererClient::renderPasses):
(FakeCCRendererClient::memoryAllocationLimitBytes):
(FakeCCRendererGL):
(FakeCCRendererGL::FakeCCRendererGL):
(CCRendererGLTest):
(CCRendererGLTest::CCRendererGLTest):
(CCRendererGLTest::SetUp):
(CCRendererGLTest::TearDown):
(CCRendererGLTest::swapBuffers):
(CCRendererGLTest::context):
(TEST_F):
(ForbidSynchronousCallContext):
(ForbidSynchronousCallContext::ForbidSynchronousCallContext):
(ForbidSynchronousCallContext::getActiveAttrib):
(ForbidSynchronousCallContext::getActiveUniform):
(ForbidSynchronousCallContext::getAttachedShaders):
(ForbidSynchronousCallContext::getAttribLocation):
(ForbidSynchronousCallContext::getBooleanv):
(ForbidSynchronousCallContext::getBufferParameteriv):
(ForbidSynchronousCallContext::getContextAttributes):
(ForbidSynchronousCallContext::getError):
(ForbidSynchronousCallContext::getFloatv):
(ForbidSynchronousCallContext::getFramebufferAttachmentParameteriv):
(ForbidSynchronousCallContext::getIntegerv):
(ForbidSynchronousCallContext::getProgramiv):
(ForbidSynchronousCallContext::getShaderiv):
(ForbidSynchronousCallContext::getString):
(ForbidSynchronousCallContext::getProgramInfoLog):
(ForbidSynchronousCallContext::getRenderbufferParameteriv):
(ForbidSynchronousCallContext::getShaderInfoLog):
(ForbidSynchronousCallContext::getShaderPrecisionFormat):
(ForbidSynchronousCallContext::getShaderSource):
(ForbidSynchronousCallContext::getTexParameterfv):
(ForbidSynchronousCallContext::getTexParameteriv):
(ForbidSynchronousCallContext::getUniformfv):
(ForbidSynchronousCallContext::getUniformiv):
(ForbidSynchronousCallContext::getUniformLocation):
(ForbidSynchronousCallContext::getVertexAttribfv):
(ForbidSynchronousCallContext::getVertexAttribiv):
(ForbidSynchronousCallContext::getVertexAttribOffset):
(TEST):
(LoseContextOnFirstGetContext):
(LoseContextOnFirstGetContext::LoseContextOnFirstGetContext):
(ContextThatDoesNotSupportMemoryManagmentExtensions):
(ContextThatDoesNotSupportMemoryManagmentExtensions::ContextThatDoesNotSupportMemoryManagmentExtensions):
(ContextThatDoesNotSupportMemoryManagmentExtensions::prepareTexture):
(ContextThatDoesNotSupportMemoryManagmentExtensions::setMemoryAllocationChangedCallbackCHROMIUM):
(ContextThatDoesNotSupportMemoryManagmentExtensions::getString):
(ClearCountingContext):
(ClearCountingContext::ClearCountingContext):
(ClearCountingContext::clear):
(ClearCountingContext::clearCount):
* tests/TiledLayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Removing media/track/track-mode.html - resolved.
annacc@chromium.org [Thu, 23 Aug 2012 20:29:20 +0000 (20:29 +0000)]
[Chromium] Removing media/track/track-mode.html - resolved.
[Chromium] Removing media/track/track-cues-cuechange.html - appears to be no longer failing.

Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Web pages are zoomed out to much on initial load
zhajiang@rim.com [Thu, 23 Aug 2012 20:27:10 +0000 (20:27 +0000)]
[BlackBerry] Web pages are zoomed out to much on initial load
https://bugs.webkit.org/show_bug.cgi?id=94830

Reviewed by Adam Treat.
Patch by Jacky Jiang <zhajiang@rim.com>

PR: 193943
Browser continuously adds paddings to the left and right sides of the
main contents which makes the main contents even smaller.
The issue can be reproduced on the desktop websites such as
huffingtonpost.ca, bloomberg.com, online.wsj.com, nytimes.com,
yahoo.com, thestar.com, sina.com.cn, sohu.com and so on.
The root cause is that we layout those contents at the width of 1280
although the fixed width of the main contents of those websites is
less than 1000, which results in adding the paddings.
To fix this, we need to get back to the default max layout size
1024 * 768, which will make the main contents of those popular websites
take full advantage of the screen real estate and look much better.

Internally reviewed by Adam Treat.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
* Api/WebPage_p.h:
(WebPagePrivate):
* WebKitSupport/RenderQueue.cpp:
(BlackBerry::WebKit::RenderQueue::splittingFactor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
senorblanco@chromium.org [Thu, 23 Aug 2012 20:22:52 +0000 (20:22 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFlexbox doesn't need to compute logical height for stretched items in row flow
commit-queue@webkit.org [Thu, 23 Aug 2012 19:46:51 +0000 (19:46 +0000)]
Flexbox doesn't need to compute logical height for stretched items in row flow
https://bugs.webkit.org/show_bug.cgi?id=94807

Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-08-23
Reviewed by Tony Chang.

Change logicalHeightConstrainedByMinMax to
constrainLogicalHeightByMinMax. The new method doesn't compute the
MainOrPreferred logical height (that computation has been moved back to
computeLogicalHeight). RenderFlexibleBox now just constrains the
stretchedLogicalHeight by min/max.

No new tests. This is a cleanup of bug 94237.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::constrainLogicalHeightByMinMax): Instead of
computing the MainOrPreferred logical height, just constrain the given
logical height by MinSize and MaxSize.
(WebCore::RenderBox::computeLogicalHeight): Compute the MainOrPreferred
logical height before constraining by min/max.
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild): Use
constrainLogicalHeightByMinMax to constrain the stretchedLogicalHeight.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Update pixel test expectations for layout test fast/forms/
commit-queue@webkit.org [Thu, 23 Aug 2012 19:20:49 +0000 (19:20 +0000)]
[EFL] Update pixel test expectations for layout test fast/forms/
https://bugs.webkit.org/show_bug.cgi?id=94687

Unreviewed, rebaseline.

Some tests have wrong pixel test expectations. They should be replaced.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-23

* platform/efl/fast/forms/003-expected.png:
* platform/efl/fast/forms/006-expected.png:
* platform/efl/fast/forms/007-expected.png:
* platform/efl/fast/forms/HTMLOptionElement_label01-expected.png:
* platform/efl/fast/forms/HTMLOptionElement_label02-expected.png:
* platform/efl/fast/forms/HTMLOptionElement_label03-expected.png:
* platform/efl/fast/forms/HTMLOptionElement_label04-expected.png:
* platform/efl/fast/forms/HTMLOptionElement_label05-expected.png:
* platform/efl/fast/forms/basic-buttons-expected.png:
* platform/efl/fast/forms/basic-inputs-expected.png:
* platform/efl/fast/forms/button-align-expected.png:
* platform/efl/fast/forms/button-cannot-be-nested-expected.png:
* platform/efl/fast/forms/button-default-title-expected.png:
* platform/efl/fast/forms/button-generated-content-expected.png:
* platform/efl/fast/forms/button-inner-block-reuse-expected.png:
* platform/efl/fast/forms/button-sizes-expected.png:
* platform/efl/fast/forms/button-style-color-expected.png:
* platform/efl/fast/forms/button-table-styles-expected.png:
* platform/efl/fast/forms/button-text-transform-expected.png:
* platform/efl/fast/forms/button-white-space-expected.png:
* platform/efl/fast/forms/control-clip-expected.png:
* platform/efl/fast/forms/control-clip-overflow-expected.png:
* platform/efl/fast/forms/control-restrict-line-height-expected.png:
* platform/efl/fast/forms/disabled-select-change-index-expected.png:
* platform/efl/fast/forms/encoding-test-expected.png:
* platform/efl/fast/forms/fieldset-align-expected.png:
* platform/efl/fast/forms/file/file-input-direction-expected.png:
* platform/efl/fast/forms/file/file-input-disabled-expected.png:
* platform/efl/fast/forms/floating-textfield-relayout-expected.png:
* platform/efl/fast/forms/form-hides-table-expected.png:
* platform/efl/fast/forms/image-border-expected.png:
* platform/efl/fast/forms/input-appearance-bkcolor-expected.png:
* platform/efl/fast/forms/input-appearance-default-bkcolor-expected.png:
* platform/efl/fast/forms/input-appearance-focus-expected.png:
* platform/efl/fast/forms/input-appearance-preventDefault-expected.png:
* platform/efl/fast/forms/input-appearance-selection-expected.png:
* platform/efl/fast/forms/input-appearance-visibility-expected.png:
* platform/efl/fast/forms/input-appearance-width-expected.png:
* platform/efl/fast/forms/input-button-sizes-expected.png:
* platform/efl/fast/forms/input-disabled-color-expected.png:
* platform/efl/fast/forms/input-double-click-selection-gap-bug-expected.png:
* platform/efl/fast/forms/input-field-text-truncated-expected.png:
* platform/efl/fast/forms/input-readonly-dimmed-expected.png:
* platform/efl/fast/forms/input-readonly-empty-expected.png:
* platform/efl/fast/forms/input-spaces-expected.png:
* platform/efl/fast/forms/input-table-expected.png:
* platform/efl/fast/forms/input-text-click-inside-expected.png:
* platform/efl/fast/forms/input-text-option-delete-expected.png:
* platform/efl/fast/forms/input-text-self-emptying-click-expected.png:
* platform/efl/fast/forms/input-text-word-wrap-expected.png:
* platform/efl/fast/forms/input-type-text-min-width-expected.png:
* platform/efl/fast/forms/input-value-expected.png:
* platform/efl/fast/forms/input-width-expected.png:
* platform/efl/fast/forms/listbox-bidi-align-expected.png:
* platform/efl/fast/forms/listbox-scrollbar-incremental-load-expected.png:
* platform/efl/fast/forms/listbox-width-change-expected.png:
* platform/efl/fast/forms/menulist-clip-expected.png:
* platform/efl/fast/forms/menulist-option-wrap-expected.png:
* platform/efl/fast/forms/menulist-width-change-expected.png:
* platform/efl/fast/forms/minWidthPercent-expected.png:
* platform/efl/fast/forms/negativeLineHeight-expected.png:
* platform/efl/fast/forms/option-index-expected.png:
* platform/efl/fast/forms/option-script-expected.png:
* platform/efl/fast/forms/option-strip-whitespace-expected.png:
* platform/efl/fast/forms/option-text-clip-expected.png:
* platform/efl/fast/forms/search-display-none-cancel-button-expected.png:
* platform/efl/fast/forms/search-vertical-alignment-expected.png:
* platform/efl/fast/forms/searchfield-heights-expected.png:
* platform/efl/fast/forms/select-align-expected.png:
* platform/efl/fast/forms/select-block-background-expected.png:
* platform/efl/fast/forms/select-change-listbox-size-expected.png:
* platform/efl/fast/forms/select-change-listbox-to-popup-expected.png:
* platform/efl/fast/forms/select-change-popup-to-listbox-expected.png:
* platform/efl/fast/forms/select-dirty-parent-pref-widths-expected.png:
* platform/efl/fast/forms/select-display-none-style-resolve-expected.png:
* platform/efl/fast/forms/select-initial-position-expected.png:
* platform/efl/fast/forms/select-item-background-clip-expected.png:
* platform/efl/fast/forms/select-list-box-with-height-expected.png:
* platform/efl/fast/forms/select-size-expected.png:
* platform/efl/fast/forms/select-visual-hebrew-expected.png:
* platform/efl/fast/forms/select/optgroup-rendering-expected.png:
* platform/efl/fast/forms/tabbing-input-iframe-expected.png:
* platform/efl/fast/forms/targeted-frame-submission-expected.png:
* platform/efl/fast/forms/text-style-color-expected.png:
* platform/efl/fast/forms/textAreaLineHeight-expected.png:
* platform/efl/fast/forms/textarea-align-expected.png:
* platform/efl/fast/forms/textarea-width-expected.png:
* platform/efl/fast/forms/textfield-focus-ring-expected.png:
* platform/efl/fast/forms/textfield-outline-expected.png:
* platform/efl/fast/forms/visual-hebrew-text-field-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] V8ScriptInstance is much more complicated than necessary
abarth@webkit.org [Thu, 23 Aug 2012 19:16:46 +0000 (19:16 +0000)]
[V8] V8ScriptInstance is much more complicated than necessary
https://bugs.webkit.org/show_bug.cgi?id=94785

Reviewed by Kentaro Hara.

V8ScriptInstance just needs to be a one-line wrapper around OwnHandle.

* bindings/v8/OwnHandle.h:
(WebCore::OwnHandle::get):
* bindings/v8/ScriptInstance.cpp:
(WebCore::V8ScriptInstance::V8ScriptInstance):
(WebCore::V8ScriptInstance::~V8ScriptInstance):
(WebCore::V8ScriptInstance::instance):
* bindings/v8/ScriptInstance.h:
(WebCore::V8ScriptInstance::create):
(V8ScriptInstance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSerialization of JavaScript values does not appear to respect new HTML5 Structured...
commit-queue@webkit.org [Thu, 23 Aug 2012 19:08:54 +0000 (19:08 +0000)]
Serialization of JavaScript values does not appear to respect new HTML5 Structured Clone semantics
https://bugs.webkit.org/show_bug.cgi?id=65292

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-08-23
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Add function to construct a StringObject from a JSValue.
Similar functions already exist for NumberObject and
BooleanObject for example.

Export several symbols so address linking errors in
WebCore.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/BooleanObject.h:
(BooleanObject):
* runtime/NumberObject.h:
(NumberObject):
(JSC):
* runtime/StringObject.cpp:
(JSC::constructString):
(JSC):
* runtime/StringObject.h:
(JSC):

Source/WebCore:

JSC now correctly serialize Boolean, Number and String objects as per
the structured clone algorithm specification. This patch reduces the
delta with the V8 implementation of SerializedScriptValue.

No new tests, already tested by fast/dom/Window/window-postmessage-clone.html

* bindings/js/SerializedScriptValue.cpp:
(WebCore):
(WebCore::CloneSerializer::dumpStringObject):
(CloneSerializer):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::readTerminal):

LayoutTests:

Update expected results for fast/dom/Window/window-postmessage-clone.html
now that String, Boolean and Number object are correctly serialized with
JSC.

* fast/dom/Window/window-postmessage-clone-expected.txt:
* platform/gtk/fast/dom/Window/window-postmessage-clone-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocreate different WebKit::WebMediaPlayer based on URL
commit-queue@webkit.org [Thu, 23 Aug 2012 19:01:04 +0000 (19:01 +0000)]
create different WebKit::WebMediaPlayer based on URL
https://bugs.webkit.org/show_bug.cgi?id=91301

Patch by Wei Jia <wjia@chromium.org> on 2012-08-23
Reviewed by Adam Barth.

Source/WebKit/chromium:

Pass URL to WebFrameClient::createMediaPlayer(). This allows creation
of different WebMediaPlayer implementations based on the URL.

* public/WebFrameClient.h:
(WebKit::WebFrameClient::createMediaPlayer): add URL as additional argument.
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::createWebMediaPlayer): add URL as additional argument.
(WebKit::WebMediaPlayerClientImpl::loadInternal):

Tools:

Pass URL to createMediaPlayer. This corresponds to change in base
class WebKit::WebFrameClient.

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createMediaPlayer): add URL as additional argument.
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Move onSuccess(IDBDatabaseBackendInterface) to IDBOpenDBRequest
jsbell@chromium.org [Thu, 23 Aug 2012 18:56:28 +0000 (18:56 +0000)]
IndexedDB: Move onSuccess(IDBDatabaseBackendInterface) to IDBOpenDBRequest
https://bugs.webkit.org/show_bug.cgi?id=94757

Reviewed by Tony Chang.

Source/WebCore:

Move the implementation of IDBCallbacks::onSuccess(IDBDatabaseBackendInterface)
from IDBRequest to the new IDBOpenDBRequest, which is the only request type that
should be receiving that callback.

No new tests - no functional changes.

* Modules/indexeddb/IDBCallbacks.h:
(IDBCallbacks):
(WebCore::IDBCallbacks::onSuccess):
* Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::onUpgradeNeeded):
(WebCore::IDBOpenDBRequest::onSuccess):
(WebCore):
* Modules/indexeddb/IDBOpenDBRequest.h:
(IDBOpenDBRequest):
* Modules/indexeddb/IDBRequest.cpp:
* Modules/indexeddb/IDBRequest.h:

Source/WebKit/chromium:

Drop onSuccess(IDBDatabaseBackendImpl) overload from test, as it is no longer
implemented by IDBRequest.

* tests/IDBRequestTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: three layout tests crashing with assertion failure
kbr@google.com [Thu, 23 Aug 2012 18:47:15 +0000 (18:47 +0000)]
Web Inspector: three layout tests crashing with assertion failure
https://bugs.webkit.org/show_bug.cgi?id=94829

Unreviewed. Expanded suppressions.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSSRegions]Crash when moving anonymous block children inside a named flow
commit-queue@webkit.org [Thu, 23 Aug 2012 18:45:47 +0000 (18:45 +0000)]
[CSSRegions]Crash when moving anonymous block children inside a named flow
https://bugs.webkit.org/show_bug.cgi?id=90865

Patch by Andrei Onea <onea@adobe.com> on 2012-08-23
Reviewed by Abhishek Arya.

Source/WebCore:

When an anonymous block's children are detached in RenderBlock::collapseAnonymousBoxChild, the reference
to their enclosingRenderFlowThread is lost and causes a crash in RenderObject::willBeRemovedFromTree.
Because of this, we now maintain the enclosingRenderFlowThread during the whole lifetime of the
RenderBlock::collapseAnonymousBoxChild function, using a CurrentRenderFlowThreadMaintainer local.

Test: fast/regions/move-anonymous-block-inside-named-flow-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::collapseAnonymousBoxChild):
* rendering/RenderFlowThread.cpp:
(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
(WebCore):
(WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer):
Moved CurrentRenderFlowThreadMaintaner declaration from .cpp to .h, so that we can access it from
RenderBlock::collapseAnonymousBoxChild.
* rendering/RenderFlowThread.h:
(CurrentRenderFlowThreadMaintainer):
(WebCore):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeRemovedFromTree):

LayoutTests:

Added test for crash which happens when the children of an anonymous block
inside a flow thread are moved.

* fast/regions/move-anonymous-block-inside-named-flow-crash-expected.txt:
* fast/regions/move-anonymous-block-inside-named-flow-crash.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd test for decodeAudioData
commit-queue@webkit.org [Thu, 23 Aug 2012 18:43:55 +0000 (18:43 +0000)]
Add test for decodeAudioData
https://bugs.webkit.org/show_bug.cgi?id=92620

Patch by Li Yin <li.yin@intel.com> on 2012-08-23
Reviewed by Chris Rogers.

Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioContext-section
This test checks if successCallback or errorCallback can be invoked correctly when
there is a correct or error decoding.

* webaudio/decode-audio-data-basic-expected.txt: Added.
* webaudio/decode-audio-data-basic.html: Added.
* webaudio/resources/media/invalid-audio-file.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[wx] Unreviewed build fix. Disable compilation of WebDOM file for now,
kevino@webkit.org [Thu, 23 Aug 2012 18:41:33 +0000 (18:41 +0000)]
[wx] Unreviewed build fix. Disable compilation of WebDOM file for now,
add the opentype directory, and remove old ATSUI files no longer in the tree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[wx] Unreviewed build fix. Add wx to the list of platforms that use CoreText
kevino@webkit.org [Thu, 23 Aug 2012 18:37:59 +0000 (18:37 +0000)]
[wx] Unreviewed build fix. Add wx to the list of platforms that use CoreText
APIs on Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert ScrollableArea ASSERT_NOT_REACHED virtuals into pure virtuals
kbr@google.com [Thu, 23 Aug 2012 18:36:49 +0000 (18:36 +0000)]
Convert ScrollableArea ASSERT_NOT_REACHED virtuals into pure virtuals
https://bugs.webkit.org/show_bug.cgi?id=93306

Unreviewed build fix.

* src/ScrollbarGroup.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[wx] Unreviewed build fix. Don't rely on implicit casts, explicitly use the
kevino@webkit.org [Thu, 23 Aug 2012 18:35:10 +0000 (18:35 +0000)]
[wx] Unreviewed build fix. Don't rely on implicit casts, explicitly use the
Cursor constructor that takes a platform cursor for creating native cursors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Use WTF_USE_SOUP instead BUILDING_SOUP__
jesus@webkit.org [Thu, 23 Aug 2012 18:28:41 +0000 (18:28 +0000)]
[EFL] Use WTF_USE_SOUP instead BUILDING_SOUP__
https://bugs.webkit.org/show_bug.cgi?id=94744

Reviewed by Gustavo Noronha Silva.

.:

There is no need to define BUILDING_SOUP__ if only WTF_USE_SOUP
is used.

* GNUmakefile.am:
* Source/cmake/OptionsEfl.cmake:

Source/WebKit2:

Use #if defined(WTF_USE_SOUP) instead of #if defined(BUILDING_SOUP__)
since the former is used everywhere.

* Shared/API/c/WKBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove redundant check for negative values when using WebCore::Color::alpha()
commit-queue@webkit.org [Thu, 23 Aug 2012 18:28:23 +0000 (18:28 +0000)]
Remove redundant check for negative values when using WebCore::Color::alpha()
https://bugs.webkit.org/show_bug.cgi?id=94811

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-08-23
Reviewed by Eric Seidel.

Though alpha() returns a signed value (int), its value is stored on an unsigned
typedef (RGBA32) and is safeguarded by alphaChannel() that its value never goes
beyond 255, so no integer overflow, thus we can safely remove redundant check
for negative values while using it.

This change does not affect behavior, so no new tests needed.

* platform/graphics/Image.cpp:
(WebCore::Image::fillWithSolidColor):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::boxShadowShouldBeAppliedToBackground): Using hasAlpha() for readibility.
* rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations):
* rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: three layout tests crashing with assertion failure
kbr@google.com [Thu, 23 Aug 2012 18:20:52 +0000 (18:20 +0000)]
Web Inspector: three layout tests crashing with assertion failure
https://bugs.webkit.org/show_bug.cgi?id=94829

Unreviewed Chromium gardening. Suppressed failing tests.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] Move feature defines processing into a GNUmakefile that's simple to autogenerate
zandobersek@gmail.com [Thu, 23 Aug 2012 18:20:39 +0000 (18:20 +0000)]
[Gtk] Move feature defines processing into a GNUmakefile that's simple to autogenerate
https://bugs.webkit.org/show_bug.cgi?id=87127

Reviewed by Martin Robinson.

.:

Add 'feature_defines_defaults' and 'feature_defines_overrides' variables
and define them, along with 'feature_defines' (changed from the all-caps version),
before webcore_cppflags.

* GNUmakefile.am:

Source/WebCore:

List all the feature defines with their default value in
GNUmakefile.features.am and append them to the 'feature_defines_defaults'.
variable.

In GNUmakefile.am, include the GNUmakefile.features.am. When checking the
AM conditionals for feature-enabling, append the appropriate define to
'feature_defines_overrides'.

After all such overrides are performed, append the proper define (of which
value was possibly overridden) for each feature to the 'feature_defines'
variable. Finally, append all these defines to webcore_cppflags in the form
of macros for preprocessing.

No new tests - no new functionality.

* GNUmakefile.am:
* GNUmakefile.features.am: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Free ewk context data on program exit.
commit-queue@webkit.org [Thu, 23 Aug 2012 18:02:34 +0000 (18:02 +0000)]
[EFL][WK2] Free ewk context data on program exit.
https://bugs.webkit.org/show_bug.cgi?id=94808

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-08-23
Reviewed by Kenneth Rohde Christiansen.

Make sure the default Ewk_Context gets freed
on program exit.

The patch also fixes leaking of WKContextRef
inside Ewk_Context which should have been
adopted.

* UIProcess/API/efl/ewk_context.cpp:
(_Ewk_Context::_Ewk_Context):
(ewk_context_default_get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFixed a fastMallocForbid/Allow compile error for some compilers
ggaren@apple.com [Thu, 23 Aug 2012 17:55:05 +0000 (17:55 +0000)]
Fixed a fastMallocForbid/Allow compile error for some compilers
https://bugs.webkit.org/show_bug.cgi?id=94775

Reviewed by Gavin Barraclough.

* wtf/FastMalloc.h:
(WTF::fastMallocForbid()):
(WTF::fastMallocAllow()): Export, since these are called by JavaScriptCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] ScheduledAction is ugly and needs a cleanup
abarth@webkit.org [Thu, 23 Aug 2012 17:51:26 +0000 (17:51 +0000)]
[V8] ScheduledAction is ugly and needs a cleanup
https://bugs.webkit.org/show_bug.cgi?id=94784

Reviewed by Eric Seidel.

This patch updates ScheduledAction to use modern WebKit machinery, like
OwnHandle and Vector.

* bindings/v8/OwnHandle.h:
(OwnHandle):
* bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::ScheduledAction):
(WebCore::ScheduledAction::~ScheduledAction):
(WebCore::ScheduledAction::execute):
* bindings/v8/ScheduledAction.h:
(WebCore):
(ScheduledAction):
(WebCore::ScheduledAction::ScheduledAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: dblclick on Timeline overview no longer selects entire timeline range
caseq@chromium.org [Thu, 23 Aug 2012 17:45:59 +0000 (17:45 +0000)]
Web Inspector: dblclick on Timeline overview no longer selects entire timeline range
https://bugs.webkit.org/show_bug.cgi?id=94826

Reviewed by Vsevolod Vlasov.

Only install a glass pane for drag-n-drop upon first mouseout event -- otherwise, glass pane
will interfere with double clicks.

* inspector/front-end/UIUtils.js:
(WebInspector._elementDragStart.onMouseOut):
(WebInspector._elementDragStart):
(WebInspector._elementDragEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert ScrollableArea ASSERT_NOT_REACHED virtuals
enne@google.com [Thu, 23 Aug 2012 17:41:18 +0000 (17:41 +0000)]
Convert ScrollableArea ASSERT_NOT_REACHED virtuals
https://bugs.webkit.org/show_bug.cgi?id=93306

Reviewed by Darin Adler.

Source/WebCore:

ASSERT_NOT_REACHED is a bad way to make sure that a virtual function
gets an override, because it only fails at run-time in debug builds.

To fix this, convert the virtuals in ScrollableArea that have
ASSERT_NOT_REACHED to be either pure virtual or implemented directly
in ScrollableArea. Add implementations where necessary to make derived
classes concrete.

Additionally, consistently add OVERRIDE for virtual functions in
derived classes that override ScrollableArea methods.

* WebCore.exp.in:
* page/FrameView.h:
(FrameView):
* platform/ScrollView.h:
(ScrollView):
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::scrollPosition):
(WebCore):
(WebCore::ScrollableArea::minimumScrollPosition):
(WebCore::ScrollableArea::maximumScrollPosition):
(WebCore::ScrollableArea::visibleContentRect):
* platform/ScrollableArea.h:
(ScrollableArea):
(WebCore::ScrollableArea::overhangAmount):
* platform/chromium/FramelessScrollView.cpp:
(WebCore::FramelessScrollView::isOnActivePage):
(WebCore):
(WebCore::FramelessScrollView::scrollableAreaBoundingBox):
* platform/chromium/FramelessScrollView.h:
(FramelessScrollView):
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::visibleHeight):
(WebCore):
(WebCore::PopupMenuWin::visibleWidth):
(WebCore::PopupMenuWin::contentsSize):
(WebCore::PopupMenuWin::isOnActivePage):
(WebCore::PopupMenuWin::scrollableAreaBoundingBox):
* platform/win/PopupMenuWin.h:
(PopupMenuWin):
* rendering/RenderListBox.cpp:
* rendering/RenderListBox.h:
(RenderListBox):

Source/WebKit/chromium:

Add implementations where necessary to make derived classes concrete.
Add OVERRIDE for ScrollableArea functions.

* src/ScrollbarGroup.h:
(ScrollbarGroup):
(WebKit::ScrollbarGroup::scrollCornerRect):
* tests/ScrollAnimatorNoneTest.cpp:
(MockScrollableArea):

Source/WebKit/win:

Add implementations where necessary to make derived classes concrete.
Add OVERRIDE for ScrollableArea functions.

* WebScrollBar.cpp:
(WebScrollBar::visibleHeight):
(WebScrollBar::visibleWidth):
(WebScrollBar::contentsSize):
(WebScrollBar::isOnActivePage):
(WebScrollBar::scrollableAreaBoundingBox):
* WebScrollBar.h:
(WebScrollBar):

Source/WebKit2:

Add implementations where necessary to make derived classes concrete.
Add OVERRIDE for ScrollableArea functions.

* UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::visibleHeight):
(WebKit):
(WebKit::WebPopupMenuProxyWin::visibleWidth):
(WebKit::WebPopupMenuProxyWin::contentsSize):
(WebKit::WebPopupMenuProxyWin::scrollableAreaBoundingBox):
* UIProcess/win/WebPopupMenuProxyWin.h:
(WebPopupMenuProxyWin):
* WebProcess/Plugins/PDF/BuiltInPDFView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agogetComputedStyle returns wrong value for CSS3 2D transformations
commit-queue@webkit.org [Thu, 23 Aug 2012 17:23:20 +0000 (17:23 +0000)]
getComputedStyle returns wrong value for CSS3 2D transformations
https://bugs.webkit.org/show_bug.cgi?id=94211

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-08-23
Reviewed by Simon Fraser.

Source/WebCore:

When computed style is calculated for CSS3 2D transformation, content
box size is used. According to W3C specification, object's bounding
box should be used. This patch fixes transformation matrix calculation.

Layout tests getComputedStyle-transform.html and computed-style-origin.html
were modified to test changes.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::computedTransform):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::pixelSnappedSizingBox): Removed unused method

LayoutTests:

This change fixes getComputedStyle-transform.html test.
Before this change, the test doesn't do anything.
When new transformation value is set, it immediately read
back as an old value, thus computed style is equal to
an old style. Moreover, expected result is never checked.
Added new test case to computed-style-origin.html layout test.

* fast/css/getComputedStyle/getComputedStyle-transform-expected.txt:
* fast/css/getComputedStyle/getComputedStyle-transform.html:
* transforms/2d/computed-style-origin-expected.txt:
* transforms/2d/computed-style-origin.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDistributed nodes should not share styles.
commit-queue@webkit.org [Thu, 23 Aug 2012 17:08:21 +0000 (17:08 +0000)]
Distributed nodes should not share styles.
https://bugs.webkit.org/show_bug.cgi?id=90661

Patch by Takashi Sakamoto <tasak@google.com> on 2012-08-23
Reviewed by Hajime Morita.

Source/WebCore:

styleForElement tries to use previous sibling's style for distributed
nodes. However distributed nodes are children of a shadow host, but
the nodes are not siblings as the result of distribution.
The spec is:
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#shadow-dom-subtrees
So sharing previous sibling's style should be disabled for distrbuted
nodes.

Test: fast/dom/shadow/style-of-distributed-node.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
Initialized m_distributedToInsertionPoint. Its initial value is false.
(WebCore::StyleResolver::initForStyleResolve):
After invoking NodeRenderingContext, if the context returns any
insertion point, set m_distributedToInsertionPoint to be true.
Otherwise, false. The value is used in styleForElement.
(WebCore::StyleResolver::styleForElement):
If m_distributedToInsertionPoint is true, disable local sibling style
cache.
* css/StyleResolver.h:
(StyleResolver):
Added a new member variable, m_distributedToInsertionPoint.
The variable keeps whether the m_element is distributed to an
insertion point.

LayoutTests:

* fast/dom/shadow/style-of-distributed-node-expected.txt: Added.
* fast/dom/shadow/style-of-distributed-node.html: Added.
* fast/dom/shadow/user-modify-inheritance-expected.txt:
As this patch also change the user-modify-inheritance's test result,
updated the expected result.
* fast/dom/shadow/user-modify-inheritance.html:
Added FIXME comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago Replace access ot HTMLMediaElement from MediaPlayerPrivateBlackBerry with...
commit-queue@webkit.org [Thu, 23 Aug 2012 16:52:20 +0000 (16:52 +0000)]
    Replace access ot HTMLMediaElement from MediaPlayerPrivateBlackBerry with methods in MediaPlayerClient - updated with notes from initial reviews.  https://bugs.webkit.org/show_bug.cgi?id=84291

        Reviewed by Eric Carlson.

        Code standard compliance - no functional change, so no new tests required.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::mediaPlayerExitFullscreen):
        (WebCore):
        (WebCore::HTMLMediaElement::mediaPlayerIsVideo):
        (WebCore::HTMLMediaElement::mediaPlayerContentBoxRect):
        (WebCore::HTMLMediaElement::mediaPlayerSetSize):
        (WebCore::HTMLMediaElement::mediaPlayerPause):
        (WebCore::HTMLMediaElement::mediaPlayerPlay):
        (WebCore::HTMLMediaElement::mediaPlayerIsPaused):
        (WebCore::HTMLMediaElement::mediaPlayerHostWindow):
        (WebCore::HTMLMediaElement::mediaPlayerWindowClipRect):
        * html/HTMLMediaElement.h:
        (HTMLMediaElement):
        * platform/graphics/MediaPlayer.h:
        (WebCore):
        (WebCore::MediaPlayerClient::mediaPlayerExitFullscreen):
        (WebCore::MediaPlayerClient::mediaPlayerIsVideo):
        (WebCore::MediaPlayerClient::mediaPlayerContentBoxRect):
        (WebCore::MediaPlayerClient::mediaPlayerSetSize):
        (WebCore::MediaPlayerClient::mediaPlayerPause):
        (WebCore::MediaPlayerClient::mediaPlayerPlay):
        (WebCore::MediaPlayerClient::mediaPlayerIsPaused):
        (WebCore::MediaPlayerClient::mediaPlayerHostWindow):
        (WebCore::MediaPlayerClient::mediaPlayerWindowClipRect):
        * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
        (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::load):
        (WebCore::MediaPlayerPrivate::paint):
        (WebCore::MediaPlayerPrivate::resizeSourceDimensions):
        (WebCore::MediaPlayerPrivate::updateStates):
        (WebCore::MediaPlayerPrivate::onPauseStateChanged):
        (WebCore::MediaPlayerPrivate::onPlayNotified):
        (WebCore::MediaPlayerPrivate::onPauseNotified):
        (WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
        (WebCore::MediaPlayerPrivate::showErrorDialog):
        (WebCore::MediaPlayerPrivate::platformWindow):
        (WebCore::MediaPlayerPrivate::isElementPaused):
        (WebCore::MediaPlayerPrivate::isTabVisible):
        * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
        (MediaPlayerPrivate):

Patch by John Griggs <jgriggs@rim.com> on 2012-08-23

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] The tarball should be called webkitgtk-x.x.x.tar.xz
commit-queue@webkit.org [Thu, 23 Aug 2012 16:26:04 +0000 (16:26 +0000)]
[GTK] The tarball should be called webkitgtk-x.x.x.tar.xz
https://bugs.webkit.org/show_bug.cgi?id=94572

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-08-23
Reviewed by Carlos Garcia Campos.

Change the name of the tarball to match the name of the library
and to disambiguate it from other WebKit ports.

* configure.ac: Update the tarball name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoText Autosizing: Multiply large fonts less, as they are already more legible.
commit-queue@webkit.org [Thu, 23 Aug 2012 16:24:15 +0000 (16:24 +0000)]
Text Autosizing: Multiply large fonts less, as they are already more legible.
https://bugs.webkit.org/show_bug.cgi?id=94227

Patch by John Mellor <johnme@chromium.org> on 2012-08-23
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Rather than uniformly multiplying font sizes by the multiplier (derived
from the width of the block), we should multiply fonts that are already
large less, since they are already more legible hence there is less need
for them to grow.

However it is still important to maintain differentiation between text
that the author specified to be of different sizes.

This algorithm multiplies text by the multiplier up until a predefined
"pleasant" font size; beyond that the computedSize goes up with
specifiedSize but at a gradient of less than 1 in order to gradually
fade out the size increase; finally for very large specifiedSizes the
computedSize will be the same as the specifiedSize.

For further details, including a graph, please see the bug report.

Test: fast/text-autosizing/various-font-sizes.html

* rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::computeAutosizedFontSize):

    Implements the custom multiplication. See comment for details.

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::lineHeight):

    Use computeAutosizedFontSize instead of directly multiplying.

(WebCore::RenderStyle::setFontSize):

    Use computeAutosizedFontSize instead of directly multiplying.

LayoutTests:

Added test demonstrating how various font sizes are affected.

* fast/text-autosizing/various-font-sizes-expected.html: Added.
* fast/text-autosizing/various-font-sizes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove dependency on RenderStyle from FractionalLayoutBoxExtent and LayoutBox
eae@chromium.org [Thu, 23 Aug 2012 16:21:57 +0000 (16:21 +0000)]
Remove dependency on RenderStyle from FractionalLayoutBoxExtent and LayoutBox
https://bugs.webkit.org/show_bug.cgi?id=94146

Reviewed by Eric Seidel.

FractionalLayoutBoxExtent and LayoutBox currently have a dependency on
RenderStyle to resolve writing mode and text direction.
This is undesirable and breaks encapsulation.

Change FractionalLayoutBoxExtent and LengthBox to take a writing mode
parameter, and text direction as needed, instead of a pointer to a
RenderStyle object.

No new tests, no change in functionality.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Add new WritingMode.h file.

* css/CSSPrimitiveValueMappings.h:
* css/CSSProperty.h:
* css/CSSToStyleMap.h:
Change includes as needed.

* platform/LengthBox.h:
* platform/LengthBox.cpp:
(WebCore::LengthBox::logicalLeft):
(WebCore::LengthBox::logicalRight):
(WebCore::LengthBox::before):
(WebCore::LengthBox::after):
Change methods to take a WirtingMode parameter instead of a RenderStyle pointer.

(WebCore::LengthBox::start):
(WebCore::LengthBox::end):
Change methods to take WritingMode and TextDirection parameters instead of a RenderStyle pointer.

* platform/graphics/FractionalLayoutBoxExtent.h:
* platform/graphics/FractionalLayoutBoxExtent.cpp:
(WebCore::FractionalLayoutBoxExtent::logicalTop):
(WebCore::FractionalLayoutBoxExtent::logicalBottom):
(WebCore::FractionalLayoutBoxExtent::logicalLeft):
(WebCore::FractionalLayoutBoxExtent::logicalRight):
(WebCore::FractionalLayoutBoxExtent::before):
(WebCore::FractionalLayoutBoxExtent::after):
(WebCore::FractionalLayoutBoxExtent::setBefore):
(WebCore::FractionalLayoutBoxExtent::setAfter):
(WebCore::FractionalLayoutBoxExtent::mutableLogicalLeft):
(WebCore::FractionalLayoutBoxExtent::mutableLogicalRight):
(WebCore::FractionalLayoutBoxExtent::mutableBefore):
(WebCore::FractionalLayoutBoxExtent::mutableAfter):
Change methods to take a WritingMode parameter instead of a RenderStyle pointer.

(WebCore::FractionalLayoutBoxExtent::start):
(WebCore::FractionalLayoutBoxExtent::end):
(WebCore::FractionalLayoutBoxExtent::setStart):
(WebCore::FractionalLayoutBoxExtent::setEnd):
Change methods to take WritingMode and TextDirection parameters instead of a RenderStyle pointer.

* platform/text/TextDirection.h:
(WebCore::isLeftToRightDirection):
Add convenience method.

* platform/text/WritingMode.h: Added.
Move WritingMode enum from RenderStyleConstants to new file.

(WebCore::isHorizontalWritingMode):
(WebCore::isFlippedLinesWritingMode):
(WebCore::isFlippedBlocksWritingMode):
Add convenience methods for working with writing modes.

* rendering/InlineFlowBox.cpp:
* rendering/RenderBox.cpp:
* rendering/RenderBox.h:
* rendering/style/RenderStyle.h:
Update calls to FractionalLayoutBoxExtent/LengthBox to pass WritingMode/
TextDirection as needed.

* rendering/style/RenderStyleConstants.h:
Remove WritingMode enum as it is now in a dedicated file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, upgrade gyuyoung to reviewer.
gyuyoung.kim@samsung.com [Thu, 23 Aug 2012 16:01:57 +0000 (16:01 +0000)]
Unreviewed, upgrade gyuyoung to reviewer.
http://lists.webkit.org/pipermail/webkit-dev/2012-August/022004.html

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: introduce canFilter on panel (otherwise we check for function existence).
pfeldman@chromium.org [Thu, 23 Aug 2012 15:59:52 +0000 (15:59 +0000)]
Web Inspector: introduce canFilter on panel (otherwise we check for function existence).
https://bugs.webkit.org/show_bug.cgi?id=94820

Reviewed by Alexander Pavlov.

Drive-by: fix for network panel sorting null pointer access.
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype.performSearch):
(WebInspector.NetworkPanel.prototype.canFilter):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.replaceAllWith):
(WebInspector.Panel.prototype.canFilter):
(WebInspector.Panel.prototype.performFilter):
* inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype._updateFilterVisibility):
(WebInspector.SearchController.prototype._performFilter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] ewk_intent_request API test does not free Eina_List
commit-queue@webkit.org [Thu, 23 Aug 2012 15:58:58 +0000 (15:58 +0000)]
[EFL][WK2] ewk_intent_request API test does not free Eina_List
https://bugs.webkit.org/show_bug.cgi?id=94809

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-23
Reviewed by Kenneth Rohde Christiansen.

The used Eina_List should be freed due to ewk_intent_suggestions_get() documentation.

* UIProcess/API/efl/tests/test_ewk2_intents.cpp:
(onIntentReceived):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Bump WebKitGTK+ version number.
carlosgc@webkit.org [Thu, 23 Aug 2012 15:48:18 +0000 (15:48 +0000)]
Unreviewed. Bump WebKitGTK+ version number.

* configure.ac: Bump version number to 1.11.0 now that we branched
for 1.10.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: introduce TimelineGrid.Calculator interface.
pfeldman@chromium.org [Thu, 23 Aug 2012 15:46:13 +0000 (15:46 +0000)]
Web Inspector: introduce TimelineGrid.Calculator interface.
https://bugs.webkit.org/show_bug.cgi?id=94819

Reviewed by Alexander Pavlov.

This way we can compile TimelineGrid properly.

* inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.prototype._calculateVisibleIndexes):
* inspector/front-end/TimelineGrid.js:
(WebInspector.TimelineGrid.prototype.updateDividers):
(WebInspector.TimelineGrid.Calculator):
(WebInspector.TimelineGrid.Calculator.prototype.computePosition):
(WebInspector.TimelineGrid.Calculator.prototype.formatTime):
(WebInspector.TimelineGrid.Calculator.prototype.minimumBoundary):
(WebInspector.TimelineGrid.Calculator.prototype.maximumBoundary):
(WebInspector.TimelineGrid.Calculator.prototype.boundarySpan):
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewCalculator.prototype.computePosition):
(WebInspector.TimelineOverviewCalculator.prototype.computeBarGraphPercentages):
(WebInspector.TimelineOverviewCalculator.prototype.setWindow):
(WebInspector.TimelineOverviewCalculator.prototype.formatTime):
(WebInspector.TimelineOverviewCalculator.prototype.maximumBoundary):
(WebInspector.TimelineOverviewCalculator.prototype.minimumBoundary):
(WebInspector.TimelineOverviewCalculator.prototype.boundarySpan):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._shouldShowFrames):
(WebInspector.TimelineCalculator.prototype.computePosition):
(WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):
(WebInspector.TimelineCalculator.prototype.setWindow):
(WebInspector.TimelineCalculator.prototype.formatTime):
(WebInspector.TimelineCalculator.prototype.maximumBoundary):
(WebInspector.TimelineCalculator.prototype.minimumBoundary):
(WebInspector.TimelineCalculator.prototype.boundarySpan):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unnecessary delay when starting to update resources with an inactive vsync...
commit-queue@webkit.org [Thu, 23 Aug 2012 15:42:33 +0000 (15:42 +0000)]
[Chromium] Unnecessary delay when starting to update resources with an inactive vsync timer.
https://bugs.webkit.org/show_bug.cgi?id=94719

Patch by David Reveman <reveman@chromium.org> on 2012-08-23
Reviewed by James Robinson.

Source/WebCore:

Replace nextTickTime() with nextTickTimeIfActivated() and return
appropriate value when timer is inactive.

No new tests.

* platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
(WebCore::CCDelayBasedTimeSource::nextTickTimeIfActivated):
(WebCore::CCDelayBasedTimeSource::nextTickTarget):
(WebCore):
(WebCore::CCDelayBasedTimeSource::postNextTickTask):
* platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:
* platform/graphics/chromium/cc/CCFrameRateController.cpp:
(WebCore::CCFrameRateController::nextTickTimeIfActivated):
* platform/graphics/chromium/cc/CCFrameRateController.h:
(CCFrameRateController):
* platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCScheduler::processScheduledActions):
* platform/graphics/chromium/cc/CCTimeSource.h:
(CCTimeSource):

Source/WebKit/chromium:

* tests/CCSchedulerTestCommon.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: make treeoutline.js compiler-friendly
pfeldman@chromium.org [Thu, 23 Aug 2012 15:36:45 +0000 (15:36 +0000)]
Web Inspector: make treeoutline.js compiler-friendly
https://bugs.webkit.org/show_bug.cgi?id=94818

Reviewed by Alexander Pavlov.

This change declares base methods on TreeElement so that we did not need to check for their existence.

* inspector/front-end/AdvancedSearchController.js:
(WebInspector.FileBasedSearchResultsPane.prototype._appendShowMoreMatchesElement):
(WebInspector.FileBasedSearchResultsPane.prototype._addFileTreeElement):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype.onselect):
* inspector/front-end/SidebarPane.js:
(WebInspector.SidebarPane.prototype.expand):
(WebInspector.SidebarPane.prototype.onexpand):
(WebInspector.SidebarPane.prototype.collapse):
* inspector/front-end/treeoutline.js:
(TreeOutline.prototype._treeKeyDown):
(TreeOutline.prototype._searchInputKeyDown):
(TreeElement.prototype._fireDidChange):
(TreeElement.prototype._attach):
(TreeElement.treeElementDoubleClicked):
(TreeElement.prototype.collapse):
(TreeElement.prototype.expand):
(TreeElement.prototype.reveal):
(TreeElement.prototype.select):
(TreeElement.prototype.deselect):
(TreeElement.prototype.onpopulate):
(TreeElement.prototype.onenter):
(TreeElement.prototype.ondelete):
(TreeElement.prototype.onspace):
(TreeElement.prototype.onattach):
(TreeElement.prototype.onexpand):
(TreeElement.prototype.oncollapse):
(TreeElement.prototype.ondblclick):
(TreeElement.prototype.onreveal):
(TreeElement.prototype.onselect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: use temporary directory for modules generated by compile-front-end.py
yurys@chromium.org [Thu, 23 Aug 2012 15:34:14 +0000 (15:34 +0000)]
Web Inspector: use temporary directory for modules generated by compile-front-end.py
https://bugs.webkit.org/show_bug.cgi?id=94804

Reviewed by Pavel Feldman.

Create temporary directory for generated js modules and remove the directory
after the compilation.

* inspector/compile-front-end.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Helper functions used by the raw webview tests should not be guarded by...
abecsi@webkit.org [Thu, 23 Aug 2012 15:11:47 +0000 (15:11 +0000)]
[Qt][WK2] Helper functions used by the raw webview tests should not be guarded by HAVE_QTQUICK

Reviewed by Simon Hausmann.

This fixes the build if the QtQuick module is not present.

* UIProcess/API/qt/tests/util.cpp:
(messageHandler):
(suppressDebugOutput):
* UIProcess/API/qt/tests/util.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix make install on Windows
hausmann@webkit.org [Thu, 23 Aug 2012 15:09:34 +0000 (15:09 +0000)]
[Qt] Fix make install on Windows
https://bugs.webkit.org/show_bug.cgi?id=94816

Reviewed by Laszlo Gombos.

This old left-over rule for Windows to add dlltarget to INSTALLS caused
various bugs: WebCore's Makefile had an actual install target that
tried to install the WebCore static library and it also screwed up
api.pri's install rule by overriding what is usually set up for qt
modules, i.e. the install path was missing INSTALL_ROOT. We don't need
these rules at all, the default qmake features take care of setting up
target install rules accordingly.

* WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: extract ParsedURL into a separate file.
pfeldman@chromium.org [Thu, 23 Aug 2012 15:08:29 +0000 (15:08 +0000)]
Web Inspector: extract ParsedURL into a separate file.
https://bugs.webkit.org/show_bug.cgi?id=94817

Reviewed by Alexander Pavlov.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._rewriteHref):
* inspector/front-end/ParsedURL.js: Added.
(WebInspector.ParsedURL):
(WebInspector.ParsedURL.completeURL):
(WebInspector.ParsedURL.prototype.get displayName):
(String.prototype.asParsedURL):
* inspector/front-end/ResourceUtils.js:
(WebInspector.resourceURLForRelatedNode):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: register context menu providers for lazily loaded panels.
pfeldman@chromium.org [Thu, 23 Aug 2012 14:59:13 +0000 (14:59 +0000)]
Web Inspector: register context menu providers for lazily loaded panels.
https://bugs.webkit.org/show_bug.cgi?id=94812

Reviewed by Alexander Pavlov.

- Panel descriptors now register providers that lazily load panels on demand.
- Removed custom profiles context provider infrastructure in favor of generic one.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel):
* inspector/front-end/NetworkPanelDescriptor.js: Added.
(WebInspector.NetworkPanelDescriptor):
(WebInspector.NetworkPanelDescriptor.prototype.appendApplicableItems):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertiesSection.prototype._contextMenuEventFired):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
(WebInspector.ProfilesPanel.prototype.appendApplicableItems.didReceiveHeapObjectId):
(WebInspector.ProfilesPanel.prototype.appendApplicableItems):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
* inspector/front-end/ScriptsPanelDescriptor.js: Added.
(WebInspector.ScriptsPanelDescriptor):
(WebInspector.ScriptsPanelDescriptor.prototype.appendApplicableItems):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector._panelDescriptors):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
peter@chromium.org [Thu, 23 Aug 2012 14:55:28 +0000 (14:55 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix make distcheck.
carlosgc@webkit.org [Thu, 23 Aug 2012 13:24:53 +0000 (13:24 +0000)]
Unreviewed. Fix make distcheck.

* GNUmakefile.am: Add idl files in Modules/quota to EXTRA_DIST.
* GNUmakefile.list.am: Add missing files to compilation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r126306): it broke the plugin process
commit-queue@webkit.org [Thu, 23 Aug 2012 13:21:39 +0000 (13:21 +0000)]
REGRESSION(r126306): it broke the plugin process
https://bugs.webkit.org/show_bug.cgi?id=94797

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2012-08-23
Reviewed by Xan Lopez.

.:

* GNUmakefile.am:

Source/WebCore:

* GNUmakefile.am:
* GNUmakefile.list.am:

Source/WebKit/gtk:

* GNUmakefile.am:

Source/WebKit2:

* GNUmakefile.am:

Tools:

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed trivial build fix for Qt/Mac on OS X 10.6: Avoid using an
hausmann@webkit.org [Thu, 23 Aug 2012 13:11:33 +0000 (13:11 +0000)]
Unreviewed trivial build fix for Qt/Mac on OS X 10.6: Avoid using an
enum value that clashes with an existing class name that's used in the
same file.

* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::valueRealType):
(JSC::Bindings::convertValueToQVariant):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Add url bar to EWebLauncher and MiniBrowser/Efl.
ryuan.choi@samsung.com [Thu, 23 Aug 2012 13:04:48 +0000 (13:04 +0000)]
[EFL] Add url bar to EWebLauncher and MiniBrowser/Efl.
https://bugs.webkit.org/show_bug.cgi?id=63966

Reviewed by Kenneth Rohde Christiansen.

EWebLauncher and MiniBrowser/Efl did not have functionality that users
navigates the site which they want.
This patch adds the urlbar and functionality to load url which users want.

* CMakeLists.txt:
Added to share urlbar theme for both EWebLauncher and MiniBrowser/Efl.
* EWebLauncher/CMakeLists.txt:
Added urlbar.c and dependency of urlbar theme.
In addition, changed macro name to THEME_DIR to share the code easily.
* EWebLauncher/ControlTheme/CMakeLists.txt: Added for urlbar theme.
* EWebLauncher/ControlTheme/entry.edc: Implemented urlbar theme.
* EWebLauncher/main.c:
Implemented to use the urlbar.
In addition, remove unnecessary border of webview to control webview and urlbar easily.
(_ELauncher):
(on_url_changed):
(browserCreate):
(closeWindow):
(findThemePath):
* EWebLauncher/url_bar.c: Implemented functionality of the urlbar.
(_url_bar_url_get_with_protocol):
(on_urlbar_key_down):
(on_urlbar_mouse_down):
(on_urlbar_focus_out):
(url_bar_add):
(url_bar_del):
(url_bar_url_set):
* EWebLauncher/url_bar.h: Added.
* MiniBrowser/efl/CMakeLists.txt:
* MiniBrowser/efl/main.c: Implemented to use the urlbar.
(_MiniBrowser):
(on_url_changed):
(browserCreate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[nrwt, WTR] Remove workaround for timeout handing from r126062
kbalazs@webkit.org [Thu, 23 Aug 2012 11:50:24 +0000 (11:50 +0000)]
[nrwt, WTR] Remove workaround for timeout handing from r126062
https://bugs.webkit.org/show_bug.cgi?id=94609

Reviewed by Dirk Pranke.

Don't try to reset state if a timeout occured but inform
the harness that the web process is no longer reliable.

* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.run_test): Remove the workaround. Furthermore, handle the case when
the pid is unknown.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::run):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::dumpWebProcessUnresponsiveness):
* WebKitTestRunner/TestInvocation.h:
(TestInvocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Thu, 23 Aug 2012 11:34:42 +0000 (11:34 +0000)]
Unreviewed GTK gardening.

Adding platform-specific baselines required after r126343 and r126372.

* platform/gtk/fast/overflow/paged-x-div-expected.png: Added.
* platform/gtk/fast/overflow/paged-x-div-expected.txt: Added.
* platform/gtk/fast/overflow/paged-x-on-root-expected.png: Added.
* platform/gtk/fast/overflow/paged-x-on-root-expected.txt: Added.
* platform/gtk/fast/overflow/paged-y-div-expected.png: Added.
* platform/gtk/fast/overflow/paged-y-div-expected.txt: Added.
* platform/gtk/fast/overflow/paged-y-on-root-expected.png: Added.
* platform/gtk/fast/overflow/paged-y-on-root-expected.txt: Added.
* platform/gtk/media/track: Added.
* platform/gtk/media/track/track-cue-rendering-horizontal-expected.png: Added.
* platform/gtk/media/track/track-cue-rendering-horizontal-expected.txt: Added.
* platform/gtk/media/track/track-cue-rendering-vertical-expected.png: Added.
* platform/gtk/media/track/track-cue-rendering-vertical-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for WinCE after r126359.
paroga@webkit.org [Thu, 23 Aug 2012 11:30:53 +0000 (11:30 +0000)]
Build fix for WinCE after r126359.

* rendering/RenderThemeWinCE.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebInspector: unreviewed single line test fix.
loislo@chromium.org [Thu, 23 Aug 2012 10:46:56 +0000 (10:46 +0000)]
WebInspector: unreviewed single line test fix.

The test has to open profiles panel explicitly because it is creating lazily.

* inspector/heap-snapshot-performance-test.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r126391.
dominicc@chromium.org [Thu, 23 Aug 2012 10:31:03 +0000 (10:31 +0000)]
Unreviewed, rolling out r126391.
http://trac.webkit.org/changeset/126391
https://bugs.webkit.org/show_bug.cgi?id=94302

Breaks Chromium browser_tests AccessibilityFooter,
AccessibilityListMarkers, AccessibilityUI

Source/WebCore:

* accessibility/AccessibilityNodeObject.cpp:
* accessibility/AccessibilityNodeObject.h:
(AccessibilityNodeObject):
* accessibility/AccessibilityObject.cpp:
* accessibility/AccessibilityObject.h:
(AccessibilityObject):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::isDescendantOfElementType):
* accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):

LayoutTests:

* accessibility/editable-webarea-context-menu-point.html:
* accessibility/focusable-div-expected.txt: Removed.
* accessibility/focusable-div.html: Removed.
* accessibility/table-detection.html:
* platform/mac/accessibility/listbox-hit-test.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [WebGL] Allow collecting calls for Resource objects affecting their...
commit-queue@webkit.org [Thu, 23 Aug 2012 10:08:21 +0000 (10:08 +0000)]
Web Inspector: [WebGL] Allow collecting calls for Resource objects affecting their states
https://bugs.webkit.org/show_bug.cgi?id=94686

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-08-23
Reviewed by Pavel Feldman.

Allow collecting calls for WebGL Resource objects affecting their states.
Clone Call's mutable arguments before pushing it to the log.

* inspector/InjectedScriptWebGLModuleSource.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] draw <video> on <canvas> does not work
commit-queue@webkit.org [Thu, 23 Aug 2012 09:52:25 +0000 (09:52 +0000)]
[BlackBerry] draw <video> on <canvas> does not work
https://bugs.webkit.org/show_bug.cgi?id=94791
PR #195866

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-08-23
Reviewed by George Staikos.

Re-implement MediaPlayerPrivate::paintCurrentFrameInContext() in the
blackberry port. This method is mainly called from <canvas>, and it
is supposed to paint video frames using software rendering path.

On the other hand, MediaPlayerPrivate::paint() will choose accelerated
rendering if possible.

media/video-canvas-alpha.html covers this.

* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::paint):
(WebCore):
(WebCore::MediaPlayerPrivate::paintCurrentFrameInContext):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium gardeing.
morrita@google.com [Thu, 23 Aug 2012 09:42:53 +0000 (09:42 +0000)]
Unreviewed Chromium gardeing.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-08-23 Dominic Cooney <dominicc@chromium.org>
dominicc@chromium.org [Thu, 23 Aug 2012 09:24:10 +0000 (09:24 +0000)]
2012-08-23  Dominic Cooney  <dominicc@chromium.org>

        [Chromium] Unreviewed gardening.

        notifications-event-listener-crash.html test has non-deterministic
        output on Chromium XP debug.

        * platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening after r126350
commit-queue@webkit.org [Thu, 23 Aug 2012 09:04:54 +0000 (09:04 +0000)]
[EFL] Gardening after r126350
https://bugs.webkit.org/show_bug.cgi?id=94787

Unreviewed gardening.

Gardening of media/track/track-cue-rendering-snap-to-lines-not-set.html.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-23

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium gardeing.
morrita@google.com [Thu, 23 Aug 2012 09:02:20 +0000 (09:02 +0000)]
Unreviewed Chromium gardeing.

* platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.txt: Added.
* platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Build fix for r126399.
haraken@chromium.org [Thu, 23 Aug 2012 08:50:04 +0000 (08:50 +0000)]
Unreviewed. Build fix for r126399.

* bindings/v8/ScriptInstance.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Refactoring: WebBackForwardList getters should be const
commit-queue@webkit.org [Thu, 23 Aug 2012 08:47:11 +0000 (08:47 +0000)]
[WK2] Refactoring: WebBackForwardList getters should be const
https://bugs.webkit.org/show_bug.cgi?id=94711

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-23
Reviewed by Kenneth Rohde Christiansen.

Before the change were not consistent with each other
(WebBackForwardList::entries() was const but WebBackForwardList::currentIndex() was not).
Besides having not const getters is not a good practice in C++. (Please read
Scott Meyers. Effective C++ (3rd edition). ISBN: 0-321-33487-6.
Item 3: 'Use const whenever possible').

* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::backListCount):
(WebKit::WebBackForwardList::forwardListCount):
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
* UIProcess/WebBackForwardList.h:
(WebKit::WebBackForwardList::currentIndex):
(WebBackForwardList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: treat 0 cookies as "no cookies" and render it accordingly in the UI
pfeldman@chromium.org [Thu, 23 Aug 2012 08:32:23 +0000 (08:32 +0000)]
Web Inspector: treat 0 cookies as "no cookies" and render it accordingly in the UI
https://bugs.webkit.org/show_bug.cgi?id=94732

Reviewed by Yury Semikhatsky.

* inspector/front-end/RequestCookiesView.js:
(WebInspector.RequestCookiesView.prototype.get _gotCookies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
zandobersek@gmail.com [Thu, 23 Aug 2012 08:26:51 +0000 (08:26 +0000)]
Unreviewed gardening.

A follow-up to r126400, updating various baselines for fast/js/constructor-length.html
so they are correct.

* platform/gtk/fast/js/constructor-length-expected.txt:
* platform/mac/fast/js/constructor-length-expected.txt:
* platform/qt/fast/js/constructor-length-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Added missing SKIP keyword to platform/efl/TestExpectations
commit-queue@webkit.org [Thu, 23 Aug 2012 08:10:46 +0000 (08:10 +0000)]
[EFL] Added missing SKIP keyword to platform/efl/TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=94781

Unreviewed. Some layout tests which are expected missing should not make
expected result files during layout test.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-23

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Adding myself to committers list.
kadam@inf.u-szeged.hu [Thu, 23 Aug 2012 08:08:55 +0000 (08:08 +0000)]
Unreviewed. Adding myself to committers list.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Use vertical slider theme when the slider is vertical
commit-queue@webkit.org [Thu, 23 Aug 2012 07:54:41 +0000 (07:54 +0000)]
[EFL] Use vertical slider theme when the slider is vertical
https://bugs.webkit.org/show_bug.cgi?id=93838

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-23
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Applied vertical slider theme to the vertical sliders. The height
of the vertical slider is wrong when it's applied horizontal
slider theme.

And do not resize slider when its size is not specified. It's natural
to use the default value of renderer.

No new tests. It's covered by existing range and datalist tests.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::adjustSliderTrackStyle):

LayoutTests:

Updated expected result because theme of the slider is changed.

The size of the renderSlider is changed to 129x12 from 129x11
because it has the slider thumb 12x12 and it is not resized when
the size is not specified.

* platform/efl/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
* platform/efl/fast/forms/box-shadow-override-expected.png:
* platform/efl/fast/forms/box-shadow-override-expected.txt:
* platform/efl/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Added.
* platform/efl/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Added.
* platform/efl/fast/forms/input-appearance-height-expected.png:
* platform/efl/fast/forms/input-appearance-height-expected.txt:
* platform/efl/fast/forms/range/input-appearance-range-expected.png:
* platform/efl/fast/forms/range/input-appearance-range-expected.txt:
* platform/efl/fast/forms/range/slider-padding-expected.png:
* platform/efl/fast/forms/range/slider-padding-expected.txt:
* platform/efl/fast/forms/range/slider-thumb-shared-style-expected.png:
* platform/efl/fast/forms/range/slider-thumb-shared-style-expected.txt:
* platform/efl/fast/repaint/slider-thumb-drag-release-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
zandobersek@gmail.com [Thu, 23 Aug 2012 07:37:50 +0000 (07:37 +0000)]
Unreviewed gardening.

After the TextTrackCue constructor was updated in r126350 the
expected constructor length is 3. Updating fast/js/constructor-length.html
to reflect that.

* fast/js/constructor-length.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Remove almost all #include "V8Proxy.h"
haraken@chromium.org [Thu, 23 Aug 2012 07:35:47 +0000 (07:35 +0000)]
[V8] Remove almost all #include "V8Proxy.h"
https://bugs.webkit.org/show_bug.cgi?id=94777

Reviewed by Adam Barth.

No tests. No change in behavior.

* bindings/v8/NPV8Object.cpp:
* bindings/v8/PageScriptDebugServer.cpp:
* bindings/v8/ScheduledAction.cpp:
* bindings/v8/ScriptController.cpp:
* bindings/v8/ScriptInstance.cpp:
* bindings/v8/ScriptObject.cpp:
* bindings/v8/ScriptRunner.cpp:
* bindings/v8/SerializedScriptValue.cpp:
* bindings/v8/V8AbstractEventListener.cpp:
* bindings/v8/V8Binding.h:
(WebCore):
* bindings/v8/V8BindingMacros.h:
(WebCore):
* bindings/v8/V8Collection.h:
* bindings/v8/V8DOMWindowShell.cpp:
* bindings/v8/V8DOMWrapper.cpp:
* bindings/v8/V8EventListener.cpp:
* bindings/v8/V8GCController.cpp:
* bindings/v8/V8LazyEventListener.cpp:
* bindings/v8/V8NPObject.cpp:
* bindings/v8/V8NPUtils.cpp:
* bindings/v8/V8Proxy.h:
(WebCore):
* bindings/v8/V8Utilities.cpp:
* bindings/v8/WorkerContextExecutionProxy.cpp:
* bindings/v8/WorkerScriptController.cpp:
* bindings/v8/custom/V8ArrayBufferCustom.cpp:
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
* bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:
* bindings/v8/custom/V8AudioContextCustom.cpp:
* bindings/v8/custom/V8BlobCustom.cpp:
* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
* bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
* bindings/v8/custom/V8ClipboardCustom.cpp:
* bindings/v8/custom/V8ConsoleCustom.cpp:
* bindings/v8/custom/V8CoordinatesCustom.cpp:
* bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
* bindings/v8/custom/V8DOMFormDataCustom.cpp:
* bindings/v8/custom/V8DataViewCustom.cpp:
* bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
* bindings/v8/custom/V8DeviceMotionEventCustom.cpp:
* bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:
* bindings/v8/custom/V8DocumentCustom.cpp:
* bindings/v8/custom/V8DocumentLocationCustom.cpp:
* bindings/v8/custom/V8EntryCustom.cpp:
* bindings/v8/custom/V8EntrySyncCustom.cpp:
* bindings/v8/custom/V8EventCustom.cpp:
* bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
* bindings/v8/custom/V8HTMLFormElementCustom.cpp:
* bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
* bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
* bindings/v8/custom/V8HTMLInputElementCustom.cpp:
* bindings/v8/custom/V8HTMLLinkElementCustom.cpp:
* bindings/v8/custom/V8HTMLMediaElementCustom.cpp:
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
* bindings/v8/custom/V8HTMLOutputElementCustom.cpp:
* bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
* bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
* bindings/v8/custom/V8HistoryCustom.cpp:
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
* bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
* bindings/v8/custom/V8IntentConstructor.cpp:
* bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:
* bindings/v8/custom/V8LocationCustom.cpp:
* bindings/v8/custom/V8MessageChannelConstructor.cpp:
* bindings/v8/custom/V8MessageEventCustom.cpp:
* bindings/v8/custom/V8MessagePortCustom.cpp:
* bindings/v8/custom/V8MutationCallbackCustom.cpp:
* bindings/v8/custom/V8MutationObserverCustom.cpp:
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
* bindings/v8/custom/V8NodeCustom.cpp:
* bindings/v8/custom/V8NodeListCustom.cpp:
* bindings/v8/custom/V8NotificationCenterCustom.cpp:
* bindings/v8/custom/V8NotificationCustom.cpp:
* bindings/v8/custom/V8PopStateEventCustom.cpp:
* bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
* bindings/v8/custom/V8SQLTransactionCustom.cpp:
* bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
* bindings/v8/custom/V8SVGDocumentCustom.cpp:
* bindings/v8/custom/V8ScriptProfileCustom.cpp:
* bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:
* bindings/v8/custom/V8StorageCustom.cpp:
* bindings/v8/custom/V8StyleSheetListCustom.cpp:
* bindings/v8/custom/V8TrackEventCustom.cpp:
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
* bindings/v8/custom/V8WebKitAnimationCustom.cpp:
* bindings/v8/custom/V8WebKitPointConstructor.cpp:
* bindings/v8/custom/V8WebSocketCustom.cpp:
* bindings/v8/custom/V8WorkerContextCustom.cpp:
* bindings/v8/custom/V8WorkerCustom.cpp:
* bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
* bindings/v8/custom/V8XSLTProcessorCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium gardeing.
morrita@google.com [Thu, 23 Aug 2012 07:34:30 +0000 (07:34 +0000)]
Unreviewed Chromium gardeing.

* platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt: Removed.
* platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.txt: Removed.
* platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.txt: Removed.
* platform/chromium-win-xp/media/track/track-cue-rendering-horizontal-expected.png: Removed.
* platform/chromium-win-xp/media/track/track-cue-rendering-horizontal-expected.txt: Removed.
* platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r126348.
haraken@chromium.org [Thu, 23 Aug 2012 06:54:26 +0000 (06:54 +0000)]
Unreviewed, rolling out r126348.
http://trac.webkit.org/changeset/126348
https://bugs.webkit.org/show_bug.cgi?id=94588

We should use v8::String::NewSymbol() for symbols. See
https://bugs.webkit.org/show_bug.cgi?id=94574#c10 for more
details

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateNamedConstructorCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::ConfigureV8Float64ArrayTemplate):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::ConfigureV8TestEventTargetTemplate):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::ConfigureV8TestInterfaceTemplate):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextProperties):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetter):
* bindings/v8/V8Binding.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] media/video-duration-known-after-eos.html and media/media-element-play-after...
philn@webkit.org [Thu, 23 Aug 2012 06:29:36 +0000 (06:29 +0000)]
[GTK] media/video-duration-known-after-eos.html and media/media-element-play-after-eos.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=83790

Reviewed by Eric Seidel.

Refactor the tests to wait the loadedmetadata event before
starting playback and attempting any access to the duration
attribute. This is an attempt to eliminate flakyness of the tests.

* media/media-element-play-after-eos-expected.txt:
* media/media-element-play-after-eos.html:
* media/video-duration-known-after-eos.html:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium gardeing.
morrita@google.com [Thu, 23 Aug 2012 06:10:48 +0000 (06:10 +0000)]
Unreviewed Chromium gardeing.

* platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.png: Added.
* platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.txt: Added.
* platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.png: Added.
* platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.txt: Added.
* platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png: Added.
* platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.txt: Added.
* platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.png: Added.
* platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.txt: Added.
* platform/chromium-win-xp/media/track/track-cue-rendering-horizontal-expected.png: Added.
* platform/chromium-win-xp/media/track/track-cue-rendering-horizontal-expected.txt: Added.
* platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.png: Added.
* platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.txt: Added.
* platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png: Added.
* platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.txt: Added.
* platform/chromium-win/media/track/track-cue-rendering-vertical-expected.png: Added.
* platform/chromium-win/media/track/track-cue-rendering-vertical-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Remove V8Proxy from CodeGeneratorV8.pm
haraken@chromium.org [Thu, 23 Aug 2012 05:59:23 +0000 (05:59 +0000)]
[V8] Remove V8Proxy from CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=94773

Reviewed by Adam Barth.

To kill V8Proxy, we can remove V8Proxy uses from CodeGeneratorV8.pm.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateToV8Converters):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::wrapSlow):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::wrapSlow):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement UndoManager's item() method
commit-queue@webkit.org [Thu, 23 Aug 2012 05:58:10 +0000 (05:58 +0000)]
Implement UndoManager's item() method
https://bugs.webkit.org/show_bug.cgi?id=94671

Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-08-22
Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch implements UndoManager's item() method and its V8 custom binding.
We need to use custom binding here because we need to return user objects
that are stored in a hidden property of DOMTransaction wrappers, not returning
the wrappers themselves.

Test: editing/undomanager/undomanager-item.html

* bindings/js/JSUndoManagerCustom.cpp:
(WebCore::JSUndoManager::item):
(WebCore):
* bindings/v8/DOMTransaction.cpp:
(WebCore::DOMTransaction::data):
(WebCore):
(WebCore::DOMTransaction::setData):
(WebCore::DOMTransaction::getFunction):
* bindings/v8/DOMTransaction.h:
* bindings/v8/custom/V8UndoManagerCustom.cpp:
(WebCore::V8UndoManager::transactCallback):
(WebCore::V8UndoManager::itemCallback):
(WebCore):
* editing/UndoManager.cpp:
(WebCore::UndoManager::item):
(WebCore):
* editing/UndoManager.h:
(UndoManager):
* editing/UndoManager.idl:

LayoutTests:

* editing/undomanager/undomanager-item-expected.txt: Added.
* editing/undomanager/undomanager-item.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: Focusable elements without a role should not be ignored
dmazzoni@google.com [Thu, 23 Aug 2012 05:54:42 +0000 (05:54 +0000)]
AX: Focusable elements without a role should not be ignored
https://bugs.webkit.org/show_bug.cgi?id=94302

Reviewed by Chris Fleizach.

Source/WebCore:

Changes the accessibility logic so that a generic element that's focusable is
not ignored for accessibility, and returns its inner text as its title. That way
if you Tab to the element, a reasonable accessibility notification is generated.

One exception is the body element, because focusing the body is equivalent to
blurring the current focused element and does not result in a "focus" accessibility
notification.

Also fixes logic that determined if an element was contentEditable by making
sure it catches the case with no attribute value (e.g. <div contentEditable>),
which also implies contentEditable=true according to the spec.

Test: accessibility/focusable-div.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore):
(WebCore::nodeHasContentEditableAttributeSet):
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

LayoutTests:

Adds a new test to make sure that a generic focusable element (like a div with tabindex=0)
can get focus and return an appropriate title, just like a form control or element with
an ARIA role.

Modifies three existing tests that were previously assuming that a focusable node
with no role would be ignored for accessibility ("accessibilityIsIgnored").

* accessibility/editable-webarea-context-menu-point.html:
* accessibility/focusable-div-expected.txt: Added.
* accessibility/focusable-div.html: Added.
* accessibility/table-detection.html:
* platform/mac/accessibility/listbox-hit-test.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r126383.
haraken@chromium.org [Thu, 23 Aug 2012 04:49:03 +0000 (04:49 +0000)]
Unreviewed, rolling out r126383.
http://trac.webkit.org/changeset/126383
https://bugs.webkit.org/show_bug.cgi?id=82888

Chromium win build crash

* bindings/js/JSClipboardCustom.cpp:
(WebCore::JSClipboard::types):
* bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::typesAccessorGetter):
* dom/Clipboard.h:
(Clipboard):
* platform/blackberry/ClipboardBlackBerry.cpp:
(WebCore::ClipboardBlackBerry::types):
* platform/blackberry/ClipboardBlackBerry.h:
(ClipboardBlackBerry):
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
* platform/chromium/ChromiumDataObject.h:
(ChromiumDataObject):
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::types):
* platform/chromium/ClipboardChromium.h:
(ClipboardChromium):
* platform/efl/ClipboardEfl.cpp:
(WebCore::ClipboardEfl::types):
* platform/efl/ClipboardEfl.h:
(ClipboardEfl):
* platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::types):
* platform/gtk/ClipboardGtk.h:
(ClipboardGtk):
* platform/mac/ClipboardMac.h:
(ClipboardMac):
* platform/mac/ClipboardMac.mm:
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):
* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::types):
* platform/qt/ClipboardQt.h:
(ClipboardQt):
* platform/win/ClipboardWin.cpp:
(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):
* platform/win/ClipboardWin.h:
(ClipboardWin):
* platform/wx/ClipboardWx.cpp:
(WebCore::ClipboardWx::types):
* platform/wx/ClipboardWx.h:
(ClipboardWx):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Move m_isolatedWorlds and m_isolatedWorldSecurityOrigins from V8Proxy to ScriptC...
haraken@chromium.org [Thu, 23 Aug 2012 03:46:53 +0000 (03:46 +0000)]
[V8] Move m_isolatedWorlds and m_isolatedWorldSecurityOrigins from V8Proxy to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=94770

Reviewed by Adam Barth.

Now m_isolatedWorlds and m_isolatedWorldSecurityOrigins of V8Proxy
are used by ScriptController only. We can move them to ScriptController.

No tests. No change in behavior.

* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::resetIsolatedWorlds):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::setIsolatedWorldSecurityOrigin):
(WebCore::ScriptController::collectIsolatedContexts):
* bindings/v8/ScriptController.h:
(ScriptController):
* bindings/v8/V8Proxy.h:
(V8Proxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Move evaluate() from V8Proxy to ScriptController
haraken@chromium.org [Thu, 23 Aug 2012 03:42:54 +0000 (03:42 +0000)]
[V8] Move evaluate() from V8Proxy to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=94768

Reviewed by Adam Barth.

To kill V8Proxy, we can move evaluate() from V8Proxy to ScriptController.

- Renamed evaluate() to compileAndRunScript() to avoid name conflict
with existing ScriptController::evaluate().

- Removed toV8Proxy() from NPV8Object, as it is no longer used.

No tests. No change in behavior.

* bindings/v8/NPV8Object.cpp:
(_NPN_EvaluateHelper):
* bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::compileAndRunScript):
(WebCore):
(WebCore::ScriptController::evaluate):
(WebCore::ScriptController::evaluateInIsolatedWorld):
* bindings/v8/ScriptController.h:
(ScriptController):
* bindings/v8/V8Proxy.cpp:
* bindings/v8/V8Proxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoArray accesses should remember what kind of array they are predicted to access
fpizlo@apple.com [Thu, 23 Aug 2012 03:38:52 +0000 (03:38 +0000)]
Array accesses should remember what kind of array they are predicted to access
https://bugs.webkit.org/show_bug.cgi?id=94448

Reviewed by Gavin Barraclough.

Introduced the notion of DFG::Array::Mode, stored in node.arrayMode(), which allows nodes
to remember how they decided to access arrays. This permits the bytecode parser to "lock in"
the mode of access if it has profiling at its disposal, and it also allows the prediction
propagator to do a fixup of the array mode later in the optimization fixpoint.

This patch adds a healthy amount of new capability (specifically the ability of the parser
to lock in an array mode regardless of type predictions) and it also blows away a lot of
messy code.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
* dfg/DFGArrayMode.cpp: Added.
(DFG):
(JSC::DFG::fromObserved):
(JSC::DFG::refineArrayMode):
(JSC::DFG::modeAlreadyChecked):
(JSC::DFG::modeToString):
* dfg/DFGArrayMode.h: Added.
(DFG):
(JSC::DFG::canCSEStorage):
(JSC::DFG::modeForPut):
(JSC::DFG::modesCompatibleForStorageLoad):
(JSC::DFG::modeSupportsLength):
* dfg/DFGByteCodeParser.cpp:
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::getArrayModeWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getArrayMode):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkStructureLoadElimination):
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::putByOffsetStoreElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::byValIsPure):
(JSC::DFG::Graph::clobbersWorld):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasArrayMode):
(Node):
(JSC::DFG::Node::arrayMode):
(JSC::DFG::Node::setArrayMode):
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::typedArrayDescriptor):
(DFG):
(JSC::DFG::SpeculativeJIT::speculateArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed update of my email.
alexis@webkit.org [Thu, 23 Aug 2012 03:09:33 +0000 (03:09 +0000)]
Unreviewed update of my email.

* Scripts/webkitpy/common/config/committers.py:
* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConsider replacing return type of Clipboard::types() from HashSet<String> to Vector...
commit-queue@webkit.org [Thu, 23 Aug 2012 01:56:54 +0000 (01:56 +0000)]
Consider replacing return type of Clipboard::types() from HashSet<String> to Vector<String>.
https://bugs.webkit.org/show_bug.cgi?id=82888

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-08-22
Reviewed by Kentaro Hara.

As part of removing custom bindings of types Array Clipboard::types() needs to return
Vector<String> than HashSet<String>

No new tests. Exixting test should pass with this change as no behavoural changes.

* bindings/js/JSClipboardCustom.cpp: Replace data type from HashSet<> to Vector<>.
(WebCore::JSClipboard::types):
* bindings/v8/custom/V8ClipboardCustom.cpp: Ditto.
(WebCore::V8Clipboard::typesAccessorGetter):
* dom/Clipboard.h: Ditto.
(Clipboard):
* platform/blackberry/ClipboardBlackBerry.cpp: Ditto.
(WebCore::ClipboardBlackBerry::types):
* platform/blackberry/ClipboardBlackBerry.h: Ditto.
(ClipboardBlackBerry):
* platform/chromium/ChromiumDataObject.cpp: Ditto.
(WebCore::ChromiumDataObject::types):
* platform/chromium/ChromiumDataObject.h: Ditto.
(ChromiumDataObject):
* platform/chromium/ClipboardChromium.cpp: Ditto.
(WebCore::ClipboardChromium::types):
* platform/chromium/ClipboardChromium.h: Ditto.
(ClipboardChromium):
* platform/efl/ClipboardEfl.cpp: Ditto.
(WebCore::ClipboardEfl::types):
* platform/efl/ClipboardEfl.h: Ditto.
(ClipboardEfl):
* platform/gtk/ClipboardGtk.cpp: Ditto.
(WebCore::ClipboardGtk::types):
* platform/gtk/ClipboardGtk.h: Ditto.
(ClipboardGtk):
* platform/mac/ClipboardMac.h: Ditto.
(ClipboardMac):
* platform/mac/ClipboardMac.mm: Ditto.
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):
* platform/qt/ClipboardQt.cpp: Ditto.
(WebCore::ClipboardQt::types):
* platform/qt/ClipboardQt.h: Ditto.
(ClipboardQt):
* platform/win/ClipboardWin.cpp: Ditto.
(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):
* platform/win/ClipboardWin.h: Ditto.
(ClipboardWin):
* platform/wx/ClipboardWx.cpp: Ditto.
(WebCore::ClipboardWx::types):
* platform/wx/ClipboardWx.h: Ditto.
(ClipboardWx):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium gardening. Optimized baselines from yesterday
kbr@google.com [Thu, 23 Aug 2012 01:54:06 +0000 (01:54 +0000)]
Unreviewed Chromium gardening. Optimized baselines from yesterday
with dpranke's new algorithm in webkit-patch optimize-baselines
from r126374 and r126380.

* platform/chromium-linux/fast/canvas/canvas-scale-shadowBlur-expected.txt: Removed.
* platform/chromium-linux/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
* platform/chromium-linux/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Removed.
* platform/chromium-linux/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-scale-shadowBlur-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Removed.
* platform/chromium-mac/fast/canvas/canvas-scale-shadowBlur-expected.txt: Removed.
* platform/chromium-mac/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
* platform/chromium-mac/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Removed.
* platform/chromium-mac/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Removed.
* platform/chromium-win-xp/fast/canvas/canvas-scale-shadowBlur-expected.txt: Removed.
* platform/chromium-win-xp/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
* platform/chromium-win-xp/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Removed.
* platform/chromium-win-xp/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Removed.
* platform/chromium-win/fast/canvas/canvas-scale-shadowBlur-expected.txt: Removed.
* platform/chromium-win/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
* platform/chromium-win/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Removed.
* platform/chromium-win/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Removed.
* platform/chromium/fast/canvas/canvas-scale-shadowBlur-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/canvas/canvas-scale-shadowBlur-expected.txt.
* platform/chromium/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/canvas/canvas-scale-strokePath-shadow-expected.txt.
* platform/chromium/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt.
* platform/chromium/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: tests for injection/extraction of idb keys
commit-queue@webkit.org [Thu, 23 Aug 2012 01:49:56 +0000 (01:49 +0000)]
IndexedDB: tests for injection/extraction of idb keys
https://bugs.webkit.org/show_bug.cgi?id=94653

Patch by Alec Flett <alecflett@chromium.org> on 2012-08-22
Reviewed by Tony Chang.

Added unit tests for key injection/extraction using
SerializedScriptValue. These were moved from chromium, now
that all uses of the API are through WebKit.

* tests/IDBKeyPathTest.cpp:
(WebCore):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126381 268f45cc-cd09-0410-ab3c-d52691b4dbfc