WebKit-https.git
2 years ago[WPE] Avoid using autogen for JHBuild modules, trying to fix the EWS
aperez@igalia.com [Tue, 29 Aug 2017 21:41:35 +0000 (21:41 +0000)]
[WPE] Avoid using autogen for JHBuild modules, trying to fix the EWS

Unreviewed build fix.

This also makes the JHBuild process faster, because there are less
modules which will trigger slow, ancient Perl and M4 based tooling.

* wpe/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSetting the cache storage engine root path according the session WebsiteDataStore
commit-queue@webkit.org [Tue, 29 Aug 2017 21:39:48 +0000 (21:39 +0000)]
Setting the cache storage engine root path according the session WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=176055

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-29
Reviewed by Alex Christensen.

Source/WebCore:

No test right now as the engine is not making any read/write operations.

* platform/network/NetworkStorageSession.h:
(WebCore::NetworkStorageSession::cacheStorageDirectory const):
(WebCore::NetworkStorageSession::setCacheStorageDirectory):

Source/WebKit:

Adding disk read/write capacities to CacheStorage engine.
This is used to store per-origin cache names in a file.
Making Engine a thread safe refcounted object so that it does read/write in a background thread.

Setting the root path of the engine to the directory set for the session in use according the WebsiteDataStore.
For each WebsiteDataStore, a path and a sandbox extension is passed to the network process if persistency of the cache storage is wanted.
Ephemeral sessions will set the path of the engine to null so that no read/write access is performed.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::ensureLegacyPrivateBrowsingSession):
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::cacheStorageDirectory const):
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::from):
(WebKit::CacheStorage::Engine::defaultEngine):
(WebKit::CacheStorage::Engine::Engine):
(WebKit::CacheStorage::Engine::writeFile):
* NetworkProcess/cache/CacheStorageEngine.h:
(WebKit::CacheStorage::Engine::create):
(WebKit::CacheStorage::Engine::shouldPersist const):
* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
* NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):
* Shared/WebsiteDataStoreParameters.cpp:
(WebKit::WebsiteDataStoreParameters::encode const):
(WebKit::WebsiteDataStoreParameters::decode):
* Shared/WebsiteDataStoreParameters.h:
* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::parameters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoBuild fix. OS X "revision" can have a space.
rniwa@webkit.org [Tue, 29 Aug 2017 21:28:04 +0000 (21:28 +0000)]
Build fix. OS X "revision" can have a space.

* public/include/commit-log-fetcher.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMake it possible to specify A/B testing revision with a partial hash
rniwa@webkit.org [Tue, 29 Aug 2017 21:18:49 +0000 (21:18 +0000)]
Make it possible to specify A/B testing revision with a partial hash
https://bugs.webkit.org/show_bug.cgi?id=176047

Rubber-stamped by Chris Dumez.

Added the support for specifying a partial hash in A/B testing instead of the full hash.

* public/include/commit-log-fetcher.php:
(CommitLogFetcher::find_commit_id_by_revision): Extracted from associate-commit.php.
* public/privileged-api/associate-commit.php:
(main):
* public/privileged-api/create-test-group.php:
(main): Use find_commit_id_by_revision here to support scheduling an A/B testing with a partial hash.
* server-tests/privileged-api-create-test-group-tests.js:
(createAnalysisTask): Make it possible to customize revision string in some test cases.
* server-tests/resources/test-server.js:
(TestServer.prototype._stopApache): Fixed the bug that cleanup step always fails whenever the test file
runs more than 8s.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRebaselined http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl for...
jlewis3@apple.com [Tue, 29 Aug 2017 21:00:32 +0000 (21:00 +0000)]
Rebaselined http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl for ios-11.

Unreviewed test gardening.

* http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[CMake] Use find_package for libxml2 and libxstl
don.olmstead@sony.com [Tue, 29 Aug 2017 20:53:02 +0000 (20:53 +0000)]
[CMake] Use find_package for libxml2 and libxstl
https://bugs.webkit.org/show_bug.cgi?id=176042

Reviewed by Konstantin Tokarev.

.:

* Source/cmake/OptionsAppleWin.cmake:
* Source/cmake/OptionsWinCairo.cmake:

Source/WebCore:

No new tests. No change in behavior.

* CMakeLists.txt:
* PlatformGTK.cmake:
* PlatformWPE.cmake:
* PlatformWinCairo.cmake:

Source/WebKitLegacy:

* PlatformWin.cmake:

Tools:

* TestWebKitAPI/PlatformWin.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Optimize View.prototype.removeSubview
nvasilyev@apple.com [Tue, 29 Aug 2017 19:25:56 +0000 (19:25 +0000)]
Web Inspector: Optimize View.prototype.removeSubview
https://bugs.webkit.org/show_bug.cgi?id=176041

Reviewed by Matt Baker.

Source/WebInspectorUI:

Look up a subview in an array only once, not twice.

* UserInterface/Base/Utilities.js:
(Array.prototype.removeAll):
(Array.prototype.remove):
Split Array.propotype.remove(value, onlyFirst) into Array.propotype.removeAll(value) and
Array.propotype.remove(value).

* UserInterface/Controllers/DebuggerManager.js:
(WI.DebuggerManager.prototype._debuggerBreakpointOptions):
* UserInterface/Views/ContentViewContainer.js:
(WI.ContentViewContainer.prototype._clearTombstonesForContentView):
(WI.ContentViewContainer.prototype._disassociateFromContentView):
* UserInterface/Views/View.js:
(WI.View.prototype.removeSubview):

LayoutTests:

Split Array.prototype.remove(value, onlyFirst) into Array.prototype.removeAll(value) and Array.prototype.remove(value).

* inspector/unit-tests/array-utilities-expected.txt:
* inspector/unit-tests/array-utilities.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Win] A WTF test is timing out in run-api-tests.
pvollan@apple.com [Tue, 29 Aug 2017 18:34:38 +0000 (18:34 +0000)]
[Win] A WTF test is timing out in run-api-tests.
https://bugs.webkit.org/show_bug.cgi?id=176056

Reviewed by Brent Fulgham.

The test SynchronizedFixedQueue.ProduceOnly relies on that putting a thread to sleep for
1ms will wake it up before another thread which is put to sleep for 10ms. I believe this
is not neccessarily true on Windows where the thread scheduling does not have millisecond
accuracy. Fix the test timeout by adjusting the sleep time slightly.

* TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
(TestWebKitAPI::ToUpperConverter::startProducing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoCacheQueryOptions::isolatedCopy() copies the cache name twice
dbates@webkit.org [Tue, 29 Aug 2017 18:08:54 +0000 (18:08 +0000)]
CacheQueryOptions::isolatedCopy() copies the cache name twice
https://bugs.webkit.org/show_bug.cgi?id=175974

Reviewed by Youenn Fablet.

Currently CacheQueryOptions has a user-defined constructor that calls String.isolatedCopy()
on the passed cache name. CacheQueryOptions::isolatedCopy() also calls String.isolatedCopy()
on the cache name before passing the result to the user-defined constructor; => we malloc
and copy the cache name twice. Ideally we would remove the user-defined constructors and
have callers use aggregate initializer syntax to instantiate a CacheQueryOptions. Unfortunately
we cannot do this until we upgrade from Visual Studio 2015 to Visual Studio 2017 as the former
does not support non-static data member initializers (NSDMI) for aggregates and CacheQueryOptions
has some. Therefore we modify the user-defined, non-default, constructor to take a String&&
and conditionally compile the the constructors when building with compilers that do not
support NSDMI for aggregates.

* Modules/cache/CacheQueryOptions.h:
(WebCore::CacheQueryOptions::CacheQueryOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoCanvasCaptureMediaStreamTrack clone is not a CanvasCaptureMediaStreamTrack
commit-queue@webkit.org [Tue, 29 Aug 2017 17:43:51 +0000 (17:43 +0000)]
CanvasCaptureMediaStreamTrack clone is not a CanvasCaptureMediaStreamTrack
https://bugs.webkit.org/show_bug.cgi?id=176036

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-29
Reviewed by Eric Carlson.

Source/WebCore:

Covered by existing tests.

Instead of creating a MediaStreamTrack clone when cloning a CanvasCaptureMediaStreamTrack,
we are now creating a CanvasCaptureMediaStreamTrack.
This allows exposing the expected methods and having the expected functionality.

* Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:
(WebCore::CanvasCaptureMediaStreamTrack::clone):
* Modules/mediastream/CanvasCaptureMediaStreamTrack.h:
* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::clone):
* Modules/mediastream/MediaStreamTrack.h:

LayoutTests:

* fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track-expected.txt:
* fast/mediastream/captureStream/canvas2d.html:
* fast/mediastream/captureStream/canvas2d-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSkip editing/pasteboard/paste-empty-startcontainer.html on Windows.
pvollan@apple.com [Tue, 29 Aug 2017 17:40:14 +0000 (17:40 +0000)]
Skip editing/pasteboard/paste-empty-startcontainer.html on Windows.
It is skipped on all other platforms.

Unreviewed test gardening.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMarked fast/events/mouse-cursor-no-mousemove.html as flaky.
jlewis3@apple.com [Tue, 29 Aug 2017 17:35:39 +0000 (17:35 +0000)]
Marked fast/events/mouse-cursor-no-mousemove.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=169238

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd initial support for dataTransferItem.webkitGetAsEntry()
cdumez@apple.com [Tue, 29 Aug 2017 17:00:09 +0000 (17:00 +0000)]
Add initial support for dataTransferItem.webkitGetAsEntry()
https://bugs.webkit.org/show_bug.cgi?id=176038
<rdar://problem/34121095>

Reviewed by Wenson Hsieh.

Source/JavaScriptCore:

Add CommonIdentifier needed by [EnabledAtRuntime].

* runtime/CommonIdentifiers.h:

Source/WebCore:

Add initial support for dataTransferItem.webkitGetAsEntry() as per:
- https://wicg.github.io/entries-api/#html-data

The method works as expected and returns a FileSystemEntry. The entry
can be either a file or a directory. All of the attributes exposed on
the FileSystemEntry return correct values.

What remains to be implemented for this new API to actually be useful:
- directory.getFile() / directory.getDirectory()
- file.file()
- entry.getParent()
- directoryReader.readEntries()

Test: editing/pasteboard/datatransfer-items-drop-getAsEntry.html

* CMakeLists.txt:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
Add new files to projects.

* Modules/entriesapi/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::DOMFileSystem):
* Modules/entriesapi/DOMFileSystem.h:
(WebCore::DOMFileSystem::create):
DOMFileSystem factory now takes a name parameter. This name is a UUID, as suggested in
the specification and implemented by Firefox.

* Modules/entriesapi/ErrorCallback.cpp: Added.
* Modules/entriesapi/ErrorCallback.h:
Add scheduleCallback() convenience method as we often need to call this callback
asynchronously.

* Modules/entriesapi/FileSystemDirectoryEntry.cpp:
(WebCore::FileSystemDirectoryEntry::FileSystemDirectoryEntry):
(WebCore::FileSystemDirectoryEntry::createReader):
(WebCore::FileSystemDirectoryEntry::getFile):
(WebCore::FileSystemDirectoryEntry::getDirectory):
* Modules/entriesapi/FileSystemDirectoryEntry.h:
- Add implementation for createReader().
- Update getFile() / getDirectory() to call the error callback for now as they are
  unimplemented.
- Have the factory take the virtual path of the entry so that it can be
  exposed via the fullPath attribute in IDL.

* Modules/entriesapi/FileSystemDirectoryEntry.idl:
Expose createReader() now that we have stubs for FileSystemDirectoryReader.

* Modules/entriesapi/FileSystemDirectoryReader.cpp: Added.
* Modules/entriesapi/FileSystemDirectoryReader.h: Added.
* Modules/entriesapi/FileSystemDirectoryReader.idl: Added.
* Modules/entriesapi/FileSystemEntriesCallback.cpp: Added.
* Modules/entriesapi/FileSystemEntriesCallback.h: Added.
* Modules/entriesapi/FileSystemEntriesCallback.idl: Added.
Land stubs for FileSystemDirectoryReader and its FileSystemEntriesCallback.

* Modules/entriesapi/FileSystemEntry.cpp:
(WebCore::FileSystemEntry::FileSystemEntry):
* Modules/entriesapi/FileSystemEntry.h:
(WebCore::FileSystemEntry::virtualPath const):
* Modules/entriesapi/FileSystemEntry.idl:
Update constructor to take a virtual path, which is exposed via fullPath
attribute in IDL.

* Modules/entriesapi/FileSystemFileEntry.cpp:
(WebCore::FileSystemFileEntry::FileSystemFileEntry):
(WebCore::FileSystemFileEntry::file):
* Modules/entriesapi/FileSystemFileEntry.h:
(isType):
* Modules/entriesapi/FileSystemFileEntry.idl:
- Update file() to call the error callback for now as they are
  unimplemented.
- Have the factory take the virtual path of the entry so that it can be
  exposed via the fullPath attribute in IDL.

* bindings/js/JSFileSystemEntryCustom.cpp: Added.
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
Add custom implementation of FileSystemEntry's toJS() function. This is
needed because FileSystemEntry has 2 subclasses and we need to type check
at runtime to construct the right wrapper.

* dom/DataTransferItem.cpp:
(WebCore::DataTransferItem::getAsEntry const):
* dom/DataTransferItem.h:
* dom/DataTransferItem.idl:
Add initial implementation for getAsEntry(), currently exposed as
webkitGetAsEntry().

* dom/DataTransferItemList.cpp:
(WebCore::DataTransferItemList::ensureItems const):
Construct a DataTransferItem if the file is a directory now that we
support getAsEntry().

* fileapi/File.cpp:
(WebCore::File::isDirectory const):
* fileapi/File.h:
Add convenience method to query if a File is a directory.

Source/WebKit:

Make dataTransfer.items an experimental feature so that it can be easily
turned on from the Develop menu, for testing convenience.

* Shared/WebPreferencesDefinitions.h:

LayoutTests:

* editing/pasteboard/datatransfer-items-drop-getAsEntry-expected.txt: Added.
* editing/pasteboard/datatransfer-items-drop-getAsEntry.html: Added.
Add layout test coverage.

* http/wpt/entries-api/interfaces-expected.txt:
Rebaseline test now that we support more of the API.

* platform/wk2/TestExpectations:
Skip new test on WK2 because it relies on beginDragWithFiles().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, update my watchlist filters.
eric.carlson@apple.com [Tue, 29 Aug 2017 17:00:04 +0000 (17:00 +0000)]
Unreviewed, update my watchlist filters.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago Marked media/video-controls-no-display-with-text-track.html and media/video-controls...
jlewis3@apple.com [Tue, 29 Aug 2017 16:52:23 +0000 (16:52 +0000)]
 Marked media/video-controls-no-display-with-text-track.html and media/video-controls-in-media-document.html as flaky.
 https://bugs.webkit.org/show_bug.cgi?id=176054

 Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRebaseline fast/doctypes/002.html after r220858.
pvollan@apple.com [Tue, 29 Aug 2017 15:21:42 +0000 (15:21 +0000)]
Rebaseline fast/doctypes/002.html after r220858.

Unreviewed test gardening.

* platform/win/fast/doctypes/002-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRebaseline fast/lists/marker-before-empty-inline.html after r220858.
pvollan@apple.com [Tue, 29 Aug 2017 14:57:36 +0000 (14:57 +0000)]
Rebaseline fast/lists/marker-before-empty-inline.html after r220858.

Unreviewed test gardening.

* platform/win/fast/lists/marker-before-empty-inline-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRebaseline css2.1/t0805-c5520-brdr-b-01-e.html after r220858.
pvollan@apple.com [Tue, 29 Aug 2017 14:33:06 +0000 (14:33 +0000)]
Rebaseline css2.1/t0805-c5520-brdr-b-01-e.html after r220858.

Unreviewed test gardening.

* platform/win/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] Remove some obsolete expectations.
commit-queue@webkit.org [Tue, 29 Aug 2017 14:20:04 +0000 (14:20 +0000)]
[GTK] Remove some obsolete expectations.
https://bugs.webkit.org/show_bug.cgi?id=176051

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-29

* platform/gtk/TestExpectations:
  - fast/animation/request-animation-frame-throttling-detached-iframe.html: passing since r215259.
  - fast/animation/request-animation-frame-throttling-lowPowerMode.html: passing since r215259.
  - fast/events/drag-parent-node.html: passing since r217670-r217679.
  - fast/events/keydown-leftright-keys.html: passing since r210504.
  - fast/events/selectionchange-iframe.html: passing since r205908-r205913.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed. REGRESSION(r221219): Fix unit tests using resources from WebKit directory.
carlosgc@webkit.org [Tue, 29 Aug 2017 14:01:47 +0000 (14:01 +0000)]
Unreviewed. REGRESSION(r221219): Fix unit tests using resources from WebKit directory.

The WebKit2 directory was renamed as WebKit in r221219, but neither run-gtk-tests script nor
Test::getResourcesDir() were updated to use the new name.

* Scripts/run-gtk-tests:
(TestRunner._setup_testing_environment):
* TestWebKitAPI/glib/WebKitGLib/TestMain.h:
(Test::getResourcesDir):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WebCrypto] Push WorkQueue dispatches for HKDF, HMAC, PBKDF2 algorithms into shared...
zandobersek@gmail.com [Tue, 29 Aug 2017 11:30:49 +0000 (11:30 +0000)]
[WebCrypto] Push WorkQueue dispatches for HKDF, HMAC, PBKDF2 algorithms into shared code
https://bugs.webkit.org/show_bug.cgi?id=175620

Reviewed by Jiewen Tan.

Push the WorkQueue dispatch code and other code duplicated between the
Mac and libgcrypt implementations of Web Crypto into the shared layer.
This patch focuses on the HKDF, HMAC and PBKDF2 algorithms.

Functions with platform-specific implementations that are invoked from
these asynchronous dispatches are made static and return an ExceptionOr
value. CryptoAlgorithmParameters objects are passed through non-const
references because data getters could lazily construct the underlying
Vector objects. CryptoKey objects are passed through const references.
Implementations can then manually retrieve and further validate any key
or parameter data, as required for that specific implementation. Input
data is passed through const references to the original Vector objects.

No new tests -- no changes in behavior that's covered by existing tests.

* crypto/algorithms/CryptoAlgorithmHKDF.cpp:
(WebCore::CryptoAlgorithmHKDF::deriveBits):
* crypto/algorithms/CryptoAlgorithmHKDF.h:
* crypto/algorithms/CryptoAlgorithmHMAC.cpp:
(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):
* crypto/algorithms/CryptoAlgorithmHMAC.h:
* crypto/algorithms/CryptoAlgorithmPBKDF2.cpp:
(WebCore::CryptoAlgorithmPBKDF2::deriveBits):
* crypto/algorithms/CryptoAlgorithmPBKDF2.h:
* crypto/gcrypt/CryptoAlgorithmHKDFGCrypt.cpp:
(WebCore::CryptoAlgorithmHKDF::platformDeriveBits):
* crypto/gcrypt/CryptoAlgorithmHMACGCrypt.cpp:
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):
* crypto/gcrypt/CryptoAlgorithmPBKDF2GCrypt.cpp:
(WebCore::CryptoAlgorithmPBKDF2::platformDeriveBits):
* crypto/mac/CryptoAlgorithmHKDFMac.cpp:
(WebCore::CryptoAlgorithmHKDF::platformDeriveBits):
* crypto/mac/CryptoAlgorithmHMACMac.cpp:
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):
* crypto/mac/CryptoAlgorithmPBKDF2Mac.cpp:
(WebCore::CryptoAlgorithmPBKDF2::platformDeriveBits):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WebCrypto] Push WorkQueue dispatches for EC algorithms into shared code
zandobersek@gmail.com [Tue, 29 Aug 2017 11:29:56 +0000 (11:29 +0000)]
[WebCrypto] Push WorkQueue dispatches for EC algorithms into shared code
https://bugs.webkit.org/show_bug.cgi?id=175619

Reviewed by Jiewen Tan.

Push the WorkQueue dispatch code duplicated between the Mac and libgcrypt
implementations of Web Crypto into the shared layer. This patch focuses on
the EC-based algorithms.

Functions with platform-specific implementations that are invoked from
these asynchronous dispatches are made static and return an ExceptionOr or
std::optional value. CryptoKey and CryptoAlgorithmParameters objects are
passed to those through const references. Input data is passed through
const references to the original Vector objects.

No new tests -- no changes in behavior that's covered by existing tests.

* crypto/algorithms/CryptoAlgorithmECDH.cpp:
(WebCore::CryptoAlgorithmECDH::deriveBits):
* crypto/algorithms/CryptoAlgorithmECDH.h:
* crypto/algorithms/CryptoAlgorithmECDSA.cpp:
(WebCore::CryptoAlgorithmECDSA::sign):
(WebCore::CryptoAlgorithmECDSA::verify):
* crypto/algorithms/CryptoAlgorithmECDSA.h:
* crypto/gcrypt/CryptoAlgorithmECDHGCrypt.cpp:
(WebCore::CryptoAlgorithmECDH::platformDeriveBits):
* crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp:
(WebCore::CryptoAlgorithmECDSA::platformSign):
(WebCore::CryptoAlgorithmECDSA::platformVerify):
* crypto/keys/CryptoKeyEC.h:
* crypto/mac/CryptoAlgorithmECDHMac.cpp:
(WebCore::CryptoAlgorithmECDH::platformDeriveBits):
* crypto/mac/CryptoAlgorithmECDSAMac.cpp:
(WebCore::CryptoAlgorithmECDSA::platformSign):
(WebCore::CryptoAlgorithmECDSA::platformVerify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[SVG] Leak in SVGAnimatedListPropertyTearOff
svillar@igalia.com [Tue, 29 Aug 2017 09:32:34 +0000 (09:32 +0000)]
[SVG] Leak in SVGAnimatedListPropertyTearOff
https://bugs.webkit.org/show_bug.cgi?id=172545

Reviewed by Darin Adler.

Source/WebCore:

SVGAnimatedListPropertyTearOff maintains a vector m_wrappers with references to
SVGPropertyTraits<PropertyType>::ListItemTearOff. Apart from that SVGPropertyTearOff has a
reference to SVGAnimatedProperty.

When SVGListProperty::getItemValuesAndWrappers() is called, it creates a
SVGPropertyTraits<PropertyType>::ListItemTearOff pointing to the same SVGAnimatedProperty (a
SVGAnimatedListPropertyTearOff) which stores the m_wrappers vector where the ListItemTearOff
is going to be added to. This effectively creates a reference cycle between the
SVGAnimatedListPropertyTearOff and all the ListItemTearOff it stores in m_wrappers.

In order to effectively break the cycle without freeing too many wrappers we should take two
measures:
1) Break the reference cycle by storing raw pointers in the m_wrappers Vector
2) Remove the ListItemTearOff which is being deleted (it notifies the animated property by
calling propertyWillBeDeleted) from the m_wrappers Vector.

This is a re-land of r219334 which caused early releases of custom data attribute objects
added to SVG elements (wkb.ug/175023).

Tests: svg/animations/animation-leak-list-property-instances.html
       svg/dom/SVGAnimatedListPropertyTearOff-crash-2.html
       svg/dom/SVGAnimatedListPropertyTearOff-crash.html
       svg/dom/SVGAnimatedListPropertyTearOff-leak.html

* svg/properties/SVGAnimatedListPropertyTearOff.h:
* svg/properties/SVGListProperty.h:
(WebCore::SVGListProperty::getItemValuesAndWrappers):
* svg/properties/SVGListPropertyTearOff.h:
(WebCore::SVGListPropertyTearOff::removeItemFromList):

LayoutTests:

The list of new added tests includes the one for the original bug, a new test for the
regression and a couple of tests imported from Blink which verify that
SVGAnimatedListPropertyTearOff does not crash after the context element goes out of scope.

* svg/animations/animation-leak-list-property-instances-expected.txt: Added.
* svg/animations/animation-leak-list-property-instances.html: Added.
* svg/dom/SVGAnimatedListPropertyTearOff-crash-2-expected.txt: Added. Imported from Blink.
* svg/dom/SVGAnimatedListPropertyTearOff-crash-2.html: Added. Imported from Blink.
* svg/dom/SVGAnimatedListPropertyTearOff-crash-expected.txt: Added. Imported from Blink.
* svg/dom/SVGAnimatedListPropertyTearOff-crash.html: Added. Imported from Blink.
* svg/dom/SVGAnimatedListPropertyTearOff-leak-expected.txt: Added.
* svg/dom/SVGAnimatedListPropertyTearOff-leak.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
aestes@apple.com [Tue, 29 Aug 2017 09:10:52 +0000 (09:10 +0000)]
[Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
https://bugs.webkit.org/show_bug.cgi?id=176046

Reviewed by Alex Christensen.

Source/WebCore:

* platform/FileSystem.cpp:
(WebCore::setMetadataURL):
* platform/FileSystem.h:
(WebCore::setMetadataURL):
* platform/mac/FileSystemMac.mm:
(WebCore::setMetadataURL):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

Source/WebCore/PAL:

* PAL.xcodeproj/project.pbxproj:
* pal/spi/mac/MetadataSPI.h: Added.

Source/WebKit:

* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::savePDFToTemporaryFolderAndOpenWithNativeApplicationRaw):
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

Source/WebKitLegacy/mac:

Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.

* Misc/WebNSFileManagerExtras.mm:
(-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
(setMetaData): Deleted.
* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed WPE debug build fix.
zandobersek@gmail.com [Tue, 29 Aug 2017 07:46:13 +0000 (07:46 +0000)]
Unreviewed WPE debug build fix.

* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::dispatchPendingDecryptionStructure):
AppendState is an enum class, enum values have to be accessed
using scope resolution.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed build fix #2 after r221275.
bfulgham@apple.com [Tue, 29 Aug 2017 04:33:36 +0000 (04:33 +0000)]
Unreviewed build fix #2 after r221275.

* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
to match new API.
* WebCoreSupport/WebPlatformStrategies.h: Update signatures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoLogger should use makeString instead of String::format
eric.carlson@apple.com [Tue, 29 Aug 2017 02:59:18 +0000 (02:59 +0000)]
Logger should use makeString instead of String::format
https://bugs.webkit.org/show_bug.cgi?id=176035

Reviewed by Jer Noble.

Source/WebCore/PAL:

* pal/Logger.h:
(PAL::LogArgument::toString):
(PAL::Logger::logAlways):
(PAL::Logger::error):
(PAL::Logger::warning):
(PAL::Logger::notice):
(PAL::Logger::info):
(PAL::Logger::debug):
(PAL::Logger::MethodAndPointer::MethodAndPointer):
(PAL::Logger::log):
(PAL::LogArgument<Logger::MethodAndPointer>::toString):

Tools:

* TestWebKitAPI/Tests/WebCore/Logging.cpp:
(TestWebKitAPI::TEST_F): Update test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRebaseline accessibility/menu-list-crash2.html after r220930.
pvollan@apple.com [Tue, 29 Aug 2017 02:18:29 +0000 (02:18 +0000)]
Rebaseline accessibility/menu-list-crash2.html after r220930.

Unreviewed test gardening.

* platform/win/accessibility/menu-list-crash2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
aestes@apple.com [Tue, 29 Aug 2017 00:55:01 +0000 (00:55 +0000)]
[Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
https://bugs.webkit.org/show_bug.cgi?id=176039

Reviewed by Alex Christensen.

Source/WebCore:

* PlatformMac.cmake:
* WebCore.xcodeproj/project.pbxproj:
* platform/ios/WebCoreSystemInterfaceIOS.mm:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
* platform/text/TextEncodingRegistry.cpp:
(WebCore::defaultTextEncodingNameForSystemLanguage):
* platform/text/TextEncodingRegistry.h:
* platform/text/ios/TextEncodingRegistryIOS.mm: Added.
(WebCore::webDefaultCFStringEncoding):
* platform/text/mac/TextEncodingRegistryMac.mm: Added.
(WebCore::webDefaultCFStringEncoding):

Source/WebKit:

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

Source/WebKitLegacy/mac:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
* WebView/WebPreferences.mm:
(+[WebPreferences _systemCFStringEncoding]):

Source/WTF:

* wtf/spi/cf/CFStringSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRebaseline http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl.
ryanhaddad@apple.com [Tue, 29 Aug 2017 00:42:27 +0000 (00:42 +0000)]
Rebaseline http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl.

Unreviewed test gardening.

* http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt:
* platform/mac-highsierra/http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt: Copied from LayoutTests/http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GStreamer] The glvideoflip GStreamer element isn't available. Video mirroring and...
mcatanzaro@igalia.com [Tue, 29 Aug 2017 00:40:35 +0000 (00:40 +0000)]
[GStreamer] The glvideoflip GStreamer element isn't available. Video mirroring and rotation functionalities are thus disabled.
https://bugs.webkit.org/show_bug.cgi?id=175576

Reviewed by Carlos Alberto Lopez Perez.

Build graphene to enable the glvideoflip element.

* gstreamer/jhbuild.modules:
* gtk/jhbuild.modules:
* jhbuild/jhbuild-wrapper:
* wpe/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoREGRESSION(r220278): Web Inspector: ContextMenu items are not getting triggered
commit-queue@webkit.org [Tue, 29 Aug 2017 00:27:54 +0000 (00:27 +0000)]
REGRESSION(r220278): Web Inspector: ContextMenu items are not getting triggered
https://bugs.webkit.org/show_bug.cgi?id=176034

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-08-28
Reviewed by Devin Rousso.

* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::showContextMenu):
Responses go through InspectorFrontendAPI not InspectorFrontendHost.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoFix incorrect enum in atBoundaryOfGranularity call
megan_gardner@apple.com [Mon, 28 Aug 2017 23:56:25 +0000 (23:56 +0000)]
Fix incorrect enum in atBoundaryOfGranularity call
https://bugs.webkit.org/show_bug.cgi?id=176004

Reviewed by Wenson Hsieh and Enrica Casucci

Enum that was being used was incorrect, as that case in not covered in called function.
Resulted in a no-op. Should now have correct behavior around line boundaries.

Not possible to add tests for selections with velocity. Will attempt to add this behavior later.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::rangeAtWordBoundaryForPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed test gardening. <rdar://problem/34051745>
jlewis3@apple.com [Mon, 28 Aug 2017 23:29:54 +0000 (23:29 +0000)]
Unreviewed test gardening. <rdar://problem/34051745>

* platform/ios-11/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WinCairo] Add PlatformWin cmake for Webkit
commit-queue@webkit.org [Mon, 28 Aug 2017 23:29:29 +0000 (23:29 +0000)]
[WinCairo] Add PlatformWin cmake for Webkit
https://bugs.webkit.org/show_bug.cgi?id=176027

Patch by Stephan Szabo <stephan.szabo@sony.com> on 2017-08-28
Reviewed by Brent Fulgham.

* PlatformWin.cmake: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed build fix after r221275.
bfulgham@apple.com [Mon, 28 Aug 2017 22:46:02 +0000 (22:46 +0000)]
Unreviewed build fix after r221275.

* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
to match new API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWebRTC MediaStream created without tracks does not update active state after tracks...
commit-queue@webkit.org [Mon, 28 Aug 2017 22:38:13 +0000 (22:38 +0000)]
WebRTC MediaStream created without tracks does not update active state after tracks are added
https://bugs.webkit.org/show_bug.cgi?id=175434

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-28
Reviewed by Eric Carlson.

Source/WebCore:

Covered by updated test.

Removing active/inactive events.
active attribute is still kept and is updated synchronously on every track change.

* Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::activeStatusChanged):
(WebCore::MediaStream::internalAddTrack):
(WebCore::MediaStream::updateActiveState):
(WebCore::MediaStream::hasPendingActivity const):
(WebCore::MediaStream::scheduleActiveStateChange): Deleted.
(WebCore::MediaStream::activityEventTimerFired): Deleted.
* Modules/mediastream/MediaStream.h:
* Modules/mediastream/MediaStream.idl:

LayoutTests:

* fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track-expected.txt:
* fast/mediacapturefromelement/CanvasCaptureMediaStream-creation-expected.txt:
* fast/mediastream/MediaStream-add-remove-tracks-expected.txt:
* fast/mediastream/MediaStream-add-remove-tracks.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
aestes@apple.com [Mon, 28 Aug 2017 22:23:08 +0000 (22:23 +0000)]
[Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
https://bugs.webkit.org/show_bug.cgi?id=176032

Reviewed by Alex Christensen.

Source/WebCore:

* platform/ios/WebCoreSystemInterfaceIOS.mm:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
* platform/network/NetworkStorageSession.h:
* platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::NetworkStorageSession::switchToNewTestingSession):
(WebCore::NetworkStorageSession::ensureSession):
* platform/network/cf/ResourceRequest.h:
* platform/network/cocoa/NetworkStorageSessionCocoa.mm:
(WebCore::createPrivateStorageSession):
* platform/network/cocoa/ResourceRequestCocoa.mm:
(WebCore::ResourceRequest::setStorageSession):
(WebCore::copyRequestWithStorageSession):
(WebCore::cachedResponseForRequest):
* platform/network/mac/CookieJarMac.mm:
(WebCore::httpCookies):
(WebCore::setHTTPCookiesForURL):
(WebCore::deleteHTTPCookie):
(WebCore::deleteAllHTTPCookies):
(WebCore::setCookiesFromDOM):
(WebCore::httpCookieAcceptPolicy):
(WebCore::cookiesEnabled):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteAllCookies):
(WebCore::deleteCookiesForHostnames):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::createNSURLConnection):

Source/WebCore/PAL:

* pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::privateBrowsingSession):
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformHasLocalDataForURL):
(WebKit::cachedResponseForURL):

Source/WebKitLegacy/mac:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
* WebView/WebView.mm:
(-[WebView _cachedResponseForURL:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDisable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header...
bfulgham@apple.com [Mon, 28 Aug 2017 22:08:34 +0000 (22:08 +0000)]
Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
https://bugs.webkit.org/show_bug.cgi?id=175992
<rdar://problem/34086613>

Reviewed by Daniel Bates.

Source/WebCore:

The original work in Bug 157053 did not properly handle the case of websockets. This patch completes
the changes to secure cookie handling to make sure websockets are also protected.

Tests: http/tests/websocket/tests/hybi/secure-cookie-insecure-connection.pl
       http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl

* Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::clientHandshakeRequest): Remove 'const' declaration so we can work with
a mutable Document object. This allows us to mark the Document as having accessed secure cookies.
(WebCore::WebSocketChannel::clientHandshakeRequest const): Deleted.
* Modules/websockets/WebSocketChannel.h:
* Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::clientHandshakeMessage): Ditto.
(WebCore::WebSocketHandshake::clientHandshakeRequest): Ditto.
(WebCore::WebSocketHandshake::clientHandshakeMessage const): Deleted.
(WebCore::WebSocketHandshake::clientHandshakeRequest const): Deleted.
* Modules/websockets/WebSocketHandshake.h:
* loader/CookieJar.cpp:
(WebCore::cookies): Small naming cleanup.
(WebCore::cookieRequestHeaderFieldValue): Pass a flag indicating whether secure cookies should be
included in the result or not. Set the document flag indicating secure cookies were accessed (if
they were), and return the resulting cookie string.
* loader/CookieJar.h:
* platform/CookiesStrategy.h:
* platform/network/CacheValidation.cpp:
(WebCore::headerValueForVary): Revise to pass a flag indicating whether secure cookies should be included
or not.
* platform/network/PlatformCookieJar.h:
* platform/network/cf/CookieJarCFNet.cpp:
(WebCore::doesContainSecureCookies): Added helper method.
(WebCore::cookiesForDOM): Revise to use new helper function.
(WebCore::cookieRequestHeaderFieldValue): Revise to accept a flag indicating if secure cookies should
be included in the result. Return a pair consisting of the cookie string, and a flag indicating whether
secure cookies were accessed or not.
* platform/network/curl/CookieJarCurl.cpp:
(WebCore::CookieJarCurlFileSystem::cookieRequestHeaderFieldValue): Ditto.
(WebCore::cookieRequestHeaderFieldValue): Ditto.
* platform/network/curl/CookieJarCurl.h:
* platform/network/mac/CookieJarMac.mm:
(WebCore::cookiesForSession): Ditto.
(WebCore::cookiesForDOM): Update for new 'cookiesForSession' signature.
(WebCore::cookieRequestHeaderFieldValue): Ditto.
* platform/network/soup/CookieJarSoup.cpp:
(WebCore::cookieRequestHeaderFieldValue): Revise to accept a flag indicating if secure cookies should
be included in the result. Return a pair consisting of the cookie string, and a flag indicating whether
secure cookies were accessed or not.

Source/WebKit:

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM): Use a better label than 'result'.
(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue): Modify to accept a flag
indicating if secure cookies should be included, and return a pair containing the resulting
cookie string and a boolean indicating if secure cookies were accessed.
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in: Ditto.
* Shared/mac/CookieStorageShim.mm:
(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL): Ditto.
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue): Ditto.
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:

Source/WebKitLegacy/mac:

* WebCoreSupport/WebPlatformStrategies.h:
* WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
cookies should be included, and return a pair containing the resulting cookie string and a boolean
indicating if secure cookies were accessed.

LayoutTests:

* http/tests/websocket/tests/hybi/secure-cookie-insecure-connection-expected.txt: Added.
* http/tests/websocket/tests/hybi/secure-cookie-insecure-connection.pl: Added.
* http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt: Added.
* http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, remove duplicated TestExpectation entry.
ryanhaddad@apple.com [Mon, 28 Aug 2017 21:57:28 +0000 (21:57 +0000)]
Unreviewed, remove duplicated TestExpectation entry.

* platform/mac-highsierra-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoBefore r220970, these ssl tests were failing. Now they are timing out.
pvollan@apple.com [Mon, 28 Aug 2017 21:14:44 +0000 (21:14 +0000)]
Before r220970, these ssl tests were failing. Now they are timing out.

Unreviewed test gardening.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMark tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-with-handler.html...
ryanhaddad@apple.com [Mon, 28 Aug 2017 21:13:00 +0000 (21:13 +0000)]
Mark tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-with-handler.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=172544

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Win] The test http/tests/misc/policy-delegate-called-twice.html is crashing.
pvollan@apple.com [Mon, 28 Aug 2017 20:11:45 +0000 (20:11 +0000)]
[Win] The test http/tests/misc/policy-delegate-called-twice.html is crashing.
https://bugs.webkit.org/show_bug.cgi?id=176031

Reviewed by Brent Fulgham.

When the function in the FramePolicyFunction parameter is called, it has already been moved
to an internal member by the setUpPolicyListener method, and is no longer valid. Invoke the
function by using the stored member instead.

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMarked svg/in-html/by-reference.html as flaky.
jlewis3@apple.com [Mon, 28 Aug 2017 20:10:16 +0000 (20:10 +0000)]
Marked svg/in-html/by-reference.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=175781

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Remove some unused DataGrid code
commit-queue@webkit.org [Mon, 28 Aug 2017 19:56:58 +0000 (19:56 +0000)]
Web Inspector: Remove some unused DataGrid code
https://bugs.webkit.org/show_bug.cgi?id=176029

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-08-28
Reviewed by Matt Baker.

* UserInterface/Views/DataGrid.js:
(WI.DataGrid.prototype.get copyTextDelimiter):
(WI.DataGrid.prototype.set copyTextDelimiter):
(WI.DataGrid.prototype.resizerDragging):
(WI.DataGrid.prototype.columnWidthsMap): Deleted.
(WI.DataGrid.prototype.applyColumnWidthsMap): Deleted.
(WI.DataGrid.prototype.get resizeMethod): Deleted.
(WI.DataGrid.prototype.set resizeMethod): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSkip service workers tests on Windows.
pvollan@apple.com [Mon, 28 Aug 2017 19:48:58 +0000 (19:48 +0000)]
Skip service workers tests on Windows.

Unreviewed test gardening.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoFixed expectations for http/tests/loading/basic-auth-remove-credentials.html by remov...
jlewis3@apple.com [Mon, 28 Aug 2017 19:05:10 +0000 (19:05 +0000)]
Fixed expectations for http/tests/loading/basic-auth-remove-credentials.html by removing double expectations

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRebaseline js/dom/global-constructors-attributes.html after r221209.
ryanhaddad@apple.com [Mon, 28 Aug 2017 18:40:33 +0000 (18:40 +0000)]
Rebaseline js/dom/global-constructors-attributes.html after r221209.

Unreviewed test gardening..

* platform/mac-highsierra-wk1/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-highsierra/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd WKUIDelegatePrivate equivalent of WKPageUIClient's didExceedBackgroundResourceLim...
achristensen@apple.com [Mon, 28 Aug 2017 18:20:49 +0000 (18:20 +0000)]
Add WKUIDelegatePrivate equivalent of WKPageUIClient's didExceedBackgroundResourceLimitWhileInForeground
https://bugs.webkit.org/show_bug.cgi?id=176028
<rdar://problem/29270035>

Reviewed by Andy Estes.

An API test for this did not succeed with either the memory or CPU limit calls,
possibly because the app must be in the foreground for this call to be made.

* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
* UIProcess/Cocoa/UIDelegate.h:
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::toWKResourceLimit):
(WebKit::UIDelegate::UIClient::didExceedBackgroundResourceLimitWhileInForeground):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoFix document-create-touch.html.
commit-queue@webkit.org [Mon, 28 Aug 2017 16:52:48 +0000 (16:52 +0000)]
Fix document-create-touch.html.
https://bugs.webkit.org/show_bug.cgi?id=172813

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-28
Reviewed by Michael Catanzaro.

The document.createTouch() call is supposed to throw an exception (as
defined by WebIDL). It has been doing this since r203941, but this
wasn't noticed because the entire fast/events/touch folder is skipped
on mac, ios and win.

* fast/events/touch/document-create-touch-expected.txt:
* fast/events/touch/document-create-touch.html:
* platform/gtk/TestExpectations:
* platform/gtk/fast/events/touch/document-create-touch-expected.txt: Removed.
* platform/wpe/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] [WPE] Rename EventHandlerGlib to EventHandlerGLib
clopez@igalia.com [Mon, 28 Aug 2017 16:37:31 +0000 (16:37 +0000)]
[GTK] [WPE] Rename EventHandlerGlib to EventHandlerGLib
https://bugs.webkit.org/show_bug.cgi?id=175864

Unreviewed cosmetic follow-up patch after r221075.

No new tests. No change in behavior.

* PlatformGTK.cmake:
* PlatformWPE.cmake:
* platform/glib/EventHandlerGLib.cpp: Renamed from Source/WebCore/platform/glib/EventHandlerGlib.cpp.
(WebCore::EventHandler::tabsToAllFormControls const):
(WebCore::EventHandler::focusDocumentView):
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::passMouseDownEventToWidget):
(WebCore::EventHandler::eventActivatedView const):
(WebCore::EventHandler::widgetDidHandleWheelEvent):
(WebCore::EventHandler::createDraggingDataTransfer const):
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
(WebCore::EventHandler::accessKeyModifiers):
(WebCore::EventHandler::shouldTurnVerticalTicksIntoHorizontal const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRebaseline js/dom/global-constructors-attributes.html after r221209.
ryanhaddad@apple.com [Mon, 28 Aug 2017 15:50:10 +0000 (15:50 +0000)]
Rebaseline js/dom/global-constructors-attributes.html after r221209.

Unreviewed test gardening.

* platform/mac-elcapitan-wk2/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed GTK/WPE test gardening
mcatanzaro@igalia.com [Mon, 28 Aug 2017 15:29:44 +0000 (15:29 +0000)]
Unreviewed GTK/WPE test gardening

* platform/gtk/TestExpectations:
* platform/gtk/compositing/iframes/compositing-for-scrollable-iframe-expected.txt: Added.
* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
* platform/wpe/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWebDriver: implement screen capture commands
carlosgc@webkit.org [Mon, 28 Aug 2017 13:55:10 +0000 (13:55 +0000)]
WebDriver: implement screen capture commands
https://bugs.webkit.org/show_bug.cgi?id=174615

Reviewed by Brian Burg.

Source/WebDriver:

Implement takeScreenshot and takeElementScreenshot commands.

19. Screen Capture.
https://w3c.github.io/webdriver/webdriver-spec.html#screen-capture

* CommandResult.cpp:
(WebDriver::CommandResult::CommandResult): Handle ScreenshotError protocol error.
(WebDriver::CommandResult::httpStatusCode const): Add UnableToCaptureScreen.
(WebDriver::CommandResult::errorString const): Ditto.
* CommandResult.h:
* Session.cpp:
(WebDriver::Session::takeScreenshot):
* Session.h:
* WebDriverService.cpp:
(WebDriver::WebDriverService::takeScreenshot):
(WebDriver::WebDriverService::takeElementScreenshot):
* WebDriverService.h:

Source/WebKit:

Extend takeScreenshot command to optionally take a screenshot of an element. When no element is provided, the
screenshot is taken from the page visible area.

* PlatformGTK.cmake: Add WebAutomationSessionCairo.cpp to compilation.
* PlatformWPE.cmake: Ditto.
* UIProcess/Automation/Automation.json: Add ScreenshotError and several optional parameters to takeScreenshot.
* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::takeScreenshot): Receive optional frame, node and scrollIntoView that are
checked and passed to the web process.
* UIProcess/Automation/WebAutomationSession.h:
* UIProcess/Automation/cairo/WebAutomationSessionCairo.cpp: Added.
(WebKit::WebAutomationSession::platformGetBase64EncodedPNGData): Cairo implementation.
* UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:
* WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::snapshotRectForScreenshot): Helper to get the rectangle to be used for a screenshot.
(WebKit::WebAutomationSessionProxy::takeScreenshot): If a node handle is provided take the snapshot using the
element rectangle, otherwise use the page visible content rectangle.
* WebProcess/Automation/WebAutomationSessionProxy.h:
* WebProcess/Automation/WebAutomationSessionProxy.messages.in: Update TakeSnapshot message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAutomation: takeScreenshot should use the visible content rect not the document rect
carlosgc@webkit.org [Mon, 28 Aug 2017 12:32:34 +0000 (12:32 +0000)]
Automation: takeScreenshot should use the visible content rect not the document rect
https://bugs.webkit.org/show_bug.cgi?id=175665

Reviewed by Brian Burg.

According to the spec, we should get the toplevel browsing context document rectangle and take a screenshot of
it using the current viewport width and height. We are currently using the document size.

19. Screen Capture.
https://w3c.github.io/webdriver/webdriver-spec.html#dfn-draw-a-bounding-box-from-the-framebuffer

* WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::WebAutomationSessionProxy::takeScreenshot): Use FrameView::visibleContentRect().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWebDriver: implement cookies commands
carlosgc@webkit.org [Mon, 28 Aug 2017 11:52:55 +0000 (11:52 +0000)]
WebDriver: implement cookies commands
https://bugs.webkit.org/show_bug.cgi?id=174613

Reviewed by Brian Burg.

Add cookies commands.

16. Cookies.
https://w3c.github.io/webdriver/webdriver-spec.html#cookies

* CommandResult.cpp:
(WebDriver::CommandResult::httpStatusCode const): Add NoSuchCookie error.
(WebDriver::CommandResult::errorString const): Ditto.
* CommandResult.h:
* Session.cpp:
(WebDriver::parseAutomationCookie): Parse JSON cookie object returned by automation and convert it to a Cookie struct.
(WebDriver::builtAutomationCookie): Build a JSON cookie object as expected by automation from a Cookie struct.
(WebDriver::serializeCookie): Serialize a Cookie struct into a JSON cookie object according to the WebDriver spec.
(WebDriver::Session::getAllCookies):
(WebDriver::Session::getNamedCookie):
(WebDriver::Session::addCookie):
(WebDriver::Session::deleteCookie):
(WebDriver::Session::deleteAllCookies):
* Session.h:
* WebDriverService.cpp:
(WebDriver::WebDriverService::getAllCookies):
(WebDriver::WebDriverService::getNamedCookie):
(WebDriver::deserializeCookie):
(WebDriver::WebDriverService::addCookie):
(WebDriver::WebDriverService::deleteCookie):
(WebDriver::WebDriverService::deleteAllCookies):
* WebDriverService.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoEnsure that the alert function is called in TestWebExtensions.
commit-queue@webkit.org [Mon, 28 Aug 2017 11:46:14 +0000 (11:46 +0000)]
Ensure that the alert function is called in TestWebExtensions.
https://bugs.webkit.org/show_bug.cgi?id=175880

Patch by Ms2ger <Ms2ger@gmail.com> on 2017-08-28
Reviewed by Carlos Garcia Campos.

The test relied on a bug in the HTMLDocument JavaScript bindings: when calling
document.open() with three arguments, it would call any function set as the
"open" property on the window object, rather than just the real Window::open()
method. This bug was fixed by the removal of custom bindings for HTMLDocument
in r218437. As a result, the test no longer called alert(), which caused it to
fail.

Instead, call the window.open() function directly.

* TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
(testWebExtensionIsolatedWorld):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoNew baseline for insecure-audio-video-in-main-frame.html should apply to all ports
mcatanzaro@igalia.com [Mon, 28 Aug 2017 11:23:13 +0000 (11:23 +0000)]
New baseline for insecure-audio-video-in-main-frame.html should apply to all ports

The global baseline was never updated because the test has been failing on macOS.

* http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt:
* platform/gtk/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK][WPE] ASSERTION FAILED: !isOpen() in WebKit::IconDatabase::~IconDatabase()
carlosgc@webkit.org [Mon, 28 Aug 2017 11:18:25 +0000 (11:18 +0000)]
[GTK][WPE] ASSERTION FAILED: !isOpen() in WebKit::IconDatabase::~IconDatabase()
https://bugs.webkit.org/show_bug.cgi?id=175719

Reviewed by Michael Catanzaro.

This is happening always when running /webkit2/WebKitFaviconDatabase/favicon-database-test in debug builds. The
last step we do is removing all icons, then the test finishes, which destroys the WebKitFaviconDatabase object
that closes the icon database on dispose. The problem is that removing all icons schedules a main thread
notification and IconDatabase is not considered closed until all main thread callbacks have been dispatched. This
is never going to happen in the test, because the main loop is no longer running at that point. I don't think
it's worth it to consider the database open while main thread callbacks are pending, they are just notifications
and the client is no longer insterested on them afer closing the database. I think it's bettter and simpler to
simply cancel the pending callbacks on database close. That ensures that isOpen() after close() is always
false. This patch adds a helper private class to schedule notifications to the main thread that can be cancelled
on database close. It also removes the didClose() notification because it was unused and because it's pointless
now that we know the database is closed after close().

* UIProcess/API/glib/IconDatabase.cpp:
(WebKit::IconDatabase::open): Mark the main thread notifier as active.
(WebKit::IconDatabase::close): Mark the main thread notifier as not active.
(WebKit::IconDatabase::IconDatabase): Remove m_mainThreadCallbackCount initialization.
(WebKit::IconDatabase::isOpen const): Do what isOpenBesidesMainThreadCallbacks() used to do.
(WebKit::IconDatabase::removeAllIconsOnThread): Remove the notification because it's currently unused.
(WebKit::IconDatabase::dispatchDidImportIconURLForPageURLOnMainThread): Use MainThreadNotifier.
(WebKit::IconDatabase::dispatchDidImportIconDataForPageURLOnMainThread): Ditto.
(WebKit::IconDatabase::dispatchDidFinishURLImportOnMainThread): Ditto.
(WebKit::IconDatabase::isOpenBesidesMainThreadCallbacks const): Deleted.
(WebKit::IconDatabase::checkClosedAfterMainThreadCallback): Deleted.
(WebKit::IconDatabase::dispatchDidRemoveAllIconsOnMainThread): Deleted.
* UIProcess/API/glib/IconDatabase.h:
(WebKit::IconDatabaseClient::didChangeIconForPageURL):
(WebKit::IconDatabaseClient::didFinishURLImport):
(WebKit::IconDatabase::MainThreadNotifier::MainThreadNotifier):
(WebKit::IconDatabase::MainThreadNotifier::setActive):
(WebKit::IconDatabase::MainThreadNotifier::notify):
(WebKit::IconDatabase::MainThreadNotifier::stop):
(WebKit::IconDatabase::MainThreadNotifier::timerFired):
(WebKit::IconDatabaseClient::didRemoveAllIcons): Deleted.
(WebKit::IconDatabaseClient::didClose): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] Rebaseline insecure-audio-video-in-main-frame.html.
commit-queue@webkit.org [Mon, 28 Aug 2017 11:02:56 +0000 (11:02 +0000)]
[GTK] Rebaseline insecure-audio-video-in-main-frame.html.
https://bugs.webkit.org/show_bug.cgi?id=142482

Unreviewed test gardening.

The test is failing due to a different console message. It seems better
to add a platform-specific baseline so we can catch actual failures.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-28

* platform/gtk/TestExpectations:
* platform/gtk/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] Enable userAgentShadowDOM tests.
commit-queue@webkit.org [Mon, 28 Aug 2017 10:20:22 +0000 (10:20 +0000)]
[GTK] Enable userAgentShadowDOM tests.
https://bugs.webkit.org/show_bug.cgi?id=176015

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-28

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WebCrypto] Push WorkQueue dispatches for AES algorithms into shared code
zandobersek@gmail.com [Mon, 28 Aug 2017 08:16:07 +0000 (08:16 +0000)]
[WebCrypto] Push WorkQueue dispatches for AES algorithms into shared code
https://bugs.webkit.org/show_bug.cgi?id=175539

Reviewed by Sam Weinig.

Push the WorkQueue dispatch code and other code duplicated between the
Mac and libgcrypt implementations of Web Crypto into the shared layer.
This patch focuses on the AES-based algorithms.

Functions with platform-specific implementations that are invoked from
these asynchronous dispatches are made static and return an ExceptionOr
value. CryptoAlgorithmParameters objects are passed through non-const
references because data getters could lazily construct the underlying
Vector objects. CryptoKey objects are passed through const references.
Implementations can then manually retrieve and further validate any key
or parameter data, as required for that specific implementation. Input
data is passed through const references to the original Vector objects.

No new tests -- no changes in behavior that's covered by existing tests.

* crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):
* crypto/algorithms/CryptoAlgorithmAES_CBC.h:
* crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:
(WebCore::CryptoAlgorithmAES_CFB::encrypt):
(WebCore::CryptoAlgorithmAES_CFB::decrypt):
* crypto/algorithms/CryptoAlgorithmAES_CFB.h:
* crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:
(WebCore::CryptoAlgorithmAES_CTR::encrypt):
(WebCore::CryptoAlgorithmAES_CTR::decrypt):
* crypto/algorithms/CryptoAlgorithmAES_CTR.h:
* crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:
(WebCore::CryptoAlgorithmAES_GCM::encrypt):
(WebCore::CryptoAlgorithmAES_GCM::decrypt):
* crypto/algorithms/CryptoAlgorithmAES_GCM.h:
* crypto/algorithms/CryptoAlgorithmAES_KW.cpp:
(WebCore::CryptoAlgorithmAES_KW::wrapKey):
(WebCore::CryptoAlgorithmAES_KW::unwrapKey):
* crypto/algorithms/CryptoAlgorithmAES_KW.h:
* crypto/gcrypt/CryptoAlgorithmAES_CBCGCrypt.cpp:
(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):
* crypto/gcrypt/CryptoAlgorithmAES_CFBGCrypt.cpp:
(WebCore::CryptoAlgorithmAES_CFB::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CFB::platformDecrypt):
* crypto/gcrypt/CryptoAlgorithmAES_CTRGCrypt.cpp:
(WebCore::CryptoAlgorithmAES_CTR::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CTR::platformDecrypt):
* crypto/gcrypt/CryptoAlgorithmAES_GCMGCrypt.cpp:
(WebCore::gcryptEncrypt):
(WebCore::gcryptDecrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformEncrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):
* crypto/gcrypt/CryptoAlgorithmAES_KWGCrypt.cpp:
(WebCore::CryptoAlgorithmAES_KW::platformWrapKey):
(WebCore::CryptoAlgorithmAES_KW::platformUnwrapKey):
* crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:
(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):
* crypto/mac/CryptoAlgorithmAES_CFBMac.cpp:
(WebCore::CryptoAlgorithmAES_CFB::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CFB::platformDecrypt):
* crypto/mac/CryptoAlgorithmAES_CTRMac.cpp:
(WebCore::CryptoAlgorithmAES_CTR::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CTR::platformDecrypt):
* crypto/mac/CryptoAlgorithmAES_GCMMac.cpp:
(WebCore::CryptoAlgorithmAES_GCM::platformEncrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):
* crypto/mac/CryptoAlgorithmAES_KWMac.cpp:
(WebCore::CryptoAlgorithmAES_KW::platformWrapKey):
(WebCore::CryptoAlgorithmAES_KW::platformUnwrapKey):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoPicking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput...
wenson_hsieh@apple.com [Mon, 28 Aug 2017 05:12:56 +0000 (05:12 +0000)]
Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
https://bugs.webkit.org/show_bug.cgi?id=170955
<rdar://problem/31697653>

Reviewed by Ryosuke Niwa.

Source/WebKit:

Currently, we insert text with TextEventInputAutocompletion as the text event input type if any text range to
replace was specified by the platform. Instead, limit this only to when the text replacement range is not empty.
This more closely matches the intention of the spec, which states that the "insertReplacementText" inputType
should be used when "[replacing] existing text by means of a spell checker, auto-correct or similar".

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::insertTextAsync):

Source/WebKitLegacy/mac:

Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
text is being replaced.

* WebView/WebHTMLView.mm:
(-[WebHTMLView insertText:]):

Tools:

Replace UIScriptController.insertText with UIScriptController.replaceTextAtRange, and implement
replaceTextAtRange in WebKit1. See corresponding layout tests (input-event-insert-replacement.html and
before-input-prevent-insert-replacement.html) for more detail.

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/mac/AppKitTestSPI.h: Added.

Introduce an SPI header for private AppKit headers needed to support DumpRenderTree.

* DumpRenderTree/mac/UIScriptControllerMac.mm:
(WTR::UIScriptController::replaceTextAtRange):
(WTR::UIScriptController::insertText): Deleted.
* TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
* TestRunnerShared/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::replaceTextAtRange):
(WTR::UIScriptController::insertText): Deleted.
* TestRunnerShared/UIScriptContext/UIScriptController.h:
* WebKitTestRunner/mac/UIScriptControllerMac.mm:
(WTR::UIScriptController::replaceTextAtRange):
(WTR::UIScriptController::insertText): Deleted.

Replace UIScriptController.insertText with UIScriptController.replaceTextAtRange, which better describes the
behavior of this function.

LayoutTests:

Augments two existing layout tests to check for additional cases of inserting text with replacement ranges.
Also enables this test for WebKit1 on Mac. Both these tests are currently enabled only for WebKit2, and also only
check the case where we're replacing an existing non-empty range of text.

* fast/events/before-input-prevent-insert-replacement-expected.txt:
* fast/events/before-input-prevent-insert-replacement.html:
* fast/events/input-event-insert-replacement-expected.txt:
* fast/events/input-event-insert-replacement.html:

Tests for cases of replacing existing text ranges, and inserting text at a position.

* platform/mac-wk1/TestExpectations:
* resources/ui-helper.js:

Add a new UIHelper function to insert text at a given replacement range. This codepath is taken when selecting
an emoji using the emoji picker menu on Mac, and also when selecting a dead key option after holding down on a
vowel key.

(window.UIHelper.replaceTextAtRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[iOS WK2] Web process crashes after changing selection to the end of the document...
wenson_hsieh@apple.com [Mon, 28 Aug 2017 01:22:55 +0000 (01:22 +0000)]
[iOS WK2] Web process crashes after changing selection to the end of the document when speaking a selection
https://bugs.webkit.org/show_bug.cgi?id=176011
<rdar://problem/32614095>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Adds a null check to visiblePositionForPositionWithOffset. This is a crash point for accessibility codepaths,
since indexForVisiblePosition is not guaranteed to set the given `root` outparam to a non-null value, yet
visiblePositionForIndex requires root to be non-null. This causes a crash when selecting some text, hitting
'Speak', and then changing the selection to somewhere near the end of the document, since accessibility code
will attempt to speak words at an offset past the end of the document. While this is a bug in and of itself, the
web process should still handle this case gracefully and not crash. To fix this, we simply bail and return a
null VisiblePosition if a root container node was not found.

Currently, visiblePositionForPositionWithOffset is implemented twice, in WebCore (AXObjectCache.cpp) and also in
WebKit (WebPageIOS.mm), as identical static functions. This patch moves this helper into Editing.cpp and removes
it from AXObjectCache and WebPageIOS.

Tests: AccessibilityTests.RectsForSpeakingSelectionBasic
       AccessibilityTests.RectsForSpeakingSelectionWithLineWrapping
       AccessibilityTests.RectsForSpeakingSelectionDoNotCrashWhenChangingSelection

* accessibility/AXObjectCache.cpp:
(WebCore::visiblePositionForPositionWithOffset): Deleted.
* editing/Editing.cpp:
(WebCore::visiblePositionForPositionWithOffset):
* editing/Editing.h:

Source/WebKit:

Adds an SPI hook to test accessibility codepaths when speaking selected content. This patch does some minor
refactoring by introducing _accessibilityRetrieveRectsAtSelectionOffset:withText:completionHandler:, which takes
and invokes a completion handler block. The existing _accessibilityRetrieveRectsAtSelectionOffset:withText:
method simply turns around and calls the former variant with `nil` as a completion handler.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _accessibilityRetrieveRectsAtSelectionOffset:withText:completionHandler:]):
* UIProcess/API/Cocoa/WKWebViewPrivate.h:
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _accessibilityRetrieveRectsAtSelectionOffset:withText:]):
(-[WKContentView _accessibilityRetrieveRectsAtSelectionOffset:withText:completionHandler:]):
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::visiblePositionForPositionWithOffset): Deleted.

Tools:

Introduces AccessibilityTests, and adds three new tests that traverse selection-rect-finding codepaths when
speaking selected content. See WebKit and WebCore ChangeLogs for more detail.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm: Added.
(-[WKWebView rectsAtSelectionOffset:withText:]):
(checkCGRectValueAtIndex):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Record actions performed on WebGLRenderingContext
webkit@devinrousso.com [Sun, 27 Aug 2017 16:12:39 +0000 (16:12 +0000)]
Web Inspector: Record actions performed on WebGLRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=174483
<rdar://problem/34040722>

Reviewed by Matt Baker.

Source/JavaScriptCore:

* inspector/protocol/Recording.json:
* inspector/scripts/codegen/generator.py:
Add type and mapping for WebGL: "canvas-webgl" => CanvasWebGL

Source/WebCore:

Tests: inspector/canvas/recording-webgl.html
       inspector/canvas/recording-webgl-snapshots.html

* bindings/js/CallTracerTypes.h:
Add types for WebGL parameters.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateAttributeSetterBodyDefinition):
(GenerateImplementationFunctionCall):
(GenerateCallTracerParameter):
Modify the generated code for `CallTracingCallback` so that optional/nullable types are only
dereferenced if they have a value.

* html/canvas/WebGLRenderingContext.idl:
Add `CallTracingCallback` to interface to record all API calls.

* inspector/InspectorCanvas.h:
* inspector/InspectorCanvas.cpp:
(WebCore::InspectorCanvas::resetRecordingData):
(WebCore::shouldSnapshotWebGLAction):
(WebCore::InspectorCanvas::recordAction):
(WebCore::InspectorCanvas::releaseInitialState):
(WebCore::InspectorCanvas::releaseFrames):
(WebCore::InspectorCanvas::appendActionSnapshotIfNeeded):
(WebCore::InspectorCanvas::getCanvasContentAsDataURL):
(WebCore::InspectorCanvas::buildInitialState):
(WebCore::InspectorCanvas::buildAction):
For all non-primitive WebGL objects, send a string corresponding to the object's name. The
value isn't needed since the preview will be generated by the `toDataURL` snapshots taken
after every visual action.

* inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::didFinishRecordingCanvasFrame):

* bindings/scripts/test/TestCallTracer.idl:
* bindings/scripts/test/JS/JSTestCallTracer.cpp:
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableVariantArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableVariantArgument):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithOptionalVariantArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithOptionalVariantArgument):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithDefaultVariantArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithDefaultVariantArgument):

Source/WebInspectorUI:

* UserInterface/Models/Recording.js:
(WI.Recording):
(WI.Recording.fromPayload):
(WI.Recording.prototype.swizzle):
Add swizzle types for WebGL parameters.

* UserInterface/Models/RecordingAction.js:
(WI.RecordingAction):
(WI.RecordingAction.fromPayload):
(WI.RecordingAction.prototype.get snapshot):
(WI.RecordingAction.prototype.swizzle):
(WI.RecordingAction.prototype.toJSON):
Include an optional fourth parameter `snapshot` that will be sent for visual actions when
recording WebGL canvas contexts.

* UserInterface/Views/RecordingContentView.js:
(WI.RecordingContentView):
(WI.RecordingContentView.prototype.get navigationItems):
(WI.RecordingContentView.prototype.updateActionIndex):
(WI.RecordingContentView.prototype.shown):
(WI.RecordingContentView.prototype._generateContentCanvasWebGL):
* UserInterface/Views/RecordingContentView.css:
(.content-view:not(.tab).recording :matches(img, canvas)):
(.content-view:not(.tab).recording canvas): Deleted.
Instead of regenerating the canvas context in the WebInspector frontend, just display the
snapshot image for the last visual action.

* UserInterface/Views/CanvasContentView.js:
(WI.CanvasContentView):

* UserInterface/Views/RecordingActionTreeElement.js:
(WI.RecordingActionTreeElement._generateDOM):

LayoutTests:

* inspector/canvas/recording-webgl-expected.txt: Added.
* inspector/canvas/recording-webgl.html: Added.

* inspector/canvas/recording-webgl-snapshots-expected.txt: Added.
* inspector/canvas/recording-webgl-snapshots.html: Added.
Created separate test for checking that snapshots differ so that each test doesn't interfere
with the results of the other tests.

* inspector/canvas/recording-2d-expected.html:
* inspector/canvas/recording-2d.html:
Drive by: change naming to match inspector/canvas/recording-webgl.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoREGRESSION (r220105): Storage service appears in macOS Activity Monitor as “localized...
mitz@apple.com [Sun, 27 Aug 2017 00:08:50 +0000 (00:08 +0000)]
REGRESSION (r220105): Storage service appears in macOS Activity Monitor as “localized string not found”
https://bugs.webkit.org/show_bug.cgi?id=176007

Reviewed by Tim Horton.

* English.lproj/Localizable.strings: Updated using update-webkit-localizable-strings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoBuild fix. Creating trying a test group no longer updates the page.
rniwa@webkit.org [Sat, 26 Aug 2017 23:26:16 +0000 (23:26 +0000)]
Build fix. Creating trying a test group no longer updates the page.

* public/v3/models/test-group.js:
(TestGroup.createWithCustomConfiguration): Added the missing ignoreCache=true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed gardening, mark a test as still failing
mcatanzaro@igalia.com [Sat, 26 Aug 2017 19:09:24 +0000 (19:09 +0000)]
Unreviewed gardening, mark a test as still failing

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove PolicyChecker::cancelCheck
commit-queue@webkit.org [Sat, 26 Aug 2017 16:58:22 +0000 (16:58 +0000)]
Remove PolicyChecker::cancelCheck
https://bugs.webkit.org/show_bug.cgi?id=176002

Patch by Alex Christensen <achristensen@webkit.org> on 2017-08-26
Reviewed by Darin Adler.

cancelCheck is conceptually equivalent to not calling a completion handler.
stopCheck is conceptually equivalent to calling a completion handler with PolicyIgnore just before cleaning up everything,
which is semantically cleaner and necessary when I replace the last use of PolicyCallback with a CompletionHandler.
Before this change, we were probably causing some loading objects to hang right before deleting them, and this cleans them up better.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::cancelPolicyCheckIfNeeded):
* loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::cancelCheck): Deleted.
* loader/PolicyChecker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, tighten up scope of variable in previous commit
mcatanzaro@igalia.com [Sat, 26 Aug 2017 16:54:35 +0000 (16:54 +0000)]
Unreviewed, tighten up scope of variable in previous commit

* platform/network/soup/CookieJarSoup.cpp:
(WebCore::cookiesForSession):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[SOUP] Update cookie jar implementation to filter out secure cookies
mcatanzaro@igalia.com [Sat, 26 Aug 2017 16:49:59 +0000 (16:49 +0000)]
[SOUP] Update cookie jar implementation to filter out secure cookies
https://bugs.webkit.org/show_bug.cgi?id=175850

Reviewed by Brent Fulgham.

Source/WebCore:

Filter out secure cookies when indicated.

* platform/network/soup/CookieJarSoup.cpp:
(WebCore::cookiesForSession):
(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::getRawCookies):

LayoutTests:

Unskip newly-passing tests.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, suppress warnings in GTK port
utatane.tea@gmail.com [Sat, 26 Aug 2017 08:40:49 +0000 (08:40 +0000)]
Unreviewed, suppress warnings in GTK port

Source/JavaScriptCore:

The "block" variable hides the argument variable.

* dfg/DFGLiveCatchVariablePreservationPhase.cpp:
(JSC::DFG::LiveCatchVariablePreservationPhase::isValidFlushLocation):

Source/WTF:

Add printf format attribute.

* wtf/text/WTFString.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[EME][GStreamer] Connect CDM to GStreamer
calvaris@igalia.com [Sat, 26 Aug 2017 08:29:00 +0000 (08:29 +0000)]
[EME][GStreamer] Connect CDM to GStreamer
https://bugs.webkit.org/show_bug.cgi?id=175983

Reviewed by Žan Doberšek.

This is still a version that will need some changes for some other
use cases but it should be enough to begin with some passes in the
tests and some basic use cases.

We use the attach CDMInstance interface in the private player to
get the instance in time for the initializationDataEncountered
event, which is handled when the demuxer reports synchronously the
events even before configuring the decryptors. We wait there in
case we don't have the CDMInstance attached (which contains info
about the key system now) and when we get it we report it back to
the demuxer and continue sending the event.

We also handled the events when handled by the decryptors but for
now this will remain a FIXME. The events handled by the
AppendPipeline will end up here too for now.

The CDM instance is created with the key system because some CDMs
can handle more than one, not ClearKey yet but others in the
(near) future.

MockCDMFactory is adapted to the changes as expected.

* Modules/encryptedmedia/CDM.cpp:
(WebCore::CDM::CDM):
* platform/encryptedmedia/CDMFactory.h:
* platform/encryptedmedia/CDMInstance.h:
* platform/encryptedmedia/clearkey/CDMClearKey.cpp:
(WebCore::CDMFactoryClearKey::createCDM):
(WebCore::CDMInstanceClearKey::keySystem const):
* platform/encryptedmedia/clearkey/CDMClearKey.h:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
(WebCore::extractEventsAndSystemsFromMessage):
(WebCore::MediaPlayerPrivateGStreamerBase::handleSyncMessage):
(WebCore::MediaPlayerPrivateGStreamerBase::cdmInstanceAttached):
(WebCore::MediaPlayerPrivateGStreamerBase::cdmInstanceDetached):
(WebCore::MediaPlayerPrivateGStreamerBase::attemptToDecryptWithInstance):
(WebCore::MediaPlayerPrivateGStreamerBase::attemptToDecryptWithLocalInstance):
(WebCore::MediaPlayerPrivateGStreamerBase::dispatchDecryptionKey):
(WebCore::MediaPlayerPrivateGStreamerBase::handleProtectionEvent):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::appendPipelineElementMessageCallback):
(WebCore::AppendPipeline::AppendPipeline):
(WebCore::AppendPipeline::~AppendPipeline):
(WebCore::AppendPipeline::handleNeedContextSyncMessage):
(WebCore::AppendPipeline::handleElementMessage):
(WebCore::AppendPipeline::handleAppsrcNeedDataReceived):
(WebCore::AppendPipeline::appsinkNewSample):
* platform/graphics/gstreamer/mse/AppendPipeline.h:
* testing/MockCDMFactory.cpp:
(WebCore::MockCDMFactory::createCDM):
(WebCore::MockCDMInstance::keySystem const):
* testing/MockCDMFactory.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMerge WeakMapData into JSWeakMap and JSWeakSet
utatane.tea@gmail.com [Sat, 26 Aug 2017 08:01:24 +0000 (08:01 +0000)]
Merge WeakMapData into JSWeakMap and JSWeakSet
https://bugs.webkit.org/show_bug.cgi?id=143919

Reviewed by Darin Adler.

This patch changes WeakMapData from JSCell to JSDestructibleObject,
renaming it to WeakMapBase, and JSWeakMap and JSWeakSet simply inherit
it instead of separately allocating WeakMapData. This reduces memory
consumption and allocation times.

Also this patch a bit optimizes sizeof(DeadKeyCleaner) by dropping m_target
field. Since this class is always embedded in WeakMapBase, we can calculate
WeakMapBase address from the address of DeadKeyCleaner.

This patch does not include the optimization changing WeakMapData to Set
for JSWeakSet.

* CMakeLists.txt:
* JavaScriptCore.xcodeproj/project.pbxproj:
* inspector/JSInjectedScriptHost.cpp:
(Inspector::JSInjectedScriptHost::weakMapSize):
(Inspector::JSInjectedScriptHost::weakMapEntries):
(Inspector::JSInjectedScriptHost::weakSetSize):
(Inspector::JSInjectedScriptHost::weakSetEntries):
* runtime/JSWeakMap.cpp:
(JSC::JSWeakMap::finishCreation): Deleted.
(JSC::JSWeakMap::visitChildren): Deleted.
* runtime/JSWeakMap.h:
(JSC::JSWeakMap::createStructure): Deleted.
(JSC::JSWeakMap::create): Deleted.
(JSC::JSWeakMap::weakMapData): Deleted.
(JSC::JSWeakMap::JSWeakMap): Deleted.
* runtime/JSWeakSet.cpp:
(JSC::JSWeakSet::finishCreation): Deleted.
(JSC::JSWeakSet::visitChildren): Deleted.
* runtime/JSWeakSet.h:
(JSC::JSWeakSet::createStructure): Deleted.
(JSC::JSWeakSet::create): Deleted.
(JSC::JSWeakSet::weakMapData): Deleted.
(JSC::JSWeakSet::JSWeakSet): Deleted.
* runtime/VM.cpp:
(JSC::VM::VM):
* runtime/VM.h:
* runtime/WeakMapBase.cpp: Renamed from Source/JavaScriptCore/runtime/WeakMapData.cpp.
(JSC::WeakMapBase::WeakMapBase):
(JSC::WeakMapBase::destroy):
(JSC::WeakMapBase::estimatedSize):
(JSC::WeakMapBase::visitChildren):
(JSC::WeakMapBase::set):
(JSC::WeakMapBase::get):
(JSC::WeakMapBase::remove):
(JSC::WeakMapBase::contains):
(JSC::WeakMapBase::clear):
(JSC::WeakMapBase::DeadKeyCleaner::target):
(JSC::WeakMapBase::DeadKeyCleaner::visitWeakReferences):
(JSC::WeakMapBase::DeadKeyCleaner::finalizeUnconditionally):
* runtime/WeakMapBase.h: Renamed from Source/JavaScriptCore/runtime/WeakMapData.h.
(JSC::WeakMapBase::size const):
* runtime/WeakMapPrototype.cpp:
(JSC::getWeakMap):
(JSC::protoFuncWeakMapDelete):
(JSC::protoFuncWeakMapGet):
(JSC::protoFuncWeakMapHas):
(JSC::protoFuncWeakMapSet):
(JSC::getWeakMapData): Deleted.
* runtime/WeakSetPrototype.cpp:
(JSC::getWeakSet):
(JSC::protoFuncWeakSetDelete):
(JSC::protoFuncWeakSetHas):
(JSC::protoFuncWeakSetAdd):
(JSC::getWeakMapData): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WebCrypto] Push WorkQueue dispatches for RSA algorithms into shared code
zandobersek@gmail.com [Sat, 26 Aug 2017 07:48:19 +0000 (07:48 +0000)]
[WebCrypto] Push WorkQueue dispatches for RSA algorithms into shared code
https://bugs.webkit.org/show_bug.cgi?id=175621

Reviewed by Darin Adler.

Push the WorkQueue dispatch code and other code duplicated between the
Mac and libgcrypt implementations of Web Crypto into the shared layer.
This patch focuses on the RSA-based algorithms.

The WorkQueue dispatch code is condensed into two static functions on
the CryptoAlgorithm class, the first variation handling VectorCallback
as the callback type and the other handling BoolCallback. The operation
is kept in a WTF::Function<> object that returns an ExceptionOr<> value
embedding either a Vector<uint8_t> object or a boolean value, as
appropriate for the callback type.

Functions with platform-specific implementations that are invoked from
these asynchronous dispatches are made static and return an ExceptionOr
value. CryptoAlgorithmParameters objects are passed through non-const
references because data getters could lazily construct the underlying
Vector objects. CryptoKey objects are passed through const references.
Implementations can then manually retrieve and further validate any key
or parameter data, as required for that specific implementation. Input
data is passed through const references to the original Vector objects.

No new tests -- no changes in behavior that's covered by existing tests.

* crypto/CryptoAlgorithm.cpp:
(WebCore::dispatchOperationImpl):
(WebCore::CryptoAlgorithm::dispatchOperation):
* crypto/CryptoAlgorithm.h:
* crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::encrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::decrypt):
* crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h:
* crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):
* crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
* crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:
(WebCore::CryptoAlgorithmRSA_OAEP::encrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::decrypt):
* crypto/algorithms/CryptoAlgorithmRSA_OAEP.h:
* crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:
(WebCore::CryptoAlgorithmRSA_PSS::sign):
(WebCore::CryptoAlgorithmRSA_PSS::verify):
* crypto/algorithms/CryptoAlgorithmRSA_PSS.h:
* crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:
(WebCore::gcryptEncrypt):
(WebCore::gcryptDecrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):
* crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp:
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):
* crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:
(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):
* crypto/gcrypt/CryptoAlgorithmRSA_PSSGCrypt.cpp:
(WebCore::CryptoAlgorithmRSA_PSS::platformSign):
(WebCore::CryptoAlgorithmRSA_PSS::platformVerify):
* crypto/mac/CryptoAlgorithmRSAES_PKCS1_v1_5Mac.cpp:
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):
* crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):
* crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp:
(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):
* crypto/mac/CryptoAlgorithmRSA_PSSMac.cpp:
(WebCore::CryptoAlgorithmRSA_PSS::platformSign):
(WebCore::CryptoAlgorithmRSA_PSS::platformVerify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd Logger::logAlways
eric.carlson@apple.com [Sat, 26 Aug 2017 03:30:41 +0000 (03:30 +0000)]
Add Logger::logAlways
https://bugs.webkit.org/show_bug.cgi?id=175996

Reviewed by Jer Noble.

Source/WebCore/PAL:

* PAL.xcodeproj/project.pbxproj:
* pal/Logger.h:
(PAL::Logger::willLog const):
(PAL::Logger::willLog const):
(PAL::Logger::logAlways): Added.
(PAL::Logger::error const): Add missing WTF_ATTRIBUTE_PRINTF.
(PAL::Logger::warning const): Ditto.
(PAL::Logger::notice const): Ditto.
(PAL::Logger::info const): Ditto.
(PAL::Logger::debug const): Use String::formatWithArguments.

Source/WTF:

* wtf/Assertions.cpp:
* wtf/Assertions.h:

Tools:

* TestWebKitAPI/Tests/WebCore/Logging.cpp:
(TestWebKitAPI::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDisable saveDataToFile API test.
achristensen@apple.com [Sat, 26 Aug 2017 02:49:55 +0000 (02:49 +0000)]
Disable saveDataToFile API test.
https://bugs.webkit.org/show_bug.cgi?id=176000

* TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
The test was only working on High Sierra.  It needs investigation on older operating systems.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRename TestWebKitAPI/Tests/WebKit2* to WebKit* following Source directory rename.
achristensen@apple.com [Sat, 26 Aug 2017 01:43:56 +0000 (01:43 +0000)]
Rename TestWebKitAPI/Tests/WebKit2* to WebKit* following Source directory rename.

Rubber-stamped by Brady Eidson.

* TestWebKitAPI/PlatformGTK.cmake:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2Cocoa: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsPlugin.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsProtocol.h: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresourcePlugIn.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/DoAfterNextPresentationUpdateAfterCrash.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestBlobURL.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL2.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURLFrame.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/Geolocation.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/GeolocationGetCurrentPositionResult.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-1.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-3.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-1.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-2.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/InitialWarmedProcessUsed.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/LoadDataWithNilMIMEType.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageQuirkEnabled.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageQuirkTest.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/ObservedRenderingProgressEventsAfterCrash.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/PrepareForMoveToWindow.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsPlugIn.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsProtocol.h: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/RunOpenPanel.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorldPlugIn.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorldProtocol.h: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/VisibleContentRect.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/WKContentViewEditingActions.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFView.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDoesNotLogDuringInitialization.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewGetContents.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewSnapshot.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-1.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-2.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/apple.gif: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/attachment-element.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/autofocused-text-input.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-click.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-end.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/double-click-does-not-select-trailing-space.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/editable-body.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/enormous-video-with-sound.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/gif-and-file-input.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/image-in-link-and-input.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/input-field-in-scrollable-document.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/large-input-field-focus-onload.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/large-red-square.png: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/large-video-mutes-onplaying.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/large-video-offscreen.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/large-video-test-now-playing.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.mp4: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/offscreen-iframe-of-media-document.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/password-protected.pages: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/play-audio-on-click.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/rendered-image-excluding-overflow.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/rich-and-plain-text.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/silence-long.m4a: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/text-and-password-inputs.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/two-paragraph-contenteditable.html: Removed.
* TestWebKitAPI/Tests/WebKit2Cocoa/wide-autoplaying-video-with-audio.html: Removed.
* TestWebKitAPI/Tests/WebKit2Gtk: Removed.
* TestWebKitAPI/Tests/WebKit2Gtk/AccessibilityTestServer.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2Gtk/DOMClientRectTest.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2Gtk/TestDOMClientRect.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2Gtk/TestDOMDOMWindow.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2Gtk/TestEditor.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2Gtk/TestOptionMenu.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitVersion.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2ObjC: Removed.
* TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Removed.
* TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Removed.
* TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: Removed.
* TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm: Removed.
* TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm: Removed.
* TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm: Removed.
* TestWebKitAPI/Tests/WebKitCocoa: Copied from TestWebKitAPI/Tests/WebKit2Cocoa.
* TestWebKitAPI/Tests/WebKitGtk: Copied from TestWebKitAPI/Tests/WebKit2Gtk.
* TestWebKitAPI/Tests/WebKitObjC: Copied from TestWebKitAPI/Tests/WebKit2ObjC.
* TestWebKitAPI/glib/PlatformGTK.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRename TestWebKitAPI/Tests/WebKit2 to WebKit following Source directory rename.
achristensen@apple.com [Sat, 26 Aug 2017 00:54:53 +0000 (00:54 +0000)]
Rename TestWebKitAPI/Tests/WebKit2 to WebKit following Source directory rename.

Rubber-stamped by Brady Eidson.

* TestWebKitAPI/CMakeLists.txt:
* TestWebKitAPI/PlatformGTK.cmake:
* TestWebKitAPI/PlatformWin.cmake:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit: Copied from TestWebKitAPI/Tests/WebKit2.
* TestWebKitAPI/Tests/WebKit2: Removed.
* TestWebKitAPI/Tests/WebKit2/18-characters.html: Removed.
* TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/Ahem.ttf: Removed.
* TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/DeferredViewInWindowStateChange.mm: Removed.
* TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/EnvironmentUtilitiesTest.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/EventModifiers.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/Find.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Removed.
* TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/Geolocation.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: Removed.
* TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/LimitTitleSize.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Removed.
* TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/NavigationClientDefaultCrypto.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Removed.
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/PageGroup.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm: Removed.
* TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/ProcessDidTerminate.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/ResponsivenessTimer.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Removed.
* TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Removed.
* TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/WKString.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/WKThumbnailView.mm: Removed.
* TestWebKitAPI/Tests/WebKit2/WKURL.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/all-content-in-one-iframe.html: Removed.
* TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Removed.
* TestWebKitAPI/Tests/WebKit2/auto-submitting-form.html: Removed.
* TestWebKitAPI/Tests/WebKit2/autoplay-check-frame.html: Removed.
* TestWebKitAPI/Tests/WebKit2/autoplay-check-in-iframe.html: Removed.
* TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Removed.
* TestWebKitAPI/Tests/WebKit2/autoplay-inherits-gesture-from-document.html: Removed.
* TestWebKitAPI/Tests/WebKit2/autoplay-muted-with-controls.html: Removed.
* TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Removed.
* TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Removed.
* TestWebKitAPI/Tests/WebKit2/autoplay-zero-volume-check.html: Removed.
* TestWebKitAPI/Tests/WebKit2/bundle-file.html: Removed.
* TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Removed.
* TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Removed.
* TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html: Removed.
* TestWebKitAPI/Tests/WebKit2/cocoa: Removed.
* TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm: Removed.
* TestWebKitAPI/Tests/WebKit2/contentBlockerCheck.html: Removed.
* TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Removed.
* TestWebKitAPI/Tests/WebKit2/encrypted.pdf: Removed.
* TestWebKitAPI/Tests/WebKit2/enumerateMediaDevices.html: Removed.
* TestWebKitAPI/Tests/WebKit2/execCopy.html: Removed.
* TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Removed.
* TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Removed.
* TestWebKitAPI/Tests/WebKit2/file-with-video.html: Removed.
* TestWebKitAPI/Tests/WebKit2/find.html: Removed.
* TestWebKitAPI/Tests/WebKit2/findRanges.html: Removed.
* TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPosition.html: Removed.
* TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPositionWithHighAccuracy.html: Removed.
* TestWebKitAPI/Tests/WebKit2/geolocationWatchPosition.html: Removed.
* TestWebKitAPI/Tests/WebKit2/geolocationWatchPositionWithHighAccuracy.html: Removed.
* TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Removed.
* TestWebKitAPI/Tests/WebKit2/gtk: Removed.
* TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/icon.png: Removed.
* TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Removed.
* TestWebKitAPI/Tests/WebKit2/js-autoplay-audio.html: Removed.
* TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Removed.
* TestWebKitAPI/Tests/WebKit2/large-red-square-image.html: Removed.
* TestWebKitAPI/Tests/WebKit2/link-with-download-attribute-with-slashes.html: Removed.
* TestWebKitAPI/Tests/WebKit2/link-with-download-attribute.html: Removed.
* TestWebKitAPI/Tests/WebKit2/link-with-title.html: Removed.
* TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Removed.
* TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Removed.
* TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Removed.
* TestWebKitAPI/Tests/WebKit2/lots-of-text.html: Removed.
* TestWebKitAPI/Tests/WebKit2/mac: Removed.
* TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Removed.
* TestWebKitAPI/Tests/WebKit2/mac/ContextMenuDownload.mm: Removed.
* TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm: Removed.
* TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm: Removed.
* TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm: Removed.
* TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent_Bundle.cpp: Removed.
* TestWebKitAPI/Tests/WebKit2/mac/RestoreStateAfterTermination.mm: Removed.
* TestWebKitAPI/Tests/WebKit2/many-iframes.html: Removed.
* TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Removed.
* TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html: Removed.
* TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Removed.
* TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Removed.
* TestWebKitAPI/Tests/WebKit2/navigation-client-default-crypto.html: Removed.
* TestWebKitAPI/Tests/WebKit2/no-autoplay-with-controls.html: Removed.
* TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Removed.
* TestWebKitAPI/Tests/WebKit2/push-state.html: Removed.
* TestWebKitAPI/Tests/WebKit2/set-long-title.html: Removed.
* TestWebKitAPI/Tests/WebKit2/should-open-external-schemes.html: Removed.
* TestWebKitAPI/Tests/WebKit2/simple-accelerated-compositing.html: Removed.
* TestWebKitAPI/Tests/WebKit2/simple-form.html: Removed.
* TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Removed.
* TestWebKitAPI/Tests/WebKit2/simple-tall.html: Removed.
* TestWebKitAPI/Tests/WebKit2/simple.html: Removed.
* TestWebKitAPI/Tests/WebKit2/simple2.html: Removed.
* TestWebKitAPI/Tests/WebKit2/simple3.html: Removed.
* TestWebKitAPI/Tests/WebKit2/spacebar-scrolling.html: Removed.
* TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Removed.
* TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Removed.
* TestWebKitAPI/Tests/WebKit2/test.mp4: Removed.
* TestWebKitAPI/Tests/WebKit2/test.pdf: Removed.
* TestWebKitAPI/Tests/WebKit2/webfont.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRename TestWebKitAPI/Tests/WebKit to WebKitLegacy following Source directory rename.
achristensen@apple.com [Sat, 26 Aug 2017 00:47:51 +0000 (00:47 +0000)]
Rename TestWebKitAPI/Tests/WebKit to WebKitLegacy following Source directory rename.

Rubber-stamped by Brady Eidson.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit: Removed.
* TestWebKitAPI/Tests/WebKit/ios: Removed.
* TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm: Removed.
* TestWebKitAPI/Tests/WebKit/ios/SnapshotViaRenderInContext.mm: Removed.
* TestWebKitAPI/Tests/WebKit/ios/audio-only.html: Removed.
* TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html: Removed.
* TestWebKitAPI/Tests/WebKit/ios/video-with-audio.mp4: Removed.
* TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Removed.
* TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Removed.
* TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html: Removed.
* TestWebKitAPI/Tests/WebKit/ios/video-without-audio.mp4: Removed.
* TestWebKitAPI/Tests/WebKit/win: Removed.
* TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Removed.
* TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed.
* TestWebKitAPI/Tests/WebKitLegacy: Copied from TestWebKitAPI/Tests/WebKit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd WKUIDelegatePrivate equivalent of WKPageUIClient's saveDataToFileInDownloadsFolder
achristensen@apple.com [Sat, 26 Aug 2017 00:13:47 +0000 (00:13 +0000)]
Add WKUIDelegatePrivate equivalent of WKPageUIClient's saveDataToFileInDownloadsFolder
https://bugs.webkit.org/show_bug.cgi?id=176000
<rdar://problem/29270035>

Reviewed by Andy Estes.
Source/WebKit:

Covered by a new API test.

* Shared/Cocoa/WKNSData.h:
(wrapper): Deleted.
* UIProcess/API/APIUIClient.h:
(API::UIClient::saveDataToFileInDownloadsFolder):
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
* UIProcess/Cocoa/UIDelegate.h:
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::saveDataToFileInDownloadsFolder):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::saveDataToFileInDownloadsFolder):
(WebKit::WebPageProxy::savePDFToFileInDownloadsFolder):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::url const):
* WebProcess/WebPage/WebFrame.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::savePDFToFileInDownloadsFolder):
* WebProcess/WebPage/WebPage.h:

Tools:

* TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm:
(-[FocusDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TEST):
(-[SaveDataToFileDelegate _webView:saveDataToFile:suggestedFilename:mimeType:originatingURL:]):
(-[SaveDataToFileDelegate webView:didFinishNavigation:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoFix -Wunused-lambda-capture warnings in WebKit with new clang compiler
ddkilzer@apple.com [Fri, 25 Aug 2017 23:59:35 +0000 (23:59 +0000)]
Fix -Wunused-lambda-capture warnings in WebKit with new clang compiler
<https://webkit.org/b/175911>
<rdar://problem/33667497>

Reviewed by Alex Christensen.

* NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::retrieveCaches): Remove unused
lambda capture for 'this'.
(WebKit::CacheStorage::Engine::putRecords): Remove unused
lambda capture for 'cacheIdentifier'.
* NetworkProcess/cache/CacheStorageEngineConnection.cpp:
(WebKit::CacheStorageEngineConnection::records): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWPT server should not need to copy test harness files
commit-queue@webkit.org [Fri, 25 Aug 2017 23:58:57 +0000 (23:58 +0000)]
WPT server should not need to copy test harness files
https://bugs.webkit.org/show_bug.cgi?id=175938

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-25
Reviewed by Alexey Proskuryakov.

LayoutTests/imported/w3c:

* resources/config.json: Use aliases to load testharness.css and testharnessreport.js

Tools:

* Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
(WebPlatformTestServer.__init__): Stopping explicit resource files copy when launching the WPT server.
Use aliases instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDemarcate code added due to lack of NSDMI for aggregates
dbates@webkit.org [Fri, 25 Aug 2017 23:42:02 +0000 (23:42 +0000)]
Demarcate code added due to lack of NSDMI for aggregates
https://bugs.webkit.org/show_bug.cgi?id=175990

Reviewed by Andy Estes.

Source/bmalloc:

* bmalloc/BPlatform.h:
* bmalloc/List.h: Be explicit when initializing m_node to improve readability.
(bmalloc::ListNode::ListNode):

Source/JavaScriptCore:

* domjit/DOMJITEffect.h:
(JSC::DOMJIT::Effect::Effect):
(JSC::DOMJIT::Effect::forWrite):
(JSC::DOMJIT::Effect::forRead):
(JSC::DOMJIT::Effect::forReadWrite):
(JSC::DOMJIT::Effect::forPure):
(JSC::DOMJIT::Effect::forDef):
* runtime/HasOwnPropertyCache.h:
(JSC::HasOwnPropertyCache::Entry::Entry):
(JSC::HasOwnPropertyCache::Entry::operator=): Deleted.
* wasm/WasmFormat.h: Modernize some of the code while I am here. Also
make some comments read well.
(JSC::Wasm::CallableFunction::CallableFunction):
* wasm/js/WebAssemblyFunction.cpp:
(JSC::WebAssemblyFunction::WebAssemblyFunction):
* wasm/js/WebAssemblyWrapperFunction.cpp:
(JSC::WebAssemblyWrapperFunction::create):

Source/WebCore:

* html/canvas/CanvasStyle.h:
* platform/mediastream/IceCandidate.h:
(WebCore::IceCandidate::IceCandidate):
* platform/text/StringWithDirection.h: Replace const String& and String&& constructor
overloads with a single user-defined constructor that takes a String by value to handle
both cases.
(WebCore::StringWithDirection::StringWithDirection):
(WebCore::truncateFromEnd):
* style/StyleUpdate.h:
(WebCore::Style::ElementUpdate::ElementUpdate):
(WebCore::Style::TextUpdate::TextUpdate):

Source/WTF:

* wtf/Compiler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoInlineTextBox::paintDocumentMarker() does not need to special case painting of gramma...
dbates@webkit.org [Fri, 25 Aug 2017 23:41:11 +0000 (23:41 +0000)]
InlineTextBox::paintDocumentMarker() does not need to special case painting of grammar and
dictation alternatives
https://bugs.webkit.org/show_bug.cgi?id=175966

Reviewed by Tim Horton.

Remove code that forced computing the marker rect for grammar and dictation alternative
regardless of whether the marker spans the entire width of the line box. InlineTextBox::paintDocumentMarker()
has performance optimizations to avoid computing the marker rect if it spans the entire line box.
Prior to r190363 we had to opt out of these optimizations for grammar and dictation alternative
markers so that we could store their computed marker rect. In r190363 we removed the logic in
InlineTextBox::paintDocumentMarker() to store the computed marker rect and hence no longer
needed to opt out of the optimization for these marker types, but inadvertently left in the
conditional code that opts them out.

No functionality changed. So no new tests.

* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintDocumentMarker): Remove unnecessary argument grammar and
code that special cased handling of grammar an dictation alternative markers.
(WebCore::InlineTextBox::paintDocumentMarkers): Update as necessary.
* rendering/InlineTextBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDefine *_GIGACAGE_MASK when Gigacage is not supported
don.olmstead@sony.com [Fri, 25 Aug 2017 23:11:25 +0000 (23:11 +0000)]
Define *_GIGACAGE_MASK when Gigacage is not supported
https://bugs.webkit.org/show_bug.cgi?id=175994

Reviewed by Mark Lam.

* wtf/Gigacage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed. Fix 32-bit after r221196
sbarati@apple.com [Fri, 25 Aug 2017 22:50:53 +0000 (22:50 +0000)]
Unreviewed. Fix 32-bit after r221196

* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_catch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoLand stubs for File and Directory Entries API interfaces
cdumez@apple.com [Fri, 25 Aug 2017 22:41:04 +0000 (22:41 +0000)]
Land stubs for File and Directory Entries API interfaces
https://bugs.webkit.org/show_bug.cgi?id=175993
<rdar://problem/34087477>

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

Add CommonIdentifiers needed for [EnabledAtRuntime].

* runtime/CommonIdentifiers.h:

Source/WebCore:

Land stubs for File and Directory Entries API interfaces:
- https://wicg.github.io/entries-api/#idl-index

Those will be needed to support drag and drop.

Test: http/wpt/entries-api/interfaces.html

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* Modules/entriesapi/DOMFileSystem.cpp: Added.
(WebCore::DOMFileSystem::DOMFileSystem):
(WebCore::DOMFileSystem::~DOMFileSystem):
* Modules/entriesapi/DOMFileSystem.h: Added.
(WebCore::DOMFileSystem::create):
(WebCore::DOMFileSystem::name const):
(WebCore::DOMFileSystem::root const):
* Modules/entriesapi/DOMFileSystem.idl: Added.
* Modules/entriesapi/ErrorCallback.h: Added.
* Modules/entriesapi/ErrorCallback.idl: Added.
* Modules/entriesapi/FileCallback.h: Added.
* Modules/entriesapi/FileCallback.idl: Added.
* Modules/entriesapi/FileSystemDirectoryEntry.cpp: Added.
(WebCore::FileSystemDirectoryEntry::FileSystemDirectoryEntry):
(WebCore::FileSystemDirectoryEntry::getFile):
(WebCore::FileSystemDirectoryEntry::getDirectory):
* Modules/entriesapi/FileSystemDirectoryEntry.h: Added.
* Modules/entriesapi/FileSystemDirectoryEntry.idl: Added.
* Modules/entriesapi/FileSystemEntry.cpp: Added.
(WebCore::FileSystemEntry::FileSystemEntry):
* Modules/entriesapi/FileSystemEntry.h: Added.
(WebCore::FileSystemEntry::~FileSystemEntry):
(WebCore::FileSystemEntry::isFile const):
(WebCore::FileSystemEntry::isDirectory const):
(WebCore::FileSystemEntry::name const):
(WebCore::FileSystemEntry::fullPath const):
(WebCore::FileSystemEntry::filesystem const):
* Modules/entriesapi/FileSystemEntry.idl: Added.
* Modules/entriesapi/FileSystemEntryCallback.h: Added.
* Modules/entriesapi/FileSystemEntryCallback.idl: Added.
* Modules/entriesapi/FileSystemFileEntry.cpp: Added.
(WebCore::FileSystemFileEntry::FileSystemFileEntry):
(WebCore::FileSystemFileEntry::file):
* Modules/entriesapi/FileSystemFileEntry.h: Added.
* Modules/entriesapi/FileSystemFileEntry.idl: Added.
* WebCore.xcodeproj/project.pbxproj:

LayoutTests:

Add layout test coverage.

* http/wpt/entries-api/interfaces-expected.txt: Added.
* http/wpt/entries-api/interfaces.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Automation: add capabilities to control ICE candidate filtering and insecure...
bburg@apple.com [Fri, 25 Aug 2017 22:09:22 +0000 (22:09 +0000)]
Web Automation: add capabilities to control ICE candidate filtering and insecure media capture
https://bugs.webkit.org/show_bug.cgi?id=175563
<rdar://problem/33734492>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Add macros for new capability protocol string names. Let's use a reverse
domain name notification for these capabilities so we know whether they are
intended for a particular client/port or any WebKit client, and what feature they
are related to (i.e., webrtc).

* inspector/remote/RemoteInspectorConstants.h:

Source/WebKit:

* UIProcess/Cocoa/AutomationClient.mm:
(WebKit::AutomationClient::requestAutomationSessionWithCapabilities):
Translate new capabilities to _WKAutomationSessionConfiguration properties.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSpeedometer: Restructure Ember example
commit-queue@webkit.org [Fri, 25 Aug 2017 21:59:29 +0000 (21:59 +0000)]
Speedometer: Restructure Ember example
https://bugs.webkit.org/show_bug.cgi?id=175926

Patch by Mathias Bynens <mathias@qiwi.be> on 2017-08-25
Reviewed by Ryosuke Niwa.

This patch removes an unused stylesheet from the output, and gets rid of the unneeded intermediate `source` folder.

* Speedometer/resources/tests.js: Update path to Ember benchmark.
* Speedometer/resources/todomvc/architecture-examples/emberjs/source/*: Moved to `../`.
* Speedometer/resources/todomvc/architecture-examples/emberjs/app/index.html: Removed stylesheet reference.
* Speedometer/resources/todomvc/architecture-examples/emberjs/app/styles/.gitkeep: Added.
* Speedometer/resources/todomvc/architecture-examples/emberjs/dist/*: Regenerated per build instructions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSpeedometer 2.0: Duplicate the current EmberJS test as EmberJS-Debug test
rniwa@webkit.org [Fri, 25 Aug 2017 21:21:35 +0000 (21:21 +0000)]
Speedometer 2.0: Duplicate the current EmberJS test as EmberJS-Debug test
https://bugs.webkit.org/show_bug.cgi?id=175956

Reviewed by Saam Barati.

Made the copy of Ember.js directory at r216946 as emberjs-debug, and added a new test suite "EmberJS-Debug-TodoMVC".

* Speedometer/resources/tests.js:
(Suites.push.prepare):
* Speedometer/resources/todomvc/architecture-examples/emberjs-debug: Copied from emberjs@r216946.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Automation: use automation session configurations to propagate per-session settings
bburg@apple.com [Fri, 25 Aug 2017 21:08:09 +0000 (21:08 +0000)]
Web Automation: use automation session configurations to propagate per-session settings
https://bugs.webkit.org/show_bug.cgi?id=175562
<rdar://problem/30853362>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Add a Cocoa-specific code path to forward capabilities when requesting
a new session from the remote inspector (i.e., automation) client.

If other ports want to use this, then we can convert Cocoa types to WebKit types later.

* inspector/remote/RemoteInspector.h:
* inspector/remote/RemoteInspectorConstants.h:
* inspector/remote/cocoa/RemoteInspectorCocoa.mm:
(Inspector::RemoteInspector::receivedAutomationSessionRequestMessage):

Source/WebKit:

Some WebDriver capabilities need WebKit support in order to be implemented correctly.
There is currently no easy way to forward WebDriver capability keys and values to WebKit
at session creation time. This is unfortunate, as it would be best to implement many of
them via existing mechanisms (i.e., WKPreferences properties) that need to be set up
before any windows are opened in the session.

This patch adds WebKit-side plumbing to forward named capabilities from a remote
WebDriver client to the _WKAutomationSession and its delegate in WebKit2 UIProcess.
These capabilities are exposed via API in ways that abstract away details of how the
capabilities are represented in RWI wire protocol messages.

In the Cocoa API, these capabilities are exposed via a session configuration object
that's similar to WKWebView's WKWebViewConfiguration. A session's configuration is copied
and used at initialization and cannot be modified after the session is created.
Code in the Cocoa subclass of API::AutomationClient translates between RWI protocol
capability names and property values on the _WKAutomationSessionConfiguration it
uses to request a new session.

Later patches will hook up the two properties present in the configuration in this patch.
Most of this patch is just generic plumbing without doing any capability-specific work.

* UIProcess/API/Cocoa/_WKAutomationDelegate.h:
* UIProcess/API/Cocoa/_WKAutomationSession.h:
* UIProcess/API/Cocoa/_WKAutomationSession.mm:
(-[_WKAutomationSession init]):
(-[_WKAutomationSession initWithConfiguration:]):
(-[_WKAutomationSession configuration]):
* UIProcess/API/Cocoa/_WKAutomationSessionConfiguration.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKAutomationDelegate.h.
* UIProcess/API/Cocoa/_WKAutomationSessionConfiguration.mm: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKAutomationSession.h.
(-[_WKAutomationSessionConfiguration init]):
(-[_WKAutomationSessionConfiguration description]):
* UIProcess/Cocoa/AutomationClient.h:
* UIProcess/Cocoa/AutomationClient.mm:
(WebKit::AutomationClient::AutomationClient):
(WebKit::AutomationClient::requestAutomationSession):
(WebKit::AutomationClient::requestAutomationSessionWithCapabilities):
* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd String::format variant that takes va_args
eric.carlson@apple.com [Fri, 25 Aug 2017 20:23:57 +0000 (20:23 +0000)]
Add String::format variant that takes va_args
https://bugs.webkit.org/show_bug.cgi?id=175988

Reviewed by Jer Noble.

Source/WTF:

* wtf/text/WTFString.cpp:
(WTF::createWithFormatAndArguments): Created with the guts of String::format.
(WTF::String::formatWithArguments): New, call createWithFormatAndArguments.
(WTF::String::format): Move logic to createWithFormatAndArguments, use it.
* wtf/text/WTFString.h:

Tools:

* TestWebKitAPI/Tests/WTF/WTFString.cpp:
(TestWebKitAPI::testWithFormatAndArguments):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoREGRESSION(r221017): Quip stuck in a perpetual loading loop
bfulgham@apple.com [Fri, 25 Aug 2017 20:10:51 +0000 (20:10 +0000)]
REGRESSION(r221017): Quip stuck in a perpetual loading loop
https://bugs.webkit.org/show_bug.cgi?id=175991
<rdar://problem/34044445>

Reviewed by Daniel Bates.

This is a quick fix to return proper function to WebKit. I'll relate a follow-up fix that
addresses WebSockets more completely.

* platform/network/mac/CookieJarMac.mm:
(WebCore::cookieRequestHeaderFieldValue): Don't hard code a value of 'No' for returning secure
cookies. HTTPS connection should get secure cookies.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd support for ReadableStream storage in FetchBody
commit-queue@webkit.org [Fri, 25 Aug 2017 20:09:31 +0000 (20:09 +0000)]
Add support for ReadableStream storage in FetchBody
https://bugs.webkit.org/show_bug.cgi?id=175866

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-25
Reviewed by Sam Weinig.

Source/WebCore:

Test: http/wpt/beacon/beacon-readablestream.html

Add support for IDLInterface<ReadableStream>, in particular to handle union conversions.
Adding a ReadableStream that guards JSReadableStream from being collected.
With this object, FetchBody will be able to store and manipulate ReadableStream.

Ensure conversion of BodyInit union with ReadableStream is working by adding support for beacon rejection in case of request body streams.

* Modules/beacon/NavigatorBeacon.cpp:
(WebCore::NavigatorBeacon::sendBeacon):
* Modules/beacon/NavigatorBeacon.idl:
* Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::extract):
* Modules/fetch/FetchBody.h:
* Modules/fetch/FetchRequest.idl:
* Modules/fetch/FetchRequestInit.idl:
* Modules/fetch/FetchResponse.idl:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMConvertInterface.h:
(WebCore::JSToWrappedOverloader::toWrapped):
(WebCore::Converter<IDLInterface<T>>::convert):
* bindings/js/JSDOMConvertUnion.h:
* bindings/js/ReadableStream.h: Added.
(WebCore::JSReadableStreamWrapperConverter::toWrapped):

LayoutTests:

* http/wpt/beacon/beacon-readablestream-expected.txt: Added.
* http/wpt/beacon/beacon-readablestream.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDFG::JITCode::osrEntry should get sorted since we perform a binary search on it
sbarati@apple.com [Fri, 25 Aug 2017 19:12:37 +0000 (19:12 +0000)]
DFG::JITCode::osrEntry should get sorted since we perform a binary search on it
https://bugs.webkit.org/show_bug.cgi?id=175893

Reviewed by Mark Lam.

* dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::finalizeOSREntrypoints):
* dfg/DFGJITCode.h:
(JSC::DFG::JITCode::finalizeCatchOSREntrypoints): Deleted.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::linkOSREntries):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUsing the touchbar, both align left and align justify send a beforeinput event with...
wenson_hsieh@apple.com [Fri, 25 Aug 2017 19:04:23 +0000 (19:04 +0000)]
Using the touchbar, both align left and align justify send a beforeinput event with the 'formatJustifyLeft' inputType.
https://bugs.webkit.org/show_bug.cgi?id=168669
<rdar://problem/30639155>

Reviewed by Beth Dakin.

Source/WebCore:

Small tweak to add a "formatJustifyFull" inputType when justifying text using the touch bar's rich text
formatting controls. Currently, the EditActionJustify edit command incorrectly maps to "formatJustifyLeft".

Test: fast/events/input-events-text-alignment.html

* editing/EditCommand.cpp:
(WebCore::inputTypeNameForEditingAction):

LayoutTests:

Adds a new LayoutTest checking that the text alignment editor commands, "Align{Right|Center|Left|Justify}",
correctly propagate input events and beforeinput events of inputType "formatJustify{Right|Center|Left|Justify}",
and that these text alignment style changes can be prevented by calling preventDefault() on the dispatched
beforeinput event.

* fast/events/input-events-text-alignment-expected.txt: Added.
* fast/events/input-events-text-alignment.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoIntroduce ServerWorkerRegistration task queues.
beidson@apple.com [Fri, 25 Aug 2017 18:57:44 +0000 (18:57 +0000)]
Introduce ServerWorkerRegistration task queues.
https://bugs.webkit.org/show_bug.cgi?id=175851

Reviewed by Andy Estes.

Source/WebCore:

Test: http/tests/workers/service/registration-task-queue-scheduling-1.html

This change introduces:
- A task thread/queue owned by each SWServer object.
- The SWServerRegistration object, which is the in-server representation of a
  service worker registration scope.
- A registration job queue per SWServerRegistration object which actually runs the
  jobs as tasks on the owning SWServer's thread.

With that infrastructure in place, it moves the "register" job to something that is
scheduled and rejected asynchronously, as opposed to synchronously rejected.

The test verifies that two different registration scopes (localhost and 127.0.0.1)
can both spam the SWServer with registration requests, but neither of their queues
starve the other.

The rest of this change is a lot of support and plumbing for making the above happen.

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:

* dom/ExceptionData.cpp:
(WebCore::ExceptionData::isolatedCopy const):
* dom/ExceptionData.h:

* workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::connectionIdentifier):
* workers/service/ServiceWorkerContainer.h:

* workers/service/ServiceWorkerJob.cpp:
(WebCore::ServiceWorkerJob::ServiceWorkerJob):
(WebCore::ServiceWorkerJob::data const): Deleted.
* workers/service/ServiceWorkerJob.h:
(WebCore::ServiceWorkerJob::create):
(WebCore::ServiceWorkerJob::data const):
(WebCore::ServiceWorkerJob::createRegisterJob): Deleted.

* workers/service/ServiceWorkerJobClient.h:

* workers/service/ServiceWorkerJobData.cpp:
(WebCore::ServiceWorkerJobData::ServiceWorkerJobData):
(WebCore::ServiceWorkerJobData::registrationKey const):
(WebCore::ServiceWorkerJobData::isolatedCopy const):
* workers/service/ServiceWorkerJobData.h:
(WebCore::ServiceWorkerJobData::jobIdentifier const):
(WebCore::ServiceWorkerJobData::connectionIdentifier const):
(WebCore::ServiceWorkerJobData::encode const):
(WebCore::ServiceWorkerJobData::decode):

* workers/service/ServiceWorkerRegistrationKey.cpp:
(WebCore::ServiceWorkerRegistrationKey::emptyKey):
(WebCore::ServiceWorkerRegistrationKey::hash const):
(WebCore::ServiceWorkerRegistrationKey::operator== const):
* workers/service/ServiceWorkerRegistrationKey.h:
(WTF::ServiceWorkerRegistrationKeyHash::hash):
(WTF::ServiceWorkerRegistrationKeyHash::equal):
(WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>::emptyValue):
(WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>::constructDeletedValue):
(WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>::isDeletedValue):

* workers/service/ServiceWorkerRegistrationOptions.cpp:
(WebCore::RegistrationOptions::isolatedCopy const):
* workers/service/ServiceWorkerRegistrationOptions.h:
(WebCore::RegistrationOptions::encode const):
(WebCore::RegistrationOptions::decode):

* workers/service/server/SWClientConnection.h:

* workers/service/server/SWServer.cpp:
(WebCore::SWServer::Connection::Connection):
(WebCore::SWServer::~SWServer):
(WebCore::SWServer::Connection::scheduleJobInServer):
(WebCore::SWServer::SWServer):
(WebCore::SWServer::scheduleJob):
(WebCore::SWServer::rejectJob):
(WebCore::SWServer::taskThreadEntryPoint):
(WebCore::SWServer::postTask):
(WebCore::SWServer::postTaskReply):
(WebCore::SWServer::handleTaskRepliesOnMainThread):
(WebCore::SWServer::registerConnection):
(WebCore::SWServer::unregisterConnection):
* workers/service/server/SWServer.h:
(WebCore::SWServer::Connection::identifier const):

* workers/service/server/SWServerRegistration.cpp: Added.
(WebCore::SWServerRegistration::SWServerRegistration):
(WebCore::SWServerRegistration::~SWServerRegistration):
(WebCore::SWServerRegistration::enqueueJob):
(WebCore::SWServerRegistration::startNextJob):
(WebCore::SWServerRegistration::performCurrentJob):
(WebCore::SWServerRegistration::rejectCurrentJob):
(WebCore::SWServerRegistration::finishCurrentJob):
* workers/service/server/SWServerRegistration.h:

Source/WebKit:

* StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::WebSWServerConnection):
* StorageProcess/ServiceWorker/WebSWServerConnection.h:
(WebKit::WebSWServerConnection::identifier const): Deleted.

* WebProcess/Storage/WebSWClientConnection.h:
(WebKit::WebSWClientConnection::identifier const): Deleted.

LayoutTests:

* http/tests/workers/service/registration-task-queue-scheduling-1-expected.txt: Added.
* http/tests/workers/service/registration-task-queue-scheduling-1.html: Added.
* http/tests/workers/service/resources/registration-task-queue-scheduling-1-second-window.html: Added.
* http/tests/workers/service/resources/registration-task-queue-scheduling-1.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoFollow-up Internal build fix for r221187
jbedard@apple.com [Fri, 25 Aug 2017 18:54:55 +0000 (18:54 +0000)]
Follow-up Internal build fix for r221187
https://bugs.webkit.org/show_bug.cgi?id=175960
<rdar://problem/34069264>

Unreviewed build fix.

* TestWebKitAPI/ios/DataInteractionSimulator.h: Move UIItemProvider declaration
into #if block.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSupport compiling catch in the DFG
sbarati@apple.com [Fri, 25 Aug 2017 18:26:15 +0000 (18:26 +0000)]
Support compiling catch in the DFG
https://bugs.webkit.org/show_bug.cgi?id=174590
<rdar://problem/34047845>

Reviewed by Filip Pizlo.

JSTests:

* microbenchmarks/delta-blue-try-catch.js: Added.
(exception):
(value):
(OrderedCollection):
(OrderedCollection.prototype.add):
(OrderedCollection.prototype.at):
(OrderedCollection.prototype.size):
(OrderedCollection.prototype.removeFirst):
(OrderedCollection.prototype.remove):
(Strength):
(Strength.stronger):
(Strength.weaker):
(Strength.weakestOf):
(Strength.strongest):
(Strength.prototype.nextWeaker):
(Constraint):
(Constraint.prototype.addConstraint):
(Constraint.prototype.satisfy):
(Constraint.prototype.destroyConstraint):
(Constraint.prototype.isInput):
(UnaryConstraint):
(UnaryConstraint.prototype.addToGraph):
(UnaryConstraint.prototype.chooseMethod):
(UnaryConstraint.prototype.isSatisfied):
(UnaryConstraint.prototype.markInputs):
(UnaryConstraint.prototype.output):
(UnaryConstraint.prototype.recalculate):
(UnaryConstraint.prototype.markUnsatisfied):
(UnaryConstraint.prototype.inputsKnown):
(UnaryConstraint.prototype.removeFromGraph):
(StayConstraint):
(StayConstraint.prototype.execute):
(EditConstraint.prototype.isInput):
(EditConstraint.prototype.execute):
(BinaryConstraint):
(BinaryConstraint.prototype.chooseMethod):
(BinaryConstraint.prototype.addToGraph):
(BinaryConstraint.prototype.isSatisfied):
(BinaryConstraint.prototype.markInputs):
(BinaryConstraint.prototype.input):
(BinaryConstraint.prototype.output):
(BinaryConstraint.prototype.recalculate):
(BinaryConstraint.prototype.markUnsatisfied):
(BinaryConstraint.prototype.inputsKnown):
(BinaryConstraint.prototype.removeFromGraph):
(ScaleConstraint):
(ScaleConstraint.prototype.addToGraph):
(ScaleConstraint.prototype.removeFromGraph):
(ScaleConstraint.prototype.markInputs):
(ScaleConstraint.prototype.execute):
(ScaleConstraint.prototype.recalculate):
(EqualityConstraint):
(EqualityConstraint.prototype.execute):
(Variable):
(Variable.prototype.addConstraint):
(Variable.prototype.removeConstraint):
(Planner):
(Planner.prototype.incrementalAdd):
(Planner.prototype.incrementalRemove):
(Planner.prototype.newMark):
(Planner.prototype.makePlan):
(Planner.prototype.extractPlanFromConstraints):
(Planner.prototype.addPropagate):
(Planner.prototype.removePropagateFrom):
(Planner.prototype.addConstraintsConsumingTo):
(Plan):
(Plan.prototype.addConstraint):
(Plan.prototype.size):
(Plan.prototype.constraintAt):
(Plan.prototype.execute):
(chainTest):
(projectionTest):
(change):
(deltaBlue):
* microbenchmarks/fake-iterators-that-throw-when-finished.js: Added.
(assert):
(Numbers):
(Numbers.prototype.next):
(return.Transpose):
(return.Transpose.prototype.next):
(transpose):
(verifyEven):
(verifyString):
(foo):
(runIterators):
* microbenchmarks/try-catch-word-count.js: Added.
(let.assert):
(EOF):
(let.texts):
(let.o.apply):
(foo):
(bar):
(f):
(run):
(test1):
(test2):
(test3):
(fn):
(A):
(B):
(A.prototype.getValue):
(B.prototype.getParentValue):
(strlen):
(sum.0):
(test):
(result.test.o):
(set add.set add):
(set forEach):
(stringHash):
(set if):
(testFunction):
(set delete.set has.set add):
* stress/catch-set-argument-speculation-failure.js: Added.
(o):
(e):
(e2):
(escape):
(baz):
(noInline.run):
(noInline):
* stress/osr-enter-to-catch-with-set-local-type-check-failure.js: Added.
(foo):
(e):
(baz):
(bar):

Source/JavaScriptCore:

This patch implements OSR entry into op_catch in the DFG. We will support OSR entry
into the FTL in a followup: https://bugs.webkit.org/show_bug.cgi?id=175396

To implement catch in the DFG, this patch introduces the concept of multiple
entrypoints into CPS/LoadStore DFG IR. A lot of this patch is stringing this concept
through the DFG. Many phases used to assume that Graph::block(0) is the only root, and this
patch contains many straight forward changes generalizing the code to handle more than
one entrypoint.

A main building block of this is moving to two CFG types: SSACFG and CPSCFG. SSACFG
is the same CFG we used to have. CPSCFG is a new type that introduces a fake root
that has an outgoing edge to all the entrypoints. This allows our existing graph algorithms
to Just Work over CPSCFG. For example, there is now the concept of SSADominators vs CPSDominators,
and SSANaturalLoops vs CPSNaturalLoops.

The way we compile the catch entrypoint is by bootstrapping the state
of the program by loading all live bytecode locals from a buffer. The OSR
entry code will store all live values into that buffer before jumping to
the entrypoint. The OSR entry code is also responsible for performing type
proofs of the arguments before doing an OSR entry. If there is a type
mismatch, it's not legal to OSR enter into the DFG compilation. Currently,
each catch entrypoint knows the argument type proofs it must perform to enter
into the DFG. Currently, all entrypoints' arguments flush format are unified
via ArgumentPosition, but this is just an implementation detail. The code is
written more generally to assume that each entrypoint may perform its own distinct
proof.

op_catch now performs value profiling for all live bytecode locals in the
LLInt and baseline JIT. This information is then fed into the DFG via the
ExtractCatchLocal node in the prediction propagation phase.

This patch also changes how we generate op_catch in bytecode. All op_catches
are now split out at the end of the program in bytecode. This ensures that
no op_catch is inside a try block. This is needed to ensure correctness in
the DFGLiveCatchVariablePreservationPhase. That phase only inserts flushes
before SetLocals inside a try block. If an op_catch were in a try block, this
would cause the phase to insert a Flush before one of the state bootstrapping
SetLocals, which would generate invalid IR. Moving op_catch to be generated on
its own at the end of a bytecode stream seemed like the most elegant solution since
it better represents that we treat op_catch as an entrypoint. This is true
both in the DFG and in the baseline and LLInt: we don't reach an op_catch
via normal control flow. Because op_catch cannot throw, this will not break
any previous semantics of op_catch. Logically, it'd be valid to split try
blocks around any non-throwing bytecode operation.

* CMakeLists.txt:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/BytecodeDumper.cpp:
(JSC::BytecodeDumper<Block>::dumpBytecode):
* bytecode/BytecodeList.json:
* bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::ensureCatchLivenessIsComputedForBytecodeOffset):
(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
(JSC::CodeBlock::validate):
* bytecode/CodeBlock.h:
* bytecode/ValueProfile.h:
(JSC::ValueProfile::ValueProfile):
(JSC::ValueProfileAndOperandBuffer::ValueProfileAndOperandBuffer):
(JSC::ValueProfileAndOperandBuffer::~ValueProfileAndOperandBuffer):
(JSC::ValueProfileAndOperandBuffer::forEach):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCatch):
(JSC::BytecodeGenerator::emitEnumeration):
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/NodesCodegen.cpp:
(JSC::TryNode::emitBytecode):
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
* dfg/DFGBackwardsCFG.h:
(JSC::DFG::BackwardsCFG::BackwardsCFG):
* dfg/DFGBasicBlock.cpp:
(JSC::DFG::BasicBlock::BasicBlock):
* dfg/DFGBasicBlock.h:
(JSC::DFG::BasicBlock::findTerminal const):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::setDirect):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::DelayedSetLocal::DelayedSetLocal):
(JSC::DFG::ByteCodeParser::DelayedSetLocal::execute):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGCFG.h:
(JSC::DFG::CFG::root):
(JSC::DFG::CFG::roots):
(JSC::DFG::CPSCFG::CPSCFG):
(JSC::DFG::selectCFG):
* dfg/DFGCPSRethreadingPhase.cpp:
(JSC::DFG::CPSRethreadingPhase::specialCaseArguments):
* dfg/DFGCSEPhase.cpp:
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGControlEquivalenceAnalysis.h:
(JSC::DFG::ControlEquivalenceAnalysis::ControlEquivalenceAnalysis):
* dfg/DFGDCEPhase.cpp:
(JSC::DFG::DCEPhase::run):
* dfg/DFGDisassembler.cpp:
(JSC::DFG::Disassembler::createDumpList):
* dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
* dfg/DFGDominators.h:
(JSC::DFG::Dominators::Dominators):
(JSC::DFG::ensureDominatorsForCFG):
* dfg/DFGEdgeDominates.h:
(JSC::DFG::EdgeDominates::EdgeDominates):
(JSC::DFG::EdgeDominates::operator()):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupChecksInBlock):
* dfg/DFGFlushFormat.h:
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph):
(JSC::DFG::unboxLoopNode):
(JSC::DFG::Graph::dumpBlockHeader):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::determineReachability):
(JSC::DFG::Graph::invalidateCFG):
(JSC::DFG::Graph::blocksInPreOrder):
(JSC::DFG::Graph::blocksInPostOrder):
(JSC::DFG::Graph::ensureCPSDominators):
(JSC::DFG::Graph::ensureSSADominators):
(JSC::DFG::Graph::ensureCPSNaturalLoops):
(JSC::DFG::Graph::ensureSSANaturalLoops):
(JSC::DFG::Graph::ensureBackwardsCFG):
(JSC::DFG::Graph::ensureBackwardsDominators):
(JSC::DFG::Graph::ensureControlEquivalenceAnalysis):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):
(JSC::DFG::Graph::clearCPSCFGData):
(JSC::DFG::Graph::ensureDominators): Deleted.
(JSC::DFG::Graph::ensurePrePostNumbering): Deleted.
(JSC::DFG::Graph::ensureNaturalLoops): Deleted.
* dfg/DFGGraph.h:
(JSC::DFG::Graph::willCatchExceptionInMachineFrame):
(JSC::DFG::Graph::isEntrypoint const):
* dfg/DFGInPlaceAbstractState.cpp:
(JSC::DFG::InPlaceAbstractState::initialize):
(JSC::DFG::InPlaceAbstractState::mergeToSuccessors):
* dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::shrinkToFit):
* dfg/DFGJITCode.h:
(JSC::DFG::JITCode::catchOSREntryDataForBytecodeIndex):
(JSC::DFG::JITCode::finalizeCatchOSREntrypoints):
(JSC::DFG::JITCode::appendCatchEntrypoint):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::noticeCatchEntrypoint):
(JSC::DFG::JITCompiler::noticeOSREntry):
(JSC::DFG::JITCompiler::makeCatchOSREntryBuffer):
* dfg/DFGJITCompiler.h:
* dfg/DFGLICMPhase.cpp:
(JSC::DFG::LICMPhase::run):
(JSC::DFG::LICMPhase::attemptHoist):
* dfg/DFGLiveCatchVariablePreservationPhase.cpp:
(JSC::DFG::LiveCatchVariablePreservationPhase::run):
(JSC::DFG::LiveCatchVariablePreservationPhase::isValidFlushLocation):
(JSC::DFG::LiveCatchVariablePreservationPhase::handleBlockForTryCatch):
(JSC::DFG::LiveCatchVariablePreservationPhase::newVariableAccessData):
(JSC::DFG::LiveCatchVariablePreservationPhase::willCatchException): Deleted.
(JSC::DFG::LiveCatchVariablePreservationPhase::handleBlock): Deleted.
* dfg/DFGLoopPreHeaderCreationPhase.cpp:
(JSC::DFG::createPreHeader):
(JSC::DFG::LoopPreHeaderCreationPhase::run):
* dfg/DFGMaximalFlushInsertionPhase.cpp:
(JSC::DFG::MaximalFlushInsertionPhase::run):
(JSC::DFG::MaximalFlushInsertionPhase::treatRegularBlock):
(JSC::DFG::MaximalFlushInsertionPhase::treatRootBlock):
* dfg/DFGMayExit.cpp:
* dfg/DFGNaturalLoops.h:
(JSC::DFG::NaturalLoops::NaturalLoops):
* dfg/DFGNode.h:
(JSC::DFG::Node::isSwitch const):
(JSC::DFG::Node::successor):
(JSC::DFG::Node::catchOSREntryIndex const):
(JSC::DFG::Node::catchLocalPrediction):
(JSC::DFG::Node::isSwitch): Deleted.
* dfg/DFGNodeType.h:
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareCatchOSREntry):
* dfg/DFGOSREntry.h:
* dfg/DFGOSREntrypointCreationPhase.cpp:
(JSC::DFG::OSREntrypointCreationPhase::run):
* dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::handleExitCounts):
* dfg/DFGObjectAllocationSinkingPhase.cpp:
* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
* dfg/DFGPrePostNumbering.cpp:
(JSC::DFG::PrePostNumbering::PrePostNumbering): Deleted.
(JSC::DFG::PrePostNumbering::~PrePostNumbering): Deleted.
(WTF::printInternal): Deleted.
* dfg/DFGPrePostNumbering.h:
(): Deleted.
(JSC::DFG::PrePostNumbering::preNumber const): Deleted.
(JSC::DFG::PrePostNumbering::postNumber const): Deleted.
(JSC::DFG::PrePostNumbering::isStrictAncestorOf const): Deleted.
(JSC::DFG::PrePostNumbering::isAncestorOf const): Deleted.
(JSC::DFG::PrePostNumbering::isStrictDescendantOf const): Deleted.
(JSC::DFG::PrePostNumbering::isDescendantOf const): Deleted.
(JSC::DFG::PrePostNumbering::edgeKind const): Deleted.
* dfg/DFGPredictionInjectionPhase.cpp:
(JSC::DFG::PredictionInjectionPhase::run):
* dfg/DFGPredictionPropagationPhase.cpp:
* dfg/DFGPutStackSinkingPhase.cpp:
* dfg/DFGSSACalculator.cpp:
(JSC::DFG::SSACalculator::nonLocalReachingDef):
(JSC::DFG::SSACalculator::reachingDefAtTail):
* dfg/DFGSSACalculator.h:
(JSC::DFG::SSACalculator::computePhis):
* dfg/DFGSSAConversionPhase.cpp:
(JSC::DFG::SSAConversionPhase::run):
(JSC::DFG::performSSAConversion):
* dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::createOSREntries):
(JSC::DFG::SpeculativeJIT::linkOSREntries):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGStaticExecutionCountEstimationPhase.cpp:
(JSC::DFG::StaticExecutionCountEstimationPhase::run):
* dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):
* dfg/DFGTierUpCheckInjectionPhase.cpp:
(JSC::DFG::TierUpCheckInjectionPhase::run):
(JSC::DFG::TierUpCheckInjectionPhase::buildNaturalLoopToLoopHintMap):
* dfg/DFGTypeCheckHoistingPhase.cpp:
(JSC::DFG::TypeCheckHoistingPhase::run):
* dfg/DFGValidate.cpp:
* ftl/FTLLink.cpp:
(JSC::FTL::link):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::lower):
(JSC::FTL::DFG::LowerDFGToB3::safelyInvalidateAfterTermination):
(JSC::FTL::DFG::LowerDFGToB3::isValid):
* jit/JIT.h:
* jit/JITInlines.h:
(JSC::JIT::callOperation):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_catch):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_catch):
* jit/JITOperations.cpp:
* jit/JITOperations.h:
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* llint/LLIntSlowPaths.h:
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:

Source/WTF:

This patch generalizes the BackwardsGraph fake root into a more generalizable
class called SingleRootGraph. SingleRootGraph exposes the general graph interface
used in Dominators and NaturalLoops. SingleRootGraph takes as input a graph with
the normal graph interface, but also allows the input graph to contain more than
one root. SingleRootGraph then exposes a single root, which it creates, that has
an outgoing edge to all the roots in the original graph.

* WTF.xcodeproj/project.pbxproj:
* wtf/BackwardsGraph.h:
(WTF::BackwardsGraph::dump const):
(WTF::BackwardsGraph::rootName): Deleted.
(WTF::BackwardsGraph::Node::Node): Deleted.
(WTF::BackwardsGraph::Node::root): Deleted.
(WTF::BackwardsGraph::Node::operator== const): Deleted.
(WTF::BackwardsGraph::Node::operator!= const): Deleted.
(WTF::BackwardsGraph::Node::operator bool const): Deleted.
(WTF::BackwardsGraph::Node::isRoot const): Deleted.
(WTF::BackwardsGraph::Node::node const): Deleted.
(): Deleted.
(WTF::BackwardsGraph::Set::Set): Deleted.
(WTF::BackwardsGraph::Set::add): Deleted.
(WTF::BackwardsGraph::Set::remove): Deleted.
(WTF::BackwardsGraph::Set::contains): Deleted.
(WTF::BackwardsGraph::Set::dump const): Deleted.
(WTF::BackwardsGraph::Map::Map): Deleted.
(WTF::BackwardsGraph::Map::clear): Deleted.
(WTF::BackwardsGraph::Map::size const): Deleted.
(WTF::BackwardsGraph::Map::operator[]): Deleted.
(WTF::BackwardsGraph::Map::operator[] const): Deleted.
* wtf/Dominators.h:
(WTF::Dominators::Dominators):
(WTF::Dominators::forAllBlocksInIteratedDominanceFrontierOf):
(WTF::Dominators::forAllBlocksInPrunedIteratedDominanceFrontierOf):
(WTF::Dominators::iteratedDominanceFrontierOf const):
(WTF::Dominators::forAllBlocksInIteratedDominanceFrontierOfImpl const):
* wtf/SingleRootGraph.h: Added.
(WTF::SingleRootGraphNode::rootName):
(WTF::SingleRootGraphNode::SingleRootGraphNode):
(WTF::SingleRootGraphNode::root):
(WTF::SingleRootGraphNode::operator== const):
(WTF::SingleRootGraphNode::operator!= const):
(WTF::SingleRootGraphNode::operator bool const):
(WTF::SingleRootGraphNode::isRoot const):
(WTF::SingleRootGraphNode::node const):
(WTF::SingleRootGraphSet::add):
(WTF::SingleRootGraphSet::remove):
(WTF::SingleRootGraphSet::contains):
(WTF::SingleRootGraphSet::dump const):
(WTF::SingleRootMap::SingleRootMap):
(WTF::SingleRootMap::clear):
(WTF::SingleRootMap::size const):
(WTF::SingleRootMap::operator[]):
(WTF::SingleRootMap::operator[] const):
(WTF::SingleRootGraph::SingleRootGraph):
(WTF::SingleRootGraph::root const):
(WTF::SingleRootGraph::newMap):
(WTF::SingleRootGraph::successors const):
(WTF::SingleRootGraph::predecessors const):
(WTF::SingleRootGraph::index const):
(WTF::SingleRootGraph::node const):
(WTF::SingleRootGraph::numNodes const):
(WTF::SingleRootGraph::dump const):
(WTF::SingleRootGraph::assertIsConsistent const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221196 268f45cc-cd09-0410-ab3c-d52691b4dbfc