mjs [Tue, 30 Oct 2007 01:55:13 +0000 (01:55 +0000)]
Reviewed by Oliver.
- Give better error messages when sunspider-compare-results fails
* sunspider-compare-results:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27247
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Tue, 30 Oct 2007 01:54:47 +0000 (01:54 +0000)]
Reviewed by Maciej.
Do not allow control to reach end of non-void functions
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27246
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Tue, 30 Oct 2007 01:46:19 +0000 (01:46 +0000)]
ChangeLog entry for r27244
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27245
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Tue, 30 Oct 2007 01:44:54 +0000 (01:44 +0000)]
Reviewed by Maciej.
Add GTK+ convenience conversions for various primitives
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27244
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 30 Oct 2007 01:37:42 +0000 (01:37 +0000)]
Reviewed by Darin.
- fix Date tests to work in command-line SpiderMonkey
* tests/date-format-tofte.js:
* tests/date-format-xparb.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27243
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 30 Oct 2007 01:34:00 +0000 (01:34 +0000)]
Reviewed by Darin.
- Define good VectorTraits for LocalStorage entry for 0.5% speed improvement on SunSpider.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* kjs/LocalStorage.h: Added.
(KJS::LocalStorageEntry::LocalStorageEntry):
(WTF::):
* kjs/function.h:
* kjs/nodes.cpp:
(KJS::FunctionBodyNode::processDeclarationsForFunctionCode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27242
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Tue, 30 Oct 2007 01:31:18 +0000 (01:31 +0000)]
updated reviewers for my previous changelog.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27241
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Tue, 30 Oct 2007 01:30:22 +0000 (01:30 +0000)]
Reviewed by Maciej and Adam.
- Minor mac-side improvements including moving a function to a more
appropriate location, fixing a warning, and correctly checking
exceptions.
* Drosera/DebuggerDocument.cpp: Corrected the exception checking.
(DebuggerDocument::willExecuteStatement):
(DebuggerDocument::didEnterCallFrame):
(DebuggerDocument::willLeaveCallFrame):
(DebuggerDocument::windowScriptObjectAvailable):
(DebuggerDocument::callFunctionOnObject):
* Drosera/mac/DebuggerClient.mm: Fixes a warning.
* Drosera/mac/DebuggerDocumentPlatform.mm: Moved
webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
because it doesn't require the ServerConnection at all.
(NSStringCreateWithJSStringRef): Made an argument const.
(JSValueRefCreateWithNSString): Made an argument const.
(+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
(DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
* Drosera/mac/ServerConnection.h: Moved aforementioned function.
* Drosera/mac/ServerConnection.mm: Ditto.
(-[ServerConnection webView:didLoadMainResourceForDataSource:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27240
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 30 Oct 2007 00:49:03 +0000 (00:49 +0000)]
Rubber-stamped by Adam Roben.
Simplify the dataURL xxs tests.
* http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level.html:
* http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame.html:
* http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame.html:
* http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url.html:
* http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open.html:
* http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url.html:
* http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level.html:
* http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-window-open.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27239
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 30 Oct 2007 00:34:13 +0000 (00:34 +0000)]
Reviewed by Adam Roben.
Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(getGlobalFlagCallback):
(setGlobalFlagCallback):
(LayoutTestController::getJSClass):
(LayoutTestController::staticValues):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController::globalFlag):
(LayoutTestController::setGlobalFlag):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27238
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 30 Oct 2007 00:28:29 +0000 (00:28 +0000)]
SunSpider:
Reviewed by Maciej.
* sunspider: Added --shark20 option, to run Shark at its highest sample
resolution instead of its default.
WebKitTools:
Reviewed by Maciej.
* Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
resolution instead of its default.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27237
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
honeycutt [Mon, 29 Oct 2007 23:13:24 +0000 (23:13 +0000)]
2007-10-29 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Anders.
Speculative fix for <rdar://5538489> Safari 3.0.4 seed hangs at
http://tgmonline.futuregamer.it/ (works fine on Safari 2.0.4 and Safari
Beta for Mac)
I cannot reproduce this hang, but it is likely due to our not limiting
WM_USER+1 messages or InvalidateRect calls for a plugin with initially-
unknown MIME type. The embed tag on the page is missing a type
attribute, so as fallback, we choose to load the Flash plugin based on
the file extension of "swf." However, we do not record this determined
MIME type, and so our quirks cannot be established.
Changed findPlugin() so that, if it fails to find a plugin for the
given MIME type, it will lookup the MIME type for the file extension -
overwriting its passed MIME type parameter - and search for a plugin
for that MIME type.
* plugins/win/PluginDatabaseWin.cpp:
(WebCore::PluginDatabaseWin::pluginForMIMEType): Added an early return
if the MIME type is empty
(WebCore::PluginDatabaseWin::MIMETypeForExtension): Added to replace
pluginForExtension. Returns a String with the MIME type for the file
extension. Also, changed to use case-insensitive compares
(WebCore::PluginDatabaseWin::findPlugin): If we fail to find a plugin
for the given extension, overwrite the incoming MIME type parameter
with the MIME type for the file extension, and search for a plugin for
that MIME type. Also, changed the way that the extension is determined
(WebCore::PluginDatabaseWin::createPluginView): Pass a mutable String
to findPlugin() so that it can be updated if necessary
* plugins/win/PluginDatabaseWin.h: Changed findPlugin() to take a non-
const String, removed definition of pluginForExtension, added
definition for MIMETypeForExtension
* plugins/win/PluginPackageWin.cpp:
(WebCore::PluginPackageWin::fetchInfo): Store the MIME type in
lowercase for easier compares
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27236
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andrew [Mon, 29 Oct 2007 22:55:07 +0000 (22:55 +0000)]
Not reviewed - build fix
Fix Mac Build.
WebKit/WebCore/xml/XSLTProcessor.cpp:79: warning: 'level' may be used uninitialized
in this function
* xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::parseErrorFunc):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27235
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Mon, 29 Oct 2007 22:28:24 +0000 (22:28 +0000)]
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=15725
[GTK] WebCore.pro header dependencies are incorrect
Fix header dependencies in the build system
INCLUDEPATH and DEPENDPATH are now up to date.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27234
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 29 Oct 2007 22:16:10 +0000 (22:16 +0000)]
Upgrade WordPress.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27233
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 29 Oct 2007 21:46:19 +0000 (21:46 +0000)]
Files that have been added or modified on the server without making it in to SVN.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27232
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Mon, 29 Oct 2007 19:17:09 +0000 (19:17 +0000)]
Reviewed by Oliver Hunt.
Some small tweaks that I notice while reviewing Oliver's last patch.
Includes removal of an unnecessary KJS_CHECKEXCEPTIONVALUE.
No change in SunSpider because SunSpider doesn't take the code path that
would execute the unnecessary KJS_CHECKEXCEPTIONVALUE much.
* kjs/nodes.cpp:
(KJS::LocalVarPostfixNode::evaluate):
(KJS::TypeOfResolveNode::optimizeVariableAccess):
(KJS::LocalVarTypeOfNode::evaluate):
(KJS::PrefixResolveNode::optimizeVariableAccess):
(KJS::LocalVarPrefixNode::evaluate):
(KJS::AssignResolveNode::optimizeVariableAccess):
(KJS::LocalVarAssignNode::evaluate):
* kjs/nodes.h:
(KJS::LocalVarTypeOfNode::):
(KJS::PrefixResolveNode::):
(KJS::LocalVarPrefixNode::):
(KJS::AssignResolveNode::):
(KJS::LocalVarAssignNode::):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27231
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Mon, 29 Oct 2007 18:57:11 +0000 (18:57 +0000)]
A better build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27230
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Mon, 29 Oct 2007 18:50:06 +0000 (18:50 +0000)]
Build fix.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseTimingFunctionValue):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::mapTransitionTimingFunction):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27229
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Mon, 29 Oct 2007 18:22:44 +0000 (18:22 +0000)]
Land the back end for CSS animated property transitions. I am landing this in stages, so the AnimationController
class is deliberately left empty.
Reviewed by darin/aroben
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSPropertyNames.in:
* css/CSSTimingFunctionValue.cpp: Added.
(WebCore::CSSTimingFunctionValue::cssText):
* css/CSSTimingFunctionValue.h: Added.
(WebCore::CSSTimingFunctionValue::CSSTimingFunctionValue):
(WebCore::CSSTimingFunctionValue::firstPoint):
(WebCore::CSSTimingFunctionValue::secondPoint):
* css/CSSValueKeywords.in:
* history/CachedPage.cpp:
(WebCore::CachedPage::restore):
* page/AnimationController.cpp: Added.
(WebCore::AnimationController::AnimationController):
(WebCore::AnimationController::~AnimationController):
(WebCore::AnimationController::cancelTransitions):
(WebCore::AnimationController::updateTransitions):
(WebCore::AnimationController::suspendAnimations):
(WebCore::AnimationController::resumeAnimations):
* page/AnimationController.h: Added.
* page/Frame.cpp:
(WebCore::Frame::animationController):
(WebCore::Frame::clearTimers):
* page/Frame.h:
* page/FramePrivate.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::setStyle):
(WebCore::RenderBox::destroy):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::animationController):
* rendering/RenderObject.h:
* rendering/RenderStyle.cpp:
(WebCore::Transition::Transition):
(WebCore::Transition::~Transition):
(WebCore::Transition::operator=):
(WebCore::Transition::operator==):
(WebCore::Transition::fillUnsetProperties):
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
(WebCore::StyleRareNonInheritedData::transitionDataEquivalent):
(WebCore::RenderStyle::diff):
(WebCore::RenderStyle::adjustTransitions):
(WebCore::RenderStyle::accessTransitions):
* rendering/RenderStyle.h:
(WebCore::BackgroundLayer::next):
(WebCore::):
(WebCore::TimingFunction::TimingFunction):
(WebCore::TimingFunction::operator==):
(WebCore::Transition::next):
(WebCore::Transition::isTransitionDurationSet):
(WebCore::Transition::isTransitionRepeatCountSet):
(WebCore::Transition::isTransitionTimingFunctionSet):
(WebCore::Transition::isTransitionPropertySet):
(WebCore::Transition::isEmpty):
(WebCore::Transition::clearTransitionDuration):
(WebCore::Transition::clearTransitionRepeatCount):
(WebCore::Transition::clearTransitionTimingFunction):
(WebCore::Transition::clearTransitionProperty):
(WebCore::Transition::transitionDuration):
(WebCore::Transition::transitionRepeatCount):
(WebCore::Transition::transitionTimingFunction):
(WebCore::Transition::transitionProperty):
(WebCore::Transition::setTransitionDuration):
(WebCore::Transition::setTransitionRepeatCount):
(WebCore::Transition::setTransitionTimingFunction):
(WebCore::Transition::setTransitionProperty):
(WebCore::Transition::setNext):
(WebCore::Transition::operator!=):
(WebCore::RenderStyle::transitions):
(WebCore::RenderStyle::clearTransitions):
(WebCore::RenderStyle::inheritTransitions):
(WebCore::RenderStyle::initialTransitionDuration):
(WebCore::RenderStyle::initialTransitionRepeatCount):
(WebCore::RenderStyle::initialTransitionTimingFunction):
(WebCore::RenderStyle::initialTransitionProperty):
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::destroy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27228
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Mon, 29 Oct 2007 17:02:51 +0000 (17:02 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=6040
XSLT does not report errors to the user
Made parseErrorFunc a static member function of XSLTProcessor to be reusable from XSLStylesheet.
Switched to xmlSetStructuredErrorFunc to get an error structure instead of pre-formatted console
output. Got rid of DeprecatedString in XSLTProcessor.
* dom/Document.cpp:
(WebCore::Document::applyXSLTransform):
* xml/XSLStyleSheet.cpp:
(WebCore::XSLStyleSheet::parseString):
* xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::parseErrorFunc):
(WebCore::docLoaderFunc):
(WebCore::setXSLTLoadCallBack):
(WebCore::writeToString):
(WebCore::saveResultToString):
(WebCore::transformTextStringToXHTMLDocumentString):
(WebCore::xsltParamArrayFromParameterMap):
(WebCore::freeXsltParamArray):
(WebCore::XSLTProcessor::createDocumentFromSource):
(WebCore::createFragmentFromSource):
(WebCore::xsltStylesheetPointer):
(WebCore::xmlDocPtrFromNode):
(WebCore::resultMIMEType):
(WebCore::XSLTProcessor::transformToString):
(WebCore::XSLTProcessor::transformToDocument):
(WebCore::XSLTProcessor::transformToFragment):
* xml/XSLTProcessor.h:
(WebCore::XSLTProcessor::setXSLStylesheet):
(WebCore::XSLTProcessor::importStylesheet):
(WebCore::XSLTProcessor::xslStylesheet):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27227
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Mon, 29 Oct 2007 16:34:19 +0000 (16:34 +0000)]
Fixed showStatus() to print status for successfully resolved conflicts when using git.
Reviewed by Mark Rowe.
Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
was successfully resolved, but this would not show any status because the change had
already been cached in the index using "git add". The solution is to add an optional
second argument to showStatus() which adds the "--cached" switch to the command.
* Scripts/resolve-ChangeLogs:
(showStatus):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27226
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Mon, 29 Oct 2007 16:28:07 +0000 (16:28 +0000)]
Reviewed by Mitz.
Test for http://bugs.webkit.org/show_bug.cgi?id=10030
Star Alliance site is opened without the main frame
* fast/frames/location-change-expected.txt: Added.
* fast/frames/location-change.html: Added.
* fast/frames/resources/location-change-frame-1.html: Added.
* fast/frames/resources/location-change-frame-2.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27225
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz [Mon, 29 Oct 2007 16:02:22 +0000 (16:02 +0000)]
WebCore:
Reviewed by John Sullivan.
- fix <rdar://problem/5424455> REGRESSION (r21168-r21193, Tiger only): Safari scrollbar is clipped at top when loading particular RSS page
Test: fast/repaint/layout-state-only-posiitoned.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutOnlyPositionedObjects): Pop layout state
before updating scroll info, which possibly repaints us.
LayoutTests:
Reviewed by John Sullivan,
- repaint test for <rdar://problem/5424455> REGRESSION (r21168-r21193, Tiger only): Safari scrollbar is clipped at top when loading particular RSS page
* fast/repaint/layout-state-only-posiitoned.html: Added.
* platform/mac/fast/repaint/layout-state-only-posiitoned-expected.checksum: Added.
* platform/mac/fast/repaint/layout-state-only-posiitoned-expected.png: Added.
* platform/mac/fast/repaint/layout-state-only-posiitoned-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27224
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Mon, 29 Oct 2007 10:31:09 +0000 (10:31 +0000)]
WebCore:
REGRESSION (r17701): Favicons should be viewable as image documents
<http://bugs.webkit.org/show_bug.cgi?id=15640>
Reviewed by Darin.
On Tiger and Leopard, the image/x-icon MIME type is not returned from
CGImageSourceCopyTypeIdentifiers(), so opening a URL to a favicon caused
the icon to be downloaded instead being displayed in an image document.
Test: fast/images/favicon-as-image.html
* platform/MIMETypeRegistry.cpp:
(WebCore::initialiseSupportedImageMIMETypes): Manually add image/x-icon to
supportedImageMIMETypes and supportedImageResourceMIMETypes. Also fixed
comment about the image/bmp MIME type since it applies to both Tiger and
Leopard.
LayoutTests:
Test for: REGRESSION (r17701): Favicons should be viewable as image documents
<http://bugs.webkit.org/show_bug.cgi?id=15640>
Reviewed by Darin.
* fast/images/favicon-as-image.html: Added.
* fast/images/resources/favicon.ico: Added.
* platform/mac/fast/images/favicon-as-image-expected.checksum: Added.
* platform/mac/fast/images/favicon-as-image-expected.png: Added.
* platform/mac/fast/images/favicon-as-image-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27223
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Mon, 29 Oct 2007 09:14:08 +0000 (09:14 +0000)]
2007-10-29 Eric Seidel <eric@webkit.org>
Reviewed by Maciej.
SunSpider claims this was a 0.7% speedup.
* kjs/string_object.cpp:
(KJS::StringProtoFunc::callAsFunction): avoid mallocing a jsString in the common case
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27222
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 29 Oct 2007 08:44:44 +0000 (08:44 +0000)]
JavaScriptCore:
Reviewed by Mark.
- re-enable asserts for access to empty or deleted keys
* wtf/HashTable.h:
(WTF::::lookup):
(WTF::::lookupForWriting):
(WTF::::fullLookupForWriting):
(WTF::::add):
WebCore:
Reviewed by Mark.
- fixed assertion failures detected by the new assertions
* bindings/objc/DOMRGBColor.mm:
(-[DOMRGBColor dealloc]): Clear _internal before calling [super dealloc]
because it's not a pointer and shouldn't be in the normal wrapper cache.
* dom/Document.cpp:
(WebCore::Document::addImageMap): Don't access hashmap if name is null.
(WebCore::Document::removeImageMap): ditto
* dom/StyledElement.cpp:
(WebCore::StyledElement::parseMappedAttribute): Don't claim we have a class
when the class attribute is empty.
* platform/TextCodecICU.cpp:
(WebCore::gbkCallbackEscape): Don't look up 0 code points.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27221
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Mon, 29 Oct 2007 08:32:37 +0000 (08:32 +0000)]
2007-10-29 Eric Seidel <eric@webkit.org>
Build fix only, no review.
* JavaScriptCore.exp: Export symbol for new StringInstance::getOwnPropertySlot
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27220
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 29 Oct 2007 08:31:46 +0000 (08:31 +0000)]
2007-10-29 Mark Rowe <mrowe@apple.com>
Gtk build fix. Move struct declarations into nodes.h.
* kjs/grammar.y:
* kjs/nodes.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27219
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Mon, 29 Oct 2007 07:55:34 +0000 (07:55 +0000)]
2007-10-29 Eric Seidel <eric@webkit.org>
Reviewed by darin.
Give StringInstance a getOwnPropertySlot(ExecState, unsigned, PropertySlot) fastpath, just like Arrays.
Make it a compile time error to use toString(ExecState) on a StringInstance
SunSpider claims this was a 6.6% speedup overall (22% on string-base64)
* kjs/internal.h:
(KJS::StringImp::getLength):
* kjs/string_object.cpp:
(KJS::StringInstance::lengthGetter):
(KJS::StringInstance::inlineGetOwnPropertySlot):
(KJS::StringInstance::getOwnPropertySlot):
* kjs/string_object.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27218
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Mon, 29 Oct 2007 07:21:17 +0000 (07:21 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=10734
Made HTMLOptionElement.index read-only, matching IE and DOM standard.
Test: fast/dom/HTMLOptionElement/set-option-index-text.html
* html/HTMLOptionElement.idl: Marked index as readonly.
* html/HTMLOptionElement.cpp:
* html/HTMLOptionElement.h:
Removed setIndex().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27217
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Mon, 29 Oct 2007 07:05:49 +0000 (07:05 +0000)]
Added nodes to allow Assignment, TypeOf, and prefix operators to
make use of the new optimised local variable look up.
5% gain on sunspider
Reviewed by Darin
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27216
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 29 Oct 2007 06:49:54 +0000 (06:49 +0000)]
Reviewed by Darin.
- avoid creating and then breaking circular lists in the parser, instead track head and tail pointers at parse time
http://bugs.webkit.org/show_bug.cgi?id=15748
Not a significant speedup or slowdown on SunSpider.
* kjs/Parser.cpp:
(KJS::clearNewNodes):
* kjs/Parser.h:
* kjs/grammar.y:
* kjs/nodes.cpp:
(KJS::BlockNode::BlockNode):
(KJS::CaseBlockNode::CaseBlockNode):
(KJS::FunctionBodyNode::FunctionBodyNode):
(KJS::SourceElementsNode::SourceElementsNode):
(KJS::ProgramNode::ProgramNode):
* kjs/nodes.h:
(KJS::ElementNode::):
(KJS::ArrayNode::):
(KJS::PropertyListNode::):
(KJS::ObjectLiteralNode::):
(KJS::ArgumentListNode::):
(KJS::ArgumentsNode::):
(KJS::VarDeclListNode::):
(KJS::VarStatementNode::):
(KJS::ForNode::):
(KJS::ParameterNode::):
(KJS::FuncExprNode::):
(KJS::FuncDeclNode::):
(KJS::SourceElementsNode::):
(KJS::CaseClauseNode::):
(KJS::ClauseListNode::):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27215
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 29 Oct 2007 06:25:40 +0000 (06:25 +0000)]
2007-10-28 Mark Rowe <mrowe@apple.com>
Disable assertions in a manner that doesn't break the Qt Windows build.
* wtf/HashTable.h:
(WTF::::lookup):
(WTF::::lookupForWriting):
(WTF::::fullLookupForWriting):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27214
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Mon, 29 Oct 2007 06:14:49 +0000 (06:14 +0000)]
Temporarily disabling some ASSERTs I introduced in my last check-in
because of http://bugs.webkit.org/show_bug.cgi?id=15747
Lots of layout tests fail the !HashTranslator::equal(KeyTraits::emptyValue() ASSERT
* wtf/HashTable.h:
(WTF::::lookup):
(WTF::::lookupForWriting):
(WTF::::fullLookupForWriting):
(WTF::::add):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27213
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Mon, 29 Oct 2007 06:13:02 +0000 (06:13 +0000)]
Fix SunSpider on Windows
Reviewed by Eric.
* sunspider: Don't use colons in filenames.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27212
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Mon, 29 Oct 2007 05:53:48 +0000 (05:53 +0000)]
Reviewed by Darin Adler.
Fixed http://bugs.webkit.org/show_bug.cgi?id=15746
#ifndef ASSERT_DISABLED is no good!
Replaced with #if !ASSERT_DISABLED.
* wtf/HashTable.h:
(WTF::::lookup):
(WTF::::lookupForWriting):
(WTF::::fullLookupForWriting):
(WTF::::add):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27211
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Mon, 29 Oct 2007 05:32:23 +0000 (05:32 +0000)]
Reviewed by Darin Adler.
Added FunctionCallResolveNode, PostfixResolveNode, and DeleteResolveNode
to the AST transfom that replaces slow resolve nodes with fast local
variable alternatives.
2.5% speedup on SunSpider.
Also added some missing copyright notices.
* kjs/nodes.cpp:
(KJS::FunctionCallResolveNode::optimizeVariableAccess):
(KJS::FunctionCallResolveNode::evaluate):
(KJS::LocalVarFunctionCallNode::evaluate):
(KJS::PostfixResolveNode::optimizeVariableAccess):
(KJS::PostfixResolveNode::evaluate):
(KJS::LocalVarPostfixNode::evaluate):
(KJS::DeleteResolveNode::optimizeVariableAccess):
(KJS::DeleteResolveNode::evaluate):
(KJS::LocalVarDeleteNode::evaluate):
* kjs/nodes.h:
(KJS::FunctionCallResolveNode::):
(KJS::LocalVarFunctionCallNode::LocalVarFunctionCallNode):
(KJS::PostfixResolveNode::):
(KJS::LocalVarPostfixNode::LocalVarPostfixNode):
(KJS::DeleteResolveNode::):
(KJS::LocalVarDeleteNode::LocalVarDeleteNode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27210
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Mon, 29 Oct 2007 04:53:26 +0000 (04:53 +0000)]
2007-10-28 Eric Seidel <eric@webkit.org>
Reviewed by darin.
Inline UString::Rep::deref() for a 0.8% improvement in SunSpider
Add virtual keyword to a few virtual functions previously unmarked.
* kjs/internal.h:
(KJS::StringImp::type):
(KJS::NumberImp::type):
* kjs/ustring.h:
(KJS::UString::Rep::deref):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27209
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 29 Oct 2007 04:37:37 +0000 (04:37 +0000)]
- fix "broken everything" from the storage leak fix
* wtf/RefPtr.h: (WTF::RefPtr::RefPtr): Added a PlacementNewAdopt constructor.
* kjs/ustring.h: (KJS::UString::UString): Pass PlacementNewAdopt along to RefPtr.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27208
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 29 Oct 2007 04:31:54 +0000 (04:31 +0000)]
Reviewed by Adam.
- turn on unused parameter waring on Mac OS X because it's already on elsewhere
* Configurations/Base.xcconfig: Took out -wno-unused-parameter.
* API/JSNode.c:
* API/JSNodeList.c:
* API/minidom.c:
* API/testapi.c:
Fixed unused variables by using them or marked them with UNUSED_PARAM.
* kjs/CollectorHeapIntrospector.h: (KJS::CollectorHeapIntrospector::zoneCalloc):
Removed parameter names to indicate they are unused.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27207
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 29 Oct 2007 04:11:37 +0000 (04:11 +0000)]
Reviewed by Maciej.
- fix a storage leak where we ref the UString every time we replace
a ResolveNode with a LocalVarAccessNode
* kjs/identifier.h: (KJS::Identifier::Identifier): Added a constructor
that takes PlacementNewAdopt.
* kjs/nodes.h: (KJS::ResolveNode::ResolveNode): Initialize the ident
with PlacementNewAdopt instead of the old value of ident.
* kjs/ustring.h: (KJS::UString::UString): Added a constructor that
takes PlacementNewAdopt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27206
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Mon, 29 Oct 2007 04:04:03 +0000 (04:04 +0000)]
2007-10-28 Eric Seidel <eric@webkit.org>
Reviewed by aroben.
* platform/mac/svg/custom/path-bad-data-expected.txt: updated to better results
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27205
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 29 Oct 2007 04:02:53 +0000 (04:02 +0000)]
- Windows build fix; get rid of unused parameter
* kjs/nodes.cpp: (KJS::ResolveNode::optimizeVariableAccess): Don't pass it.
* kjs/nodes.h: (KJS::LocalVarAccessNode::LocalVarAccessNode): Remove it.
The assertions weren't all that helpful.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27204
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Mon, 29 Oct 2007 03:48:43 +0000 (03:48 +0000)]
2007-10-28 Eric Seidel <eric@webkit.org>
Reviewed by darin.
Fix leaks on TOT and prevent Path code from logging to console so frequently
* platform/graphics/svg/SVGResourceFilter.h:
(WebCore::SVGResourceFilterPlatformData::SVGResourceFilterPlatformData):
(WebCore::SVGResourceFilterPlatformData::~SVGResourceFilterPlatformData):
* platform/graphics/svg/cg/CgSupport.cpp:
(WebCore::strokeBoundingBox):
* platform/graphics/svg/cg/SVGResourceFilterCg.mm:
* platform/graphics/svg/mac/SVGResourceFilterPlatformDataMac.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27203
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 29 Oct 2007 03:00:16 +0000 (03:00 +0000)]
2007-10-28 Mark Rowe <mrowe@apple.com>
Gtk build fix. Add include of MathExtras.h.
* kjs/string_object.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27202
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 29 Oct 2007 02:52:04 +0000 (02:52 +0000)]
2007-10-28 Mark Rowe <mrowe@apple.com>
Reviewed by Maciej and Tim.
Replace uses of isNaN and isInf with isnan and isinf, and
remove isNaN and isInf.
* kjs/config.h: Remove unused HAVE_'s
* kjs/date_object.cpp:
(KJS::DateInstance::getTime):
(KJS::DateInstance::getUTCTime):
(KJS::DateProtoFunc::callAsFunction):
(KJS::DateObjectImp::construct):
(KJS::DateObjectFuncImp::callAsFunction):
* kjs/function.cpp:
(KJS::GlobalFuncImp::callAsFunction):
* kjs/math_object.cpp:
(MathFuncImp::callAsFunction):
* kjs/nodes2string.cpp:
(KJS::isParserRoundTripNumber):
* kjs/number_object.cpp:
(NumberProtoFunc::callAsFunction):
* kjs/operations.cpp:
* kjs/operations.h:
* kjs/string_object.cpp:
(KJS::StringProtoFunc::callAsFunction):
* kjs/ustring.cpp:
(KJS::UString::from):
* kjs/value.cpp:
(KJS::JSValue::toInteger):
(KJS::JSValue::toInt32SlowCase):
(KJS::JSValue::toUInt32SlowCase):
2007-10-28 Mark Rowe <mrowe@apple.com>
Reviewed by Maciej.
Replace uses of isNaN and isInf with isnan and isinf.
* bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::JSHTMLOptionsCollection::setLength):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27201
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Mon, 29 Oct 2007 02:08:18 +0000 (02:08 +0000)]
Build fix: use the new-fangled missingSymbolMarker().
* kjs/nodes.cpp:
(KJS::ResolveNode::optimizeVariableAccess):
* kjs/nodes.h:
(KJS::LocalVarAccessNode::LocalVarAccessNode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27200
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Mon, 29 Oct 2007 02:00:57 +0000 (02:00 +0000)]
Reviewed by Maciej Stachowiak, Darin Adler.
Much supporting work done by Maciej Stachowiak, Maks Orlovich, and
Cameron Zwarich.
AST transfom to replace slow resolve nodes with fast local variable
alternatives that do direct memory access. Currently, only ResolveNode
provides a fast local variable alternative. 6 others are soon to come.
16.7% speedup on SunSpider.
Most of this patch is just scaffolding to support iterating all the
resolve nodes in the AST through optimizeResolveNodes(). In
optimizeResolveNodes(), most classes just push their child nodes onto
the processing stack, while ResolveNodes actually replace themselves in
the tree with more optimized alternatives, if possible.
Here are the interesting bits:
* kjs/nodes.h: Added PlacementNewAdoptTag, along with implementations
in Node and ResolveNode. This tag allows you to use placement new to
swap out a base class Node in favor of a subclass copy that holds the
same data. (Without this tag, default initialization would NULL out
RefPtrs, change line numbers, etc.)
* kjs/nodes.cpp:
(KJS::ResolveNode::evaluate): Since we're taking the slow path, ASSERT
that the fast path is impossible, to make sure we didn't leave anything
on the table.
(KJS::FunctionBodyNode::optimizeResolveNodes): Here's where the AST
transformation happens.
(KJS::ResolveNode::optimizeResolveNodes): Here's where the ResolveNode
optimization happens.
* kjs/function.h: Added symbolTable() accessor for, for the sake of
an ASSERT.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27199
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 29 Oct 2007 01:56:05 +0000 (01:56 +0000)]
2007-10-28 Mark Rowe <mrowe@apple.com>
Reviewed by Maciej.
Fix "AllInOneFile.o has a global initializer in it".
Some versions of gcc generate a global initializer for std::numeric_limits<size_t>::max().
We can avoid this by moving it inside an inline function.
* kjs/SymbolTable.h:
(KJS::missingSymbolMarker):
* kjs/function.cpp:
(KJS::ActivationImp::getOwnPropertySlot):
(KJS::ActivationImp::put):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27198
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Mon, 29 Oct 2007 01:50:50 +0000 (01:50 +0000)]
2007-10-28 Eric Seidel <eric@webkit.org>
Reviewed by Maciej and Geoff, in unison.
* Scripts/run-webkit-tests: remove broken --svg option
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27197
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 29 Oct 2007 01:29:48 +0000 (01:29 +0000)]
JavaScriptCore:
Reviewed by Mark.
- Added assertions to protect against adding empty or deleted keys to a HashTable
* wtf/HashTable.h:
(WTF::HashTable::lookup):
(WTF::HashTable::lookupForWriting):
(WTF::HashTable::fullLookupForWriting):
(WTF::HashTable::add):
WebCore:
Reviewed by Mark.
- fixed REGRESSION(r27176): Reproducible crash while trying to order dinner makes bdash sad
http://bugs.webkit.org/show_bug.cgi?id=15731
* bindings/js/kjs_window.cpp:
(KJS::Window::installTimeout): Avoid putting in or accessing empty or deleted keys.
(KJS::Window::clearTimeout): ditto
* manual-tests/bad-clearTimeout-crash.html: Added. Automated test not possible.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27196
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Mon, 29 Oct 2007 00:14:52 +0000 (00:14 +0000)]
Remove IDLs from the Copy Bundle Resources phase.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27195
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 28 Oct 2007 23:08:44 +0000 (23:08 +0000)]
Reviewed by Adam.
* resources/sunspider-analyze-results.js: Tweak the output format a little.
Change so that when there's only one run we don't write out confidence
intervals at all rather than writing "NaN" over and over again.
* sunspider: Use the time and date as a suffix on the results file, that way
all the results are left behind in the tmp directory. This will make it easy
for us to add features that compare past results in the future. Also rename
the .mshark files using the same scheme.
* sunspider-compare-results: Relax the parsing rules so we can parse the
results file exactly as it's emitted from sunspider.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27194
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 28 Oct 2007 23:06:27 +0000 (23:06 +0000)]
- fix GTK build
* kjs/nodes2string.cpp: (KJS::isParserRoundTripNumber):
Use isNaN and isInf instead of isnan and isinf.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27193
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 28 Oct 2007 23:00:12 +0000 (23:00 +0000)]
Reviewed by Adam.
* Scripts/run-sunspider: Default to "Release" configuration rather than
defaulting to the last configuration used as other scripts do. This can
still be overriden on the command line with "--debug" if there's some
reason to do so. Also fix a typo.
* Scripts/sunspider-compare-results: Fix a typo.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27192
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 28 Oct 2007 22:50:59 +0000 (22:50 +0000)]
JavaScriptCore:
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15735
remove GroupNode to simplify AST and possibly get a modest speedup
This patch removes 4 node types: GroupNode, PropertyNameNode,
FunctionCallParenBracketNode, and FunctionCallParenDotNode.
To remove GroupNode, we add knowledge of precedence to the tree nodes,
and use that when serializing to determine where parentheses are needed.
This means we no longer have to represent parentheses in the tree.
The precedence values are named after productions in the grammar from the
JavaScript standard.
SunSpider says this is an 0.4% speedup.
* kjs/function.h:
* kjs/function.cpp: Removed escapeStringForPrettyPrinting -- it's part of
serialization, so I moved it to the file that takes care of that.
* kjs/grammar.y: Changed makeGetterOrSetterPropertyNode to use 0 to
indicate failure instead of a separate boolean. Got rid of PropertyNameNode
by merging the PropertyName rule into the Property rule (which was easier
than figuring out how to pass the Identifier from one node to another).
Got rid of GroupNode, nodeInsideAllParens(), FunctionCallParenBracketNode,
and FunctionCallParenDotNode.
* kjs/nodes.h: Removed unused forward declarations and Operator values.
Added Precedence enum, and precedence function to all nodes. Removed
nodeInsideAllParens. Added streamBinaryOperator function for serialization.
Removed GroupNode and PropertyNameNode. Made PropertyNode store an Identifier.
Removed FunctionCallParenBracketNode and FunctionCallParenDotNode.
* kjs/nodes.cpp: Removed Node::nodinsideAllParens, GroupNode, and PropertyNameNode.
(KJS::PropertyListNode::evaluate): Changed code to get name directly instead
of converting it from an Identifier to a jsString then back to a UString
then into an Identifier again!
* kjs/nodes2string.cpp: Changed special-token implementation to use a separate
function for each of Endl, Indent, Unindent, and DotExpr instead of using a
single function with a switch. Added a precedence that you can stream in, to
cause the next node serialized to add parentheses based on that precedence value.
(KJS::operatorString): Moved to the top of the file.
(KJS::escapeStringForPrettyPrinting): Moved here from function.cpp. Removed old
workaround for snprintf, since StringExtras.h takes care of that.
(KJS::operator<<): Made the char and char* versions faster by using UString's
character append functions instead of constructing a UString. Added the logic
to the Node* version to add parentheses if needed.
(KJS::Node::streamLeftAssociativeBinaryOperator): Added helper function.
(KJS::ElementNode::streamTo): Use PrecAssignment for the elements.
(KJS::BracketAccessorNode::streamTo): Use PrecCall for the expression before
the bracket.
(KJS::DotAccessorNode::streamTo): Use PrecCall for the expression before the dot.
(KJS::ArgumentListNode::streamTo): Use PrecAssignment for the arguments.
(KJS::NewExprNode::streamTo): Use PrecMember for the expression.
(KJS::FunctionCallValueNode::streamTo): Use PrecCall.
(KJS::FunctionCallBracketNode::streamTo): Ditto.
(KJS::FunctionCallDotNode::streamTo): Ditto.
(KJS::PostfixBracketNode::streamTo): Ditto.
(KJS::PostfixDotNode::streamTo): Ditto.
(KJS::PostfixErrorNode::streamTo): Use PrecLeftHandSide.
(KJS::DeleteBracketNode::streamTo): Use PrecCall.
(KJS::DeleteDotNode::streamTo): Ditto.
(KJS::DeleteValueNode::streamTo): Use PrecUnary.
(KJS::VoidNode::streamTo): Ditto.
(KJS::TypeOfValueNode::streamTo): Ditto.
(KJS::PrefixBracketNode::streamTo): Use PrecCall.
(KJS::PrefixDotNode::streamTo): Ditto.
(KJS::PrefixErrorNode::streamTo): Use PrecUnary.
(KJS::UnaryPlusNode::streamTo): Ditto.
(KJS::NegateNode::streamTo): Ditto.
(KJS::BitwiseNotNode::streamTo): Ditto.
(KJS::LogicalNotNode::streamTo): Ditto.
(KJS::MultNode::streamTo): Use streamLeftAssociativeBinaryOperator.
(KJS::DivNode::streamTo): Ditto.
(KJS::ModNode::streamTo): Ditto.
(KJS::AddNode::streamTo): Ditto.
(KJS::SubNode::streamTo): Ditto.
(KJS::LeftShiftNode::streamTo): Ditto.
(KJS::RightShiftNode::streamTo): Ditto.
(KJS::UnsignedRightShiftNode::streamTo): Ditto.
(KJS::LessNode::streamTo): Ditto.
(KJS::GreaterNode::streamTo): Ditto.
(KJS::LessEqNode::streamTo): Ditto.
(KJS::GreaterEqNode::streamTo): Ditto.
(KJS::InstanceOfNode::streamTo): Ditto.
(KJS::InNode::streamTo): Ditto.
(KJS::EqualNode::streamTo): Ditto.
(KJS::NotEqualNode::streamTo): Ditto.
(KJS::StrictEqualNode::streamTo): Ditto.
(KJS::NotStrictEqualNode::streamTo): Ditto.
(KJS::BitAndNode::streamTo): Ditto.
(KJS::BitXOrNode::streamTo): Ditto.
(KJS::BitOrNode::streamTo): Ditto.
(KJS::LogicalAndNode::streamTo): Ditto.
(KJS::LogicalOrNode::streamTo): Ditto.
(KJS::ConditionalNode::streamTo): Ditto.
(KJS::AssignResolveNode::streamTo): Use PrecAssignment for the right side.
(KJS::AssignBracketNode::streamTo): Use PrecCall for the expression before
the bracket and PrecAssignment for the right side.
(KJS::AssignDotNode::streamTo): Ditto.
(KJS::AssignErrorNode::streamTo): Use PrecLeftHandSide for the left side
and PrecAssignment for the right side.
(KJS::CommaNode::streamTo): Use PrecAssignment for both expressions.
(KJS::AssignExprNode::streamTo): Use PrecAssignment.
LayoutTests:
Reviewed by Maciej.
- test for http://bugs.webkit.org/show_bug.cgi?id=15735
remove GroupNode to simplify AST and possibly get a modest speedup
One test is a start at testing that parentheses are added when needed.
The other test checks some aspects of object literals, since I changed
the way the property names is handled in those. More tests are needed.
* fast/js/function-toString-object-literals-expected.txt: Added.
* fast/js/function-toString-object-literals.html: Added.
* fast/js/function-toString-parentheses-expected.txt: Added.
* fast/js/function-toString-parentheses.html: Added.
* fast/js/resources/function-toString-object-literals.js: Added.
* fast/js/resources/function-toString-parentheses.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27191
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino [Sun, 28 Oct 2007 21:27:17 +0000 (21:27 +0000)]
wx port defines for graphics and network layers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27190
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Sun, 28 Oct 2007 21:09:42 +0000 (21:09 +0000)]
Reviewed by Anders Carlsson.
http://bugs.webkit.org/show_bug.cgi?id=14124
[CURL] Support data URLs
Add data URL support (both Base64 and percent-encoded formats).
Inspired by code from the Qt port.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27189
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Sun, 28 Oct 2007 20:23:11 +0000 (20:23 +0000)]
http://bugs.webkit.org/show_bug.cgi?id=15701
The curl http backend does not deal properly with redirects
Implement http redirect support.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27188
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino [Sun, 28 Oct 2007 19:18:04 +0000 (19:18 +0000)]
Add the defines, platform types and options needed for the wx port.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27187
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sun, 28 Oct 2007 18:20:05 +0000 (18:20 +0000)]
2007-10-28 Mark Rowe <mrowe@apple.com>
We don't include "config.h" in headers.
* bindings/jni/jni_instance.h:
* kjs/regexp.h:
* wtf/TCPageMap.h:
* wtf/TCSpinLock.h:
2007-10-28 Mark Rowe <mrowe@apple.com>
We don't include "config.h" in headers.
* dom/XMLTokenizer.h:
* platform/graphics/svg/SVGResourceFilter.h:
* platform/image-decoders/ImageDecoder.h:
* platform/wx/FontPlatformData.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27186
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 28 Oct 2007 17:41:44 +0000 (17:41 +0000)]
Removed some "Reviewed by NOBODY".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27185
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 28 Oct 2007 17:37:22 +0000 (17:37 +0000)]
Removed some "Reviewed by NOBODY".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27184
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 28 Oct 2007 17:36:21 +0000 (17:36 +0000)]
Removed some "Reviewed by NOBODY".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27183
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 28 Oct 2007 17:31:11 +0000 (17:31 +0000)]
* platform/graphics/svg/mac/SVGResourceFilterPlatformDataMac.h:
We don't include "config.h" in headers. Hope this desn't break
the non-SVG build again.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27182
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 28 Oct 2007 17:22:44 +0000 (17:22 +0000)]
- try to fix Windows build
* WebKit.vcproj/WebKit.vcproj: Suppress warning 4800 (conversion to bool),
since we don't want to add !! everywhere, and because HashTable.h has a
conversion to bool of this type now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27181
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Sun, 28 Oct 2007 11:47:41 +0000 (11:47 +0000)]
2007-10-28 Eric Seidel <eric@webkit.org>
Build fix for non-SVG build, no review.
* platform/graphics/svg/mac/SVGResourceFilterPlatformDataMac.h:
* platform/graphics/svg/mac/SVGResourceFilterPlatformDataMac.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27180
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Sun, 28 Oct 2007 10:34:24 +0000 (10:34 +0000)]
2007-10-28 Eric Seidel <eric@webkit.org>
Reviewed by Oliver.
Push SVGResourceFilter platform specific data down into m_platformData
in preparation for implementing a non-mac filter solution.
Also update a very old email address in copyright headers
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/FloatPoint3D.cpp:
(WebCore::FloatPoint3D::FloatPoint3D):
* platform/graphics/FloatPoint3D.h:
* platform/graphics/svg/SVGResourceFilter.cpp:
(WebCore::SVGResourceFilter::SVGResourceFilter):
* platform/graphics/svg/SVGResourceFilter.h:
(WebCore::SVGResourceFilter::platformData):
(WebCore::SVGResourceFilter::effects):
* platform/graphics/svg/cg/SVGResourceFilterCg.mm:
(WebCore::SVGResourceFilter::createPlatformData):l
(WebCore::SVGResourceFilter::prepareFilter):
(WebCore::SVGResourceFilter::applyFilter):
* platform/graphics/svg/filters/SVGDistantLightSource.h:
* platform/graphics/svg/filters/SVGFEBlend.cpp:
* platform/graphics/svg/filters/SVGFEBlend.h:
* platform/graphics/svg/filters/SVGFEColorMatrix.cpp:
* platform/graphics/svg/filters/SVGFEColorMatrix.h:
* platform/graphics/svg/filters/SVGFEComponentTransfer.cpp:
* platform/graphics/svg/filters/SVGFEComponentTransfer.h:
* platform/graphics/svg/filters/SVGFEComposite.cpp:
* platform/graphics/svg/filters/SVGFEComposite.h:
* platform/graphics/svg/filters/SVGFEConvolveMatrix.cpp:
* platform/graphics/svg/filters/SVGFEConvolveMatrix.h:
* platform/graphics/svg/filters/SVGFEDiffuseLighting.cpp:
* platform/graphics/svg/filters/SVGFEDiffuseLighting.h:
* platform/graphics/svg/filters/SVGFEDisplacementMap.cpp:
* platform/graphics/svg/filters/SVGFEDisplacementMap.h:
* platform/graphics/svg/filters/SVGFEFlood.cpp:
* platform/graphics/svg/filters/SVGFEFlood.h:
* platform/graphics/svg/filters/SVGFEGaussianBlur.cpp:
* platform/graphics/svg/filters/SVGFEGaussianBlur.h:
* platform/graphics/svg/filters/SVGFEImage.cpp:
* platform/graphics/svg/filters/SVGFEImage.h:
* platform/graphics/svg/filters/SVGFEMerge.cpp:
* platform/graphics/svg/filters/SVGFEMerge.h:
* platform/graphics/svg/filters/SVGFEMorphology.cpp:
* platform/graphics/svg/filters/SVGFEMorphology.h:
* platform/graphics/svg/filters/SVGFEOffset.cpp:
* platform/graphics/svg/filters/SVGFEOffset.h:
* platform/graphics/svg/filters/SVGFESpecularLighting.cpp:
* platform/graphics/svg/filters/SVGFESpecularLighting.h:
* platform/graphics/svg/filters/SVGFETile.h:
* platform/graphics/svg/filters/SVGFETurbulence.cpp:
* platform/graphics/svg/filters/SVGFETurbulence.h:
* platform/graphics/svg/filters/SVGFilterEffect.cpp:
* platform/graphics/svg/filters/SVGFilterEffect.h:
* platform/graphics/svg/filters/SVGLightSource.cpp:
* platform/graphics/svg/filters/SVGLightSource.h:
* platform/graphics/svg/filters/SVGPointLightSource.h:
* platform/graphics/svg/filters/SVGSpotLightSource.h:
* platform/graphics/svg/filters/cg/SVGFEBlendCg.mm:
(WebCore::SVGFEBlend::getCIFilter):
* platform/graphics/svg/filters/cg/SVGFEColorMatrixCg.mm:
(WebCore::SVGFEColorMatrix::getCIFilter):
* platform/graphics/svg/filters/cg/SVGFEComponentTransferCg.mm:
(WebCore::SVGFEComponentTransfer::getCIFilter):
* platform/graphics/svg/filters/cg/SVGFECompositeCg.mm:
(WebCore::SVGFEComposite::getCIFilter):
* platform/graphics/svg/filters/cg/SVGFEDiffuseLightingCg.mm:
(WebCore::SVGFEDiffuseLighting::getCIFilter):
* platform/graphics/svg/filters/cg/SVGFEDisplacementMapCg.mm:
(WebCore::SVGFEDisplacementMap::getCIFilter):
* platform/graphics/svg/filters/cg/SVGFEFloodCg.mm:
(WebCore::SVGFEFlood::getCIFilter):
* platform/graphics/svg/filters/cg/SVGFEHelpersCg.h:
* platform/graphics/svg/filters/cg/SVGFEImageCg.mm:
(WebCore::SVGFEImage::getCIFilter):
* platform/graphics/svg/filters/cg/SVGFEMergeCg.mm:
(WebCore::SVGFEMerge::getCIFilter):
* platform/graphics/svg/filters/cg/SVGFESpecularLightingCg.mm:
(WebCore::SVGFESpecularLighting::getCIFilter):
* platform/graphics/svg/mac: Added.
* platform/graphics/svg/mac/SVGResourceFilterPlatformDataMac.h: Added.
* platform/graphics/svg/mac/SVGResourceFilterPlatformDataMac.mm: Added.
(WebCore::SVGResourceFilterPlatformDataMac::SVGResourceFilterPlatformDataMac):
(WebCore::SVGResourceFilterPlatformDataMac::~SVGResourceFilterPlatformDataMac):
(WebCore::SVGResourceFilterPlatformDataMac::getCIFilterStack):
(WebCore::alphaImageForImage):
(WebCore::SVGResourceFilterPlatformDataMac::imageForName):
(WebCore::SVGResourceFilterPlatformDataMac::setImageForName):
(WebCore::SVGResourceFilterPlatformDataMac::setOutputImage):
(WebCore::SVGResourceFilterPlatformDataMac::inputImage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27179
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sun, 28 Oct 2007 10:19:47 +0000 (10:19 +0000)]
Rubber stamped by Mark.
- avoid using non-portable SIZE_T_MAX in favor of std::numeric_limits
* kjs/SymbolTable.h:
(KJS::SymbolTableIndexHashTraits::emptyValue):
* kjs/function.cpp:
(KJS::ActivationImp::getOwnPropertySlot):
(KJS::ActivationImp::put):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27178
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sun, 28 Oct 2007 09:20:48 +0000 (09:20 +0000)]
Reviewed by Eric.
- switch SymbolTable to be a HashMap instead of a PropertyMap for 3% SunSpider speedup
* kjs/SymbolTable.h:
(KJS::IdentifierRepHash::hash): Special hash function for identifier reps.
(KJS::IdentifierRepHash::equal): ditto
(KJS::SymbolTableIndexHashTraits::emptyValue): Special HashTraits for the index value.
(KJS::SymbolTable): change to a typedef for a HashMap.
* kjs/function.cpp:
(KJS::ActivationImp::getOwnPropertySlot): Adjusted for new SymbolTable API.
(KJS::ActivationImp::deleteProperty): ditto
(KJS::ActivationImp::put): ditto
* kjs/nodes.cpp:
(KJS::FunctionBodyNode::initializesymbolTable): Adjusted, since
you now have to store a UString::rep, not an identifier.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27177
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sun, 28 Oct 2007 08:17:39 +0000 (08:17 +0000)]
Reviewed by Oliver.
- numerous HashTable performance improvements
This does not quite add up to a measurable win on SunSpider, but it allows a
follow-on > 3% improvement and probably helps WebCore too.
I made the following improvements, among others:
- Made HashFunctions note whether it is ok to compare a real value with the equal() function
to the empty or deleted value, and used this to optimize the comparisons done in hash lookup.
- Specialized lookup so it doesn't have to do so many extra branches and build so many extra
std::pairs for cases that don't need them. There are now four versions, one for read-only access,
two for writing, and one folded directly into add() (these all were improvments).
- Made HashMap::get() use lookup() directly instead of find() to avoid having to build iterators.
- Made a special constructor for iterators that knows it points to
a valid filled cell and so skips updating itself.
- Reordered memory accesses in the various lookup functions for better codegetion
- Made simple translators avoid passing a hash code around
- Other minor tweaks
* wtf/HashTable.h:
(WTF::):
(WTF::HashTableConstIterator::HashTableConstIterator):
(WTF::HashTableIterator::HashTableIterator):
(WTF::IdentityHashTranslator::translate):
(WTF::HashTable::end):
(WTF::HashTable::lookup):
(WTF::HashTable::lookupForWriting):
(WTF::HashTable::makeKnownGoodIterator):
(WTF::HashTable::makeKnownGoodConstIterator):
(WTF::::lookup):
(WTF::::lookupForWriting):
(WTF::::fullLookupForWriting):
(WTF::::add):
(WTF::::addPassingHashCode):
(WTF::::reinsert):
(WTF::::find):
(WTF::::contains):
* kjs/identifier.cpp:
(WTF::):
* wtf/HashFunctions.h:
(WTF::):
* wtf/HashMap.h:
(WTF::):
(WTF::::get):
* wtf/HashSet.h:
(WTF::):
(WTF::::add):
* wtf/ListHashSet.h:
(WTF::ListHashSetTranslator::translate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27176
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sun, 28 Oct 2007 08:02:06 +0000 (08:02 +0000)]
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=15217
Plugin complains that xpcom_core.dll missing
* plugins/win/PluginDatabaseWin.cpp:
(WebCore::PluginDatabaseWin::isPluginBlacklisted): Blacklist npmozax.dll.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27175
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Sun, 28 Oct 2007 07:32:15 +0000 (07:32 +0000)]
Reviewed by Adam.
Pass the Document's domain to InspectorController:didOpenDatabase. This matches
what the Inspector shows for other resources.
* storage/Database.cpp:
(WebCore::Database::openDatabase):
* dom/Document.h: Remove KURL.h, no longer needed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27174
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Sun, 28 Oct 2007 07:08:56 +0000 (07:08 +0000)]
Reviewed by Adam.
Bug 15728: Selected Resource background image gradient has banding
http://bugs.webkit.org/show_bug.cgi?id=15728
- Reduced images to 1px wide that are tiled horizontally in CSS.
- Corrected the -webkit-background-size usage to specify auto for the width.
* page/inspector/Images/attachedShadow.png:
* page/inspector/Images/bottomShadow.png:
* page/inspector/Images/darkShadow.png:
* page/inspector/Images/gradient.png:
* page/inspector/Images/gradientHighlight.png:
* page/inspector/Images/gradientHighlightBottom.png:
* page/inspector/Images/sidebarSelection.png:
* page/inspector/Images/sidebarSelectionBlurred.png:
* page/inspector/Images/sidebarSelectionBlurredTall.png:
* page/inspector/Images/sidebarSelectionGray.png:
* page/inspector/Images/sidebarSelectionGrayTall.png:
* page/inspector/Images/sidebarSelectionTall.png:
* page/inspector/inspector.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27173
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sun, 28 Oct 2007 07:04:00 +0000 (07:04 +0000)]
Re-enable a bunch of passing tests on Windows
Reviewed by NOBODY.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27172
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Sun, 28 Oct 2007 06:45:10 +0000 (06:45 +0000)]
Reviewed by Adam.
Bug 15727: Resizing the resource sidebar doesn't scale the font preview or network timeline
http://bugs.webkit.org/show_bug.cgi?id=15727
Add one window resize listener and call the new resize function on the currentPanel.
Also call the currentPanel's resize function when resizing the sidebar.
* page/inspector/DocumentPanel.js: Implement resize and call updateTreeSelection() when
the panel is shown and when resizing the DOM sidebar.
* page/inspector/FontPanel.js: Implement resize.
* page/inspector/NetworkPanel.js: Ditto.
* page/inspector/inspector.js: Add a window resize listener.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27171
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sun, 28 Oct 2007 06:31:37 +0000 (06:31 +0000)]
Reviewed by Oliver.
- update for HashTable changes
* bindings/js/JSSVGPODTypeWrapper.h:
* dom/Document.h:
* dom/QualifiedName.cpp:
* dom/StyledElement.cpp:
* ksvg2/svg/SVGAnimatedTemplate.h:
* platform/FontCache.cpp:
* platform/StringHash.h:
(WTF::):
* platform/TextEncodingRegistry.cpp:
* platform/graphics/IntSizeHash.h:
(WTF::):
* plugins/win/PluginPackageWin.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27170
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Sun, 28 Oct 2007 05:34:25 +0000 (05:34 +0000)]
2007-10-28 Alp Toker <alp@atoker.com>
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=15646
[GTK] caretBlinkFrequency is hard-coded in Frame.cpp
Abstract caretBlinkFrequency to RenderTheme.
* page/Frame.cpp:
(WebCore::Frame::selectionLayoutChanged):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::caretShouldBlink):
(WebCore::RenderThemeGtk::caretBlinkFrequency):
* platform/gtk/RenderThemeGtk.h:
* rendering/RenderTheme.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27169
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Sun, 28 Oct 2007 05:22:51 +0000 (05:22 +0000)]
2007-10-28 Lars Lindner <lars.lindner@gmail.com>
Reviewed by Alp.
http://bugs.webkit.org/show_bug.cgi?id=15466
[gtk] widget does not take focus on mouse click
Grab widget focus in mouse press callback.
* Api/webkitgtkpage.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27168
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sun, 28 Oct 2007 05:02:19 +0000 (05:02 +0000)]
Updated Windows Skipped file for currently failing tests
Reviewed by NOBODY.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27167
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sun, 28 Oct 2007 04:38:01 +0000 (04:38 +0000)]
Fix HTMLDocument12.xhtml on Leopard/Windows
<rdar://5313535> and <rdar://5539816>
The test succeeds on Leopard and Windows, but fails on Tiger. For some
reason, failing expected results had been checked in to
platform/mac-leopard. The test seems to be passing now, so I moved the
failing results to platform/mac-tiger.
Reviewed by Maciej and Sam.
* platform/mac-leopard/dom/xhtml/level2/html/HTMLDocument12-expected.txt: Removed.
* platform/mac-tiger/dom/xhtml/level2/html/HTMLDocument12-expected.txt:
Moved from platform/mac-leopard.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27166
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Sun, 28 Oct 2007 04:24:31 +0000 (04:24 +0000)]
Reviewed by Adam.
Don't print the line number in the Inspector Console if it is Zero.
* page/inspector/ConsolePanel.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27165
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 28 Oct 2007 03:31:47 +0000 (03:31 +0000)]
Reviewed by Eric.
- fix ASCIICType.h for some Windows compiles
* wtf/ASCIICType.h: Check the compiler, not the OS, since it's the
compiler/library that has the wchar_t that is just a typedef.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27164
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Sun, 28 Oct 2007 03:12:44 +0000 (03:12 +0000)]
Hit with the rubber-stamp of Timothy Hatcher.
Tests for window.console's functions.
* fast/dom/Window/console-functions-expected.txt: Added.
* fast/dom/Window/console-functions.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27163
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Sun, 28 Oct 2007 02:52:54 +0000 (02:52 +0000)]
Reviewed by Tim Hatcher.
Speculative fix for an intermittently failing test
* fast/dom/Window/resources/opened-window.html: Added.
* fast/dom/Window/window-early-properties.html: Use onload for opened
window and use a local file instead of a data: URL to avoid same origin
check issues.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27162
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Sun, 28 Oct 2007 02:11:55 +0000 (02:11 +0000)]
WebCore:
Reviewed by Adam Roben.
Fix http://bugs.webkit.org/show_bug.cgi?id=14953
Implement window.console in WebCore
- Adds a window.console object that has 4 methods (log, info, warn, and error)
that send messages to the Chrome. This moves functionality that was in the
app down into WebCore.
* DerivedSources.make:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/scripts/CodeGeneratorJS.pm: Add extended attribute
to mark attributes as [Replacable] which indicates they can
overridden when set.
* page/Chrome.cpp:
(WebCore::Chrome::addMessageToConsole): Allow all messages to go
up to the ChromeClient.
* page/Console.cpp: Added.
(WebCore::Console::Console):
(WebCore::Console::disconnectFrame):
(WebCore::Console::error):
(WebCore::Console::info):
(WebCore::Console::log):
(WebCore::Console::warn):
* page/Console.h: Added.
* page/Console.idl: Added.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::clear):
(WebCore::DOMWindow::console):
* page/DOMWindow.h:
* page/DOMWindow.idl:
LayoutTests:
Reviewed by Adam Roben.
Update tests for http://bugs.webkit.org/show_bug.cgi?id=14953
Implement window.console in WebCore
* fast/dom/Window/window-properties-expected.txt:
* http/tests/security/cross-frame-access-put-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27161
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pewtermoose [Sun, 28 Oct 2007 00:47:42 +0000 (00:47 +0000)]
Update results
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27160
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sun, 28 Oct 2007 00:02:59 +0000 (00:02 +0000)]
Speculative fix for an intermittently failing test
Reviewed by Sam and Eric.
* http/tests/local/style-access-before-stylesheet-loaded.html: Use
waitUntilDone/notifyDone.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27159
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Sat, 27 Oct 2007 23:53:45 +0000 (23:53 +0000)]
2007-10-27 Eric Seidel <eric@webkit.org>
Reviewed by aroben.
Remove legacy createFilterEffect function (causing extra filter tests to fail on windows)
No functional changes, thus no tests.
* ksvg2/svg/SVGFEBlendElement.cpp:
(WebCore::SVGFEBlendElement::filterEffect):
* ksvg2/svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::filterEffect):
* ksvg2/svg/SVGFEComponentTransferElement.cpp:
(WebCore::SVGFEComponentTransferElement::filterEffect):
* ksvg2/svg/SVGFECompositeElement.cpp:
(WebCore::SVGFECompositeElement::filterEffect):
* ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::filterEffect):
* ksvg2/svg/SVGFEDisplacementMapElement.cpp:
(WebCore::SVGFEDisplacementMapElement::filterEffect):
* ksvg2/svg/SVGFEFloodElement.cpp:
(WebCore::SVGFEFloodElement::filterEffect):
* ksvg2/svg/SVGFEGaussianBlurElement.cpp:
(WebCore::SVGFEGaussianBlurElement::filterEffect):
* ksvg2/svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::filterEffect):
* ksvg2/svg/SVGFEMergeElement.cpp:
(WebCore::SVGFEMergeElement::filterEffect):
* ksvg2/svg/SVGFEOffsetElement.cpp:
(WebCore::SVGFEOffsetElement::filterEffect):
* ksvg2/svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::filterEffect):
* ksvg2/svg/SVGFETileElement.cpp:
(WebCore::SVGFETileElement::filterEffect):
* ksvg2/svg/SVGFETurbulenceElement.cpp:
(WebCore::SVGFETurbulenceElement::filterEffect):
* platform/graphics/svg/SVGResourceFilter.h:
* platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
* platform/graphics/svg/cg/SVGResourceFilterCg.mm:
* platform/graphics/svg/qt/SVGResourceFilterQt.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27158
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sat, 27 Oct 2007 23:31:30 +0000 (23:31 +0000)]
Add some more failing tests to the Windows Skipped file
Reviewed by NOBODY.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27157
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Sat, 27 Oct 2007 23:26:58 +0000 (23:26 +0000)]
Reviewed by Adam.
- Stubbed out IWebScriptCallFrame for Drosera.
* Interfaces/IWebScriptCallFrame.idl: Added function declarations.
* WebKit.vcproj/WebKit.vcproj: Added .h/.cpp files to the project.
* WebScriptCallFrame.cpp: Added.
(WebScriptCallFrame::WebScriptCallFrame):
(WebScriptCallFrame::~WebScriptCallFrame):
(WebScriptCallFrame::createInstance):
(WebScriptCallFrame::QueryInterface):
(WebScriptCallFrame::AddRef):
(WebScriptCallFrame::Release):
(WebScriptCallFrame::caller):
(WebScriptCallFrame::scopeChain):
(WebScriptCallFrame::functionName):
(WebScriptCallFrame::evaluateWebScript):
* WebScriptCallFrame.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27156
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz [Sat, 27 Oct 2007 23:25:24 +0000 (23:25 +0000)]
WebCore:
Reviewed by Darin Adler.
- fix a crash when opening Zenoss server history view
<rdar://problem/5530657>
Test: fast/table/colgroup-relative.html
* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState): Added a hasLayer() check before
accessing layer().
LayoutTests:
Reviewed by Darin Adler.
- test for <rdar://problem/5530657>
* fast/table/colgroup-relative-expected.txt: Added.
* fast/table/colgroup-relative.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27155
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Sat, 27 Oct 2007 22:45:04 +0000 (22:45 +0000)]
- BuildFix
- Forgot to change the build step when I changed the filename.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27154
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Sat, 27 Oct 2007 19:20:25 +0000 (19:20 +0000)]
Reviewed by Darin Adler.
Fixed the rest of "ASSERTION FAILED: _hash in KJS::UString::Rep::
computedHash()"
http://bugs.webkit.org/show_bug.cgi?id=15718
* kjs/identifier.cpp: Fixed more cases where an Identifier didn't get a
hash value. Also changed O(n) strlen to O(1) check for empty string.
(KJS::Identifier::add):
* kjs/ustring.cpp: Changed O(n) strlens to O(1) checks for empty string.
(KJS::UString::UString):
(KJS::UString::operator=):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27153
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sat, 27 Oct 2007 19:10:40 +0000 (19:10 +0000)]
Reviewed by Eric.
- a couple of Windows fixes
* wtf/MathExtras.h: (wtf_pow): Add a special case for MSVC, which has
a "pow" function that does not properly handle the case where arg1 is
NaN and arg2 is 0.
* kjs/math_object.cpp: (MathFuncImp::callAsFunction): Don't explicity
specify "::pow" -- just "pow" is fine.
* wtf/ASCIICType.h: Check the compiler, not the OS, since it's the
compiler/library that has the wchar_t that is just a typedef.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27152
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 27 Oct 2007 18:51:25 +0000 (18:51 +0000)]
2007-10-27 Julien <julien.chaffraix@gmail.com>
Reviewed by Alexey.
http://bugs.webkit.org/show_bug.cgi?id=13141
XMLHttpRequest should set readyState to 0 after abort()
Test: http/tests/xmlhttprequest/xmlhttprequest-abort-readyState.html
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::open):
(WebCore::XMLHttpRequest::abort):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27151
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz [Sat, 27 Oct 2007 16:54:19 +0000 (16:54 +0000)]
WebCore:
Reviewed by Dave Hyatt.
- fix rotated border images by using a temporary subimage containing
only the part we want to tile
Test: fast/borders/border-image-rotate-transform.html
* platform/graphics/cg/ImageCG.cpp:
(WebCore::Image::drawPatternCallback):
(WebCore::Image::drawPattern):
LayoutTests:
Reviewed by Dave Hyatt.
- rotated border image test
* fast/borders/border-image-rotate-transform.html: Added.
* platform/mac/fast/borders/border-image-rotate-transform-expected.checksum: Added.
* platform/mac/fast/borders/border-image-rotate-transform-expected.png: Added.
* platform/mac/fast/borders/border-image-rotate-transform-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27150
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sat, 27 Oct 2007 14:48:34 +0000 (14:48 +0000)]
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15711
force JSImmediate to be inlined for roughly 1.2% SunSpider speedup
* kjs/JSImmediate.h: Put ALWAYS_INLINE on everything.
* kjs/object.h: Removed redundant includes.
* kjs/value.h: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27149
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 27 Oct 2007 10:46:23 +0000 (10:46 +0000)]
2007-10-27 Mark Ambachtsheer <mark.a@apple.com>
Reviewed by Darin.
Fix for bug 15710, When QD plugins draw to an offscreen bitmap and the plugin is not at
(0, 0) the clipping rectangle is not correct.
Added the origin to the window clip rectangle coordinates to account for plugins that
don't originate at (0,0); affects code for offscreen GWorlds only.
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27148
268f45cc-cd09-0410-ab3c-
d52691b4dbfc