WebKit-https.git
12 years agoWebCore:
mitz@apple.com [Sat, 23 Aug 2008 07:16:41 +0000 (07:16 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline

        Test: fast/table/vertical-align-baseline.html

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::getBaselineOfFirstLineBox): Added. Returns the
        baseline of the first table row, if there is one, -1 otherwise.
        * rendering/RenderTable.h:
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::baselinePosition): Changed to follow the
        CSS2.1 definition of the baseline of a table cell.
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::getBaselineOfFirstLineBox): Added. Returns
        the baseline of the first row in the section.
        * rendering/RenderTableSection.h:

LayoutTests:

        Reviewed by Dave Hyatt.

        - test and updated results for <rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline

        * fast/table/vertical-align-baseline.html: Added.
        * platform/mac/fast/table/form-with-table-style-expected.checksum:
        * platform/mac/fast/table/form-with-table-style-expected.png:
        * platform/mac/fast/table/form-with-table-style-expected.txt:
        * platform/mac/fast/table/vertical-align-baseline-expected.checksum: Added.
        * platform/mac/fast/table/vertical-align-baseline-expected.png: Added.
        * platform/mac/fast/table/vertical-align-baseline-expected.txt: Added.
        * platform/mac/tables/mozilla/bugs/bug3037-1-expected.txt:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-22 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sat, 23 Aug 2008 03:17:17 +0000 (03:17 +0000)]
2008-08-22  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Some cleanup to match our coding style.

        * VM/CodeGenerator.h:
        * VM/Machine.cpp:
        (KJS::Machine::privateExecute):
        * kjs/ExecState.cpp:
        * kjs/ExecState.h:
        * kjs/completion.h:
        * kjs/identifier.cpp:
        (KJS::Identifier::equal):
        (KJS::CStringTranslator::hash):
        (KJS::CStringTranslator::equal):
        (KJS::CStringTranslator::translate):
        (KJS::UCharBufferTranslator::equal):
        (KJS::UCharBufferTranslator::translate):
        (KJS::Identifier::remove):
        * kjs/operations.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-18 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Fri, 22 Aug 2008 23:44:32 +0000 (23:44 +0000)]
2008-08-18  Jon Honeycutt  <jhoneycutt@apple.com>

        Add SPI to make a Windows WebView transparent.

        Reviewed by Dan Bernstein.

        * Interfaces/IWebViewPrivate.idl:
        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::transitionToCommittedForNewPage): Call
        updateBackground() when a new frame is attached, matching the Mac.
        * WebFrame.cpp:
        (WebFrame::updateBackground): Propagate WebView transparency to ourself
        and our child frames.
        * WebFrame.h:
        * WebView.cpp:
        (WebView::WebView):
        (WebView::paintIntoBackingStore): Pass m_transparent when creating a
        GraphicsContext, so the context will be created with an alpha channel.
        (WebView::setTransparent):
        (WebView::transparent):
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-12 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Fri, 22 Aug 2008 23:44:14 +0000 (23:44 +0000)]
2008-08-12  Jon Honeycutt  <jhoneycutt@apple.com>

        Add SPI to get a handle to the WebView's backing store bitmap.

        Reviewed by Dan Bernstein.

        * Interfaces/IWebViewPrivate.idl:
        * WebView.cpp:
        (WebView::backingStore):
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rolls out r35834 because it caused a regression in the Inspector's
timothy@apple.com [Fri, 22 Aug 2008 20:35:20 +0000 (20:35 +0000)]
    Rolls out r35834 because it caused a regression in the Inspector's
        Console where some expressions always threw a syntax error.

        https://bugs.webkit.org/show_bug.cgi?id=20487

        * page/inspector/Console.js:
        (Console.prototype._evalInInspectedWindow): Removes parenthesis
        around the expression.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 22 Aug 2008 19:39:36 +0000 (19:39 +0000)]
2008-08-22  Anders Carlsson  <andersca@apple.com>

        Fix build for real this time.

        * UserObjectImp.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 22 Aug 2008 19:14:11 +0000 (19:14 +0000)]
2008-08-22  Anders Carlsson  <andersca@apple.com>

        Fix build.

        * UserObjectImp.cpp:
        (UserObjectImp::toPrimitive):
        * UserObjectImp.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMakes getStyleProperty return a value for the overflow property when overflow-x and...
timothy@apple.com [Fri, 22 Aug 2008 18:39:52 +0000 (18:39 +0000)]
Makes getStyleProperty return a value for the overflow property when overflow-x and overflow-y are equal.

WebCore:

2008-08-22  Timothy Hatcher  <timothy@apple.com>

        Makes getStyleProperty return a value for the overflow property
        when overflow-x and overflow-y are equal.

        https://bugs.webkit.org/show_bug.cgi?id=20485

        Reviewed by Dan Bernstein.

        Test: fast/css/overflow-property.html

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::getPropertyValue):

LayoutTests:

2008-08-22  Timothy Hatcher  <timothy@apple.com>

        Test for the tests the parsing and retrieval of the overflow,
        overflow-x and overflow-y properties

        https://bugs.webkit.org/show_bug.cgi?id=20485

        Reviewed by Dan Bernstein.

        * fast/css/overflow-property-expected.txt: Added.
        * fast/css/overflow-property.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fixes a bug where while editing in the Inspector the
timothy@apple.com [Fri, 22 Aug 2008 18:39:42 +0000 (18:39 +0000)]
    Fixes a bug where while editing in the Inspector the
        sidebar scroll position would jump to the top.

        https://bugs.webkit.org/show_bug.cgi?id=20484

        Reviewed by Darin Adler.

        * page/inspector/treeoutline.js:
        (TreeOutline._removeChildren): Remove the offsetTop call that
        was forcing a layout, since layout causes scroll positions
        to be clamped to the new scrollHeight/Width. Layout will happen
        normally when needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler
simon.fraser@apple.com [Fri, 22 Aug 2008 17:38:53 +0000 (17:38 +0000)]
    Reviewed by Darin Adler

        css3/transform-computed-style-001.html is better tested
        by fast/css/getComputedStyle-transform.html, so removed.
        https://bugs.webkit.org/show_bug.cgi?id=20477

        * css3/transform-computed-style-001-expected.txt: Removed.
        * css3/transform-computed-style-001.fhtml: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix. Add AccessibilityTable sources.
kevino@webkit.org [Fri, 22 Aug 2008 16:25:52 +0000 (16:25 +0000)]
wx build fix. Add AccessibilityTable sources.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Fri, 22 Aug 2008 06:29:33 +0000 (06:29 +0000)]
WebCore:

        Reviewed by Jon Honeycutt and Alexey Proskuryakov.

        - fix <rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics

        Test: platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html

        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::SimpleFontData::platformInit): Add 8% to Geeza Pro's reported
        ascent and 100% to its reported descent.

LayoutTests:

        Reviewed by Jon Honeycutt and Alexey Proskuryakov.

        - test for <rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics

        * platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum: Added.
        * platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
        * platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
        * platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-21 Jonas Klink <klinktech@gmail.com>
mrowe@apple.com [Fri, 22 Aug 2008 02:20:13 +0000 (02:20 +0000)]
2008-08-21 Jonas Klink <klinktech@gmail.com>

        Reviewed by Jon Honeycutt.

        Fix https://bugs.webkit.org/show_bug.cgi?id=20231
        Bug 20231: accNavigate: no screen element found in the specified direction should return S_FALSE

        Per <http://msdn.microsoft.com/en-us/library/ms696145(VS.85).aspx>, we should return S_FALSE
        from accNavigate if no screen element is found in the specified direction.

        * AccessibleBase.cpp:
        (AccessibleBase::accNavigate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-21 Jonas Klink <klinktech@gmail.com>
mrowe@apple.com [Fri, 22 Aug 2008 02:20:08 +0000 (02:20 +0000)]
2008-08-21 Jonas Klink <klinktech@gmail.com>

        Reviewed by Jon Honeycutt.

        Fix http://bugs.webkit.org/show_bug.cgi?id=20230
        Bug 20230: get_accState should be testing state on childObj

        Also initializes output parameter action to 0 in get_accDefaultAction.

        * AccessibleBase.cpp:
        (AccessibleBase::get_accState):
        (AccessibleBase::get_accDefaultAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix bug number in ChangeLog.
mrowe@apple.com [Fri, 22 Aug 2008 02:10:15 +0000 (02:10 +0000)]
Fix bug number in ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-21 Kalle Vahlman <kalle.vahlman@movial.com>
mrowe@apple.com [Fri, 22 Aug 2008 02:07:54 +0000 (02:07 +0000)]
2008-08-21  Kalle Vahlman  <kalle.vahlman@movial.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=19171
        [GTK] Crash on some pages due to a plugin

        Fix handling of badly formatted and empty plugin mime descriptions

        * plugins/gtk/PluginPackageGtk.cpp:
        (WebCore::PluginPackage::fetchInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-21 Kevin Watters <kevinwatters@gmail.com>
mrowe@apple.com [Fri, 22 Aug 2008 02:07:48 +0000 (02:07 +0000)]
2008-08-21  Kevin Watters  <kevinwatters@gmail.com>

        Reviewed by Darin Adler.

        Follow other ports (and IE) in ImageSourceWx.cpp never to return an
        animated GIF frame duration of less than 50ms.

        * platform/graphics/wx/ImageSourceWx.cpp:
        (WebCore::ImageSource::frameDurationAtIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-21 Maxime Britto <britto@apple.com>
britto@apple.com [Fri, 22 Aug 2008 00:39:39 +0000 (00:39 +0000)]
2008-08-21  Maxime Britto  <britto@apple.com>

        Reviewed by Kevin McCullough.

        Test: fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html
        https://bugs.webkit.org/show_bug.cgi?id=20451

        rdar://problem/6166435 Inspector doesn't auto scroll when selecting text (20451)
        When we climb up the rendering tree looking for a scrollable renderer, we need to be able to jump outside of an iframe.
        This way we can see if what is embedding the iframe can be scrolled even if the iframe content can't.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseDraggedEvent): when we reach the document node and it can't be scrolled we set the next parent as the document's owner element if it exists.

        (WebCore::EventHandler::handleMousePressEvent): ditto

2008-08-21  Maxime Britto  <britto@apple.com>

        Reviewed by Kevin McCullough.

        rdar://problem/6166435 Inspector doesn't auto scroll when selecting text (20451)
        https://bugs.webkit.org/show_bug.cgi?id=20451

        This test can be run automatically or manually as well.

        * fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div-expected.txt: Added.
        * fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html: Added.
        * fast/events/resources/big-page-with-overflow-hidden.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Small optimization for when the dividers in the Inspector's
timothy@apple.com [Thu, 21 Aug 2008 23:54:01 +0000 (23:54 +0000)]
    Small optimization for when the dividers in the Inspector's
        Resources panel are updated.

        Reviewed by Tim Hatcher.

        * page/inspector/ResourcesPanel.js:
        (WebInsector.ResourcesPanel.prototype._updateGraphDividersIfNeeded):
        Combind a for loop and clone the divider element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Mark Rowe
simon.fraser@apple.com [Thu, 21 Aug 2008 23:44:56 +0000 (23:44 +0000)]
Reviewed by Mark Rowe

Make build-launcher-app work when run from a git repository.
https://bugs.webkit.org/show_bug.cgi?id=20478

* BuildSlaveSupport/build-launcher-app:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-21 Chris Marrin <cmarrin@apple.com>
dino@apple.com [Thu, 21 Aug 2008 23:35:23 +0000 (23:35 +0000)]
2008-08-21  Chris Marrin  <cmarrin@apple.com>

        Allow 0 (without units) for Time eg. duration
        Fix for https://bugs.webkit.org/show_bug.cgi?id=20467

        Reviewed by Dave Hyatt.

        Test: css1/units/zero-duration-without-units.html

        * css/CSSParser.cpp:
        (WebCore::CSSParser::validUnit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Make deleting all text while editing a DOM attribute in
timothy@apple.com [Thu, 21 Aug 2008 20:13:12 +0000 (20:13 +0000)]
    Make deleting all text while editing a DOM attribute in
        the Inspector delete the attribute. This also fixes
        an exception that would happen before.

        https://bugs.webkit.org/show_bug.cgi?id=20472

        Reviewed by Kevin McCullough.

        * page/inspector/ElementsPanel.js:
        (WebInspector.DOMNodeTreeElement.prototype._attributeEditingCommitted):
        Don't check for hasAttributes on the parseElement, continuing
        through the function will correctly remove the attribute.
        If the parseElement is null, call _editingCancelled not
        editingCancelled, this fixes an exception.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Update the Inspector's Metrics pane when editing in
timothy@apple.com [Thu, 21 Aug 2008 20:12:59 +0000 (20:12 +0000)]
    Update the Inspector's Metrics pane when editing in
        the Styles pane. This makes sure the metrics shown
        always match what the Styles pane shows.

        https://bugs.webkit.org/show_bug.cgi?id=20470

        Reviewed by Kevin McCullough.

        * page/inspector/ElementsPanel.js:
        (WebInspector.ElementsPanel): Add event listeners for
        the "style edited" and "style property toggled" events,
        so the Metrics pane is updated.
        (WebInspector.ElementsPanel.prototype._stylesPaneEdited):
        Update the Metrics pane.
        * page/inspector/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled):
        Dispatch the "style property toggled" event.
        (WebInspector.StylePropertyTreeElement.prototype.editingCancelled):
        Dispatch the "style edited" event when the CSS text is restored.
        (WebInspector.StylePropertyTreeElement.prototype.applyStyleText):
        Dispatch the "style edited" event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Make the Inspector's Metrics sidebar pane editable.
timothy@apple.com [Thu, 21 Aug 2008 20:12:47 +0000 (20:12 +0000)]
    Make the Inspector's Metrics sidebar pane editable.

        https://bugs.webkit.org/show_bug.cgi?id=17218
        rdar://problem/5732818

        Reviewed by Kevin McCullough.

        * page/inspector/ElementsPanel.js:
        (WebInspector.ElementsPanel): Add an event listener for
        the "metrics edited" event, so the Styles pane is updated.
        * page/inspector/MetricsSidebarPane.js:
        (WebInspector.MetricsSidebarPane.prototype.update): Remember the node
        so future updates work. Add a double click event listener for the
        metric values to start editing.
        (WebInspector.MetricsSidebarPane.prototype.startEditing):
        Call WebInspector.startEditing with some context.
        (WebInspector.MetricsSidebarPane.prototype.editingCancelled):
        (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
        Set the user input on the elements inline style. Fire the
        "metrics edited" event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix a race condition in Windows timer code.
sfalken@apple.com [Thu, 21 Aug 2008 18:42:44 +0000 (18:42 +0000)]
    Fix a race condition in Windows timer code.
        Timer function could end up being called with a 0 timer, leading to a Windows exception.

        Don't post a timer message if one is already pending.

        Reviewed by Ada Chan.

        * platform/win/SharedTimerWin.cpp:
        (WebCore::TimerWindowWndProc):
        (WebCore::clearTimer):
        (WebCore::queueTimerProc):
        (WebCore::setSharedTimerFireTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago After trying to add the expression, try again with quotes for
timothy@apple.com [Thu, 21 Aug 2008 16:36:06 +0000 (16:36 +0000)]
    After trying to add the expression, try again with quotes for
        easier edition.

        https://bugs.webkit.org/show_bug.cgi?id=20466

        Reviewed by Tim Hatcher.

        * page/inspector/ObjectPropertiesSection.js: Added an
        evaluateExpression function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Perform Inspector searches on search event to clear results when
timothy@apple.com [Thu, 21 Aug 2008 16:33:17 +0000 (16:33 +0000)]
    Perform Inspector searches on search event to clear results when
        clicking the cross to empty it. Delete the lastQuery when the field
        is emptied in order to perform the search if exactly the same query
        is entered next.

        https://bugs.webkit.org/show_bug.cgi?id=20462

        Reviewed by Tim Hatcher.

        * page/inspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-21 Marco Barisione <marco.barisione@collabora.co.uk>
jmalonzo@webkit.org [Thu, 21 Aug 2008 11:22:51 +0000 (11:22 +0000)]
2008-08-21  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Mark Rowe.

        http://bugs.webkit.org/show_bug.cgi?id=19656
        [SOUP] The gio code should call didFail() instead of
        didFinishLoading() in case of error

        In case of error call didFail() instead of didReceiveResponse() and
        didFinishLoading().

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::networkErrorForFile):
        (WebCore::readCallback):
        (WebCore::openCallback):
        (WebCore::queryInfoCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix build failure.
mrowe@apple.com [Thu, 21 Aug 2008 06:52:42 +0000 (06:52 +0000)]
Fix build failure.

Reviewed by Jon Honeycutt.

* bridge/c/c_instance.cpp:
(KJS::Bindings::CInstance::getPropertyNames): Declare count as uint32_t rather than unsigned
as that is what NPEnumerationFunctionPtr is declared as accepting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd Anthony Ricaud's blog.
timothy@apple.com [Thu, 21 Aug 2008 05:03:21 +0000 (05:03 +0000)]
Add Anthony Ricaud's blog.

        Reviewed by Tim Hatcher.

        * config.ini: Add Anthony Ricaud's blog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix.
mrowe@apple.com [Thu, 21 Aug 2008 04:01:51 +0000 (04:01 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Thu, 21 Aug 2008 00:33:29 +0000 (00:33 +0000)]
WebCore:

        Rubber-stamped by John Sullivan.

        - rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen and
          rename related methods and variables accordingly.

        * WebCore.base.exp:
        * page/FrameView.cpp:
        (WebCore::FrameViewPrivate::FrameViewPrivate):
        (WebCore::FrameView::shouldUpdateWhileOffscreen):
        (WebCore::FrameView::setShouldUpdateWhileOffscreen):
        * page/FrameView.h:
        * platform/ScrollView.h:
        * platform/mac/ScrollViewMac.mm:
        (WebCore::ScrollView::updateContents):

WebKit/mac:

        Rubber-stamped by John Sullivan.

        - rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen,
          rename related methods and variables accordingly, and make
          -setShouldUpdateWhileOffscreen: and -shouldUpdateWhileOffscreen
          WebView API.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::transitionToCommittedForNewPage):
        * WebView/WebFrame.mm:
        (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
        * WebView/WebFrameInternal.h:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView windowWillOrderOnScreen:]):
        * WebView/WebView.h:
        * WebView/WebView.mm:
        (-[WebViewPrivate init]):
        (-[WebView setBackgroundColor:]):
        (-[WebView setDrawsBackground:]):
        (-[WebView setShouldUpdateWhileOffscreen:]):
        (-[WebView shouldUpdateWhileOffscreen]):
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-20 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 21 Aug 2008 00:13:12 +0000 (00:13 +0000)]
2008-08-20  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitzpettel

        <rdar://problem/6163636> - Many images broken in Mail

        This can be traced back to the preload scanner.  With that change, CachedResources are created a lot
        sooner than before and confuse the WebArchive machinery.

        When referencing WebArchive subresources directly through the WebKit API it is appropriate to ignore
        such CachedResources since they are placeholders and have not been submitted to the ResourceLoadDelegate
        machinery and nothing is known about where the data will eventually come from.

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::subresource):  Ignore a CachedResource if its preloadResult is
          CachedResource::PreloadReferenced.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSwitch to non-deprecated NSFileManager APIs.
mrowe@apple.com [Wed, 20 Aug 2008 23:20:55 +0000 (23:20 +0000)]
Switch to non-deprecated NSFileManager APIs.

In order to minimize #if's the new NSFileManager APIs have been implemented for
Tiger and call sites updated to use the new methods.

Reviewed by Darin Adler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Dave Hyatt
simon.fraser@apple.com [Wed, 20 Aug 2008 23:04:43 +0000 (23:04 +0000)]
    Reviewed by Dave Hyatt

        getComputedStyle() for webkitTransform should return a transform
        that does not have the transform origin baked into it.
        https://bugs.webkit.org/show_bug.cgi?id=20464

        * fast/css/getComputedStyle-transform-expected.txt: Added.
        * fast/css/getComputedStyle-transform.html: Added.

        (Missed these test files on last commit)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-20 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Wed, 20 Aug 2008 22:50:39 +0000 (22:50 +0000)]
2008-08-20  Holger Hans Peter Freyther  <zecke@selfish.org>

        Unreviewed compile fix

        Catch up with the JSValue::type elimination.

        * bridge/qt/qt_instance.cpp:
        (KJS::Bindings::QtRuntimeObjectImp::construct):
        (KJS::Bindings::QtInstance::defaultValue):
        * bridge/qt/qt_runtime.cpp:
        (KJS::Bindings::QtRuntimeConnectionMethod::call):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-20 Chris Teague <chris.teague@gmail.com>
mrowe@apple.com [Wed, 20 Aug 2008 22:15:53 +0000 (22:15 +0000)]
2008-08-20  Chris Teague  <chris.teague@gmail.com>

        Reviewed by Mark Rowe.

        Fix https://bugs.webkit.org/show_bug.cgi?id=20449
        Bug 20449: Build fails if LOW_BANDWIDTH_DISPLAY is defined

        * ChangeLog:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Dave Hyatt
simon.fraser@apple.com [Wed, 20 Aug 2008 21:57:22 +0000 (21:57 +0000)]
    Reviewed by Dave Hyatt

        getComputedStyle() for webkitTransform should return a transform
        that does not have the transform origin baked into it.
        https://bugs.webkit.org/show_bug.cgi?id=20464

        Test: fast/css/getComputedStyle-transform.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::computedTransform):
        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::applyTransform):
        * rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca@apple.com [Wed, 20 Aug 2008 21:04:12 +0000 (21:04 +0000)]
WebCore:

2008-08-20  Josh Aas  <joshmoz@gmail.com>

        Reviewed and landed by Anders.

        <rdar://problem/6163636>
        rename NPCocoaEvent's "event" struct to "data" (20446)

        * bridge/npapi.h:
        (_NPCocoaEvent::):

WebKit/mac:

2008-08-20  Josh Aas  <joshmoz@gmail.com>

        Reviewed and landed by Anders.

        <rdar://problem/6163636>
        rename NPCocoaEvent's "event" struct to "data" (20446)

        * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
        (WebNetscapePluginEventHandlerCocoa::drawRect):
        (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
        (WebNetscapePluginEventHandlerCocoa::flagsChanged):
        (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
        (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
        (WebNetscapePluginEventHandlerCocoa::focusChanged):

WebKitExamplePlugins:

2008-08-20  Josh Aas  <joshmoz@gmail.com>

        Reviewed and landed by Anders.

        <rdar://problem/6163636>
        rename NPCocoaEvent's "event" struct to "data" (20446)

        * NetscapeCocoaPlugin/main.m:
        (handleMouseEvent):
        (handleKeyboardEvent):
        (NPP_HandleEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
bdakin@apple.com [Wed, 20 Aug 2008 20:46:28 +0000 (20:46 +0000)]
WebCore:

2008-08-20  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin.

        Fix for <rdar://problem/6145626>
        This patch fixes a number of remaining problems getting
        disconnected frames to work correctly with markAllMatchesForText()
        and findString(). Details inline.

        This was a static helper function in Frame, but this patch requires
        the same functionality in Editor, so I just added it as a function
        on Node.
        * dom/Node.cpp:
        (WebCore::Node::isInShadowTree):
        * dom/Node.h:

        * editing/Editor.cpp:
        (WebCore::Editor::insideVisibleArea): Returns false if
        excludeFromTextSearch() is true.

        In a normal (non-disconnected) frame, findString returns a range of
        the document node if the text is not found in the frame. I changed
        firstVisibleRange and lastVisibleRange to match that behavior when
        the text is not found
        (WebCore::Editor::firstVisibleRange):
        (WebCore::Editor::lastVisibleRange):

        Here are the bulk of the changes in the patch. A lot of text was
        not being found in disconnected frames because I failed to account
        for all of the possible problems associated with shadow trees. That
        is fixed here.
        (WebCore::Editor::nextVisibleRange):
        * editing/Editor.h:

        excludeFromTextSearch() is new. It allows a WebKit client to mark a
        frame as not-text-searchable through SPI.
        * WebCore.base.exp:
        * page/Frame.cpp:
        (WebCore::Frame::excludeFromTextSearch):
        (WebCore::Frame::setExcludeFromTextSearch):
        (WebCore::FramePrivate::FramePrivate):
        * page/Frame.h:
        * page/FramePrivate.h:

        (WebCore::Frame::findString):
        (WebCore::Frame::markAllMatchesForText):  I kept running into an
        assertion failure in paining code because of the forced paint on
        empty visible rects.

WebKit/mac:

2008-08-20  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin.

        Fix for <rdar://problem/6145626>
        Allows a WebKit client to mark a frame as not-text-searchable
        through SPI.

        * WebView/WebFrame.mm:
        (-[WebFrame _setExcludeFromTextSearch:]):
        * WebView/WebFramePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Adds a positon box to the Inspector's Metrics sidebar
timothy@apple.com [Wed, 20 Aug 2008 19:10:54 +0000 (19:10 +0000)]
    Adds a positon box to the Inspector's Metrics sidebar
        pane. When an element is not statically positioned, there
        is now a position box that show top, right, bottom and
        left computed values.

        Reviewed by Kevin McCullough.

        * English.lproj/localizedStrings.js: Updated the strings.
        * page/inspector/MetricsSidebarPane.js:
        (WebInspector.MetricsSidebarPane.prototype.update):
        Renamed the boxPartValue function to createBoxPartElement
        and made it create the entire element. Made it understand
        how to get position style properties. Don't use the figure dash
        when 0px is used for positions, since the 0 is meaningful there.
        Instead use the figure dash when a position is auto.
        * page/inspector/inspector.css: Added a new rule for position.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-20 Maxime Britto <britto@apple.com>
britto@apple.com [Wed, 20 Aug 2008 19:01:24 +0000 (19:01 +0000)]
2008-08-20  Maxime Britto  <britto@apple.com>

        Reviewed by Ada Chan.

        rdar://5259746
        Mouse events are sent to page while resizing window (affects Gmail)
        In the WebView, if the MouseEvent is located in the resize corner, we send it back to the UIDelegate and early return.

        * Interfaces/IWebUIDelegatePrivate.idl: Add a new method to the UIDelegate to send the resize message
        * WebView.cpp:
        (WebView::handleMouseEvent): If the mouse event is in the resize corner and our UIDelegate supports the message it sends the new message and early returns

2008-08-20  Maxime Britto  <britto@apple.com>

        Reviewed by Ada Chan.

         rdar://5259746
        Mouse events are sent to page while resizing window (affects Gmail)

        * DumpRenderTree/win/UIDelegate.h:
        (UIDelegate::webViewSendResizeMessage): Add the new interface method, not implemented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoQt build fix
cfleizach@apple.com [Wed, 20 Aug 2008 18:34:56 +0000 (18:34 +0000)]
Qt build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders Carlsson.
mitz@apple.com [Wed, 20 Aug 2008 18:28:07 +0000 (18:28 +0000)]
    Reviewed by Anders Carlsson.

        - avoid using a deprecated NSScroller method on Leopard

        * platform/mac/PlatformScrollBarMac.mm:
        (WebCore::PlatformScrollbar::updateThumbPosition):
        (WebCore::PlatformScrollbar::updateThumbProportion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-20 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Wed, 20 Aug 2008 11:40:31 +0000 (11:40 +0000)]
2008-08-20  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Oliver Hunt.

        Gtk build fix

        * GNUmakefile.am:
        * page/AccessibilityTable.cpp: Change nil to 0
        (WebCore::AccessibilityTable::cellForColumnAndRow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix.
ap@webkit.org [Wed, 20 Aug 2008 10:40:16 +0000 (10:40 +0000)]
    Windows build fix.

        * API/WebKitAvailability.h: Define DEPRECATED_ATTRIBUTE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoff Garen.
ap@webkit.org [Wed, 20 Aug 2008 07:23:06 +0000 (07:23 +0000)]
    Reviewed by Geoff Garen.

        Bring back shared JSGlobalData and implicit locking, because too many clients rely on it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoff Garen.
eric@webkit.org [Tue, 19 Aug 2008 23:33:07 +0000 (23:33 +0000)]
    Reviewed by Geoff Garen.

        Add the beginnings of Skia graphics support to WebCore
        as I try to begin the long process of un-forking the changes
        needed to WebCore to make Andriod's WebCore build.

        I'll follow this up with actual *Skia.cpp files in a separate patch.

        * platform/graphics/AffineTransform.h:
        * platform/graphics/FloatPoint.h:
        * platform/graphics/FloatRect.h:
        * platform/graphics/Gradient.h:
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/Image.h:
        * platform/graphics/ImageBuffer.h:
        * platform/graphics/ImageSource.h:
        * platform/graphics/IntPoint.h:
        * platform/graphics/IntRect.h:
        * platform/graphics/Path.h:
        * platform/graphics/Pattern.h:
        * svg/graphics/SVGPaintServerPattern.h:
        * svg/graphics/SVGPaintServerSolid.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix Windows build more.
sfalken@apple.com [Tue, 19 Aug 2008 22:46:31 +0000 (22:46 +0000)]
    Fix Windows build more.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fixes the Web Inspector flashing white while resizing after
timothy@apple.com [Tue, 19 Aug 2008 22:36:30 +0000 (22:36 +0000)]
    Fixes the Web Inspector flashing white while resizing after
        highlighting a page element. Calling disableScreenUpdatesUntilFlush
        when attaching and detaching the Inspector page highlight is bad,
        since the browser window might not flush again for a while. So screen
        updates could be disabled for long periods of time, causing backing store
        flashing while resizing. There is no need to call disableScreenUpdatesUntilFlush
        when attaching or detaching the child window.

        Reviewed by John Sullivan and Kevin McCullough.

        * WebInspector/WebNodeHighlight.m:
        (-[WebNodeHighlight attach]): Remove the call to disableScreenUpdatesUntilFlush.
        (-[WebNodeHighlight detach]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix Windows build.
sfalken@apple.com [Tue, 19 Aug 2008 22:34:37 +0000 (22:34 +0000)]
    Fix Windows build.

        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::canSetFocusAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix build.
sfalken@apple.com [Tue, 19 Aug 2008 22:29:18 +0000 (22:29 +0000)]
    Fix build.

        * WebScriptCallFrame.cpp:
        (WebScriptCallFrame::jsValueToString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-19 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 19 Aug 2008 22:22:02 +0000 (22:22 +0000)]
2008-08-19  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim and Mark.

        Implement DTrace hooks for dashcode and instruments.

        * API/JSProfilerPrivate.cpp: Added. Expose SPI so that profiling can be
        turned on from a client.  The DTrace probes were added within the
        profiler mechanism for performance reasons so the profiler must be
        started to enable tracing.
        (JSStartProfiling):
        (JSEndProfiling):
        * API/JSProfilerPrivate.h: Added. Ditto.
        * JavaScriptCore.exp: Exposing the start/stop methods to clients.
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/Tracing.d: Define the DTrace probes.
        * kjs/Tracing.h: Ditto.
        * profiler/ProfileGenerator.cpp: Implement the DTrace probes in the
        profiler.
        (KJS::ProfileGenerator::willExecute):
        (KJS::ProfileGenerator::didExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/4003764> Expose tables as AXTables
cfleizach@apple.com [Tue, 19 Aug 2008 22:05:37 +0000 (22:05 +0000)]
<rdar://problem/4003764> Expose tables as AXTables

Exposes "data" tables in HTML as AXTables through accessibility

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix.
sfalken@apple.com [Tue, 19 Aug 2008 21:35:49 +0000 (21:35 +0000)]
    Build fix.

        * kjs/operations.cpp:
        (KJS::equal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap@webkit.org [Tue, 19 Aug 2008 20:18:54 +0000 (20:18 +0000)]
    Reviewed by Darin.

        Fix run-webkit-tests misreporting crashed tests as timed out ones because DumpRenderTree
        is waiting for crash reporter to let it exit.

        The fix does not work on Tiger, because the state of the process is indistinguishable from
        other waiting processes, at least not with this technique.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix.
sfalken@apple.com [Tue, 19 Aug 2008 18:39:44 +0000 (18:39 +0000)]
    Build fix.
        Add buildfailed support to stop builds early (preventing inaccurate error messages).
        Add missing post-build rule to Release.

        * WebCore.vcproj/QTMovieWin.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Added support for console.count in the inspector.
timothy@apple.com [Tue, 19 Aug 2008 18:33:27 +0000 (18:33 +0000)]
    Added support for console.count in the inspector.

        Reviewed by Geoff Garen.

        * page/Console.cpp:
        (WebCore::Console::count):
        * page/Console.h:
        * page/Console.idl: Added console.count.
        * page/InspectorController.cpp:
        (WebCore::InspectorController::didCommitLoad): Clears m_counts.
        (WebCore::InspectorController::count): Updates the count number
        sing "title@source:line" as the identifier, and adds a
        message to the console.
        * page/InspectorController.h: Added m_counts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Clear console.time timers when changing page.
timothy@apple.com [Tue, 19 Aug 2008 18:33:02 +0000 (18:33 +0000)]
    Clear console.time timers when changing page.

        Reviewed by Geoff Garen.

        * page/InspectorController.cpp:
        (WebCore::InspectorController::didCommitLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-19 Eric Carlson <eric.carlson@apple.com>
adele@apple.com [Tue, 19 Aug 2008 17:55:58 +0000 (17:55 +0000)]
2008-08-19  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adele.

        Fix for <rdar://problem/6154695> Full-page movies flicker while playing
        https://bugs.webkit.org/show_bug.cgi?id=20404

        Ignore setVisible() when visibility doesn't change.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::setVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Correctly remembers the attached state of the Web Inspector so
timothy@apple.com [Tue, 19 Aug 2008 17:01:23 +0000 (17:01 +0000)]
    Correctly remembers the attached state of the Web Inspector so
        it opens in that state for the next window, or next launch.

        Reviewed by Kevin McCullough.

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController attach]): Set WebKitInspectorAttachedKey
        to YES in the user defaults.
        (-[WebInspectorWindowController detach]): Set WebKitInspectorAttachedKey
        to NO in the user defaults.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fixes a bug in the Profile view where switching sort order, then
timothy@apple.com [Tue, 19 Aug 2008 17:01:12 +0000 (17:01 +0000)]
    Fixes a bug in the Profile view where switching sort order, then
        switching from heavy to tree mode would show the tree in the
        previous sort order.

        https://bugs.webkit.org/show_bug.cgi?id=20441

        Reviewed by Kevin McCullough.

        * page/inspector/ProfileView.js:
        (WebInspector.ProfileView.prototype._changeView): Call _sortProfile
        on the next profile before assigning it to this.profile.
        (WebInspector.ProfileView.prototype._sortData): Call _sortProfile.
        (WebInspector.ProfileView.prototype._sortProfile): Moves from
        _sortData and takes a profile argument. If the profile passed in
        matches the this.profile, then call refresh.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Changed the default sort order now that heavy view is the default.
timothy@apple.com [Tue, 19 Aug 2008 17:01:00 +0000 (17:01 +0000)]
    Changed the default sort order now that heavy view is the default.
        Also fixes a bug where the heavy profile was not sorted at first.

        https://bugs.webkit.org/show_bug.cgi?id=20440

        Reviewed by Kevin McCullough.

        * page/inspector/ProfileView.js:
        (WebInspector.ProfileView): Changed the default sort column. Also assign
        heavyProfile to profile, so the sortSelfTimeDescending call happens
        on the heavy profile before assigning to this.profile.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix an assertion when generating a heavy profile because the
timothy@apple.com [Tue, 19 Aug 2008 17:00:48 +0000 (17:00 +0000)]
    Fix an assertion when generating a heavy profile because the
        empty value and deleted value of CallIdentifier where equal.

        https://bugs.webkit.org/show_bug.cgi?id=20439

        Reviewed by Dan Bernstein.

        * profiler/CallIdentifier.h: Make the emptyValue for CallIdentifier
        use empty strings for URL and function name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Add support for editing DOM properties and scope variables by double
timothy@apple.com [Tue, 19 Aug 2008 17:00:36 +0000 (17:00 +0000)]
    Add support for editing DOM properties and scope variables by double
        clicking a property to enter edit mode.

        https://bugs.webkit.org/show_bug.cgi?id=20415

        Reviewed by Kevin McCullough.

        * page/inspector/ObjectPropertiesSection.js:
        (WebInspector.ObjectPropertiesSection): Set editable to true by default.
        (WebInspector.ObjectPropertiesSection.prototype.onpopulate):
        Factored out code into update, and calls update.
        (WebInspector.ObjectPropertiesSection.prototype.update): Moved from onpopulate.
        Call removeChildren since this method can be called multiple times now.
        (WebInspector.ObjectPropertyTreeElement): Pass an empty title, the title
        gets made later in onattach.
        (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): Don't return early
        if shouldRefreshChildren is true. Call removeChildren since this method can be
        called multiple times now.
        (WebInspector.ObjectPropertyTreeElement.prototype.ondblclick): Call startEditing.
        (WebInspector.ObjectPropertyTreeElement.prototype.onattach): Call update.
        (WebInspector.ObjectPropertyTreeElement.prototype.update): Update the title for
        this element (code moved from the constructor.)
        (WebInspector.ObjectPropertyTreeElement.prototype.updateSiblings): Recreate all
        sibling property elements.
        (WebInspector.ObjectPropertyTreeElement.prototype.startEditing): Call
        WebInspector.startEditing after rememebring some context.
        (WebInspector.ObjectPropertyTreeElement.prototype.editingEnded): Reset the scrollLeft
        for the list element, since it might have scrolled during editing.
        (WebInspector.ObjectPropertyTreeElement.prototype.editingCancelled): Call editingEnded
        then restore the state from the context. Then call update to restore the title.
        (WebInspector.ObjectPropertyTreeElement.prototype.editingCommitted): Call editingCancelled
        if the user input and the previous input are the same. Call editingEnded, then call applyExpression
        to commit the user input.
        (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression): Evaluates the input expression
        and stores the result on the object for the property name of this element. If the expression is
        empty, delete the property and remove the tree element.
        * page/inspector/ScopeChainSidebarPane.js:
        (WebInspector.ScopeChainSidebarPane.prototype.update): Set the editInSelectedCallFrameWhenPaused
        property on each ObjectPropertiesSection.
        (WebInspector.ScopeVariableTreeElement.prototype.onattach): Call ObjectPropertyTreeElement's onattach
        since it is now implemented.
        * page/inspector/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): Added an updateInterface argument
        that defaults to true if omitted. It specifies whether to call update on the scope chain.
        * page/inspector/inspector.css: New styles.
        * page/inspector/treeoutline.js:
        (TreeElement.prototype._attach): Fixed an exception that fired when handling the shouldRefreshChildren
        change. The nextSibling would exist but have a _listItemNode that didn't match the new parent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Surround the expression to be evaluated in parenthesis so the
timothy@apple.com [Tue, 19 Aug 2008 17:00:26 +0000 (17:00 +0000)]
    Surround the expression to be evaluated in parenthesis so the
        result of the eval is the result of the whole expression not
        the last potential sub-expression. So evaluating {x: 123}
        will show the Object not 123.

        https://bugs.webkit.org/show_bug.cgi?id=20428

        Reviewed by Kevin McCullough.

        * page/inspector/Console.js:
        (Console.prototype._evalInInspectedWindow): Add parenthesis
        around the expression. And add couple comments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-19 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 19 Aug 2008 16:38:06 +0000 (16:38 +0000)]
2008-08-19 Kevin McCullough <kmccullough@apple.com>

        Reviewed by Geoff.

        -Implement a page() function to extract a common code pattern.

        * WebCore.xcodeproj/project.pbxproj:
        * page/Console.cpp:
        (WebCore::Console::addMessage):
        (WebCore::Console::error):
        (WebCore::Console::info):
        (WebCore::Console::log):
        (WebCore::Console::dir):
        (WebCore::Console::assertCondition):
        (WebCore::Console::time):
        (WebCore::Console::timeEnd):
        (WebCore::Console::group):
        (WebCore::Console::groupEnd):
        (WebCore::Console::finishedProfiling):
        (WebCore::Console::warn):
        (WebCore::Console::framePage):
        * page/Console.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago https://bugs.webkit.org/show_bug.cgi?id=19762
ap@webkit.org [Tue, 19 Aug 2008 14:35:48 +0000 (14:35 +0000)]
    https://bugs.webkit.org/show_bug.cgi?id=19762
        Crash in svg/webarchive/svg-cursor-subresources.svg

        Disabling the test while the crash is being investigated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Dan Bernstein.
ap@webkit.org [Tue, 19 Aug 2008 07:27:12 +0000 (07:27 +0000)]
    Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=19347
        <rdar://problem/5977562> Input methods do not work after switching to a password field
        and back.

        Fix <rdar://problem/5522011> (The content of the password field of Safari is displayed by
        reconversion) in a different way which doesn't conflict with context caching performed
        by AppKit.

        This original bug does not really occur in ToT or shipping Safari under Mac OS X 10.5.4,
        because input methods are disabled in password fields. Attempting to reconvert text typed
        with Romaji only yields a string of bullets. Still, it is probably better to match Cocoa
        password field behavior and disable reconversion completely.

        * WebView/WebHTMLView.mm:
        (isInPasswordField): Factored out code to determine that the current selection is in
        a password field.
        (inputContext): Removed a hack that was breaking TSMGetActiveDocument().
        (-[WebHTMLView attributedSubstringFromRange:]): Check for password fields.
        (-[WebHTMLView textStorage]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
darin@apple.com [Tue, 19 Aug 2008 04:39:04 +0000 (04:39 +0000)]
JavaScriptCore:

2008-08-12  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        - eliminate JSValue::type()

        This will make it slightly easier to change the JSImmediate design without
        having to touch so many call sites.

        SunSpider says this change is a wash (looked like a slight speedup, but not
        statistically significant).

        * API/JSStringRef.cpp: Removed include of JSType.h.
        * API/JSValueRef.cpp: Removed include of JSType.h.
        (JSValueGetType): Replaced use of JSValue::type() with
        JSValue::is functions.

        * JavaScriptCore.exp: Updated.

        * VM/JSPropertyNameIterator.cpp: Removed type() implementation.
        (KJS::JSPropertyNameIterator::toPrimitive): Changed to take
        PreferredPrimitiveType argument instead of JSType.
        * VM/JSPropertyNameIterator.h: Ditto.

        * VM/Machine.cpp:
        (KJS::fastIsNumber): Updated for name change.
        (KJS::fastToInt32): Ditto.
        (KJS::fastToUInt32): Ditto.
        (KJS::jsAddSlowCase): Updated toPrimitive caller for change from
        JSType to PreferredPrimitiveType.
        (KJS::jsAdd): Replaced calls to JSValue::type() with calls to
        JSValue::isString().
        (KJS::jsTypeStringForValue): Replaced calls to JSValue::type()
        with multiple calls to JSValue::is -- we could make this a
        virtual function instead if we want to have faster performance.
        (KJS::Machine::privateExecute): Renamed JSImmediate::toTruncatedUInt32
        to JSImmediate::getTruncatedUInt32 for consistency with other functions.
        Changed two calls of JSValue::type() to JSValue::isString().

        * kjs/GetterSetter.cpp:
        (KJS::GetterSetter::toPrimitive): Changed to take
        PreferredPrimitiveType argument instead of JSType.
        (KJS::GetterSetter::isGetterSetter): Added.
        * kjs/GetterSetter.h:

        * kjs/JSCell.cpp:
        (KJS::JSCell::isString): Added.
        (KJS::JSCell::isGetterSetter): Added.
        (KJS::JSCell::isObject): Added.

        * kjs/JSCell.h: Eliminated type function. Added isGetterSetter.
        Made isString and isObject virtual. Changed toPrimitive to take
        PreferredPrimitiveType argument instead of JSType.
        (KJS::JSCell::isNumber): Use Heap::isNumber for faster performance.
        (KJS::JSValue::isGetterSetter): Added.
        (KJS::JSValue::toPrimitive): Changed to take
        PreferredPrimitiveType argument instead of JSType.

        * kjs/JSImmediate.h: Removed JSValue::type() and replaced
        JSValue::toTruncatedUInt32 with JSValue::getTruncatedUInt32.
        (KJS::JSImmediate::isEitherImmediate): Added.

        * kjs/JSNotAnObject.cpp:
        (KJS::JSNotAnObject::toPrimitive): Changed to take
        PreferredPrimitiveType argument instead of JSType.
        * kjs/JSNotAnObject.h: Ditto.
        * kjs/JSNumberCell.cpp:
        (KJS::JSNumberCell::toPrimitive): Ditto.
        * kjs/JSNumberCell.h:
        (KJS::JSNumberCell::toInt32): Renamed from fastToInt32. There's no
        other "slow" version of this once you have a JSNumberCell, so there's
        no need for "fast" in the name. It's a feature that this hides the
        base class toInt32, which does the same job less efficiently (and has
        an additional ExecState argument).
        (KJS::JSNumberCell::toUInt32): Ditto.

        * kjs/JSObject.cpp:
        (KJS::callDefaultValueFunction): Use isGetterSetter instead of type.
        (KJS::JSObject::getPrimitiveNumber): Use PreferredPrimitiveType.
        (KJS::JSObject::defaultValue): Ditto.
        (KJS::JSObject::defineGetter): Use isGetterSetter.
        (KJS::JSObject::defineSetter): Ditto.
        (KJS::JSObject::lookupGetter): Ditto.
        (KJS::JSObject::lookupSetter): Ditto.
        (KJS::JSObject::toNumber): Use PreferredPrimitiveType.
        (KJS::JSObject::toString): Ditto.
        (KJS::JSObject::isObject): Added.

        * kjs/JSObject.h:
        (KJS::JSObject::inherits): Call the isObject from JSCell; it's now
        hidden by our override of isObject.
        (KJS::JSObject::getOwnPropertySlotForWrite): Use isGetterSetter
        instead of type.
        (KJS::JSObject::getOwnPropertySlot): Ditto.
        (KJS::JSObject::toPrimitive): Use PreferredPrimitiveType.

        * kjs/JSString.cpp:
        (KJS::JSString::toPrimitive): Use PreferredPrimitiveType.
        (KJS::JSString::isString): Added.
        * kjs/JSString.h: Ditto.

        * kjs/JSValue.h: Removed type(), added isGetterSetter(). Added
        PreferredPrimitiveType enum and used it as the argument for the
        toPrimitive function.
        (KJS::JSValue::getBoolean): Simplified a bit an removed a branch.

        * kjs/collector.cpp:
        (KJS::typeName): Changed to use JSCell::is functions instead of
        calling JSCell::type.

        * kjs/collector.h:
        (KJS::Heap::isNumber): Renamed from fastIsNumber.

        * kjs/nodes.h: Added now-needed include of JSType, since the type
        is used here to record types of values in the tree.

        * kjs/operations.cpp:
        (KJS::equal): Rewrote to no longer depend on type().
        (KJS::strictEqual): Ditto.

JavaScriptGlue:

2008-08-12  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        - eliminate JSValue::type()

        * JSUtils.cpp:
        (KJSValueToCFTypeInternal): Replaced uses of JSValue::type() with
        JSValue::is functions.
        * UserObjectImp.cpp:
        (UserObjectImp::getOwnPropertySlot): Ditto.
        (UserObjectImp::toPrimitive): Take PreferredPrimitiveType argument
        instead of JSType argument.
        * UserObjectImp.h: Ditto.

WebCore:

2008-08-12  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        - eliminate JSValue::type()

        * bridge/c/c_instance.cpp:
        (KJS::Bindings::CInstance::defaultValue): Take PreferredPrimitiveType
        argument instead of JSType argument. Removed unneeded code to handle
        boolean, since that's never passed.
        * bridge/c/c_instance.h: Ditto.

        * bridge/c/c_utility.cpp:
        (KJS::Bindings::convertValueToNPVariant): Use JSValue::is functions
        instead of JSValue::type(). Removed unneeded code to handle
        "unspecified".

        * bridge/jni/jni_instance.cpp:
        (JavaInstance::defaultValue): Take PreferredPrimitiveType argument
        instead of JSType argument. Removed unneeded code to handle boolean.
        * bridge/jni/jni_instance.h: Ditto.

        * bridge/jni/jni_jsobject.mm:
        (JavaJSObject::convertValueToJObject): Use JSValue::is functions
        instead of JSValue::type().

        * bridge/objc/objc_instance.h: Take PreferredPrimitiveType argument
        instead of JSType argument. Removed unused argument.
        * bridge/objc/objc_instance.mm:
        (ObjcInstance::getValueOfUndefinedField): Removed unused argument.
        (ObjcInstance::defaultValue): Take PreferredPrimitiveType argument
        instead of JSType argument. Removed unneeded code to handle boolean
        and another dead code path for unknown types.

        * bridge/objc/objc_runtime.h: Take PreferredPrimitiveType argument
        instead of JSType argument. Removed override of type() that caused
        the fallback object to return "UndefinedType" when there is no
        invokeUndefinedMethodFromWebScript:withArguments: method defined.
        That didn't accomplish much, since most checks for undefined don't
        ever call type().
        * bridge/objc/objc_runtime.mm:
        (ObjcFallbackObjectImp::defaultValue): Ditto.

        * bridge/qt/qt_instance.cpp:
        (KJS::Bindings::QtInstance::defaultValue): Take PreferredPrimitiveType
        argument instead of JSType argument. Removed unneeded code to handle
        boolean.
        * bridge/qt/qt_instance.h: Ditto.

        * bridge/runtime.h:
        (KJS::Bindings::Instance::getValueOfUndefinedField): Removed
        unsed argument.
        * bridge/runtime_object.cpp:
        (RuntimeObjectImp::defaultValue): Take PreferredPrimitiveType
        argument instead of JSType argument.
        * bridge/runtime_object.h: Ditto.

WebKit/mac:

2008-08-12  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        - eliminate JSValue::type()

        * WebView/WebView.mm:
        (aeDescFromJSValue): Rewrite to use the JSValue::is functions instead
        of a switch on JSValue::type().

LayoutTests:

2008-08-12  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        - added a test since I had to rewrite the == and === operators

        * fast/js/equality-expected.txt: Added.
        * fast/js/equality.html: Added.
        * fast/js/resources/equality.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-18 Maxime Britto <britto@apple.com>
britto@apple.com [Tue, 19 Aug 2008 00:42:13 +0000 (00:42 +0000)]
2008-08-18  Maxime Britto  <britto@apple.com>

        Reviewed by Adele.

        <rdar://6157207> Mouse pointer does not change when new window is opened after pan-scrolling original window
        Related to the discussion from rdar://6102511 , we should disable every key event (except for the esc key which stops the panning).
        We shouldn't be able to create another window while we are in pan scrolling.
        Other browsers behaviors :
          FF3 : Most of the keys are disabled, there is no way to create another window while in panscroll mode
          IE7 : Keys are not disabled but stops immediately the panning.
        This patch matches FF3 behavior by disabling every key but the esc key.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::stopAutoscrollTimer): Change the cursor back to the regular arrow cursor when the pannning is stopped.
        (WebCore::EventHandler::keyEvent): When a key event is received while in panning or autoscroll we swallow the event early.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Tue, 19 Aug 2008 00:20:38 +0000 (00:20 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/5862634> REGRESSION (3.1.1): In iChat, inline image not resizable past current size after another IM is received

        Test: fast/replaced/max-width-percent.html

        Added an includeMaxWidth boolean to RenderBox::calcReplaedWidth().
        When false, max-width is not factored into the
        calculation.
        Changed RenderReplaced and subclasses' calcPrefWidths() to call
        calcReplacedWidth(false) and then apply max-width only if it has a
        fixed, positive value.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcReplacedWidth):
        * rendering/RenderBox.h:
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::calcReplacedWidth):
        (WebCore::RenderImage::calcPrefWidths):
        * rendering/RenderImage.h:
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::calcPrefWidths):
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::calcPrefWidths):
        * rendering/RenderVideo.cpp:
        (WebCore::RenderVideo::calcReplacedWidth):
        (WebCore::RenderVideo::calcPrefWidths):
        * rendering/RenderVideo.h:

LayoutTests:

        Reviewed by Dave Hyatt.

        - test for <rdar://problem/5862634> REGRESSION (3.1.1): In iChat, inline image not resizable past current size after another IM is received

        * fast/replaced/max-width-percent.html: Added.
        * platform/mac/fast/replaced/max-width-percent-expected.checksum: Added.
        * platform/mac/fast/replaced/max-width-percent-expected.png: Added.
        * platform/mac/fast/replaced/max-width-percent-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Make transition_shorthand_parsing.html a text-only test.
simon.fraser@apple.com [Mon, 18 Aug 2008 23:08:22 +0000 (23:08 +0000)]
    Make transition_shorthand_parsing.html a text-only test.

        * fast/css/transition_shorthand_parsing-expected.txt: Added.
        * fast/css/transition_shorthand_parsing.html:
        * platform/mac/fast/css/transition_shorthand_parsing-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-18 Daniel Macks <dmacks@netspace.org>
mrowe@apple.com [Mon, 18 Aug 2008 22:47:28 +0000 (22:47 +0000)]
2008-08-18  Daniel Macks  <dmacks@netspace.org>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=20410
        More portable/self-documenting replacement for SIZE_MAX.

        * platform/network/curl/FormDataStreamCurl.cpp:
        (WebCore::FormDataStream::read):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Dave Hyatt
simon.fraser@apple.com [Mon, 18 Aug 2008 22:11:10 +0000 (22:11 +0000)]
    Reviewed by Dave Hyatt

        Need to make sure we have an Animation in the AnimationList
        before setting the initial value.
        https://bugs.webkit.org/show_bug.cgi?id=20408

        Test: fast/css/transition_shorthand_parsing.html

        * css/CSSStyleSelector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix for Win. Don't include the libxml/libxslt directories in the
kevino@webkit.org [Mon, 18 Aug 2008 21:55:04 +0000 (21:55 +0000)]
Build fix for Win. Don't include the libxml/libxslt directories in the
include path, it picks up the wrong Pattern.h in that case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-18 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Mon, 18 Aug 2008 20:53:59 +0000 (20:53 +0000)]
2008-08-18  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        If there are no nodes in a profile all the time should be attributed to
        (idle)

        * profiler/Profile.cpp: If ther are no nodes make sure we still process
        the head.
        (KJS::Profile::forEach):
        * profiler/ProfileGenerator.cpp: Remove some useless code.
        (KJS::ProfileGenerator::stopProfiling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-18 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Mon, 18 Aug 2008 20:21:57 +0000 (20:21 +0000)]
2008-08-18  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        <rdar://problem/6150593> JSProfiler: Empty profiles disappear when there
        is another profile.

        * page/inspector/ProfilesPanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-18 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Mon, 18 Aug 2008 19:55:35 +0000 (19:55 +0000)]
2008-08-18  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Geoff.

        <rdar://problem/6150642> REGRESSION: Closing the Web Inspector clears
        all console messages

        * page/inspector/Console.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpgrade to WordPress 2.6.1.
mrowe@apple.com [Mon, 18 Aug 2008 14:54:28 +0000 (14:54 +0000)]
Upgrade to WordPress 2.6.1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-18 Dirk Schulze <vbs85@gmx.de>
jmalonzo@webkit.org [Mon, 18 Aug 2008 11:20:11 +0000 (11:20 +0000)]
2008-08-18  Dirk Schulze  <vbs85@gmx.de>

        Reviewed by Eric Seidel.

        Fixed Canvas for Cairo. Stroke and fill colors didn't work after
        the canvas clean up.

        https://bugs.webkit.org/show_bug.cgi?id=20405

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::fill):
        (WebCore::CanvasRenderingContext2D::stroke):
        (WebCore::CanvasRenderingContext2D::fillRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-18 Alp Toker <alp@nuanti.com>
jmalonzo@webkit.org [Mon, 18 Aug 2008 11:14:38 +0000 (11:14 +0000)]
2008-08-18  Alp Toker  <alp@nuanti.com>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=20350
        [GTK] Get DumpRenderTree working

        WebKit/gtk:

        Add a private function to WebFrame to dump the render tree as required
        for the DumpRenderTree testing tool.

        * webkit/webkitprivate.h:
        * webkit/webkitwebframe.cpp:

        WebKitTools/DumpRenderTree/gtk:

        Fixes and enhancements to DumpRenderTree. With these changes, the test
        suite can now complete a run producing text and render tree dumps.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (dumpFramesAsText):
        (dump):
        (runTest):
        (webViewLoadFinished):
        (webViewWindowObjectCleared):
        (webViewConsoleMessage):
        (webViewScriptAlert):
        (webViewScriptPrompt):
        (webViewScriptConfirm):
        (webViewTitleChanged):
        (main):
        * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::clearBackForwardList):
        (LayoutTestController::pathToLocalResource):
        (LayoutTestController::setAcceptsEditing):
        (LayoutTestController::setUserStyleSheetEnabled):
        (LayoutTestController::setUserStyleSheetLocation):
        (waitToDumpWatchdogFired):
        (LayoutTestController::windowCount):
        * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
        (JSStringCopyUTF8CString):
        (ScriptItem::invoke):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Maciej.
ap@webkit.org [Mon, 18 Aug 2008 08:09:59 +0000 (08:09 +0000)]
    Reviewed by Maciej.

        Make JSGlobalContextRetain/Release actually work.

        * API/JSContextRef.cpp:
        (JSGlobalContextRetain):
        (JSGlobalContextRelease):
        Ref/deref global data to give checking for globalData.refCount() some sense.

        * API/tests/testapi.c: (main): Added a test for this bug.

        * kjs/JSGlobalData.cpp:
        (KJS::JSGlobalData::~JSGlobalData):
        While checking for memory leaks, found that JSGlobalData::emptyList has changed to
        a pointer, but it was not destructed, causing a huge leak in run-webkit-tests --threaded.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Complete in scope variables in the Console when paused.
timothy@apple.com [Mon, 18 Aug 2008 03:21:46 +0000 (03:21 +0000)]
    Complete in scope variables in the Console when paused.

        https://bugs.webkit.org/show_bug.cgi?id=19115

        Reviewed by Geoffrey Garen.

        * page/inspector/Console.js:
        (WebInspector.Console.prototype.completions): If the expressionString
        is null or empty and the debugger is paused, call variablesInScopeForSelectedCallFrame
        to get an object that declares all the in scope variables. That way
        "top level" expressions are completed.
        * page/inspector/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.variablesInScopeForSelectedCallFrame):
        Return an object that has all the variables that are in scope for the
        selected call frame. The value of each property is just true.
        The return object is useful for quick lookups or auto completion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Mon, 18 Aug 2008 02:42:07 +0000 (02:42 +0000)]
2008-08-17  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej.

        Change the counting of constants so that preincrement and predecrement of
        const local variables are considered unexpected loads.

        JavaScriptCore:

        * kjs/nodes.cpp:
        (KJS::PrefixResolveNode::emitCode):
        * kjs/nodes.h:
        (KJS::ScopeNode::neededConstants):

        LayoutTests:

        * fast/js/deep-recursion-test.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/6150322> In Gmail, a crash occurs at KJS::Machine::privateExecute...
oliver@apple.com [Sun, 17 Aug 2008 23:38:36 +0000 (23:38 +0000)]
<rdar://problem/6150322> In Gmail, a crash occurs at KJS::Machine::privateExecute() when applying list styling to text after a quote had been removed
<https://bugs.webkit.org/show_bug.cgi?id=20386>

Reviewed by Cameron Zwarich.

This crash was caused by "depth()" incorrectly determining the scope depth
of a 0 depth function without a full scope chain.  Because such a function
would not have an activation the depth function would return the scope depth
of the parent frame, thus triggering an incorrect unwind.  Any subsequent
look up that walked the scope chain would result in incorrect behaviour,
leading to a crash or incorrect variable resolution.  This can only actually
happen in try...finally statements as that's the only path that can result in
the need to unwind the scope chain, but not force the function to need a
full scope chain.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sun, 17 Aug 2008 21:34:46 +0000 (21:34 +0000)]
2008-08-17  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Not reviewed.

        Speculative Qt build fix.

        * bridge/qt/qt_runtime.cpp:
        (KJS::Bindings::convertValueToQVariant):
        (KJS::Bindings::QtRuntimeMethod::QtRuntimeMethod):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sun, 17 Aug 2008 21:27:56 +0000 (21:27 +0000)]
2008-08-17  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej.

        Bug 20419: Remove op_jless
        <https://bugs.webkit.org/show_bug.cgi?id=20419>

        Remove op_jless, which is rarely used now that we have op_loop_if_less.

        * VM/CodeBlock.cpp:
        (KJS::CodeBlock::dump):
        * VM/CodeGenerator.cpp:
        (KJS::CodeGenerator::emitJumpIfTrue):
        * VM/Machine.cpp:
        (KJS::Machine::privateExecute):
        * VM/Opcode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sun, 17 Aug 2008 21:18:42 +0000 (21:18 +0000)]
2008-08-17  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Dan Bernstein.

        Fix a typo in r35807 that is also causing build failures for
        non-AllInOne builds.

        * kjs/NumberConstructor.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptGlue:
ggaren@apple.com [Sun, 17 Aug 2008 20:28:37 +0000 (20:28 +0000)]
JavaScriptGlue:

2008-08-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Updated project files to XCode 3.1.

        * JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

2008-08-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Updated project files to XCode 3.1.

        * manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj:

WebKit:

2008-08-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Updated project files to XCode 3.1.

        * WebKit.xcodeproj/project.pbxproj:

WebKitTools:

2008-08-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Updated project files to XCode 3.1.

        * DrawTest/DrawTest.xcodeproj/project.pbxproj:
        * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
ggaren@apple.com [Sun, 17 Aug 2008 20:23:49 +0000 (20:23 +0000)]
JavaScriptCore:

2008-08-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Made room for a free word in JSCell.

        SunSpider says no change.

        I changed JSCallbackObjectData, Arguments, JSArray, and RegExpObject to
        store auxiliary data in a secondary structure.

        I changed InternalFunction to store the function's name in the property
        map.

        I changed JSGlobalObjectData to use a virtual destructor, so WebCore's
        JSDOMWindowBaseData could inherit from it safely. (It's a strange design
        for JSDOMWindowBase to allocate an object that JSGlobalObject deletes,
        but that's really our only option, given the size constraint.)

        I also added a bunch of compile-time ASSERTs, and removed lots of comments
        in JSObject.h because they were often out of date, and they got in the
        way of reading what was actually going on.

        Also renamed JSArray::getLength to JSArray::length, to match our style
        guidelines.

WebCore:

2008-08-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Made room for a free word in JSCell.

        Changed JSDOMWindowBase to store its auxiliary data in a subclass of
        JSGlobalData, so the two could share a pointer.

        Added a bunch of ASSERTs, to help catch over-sized objects.

WebKit/mac:

2008-08-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Made room for a free word in JSCell.

        (Updated for JavaScriptCore changes.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-08-16 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sun, 17 Aug 2008 07:57:39 +0000 (07:57 +0000)]
2007-08-16  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Sped up property access for array.length and string.length by adding a
        mechanism for returning a temporary value directly instead of returning
        a pointer to a function that retrieves the value.

        Also removed some unused cruft from PropertySlot.

        SunSpider says 0.5% - 1.2% faster.

        NOTE: This optimization is not a good idea in general, because it's
        actually a pessimization in the case of resolve for assignment,
        and it may get in the way of other optimizations in the future.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoffrey Garen.
mitz@apple.com [Sun, 17 Aug 2008 05:06:18 +0000 (05:06 +0000)]
    Reviewed by Geoffrey Garen.

        Disable dead code stripping in debug builds.

        * Configurations/Base.xcconfig:
        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-15 Mark Rowe <mrowe@apple.com>
mitz@apple.com [Sun, 17 Aug 2008 03:28:52 +0000 (03:28 +0000)]
2008-08-15  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dan Bernstein.

        Disable dead code stripping in debug builds.

        * Configurations/Base.xcconfig:
        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/6143072> FastMallocZone's enumeration code makes assumptions about...
mrowe@apple.com [Sat, 16 Aug 2008 06:53:44 +0000 (06:53 +0000)]
<rdar://problem/6143072> FastMallocZone's enumeration code makes assumptions about handling of remote memory regions that overlap

Reviewed by Oliver Hunt.

* wtf/FastMalloc.cpp:
(WTF::TCMalloc_Central_FreeList::enumerateFreeObjects): Don't directly compare pointers mapped into the local process with
a pointer that has not been mapped.  Instead, calculate a local address for the pointer and compare with that.
(WTF::TCMallocStats::FreeObjectFinder::findFreeObjects): Pass in the remote address of the central free list so that it can
be used when calculating local addresses.
(WTF::TCMallocStats::FastMallocZone::enumerate): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
mrowe@apple.com [Sat, 16 Aug 2008 06:48:10 +0000 (06:48 +0000)]
<rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework

Rubber-stamped by Geoff Garen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-15 Antti Koivisto <antti@apple.com>
antti@apple.com [Fri, 15 Aug 2008 22:58:06 +0000 (22:58 +0000)]
2008-08-15  Antti Koivisto  <antti@apple.com>

        Reviewed by Anders.

        Don't start preloading body resources before the head is complete. This prevents
        body preloads from slowing down initial display when there is limited amount
        of bandwidth available.

        Works by queuing up found body preloads to DocLoader and only issuing them
        after document has rendering.

        With bandwidth capped to 300kbit/s this speeds up cnn.com initial display by ~25% or 5s
        without affecting complete load time.

        * html/PreloadScanner.cpp:
        (WebCore::PreloadScanner::PreloadScanner):
        (WebCore::PreloadScanner::scanningBody):
        (WebCore::PreloadScanner::emitTag):
        (WebCore::PreloadScanner::emitCSSRule):
        * html/PreloadScanner.h:
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::preload):
        (WebCore::DocLoader::checkForPendingPreloads):
        (WebCore::DocLoader::requestPreload):
        * loader/DocLoader.h:
        * loader/loader.cpp:
        (WebCore::Loader::Host::didFinishLoading):
        (WebCore::Loader::Host::didFail):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Use item's computed style if the render style is 0 before falling back to...
adachan@apple.com [Fri, 15 Aug 2008 21:08:40 +0000 (21:08 +0000)]
    Use item's computed style if the render style is 0 before falling back to the <select>'s style.
        This way style set on an <hr> within a <select> will be honored.

        Reviewed by Dave Hyatt and Dan Bernstein.

        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::itemStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-15 Antti Koivisto <antti@apple.com>
antti@apple.com [Fri, 15 Aug 2008 20:48:06 +0000 (20:48 +0000)]
2008-08-15  Antti Koivisto  <antti@apple.com>

        Reviewed by Oliver.

        Some loader performance tweaks:
        - Make stylesheets highest priority instead of scripts. We block script execution on stylesheets.
          Especially if a stylesheet @imports other stylesheets it is important to get them to the front of the queue
          to not delay rendering.
        - Issue the first resource load for a host immediately even if the resource is low priority. TCP connection setup
          can take long time when latency is high so it is good to get started early.
        - When the document is fully parsed and stylesheets have been loaded there is no need to keep managing the
          load queues. Issue remaining loads to the network layer.

        * loader/loader.cpp:
        (WebCore::Loader::determinePriority):
        (WebCore::Loader::load):
        (WebCore::Loader::Host::servePendingRequests):
        * loader/loader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Detach the script debugger when the Web Inspector's window closes.
timothy@apple.com [Fri, 15 Aug 2008 18:35:39 +0000 (18:35 +0000)]
    Detach the script debugger when the Web Inspector's window closes.
        This has always been the intended design, but never fully implemented.

        https://bugs.webkit.org/show_bug.cgi?id=20402

        Reviewed by Adam Roben.

        * page/InspectorController.cpp:
        (WebCore::InspectorController::setWindowVisible): Call stopDebugging()
        if the window is no longer visible.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35798 268f45cc-cd09-0410-ab3c-d52691b4dbfc