WebKit-https.git
7 years agoUnreviewed. Rolled DEPS.
peter@chromium.org [Thu, 2 Aug 2012 10:03:00 +0000 (10:03 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Improve garbage collector hint if page uses Canvas contexts
commit-queue@webkit.org [Thu, 2 Aug 2012 09:26:37 +0000 (09:26 +0000)]
[chromium] Improve garbage collector hint if page uses Canvas contexts
https://bugs.webkit.org/show_bug.cgi?id=92856

Patch by ulan@chromium.org <ulan@chromium.org> on 2012-08-02
Reviewed by Kentaro Hara.

Request GC by sending context disposed and idle notification to V8 instead
of sending low memory notification. It is faster as it causes one GC
instead of seven GCs caused by low memory notification.

* bindings/v8/V8Binding.cpp:
(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):
* bindings/v8/V8Binding.h:
(V8BindingPerIsolateData):
(WebCore::V8BindingPerIsolateData::setShouldCollectGarbageSoon):
(WebCore::V8BindingPerIsolateData::clearShouldCollectGarbageSoon):
(WebCore::V8BindingPerIsolateData::shouldCollectGarbageSoon):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::hintForGCIfNecessary):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] fast/forms/color/input-appearance-color.html and input-color-onchange...
keishi@webkit.org [Thu, 2 Aug 2012 09:18:58 +0000 (09:18 +0000)]
[Chromium] fast/forms/color/input-appearance-color.html and input-color-onchange-event.html are failing on WebKit waterfall
https://bugs.webkit.org/show_bug.cgi?id=88951

Unreviewed.

Rebaseline these two tests.

* platform/chromium-linux/fast/forms/color/input-appearance-color-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/color/input-appearance-color-expected.png: Added.
* platform/chromium-mac/fast/forms/color/input-appearance-color-expected.png: Added.
* platform/chromium-mac/fast/forms/color/input-appearance-color-expected.txt: Added.
* platform/chromium-win/fast/forms/color/input-appearance-color-expected.png: Added.
* platform/chromium-win/fast/forms/color/input-appearance-color-expected.txt: Added.
* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/color/input-color-onchange-event-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Test expectation updates.
pkasting@chromium.org [Thu, 2 Aug 2012 09:14:28 +0000 (09:14 +0000)]
[Chromium] Test expectation updates.
https://bugs.webkit.org/show_bug.cgi?id=76270
https://bugs.webkit.org/show_bug.cgi?id=92941

Mark a test as flakily crashing, unskip some questionably-skipped tests, reorganize slow test section a bit.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening after r124278, r124371
commit-queue@webkit.org [Thu, 2 Aug 2012 09:09:34 +0000 (09:09 +0000)]
[EFL] Gardening after r124278, r124371
https://bugs.webkit.org/show_bug.cgi?id=92959

Unreviewed gardening.

Putting to TestExpectations css3/flexbox/content-height-with-scrollbars.html and
http/tests/security/contentSecurityPolicy/object-src-url-blocked.html.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-02

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add WebKitNetworkResponse::suggested-filename property
commit-queue@webkit.org [Thu, 2 Aug 2012 09:06:21 +0000 (09:06 +0000)]
[GTK] Add WebKitNetworkResponse::suggested-filename property
https://bugs.webkit.org/show_bug.cgi?id=92878

Patch by Claudio Saavedra <csaavedra@igalia.com> on 2012-08-02
Reviewed by Carlos Garcia Campos.

Webcore has API the suggested filename for a response, add
a property and getter for it in WebKitNetworkResponse.

* docs/webkitgtk-sections.txt: Add the symbols
* webkit/webkitnetworkresponse.cpp:
(_WebKitNetworkResponsePrivate): Add suggested_filename.
(webkit_network_response_finalize): Free it on finalize
(webkit_network_response_get_property): Add the getter call.
(webkit_network_response_class_init): Install the property.
(webkit_network_response_get_suggested_filename): New getter.
* webkit/webkitnetworkresponse.h: Add the declaration to header
file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Update expectations of calendar-picker-appearance.html
tkent@chromium.org [Thu, 2 Aug 2012 09:04:58 +0000 (09:04 +0000)]
[Chromium] Update expectations of calendar-picker-appearance.html
https://bugs.webkit.org/show_bug.cgi?id=92710

* platform/chromium-linux-x86/fast/forms/date/calendar-picker-appearance-expected.png: Removed.
* platform/chromium-linux/fast/forms/date/calendar-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/date/calendar-picker-appearance-expected.png:
* platform/chromium-mac/fast/forms/date/calendar-picker-appearance-expected.png:
* platform/chromium-win-xp/fast/forms/date/calendar-picker-appearance-expected.png:
* platform/chromium-win/fast/forms/date/calendar-picker-appearance-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSSRegions: Crash when reattaching a region to a named flow.
mihnea@adobe.com [Thu, 2 Aug 2012 08:49:52 +0000 (08:49 +0000)]
CSSRegions: Crash when reattaching a region to a named flow.
https://bugs.webkit.org/show_bug.cgi?id=91307

Reviewed by Abhishek Arya.

Source/WebCore:

The lifetime of a flow thread  has changed from not being destroyed (until the RenderView is destroyed) to being destroyed,
under certain conditions, no attached regions and no content, before RenderView is destroyed.
When the flow thread does not have any content and the region to be detached is the last region for the flow thread,
the flow thread is destroyed.
In this case, if the same region has to be attached again to the flow thread, the flow thread needs to be
recreated, otherwise the crash will result.

Test: fast/regions/region-flow-reattach-crash.html

* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::attachRegion):
We skip the attach if we are in the middle of document destruction.
We recreate the flow thread to which the region is intended to be attached only if the region was
not previously marked as invalid in relation to the flow thread (because the region was part of a
circular dependency).
(WebCore::RenderRegion::detachRegion): After the region is detached from flow thread,
null the region internal pointer to the flow thread to mark that the region is not
attached.

LayoutTests:

Test that after the last region from a flow thread is reattached
to the same flow thread, the flow thread object is properly recreated
thus preventing a crash.

* fast/regions/region-flow-reattach-crash-expected.txt: Added.
* fast/regions/region-flow-reattach-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed, expectations cleanup
apavlov@chromium.org [Thu, 2 Aug 2012 08:46:52 +0000 (08:46 +0000)]
[Chromium] Unreviewed, expectations cleanup

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
kkristof@inf.u-szeged.hu [Thu, 2 Aug 2012 08:43:47 +0000 (08:43 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped:
* platform/qt/fast/box-sizing/box-sizing-expected.txt:
* platform/qt/fast/forms/basic-selects-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, missed a style goof in the previous patch: "NodeIndex nodeIndex"
fpizlo@apple.com [Thu, 2 Aug 2012 08:27:48 +0000 (08:27 +0000)]
Unreviewed, missed a style goof in the previous patch: "NodeIndex nodeIndex"
in a method signature is painfully redundant.

* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream API: Move RTCConfiguration to its proper place
tommyw@google.com [Thu, 2 Aug 2012 08:23:13 +0000 (08:23 +0000)]
MediaStream API: Move RTCConfiguration to its proper place
https://bugs.webkit.org/show_bug.cgi?id=92867

Reviewed by Adam Barth.

This patch moves RTCConfiguration to Source/WebCore/platform/mediastream,
and adds its WebKit interface for chromium.

Source/Platform:

* Platform.gypi:
* chromium/public/WebRTCConfiguration.h: Added.
(WebCore):
(WebKit):
(WebRTCICEServer):
(WebKit::WebRTCICEServer::WebRTCICEServer):
(WebKit::WebRTCICEServer::~WebRTCICEServer):
(WebKit::WebRTCICEServer::operator=):
(WebKit::WebRTCICEServer::isNull):
(WebRTCConfiguration):
(WebKit::WebRTCConfiguration::WebRTCConfiguration):
(WebKit::WebRTCConfiguration::~WebRTCConfiguration):
(WebKit::WebRTCConfiguration::operator=):
(WebKit::WebRTCConfiguration::isNull):

Source/WebCore:

No functional code changes.

* GNUmakefile.list.am:
* Modules/mediastream/RTCPeerConnection.cpp:
* WebCore.gypi:
* platform/chromium/support/WebRTCConfiguration.cpp: Added.
(WebKit):
(WebKit::WebRTCICEServer::WebRTCICEServer):
(WebKit::WebRTCICEServer::assign):
(WebKit::WebRTCICEServer::reset):
(WebKit::WebRTCICEServer::uri):
(WebKit::WebRTCICEServer::credential):
(WebKit::WebRTCConfiguration::WebRTCConfiguration):
(WebKit::WebRTCConfiguration::assign):
(WebKit::WebRTCConfiguration::reset):
(WebKit::WebRTCConfiguration::numberOfServers):
(WebKit::WebRTCConfiguration::server):
* platform/mediastream/RTCConfiguration.h: Added.
(WebCore):
(RTCIceServer):
(WebCore::RTCIceServer::create):
(WebCore::RTCIceServer::~RTCIceServer):
(WebCore::RTCIceServer::uri):
(WebCore::RTCIceServer::credential):
(WebCore::RTCIceServer::RTCIceServer):
(RTCConfiguration):
(WebCore::RTCConfiguration::create):
(WebCore::RTCConfiguration::~RTCConfiguration):
(WebCore::RTCConfiguration::appendServer):
(WebCore::RTCConfiguration::numberOfServers):
(WebCore::RTCConfiguration::server):
(WebCore::RTCConfiguration::RTCConfiguration):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFGSpeculativeJIT.h has too many inline method bodies
fpizlo@apple.com [Thu, 2 Aug 2012 08:22:57 +0000 (08:22 +0000)]
DFGSpeculativeJIT.h has too many inline method bodies
https://bugs.webkit.org/show_bug.cgi?id=92957

Reviewed by Antti Koivisto.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::speculationCheck):
(DFG):
(JSC::DFG::SpeculativeJIT::speculationWatchpoint):
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):
(JSC::DFG::SpeculativeJIT::speculationCheckWithConditionalDirection):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecutionWithConditionalDirection):
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayout Test fast/forms/input-widths.html is failing
yosin@chromium.org [Thu, 2 Aug 2012 08:17:13 +0000 (08:17 +0000)]
Layout Test fast/forms/input-widths.html is failing
https://bugs.webkit.org/show_bug.cgi?id=92863

Reviewed by Kent Tamura.

This patch removes test cases for "date", "datetime", "datetime-local",
"month", "time" and "week" input types from fast/forms/input-widths.html
and updates its expectation, because these test cases aren't reasonable
any more.

This patch also removes test sample of input type "color".

After r124314, All chromium ports, except for Android, input type
"time" uses "monospace" font which makes input field wider.

* fast/forms/input-widths-expected.txt: Removed expectation of "date", "datetime", "datetime-local",
"month", "time" and "week" input types.
* fast/forms/input-widths.html: Removed test cases for "date", "datetime", "datetime-local",
"month", "time" and "week" input types, and a test sample for "color".
* platform/chromium/TestExpectations: Removed disabling line of fast/forms/input-widths.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline per bug 92904.
pkasting@chromium.org [Thu, 2 Aug 2012 07:49:47 +0000 (07:49 +0000)]
Rebaseline per bug 92904.
https://bugs.webkit.org/show_bug.cgi?id=92904

Unreviewed, rebaselining.

* fast/box-sizing/box-sizing-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/box-sizing/box-sizing-expected.png:
* platform/chromium-mac-snowleopard/fast/box-sizing/box-sizing-expected.txt: Removed.
* platform/chromium-mac/compositing/overflow/clip-descendents-expected.txt: Added.
* platform/chromium-mac/fast/box-sizing/box-sizing-expected.png:
* platform/chromium-mac/fast/box-sizing/box-sizing-expected.txt:
* platform/chromium-win-xp/fast/box-sizing: Added.
* platform/chromium-win-xp/fast/box-sizing/box-sizing-expected.png: Added.
* platform/chromium-win/fast/box-sizing/box-sizing-expected.png:
* platform/chromium/TestExpectations:
* platform/efl/fast/box-sizing/box-sizing-expected.txt: Removed.
* platform/gtk/fast/box-sizing/box-sizing-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Browser crashes when non-progress element with -webkit-appearance:progress...
commit-queue@webkit.org [Thu, 2 Aug 2012 07:48:29 +0000 (07:48 +0000)]
[EFL] Browser crashes when non-progress element with -webkit-appearance:progress-bar is rendered
https://bugs.webkit.org/show_bug.cgi?id=92747

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-08-02
Reviewed by Hajime Morita.

When https://bugs.webkit.org/show_bug.cgi?id=40158 was fixed, all ports
were fixed except EFL port. This patch fixes assert that is hit when
non-progress element is rendered with -webkit-appearance:progress-bar style.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintProgressBar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r102741): [Forms] In selects, when disabled, browser skips first option...
yosin@chromium.org [Thu, 2 Aug 2012 07:14:49 +0000 (07:14 +0000)]
REGRESSION(r102741): [Forms] In selects, when disabled, browser skips first option if not in optgroup, then selects first option in optgroup
https://bugs.webkit.org/show_bug.cgi?id=92833

Reviewed by Kent Tamura.

Source/WebCore:

This patch changes implementation of HTMLOptionElement::disabled() to
follow the "disabled" concept of option element in HTML5 specification[1],
the option element is disabled if option element has "disabled"
attribute or parent optgroup element has "disabled" attribute. Before
this patch, HTMLOptionElement::disabled() checks presenting "disabled"
attribute in option element itself and any parent element.

Before this patch, HTMLSelectElement::recalcListItems() didn't considers
non-disabled option as default selected option if select element is
disabled because HTMLOptionElement::disabled() returned true if select
element is disabled.

After this patch, HTMLOptionElement::disabled() is independent from
select element. HTMLSelectElement::recalcListItems() considers
non-disabled option as default selected option.

[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#concept-option-disabled

Tests: fast/forms/basic-selects.html: Fixed expectation to right thing.

* css/html.css:
(select[disabled]>option): Added to render option elements in disabled
select element to disabled color as before this patch.
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::disabled): Changed to check parent element
is optgroup.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): On mouse up
and down, don't update selection if select element is disabled.
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintItemForeground): Added checking select
element is disabled. Before this patch, it was done by HTMLOptionElement::disabled().

LayoutTests:

This patch updates test expectation of fast/forms/basic-selects.html
for Chromium-Linux and disables it for Chromium-Mac and Chromium-Win.

Note: We need to rebaseline for all ports expect for Chromium-Linux.

* platform/chromium-linux/fast/forms/basic-selects-expected.png: Changed for default selected option for disabled select element, "foo" to "bar" of second select element of "Line-height should be ignored" line.
* platform/chromium-linux/fast/forms/basic-selects-expected.txt:
* platform/chromium/TestExpectations: Disabled fast/forms/basic-selects.html for Chromium-Mac and Chromium-Win.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed, mark fast/js/dfg-osr-entry-hoisted-clobbered-structure-check...
apavlov@chromium.org [Thu, 2 Aug 2012 07:09:18 +0000 (07:09 +0000)]
[Chromium] Unreviewed, mark fast/js/dfg-osr-entry-hoisted-clobbered-structure-check.html as DEBUG SLOW = PASS.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed, update test expectations.
apavlov@chromium.org [Thu, 2 Aug 2012 06:59:34 +0000 (06:59 +0000)]
[Chromium] Unreviewed, update test expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r124406.
commit-queue@webkit.org [Thu, 2 Aug 2012 06:44:46 +0000 (06:44 +0000)]
Unreviewed, rolling out r124406.
http://trac.webkit.org/changeset/124406
https://bugs.webkit.org/show_bug.cgi?id=92951

it set the Mac bots on fire (Requested by pizlo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-01

Source/JavaScriptCore:

* bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDebugHook):
* bytecompiler/BytecodeGenerator.h:
(BytecodeGenerator):
* bytecompiler/NodesCodegen.cpp:
(JSC::ArrayNode::toArgumentList):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::ConditionalNode::emitBytecode):
(JSC::ConstStatementNode::emitBytecode):
(JSC::EmptyStatementNode::emitBytecode):
(JSC::DebuggerStatementNode::emitBytecode):
(JSC::ExprStatementNode::emitBytecode):
(JSC::VarStatementNode::emitBytecode):
(JSC::IfNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::WithNode::emitBytecode):
(JSC::SwitchNode::emitBytecode):
(JSC::LabelNode::emitBytecode):
(JSC::ThrowNode::emitBytecode):
(JSC::TryNode::emitBytecode):
(JSC::ProgramNode::emitBytecode):
(JSC::EvalNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode):
* debugger/Debugger.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::debug):
* interpreter/Interpreter.h:
(Interpreter):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_debug):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_debug):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* parser/ASTBuilder.h:
(ASTBuilder):
(JSC::ASTBuilder::createCommaExpr):
(JSC::ASTBuilder::createLogicalNot):
(JSC::ASTBuilder::createUnaryPlus):
(JSC::ASTBuilder::createVoid):
(JSC::ASTBuilder::thisExpr):
(JSC::ASTBuilder::createResolve):
(JSC::ASTBuilder::createObjectLiteral):
(JSC::ASTBuilder::createArray):
(JSC::ASTBuilder::createNumberExpr):
(JSC::ASTBuilder::createString):
(JSC::ASTBuilder::createBoolean):
(JSC::ASTBuilder::createNull):
(JSC::ASTBuilder::createBracketAccess):
(JSC::ASTBuilder::createDotAccess):
(JSC::ASTBuilder::createRegExp):
(JSC::ASTBuilder::createNewExpr):
(JSC::ASTBuilder::createConditionalExpr):
(JSC::ASTBuilder::createAssignResolve):
(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createArgumentsList):
(JSC::ASTBuilder::createPropertyList):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::createBlockStatement):
(JSC::ASTBuilder::createExprStatement):
(JSC::ASTBuilder::createIfStatement):
(JSC::ASTBuilder::createForLoop):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::createEmptyStatement):
(JSC::ASTBuilder::createVarStatement):
(JSC::ASTBuilder::createReturnStatement):
(JSC::ASTBuilder::createBreakStatement):
(JSC::ASTBuilder::createContinueStatement):
(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::createSwitchStatement):
(JSC::ASTBuilder::createWhileStatement):
(JSC::ASTBuilder::createDoWhileStatement):
(JSC::ASTBuilder::createLabelStatement):
(JSC::ASTBuilder::createWithStatement):
(JSC::ASTBuilder::createThrowStatement):
(JSC::ASTBuilder::createDebugger):
(JSC::ASTBuilder::createConstStatement):
(JSC::ASTBuilder::appendConstDecl):
(JSC::ASTBuilder::combineCommaNodes):
(JSC::ASTBuilder::appendBinaryOperation):
(JSC::ASTBuilder::createAssignment):
(JSC::ASTBuilder::createNumber):
(JSC::ASTBuilder::makeTypeOfNode):
(JSC::ASTBuilder::makeDeleteNode):
(JSC::ASTBuilder::makeNegateNode):
(JSC::ASTBuilder::makeBitwiseNotNode):
(JSC::ASTBuilder::makeMultNode):
(JSC::ASTBuilder::makeDivNode):
(JSC::ASTBuilder::makeModNode):
(JSC::ASTBuilder::makeAddNode):
(JSC::ASTBuilder::makeSubNode):
(JSC::ASTBuilder::makeLeftShiftNode):
(JSC::ASTBuilder::makeRightShiftNode):
(JSC::ASTBuilder::makeURightShiftNode):
(JSC::ASTBuilder::makeBitOrNode):
(JSC::ASTBuilder::makeBitAndNode):
(JSC::ASTBuilder::makeBitXOrNode):
(JSC::ASTBuilder::makeFunctionCallNode):
(JSC::ASTBuilder::makeBinaryNode):
(JSC::ASTBuilder::makeAssignNode):
(JSC::ASTBuilder::makePrefixNode):
(JSC::ASTBuilder::makePostfixNode):
* parser/Lexer.cpp:
(JSC::::setCode):
(JSC::::internalShift):
(JSC::::shift):
(JSC::::lex):
* parser/Lexer.h:
(Lexer):
(JSC::::lexExpectIdentifier):
* parser/NodeConstructors.h:
(JSC::Node::Node):
(JSC::ExpressionNode::ExpressionNode):
(JSC::StatementNode::StatementNode):
(JSC::NullNode::NullNode):
(JSC::BooleanNode::BooleanNode):
(JSC::NumberNode::NumberNode):
(JSC::StringNode::StringNode):
(JSC::RegExpNode::RegExpNode):
(JSC::ThisNode::ThisNode):
(JSC::ResolveNode::ResolveNode):
(JSC::ArrayNode::ArrayNode):
(JSC::PropertyListNode::PropertyListNode):
(JSC::ObjectLiteralNode::ObjectLiteralNode):
(JSC::BracketAccessorNode::BracketAccessorNode):
(JSC::DotAccessorNode::DotAccessorNode):
(JSC::ArgumentListNode::ArgumentListNode):
(JSC::NewExprNode::NewExprNode):
(JSC::EvalFunctionCallNode::EvalFunctionCallNode):
(JSC::FunctionCallValueNode::FunctionCallValueNode):
(JSC::FunctionCallResolveNode::FunctionCallResolveNode):
(JSC::FunctionCallBracketNode::FunctionCallBracketNode):
(JSC::FunctionCallDotNode::FunctionCallDotNode):
(JSC::CallFunctionCallDotNode::CallFunctionCallDotNode):
(JSC::ApplyFunctionCallDotNode::ApplyFunctionCallDotNode):
(JSC::PrePostResolveNode::PrePostResolveNode):
(JSC::PostfixResolveNode::PostfixResolveNode):
(JSC::PostfixBracketNode::PostfixBracketNode):
(JSC::PostfixDotNode::PostfixDotNode):
(JSC::PostfixErrorNode::PostfixErrorNode):
(JSC::DeleteResolveNode::DeleteResolveNode):
(JSC::DeleteBracketNode::DeleteBracketNode):
(JSC::DeleteDotNode::DeleteDotNode):
(JSC::DeleteValueNode::DeleteValueNode):
(JSC::VoidNode::VoidNode):
(JSC::TypeOfResolveNode::TypeOfResolveNode):
(JSC::TypeOfValueNode::TypeOfValueNode):
(JSC::PrefixResolveNode::PrefixResolveNode):
(JSC::PrefixBracketNode::PrefixBracketNode):
(JSC::PrefixDotNode::PrefixDotNode):
(JSC::PrefixErrorNode::PrefixErrorNode):
(JSC::UnaryOpNode::UnaryOpNode):
(JSC::UnaryPlusNode::UnaryPlusNode):
(JSC::NegateNode::NegateNode):
(JSC::BitwiseNotNode::BitwiseNotNode):
(JSC::LogicalNotNode::LogicalNotNode):
(JSC::BinaryOpNode::BinaryOpNode):
(JSC::MultNode::MultNode):
(JSC::DivNode::DivNode):
(JSC::ModNode::ModNode):
(JSC::AddNode::AddNode):
(JSC::SubNode::SubNode):
(JSC::LeftShiftNode::LeftShiftNode):
(JSC::RightShiftNode::RightShiftNode):
(JSC::UnsignedRightShiftNode::UnsignedRightShiftNode):
(JSC::LessNode::LessNode):
(JSC::GreaterNode::GreaterNode):
(JSC::LessEqNode::LessEqNode):
(JSC::GreaterEqNode::GreaterEqNode):
(JSC::ThrowableBinaryOpNode::ThrowableBinaryOpNode):
(JSC::InstanceOfNode::InstanceOfNode):
(JSC::InNode::InNode):
(JSC::EqualNode::EqualNode):
(JSC::NotEqualNode::NotEqualNode):
(JSC::StrictEqualNode::StrictEqualNode):
(JSC::NotStrictEqualNode::NotStrictEqualNode):
(JSC::BitAndNode::BitAndNode):
(JSC::BitOrNode::BitOrNode):
(JSC::BitXOrNode::BitXOrNode):
(JSC::LogicalOpNode::LogicalOpNode):
(JSC::ConditionalNode::ConditionalNode):
(JSC::ReadModifyResolveNode::ReadModifyResolveNode):
(JSC::AssignResolveNode::AssignResolveNode):
(JSC::ReadModifyBracketNode::ReadModifyBracketNode):
(JSC::AssignBracketNode::AssignBracketNode):
(JSC::AssignDotNode::AssignDotNode):
(JSC::ReadModifyDotNode::ReadModifyDotNode):
(JSC::AssignErrorNode::AssignErrorNode):
(JSC::CommaNode::CommaNode):
(JSC::ConstStatementNode::ConstStatementNode):
(JSC::EmptyStatementNode::EmptyStatementNode):
(JSC::DebuggerStatementNode::DebuggerStatementNode):
(JSC::ExprStatementNode::ExprStatementNode):
(JSC::VarStatementNode::VarStatementNode):
(JSC::IfNode::IfNode):
(JSC::IfElseNode::IfElseNode):
(JSC::DoWhileNode::DoWhileNode):
(JSC::WhileNode::WhileNode):
(JSC::ForNode::ForNode):
(JSC::ContinueNode::ContinueNode):
(JSC::BreakNode::BreakNode):
(JSC::ReturnNode::ReturnNode):
(JSC::WithNode::WithNode):
(JSC::LabelNode::LabelNode):
(JSC::ThrowNode::ThrowNode):
(JSC::TryNode::TryNode):
(JSC::FuncExprNode::FuncExprNode):
(JSC::FuncDeclNode::FuncDeclNode):
(JSC::SwitchNode::SwitchNode):
(JSC::ConstDeclNode::ConstDeclNode):
(JSC::BlockNode::BlockNode):
(JSC::ForInNode::ForInNode):
* parser/Nodes.cpp:
(JSC):
(JSC::StatementNode::setLoc):
(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create):
* parser/Nodes.h:
(Node):
(ExpressionNode):
(StatementNode):
(NullNode):
(BooleanNode):
(NumberNode):
(StringNode):
(RegExpNode):
(ThisNode):
(ResolveNode):
(ArrayNode):
(PropertyListNode):
(ObjectLiteralNode):
(BracketAccessorNode):
(DotAccessorNode):
(ArgumentListNode):
(NewExprNode):
(EvalFunctionCallNode):
(FunctionCallValueNode):
(FunctionCallResolveNode):
(FunctionCallBracketNode):
(FunctionCallDotNode):
(CallFunctionCallDotNode):
(ApplyFunctionCallDotNode):
(PrePostResolveNode):
(PostfixResolveNode):
(PostfixBracketNode):
(PostfixDotNode):
(PostfixErrorNode):
(DeleteResolveNode):
(DeleteBracketNode):
(DeleteDotNode):
(DeleteValueNode):
(VoidNode):
(TypeOfResolveNode):
(TypeOfValueNode):
(PrefixResolveNode):
(PrefixBracketNode):
(PrefixDotNode):
(PrefixErrorNode):
(UnaryOpNode):
(UnaryPlusNode):
(NegateNode):
(BitwiseNotNode):
(LogicalNotNode):
(BinaryOpNode):
(MultNode):
(DivNode):
(ModNode):
(AddNode):
(SubNode):
(LeftShiftNode):
(RightShiftNode):
(UnsignedRightShiftNode):
(LessNode):
(GreaterNode):
(LessEqNode):
(GreaterEqNode):
(ThrowableBinaryOpNode):
(InstanceOfNode):
(InNode):
(EqualNode):
(NotEqualNode):
(StrictEqualNode):
(NotStrictEqualNode):
(BitAndNode):
(BitOrNode):
(BitXOrNode):
(LogicalOpNode):
(ConditionalNode):
(ReadModifyResolveNode):
(AssignResolveNode):
(ReadModifyBracketNode):
(AssignBracketNode):
(AssignDotNode):
(ReadModifyDotNode):
(AssignErrorNode):
(CommaNode):
(ConstDeclNode):
(ConstStatementNode):
(BlockNode):
(EmptyStatementNode):
(DebuggerStatementNode):
(ExprStatementNode):
(VarStatementNode):
(IfNode):
(IfElseNode):
(DoWhileNode):
(WhileNode):
(ForNode):
(ForInNode):
(ContinueNode):
(BreakNode):
(ReturnNode):
(WithNode):
(LabelNode):
(ThrowNode):
(TryNode):
(ScopeNode):
(ProgramNode):
(EvalNode):
(FunctionBodyNode):
(FuncExprNode):
(FuncDeclNode):
(SwitchNode):
* parser/Parser.cpp:
(JSC::::parseSourceElements):
(JSC::::parseVarDeclaration):
(JSC::::parseConstDeclaration):
(JSC::::parseDoWhileStatement):
(JSC::::parseWhileStatement):
(JSC::::parseVarDeclarationList):
(JSC::::parseConstDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseBreakStatement):
(JSC::::parseContinueStatement):
(JSC::::parseReturnStatement):
(JSC::::parseThrowStatement):
(JSC::::parseWithStatement):
(JSC::::parseSwitchStatement):
(JSC::::parseTryStatement):
(JSC::::parseDebuggerStatement):
(JSC::::parseBlockStatement):
(JSC::::parseStatement):
(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):
(JSC::::parseFunctionDeclaration):
(JSC::::parseExpressionOrLabelStatement):
(JSC::::parseExpressionStatement):
(JSC::::parseIfStatement):
(JSC::::parseExpression):
(JSC::::parseAssignmentExpression):
(JSC::::parseConditionalExpression):
(JSC::::parseBinaryExpression):
(JSC::::parseProperty):
(JSC::::parseObjectLiteral):
(JSC::::parseStrictObjectLiteral):
(JSC::::parseArrayLiteral):
(JSC::::parsePrimaryExpression):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):
(JSC::::parseUnaryExpression):
* parser/Parser.h:
(JSC::Parser::next):
(JSC::Parser::nextExpectIdentifier):
(JSC::Parser::tokenStart):
(JSC::Parser::tokenLine):
(JSC::Parser::tokenEnd):
(JSC::Parser::getTokenName):
(JSC::::parse):
* parser/ParserTokens.h:
(JSC::JSTokenInfo::JSTokenInfo):
(JSTokenInfo):
(JSToken):
* parser/SourceProviderCacheItem.h:
(JSC::SourceProviderCacheItem::closeBraceToken):
* parser/SyntaxChecker.h:
(JSC::SyntaxChecker::makeFunctionCallNode):
(JSC::SyntaxChecker::createCommaExpr):
(JSC::SyntaxChecker::makeAssignNode):
(JSC::SyntaxChecker::makePrefixNode):
(JSC::SyntaxChecker::makePostfixNode):
(JSC::SyntaxChecker::makeTypeOfNode):
(JSC::SyntaxChecker::makeDeleteNode):
(JSC::SyntaxChecker::makeNegateNode):
(JSC::SyntaxChecker::makeBitwiseNotNode):
(JSC::SyntaxChecker::createLogicalNot):
(JSC::SyntaxChecker::createUnaryPlus):
(JSC::SyntaxChecker::createVoid):
(JSC::SyntaxChecker::thisExpr):
(JSC::SyntaxChecker::createResolve):
(JSC::SyntaxChecker::createObjectLiteral):
(JSC::SyntaxChecker::createArray):
(JSC::SyntaxChecker::createNumberExpr):
(JSC::SyntaxChecker::createString):
(JSC::SyntaxChecker::createBoolean):
(JSC::SyntaxChecker::createNull):
(JSC::SyntaxChecker::createBracketAccess):
(JSC::SyntaxChecker::createDotAccess):
(JSC::SyntaxChecker::createRegExp):
(JSC::SyntaxChecker::createNewExpr):
(JSC::SyntaxChecker::createConditionalExpr):
(JSC::SyntaxChecker::createAssignResolve):
(JSC::SyntaxChecker::createFunctionExpr):
(JSC::SyntaxChecker::createFunctionBody):
(JSC::SyntaxChecker::createArgumentsList):
(JSC::SyntaxChecker::createPropertyList):
(JSC::SyntaxChecker::createFuncDeclStatement):
(JSC::SyntaxChecker::createBlockStatement):
(JSC::SyntaxChecker::createExprStatement):
(JSC::SyntaxChecker::createIfStatement):
(JSC::SyntaxChecker::createForLoop):
(JSC::SyntaxChecker::createForInLoop):
(JSC::SyntaxChecker::createEmptyStatement):
(JSC::SyntaxChecker::createVarStatement):
(JSC::SyntaxChecker::createReturnStatement):
(JSC::SyntaxChecker::createBreakStatement):
(JSC::SyntaxChecker::createContinueStatement):
(JSC::SyntaxChecker::createTryStatement):
(JSC::SyntaxChecker::createSwitchStatement):
(JSC::SyntaxChecker::createWhileStatement):
(JSC::SyntaxChecker::createWithStatement):
(JSC::SyntaxChecker::createDoWhileStatement):
(JSC::SyntaxChecker::createLabelStatement):
(JSC::SyntaxChecker::createThrowStatement):
(JSC::SyntaxChecker::createDebugger):
(JSC::SyntaxChecker::createConstStatement):
(JSC::SyntaxChecker::appendConstDecl):
(JSC::SyntaxChecker::createGetterOrSetterProperty):
(JSC::SyntaxChecker::combineCommaNodes):
(JSC::SyntaxChecker::operatorStackPop):

Source/WebCore:

* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::callEvent):
(WebCore::ScriptDebugServer::atStatement):
(WebCore::ScriptDebugServer::returnEvent):
(WebCore::ScriptDebugServer::exception):
(WebCore::ScriptDebugServer::willExecuteProgram):
(WebCore::ScriptDebugServer::didExecuteProgram):
(WebCore::ScriptDebugServer::didReachBreakpoint):
* bindings/js/ScriptDebugServer.h:
(ScriptDebugServer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: test native memory instrumentation code with help of unittests
loislo@chromium.org [Thu, 2 Aug 2012 06:32:29 +0000 (06:32 +0000)]
Web Inspector: test native memory instrumentation code with help of unittests
https://bugs.webkit.org/show_bug.cgi?id=92743

Reviewed by Yury Semikhatsky.

Test a part of existing Native Memory Instrumentation code with help of unit tests.
6 tests were added and two bugs were fixed.
a drive-by improvement: the method MemoryInstrumentation::addInstrumentedObject
was marked as private and addRootObject was introduced instead of it.
The new function also calls processDeferedPointers.

Source/WebCore:

* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::collectBindingMemoryInfo):
* dom/MemoryInstrumentation.h:
(WebCore::MemoryInstrumentation::addRootObject):
(MemoryInstrumentation):
(WebCore::MemoryInstrumentation::addInstrumentedObject):
(WebCore::MemoryInstrumentation::addInstrumentedObjectImpl):
(WebCore):
(WebCore::MemoryInstrumentation::addObjectImpl):
* inspector/InspectorMemoryAgent.cpp:
(WebCore):
* inspector/MemoryInstrumentationImpl.h:
(MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::totalSize):
(WebCore::MemoryInstrumentationImpl::reportedSizeForAllTypes):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/MemoryInstrumentationTest.cpp: Added.
(WebCore):
(NotInstrumented):
(Instrumented):
(WebCore::Instrumented::Instrumented):
(WebCore::Instrumented::~Instrumented):
(WebCore::Instrumented::reportMemoryUsage):
(WebCore::TEST):
(InstrumentedWithOwnPtr):
(WebCore::InstrumentedWithOwnPtr::InstrumentedWithOwnPtr):
(WebCore::InstrumentedWithOwnPtr::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium Android build fix after r124402.
rniwa@webkit.org [Thu, 2 Aug 2012 05:57:42 +0000 (05:57 +0000)]
Chromium Android build fix after r124402.
Initialize the out variables as suggested by the compiler.

* Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode):
(WebCore::IDBLevelDBCoding::IndexNamesKey::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse testRunner instead of layoutTestController in fast/notifications, overflow, parse...
rniwa@webkit.org [Thu, 2 Aug 2012 05:53:47 +0000 (05:53 +0000)]
Use testRunner instead of layoutTestController in fast/notifications, overflow, parser, performance,
preloader, profiler, reflections, regex, regions, repaint, ruby and runin tests
https://bugs.webkit.org/show_bug.cgi?id=92944

Reviewed by Kent Tamura.

* fast/notifications/notification-after-close.html:
* fast/notifications/notifications-cancel-request-permission.html:
* fast/notifications/notifications-check-permission.html:
* fast/notifications/notifications-click-event-focus.html:
* fast/notifications/notifications-click-event.html:
* fast/notifications/notifications-display-close-events.html:
* fast/notifications/notifications-document-close-crash.html:
* fast/notifications/notifications-double-show.html:
* fast/notifications/notifications-event-stop-propagation.html-disabled:
* fast/notifications/notifications-multi-events.html-disabled:
* fast/notifications/notifications-no-icon.html:
* fast/notifications/notifications-replace.html:
* fast/notifications/notifications-request-permission.html:
* fast/notifications/notifications-rtl.html:
* fast/notifications/notifications-window-close-crash.html:
* fast/notifications/notifications-with-permission.html:
* fast/notifications/notifications-without-permission.html:
* fast/notifications/resources/notifications-cancel-request-permission.html:
* fast/overflow/generated-content-crash.html:
* fast/overflow/hidden-scrollbar-resize.html:
* fast/overflow/horizontal-scroll-after-back.html:
* fast/overflow/lots-of-sibling-inline-boxes.html:
* fast/overflow/onscroll-layer-self-destruct.html:
* fast/overflow/overflow-height-float-not-removed-crash.html:
* fast/overflow/overflow-height-float-not-removed-crash2.html:
* fast/overflow/overflow-height-float-not-removed-crash3.html:
* fast/overflow/overflow-rtl-vertical-origin.html:
* fast/overflow/overflow-text-hit-testing.html:
* fast/overflow/overflow-y-scroll.html:
* fast/overflow/scroll-vertical-not-horizontal.html:
* fast/overflow/scrollRevealButton.html:
* fast/overflow/scrollbar-restored-and-then-locked.html:
* fast/overflow/scrollbar-restored.html:
* fast/overflow/setting-scrollTop-after-hide-show.html:
* fast/parser/:
* fast/preloader/document-write-2.html:
* fast/preloader/document-write-noscript.html:
* fast/preloader/document-write.html:
* fast/preloader/first-base-tag-scanned-wins.html:
* fast/preloader/first-base-tag-wins.html:
* fast/preloader/image.html:
* fast/preloader/input.html:
* fast/preloader/link.html:
* fast/preloader/noscript.html:
* fast/preloader/scan-body-from-head-import.html:
* fast/preloader/scan-body-from-head-script.html:
* fast/preloader/script.html:
* fast/preloader/style.html:
* fast/preloader/understands-base-tag.html:
* fast/profiler/:
* fast/reflections/inline-crash.html:
* fast/reflections/pending-reflection-mask-crash.html:
* fast/reflections/reflected-img-crash.html:
* fast/reflections/reflection-computed-style.html:
* fast/reflections/remove-reflection-crash.html:
* fast/reflections/resources/reflection-overflow-scroll.js:
* fast/reflections/teardown-crash.html:
* fast/reflections/toggle-reflection-crash.html:
* fast/regex/syntax-errors.html:
* fast/regions/content-flowed-into-regions-no-scroll.html:
* fast/regions/element-region-overflow-state-vertical-rl.html:
* fast/regions/element-region-overflow-state.html:
* fast/regions/flexbox-in-region-crash.html:
* fast/regions/flow-anonymous-children.html:
* fast/regions/flowed-content-bounding-client-rect-horizontal-bt.html:
* fast/regions/flowed-content-bounding-client-rect-vertical-rl.html:
* fast/regions/flowed-content-bounding-client-rect-vertical.html:
* fast/regions/flowed-content-bounding-client-rect.html:
* fast/regions/flowed-content-transform-bounding-client-rect.html:
* fast/regions/get-regions-by-content-horiz-bt.html:
* fast/regions/get-regions-by-content-horiz-tb.html:
* fast/regions/get-regions-by-content-vert-lr.html:
* fast/regions/get-regions-by-content-vert-rl.html:
* fast/regions/get-regions-by-content.html:
* fast/regions/get-regions-by-content2.html:
* fast/regions/hit-test-float.html:
* fast/regions/hit-test-region.html:
* fast/regions/imbricated-flow-threads-crash.html:
* fast/regions/no-split-line-box.html:
* fast/regions/parse-incomplete-region-rule.html:
* fast/regions/parsing-region-style-rule.html:
* fast/regions/region-element-dynamic-attach-flow.html:
* fast/regions/region-element-dynamic-detach-flow.html:
* fast/regions/region-range-for-box-crash.html:
* fast/regions/region-style-block-background-color2.html:
* fast/regions/script-tests/css-regions-disabled.js:
* fast/regions/select-in-region-crash.html:
* fast/regions/set-box-style-in-region-crash.html:
* fast/regions/svg-root-element-collected.html:
* fast/regions/symbol-in-named-flow-crash.svg:
* fast/regions/text-region-breaks.html:
* fast/regions/text-region-split-after-resize.html:
* fast/regions/text-region-split-horizontal-bt.html:
* fast/regions/text-region-split-vertical-rl.html:
* fast/regions/text-region-split-vertical.html:
* fast/regions/text-region-split.html:
* fast/regions/webkit-named-flow-event-add-to-flow.html:
* fast/regions/webkit-named-flow-event-no-regions.html:
* fast/regions/webkit-named-flow-event-remove-from-dom.html:
* fast/regions/webkit-named-flow-event-remove-from-flow.html:
* fast/regions/webkit-named-flow-event-target.html:
* fast/regions/webkit-named-flow-event-to-null.html:
* fast/regions/webkit-named-flow-event.html:
* fast/regions/webkit-named-flow-existing-flow.html:
* fast/regions/webkit-named-flow-first-empty-region-index.html:
* fast/regions/webkit-named-flow-flow-added.html:
* fast/regions/webkit-named-flow-get-content.html:
* fast/regions/webkit-named-flow-invalid-name.html:
* fast/regions/webkit-named-flow-modified-flow.html:
* fast/regions/webkit-named-flow-name.html:
* fast/regions/webkit-named-flow-non-existing-flow.html:
* fast/regions/webkit-named-flow-overset.html:
* fast/regions/webkit-named-flow-removed-flow.html:
* fast/regions/webkit-named-flow-same-object.html:
* fast/repaint/:
* fast/replaced/css-content-and-webkit-mask-box-image-crash.html:
* fast/replaced/frame-removed-during-resize-smaller.html:
* fast/replaced/frame-removed-during-resize.html:
* fast/replaced/image-map-2.html:
* fast/replaced/image-map-bug16782.html:
* fast/replaced/image-map.html:
* fast/replaced/image-resize-width.html:
* fast/replaced/invalid-object-with-fallback.html:
* fast/replaced/object-param-no-name.html:
* fast/replaced/object-param-spaces.html:
* fast/replaced/object-with-embed-url-param.html:
* fast/replaced/object-with-non-empty-classid-triggers-fallback.html:
* fast/replaced/outline-replaced-elements.html:
* fast/replaced/resources/focus-test.js:
(checkNoFocusRing):
* fast/replaced/table-percent-height-text-controls.html:
* fast/replaced/table-percent-height.html:
* fast/replaced/table-percent-width.html:
* fast/replaced/table-replaced-element.html:
* fast/replaced/vertical-resize-100percent-element.html:
* fast/replaced/width100percent-textarea.html:
* platform/chromium/fast/repaint/fixed-layout-360x240.html:
* platform/mac/fast/overflow/overflow-scrollbar-hit-test.html:
* platform/qt/fast/repaint/flexible-box-overflow-expected.txt:
* platform/qt/fast/repaint/flexible-box-overflow-horizontal-expected.txt:
* platform/qt/fast/repaint/focus-ring-expected.txt:
* platform/qt/fast/repaint/inline-block-overflow-expected.txt:
* platform/qt/fast/repaint/layer-child-outline-expected.txt:
* platform/qt/fast/repaint/layer-outline-expected.txt:
* platform/qt/fast/repaint/layer-outline-horizontal-expected.txt:
* platform/qt/fast/repaint/list-marker-expected.txt:
* platform/qt/fast/repaint/text-shadow-expected.txt:
* platform/qt/fast/repaint/text-shadow-horizontal-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix typo in colorSuggestionPicker.js
keishi@webkit.org [Thu, 2 Aug 2012 05:29:57 +0000 (05:29 +0000)]
Fix typo in colorSuggestionPicker.js
https://bugs.webkit.org/show_bug.cgi?id=92936

Reviewed by Kent Tamura.

Source/WebCore:

Fixes typo.

Test: platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html

* Resources/colorSuggestionPicker.js:
(getScrollbarWidth):

LayoutTests:

* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.txt: Added.
* platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html: Added. Tests the appearance when there are many datalist options.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Test expectation updates.
pkasting@chromium.org [Thu, 2 Aug 2012 05:21:22 +0000 (05:21 +0000)]
[Chromium] Test expectation updates.
https://bugs.webkit.org/show_bug.cgi?id=72990
https://bugs.webkit.org/show_bug.cgi?id=74694
https://bugs.webkit.org/show_bug.cgi?id=80219
https://bugs.webkit.org/show_bug.cgi?id=90741
https://bugs.webkit.org/show_bug.cgi?id=92850
https://bugs.webkit.org/show_bug.cgi?id=92852
https://bugs.webkit.org/show_bug.cgi?id=92938
https://bugs.webkit.org/show_bug.cgi?id=92941

Unreviewed, test expectation updates.

* Attempting to fix http/tests/cache tests dumping as pixel tests by
  changing "window.testRunner.dumpAsText()" to "testRunner.dumpAsText()"
  since the test opens multiple windows.  (I don't know why else it
  might not be working.)
* Removing erroneous Chromium Linux pixel baselines for that test.
* Rebaselined a CSS test after http://trac.webkit.org/changeset/123782 ,
  which only got partially rebaselined before.
* Fixed some incorrect bug numbers on some expectations.
* Miscellaneous other stuff.

* http/tests/cache/history-only-cached-subresource-loads-max-age-https.html:
* http/tests/cache/history-only-cached-subresource-loads.html:
* platform/chromium-linux/http/tests/cache/history-only-cached-subresource-loads-expected.png: Removed.
* platform/chromium-linux/http/tests/cache/history-only-cached-subresource-loads-max-age-https-expected.png: Removed.
* platform/chromium-mac-snowleopard/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt: Removed.
* platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThe elements in Shadow DOM of input should not be modifiable.
shinyak@chromium.org [Thu, 2 Aug 2012 04:57:24 +0000 (04:57 +0000)]
The elements in Shadow DOM of input should not be modifiable.
https://bugs.webkit.org/show_bug.cgi?id=92200

Reviewed by Kent Tamura.

Source/WebCore:

Since we don't have "-webkit-user-modify: read-only !important;" for the elements in Shadow DOM of
input element, user can change them and it causes a crash.

We should have "-webkit-user-modify: read-only !important;" for those elements.

Test: fast/forms/input-user-modify.html

* css/html.css:
(input::-webkit-textfield-decoration-container):
(input[type="search"]::-webkit-search-cancel-button):
(input[type="search"]::-webkit-search-decoration):
(input[type="search"]::-webkit-search-results-decoration):
(input[type="search"]::-webkit-search-results-button):
(input::-webkit-inner-spin-button):
(input::-webkit-input-speech-button):
(input::-webkit-input-placeholder, isindex::-webkit-input-placeholder):
(input[type="file"]::-webkit-file-upload-button):
(input[type="range"]::-webkit-slider-container, input[type="range"]::-webkit-media-slider-container):
(input[type="range"]::-webkit-slider-runnable-track):
(input[type="range"]::-webkit-slider-thumb, input[type="range"]::-webkit-media-slider-thumb):
(input[type="color"]::-webkit-color-swatch-wrapper):
(input[type="color"]::-webkit-color-swatch):
(input::-webkit-calendar-picker-indicator):

LayoutTests:

* fast/forms/input-user-modify-expected.txt: Added.
* fast/forms/input-user-modify.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [JSC] implement setting breakpoints by line:column
commit-queue@webkit.org [Thu, 2 Aug 2012 04:49:25 +0000 (04:49 +0000)]
Web Inspector: [JSC] implement setting breakpoints by line:column
https://bugs.webkit.org/show_bug.cgi?id=53003

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-08-01
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Add a counter in lexer to record the column of each token. Debugger will use column info
in "Pretty Print" debug mode of Inspector.

* bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDebugHook):
* bytecompiler/BytecodeGenerator.h:
(BytecodeGenerator):
* bytecompiler/NodesCodegen.cpp:
(JSC::ArrayNode::toArgumentList):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::ConditionalNode::emitBytecode):
(JSC::ConstStatementNode::emitBytecode):
(JSC::EmptyStatementNode::emitBytecode):
(JSC::DebuggerStatementNode::emitBytecode):
(JSC::ExprStatementNode::emitBytecode):
(JSC::VarStatementNode::emitBytecode):
(JSC::IfNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::WithNode::emitBytecode):
(JSC::SwitchNode::emitBytecode):
(JSC::LabelNode::emitBytecode):
(JSC::ThrowNode::emitBytecode):
(JSC::TryNode::emitBytecode):
(JSC::ProgramNode::emitBytecode):
(JSC::EvalNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode):
* debugger/Debugger.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::debug):
* interpreter/Interpreter.h:
(Interpreter):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_debug):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_debug):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* parser/ASTBuilder.h:
(ASTBuilder):
(JSC::ASTBuilder::createCommaExpr):
(JSC::ASTBuilder::createLogicalNot):
(JSC::ASTBuilder::createUnaryPlus):
(JSC::ASTBuilder::createVoid):
(JSC::ASTBuilder::thisExpr):
(JSC::ASTBuilder::createResolve):
(JSC::ASTBuilder::createObjectLiteral):
(JSC::ASTBuilder::createArray):
(JSC::ASTBuilder::createNumberExpr):
(JSC::ASTBuilder::createString):
(JSC::ASTBuilder::createBoolean):
(JSC::ASTBuilder::createNull):
(JSC::ASTBuilder::createBracketAccess):
(JSC::ASTBuilder::createDotAccess):
(JSC::ASTBuilder::createRegExp):
(JSC::ASTBuilder::createNewExpr):
(JSC::ASTBuilder::createConditionalExpr):
(JSC::ASTBuilder::createAssignResolve):
(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createArgumentsList):
(JSC::ASTBuilder::createPropertyList):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::createBlockStatement):
(JSC::ASTBuilder::createExprStatement):
(JSC::ASTBuilder::createIfStatement):
(JSC::ASTBuilder::createForLoop):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::createEmptyStatement):
(JSC::ASTBuilder::createVarStatement):
(JSC::ASTBuilder::createReturnStatement):
(JSC::ASTBuilder::createBreakStatement):
(JSC::ASTBuilder::createContinueStatement):
(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::createSwitchStatement):
(JSC::ASTBuilder::createWhileStatement):
(JSC::ASTBuilder::createDoWhileStatement):
(JSC::ASTBuilder::createLabelStatement):
(JSC::ASTBuilder::createWithStatement):
(JSC::ASTBuilder::createThrowStatement):
(JSC::ASTBuilder::createDebugger):
(JSC::ASTBuilder::createConstStatement):
(JSC::ASTBuilder::appendConstDecl):
(JSC::ASTBuilder::combineCommaNodes):
(JSC::ASTBuilder::appendBinaryOperation):
(JSC::ASTBuilder::createAssignment):
(JSC::ASTBuilder::createNumber):
(JSC::ASTBuilder::makeTypeOfNode):
(JSC::ASTBuilder::makeDeleteNode):
(JSC::ASTBuilder::makeNegateNode):
(JSC::ASTBuilder::makeBitwiseNotNode):
(JSC::ASTBuilder::makeMultNode):
(JSC::ASTBuilder::makeDivNode):
(JSC::ASTBuilder::makeModNode):
(JSC::ASTBuilder::makeAddNode):
(JSC::ASTBuilder::makeSubNode):
(JSC::ASTBuilder::makeLeftShiftNode):
(JSC::ASTBuilder::makeRightShiftNode):
(JSC::ASTBuilder::makeURightShiftNode):
(JSC::ASTBuilder::makeBitOrNode):
(JSC::ASTBuilder::makeBitAndNode):
(JSC::ASTBuilder::makeBitXOrNode):
(JSC::ASTBuilder::makeFunctionCallNode):
(JSC::ASTBuilder::makeBinaryNode):
(JSC::ASTBuilder::makeAssignNode):
(JSC::ASTBuilder::makePrefixNode):
(JSC::ASTBuilder::makePostfixNode):
* parser/Lexer.cpp:
(JSC::::setCode):
(JSC::::internalShift):
(JSC::::shift):
(JSC::::lex):
* parser/Lexer.h:
(Lexer):
(JSC::Lexer::currentColumnNumber):
(JSC::::lexExpectIdentifier):
* parser/NodeConstructors.h:
(JSC::Node::Node):
(JSC::ExpressionNode::ExpressionNode):
(JSC::StatementNode::StatementNode):
(JSC::NullNode::NullNode):
(JSC::BooleanNode::BooleanNode):
(JSC::NumberNode::NumberNode):
(JSC::StringNode::StringNode):
(JSC::RegExpNode::RegExpNode):
(JSC::ThisNode::ThisNode):
(JSC::ResolveNode::ResolveNode):
(JSC::ArrayNode::ArrayNode):
(JSC::PropertyListNode::PropertyListNode):
(JSC::ObjectLiteralNode::ObjectLiteralNode):
(JSC::BracketAccessorNode::BracketAccessorNode):
(JSC::DotAccessorNode::DotAccessorNode):
(JSC::ArgumentListNode::ArgumentListNode):
(JSC::NewExprNode::NewExprNode):
(JSC::EvalFunctionCallNode::EvalFunctionCallNode):
(JSC::FunctionCallValueNode::FunctionCallValueNode):
(JSC::FunctionCallResolveNode::FunctionCallResolveNode):
(JSC::FunctionCallBracketNode::FunctionCallBracketNode):
(JSC::FunctionCallDotNode::FunctionCallDotNode):
(JSC::CallFunctionCallDotNode::CallFunctionCallDotNode):
(JSC::ApplyFunctionCallDotNode::ApplyFunctionCallDotNode):
(JSC::PrePostResolveNode::PrePostResolveNode):
(JSC::PostfixResolveNode::PostfixResolveNode):
(JSC::PostfixBracketNode::PostfixBracketNode):
(JSC::PostfixDotNode::PostfixDotNode):
(JSC::PostfixErrorNode::PostfixErrorNode):
(JSC::DeleteResolveNode::DeleteResolveNode):
(JSC::DeleteBracketNode::DeleteBracketNode):
(JSC::DeleteDotNode::DeleteDotNode):
(JSC::DeleteValueNode::DeleteValueNode):
(JSC::VoidNode::VoidNode):
(JSC::TypeOfResolveNode::TypeOfResolveNode):
(JSC::TypeOfValueNode::TypeOfValueNode):
(JSC::PrefixResolveNode::PrefixResolveNode):
(JSC::PrefixBracketNode::PrefixBracketNode):
(JSC::PrefixDotNode::PrefixDotNode):
(JSC::PrefixErrorNode::PrefixErrorNode):
(JSC::UnaryOpNode::UnaryOpNode):
(JSC::UnaryPlusNode::UnaryPlusNode):
(JSC::NegateNode::NegateNode):
(JSC::BitwiseNotNode::BitwiseNotNode):
(JSC::LogicalNotNode::LogicalNotNode):
(JSC::BinaryOpNode::BinaryOpNode):
(JSC::MultNode::MultNode):
(JSC::DivNode::DivNode):
(JSC::ModNode::ModNode):
(JSC::AddNode::AddNode):
(JSC::SubNode::SubNode):
(JSC::LeftShiftNode::LeftShiftNode):
(JSC::RightShiftNode::RightShiftNode):
(JSC::UnsignedRightShiftNode::UnsignedRightShiftNode):
(JSC::LessNode::LessNode):
(JSC::GreaterNode::GreaterNode):
(JSC::LessEqNode::LessEqNode):
(JSC::GreaterEqNode::GreaterEqNode):
(JSC::ThrowableBinaryOpNode::ThrowableBinaryOpNode):
(JSC::InstanceOfNode::InstanceOfNode):
(JSC::InNode::InNode):
(JSC::EqualNode::EqualNode):
(JSC::NotEqualNode::NotEqualNode):
(JSC::StrictEqualNode::StrictEqualNode):
(JSC::NotStrictEqualNode::NotStrictEqualNode):
(JSC::BitAndNode::BitAndNode):
(JSC::BitOrNode::BitOrNode):
(JSC::BitXOrNode::BitXOrNode):
(JSC::LogicalOpNode::LogicalOpNode):
(JSC::ConditionalNode::ConditionalNode):
(JSC::ReadModifyResolveNode::ReadModifyResolveNode):
(JSC::AssignResolveNode::AssignResolveNode):
(JSC::ReadModifyBracketNode::ReadModifyBracketNode):
(JSC::AssignBracketNode::AssignBracketNode):
(JSC::AssignDotNode::AssignDotNode):
(JSC::ReadModifyDotNode::ReadModifyDotNode):
(JSC::AssignErrorNode::AssignErrorNode):
(JSC::CommaNode::CommaNode):
(JSC::ConstStatementNode::ConstStatementNode):
(JSC::EmptyStatementNode::EmptyStatementNode):
(JSC::DebuggerStatementNode::DebuggerStatementNode):
(JSC::ExprStatementNode::ExprStatementNode):
(JSC::VarStatementNode::VarStatementNode):
(JSC::IfNode::IfNode):
(JSC::IfElseNode::IfElseNode):
(JSC::DoWhileNode::DoWhileNode):
(JSC::WhileNode::WhileNode):
(JSC::ForNode::ForNode):
(JSC::ContinueNode::ContinueNode):
(JSC::BreakNode::BreakNode):
(JSC::ReturnNode::ReturnNode):
(JSC::WithNode::WithNode):
(JSC::LabelNode::LabelNode):
(JSC::ThrowNode::ThrowNode):
(JSC::TryNode::TryNode):
(JSC::FuncExprNode::FuncExprNode):
(JSC::FuncDeclNode::FuncDeclNode):
(JSC::SwitchNode::SwitchNode):
(JSC::ConstDeclNode::ConstDeclNode):
(JSC::BlockNode::BlockNode):
(JSC::ForInNode::ForInNode):
* parser/Nodes.cpp:
(JSC::StatementNode::setLoc):
(JSC):
(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create):
* parser/Nodes.h:
(Node):
(JSC::Node::columnNo):
(ExpressionNode):
(StatementNode):
(JSC::StatementNode::column):
(NullNode):
(BooleanNode):
(NumberNode):
(StringNode):
(RegExpNode):
(ThisNode):
(ResolveNode):
(ArrayNode):
(PropertyListNode):
(ObjectLiteralNode):
(BracketAccessorNode):
(DotAccessorNode):
(ArgumentListNode):
(NewExprNode):
(EvalFunctionCallNode):
(FunctionCallValueNode):
(FunctionCallResolveNode):
(FunctionCallBracketNode):
(FunctionCallDotNode):
(CallFunctionCallDotNode):
(ApplyFunctionCallDotNode):
(PrePostResolveNode):
(PostfixResolveNode):
(PostfixBracketNode):
(PostfixDotNode):
(PostfixErrorNode):
(DeleteResolveNode):
(DeleteBracketNode):
(DeleteDotNode):
(DeleteValueNode):
(VoidNode):
(TypeOfResolveNode):
(TypeOfValueNode):
(PrefixResolveNode):
(PrefixBracketNode):
(PrefixDotNode):
(PrefixErrorNode):
(UnaryOpNode):
(UnaryPlusNode):
(NegateNode):
(BitwiseNotNode):
(LogicalNotNode):
(BinaryOpNode):
(MultNode):
(DivNode):
(ModNode):
(AddNode):
(SubNode):
(LeftShiftNode):
(RightShiftNode):
(UnsignedRightShiftNode):
(LessNode):
(GreaterNode):
(LessEqNode):
(GreaterEqNode):
(ThrowableBinaryOpNode):
(InstanceOfNode):
(InNode):
(EqualNode):
(NotEqualNode):
(StrictEqualNode):
(NotStrictEqualNode):
(BitAndNode):
(BitOrNode):
(BitXOrNode):
(LogicalOpNode):
(ConditionalNode):
(ReadModifyResolveNode):
(AssignResolveNode):
(ReadModifyBracketNode):
(AssignBracketNode):
(AssignDotNode):
(ReadModifyDotNode):
(AssignErrorNode):
(CommaNode):
(ConstDeclNode):
(ConstStatementNode):
(BlockNode):
(EmptyStatementNode):
(DebuggerStatementNode):
(ExprStatementNode):
(VarStatementNode):
(IfNode):
(IfElseNode):
(DoWhileNode):
(WhileNode):
(ForNode):
(ForInNode):
(ContinueNode):
(BreakNode):
(ReturnNode):
(WithNode):
(LabelNode):
(ThrowNode):
(TryNode):
(ScopeNode):
(ProgramNode):
(EvalNode):
(FunctionBodyNode):
(FuncExprNode):
(FuncDeclNode):
(SwitchNode):
* parser/Parser.cpp:
(JSC::::parseSourceElements):
(JSC::::parseVarDeclaration):
(JSC::::parseConstDeclaration):
(JSC::::parseDoWhileStatement):
(JSC::::parseWhileStatement):
(JSC::::parseVarDeclarationList):
(JSC::::parseConstDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseBreakStatement):
(JSC::::parseContinueStatement):
(JSC::::parseReturnStatement):
(JSC::::parseThrowStatement):
(JSC::::parseWithStatement):
(JSC::::parseSwitchStatement):
(JSC::::parseTryStatement):
(JSC::::parseDebuggerStatement):
(JSC::::parseBlockStatement):
(JSC::::parseStatement):
(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):
(JSC::::parseFunctionDeclaration):
(JSC::::parseExpressionOrLabelStatement):
(JSC::::parseExpressionStatement):
(JSC::::parseIfStatement):
(JSC::::parseExpression):
(JSC::::parseAssignmentExpression):
(JSC::::parseConditionalExpression):
(JSC::::parseBinaryExpression):
(JSC::::parseProperty):
(JSC::::parseObjectLiteral):
(JSC::::parseStrictObjectLiteral):
(JSC::::parseArrayLiteral):
(JSC::::parsePrimaryExpression):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):
(JSC::::parseUnaryExpression):
* parser/Parser.h:
(JSC::Parser::next):
(JSC::Parser::nextExpectIdentifier):
(JSC::Parser::tokenStart):
(JSC::Parser::tokenLine):
(JSC::Parser::tokenEnd):
(JSC::Parser::tokenLocation):
(Parser):
(JSC::Parser::getTokenName):
(JSC::::parse):
* parser/ParserTokens.h:
(JSC::JSTokenLocation::JSTokenLocation):
(JSTokenLocation):
(JSToken):
* parser/SourceProviderCacheItem.h:
(JSC::SourceProviderCacheItem::closeBraceToken):
* parser/SyntaxChecker.h:
(JSC::SyntaxChecker::makeFunctionCallNode):
(JSC::SyntaxChecker::createCommaExpr):
(JSC::SyntaxChecker::makeAssignNode):
(JSC::SyntaxChecker::makePrefixNode):
(JSC::SyntaxChecker::makePostfixNode):
(JSC::SyntaxChecker::makeTypeOfNode):
(JSC::SyntaxChecker::makeDeleteNode):
(JSC::SyntaxChecker::makeNegateNode):
(JSC::SyntaxChecker::makeBitwiseNotNode):
(JSC::SyntaxChecker::createLogicalNot):
(JSC::SyntaxChecker::createUnaryPlus):
(JSC::SyntaxChecker::createVoid):
(JSC::SyntaxChecker::thisExpr):
(JSC::SyntaxChecker::createResolve):
(JSC::SyntaxChecker::createObjectLiteral):
(JSC::SyntaxChecker::createArray):
(JSC::SyntaxChecker::createNumberExpr):
(JSC::SyntaxChecker::createString):
(JSC::SyntaxChecker::createBoolean):
(JSC::SyntaxChecker::createNull):
(JSC::SyntaxChecker::createBracketAccess):
(JSC::SyntaxChecker::createDotAccess):
(JSC::SyntaxChecker::createRegExp):
(JSC::SyntaxChecker::createNewExpr):
(JSC::SyntaxChecker::createConditionalExpr):
(JSC::SyntaxChecker::createAssignResolve):
(JSC::SyntaxChecker::createFunctionExpr):
(JSC::SyntaxChecker::createFunctionBody):
(JSC::SyntaxChecker::createArgumentsList):
(JSC::SyntaxChecker::createPropertyList):
(JSC::SyntaxChecker::createFuncDeclStatement):
(JSC::SyntaxChecker::createBlockStatement):
(JSC::SyntaxChecker::createExprStatement):
(JSC::SyntaxChecker::createIfStatement):
(JSC::SyntaxChecker::createForLoop):
(JSC::SyntaxChecker::createForInLoop):
(JSC::SyntaxChecker::createEmptyStatement):
(JSC::SyntaxChecker::createVarStatement):
(JSC::SyntaxChecker::createReturnStatement):
(JSC::SyntaxChecker::createBreakStatement):
(JSC::SyntaxChecker::createContinueStatement):
(JSC::SyntaxChecker::createTryStatement):
(JSC::SyntaxChecker::createSwitchStatement):
(JSC::SyntaxChecker::createWhileStatement):
(JSC::SyntaxChecker::createWithStatement):
(JSC::SyntaxChecker::createDoWhileStatement):
(JSC::SyntaxChecker::createLabelStatement):
(JSC::SyntaxChecker::createThrowStatement):
(JSC::SyntaxChecker::createDebugger):
(JSC::SyntaxChecker::createConstStatement):
(JSC::SyntaxChecker::appendConstDecl):
(JSC::SyntaxChecker::createGetterOrSetterProperty):
(JSC::SyntaxChecker::combineCommaNodes):
(JSC::SyntaxChecker::operatorStackPop):

Source/WebCore:

As JSC is enabled to provide column info of statement, ScriptDebugServer can use it to
support "Pretty Print" debug mode.

No new test case for this patch.

* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore):
(WebCore::ScriptDebugServer::updateCurrentStatementPosition):
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::callEvent):
(WebCore::ScriptDebugServer::atStatement):
(WebCore::ScriptDebugServer::returnEvent):
(WebCore::ScriptDebugServer::exception):
(WebCore::ScriptDebugServer::willExecuteProgram):
(WebCore::ScriptDebugServer::didExecuteProgram):
(WebCore::ScriptDebugServer::didReachBreakpoint):
* bindings/js/ScriptDebugServer.h:
(ScriptDebugServer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][Regression] Build break with NETSCAPE_PLUGIN_API after r123604
ryuan.choi@samsung.com [Thu, 2 Aug 2012 04:45:32 +0000 (04:45 +0000)]
[EFL][Regression] Build break with NETSCAPE_PLUGIN_API after r123604
https://bugs.webkit.org/show_bug.cgi?id=92937

Unreviewed build fix.

r123604 replaced strdup to eina_stringshare, but related codes are not
changed properly.
This patch changes remained code to use eina_stringshare.

* ewk/ewk_js.cpp:
(ewk_js_variant_to_npvariant):
(ewk_js_property_free):
(ewk_js_npvariant_to_variant):
(ewk_js_variant_free):
(ewk_js_variant_array_free):
* ewk/ewk_js.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG should hoist structure checks
fpizlo@apple.com [Thu, 2 Aug 2012 04:32:30 +0000 (04:32 +0000)]
DFG should hoist structure checks
https://bugs.webkit.org/show_bug.cgi?id=92696

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

This hoists structure checks in the same way that we would hoist array checks, but with added
complexity to cope with the fact that the structure of an object may change. This is handled
by performing a side effects analysis over the region in which the respective variable is
live. If a structure clobbering side effect may happen then we either hoist the structure
checks and fall back on structure transition watchpoints (if the watchpoint set is still
valid), or we avoid hoisting altogether.

Doing this required teaching the CFA that we may have an expectation that an object has a
particular structure even after structure clobbering happens, in the sense that structure
proofs that were cobbered can be revived using watchpoints. CFA must know about this so that
OSR entry may know about it, since we cannot allow entry to happen if the variable has a
clobbered structure proof, will have a watchpoint to revive the proof, and the variable in
the baseline JIT has a completely unrelated structure.

This is mostly performance neutral.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/ValueRecovery.h:
(JSC::ValueRecovery::isSet):
(JSC::ValueRecovery::operator!):
(ValueRecovery):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::clobberWorld):
(DFG):
(JSC::DFG::AbstractState::clobberCapturedVars):
* dfg/DFGAbstractState.h:
(AbstractState):
* dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::clear):
(JSC::DFG::AbstractValue::isClear):
(JSC::DFG::AbstractValue::makeTop):
(JSC::DFG::AbstractValue::isTop):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::operator==):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::validate):
(JSC::DFG::AbstractValue::validateForEntry):
(AbstractValue):
(JSC::DFG::AbstractValue::checkConsistency):
(JSC::DFG::AbstractValue::dump):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::fixVariableAccessSpeculations):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::checkStructureLoadElimination):
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(JSC::DFG::CSEPhase::putStructureStoreElimination):
(JSC::DFG::CSEPhase::getLocalLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::vote):
(Graph):
* dfg/DFGNode.h:
(JSC::DFG::Node::convertToStructureTransitionWatchpoint):
(Node):
(JSC::DFG::Node::hasStructureSet):
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):
(JSC::DFG::SpeculativeJIT::speculationCheckWithConditionalDirection):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecutionWithConditionalDirection):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(JSC::DFG::SpeculateCellOperand::gpr):
(SpeculateCellOperand):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGStructureCheckHoistingPhase.cpp: Added.
(DFG):
(StructureCheckHoistingPhase):
(JSC::DFG::StructureCheckHoistingPhase::StructureCheckHoistingPhase):
(JSC::DFG::StructureCheckHoistingPhase::run):
(JSC::DFG::StructureCheckHoistingPhase::noticeStructureCheck):
(JSC::DFG::StructureCheckHoistingPhase::noticeClobber):
(JSC::DFG::StructureCheckHoistingPhase::clobber):
(CheckData):
(JSC::DFG::StructureCheckHoistingPhase::CheckData::CheckData):
(JSC::DFG::performStructureCheckHoisting):
* dfg/DFGStructureCheckHoistingPhase.h: Added.
(DFG):
* dfg/DFGVariableAccessData.h:
(VariableAccessData):
(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::mergeStructureCheckHoistingFailed):
(JSC::DFG::VariableAccessData::structureCheckHoistingFailed):
(JSC::DFG::VariableAccessData::clearVotes):
(JSC::DFG::VariableAccessData::vote):
(JSC::DFG::VariableAccessData::voteRatio):
(JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):
* runtime/Options.h:
(JSC):

LayoutTests:

Rubber stamped by Gavin Barraclough.

Added a new test that covers the following scenarios:

- OSR entry if a variable with a hoisted check has an unexpected structure, structures get clobbered, and
  we're protecting ourselves with structure transition watchpoints.

- OSR exit on hoisted structure checks, if the object doesn't have the expected structure, and where the
  source of the assignment is side-effecting.

I combined these into a single test because there is no way to test the latter without testing the former.

* fast/js/dfg-osr-entry-hoisted-clobbered-structure-check-expected.txt: Added.
* fast/js/dfg-osr-entry-hoisted-clobbered-structure-check.html: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/dfg-osr-entry-hoisted-clobbered-structure-check.js: Added.
(foo):
(bar):
(baz):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Favicon should be Base64 encoded for cross-process passing
charles.wei@torchmobile.com.cn [Thu, 2 Aug 2012 03:55:40 +0000 (03:55 +0000)]
[BlackBerry] Favicon should be Base64 encoded for cross-process passing
https://bugs.webkit.org/show_bug.cgi?id=92857

Reviewed by George Staikos.

The current implementation just passes the internal of SkPixels data to the client,
which can't be passed accross the process boundary to chrome for processing.
This patch makes the favicon Base64 encoded so that can be passed to chrome in another process.

* Api/WebPageClient.h:
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: ObjectStoreMetaDataKey::m_metaDataType should use byte type
commit-queue@webkit.org [Thu, 2 Aug 2012 03:08:10 +0000 (03:08 +0000)]
IndexedDB: ObjectStoreMetaDataKey::m_metaDataType should use byte type
https://bugs.webkit.org/show_bug.cgi?id=92725

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-08-01
Reviewed by Kentaro Hara.

Source/WebCore:

No new tests - Low level functions covered by existing layout tests and also covered by Chromium
webkit_unit_tests IDBLevelIDBCodingTest.*.

* Modules/indexeddb/IDBLevelDBCoding.cpp:
(IDBLevelDBCoding):
(WebCore::IDBLevelDBCoding::decodeByte):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode):
(WebCore::IDBLevelDBCoding::IndexNamesKey::decode):
* Modules/indexeddb/IDBLevelDBCoding.h:
(IDBLevelDBCoding):

Source/WebKit/chromium:

Add two new tests in IDBLevelDBCodingTest.cpp. One for an added function decodeByte() and
another for verifying that encodeByte() and encodeVarInt() are indentical when the encoded
values are <= 127.

* tests/IDBLevelDBCodingTest.cpp:
(IDBLevelDBCoding::TEST):
(IDBLevelDBCoding):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r123893): Reftest mismatches are run through ImageDiff with 0.1 tolerance
dpranke@chromium.org [Thu, 2 Aug 2012 02:31:18 +0000 (02:31 +0000)]
REGRESSION(r123893): Reftest mismatches are run through ImageDiff with 0.1 tolerance
https://bugs.webkit.org/show_bug.cgi?id=92847

Reviewed by Ojan Vafai.

I was failing to distinguish between 'None' and 0 :(. Fixed and added tests.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.diff_image):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_diff_image.make_proc):
(PortTestCase.test_diff_image):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Use new-style tracing macros with explicit category
commit-queue@webkit.org [Thu, 2 Aug 2012 02:29:39 +0000 (02:29 +0000)]
[chromium] Use new-style tracing macros with explicit category
https://bugs.webkit.org/show_bug.cgi?id=92928

Patch by James Robinson <jamesr@chromium.org> on 2012-08-01
Reviewed by Adam Barth.

Source/WebCore:

The chromium tracing system supports using a string identifier for trace categories that can be used to filter
events. This switches over to setting an explicit category for all traces and removes the old-style
TRACE_EVENT() macro.

* bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::animationTimerFired):
* platform/chromium/TraceEvent.h:
* platform/graphics/chromium/ProgramBinding.cpp:
(WebCore::ProgramBindingBase::init):
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::drawResampledBitmap):
(WebCore::paintSkBitmap):
(WebCore::Image::drawPattern):
* platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::resizedBitmap):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::bitmap):
* platform/image-decoders/bmp/BMPImageDecoder.cpp:
(WebCore::BMPImageDecoder::decode):
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::decode):
* platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::decode):
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageDecoder::decode):
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::decode):
* platform/image-decoders/webp/WEBPImageDecoder.cpp:
(WebCore::WEBPImageDecoder::decode):

Source/WebKit/chromium:

Set the category explicitly in traces.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::updateAnimations):
(WebKit::WebViewImpl::layout):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Crash at WebCore::toRenderSlider
commit-queue@webkit.org [Thu, 2 Aug 2012 01:44:32 +0000 (01:44 +0000)]
[EFL] Crash at WebCore::toRenderSlider
https://bugs.webkit.org/show_bug.cgi?id=92893

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-01
Reviewed by Hajime Morita.

Added a type check before casting a render object to RenderSlider as
an arbitrary element can have for example webkit-appearance: slider-horizontal.

No new tests. Existing test fast/forms/range/slider-appearance-crash.html covers the case.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintThemePart):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG should distinguish between PutByVal's that clobber the world and ones that don't
fpizlo@apple.com [Thu, 2 Aug 2012 01:28:10 +0000 (01:28 +0000)]
DFG should distinguish between PutByVal's that clobber the world and ones that don't
https://bugs.webkit.org/show_bug.cgi?id=92923

Reviewed by Mark Hahnenberg.

This is performance-neutral. I also confirmed that it's neutral if we make the
clobbering variant (PutByValSafe) clobber all knowledge of what is an array,
which should feed nicely into work on removing uses of ClassInfo.

* bytecode/DFGExitProfile.h:
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkStructureLoadElimination):
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::putByOffsetStoreElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::byValIsPure):
(JSC::DFG::Graph::clobbersWorld):
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCache support for OpenTypeVerticalData
yosin@chromium.org [Thu, 2 Aug 2012 01:26:52 +0000 (01:26 +0000)]
Cache support for OpenTypeVerticalData
https://bugs.webkit.org/show_bug.cgi?id=81332

Patch by Koji Ishii <kojiishi@gmail.com> on 2012-08-01
Reviewed by Tony Chang.

This patch adds FontCache to cache OpenTypeVerticalData class
instances that was introduced in bug 81326.

We need one instance of the class per OpenType font file, and we don't
have a class to hold such instances today.

ENABLE_OPENTYPE_VERTICAL isn't enabled for any platforms yet, so this
patch isn't on any code path. Apple Windows port (bug 48459) is going
to use this code, and probably Chromium (51450, 69282) as well.

"FIXME" comment in SimpleFontData.h will be implemented in 48459.

No new tests are required. No behavior changes.

* platform/graphics/FontCache.cpp:
(WebCore::FontCache::getCachedFontPlatformData): Ignore leading "@" on Windows to disable Windows feature for vertical flow.
(WebCore):
(WebCore::FontCache::getVerticalData): Get cached OpenTypeVerticalData from FontPlatformData, or crete one.
(WebCore::FontCache::purgeInactiveFontData): Purge inactive OpenTypeVerticalData.
* platform/graphics/FontCache.h:
(WebCore):
* platform/graphics/SimpleFontData.h:
(SimpleFontData):
(WebCore::SimpleFontData::verticalData): A dummy implementation for purgeInactiveFontData() to work.
* platform/graphics/opentype/OpenTypeVerticalData.h: Added m_inFontCache for mark & sweep.
(OpenTypeVerticalData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Move compositor HUD font atlas initialization code out of compositor core
jamesr@google.com [Thu, 2 Aug 2012 01:18:42 +0000 (01:18 +0000)]
[chromium] Move compositor HUD font atlas initialization code out of compositor core
https://bugs.webkit.org/show_bug.cgi?id=92924

Reviewed by Adrienne Walker.

Source/Platform:

The chromium compositor does not have any text rendering capabilities. It generally does not need them, but it
is helpful for some debugging aids to be able to render at least ASCII text to the screen. This provides an API
on WebLayerTreeView by which an embedder can provide an ASCII glyph atlas to use for displaying debug
information.

* chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):

Source/WebCore:

This moves the HUD font atlas initialization code out of the compositor implementation to cut out Font-related
dependencies. The new flow is that an embedder can pass a font atlas to the CCLayerTreeHost, after which the
atlas is provided the HUD layer (if any) on the next commit. The HUD layer renders text using the font atlas if
it has any if the settings require text.

HUD tested manually, we don't have automated tests for this debugging-only feature.

* platform/graphics/chromium/CompositorHUDFontAtlas.cpp:
(WebCore):
(WebCore::CompositorHUDFontAtlas::generateFontAtlas):
* platform/graphics/chromium/CompositorHUDFontAtlas.h:
(CompositorHUDFontAtlas):
* platform/graphics/chromium/HeadsUpDisplayLayerChromium.cpp:
(WebCore::HeadsUpDisplayLayerChromium::create):
(WebCore::HeadsUpDisplayLayerChromium::HeadsUpDisplayLayerChromium):
(WebCore::HeadsUpDisplayLayerChromium::setFontAtlas):
(WebCore):
(WebCore::HeadsUpDisplayLayerChromium::createCCLayerImpl):
(WebCore::HeadsUpDisplayLayerChromium::pushPropertiesTo):
* platform/graphics/chromium/HeadsUpDisplayLayerChromium.h:
(HeadsUpDisplayLayerChromium):
* platform/graphics/chromium/cc/CCFontAtlas.cpp:
(WebCore::CCFontAtlas::CCFontAtlas):
* platform/graphics/chromium/cc/CCFontAtlas.h:
(WebCore):
(WebCore::CCFontAtlas::create):
(CCFontAtlas):
* platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:
(WebCore::CCHeadsUpDisplayLayerImpl::CCHeadsUpDisplayLayerImpl):
(WebCore::CCHeadsUpDisplayLayerImpl::setFontAtlas):
(WebCore):
* platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.h:
(WebCore::CCHeadsUpDisplayLayerImpl::create):
(CCHeadsUpDisplayLayerImpl):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setFontAtlas):
(WebCore):
(WebCore::CCLayerTreeHost::willCommit):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):
(CCLayerTreeHost):

Source/WebKit/chromium:

This initializes the compositor's font atlas when initialization the compositor if the "Show FPS counter" or
"Show layer tree" settings are true.

* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setFontAtlas):
(WebKit):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix build break for chromium.
jianli@chromium.org [Thu, 2 Aug 2012 00:49:47 +0000 (00:49 +0000)]
Unreviewed. Fix build break for chromium.

* Platform.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Make WebKit API support draggable region change update
jianli@chromium.org [Thu, 2 Aug 2012 00:27:06 +0000 (00:27 +0000)]
[chromium] Make WebKit API support draggable region change update
https://bugs.webkit.org/show_bug.cgi?id=92813

Reviewed by Adam Barth.

Source/Platform:

Add WebDraggableRegion for chromium's usage.

* Platform.gypi:

Source/WebKit/chromium:

Introduce WebDraggableRegion and delegate the draggable region update
call to the new method draggableRegionsChanged in WebViewClient.

* public/WebDocument.h:
(WebDocument):
* public/WebDraggableRegion.h: Added.
(WebKit):
(WebDraggableRegion):
* public/WebViewClient.h:
(WebViewClient):
(WebKit::WebViewClient::draggableRegionsChanged):
* src/ChromeClientImpl.cpp:
(WebKit):
(WebKit::ChromeClientImpl::dashboardRegionsChanged):
* src/ChromeClientImpl.h:
(ChromeClientImpl):
* src/WebDocument.cpp:
(WebKit::WebDocument::draggableRegions):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSmall part of "Out-of-process plug-ins should support asynchronous initialization."
beidson@apple.com [Thu, 2 Aug 2012 00:26:52 +0000 (00:26 +0000)]
Small part of "Out-of-process plug-ins should support asynchronous initialization."
<rdar://problem/10598594> and https://bugs.webkit.org/show_bug.cgi?id=92919

Reviewed by Anders Carlsson.

Add API-level preferences for:
- Is asynchronous plug-in initialization enabled.
- Is an artificial initialization delay (for testing purposes) enabled.

* Shared/WebPreferencesStore.h:
(WebKit):

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetAsynchronousPluginInitializationEnabled):
(WKPreferencesGetAsynchronousPluginInitializationEnabled):
(WKPreferencesSetArtificialPluginInitializationDelayEnabled):
(WKPreferencesGetArtificialPluginInitializationDelayEnabled):
* UIProcess/API/C/WKPreferencesPrivate.h:

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::updatePreferences):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::asynchronousPluginInitializationEnabled):
(WebKit::WebPage::artificialPluginInitializationDelayEnabled):
(WebPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] factor out the optimization pass in CCRenderSurfaceFilters::apply
piman@chromium.org [Thu, 2 Aug 2012 00:22:05 +0000 (00:22 +0000)]
[chromium] factor out the optimization pass in CCRenderSurfaceFilters::apply
https://bugs.webkit.org/show_bug.cgi?id=92453

Reviewed by James Robinson.

This separates the "optimization" pass in CCRenderSurfaceFilters::apply
to resolve a succession of color matrix filters into a single operation.
This allows testing of that code.
This introduces a new generic color matrix WebFilterOperation, which can
also be used on its own.

Source/Platform:

* Platform.gypi:
* chromium/public/WebFilterOperation.h:
(WebKit::WebFilterOperation::matrix):
(WebKit::WebFilterOperation::createColorMatrixFilter):
(WebFilterOperation):
(WebKit::WebFilterOperation::WebFilterOperation):
* chromium/src/WebFilterOperation.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCRenderSurfaceFilters.h.
(WebKit):
(WebKit::WebFilterOperation::equals):
(WebKit::WebFilterOperation::WebFilterOperation):
* chromium/src/WebFilterOperations.cpp:
(WebKit::WebFilterOperations::hasFilterThatAffectsOpacity):

Source/WebCore:

New test: CCRenderSurfaceFiltersTest.

* platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:
(WebCore::CCRenderSurfaceFilters::optimize):
(WebCore):
(WebCore::CCRenderSurfaceFilters::apply):
* platform/graphics/chromium/cc/CCRenderSurfaceFilters.h:
(CCRenderSurfaceFilters):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/CCRenderSurfaceFiltersTest.cpp: Added.
(WebKit):
(WebKit::isCombined):
(WebKit::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix for drawing invalid layers in WebViewBenchmarkSupportImpl
commit-queue@webkit.org [Thu, 2 Aug 2012 00:20:08 +0000 (00:20 +0000)]
Fix for drawing invalid layers in WebViewBenchmarkSupportImpl
https://bugs.webkit.org/show_bug.cgi?id=92920

Patch by Daniel Murphy <dmurph@chromium.org> on 2012-08-01
Reviewed by Adrienne Walker.

The GraphicsLayers without content needed to be skipped.

* src/WebViewBenchmarkSupportImpl.cpp:
(WebKit::WebViewBenchmarkSupportImpl::acceleratedPaintUnclipped):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable codec tests in TestExpectations and update expected mp3 files
commit-queue@webkit.org [Thu, 2 Aug 2012 00:16:26 +0000 (00:16 +0000)]
Enable codec tests in TestExpectations and update expected mp3 files
https://bugs.webkit.org/show_bug.cgi?id=92886

Patch by Raymond Toy <rtoy@google.com> on 2012-08-01
Reviewed by Chris Rogers.

Update expected results caused by ffmpeg now removing pre-roll samples.
* platform/chromium-linux/webaudio/codec-tests/mp3/128kbps-44khz-expected.wav:
* platform/chromium-mac/webaudio/codec-tests/mp3/128kbps-44khz-expected.wav:
* platform/chromium-win/webaudio/codec-tests/mp3/128kbps-44khz-expected.wav:

Enable codec tests.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd new CSS property "-webkit-widget-region" to expose dashboard region support for...
jianli@chromium.org [Thu, 2 Aug 2012 00:14:28 +0000 (00:14 +0000)]
Add new CSS property "-webkit-widget-region" to expose dashboard region support for other port
https://bugs.webkit.org/show_bug.cgi?id=90298

Reviewed by Adam Barth.

.:

* configure.ac: Add ENABLE_WIDGET_REGION define.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig: Add ENABLE_WIDGET_REGION define.

Source/WebCore:

The css property "-webkit-widget-region" is essentially a synonym of
"-webkit-dashboard-region" that allows us to expose dashboard region
support for other port. This patch also adds a new feature define
ENABLE(WIDGET_REGION) such that "-webkit-dashboard-region" is only
provided under ENABLE(DASHBOARD_SUPPORT) as it is now and
"-webkit-widget-region" is only exposed under ENABLE(WIDGET_REGION).

Change almost all the code pieces guarded by ENABLE(DASHBOARD_SUPPORT)
to make them also guarded by ENABLE(WIDGET_REGION), except those
that are specific to Apple/WebKit.

Currently ENABLE(WIDGET_REGION) has been turned on by default for
Mac/WebKit and chromium ports.

Test: fast/css/widget-region-parser.html

* Configurations/FeatureDefines.xcconfig: Add ENABLE_WIDGET_REGION define.
* DerivedSources.make:
* GNUmakefile.am: Add ENABLE_WIDGET_REGION define.
* WebCore.exp.in:
* css/CSSComputedStyleDeclaration.cpp: Handle CSSPropertyWebkitWidgetRegion.
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp: Parse "-webkit-widget-region".
(WebCore::CSSParser::parseValue):
(WebCore):
(WebCore::CSSParser::parseDashboardRegions):
* css/CSSProperty.cpp: Handle CSSPropertyWebkitWidgetRegion.
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPrimitiveValue.cpp:
(WebCore):
(WebCore::CSSPrimitiveValue::customCssText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
* css/CSSPropertyNames.in: Add "-webkit-widget-region" property.
* css/DashboardRegion.h:
(DashboardRegion):
* css/StyleResolver.cpp: Handle CSSPropertyWebkitWidgetRegion.
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore):
* dom/Document.h:
(WebCore):
(Document):
* page/Chrome.cpp:
(WebCore):
* page/ChromeClient.h:
(ChromeClient):
* page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore):
(WebCore::FrameView::paintContents):
* page/FrameView.h:
(FrameView):
* rendering/RenderInline.cpp:
(WebCore):
* rendering/RenderInline.h:
(RenderInline):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):
(WebCore::RenderLayer::updateScrollbarsAfterLayout):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::setHasVerticalScrollbar):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange):
(WebCore):
* rendering/RenderObject.h:
(RenderObject):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
(WebCore):
* rendering/style/RenderStyle.h:
* rendering/style/StyleDashboardRegion.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:
(WebCore):
(StyleRareNonInheritedData):

Source/WebKit/chromium:

* features.gypi: Add ENABLE_WIDGET_REGION define.

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig: Add ENABLE_WIDGET_REGION define.

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig: Add ENABLE_WIDGET_REGION define.

LayoutTests:

Added a new test to test the new CSS property.

* fast/css/widget-region-parser-expected.txt: Added.
* fast/css/widget-region-parser.html: Added.
* platform/efl/Skipped: Skip the new test.
* platform/gtk/TestExpectations: Skip the new test.
* platform/qt/Skipped: Skip the new test.
* platform/win/Skipped: Skip the new test.
* platform/wincario/Skipped: Skip the new test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove apparent merge goof from JavaScriptCore/ChangeLog
fpizlo@apple.com [Thu, 2 Aug 2012 00:10:20 +0000 (00:10 +0000)]
Remove apparent merge goof from JavaScriptCore/ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSome of the test results for LayoutTests/accessibility/canvas-accessibilitynodeobject...
commit-queue@webkit.org [Wed, 1 Aug 2012 23:57:24 +0000 (23:57 +0000)]
Some of the test results for LayoutTests/accessibility/canvas-accessibilitynodeobject.html do not show up on Windows.
https://bugs.webkit.org/show_bug.cgi?id=92916

Patch by Roger Fong <roger_fong@apple.com> on 2012-08-01
Reviewed by Tim Horton.

Adding a failing test result and filing a bug.

* platform/win/accessibility/canvas-accessibilitynodeobject-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] TypedArray binding performance improvements
commit-queue@webkit.org [Wed, 1 Aug 2012 23:53:06 +0000 (23:53 +0000)]
[V8] TypedArray binding performance improvements
https://bugs.webkit.org/show_bug.cgi?id=92557

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-08-01
Reviewed by Kenneth Russell.

Improve TypedArray bindings performance:
- create arrays with createUninitialized when possible. Typed Array
construction is about 10% faster.
- when creating a typed array from a same typed array, memcpy data
from source to target.

In order to detect if argument array is the same type as
implementation array, we pass the javascript wrapper type as a new
type argument to template function constructWebGLArray.

Introduce wrapArrayBufferView which wraps typed array into a v8::Value

No new tests: Performance tests are already handled by
Bindings/typed-array-construct-from-same-type.html and
Bindings/typed-array-construct-from-typed.html

* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore):
(WebCore::constructWebGLArray):
* bindings/v8/custom/V8Float32ArrayCustom.cpp:
(WebCore::V8Float32Array::constructorCallback):
* bindings/v8/custom/V8Float64ArrayCustom.cpp:
(WebCore::V8Float64Array::constructorCallback):
* bindings/v8/custom/V8Int16ArrayCustom.cpp:
(WebCore::V8Int16Array::constructorCallback):
* bindings/v8/custom/V8Int32ArrayCustom.cpp:
(WebCore::V8Int32Array::constructorCallback):
* bindings/v8/custom/V8Int8ArrayCustom.cpp:
(WebCore::V8Int8Array::constructorCallback):
* bindings/v8/custom/V8Uint16ArrayCustom.cpp:
(WebCore::V8Uint16Array::constructorCallback):
* bindings/v8/custom/V8Uint32ArrayCustom.cpp:
(WebCore::V8Uint32Array::constructorCallback):
* bindings/v8/custom/V8Uint8ArrayCustom.cpp:
(WebCore::V8Uint8Array::constructorCallback):
* bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:
(WebCore::V8Uint8ClampedArray::constructorCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Fix lost context handling on hud layer
piman@chromium.org [Wed, 1 Aug 2012 23:48:45 +0000 (23:48 +0000)]
[chromium] Fix lost context handling on hud layer
https://bugs.webkit.org/show_bug.cgi?id=92915

Reviewed by Adrienne Walker.

On lost context we need to release CCScopedTextures, otherwise later on
we will try to re-allocate it using a stale CCResourceProvider.

Test CCLayerTreeHostImplTest.dontUseOldResourcesAfterLostContext
extended.

Source/WebCore:

* platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:
(WebCore::CCHeadsUpDisplayLayerImpl::didLoseContext):
* platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.h:

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium/mac] Delete WebImageCG.cpp
thakis@chromium.org [Wed, 1 Aug 2012 23:43:54 +0000 (23:43 +0000)]
[chromium/mac] Delete WebImageCG.cpp
https://bugs.webkit.org/show_bug.cgi?id=92910

Reviewed by James Robinson.

It's been unused since the switch to skia.
Also remove now-unneeded *CG.cpp exclusion rule.

* WebKit.gyp:
* src/WebImageCG.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: integer version layout tests
dgrogan@chromium.org [Wed, 1 Aug 2012 23:27:13 +0000 (23:27 +0000)]
IndexedDB: integer version layout tests
https://bugs.webkit.org/show_bug.cgi?id=92560

Reviewed by Nate Chapin.

Most of the integer version layout tests are here, with failures in
the expected files.  This will allow us to incrementally implement
upgradeneeded and integer versions and just make the big patch in bug
89505 smaller.

There are two added skips to TestExpectations, one test exposes a bug
in the current implementation, causing an assert to fail.  The other
times out in DRT so we will run it as a content_browsertest for the
time being.

* platform/chromium/TestExpectations:
* storage/indexeddb/intversion-abort-in-initial-upgradeneeded-expected.txt: Added.
* storage/indexeddb/intversion-abort-in-initial-upgradeneeded.html: Added.
* storage/indexeddb/intversion-and-setversion-expected.txt: Added.
* storage/indexeddb/intversion-and-setversion.html: Added.
* storage/indexeddb/intversion-blocked-expected.txt: Added.
* storage/indexeddb/intversion-blocked.html: Added.
* storage/indexeddb/intversion-close-between-events-expected.txt: Added.
* storage/indexeddb/intversion-close-between-events.html: Added.
* storage/indexeddb/intversion-close-in-oncomplete-expected.txt: Added.
* storage/indexeddb/intversion-close-in-oncomplete.html: Added.
* storage/indexeddb/intversion-close-in-upgradeneeded-expected.txt: Added.
* storage/indexeddb/intversion-close-in-upgradeneeded.html: Added.
* storage/indexeddb/intversion-delete-in-upgradeneeded-expected.txt: Added.
* storage/indexeddb/intversion-delete-in-upgradeneeded.html: Added.
* storage/indexeddb/intversion-gated-on-delete-expected.txt: Added.
* storage/indexeddb/intversion-gated-on-delete.html: Added.
* storage/indexeddb/intversion-invalid-setversion-has-no-side-effects-expected.txt: Added.
* storage/indexeddb/intversion-invalid-setversion-has-no-side-effects.html: Added.
* storage/indexeddb/intversion-long-queue-expected.txt: Added.
* storage/indexeddb/intversion-long-queue.html: Added.
* storage/indexeddb/intversion-omit-parameter-expected.txt: Added.
* storage/indexeddb/intversion-omit-parameter.html: Added.
* storage/indexeddb/intversion-open-with-version-expected.txt: Added.
* storage/indexeddb/intversion-open-with-version.html: Added.
and their respective js files...
* storage/indexeddb/resources/shared.js:
(unexpectedVersionChangeCallback):
(setDBNameFromPath):
(preamble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] IndexedDB: API stubs to simplify WebIDBCursor API
jsbell@chromium.org [Wed, 1 Aug 2012 23:15:49 +0000 (23:15 +0000)]
[Chromium] IndexedDB: API stubs to simplify WebIDBCursor API
https://bugs.webkit.org/show_bug.cgi?id=92414

Reviewed by Adam Barth.

Prep work to unblock Chromium changes so that http://webkit.org/b/92278 can land.
Adds no-op methods which will later be implemented; during the landing sequence,
Chromium will call both the new methods and the old ones. The end goal is that
the success callbacks for cursors will include the new key/primaryKey/value rather
than requiring the callee to call back into the cursor backend to fetch them.

* public/WebIDBCallbacks.h:
(WebIDBCallbacks):
(WebKit::WebIDBCallbacks::onSuccess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSet the svn:mime-type property on libWebKitSystemInterfaceMountainLion.a to indicate...
mitz@apple.com [Wed, 1 Aug 2012 23:12:50 +0000 (23:12 +0000)]
Set the svn:mime-type property on libWebKitSystemInterfaceMountainLion.a to indicate that it is a binary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse testRunner instead of layoutTestController in SVG tests
fmalita@chromium.org [Wed, 1 Aug 2012 23:05:16 +0000 (23:05 +0000)]
Use testRunner instead of layoutTestController in SVG tests
https://bugs.webkit.org/show_bug.cgi?id=92898

Reviewed by Dirk Schulze.

* svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg:
* svg/animations/animate-beginElementAt.svg:
* svg/animations/animate-calcMode-spline-crash-bad-array-length.xhtml:
* svg/animations/animate-linear-discrete-additive-b.svg:
* svg/animations/animate-linear-discrete-additive-c.svg:
* svg/animations/animate-linear-discrete-additive.svg:
* svg/animations/animate-list-crash.svg:
* svg/animations/animate-setcurrenttime.html:
* svg/animations/animate-update-crash.xhtml:
* svg/animations/animateColor-additive-2a.svg:
* svg/animations/animateColor-additive-2b.svg:
* svg/animations/animateColor-additive-2c.svg:
* svg/animations/animateColor-additive-2d.svg:
* svg/animations/animateMotion-additive-1.svg:
* svg/animations/animateMotion-additive-2a.svg:
* svg/animations/animateMotion-additive-2b.svg:
* svg/animations/animateMotion-additive-2c.svg:
* svg/animations/animateMotion-additive-2d.svg:
* svg/animations/animateTransform-accumulation.svg:
* svg/animations/animateTransform-by-scale-1.svg:
* svg/animations/animateTransform-by-scale.svg:
* svg/animations/animateTransform-from-by-from-to-comparision-expected.svg:
* svg/animations/animateTransform-from-by-from-to-comparision.svg:
* svg/animations/animateTransform-from-by-scale-additive-sum.svg:
* svg/animations/animateTransform-from-by-scale.svg:
* svg/animations/animateTransform-rotate-around-point.svg:
* svg/animations/animateTransform-skewX.svg:
* svg/animations/animateTransform-skewY.svg:
* svg/animations/animateTransform-translate.svg:
* svg/animations/dynamic-modify-attributename-crash.svg:
* svg/animations/keypoints-mismatch.svg:
* svg/animations/length-list-animation.svg:
* svg/animations/list-wrapper-assertion.svg:
* svg/animations/mozilla/animateMotion-by-1.svg:
* svg/animations/mozilla/animateMotion-from-to-1-expected.svg:
* svg/animations/mozilla/animateMotion-from-to-1.svg:
* svg/animations/mozilla/animateMotion-mpath-pathLength-1.svg:
* svg/animations/mozilla/animateMotion-mpath-targetChange-1.svg:
* svg/animations/mozilla/animateMotion-to-overridden-1.svg:
* svg/animations/multiple-animateTransform-additive-sum.svg:
* svg/animations/multiple-begin-animation-discrete.svg:
* svg/animations/multiple-begin-animation.svg:
* svg/animations/path-animation.svg:
* svg/animations/repeatDur-zero.xhtml:
* svg/animations/repeating-path-animation.svg:
* svg/animations/resources/SVGAnimationTestCase.js:
(runAnimationTest):
* svg/animations/smil-element-not-removed-crash.html:
* svg/animations/smil-element-target-crash-main.html:
* svg/animations/smil-leak-dynamically-added-element-instances.svg:
* svg/animations/smil-leak-element-instances-noBaseValRef.svg:
* svg/animations/smil-leak-element-instances.svg:
* svg/animations/smil-leak-elements.svg:
* svg/animations/svg-two-animate-elements-crash.svg:
* svg/animations/svglength-animation-retarget-crash.html:
* svg/animations/svglength-element-removed-crash.svg:
* svg/as-background-image/animated-svg-as-background.html:
* svg/as-background-image/svg-background-crash-on-refresh.html:
* svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size.html:
* svg/as-image/animated-svg-as-image-same-image.html:
* svg/as-image/animated-svg-as-image.html:
* svg/as-image/animated-svg-repaints-completely-in-hidpi.html:
* svg/as-image/drag-svg-as-image.html:
* svg/as-image/image-respects-deviceScaleFactor.html:
* svg/as-image/image-respects-pageScaleFactor-change.html:
* svg/as-image/svg-image-leak-cached-data.html:
* svg/as-image/svg-image-leak-loader.html:
* svg/as-image/svg-nested.html:
* svg/as-object/embedded-svg-immediate-offsetWidth-query.html:
* svg/as-object/embedded-svg-size-changes-no-layout-triggers.html:
* svg/as-object/embedded-svg-size-changes.html:
* svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1.html:
* svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2.html:
* svg/as-object/nested-embedded-svg-size-changes.html:
* svg/as-object/resources/embedded-svg-size-changes-no-layout-triggers.svg:
* svg/as-object/resources/nested-embedded-svg-size-changes-target-no-layout-triggers-1.html:
* svg/carto.net/frameless-svg-parse-error.html:
* svg/carto.net/window.svg:
* svg/css/crash-css-generated-content.xhtml:
* svg/css/cursor-image-replace.svg:
* svg/css/cursor-replace.svg:
* svg/css/getComputedStyle-basic.xhtml:
* svg/css/invalid-color-crash.svg:
* svg/css/multiple-cursors-crash.html:
* svg/css/script-tests/svg-attribute-length-parsing.js:
* svg/css/script-tests/svg-attribute-parser-mode.js:
* svg/css/style-change-crash.html:
* svg/css/svg-ellipse-render-crash.html:
* svg/custom/acid3-test-77.html:
* svg/custom/anchor-on-use.svg:
* svg/custom/animate-disallowed-mask-element.svg:
* svg/custom/animate-disallowed-use-element.svg:
* svg/custom/animate-path-discrete.svg:
* svg/custom/animate-path-morphing.svg:
* svg/custom/animate-target-id-changed.svg:
* svg/custom/animate-target-removed-from-document.svg:
* svg/custom/animate-use-crash.xhtml:
* svg/custom/assert-empty-layout-attributes.svg:
* svg/custom/bbox-of-g-in-symbol.svg:
* svg/custom/boundingBox.html:
* svg/custom/bug78700.svg:
* svg/custom/bug78807.svg:
* svg/custom/bug78838.html:
* svg/custom/bug79798.html:
* svg/custom/bug86119.html:
* svg/custom/bug86392.html:
* svg/custom/bug86781.html:
* svg/custom/click-internal-anchor-with-use-crash.xhtml:
* svg/custom/crash-inline-container-client.html:
* svg/custom/crash-text-in-textpath.svg:
* svg/custom/crash-textPath-attributes.html:
* svg/custom/delete-modified-text-in-defs-crash.svg:
* svg/custom/delete-text-crash.html:
* svg/custom/delete-text-innerText-crash.html:
* svg/custom/detached-outermost-svg-crash.html:
* svg/custom/disallowed-text-content-rendering.svg:
* svg/custom/display-table-caption-foreignObject.svg:
* svg/custom/display-table-caption-inherit-foreignObject.xhtml:
* svg/custom/display-table-caption-inherit-text.xhtml:
* svg/custom/display-table-caption-text.svg:
* svg/custom/element-instance-held-by-js-crash.svg:
* svg/custom/embedded-svg-allowed-in-dashboard.xml:
* svg/custom/empty-className-baseVal-crash.html:
* svg/custom/filter-on-svgimage.svg:
* svg/custom/font-face-move.svg:
* svg/custom/font-face-name-without-name-attr.svg:
* svg/custom/font-face-not-in-document.svg:
* svg/custom/font-platformDestroy-crash.svg:
* svg/custom/foreignObject-crash-on-hover.xml:
* svg/custom/foreignobject-crash-with-absolute-positioned-children.svg:
* svg/custom/frame-getSVGDocument.html:
* svg/custom/g-outside-svg.html:
* svg/custom/get-text-element-transform-crash.html:
* svg/custom/getBBox-empty-container.html:
* svg/custom/getBBox-js.svg:
* svg/custom/getBBox-path.svg:
* svg/custom/getBBox-perpendicular-path.svg:
* svg/custom/getscreenctm-in-mixed-content2.xhtml:
* svg/custom/gradient-attr-update.svg:
* svg/custom/gradient-stop-display-none-crash.svg:
* svg/custom/hit-test-path-stroke.svg:
* svg/custom/hit-test-path.svg:
* svg/custom/hit-test-unclosed-subpaths.svg:
* svg/custom/hit-test-with-br.xhtml:
* svg/custom/image-base-uri.svg:
* svg/custom/image-clipped-hit.svg:
* svg/custom/image-rescale-scroll.html:
* svg/custom/image-with-prefix-in-webarchive-expected.webarchive:
* svg/custom/image-with-prefix-in-webarchive.svg:
* svg/custom/insertItemBefore-from-non-list-origin.svg:
* svg/custom/intersection-list-clipping.svg:
* svg/custom/intersection-list-crash.svg:
* svg/custom/intersection-list-nested-svg.svg:
* svg/custom/intersection-list-null.svg:
* svg/custom/invalid-gradient-with-xlink.svg:
* svg/custom/invalid-paint-shape-mask.svg:
* svg/custom/js-late-clipPath-and-object-creation.svg:
* svg/custom/js-late-clipPath-creation.svg:
* svg/custom/js-late-gradient-and-object-creation.svg:
* svg/custom/js-late-gradient-creation.svg:
* svg/custom/js-late-marker-and-object-creation.svg:
* svg/custom/js-late-marker-creation.svg:
* svg/custom/js-late-mask-and-object-creation.svg:
* svg/custom/js-late-mask-creation.svg:
* svg/custom/js-late-pattern-and-object-creation.svg:
* svg/custom/js-late-pattern-creation.svg:
* svg/custom/js-svg-constructors.svg:
* svg/custom/js-update-container2.svg:
* svg/custom/js-update-image-and-display.svg:
* svg/custom/js-update-image-and-display2.svg:
* svg/custom/js-update-image-and-display3.svg:
* svg/custom/layout-loop.svg:
* svg/custom/linking-a-03-b-all.svg:
* svg/custom/linking-a-03-b-preserveAspectRatio.svg:
* svg/custom/linking-a-03-b-transform.svg:
* svg/custom/linking-a-03-b-viewBox-transform.svg:
* svg/custom/linking-a-03-b-viewBox.svg:
* svg/custom/linking-a-03-b-viewTarget.svg:
* svg/custom/linking-a-03-b-zoomAndPan.svg:
* svg/custom/linking-uri-01-b.svg:
* svg/custom/loadevents-capturing.svg:
* svg/custom/loadevents-externalresourcesrequired-displaynone.svg:
* svg/custom/loadevents-externalresourcesrequired.svg:
* svg/custom/loadevents-normal-displaynone.svg:
* svg/custom/loadevents-normal.svg:
* svg/custom/manually-parsed-embedded-svg-allowed-in-dashboard.html:
* svg/custom/manually-parsed-svg-allowed-in-dashboard.html:
* svg/custom/marker-getPropertyValue.svg:
* svg/custom/mask-changes.svg:
* svg/custom/mask-invalidation.svg:
* svg/custom/mouse-move-on-svg-container-standalone.svg:
* svg/custom/mouse-move-on-svg-container.xhtml:
* svg/custom/mouse-move-on-svg-root-standalone.svg:
* svg/custom/mouse-move-on-svg-root.xhtml:
* svg/custom/multiple-title-elements.svg:
* svg/custom/new-image-is-html-element.svg:
* svg/custom/path-getPresentationAttribute-crash.html:
* svg/custom/path-getTotalLength-on-big-segment-crash.svg:
* svg/custom/path-getTotalLength.svg:
* svg/custom/pending-resource-after-removal.xhtml:
* svg/custom/pending-resource-leak-2.svg:
* svg/custom/pending-resource-leak-3.svg:
* svg/custom/pending-resource-leak.svg:
* svg/custom/pointer-events-image-css-transform.svg:
* svg/custom/pointer-events-image.svg:
* svg/custom/pointer-events-invalid-fill.svg:
* svg/custom/pointer-events-on-rounded-rect.xhtml:
* svg/custom/pointer-events-on-svg-with-pointer.xhtml:
* svg/custom/pointer-events-on-svg-without-pointer.xhtml:
* svg/custom/pointer-events-text-css-transform.svg:
* svg/custom/pointer-events-text.svg:
* svg/custom/pointer-events-with-linecaps-and-miterlimits.xhtml:
* svg/custom/poly-points-attribute-changes.svg:
* svg/custom/polyline-hittest.svg:
* svg/custom/polyline-points-crash.html:
* svg/custom/prevent-default.svg:
* svg/custom/recursive-use.svg:
* svg/custom/recursive-use2.svg:
* svg/custom/repaint-moving-svg-and-div.xhtml:
* svg/custom/resource-client-removal.svg:
* svg/custom/resources/focus-event-handling-keyboard.js:
* svg/custom/resources/focus-event-handling.js:
* svg/custom/resources/link-target.html:
* svg/custom/resources/linkingCircle-f.svg:
* svg/custom/resources/svgsvgelement-ctm.js:
* svg/custom/resources/use-instanceRoot-event-bubbling.js:
(repaintTest):
* svg/custom/resources/use-instanceRoot-event-listeners.js:
(repaintTest):
* svg/custom/scroll-hit-test.xhtml:
* svg/custom/scroll-to-anchor-in-symbol.svg:
* svg/custom/scroll-to-svg-element-assertion.html:
* svg/custom/scrolling-embedded-svg-file-image-repaint-problem.html:
* svg/custom/stop-crash.svg:
* svg/custom/stroke-width-click.svg:
* svg/custom/svg-allowed-in-dashboard-object.html:
* svg/custom/svg-features.html:
* svg/custom/svg-fonts-in-html-linebreaks.html:
* svg/custom/svg-fonts-no-latin-glyph.html:
* svg/custom/svg-getelementid.xhtml:
* svg/custom/svg-parse-overflow-1.html:
* svg/custom/svg-parse-overflow-2.html:
* svg/custom/svg-parse-overflow-3.html:
* svg/custom/svg-parse-overflow-4.html:
* svg/custom/svg-parse-overflow-5.html:
* svg/custom/svg-use-style-float-crash.svg:
* svg/custom/svg-width-intrinsic-crash.html:
* svg/custom/symbol-viewport-element-crash.svg:
* svg/custom/text-node-in-text-invalidated.svg:
* svg/custom/text-tref-03-b-dynamic.svg:
* svg/custom/text-tref-03-b-dynamic2.svg:
* svg/custom/textPath-assert.svg:
* svg/custom/textPath-set-id.svg:
* svg/custom/tiling-regular-hexagonal-crash.svg:
* svg/custom/tref-clone-crash.html:
* svg/custom/tref-shadowdom.html:
* svg/custom/use-animation-in-fill.html:
* svg/custom/use-crash-in-non-wellformed-document.svg:
* svg/custom/use-crash-pending-resource.svg:
* svg/custom/use-crash-using-children-before-destroy.svg:
* svg/custom/use-crash-when-href-change.svg:
* svg/custom/use-detach.svg:
* svg/custom/use-display-none.svg:
* svg/custom/use-elementInstance-event-target.svg:
* svg/custom/use-elementInstance-methods.svg:
* svg/custom/use-event-handler-on-referenced-element.svg:
* svg/custom/use-event-handler-on-use-element.svg:
* svg/custom/use-external-crash.svg:
* svg/custom/use-instanceRoot-as-event-target.xhtml:
* svg/custom/use-instanceRoot-event-listener-liveness.xhtml:
* svg/custom/use-instanceRoot-with-use-removed.svg:
* svg/custom/use-invalid-font-face.svg:
* svg/custom/use-invalid-html.xhtml:
* svg/custom/use-invalid-pattern.svg:
* svg/custom/use-invalid-style.svg:
* svg/custom/use-move-to-offset.svg:
* svg/custom/use-multiple-on-nested-disallowed-font.html:
* svg/custom/use-mutation-event-crash.svg:
* svg/custom/use-nested-children.svg:
* svg/custom/use-nested-disallowed-target.svg:
* svg/custom/use-nested-missing-target-added.svg:
* svg/custom/use-nested-missing-target-removed.svg:
* svg/custom/use-nested-missing-target.svg:
* svg/custom/use-nested-notarget.svg:
* svg/custom/use-non-existing-symbol-crash.svg:
* svg/custom/use-on-use-with-child-and-empty-target.svg:
* svg/custom/use-on-use-with-child.svg:
* svg/custom/use-referencing-style-crash.svg:
* svg/custom/use-shadow-root-parent-removal.svg:
* svg/custom/use-tref-crash.svg:
* svg/custom/webkit-transform-crash.html:
* svg/custom/xlink-prefix-in-attributes.html:
* svg/custom/xlink-to-invalid-gradient.svg:
* svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml:
* svg/dom/SVGPolygonElement-baseVal-list-removal-crash.html:
* svg/dom/SVGScriptElement/script-async-attr.svg:
* svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg:
* svg/dom/SVGScriptElement/script-clone-rerun-self.svg:
* svg/dom/SVGScriptElement/script-clone-rerun.svg:
* svg/dom/SVGScriptElement/script-load-and-error-events.svg:
* svg/dom/SVGScriptElement/script-onerror-bubbling.svg:
* svg/dom/SVGScriptElement/script-reexecution.svg:
* svg/dom/SVGScriptElement/script-set-href.svg:
* svg/dom/SVGStyledElement-pendingResource-crash.html:
* svg/dom/SVGTransformList-empty-list-consolidation.html:
* svg/dom/animated-tearoff-equality.xhtml:
* svg/dom/animated-tearoff-lifespan.xhtml:
* svg/dom/baseVal-animVal-crash.html:
* svg/dom/baseVal-animVal-list-crash.html:
* svg/dom/frame-related-api-during-load.html:
* svg/dom/parent-view-layout-crash.html:
* svg/dom/path-marker-removed-crash.svg:
* svg/dom/resources/viewspec-parser.js:
(continueFuzzing.else.script.onload):
(continueFuzzing):
* svg/dom/script-tests/SVGViewSpec.js:
(completeTest.script.onload):
(completeTest):
* svg/dom/smil-methods.svg:
* svg/dom/stylesheet-candidate-node-crash-main.html:
* svg/dom/svg-element-attribute-js-null.xhtml:
* svg/dom/symbol-embeddedAnimation.svg:
* svg/dom/use-style-recalc-script-execute-crash.html:
* svg/dom/use-transform.svg:
* svg/dom/viewport-container-crash.svg:
* svg/dom/vkern-element-crash.html:
* svg/dynamic-updates/resources/SVGTestCase.js:
(createSVGTestCase):
(embedSVGTestCase):
(completeTest.script.onload):
(completeTest):
* svg/dynamic-updates/resources/linkTarget.svg:
* svg/filters/feBlend-invalid-mode.xhtml:
* svg/filters/feColorMatrix-invalid-value.svg:
* svg/filters/feComponentTransfer-style-crash.xhtml:
* svg/filters/feDisplacementMap-crash-test.xhtml:
* svg/filters/feImage-animated-transform-on-target-rect.svg:
* svg/filters/feImage-target-reappend-to-document.svg:
* svg/filters/feImage-zero-size-crash.svg:
* svg/filters/feMorphology-invalid-radius.svg:
* svg/filters/feMorphology-zero-radius.svg:
* svg/filters/filter-after-transform-crash.svg:
* svg/filters/reparent-animated-filter-target.html:
* svg/filters/svg-transform-blur-crash.svg:
* svg/foreignObject/absolute-position-foreign-object-child-crash.html:
* svg/foreignObject/fO-fixed-position-crash.html:
* svg/hittest/foreign-object-background.svg:
* svg/hittest/svg-ellipse-non-scale-stroke.xhtml:
* svg/hittest/svg-ellipse-rect-stroke.xhtml:
* svg/hittest/svg-ellipse.xhtml:
* svg/hittest/svg-inside-display-table.xhtml:
* svg/hittest/svg-inside-table.xhtml:
* svg/hittest/svg-padding.xhtml:
* svg/hittest/svg-shapes-non-scale-stroke.html:
* svg/hittest/svg-small-path.xhtml:
* svg/hittest/svg-small-viewbox.xhtml:
* svg/hittest/zero-length-butt-cap-path.xhtml:
* svg/hittest/zero-length-round-cap-path.xhtml:
* svg/hittest/zero-length-square-cap-path.xhtml:
* svg/hixie/dynamic/001.xml:
* svg/hixie/links/003.xml:
* svg/hixie/perf/001.xml:
* svg/hixie/perf/002.xml:
* svg/hixie/perf/003.xml:
* svg/hixie/perf/004.xml:
* svg/hixie/perf/005.xml:
* svg/hixie/perf/006.xml:
* svg/hixie/perf/007.xml:
* svg/in-html/script-external.html:
* svg/in-html/script-nested.html:
* svg/in-html/script-write.html:
* svg/in-html/script.html:
* svg/in-html/svg-assert-failure-percentage.html:
* svg/path-arc-invalid.html:
* svg/repaint/filter-repaint.svg:
* svg/repaint/image-href-change.svg:
* svg/repaint/image-with-clip-path.svg:
* svg/repaint/repainting-after-animation-element-removal.svg:
* svg/text/add-tspan-position-bug.html:
* svg/text/caret-in-svg-text.xhtml:
* svg/text/clear-floats-crash.svg:
* svg/text/font-size-null-assertion.svg:
* svg/text/font-size-too-large-crash.svg:
* svg/text/foreignObject-text-clipping-bug.xml:
* svg/text/glyphref-renderer-create-crash.html:
* svg/text/highcharts-assertion.html:
* svg/text/inline-text-destroy-attributes-crash.xhtml:
* svg/text/modify-tspan-position-bug.html:
* svg/text/resources/SelectionTestCase.js:
* svg/text/select-text-svgfont.html:
* svg/text/selection-doubleclick.svg:
* svg/text/selection-tripleclick.svg:
* svg/text/svg-rtl-text-crash.html:
* svg/text/svg-zoom-large-value.xhtml:
* svg/text/text-align-01-b.svg:
* svg/text/text-align-02-b.svg:
* svg/text/text-align-03-b.svg:
* svg/text/text-align-04-b.svg:
* svg/text/text-align-05-b.svg:
* svg/text/text-align-06-b.svg:
* svg/text/text-altglyph-01-b.svg:
* svg/text/text-assert.svg:
* svg/text/text-block-child-crash.xhtml:
* svg/text/text-deco-01-b.svg:
* svg/text/text-font-anonymous-parent.xhtml:
* svg/text/text-font-invalid.html:
* svg/text/text-font-uri-invalid.svg:
* svg/text/text-fonts-01-t.svg:
* svg/text/text-fonts-02-t.svg:
* svg/text/text-intro-05-t.svg:
* svg/text/text-path-01-b.svg:
* svg/text/text-positioning-remove-child-crash.svg:
* svg/text/text-property-with-display-none.html:
* svg/text/text-spacing-01-b.svg:
* svg/text/text-style-invalid.svg:
* svg/text/text-style-recalc-crash.html:
* svg/text/text-text-01-b.svg:
* svg/text/text-text-03-b.svg:
* svg/text/text-text-04-t.svg:
* svg/text/text-text-05-t.svg:
* svg/text/text-text-06-t.svg:
* svg/text/text-text-07-t.svg:
* svg/text/text-text-08-b.svg:
* svg/text/text-tref-01-b.svg:
* svg/text/text-tselect-01-b.svg:
* svg/text/text-tselect-02-f.svg:
* svg/text/text-tspan-01-b.svg:
* svg/text/text-ws-01-t.svg:
* svg/text/text-ws-02-t.svg:
* svg/text/textPathBoundsBug.svg:
* svg/text/textpath-reference-crash.html:
* svg/text/tref-event-listener-crash.svg:
* svg/text/tspan-getComputedTextLength.svg:
* svg/transforms/percent-transform-values.xhtml:
* svg/transforms/transform-origin-presentation-attribute.xhtml:
* svg/webarchive/svg-cursor-subresources-expected.webarchive:
* svg/webarchive/svg-cursor-subresources.svg:
* svg/webarchive/svg-feimage-subresources-expected.webarchive:
* svg/webarchive/svg-feimage-subresources.svg:
* svg/webarchive/svg-script-subresouces-expected.webarchive:
* svg/webarchive/svg-script-subresouces.svg:
* svg/zoom/page/zoom-getBoundingClientRect.xhtml:
* svg/zoom/page/zoom-zoom-coords.xhtml:
* svg/zoom/resources/testPageZoom.js:
(repaintTest):
(completeDynamicTest.script.onload):
(completeDynamicTest):
* svg/zoom/resources/testTextZoom.js:
(repaintTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRead tag names and attributes from the saved tokens in HTMLElementStack
kseo@webkit.org [Wed, 1 Aug 2012 22:56:46 +0000 (22:56 +0000)]
Read tag names and attributes from the saved tokens in HTMLElementStack
https://bugs.webkit.org/show_bug.cgi?id=92830

Reviewed by Adam Barth.

This is a follow-up patch for r123577.
Replaced top()->hasTagName(x) with topStackItem()->hasTagName(x).
Also replaced item->element()->hasTagName(x) with item->hasTagName(x).

No new tests, covered by existing tests.

* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLElementStack::pop):
(WebCore::HTMLElementStack::popUntil):
(WebCore::HTMLElementStack::pushHTMLHtmlElement):
(WebCore::HTMLElementStack::pushHTMLHeadElement):
(WebCore::HTMLElementStack::pushHTMLBodyElement):
(WebCore::HTMLElementStack::push):
(WebCore::HTMLElementStack::insertAbove):
(WebCore::HTMLElementStack::popCommon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agotest-webkitpy: clean up handling of tests to skip
dpranke@chromium.org [Wed, 1 Aug 2012 22:53:06 +0000 (22:53 +0000)]
test-webkitpy: clean up handling of tests to skip
https://bugs.webkit.org/show_bug.cgi?id=92909

Reviewed by Ryosuke Niwa.

This change moves the handling of tests to skip into main.py
where it is at least slightly more findable and generic.

Also fix a couple of lint nits.

* Scripts/webkitpy/test/finder.py:
(Finder.__init__):
(Finder.skip):
(Finder._default_names):
* Scripts/webkitpy/test/main.py:
(main):
(Tester.skip):
* Scripts/webkitpy/test/main_unittest.py:
(TesterTest.test_no_tests_found):
* Scripts/webkitpy/test/runner_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agotest-webkitpy: remove --skip-integrationtests flag
dpranke@chromium.org [Wed, 1 Aug 2012 22:52:05 +0000 (22:52 +0000)]
test-webkitpy: remove --skip-integrationtests flag
https://bugs.webkit.org/show_bug.cgi?id=92907

Reviewed by Ryosuke Niwa.

This flag is no longer used since the tests complete quickly.

Also clean up the unused skip_if_parallel arg in finder, and
make a couple of lint fixes.

* Scripts/webkitpy/test/finder.py:
(Finder.find_names):
(Finder._default_names):
* Scripts/webkitpy/test/finder_unittest.py:
(FinderTest.check_names):
(FinderTest.test_default_names):
* Scripts/webkitpy/test/main.py:
(Tester._parse_args):
(Tester.run):
* Scripts/webkitpy/test/main_unittest.py:
(TesterTest.test_no_tests_found):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] remove unused fields from LayerRendererCapabilities
piman@chromium.org [Wed, 1 Aug 2012 22:27:51 +0000 (22:27 +0000)]
[chromium] remove unused fields from LayerRendererCapabilities
https://bugs.webkit.org/show_bug.cgi?id=92906

Reviewed by James Robinson.

No new tests (just removing dead code).

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):
(LayerRendererCapabilities):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Move compositor HUD font atlas generation out of compositor core
jamesr@google.com [Wed, 1 Aug 2012 22:26:21 +0000 (22:26 +0000)]
[chromium] Move compositor HUD font atlas generation out of compositor core
https://bugs.webkit.org/show_bug.cgi?id=92901

Reviewed by Adrienne Walker.

This moves the font atlas generation out of CCFontAtlas into a separate helper class and ports the CCFontAtlas
text drawing code over to use skia directly.

* WebCore.gypi:
* platform/graphics/chromium/CompositorHUDFontAtlas.cpp: Added.
(WebCore):
(WebCore::wrapPositionIfNeeded):
(WebCore::CompositorHUDFontAtlas::generateFontAtlas):
* platform/graphics/chromium/CompositorHUDFontAtlas.h: Added.
(WebCore):
(CompositorHUDFontAtlas):
* platform/graphics/chromium/cc/CCFontAtlas.cpp:
(WebCore::CCFontAtlas::CCFontAtlas):
(WebCore::CCFontAtlas::~CCFontAtlas):
(WebCore::CCFontAtlas::initialize):
(WebCore::CCFontAtlas::drawText):
(WebCore::CCFontAtlas::drawOneLineOfTextInternal):
(WebCore::CCFontAtlas::drawDebugAtlas):
* platform/graphics/chromium/cc/CCFontAtlas.h:
(WebCore):
(CCFontAtlas):
* platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Race condition between first layout and viewport attributes initialization
commit-queue@webkit.org [Wed, 1 Aug 2012 22:21:00 +0000 (22:21 +0000)]
[Qt][WK2] Race condition between first layout and viewport attributes initialization
https://bugs.webkit.org/show_bug.cgi?id=92902

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-08-01
Reviewed by Noam Rosenthal.

Initializing m_rawAttributes from QtViewportHandler to avoid calculation of random
scale factors on the first layout is triggered.

* UIProcess/qt/QtViewportHandler.cpp:
(WebKit::QtViewportHandler::QtViewportHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGeneralize SheriffIRCBot to prepare for PerfBot
rniwa@webkit.org [Wed, 1 Aug 2012 22:16:08 +0000 (22:16 +0000)]
Generalize SheriffIRCBot to prepare for PerfBot
https://bugs.webkit.org/show_bug.cgi?id=92912

Reviewed by Adam Barth.

Renamed SheriffIRCBot to IRCBot and generalized to support non-sheriffbot IRC bot in the future.
This will be useful when I add an experimental perf EWS IRC bot.

* Scripts/webkitpy/tool/bot/irc_command.py:
(Whois.execute):
* Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest):
* Scripts/webkitpy/tool/bot/ircbot.py: Moved from Tools/Scripts/webkitpy/tool/bot/sheriffircbot.py.
(Eliza): Moved from irc_command.
(Eliza.__init__):
(Eliza.execute):
(IRCBot):
(IRCBot.__init__):
(IRCBot.irc_delegate):
(IRCBot._parse_command_and_args):
(IRCBot.process_message):
* Scripts/webkitpy/tool/bot/ircbot_unittest.py: Moved from Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py.
(run):
(IRCBotTest):
(IRCBotTest.test_eliza): Moved from IRCCommandTest.
(IRCBotTest.test_parse_command_and_args):
(IRCBotTest.test_exception_during_command):
* Scripts/webkitpy/tool/bot/sheriffircbot.py: Removed.
* Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Removed.
* Scripts/webkitpy/tool/commands/sheriffbot.py:
(SheriffBot.begin_work_queue):
* Scripts/webkitpy/webkitpy.pyproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Text Autosizing] Provide an API for influencing the font scale factor
peter@chromium.org [Wed, 1 Aug 2012 22:12:23 +0000 (22:12 +0000)]
[Text Autosizing] Provide an API for influencing the font scale factor
https://bugs.webkit.org/show_bug.cgi?id=92882

Reviewed by Adam Barth.

Source/WebCore:

Add the font scale factor to settings, and provide an API in
window.internal.settings to change it from layout tests.

The font scale factor applied to Text Autosizing influences the sizing
of text, and will influence the scaling of boosted blocks once the
implementation progresses. For Android, it will be set to the font size
chosen in the user's system-wide preferences.

Test: fast/text-autosizing/font-scale-factor.html

* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore):
(WebCore::Settings::setTextAutosizingFontScaleFactor):
* page/Settings.h:
(Settings):
(WebCore::Settings::textAutosizingFontScaleFactor):
* rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::processBlock):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setTextAutosizingFontScaleFactor):
(WebCore):
* testing/InternalSettings.h:
(Backup):
(InternalSettings):
* testing/InternalSettings.idl:

Source/WebKit/chromium:

Add an API to change Text Autosizing's font scale factor.

The font scale factor applied to Text Autosizing influences the sizing
of text, and will influence the scaling of boosted blocks once the
implementation progresses. For Android, it will be set to the font size
chosen in the user's system-wide preferences.

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setTextAutosizingFontScaleFactor):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):

LayoutTests:

Add a basic test. More usable tests should be added later, as it's
really hard to test this accurately in this phase of the implementation,
and Text Autosizing is still subject to various bugs.

The font scale factor applied to Text Autosizing influences the sizing
of text, and will influence the scaling of boosted blocks once the
implementation progresses. For Android, it will be set to the font size
chosen in the user's system-wide preferences.

* fast/text-autosizing/font-scale-factor-expected.html: Added.
* fast/text-autosizing/font-scale-factor.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSP should correctly block plugin resources rendered in PluginDocuments.
commit-queue@webkit.org [Wed, 1 Aug 2012 21:34:13 +0000 (21:34 +0000)]
CSP should correctly block plugin resources rendered in PluginDocuments.
https://bugs.webkit.org/show_bug.cgi?id=92675

Patch by Mike West <mkwst@chromium.org> on 2012-08-01
Reviewed by Adam Barth.

Source/WebCore:

In certain cases, plugins aren't loaded directly, but are stuffed into a
newly-created PluginDocument before rendering. While we were already
correctly populating information that allowed us to make decisions about
that document's security origin, and already dealing with sandbox
status by creating a 'SinkDocument' that ignored plugin data, we weren't
correctly inheriting the parent frame's Content Security Policy. This
patch ensures that PluginDocuments correctly inherit their parent's
Content Security Policy, meaning that the plugin is blocked or allowed
according to the policy of the protected resource in which the
PluginDocument is embedded.

Tests: http/tests/security/contentSecurityPolicy/object-src-url-allowed.html
       http/tests/security/contentSecurityPolicy/object-src-url-blocked.html

* dom/Document.cpp:
(WebCore::Document::initContentSecurityPolicy):
    Populate a created PluginDocument with its frame's parent's Content
    Security Policy.

LayoutTests:

* http/tests/plugins/resources/mock-plugin.pl: Added.
    This lovely perl script mocks a plugin by sending a
    'Content-Type application/x-webkit-test-netscape' header.
* http/tests/security/contentSecurityPolicy/object-src-url-allowed-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/object-src-url-allowed.html: Added.
* http/tests/security/contentSecurityPolicy/object-src-url-blocked-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/object-src-url-blocked.html: Added.
    Test that non-'data:' URLs that end up in PluginDocuments are also
    dealt with correctly by CSP.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: reenable the test for --verbose working in child processes
dpranke@chromium.org [Wed, 1 Aug 2012 21:27:00 +0000 (21:27 +0000)]
nrwt: reenable the test for --verbose working in child processes
https://bugs.webkit.org/show_bug.cgi?id=92894

Reviewed by Ryosuke Niwa.

This change rewrites the test to not use outputcapture, meaning
that the MockHost can propagate to Worker properly and things
work again :).

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_verbose_in_child_processes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSVG animation not working for elements inserted after parsing is finished
fmalita@chromium.org [Wed, 1 Aug 2012 21:24:28 +0000 (21:24 +0000)]
SVG animation not working for elements inserted after parsing is finished
https://bugs.webkit.org/show_bug.cgi?id=92025

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Time containers for SVG elements inserted after document parsing is finished need to be
initialized on insertion (since they've missed the Document::implicitClose() initialization
point).

Test: svg/animations/deferred-insertion.html

* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::insertedInto):

LayoutTests:

* svg/animations/deferred-insertion-expected.txt: Added.
* svg/animations/deferred-insertion.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBlock pointer lock for sandboxed iframes.
scheib@chromium.org [Wed, 1 Aug 2012 21:21:55 +0000 (21:21 +0000)]
Block pointer lock for sandboxed iframes.
https://bugs.webkit.org/show_bug.cgi?id=92796

Reviewed by Adam Barth.

Source/WebCore:

Sandboxed iframe documents should be blocked from using the
pointer lock API until there is specification agreement
on what attribute to use to allow the feature. After
specification this restriction can be relaxed, but not
restricting it now would require breaking applications
later.

Test: http/tests/pointer-lock/iframe-sandboxed.html

* dom/SecurityContext.h:
* page/PointerLockController.cpp:
(WebCore::PointerLockController::requestPointerLock):

LayoutTests:

Sandboxed iframe documents should be blocked from using the
pointer lock API until there is specification agreement
on what attribute to use to allow the feature.

* http/tests/pointer-lock/iframe-sandboxed-expected.txt: Added.
* http/tests/pointer-lock/iframe-sandboxed.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium TestExpectations change, replace BUG_eae with a proper bug number.
eae@chromium.org [Wed, 1 Aug 2012 21:19:18 +0000 (21:19 +0000)]
Unreviewed chromium TestExpectations change, replace BUG_eae with a proper bug number.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agorun-perf-tests --build-directory doesn't work
rniwa@webkit.org [Wed, 1 Aug 2012 21:02:56 +0000 (21:02 +0000)]
run-perf-tests --build-directory doesn't work
https://bugs.webkit.org/show_bug.cgi?id=92051

Reviewed by Dirk Pranke.

The bug was caused by not prepending build_directory even when one is defined.
Fixed that.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port._build_path):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_build_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace WTF::getCurrentLocalTime() with GregorianDateTime::setToCurrentLocalTime()
paroga@webkit.org [Wed, 1 Aug 2012 20:49:26 +0000 (20:49 +0000)]
Replace WTF::getCurrentLocalTime() with GregorianDateTime::setToCurrentLocalTime()
https://bugs.webkit.org/show_bug.cgi?id=92286

Reviewed by Geoffrey Garen.

Add a method to GregorianDateTime to set its values to the current locale time.
Replacing all occurrences of getCurrentLocalTime with the new function allows
us to remove getCurrentLocalTime in a next step.

Source/JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Source/WebCore:

* html/FTPDirectoryDocument.cpp:
(WebCore::processFileDateString):
* loader/archive/mhtml/MHTMLArchive.cpp:
(WebCore::MHTMLArchive::generateMHTMLData):

Source/WTF:

* GNUmakefile.list.am:
* WTF.gypi:
* WTF.pro:
* WTF.vcproj/WTF.vcproj:
* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/DateMath.cpp:
(WTF::dayInYear):
* wtf/DateMath.h:
(WTF):
* wtf/GregorianDateTime.cpp: Added.
(WTF):
(WTF::GregorianDateTime::setToCurrentLocalTime):
* wtf/GregorianDateTime.h:
(GregorianDateTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove code duplication in determining if display is inline or replaced
ojan@chromium.org [Wed, 1 Aug 2012 20:47:09 +0000 (20:47 +0000)]
Remove code duplication in determining if display is inline or replaced
https://bugs.webkit.org/show_bug.cgi?id=92880

Reviewed by Julien Chaffraix.

Deduplicate lists of display types by using private helpers.

No new tests. No change in behavior.

* rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate WKSI.
jonlee@apple.com [Wed, 1 Aug 2012 20:35:58 +0000 (20:35 +0000)]
Update WKSI.

Reviewed by Mark Rowe.

* libWebKitSystemInterfaceLion.a:
* libWebKitSystemInterfaceMountainLion.a:
* libWebKitSystemInterfaceSnowLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream API: Add ExtraData capability to MediaStreamSource
tommyw@google.com [Wed, 1 Aug 2012 20:33:39 +0000 (20:33 +0000)]
MediaStream API: Add ExtraData capability to MediaStreamSource
https://bugs.webkit.org/show_bug.cgi?id=92860

Reviewed by Adam Barth.

The Chromium port needs to store some related data in MediaStreamSource objects.

Source/Platform:

* chromium/public/WebMediaStreamSource.h:
(ExtraData):
(WebKit::WebMediaStreamSource::ExtraData::~ExtraData):
(WebMediaStreamSource):

Source/WebCore:

Not testable from a LayoutTest.

* platform/chromium/support/WebMediaStreamSource.cpp:
(ExtraDataContainer):
(WebKit::ExtraDataContainer::ExtraDataContainer):
(WebKit::ExtraDataContainer::extraData):
(WebKit):
(WebKit::WebMediaStreamSource::extraData):
(WebKit::WebMediaStreamSource::setExtraData):
* platform/mediastream/MediaStreamSource.h:
(ExtraData):
(WebCore::MediaStreamSource::ExtraData::~ExtraData):
(MediaStreamSource):
(WebCore::MediaStreamSource::extraData):
(WebCore::MediaStreamSource::setExtraData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: IDBCursor.continue(key) does not throw for key "behind" cursor
jsbell@chromium.org [Wed, 1 Aug 2012 20:20:53 +0000 (20:20 +0000)]
IndexedDB: IDBCursor.continue(key) does not throw for key "behind" cursor
https://bugs.webkit.org/show_bug.cgi?id=92562

Reviewed by Ojan Vafai.

Source/WebCore:

Per spec, IDBCursor.continue(key) should throw for forward cursors
if key <= current key, and for reverse cursors if key >= current key.
Code was present on the back end but the error code was ignored, possibly
broken in a recent refactor, and there were no tests for this case.

Test: storage/indexeddb/cursor-continue-dir.html

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::advance): Handle async transaction termination.
(WebCore::IDBCursor::continueFunction): Move checks here from backend.
* Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): Don't need direction param.
(WebCore::IDBCursorBackendImpl::continueFunction): Remove checks.
* Modules/indexeddb/IDBCursorBackendImpl.h: Only IDBBackingStore::cursor needs direction now.
(WebCore::IDBCursorBackendImpl::create):
(IDBCursorBackendImpl):
* Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::openCursorInternal): Drop unused param.
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal): Ditto.

LayoutTests:

Ensure cursor.continue(key) throws if key is "behind" the cursor.

* storage/indexeddb/cursor-continue-dir-expected.txt: Added.
* storage/indexeddb/cursor-continue-dir.html: Added.
* storage/indexeddb/resources/cursor-continue-dir.js: Added.
(test.request.onsuccess.request.onsuccess.request.onsuccess):
(test.request.onsuccess.request.onsuccess):
(test.request.onsuccess):
(test):
(testCursors):
(testForwardCursor.request.onsuccess):
(testForwardCursor):
(testReverseCursor.request.onsuccess):
(testReverseCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAssertion failure in inspector/profiler/heap-snapshot-containment-show-all.html on...
antti@apple.com [Wed, 1 Aug 2012 20:14:01 +0000 (20:14 +0000)]
Assertion failure in inspector/profiler/heap-snapshot-containment-show-all.html on Lion bot
https://bugs.webkit.org/show_bug.cgi?id=92888

Reviewed by Andreas Kling.

Protect the WebInspectorWindowController so it doesn't get destroyed during [WebView close] and cause
unsafe [WebView dealloc].

* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController destroyInspectorView:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Don't request a clickCount of 1 on mouseMove event generated by tap...
commit-queue@webkit.org [Wed, 1 Aug 2012 20:10:18 +0000 (20:10 +0000)]
Source/WebCore: Don't request a clickCount of 1 on mouseMove event generated by tap gestures
https://bugs.webkit.org/show_bug.cgi?id=92779

Patch by Rick Byers <rbyers@chromium.org> on 2012-08-01
Reviewed by Adam Barth.

mousemove events don't have a click count, so we shouldn't be passing 1
here.  Note this makes no real difference in practice since the value is
ignored - fixed strictly for pedantics.

Test: fast/events/touch/gesture/gesture-click

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureTap):

LayoutTests: Make Gesture click test validate click count in UIEvent.detail
https://bugs.webkit.org/show_bug.cgi?id=92779

Patch by Rick Byers <rbyers@chromium.org> on 2012-08-01
Reviewed by Adam Barth.

Also validates that no dblclick event is fired for this single click.
* fast/events/touch/gesture/gesture-click.html:
* platform/chromium/fast/events/touch/gesture/gesture-click-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDropping webkit prefix from Vibration API
commit-queue@webkit.org [Wed, 1 Aug 2012 19:51:04 +0000 (19:51 +0000)]
Dropping webkit prefix from Vibration API
https://bugs.webkit.org/show_bug.cgi?id=92840

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-08-01
Reviewed by Adam Barth.

Source/WebCore:

Remove webkit prefix from navigator.webkitVibrate().
- Vibration API have been entered CR already.
- Firefox already implements Vibration API.

No new tests. Covered by fast/dom/navigator-vibration.html

* Modules/vibration/NavigatorVibration.cpp:
(WebCore::NavigatorVibration::vibrate):
* Modules/vibration/NavigatorVibration.h:
(NavigatorVibration):
* Modules/vibration/NavigatorVibration.idl:

LayoutTests:

Remove webkit prefix from navigator.webkitVibrate().

* fast/dom/navigator-vibration-expected.txt:
* fast/dom/navigator-vibration.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRead tag names and attributes from the saved tokens in HTMLFormattingElementList...
commit-queue@webkit.org [Wed, 1 Aug 2012 19:42:04 +0000 (19:42 +0000)]
Read tag names and attributes from the saved tokens in HTMLFormattingElementList::closestElementInScopeWithName(const AtomicString&)
https://bugs.webkit.org/show_bug.cgi?id=92841

Patch by Kwang Yul Seo <skyul@company100.net> on 2012-08-01
Reviewed by Adam Barth.

This is a follow-up patch for r123577.
Replaced entry.element()->hasLocalName(targetName) with entry.stackItem()->hasLocalName(targetName).

No new tests, covered by existing tests.

* html/parser/HTMLFormattingElementList.cpp:
(WebCore::HTMLFormattingElementList::closestElementInScopeWithName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix FastMalloc build with assertions enabled.
paroga@webkit.org [Wed, 1 Aug 2012 19:41:27 +0000 (19:41 +0000)]
Fix FastMalloc build with assertions enabled.

* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::isScavengerSuspended):
(WTF::TCMalloc_PageHeap::scheduleScavenger):
(WTF::TCMalloc_PageHeap::suspendScavenger):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoC++ code should get ClassInfo from the Structure
mhahnenberg@apple.com [Wed, 1 Aug 2012 19:24:58 +0000 (19:24 +0000)]
C++ code should get ClassInfo from the Structure
https://bugs.webkit.org/show_bug.cgi?id=92892

Reviewed by Geoffrey Garen.

In our march to remove ClassInfo from our JSCell object headers, we can switch
C++ code over to grabbing the ClassInfo from the Structure since it is finally
safe to do so now that Structure access is safe during finalization/destruction.
The remaining JIT code changes can be done in a separate patch.

* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::callDestructor): We don't want to clear the Structure any more
since the Structure should still be valid at this point.
* heap/WeakSetInlines.h:
(JSC::WeakBlock::finalize): Ditto.
* runtime/JSCell.h:
(JSC):
* runtime/Structure.h:
(JSC::JSCell::classInfo): Move JSCell's classInfo() to Structure.h so it can be
inline. Use a different method of getting the JSCell's Structure based on
whether we're in GC_VALIDATION mode or not, since always using get() will cause
infinite recursion in GC_VALIDATION mode.
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r123865.
commit-queue@webkit.org [Wed, 1 Aug 2012 19:05:55 +0000 (19:05 +0000)]
Unreviewed, rolling out r123865.
http://trac.webkit.org/changeset/123865
https://bugs.webkit.org/show_bug.cgi?id=92891

This patch is causing the style-queue to fall behind
(Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-01

* Scripts/webkitpy/tool/commands/queues.py:
(AbstractReviewQueue.begin_work_queue):
(StyleQueue.__init__):
* Scripts/webkitpy/tool/commands/queues_unittest.py:
(StyleQueueTest.test_style_queue_with_style_exception):
(test_style_queue_with_watch_list_exception):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHTMLTreeBuilder passes a wrong token when pushing the head element
commit-queue@webkit.org [Wed, 1 Aug 2012 19:03:14 +0000 (19:03 +0000)]
HTMLTreeBuilder passes a wrong token when pushing the head element
https://bugs.webkit.org/show_bug.cgi?id=92838

Patch by Kwang Yul Seo <skyul@company100.net> on 2012-08-01
Reviewed by Adam Barth.

When the tree builder pushes the head element in the "after head" insertion mode,
it creates a HTMLStackItem from a wrong token.

Added HTMLConstructionSite::headStackItem() to retrieve the stack item for the head
element. Modified the tree builder to pass the correct stack item when pushing the head
element in the "after head" insertion mode.

No new tests, covered by existing tests.

* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLHeadElement):
* html/parser/HTMLConstructionSite.h:
(WebCore::HTMLConstructionSite::head):
(WebCore::HTMLConstructionSite::headStackItem):
(HTMLConstructionSite):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMarkedBlock::sweep() should sweep another block if it can't sweep a Structure block
mhahnenberg@apple.com [Wed, 1 Aug 2012 18:55:03 +0000 (18:55 +0000)]
MarkedBlock::sweep() should sweep another block if it can't sweep a Structure block
https://bugs.webkit.org/show_bug.cgi?id=92819

Reviewed by Geoffrey Garen.

If we are forced to allocate a new block for Structures because we are unable to safely
sweep our pre-existing Structure blocks, we should sweep another random block so that we
can start sweeping Structure blocks sooner.

* heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::doSweep): Change to use sweepNextBlock.
(JSC):
(JSC::IncrementalSweeper::sweepNextBlock):
* heap/IncrementalSweeper.h:
(IncrementalSweeper):
* heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::tryAllocateHelper): When we can't safely sweep
our Structure blocks, call sweepNextBlock instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClean-up touchadjustment tests.
allan.jensen@nokia.com [Wed, 1 Aug 2012 18:45:12 +0000 (18:45 +0000)]
Clean-up touchadjustment tests.
https://bugs.webkit.org/show_bug.cgi?id=92869

Reviewed by Jocelyn Turcotte.

Review and cleanup the touchadjustment tests, so they are more consistent,
uses best practices and are good examples for future touchadjustment tests.

Gather commonly used functions in touchadjustment.js.
Add HTML5 doctype to ensure strict parsing rules.
Remove redundant testRunner calls, and use js-test-post.js instead.
Fix XHTMLisms in small-target-test.html
Fix ignored offset mistake in nested-touch.html that resulted in three identical tests.

* touchadjustment/big-div-expected.txt:
* touchadjustment/big-div.html:
* touchadjustment/block-testing-expected.txt:
* touchadjustment/block-testing.html:
* touchadjustment/disabled-formelements-expected.txt:
* touchadjustment/disabled-formelements.html:
* touchadjustment/event-triggered-widgets-expected.txt:
* touchadjustment/event-triggered-widgets.html:
* touchadjustment/html-label-expected.txt:
* touchadjustment/html-label.html:
* touchadjustment/iframe.html:
* touchadjustment/nested-shadow-node.html:
* touchadjustment/nested-touch-expected.txt:
* touchadjustment/nested-touch.html:
* touchadjustment/resources/inner-frame.html:
* touchadjustment/resources/touchadjustment.js: Added.
(findAbsoluteBounds):
(nodeToString):
(touchPoint):
(offsetTouchPoint):
* touchadjustment/rotated-node-expected.txt:
* touchadjustment/rotated-node.html:
* touchadjustment/scroll-offset-expected.txt:
* touchadjustment/scroll-offset.html:
* touchadjustment/search-cancel.html:
* touchadjustment/small-target-test-expected.txt:
* touchadjustment/small-target-test.html:
* touchadjustment/touch-inlines-expected.txt:
* touchadjustment/touch-inlines.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] The regionLayoutUpdate event should be dispatched on the NamedFlow...
commit-queue@webkit.org [Wed, 1 Aug 2012 18:42:27 +0000 (18:42 +0000)]
[CSS Regions] The regionLayoutUpdate event should be dispatched on the NamedFlow object
https://bugs.webkit.org/show_bug.cgi?id=88778

Patch by Andrei Bucur <abucur@adobe.com> on 2012-08-01
Reviewed by Adam Barth.

Spec: http://www.w3.org/TR/css3-regions/#region-flow-layout-events

Source/WebCore:

This patch implements the regionLayoutUpdate event per May 3rd CSS Regions spec recommendation.
Before this patch the event was dispatched individually on each region whenever its overflow state changed. The trigger conditions are preserved with the following additions:
- the event is dispatched when the last region is removed
- the event is not dispatched when the named flow switches to the NULL state
Also, the NamedFlow objects are not deleted if they switch to the NULL state and have listeners attached. In that scenario the JS wrapper will not release the reference
until the parent Document is destroyed.

Tests: The old tests have been modified to use the event on the NamedFlow object rather the one on the Region. New tests have been added to verify the
correct behavior in the special states of the NamedFlow (no region chain, NULL state).

* dom/Document.cpp:
(WebCore::Document::addListenerTypeIfNeeded): Listeners are not added on Nodes any more so the regionLayoutUpdate type was removed from the list.
* dom/Document.h:
* dom/EventTarget.h:
(WebCore):
* dom/EventTargetFactory.in:
* dom/Node.cpp:
* dom/Node.h:
(Node):
* dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::eventTargetData):
(WebCore):
(WebCore::WebKitNamedFlow::ensureEventTargetData):
(WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent): The 3rd May WD says the event is bubbling. However this doesn't make sense as this object doesn't belong to the DOM tree. This was fixed in the ED.
(WebCore::WebKitNamedFlow::interfaceName):
(WebCore::WebKitNamedFlow::scriptExecutionContext):
(WebCore::WebKitNamedFlow::base): Getter for the owner Document used by the wrapper to determine if the object is reachable.
* dom/WebKitNamedFlow.h:
(WebCore):
(WebKitNamedFlow):
(WebCore::WebKitNamedFlow::refEventTarget):
(WebCore::WebKitNamedFlow::derefEventTarget):
* dom/WebKitNamedFlow.idl:
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout): The event dispatching is now handled by the implementation of RenderFlowThread.
(WebCore::RenderFlowThread::computeOverflowStateForRegions):
* rendering/RenderFlowThread.h:
* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::removeRegionFromThread): The layout doesn't detect changes caused by removing the last region. This case is handled separately.
(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):
(WebCore):
(WebCore::RenderNamedFlowThread::regionLayoutUpdateEventTimerFired):
* rendering/RenderNamedFlowThread.h:
(RenderNamedFlowThread):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
* rendering/RenderRegion.h:
(RenderRegion):

LayoutTests:

The existing tests have been adapted to match the transition of the event on the NamedFlow interface. Also there are three more tests for the case
the region chain is removed, the flow goes in the NULL state and for the event target to match the NamedFlow object.

* fast/regions/webkit-named-flow-event-add-to-flow-expected.txt: Renamed from LayoutTests/fast/regions/region-event-add-to-flow-expected.txt.
* fast/regions/webkit-named-flow-event-add-to-flow.html: Renamed from LayoutTests/fast/regions/region-event-add-to-flow.html.
* fast/regions/webkit-named-flow-event-expected.txt: Renamed from LayoutTests/fast/regions/region-event-expected.txt.
* fast/regions/webkit-named-flow-event-no-regions-expected.txt: Added.
* fast/regions/webkit-named-flow-event-no-regions.html: Added.
* fast/regions/webkit-named-flow-event-remove-from-dom-expected.txt: Renamed from LayoutTests/fast/regions/region-event-remove-from-dom-expected.txt.
* fast/regions/webkit-named-flow-event-remove-from-dom.html: Renamed from LayoutTests/fast/regions/region-event-remove-from-dom.html.
* fast/regions/webkit-named-flow-event-remove-from-flow-expected.txt: Renamed from LayoutTests/fast/regions/region-event-remove-from-flow-expected.txt.
* fast/regions/webkit-named-flow-event-remove-from-flow.html: Renamed from LayoutTests/fast/regions/region-event-remove-from-flow.html.
* fast/regions/webkit-named-flow-event-target-expected.txt: Added.
* fast/regions/webkit-named-flow-event-target.html: Added.
* fast/regions/webkit-named-flow-event-to-null-expected.txt: Added.
* fast/regions/webkit-named-flow-event-to-null.html: Added.
* fast/regions/webkit-named-flow-event.html: Renamed from LayoutTests/fast/regions/region-event.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agorun-perf-tests throws an exception when the output json is malformed
rniwa@webkit.org [Wed, 1 Aug 2012 18:23:25 +0000 (18:23 +0000)]
run-perf-tests throws an exception when the output json is malformed
https://bugs.webkit.org/show_bug.cgi?id=92887

Reviewed by Dirk Pranke.

Catch exceptions and gracefully fail. Also split _generate_json into smaller methods.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner):
(PerfTestsRunner.run):
(PerfTestsRunner._generate_output): Extracted from _generate_json.
(PerfTestsRunner._merge_source_json): Ditto; catch all exceptions since they are too many
exceptions to consder here.
(PerfTestsRunner._merge_outputs): Ditto.
(PerfTestsRunner._generate_output_files): Extracted from _generate_json.
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(_test_run_with_json_output): Don't assert logs when we except an non-zero exit code.
(create_runner_and_setup_results_template): Extracted from test_run_generates_results_page.
(test_run_generates_results_page):
(test_run_with_bad_output_json): Added.
(test_run_with_bad_json_source): Added.
(test_run_with_upload_json):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRoll chromium DEPS to 149416.
dpranke@chromium.org [Wed, 1 Aug 2012 18:17:42 +0000 (18:17 +0000)]
Roll chromium DEPS to 149416.

Unreviewed.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSS 2.1 failure: margin-collapse-012 fails
robert@webkit.org [Wed, 1 Aug 2012 18:16:58 +0000 (18:16 +0000)]
CSS 2.1 failure: margin-collapse-012 fails
https://bugs.webkit.org/show_bug.cgi?id=80219

Reviewed by Eric Seidel.

Source/WebCore:

Tests: css2.1/20110323/margin-collapse-012.htm
       fast/css/margin-collapse-abspos-negmargin.htm

I also ran this against the full margin-collapse-* CSS 2.1 suite without regressions.

Per http://www.w3.org/TR/CSS21/box.html#collapsing-margins don't collapse the margins of
positioned blocks. Instead, just use the margin of the sibling/container to offset the
positioned block's logical top - its own margin gets added in later at
RenderBox::computePositionedLogicalHeightUsing().

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustPositionedBlock):

LayoutTests:

* css2.1/20110323/margin-collapse-012.htm: Added.
* css2.1/20110323/margin-collapse-012-expected.html: Added.
* fast/css/margin-collapse-abspos-negmargin-expected.html: Added.
* fast/css/margin-collapse-abspos-negmargin.htm: Added.

* fast/block/positioning/auto/001.html:
* fast/block/positioning/auto/002.html:
* fast/block/positioning/auto/vertical-lr/002.html:
* fast/block/positioning/auto/vertical-rl/002.html:
* fast/dynamic/staticY.html:
  Remove the margins from these tests so the results remain the same. The new results
  are consistent with FF.

* platform/chromium-linux/fast/box-sizing/box-sizing-expected.png:
* platform/chromium-win/compositing/overflow/clip-descendents-expected.txt:
* platform/chromium-win/fast/box-sizing/box-sizing-expected.txt:
  I've rebaselined these - removing the margins doesn't seem helpful.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRegression(r124135): nrwt: --verbose logging does not work right on windows
commit-queue@webkit.org [Wed, 1 Aug 2012 17:49:56 +0000 (17:49 +0000)]
Regression(r124135): nrwt: --verbose logging does not work right on windows
https://bugs.webkit.org/show_bug.cgi?id=92845

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-01
Reviewed by Dirk Pranke.

Disabled the failing test. The Workers spawned by this test are using Host()
instead of MockHost() and trying to access the real filesystem instead of the
MockFilesytem.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.disabled_test_verbose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agokeyring.get_password may raise an exception.
commit-queue@webkit.org [Wed, 1 Aug 2012 17:48:08 +0000 (17:48 +0000)]
keyring.get_password may raise an exception.
https://bugs.webkit.org/show_bug.cgi?id=92876

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-08-01
Reviewed by Dirk Pranke.

keyring.get_password sometimes raises an exception. We wrap this call,
and also set_password to avoid breaking webkit-patch in that case.

* Scripts/webkitpy/common/net/credentials.py:
(Credentials._offer_to_store_credentials_in_keyring):
(Credentials.read_credentials):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r124334.
commit-queue@webkit.org [Wed, 1 Aug 2012 17:43:13 +0000 (17:43 +0000)]
Unreviewed, rolling out r124334.
http://trac.webkit.org/changeset/124334
https://bugs.webkit.org/show_bug.cgi?id=92879

Broke MemoryInstrumentationTest.sizeOf from webkit_unit_tests
on Chromium canaries (Requested by apavlov1 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-01

Source/WebCore:

* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::collectBindingMemoryInfo):
* dom/MemoryInstrumentation.h:
(WebCore::MemoryInstrumentation::addInstrumentedObject):
(MemoryInstrumentation):
(WebCore::MemoryInstrumentation::addInstrumentedObjectImpl):
* inspector/InspectorMemoryAgent.cpp:
(WebCore):
* inspector/MemoryInstrumentationImpl.h:
(MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::totalTypeSize):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/MemoryInstrumentationTest.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix gcc 4.7 compile warnings.
commit-queue@webkit.org [Wed, 1 Aug 2012 17:37:16 +0000 (17:37 +0000)]
Fix gcc 4.7 compile warnings.
https://bugs.webkit.org/show_bug.cgi?id=92797

Patch by Han Shen <shenhan@google.com> on 2012-08-01
Reviewed by Kentaro Hara.

GCC 4.7 gives (more strict) warnings on uninitialized variables,
fixed by providing initilization values.

Tested by gcc 4.7 building. No change in behavior.

* platform/graphics/filters/arm/NEONHelpers.h:
(WebCore::loadRGBA8AsFloat): Add initilizaton value for local variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayout Test fast/text/descent-clip-in-scaled-page.html is failing on linux since...
wangxianzhu@chromium.org [Wed, 1 Aug 2012 16:54:53 +0000 (16:54 +0000)]
Layout Test fast/text/descent-clip-in-scaled-page.html is failing on linux since it was added
https://bugs.webkit.org/show_bug.cgi?id=91386

Reviewed by Tony Chang.

Tools:

Added font mapping from SubpixelPositioningAhem to Ahem on Linux and Android
(used in layout test fast/text/descent-clip-in-scaled-page.html).
Added font mapping from SubpixelPositioning to Times New Roman on Android to match Linux
(used in platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning.html)

* DumpRenderTree/chromium/android_main_fonts.xml:
* DumpRenderTree/chromium/fonts.conf:

LayoutTests:

The failure was because of the caching of font data. Now use the fake font families which are
only used when subpixel text positioing is enabled. This is the same method used in
platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning.html.

On Linux and Android, the fake font families will be mapped to Time New Roman and Ahem, respectively.
On other platforms, they will fall back to system default fonts.

* fast/text/descent-clip-in-scaled-page-expected.html:
* fast/text/descent-clip-in-scaled-page.html:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r122498): Assertion failure: m_nodeListCounts is sometimes not zero in...
rniwa@webkit.org [Wed, 1 Aug 2012 16:40:15 +0000 (16:40 +0000)]
REGRESSION(r122498): Assertion failure: m_nodeListCounts is sometimes not zero in the Document destructor
https://bugs.webkit.org/show_bug.cgi?id=92742

Reviewed by Andreas Kling.

Source/WebCore:

The bug was caused by adoptTreeScope's not always calling unregisterNodeListCache and registerNodeListCache
on node lists that use m_atomicNameCaches and m_nameCaches.

Tests: fast/dom/NodeList/nodelist-moved-to-fragment-2.html
       fast/dom/NodeList/nodelist-moved-to-fragment.html

* dom/NodeRareData.h:
(WebCore::NodeListsNodeData::adoptTreeScope):

LayoutTests:

Add regression tests for two types of node lists: one that uses addCacheWithName and the other that uses
addCacheWithAtomicName.

* fast/dom/NodeList/nodelist-moved-to-fragment-2-expected.txt: Added.
* fast/dom/NodeList/nodelist-moved-to-fragment-2.html: Added.
* fast/dom/NodeList/nodelist-moved-to-fragment-expected.txt: Added.
* fast/dom/NodeList/nodelist-moved-to-fragment.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Allow client side to add and remove origin access whitelist entries
zhajiang@rim.com [Wed, 1 Aug 2012 16:15:05 +0000 (16:15 +0000)]
[BlackBerry] Allow client side to add and remove origin access whitelist entries
https://bugs.webkit.org/show_bug.cgi?id=92790

Reviewed by Yong Li.

PR: 172658
Add two new APIs to add and remove origin access whitelist entries.
Initialize the BlackBerryAllowCrossSiteRequests WebSetting to false.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::addOriginAccessWhitelistEntry):
(WebKit):
(BlackBerry::WebKit::WebPage::addOriginAccessWhitelistEntry):
(BlackBerry::WebKit::WebPagePrivate::removeOriginAccessWhitelistEntry):
(BlackBerry::WebKit::WebPage::removeOriginAccessWhitelistEntry):
* Api/WebPage.h:
* Api/WebPage_p.h:
(WebPagePrivate):
* Api/WebSettings.cpp:
(BlackBerry::WebKit::WebSettings::standardSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Consolidate suppression of keyboard requests.
mifenton@rim.com [Wed, 1 Aug 2012 15:57:44 +0000 (15:57 +0000)]
[BlackBerry] Consolidate suppression of keyboard requests.
https://bugs.webkit.org/show_bug.cgi?id=92871

Reviewed by Antonio Gomes.

Reduce VKB requests even more by applying the filter on
all requests during processing.

Reviewed Internally by Gen Mak.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::focusedNodeChanged):
(BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt]REGRESSION(r123786): It made 3 fast/animation tests fail.
zeno.albisser@nokia.com [Wed, 1 Aug 2012 15:45:28 +0000 (15:45 +0000)]
[Qt]REGRESSION(r123786): It made 3 fast/animation tests fail.
https://bugs.webkit.org/show_bug.cgi?id=92490

Source/WebKit/qt:

QAbstractAnimation:start() is implicitly calling updateTime
without going through the event loop. This resulted in executing
scripted animation callbacks right when registering a first callback.

Reviewed by Noam Rosenthal.

* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::RefreshAnimation::scheduleAnimation):
    Invoke QAbstractAnimation::start() method through the event loop.

Source/WebKit2:

Make sure that scripted animations are also serviced when
forceRepaint is being executed. As this is what is being used for
running layout tests.
Move servicing of scripted animations and layoutIfNeeded call
into a separate function syncDisplayState.
This function can then be called from forceRepaint as well as from
performScheduledLayerFlush.

Reviewed by Noam Rosenthal.

* WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::forceRepaint):
(WebKit::LayerTreeCoordinator::performScheduledLayerFlush):
(WebKit):
(WebKit::LayerTreeCoordinator::syncDisplayState):
* WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.h:
(LayerTreeCoordinator):

LayoutTests:

Reviewed by Noam Rosenthal.

* platform/qt/Skipped: Unskipping the tests listed below.
    fast/animation/request-animation-frame-cancel2.html
    fast/animation/request-animation-frame-detach-element.html
    fast/animation/request-animation-frame-during-modal.html
    fast/animation/request-animation-frame-timestamps.html
    fast/dom/Window/post-message-crash.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Crashes in NetworkResourcesData.
vsevik@chromium.org [Wed, 1 Aug 2012 14:58:09 +0000 (14:58 +0000)]
Web Inspector: Crashes in NetworkResourcesData.
https://bugs.webkit.org/show_bug.cgi?id=92874

Reviewed by Yury Semikhatsky.

* inspector/NetworkResourcesData.cpp:
(WebCore::contentSizeInBytes):
(WebCore):
(WebCore::NetworkResourcesData::ResourceData::removeContent):
(WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::maybeDecodeDataToContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: test native memory instrumentation code with help of unittests
loislo@chromium.org [Wed, 1 Aug 2012 14:38:01 +0000 (14:38 +0000)]
Web Inspector: test native memory instrumentation code with help of unittests
https://bugs.webkit.org/show_bug.cgi?id=92743

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test a part of existing Native Memory Instrumentation code with help of unit tests.
6 tests were added and two bugs were fixed.
a drive-by improvement: the method MemoryInstrumentation::addInstrumentedObject
was marked as private and addRootObject was introduced instead of it.
The new function also calls processDeferedPointers.

* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::collectBindingMemoryInfo):
* dom/MemoryInstrumentation.h:
(WebCore::MemoryInstrumentation::addRootObject):
(MemoryInstrumentation):
(WebCore::MemoryInstrumentation::addInstrumentedObject):
(WebCore::MemoryInstrumentation::addInstrumentedObjectImpl):
(WebCore):
(WebCore::MemoryInstrumentation::addObjectImpl):
* inspector/InspectorMemoryAgent.cpp:
(WebCore):
* inspector/MemoryInstrumentationImpl.h:
(MemoryInstrumentationImpl):

Source/WebKit/chromium:

Test a part of existing Native Memory Instrumentation code with help of unit tests.
6 tests were added and two bugs were fixed.

* WebKit.gypi:
* tests/MemoryInstrumentationTest.cpp: Added.
(WebCore):
(MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::reportedSize):
(WebCore::MemoryInstrumentationImpl::countObjectSize):
(WebCore::MemoryInstrumentationImpl::processDeferredInstrumentedPointers):
(NotInstrumented):
(Instrumented):
(WebCore::Instrumented::Instrumented):
(WebCore::Instrumented::~Instrumented):
(WebCore::Instrumented::reportMemoryUsage):
(WebCore::TEST):
(InstrumentedWithOwnPtr):
(WebCore::InstrumentedWithOwnPtr::InstrumentedWithOwnPtr):
(WebCore::InstrumentedWithOwnPtr::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Memory leak found while running webaudio tests
commit-queue@webkit.org [Wed, 1 Aug 2012 14:33:32 +0000 (14:33 +0000)]
[GTK] Memory leak found while running webaudio tests
https://bugs.webkit.org/show_bug.cgi?id=92861

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-01
Reviewed by Philippe Normand.

Fix a memory leak in decodeAudioForBusCreation by adopting
an allocation of GInputStream.

No new tests. No change in behavior.

* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::decodeAudioForBusCreation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: count DOM storage cache memory for native snapshot
commit-queue@webkit.org [Wed, 1 Aug 2012 13:55:07 +0000 (13:55 +0000)]
Web Inspector: count DOM storage cache memory for native snapshot
https://bugs.webkit.org/show_bug.cgi?id=91617

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-08-01
Reviewed by Yury Semikhatsky.

Source/Platform:

Add memory size used for DOM storage cache reporting interface.

* chromium/public/WebStorageArea.h:
(WebStorageArea):
(WebKit::WebStorageArea::memoryBytesUsedByCache):

Source/WebCore:

Add memory size used for DOM storage cache reporting interface.
Report it to the native memory snapshot instrumentation framework.

* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::memoryBytesUsedByStorageCache):
(WebCore):
* inspector/InspectorDOMStorageAgent.h:
(InspectorDOMStorageAgent):
* inspector/InspectorMemoryAgent.cpp:
(MemoryBlockName):
(WebCore):
(WebCore::dumpDOMStorageCache):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
* inspector/InspectorMemoryAgent.h:
(WebCore):
(WebCore::InspectorMemoryAgent::create):
(InspectorMemoryAgent):
* inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.MemoryBlockViewProperties._initialize):
* storage/StorageArea.h:
(StorageArea):
* storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::memoryBytesUsedByCache):
(WebCore):
* storage/StorageAreaImpl.h:
(StorageAreaImpl):

Source/WebKit/chromium:

Add memory size used for DOM storage cache reporting interface.

* src/StorageAreaProxy.cpp:
(WebCore::StorageAreaProxy::memoryBytesUsedByCache):
(WebCore):
* src/StorageAreaProxy.h:
(StorageAreaProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Disable tap highlight when transparent color is specified
commit-queue@webkit.org [Wed, 1 Aug 2012 13:39:45 +0000 (13:39 +0000)]
[BlackBerry] Disable tap highlight when transparent color is specified
https://bugs.webkit.org/show_bug.cgi?id=92849

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-08-01
Reviewed by Antonio Gomes.

When the web page specifies -webkit-tap-highlight-color:rgba(0,0,0,0)
or any color with alpha value 0, we should disable the tap highlight.

* WebKitSupport/DefaultTapHighlight.cpp:
(BlackBerry::WebKit::DefaultTapHighlight::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124331 268f45cc-cd09-0410-ab3c-d52691b4dbfc