WebKit-https.git
7 years agoYet another Windows build fix attempt. Try exporting more symbols.
rniwa@webkit.org [Wed, 2 Jan 2013 20:49:53 +0000 (20:49 +0000)]
Yet another Windows build fix attempt. Try exporting more symbols.

* win/WebKit2.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoView source mode is missing the processing instruction line.
esprehn@chromium.org [Wed, 2 Jan 2013 20:48:33 +0000 (20:48 +0000)]
View source mode is missing the processing instruction line.
https://bugs.webkit.org/show_bug.cgi?id=15961

Reviewed by Adam Barth.

Add a test for XML documents shown in viewsource mode. The bug
with the missing processing instruction line was fixed long
ago with the HTML5 parser rewrite so this just adds a test.

* fast/frames/viewsource-xml-expected.txt: Added.
* fast/frames/viewsource-xml.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother Windows port build fix attempt. Try not exporting this symbol from JSC
rniwa@webkit.org [Wed, 2 Jan 2013 20:40:42 +0000 (20:40 +0000)]
Another Windows port build fix attempt. Try not exporting this symbol from JSC
since it's also compiled in WebCore.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r138464): Safari hangs when opening Privacy preferences
ap@apple.com [Wed, 2 Jan 2013 20:39:24 +0000 (20:39 +0000)]
REGRESSION (r138464): Safari hangs when opening Privacy preferences
https://bugs.webkit.org/show_bug.cgi?id=105933

Reviewed by Sam Weinig.

Quick and dirty fix - added a special case for main thread. But I'm not sure if
dispatch_sync on main queue is really the best idiom here.

* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::getPluginInfoFromCarbonResources):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove old-run-webkit-tests support from webkitpy
abarth@webkit.org [Wed, 2 Jan 2013 20:37:53 +0000 (20:37 +0000)]
Remove old-run-webkit-tests support from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=105619

Reviewed by Eric Seidel.

This patch removes support for webkitpy parsing the
old-run-webkit-tests results format. There doesn't seem to be any
reason to keep this code around anymore now that most bots have
switched to new-run-webkit-tests.

* Scripts/webkitpy/common/net/buildbot/buildbot.py:
(Builder.fetch_layout_test_results):
* Scripts/webkitpy/common/net/layouttestresults.py:
(path_for_layout_test):
(LayoutTestResults.results_from_string):
(LayoutTestResults):
* Scripts/webkitpy/common/net/layouttestresults_unittest.py:
(LayoutTestResultsTest.test_results_from_string):
* Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
(test_flaky_test_failure):
* Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
(LayoutTestResultsReaderTest.test_missing_layout_test_results):
* Scripts/webkitpy/tool/bot/patchanalysistask.py:
(PatchAnalysisTask._test_patch):
* Scripts/webkitpy/tool/commands/queuestest.py:
(QueuesTest.assert_queue_outputs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r138627.
rniwa@webkit.org [Wed, 2 Jan 2013 20:33:18 +0000 (20:33 +0000)]
Unreviewed, rolling out r138627.
http://trac.webkit.org/changeset/138627
https://bugs.webkit.org/show_bug.cgi?id=105935

This patch doesn't fix Windows port build failure (Requested
by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-02

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTransitions and animations do not apply to CSS ::before and ::after pseudo-elements
esprehn@chromium.org [Wed, 2 Jan 2013 20:31:44 +0000 (20:31 +0000)]
Transitions and animations do not apply to CSS ::before and ::after pseudo-elements
https://bugs.webkit.org/show_bug.cgi?id=92591

Reviewed by Eric Seidel.

.:

Expose Element::pseudoElement for Internals.

* Source/autotools/symbols.filter:

Source/WebCore:

The new DOM based :before and :after pseudo elements support animations
and transitions already, but I had disabled support so we could turn them
on in a separate step. This patch just removes the checks and adds tests.

This also adds two methods to internals to allow pausing animations and
transitions on pseudo elements at predictable locations so the tests
are not flaky.

Tests: fast/css-generated-content/pseudo-animation.html
       fast/css-generated-content/pseudo-transition.html

* WebCore.exp.in:
* page/animation/AnimationController.cpp:
(WebCore::AnimationController::updateAnimations):
* testing/Internals.cpp:
(WebCore::Internals::pauseAnimationAtTimeOnPseudoElement):
(WebCore::Internals::pauseTransitionAtTimeOnPseudoElement):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

LayoutTests:

Add tests that check if animations and transitions play for pseudo
:before and :after pseudo elements.

* fast/css-generated-content/pseudo-animation-expected.txt: Added.
* fast/css-generated-content/pseudo-animation.html: Added.
* fast/css-generated-content/pseudo-transition-expected.txt: Added.
* fast/css-generated-content/pseudo-transition.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement WebIDL-style string constants in WebAudio
crogers@google.com [Wed, 2 Jan 2013 20:27:40 +0000 (20:27 +0000)]
Implement WebIDL-style string constants in WebAudio
https://bugs.webkit.org/show_bug.cgi?id=105058

Reviewed by Kentaro Hara.

Source/WebCore:

See Deprecation Notes for more detail:
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#DeprecationNotes

PannerNode, BiquadFilterNode, OscillatorNode constants must support WebIDL-style string constants.
Legacy support in the setters for the old integer values should be supported.

This patch handles the changes for OscillatorNode.

* GNUmakefile.list.am:
* Modules/webaudio/OscillatorNode.cpp:
(WebCore::OscillatorNode::OscillatorNode):
(WebCore::OscillatorNode::type):
(WebCore):
(WebCore::OscillatorNode::setType):
* Modules/webaudio/OscillatorNode.h:
* Modules/webaudio/OscillatorNode.idl:
* Target.pri:
* UseJSC.cmake:
* UseV8.cmake:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSOscillatorNodeCustom.cpp: Copied from Source/WebCore/Modules/webaudio/OscillatorNode.idl.
(WebCore):
(WebCore::JSOscillatorNode::setType):
* bindings/v8/custom/V8OscillatorNodeCustom.cpp: Copied from Source/WebCore/Modules/webaudio/OscillatorNode.idl.
(WebCore):
(WebCore::V8OscillatorNode::typeAccessorSetter):

LayoutTests:

* webaudio/oscillator-basic-expected.txt:
* webaudio/oscillator-basic.html:
* webaudio/resources/audio-testing.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRegression (r132935): WebKit breaks between <nobr> tags
robert@webkit.org [Wed, 2 Jan 2013 20:18:15 +0000 (20:18 +0000)]
Regression (r132935): WebKit breaks between <nobr> tags
https://bugs.webkit.org/show_bug.cgi?id=11857

Reviewed by David Hyatt.

Source/WebCore:

The fix for bug 29648 in http://trac.webkit.org/changeset/132935 was too broad - it caused us
to find linebreaks in autowrap containers between non-wrapping elements where there was no
whitespace to allow the break. This reverts the code change in r132935 and ensures we attempt
to move below floats when inside an autowrap container but leaves the treatment of non-wrapping
elements in an autowrap container unaffected.

Test: fast/inline/break-between-nobr.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

* fast/inline/break-between-nobr-expected.html: Added.
* fast/inline/break-between-nobr.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Use top level field for gesture event source
rjkroege@chromium.org [Wed, 2 Jan 2013 20:16:57 +0000 (20:16 +0000)]
[chromium] Use top level field for gesture event source
https://bugs.webkit.org/show_bug.cgi?id=105664

Reviewed by Adam Barth.

Previously, only GestureFlingStart subtypes of WebGestureEvent
had a deviceSource flag. A previous CL added a top-level
deviceSource field for all WebGestureEvent. Now that this field
is populated in Chromium, use it as necessary in the Chromium
WebKit layer.

No new tests: covered by existing tests.

* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
* tests/WebCompositorInputHandlerImplTest.cpp:
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWTF.gypi lists Platform.h twice
abarth@webkit.org [Wed, 2 Jan 2013 20:00:47 +0000 (20:00 +0000)]
WTF.gypi lists Platform.h twice
https://bugs.webkit.org/show_bug.cgi?id=105731

Reviewed by Tony Chang.

Once ought to be enough for everybody.

* WTF.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother Windows port build fix attempt. Don't try to build WTF files in WebCore.
rniwa@webkit.org [Wed, 2 Jan 2013 19:48:28 +0000 (19:48 +0000)]
Another Windows port build fix attempt. Don't try to build WTF files in WebCore.

Rubber-stamped by Sam Weinig.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't include a header that has been removed in r138413.
rniwa@webkit.org [Wed, 2 Jan 2013 19:28:37 +0000 (19:28 +0000)]
Don't include a header that has been removed in r138413.

* WebProcess/win/WebProcessWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agosandboxed iframe attribute parsing layout tests are flaky
mkwst@chromium.org [Wed, 2 Jan 2013 19:27:53 +0000 (19:27 +0000)]
sandboxed iframe attribute parsing layout tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=104848

Reviewed by Adam Barth.

This patch breaks the monolithic sandboxed-iframe-attribute-parsing.html
test into separate tests for each case. The flaky failures were due to
one of the 14 frames loading out of order, which shifted console message
positions around. Breaking them into separate tests should both speed up
the tests, as more can run in parallel, and solve the flake.

* fast/frames/resources/sandboxed-iframe-attribute-test.js: Added.
(fail):
(setStatus):
(allowedCallFromSandbox):
(disallowedCallFromSandbox):
(disallowedFormSubmitted):
(window.onload):
* fast/frames/sandboxed-iframe-attribute-parsing-01-expected.txt: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-01.html: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-02-expected.txt: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-02.html: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-03-expected.txt: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-03.html: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-04-expected.txt: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-04.html: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-05-expected.txt: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-05.html: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-06-expected.txt: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-06.html: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-07-expected.txt: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-07.html: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-08-expected.txt: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-08.html: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-09-expected.txt: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-09.html: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-10-expected.txt: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-10.html: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-11-expected.txt: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-11.html: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-12-expected.txt: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-12.html: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-13-expected.txt: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-13.html: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-14-expected.txt: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-14.html: Added.
* fast/frames/sandboxed-iframe-attribute-parsing-expected.txt: Removed.
* fast/frames/sandboxed-iframe-attribute-parsing.html: Removed.
* platform/chromium/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt-arm/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSandboxed iframes should not be granted notification permission of the parent frame...
mkwst@chromium.org [Wed, 2 Jan 2013 19:15:46 +0000 (19:15 +0000)]
Sandboxed iframes should not be granted notification permission of the parent frame unless allow-same-origin is specified
https://bugs.webkit.org/show_bug.cgi?id=36732

Reviewed by Adam Barth.

The behavior was fixed in wkbug.com/79704, but there aren't currently
any tests ensuring that it doesn't regress for sandboxed frames. This
patch adds one.

* fast/notifications/notifications-sandbox-permission-expected.txt: Added.
* fast/notifications/notifications-sandbox-permission.html: Added.
* fast/notifications/resources/notifications-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate Mac test expectation per bug 105932.
rniwa@webkit.org [Wed, 2 Jan 2013 19:10:30 +0000 (19:10 +0000)]
Update Mac test expectation per bug 105932.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Rename SetFrameInViewSourceMode to SetMainFrameInViewSourceMode
carlosgc@webkit.org [Wed, 2 Jan 2013 17:42:10 +0000 (17:42 +0000)]
[WK2] Rename SetFrameInViewSourceMode to SetMainFrameInViewSourceMode
https://bugs.webkit.org/show_bug.cgi?id=105885

Reviewed by Martin Robinson.

This way we don't depend on a WebFrameProxy and
webkit_web_view_set_view_mode() works even if the main frame proxy
hasn't been created yet.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_set_view_mode): Call
WebPageProxy::setMainFrameInViewSourceMode() directly.
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::WebFrameProxy): Remove
setInViewSourceMode().
* UIProcess/WebFrameProxy.h:
(WebFrameProxy):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setMainFrameInViewSourceMode):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setMainFrameInViewSourceMode):
* WebProcess/WebPage/WebPage.h:
(WebPage):
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Use WebPageGroup to create user scripts instead of Qt-specific function in WebPage
caio.oliveira@openbossa.org [Wed, 2 Jan 2013 17:10:24 +0000 (17:10 +0000)]
[Qt] Use WebPageGroup to create user scripts instead of Qt-specific function in WebPage
https://bugs.webkit.org/show_bug.cgi?id=105921

Reviewed by Simon Hausmann.

After r131281 the WebPageGroup.h (in UIProcess) exposes a way to add user scripts, so we can
use this directly to implement the user script functionality in Qt. The previous solution was
a Qt-port specific function in WebPage that can be removed now.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::updateUserScripts): Use WebPageGroup functions to manipulate user scripts directly.
* UIProcess/WebPageProxy.h:
(WebPageProxy): Remove now unused function.
* UIProcess/qt/WebPageProxyQt.cpp: Ditto.
* WebProcess/WebPage/WebPage.messages.in: Ditto.
* WebProcess/WebPage/qt/WebPageQt.cpp: Remove now unused function and headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] [WebGL] Minor cleanup in PlatformContext.
commit-queue@webkit.org [Wed, 2 Jan 2013 16:46:30 +0000 (16:46 +0000)]
[EFL] [WebGL] Minor cleanup in PlatformContext.
https://bugs.webkit.org/show_bug.cgi?id=105872

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-01-02
Reviewed by Kenneth Rohde Christiansen.

The logic to check for supported extensions is scattered in different classes i.e PlatformContext, eglcontext etc.
This patch cleans up any duplicate code and adds new api in GLPlatformContext to query for supported GL, EGL and GLX extensions.

* PlatformEfl.cmake:
* platform/graphics/opengl/GLPlatformContext.cpp:
(WebCore):
(WebCore::GLPlatformContext::createContext):
(WebCore::GLPlatformContext::supportsGLExtension):
(WebCore::GLPlatformContext::supportsEGLExtension):
(WebCore::GLPlatformContext::supportsGLXExtension):
(WebCore::GLPlatformContext::makeCurrent):
(WebCore::GLPlatformContext::initializeResetStatusExtension):
* platform/graphics/opengl/GLPlatformContext.h:
* platform/graphics/surfaces/egl/EGLContext.cpp:
(WebCore::isRobustnessExtSupported):
(WebCore::EGLOffScreenContext::initialize):
* platform/graphics/surfaces/glx/GLXContext.cpp:
(WebCore::initializeARBExtensions):
(WebCore::GLXOffScreenContext::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Use fatfingers result when checking for misspelled words
nghanavatian@rim.com [Wed, 2 Jan 2013 16:42:47 +0000 (16:42 +0000)]
[BlackBerry] Use fatfingers result when checking for misspelled words
https://bugs.webkit.org/show_bug.cgi?id=105923

Reviewed by Yong Li.

PR270866
Currently we are using the raw touch point when checking to see if spell check
is required on a word. When tapping close to a boundary, the raw point can be
placed off but fatfingers moves the point onto the word. This causes the caret
to be placed on a word but no spell check request triggered.

Internally reviewed by Mike Fenton and Tiancheng Jiang

* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebKit2: [Qt][WK2] Add experimental API to find text from page
commit-queue@webkit.org [Wed, 2 Jan 2013 15:05:35 +0000 (15:05 +0000)]
Source/WebKit2: [Qt][WK2] Add experimental API to find text from page
https://bugs.webkit.org/show_bug.cgi?id=96481

Patch by Heikki Paajanen <heikki.paajanen@palm.com> on 2013-01-02
Reviewed by Jocelyn Turcotte.

Expose findString and PageFindClient provided functionality to QtQuick
applications.

* Target.pri:
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
(QQuickWebViewExperimental::findText):
(QQuickWebViewPrivate::didFindString):
* UIProcess/API/qt/qquickwebview_p.h:
(WebKit):
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/API/qt/tests/qmltests/WebView/tst_findText.qml: Added.
* UIProcess/qt/QtWebPageFindClient.cpp: Added.
(WebKit):
(WebKit::QtWebPageFindClient::QtWebPageFindClient):
(WebKit::QtWebPageFindClient::didFindString):
(WebKit::toQtWebPageFindClient):
(WebKit::QtWebPageFindClient::didFailToFindString):
* UIProcess/qt/QtWebPageFindClient.h: Added.
(WebKit):
(QtWebPageFindClient):

Tools: [Qt][WK2] Add simple UI to find text from page
https://bugs.webkit.org/show_bug.cgi?id=96481

Patch by Heikki Paajanen <heikki.paajanen@palm.com> on 2013-01-02
Reviewed by Jocelyn Turcotte.

Find bar that slides between navigation bar and WebView.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::toggleFind):
* MiniBrowser/qt/BrowserWindow.h:
(BrowserWindow):
* MiniBrowser/qt/MiniBrowser.qrc:
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify):
* MiniBrowser/qt/icons/find.png: Added.
* MiniBrowser/qt/qml/BrowserWindow.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRegression(r138603): Caused 2 webkitpy tests to fail
christophe.dumez@intel.com [Wed, 2 Jan 2013 14:16:18 +0000 (14:16 +0000)]
Regression(r138603): Caused 2 webkitpy tests to fail
https://bugs.webkit.org/show_bug.cgi?id=105913

Reviewed by Kentaro Hara.

Fix 2 webkitpy tests that started to fail after
r138603.

* Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest._sheriff_test_data_url): Make sure the
returned test file URL is valid no matter what the
current working directory is.
* Scripts/webkitpy/tool/bot/ircbot_unittest.py:
(IRCBotTest.test_help): Add "sheriffs" command to the
list of available commands.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r138601.
commit-queue@webkit.org [Wed, 2 Jan 2013 12:19:48 +0000 (12:19 +0000)]
Unreviewed, rolling out r138601.
http://trac.webkit.org/changeset/138601
https://bugs.webkit.org/show_bug.cgi?id=105917

Also not an optimal solution, needs more discussion.
(Requested by mkwst_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-02

Source/WebCore:

* dom/Document.cpp:
(WebCore::Document::finishedParsing):

LayoutTests:

* fast/frames/seamless/resources/span.html: Removed.
* fast/frames/seamless/seamless-contenteditable-not-inherited-expected.txt:
* fast/frames/seamless/seamless-srcdoc-expected.txt: Removed.
* fast/frames/seamless/seamless-srcdoc.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r138611.
commit-queue@webkit.org [Wed, 2 Jan 2013 12:07:11 +0000 (12:07 +0000)]
Unreviewed, rolling out r138611.
http://trac.webkit.org/changeset/138611
https://bugs.webkit.org/show_bug.cgi?id=105916

Not an optimal solution, needs more discussion. (Requested by
mkwst_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-02

Source/WebCore:

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.vcproj/WebCore.vcproj:
* css/StyleResolver.cpp:
(WebCore):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::reportMemoryUsage):
* css/seamless.css: Removed.

LayoutTests:

* fast/frames/seamless/resources/nested-seamless.html:
* fast/frames/seamless/resources/quirks-square.html:
* fast/frames/seamless/resources/two-inline-blocks.html:
* fast/frames/seamless/seamless-body-margin-expected.txt: Removed.
* fast/frames/seamless/seamless-body-margin.html: Removed.
* fast/frames/seamless/seamless-inherited-origin-expected.txt:
* fast/frames/seamless/seamless-inherited-origin.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[AC] Memory leak in GraphicsSurfacePrivate::findFBConfigWithAlpha()
commit-queue@webkit.org [Wed, 2 Jan 2013 11:24:50 +0000 (11:24 +0000)]
[AC] Memory leak in GraphicsSurfacePrivate::findFBConfigWithAlpha()
https://bugs.webkit.org/show_bug.cgi?id=105770

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-01-02
Reviewed by Noam Rosenthal.

Free the memory returned by glXGetVisualFromFBConfig() using
XFree to avoid a memory leak.

No new tests. No change in behavior.

* platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::findFBConfigWithAlpha):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRegression(r138607): Causes crashes related to WebIconDatabase
christophe.dumez@intel.com [Wed, 2 Jan 2013 10:09:02 +0000 (10:09 +0000)]
Regression(r138607): Causes crashes related to WebIconDatabase
https://bugs.webkit.org/show_bug.cgi?id=105909

Reviewed by Gyuyoung Kim.

Add back WebIconDatabase initialization statement
in WebContext constructor. It was removed in
r138607 and causing a lot of crashes on WebKit2.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOne more unreviewed buildfix after r138609.
ossy@webkit.org [Wed, 2 Jan 2013 09:43:25 +0000 (09:43 +0000)]
One more unreviewed buildfix after r138609.

* jit/JITCall.cpp: Add a missing include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThe 'body' of seamless IFrames should default to 'margin: 0'
mkwst@chromium.org [Wed, 2 Jan 2013 09:17:41 +0000 (09:17 +0000)]
The 'body' of seamless IFrames should default to 'margin: 0'
https://bugs.webkit.org/show_bug.cgi?id=90834

Reviewed by Eric Seidel.

Source/WebCore:

Documents displayed in seamless iframes should override the 'body'
element's normal 8px default margins with 0px, in order to ensure that
contents are displayed flush with the boundries of the seamless box.[1]

This patch does so by adding a new user agent stylesheet for seamless
documents, and teaching the StyleResolver how and when to apply it.

[1]: http://lists.w3.org/Archives/Public/public-whatwg-archive/2012Jul/0039.html

Test: fast/frames/seamless/seamless-body-margin.html

* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.vcproj/WebCore.vcproj:
* CMakeLists.txt:
    Added a new CSS file! Let's tell everyone!
* css/StyleResolver.cpp:
(WebCore):
(WebCore::loadSeamlessStyle):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::reportMemoryUsage):
    Load the new stylesheet, and apply it to the document in
    matchUARules iff the document should be displayed seamlessly.
* css/seamless.css: Added.
(body):
    Stylesheet containing defaults for seamless documents.

LayoutTests:

* fast/frames/seamless/seamless-body-margin-expected.txt: Added.
* fast/frames/seamless/seamless-body-margin.html: Added.
    New test to explicitly check 'body' margins.
* fast/frames/seamless/resources/nested-seamless.html:
* fast/frames/seamless/resources/quirks-square.html:
* fast/frames/seamless/resources/two-inline-blocks.html:
* fast/frames/seamless/seamless-inherited-origin-expected.txt:
* fast/frames/seamless/seamless-inherited-origin.html:
    Updated these tests to remove the assumption that the body had an
    8px margin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed buildfix after r138609.
ossy@webkit.org [Wed, 2 Jan 2013 09:07:05 +0000 (09:07 +0000)]
Unreviewed buildfix after r138609.

* jit/JITCall32_64.cpp: Add a missing include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBaseline JIT should have closure call caching
fpizlo@apple.com [Wed, 2 Jan 2013 08:48:18 +0000 (08:48 +0000)]
Baseline JIT should have closure call caching
https://bugs.webkit.org/show_bug.cgi?id=105900

Reviewed by Gavin Barraclough.

This is not a speed-up by itself, but is meant to allow the DFG inliner to
accurately discern between closure calls and non-closure calls, so that it can
do closure call inlining in the future.

* bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFromLLInt):
(JSC::CallLinkStatus::computeFor):
* bytecode/CallLinkStatus.h:
(JSC::CallLinkStatus::CallLinkStatus):
(JSC::CallLinkStatus::isClosureCall):
(CallLinkStatus):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
* jit/JIT.cpp:
(JSC::JIT::linkFor):
(JSC::JIT::linkSlowCall):
* jit/JIT.h:
(JSC::JIT::compileClosureCall):
* jit/JITCall.cpp:
(JSC::JIT::privateCompileClosureCall):
* jit/JITCall32_64.cpp:
(JSC::JIT::privateCompileClosureCall):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
* jit/ThunkGenerators.cpp:
(JSC::linkClosureCallGenerator):
* jit/ThunkGenerators.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
christophe.dumez@intel.com [Wed, 2 Jan 2013 06:53:25 +0000 (06:53 +0000)]
[WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
https://bugs.webkit.org/show_bug.cgi?id=105897

Reviewed by Alexey Proskuryakov.

Tools:

Dump in WebKitTestRunner the message that is expected by layout tests
when the missing plugin button is clicked.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::unavailablePluginButtonClicked):
(WTR):
* WebKitTestRunner/TestController.h:
(TestController):

LayoutTests:

Unskip plugins/clicking-missing-plugin-fires-delegate.html for
WK2 now that WebKitTestRunner is dumping the expected text when
the missing plugin button is clicked.

* platform/efl-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert more classes to be WebContextSupplements
weinig@apple.com [Wed, 2 Jan 2013 04:19:28 +0000 (04:19 +0000)]
Convert more classes to be WebContextSupplements
https://bugs.webkit.org/show_bug.cgi?id=105890

Reviewed by Dan Bernstein.

* UIProcess/API/C/WKContext.cpp:
(WKContextGetCookieManager):
(WKContextGetDatabaseManager):
(WKContextGetGeolocationManager):
(WKContextGetKeyValueStorageManager):
(WKContextGetMediaCacheManager):
(WKContextGetNotificationManager):
(WKContextGetResourceCacheManager):
* UIProcess/API/efl/ewk_context.cpp:
(EwkContext::cookieManager):
(EwkContext::clearResourceCache):
* UIProcess/API/efl/ewk_database_manager_private.h:
(EwkDatabaseManager::create):
* UIProcess/API/efl/ewk_storage_manager_private.h:
(EwkStorageManager::create):
* UIProcess/API/gtk/WebKitWebContext.cpp:
(createDefaultWebContext):
(webkit_web_context_clear_cache):
(webkit_web_context_get_cookie_manager):
* UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::supplementName):
(WebKit):
(WebKit::WebNotificationManagerProxy::WebNotificationManagerProxy):
(WebKit::WebNotificationManagerProxy::initializeProvider):
(WebKit::WebNotificationManagerProxy::contextDestroyed):
(WebKit::WebNotificationManagerProxy::processDidClose):
(WebKit::WebNotificationManagerProxy::refWebContextSupplement):
(WebKit::WebNotificationManagerProxy::derefWebContextSupplement):
(WebKit::WebNotificationManagerProxy::didReceiveMessage):
(WebKit::WebNotificationManagerProxy::providerDidShowNotification):
(WebKit::WebNotificationManagerProxy::providerDidClickNotification):
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications):
(WebKit::WebNotificationManagerProxy::providerDidUpdateNotificationPolicy):
(WebKit::WebNotificationManagerProxy::providerDidRemoveNotificationPolicies):
* UIProcess/Notifications/WebNotificationManagerProxy.h:
(WebNotificationManagerProxy):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::removeNetworkProcessProxy):
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::shouldTerminate):
(WebKit::WebContext::disconnectProcess):
* UIProcess/WebContext.h:
(WebKit):
(WebContext):
(WebKit::WebContext::iconDatabase):
* UIProcess/WebContextSupplement.h:
(WebKit):
(WebKit::WebContextSupplement::contextDestroyed):
(WebKit::WebContextSupplement::processDidClose):
(WebContextSupplement):
(WebKit::WebContextSupplement::shouldTerminate):
(WebKit::WebContextSupplement::ref):
(WebKit::WebContextSupplement::deref):
* UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::supplementName):
(WebKit):
(WebKit::WebCookieManagerProxy::WebCookieManagerProxy):
(WebKit::WebCookieManagerProxy::initializeClient):
(WebKit::WebCookieManagerProxy::contextDestroyed):
(WebKit::WebCookieManagerProxy::processDidClose):
(WebKit::WebCookieManagerProxy::shouldTerminate):
(WebKit::WebCookieManagerProxy::refWebContextSupplement):
(WebKit::WebCookieManagerProxy::derefWebContextSupplement):
(WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
(WebKit::WebCookieManagerProxy::deleteCookiesForHostname):
(WebKit::WebCookieManagerProxy::deleteAllCookies):
(WebKit::WebCookieManagerProxy::startObservingCookieChanges):
(WebKit::WebCookieManagerProxy::stopObservingCookieChanges):
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):
* UIProcess/WebCookieManagerProxy.h:
(WebCookieManagerProxy):
* UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::supplementName):
(WebKit):
(WebKit::WebDatabaseManagerProxy::WebDatabaseManagerProxy):
(WebKit::WebDatabaseManagerProxy::initializeClient):
(WebKit::WebDatabaseManagerProxy::contextDestroyed):
(WebKit::WebDatabaseManagerProxy::processDidClose):
(WebKit::WebDatabaseManagerProxy::refWebContextSupplement):
(WebKit::WebDatabaseManagerProxy::derefWebContextSupplement):
(WebKit::WebDatabaseManagerProxy::didReceiveMessage):
(WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::getDatabaseOrigins):
(WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteAllDatabases):
(WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):
* UIProcess/WebDatabaseManagerProxy.h:
(WebDatabaseManagerProxy):
* UIProcess/WebGeolocationManagerProxy.cpp:
(WebKit::WebGeolocationManagerProxy::supplementName):
(WebKit):
(WebKit::WebGeolocationManagerProxy::WebGeolocationManagerProxy):
(WebKit::WebGeolocationManagerProxy::initializeProvider):
(WebKit::WebGeolocationManagerProxy::contextDestroyed):
(WebKit::WebGeolocationManagerProxy::processDidClose):
(WebKit::WebGeolocationManagerProxy::refWebContextSupplement):
(WebKit::WebGeolocationManagerProxy::derefWebContextSupplement):
(WebKit::WebGeolocationManagerProxy::didReceiveMessage):
(WebKit::WebGeolocationManagerProxy::providerDidChangePosition):
(WebKit::WebGeolocationManagerProxy::providerDidFailToDeterminePosition):
* UIProcess/WebGeolocationManagerProxy.h:
(WebGeolocationManagerProxy):
* UIProcess/WebKeyValueStorageManagerProxy.cpp:
(WebKit::WebKeyValueStorageManagerProxy::supplementName):
(WebKit):
(WebKit::WebKeyValueStorageManagerProxy::WebKeyValueStorageManagerProxy):
(WebKit::WebKeyValueStorageManagerProxy::contextDestroyed):
(WebKit::WebKeyValueStorageManagerProxy::processDidClose):
(WebKit::WebKeyValueStorageManagerProxy::refWebContextSupplement):
(WebKit::WebKeyValueStorageManagerProxy::derefWebContextSupplement):
(WebKit::WebKeyValueStorageManagerProxy::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManagerProxy::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManagerProxy::deleteAllEntries):
* UIProcess/WebKeyValueStorageManagerProxy.h:
(WebKeyValueStorageManagerProxy):
* UIProcess/WebMediaCacheManagerProxy.cpp:
(WebKit::WebMediaCacheManagerProxy::supplementName):
(WebKit):
(WebKit::WebMediaCacheManagerProxy::WebMediaCacheManagerProxy):
(WebKit::WebMediaCacheManagerProxy::contextDestroyed):
(WebKit::WebMediaCacheManagerProxy::processDidClose):
(WebKit::WebMediaCacheManagerProxy::refWebContextSupplement):
(WebKit::WebMediaCacheManagerProxy::derefWebContextSupplement):
(WebKit::WebMediaCacheManagerProxy::getHostnamesWithMediaCache):
(WebKit::WebMediaCacheManagerProxy::clearCacheForHostname):
(WebKit::WebMediaCacheManagerProxy::clearCacheForAllHostnames):
* UIProcess/WebMediaCacheManagerProxy.h:
(WebMediaCacheManagerProxy):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showNotification):
* UIProcess/WebResourceCacheManagerProxy.cpp:
(WebKit::WebResourceCacheManagerProxy::supplementName):
(WebKit):
(WebKit::WebResourceCacheManagerProxy::WebResourceCacheManagerProxy):
(WebKit::WebResourceCacheManagerProxy::contextDestroyed):
(WebKit::WebResourceCacheManagerProxy::processDidClose):
(WebKit::WebResourceCacheManagerProxy::refWebContextSupplement):
(WebKit::WebResourceCacheManagerProxy::derefWebContextSupplement):
(WebKit::WebResourceCacheManagerProxy::didReceiveMessage):
(WebKit::WebResourceCacheManagerProxy::getCacheOrigins):
(WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin):
(WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins):
* UIProcess/WebResourceCacheManagerProxy.h:
(WebResourceCacheManagerProxy):
* UIProcess/efl/WebContextEfl.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
* UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
* UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformInitializeWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/12942239> Update copyright strings
mitz@apple.com [Wed, 2 Jan 2013 04:18:32 +0000 (04:18 +0000)]
<rdar://problem/12942239> Update copyright strings

Reviewed by Sam Weinig.

Source/JavaScriptCore:

* Info.plist:

Source/WebCore:

* Info.plist:

Source/WebKit/mac:

* Info.plist:

Source/WebKit2:

* Info.plist:
* NetworkProcess/Info.plist:
* PluginProcess/Info.plist:
* SharedWorkerProcess/Info.plist:
* WebProcess/Info.plist:
* WebProcessService/Info.plist:
* WebProcessServiceForWebKitDevelopment/Info.plist:

WebKitLibraries:

* win/tools/scripts/COPYRIGHT-END-YEAR:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Enable MHTML feature
commit-queue@webkit.org [Wed, 2 Jan 2013 04:14:32 +0000 (04:14 +0000)]
[EFL] Enable MHTML feature
https://bugs.webkit.org/show_bug.cgi?id=105815

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-01-01
Reviewed by Laszlo Gombos.

.:

ENABLE_MHTML is now ON for EFL.

* Source/cmake/OptionsEfl.cmake:

Source/WebCore:

Add application/x-mimearchive type to archive mime types.
Add mht and mhtml to extension map.

No new tests. Existing layout tests pass.

* loader/archive/ArchiveFactory.cpp:
(WebCore::archiveMIMETypes):
* platform/efl/MIMETypeRegistryEfl.cpp:
(WebCore):

Source/WebKit2:

Add missing include directory for ENABLE_MHTML.

* CMakeLists.txt:

Tools:

Enable MHTML feature for EFL port by default.

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoObjective-C API for JavaScriptCore
barraclough@apple.com [Wed, 2 Jan 2013 03:51:15 +0000 (03:51 +0000)]
Objective-C API for JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=105889

Reviewed by Filip Pizlo.

../JavaScriptCore:

For a detailed description of the API implemented here, see:
    JSContext.h
    APIJSValue.h
    JSVirtualMachine.h
    JSExport.h
Still to do -
    (1) Shoud rename APIJSValue.h -> JSValue.h (but we'll have to rename JSValue.h first).
    (2) Numerous FIXMEs, all with separate bugs filed.

* API/APIJSValue.h: Added.
    - this Objective-C class is used to reference a JavaScript object.
* API/JSBase.h:
    - added JS_OBJC_API_ENABLED macro to control ObjC API support.
* API/JSBlockAdaptor.h: Added.
    - this Objective-C class is used in creating a special NSBlock proxying a JavaScript function.
* API/JSBlockAdaptor.mm: Added.
(BlockArgument):
(BlockArgument::~BlockArgument):
(BlockArgumentBoolean):
(BlockArgumentBoolean::get):
(BlockArgumentNumeric):
(BlockArgumentNumeric::get):
(BlockArgumentId):
(BlockArgumentId::get):
(BlockArgumentStruct):
(BlockArgumentStruct::BlockArgumentStruct):
(BlockArgumentStruct::~BlockArgumentStruct):
(BlockArgumentStruct::get):
    - decoded arguent type information of a JSBlockAdaptor.
(BlockArgumentTypeDelegate):
(BlockArgumentTypeDelegate::typeInteger):
(BlockArgumentTypeDelegate::typeDouble):
(BlockArgumentTypeDelegate::typeBool):
(BlockArgumentTypeDelegate::typeVoid):
(BlockArgumentTypeDelegate::typeId):
(BlockArgumentTypeDelegate::typeOfClass):
(BlockArgumentTypeDelegate::typeBlock):
(BlockArgumentTypeDelegate::typeStruct):
    - delegate for use in conjunction with parseObjCType.
(BlockResult):
(BlockResult::~BlockResult):
(BlockResultVoid):
(BlockResultVoid::set):
(BlockResultInteger):
(BlockResultInteger::set):
(BlockResultDouble):
(BlockResultDouble::set):
(BlockResultBoolean):
(BlockResultBoolean::set):
(BlockResultStruct):
(BlockResultStruct::BlockResultStruct):
(BlockResultStruct::~BlockResultStruct):
(BlockResultStruct::set):
    - decoded result type information of a JSBlockAdaptor.
(buildBlockSignature):
    - partial step in constructing a signature with stack offset information from one without.
(-[JSBlockAdaptor initWithBlockSignatureFromProtocol:]):
    - constructor.
(-[JSBlockAdaptor blockMatchesSignature:]):
    - check whether signature strings match, where only one contains stack frame offsets.
(-[JSBlockAdaptor blockFromValue:inContext:withException:]):
    - use the adaptor to create a special forwarding block.
* API/JSCallbackObjectFunctions.h:
(JSC::::inherits):
    - add missing braces to multiline for statement.
* API/JSContext.h: Added.
    - this Objective-C class is used to reference a JavaScript context.
* API/JSContext.mm: Added.
(-[JSContext init]):
    - constructor.
(-[JSContext initWithVirtualMachine:]):
    - construct in a given VM (JSGlobalData).
(-[JSContext evaluateScript:]):
(-[JSContext globalObject]):
    - evaluate a script, global object accessor.
(+[JSContext currentContext]):
(+[JSContext currentThis]):
(+[JSContext currentArguments]):
    - These methods obtain context, this, arguments from within a callback.
(-[JSContext virtualMachine]):
    - implementation for .virtualMachine property.
(-[JSContext objectForKeyedSubscript:]):
(-[JSContext setObject:forKeyedSubscript:]):
    - support for subscript property access.
(contextInternalContext):
    - internal accessor to m_context.
(-[JSContext dealloc]):
    - desctructor.
(-[JSContext notifyException:]):
(-[JSContext valueFromNotifyException:]):
(-[JSContext boolFromNotifyException:]):
    - internal method to record an exception was thrown.
(-[JSContext beginCallbackWithData:thisValue:argumentCount:arguments:]):
(-[JSContext endCallbackWithData:]):
    - internal methods to push/pop a callback record.
(-[JSContext protect:]):
(-[JSContext unprotect:]):
    - internal methods to add a value to a protect set (used to protect the internal property of JSValue).
(-[JSContext wrapperForObject:]):
    - internal method to create a wrapper object.
(WeakContextRef::WeakContextRef):
(WeakContextRef::~WeakContextRef):
(WeakContextRef::get):
(WeakContextRef::set):
    - Helper class to implement a weak reference to a JSContext.
* API/JSContextInternal.h: Added.
(CallbackData):
(WeakContextRef):
    - see API/JSContext.mm for description of internal methods.
* API/JSExport.h: Added.
    - Provides JSExport protocol & JSExportAs macro.
* API/JSValue.mm: Added.
(+[JSValue valueWithObject:inContext:]):
(+[JSValue valueWithBool:inContext:]):
(+[JSValue valueWithDouble:inContext:]):
(+[JSValue valueWithInt32:inContext:]):
(+[JSValue valueWithUInt32:inContext:]):
(+[JSValue valueWithNewObjectInContext:]):
(+[JSValue valueWithNewArrayInContext:]):
(+[JSValue valueWithNewRegularExpressionFromPattern:flags:inContext:]):
(+[JSValue valueWithNewErrorFromMessage:inContext:]):
(+[JSValue valueWithNullInContext:]):
(+[JSValue valueWithUndefinedInContext:]):
    - Constructors.
(-[JSValue toObject]):
(-[JSValue toObjectOfClass:]):
(-[JSValue toBool]):
(-[JSValue toDouble]):
(-[JSValue toInt32]):
(-[JSValue toUInt32]):
(-[JSValue toNumber]):
(-[JSValue toString]):
(-[JSValue toDate]):
(-[JSValue toArray]):
(-[JSValue toDictionary]):
    - Conversion to Objective-C types.
(-[JSValue valueForProperty:]):
(-[JSValue setValue:forProperty:]):
(-[JSValue deleteProperty:]):
(-[JSValue hasProperty:]):
(-[JSValue defineProperty:descriptor:]):
    - Property access by property name.
(-[JSValue valueAtIndex:]):
(-[JSValue setValue:atIndex:]):
    - Property access by index.
(-[JSValue isUndefined]):
(-[JSValue isNull]):
(-[JSValue isBoolean]):
(-[JSValue isNumber]):
(-[JSValue isString]):
(-[JSValue isObject]):
    - Test JavaScript type.
(-[JSValue isEqualToObject:]):
(-[JSValue isEqualWithTypeCoercionToObject:]):
(-[JSValue isInstanceOf:]):
    - ===, ==, instanceof operators.
(-[JSValue callWithArguments:]):
(-[JSValue constructWithArguments:]):
(-[JSValue invokeMethod:withArguments:]):
    - Call & construct.
(-[JSValue context]):
    - implementation for .context property.
(-[JSValue toPoint]):
(-[JSValue toRange]):
(-[JSValue toRect]):
(-[JSValue toSize]):
(+[JSValue valueWithPoint:inContext:]):
(+[JSValue valueWithRange:inContext:]):
(+[JSValue valueWithRect:inContext:]):
(+[JSValue valueWithSize:inContext:]):
    - Support for NS struct types.
(-[JSValue objectForKeyedSubscript:]):
(-[JSValue objectAtIndexedSubscript:]):
(-[JSValue setObject:forKeyedSubscript:]):
(-[JSValue setObject:atIndexedSubscript:]):
    - support for subscript property access.
(isDate):
(isArray):
    - internal helper functions to check for instances of JS Date, Array types.
(JSContainerConvertor):
(Task):
(JSContainerConvertor::JSContainerConvertor):
(JSContainerConvertor::isWorkListEmpty):
(JSContainerConvertor::convert):
(JSContainerConvertor::add):
(JSContainerConvertor::take):
    - helper class for tracking state while converting to Array/Dictionary objects.
(valueToObjectWithoutCopy):
(containerValueToObject):
(valueToObject):
(valueToNumber):
(valueToString):
(valueToDate):
(valueToArray):
(valueToDictionary):
    - function for converting JavaScript values to Objective-C objects.
(ObjcContainerConvertor):
(ObjcContainerConvertor::ObjcContainerConvertor):
(ObjcContainerConvertor::isWorkListEmpty):
(ObjcContainerConvertor::convert):
(ObjcContainerConvertor::add):
(ObjcContainerConvertor::take):
    - helper class for tracking state while converting to Array/Dictionary values.
(objectToValueWithoutCopy):
(objectToValue):
(valueInternalValue):
    - function for converting Objective-C objects to JavaScript values.
(+[JSValue valueWithValue:inContext:]):
(-[JSValue initWithValue:inContext:]):
    - internal constructors.
(StructTagHandler):
(getStructTagHandler):
(+[JSValue selectorForStructToValue:]):
(+[JSValue selectorForValueToStruct:]):
    - methods to tracking struct types that support conversion to/from JSValue.
(-[JSValue dealloc]):
    - destructor.
(-[JSValue description]):
    - Objective-C to-NSString conversion.
(typeToValueInvocationFor):
(valueToTypeInvocationFor):
    - create invocation objects for conversion to/from JSValue.
* API/JSValueInternal.h: Added.
    - see API/JSValue.mm for description of internal methods.
* API/JSVirtualMachine.h: Added.
    - this Objective-C class is used to reference a JavaScript virtual machine (JSGlobalData).
* API/JSVirtualMachine.mm: Added.
(-[JSVirtualMachine init]):
(-[JSVirtualMachine dealloc]):
    - constructor & destructor.
(getGroupFromVirtualMachine):
    - internal accessor for m_group property.
* API/JSVirtualMachineInternal.h: Added.
    - see API/JSVirtualMachine.mm for description of internal methods.
* API/JSWrapperMap.h: Added.
* API/JSWrapperMap.mm: Added.
(wrapperClass):
    - singleton root for detction (& unwrapping) of wrapper objects.
(selectorToPropertyName):
    - default selector to property name conversion.
(createObjectWithCustomBrand):
    - creates a JSObject with a custom NativeBrand (class name).
(createRenameMap):
    - parse @optional properties of a JSExport protocol.
(putNonEnumerable):
    - property put with enumerable=false.
(copyMethodsToObject):
    - iterate methods in a protocol; add functions to a JSObject.
(parsePropertyAttributes):
    - examine protocol property metadata.
(makeSetterName):
    - "foo" -> "setFoo"
(copyPrototypeProperties):
    - create properties on a Protocol object reflecting the instance methods & properties of a protocol.
(-[JSObjCClassInfo initWithContext:forClass:superClassInfo:]):
(-[JSObjCClassInfo dealloc]):
(-[JSObjCClassInfo wrapperForObject:]):
(-[JSObjCClassInfo constructor]):
    - cache the Protocol/Constructor objects for an Objective-C type.
(-[JSWrapperMap initWithContext:]):
(-[JSWrapperMap dealloc]):
    - constructor & desctructor.
(-[JSWrapperMap classInfoForClass:]):
    - maps Class -> JSObjCClassInfo.
(-[JSWrapperMap wrapperForObject:]):
    - cretae or retrieve a cached wrapper value for an object.
(tryUnwrapObjcObject):
    - check whether a value is a wrapper object; unwrap if so.
* API/JavaScriptCore.h:
    - Added includes for new API headers.
* API/ObjCCallbackFunction.h: Added.
    - this class is used to wrap Objective-C instance methods, class methods & blocks as JSFunction objects.
* API/ObjCCallbackFunction.mm: Added.
(CallbackArgument):
(CallbackArgument::~CallbackArgument):
(CallbackArgumentBoolean):
(CallbackArgumentBoolean::set):
(CallbackArgumentInteger):
(CallbackArgumentInteger::set):
(CallbackArgumentDouble):
(CallbackArgumentDouble::set):
(CallbackArgumentJSValue):
(CallbackArgumentJSValue::set):
(CallbackArgumentId):
(CallbackArgumentId::set):
(CallbackArgumentOfClass):
(CallbackArgumentOfClass::CallbackArgumentOfClass):
(CallbackArgumentOfClass::~CallbackArgumentOfClass):
(CallbackArgumentOfClass::set):
(CallbackArgumentNSNumber):
(CallbackArgumentNSNumber::set):
(CallbackArgumentNSString):
(CallbackArgumentNSString::set):
(CallbackArgumentNSDate):
(CallbackArgumentNSDate::set):
(CallbackArgumentNSArray):
(CallbackArgumentNSArray::set):
(CallbackArgumentNSDictionary):
(CallbackArgumentNSDictionary::set):
(CallbackArgumentStruct):
(CallbackArgumentStruct::CallbackArgumentStruct):
(CallbackArgumentStruct::~CallbackArgumentStruct):
(CallbackArgumentStruct::set):
(CallbackArgumentBlockCallback):
(CallbackArgumentBlockCallback::CallbackArgumentBlockCallback):
(CallbackArgumentBlockCallback::~CallbackArgumentBlockCallback):
(CallbackArgumentBlockCallback::set):
    - decoded arguent type information of a ObjCCallbackFunction.
(ArgumentTypeDelegate):
(ArgumentTypeDelegate::typeInteger):
(ArgumentTypeDelegate::typeDouble):
(ArgumentTypeDelegate::typeBool):
(ArgumentTypeDelegate::typeVoid):
(ArgumentTypeDelegate::typeId):
(ArgumentTypeDelegate::typeOfClass):
(ArgumentTypeDelegate::typeBlock):
(ArgumentTypeDelegate::typeStruct):
    - delegate for use in conjunction with parseObjCType.
(CallbackResult):
(CallbackResult::~CallbackResult):
(CallbackResultVoid):
(CallbackResultVoid::get):
(CallbackResultId):
(CallbackResultId::get):
(CallbackResultNumeric):
(CallbackResultNumeric::get):
(CallbackResultBoolean):
(CallbackResultBoolean::get):
(CallbackResultStruct):
(CallbackResultStruct::CallbackResultStruct):
(CallbackResultStruct::~CallbackResultStruct):
(CallbackResultStruct::get):
    - decoded result type information of a ObjCCallbackFunction.
(ResultTypeDelegate):
(ResultTypeDelegate::typeInteger):
(ResultTypeDelegate::typeDouble):
(ResultTypeDelegate::typeBool):
(ResultTypeDelegate::typeVoid):
(ResultTypeDelegate::typeId):
(ResultTypeDelegate::typeOfClass):
(ResultTypeDelegate::typeBlock):
(ResultTypeDelegate::typeStruct):
    - delegate for use in conjunction with parseObjCType.
(ObjCCallbackFunction):
(ObjCCallbackFunction::ObjCCallbackFunction):
(ObjCCallbackFunction::~ObjCCallbackFunction):
    - constructor & destructor.
(ObjCCallbackFunction::context):
    - accessor.
(ObjCCallbackFunction::wrappedBlock):
    - attemmpt to unwrap a block object.
(objCCallbackFunctionFinalize):
(objCCallbackFunctionCallAsFunction):
(objCCallbackFunctionClass):
    - JSClassRef used to represent ObjCCallbackFunction objects.
(ObjCCallbackFunction::call):
(blockSignatureContainsClass):
    - helper function to determine if we're running on a recent Clang.
(skipNumber):
    - helper used in parsing signature strings.
(objCCallbackFunctionForInvocation):
(objCCallbackFunctionForMethod):
(objCCallbackFunctionForBlock):
    - functions to try to create ObjCCallbackFunction instances for methods/blocks.
(tryUnwrapBlock):
    - attemmpt to unwrap a block object.
* API/ObjcRuntimeExtras.h: Added.
(protocolImplementsProtocol):
(forEachProtocolImplementingProtocol):
(forEachMethodInClass):
(forEachMethodInProtocol):
(forEachPropertyInProtocol):
    - functions used in reflecting on Objective-C types.
(skipPair):
    - parsing helper used by parseObjCType, scans for matching parentheses.
(StringRange):
(StringRange::StringRange):
(StringRange::~StringRange):
(StringRange::operator const char*):
(StringRange::get):
    - Helper class - create a c string copy of a range of an existing string.
(parseObjCType):
    - function to parse Objective-C type strings, makes callbacks to a deleagte.
* API/tests/testapi.c:
(main):
    - added call to testObjectiveCAPI (in testapi.m).
* API/tests/testapi.m: Added.
(+[ParentObject parentTest]):
(+[TestObject testObject]):
(+[TestObject classTest]):
(-[TestObject getString]):
(-[TestObject testArgumentTypesWithInt:double:boolean:string:number:array:dictionary:]):
(-[TestObject callback:]):
(-[TextXYZ test:]):
    - test object, used in various test vases.
(checkResult):
    - helper function.
(blockSignatureContainsClass):
    - helper function to determine if we're running on a recent Clang.
(testObjectiveCAPI):
    - new test cases.
* JavaScriptCore.xcodeproj/project.pbxproj:
    - added new files.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSGlobalData):
    - added m_apiData - provide convenient storage for use by the API.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::JSGlobalObject):
* runtime/JSGlobalObject.h:
(JSGlobalObject):
    - added m_apiData - provide convenient storage for use by the API.

../WTF:

* wtf/WTFThreadData.cpp:
(WTF::WTFThreadData::WTFThreadData):
* wtf/WTFThreadData.h:
(WTFThreadData):
    - Added m_apiData - provide convenient storage for use by the API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agosheriff-bot should know who the gardeners/sheriffs are
commit-queue@webkit.org [Wed, 2 Jan 2013 02:54:18 +0000 (02:54 +0000)]
sheriff-bot should know who the gardeners/sheriffs are
https://bugs.webkit.org/show_bug.cgi?id=105698

Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-01
Reviewed by Eric Seidel.

Added a "sheriffs" command to sheriffbot to fetch the current Chromium Webkit sheriffs.

* Scripts/webkitpy/tool/bot/irc_command.py:
(Current):
(Current._retrieve_webkit_sheriffs):
(Current.execute):
* Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest.test_current):
* Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Added.
* Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Added.
* Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Added.
* Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Added.
* Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK1] Skip some webaudio test cases due to lack of implementation
commit-queue@webkit.org [Wed, 2 Jan 2013 00:23:25 +0000 (00:23 +0000)]
[EFL][WK1] Skip some webaudio test cases due to lack of implementation
https://bugs.webkit.org/show_bug.cgi?id=105882

Unreviewed, EFL gardening.

Bunch of webaudio test cases need setAudioData implementation and DRT has not it.
So, skips those cases.

Patch by Kangil Han <kangil.han@samsung.com> on 2013-01-01

* platform/efl-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoseamless iframes don't inherit styles when srcdoc is used
mkwst@chromium.org [Tue, 1 Jan 2013 17:20:50 +0000 (17:20 +0000)]
seamless iframes don't inherit styles when srcdoc is used
https://bugs.webkit.org/show_bug.cgi?id=103539

Reviewed by Eric Seidel.

Source/WebCore:

Seamless iframes populated via a 'srcdoc' attribute should always
inherit styles from their parent documents. At the moment, this is
only the case when they contain a stylesheet or some other markup
that forces a style recalculation on the document. Simple 'srcdoc'
attributes (e.g. "srcdoc='<p>This is a comment.</p>'") bail out of
recalculating style early, resulting in unstyled appearance.

This patch instructs WebCore to treat seamless documents as having an
updated StyleResolver regardless of what actions the parser takes,
which in turn ensures that the document's style is recalculated
correctly.

Test: fast/frames/seamless/seamless-srcdoc.html

* dom/Document.cpp:
(WebCore::Document::finishedParsing):
    If it's a seamless document, notify it that its StyleResolver isn't
    what it might have expected.

LayoutTests:

* fast/frames/seamless/resources/span.html: Added.
* fast/frames/seamless/seamless-contenteditable-not-inherited-expected.txt:
    Updating the previously FAILing expectation.
* fast/frames/seamless/seamless-srcdoc-expected.txt: Added.
* fast/frames/seamless/seamless-srcdoc.html: Added.
    Exciting new test to ensure that this doesn't regress, neither
    for totally simple srcdoc attriubtes, nor for slightly more
    complex variations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Fullscreen Media Time Indicators Background Incorrect
commit-queue@webkit.org [Mon, 31 Dec 2012 20:37:06 +0000 (20:37 +0000)]
[BlackBerry] Fullscreen Media Time Indicators Background Incorrect
https://bugs.webkit.org/show_bug.cgi?id=105888

Patch by Jeff Rogers <jrogers@rim.com> on 2012-12-31
Reviewed by George Staikos.

Internal PR 272699.
Update fullscreen media controls CSS to fix time container background
color. Also fix transparency to be 80% opaque to and the time
remaining text color to match the system player.

No new tests as there is no functionality change.

* css/mediaControlsBlackBerryFullscreen.css:
(video:-webkit-full-screen::-webkit-media-controls-panel):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-time-display-container):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-timeline-container):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-current-time-display):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-time-remaining-display):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-button-container, video:-webkit-full-screen::-webkit-media-controls-play-button-container):
(video:-webkit-full-screen::-webkit-media-controls-placeholder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd supplementability for WebContext
weinig@apple.com [Mon, 31 Dec 2012 19:53:31 +0000 (19:53 +0000)]
Add supplementability for WebContext
https://bugs.webkit.org/show_bug.cgi?id=105878

Reviewed by Dan Bernstein.

Add WebContextSupplement and convert WebApplicationCacheManagerProxy to it.

* UIProcess/API/C/WKContext.cpp:
(WKContextGetApplicationCacheManager):
* UIProcess/WebApplicationCacheManagerProxy.cpp:
(WebKit::WebApplicationCacheManagerProxy::supplementName):
(WebKit::WebApplicationCacheManagerProxy::WebApplicationCacheManagerProxy):
(WebKit::WebApplicationCacheManagerProxy::contextDestroyed):
(WebKit::WebApplicationCacheManagerProxy::processDidClose):
(WebKit::WebApplicationCacheManagerProxy::refWebContextSupplement):
(WebKit::WebApplicationCacheManagerProxy::derefWebContextSupplement):
(WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):
* UIProcess/WebApplicationCacheManagerProxy.h:
(WebApplicationCacheManagerProxy):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::shouldTerminate):
(WebKit::WebContext::disconnectProcess):
* UIProcess/WebContext.h:
(WebKit::WebContext::supplement):
(WebKit::WebContext::addSupplement):
* UIProcess/WebContextSupplement.h: Added.
(WebKit::WebContextSupplement::WebContextSupplement):
(WebKit::WebContextSupplement::~WebContextSupplement):
(WebKit::WebContextSupplement::ref):
(WebKit::WebContextSupplement::deref):
(WebKit::WebContextSupplement::context):
(WebKit::WebContextSupplement::clearContext):
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WebGL] Add compile time support for GLES2.
commit-queue@webkit.org [Mon, 31 Dec 2012 16:56:42 +0000 (16:56 +0000)]
[EFL][WebGL] Add compile time support for GLES2.
https://bugs.webkit.org/show_bug.cgi?id=105816

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-31
Reviewed by Kenneth Rohde Christiansen.

.:

This patch adds build support for GLES2.
GLES2 support can be enabled during compile time by passing -DENABLE_GLES2=ON as
cmake config parameter. GLES2 options is not enabled by default. This patch doesn't
address all the build issues related to GLES2 but only adds the needed support in
OptionsEfl.cmake.

* Source/cmake/OptionsEfl.cmake:

Source/WebCore:

This patch adds build support for GLES2.
GLES2 support can be enabled during compile time by passing -DENABLE_GLES2=ON as
cmake config parameter. GLES2 options is not enabled by default. This patch doesn't
address all the build issues related to GLES2 but only adds the needed support in
PlatformEfl.cmake.

* PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL[WK2] Regression(r138574): Should not allocate memory in the fork
christophe.dumez@intel.com [Mon, 31 Dec 2012 16:31:24 +0000 (16:31 +0000)]
[EFL[WK2] Regression(r138574): Should not allocate memory in the fork
https://bugs.webkit.org/show_bug.cgi?id=105868

Reviewed by Kenneth Rohde Christiansen.

Store prefixed executable path in a CString before the fork to
avoid allocating memory in the fork by calling String::utf8().
Allocating memory in the fork may lead to deadlocks due to
FastMalloc and the fork not inheriting the threads.

* UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
(WebKit::ProcessLauncher::launchProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] The HTML5 video fullscreen time indicator on the right cuts clipped...
commit-queue@webkit.org [Mon, 31 Dec 2012 16:05:07 +0000 (16:05 +0000)]
[BlackBerry] The HTML5 video fullscreen time indicator on the right cuts clipped when the video is longer than 1 hour
https://bugs.webkit.org/show_bug.cgi?id=105887

Patch by Andy Chen <andchen@rim.com> on 2012-12-31
Reviewed by George Staikos.

The width of the time part was fixed. Remove it.

No new test is required because no functionality change.

* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Move ImageDiff to the Tools directory root
commit-queue@webkit.org [Mon, 31 Dec 2012 13:54:36 +0000 (13:54 +0000)]
[GTK] Move ImageDiff to the Tools directory root
https://bugs.webkit.org/show_bug.cgi?id=105421

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2012-12-31
Reviewed by Kenneth Rohde Christiansen.

.:

* GNUmakefile.am: Remove the old ImageDiff makefile include.

Tools:

* DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Removed.
* GNUmakefile.am:
* ImageDiff/gtk/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/gtk/ImageDiff.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] css3/masking/clip-path-circle-relative-overflow.html needs expected results...
commit-queue@webkit.org [Mon, 31 Dec 2012 13:25:10 +0000 (13:25 +0000)]
[EFL] css3/masking/clip-path-circle-relative-overflow.html needs expected results update after 97217
https://bugs.webkit.org/show_bug.cgi?id=105883

Unreviewed, EFL gardening.

Rebaseline css3/masking/clip-path-circle-relative-overflow.html because BUG 97217 has been resolved.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-12-31

* platform/efl/TestExpectations:
* platform/efl/css3/masking/clip-path-circle-relative-overflow-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add API to set a WebKitWebView in view source mode to WebKit2
carlosgc@webkit.org [Mon, 31 Dec 2012 12:50:27 +0000 (12:50 +0000)]
[GTK] Add API to set a WebKitWebView in view source mode to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=99315

Reviewed by Martin Robinson.

Add a generic API to set/get a view mode. For now there are only
two modes, Web and Source, but the API can be extended if we
eventually support other view modes like Printing for example.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewSetProperty): Implement setter for view-mode
property.
(webkitWebViewGetProperty): Implement getter for view-mode
property.
(webkit_web_view_class_init): Add view-source property.
(webkit_web_view_set_view_mode): Public method to set the view
mode.
(webkit_web_view_get_view_mode): Public method to get the view
mode.
* UIProcess/API/gtk/WebKitWebView.h: Add WebKitViewMode enum.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewMode):
(beforeAll):
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::WebFrameProxy): Initialize
m_inViewSourceMode.
(WebKit::WebFrameProxy::setInViewSourceMode): Set
m_inViewSourceMode if it has changed and call
WebPageProxy::setFrameInViewSourceMode() to notify the WebProcess.
* UIProcess/WebFrameProxy.h:
(WebKit::WebFrameProxy::inViewSourceMode): Return whether the
frame is currently in view source mode.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setFrameInViewSourceMode): Send a message
to the WebProcess to set the given frame in view source mode or not.
* UIProcess/WebPageProxy.h:
(WebPageProxy): Add setFrameInViewSourceMode().
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setFrameInViewSourceMode): Call
setInViewSourceMode for the main frame.
* WebProcess/WebPage/WebPage.h:
(WebPage): Add setFrameInViewSourceMode().
* WebProcess/WebPage/WebPage.messages.in: Add new message
SetFrameInViewSourceMode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
christophe.dumez@intel.com [Mon, 31 Dec 2012 08:57:11 +0000 (08:57 +0000)]
Unreviewed EFL gardening.

Mark editing/spelling/spelling-insert-html.html as flaky
since it sometimes hits an assertion in RenderObject
destructor.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
christophe.dumez@intel.com [Mon, 31 Dec 2012 07:57:42 +0000 (07:57 +0000)]
Unreviewed EFL gardening.

Mark fast/dom/Range/range-extract-contents.html as flaky
since it sometimes hits an assertion in
WebCore::endOfContinuations().

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
christophe.dumez@intel.com [Mon, 31 Dec 2012 07:49:41 +0000 (07:49 +0000)]
Unreviewed EFL gardening.

Mark editing/pasteboard/4806874.html as flaky since
it sometimes hits an assertion in RenderObject
destructor.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
christophe.dumez@intel.com [Mon, 31 Dec 2012 07:41:17 +0000 (07:41 +0000)]
Unreviewed EFL gardening.

Rebaseline fast/js/global-constructors.html after
TEMPLATE_ELEMENT was enabled for EFL port in r138586.

* platform/efl/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] [WebGL] Rename EGLConfigHelper as EGLConfigSelector.
commit-queue@webkit.org [Mon, 31 Dec 2012 07:33:02 +0000 (07:33 +0000)]
[EFL] [WebGL] Rename EGLConfigHelper as EGLConfigSelector.
https://bugs.webkit.org/show_bug.cgi?id=105876

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-30
Reviewed by Kenneth Rohde Christiansen.

This is to sync the naming conventions of our classes in both EGL and GLX implementations.
In our GLX implementation, class responsible for the same functionality is named as GLXConfigSelector.
This patch renames EGLConfigHelper as EGLConfigSelector.

.:

* Source/cmake/OptionsEfl.cmake:

Source/WebCore:

* PlatformEfl.cmake:
* platform/graphics/surfaces/egl/EGLConfigSelector.cpp: Renamed from Source/WebCore/platform/graphics/surfaces/egl/EGLConfigHelper.cpp.
(WebCore):
(WebCore::SharedEGLDisplay::deref):
(WebCore::SharedEGLDisplay::sharedEGLDisplay):
(WebCore::SharedEGLDisplay::SharedEGLDisplay):
(WebCore::SharedEGLDisplay::cleanup):
(WebCore::SharedEGLDisplay::~SharedEGLDisplay):
(WebCore::EGLConfigSelector::EGLConfigSelector):
(WebCore::EGLConfigSelector::~EGLConfigSelector):
(WebCore::EGLConfigSelector::display):
(WebCore::EGLConfigSelector::pBufferContextConfig):
(WebCore::EGLConfigSelector::surfaceContextConfig):
(WebCore::EGLConfigSelector::nativeVisualId):
(WebCore::EGLConfigSelector::reset):
(WebCore::EGLConfigSelector::createConfig):
* platform/graphics/surfaces/egl/EGLConfigSelector.h: Renamed from Source/WebCore/platform/graphics/surfaces/egl/EGLConfigHelper.h.
(WebCore):
(SharedEGLDisplay):
(WebCore::SharedEGLDisplay::create):
(EGLConfigSelector):
* platform/graphics/surfaces/egl/EGLSurface.cpp:
(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):
(WebCore::EGLWindowTransportSurface::configuration):
(WebCore::EGLWindowTransportSurface::destroy):
* platform/graphics/surfaces/egl/EGLSurface.h:
(EGLWindowTransportSurface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd myself to watchlists for CSP and console logs.
mkwst@chromium.org [Mon, 31 Dec 2012 07:12:34 +0000 (07:12 +0000)]
Add myself to watchlists for CSP and console logs.
https://bugs.webkit.org/show_bug.cgi?id=105874

Reviewed by Dirk Pranke.

Because I really, really, really need more email.

* Scripts/webkitpy/common/config/committers.py:
    Add mkwst+watchlist@chromium.org as a contributor.
* Scripts/webkitpy/common/config/watchlist:
    Create watchlist categories for 1) the various mechanisms used to
    generate console messages, and 2) CSP usage and files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago.: [EFL] Enable TEMPLATE_ELEMENT feature
gyuyoung.kim@samsung.com [Mon, 31 Dec 2012 04:44:16 +0000 (04:44 +0000)]
.: [EFL] Enable TEMPLATE_ELEMENT feature
https://bugs.webkit.org/show_bug.cgi?id=105865

Reviewed by Laszlo Gombos.

* Source/cmake/OptionsEfl.cmake: Add ENABLE_TEMPLATE_ELEMENT macro.

Tools: [EFL] Enable TEMPLATE_ELEMENT feature
https://bugs.webkit.org/show_bug.cgi?id=105865

Reviewed by Laszlo Gombos.

* Scripts/webkitperl/FeatureList.pm: Enable template element feature for EFL port.

LayoutTests: [EFL] Enable TEMPLATE_ELEMENT feature
https://bugs.webkit.org/show_bug.cgi?id=105865

Reviewed by Laszlo Gombos.

* platform/efl/TestExpectations: Unskip test cases for template element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPrettyDiff.rb fails to render image diffs with Ruby 1.9.3p194
mrobinson@webkit.org [Sun, 30 Dec 2012 21:22:04 +0000 (21:22 +0000)]
PrettyDiff.rb fails to render image diffs with Ruby 1.9.3p194
https://bugs.webkit.org/show_bug.cgi?id=104932

Reviewed by Eric Seidel.

Ruby 1.9 added the concept of string encodings, so the use of `match' with binary data
treats it as UTF-8. Forcing the png_bytes string to have the "binary" encoding avoids
this error.

* PrettyPatch/PrettyPatch.rb: Use force_encoding.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
christophe.dumez@intel.com [Sun, 30 Dec 2012 17:51:43 +0000 (17:51 +0000)]
Unreviewed EFL gardening.

Add several webaudio tests to TestExpectations since
they sometimes hit !m_finishedNodes.size() assertion
in AudioContext destructor.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
christophe.dumez@intel.com [Sun, 30 Dec 2012 17:37:18 +0000 (17:37 +0000)]
Unreviewed EFL gardening.

Unskip XSS Auditor test case that has been consistently
passing on EFL port for a while.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
christophe.dumez@intel.com [Sun, 30 Dec 2012 17:08:14 +0000 (17:08 +0000)]
Unreviewed EFL gardening.

Unskip fast/dom/shadow/host-wrapper-reclaimed.html
since it is passing after r137978.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
christophe.dumez@intel.com [Sun, 30 Dec 2012 17:05:27 +0000 (17:05 +0000)]
Unreviewed EFL gardening.

Update expectations for 2 fast/dom test cases so
that they are not reported as unexpected passes.

Those tests are passing because their generated
expectations are wrong.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GStreamer] webaudio/decode-audio-data-basic.html fails
philn@webkit.org [Sun, 30 Dec 2012 16:57:45 +0000 (16:57 +0000)]
[GStreamer] webaudio/decode-audio-data-basic.html fails
https://bugs.webkit.org/show_bug.cgi?id=105298

Reviewed by Martin Robinson.

Source/WebCore:

* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::createBus): Return a null pointer if an
error happened while processing a media file.

LayoutTests:

* platform/efl/TestExpectations: Unflag fixed test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
christophe.dumez@intel.com [Sun, 30 Dec 2012 16:55:22 +0000 (16:55 +0000)]
Unreviewed EFL gardening.

Unskip text-decoration-style tests passing after
r126054 and r132076.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
christophe.dumez@intel.com [Sun, 30 Dec 2012 15:55:51 +0000 (15:55 +0000)]
Unreviewed EFL gardening.

Unskip cairo-related tests that are now consistently
passing on both WK1 and WK2 EFL.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
christophe.dumez@intel.com [Sun, 30 Dec 2012 15:45:55 +0000 (15:45 +0000)]
Unreviewed EFL gardening.

Unskip several compositing test cases that are passing
consistently on EFL WK2.

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRegression(r138545): Makes WebAudio tests crash
christophe.dumez@intel.com [Sun, 30 Dec 2012 14:57:20 +0000 (14:57 +0000)]
Regression(r138545): Makes WebAudio tests crash
https://bugs.webkit.org/show_bug.cgi?id=105869

Reviewed by Philippe Normand.

Stop using smart pointers and adoptGRef() for the
GstBus object and call gst_object_unref() manually.
This fixes assertions hits when calling adoptGRef()
since the GstBus object has a floating reference.

Alternatively, we could keep using smart pointers
and stop calling adoptGRef() so that
gst_object_ref_sink() is called and the floating
flag is cleared but I think it is clearer to do
it manually here.

No new tests, already covered by existing tests.

* platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::messageCallback):
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer):
* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::~AudioFileReader):
(WebCore::AudioFileReader::decodeAudioForBusCreation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening, unskip a now passing test.
ossy@webkit.org [Sun, 30 Dec 2012 14:52:13 +0000 (14:52 +0000)]
Unreviewed gardening, unskip a now passing test.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Invalid use of temporary object in ProcessLauncher::launchProcess()
christophe.dumez@intel.com [Sun, 30 Dec 2012 11:56:40 +0000 (11:56 +0000)]
[EFL][WK2] Invalid use of temporary object in ProcessLauncher::launchProcess()
https://bugs.webkit.org/show_bug.cgi?id=105867

Reviewed by Kenneth Rohde Christiansen.

Fix invalid use of temporary object in ProcessLauncher::launchProcess()
for prefixedExecutablePath.

* UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
(WebKit::ProcessLauncher::launchProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening of the unit tests.
zandobersek@gmail.com [Sun, 30 Dec 2012 09:51:21 +0000 (09:51 +0000)]
Unreviewed GTK gardening of the unit tests.

Skip the TestInspectorServer unit test that's timing out completely.

* Scripts/run-gtk-tests:
(TestRunner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename StyleResolver's member variable that holds SelectorChecker to a proper name.
dglazkov@chromium.org [Sun, 30 Dec 2012 01:22:48 +0000 (01:22 +0000)]
Rename StyleResolver's member variable that holds SelectorChecker to a proper name.
https://bugs.webkit.org/show_bug.cgi?id=105864

In https://bugs.webkit.org/show_bug.cgi?id=105660#c11, Antti suggested renaming m_checker to
m_selectorChecker. I've forgotten about that, but now I remembered it.

Reviewed by Eric Seidel.

No change in functionality, covered by existing tests.

* css/StyleResolver.cpp/h: Renamed all instances of m_checker to m_selectorChecker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove pointer to Document up from SelectorChecker to StyleResolver.
dglazkov@chromium.org [Sun, 30 Dec 2012 00:29:52 +0000 (00:29 +0000)]
Move pointer to Document up from SelectorChecker to StyleResolver.
https://bugs.webkit.org/show_bug.cgi?id=105863

Now that SelectorChecker is mostly stateless, it no longer needs to keep a pointer to Document, which
makes all the code in StyleResolver that reaches for it sort of weird.

Reviewed by Eric Seidel.

No change in functionality, covered by existing tests.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::SelectorChecker): Changed to take document as argument (only used to set bit fields).
(WebCore::SelectorChecker::checkOneSelector): Changed to use element document.
(WebCore::SelectorChecker::checkScrollbarPseudoClass): Ditto.
* css/SelectorChecker.h:
(WebCore): Removed unnecessary Document forward declaration.
(SelectorChecker): Changed constructor declaration, and removed m_document member.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver): Adjusted SelectorChecker initializer accordingly.
(WebCore::StyleResolver::initElement): Changed to use own document accessor.
(WebCore::StyleResolver::initForStyleResolve): Ditto.
(WebCore::StyleResolver::matchUARules): Ditto.
(WebCore::StyleResolver::styleForPage): Ditto.
(WebCore::StyleResolver::applyProperty): Ditto.
(WebCore::StyleResolver::checkForGenericFamilyChange): Ditto.
(WebCore::StyleResolver::initializeFontStyle): Ditto.
(WebCore::StyleResolver::setFontSize): Ditto.
* css/StyleResolver.h:
(WebCore::StyleResolver::document): Changed to use own member.
(WebCore::StyleResolver::documentSettings): Ditto.
(StyleResolver): Added m_document member.
* dom/SelectorQuery.cpp:
(WebCore::SelectorQuery::matches): Changed callsite to reflect new constructor signature.
(WebCore::SelectorQuery::queryAll): Ditto.
(WebCore::SelectorQuery::queryFirst): Ditto.
* html/shadow/ContentSelectorQuery.cpp:
(WebCore::ContentSelectorChecker::ContentSelectorChecker): Ditto.
(WebCore::ContentSelectorQuery::ContentSelectorQuery): Ditto.
* html/shadow/ContentSelectorQuery.h:
(ContentSelectorChecker): Removed unnecessary argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWindows build fix.
weinig@apple.com [Sat, 29 Dec 2012 22:17:42 +0000 (22:17 +0000)]
Windows build fix.

* win/WebKit2Common.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd supplementability to the NetworkProcess
weinig@apple.com [Sat, 29 Dec 2012 21:58:13 +0000 (21:58 +0000)]
Add supplementability to the NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=105838

Reviewed by Dan Bernstein.

This patch adds a NetworkProcessSupplement, which is almost identical to
WebProcessSupplement, but has a different initialization override. It also
stops WebProcessSupplement from inheriting from MessageReceiver (and makes
everything that is a WebProcessSupplement also a MessageReceiver) as keeping
that would cause classes that need to be both WebProcessSupplements and
NetworkProcessSupplements inherit from MessageReceiver twice.

* GNUmakefile.list.am:
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::downloadsAuthenticationManager):
(WebKit::NetworkProcess::initializeNetworkProcess):
* NetworkProcess/NetworkProcess.h:
(WebKit):
(NetworkProcess):
(WebKit::NetworkProcess::supplement):
(WebKit::NetworkProcess::addSupplement):
* Shared/Network/CustomProtocols/CustomProtocolManager.h:
(CustomProtocolManager):
* Shared/Network/NetworkProcessSupplement.h: Added.
(WebKit):
(NetworkProcessSupplement):
(WebKit::NetworkProcessSupplement::~NetworkProcessSupplement):
(WebKit::NetworkProcessSupplement::initialize):
* Target.pri:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/ApplicationCache/WebApplicationCacheManager.h:
* WebProcess/Authentication/AuthenticationManager.h:
* WebProcess/Cookies/WebCookieManager.h:
* WebProcess/Geolocation/WebGeolocationManager.h:
* WebProcess/KeyValueStorage/WebKeyValueStorageManager.h:
* WebProcess/MediaCache/WebMediaCacheManager.h:
* WebProcess/Notifications/WebNotificationManager.h:
* WebProcess/ResourceCache/WebResourceCacheManager.h:
* WebProcess/WebCoreSupport/WebDatabaseManager.h:
* WebProcess/WebProcessSupplement.h:
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Cookies with an IP domain are not being loaded properly into memory
commit-queue@webkit.org [Sat, 29 Dec 2012 19:10:56 +0000 (19:10 +0000)]
[BlackBerry] Cookies with an IP domain are not being loaded properly into memory
https://bugs.webkit.org/show_bug.cgi?id=105859

PR 271597

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-12-29
Reviewed by George Staikos.

The isIP flag isn't persistented in the database. We need to check it
again when we load it into memory.

* platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::getBackingStoreCookies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WebGL] Refactor GLXImplementation.
commit-queue@webkit.org [Sat, 29 Dec 2012 18:11:57 +0000 (18:11 +0000)]
[EFL][WebGL] Refactor GLXImplementation.
https://bugs.webkit.org/show_bug.cgi?id=105825

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-29
Reviewed by Kenneth Rohde Christiansen.

This patch decouples native window management and logic to find surface configuration in GLX implementation.

* platform/graphics/opengl/GLDefs.h:
* platform/graphics/surfaces/glx/GLXConfigSelector.h: Renamed from Source/WebCore/platform/graphics/surfaces/glx/GLXWindowResources.h.
(WebCore):
(GLXConfigSelector):
(WebCore::GLXConfigSelector::GLXConfigSelector):
(WebCore::GLXConfigSelector::~GLXConfigSelector):
(WebCore::GLXConfigSelector::visualInfo):
(WebCore::GLXConfigSelector::pBufferContextConfig):
(WebCore::GLXConfigSelector::surfaceContextConfig):
(WebCore::GLXConfigSelector::reset):
(WebCore::GLXConfigSelector::createConfig):

Helper class to find surface configuration.

* platform/graphics/surfaces/glx/GLXContext.h:
(GLXOffScreenContext):
* platform/graphics/surfaces/glx/GLXSurface.cpp:
(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurface::configuration):
(WebCore::GLXTransportSurface::setGeometry):
(WebCore::GLXTransportSurface::destroy):
(WebCore::GLXPBuffer::GLXPBuffer):
(WebCore::GLXPBuffer::initialize):
(WebCore::GLXPBuffer::configuration):
* platform/graphics/surfaces/glx/GLXSurface.h:
(GLXTransportSurface):
(GLXPBuffer):

Inheritance changed from X11OffScreenWindow to GLPlatformSurface.

* platform/graphics/surfaces/glx/X11WindowResources.cpp:
(WebCore):
(WebCore::X11OffScreenWindow::X11OffScreenWindow):
(WebCore::X11OffScreenWindow::reSizeWindow):
(WebCore::X11OffScreenWindow::createOffscreenWindow):
(WebCore::X11OffScreenWindow::destroyWindow):
(WebCore::X11OffScreenWindow::nativeSharedDisplay):
(WebCore::X11OffScreenWindow::setVisualInfo):
(WebCore::X11OffScreenWindow::isXRenderExtensionSupported):
* platform/graphics/surfaces/glx/X11WindowResources.h:
(WebCore::SharedX11Resources::create):
(SharedX11Resources):
(X11OffScreenWindow):

 Removed code related to surface configiration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Change bug for some inspector tests
commit-queue@webkit.org [Sat, 29 Dec 2012 17:02:21 +0000 (17:02 +0000)]
[GTK] Change bug for some inspector tests
https://bugs.webkit.org/show_bug.cgi?id=105842

Unreviewed gardening.

Bug 43332 was landed. But these tests still fail on GTK port.
And change bug to track the failures.

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2012-12-29

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Mac WK1 Inspector can't save/load timeline data
aroben@webkit.org [Sat, 29 Dec 2012 16:14:21 +0000 (16:14 +0000)]
Web Inspector: Mac WK1 Inspector can't save/load timeline data
https://bugs.webkit.org/show_bug.cgi?id=105547

Reviewed by Pavel Feldman.

* WebCoreSupport/WebInspectorClient.h: Declared new overrides and
member variables necessary for save support.

* WebCoreSupport/WebInspectorClient.mm:
(WebInspectorFrontendClient::save):
(WebInspectorFrontendClient::append):
Implemented these to make saving timeline data work. (It seems to me
the InspectorFrontendClient API could be cleaned up a bit. I had to
look at Chromium source code to determine that I needed to call back
into the InspectorFrontendAPI JS object after saving/appending, and
that I needed to keep a map of passed URLs -> chosen URLs.)

(-[WebInspectorWindowController window:willPositionSheet:usingRect:]):
Tweaked the position of the sheet so that open/save sheets look a
little bette.r

(-[WebInspectorWindowController webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
Implemented to make loading timeline data work.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Timeline] cpu bar popover shows wrong duration / cpu time.
commit-queue@webkit.org [Sat, 29 Dec 2012 12:41:05 +0000 (12:41 +0000)]
Web Inspector: [Timeline] cpu bar popover shows wrong duration / cpu time.
https://bugs.webkit.org/show_bug.cgi?id=105854

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-12-29
Reviewed by Vsevolod Vlasov.

Problem: CPU task indexes are already incremented before written to
data structure.

* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._refreshMainThreadBars):
Use for loop to get correct indexes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Native Memory Instrumentation plugin: do not generate 'not instrumente...
loislo@chromium.org [Sat, 29 Dec 2012 11:38:05 +0000 (11:38 +0000)]
Web Inspector: Native Memory Instrumentation plugin: do not generate 'not instrumented' warning for instrumented mutable members.
https://bugs.webkit.org/show_bug.cgi?id=105855

Reviewed by Vsevolod Vlasov.

Extract MemberExpr from ImplicitCastExpr. It happens when we instrument a mutable member because
addMember expects const T& and the mutable ref to member implicitly converts into const ref to member.

* clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
(ReportMemoryUsageVisitor):
(clang::AddMemberCallVisitor::VisitCallExpr):
(clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
(clang::ReportMemoryUsageVisitor::checkMembersCoverage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Native Memory Instrumentation plugin: move function bodies out of...
loislo@chromium.org [Sat, 29 Dec 2012 10:53:10 +0000 (10:53 +0000)]
Web Inspector: Native Memory Instrumentation plugin: move function bodies out of class declarations.
https://bugs.webkit.org/show_bug.cgi?id=105852

Reviewed by Alexander Pavlov.

* clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
(clang):
(AddMemberCallVisitor):
(ReportMemoryUsageVisitor):
(clang::ReportMemoryUsageAction::ParseArgs):
(clang::AddMemberCallVisitor::VisitCallExpr):
(clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
(clang::ReportMemoryUsageVisitor::emitWarning):
(clang::ReportMemoryUsageVisitor::findInstrumentationMethod):
(clang::ReportMemoryUsageVisitor::needsToBeInstrumented):
(clang::ReportMemoryUsageVisitor::CheckMembersCoverage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Native Memory Instrumentation: instrument not instrumented members.
loislo@chromium.org [Sat, 29 Dec 2012 09:27:01 +0000 (09:27 +0000)]
Web Inspector: Native Memory Instrumentation: instrument not instrumented members.
https://bugs.webkit.org/show_bug.cgi?id=105830

Reviewed by Vsevolod Vlasov.

In some cases we don't want to visit some class members.
As example we decided to skip pointers to interface classes such as GraphicLayerClient.
We could use addWeakPointer for them but it can't be used for nonpointer members.
In the offline discussion we came to a conclusion that we need a new instrumentation
method ignoreMember, which will be used for all the members which we won't like to visit/instrument.

DriveBy: Also I instrumented not yet instrumented members.

Source/WebCore:

* bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperMap::reportMemoryUsage):
* bindings/v8/ScriptWrappable.h:
(WebCore::ScriptWrappable::reportMemoryUsage):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::reportMemoryUsage):
* platform/KURLGoogle.cpp:
(WebCore::KURLGooglePrivate::reportMemoryUsage):
* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::reportMemoryUsage):
* platform/audio/AudioArray.h:
(WebCore::AudioArray::reportMemoryUsage):
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::reportMemoryUsage):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::reportMemoryUsage):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::RowStruct::reportMemoryUsage):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::reportMemoryUsage):
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::reportMemoryUsage):

Source/WTF:

* wtf/MemoryInstrumentation.h:
(MemoryClassInfo):
(WTF::MemoryClassInfo::ignoreMember):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Web Inspector: refactor DefaultTextEditor - annotate handlers and...
commit-queue@webkit.org [Sat, 29 Dec 2012 09:19:35 +0000 (09:19 +0000)]
Source/WebCore: Web Inspector: refactor DefaultTextEditor - annotate handlers and fix getters style
https://bugs.webkit.org/show_bug.cgi?id=105829

Patch by Andrey Lushnikov <lushnikov@chromium.com> on 2012-12-29
Reviewed by Pavel Feldman.

Refactor DefaultTextEditor.js: improve handler method annotations,
remove "get" prefix from method names, get rid of unnecessary
delegation (e.g. see _handleCut).

No new tests: no change in behaviour.

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor):
(WebInspector.DefaultTextEditor.prototype._contextMenu):
(WebInspector.DefaultTextEditor.prototype.selection):
(WebInspector.DefaultTextEditor.prototype.lastSelection):
(WebInspector.DefaultTextEditor.prototype.wasShown):
(WebInspector.DefaultTextEditor.prototype.willHide):
(WebInspector.TextEditorChunkedPanel.prototype.createNewChunk):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype.wasShown):
(WebInspector.TextEditorMainPanel.prototype.willHide):
(WebInspector.TextEditorMainPanel.prototype.populateContextMenu):
(WebInspector.TextEditorMainPanel.prototype.splitChunkOnALine):
(WebInspector.TextEditorMainPanel.prototype.expandChunks):
(WebInspector.TextEditorMainPanel.prototype._paintLineChunks):
(WebInspector.TextEditorMainPanel.prototype.selection):
(WebInspector.TextEditorMainPanel.prototype.lastSelection):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._handleSelectionChange):
(WebInspector.TextEditorMainPanel.prototype._handleTextInput):
(WebInspector.TextEditorMainPanel.prototype.handleKeyDown):
(WebInspector.TextEditorMainPanel.prototype._handleCut):

LayoutTests: Web Inspector: refactor DefaultTextEditor
https://bugs.webkit.org/show_bug.cgi?id=105829

Patch by Andrey Lushnikov <lushnikov@chromium.com> on 2012-12-29
Reviewed by Pavel Feldman.

Fix test to correlate with refactoring of DefaultTextEditor.

* inspector/editor/text-editor-selection.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[webkitpy] Omit webkitpy/thirdparty/BeautifulSoup.py from code coverage checking
zandobersek@gmail.com [Sat, 29 Dec 2012 08:02:50 +0000 (08:02 +0000)]
[webkitpy] Omit webkitpy/thirdparty/BeautifulSoup.py from code coverage checking
https://bugs.webkit.org/show_bug.cgi?id=105835

Reviewed by Dirk Pranke.

The BeautifulSoup module is a third-party import and as such we don't have much control
over its testing. Because of that it should be omitted from code coverage checking.

* Scripts/webkitpy/test/main.py:
(Tester._run_tests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION: r138555 asserts on Linux EFL/Qt debug builds
commit-queue@webkit.org [Sat, 29 Dec 2012 05:42:38 +0000 (05:42 +0000)]
REGRESSION: r138555 asserts on Linux EFL/Qt debug builds
https://bugs.webkit.org/show_bug.cgi?id=105848

Unreviewed test fix.

Patch by No'am Rosenthal <noam@webkit.org> on 2012-12-28

* platform/graphics/texmap/TextureMapperShaderManager.cpp:
    Added parameter name to noop shader.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] MiniBrowser could not be launched on specific machine
ryuan.choi@samsung.com [Sat, 29 Dec 2012 05:30:37 +0000 (05:30 +0000)]
[EFL][WK2] MiniBrowser could not be launched on specific machine
https://bugs.webkit.org/show_bug.cgi?id=105844

Reviewed by Gyuyoung Kim.

* UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
(WebKit::ProcessLauncher::launchProcess):
Modified to avoid bad use of temporary object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Texmap] Use a transform uniform instead of u_flip/u_textureSize
commit-queue@webkit.org [Sat, 29 Dec 2012 05:10:22 +0000 (05:10 +0000)]
[Texmap] Use a transform uniform instead of u_flip/u_textureSize
https://bugs.webkit.org/show_bug.cgi?id=105809

Patch by No'am Rosenthal <noam@webkit.org> on 2012-12-28
Reviewed by Martin Robinson.

In order to support tiled-patterns, we'd have to apply texture-space transformations in the
vertex shader.
This patch cleans up the current texture-space transformations, and uses
single matrix uniform instead of the current uniforms.

No new tests, refactor only.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawTexturedQuadWithProgram):
* platform/graphics/texmap/TextureMapperShaderManager.cpp:
(WebCore):
* platform/graphics/texmap/TextureMapperShaderManager.h:
(TextureMapperShaderProgram):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Texmap] Edge antialiasing in TextureMapper could be done with less per-pixel calls
commit-queue@webkit.org [Sat, 29 Dec 2012 03:05:32 +0000 (03:05 +0000)]
[Texmap] Edge antialiasing in TextureMapper could be done with less per-pixel calls
https://bugs.webkit.org/show_bug.cgi?id=105377

Patch by No'am Rosenthal <noam@webkit.org> on 2012-12-28
Reviewed by Kenneth Rohde Christiansen.

Instead of passing 8 quad edge coefficients as uniforms and analyze the distance in the
fragment shader, we render the antialiased quad as 4 edge triangles, which originate in the
center of the quad.

The vertex shader expands the quad based on the screen transform, and applies a value to each vertex to be interpolated by the GPU.

It is very difficult to test performance gain; However, the following is apparent:
- The matrix multiplications and inversions done before in the quad inflation code were
  always visible in instruments/valgrind and they are now gone.
- We now perform a single smoothstep() command per pixel instead of 8 clamp(dot()) commands.
- It should now be possible to antialias individual edges.

Covered by existing tests.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGLData::getStaticVBO):
    Cache the unit-rect and edge-triangle vertex data in a VBO.

(WebCore::TextureMapperGLData::~TextureMapperGLData):
    Clear the cached VBOs upon destruction.

(WebCore::TextureMapperGL::drawBorder):
(WebCore::TextureMapperGL::drawTexture):
    Removed call to useProgram, since it's already called in drawTexturedQuadWithProgram.

(WebCore::TextureMapperGL::drawTexturedQuadWithProgram):
(WebCore::TextureMapperGL::drawSolidColor):
    Use the new signature "draw" instead of "drawQuad".

(WebCore::TextureMapperGL::drawEdgeTriangles):
(WebCore::TextureMapperGL::drawUnitRect):
(WebCore::TextureMapperGL::draw):
    Removed DrawQuad, instead draw either a unit rect or edge triangles.

(WebCore::TextureMapperGL::beginClip):
    Use the new setMatrix function.

* platform/graphics/texmap/TextureMapperGL.h:
    Added a paint flag for antialiasing.

* platform/graphics/texmap/TextureMapperShaderManager.cpp:
(WebCore::TextureMapperShaderProgram::setMatrix):
    Since we now set the matrix in multiple locations, added a convenience
    function for matrix uniform.

(WebCore::getShaderSpec):
    Update the vertex and fragment shader to account for the new antialiasing
    mechanism.
* platform/graphics/texmap/TextureMapperShaderManager.h:
(TextureMapperShaderProgram):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Implement ewk_context_resource_cache_clear
joone.hur@intel.com [Sat, 29 Dec 2012 02:25:34 +0000 (02:25 +0000)]
[EFL][WK2] Implement ewk_context_resource_cache_clear
https://bugs.webkit.org/show_bug.cgi?id=104782

The purpose of this API is to clear HTTP caches in local storage and
all resources cached in memory such as images, CSS, JavaScript, XSL,
and fonts.

Reviewed by Kenneth Rohde Christiansen.

* UIProcess/API/efl/ewk_context.cpp:
(EwkContext::clearResourceCache): Call WebResourceCacheManager::ClearCacheForAllOrigins.
(ewk_context_resource_cache_clear):
* UIProcess/API/efl/ewk_context.h: Add ewk_context_resource_cache_clear.
* UIProcess/API/efl/ewk_context_private.h:
(EwkContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove logic for extracting the OS X marketing version in to WebCore
mrowe@apple.com [Sat, 29 Dec 2012 02:05:38 +0000 (02:05 +0000)]
Move logic for extracting the OS X marketing version in to WebCore
<http://webkit.org/b/105841> / <rdar://problem/10736041>

Reviewed by Dan Bernstein.

Source/WebCore:

The logic for extracting the OS X markerting version is moved in to systemMarketingVersion
from WebKitSystemInterface (post-10.8) and WebKit (pre-10.8).

* WebCore.exp.in: Export systemMarketingVersion and remove the old WKSI symbol.
* WebCore.xcodeproj/project.pbxproj: Add the new files.
* platform/mac/SystemVersionMac.h: Added.
* platform/mac/SystemVersionMac.mm: Added.
(WebCore::createSystemMarketingVersion): Read the marketing version out of SystemVersion.plist
(WebCore::callGestalt):
(WebCore::createSystemMarketingVersion): Build the marketing version by piecing together the results
of calls to Gestalt.
(WebCore::systemMarketingVersion): Return the cached string.
* platform/mac/WebCoreSystemInterface.h: Remove the old WKSI symbol.
* platform/mac/WebCoreSystemInterface.mm: Ditto.

Source/WebKit/mac:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Remove the code related to the WKSI symbol.
* WebView/WebView.mm:
(systemMarketingVersionForUserAgentString): Call the WebCore function instead of the WKSI function.
(+[WebView _standardUserAgentWithApplicationName:]): Retain the result now that our helper doesn't
do that for us.

Source/WebKit2:

* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::systemMarketingVersionForUserAgentString): Call the WebCore function instead
of the WKSI function.
(WebKit::WebPageProxy::standardUserAgent):
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Remove the code related to the WKSI symbol.

WebKitLibraries:

* WebKitSystemInterface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed rebaseline.
fsamuel@chromium.org [Sat, 29 Dec 2012 00:29:47 +0000 (00:29 +0000)]
Unreviewed rebaseline.

* platform/chromium-win-xp/inspector/extensions/extensions-resources-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed updated test expectations
fsamuel@chromium.org [Sat, 29 Dec 2012 00:10:36 +0000 (00:10 +0000)]
Unreviewed updated test expectations

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed updated TestExpectations. Mark test as fail on XP only.
fsamuel@chromium.org [Fri, 28 Dec 2012 23:51:17 +0000 (23:51 +0000)]
Unreviewed updated TestExpectations. Mark test as fail on XP only.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Templates]: Fix assert in colgroup parse handling
fsamuel@chromium.org [Fri, 28 Dec 2012 23:32:07 +0000 (23:32 +0000)]
[Templates]: Fix assert in colgroup parse handling
https://bugs.webkit.org/show_bug.cgi?id=105837

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2012-12-28
Reviewed by Eric Seidel.

* html5lib/resources/template.dat:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRoll Chromium DEPS to r174739
fsamuel@chromium.org [Fri, 28 Dec 2012 22:03:20 +0000 (22:03 +0000)]
Roll Chromium DEPS to r174739
https://bugs.webkit.org/show_bug.cgi?id=105813

Unreviewed.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix assert seen when adding a custom protocol handler before an initial
weinig@apple.com [Fri, 28 Dec 2012 21:48:30 +0000 (21:48 +0000)]
Fix assert seen when adding a custom protocol handler before an initial
web process has been created.

* UIProcess/WebContext.h:
(WebKit::WebContext::sendToNetworkingProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Templates]: Fix assert in colgroup parse handling
rafaelw@chromium.org [Fri, 28 Dec 2012 21:07:30 +0000 (21:07 +0000)]
[Templates]: Fix assert in colgroup parse handling
https://bugs.webkit.org/show_bug.cgi?id=105837

Reviewed by Eric Seidel.

Source/WebCore:

Tests added to html5lib.

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processEndTag):

LayoutTests:

* html5lib/resources/template.dat:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GStreamer] GstMessage handler in AudioDestination
philn@webkit.org [Fri, 28 Dec 2012 21:04:18 +0000 (21:04 +0000)]
[GStreamer] GstMessage handler in AudioDestination
https://bugs.webkit.org/show_bug.cgi?id=105292

Reviewed by Martin Robinson.

Handle GStreamer warnings and errors coming from the playback
pipeline. For now we only display warnings on the console.

* platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::messageCallback):
(WebCore):
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::finishBuildingPipelineAfterWavParserPadReady):
(WebCore::AudioDestinationGStreamer::handleMessage):
* platform/audio/gstreamer/AudioDestinationGStreamer.h:
(AudioDestinationGStreamer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][WK2] Add support for IME Composition
mrobinson@webkit.org [Fri, 28 Dec 2012 20:32:06 +0000 (20:32 +0000)]
[GTK][WK2] Add support for IME Composition
https://bugs.webkit.org/show_bug.cgi?id=65093

Reviewed by Carlos Garcia Campos.

Source/WebCore:

No new tests. The GtkInputMethodFilter is covered by unit tests in TestWebKitAPI.
Doing functional tests for this behavior is much more complex.

* platform/gtk/GtkInputMethodFilter.cpp:
(WebCore::GtkInputMethodFilter::sendCompositionAndPreeditWithFakeKeyEvents): Now
pass along whether or not an event was faked.
* platform/gtk/GtkInputMethodFilter.h: Ditto.

Source/WebKit/gtk:

Update the method signatures for concrete WebKit1 implementation of
the GtkInputMethodFilter.

* WebCoreSupport/WebViewInputMethodFilter.cpp:
(WebKit::WebViewInputMethodFilter::sendSimpleKeyEvent):
(WebKit::WebViewInputMethodFilter::sendKeyEventWithCompositionResults):
* WebCoreSupport/WebViewInputMethodFilter.h:
(WebViewInputMethodFilter):

Source/WebKit2:

Add a WebKit2 implementation of the GtkInputMethodFilter and provide
the necessary plumbing to pass composition information along with
input method events.

* GNUmakefile.list.am: Add new files to the source list.
* Shared/EditorState.cpp: The cursorRect is now passed for GTK+ as well as
Qt, so update the encode and decode methods to pass that along.
* Shared/EditorState.h: Add the cursorRect member for GTK+ as well.
* Shared/NativeWebKeyboardEvent.h:
(NativeWebKeyboardEvent): Keyboard events should also have knowledge of
the compositionResults and whether or not the event was faked for composition
purposes.
* Shared/gtk/NativeWebKeyboardEventGtk.cpp: Ditto.
* Shared/gtk/WebEventFactory.cpp:
(WebKit::WebEventFactory::createWebKeyboardEvent): Copy the logic of PlatformKeyEvent,
for properly setting the windows key code and the event text from the composition
results.
* Shared/gtk/WebEventFactory.h: The createWebKeyboardEvent factory now takes a
CompositionResults argument.
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::doneWithKeyEvent): Don't forward keyboard events that
were faked for composition reasons. These events originated from WebKit and should
never be passed to parent classes.
(WebKit::PageClientImpl::updateTextInputState): Plumb through the updateTextInputState
method to the WebViewBase.
* UIProcess/API/gtk/PageClientImpl.h:
(PageClientImpl): Add a updateTextInputState method.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(_WebKitWebViewBasePrivate): Instead of having an input method context as a member
keep a WebViewBaseInputMethodFilter.
(webkitWebViewBaseRealize): Set the filter widget when the WebViewBase is realized.
(webkit_web_view_base_init): No longer create a input method context during init.
(webkitWebViewBaseFocusInEvent): Pass along focus in events to the filter.
(webkitWebViewBaseFocusOutEvent): Pass along focus out events to the filter.
(webkitWebViewBaseKeyPressEvent): Instead of passing key presses directly to the WebProcess,
filter them through the input method filter.
(webkitWebViewBaseKeyReleaseEvent): Ditto.
(webkitWebViewBaseButtonPressEvent): Notify the input method filter about button press events.
(webkitWebViewBaseGetIMContext): The input method filter owns the input method now.
(webkitWebViewBaseSetInputMethodState): Add a bit of plumbing for the PageClient.
(webkitWebViewBaseUpdateTextInputState): Ditto.
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Add plumbing declarations.
* UIProcess/API/gtk/WebViewBaseInputMethodFilter.cpp: Added. An implementation of GtkInputMethodFilter for WebKit2.
* UIProcess/API/gtk/WebViewBaseInputMethodFilter.h: Copied from Source/WebKit/gtk/WebCoreSupport/WebViewInputMethodFilter.h.
* UIProcess/PageClient.h:
(PageClient): updateInputMethod state is now for both Qt and GTK+.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::editorStateChanged): Pass the editor state for GTK+ as well as Qt.
(WebKit::WebPageProxy::setComposition): Moved this method from WebPageProxyQt as it's used for GTK+ now as well.
(WebKit::WebPageProxy::confirmComposition): Ditto.
(WebKit::WebPageProxy::cancelComposition): Ditto.
* UIProcess/WebPageProxy.h:
(WebPageProxy): The setInputMethodState message is for GTK+ as well as Qt now.
* UIProcess/WebPageProxy.messages.in: Ditto.
* UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::setInputMethodState): Ditto.
* UIProcess/qt/WebPageProxyQt.cpp: Move some methods to the platform-independent file.
* WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp: More closely match the WebKit1
logic for dealing with key events so that composition events will be handled properly.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState): Properly pass the cursorRect for GTK+.
(WebKit::targetFrameForEditing): Moved from the Qt file, because its used by GTK+ as well. They
now pass along the updated EditorState as well, just like the Mac versions.
(WebKit::WebPage::confirmComposition): Ditto.
(WebKit::WebPage::setComposition): Ditto.
(WebKit::WebPage::cancelComposition): Ditto.
* WebProcess/WebPage/WebPage.h: The above messages are now for GTK+ as well as Qt.
* WebProcess/WebPage/WebPage.messages.in: Ditto.
* WebProcess/WebPage/qt/WebPageQt.cpp: Moved some methods to the platform-independent file.

Tools:

Update unit tests for GtkInputMethodFilter to note whether or not an event
was a fake event synthesized for composition purposes. This is now used
for WebKit2.

* TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
(TestWebKitAPI::TestInputMethodFilter::sendSimpleKeyEvent):
(TestWebKitAPI::TestInputMethodFilter::sendKeyEventWithCompositionResults):
(TestWebKitAPI::TEST):
* gtk/generate-gtkdoc:
(get_webkit2_options): Skip new files in the WebKit2 source directory for documentation
generation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r138196): Regions with text-overflow: ellipsis; are being ellipsized...
eae@chromium.org [Fri, 28 Dec 2012 18:32:08 +0000 (18:32 +0000)]
REGRESSION (r138196): Regions with text-overflow: ellipsis; are being ellipsized unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=105600

Source/WebCore:

Reviewed by Darin Adler.

Pixel-snap lineBoxEdge before comparing with the block edge as
the lineBox edge isn't guaranteed to be snapped to device pixels
on all platforms.

Test: fast/sub-pixel/ellipsis-table.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::checkLinesForTextOverflow):

LayoutTests:

Reviewed by Darin Adler.

Add test for text-overflow: ellipsis inside a table.

* fast/sub-pixel/ellipsis-table-expected.html: Added.
* fast/sub-pixel/ellipsis-table.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] DrawingBuffer initialization loop breaks if completely out of memory
commit-queue@webkit.org [Fri, 28 Dec 2012 17:45:18 +0000 (17:45 +0000)]
[chromium] DrawingBuffer initialization loop breaks if completely out of memory
https://bugs.webkit.org/show_bug.cgi?id=105732

Patch by Brandon Jones <bajones@chromium.org> on 2012-12-28
Reviewed by Kenneth Russell.

When DrawingBuffer allocation fails because s_currentResourceUsePixels is maxed out
it now forces WebGLRenderingContext creation to fail gracefully.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::create): On Chromium, check for failure to allocate a DrawingBuffer

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSlightly clean up WebCore's Base.xcconfig
mitz@apple.com [Fri, 28 Dec 2012 17:02:29 +0000 (17:02 +0000)]
Slightly clean up WebCore's Base.xcconfig
https://bugs.webkit.org/show_bug.cgi?id=105808

Reviewed by Sam Weinig.

* Configurations/Base.xcconfig: Simplify the definition of GCC_GENERATE_DEBUGGING_SYMBOLS,
which is always YES.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed rebaseline
fsamuel@chromium.org [Fri, 28 Dec 2012 16:52:57 +0000 (16:52 +0000)]
Unreviewed rebaseline

* platform/chromium-win-xp/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Remove unused BackingStorePrivate::m_defersBlit
charles.wei@torchmobile.com.cn [Fri, 28 Dec 2012 16:49:39 +0000 (16:49 +0000)]
[BlackBerry] Remove unused BackingStorePrivate::m_defersBlit
https://bugs.webkit.org/show_bug.cgi?id=105811
RIM PR 272067

Reviewed by George Staikos.
Internally Reviewed by Jakob Petsovits.

BackingStorePrivate::m_defersBlit is not used anywhere, it should
be removed to simplify the code and to avoid confusion.
* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
* Api/BackingStore.h:
* Api/BackingStore_p.h:
(BackingStorePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138539 268f45cc-cd09-0410-ab3c-d52691b4dbfc