WebKit-https.git
7 years agoRubber-banding should not affect the visibleRect of the TileCache
simon.fraser@apple.com [Wed, 20 Feb 2013 01:29:39 +0000 (01:29 +0000)]
Rubber-banding should not affect the visibleRect of the TileCache
https://bugs.webkit.org/show_bug.cgi?id=110278

Reviewed by Beth Dakin.

When rubber-banding a slow-scrolling page, or image document, we would constantly re-create
the bottom tile because of the logic that adapts the tile size to the visible rect when slow
scrolling.

Avoid that by ensuring that the visibleRect is not affected by rubber-banding. This is done
via a GraphicsLayerClient function that allows RenderLayerCompositor to provide a custom
position for the scroll layer. We constrain that scroll position to remove the overhang that
results from rubber-banding.

I wasn't able to make a test for this, even with internals.setScrollViewPosition().

* platform/graphics/GraphicsLayerClient.h:
(GraphicsLayerClient):
(WebCore::GraphicsLayerClient::customPositionForVisibleRectComputation):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::computeVisibleRect):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::customPositionForVisibleRectComputation):
* rendering/RenderLayerCompositor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, force file to recompile to fix win build.
tony@chromium.org [Wed, 20 Feb 2013 01:24:49 +0000 (01:24 +0000)]
Unreviewed, force file to recompile to fix win build.

* WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix crash in preloading scanning base tags with no href attribute for background...
tonyg@chromium.org [Wed, 20 Feb 2013 01:20:48 +0000 (01:20 +0000)]
Fix crash in preloading scanning base tags with no href attribute for background parser
https://bugs.webkit.org/show_bug.cgi?id=110276

Reviewed by Eric Seidel.

Previously a <base> tag without an href attribute (like the one in fast/dom/HTMLAnchorElement/set-href-attribute-rebase.html)
would crash the background parser's preload scanner.

To fix that, we only call stripLeadingAndTrailingHTMLSpaces() if the href attribute is non-null. This matches the main thread parser.

Along with this, I decided to templatize updatePredictedBaseURL() so that the main and background parser can share the same impl.

This required making CompactHTMLToken and HTMLToken a little more similar:
1. Give HTMLToken a getAttributeItem() method.
2. Move CompactAttribute to CompactHTMLToken::Attribute and make it a struct.

No new tests because covered by existing tests.

* html/parser/AtomicHTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
* html/parser/CompactHTMLToken.cpp:
(SameSizeAsCompactHTMLToken):
(WebCore::CompactHTMLToken::CompactHTMLToken):
(WebCore::CompactHTMLToken::getAttributeItem):
(WebCore::CompactHTMLToken::isSafeToSendToAnotherThread):
* html/parser/CompactHTMLToken.h:
(WebCore::CompactHTMLToken::Attribute::Attribute):
(Attribute):
(WebCore::CompactHTMLToken::attributes):
(CompactHTMLToken):
(WebCore::CompactHTMLToken::publicIdentifier):
(WebCore::CompactHTMLToken::systemIdentifier):
* html/parser/HTMLParserIdioms.h:
(WebCore):
(WebCore::stripLeadingAndTrailingHTMLSpaces):
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(WebCore):
(WebCore::TokenPreloadScanner::updatePredictedBaseURL):
* html/parser/HTMLPreloadScanner.h:
* html/parser/HTMLToken.h:
(WebCore::HTMLToken::getAttributeItem):
(HTMLToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, include exports for VS2010 as well.
tony@chromium.org [Wed, 20 Feb 2013 01:18:24 +0000 (01:18 +0000)]
Unreviewed, include exports for VS2010 as well.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIntroducing AbstractSQLTransaction and AbstractSQLTransactionBackend.
mark.lam@apple.com [Wed, 20 Feb 2013 00:48:25 +0000 (00:48 +0000)]
Introducing AbstractSQLTransaction and AbstractSQLTransactionBackend.
https://bugs.webkit.org/show_bug.cgi?id=110273.

Reviewed by Anders Carlsson.

This is part of the webdatabase refactoring for webkit2.
- Also changed the frontend and backend to only refer to the
  abstract interface of each other.

No new tests.

* Modules/webdatabase/AbstractSQLTransaction.h: Added.
(AbstractSQLTransaction):
(WebCore::AbstractSQLTransaction::~AbstractSQLTransaction):
* Modules/webdatabase/AbstractSQLTransactionBackend.h: Added.
(AbstractSQLTransactionBackend):
(WebCore::AbstractSQLTransactionBackend::~AbstractSQLTransactionBackend):
* Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::hasCallback):
(WebCore::SQLTransaction::hasSuccessCallback):
(WebCore::SQLTransaction::hasErrorCallback):
(WebCore::SQLTransaction::setBackend):
* Modules/webdatabase/SQLTransaction.h:
(SQLTransaction):
* Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::create):
(WebCore::SQLTransactionBackend::SQLTransactionBackend):
* Modules/webdatabase/SQLTransactionBackend.h:
(SQLTransactionBackend):
* Modules/webdatabase/SQLTransactionStateMachine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSilence some analyzer warnings
oliver@apple.com [Wed, 20 Feb 2013 00:47:52 +0000 (00:47 +0000)]
Silence some analyzer warnings
https://bugs.webkit.org/show_bug.cgi?id=110281

Reviewed by Mark Hahnenberg.

The static analyzer believes that callerCodeBlock can be null,
based on other code performing null tests.  This should not
ever be the case, but we'll add RELEASE_ASSERTs to make it
obvious if we're ever wrong.

* interpreter/Interpreter.cpp:
(JSC::getCallerInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChange computeStickyPositionConstraints to use LayoutBoxExtent for margins
eae@chromium.org [Wed, 20 Feb 2013 00:45:40 +0000 (00:45 +0000)]
Change computeStickyPositionConstraints to use LayoutBoxExtent for margins
https://bugs.webkit.org/show_bug.cgi?id=108872

Reviewed by Levi Weintraub.

Change RenderBoxModelObject::computeStickyPositionConstraints to
use a LayoutBoxExtent to represent margins.

No new tests, no change in functionality.

* platform/graphics/LayoutRect.h:
(WebCore::LayoutRect::contract):
Add version contract methods that takes a LayoutBoxExtent object.

* platform/graphics/LayoutSize.h:
(WebCore::LayoutSize::shrink):
Add shrink method.

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::computeStickyPositionConstraints):
Change to use a LayoutBoxExtent object to represent margins.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, fix the Windows build after r143398.
tony@chromium.org [Wed, 20 Feb 2013 00:45:09 +0000 (00:45 +0000)]
Unreviewed, fix the Windows build after r143398.
Add new setters to the export list.

* WebKit.vcproj/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't force everything to be blinded in debug builds
oliver@apple.com [Wed, 20 Feb 2013 00:42:22 +0000 (00:42 +0000)]
Don't force everything to be blinded in debug builds
https://bugs.webkit.org/show_bug.cgi?id=110279

Reviewed by Mark Hahnenberg.

Switch to an explicit flag for indicating that we want
every constant to be blinded.

* assembler/MacroAssembler.h:
(JSC::MacroAssembler::shouldBlind):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDisable ASSERT(!hasInsertionPoint()) for background parser
tonyg@chromium.org [Wed, 20 Feb 2013 00:35:51 +0000 (00:35 +0000)]
Disable ASSERT(!hasInsertionPoint()) for background parser
https://bugs.webkit.org/show_bug.cgi?id=110251

Reviewed by Adam Barth.

The background parser crashes about 10 layout tests by hitting ASSERT(!hasInsertionPoint()).
Now, finish() is the thing that closes the HTMLInputStream which removes the insertion point.
In these tests, a document.open() calls insert() which clears the HTMLInputStream which causes
there to be an insertion point again.

With the main thread parser, insert() is called before finish() so the ASSERT passes.
However, with the threaded parser, finish() is called before insert(), so we fail the ASSERT.

This patch disables the ASSERT for the background parser because m_input isn't really relevant.
This causes us to pass the tests. However, there is a risk that now hasInsertionPoint() may be incorrect
and Document has a non-debug branch that tests hasInsertionPoint().

No new tests because covered by existing tests.

* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::prepareToStopParsing):
(WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Add myself to watch lists.
esprehn@chromium.org [Wed, 20 Feb 2013 00:34:16 +0000 (00:34 +0000)]
Unreviewed. Add myself to watch lists.

* Scripts/webkitpy/common/config/committers.py:
* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, corrected primary email.
hmuller@adobe.com [Wed, 20 Feb 2013 00:26:45 +0000 (00:26 +0000)]
Unreviewed, corrected primary email.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSeparate constraining for overhang from fixed-position zooming behavior in scrollOffs...
simon.fraser@apple.com [Wed, 20 Feb 2013 00:25:06 +0000 (00:25 +0000)]
Separate constraining for overhang from fixed-position zooming behavior in scrollOffsetForFixedPosition()
https://bugs.webkit.org/show_bug.cgi?id=110267

Reviewed by Beth Dakin.

The static scrollOffsetForFixedPosition() function in ScrollingCoordinator did two things;
it constrained the scroll position when rubber-banding, and applied the special scaling for
fixed position when zoomed.

Separate these out so that we can use the rubber-banding constrained elsewhere.

* page/FrameView.cpp:
(WebCore::FrameView::scrollOffsetForFixedPosition): The static function is here now.
* page/FrameView.h:
* page/scrolling/ScrollingCoordinator.cpp: Code moved to FrameView.
* page/scrolling/ScrollingCoordinator.h:
* page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition): scrollOffsetForFixedPosition()
is now on FrameView.
* platform/ScrollableArea.cpp:
(WebCore::constrainedScrollPosition): Helper to constrain one axis for overhang.
(WebCore::ScrollableArea::constrainScrollPositionForOverhang): Static function that
can be called by FrameView::scrollOffsetForFixedPosition().
* platform/ScrollableArea.h: Static function constrainScrollPositionForOverhang()
so we can call it from another thread. Also a member fuction of the same name, which takes
the scrollPosition as input (so we can feed it a layer position in a later patch).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r143382 and r143401.
enne@google.com [Wed, 20 Feb 2013 00:20:29 +0000 (00:20 +0000)]
Unreviewed, rolling out r143382 and r143401.
http://trac.webkit.org/changeset/143382
http://trac.webkit.org/changeset/143401
https://bugs.webkit.org/show_bug.cgi?id=106457

Breaks Chromium win/mac canary compilation

Source/Platform:

* chromium/public/Platform.h:

Source/WebKit/chromium:

* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::idbFactory):
(WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix checkThatTokensAreSafeToSendToAnotherThread() now that the preload scanner is...
tonyg@chromium.org [Wed, 20 Feb 2013 00:15:23 +0000 (00:15 +0000)]
Fix checkThatTokensAreSafeToSendToAnotherThread() now that the preload scanner is enabled
https://bugs.webkit.org/show_bug.cgi?id=110258

Reviewed by Adam Barth.

We were hitting this ASSERT on numerous tests with the background parser enabled. This copy fixes the assertion.

No new tests becuase covered by existing tests.

* html/parser/HTMLResourcePreloader.h:
(WebCore::PreloadRequest::setCharset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Move WebKitPlatformSupport declaration to Platform.h
pilgrim@chromium.org [Wed, 20 Feb 2013 00:14:25 +0000 (00:14 +0000)]
[Chromium] Move WebKitPlatformSupport declaration to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=110262

Reviewed by Adam Barth.

In preparation for removing WebKitPlatformSupport.h entirely (once
downstream references to that file have been updated). Part of a
larger refactoring series; see tracking bug 82948.

Source/Platform:

* chromium/public/Platform.h:
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):
(WebKit):

Source/WebKit/chromium:

* public/platform/WebKitPlatformSupport.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMoar hardening
oliver@apple.com [Wed, 20 Feb 2013 00:13:26 +0000 (00:13 +0000)]
Moar hardening
https://bugs.webkit.org/show_bug.cgi?id=110275

Reviewed by Anders Carlsson.

We now poison objects when they get freed, and verify that
any object that is being freed is not poisoned.  If the
object looks like it's poisoned we validate the freelist,
and ensure the object is not already present.  If it is
we crash.

On allocation, we ensure that the object being allocated
is poisoned, then clear the poisoning fields.

* wtf/FastMalloc.cpp:
(WTF::internalEntropyValue):
(WTF):
(WTF::freedObjectStartPoison):
(WTF::freedObjectEndPoison):
(TCMalloc_ThreadCache_FreeList):
(WTF::TCMalloc_ThreadCache_FreeList::Validate):
(WTF::TCMalloc_Central_FreeList::Populate):
(WTF::TCMalloc_ThreadCache::Allocate):
(WTF::TCMalloc_ThreadCache::Deallocate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix typo: inititatorFor->initiatorFor
tonyg@chromium.org [Tue, 19 Feb 2013 23:58:25 +0000 (23:58 +0000)]
Fix typo: inititatorFor->initiatorFor
https://bugs.webkit.org/show_bug.cgi?id=110260

Reviewed by Adam Barth.

No new tests because no changed functionality.

* html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::initiatorFor):
(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
* html/parser/HTMLPreloadScanner.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert 3 settings to use Settings.in
tony@chromium.org [Tue, 19 Feb 2013 23:38:15 +0000 (23:38 +0000)]
Convert 3 settings to use Settings.in
https://bugs.webkit.org/show_bug.cgi?id=109875

Reviewed by Ryosuke Niwa.

Source/WebCore:

Convert mediaEnabled, applicationChromeMode and DOMPasteAllowed to
use Settings.in. They previously had inconsistently named setters.

No new tests, this is a refactoring.

* Source/WebCore/WebCore.exp.in: Remove symbols that are now inlined from exports.
* Source/WebCore/WebCore.order: Remove symbols that no longer exist.
* dom/make_names.pl:
(printConstructorInterior): Rename isMediaEnabled to mediaEnabled.
(printWrapperFunctions): Rename isMediaEnabled to mediaEnabled.
* editing/EditorCommand.cpp:
(WebCore::supportedPaste): Rename isDOMPasteAllowed to DOMPasteAllowed.
* page/Settings.cpp:
(WebCore::Settings::Settings): Remove custom code.
* page/Settings.h:
(Settings): Remove custom code.
* page/Settings.in: Add entries for mediaEnabled, applicationChromeMode and DOMPasteAllowed.
* page/make_settings.pl:
(setterFunctionName): Expand uppercase rules to include DOM.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isDefault): Rename inApplicationChromeMode to applicationChromeMode.
* rendering/RenderThemeWin.cpp:
(WebCore::documentIsInApplicationChromeMode): Rename inApplicationChromeMode to applicationChromeMode.

Source/WebKit/efl:

* ewk/ewk_view.cpp:
(_ewk_view_priv_new): Rename isDOMPasteAllowed to DOMPasteAllowed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Grid Layout] Refactor the code in preparation of auto placement support
jchaffraix@webkit.org [Tue, 19 Feb 2013 23:34:33 +0000 (23:34 +0000)]
[CSS Grid Layout] Refactor the code in preparation of auto placement support
https://bugs.webkit.org/show_bug.cgi?id=110244

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/css-grid-layout/grid-auto-flow-resolution.html

In order to support auto placement, we need to iterate over the grid items with
auto row / column several times. This changes makes us do that in a very simple,
not-yet-conformant way. While touching this code, the distinction between grid-auto-flow
none and row / column was better drawn (and enforced).

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::resolveGridPositionFromStyle):
Made it illegal to call resolveGridPositionFromStyle if the grid track is auto and
grid-auto-flow is not none. This would catch bad use of the function.

(WebCore::RenderGrid::maximumIndexInDirection):
Updated to bail out if the grid track is auto. Also improved the comment.

(WebCore::RenderGrid::placeItemsOnGrid):
Updated the function to do several iterations. Also handled the grid-auto-flow: none
case differently as it shouldn't need the extra iteration(s).

LayoutTests:

* fast/css-grid-layout/grid-auto-flow-resolution-expected.txt: Added.
* fast/css-grid-layout/grid-auto-flow-resolution.html: Added.
* fast/css-grid-layout/implicit-position-dynamic-change.html:
* fast/css-grid-layout/resources/grid.css:
(.autoRowAutoColumn):
(.firstRowAutoColumn):
(.secondRowAutoColumn):
(.thirdRowAutoColumn):
(.autoRowFirstColumn):
(.autoRowSecondColumn):
(.autoRowThirdColumn):
Added these helper classes, some will be used in a follow-up patch.

(.sizedToGridArea):
Hoisted this class into the common style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStorageAreaProxy should know its quota
andersca@apple.com [Tue, 19 Feb 2013 23:31:58 +0000 (23:31 +0000)]
StorageAreaProxy should know its quota
https://bugs.webkit.org/show_bug.cgi?id=110268

Reviewed by Sam Weinig.

Begin stubbing out StorageAreaProxy::setItem and add some quota member variables.

* WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::StorageAreaProxy):
(WebKit::StorageAreaProxy::setItem):
* WebProcess/Storage/StorageAreaProxy.h:
(StorageAreaProxy):
* WebProcess/Storage/StorageNamespaceProxy.cpp:
(WebKit::StorageNamespaceProxy::createSessionStorageNamespace):
(WebKit::StorageNamespaceProxy::StorageNamespaceProxy):
* WebProcess/Storage/StorageNamespaceProxy.h:
(WebKit::StorageNamespaceProxy::quota):
(StorageNamespaceProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[New Multicolumn] REGRESSION: RenderMultiColumnSets broken by the RenderRegion -...
hyatt@apple.com [Tue, 19 Feb 2013 23:23:39 +0000 (23:23 +0000)]
[New Multicolumn] REGRESSION: RenderMultiColumnSets broken by the RenderRegion -> RenderBlock subclassing.
https://bugs.webkit.org/show_bug.cgi?id=110239.

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/multicol/newmulticol/column-rules-fixed-height.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::columnRectAt):
Make sure the columnGap() in the old multicolumn code is always expressed as a LayoutUnit. This was the
one place where it was still an int.

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::paintFlowThreadPortionInRegion):
Rework the painting of flow thread portions to account for the fact that regions paint at an integral
translation. This means you have to construct clipping around that integral destination. Subpixel layout
regions did not clip correctly as a result of this issue.

* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::columnRectAt):
Fix the same bug with columnGap() that the old column code has, i.e., one spot where it was an int.

(WebCore::RenderMultiColumnSet::paintObject):
RenderMultiColumnSet should be using paintObject and not paint and it needs to check for visibility
and phases now that it is a RenderBlock subclass.

(WebCore::RenderMultiColumnSet::paintColumnRules):
Fix the bug that Opera guys fixed in the old multi-column code. They didn't patch the new code, so this
takes care of that.

* rendering/RenderMultiColumnSet.h:
(RenderMultiColumnSet):
Change to use paintObject instead of paint.

LayoutTests:

* fast/multicol/newmulticol: Added.
* fast/multicol/newmulticol/column-rules-fixed-height-expected.html: Added.
* fast/multicol/newmulticol/column-rules-fixed-height.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix indentation of Opcode.h
fpizlo@apple.com [Tue, 19 Feb 2013 23:21:06 +0000 (23:21 +0000)]
Fix indentation of Opcode.h

Rubber stamped by Mark Hahnenberg.

* bytecode/Opcode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert residual-style.html test to a reftest (and fix typos)
commit-queue@webkit.org [Tue, 19 Feb 2013 23:20:37 +0000 (23:20 +0000)]
Convert residual-style.html test to a reftest (and fix typos)
https://bugs.webkit.org/show_bug.cgi?id=109981

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-19
Reviewed by Darin Adler.

* fast/flexbox/box-orient-button.html: clsas->class
* fast/flexbox/resources/box-orient-button.js: DTR->DRT
* fast/invalid/residual-style-expected.html: Added. New reftest
version. Note that some lines are red, which is
https://bugs.webkit.org/show_bug.cgi?id=109984
* fast/invalid/residual-style.html: Add missing semicolon in <style>.
Also close a few more <font> tags, so that the descriptive text is
in black as it should be.

* platform/chromium-android/fast/invalid/residual-style-expected.png: Removed.
* platform/chromium-android/fast/invalid/residual-style-expected.txt: Removed.
* platform/chromium-linux/fast/invalid/residual-style-expected.png: Removed.
* platform/chromium-linux/fast/invalid/residual-style-expected.txt: Removed.
* platform/chromium-mac-lion/fast/invalid/residual-style-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/invalid/residual-style-expected.png: Removed.
* platform/chromium-mac/fast/invalid/residual-style-expected.png: Removed.
* platform/chromium-mac/fast/invalid/residual-style-expected.txt: Removed.
* platform/chromium-win/fast/invalid/residual-style-expected.png: Removed.
* platform/chromium-win/fast/invalid/residual-style-expected.txt: Removed.
* platform/efl/fast/invalid/residual-style-expected.png: Removed.
* platform/efl/fast/invalid/residual-style-expected.txt: Removed.
* platform/gtk/fast/invalid/residual-style-expected.png: Removed.
* platform/gtk/fast/invalid/residual-style-expected.txt: Removed.
* platform/mac/fast/invalid/residual-style-expected.png: Removed.
* platform/mac/fast/invalid/residual-style-expected.txt: Removed.
Removed old expectation files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMoved PolymorphicAccessStructureList into its own file.
fpizlo@apple.com [Tue, 19 Feb 2013 23:19:25 +0000 (23:19 +0000)]
Moved PolymorphicAccessStructureList into its own file.

Rubber stamped by Mark Hahnenberg.

* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/Instruction.h:
(JSC):
* bytecode/PolymorphicAccessStructureList.h: Added.
(JSC):
(PolymorphicAccessStructureList):
(PolymorphicStubInfo):
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::PolymorphicStubInfo):
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
(JSC::PolymorphicAccessStructureList::visitWeak):
* bytecode/StructureStubInfo.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Appropriately handle word wrapping in SpellingHandler
nghanavatian@rim.com [Tue, 19 Feb 2013 23:15:42 +0000 (23:15 +0000)]
[BlackBerry] Appropriately handle word wrapping in SpellingHandler
https://bugs.webkit.org/show_bug.cgi?id=110253

Reviewed by Rob Buis.

PR286001
Since we traverse through text by visual lines instead of blocks, word wrapping causes some
bad behavior. Changing the way we traverse text to jump by words instead of lines. This will
mean it takes longer to finish spellchecking, but the removal of any loops allows webkit
processing to continue. This gives priority to user actions while still completing a large
paragraph in a reasonable amount of time.

Internally reviewed by Mike Fenton

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
* WebKitSupport/SpellingHandler.cpp:
(BlackBerry::WebKit::SpellingHandler::createSpellCheckRequest):
(BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
(BlackBerry::WebKit::SpellingHandler::getRangeForSpellCheckWithFineGranularity):
(BlackBerry::WebKit::SpellingHandler::startOfNextWord):
(WebKit):
(BlackBerry::WebKit::SpellingHandler::incrementByWord):
(BlackBerry::WebKit::SpellingHandler::doesWordWrap):
* WebKitSupport/SpellingHandler.h:
(SpellingHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix indentation of Instruction.h
fpizlo@apple.com [Tue, 19 Feb 2013 23:10:35 +0000 (23:10 +0000)]
Fix indentation of Instruction.h

Rubber stamped by Mark Hahnenberg.

* bytecode/Instruction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix 'slice' aspect ratio calculation
pdr@google.com [Tue, 19 Feb 2013 23:04:34 +0000 (23:04 +0000)]
Fix 'slice' aspect ratio calculation
https://bugs.webkit.org/show_bug.cgi?id=99984

Patch by Branimir Lambov <blambov@google.com> on 2013-02-19
Reviewed by Dirk Schulze.

Source/WebCore:

Previously the calculation for the 'slice' aspect ratio would incorrectly calculate the
source rect location based on the destination rect offset. This caused our source rect to be
incorrect, and sometimes render outside the visible area completely. After this patch
our implementation matches the implementation of both Gecko and Presto.

The relevant spec section:
http://www.w3.org/TR/SVG/single-page.html#coords-PreserveAspectRatioAttribute

Tests: svg/as-image/image-preserveAspectRatio-all.svg
       svg/filters/feImage-preserveAspectRatio-all.svg

* svg/SVGPreserveAspectRatio.cpp:
(WebCore::SVGPreserveAspectRatio::transformRect):

LayoutTests:

* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* svg/as-image/image-preserveAspectRatio-all-expected.png: Added.
* svg/as-image/image-preserveAspectRatio-all-expected.txt: Added.
* svg/as-image/image-preserveAspectRatio-all.svg: Added.
* svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
* svg/filters/feImage-preserveAspectRatio-all-expected.txt: Added.
* svg/filters/feImage-preserveAspectRatio-all.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Test Expectations to reflect flakey calendar tests.
schenney@chromium.org [Tue, 19 Feb 2013 23:03:15 +0000 (23:03 +0000)]
[Chromium] Test Expectations to reflect flakey calendar tests.
https://bugs.webkit.org/show_bug.cgi?id=107508

Unreviewed test expectations.

* platform/chromium/TestExpectations: Re-added all the flakey calendar tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] ScriptRunner::runCompiledScript() should return Handle<Value>() when OOM occurs
commit-queue@webkit.org [Tue, 19 Feb 2013 23:01:20 +0000 (23:01 +0000)]
[V8] ScriptRunner::runCompiledScript() should return Handle<Value>() when OOM occurs
https://bugs.webkit.org/show_bug.cgi?id=110254

Patch by Kentaro Hara <haraken@google.com> on 2013-02-19
Reviewed by Adam Barth.

Chromium bug: https://code.google.com/p/chromium/issues/detail?id=176951

Currently ScriptRunner::runCompiledScript() calls
ASSERT(script.IsEmpty()) when OOM occurs. The Chromium bug is
hitting the ASSERT(). The ASSERT() does not make sense at all.
Instead, we should return an empty handle when OOM occurs.

No tests. The bug happens only when OOM occurs.

* bindings/v8/ScriptRunner.cpp:
(WebCore::ScriptRunner::runCompiledScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSupport both MutationObserver and WebKitMutationObserver
esprehn@chromium.org [Tue, 19 Feb 2013 22:58:29 +0000 (22:58 +0000)]
Support both MutationObserver and WebKitMutationObserver
https://bugs.webkit.org/show_bug.cgi?id=109776

Reviewed by Ojan Vafai.

Source/WebCore:

We should allow new MutationObserver now that we support parser generated
mutations. This leaves the old prefixed constructor in until we decide
people don't depend on it.

Test: fast/dom/MutationObserver/mutation-observer-prefix.html

* page/DOMWindow.idl:

LayoutTests:

* fast/dom/MutationObserver/added-out-of-order.html:
* fast/dom/MutationObserver/callback-arguments.html:
* fast/dom/MutationObserver/clear-transient-without-delivery.html:
* fast/dom/MutationObserver/create-during-delivery.html:
* fast/dom/MutationObserver/cross-document.html:
* fast/dom/MutationObserver/database-callback-delivery.html:
* fast/dom/MutationObserver/delivery-order.html:
* fast/dom/MutationObserver/disconnect-cancel-pending.html:
* fast/dom/MutationObserver/document-fragment-insertion.html:
* fast/dom/MutationObserver/end-of-task-delivery.html:
* fast/dom/MutationObserver/filesystem-callback-delivery.html:
* fast/dom/MutationObserver/inline-event-listener.html:
* fast/dom/MutationObserver/mutate-during-delivery.html:
* fast/dom/MutationObserver/mutation-callback-non-element-crash.html:
* fast/dom/MutationObserver/mutation-observer-constructor.html:
* fast/dom/MutationObserver/mutation-observer-prefix-expected.txt: Added.
* fast/dom/MutationObserver/mutation-observer-prefix.html: Added.
* fast/dom/MutationObserver/mutation-record-nullity.html:
* fast/dom/MutationObserver/observe-attributes.html:
* fast/dom/MutationObserver/observe-characterdata.html:
* fast/dom/MutationObserver/observe-childList.html:
* fast/dom/MutationObserver/observe-exceptions.html:
* fast/dom/MutationObserver/observe-subtree.html:
* fast/dom/MutationObserver/observer-wrapper-dropoff-transient.html:
* fast/dom/MutationObserver/observer-wrapper-dropoff.html:
* fast/dom/MutationObserver/parser-mutations.html:
* fast/dom/MutationObserver/removed-out-of-order.html:
* fast/dom/MutationObserver/shadow-dom.html:
* fast/dom/MutationObserver/takeRecords.html:
* fast/dom/MutationObserver/transient-gc-crash.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago <rdar://problem/13239119> NetworkProcess generates timeout spindump logs
ap@apple.com [Tue, 19 Feb 2013 22:38:35 +0000 (22:38 +0000)]
    <rdar://problem/13239119> NetworkProcess generates timeout spindump logs

        Reviewed by Mark Rowe.

        Don't keep a window server connection in processes that don't need it, and don't
        run an NSApplication run loop.

        * Shared/ChildProcess.h:
        * Shared/mac/ChildProcessMac.mm: (WebKit::ChildProcess::shutdownWindowServerConnection):
        Added a function to shut down connections, and to make sure we don't get one in the future.

        * NetworkProcess/mac/NetworkProcessMac.mm:
        (WebKit::NetworkProcess::initializeProcessName):
        * OfflineStorageProcess/mac/OfflineStorageProcessMac.mm:
        (WebKit::OfflineStorageProcess::initializeProcessName):
        * SharedWorkerProcess/mac/SharedWorkerProcessMac.mm:
        (WebKit::SharedWorkerProcess::platformInitializeSharedWorkerProcess): Also removed
        some unused includes and forward declarations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling in r143348.
ggaren@apple.com [Tue, 19 Feb 2013 22:29:03 +0000 (22:29 +0000)]
Unreviewed, rolling in r143348.
http://trac.webkit.org/changeset/143348
https://bugs.webkit.org/show_bug.cgi?id=110242

The bug was that isEmptyValue() was returning true for the deleted value.
Fixed this and simplified things further by delegating to m_sourceCode
for both isNull() and isHashTableDeletedValue(), so they can't be out of
sync.

* runtime/CodeCache.cpp:
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
* runtime/CodeCache.h:
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::length):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::operator==):
(SourceCodeKey):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Adding myself as a committer.
hmuller@adobe.com [Tue, 19 Feb 2013 22:15:58 +0000 (22:15 +0000)]
Unreviewed. Adding myself as a committer.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Remove idbFactory from WebKitPlatformSupport
pilgrim@chromium.org [Tue, 19 Feb 2013 22:02:47 +0000 (22:02 +0000)]
[Chromium] Remove idbFactory from WebKitPlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=106457

Reviewed by Kentaro Hara.

Now that https://codereview.chromium.org/12230054 has landed, the
idbFactory method is no longer needed. (Embedders must now call
the new setIDBFactory method upon initialization.) Part of a
larger refactoring series; see tracking bug 82948.

* public/platform/WebKitPlatformSupport.h:
(WebKit):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Improve gyp build JavaScriptCore code generation
mrobinson@webkit.org [Tue, 19 Feb 2013 21:53:57 +0000 (21:53 +0000)]
[GTK] Improve gyp build JavaScriptCore code generation
https://bugs.webkit.org/show_bug.cgi?id=109969

Reviewed by Dirk Pranke.

Switch away from using DerivedSources.make when building JavaScriptCore generated
sources. This bring a couple advantages, such as building the sources in parallel,
but requires us to list the generated sources more than once.

* JavaScriptCore.gyp/JavaScriptCoreGTK.gyp: Add rules for generating JavaScriptCore sources.
* JavaScriptCore.gyp/generate-derived-sources.sh: Added.
* JavaScriptCore.gyp/redirect-stdout.sh: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove RenderText::updateText
esprehn@chromium.org [Tue, 19 Feb 2013 21:51:19 +0000 (21:51 +0000)]
Remove RenderText::updateText
https://bugs.webkit.org/show_bug.cgi?id=109991

Reviewed by Eric Seidel.

There's no reason for the generic RenderText::updateText virtual hook
anymore now that r143060 made RenderQuote stop setting dirty bits during
layout since the hook is only used by RenderCounter.

Instead add updateCounterIfNeeded and make it clear this is a hack for
counters.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::updateCounterIfNeeded): Added, not handles the counter specific hack.
(WebCore::dirtyLineBoxesForRenderer):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
* rendering/RenderCounter.cpp:
(WebCore::RenderCounter::updateCounter):
* rendering/RenderCounter.h:
(RenderCounter):
* rendering/RenderQuote.cpp:
(WebCore::RenderQuote::styleDidChange):
(WebCore::RenderQuote::updateDepth):
* rendering/RenderQuote.h:
(RenderQuote):
* rendering/RenderText.h:
(RenderText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSS3: add line-break tests, initially skipping on all platforms
glenn@skynav.com [Tue, 19 Feb 2013 21:46:06 +0000 (21:46 +0000)]
CSS3: add line-break tests, initially skipping on all platforms
https://bugs.webkit.org/show_bug.cgi?id=109954

Reviewed by Dirk Pranke.

See also wiki documentation at:
[1] http://trac.webkit.org/wiki/LineBreaking
[2] http://trac.webkit.org/wiki/LineBreakingCSS3Mapping

See also:
https://bugs.webkit.org/show_bug.cgi?id=89235

* TestExpectations:
* css3/line-break/line-break-auto-centered-expected.html: Added.
* css3/line-break/line-break-auto-centered.html: Added.
* css3/line-break/line-break-auto-half-kana-expected.html: Added.
* css3/line-break/line-break-auto-half-kana.html: Added.
* css3/line-break/line-break-auto-hyphens-expected.html: Added.
* css3/line-break/line-break-auto-hyphens.html: Added.
* css3/line-break/line-break-auto-inseparables-expected.html: Added.
* css3/line-break/line-break-auto-inseparables.html: Added.
* css3/line-break/line-break-auto-iteration-marks-expected.html: Added.
* css3/line-break/line-break-auto-iteration-marks.html: Added.
* css3/line-break/line-break-auto-postfixes-expected.html: Added.
* css3/line-break/line-break-auto-postfixes.html: Added.
* css3/line-break/line-break-auto-prefixes-expected.html: Added.
* css3/line-break/line-break-auto-prefixes.html: Added.
* css3/line-break/line-break-auto-sound-marks-expected.html: Added.
* css3/line-break/line-break-auto-sound-marks.html: Added.
* css3/line-break/line-break-loose-centered-expected.html: Added.
* css3/line-break/line-break-loose-centered.html: Added.
* css3/line-break/line-break-loose-half-kana-expected.html: Added.
* css3/line-break/line-break-loose-half-kana.html: Added.
* css3/line-break/line-break-loose-hyphens-expected.html: Added.
* css3/line-break/line-break-loose-hyphens.html: Added.
* css3/line-break/line-break-loose-inseparables-expected.html: Added.
* css3/line-break/line-break-loose-inseparables.html: Added.
* css3/line-break/line-break-loose-iteration-marks-expected.html: Added.
* css3/line-break/line-break-loose-iteration-marks.html: Added.
* css3/line-break/line-break-loose-postfixes-expected.html: Added.
* css3/line-break/line-break-loose-postfixes.html: Added.
* css3/line-break/line-break-loose-prefixes-expected.html: Added.
* css3/line-break/line-break-loose-prefixes.html: Added.
* css3/line-break/line-break-loose-sound-marks-expected.html: Added.
* css3/line-break/line-break-loose-sound-marks.html: Added.
* css3/line-break/line-break-normal-centered-expected.html: Added.
* css3/line-break/line-break-normal-centered.html: Added.
* css3/line-break/line-break-normal-half-kana-expected.html: Added.
* css3/line-break/line-break-normal-half-kana.html: Added.
* css3/line-break/line-break-normal-hyphens-expected.html: Added.
* css3/line-break/line-break-normal-hyphens.html: Added.
* css3/line-break/line-break-normal-inseparables-expected.html: Added.
* css3/line-break/line-break-normal-inseparables.html: Added.
* css3/line-break/line-break-normal-iteration-marks-expected.html: Added.
* css3/line-break/line-break-normal-iteration-marks.html: Added.
* css3/line-break/line-break-normal-postfixes-expected.html: Added.
* css3/line-break/line-break-normal-postfixes.html: Added.
* css3/line-break/line-break-normal-prefixes-expected.html: Added.
* css3/line-break/line-break-normal-prefixes.html: Added.
* css3/line-break/line-break-normal-sound-marks-expected.html: Added.
* css3/line-break/line-break-normal-sound-marks.html: Added.
* css3/line-break/line-break-strict-centered-expected.html: Added.
* css3/line-break/line-break-strict-centered.html: Added.
* css3/line-break/line-break-strict-half-kana-expected.html: Added.
* css3/line-break/line-break-strict-half-kana.html: Added.
* css3/line-break/line-break-strict-hyphens-expected.html: Added.
* css3/line-break/line-break-strict-hyphens.html: Added.
* css3/line-break/line-break-strict-inseparables-expected.html: Added.
* css3/line-break/line-break-strict-inseparables.html: Added.
* css3/line-break/line-break-strict-iteration-marks-expected.html: Added.
* css3/line-break/line-break-strict-iteration-marks.html: Added.
* css3/line-break/line-break-strict-postfixes-expected.html: Added.
* css3/line-break/line-break-strict-postfixes.html: Added.
* css3/line-break/line-break-strict-prefixes-expected.html: Added.
* css3/line-break/line-break-strict-prefixes.html: Added.
* css3/line-break/line-break-strict-sound-marks-expected.html: Added.
* css3/line-break/line-break-strict-sound-marks.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBorder changes on tables with collapsed borders doesn't relayout table cells
tony@chromium.org [Tue, 19 Feb 2013 21:18:00 +0000 (21:18 +0000)]
Border changes on tables with collapsed borders doesn't relayout table cells
https://bugs.webkit.org/show_bug.cgi?id=109774

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/table/border-collapsing/dynamic-border-width-change.html

Changes to border top and border bottom on table rows also changes the size
of the table cell causing a relayout to be needed.

* rendering/RenderTableRow.cpp:
(WebCore::borderWidthChanged): Also include border top and bottom.
(WebCore::RenderTableRow::styleDidChange): Remove logical from the helper function name.

LayoutTests:

* fast/table/border-collapsing/dynamic-border-width-change-expected.txt: Added.
* fast/table/border-collapsing/dynamic-border-width-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a test result missed in r143074.
simon.fraser@apple.com [Tue, 19 Feb 2013 20:56:14 +0000 (20:56 +0000)]
Add a test result missed in r143074.

* platform/mac-wk2/tiled-drawing/null-parent-back-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
senorblanco@chromium.org [Tue, 19 Feb 2013 20:49:40 +0000 (20:49 +0000)]
[Chromium] Unreviewed gardening.
Remove two now-passing tests.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rebaselined run-bindings-tests.
haraken@chromium.org [Tue, 19 Feb 2013 20:47:51 +0000 (20:47 +0000)]
Unreviewed. Rebaselined run-bindings-tests.

* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsNullString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WebGL] Fix oes-element-index-uint.html test.
commit-queue@webkit.org [Tue, 19 Feb 2013 20:43:48 +0000 (20:43 +0000)]
[WebGL] Fix oes-element-index-uint.html test.
https://bugs.webkit.org/show_bug.cgi?id=110045

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-19
Reviewed by Kenneth Russell.

This patch fixes the test case to use updated WebGLTestUtils functions
and adds shaders used during resized buffer tests. This patch
also enables the test for EFL port.

* fast/canvas/webgl/oes-element-index-uint-expected.txt:
* fast/canvas/webgl/oes-element-index-uint.html:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebAudio API: Change the Platform::createAudioDevice function to take a DeviceId...
tommyw@google.com [Tue, 19 Feb 2013 20:36:36 +0000 (20:36 +0000)]
WebAudio API: Change the Platform::createAudioDevice function to take a DeviceId parameter
https://bugs.webkit.org/show_bug.cgi?id=110192

Reviewed by Adam Barth.

* chromium/public/Platform.h:
(WebKit::Platform::createAudioDevice):
(Platform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][AC] Implement matrix transform animation with clutter ac backend
commit-queue@webkit.org [Tue, 19 Feb 2013 20:10:11 +0000 (20:10 +0000)]
[GTK][AC] Implement matrix transform animation with clutter ac backend
https://bugs.webkit.org/show_bug.cgi?id=109848

Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-02-19
Reviewed by Gustavo Noronha Silva.

Clutter 1.12 doesn't support additive transform animations yet, so the combination
of two or more transformations(such as rotation after translation) runs unexpectedly.
So we use a matrix transformation instead for the case.

Covered by existing animation tests.

* platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::getValueFunctionNameForTransformOperation):
(WebCore::GraphicsLayerClutter::createTransformAnimationsFromKeyframes):
* platform/graphics/clutter/PlatformClutterAnimation.cpp:
(WebCore::toClutterActorPropertyString): Add actor property "transform"
(WebCore::clutterMatrixProgress): Handle interpolation between two matrices instead of default clutter_matrix_progress.
(WebCore):
(WebCore::PlatformClutterAnimation::supportsAdditiveValueFunction):
(WebCore::PlatformClutterAnimation::setFromValue): for TransformationMatrix.
(WebCore::PlatformClutterAnimation::setToValue): ditto.
(WebCore::PlatformClutterAnimation::addClutterTransitionForProperty):
(WebCore::PlatformClutterAnimation::addTransformTransition):
* platform/graphics/clutter/PlatformClutterAnimation.h:
(PlatformClutterAnimation):
* platform/graphics/clutter/TransformationMatrixClutter.cpp: Add copy constructor for CoglMatrix.
(WebCore::TransformationMatrix::TransformationMatrix):
(WebCore):
* platform/graphics/transforms/TransformationMatrix.h:
(TransformationMatrix):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Mark fast/workers/storage/interrupt-database.html as flaky crasher
enne@google.com [Tue, 19 Feb 2013 20:01:48 +0000 (20:01 +0000)]
[chromium] Mark fast/workers/storage/interrupt-database.html as flaky crasher
https://bugs.webkit.org/show_bug.cgi?id=110247

Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r143348.
commit-queue@webkit.org [Tue, 19 Feb 2013 19:39:54 +0000 (19:39 +0000)]
Unreviewed, rolling out r143348.
http://trac.webkit.org/changeset/143348
https://bugs.webkit.org/show_bug.cgi?id=110242

"Caused a deleted value sentinel crash on the layout tests"
(Requested by ggaren on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19

* runtime/CodeCache.cpp:
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
* runtime/CodeCache.h:
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::length):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::operator==):
(SourceCodeKey):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaselining, again, calendar tests
schenney@chromium.org [Tue, 19 Feb 2013 19:29:42 +0000 (19:29 +0000)]
Rebaselining, again, calendar tests
https://bugs.webkit.org/show_bug.cgi?id=110240

Unreviewed expectations update.

* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Removed.
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate FeatureObserver on top level navigation in addition to page destruction.
commit-queue@webkit.org [Tue, 19 Feb 2013 19:19:02 +0000 (19:19 +0000)]
Update FeatureObserver on top level navigation in addition to page destruction.
https://bugs.webkit.org/show_bug.cgi?id=109874

Patch by Kassy Coan <kassycoan@chromium.org> on 2013-02-19
Reviewed by Adam Barth.

No new tests. Only effect is to histogram more frequently.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchDidCommitLoad):
* page/FeatureObserver.cpp:
(WebCore::FeatureObserver::~FeatureObserver):
(WebCore):
(WebCore::FeatureObserver::updateMeasurements):
(WebCore::FeatureObserver::didCommitLoad):
* page/FeatureObserver.h:
(FeatureObserver):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, changing primary email.
pravin.d@samsung.com [Tue, 19 Feb 2013 19:15:33 +0000 (19:15 +0000)]
Unreviewed, changing primary email.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unnecessary (and problematic) copy-constructor from LayoutUnit
commit-queue@webkit.org [Tue, 19 Feb 2013 19:10:45 +0000 (19:10 +0000)]
Remove unnecessary (and problematic) copy-constructor from LayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=110121

This copy constructor does what a default copy constructor would do, so
it's not necessary. Furthermore, this copy constructor is the only
reason why LayoutUnit becomes non-POD, and that triggers a gdb bug,
making it impossible to do things like "print location()" when inside
some RenderBlock, for instance.

Gdb bug http://sourceware.org/bugzilla/show_bug.cgi?id=15154 reported.

Patch by Morten Stenshorne <mstensho@opera.com> on 2013-02-19
Reviewed by Benjamin Poulain.

No tests. Apart from dealing with buggy debuggers, this is just code cleanup.

* platform/LayoutUnit.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION: Sheriffbot is failing to process rollout requests
commit-queue@webkit.org [Tue, 19 Feb 2013 19:10:27 +0000 (19:10 +0000)]
REGRESSION: Sheriffbot is failing to process rollout requests
https://bugs.webkit.org/show_bug.cgi?id=106945

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-19
Reviewed by Adam Barth.

Modified Sheriffbot build script to track the svn repo from git and add bot user details to the git repo config file.
This resolves problems when Sheriffbot attempts to perform a rollout request.

* EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
* EWSTools/configure-git-svn.sh: Copied from Tools/EWSTools/create-webkit-git.
* EWSTools/configure-git-user.sh: Renamed from Tools/EWSTools/create-webkit-git.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRomanian translation for WebKitGtk+ HEAD
kov@webkit.org [Tue, 19 Feb 2013 19:08:11 +0000 (19:08 +0000)]
Romanian translation for WebKitGtk+ HEAD
https://bugs.webkit.org/show_bug.cgi?id=110009

Patch by Mișu Moldovan <dumol@gnome.org> on 2013-02-19
Reviewed by Gustavo Noronha.

* ro.po: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [WK2] Cannot load documents with blob urls
ap@apple.com [Tue, 19 Feb 2013 19:06:40 +0000 (19:06 +0000)]
    [WK2] Cannot load documents with blob urls
        https://bugs.webkit.org/show_bug.cgi?id=110160

        Reviewed by Sam Weinig.

        * http/tests/fileapi/blob-url-in-subframe-expected.txt: Added.
        * http/tests/fileapi/blob-url-in-subframe.html: Added.
        * http/tests/fileapi/resources: Added.
        * http/tests/fileapi/resources/blob-url-in-subframe-frame.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayoutUnit::epsilon shouldn't be necessary to place floats
eae@chromium.org [Tue, 19 Feb 2013 19:00:35 +0000 (19:00 +0000)]
LayoutUnit::epsilon shouldn't be necessary to place floats
https://bugs.webkit.org/show_bug.cgi?id=94000

Reviewed by Levi Weintraub.

Currently, to get float placement correct, we need to have an
epsilon tolerance in RenderBlock::computeLogicalLocationForFloat
for the width of the line to fit them on. This really shouldn't
be necessary, and probably indicates we're losing precision
elsewhere.

Remove epsilon as it no longer appears to be needed. All layout
tests pass without it.

No new tests, covered by existing tests.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLogicalLocationForFloat):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoText Autosizing: prevent oscillation of font sizes during autosizing
commit-queue@webkit.org [Tue, 19 Feb 2013 18:57:31 +0000 (18:57 +0000)]
Text Autosizing: prevent oscillation of font sizes during autosizing
https://bugs.webkit.org/show_bug.cgi?id=108205

Patch by Tim Volodine <timvolodine@chromium.org> on 2013-02-19
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

On some websites autosized font-sizes oscillate due to layouts caused by
hovering or incremental page loading (and on other sites font sizes do
eventually stabilize, but it takes many layouts before they reach a steady
size). To prevent all these cases, we no longer allow the autosizing
multiplier to change after it has been set (to a value other than 1).

This won't always give exactly the same results, but testing on 2000 top
sites shows that this makes little difference in practice, and it prevents
these very jarring cases. As a happy side-effect, this speeds up layouts
as font sizes change less.

Test: fast/text-autosizing/oscillation-javascript-fontsize-change.html

* page/FrameView.cpp:
(WebCore::FrameView::setFrameRect):
* page/Settings.cpp:
(WebCore::Settings::setTextAutosizingFontScaleFactor):
* rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::recalculateMultipliers):
(WebCore):
(WebCore::TextAutosizer::processContainer):
* rendering/TextAutosizer.h:
(TextAutosizer):

LayoutTests:

Added overflow-y:hidden to some existing tests, since previously those tests
would start off with incorrect multipliers (because mainFrame->view()-layoutSize()
is initially 785 instead of 800 as ScrollView wrongly guesses a scrollbar will
be needed), and then the multipliers would get corrected on a subsequent layout.
Now that we don't allow the multiplier to change after being set, it needs to be
right first time.
Also added specific oscillation test triggered by javascript.

* fast/text-autosizing/constrained-height-body-expected.html:
* fast/text-autosizing/constrained-height-body.html:
* fast/text-autosizing/constrained-then-float-ancestors-expected.html:
* fast/text-autosizing/constrained-then-float-ancestors.html:
* fast/text-autosizing/constrained-then-position-fixed-ancestors-expected.html:
* fast/text-autosizing/constrained-then-position-fixed-ancestors.html:
* fast/text-autosizing/nested-em-line-height-expected.html:
* fast/text-autosizing/nested-em-line-height.html:
* fast/text-autosizing/oscillation-javascript-fontsize-change-expected.html: Added.
* fast/text-autosizing/oscillation-javascript-fontsize-change.html: Added.
* fast/text-autosizing/simple-paragraph-expected.html:
* fast/text-autosizing/simple-paragraph.html:
* fast/text-autosizing/span-child-expected.html:
* fast/text-autosizing/span-child.html:
* fast/text-autosizing/unwrappable-blocks-expected.html:
* fast/text-autosizing/unwrappable-blocks.html:
* fast/text-autosizing/unwrappable-inlines-expected.html:
* fast/text-autosizing/unwrappable-inlines.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Fix races in double-tap zoom minimum scale policy
aelias@chromium.org [Tue, 19 Feb 2013 18:42:27 +0000 (18:42 +0000)]
[chromium] Fix races in double-tap zoom minimum scale policy
https://bugs.webkit.org/show_bug.cgi?id=110183

Reviewed by Adam Barth.

Double-tap zoom on Android is supposed to return to minimum scale
if no pinch zoom occurred since the last double-tap. Because both
pinch zoom and the result of double-tap zoom gets passed in from CC
via applyScrollAndScale, this logic was brittle and prone to races
depending on when the animation update was received. This patch
keeps track of what the target double-tap scale is to make it more
robust.

I also fixed double-tap zoom test mocking to exercise the entire
page scale animation flow (our previous way of testing was hiding the
raciness), and added a new test case in DivAutoZoomMultipleParamsTest.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::startPageScaleAnimation):
(WebKit):
(WebKit::WebViewImpl::enableFakeDoubleTapAnimationForTesting):
(WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
(WebKit::WebViewImpl::animateZoomAroundPoint):
(WebKit::WebViewImpl::didCommitLoad):
(WebKit::WebViewImpl::applyScrollAndScale):
* src/WebViewImpl.h:
(WebViewImpl):
(WebKit::WebViewImpl::fakeDoubleTapAnimationPendingForTesting):
(WebKit::WebViewImpl::fakeDoubleTapTargetPositionForTesting):
(WebKit::WebViewImpl::fakeDoubleTapPageScaleFactorForTesting):
(WebKit::WebViewImpl::fakeDoubleTapUseAnchorForTesting):
* tests/WebFrameTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHeapBlock::destroy should issue warning if result is unused
mhahnenberg@apple.com [Tue, 19 Feb 2013 18:40:03 +0000 (18:40 +0000)]
HeapBlock::destroy should issue warning if result is unused
https://bugs.webkit.org/show_bug.cgi?id=110233

Reviewed by Oliver Hunt.

To enforce the fact that we need to return blocks to the BlockAllocator after calling destroy,
we should add WARN_UNUSED_RETURN to HeapBlock::destroy and any other destroy functions in its subclasses.

* heap/HeapBlock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [WK2] Cannot load documents with blob urls
ap@apple.com [Tue, 19 Feb 2013 18:29:32 +0000 (18:29 +0000)]
    [WK2] Cannot load documents with blob urls
        https://bugs.webkit.org/show_bug.cgi?id=110160

        Reviewed by Sam Weinig.

        * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::canHandleRequest):
        Added knowledge about blobs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] http/tests/loading/307-after-303-after-post.html times out
commit-queue@webkit.org [Tue, 19 Feb 2013 18:28:11 +0000 (18:28 +0000)]
[EFL][DRT] http/tests/loading/307-after-303-after-post.html times out
https://bugs.webkit.org/show_bug.cgi?id=93214

Source/WebCore:

Ensured that GET verb is consistently used for any request
coming after a redirection that triggers switching to GET.

Patch by Youenn Fablet <youennf@gmail.com> on 2013-02-19
Reviewed by Martin Robinson.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::doRedirect):

LayoutTests:

Removed Failure from potential outcome of
http/tests/loading/307-after-303-after-post.html test.

Patch by Youenn Fablet <youennf@gmail.com> on 2013-02-19
Reviewed by Martin Robinson.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeakSet::removeAllocator leaks WeakBlocks
mhahnenberg@apple.com [Tue, 19 Feb 2013 18:12:03 +0000 (18:12 +0000)]
WeakSet::removeAllocator leaks WeakBlocks
https://bugs.webkit.org/show_bug.cgi?id=110228

Reviewed by Geoffrey Garen.

We need to return the WeakBlock to the BlockAllocator after the call to WeakBlock::destroy.

* heap/WeakSet.cpp:
(JSC::WeakSet::removeAllocator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix compilation if Qt was configured with -no-rtti
abecsi@webkit.org [Tue, 19 Feb 2013 18:07:17 +0000 (18:07 +0000)]
[Qt] Fix compilation if Qt was configured with -no-rtti
https://bugs.webkit.org/show_bug.cgi?id=110234

Reviewed by Noam Rosenthal.

Availability of dynamic_cast should be checked.

* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::updateBackingStoreIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago Unregistered blob URLs have incorrect MIME type
ap@apple.com [Tue, 19 Feb 2013 18:05:47 +0000 (18:05 +0000)]
    Unregistered blob URLs have incorrect MIME type
        https://bugs.webkit.org/show_bug.cgi?id=110166

        Reviewed by Sam Weinig.

        * page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::shouldUseInnerURL): Added a FIXME.

        * platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::notifyResponseOnError):
        Pass an accurate MIME type (for a delegate to see).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSave space on keys in the CodeCache
ggaren@apple.com [Tue, 19 Feb 2013 17:48:15 +0000 (17:48 +0000)]
Save space on keys in the CodeCache
https://bugs.webkit.org/show_bug.cgi?id=110179

Reviewed by Oliver Hunt.

Share the SourceProvider's string instead of making our own copy. This
chops off 16MB - 32MB from the CodeCache's memory footprint when full.
(It's 16MB when the strings are LChar, and 32MB when they're UChar.)

* runtime/CodeCache.cpp:
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
* runtime/CodeCache.h: Removed a defunct enum value.

(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(SourceCodeKey):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::length):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::string):
(JSC::SourceCodeKey::operator==): Store a SourceCode instead of a String
so we can share our string with our SourceProvider. Cache our hash so
we don't have to re-decode our string just to re-hash the table.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: additional checks on LevelDB decoding
jsbell@chromium.org [Tue, 19 Feb 2013 17:42:55 +0000 (17:42 +0000)]
IndexedDB: additional checks on LevelDB decoding
https://bugs.webkit.org/show_bug.cgi?id=109711

Reviewed by Tony Chang.

Source/WebCore:

Watch out for decoding errors caused by corrupted data, and exit various
decode/compare operations earlier.

Covered by existing LayoutTests and Chromium's webkit_unit_tests

* Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::decodeStringWithLength): Bail if length is negative.
(WebCore::IDBLevelDBCoding::compareEncodedStringsWithLength): Distinguish error case.
(WebCore::IDBLevelDBCoding::extractEncodedIDBKey): Bail if length is negative.
(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys): Distinguish error case.
(WebCore::IDBLevelDBCoding::compare): Plumb through "ok".
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::compare): Ditto.
(WebCore::IDBLevelDBCoding::ExistsEntryKey::compare): Ditto.
(WebCore::IDBLevelDBCoding::IndexDataKey::compare): Ditto.
* Modules/indexeddb/IDBLevelDBCoding.h: Updated method signatures.

Source/WebKit/chromium:

* tests/IDBLevelDBCodingTest.cpp: Update test with new method signatures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agorevertBranchPtrWithPatch is incorrect on ARM traditional
zherczeg@webkit.org [Tue, 19 Feb 2013 17:12:41 +0000 (17:12 +0000)]
revertBranchPtrWithPatch is incorrect on ARM traditional
https://bugs.webkit.org/show_bug.cgi?id=110201

Reviewed by Oliver Hunt.

Revert two instructions back to their original value.

* assembler/ARMAssembler.h:
(JSC::ARMAssembler::revertBranchPtrWithPatch):
(ARMAssembler):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branchPtrWithPatch):
(JSC::MacroAssemblerARM::revertJumpReplacementToBranchPtrWithPatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix.
csaavedra@igalia.com [Tue, 19 Feb 2013 17:09:31 +0000 (17:09 +0000)]
Unreviewed build fix.

.:

* Source/autotools/FindDependencies.m4:
* Source/autotools/Versions.m4:
* Source/cmake/FindHarfBuzz.cmake:

Bump gtk and efl dependencies on harfbuzz
to 0.9.7. See bug 110145.

Tools:

* efl/jhbuild.modules:
* gtk/jhbuild.modules:

Bump harfbuzz module to 0.9.7. See related bug 110145.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOnly depend on xrender if x11 is being used
commit-queue@webkit.org [Tue, 19 Feb 2013 17:01:41 +0000 (17:01 +0000)]
Only depend on xrender if x11 is being used
https://bugs.webkit.org/show_bug.cgi?id=84095

Patch by Changhun Kang <temoochin@company100.net> on 2013-02-19
Reviewed by Martin Robinson.

* Source/autotools/FindDependencies.m4:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][AC] Implement keyframe animations with clutter ac backend
commit-queue@webkit.org [Tue, 19 Feb 2013 17:01:32 +0000 (17:01 +0000)]
[GTK][AC] Implement keyframe animations with clutter ac backend
https://bugs.webkit.org/show_bug.cgi?id=110057

Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-02-19
Reviewed by Gustavo Noronha Silva.

This patch brings accelerated keyframe animation with clutter to WebKitGtk+.
Changes of GraphicsLayerClutter are based on GraphicsLayerCA. But major changes
of PlatformClutterAnimation are implemented with clutter keyframe transition apis.
See http://developer.gnome.org/clutter/stable/ClutterKeyframeTransition.html

Covered by existing animation tests.

* platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::createKeyframeAnimation):
(WebCore::GraphicsLayerClutter::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerClutter::setAnimationKeyframes):
* platform/graphics/clutter/PlatformClutterAnimation.cpp:
(WebCore::toClutterActorPropertyString):
(WebCore::PlatformClutterAnimation::PlatformClutterAnimation):
(WebCore::PlatformClutterAnimation::setTimingFunction):
(WebCore::PlatformClutterAnimation::setValues):
(WebCore::PlatformClutterAnimation::setKeyTimes):
(WebCore::PlatformClutterAnimation::setTimingFunctions):
(WebCore::PlatformClutterAnimation::addClutterTransitionForProperty):
(WebCore):
(WebCore::PlatformClutterAnimation::addClutterKeyframeTransitionForProperty):
(WebCore::PlatformClutterAnimation::addOpacityTransition):
(WebCore::PlatformClutterAnimation::addTransformTransition):
(WebCore::PlatformClutterAnimation::addAnimationForKey):
(WebCore::PlatformClutterAnimation::removeAnimationForKey):
* platform/graphics/clutter/PlatformClutterAnimation.h:
(PlatformClutterAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Skip failing test.
kadam@inf.u-szeged.hu [Tue, 19 Feb 2013 16:55:31 +0000 (16:55 +0000)]
[Qt] Unreviewed gardening. Skip failing test.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Move the API to get TLS certificate from WebKitURIResponse to WebKitWebView
carlosgc@webkit.org [Tue, 19 Feb 2013 16:50:36 +0000 (16:50 +0000)]
[GTK] Move the API to get TLS certificate from WebKitURIResponse to WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=110190

Reviewed by Anders Carlsson.

Add webkit_web_view_get_tls_info() and remove
webkit_uri_response_get_https_status(). This way I can be sure
that when called after load has been committed the certificate
will be available. It also makes the API easier to use.

* UIProcess/API/gtk/WebKitURIResponse.cpp:
* UIProcess/API/gtk/WebKitURIResponse.h:
* UIProcess/API/gtk/WebKitURIResponsePrivate.h:
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewLoadChanged):
(mainResourceResponseChangedCallback):
(webkit_web_view_get_tls_info):
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
* UIProcess/API/gtk/tests/TestSSL.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, adding external symbol ?didBeginFrame@InspectorCanvasAgent@WebCore@@QAEXXZ.
aandrey@chromium.org [Tue, 19 Feb 2013 16:50:24 +0000 (16:50 +0000)]
Unreviewed, adding external symbol ?didBeginFrame@InspectorCanvasAgent@WebCore@@QAEXXZ.

* WebKit.vcproj/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][EFL] Eliminate access to WK2 C++ internals from ewk_view functions
mikhail.pozdnyakov@intel.com [Tue, 19 Feb 2013 16:48:06 +0000 (16:48 +0000)]
[WK2][EFL] Eliminate access to WK2 C++ internals from ewk_view functions
https://bugs.webkit.org/show_bug.cgi?id=109794

Reviewed by Anders Carlsson.

* UIProcess/API/C/efl/WKView.cpp:
(WKViewSetShowsAsSource):
(WKViewGetShowsAsSource):

    Added new WKView API to wrap WebPageProxy::setMainFrameInViewSourceMode()
    and WebPageProxy::mainFrameInViewSourceMode() calls.

(WKViewExitFullScreen):

    Added new WKView API to wrap WebFullScreenManagerProxy::exitFullScreen()
    calls.

* UIProcess/API/C/efl/WKView.h:
* UIProcess/API/efl/EwkView.cpp:
(EwkView::feedTouchEvent):

    Added feedTouchEvent() method so that: at first ewk_view_feed_touch_event()
    is not invoked from EwkView class, secondly ewk_view_feed_touch_event() does
    not access WebPage instance directly.

(EwkView::feedTouchEvents):
* UIProcess/API/efl/EwkView.h:
(EwkView):
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_feed_touch_event):
(ewk_view_pagination_mode_set):
(ewk_view_pagination_mode_get):
(ewk_view_fullscreen_exit):
(ewkViewPageContentsCallback):
(ewk_view_page_contents_get):
(ewk_view_source_mode_set):
(ewk_view_source_mode_get):

    Those are now using exported C API.

* UIProcess/efl/WebView.cpp:
(WebKit::WebView::setShowsAsSource):
(WebKit):
(WebKit::WebView::showsAsSource):
(WebKit::WebView::exitFullScreen):
* UIProcess/efl/WebView.h:
(WebView):

    Added WebView methods to support added WKView API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, Web Inspector: follow up to r143328 fixing Win Debug Build
aandrey@chromium.org [Tue, 19 Feb 2013 16:47:31 +0000 (16:47 +0000)]
Unreviewed, Web Inspector: follow up to r143328 fixing Win Debug Build
https://bugs.webkit.org/show_bug.cgi?id=110227

Adding external symbol ?didBeginFrame@InspectorCanvasAgent@WebCore@@QAEXXZ.

* WebKit.vcproj/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[harfbuzz] Crash in harfbuzz related code
csaavedra@igalia.com [Tue, 19 Feb 2013 16:27:57 +0000 (16:27 +0000)]
[harfbuzz] Crash in harfbuzz related code
https://bugs.webkit.org/show_bug.cgi?id=110145

Reviewed by Martin Robinson.

Patch by Behdad Esfahbod <behdad@google.com>

* platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Ask harfbuzz
to guess the segment properties.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTest Expectations update after r143267 and others
schenney@chromium.org [Tue, 19 Feb 2013 16:27:13 +0000 (16:27 +0000)]
Test Expectations update after r143267 and others

Unreviewed expectations update.

Updated many Chromium expectations, and removed superfluous
expectations from mac and win.

* editing/selection/extend-by-sentence-001-expected.txt: Added.
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-linux-x86/svg/filters/big-sized-filter-2-expected.png: Removed.
* platform/chromium-linux-x86/svg/filters/shadow-on-filter-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug1188-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug1318-expected.png: Removed.
* platform/chromium-linux/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-linux/svg/batik/text/xmlSpace-expected.txt:
* platform/chromium-linux/svg/filters/big-sized-filter-2-expected.png: Removed.
* platform/chromium-linux/svg/filters/shadow-on-filter-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.txt:
* platform/chromium-mac-lion/editing/selection/extend-by-sentence-001-expected.png:
* platform/chromium-mac-lion/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-mac-lion/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
* platform/chromium-mac-lion/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
* platform/chromium-mac-lion/svg/filters/filter-on-tspan-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/extend-by-sentence-001-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/filters/big-sized-filter-2-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/filters/filter-on-tspan-expected.png:
* platform/chromium-mac-snowleopard/svg/filters/shadow-on-filter-expected.png: Removed.
* platform/chromium-mac/editing/selection/extend-by-sentence-001-expected.png:
* platform/chromium-mac/editing/selection/extend-by-sentence-001-expected.txt: Added.
* platform/chromium-mac/fast/inline/drawStyledEmptyInlines-expected.txt: Added.
* platform/chromium-mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
* platform/chromium-mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt: Added.
* platform/chromium-mac/fast/text/capitalize-empty-generated-string-expected.txt: Added.
* platform/chromium-mac/fast/text/whitespace/006-expected.txt: Added.
* platform/chromium-mac/fast/text/whitespace/007-expected.txt: Added.
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added property svn:mime-type.
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
* platform/chromium-mac/svg/batik/text/xmlSpace-expected.txt: Added.
* platform/chromium-mac/svg/custom/visibility-override-filter-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
* platform/chromium-mac/svg/filters/big-sized-filter-2-expected.png:
* platform/chromium-mac/svg/filters/feImage-reference-svg-primitive-expected.png:
* platform/chromium-mac/svg/filters/filter-on-tspan-expected.png:
* platform/chromium-mac/svg/filters/filterRes1-expected.png:
* platform/chromium-mac/svg/filters/filterRes3-expected.png:
* platform/chromium-mac/svg/filters/parent-children-with-same-filter-expected.png:
* platform/chromium-mac/svg/filters/shadow-on-filter-expected.png:
* platform/chromium-mac/svg/filters/shadow-on-rect-with-filter-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug113235-3-expected.txt: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.txt:
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Added.
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: Added.
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png: Added.
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png: Added.
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: Added.
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Added.
* platform/chromium-win-xp/svg/filters/big-sized-filter-2-expected.png: Removed.
* platform/chromium-win-xp/svg/filters/shadow-on-filter-expected.png: Removed.
* platform/chromium-win/editing/selection/extend-by-sentence-001-expected.txt:
* platform/chromium-win/fast/inline/drawStyledEmptyInlines-expected.txt:
* platform/chromium-win/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
* platform/chromium-win/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt:
* platform/chromium-win/fast/text/capitalize-empty-generated-string-expected.txt:
* platform/chromium-win/fast/text/whitespace/006-expected.txt:
* platform/chromium-win/fast/text/whitespace/007-expected.txt:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
* platform/chromium-win/svg/batik/text/xmlSpace-expected.txt:
* platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
* platform/chromium-win/svg/filters/big-sized-filter-2-expected.png:
* platform/chromium-win/svg/filters/feImage-reference-svg-primitive-expected.png:
* platform/chromium-win/svg/filters/filter-on-tspan-expected.png:
* platform/chromium-win/svg/filters/shadow-on-filter-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug113235-3-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug1188-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug1318-expected.txt:
* platform/chromium/TestExpectations:
* platform/chromium/editing/selection/extend-by-sentence-001-expected.txt: Removed.
* platform/chromium/fast/inline/drawStyledEmptyInlines-expected.txt: Removed.
* platform/chromium/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt: Removed.
* platform/chromium/fast/text/capitalize-empty-generated-string-expected.txt: Removed.
* platform/chromium/fast/text/whitespace/006-expected.txt: Removed.
* platform/chromium/fast/text/whitespace/007-expected.txt: Removed.
* platform/chromium/svg/batik/text/xmlSpace-expected.txt: Removed.
* platform/chromium/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Removed.
* platform/chromium/tables/mozilla/bugs/bug113235-3-expected.txt: Removed.
* platform/efl-wk2/svg/filters: Added.
* platform/efl-wk2/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
* platform/efl/svg/filters/shadow-on-rect-with-filter-expected.png: Removed.
* platform/gtk/editing/selection/extend-by-sentence-001-expected.txt: Removed.
* platform/mac/TestExpectations:
* platform/mac/editing/selection/extend-by-sentence-001-expected.txt: Removed.
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] ASSERT(node) hit in WebPage::findZoomableAreaForPoint if no zoomable area...
abecsi@webkit.org [Tue, 19 Feb 2013 16:26:25 +0000 (16:26 +0000)]
[Qt][WK2] ASSERT(node) hit in WebPage::findZoomableAreaForPoint if no zoomable area found
https://bugs.webkit.org/show_bug.cgi?id=110220

Reviewed by Allan Sandfeld Jensen.

If EventHandler::bestZoomableAreaForTouchPoint was unsuccessfull, eg.
no node was found for a given point, we hit ASSERT(node).
We should only assert for a valid node if a zoomable area was found.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::findZoomableAreaForPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: release backtrace object group on each step.
podivilov@chromium.org [Tue, 19 Feb 2013 16:12:47 +0000 (16:12 +0000)]
Web Inspector: release backtrace object group on each step.
https://bugs.webkit.org/show_bug.cgi?id=110223

Reviewed by Pavel Feldman.

* inspector/InspectorDebuggerAgent.cpp:
(WebCore):
(WebCore::InspectorDebuggerAgent::stepOver):
(WebCore::InspectorDebuggerAgent::stepInto):
(WebCore::InspectorDebuggerAgent::stepOut):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r142975.
commit-queue@webkit.org [Tue, 19 Feb 2013 16:01:52 +0000 (16:01 +0000)]
Unreviewed, rolling out r142975.
http://trac.webkit.org/changeset/142975
https://bugs.webkit.org/show_bug.cgi?id=110225

Introduces hard-to-reproduce crashes upon inspected page
navigation on Mac (Requested by apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19

Source/WebCore:

* dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::enable):
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::collectStyleSheets):
(WebCore::InspectorCSSAgent::bindStyleSheet):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
(WebCore::InspectorCSSAgent::detectOrigin):
(WebCore::InspectorCSSAgent::buildObjectForRule):
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
* inspector/InspectorInstrumentation.h:
(WebCore):
(InspectorInstrumentation):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getViaInspectorResourceForRule):
(WebInspector.CSSStyleModelResourceBinding.prototype.):
(WebInspector.CSSStyleModelResourceBinding.prototype.requestStyleSheetIdForResource):
(WebInspector.CSSStyleModelResourceBinding.prototype.requestResourceURLForStyleSheetId):
(WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetIdForResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._loadStyleSheetHeaders):
(WebInspector.CSSStyleModelResourceBinding.prototype.headersLoaded):
(WebInspector.CSSStyleModelResourceBinding.prototype._requestViaInspectorResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._getOrCreateInspectorResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._reset):
* inspector/front-end/SASSSourceMapping.js:
(WebInspector.SASSSourceMapping.prototype._styleSheetChanged.callback):
(WebInspector.SASSSourceMapping.prototype._styleSheetChanged):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode.callback):
(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode):
* inspector/front-end/StylesSourceMapping.js:
(WebInspector.StyleContentBinding.prototype.callback):
(WebInspector.StyleContentBinding.prototype.setStyleContent):
(WebInspector.StyleContentBinding.prototype.):
(WebInspector.StyleContentBinding.prototype._innerStyleSheetChanged):

LayoutTests:

* inspector/styles/resources/stylesheet-tracking.css: Removed.
* inspector/styles/stylesheet-tracking-expected.txt: Removed.
* inspector/styles/stylesheet-tracking.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRegression(r143273): Caused a lot of tests to time out
ch.dumez@sisa.samsung.com [Tue, 19 Feb 2013 15:53:51 +0000 (15:53 +0000)]
Regression(r143273): Caused a lot of tests to time out
https://bugs.webkit.org/show_bug.cgi?id=110212

Reviewed by Anders Carlsson.

StorageManager::destroySessionStorageNamespace() and StorageManager::cloneSessionStorageNamespace()
should call their respective "*Internal" equivalent instead of calling themselves. This lead to
a lot of time outs on our build bots.

* UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::destroySessionStorageNamespace):
(WebKit::StorageManager::cloneSessionStorageNamespace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderGrid::computedUsedBreadthOfGridTracks can read past m_grid's size
jchaffraix@webkit.org [Tue, 19 Feb 2013 15:36:16 +0000 (15:36 +0000)]
RenderGrid::computedUsedBreadthOfGridTracks can read past m_grid's size
https://bugs.webkit.org/show_bug.cgi?id=110126

Reviewed by Ojan Vafai.

Source/WebCore:

The issue comes from how we store the column information inside m_grid.
Because m_grid is a Vector of rows, we could lose the column information
if we had no row, no grid item but some columns defined in CSS. As the
logic would assume that our row / column size would be greater than what
the style defines explicitely, we would access past our Vector's boundary.

The fix is to ensure that we have at least a row so that we can store the
column information in every case. This fix is overly broad as it also forces
the grid to have one column, which shouldn't be an issue.

Test: fast/css-grid-layout/grid-element-empty-row-column.html

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::maximumIndexInDirection):
Forced this function to return at least one as the maximum index so that
m_grid has at least one row / column.

(WebCore::RenderGrid::placeItemsOnGrid):
Added a ASSERT that m_grid is bigger than the explicit grid-rows / grid-columns.
Also changed an existing ASSERT to use gridWasPopulated for consistency and changed
the code not to call gridRowCount as it would ASSERT (we are in the middle of populating
the grid).

* rendering/RenderGrid.h:
(WebCore::RenderGrid::gridWasPopulated):
Added this helper function.

(WebCore::RenderGrid::gridColumnCount):
Replaced a now unneeded branch with an ASSERT. As placeItemsOnGrid should be called
prior to read m_grid, this change should be fine.

(WebCore::RenderGrid::gridRowCount):
Added an ASSERT.

LayoutTests:

* fast/css-grid-layout/grid-element-empty-row-column-expected.txt: Added.
* fast/css-grid-layout/grid-element-empty-row-column.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 19 Feb 2013 15:19:02 +0000 (15:19 +0000)]
Unreviewed GTK gardening.

* platform/gtk/TestExpectations: Adding a crash expectation for the layout test
added in r143303. The test is crashing due to missing bits of EventSender implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Soup] Use synchronous calls to close completely processed streams
sergio@webkit.org [Tue, 19 Feb 2013 15:16:07 +0000 (15:16 +0000)]
[Soup] Use synchronous calls to close completely processed streams
https://bugs.webkit.org/show_bug.cgi?id=107432

Reviewed by Martin Robinson.

There is no need to close already processed streams in asynchronous
calls since they won't block. Using the synchronous call will save
us some code and unnecessary asynchronous burden. This is kind of
a code refactor so no new tests needed.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore):
(WebCore::redirectSkipCallback):
(WebCore::readCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Canvas] use timeline's didBeginFrame for marking frame end calls
aandrey@chromium.org [Tue, 19 Feb 2013 15:13:42 +0000 (15:13 +0000)]
Web Inspector: [Canvas] use timeline's didBeginFrame for marking frame end calls
https://bugs.webkit.org/show_bug.cgi?id=110130

Reviewed by Pavel Feldman.

In Web Inspector canvas profiler use timeline's didBeginFrame for marking frame end calls instead of an ad-hoc timeout-based solution.

* inspector/InjectedScriptCanvasModule.cpp:
(WebCore::InjectedScriptCanvasModule::markFrameEnd):
(WebCore):
* inspector/InjectedScriptCanvasModule.h:
(InjectedScriptCanvasModule):
* inspector/InjectedScriptCanvasModuleSource.js:
(.):
* inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::hasUninstrumentedCanvases):
(WebCore::InspectorCanvasAgent::notifyRenderingContextWasWrapped):
(WebCore::InspectorCanvasAgent::findFramesWithUninstrumentedCanvases):
(WebCore::InspectorCanvasAgent::frameNavigated):
(WebCore::InspectorCanvasAgent::didBeginFrame):
(WebCore):
* inspector/InspectorCanvasAgent.h:
(InspectorCanvasAgent):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::didBeginFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Decouple various file system project implementation parts for better...
vsevik@chromium.org [Tue, 19 Feb 2013 14:59:38 +0000 (14:59 +0000)]
Web Inspector: Decouple various file system project implementation parts for better testability and cover with tests.
https://bugs.webkit.org/show_bug.cgi?id=110204

Reviewed by Pavel Feldman.

Source/WebCore:

Extracted FileSystemWorkspaceProvider from IsolatedFileSystemManager to take care of managing workspace projects and projectDelegates.
Replaced FileMapping.urlForURI with urlForPath method that does not need any information about workspace structure anymore.

Test: inspector/file-system-project.html

* inspector/front-end/FileMapping.js:
(WebInspector.FileMapping.prototype.urlForPath):
* inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate):
(WebInspector.FileSystemProjectDelegate.prototype.populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype.populate):
(WebInspector.FileSystemWorkspaceProvider):
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemAdded):
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemRemoved):
* inspector/front-end/IsolatedFileSystem.js:
(WebInspector.IsolatedFileSystem):
(WebInspector.IsolatedFileSystem.prototype.name):
(WebInspector.IsolatedFileSystem.prototype.rootURL):
* inspector/front-end/IsolatedFileSystemManager.js:
(WebInspector.IsolatedFileSystemManager):
(WebInspector.IsolatedFileSystemManager.prototype._innerAddFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype._fileSystemRemoved):
(WebInspector.IsolatedFileSystemManager.prototype._isolatedFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype.requestDOMFileSystem):
* inspector/front-end/inspector.js:

LayoutTests:

* http/tests/inspector/inspector-test.js:
(initialize_InspectorTest):
(initialize_InspectorTest.):
* http/tests/inspector/workspace-test.js:
(initialize_WorkspaceTest.uiSourceCodeAdded):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent):
(initialize_WorkspaceTest.InspectorTest._defaultUISourceCodeProviderEventHandler):
* inspector/file-mapping-expected.txt:
* inspector/file-mapping.html:
* inspector/file-system-project-expected.txt: Added.
* inspector/file-system-project.html: Added.
* inspector/version-controller.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Skip the build with a warning if certain tools cannot be found in the PATH
hausmann@webkit.org [Tue, 19 Feb 2013 14:43:09 +0000 (14:43 +0000)]
[Qt] Skip the build with a warning if certain tools cannot be found in the PATH
https://bugs.webkit.org/show_bug.cgi?id=110215

Reviewed by Tor Arne Vestbø.

Check that gperf, python, ruby, perl, bison and flex are in the PATH before
continuing the build. Otherwise skip with an error message explaining which
programs are missing from the build.

* qmake/mkspecs/features/configure.prf:
* qmake/mkspecs/features/functions.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Canvas] do not replace replay image with spinner icon
aandrey@chromium.org [Tue, 19 Feb 2013 14:31:43 +0000 (14:31 +0000)]
Web Inspector: [Canvas] do not replace replay image with spinner icon
https://bugs.webkit.org/show_bug.cgi?id=110213

Reviewed by Pavel Feldman.

Otherwise it's visually hard to see changes in the replay image. Instead show a small spinner icon in the bottom right corner.

* inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype._enableWaitIcon):
* inspector/front-end/canvasProfiler.css:
(#canvas-replay-image-container):
(.canvas-debug-info):
(.canvas-spinner-icon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Canvas] UI: tweak replay control buttons behavior
aandrey@chromium.org [Tue, 19 Feb 2013 14:29:47 +0000 (14:29 +0000)]
Web Inspector: [Canvas] UI: tweak replay control buttons behavior
https://bugs.webkit.org/show_bug.cgi?id=110207

Reviewed by Pavel Feldman.

Source/WebCore:

New behavior for control buttons in the Canvas profiler.
- The NextCall button (~StepInto) on a node group should expand it and move into its first child (instead of expanding and moving into the next node group)
- The NextDrawCall button (~StepOver) should move to a next node that has children (instead of just iterating call group nodes, ignoring frame nodes).
- The ReplayLast button should select the last expanded node (instead of always selecting last frame group node).

* inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView.prototype._onReplayStepClick):
(WebInspector.CanvasProfileView.prototype._onReplayDrawingCallClick):
(WebInspector.CanvasProfileView.prototype._onReplayLastStepClick):

LayoutTests:

Testing control buttons behavior.

* inspector/profiler/canvas2d/canvas-replay-log-grid-expected.txt:
* inspector/profiler/canvas2d/canvas-replay-log-grid.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r143319.
commit-queue@webkit.org [Tue, 19 Feb 2013 13:54:44 +0000 (13:54 +0000)]
Unreviewed, rolling out r143319.
http://trac.webkit.org/changeset/143319
https://bugs.webkit.org/show_bug.cgi?id=110214

Causes build issues on win32 (Requested by carewolf on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19

Tools:

* qmake/mkspecs/features/features.pri:

LayoutTests:

* platform/qt/mathml/presentation/attributes-expected.png: Removed.
* platform/qt/mathml/presentation/attributes-expected.txt: Removed.
* platform/qt/mathml/presentation/fenced-expected.png: Removed.
* platform/qt/mathml/presentation/fenced-expected.txt: Removed.
* platform/qt/mathml/presentation/fenced-mi-expected.png: Removed.
* platform/qt/mathml/presentation/fenced-mi-expected.txt: Removed.
* platform/qt/mathml/presentation/fractions-expected.png: Removed.
* platform/qt/mathml/presentation/fractions-expected.txt: Removed.
* platform/qt/mathml/presentation/fractions-vertical-alignment-expected.png: Removed.
* platform/qt/mathml/presentation/fractions-vertical-alignment-expected.txt: Removed.
* platform/qt/mathml/presentation/mo-expected.png: Removed.
* platform/qt/mathml/presentation/mo-expected.txt: Removed.
* platform/qt/mathml/presentation/mo-stretch-expected.png: Removed.
* platform/qt/mathml/presentation/mo-stretch-expected.txt: Removed.
* platform/qt/mathml/presentation/mroot-pref-width-expected.png: Removed.
* platform/qt/mathml/presentation/mroot-pref-width-expected.txt: Removed.
* platform/qt/mathml/presentation/over-expected.png: Removed.
* platform/qt/mathml/presentation/over-expected.txt: Removed.
* platform/qt/mathml/presentation/roots-expected.png: Removed.
* platform/qt/mathml/presentation/roots-expected.txt: Removed.
* platform/qt/mathml/presentation/row-alignment-expected.png: Removed.
* platform/qt/mathml/presentation/row-alignment-expected.txt: Removed.
* platform/qt/mathml/presentation/row-expected.png: Removed.
* platform/qt/mathml/presentation/row-expected.txt: Removed.
* platform/qt/mathml/presentation/style-expected.png: Removed.
* platform/qt/mathml/presentation/style-expected.txt: Removed.
* platform/qt/mathml/presentation/sub-expected.png: Removed.
* platform/qt/mathml/presentation/sub-expected.txt: Removed.
* platform/qt/mathml/presentation/subsup-expected.png: Removed.
* platform/qt/mathml/presentation/subsup-expected.txt: Removed.
* platform/qt/mathml/presentation/sup-expected.png: Removed.
* platform/qt/mathml/presentation/sup-expected.txt: Removed.
* platform/qt/mathml/presentation/tables-expected.png: Removed.
* platform/qt/mathml/presentation/tables-expected.txt: Removed.
* platform/qt/mathml/presentation/tokenElements-expected.png: Removed.
* platform/qt/mathml/presentation/tokenElements-expected.txt: Removed.
* platform/qt/mathml/presentation/under-expected.png: Removed.
* platform/qt/mathml/presentation/under-expected.txt: Removed.
* platform/qt/mathml/presentation/underover-expected.png: Removed.
* platform/qt/mathml/presentation/underover-expected.txt: Removed.
* platform/qt/mathml/xHeight-expected.png: Removed.
* platform/qt/mathml/xHeight-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] Assertion in RenderFlowThread::removeRenderBoxRegionInfo
abucur@adobe.com [Tue, 19 Feb 2013 13:44:42 +0000 (13:44 +0000)]
[CSS Regions] Assertion in RenderFlowThread::removeRenderBoxRegionInfo
https://bugs.webkit.org/show_bug.cgi?id=109914

Reviewed by David Hyatt.

Source/WebCore:

This patch moves a part of the invalidation operations inside the RenderFlowThread::invalidateRegions call. The maps
are cleared anyway at layout time but doing this earlier makes sure the flow thread is in a more consistent state
(the RenderFlowThread object has both the region chain invalidated and the regions information cleared).

RenderFlowThread::removeRenderBoxRegionInfo will check if the region chain is invalidated. If true, it means the
flow thread has a layout scheduled and the regions information is not yet reliable. In this case we just return from the
function and wait for the layout to cleanup the box information.

Test: fast/regions/remove-box-info-assert.html

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::invalidateRegions):
(WebCore):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
* rendering/RenderFlowThread.h:
* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::removeRegionFromThread):

LayoutTests:

The test creates a flow thread with two regions and a content node. We remove the region and the node from the flow thread
at the same time. When the style is updated, the region is first removed from the chain and range information for boxes
is cleared from the flow thread. When the node is removed from the flow thread it tries to delete its region box information.
The range information on the flow thread is gone so the range for the node's box is zero - nothing gets deleted. Afterwards,
an ASSERT is triggered because there's leftover box information inside the region chain.

* fast/regions/remove-box-info-assert-expected.txt: Added.
* fast/regions/remove-box-info-assert.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening.
senorblanco@chromium.org [Tue, 19 Feb 2013 13:30:40 +0000 (13:30 +0000)]
[chromium] Unreviewed gardening.
New baselines for effect-reference.html and effect-reference-hw.html

* platform/chromium-linux-x86/css3/filters/effect-reference-expected.png: Added.
* platform/chromium-linux-x86/css3/filters/effect-reference-expected.txt: Copied from LayoutTests/platform/chromium-win/css3/filters/effect-reference-expected.txt.
* platform/chromium-linux/css3/filters/effect-reference-expected.png: Added.
* platform/chromium-linux/css3/filters/effect-reference-expected.txt: Copied from LayoutTests/platform/chromium-win/css3/filters/effect-reference-expected.txt.
* platform/chromium-linux/css3/filters/effect-reference-hw-expected.png:
* platform/chromium-mac-lion/css3/filters/effect-reference-expected.png: Added.
* platform/chromium-mac-lion/css3/filters/effect-reference-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/css3/filters/effect-reference-hw-expected.txt.
* platform/chromium-mac-snowleopard/css3/filters/effect-reference-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-reference-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/css3/filters/effect-reference-hw-expected.txt.
* platform/chromium-mac/css3/filters/effect-reference-expected.png:
* platform/chromium-mac/css3/filters/effect-reference-expected.txt:
* platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-reference-hw-expected.txt:
* platform/chromium-win-xp/css3/filters/effect-reference-expected.png: Added.
* platform/chromium-win-xp/css3/filters/effect-reference-expected.txt: Copied from LayoutTests/platform/chromium-win/css3/filters/effect-reference-expected.txt.
* platform/chromium-win/css3/filters/effect-reference-expected.png:
* platform/chromium-win/css3/filters/effect-reference-expected.txt:
* platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
* platform/chromium-win/css3/filters/effect-reference-hw-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix build broekn by r142988.
keishi@webkit.org [Tue, 19 Feb 2013 13:15:48 +0000 (13:15 +0000)]
Fix build broekn by r142988.
https://bugs.webkit.org/show_bug.cgi?id=109530

Unreviewed. Build fix.

Properly add shortMonthFormat() to the LocaleNone class.

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-02-19

* platform/text/LocaleNone.cpp:
(LocaleNone):
(WebCore::LocaleNone::shortMonthFormat):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Enable MathML
allan.jensen@digia.com [Tue, 19 Feb 2013 13:02:50 +0000 (13:02 +0000)]
[Qt] Enable MathML
https://bugs.webkit.org/show_bug.cgi?id=110205

Reviewed by Simon Hausmann.

Tools:

    * qmake/mkspecs/features/features.pri:

LayoutTests:

    Baselines for the MathML tests.

    * platform/qt/mathml/presentation/attributes-expected.png: Added.
    * platform/qt/mathml/presentation/attributes-expected.txt: Added.
    * platform/qt/mathml/presentation/fenced-expected.png: Added.
    * platform/qt/mathml/presentation/fenced-expected.txt: Added.
    * platform/qt/mathml/presentation/fenced-mi-expected.png: Added.
    * platform/qt/mathml/presentation/fenced-mi-expected.txt: Added.
    * platform/qt/mathml/presentation/fractions-expected.png: Added.
    * platform/qt/mathml/presentation/fractions-expected.txt: Added.
    * platform/qt/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
    * platform/qt/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
    * platform/qt/mathml/presentation/mo-expected.png: Added.
    * platform/qt/mathml/presentation/mo-expected.txt: Added.
    * platform/qt/mathml/presentation/mo-stretch-expected.png: Added.
    * platform/qt/mathml/presentation/mo-stretch-expected.txt: Added.
    * platform/qt/mathml/presentation/mroot-pref-width-expected.png: Added.
    * platform/qt/mathml/presentation/mroot-pref-width-expected.txt: Added.
    * platform/qt/mathml/presentation/over-expected.png: Added.
    * platform/qt/mathml/presentation/over-expected.txt: Added.
    * platform/qt/mathml/presentation/roots-expected.png: Added.
    * platform/qt/mathml/presentation/roots-expected.txt: Added.
    * platform/qt/mathml/presentation/row-alignment-expected.png: Added.
    * platform/qt/mathml/presentation/row-alignment-expected.txt: Added.
    * platform/qt/mathml/presentation/row-expected.png: Added.
    * platform/qt/mathml/presentation/row-expected.txt: Added.
    * platform/qt/mathml/presentation/style-expected.png: Added.
    * platform/qt/mathml/presentation/style-expected.txt: Added.
    * platform/qt/mathml/presentation/sub-expected.png: Added.
    * platform/qt/mathml/presentation/sub-expected.txt: Added.
    * platform/qt/mathml/presentation/subsup-expected.png: Added.
    * platform/qt/mathml/presentation/subsup-expected.txt: Added.
    * platform/qt/mathml/presentation/sup-expected.png: Added.
    * platform/qt/mathml/presentation/sup-expected.txt: Added.
    * platform/qt/mathml/presentation/tables-expected.png: Added.
    * platform/qt/mathml/presentation/tables-expected.txt: Added.
    * platform/qt/mathml/presentation/tokenElements-expected.png: Added.
    * platform/qt/mathml/presentation/tokenElements-expected.txt: Added.
    * platform/qt/mathml/presentation/under-expected.png: Added.
    * platform/qt/mathml/presentation/under-expected.txt: Added.
    * platform/qt/mathml/presentation/underover-expected.png: Added.
    * platform/qt/mathml/presentation/underover-expected.txt: Added.
    * platform/qt/mathml/xHeight-expected.png: Added.
    * platform/qt/mathml/xHeight-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Text Autosizing] Combine narrow descendants of a cluster into groups that should...
commit-queue@webkit.org [Tue, 19 Feb 2013 12:45:26 +0000 (12:45 +0000)]
[Text Autosizing] Combine narrow descendants of a cluster into groups that should be autosized with the same multiplier.
https://bugs.webkit.org/show_bug.cgi?id=109825

Source/WebCore:

Enhancement of the approach introduced in https://bugs.webkit.org/show_bug.cgi?id=109573.
Instead of using the same text size multiplier for all narrow descendants of any autosizing
cluster, group the descendants by how much narrower they are than the cluster's
|blockContainingAllText| and process each group separately with a different multiplier for
each one.
For example, we want nested comments on the page to be autosized as a group but separately
from a sidebar on the same page.

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-19
Reviewed by Kenneth Rohde Christiansen.

Updated the existing test to verify the patch.

* rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::processClusterInternal):

    Splits the narrow descendants of the autosizing cluster into groups before processing
    each group individually.

(WebCore::TextAutosizer::getNarrowDescendantsGroupedByWidth):

    Sorts the narrow descendants of the given cluster into groups, combining them by the
    difference between their content widths. If sorted by width, two consecutive nodes
    belong to the same group if their width difference is no greater than 100 CSS units.

* rendering/TextAutosizer.h:

    New method definitions.

LayoutTests:

Verify that narrow descendants are grouped and autosized separately according to the
difference between the descendant's width and the width of its enclosing cluster's
|blockContainingAllText|.

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-19
Reviewed by Kenneth Rohde Christiansen.

* fast/text-autosizing/narrow-descendants-combined-expected.html:
* fast/text-autosizing/narrow-descendants-combined.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Native Memory Instrumentation: show user provided name property of...
loislo@chromium.org [Tue, 19 Feb 2013 12:21:12 +0000 (12:21 +0000)]
Web Inspector: Native Memory Instrumentation: show user provided name property of the heap snapshot node.
https://bugs.webkit.org/show_bug.cgi?id=110124

Reviewed by Yury Semikhatsky.

Publish userProvidedName into grid node.

* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotWorker):
* inspector/front-end/NativeHeapSnapshot.js:
(WebInspector.NativeHeapSnapshotNode.prototype.serialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Adding myself as a committer.
abucur@adobe.com [Tue, 19 Feb 2013 12:15:11 +0000 (12:15 +0000)]
Unreviewed. Adding myself as a committer.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, gardening for chromium.
toyoshim@chromium.org [Tue, 19 Feb 2013 11:46:40 +0000 (11:46 +0000)]
Unreviewed, gardening for chromium.
https://bugs.webkit.org/show_bug.cgi?id=110203

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r143241): It made 27 layout tests crash on 32 bit platforms
fpizlo@apple.com [Tue, 19 Feb 2013 10:41:39 +0000 (10:41 +0000)]
REGRESSION(r143241): It made 27 layout tests crash on 32 bit platforms
https://bugs.webkit.org/show_bug.cgi?id=110184

Reviewed by Zoltan Herczeg.

32-bit backend was making all sorts of crazy assumptions, which happened to mostly
not break things prior to http://trac.webkit.org/changeset/143241. This brings the
32-bit backend's type speculation fully into compliance with what the 64-bit
backend does.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCaret is not displayed when trying to focus inside a contenteditable element containi...
commit-queue@webkit.org [Tue, 19 Feb 2013 10:14:07 +0000 (10:14 +0000)]
Caret is not displayed when trying to focus inside a contenteditable element containing an empty block.
https://bugs.webkit.org/show_bug.cgi?id=108053

Source/WebCore:

Patch by Arpita Bahuguna <a.bah@samsung.com> on 2013-02-19
Reviewed by Ryosuke Niwa.

Test: editing/selection/caret-in-div-containing-empty-block.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::localCaretRect):
When trying to compute the caret rect for the contenteditable div, the
border and the padding were not considered. Because of this, for the
given test case, which had a border defined on the containing div, the
caret was being painted just atop the border, thereby masking it.

Have modified the code to ensure that the computed caret rect takes
into account the border and padding (if any) specified on the box, but only
if the node doesn't have content that shall be skipped for editing.

We do not add border and padding while computing the caret rect for any
element that either has no content or has content that shall be skipped
for editing purposes. This holds true for table elements as well.

This helps avoid the caret displacement previsouly observed before/after
any controls placed within the contenteditable box, when considering
border and padding in computation of the caret rect.

LayoutTests:

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2013-02-19
Reviewed by Ryosuke Niwa.

* editing/selection/caret-in-div-containing-empty-block-expected.txt: Added.
* editing/selection/caret-in-div-containing-empty-block.html: Added.
Layout test added for verifying that a caret is displayed within a
contenteditable div having a border, both for the horizontal
as well as the vertical writing modes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSSRegions: crash positioned object with inline containing block in flow thread
mihnea@adobe.com [Tue, 19 Feb 2013 09:56:15 +0000 (09:56 +0000)]
CSSRegions: crash positioned object with inline containing block in flow thread
https://bugs.webkit.org/show_bug.cgi?id=108307

Reviewed by David Hyatt.

Source/WebCore:

The fix for https://bugs.webkit.org/show_bug.cgi?id=69896 allowed positioned blocks work
with variable width regions. However, the information needed for that is available only
when the container used for positioning is a block.

This patch ensures we are using this solution only when the container used for positioning
is a block. This needs to be revisited when we will extend support for other types of boxes
as mentioned in RenderBox::renderBoxRegionInfo.

Test: fast/regions/positioned-object-inline-cb-crash.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::renderBoxRegionInfo):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidth): Make sure we are using containerBlocks
that are blocks. Add an assert that the type of containerBlock we are using can have
computed RenderBoxRegionInfo.
(WebCore::RenderBox::computePositionedLogicalHeight):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::canHaveBoxInfoInRegion): This helper method
will return the boxes that may have computed RenderBoxRegionInfo. Currently,
returns true for blocks only.

LayoutTests:

* fast/regions/positioned-object-inline-cb-crash-expected.txt: Added.
* fast/regions/positioned-object-inline-cb-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143312 268f45cc-cd09-0410-ab3c-d52691b4dbfc