WebKit-https.git
14 months ago[MediaCapabilities] Platform integration
philn@webkit.org [Sun, 5 Aug 2018 09:26:00 +0000 (09:26 +0000)]
[MediaCapabilities] Platform integration
https://bugs.webkit.org/show_bug.cgi?id=187850

Reviewed by Eric Carlson.

Source/WebCore:

Mock platform support for the MediaCapabilities specification.

Test: media/mediacapabilities/mock-decodingInfo.html
      media/mediacapabilities/mock-encodingInfo.html

* Modules/mediacapabilities/MediaCapabilities.cpp:
(WebCore::MediaCapabilities::decodingInfo):
(WebCore::MediaCapabilities::encodingInfo):
* Modules/mediacapabilities/MediaCapabilitiesInfo.h:
(WebCore::MediaCapabilitiesInfo::create):
* PlatformGTK.cmake:
* PlatformMac.cmake:
* PlatformWPE.cmake:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* platform/mediacapabilities/MediaEngineConfiguration.cpp: Added.
(WebCore::MediaEngineVideoConfiguration::MediaEngineVideoConfiguration):
(WebCore::MediaEngineAudioConfiguration::MediaEngineAudioConfiguration):
(WebCore::MediaEngineConfiguration::MediaEngineConfiguration):
* platform/mediacapabilities/MediaEngineConfiguration.h: Added.
(WebCore::MediaEngineVideoConfiguration::create):
(WebCore::MediaEngineVideoConfiguration::contentType const):
(WebCore::MediaEngineVideoConfiguration::size const):
(WebCore::MediaEngineVideoConfiguration::bitrate const):
(WebCore::MediaEngineVideoConfiguration::framerate const):
(WebCore::MediaEngineAudioConfiguration::create):
(WebCore::MediaEngineAudioConfiguration::contentType const):
(WebCore::MediaEngineAudioConfiguration::channels const):
(WebCore::MediaEngineAudioConfiguration::bitrate const):
(WebCore::MediaEngineAudioConfiguration::samplerate const):
(WebCore::MediaEngineConfiguration::audioConfiguration const):
(WebCore::MediaEngineConfiguration::videoConfiguration const):
* platform/mediacapabilities/MediaEngineConfigurationFactory.cpp: Added.
(WebCore::mockEnabled):
(WebCore::MediaEngineConfigurationFactory::createDecodingConfiguration):
(WebCore::MediaEngineConfigurationFactory::createEncodingConfiguration):
(WebCore::MediaEngineConfigurationFactory::enableMock):
(WebCore::MediaEngineConfigurationFactory::disableMock):
* platform/mediacapabilities/MediaEngineConfigurationFactory.h: Added.
* platform/mediacapabilities/MediaEngineDecodingConfiguration.h: Added.
(WebCore::MediaEngineDecodingConfiguration::MediaEngineDecodingConfiguration):
(WebCore::MediaEngineDecodingConfiguration::canDecodeMedia):
(WebCore::MediaEngineDecodingConfiguration::canSmoothlyDecodeMedia):
(WebCore::MediaEngineDecodingConfiguration::canPowerEfficientlyDecodeMedia):
(WebCore::MediaEngineDecodingConfiguration::decodingType const):
* platform/mediacapabilities/MediaEngineEncodingConfiguration.h: Added.
(WebCore::MediaEngineEncodingConfiguration::MediaEngineEncodingConfiguration):
(WebCore::MediaEngineEncodingConfiguration::canEncodeMedia):
(WebCore::MediaEngineEncodingConfiguration::canSmoothlyEncodeMedia):
(WebCore::MediaEngineEncodingConfiguration::canPowerEfficientlyEncodeMedia):
(WebCore::MediaEngineEncodingConfiguration::encodingType const):
* platform/mock/MediaEngineDecodingConfigurationMock.cpp: Added.
(WebCore::MediaEngineDecodingConfigurationMock::canDecodeMedia):
(WebCore::MediaEngineDecodingConfigurationMock::canSmoothlyDecodeMedia):
(WebCore::MediaEngineDecodingConfigurationMock::canPowerEfficientlyDecodeMedia):
* platform/mock/MediaEngineDecodingConfigurationMock.h: Added.
* platform/mock/MediaEngineEncodingConfigurationMock.cpp: Added.
(WebCore::MediaEngineEncodingConfigurationMock::canEncodeMedia):
(WebCore::MediaEngineEncodingConfigurationMock::canSmoothlyEncodeMedia):
(WebCore::MediaEngineEncodingConfigurationMock::canPowerEfficientlyEncodeMedia):
* platform/mock/MediaEngineEncodingConfigurationMock.h: Added.
* testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::enableMockMediaCapabilities):
* testing/Internals.h:
* testing/Internals.idl:

LayoutTests:

Mock tests for the MediaCapabilities specification.

* media/mediacapabilities/mock-decodingInfo-expected.txt: Added.
* media/mediacapabilities/mock-decodingInfo.html: Added.
* media/mediacapabilities/mock-encodingInfo-expected.txt: Added.
* media/mediacapabilities/mock-encodingInfo.html: Added.
* media/video-test.js:
(checkMediaCapabilitiesInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoMake WebCore::Timer more space-efficient
simon.fraser@apple.com [Sat, 4 Aug 2018 22:57:13 +0000 (22:57 +0000)]
Make WebCore::Timer more space-efficient
https://bugs.webkit.org/show_bug.cgi?id=187455

Reviewed by Brent Fulgham.

Steal a bit from m_heapIndex for m_wasDeleted to eliminate padding in Timer.
This reduces the size of Document, which has 8 Timers, from 3360 to 3296 bytes (saving 64 bytes).

* platform/Timer.cpp:
(WebCore::TimerBase::TimerBase):
* platform/Timer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoREGRESSION (r208953): TemplateObjectDescriptor constructor calculates m_hash on use...
ddkilzer@apple.com [Sat, 4 Aug 2018 20:07:13 +0000 (20:07 +0000)]
REGRESSION (r208953): TemplateObjectDescriptor constructor calculates m_hash on use-after-move variable
<https://webkit.org/b/188331>

Reviewed by Yusuke Suzuki.

* runtime/TemplateObjectDescriptor.h:
(JSC::TemplateObjectDescriptor::TemplateObjectDescriptor):
Use `m_rawstrings` instead of `rawStrings` to calculate hash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoSort the WebCore project file
simon.fraser@apple.com [Sat, 4 Aug 2018 17:38:13 +0000 (17:38 +0000)]
Sort the WebCore project file

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoProperties set on window.customElements can disappear due to GC
rniwa@webkit.org [Sat, 4 Aug 2018 09:02:44 +0000 (09:02 +0000)]
Properties set on window.customElements can disappear due to GC
https://bugs.webkit.org/show_bug.cgi?id=172575
<rdar://problem/32440668>

Reviewed by Saam Barati.

Source/WebCore:

Fixed the bug that JS wrapper of CustomElementsRegistry can erroneously get collected during GC
by keeping it alive as long as the global object is alive.

Test: fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html

* dom/CustomElementRegistry.cpp:
(WebCore::CustomElementRegistry::create):
(WebCore::CustomElementRegistry::CustomElementRegistry):
* dom/CustomElementRegistry.h:
(WebCore::CustomElementRegistry): Make this inherited from ContextDestructionObserver.
* dom/CustomElementRegistry.idl: Set GenerateIsReachable=ImplScriptExecutionContext in IDL. This will
make CustomElementRegistry reachable from the global object.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::ensureCustomElementRegistry):

LayoutTests:

Added a regression test.

* fast/custom-elements/custom-element-registry-wrapper-should-stay-alive-expected.txt: Added.
* fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoinnerHTML should not synchronously create a custom element
rniwa@webkit.org [Sat, 4 Aug 2018 06:35:37 +0000 (06:35 +0000)]
innerHTML should not synchronously create a custom element
https://bugs.webkit.org/show_bug.cgi?id=188327
<rdar://problem/42923114>

Reviewed by Daniel Bates.

LayoutTests/imported/w3c:

Rebaselined the test now that all test cases are passing.

* web-platform-tests/custom-elements/connected-callbacks-html-fragment-parsing-expected.txt:

Source/WebCore:

Fixed the bug that the fragment parsing algorithm was synchronously constructing a custom element instead of
enqueuing an element to upgrade.

The fragment parsing algorithm creates an element for a token with *will execute script* flag set to false:
https://html.spec.whatwg.org/multipage/parsing.html#create-an-element-for-the-token
which results in creating an element with synchronous custom elements flag *not* set:
https://dom.spec.whatwg.org/#concept-create-element

When synchronous custom elements flag is false, we're supposed to create an element and enqueue a custom element
upgrade reaction. createHTMLElementOrFindCustomElementInterface was missing this last logic.

Also fixed a bug that Element::enqueueToUpgrade would hit a debug assertion when a custom element which has been
enqueued to upgrade is enqueued to upgrade for the second time. In this case, we need to put the element into the
current element queue (https://html.spec.whatwg.org/multipage/custom-elements.html#current-element-queue) again.

While the specification simply enqueues another upgrade reaction and bails out immediately in the first step of
the upgrade, WebKit's implementation simply avoids this redundancy in the first place:
https://html.spec.whatwg.org/multipage/custom-elements.html#concept-upgrade-an-element

Existing tests such as imported/w3c/web-platform-tests/custom-elements/reactions/Document.html exercises this
code path after the fragment parsing algorithm fix.

Tests: imported/w3c/web-platform-tests/custom-elements/connected-callbacks-html-fragment-parsing.html

* dom/CustomElementReactionQueue.cpp:
(WebCore::CustomElementReactionQueueItem::type const): Added for an assertion.
(WebCore::CustomElementReactionQueue::enqueueElementUpgrade): Enqueue this element to the current element queue
by calling ensureCurrentQueue and avoid inserting a redundant upgrade reaction.
* dom/CustomElementReactionQueue.h:
* dom/Element.cpp:
(WebCore::Element::enqueueToUpgrade): Handle the case when a custom element is enqueued to upgrade for the second
time while it had been waiting in some element queue. In this case, the reaction queue for this element has
already been created and we simply need to put this element back into the current element queue (i.e. this element
now belongs to both element queues).
* html/parser/HTMLConstructionSite.cpp:
(WebCore::findCustomElementInterface): Extracted out of createHTMLElementOrFindCustomElementInterface.
(WebCore::HTMLConstructionSite::createHTMLElementOrFindCustomElementInterface): Fixed the bug that the HTML parser
was synchronously constructing a custom element even for the fragment parsing algorithm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoGive the `jsc` shell the JIT entitlement
sbarati@apple.com [Sat, 4 Aug 2018 06:27:23 +0000 (06:27 +0000)]
Give the `jsc` shell the JIT entitlement
https://bugs.webkit.org/show_bug.cgi?id=188324
<rdar://problem/42885806>

Reviewed by Dan Bernstein.

This should help us in ensuring the system jsc is able to JIT.

* Configurations/JSC.xcconfig:
* JavaScriptCore.xcodeproj/project.pbxproj:
* allow-jit-macOS.entitlements: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoWe should cache the compiled sandbox profile in a data vault
commit-queue@webkit.org [Sat, 4 Aug 2018 01:09:37 +0000 (01:09 +0000)]
We should cache the compiled sandbox profile in a data vault
https://bugs.webkit.org/show_bug.cgi?id=184991

Patch by Ben Richards <benton_richards@apple.com> on 2018-08-03
Reviewed by Ryosuke Niwa.

Source/WebCore:

Added functionality to FileHandle so that it can lock a file while open.
Added a function to FileSystem to delete non empty directories.

* platform/FileHandle.cpp:
(WebCore::FileHandle::FileHandle):
(WebCore::FileHandle::open):
(WebCore::FileHandle::close):
* platform/FileHandle.h:
* platform/FileSystem.h:
* platform/cocoa/FileSystemCocoa.mm:
(WebCore::FileSystem::deleteNonEmptyDirectory):

Source/WebKit:

This patch changes a few things (note: data vaults and sandbox entitlements are only used in internal builds):
(1) Instead of compiling a sandbox every time a process is launched, processes now look for a cached sandbox
    in a process specific data vault on macOS platforms. (ChildProcessMac.mm)
(2) If a valid cached sandbox is not found, a process will create the data vault (or ensure that it exists),
    compile a sandbox, and cache it.
(3) In order to create process specific data vaults, each process now has their own <process name>-OSX-sandbox.entitlements
    file which contains an entitlement with a process specific "storage class" which ensures that each process
    can only ever access its own data vault. (See the article on confluence "Data Vaults and Restricted Files" for more info)
(4) The sandbox entitlements file for the Network, WebContent and Plugin services are loaded dynamically
    through Scripts/<process name>-process-entitlements.sh which is triggered in a new build phase for each service.
    The Storage process sandbox entitlements are loaded directly in Configurations/StorageService.xcconfig.
    The reason that the sandbox entitlements are applied dynamically is so that these sandbox entitlements
    are only applied when WK_USE_RESTRICTED_ENTITLEMENTS is YES. This means that open source builds will still work.

* Configurations/Network-OSX-sandbox.entitlements: Added.
* Configurations/Plugin-OSX-sandbox.entitlements: Added.
* Configurations/Storage-OSX-sandbox.entitlements: Added.
* Configurations/StorageService.xcconfig:
* Configurations/WebContent-OSX-sandbox.entitlements: Added.
* Configurations/WebKit.xcconfig:
* NetworkProcess/NetworkProcess.h:
* PluginProcess/PluginProcess.h:
* Scripts/process-network-entitlements.sh: Added.
* Scripts/process-plugin-entitlements.sh: Added.
* Scripts/process-webcontent-entitlements.sh:
* Shared/ChildProcess.h:
* Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
(WebKit::XPCServiceInitializer):
* Shared/SandboxInitializationParameters.h:
(WebKit::SandboxInitializationParameters::setOverrideSandboxProfilePath):
(WebKit::SandboxInitializationParameters::overrideSandboxProfilePath const):
(WebKit::SandboxInitializationParameters::setSandboxProfile):
(WebKit::SandboxInitializationParameters::sandboxProfile const):
(): Deleted.
* Shared/mac/ChildProcessMac.mm:
(WebKit::SandboxProfileDeleter::operator()):
(WebKit::SandboxParametersDeleter::operator()):
(WebKit::SandboxInfo::SandboxInfo):
(WebKit::fileContents):
(WebKit::processStorageClass):
(WebKit::setAndSerializeSandboxParameters):
(WebKit::getUserCacheDirectory):
(WebKit::sandboxDataVaultParentDirectory):
(WebKit::sandboxDirectory):
(WebKit::sandboxFilePath):
(WebKit::ensureSandboxCacheDirectory):
(WebKit::writeSandboxDataToCacheFile):
(WebKit::compileAndCacheSandboxProfile):
(WebKit::tryApplyCachedSandbox):
(WebKit::webKit2Bundle):
(WebKit::sandboxProfilePath):
(WebKit::compileAndApplySandboxSlowCase):
(WebKit::applySandbox):
(WebKit::initializeSandboxParameters):
(WebKit::ChildProcess::initializeSandbox):
* Shared/mac/SandboxInitialiationParametersMac.mm:
(WebKit::SandboxInitializationParameters::SandboxInitializationParameters):
* StorageProcess/StorageProcess.h:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/WebProcess.h:

Source/WTF:

Added trace points for sandbox initialization and exposed functions needed for sandbox caching

* wtf/SystemTracing.h:
* wtf/spi/darwin/SandboxSPI.h:

Tools:

Added trace points for sandbox initialization

* Tracing/SystemTracePoints.plist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoWebGL 2 conformance: vertex_arrays/vertex_array_object.html
commit-queue@webkit.org [Sat, 4 Aug 2018 00:11:49 +0000 (00:11 +0000)]
WebGL 2 conformance: vertex_arrays/vertex_array_object.html
https://bugs.webkit.org/show_bug.cgi?id=188291
<rdar://problem/42792709>

Source/WebCore:

Patch by Justin Fan <justin_fan@apple.com> on 2018-08-03
Reviewed by Dean Jackson.

Get https://www.khronos.org/registry/webgl/conformance-suites/2.0.0/conformance2/vertex_arrays/vertex-array-object.html
working on Mac OS and iOS, and check in the new test expectations.

Existing test: webgl/2.0.0/conformance2/vertex_arrays/vertex-array-object.html

* html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::initializeVertexArrayObjects):
(WebCore::WebGL2RenderingContext::deleteVertexArray):
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::deleteObject):
* html/canvas/WebGLVertexArrayObject.cpp:
(WebCore::WebGLVertexArrayObject::WebGLVertexArrayObject):
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::checkVaryingsPacking const):
(WebCore::GraphicsContext3D::createVertexArray):
(WebCore::GraphicsContext3D::deleteVertexArray):
(WebCore::GraphicsContext3D::isVertexArray):
(WebCore::GraphicsContext3D::bindVertexArray):

LayoutTests:

Get https://www.khronos.org/registry/webgl/conformance-suites/2.0.0/conformance2/vertex_arrays/vertex-array-object.html
working on Mac OS and iOS, and check in the new test expectations.

Patch by Justin Fan <justin_fan@apple.com> on 2018-08-03
Reviewed by Dean Jackson.

* TestExpectations: No longer skipping vertex_arrays tests.
The following FAILed before this patch but are now expecting PASSes.
* webgl/2.0.0/conformance2/glsl3/array-as-return-value-expected.txt:
* webgl/2.0.0/conformance2/glsl3/array-assign-constructor-expected.txt:
* webgl/2.0.0/conformance2/glsl3/array-assign-expected.txt:
* webgl/2.0.0/conformance2/glsl3/array-complex-indexing-expected.txt:
* webgl/2.0.0/conformance2/glsl3/array-element-increment-expected.txt:
* webgl/2.0.0/conformance2/glsl3/array-equality-expected.txt:
* webgl/2.0.0/conformance2/glsl3/array-in-complex-expression-expected.txt:
* webgl/2.0.0/conformance2/glsl3/bool-type-cast-bug-uint-ivec-uvec-expected.txt:
* webgl/2.0.0/conformance2/glsl3/compare-structs-containing-arrays-expected.txt:
* webgl/2.0.0/conformance2/glsl3/const-array-init-expected.txt:
* webgl/2.0.0/conformance2/glsl3/frag-depth-expected.txt:
* webgl/2.0.0/conformance2/glsl3/loops-with-side-effects-expected.txt:
* webgl/2.0.0/conformance2/glsl3/no-attribute-vertex-shader-expected.txt:
* webgl/2.0.0/conformance2/glsl3/short-circuiting-in-loop-condition-expected.txt:
* webgl/2.0.0/conformance2/glsl3/tricky-loop-conditions-expected.txt:
* webgl/2.0.0/conformance2/glsl3/vector-dynamic-indexing-expected.txt:
* webgl/2.0.0/conformance2/glsl3/vector-dynamic-indexing-nv-driver-bug-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoSkip imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_abort...
ryanhaddad@apple.com [Fri, 3 Aug 2018 23:59:33 +0000 (23:59 +0000)]
Skip imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_abort.html.
https://bugs.webkit.org/show_bug.cgi?id=187269

Unreviewed test gardening.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoRemove WebGPUObject
commit-queue@webkit.org [Fri, 3 Aug 2018 23:25:56 +0000 (23:25 +0000)]
Remove WebGPUObject
https://bugs.webkit.org/show_bug.cgi?id=188114

Patch by Sam Weinig <sam@webkit.org> on 2018-08-03
Reviewed by Darin Adler.

This removes the unecessary WebGPUObject base class and updates the classes
that were inheriting from it to instead inherit directly from RefCounted. This
shrinks the size of all the classes that were inheriting from it, as they no
longer store a RefPtr<WebGPURenderingContext> member, which is unused. Most
of the classes also shrink because they can be devirtualized.

This also updates most of the create functions and constructors for the classes
that were inheriting from WebGPUObject to no longer require the WebGPURenderingContext
to be passed in.
- For WebGPUBuffer, WebGPUCommandQueue, WebGPUComputeCommandEncoder, WebGPUComputePipelineState,
WebGPUDepthStencilState, WebGPUDrawable, WebGPUFunction, WebGPULibrary, WebGPURenderCommandEncoder,
WebGPURenderPassDepthAttachmentDescriptor, WebGPURenderPipelineColorAttachmentDescriptor,
WebGPURenderPipelineState, and WebGPUTexture the WebGPURenderingContext and any other additional
parameters needed for initialization were replaced with the underlying type (e.g. WebGPUBuffer
now gets passed a GPUBuffer).
- WebGPUCommandBuffer is passed a GPUCommandQueue, since it needs to construct the underlying
GPUCommandBuffer itself so it can pass in the completion handler.
- For WebGPUDepthStencilDescriptor, WebGPURenderPassAttachmentDescriptor,
WebGPURenderPassColorAttachmentDescriptor, WebGPURenderPassDescriptor and WebGPURenderPipelineDescriptor
the create and constructor functions are empty.

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
Remove WebGPUObject.h/cpp

* html/canvas/WebGPUBuffer.cpp:
(WebCore::WebGPUBuffer::WebGPUBuffer):
* html/canvas/WebGPUBuffer.h:
* html/canvas/WebGPUBuffer.idl:
Switch from inheriting from WebGPUObject to directly inheriting from
RefCounted<WebGPUBuffer>. Since this de-virtualizes it, also add
ImplementationLacksVTable to the IDL file. Also update create
and constructor to take a GPUBuffer directly, rather than the context.

* html/canvas/WebGPUCommandBuffer.cpp:
(WebCore::WebGPUCommandBuffer::create):
(WebCore::WebGPUCommandBuffer::WebGPUCommandBuffer):
Update create and constructor to no longer require a context, as it would
now be unused, as it no longer inherits from WebGPUObject nor needs to hold
onto the context for any reason.

(WebCore::WebGPUCommandBuffer::createRenderCommandEncoderWithDescriptor):
Update to call the new WebGPURenderCommandEncoder::create, which no longer
requires a context.

(WebCore::WebGPUCommandBuffer::createComputeCommandEncoder):
Update to call the new WebGPUComputeCommandEncoder::create, which no longer
requires a context.

* html/canvas/WebGPUCommandBuffer.h:
* html/canvas/WebGPUCommandBuffer.idl:
Switch from inheriting from GPUObject to directly inheriting from
RefCounted<WebGPUCommandBuffer>. Since this de-virtualizes it, also add
ImplementationLacksVTable to the IDL file. Also update create and constructor
to no longer take a context, and just take a GPUCommandQueue. We can't directly
pass a GPUCommandBuffer as WebGPUCommandBuffer needs to pass in a completion handler
on construction of the underlying GPUCommandBuffer.

* html/canvas/WebGPUCommandQueue.cpp:
(WebCore::WebGPUCommandQueue::WebGPUCommandQueue):
(WebCore::WebGPUCommandQueue::createCommandBuffer):
Update to call the new WebGPUCommandBuffer::create, which no longer
requires a context.

* html/canvas/WebGPUCommandQueue.h:
* html/canvas/WebGPUCommandQueue.idl:
Switch from inheriting from GPUObject to directly inheriting from
RefCounted<WebGPUCommandQueue>. Since this de-virtualizes it, also add
ImplementationLacksVTable to the IDL file. Also update create and
constructor to take a GPUCommandQueue directly.

* html/canvas/WebGPUComputeCommandEncoder.cpp:
(WebCore::WebGPUComputeCommandEncoder::create):
(WebCore::WebGPUComputeCommandEncoder::WebGPUComputeCommandEncoder):
* html/canvas/WebGPUComputeCommandEncoder.h:
* html/canvas/WebGPUComputeCommandEncoder.idl:
Switch from inheriting from GPUObject to directly inheriting from
RefCounted<WebGPUComputeCommandEncoder>. Since this de-virtualizes it,
also add ImplementationLacksVTable to the IDL file. Also update create and
constructor to take a GPUComputeCommandEncoder directly

* html/canvas/WebGPUComputePipelineState.cpp:
(WebCore::WebGPUComputePipelineState::WebGPUComputePipelineState):
* html/canvas/WebGPUComputePipelineState.h:
* html/canvas/WebGPUComputePipelineState.idl:
Switch from inheriting from WebGPUObject to directly inheriting from
RefCounted<WebGPUComputePipelineState>. Since this de-virtualizes it, also add
ImplementationLacksVTable to the IDL file. Also update create and
constructor to take a GPUComputePipelineState directly.

* html/canvas/WebGPUDepthStencilDescriptor.cpp:
Remove unneeded include of include "WebGPURenderingContext.h".

* html/canvas/WebGPUDepthStencilDescriptor.h:
* html/canvas/WebGPUDepthStencilDescriptor.idl:
Switch from inheriting from WebGPUObject to directly inheriting from
RefCounted<WebGPUDepthStencilDescriptor>. Since this de-virtualizes it, also add
ImplementationLacksVTable to the IDL file.

* html/canvas/WebGPUDepthStencilState.cpp:
(WebCore::WebGPUDepthStencilState::WebGPUDepthStencilState):
* html/canvas/WebGPUDepthStencilState.h:
* html/canvas/WebGPUDepthStencilState.idl:
Switch from inheriting from WebGPUObject to directly inheriting from
RefCounted<WebGPUDepthStencilState>. Since this de-virtualizes it, also add
ImplementationLacksVTable to the IDL file. Also update create and
constructor to take a GPUDepthStencilState directly.

* html/canvas/WebGPUDrawable.cpp:
(WebCore::WebGPUDrawable::WebGPUDrawable):
* html/canvas/WebGPUDrawable.h:
* html/canvas/WebGPUDrawable.idl:
Switch from inheriting from WebGPUObject to directly inheriting from
RefCounted<WebGPUDrawable>. Since this de-virtualizes it, also add
ImplementationLacksVTable to the IDL file. Also update create and
constructor to take a GPUDrawable directly.

* html/canvas/WebGPUFunction.cpp:
(WebCore::WebGPUFunction::create):
(WebCore::WebGPUFunction::WebGPUFunction):
* html/canvas/WebGPUFunction.h:
* html/canvas/WebGPUFunction.idl:
Switch from inheriting from GPUObject to directly inheriting from
RefCounted<WebGPUFunction>. Since this de-virtualizes it, also add
ImplementationLacksVTable to the IDL file. Also update create and
constructor to take a GPUFunction directly.

* html/canvas/WebGPULibrary.cpp:
(WebCore::WebGPULibrary::WebGPULibrary):
(WebCore::WebGPULibrary::functionWithName const):
Update for new WebGPUFunction::create, which no longer requires a
context.

* html/canvas/WebGPULibrary.h:
* html/canvas/WebGPULibrary.idl:
Switch from inheriting from WebGPUObject to directly inheriting from
RefCounted<WebGPULibrary>. Since this de-virtualizes it, also add
ImplementationLacksVTable to the IDL file. Also update create and
constructor to take a GPULibrary directly, rather than the context.
Unlike the other create functions that take their underlying type, this
one also continues to need the sourceCode String to be passed, as that
is not available from the underlying GPULibrary and must be stored
seperately.

* html/canvas/WebGPUObject.cpp: Removed.
* html/canvas/WebGPUObject.h: Removed.
Deleted.

* html/canvas/WebGPURenderCommandEncoder.cpp:
(WebCore::WebGPURenderCommandEncoder::create):
(WebCore::WebGPURenderCommandEncoder::WebGPURenderCommandEncoder):
* html/canvas/WebGPURenderCommandEncoder.h:
* html/canvas/WebGPURenderCommandEncoder.idl:
Switch from inheriting from GPUObject to directly inheriting from
RefCounted<WebGPURenderCommandEncoder>. Since this de-virtualizes it, also add
ImplementationLacksVTable to the IDL file. Also update create and
constructor to take a GPURenderCommandEncoder directly.

* html/canvas/WebGPURenderPassAttachmentDescriptor.cpp:
(WebCore::WebGPURenderPassAttachmentDescriptor::WebGPURenderPassAttachmentDescriptor):
* html/canvas/WebGPURenderPassAttachmentDescriptor.h:
Switch from inheriting from GPUObject to directly inheriting from
RefCounted<WebGPURenderPassAttachmentDescriptor>. Also update create and
constructor to no longer take a context, as it is now not used. This remains virtual
as it is inherited from by WebGPURenderPassColorAttachmentDescriptor and WebGPURenderPassDepthAttachmentDescriptor.

* html/canvas/WebGPURenderPassColorAttachmentDescriptor.cpp:
(WebCore::WebGPURenderPassColorAttachmentDescriptor::create):
(WebCore::WebGPURenderPassColorAttachmentDescriptor::WebGPURenderPassColorAttachmentDescriptor):
* html/canvas/WebGPURenderPassColorAttachmentDescriptor.h:
Update create and constructor to no longer take a context, as it is now not used. Declare final
as this is not inherited by anything.

* html/canvas/WebGPURenderPassDepthAttachmentDescriptor.cpp:
(WebCore::WebGPURenderPassDepthAttachmentDescriptor::create):
(WebCore::WebGPURenderPassDepthAttachmentDescriptor::WebGPURenderPassDepthAttachmentDescriptor):
* html/canvas/WebGPURenderPassDepthAttachmentDescriptor.h:
Update create and constructor to no longer take a context, as it is now not used. Declare final
as this is not inherited by anything.

* html/canvas/WebGPURenderPassDescriptor.cpp:
(WebCore::WebGPURenderPassDescriptor::depthAttachment):
Update for new WebGPURenderPassDepthAttachmentDescriptor::create function which no longer requires
a context.

Semi-interesting note: This function was previously calling "*context()" to pass a WebGPURenderingContext&
to WebGPURenderPassDepthAttachmentDescriptor::create. However, "context()" was always returning null, as
the constructor of WebGPURenderPassDescriptor was not initializing the WebGPUObject with a WebGPURenderingContext.
Now, one might think that this would cause a null-deref, but, because it was being assigned into a
WebGPURenderingContext&, no dereference happens right away (it essentially just passes a pointer) and since
the function it is being passed to does not use it, it never actually gets dereferenced.

(WebCore::WebGPURenderPassDescriptor::colorAttachments):
Update for new WebGPURenderPassColorAttachmentDescriptor::create function which no longer requires
a context.

* html/canvas/WebGPURenderPassDescriptor.h:
* html/canvas/WebGPURenderPassDescriptor.idl:
Switch from inheriting from GPUObject to directly inheriting from
RefCounted<WebGPURenderPassDescriptor>. Since this de-virtualizes it, also add
ImplementationLacksVTable to the IDL file.

* html/canvas/WebGPURenderPipelineColorAttachmentDescriptor.cpp:
(WebCore::WebGPURenderPipelineColorAttachmentDescriptor::create):
(WebCore::WebGPURenderPipelineColorAttachmentDescriptor::WebGPURenderPipelineColorAttachmentDescriptor):
* html/canvas/WebGPURenderPipelineColorAttachmentDescriptor.h:
* html/canvas/WebGPURenderPipelineColorAttachmentDescriptor.idl:
Switch from inheriting from GPUObject to directly inheriting from
RefCounted<WebGPURenderPipelineColorAttachmentDescriptor>. Since this de-virtualizes it, also add
ImplementationLacksVTable to the IDL file. Also update create and constructor to
no longer take a context, as it is now not used.

* html/canvas/WebGPURenderPipelineDescriptor.cpp:
(WebCore::WebGPURenderPipelineDescriptor::colorAttachments):
Update for new WebGPURenderPipelineColorAttachmentDescriptor::create which no longer requires
a context.

* html/canvas/WebGPURenderPipelineDescriptor.h:
* html/canvas/WebGPURenderPipelineDescriptor.idl:
Switch from inheriting from GPUObject to directly inheriting from
RefCounted<WebGPURenderPipelineDescriptor>. Since this de-virtualizes it, also add
ImplementationLacksVTable to the IDL file.

* html/canvas/WebGPURenderPipelineState.cpp:
(WebCore::WebGPURenderPipelineState::WebGPURenderPipelineState):
* html/canvas/WebGPURenderPipelineState.h:
* html/canvas/WebGPURenderPipelineState.idl:
Switch from inheriting from GPUObject to directly inheriting from
RefCounted<WebGPURenderPipelineState>. Since this de-virtualizes it, also add
ImplementationLacksVTable to the IDL file. Also update create and
constructor to take a GPURenderPipelineState directly.

* html/canvas/WebGPURenderingContext.cpp:
(WebCore::WebGPURenderingContext::createLibrary):
(WebCore::WebGPURenderingContext::createRenderPipelineState):
(WebCore::WebGPURenderingContext::createDepthStencilState):
(WebCore::WebGPURenderingContext::createComputePipelineState):
(WebCore::WebGPURenderingContext::createCommandQueue):
(WebCore::WebGPURenderingContext::nextDrawable):
(WebCore::WebGPURenderingContext::createBuffer):
(WebCore::WebGPURenderingContext::createTexture):
Update for new create functions which require the caller to pass
the underlying type.

* html/canvas/WebGPUTexture.cpp:
(WebCore::WebGPUTexture::createFromDrawableTexture):
Renamed to create.

(WebCore::WebGPUTexture::create): Deleted
All callers now pass a GPUTexture directly.

* html/canvas/WebGPUTexture.h:
* html/canvas/WebGPUTexture.idl:
Switch from inheriting from GPUObject to directly inheriting from
RefCounted<WebGPUTexture>. Since this de-virtualizes it, also add
ImplementationLacksVTable to the IDL file.

* html/canvas/WebGPUTextureDescriptor.h:
* html/canvas/WebGPUTextureDescriptor.idl:
Switch from inheriting from GPUObject to directly inheriting from
RefCounted<WebGPUTextureDescriptor>. Since this de-virtualizes it, also add
ImplementationLacksVTable to the IDL file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoFix spelling of "overridden"
commit-queue@webkit.org [Fri, 3 Aug 2018 23:13:57 +0000 (23:13 +0000)]
Fix spelling of "overridden"
https://bugs.webkit.org/show_bug.cgi?id=188315

Patch by Alex Christensen <achristensen@webkit.org> on 2018-08-03
Reviewed by Darin Adler.

Source/JavaScriptCore:

* API/JSExport.h:
* inspector/InjectedScriptSource.js:

Source/ThirdParty/ANGLE:

* src/libANGLE/renderer/ProgramImpl.h:

Source/ThirdParty/libwebrtc:

* Source/webrtc/p2p/client/basicportallocator.h:

Source/WebCore:

* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityLabel]):
(-[WebAccessibilityObjectWrapper accessibilityValue]):
* contentextensions/ContentExtensionsBackend.h:
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
* inspector/CommandLineAPIModuleSource.js:
* platform/ScrollView.h:
* platform/ScrollableArea.h:
* platform/mediasession/MediaSessionInterruptionProvider.h:
* rendering/RenderFragmentedFlow.cpp:
(WebCore::RenderFragmentedFlow::adjustedPositionRelativeToOffsetParent const):
* rendering/RenderLayer.h:
* rendering/RenderListBox.h:
* rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
* svg/SVGElement.cpp:
(WebCore::SVGElement::localCoordinateSpaceTransform const):
* svg/SVGLengthContext.cpp:
(WebCore::SVGLengthContext::SVGLengthContext):
(WebCore::SVGLengthContext::convertValueToUserUnits const):
(WebCore::SVGLengthContext::determineViewport const):
* svg/SVGLengthContext.h:

Source/WebInspectorUI:

* UserInterface/Views/ContentBrowserTabContentView.js:
(WI.ContentBrowserTabContentView.prototype.treeElementForRepresentedObject):
* UserInterface/Views/GeneralTreeElement.js:
(WI.GeneralTreeElement.prototype.ondetach):
* UserInterface/Views/NavigationBar.js:
(WI.NavigationBar.prototype.get sizesToFit):
* UserInterface/Views/NavigationSidebarPanel.js:
(WI.NavigationSidebarPanel.prototype.shouldFilterPopulate):
* UserInterface/Views/TextEditor.js:
(WI.TextEditor.prototype.canBeFormatted):
* UserInterface/Views/TreeElement.js:
(WI.TreeElement.prototype.onpopulate):

Source/WebKit:

* Platform/IPC/mac/ConnectionMac.mm:
(IPC::Connection::receiveSourceEventHandler):
* Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::encode const):
(WebKit::WebPreferencesStore::decode):
(WebKit::valueForKey):
(WebKit::setValueForKey):
(WebKit::WebPreferencesStore::setStringValueForKey):
(WebKit::WebPreferencesStore::getStringValueForKey const):
(WebKit::WebPreferencesStore::setBoolValueForKey):
(WebKit::WebPreferencesStore::getBoolValueForKey const):
(WebKit::WebPreferencesStore::setUInt32ValueForKey):
(WebKit::WebPreferencesStore::getUInt32ValueForKey const):
(WebKit::WebPreferencesStore::setDoubleValueForKey):
(WebKit::WebPreferencesStore::getDoubleValueForKey const):
(WebKit::WebPreferencesStore::setOverrideDefaultsStringValueForKey):
(WebKit::WebPreferencesStore::setOverrideDefaultsBoolValueForKey):
(WebKit::WebPreferencesStore::setOverrideDefaultsUInt32ValueForKey):
(WebKit::WebPreferencesStore::setOverrideDefaultsDoubleValueForKey):
* Shared/WebPreferencesStore.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView dragInteraction:previewForLiftingItem:session:]):
(-[WKContentView dragInteraction:previewForCancellingItem:withDefault:]):
* UIProcess/ios/WKScrollView.mm:
(-[WKScrollView _systemContentInset]):

Source/WebKitLegacy/mac:

* Misc/WebKitVersionChecks.mm:
(setWebKitLinkTimeVersion):
(WebKitLinkTimeVersion):
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView handleMouseMoved:]):
* WebCoreSupport/PopupMenuMac.mm:
(PopupMenuMac::populate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoUnreviewed, rolling out r234517.
david_fenton@apple.com [Fri, 3 Aug 2018 23:01:35 +0000 (23:01 +0000)]
Unreviewed, rolling out r234517.

Caused API test failures on iOS

Reverted changeset:

"[Cocoa] setCookie API fails to set session cookies for
defaultDataStore if processPool created but not used"
https://bugs.webkit.org/show_bug.cgi?id=188209
https://trac.webkit.org/changeset/234517

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoAdd configuration for automatic process pre-warming
commit-queue@webkit.org [Fri, 3 Aug 2018 22:50:15 +0000 (22:50 +0000)]
Add configuration for automatic process pre-warming
https://bugs.webkit.org/show_bug.cgi?id=187108

Patch by Ben Richards <benton_richards@apple.com> on 2018-08-03
Reviewed by Ryosuke Niwa.

Source/WebKit:

Added configurations to allow setting the maximum number of processes that should be automatically prewarmed.

* UIProcess/API/APIProcessPoolConfiguration.cpp:
(API::ProcessPoolConfiguration::copy):
* UIProcess/API/APIProcessPoolConfiguration.h:
* UIProcess/API/C/WKContext.cpp:
(WKContextSetMaximumNumberOfPrewarmedProcesses):
* UIProcess/API/C/WKContextPrivate.h:
* UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _setMaximumNumberOfPrewarmedProcesses:]):
* UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
* UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
* UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:
(-[_WKProcessPoolConfiguration setMaximumPrewarmedProcessCount:]):
(-[_WKProcessPoolConfiguration maximumPrewarmedProcessCount]):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didFinishLoadForFrame): Moved call to notifyProcessPoolToPrewarm from didFirstVisuallyNonEmptyLayoutForFrame to here.
This is to try to ensure that frame loading and prewarming don't happen at the same time as this would be heavy for some devices.
(WebKit::WebPageProxy::didFirstVisuallyNonEmptyLayoutForFrame):
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::setMaximumNumberOfProcesses): Condition changed so that calling setMaximumNumberOfProcesses after warmInitialProcess
doesn't result in a crash.
(WebKit::WebProcessPool::setMaximumNumberOfPrewarmedProcesses):
(WebKit::WebProcessPool::warmInitialProcess):
(WebKit::WebProcessPool::didReachGoodTimeToPrewarm):
* UIProcess/WebProcessPool.h:

Tools:

Added new test case for setting maximum prewarmed process count and updated test case for process swap on navigation to set the maximum prewarmed process count to be 1 where relevant.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm:
(TEST):
* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
* TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm:
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[ews-build] Add build step to Check Patch Relevance
aakash_jain@apple.com [Fri, 3 Aug 2018 21:35:49 +0000 (21:35 +0000)]
[ews-build] Add build step to Check Patch Relevance
https://bugs.webkit.org/show_bug.cgi?id=188295

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-build/steps.py:
(CheckPatchRelevance): Added step to check patch relevance.
(CheckPatchRelevance._patch_is_relevant): Checks if the patch is relevant.
(CheckPatchRelevance._get_patch): Retrieves the patch from buildbot.
(CheckPatchRelevance._addToLog): Add the log message.
(CheckPatchRelevance.start):
* BuildSlaveSupport/ews-build/factories.py: Added CheckPatchRelevance step appropriately.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[LayoutTests][websocket] Return correct value even when cookie is not set.
Basuke.Suzuki@sony.com [Fri, 3 Aug 2018 21:10:44 +0000 (21:10 +0000)]
[LayoutTests][websocket] Return correct value even when cookie is not set.
https://bugs.webkit.org/show_bug.cgi?id=188317

Reviewed by Darin Adler.

> ws://127.0.0.1:8880/websocket/tests/hybi/echo-cookie_wsh.py
This web socket script throw exception when cookie is not set. That is ended up with
immediate disconnection and causes timeout for failure tests which makes debugging hard.

* http/tests/websocket/tests/hybi/echo-cookie_wsh.py:
(web_socket_transfer_data):
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[Curl] Test gardening
Basuke.Suzuki@sony.com [Fri, 3 Aug 2018 19:19:07 +0000 (19:19 +0000)]
[Curl] Test gardening
https://bugs.webkit.org/show_bug.cgi?id=188316

Unreviewed test gardening.

Skip some flaky tests.
Add comments why we skip for some platform dependent reason.

* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoFix invalid optional access in WebDriver Session::createTopLevelBrowsingContext.
Ms2ger@igalia.com [Fri, 3 Aug 2018 18:36:31 +0000 (18:36 +0000)]
Fix invalid optional access in WebDriver Session::createTopLevelBrowsingContext.
https://bugs.webkit.org/show_bug.cgi?id=188304

Reviewed by Brian Burg.

* Session.cpp:
(WebDriver::Session::createTopLevelBrowsingContext): remove incorrect value() call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[LFC][BFC] Special case the document renderer when computing the height and margin
zalan@apple.com [Fri, 3 Aug 2018 18:00:23 +0000 (18:00 +0000)]
[LFC][BFC] Special case the document renderer when computing the height and margin
https://bugs.webkit.org/show_bug.cgi?id=188313

Reviewed by Antti Koivisto.

The document renderer is certainly special and its geometry is likely to be computed as part of "10.6.6 Complicated cases" (spec is unclear) but probably not by
making the it a formatting root. Let's just special case it at contentHeightForFormattingContextRoot(), since having the document renderer as a context root has unwanted side effect.

* layout/FormattingContextGeometry.cpp:
(WebCore::Layout::contentHeightForFormattingContextRoot):
* layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::establishesBlockFormattingContext const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[LFC][BFC] Layout out-of-flow descendants only on the formatting context root.
zalan@apple.com [Fri, 3 Aug 2018 17:57:35 +0000 (17:57 +0000)]
[LFC][BFC] Layout out-of-flow descendants only on the formatting context root.
https://bugs.webkit.org/show_bug.cgi?id=188312

Reviewed by Antti Koivisto.

Collect out-of-flow descendants on the formatting root container instead of the containing block and run layout on them on the root level. It's more efficient this way.

* layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layout const):
* layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::TreeBuilder::createSubTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoCheck with SafeBrowsing during navigation in WKWebView
achristensen@apple.com [Fri, 3 Aug 2018 17:56:29 +0000 (17:56 +0000)]
Check with SafeBrowsing during navigation in WKWebView
https://bugs.webkit.org/show_bug.cgi?id=188133

Reviewed by Chris Dumez.

This turns WebFramePolicyListenerProxy into an object that now listens for the results
of two processes happening in parallel: the API::NavigationClient's decidePolicyForNavigation{Action, Response}
(which it was already waiting for) and, on platforms that support it, the SafariSafeBrowsing framework's check.
The first result is stored as it waits for the second result unless the first result is the API::NavigationClient
saying to cancel or convert the navigation to a download, in which cases we don't care what the safe browsing
framework results are because we won't show the URL in the browser.

Nothing is done with the safe browsing results yet.

* UIProcess/Cocoa/SafeBrowsingResultCocoa.mm: Added.
(WebKit::SafeBrowsingResult::SafeBrowsingResult):
* UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::beginSafeBrowsingCheck):
* UIProcess/SafeBrowsingResult.h: Added.
(WebKit::SafeBrowsingResult::provider const):
(WebKit::SafeBrowsingResult::isPhishing const):
(WebKit::SafeBrowsingResult::isMalware const):
(WebKit::SafeBrowsingResult::isUnwantedSoftware const):
(WebKit::SafeBrowsingResult::isKnownToBeUnsafe const):
* UIProcess/WebFramePolicyListenerProxy.cpp:
(WebKit::WebFramePolicyListenerProxy::WebFramePolicyListenerProxy):
(WebKit::WebFramePolicyListenerProxy::didReceiveSafeBrowsingResults):
(WebKit::WebFramePolicyListenerProxy::use):
(WebKit::WebFramePolicyListenerProxy::download):
(WebKit::WebFramePolicyListenerProxy::ignore):
* UIProcess/WebFramePolicyListenerProxy.h:
(WebKit::WebFramePolicyListenerProxy::create):
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::setUpPolicyListenerProxy):
* UIProcess/WebFrameProxy.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponse):
* UIProcess/WebPageProxy.h:
* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[LayoutTests][PHP] Fix old-style script which uses function name as a keyword.
Basuke.Suzuki@sony.com [Fri, 3 Aug 2018 17:51:21 +0000 (17:51 +0000)]
[LayoutTests][PHP] Fix old-style script which uses function name as a keyword.
https://bugs.webkit.org/show_bug.cgi?id=188289

Reviewed by Alex Christensen.

Function name should be passed as a string literal. In PHP, named function is
not the first class citizen.

* http/tests/cookies/resources/echo-cookies.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoContentFilterUnblockHandler's constructors access moved-from variables
aestes@apple.com [Fri, 3 Aug 2018 17:51:04 +0000 (17:51 +0000)]
ContentFilterUnblockHandler's constructors access moved-from variables
https://bugs.webkit.org/show_bug.cgi?id=188308
<rdar://problem/42882758>

Reviewed by Alex Christensen.

* platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[LayoutTests] Suppress PHP Error message by removing an execution time limit.
Basuke.Suzuki@sony.com [Fri, 3 Aug 2018 17:48:47 +0000 (17:48 +0000)]
[LayoutTests] Suppress PHP Error message by removing an execution time limit.
https://bugs.webkit.org/show_bug.cgi?id=188288

Reviewed by Alex Christensen.

Remove execution timeout.

* http/tests/multipart/resources/multipart.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoUnreviewed gardening; r234534 changed the policy for what audio session is set when a
jer.noble@apple.com [Fri, 3 Aug 2018 17:06:28 +0000 (17:06 +0000)]
Unreviewed gardening; r234534 changed the policy for what audio session is set when a
media element is paused. Updating the test to reflect the new policy.

* TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[LFC][Floating] Now that the document renderer belongs to "complicated cases", adjust...
zalan@apple.com [Fri, 3 Aug 2018 15:38:10 +0000 (15:38 +0000)]
[LFC][Floating] Now that the document renderer belongs to "complicated cases", adjust viewport stretching.
https://bugs.webkit.org/show_bug.cgi?id=188306

Reviewed by Antti Koivisto.

Source/WebCore:

And add passing cases for floats.

* layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::initialContainingBlock):
(WebCore::Layout::isStretchedToInitialContainingBlock):
(WebCore::Layout::stretchHeightToInitialContainingBlock):
(WebCore::Layout::stretchWidthToInitialContainingBlock):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
(WebCore::Layout::isStretchedToViewport): Deleted.

Tools:

* LayoutReloaded/misc/LFC-passing-tests.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoUnreviewed, rolling out r234513.
ryanhaddad@apple.com [Fri, 3 Aug 2018 15:26:13 +0000 (15:26 +0000)]
Unreviewed, rolling out r234513.

14 API tests fail the assertions added in this change.

Reverted changeset:

"Check with SafeBrowsing during navigation in WKWebView"
https://bugs.webkit.org/show_bug.cgi?id=188133
https://trac.webkit.org/changeset/234513

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[LFC] Do not check margin box while validating geometry.
zalan@apple.com [Fri, 3 Aug 2018 14:21:21 +0000 (14:21 +0000)]
[LFC] Do not check margin box while validating geometry.
https://bugs.webkit.org/show_bug.cgi?id=188297

Reviewed by Antti Koivisto.

The current RenderBox::marginBox implementation is not spec compliant. Ignore it for now.

* layout/Verification.cpp:
(WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[WPE] WebDriver: add support for action commands
carlosgc@webkit.org [Fri, 3 Aug 2018 10:43:14 +0000 (10:43 +0000)]
[WPE] WebDriver: add support for action commands
https://bugs.webkit.org/show_bug.cgi?id=188301

Reviewed by Žan Doberšek.

WPE doesn't support action commands because the platform specific code for handling events is not implemented.

* SourcesWPE.txt: Add new file to compilation.
* UIProcess/API/glib/WebKitUIClient.cpp: Use the drawing area size as window size in WPE.
* UIProcess/API/wpe/PageClientImpl.cpp:
(WebKit::PageClientImpl::viewBackend): Return the WPE backend of the view.
* UIProcess/API/wpe/PageClientImpl.h:
* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::performMouseInteraction):
(WebKit::WebAutomationSession::performKeyboardInteractions):
(WebKit::WebAutomationSession::performInteractionSequence):
(WebKit::WebAutomationSession::cancelInteractionSequence):
* UIProcess/Automation/wpe/WebAutomationSessionWPE.cpp: Added.
(WebKit::modifiersToEventState):
(WebKit::mouseButtonToWPEButton):
(WebKit::stateModifierForWPEButton):
(WebKit::doMouseEvent):
(WebKit::doMotionEvent):
(WebKit::WebAutomationSession::platformSimulateMouseInteraction):
(WebKit::doKeyStrokeEvent):
(WebKit::keyCodeForVirtualKey):
(WebKit::modifiersForKeyCode):
(WebKit::WebAutomationSession::platformSimulateKeyboardInteraction):
(WebKit::WebAutomationSession::platformSimulateKeySequence):
* UIProcess/WebPageProxy.h:
* UIProcess/wpe/WebPageProxyWPE.cpp:
(WebKit::WebPageProxy::viewBackend): Return the WPE backend.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[WPE] Use the new key mapper API from WPEBackend
carlosgc@webkit.org [Fri, 3 Aug 2018 10:07:55 +0000 (10:07 +0000)]
[WPE] Use the new key mapper API from WPEBackend
https://bugs.webkit.org/show_bug.cgi?id=188216

Reviewed by Žan Doberšek.

* WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
(WTR::EventSenderProxy::keyDown): Use wpe_input_xkb_context_get_entries_for_key_code() to get the hardware key
code.
* wpe/backends/WindowViewBackend.cpp:
(WPEToolingBackends::WindowViewBackend::WindowViewBackend):
(WPEToolingBackends::WindowViewBackend::handleKeyEvent):
(WPEToolingBackends::WindowViewBackend::modifiers const):
* wpe/backends/WindowViewBackend.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[WPE] Implement MouseEvent.buttons
carlosgc@webkit.org [Fri, 3 Aug 2018 09:38:18 +0000 (09:38 +0000)]
[WPE] Implement MouseEvent.buttons
https://bugs.webkit.org/show_bug.cgi?id=187998

Reviewed by Žan Doberšek.

Source/WebKit:

Pass buttons currently pressed to WebMouseEvent.

* Shared/wpe/WebEventFactory.cpp:
(WebKit::pressedMouseButtons): Helper to get the pressed buttons mask for the WPE modifiers.
(WebKit::WebEventFactory::createWebMouseEvent): Use pressedMouseButtons().
* UIProcess/API/wpe/PageClientImpl.cpp:
(WebKit::PageClientImpl::doneWithTouchEvent): Update the event modifiers.

Tools:

Pass modifiers to mouse events.

* WebKitTestRunner/EventSenderProxy.h:
* WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
(WTR::senderButtonToWPEButton):
(WTR::modifierForButton):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::wkEventModifiersToWPE):
(WTR::wpeKeySymForKeyRef):
(WTR::EventSenderProxy::keyDown):
(WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
* wpe/backends/WindowViewBackend.cpp:
(WPEToolingBackends::WindowViewBackend::handleKeyEvent):
(WPEToolingBackends::WindowViewBackend::modifiers const):
* wpe/backends/WindowViewBackend.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[WPE] Use WPE key symbols and new API instead of xkbcommon and the key mapper
carlosgc@webkit.org [Fri, 3 Aug 2018 09:16:18 +0000 (09:16 +0000)]
[WPE] Use WPE key symbols and new API instead of xkbcommon and the key mapper
https://bugs.webkit.org/show_bug.cgi?id=188093

Reviewed by Žan Doberšek.

Source/WebCore:

Add helper functions to get key code, hardware key code, key identifier and windows key code from a WPE key symbol.

* platform/PlatformKeyboardEvent.h:
* platform/wpe/PlatformKeyboardEventWPE.cpp:
(WebCore::PlatformKeyboardEvent::keyValueForWPEKeyCode):
(WebCore::PlatformKeyboardEvent::keyCodeForHardwareKeyCode):
(WebCore::PlatformKeyboardEvent::keyIdentifierForWPEKeyCode):
(WebCore::PlatformKeyboardEvent::windowsKeyCodeForWPEKeyCode):
(WebCore::PlatformKeyboardEvent::singleCharacterString):

Source/WebKit:

* Shared/WebEvent.h: Add WebKeyboardEvent constructor for WPE.
* Shared/WebKeyboardEvent.cpp:
(WebKit::WebKeyboardEvent::WebKeyboardEvent): WebKeyboardEvent constructor for WPE.
* Shared/wpe/WebEventFactory.cpp:
(WebKit::isWPEKeyCodeFromKeyPad): Helper tpo check if a key symbols is from key pad.
(WebKit::WebEventFactory::createWebKeyboardEvent): Use PlatformKeyboardEvent API to provide key code, hardware
key code, key identifier and windows key code to WebKeyboardEvent.
* UIProcess/API/wpe/WPEView.cpp:
(WKWPE::m_backend): Use WPE key symbols.

Tools:

* MiniBrowser/wpe/main.cpp: Use WPE key symbols.
* WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
(WTR::wpeKeySymForKeyRef): Use WPE key symbols and wpe_unicode_to_key_code().
(WTR::EventSenderProxy::keyDown): Do not set unicode char to the event since it was removed.
* flatpak/org.webkit.WPE.yaml: Bump WPEBackend and WPEBackend-fdo versions.
* wpe/backends/WindowViewBackend.cpp:
(WPEToolingBackends::WindowViewBackend::handleKeyEvent): Do not set unicode char to the event since it was removed.
* wpe/jhbuild.modules: Bump WPEBackend and WPEBackend-fdo versions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoRelease assert when throwing exceptions in custom element reactions
rniwa@webkit.org [Fri, 3 Aug 2018 08:16:48 +0000 (08:16 +0000)]
Release assert when throwing exceptions in custom element reactions
https://bugs.webkit.org/show_bug.cgi?id=187805
<rdar://problem/42432714>

Reviewed by Saam Barati.

LayoutTests/imported/w3c:

Generated the expected result.

* web-platform-tests/custom-elements/reactions/with-exceptions-expected.txt: Added.

Source/WebCore:

The release assertion was hit because we were not catching & re-throwing the exception thrown by DOM API
before trying to execute custom elements reactions in ~CustomElementReactionStack as specified here:
https://html.spec.whatwg.org/multipage/custom-elements.html#cereactions
Fixed the bug by capturing the exception and re-throwing the exception as specified.

Tests: imported/w3c/web-platform-tests/custom-elements/reactions/with-exceptions.html

* bindings/js/JSMainThreadExecState.h:
(WebCore::JSMainThreadNullState::JSMainThreadNullState): Use the previous JS state.
* bindings/scripts/CodeGeneratorJS.pm:
(GeneratePut): Pass in the exec state to CustomElementReactionStack.
(GeneratePutByIndex): Ditto.
(GenerateDefineOwnProperty): Ditto.
(GenerateDeletePropertyCommon): Ditto.
(GenerateAttributeSetterBodyDefinition): Ditto.
(GenerateOperationBodyDefinition): Ditto.
* bindings/scripts/test/JS/JSTestCEReactions.cpp:
(WebCore::setJSTestCEReactionsAttributeWithCEReactionsSetter):
(WebCore::setJSTestCEReactionsReflectAttributeWithCEReactionsSetter):
(WebCore::jsTestCEReactionsPrototypeFunctionMethodWithCEReactionsBody):
* bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:
(WebCore::setJSTestCEReactionsStringifierValueSetter):
* dom/CustomElementReactionQueue.cpp:
(WebCore::CustomElementReactionQueue::ElementQueue::processQueue): Added. If there is a script running
in the stack (i.e. ExecState is not null), catch any exception before executing custom element reactions,
then re-throw the exception afterwards. ExecState is null when DOM API is invoked via Objective-C bindings
or when custom element reactions are executed in the backup queue (e.g. for editing operations).
(WebCore::CustomElementReactionStack::processQueue):
(WebCore::CustomElementReactionQueue::processBackupQueue):
* dom/CustomElementReactionQueue.h:
(WebCore::CustomElementReactionStack::CustomElementReactionStack):
(WebCore::CustomElementReactionStack::~CustomElementReactionStack):

LayoutTests:

Unskipped the previously crashing test.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[Curl] Test gardening
Basuke.Suzuki@sony.com [Fri, 3 Aug 2018 05:24:07 +0000 (05:24 +0000)]
[Curl] Test gardening
https://bugs.webkit.org/show_bug.cgi?id=188293

Unreviewed test gardening.

Unskip some http tests.

* platform/wincairo/TestExpectations:
  - contentextensions
  - events
  - favicon.ico
  - fullscreen
  - globalhistory
  - gzip-content-encoding
  - history
  - local
  - messaging
  - mime
  - multipart
  - performance
  - permissionclient
  - referrer-policy
  - resourceLoadStatistics
* platform/wincairo/http/tests/local/file-url-sent-as-referer-expected.txt: Added.
* platform/wincairo/http/tests/multipart/invalid-image-data-expected.txt: Added.
* platform/wincairo/http/tests/multipart/invalid-image-data-standalone-expected.txt: Added.
* platform/wincairo/http/tests/uri/css-href-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[LFC][BFC] Apply the "10.6.6 Complicated cases" when computing height and margin...
zalan@apple.com [Fri, 3 Aug 2018 04:32:05 +0000 (04:32 +0000)]
[LFC][BFC] Apply the "10.6.6 Complicated cases" when computing height and margin for the document renderer
https://bugs.webkit.org/show_bug.cgi?id=188296

Reviewed by Simon Fraser.

The spec is not clear about what to do with the document renderer. It behaves as if it was a formatting context root when
it comes to computing the content height. Let's apply "10.6.6 Complicated cases" for now.

* layout/FormattingContext.h:
* layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::complicatedCases):
(WebCore::Layout::FormattingContext::Geometry::floatingHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedHeightAndMargin): Deleted.
* layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
* layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::establishesBlockFormattingContext const):
* layout/layouttree/LayoutBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[LFC][Floating] Add FloatingState::bottom() to enable content height computation...
zalan@apple.com [Fri, 3 Aug 2018 02:32:24 +0000 (02:32 +0000)]
[LFC][Floating] Add FloatingState::bottom() to enable content height computation for formatting roots.
https://bugs.webkit.org/show_bug.cgi?id=188294

Reviewed by Simon Fraser.

"10.6.7 'Auto' heights for block formatting context roots
...
In addition, if the element has any floating descendants whose bottom margin edge is below the element's bottom content edge,
then the height is increased to include those edges. Only floats that participate in this block formatting context are taken into
account, e.g., floats inside absolutely positioned descendants or other floats are not..."

* layout/FloatingState.cpp:
(WebCore::Layout::FloatingState::bottom const):
* layout/FloatingState.h:
* layout/FormattingContextGeometry.cpp:
(WebCore::Layout::contentHeightForFormattingContextRoot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoControl center controls disappear when pausing, locking device.
jer.noble@apple.com [Fri, 3 Aug 2018 01:54:15 +0000 (01:54 +0000)]
Control center controls disappear when pausing, locking device.
https://bugs.webkit.org/show_bug.cgi?id=188282
<rdar://problem/42497809>

Reviewed by Eric Carlson.

Source/WebCore:

Test: platform/mac/media/audio-session-category-video-paused.html

MediaRemote will set any app whose audio session category changes from MediaPlayback to
Ambient as not eligable for being the "now playing" app. Previously, due to the ordering of
events, we never moved from MediaPlayback to Ambient when pausing <video>, even though that
was the intention. Now that that bug is fixed, it exposed this new issue with MediaRemote.

To solve the new issue, make our audio session category policy more explicit: once we are in
MediaPlayback category, we will remain so as long as the media element in queston stays
loaded, has played, and is never interrupted by the system.

Make MediaSessionManagerCocoa a proper subclass of PlatformMediaSessionManager, and make
MediaSessionManageriOS and -Mac subclasses of the -Cocoa class. Add a new
m_hasPlayedSinceLastInterruption ivar to PlatformMediaSession, set when the state() changes
to Playing, and cleared during an interruption. Check this flag when deciding what audio
sessino category to set in MediaSessionManagerCocoa.

* WebCore.xcodeproj/project.pbxproj:
* platform/audio/PlatformMediaSession.cpp:
(WebCore::PlatformMediaSession::setState):
* platform/audio/PlatformMediaSession.h:
(WebCore::PlatformMediaSession::hasPlayedSinceLastInterruption const):
(WebCore::PlatformMediaSession::clearHasPlayedSinceLastInterruption):
* platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::updateSessionState): Deleted.
* platform/audio/PlatformMediaSessionManager.h:
(WebCore::PlatformMediaSessionManager::audioHardwareListener):
(WebCore::PlatformMediaSessionManager::updateSessionState):
* platform/audio/cocoa/MediaSessionManagerCocoa.cpp:
(MediaSessionManagerCocoa::updateSessionState):
(MediaSessionManagerCocoa::beginInterruption):
(PlatformMediaSessionManager::updateSessionState): Deleted.
* platform/audio/cocoa/MediaSessionManagerCocoa.h: Added.
* platform/audio/ios/MediaSessionManagerIOS.h:
* platform/audio/ios/MediaSessionManagerIOS.mm:
(WebCore::MediaSessionManageriOS::MediaSessionManageriOS):
* platform/audio/mac/MediaSessionManagerMac.h:
* platform/audio/mac/MediaSessionManagerMac.mm:
(WebCore::MediaSessionManagerMac::MediaSessionManagerMac):

LayoutTests:

* platform/mac/media/audio-session-category-video-paused-expected.txt: Added.
* platform/mac/media/audio-session-category-video-paused.html: Added.
* platform/ios/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoPDFPlugin: Context menus in RTL are left-aligned
timothy_horton@apple.com [Fri, 3 Aug 2018 01:11:46 +0000 (01:11 +0000)]
PDFPlugin: Context menus in RTL are left-aligned
https://bugs.webkit.org/show_bug.cgi?id=188292
<rdar://problem/32293787>

Reviewed by Simon Fraser.

* WebProcess/Plugins/PDF/PDFLayerControllerSPI.h:
Add some SPI.

* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::handleContextMenuEvent):
Translate UI layout direction back into the platform enum, and pass it to PDFKit.

* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::userInterfaceLayoutDirection const):
Add a getter for UI layout direction.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoRegression(r234486): assertion hit in ~CallbackAggregator()
cdumez@apple.com [Fri, 3 Aug 2018 00:24:13 +0000 (00:24 +0000)]
Regression(r234486): assertion hit in ~CallbackAggregator()
https://bugs.webkit.org/show_bug.cgi?id=188283
<rdar://problem/42851342>

Reviewed by Alex Christensen.

[NSHTTPCookieStorage _saveCookies:] SPI may call its completion block on the background queue
so we need to make sure we dispatch back to the main thread before calling our completion
handler.

* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::saveCookies):
(WebKit::NetworkProcess::platformSyncAllCookies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoSource/JavaScriptCore:
sbarati@apple.com [Fri, 3 Aug 2018 00:14:11 +0000 (00:14 +0000)]
Source/JavaScriptCore:
Reading instructionPointer from PlatformRegisters may fail when using pointer profiling
https://bugs.webkit.org/show_bug.cgi?id=188271
<rdar://problem/42850884>

Reviewed by Michael Saboff.

This patch defends against the instructionPointer containing garbage bits.
See radar for details.

* runtime/MachineContext.h:
(JSC::MachineContext::instructionPointer):
* runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::takeSample):
* runtime/VMTraps.cpp:
(JSC::SignalContext::SignalContext):
(JSC::SignalContext::tryCreate):
* tools/CodeProfiling.cpp:
(JSC::profilingTimer):
* tools/SigillCrashAnalyzer.cpp:
(JSC::SignalContext::SignalContext):
(JSC::SignalContext::tryCreate):
(JSC::SignalContext::dump):
(JSC::installCrashHandler):
* wasm/WasmFaultSignalHandler.cpp:
(JSC::Wasm::trapHandler):

Source/WTF:
Reading instructionPointer from PlatformRegisters may fail when using pointer tagging
https://bugs.webkit.org/show_bug.cgi?id=188271
<rdar://problem/42850884>

Reviewed by Michael Saboff.

* wtf/PtrTag.h:
(WTF::isTaggedWith):
(WTF::usesPointerTagging):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoAX: [iOS] add support to return the attributed string under the element
n_wang@apple.com [Thu, 2 Aug 2018 23:54:45 +0000 (23:54 +0000)]
AX: [iOS] add support to return the attributed string under the element
https://bugs.webkit.org/show_bug.cgi?id=188276
<rdar://problem/42872357>

Reviewed by Chris Fleizach.

Source/WebCore:

Provided a way on iOS to return the attributed string under the element for
better performance.

Test: accessibility/ios-simulator/attributed-string-for-element.html

* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _stringFromStartMarker:toEndMarker:attributed:]):
(-[WebAccessibilityObjectWrapper _stringForRange:attributed:]):
(-[WebAccessibilityObjectWrapper attributedStringForElement]):

Tools:

* DumpRenderTree/AccessibilityUIElement.cpp:
(attributedStringForElementCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::attributedStringForElement):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::attributedStringForElement):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::attributedStringForElement):

LayoutTests:

* accessibility/ios-simulator/attributed-string-for-element-expected.txt: Added.
* accessibility/ios-simulator/attributed-string-for-element.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[LFC][Floating] Remove redundant LayoutContext member variable.
zalan@apple.com [Thu, 2 Aug 2018 23:46:10 +0000 (23:46 +0000)]
[LFC][Floating] Remove redundant LayoutContext member variable.
https://bugs.webkit.org/show_bug.cgi?id=188286

Reviewed by Simon Fraser.

* layout/FloatingContext.cpp:
(WebCore::Layout::begin):
(WebCore::Layout::end):
(WebCore::Layout::FloatingContext::floatingPosition const):
(WebCore::Layout::FloatingPair::FloatingPair):
(WebCore::Layout::Iterator::Iterator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoREGRESSION (r234488): Layout test fast/events/ios/keyboard-scrolling-repeat.html...
timothy_horton@apple.com [Thu, 2 Aug 2018 23:35:08 +0000 (23:35 +0000)]
REGRESSION (r234488): Layout test fast/events/ios/keyboard-scrolling-repeat.html is timing out
<rdar://problem/42878480>

* fast/events/ios/keyboard-scrolling-repeat-expected.txt: Removed.
* fast/events/ios/keyboard-scrolling-repeat.html: Removed.
Remove a test that can't work anymore.
If we need to re-write it it will probably need to be an API test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoSkip API test DataInteractionTests.CustomActionSheetPopover on current SDKs.
ryanhaddad@apple.com [Thu, 2 Aug 2018 23:09:24 +0000 (23:09 +0000)]
Skip API test DataInteractionTests.CustomActionSheetPopover on current SDKs.
https://bugs.webkit.org/show_bug.cgi?id=175204

Unreviewed test gardening.

* TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoMove queue processing logic from CustomElementReactionStack to CustomElementReactionQueue
rniwa@webkit.org [Thu, 2 Aug 2018 22:37:09 +0000 (22:37 +0000)]
Move queue processing logic from CustomElementReactionStack to CustomElementReactionQueue
https://bugs.webkit.org/show_bug.cgi?id=188277

Reviewed by Wenson Hsieh.

Moved ensureCurrentQueue, processBackupQueue, ElementQueue, ensureBackupQueue, and backupElementQueue
from CustomElementReactionStack to CustomElementReactionQueue to simplify CustomElementReactionStack.

No new tests since there is no behavior change.

* dom/CustomElementReactionQueue.cpp:
(WebCore::CustomElementReactionQueue::enqueueElementUpgrade):
(WebCore::CustomElementReactionQueue::enqueueConnectedCallbackIfNeeded):
(WebCore::CustomElementReactionQueue::enqueueDisconnectedCallbackIfNeeded):
(WebCore::CustomElementReactionQueue::enqueueAdoptedCallbackIfNeeded):
(WebCore::CustomElementReactionQueue::enqueueAttributeChangedCallbackIfNeeded):
(WebCore::CustomElementReactionQueue::ElementQueue::add): Moved from CustomElementReactionStack.
(WebCore::CustomElementReactionQueue::ElementQueue::invokeAll): Ditto.
(WebCore::CustomElementReactionQueue::ensureCurrentQueue): Ditto.
(WebCore::CustomElementReactionQueue::ensureBackupQueue): Ditto.
(WebCore::CustomElementReactionQueue::processBackupQueue): Ditto.
(WebCore::CustomElementReactionQueue::backupElementQueue): Ditto.
* dom/CustomElementReactionQueue.h:
(WebCore::CustomElementReactionStack::hasCurrentProcessingStack): Deleted. It was never called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoFix some builds after r234516
achristensen@apple.com [Thu, 2 Aug 2018 22:31:48 +0000 (22:31 +0000)]
Fix some builds after r234516
​https://bugs.webkit.org/show_bug.cgi?id=188250

* Platform/IPC/ArgumentCoders.h:
This assertion was comparing integers of different signs.
Since we don't allow exception throwing in WebKit, valueless_by_exception won't be true,
so this assertion will always be true.  I'll just remove it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agohttpCookieStore.getAllCookies() does not always call completion block
sihui_liu@apple.com [Thu, 2 Aug 2018 22:20:55 +0000 (22:20 +0000)]
httpCookieStore.getAllCookies() does not always call completion block
https://bugs.webkit.org/show_bug.cgi?id=188242

Reviewed by Chris Dumez.

Take background assertion for network process to keep it alive during cookieStore API calls.

* UIProcess/GenericCallback.h:
* UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
(WebKit::WebCookieManagerProxy::deleteCookie):
(WebKit::WebCookieManagerProxy::deleteAllCookiesModifiedSince):
(WebKit::WebCookieManagerProxy::setCookie):
(WebKit::WebCookieManagerProxy::setCookies):
(WebKit::WebCookieManagerProxy::getAllCookies):
(WebKit::WebCookieManagerProxy::getCookies):
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[Cocoa] setCookie API fails to set session cookies for defaultDataStore if processPoo...
sihui_liu@apple.com [Thu, 2 Aug 2018 22:18:36 +0000 (22:18 +0000)]
[Cocoa] setCookie API fails to set session cookies for defaultDataStore if processPool created but not used
https://bugs.webkit.org/show_bug.cgi?id=188209

Reviewed by Geoffrey Garen.

Source/WebKit:

If defaultDataStore is already created when launching network process, it means user
probably set cookies for default session via API, so we should update m_websiteDataStore to
make sure pendingCookies is passed to network process.

* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureNetworkProcess):

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoUse WTF::Variant for WebPreferencesStore::Value
achristensen@apple.com [Thu, 2 Aug 2018 21:48:21 +0000 (21:48 +0000)]
Use WTF::Variant for WebPreferencesStore::Value
https://bugs.webkit.org/show_bug.cgi?id=188250

Reviewed by Sam Weinig.

It was conceptually a variant. This just uses an actual WTF::Variant.
Since it's encoded and decoded, I wrote variadic template encoders and decoders
like we have for other types (Expected, std::tuple, KeyValuePair, etc.)

* Platform/IPC/ArgumentCoders.h:
(IPC::VariantCoder::encode):
(IPC::VariantCoder::decode):
Introduce ArgumentCoder<Variant>, which encodes which type the Variant currently
holds followed by the encoding of the current type.
* Platform/IPC/Decoder.cpp:
(IPC::Decoder::Decoder):
* Platform/IPC/Decoder.h:
* Platform/IPC/mac/ConnectionMac.mm:
(IPC::createMessageDecoder):
Use move semantics to prevent an unnecessary copy of the Vector<Attachment>
* Scripts/PreferencesTemplates/WebPreferencesStoreDefaultsMap.cpp.erb:
* Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::decode):
Use modern std::optional-based decoding supported by the new Variant decoding.
(WebKit::valueForKey):
Use WTF::get and WTF::holds_alternative instead of custom type checks.
(WebKit::WebPreferencesStore::Value::encode const): Deleted.
(WebKit::WebPreferencesStore::Value::decode): Deleted.
(WebKit::as<String>): Deleted.
(WebKit::as<bool>): Deleted.
(WebKit::as<uint32_t>): Deleted.
(WebKit::as<double>): Deleted.
* Shared/WebPreferencesStore.h:
(WebKit::WebPreferencesStore::Value::Value): Deleted.
(WebKit::WebPreferencesStore::Value::operator=): Deleted.
(WebKit::WebPreferencesStore::Value::~Value): Deleted.
(WebKit::WebPreferencesStore::Value::type const): Deleted.
(WebKit::WebPreferencesStore::Value::asString const): Deleted.
(WebKit::WebPreferencesStore::Value::asBool const): Deleted.
(WebKit::WebPreferencesStore::Value::asUInt32 const): Deleted.
(WebKit::WebPreferencesStore::Value::asDouble const): Deleted.
(WebKit::WebPreferencesStore::Value::destroy): Deleted.
(): Deleted.
Use WTF::Variant instead of a custom type/union pair.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoReformat editable selection tests to remove potential flakeyness due to autoscroll
megan_gardner@apple.com [Thu, 2 Aug 2018 21:26:43 +0000 (21:26 +0000)]
Reformat editable selection tests to remove potential flakeyness due to autoscroll
https://bugs.webkit.org/show_bug.cgi?id=188263
<rdar://problem/40565375>

Reviewed by Wenson Hsieh

Change the format of these editable selection tests to put the editable content at the top of the page so
that when selecting we do not run into the page trying to autoscroll while selecting, which makes the tests more
flakey, and more difficult to get accurate and consistent answers.

* fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-down-to-change-selected-text.html:
* fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-left-to-change-selected-text.html:
* fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-right-to-change-selected-text.html:
* fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-up-to-change-selected-text.html:
* fast/events/touch/ios/long-press-on-editable-content-then-drag-down-to-change-selected-text.html:
* fast/events/touch/ios/long-press-on-editable-content-then-drag-left-to-change-selected-text.html:
* fast/events/touch/ios/long-press-on-editable-content-then-drag-right-to-change-selected-text.html:
* fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoAdd some Variant types to Forward.h
achristensen@apple.com [Thu, 2 Aug 2018 20:24:57 +0000 (20:24 +0000)]
Add some Variant types to Forward.h
https://bugs.webkit.org/show_bug.cgi?id=188250

* wtf/Forward.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoCheck with SafeBrowsing during navigation in WKWebView
achristensen@apple.com [Thu, 2 Aug 2018 20:13:05 +0000 (20:13 +0000)]
Check with SafeBrowsing during navigation in WKWebView
https://bugs.webkit.org/show_bug.cgi?id=188133

Reviewed by Chris Dumez.

This turns WebFramePolicyListenerProxy into an object that now listens for the results
of two processes happening in parallel: the API::NavigationClient's decidePolicyForNavigation{Action, Response}
(which it was already waiting for) and, on platforms that support it, the SafariSafeBrowsing framework's check.
The first result is stored as it waits for the second result unless the first result is the API::NavigationClient
saying to cancel or convert the navigation to a download, in which cases we don't care what the safe browsing
framework results are because we won't show the URL in the browser.

Nothing is done with the safe browsing results yet.

* UIProcess/Cocoa/SafeBrowsingResultCocoa.mm: Added.
(WebKit::SafeBrowsingResult::SafeBrowsingResult):
* UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::beginSafeBrowsingCheck):
* UIProcess/SafeBrowsingResult.h: Added.
(WebKit::SafeBrowsingResult::provider const):
(WebKit::SafeBrowsingResult::isPhishing const):
(WebKit::SafeBrowsingResult::isMalware const):
(WebKit::SafeBrowsingResult::isUnwantedSoftware const):
(WebKit::SafeBrowsingResult::isKnownToBeUnsafe const):
* UIProcess/WebFramePolicyListenerProxy.cpp:
(WebKit::WebFramePolicyListenerProxy::WebFramePolicyListenerProxy):
(WebKit::WebFramePolicyListenerProxy::didReceiveSafeBrowsingResults):
(WebKit::WebFramePolicyListenerProxy::use):
(WebKit::WebFramePolicyListenerProxy::download):
(WebKit::WebFramePolicyListenerProxy::ignore):
* UIProcess/WebFramePolicyListenerProxy.h:
(WebKit::WebFramePolicyListenerProxy::create):
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::setUpPolicyListenerProxy):
* UIProcess/WebFrameProxy.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponse):
* UIProcess/WebPageProxy.h:
* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoText selection color is hard to see in dark mode web views.
timothy@apple.com [Thu, 2 Aug 2018 20:12:40 +0000 (20:12 +0000)]
Text selection color is hard to see in dark mode web views.
https://bugs.webkit.org/show_bug.cgi?id=188260
rdar://problem/42721294

Reviewed by Simon Fraser.

Stop using blendWithWhite() to transform the AppKit selection color in dark mode.
Using an alpha of 80% gives good contrast, and still works good for selections over images.

* platform/graphics/Color.cpp:
(WebCore::Color::blendWithWhite const): Mark new colors as semantic if the original is.
(WebCore::Color::colorWithAlpha const): Ditto.
* rendering/RenderElement.cpp:
(WebCore::RenderElement::selectionBackgroundColor const): Use transformSelectionBackgroundColor.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::activeSelectionBackgroundColor const): Use transformSelectionBackgroundColor.
(WebCore::RenderTheme::inactiveSelectionBackgroundColor const): Ditto.
(WebCore::RenderTheme::transformSelectionBackgroundColor const): Added. Just blend with white.
* rendering/RenderTheme.h:
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::transformSelectionBackgroundColor const): Added. Use an alpha with the color
in dark mode, otherwise fallback to RenderTheme.
(WebCore::RenderThemeMac::systemColor const): Use activeListBoxSelectionBackgroundColor()
and activeSelectionBackgroundColor() instead of caching the colors again. Update hardcoded color.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[LFC][Floating] Use displayBox.rectWithMargin().bottom instead of displayBox.bottom...
zalan@apple.com [Thu, 2 Aug 2018 20:07:43 +0000 (20:07 +0000)]
[LFC][Floating] Use displayBox.rectWithMargin().bottom instead of displayBox.bottom() to where applicable.
https://bugs.webkit.org/show_bug.cgi?id=188274

Reviewed by Antti Koivisto.

Float placement uses the margin box.

* layout/FloatingContext.cpp:
(WebCore::Layout::FloatingPair::bottom const):
(WebCore::Layout::Iterator::operator++):
(WebCore::Layout::Iterator::set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[LFC][Floating] Right aligned float's horizontal candidate position is miscomputed.
zalan@apple.com [Thu, 2 Aug 2018 19:56:46 +0000 (19:56 +0000)]
[LFC][Floating] Right aligned float's horizontal candidate position is miscomputed.
https://bugs.webkit.org/show_bug.cgi?id=188273

Reviewed by Antti Koivisto.

rightAlignedBoxLeft is already shifted with the size of the margin box.

* layout/FloatingContext.cpp:
(WebCore::Layout::FloatingContext::alignWithFloatings const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[LFC] Display:Box::rectWithMargin()'s width and height don't include margin left...
zalan@apple.com [Thu, 2 Aug 2018 19:47:57 +0000 (19:47 +0000)]
[LFC] Display:Box::rectWithMargin()'s width and height don't include margin left/top.
https://bugs.webkit.org/show_bug.cgi?id=188272

Reviewed by Antti Koivisto.

* layout/displaytree/DisplayBox.h:
(WebCore::Display::Box::rectWithMargin const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[LFC][Floating] Containing block of a float could push the candidate position beyond...
zalan@apple.com [Thu, 2 Aug 2018 19:40:37 +0000 (19:40 +0000)]
[LFC][Floating] Containing block of a float could push the candidate position beyond the current float.
https://bugs.webkit.org/show_bug.cgi?id=188264

Reviewed by Antti Koivisto.

<div id=first style="float: left; width: 100px; height: 10px;"></div>
<div id=second style="float: left; width: 10px; height: 10px;"></div>
<div style="width: 50px; height: 50px;>
    <div id=third style="float: left; width: 10px; height: 10px;"></div>
</div>
In the example above by the time the "third" float comes in, we are already at 110px horizontally. However the containing block of the "third" float forces
the candidate position at 0px. In such cases intersecting won't work since the candidate position is beyond the last(second) float (horizontally).
We could either keep going back to the previous floats on this vertical position and eventually intersect with "first" or just compare the horizontal
positions and ensure that the left/right float is not going to be placed to the left/right of the last float on the current vertical position.

* layout/FloatingContext.cpp:
(WebCore::Layout::FloatingPair::intersects const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoImplement customElements.upgrade()
rniwa@webkit.org [Thu, 2 Aug 2018 19:25:23 +0000 (19:25 +0000)]
Implement customElements.upgrade()
https://bugs.webkit.org/show_bug.cgi?id=183397

Reviewed by Frédéric Wang.

LayoutTests/imported/w3c:

Rebaseline the test now that we're passing.

* web-platform-tests/custom-elements/custom-element-registry/upgrade-expected.txt:

Source/WebCore:

Added the support to upgrade custom elements directly. Ordinarily, custom elements get upgraded as they are
inserted / connected into a document but some script libraries and authors want to be able to upgrade them before that.
Also see https://github.com/w3c/webcomponents/issues/710

Implemented the method as specified at:
https://html.spec.whatwg.org/multipage/custom-elements.html#dom-customelementregistry-upgrade

    When invoked, the upgrade(root) method must run these steps:
    1. Let candidates be a list of all of root's shadow-including inclusive descendant elements,
       in shadow-including tree order.
    2. For each candidate of candidates, try to upgrade candidate.

Tests: imported/w3c/web-platform-tests/custom-elements/custom-element-registry/upgrade.html

* dom/CustomElementReactionQueue.cpp:
(WebCore::CustomElementReactionQueue::enqueueElementUpgradeIfDefined): Removed the assertion that the upgraded element
is connected since the whole point of this API is to upgrade a disconnected element.
* dom/CustomElementRegistry.cpp:
(WebCore::upgradeElementsInShadowIncludingdescendants): Added.
(WebCore::CustomElementRegistry::upgrade): Added.
* dom/CustomElementRegistry.h: Forward declare DeferredPromise instead of unnecessarily including JSDOMPromiseDeferred.h.
* dom/CustomElementRegistry.idl:
* dom/Element.cpp:
(WebCore::Element::insertedIntoAncestor): Moved the assertion here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoConvert calc-related enums to 8-bit enum classes
simon.fraser@apple.com [Thu, 2 Aug 2018 19:19:33 +0000 (19:19 +0000)]
Convert calc-related enums to 8-bit enum classes
https://bugs.webkit.org/show_bug.cgi?id=188215

Reviewed by Zalan Bujtas.

This shrinks CSSCalcOperation from 48 to 32 bytes.

* css/CSSCalculationValue.cpp:
(WebCore::unitCategory):
(WebCore::determineCategory):
(WebCore::resolvedTypeForMinOrMax):
(WebCore::isIntegerResult):
(WebCore::CSSCalcExpressionNodeParser::parseValue):
(WebCore::CSSCalcExpressionNodeParser::parseValueMultiplicativeExpression):
(WebCore::CSSCalcExpressionNodeParser::parseAdditiveValueExpression):
(WebCore::CSSCalcExpressionNodeParser::parseMinMaxExpression):
(WebCore::createBlendHalf):
(WebCore::createCSS):
* css/CSSCalculationValue.h:
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::primitiveType const):
* css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertTo100PercentMinusLength):
* css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::CalcParser::consumeNumberRaw):
(WebCore::CSSPropertyParserHelpers::CalcParser::consumePositiveIntegerRaw):
(WebCore::CSSPropertyParserHelpers::consumeInteger):
(WebCore::CSSPropertyParserHelpers::consumePositiveIntegerRaw):
(WebCore::CSSPropertyParserHelpers::consumeNumberRaw):
(WebCore::CSSPropertyParserHelpers::consumeNumber):
(WebCore::CSSPropertyParserHelpers::consumeFontWeightNumber):
(WebCore::CSSPropertyParserHelpers::consumeLength):
(WebCore::CSSPropertyParserHelpers::consumePercent):
(WebCore::CSSPropertyParserHelpers::canConsumeCalcValue):
(WebCore::CSSPropertyParserHelpers::consumeLengthOrPercent):
(WebCore::CSSPropertyParserHelpers::consumeAngle):
(WebCore::CSSPropertyParserHelpers::consumeAngleOrPercent):
(WebCore::CSSPropertyParserHelpers::consumeTime):
* platform/CalculationValue.cpp:
(WebCore::CalcExpressionNumber::operator== const):
(WebCore::CalcExpressionOperation::evaluate const):
(WebCore::CalcExpressionOperation::operator== const):
(WebCore::CalcExpressionOperation::dump const):
(WebCore::CalcExpressionLength::operator== const):
(WebCore::CalcExpressionBlendLength::CalcExpressionBlendLength):
(WebCore::CalcExpressionBlendLength::operator== const):
(WebCore::operator<<):
* platform/CalculationValue.h:
(WebCore::CalcExpressionNumber::CalcExpressionNumber):
(WebCore::toCalcExpressionNumber):
(WebCore::CalcExpressionLength::CalcExpressionLength):
(WebCore::toCalcExpressionLength):
(WebCore::CalcExpressionOperation::CalcExpressionOperation):
(WebCore::toCalcExpressionOperation):
(WebCore::toCalcExpressionBlendLength):
* platform/Length.cpp:
(WebCore::convertTo100PercentMinusLength):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoFixed WebKit.AttrStyle timing out on build.webkit.org.
mitz@apple.com [Thu, 2 Aug 2018 19:06:42 +0000 (19:06 +0000)]
Fixed WebKit.AttrStyle timing out on build.webkit.org.

* TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.html: Changed from a URL that requires network
  access to one that doesn’t.
* TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm:
(TEST): Updated expected value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[iOS] Keyboard becomes unresponsive after pressing delete while pressing down on...
wenson_hsieh@apple.com [Thu, 2 Aug 2018 18:32:22 +0000 (18:32 +0000)]
[iOS] Keyboard becomes unresponsive after pressing delete while pressing down on a character key with accents
https://bugs.webkit.org/show_bug.cgi?id=188251
<rdar://problem/37842108>

Reviewed by Tim Horton.

Source/WebKit:

Fixes a bug in key event handling where invoking -handleKeyWebEvent:withCompletionHandler: from within the
completion callback of a previous call to -handleKeyWebEvent:withCompletionHandler: would cause the completion
callback to be cleared out prematurely. In some cases (as described in the title of this bug), UIKit exercises
this codepath and subsequently hangs due to their completion block never getting invoked by WebKit.

Test: KeyboardInputTests.CanHandleKeyEventInCompletionHandler

* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView handleKeyWebEvent:withCompletionHandler:]):
(-[WKContentView _didHandleKeyEvent:eventWasHandled:]):

Tools:

Adds a new API test to verify that clients (in this case, UIKit) is allowed to invoke
-handleKeyWebEvent:withCompletionHandler: within the completion block of a prior invocation.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm: Added.
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/ios/TestInputDelegate.h: Added.

Pull some logic used to force an input session to start out from an existing API test file
(WKWebViewAutofillTests) and into a separate helper class that is used by both the existing API tests and the
new keyboard input test.

* TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
(-[AutofillTestView initWithFrame:]):
(TestWebKitAPI::TEST):
(-[TestInputDelegate init]): Deleted.
(-[TestInputDelegate _webView:focusShouldStartInputSession:]): Deleted.
* TestWebKitAPI/ios/UIKitSPI.h:

Add some UIKit SPI utilized by the new API test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoHandle zero-sized ISOMP4 boxes appropriately
cturner@igalia.com [Thu, 2 Aug 2018 17:43:40 +0000 (17:43 +0000)]
Handle zero-sized ISOMP4 boxes appropriately
https://bugs.webkit.org/show_bug.cgi?id=188256

Reviewed by Jer Noble.

According to ISO/IEC 14496-12:2012(E), when the Box classes' size
field is zero, the implied size of the box extends to the end of
the file. If this detail is not taken into account, CENC
sanitization can incorrectly report an invalid box size, since 0
!= the number of bytes in this box, specifically, the data layout
of Box is as follows,

aligned(8) class Box (unsigned int(32) boxtype,
      optional unsigned int(8)[16] extended_type) {
   unsigned int(32) size;
   unsigned int(32) type = boxtype;
   if (size==1) {
     unsigned int(64) largesize;
   } else if (size==0) { // This is the case now handled.
     // box extends to end of file
   }
   if (boxtype==‘uuid’) {
     unsigned int(8)[16] usertype = extended_type;
   }
}

Tested by imported/w3c/web-platform-tests/encrypted-media/clearkey-generate-request-disallowed-input.https.html

* platform/graphics/iso/ISOBox.cpp:
(WebCore::ISOBox::peekBox): Check if the parsed size is zero, and
if it is, the size is calculated as the total number of bytes in
the incoming DataView.
(WebCore::ISOBox::parse): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoOptionally expose Attr::style to JavaScript
mitz@apple.com [Thu, 2 Aug 2018 16:42:39 +0000 (16:42 +0000)]
Optionally expose Attr::style to JavaScript
https://bugs.webkit.org/show_bug.cgi?id=188226
<rdar://problem/42818113>

Reviewed by Darin Adler.

Source/WebCore:

Test: TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm

* dom/Attr.cpp: Update comment.
* dom/Attr.idl: Define the style attribute, enabled at runtime by the AttrStyle feature.

* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setAttrStyleEnabled): Added this accessor.
(WebCore::RuntimeEnabledFeatures::attrStyleEnabled const): Ditto.

Source/WebKit:

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const): Encode new attrStyleEnabled member.
(WebKit::WebProcessCreationParameters::decode): Decode new attrStyleEnabled member.
* Shared/WebProcessCreationParameters.h: Define new attrStyleEnabled member, initialized to
  false.

* UIProcess/API/APIProcessPoolConfiguration.cpp:
(API::ProcessPoolConfiguration::copy): Copy new m_attrStyleEnabled member.
* UIProcess/API/APIProcessPoolConfiguration.h: Define new m_attrStyleEnabled member.

* UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h: Declare new attrStyleEnabled boolean
  property.
* UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:
(-[_WKProcessPoolConfiguration attrStyleEnabled]): New accessor.
(-[_WKProcessPoolConfiguration setAttrStyleEnabled:]): Ditto.

* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::initializeNewWebProcess): Initialize parameters.attrStyleEnabled
  from the configuration.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess): Set the attrStyleEnabled runtime feature based
  on the creation parameters.

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.html: Added.
* TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm: Added.
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoUnreviewed, rolling out r234489.
david_fenton@apple.com [Thu, 2 Aug 2018 15:45:09 +0000 (15:45 +0000)]
Unreviewed, rolling out r234489.

Caused 50+ crashes and 60+ API failures on iOS

Reverted changeset:

"[WTF] Rename String::format to String::deprecatedFormat"
https://bugs.webkit.org/show_bug.cgi?id=188191
https://trac.webkit.org/changeset/234489

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[LFC][Floating] Do not pass formatting root to FloatingContext
zalan@apple.com [Thu, 2 Aug 2018 15:01:48 +0000 (15:01 +0000)]
[LFC][Floating] Do not pass formatting root to FloatingContext
https://bugs.webkit.org/show_bug.cgi?id=188257

Reviewed by Antti Koivisto.

If we ever need it, we can get it from FloatingState.

* layout/FloatingContext.cpp:
(WebCore::Layout::FloatingContext::FloatingContext):
* layout/FloatingContext.h:
* layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layout const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[LFC][Floating] Convert all coordinates relative to the formatting context root.
zalan@apple.com [Thu, 2 Aug 2018 14:28:28 +0000 (14:28 +0000)]
[LFC][Floating] Convert all coordinates relative to the formatting context root.
https://bugs.webkit.org/show_bug.cgi?id=188249

Reviewed by Antti Koivisto.

The idea here is that all the float related computation should be happening in the same coordinate system.
FloatItem holds the transformed Display::Box for both the layout box and its containing block.

* layout/FloatingContext.cpp:
(WebCore::Layout::begin):
(WebCore::Layout::end):
(WebCore::Layout::FloatingContext::computePosition const):
(WebCore::Layout::FloatingContext::floatingPosition const):
(WebCore::Layout::FloatingContext::initialVerticalPosition const):
(WebCore::Layout::FloatingContext::alignWithContainingBlock const):
(WebCore::Layout::FloatingContext::alignWithFloatings const):
(WebCore::Layout::FloatingContext::toContainingBlock const):
(WebCore::Layout::FloatingPair::FloatingPair):
(WebCore::Layout::FloatingPair::left const):
(WebCore::Layout::FloatingPair::right const):
(WebCore::Layout::Iterator::Iterator):
(WebCore::Layout::previousFloatingIndex):
(WebCore::Layout::Iterator::operator++):
(WebCore::Layout::Iterator::set):
* layout/FloatingContext.h:
* layout/FloatingState.cpp:
(WebCore::Layout::FloatingState::FloatItem::FloatItem):
(WebCore::Layout::FloatingState::remove):
(WebCore::Layout::FloatingState::append):
* layout/FloatingState.h:
(WebCore::Layout::FloatingState::isEmpty const):
(WebCore::Layout::FloatingState::FloatItem::layoutBox const):
(WebCore::Layout::FloatingState::FloatItem::containingBlock const):
(WebCore::Layout::FloatingState::FloatItem::displayBox const):
(WebCore::Layout::FloatingState::FloatItem::containingBlockDisplayBox const):
(WebCore::Layout::FloatingState::floats const):
(WebCore::Layout::FloatingState::last const):
(WebCore::Layout::FloatingState::root const):
(WebCore::Layout::FloatingState::floatings const): Deleted.
* layout/displaytree/DisplayBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[GStreamer] Dynamically adjust blocksize
cturner@igalia.com [Thu, 2 Aug 2018 12:21:53 +0000 (12:21 +0000)]
[GStreamer] Dynamically adjust blocksize
https://bugs.webkit.org/show_bug.cgi?id=188194

Reviewed by Xabier Rodriguez-Calvar.

Update the blocksize depending on how much is obtained from a read
of the input stream. This avoids doing too many reads in small
chunks when larger amounts of data are available and also prevents
using a very large memory area to read a small chunk of data.

Adapted from https://bugzilla.gnome.org/show_bug.cgi?id=767833

No tests new tests since no change in functionality.

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_init):
(CachedResourceStreamingClient::checkUpdateBlocksize):
(CachedResourceStreamingClient::dataReceived):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[GStreamer] Stop pushing buffers when seeking status changes
cturner@igalia.com [Thu, 2 Aug 2018 09:23:42 +0000 (09:23 +0000)]
[GStreamer] Stop pushing buffers when seeking status changes
https://bugs.webkit.org/show_bug.cgi?id=188193

Reviewed by Xabier Rodriguez-Calvar.

After switching to splitting buffers into smaller block sizes in

    https://bugs.webkit.org/show_bug.cgi?id=182829

It was found that during the individual buffer pushes, the seeking
status could change behind our backs from another thread. When
this happens, buffers from incorrect offsets would find their way
into appsrc and eventually the demuxer itself, which would start
parsing from a random place and at best give a confusing error
message.

The solution here is break from pushing buffers when the seeking
status has been has changed. Flushes will clear out what we've
already delivered into the appsrc, then we must make sure to not
continue sending buffers in there after the flush.

No new tests since this is a timing bug.

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(CachedResourceStreamingClient::dataReceived):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoUnreviewed, revert TransformationMatrix::operator== change
utatane.tea@gmail.com [Thu, 2 Aug 2018 04:24:11 +0000 (04:24 +0000)]
Unreviewed, revert TransformationMatrix::operator== change
https://bugs.webkit.org/show_bug.cgi?id=188197

This change partially revert cleaning up of TransformationMatrix since memcmp does not
follow double comparison algorithm. So semantics was accidentally changed.

* platform/graphics/transforms/TransformationMatrix.h:
(WebCore::TransformationMatrix::operator== const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoUnreviewed, rename TransformationMatrix::Identity to TransformationMatrix::identity
utatane.tea@gmail.com [Thu, 2 Aug 2018 04:10:43 +0000 (04:10 +0000)]
Unreviewed, rename TransformationMatrix::Identity to TransformationMatrix::identity
https://bugs.webkit.org/show_bug.cgi?id=188204

Follow the coding style.

* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::transform const):
(WebCore::GraphicsLayer::childrenTransform const):
* platform/graphics/transforms/TransformationMatrix.cpp:
* platform/graphics/transforms/TransformationMatrix.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoAdd self.queueMicrotask(f) on DOMWindow
utatane.tea@gmail.com [Thu, 2 Aug 2018 03:55:47 +0000 (03:55 +0000)]
Add self.queueMicrotask(f) on DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=188212

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

* CMakeLists.txt:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Sources.txt:
* runtime/JSGlobalObject.cpp:
(JSC::enqueueJob):
* runtime/JSMicrotask.cpp: Renamed from Source/JavaScriptCore/runtime/JSJob.cpp.
(JSC::createJSMicrotask):
Export them to WebCore.

(JSC::JSMicrotask::run):
* runtime/JSMicrotask.h: Renamed from Source/JavaScriptCore/runtime/JSJob.h.
Add another version of JSMicrotask which does not have arguments.

Source/WebCore:

This patch adds self.queueMicrotask(f) in DOMWindow, which takes a function and enqueue it into microtask queue.
We do not add this to Worker's global scope since our worker does not support microtasks correctly.

Tests: js/dom/queue-microtask-window.html

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::queueMicrotask):
Post a microtask to JSC's microtask mechanism. This will eventually go to WebCore's MicrotaskQueue code.

* page/DOMWindow.idl:

LayoutTests:

* js/dom/queue-microtask-window-expected.txt: Added.
* js/dom/queue-microtask-window.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoTestWTF.WTF_NeverDestroyed.Construct output differs for MSVC in Debug mode
ross.kirsling@sony.com [Thu, 2 Aug 2018 02:19:04 +0000 (02:19 +0000)]
TestWTF.WTF_NeverDestroyed.Construct output differs for MSVC in Debug mode
https://bugs.webkit.org/show_bug.cgi?id=188244

Reviewed by Daniel Bates.

Follow-up to r234179. MSVC chooses not to inline the lambda in Debug mode.

* TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[WTF] Rename String::format to String::deprecatedFormat
tpopela@redhat.com [Thu, 2 Aug 2018 02:11:46 +0000 (02:11 +0000)]
[WTF] Rename String::format to String::deprecatedFormat
https://bugs.webkit.org/show_bug.cgi?id=188191

Reviewed by Darin Adler.

It should be replaced with string concatenation.

Source/JavaScriptCore:

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::nameForRegister):
* inspector/InjectedScriptBase.cpp:
(Inspector::InjectedScriptBase::makeCall):
* inspector/InspectorBackendDispatcher.cpp:
(Inspector::BackendDispatcher::getPropertyValue):
* inspector/agents/InspectorConsoleAgent.cpp:
(Inspector::InspectorConsoleAgent::enable):
(Inspector::InspectorConsoleAgent::stopTiming):
* jsc.cpp:
(FunctionJSCStackFunctor::operator() const):
* parser/Lexer.cpp:
(JSC::Lexer<T>::invalidCharacterMessage const):
* runtime/IntlDateTimeFormat.cpp:
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
* runtime/IntlObject.cpp:
(JSC::canonicalizeLocaleList):
* runtime/LiteralParser.cpp:
(JSC::LiteralParser<CharType>::Lexer::lex):
(JSC::LiteralParser<CharType>::Lexer::lexStringSlow):
(JSC::LiteralParser<CharType>::parse):
* runtime/LiteralParser.h:
(JSC::LiteralParser::getErrorMessage):

Source/WebCore:

* Modules/indexeddb/IDBKeyData.cpp:
(WebCore::IDBKeyData::loggingString const):
* Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
* Modules/indexeddb/shared/IDBCursorInfo.cpp:
(WebCore::IDBCursorInfo::loggingString const):
* Modules/indexeddb/shared/IDBGetAllRecordsData.cpp:
(WebCore::IDBGetAllRecordsData::loggingString const):
* Modules/indexeddb/shared/IDBGetRecordData.cpp:
(WebCore::IDBGetRecordData::loggingString const):
* Modules/indexeddb/shared/IDBIndexInfo.cpp:
(WebCore::IDBIndexInfo::loggingString const):
(WebCore::IDBIndexInfo::condensedLoggingString const):
* Modules/indexeddb/shared/IDBIterateCursorData.cpp:
(WebCore::IDBIterateCursorData::loggingString const):
* Modules/indexeddb/shared/IDBObjectStoreInfo.cpp:
(WebCore::IDBObjectStoreInfo::condensedLoggingString const):
* Modules/indexeddb/shared/IDBResourceIdentifier.cpp:
(WebCore::IDBResourceIdentifier::loggingString const):
* Modules/webdatabase/Database.cpp:
(WebCore::formatErrorMessage):
* Modules/webdatabase/SQLError.h:
(WebCore::SQLError::create):
* Modules/websockets/WebSocket.cpp:
(WebCore::encodeProtocolString):
* accessibility/win/AccessibilityObjectWrapperWin.cpp:
(WebCore::AccessibilityObjectWrapper::accessibilityAttributeValue):
* css/CSSUnicodeRangeValue.cpp:
(WebCore::CSSUnicodeRangeValue::customCSSText const):
* css/MediaQueryEvaluator.cpp:
(WebCore::aspectRatioValueAsString):
* css/parser/CSSParserToken.cpp:
(WebCore::CSSParserToken::serialize const):
* css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::parseHexColor):
* dom/Document.cpp:
(WebCore::Document::lastModified):
* html/FTPDirectoryDocument.cpp:
(WebCore::processFilesizeString):
(WebCore::processFileDateString):
* html/HTMLMediaElement.h:
(WTF::ValueToString<WebCore::TextTrackCue::string):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setLength):
* html/ImageDocument.cpp:
(WebCore::ImageDocument::imageUpdated):
* html/canvas/WebGLRenderingContextBase.cpp:
* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::init):
* html/track/VTTCue.cpp:
(WebCore::VTTCueBox::applyCSSProperties):
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::setDockingUnavailable):
(WebCore::InspectorFrontendClientLocal::setAttachedWindow):
(WebCore::InspectorFrontendClientLocal::setDebuggingEnabled):
(WebCore::InspectorFrontendClientLocal::setTimelineProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::showMainResourceForFrame):
* inspector/agents/InspectorCSSAgent.cpp:
* inspector/agents/InspectorIndexedDBAgent.cpp:
* page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::windowRoundedCornerRadiusCSS const):
* page/History.cpp:
(WebCore::History::stateObjectAdded):
* page/MemoryRelease.cpp:
(WebCore::logMemoryStatisticsAtTimeOfDeath):
* page/cocoa/ResourceUsageOverlayCocoa.mm:
(WebCore::formatByteNumber):
(WebCore::gcTimerString):
(WebCore::ResourceUsageOverlay::platformDraw):
* page/cocoa/ResourceUsageThreadCocoa.mm:
(WebCore::logFootprintComparison):
* page/linux/ResourceUsageOverlayLinux.cpp:
(WebCore::cpuUsageString):
(WebCore::formatByteNumber):
(WebCore::gcTimerString):
* page/scrolling/AxisScrollSnapOffsets.cpp:
(WebCore::snapOffsetsToString):
(WebCore::snapOffsetRangesToString):
(WebCore::snapPortOrAreaToString):
* platform/DateComponents.cpp:
(WebCore::DateComponents::toStringForTime const):
(WebCore::DateComponents::toString const):
* platform/LocalizedStrings.cpp:
* platform/animation/TimingFunction.cpp:
(WebCore::TimingFunction::cssText const):
* platform/audio/HRTFElevation.cpp:
(WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):
* platform/cocoa/KeyEventCocoa.mm:
(WebCore::keyIdentifierForCharCode):
* platform/gamepad/mac/HIDGamepad.cpp:
(WebCore::HIDGamepad::HIDGamepad):
* platform/glib/UserAgentGLib.cpp:
(WebCore::platformVersionForUAString):
* platform/graphics/Color.cpp:
(WebCore::Color::nameForRenderTreeAsText const):
* platform/graphics/FloatPolygon.h:
(WTF::ValueToString<WebCore::FloatPolygonEdge::string):
* platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:
(WebCore::AVTrackPrivateAVFObjCImpl::id const):
* platform/graphics/avfoundation/MediaSampleAVFObjC.h:
(WebCore::MediaSampleAVFObjC::MediaSampleAVFObjC):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setName):
(WebCore::GraphicsLayerCA::setContentsToSolidColor):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::updateContentsImage):
(WebCore::GraphicsLayerCA::updateContentsRects):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
* platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::simpleBusMessageCallback):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::load):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::handleStateChangeMessage):
(WebCore::AppendPipeline::resetPipeline):
* platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::load):
(WebCore::MediaPlayerPrivateGStreamerMSE::doSeek):
* platform/graphics/gtk/ImageBufferGtk.cpp:
(WebCore::encodeImage):
* platform/gtk/PlatformKeyboardEventGtk.cpp:
(WebCore::PlatformKeyboardEvent::keyIdentifierForGdkKeyCode):
* platform/mediastream/gstreamer/GStreamerAudioCaptureSource.cpp:
(WebCore::GStreamerAudioCaptureSource::create):
* platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
(WebCore::webkitMediaStreamSrcAddPad):
* platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:
(WebCore::GStreamerVideoCaptureSource::create):
* platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:
(WebCore::GStreamerVideoEncoder::makeElement):
* platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::drawText):
* platform/mock/mediasource/MockSourceBufferPrivate.cpp:
* platform/network/ParsedContentRange.cpp:
(WebCore::ParsedContentRange::headerValue const):
* platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::NetworkStorageSession::switchToNewTestingSession):
* platform/sql/SQLiteDatabase.cpp:
(WebCore::unauthorizedSQLFunction):
* platform/text/PlatformLocale.cpp:
(WebCore::DateTimeStringBuilder::visitField):
* platform/win/GDIObjectCounter.cpp:
(WebCore::GDIObjectCounter::GDIObjectCounter):
* platform/win/KeyEventWin.cpp:
(WebCore::keyIdentifierForWindowsKeyCode):
* rendering/FloatingObjects.h:
(WTF::ValueToString<WebCore::FloatingObject::string):
* rendering/RenderFragmentedFlow.h:
(WTF::ValueToString<WebCore::RenderFragmentContainer::string):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::logLayerInfo):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::formatMediaControlsTime const):
* testing/Internals.cpp:
(WebCore::Internals::address):
* workers/service/server/RegistrationDatabase.cpp:
(WebCore::RegistrationDatabase::ensureValidRecordsTable):
(WebCore::RegistrationDatabase::importRecords):

Source/WebCore/PAL:

* pal/FileSizeFormatter.cpp:
(fileSizeDescription):

Source/WebKit:

* NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::buildAcceptLanguages):
* Platform/IPC/win/ConnectionWin.cpp:
(IPC::Connection::createServerAndClientIdentifiers):
* Shared/WebMemorySampler.cpp:
(WebKit::WebMemorySampler::writeHeaders):
* Shared/win/WebEventFactory.cpp:
(WebKit::keyIdentifierFromEvent):
* Shared/wpe/WebEventFactory.cpp:
(WebKit::identifierStringForKeyEvent):
* UIProcess/API/APINavigation.cpp:
(API::Navigation::loggingString const):
* UIProcess/API/glib/IconDatabase.cpp:
(WebKit::IconDatabase::performURLImport):
* UIProcess/Cocoa/ViewGestureController.cpp:
(WebKit::ViewGestureController::SnapshotRemovalTracker::startWatchdog):
* UIProcess/SuspendedPageProxy.cpp:
(WebKit::SuspendedPageProxy::loggingString const):
* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::loggingString):
* UIProcess/WebInspectorUtilities.cpp:
(WebKit::inspectorPageGroupIdentifierForPage):
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processDidFinishLaunching):
(WebKit::WebProcessPool::startMemorySampler):
* UIProcess/gtk/InputMethodFilter.cpp:
(WebKit::InputMethodFilter::logHandleKeyboardEventForTesting):
(WebKit::InputMethodFilter::logHandleKeyboardEventWithCompositionResultsForTesting):
(WebKit::InputMethodFilter::logConfirmCompositionForTesting):
(WebKit::InputMethodFilter::logSetPreeditForTesting):

Source/WebKitLegacy/win:

* FullscreenVideoController.cpp:
(timeToString):
* WebView.cpp:
(webKitVersionString):

Source/WTF:

* wtf/Assertions.cpp:
* wtf/JSONValues.cpp:
* wtf/WorkQueue.cpp:
(WTF::WorkQueue::concurrentApply):
* wtf/dtoa.cpp:
(WTF::dtoa):
* wtf/text/WTFString.cpp:
(WTF::String::deprecatedFormat):
(WTF::String::format): Deleted.
* wtf/text/WTFString.h:

Tools:

* DumpRenderTree/win/DumpRenderTree.cpp:
(applicationId):
(main):
* TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
(TestWebKitAPI::Util::createURLForResource):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::cacheTestRunnerCallback):
* WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::attributedStringForRange):
(WTR::AccessibilityUIElement::url):
(WTR::stringAtOffset):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveAuthenticationChallenge):
(WTR::TestController::downloadDidFail):
(WTR::originUserVisibleName):
(WTR::userMediaOriginHash):
(WTR::TestController::didNavigateWithNavigationData):
(WTR::TestController::didPerformClientRedirect):
(WTR::TestController::didPerformServerRedirect):
(WTR::TestController::didUpdateHistoryTitle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoUsing the keyboard arrow keys to scroll a webpage is very slow, not smooth, takes...
timothy_horton@apple.com [Thu, 2 Aug 2018 00:30:10 +0000 (00:30 +0000)]
Using the keyboard arrow keys to scroll a webpage is very slow, not smooth, takes too long
https://bugs.webkit.org/show_bug.cgi?id=188239
<rdar://problem/22997654>

Reviewed by Simon Fraser.

Source/WebCore/PAL:

* pal/spi/cocoa/QuartzCoreSPI.h:
Add a piece of SPI.

Source/WebKit:

Instead of depending on key repeat to drive scrolling with arrow keys held down,
run a display link that animates the scroll. We still do a single discrete scroll
first (so that you can tap the key and shift by line/page), but then on the first
repeat we ramp up to a constant velocity determined by the desired increment,
stopping when the key is lifted or a different key is pressed.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _scrollByContentOffset:animated:]):
(-[WKWebView _scrollByContentOffset:]): Deleted.
* UIProcess/API/Cocoa/WKWebViewInternal.h:
Add animated parameter to scrollByContentOffset, and plumb it through to UIScrollView.

* UIProcess/ios/WKContentViewInteraction.h:
Add a WKKeyboardScrollingAnimator member.
Conform to WKKeyboardScrollable.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
Install the WKKeyboardScrollingAnimator.

(-[WKContentView cleanupInteraction]):
Uninstall the WKKeyboardScrollingAnimator.

(-[WKContentView unscaledView]):
Fix a stupid style nit.

(-[WKContentView handleKeyWebEvent:]):
Give WKKeyboardScrollingAnimator the first shot at incoming keyboard events.
It will only consume events here if it's already performing a scrolling animation
(because otherwise they should go straight through to the page).

(-[WKContentView _interpretKeyEvent:isCharEvent:]):
Give WKKeyboardScrollingAnimator a shot at handling keyboard events that
the web content did not handle. We will only start a scrolling animation
if the page did not handle an event that would start a scroll.

(-[WKContentView isKeyboardScrollable]):
Part of WKKeyboardScrollable; only report ourselves as scrollable if
we would previously have allowed scrolling from keyboard events (if
we're not in contenteditable, and don't have a <select> focused).

(-[WKContentView distanceForScrollingIncrement:]):
Part of WKKeyboardScrollable; compute the distance for each scrolling increment.

(-[WKContentView scrollByContentOffset:animated:]):
Part of WKKeyboardScrollable; plumb scrolls up to WKWebView.

(-[WKContentView _scrollOffsetForEvent:]): Moved to WKKeyboardScrollingAnimator.mm.

* UIProcess/ios/WKKeyboardScrollingAnimator.h: Added.
* UIProcess/ios/WKKeyboardScrollingAnimator.mm: Added.
(-[WKKeyboardScrollingAnimator init]):
(-[WKKeyboardScrollingAnimator initWithScrollable:]):
(-[WKKeyboardScrollingAnimator invalidate]):
(-[WKKeyboardScrollingAnimator _scrollOffsetForEvent:]):
Compute the scroll offset given a particular event. This is moved from WKContentView;
otherwise the primary change is that it now asks the WKKeyboardScrollable
for the distance instead of computing it directly.

(-[WKKeyboardScrollingAnimator beginWithEvent:]):
If we're currently in the initial state (WaitingForFirstEvent), and
a given event should start a scroll, transition into WaitingForRepeat,
and do a single animated scroll of the appropriate distance.

(-[WKKeyboardScrollingAnimator handleKeyEvent:]):
If this key event should terminate a scroll (because it is either a keyup
or a non-scrolling keydown), shut down any running animations.

If this is the first key repeat after the initial scroll, start a scrolling
animation.

Eat the event if it either started or continued a scroll.

(-[WKKeyboardScrollingAnimator startAnimatedScroll]):
(-[WKKeyboardScrollingAnimator stopAnimatedScroll]):
Helpers to start and stop the display link and do some bookkeeping.

(-[WKKeyboardScrollingAnimator displayLinkFired:]):
Ask the WKKeyboardScrollable to scroll the content based on the frame time,
an acceleration curve, and the current animation's scrolling increment.

* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoMake sure cookies get flushed to disk before exiting or suspending the network process
cdumez@apple.com [Wed, 1 Aug 2018 23:45:44 +0000 (23:45 +0000)]
Make sure cookies get flushed to disk before exiting or suspending the network process
https://bugs.webkit.org/show_bug.cgi?id=188241
<rdar://problem/42831831>

Reviewed by Alex Christensen and Geoffrey Garen.

Make sure cookies get flushed to disk before exiting or suspending the network process,
to make sure they do not get lost.

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::didClose):
(WebKit::NetworkProcess::actualPrepareToSuspend):
(WebKit::NetworkProcess::platformSyncAllCookies):
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::syncAllCookies):
(WebKit::NetworkProcess::platformSyncAllCookies):
* Shared/ChildProcess.cpp:
(WebKit::ChildProcess::didClose):
(WebKit::callExitNow):
(WebKit::callExitSoon):
(WebKit::ChildProcess::initialize):
(WebKit::didCloseOnConnectionWorkQueue): Deleted.
* Shared/ChildProcess.h:
(WebKit::ChildProcess::shouldCallExitWhenConnectionIsClosed const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoREGRESSION(r227983): fast/dom/adopt-node-crash-2.html is flaky
rniwa@webkit.org [Wed, 1 Aug 2018 23:26:02 +0000 (23:26 +0000)]
REGRESSION(r227983): fast/dom/adopt-node-crash-2.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=182589

Rebaseline the test and remove the flaky test expectation.

* fast/dom/adopt-node-crash-2-expected.txt:
* platform/ios-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoMove all calls to ResourceLoader::start to WebKitLegacy
achristensen@apple.com [Wed, 1 Aug 2018 22:08:51 +0000 (22:08 +0000)]
Move all calls to ResourceLoader::start to WebKitLegacy
https://bugs.webkit.org/show_bug.cgi?id=184946

Reviewed by Andy Estes.

Source/WebCore:

This is in preparation for moving ResourceLoader::start to WebKitLegacy along with all ResourceHandle code.
I move the code that moves m_deferredRequest into m_request into WebKitLegacy, which won't change behavior for
modern WebKit because modern WebKit never calls ResourceLoader::start, the only place where m_deferredRequest
is ever set.  This won't change behavior for WebKitLegacy because the same operations happen in the same order.

* loader/LoaderStrategy.h:
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::setDefersLoading):
* loader/ResourceLoader.h:
(WebCore::ResourceLoader::setRequest):
(WebCore::ResourceLoader::deferredRequest const):
(WebCore::ResourceLoader::takeDeferredRequest):

Source/WebKit:

* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::setDefersLoading):
* WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

* WebCoreSupport/WebResourceLoadScheduler.cpp:
(WebResourceLoadScheduler::setDefersLoading):
* WebCoreSupport/WebResourceLoadScheduler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoAX: AOM: Add ARIA IDL Attribute Reflection
n_wang@apple.com [Wed, 1 Aug 2018 22:07:42 +0000 (22:07 +0000)]
AX: AOM: Add ARIA IDL Attribute Reflection
https://bugs.webkit.org/show_bug.cgi?id=184676
<rdar://problem/39476882>

Source/WebCore:

Reviewed by Chris Fleizach.

Test: accessibility/ARIA-reflection.html

* CMakeLists.txt:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AccessibilityRole.idl: Added.
* accessibility/AriaAttributes.idl: Added.
* dom/Element.idl:
* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setAriaReflectionEnabled):
(WebCore::RuntimeEnabledFeatures::ariaReflectionEnabled const):

Source/WebKit:

Added ARIA property string reflection on Element, behind
a new runtime flag.
Spec: https://w3c.github.io/aria/#idl-interface

Reviewed by Chris Fleizach.

* Shared/WebPreferences.yaml:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetAriaReflectionEnabled):
(WKPreferencesGetAriaReflectionEnabled):
* UIProcess/API/C/WKPreferencesRefPrivate.h:

Source/WebKitLegacy/mac:

Reviewed by Chris Fleizach.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences ariaReflectionEnabled]):
(-[WebPreferences setAriaReflectionEnabled:]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Tools:

Reviewed by Chris Fleizach.

* DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):

LayoutTests:

Reviewed by Chris Fleizach.

* accessibility/ARIA-reflection-expected.txt: Added.
* accessibility/ARIA-reflection.html: Added.
* js/dom/dom-static-property-for-in-iteration.html:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[LFC][Floating] Revert back to only one list for the all the floatings.
zalan@apple.com [Wed, 1 Aug 2018 21:46:52 +0000 (21:46 +0000)]
[LFC][Floating] Revert back to only one list for the all the floatings.
https://bugs.webkit.org/show_bug.cgi?id=188232

Reviewed by Antti Koivisto.

If the combined floating list turns out to be a performance bottleneck, we can still split it into left and right. However at this point
having 2 dedicated lists just makes the implementation more complicated.

* layout/FloatingContext.cpp:
(WebCore::Layout::begin):
(WebCore::Layout::end):
(WebCore::Layout::FloatingPair::FloatingPair):
(WebCore::Layout::FloatingPair::left const):
(WebCore::Layout::FloatingPair::right const):
(WebCore::Layout::Iterator::Iterator):
(WebCore::Layout::previousFloatingIndex):
(WebCore::Layout::Iterator::operator++):
(WebCore::Layout::Iterator::set):
(WebCore::Layout::floatingDisplayBox): Deleted.
* layout/FloatingState.cpp:
(WebCore::Layout::FloatingState::remove):
(WebCore::Layout::FloatingState::append):
* layout/FloatingState.h:
(WebCore::Layout::FloatingState::isEmpty const):
(WebCore::Layout::FloatingState::floatings const):
(WebCore::Layout::FloatingState::last const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[Curl] Change synchronous request logic using MessageQueue to match with Mac port.
Basuke.Suzuki@sony.com [Wed, 1 Aug 2018 21:36:48 +0000 (21:36 +0000)]
[Curl] Change synchronous request logic using MessageQueue to match with Mac port.
https://bugs.webkit.org/show_bug.cgi?id=188206

Reviewed by Alex Christensen.

Port synchronous request logic from ResourceHandleMac to use MessageQueue for
client callback invocation. This makes simplify the logic of CurlRequest because
now every requests are handled in Curl thread and there's no difference between
sync and async requests.

Test: Covered by these tests:
- http\tests\xmlhttprequest\simple-sync.html
- http\tests\xmlhttprequest\xmlhttprequest-unsafe-redirect.html

* platform/network/ResourceHandleInternal.h:
* platform/network/curl/CurlRequest.cpp: Remove synchronous request logics.
(WebCore::CurlRequest::CurlRequest):
(WebCore::CurlRequest::invalidateClient):
(WebCore::CurlRequest::start):
(WebCore::CurlRequest::cancel):
(WebCore::CurlRequest::runOnMainThread): Added message queue handling.
(WebCore::CurlRequest::runOnWorkerThreadIfRequired):
(WebCore::CurlRequest::didReceiveData):
(WebCore::CurlRequest::invokeDidReceiveResponseForFile):
(WebCore::CurlRequest::completeDidReceiveResponse):
(WebCore::CurlRequest::updateHandlePauseState):
(WebCore::CurlRequest::isHandlePaused const):
* platform/network/curl/CurlRequest.h:
(WebCore::CurlRequest::create):
(WebCore::CurlRequest::resourceRequest const):
* platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::createCurlRequest):
(WebCore::ResourceHandle::restartRequestWithCredential):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
(WebCore::ResourceHandle::platformContinueSynchronousDidReceiveResponse):
(WebCore::ResourceHandle::continueAfterDidReceiveResponse):
(WebCore::ResourceHandle::continueAfterWillSendRequest):
(WebCore::ResourceHandle::handleDataURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoLayout Test editing/selection/update-selection-by-style-change.html is flaky.
david_fenton@apple.com [Wed, 1 Aug 2018 21:33:41 +0000 (21:33 +0000)]
Layout Test editing/selection/update-selection-by-style-change.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=187649

Unreviewed test gardening, re-marked test as flaky.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[LFC][Floating] Use margin box consistently while placing a floating.
zalan@apple.com [Wed, 1 Aug 2018 21:31:11 +0000 (21:31 +0000)]
[LFC][Floating] Use margin box consistently while placing a floating.
https://bugs.webkit.org/show_bug.cgi?id=188222

Reviewed by Antti Koivisto.

The floating box fits when its margin box fits.

* layout/FloatingContext.cpp:
(WebCore::Layout::FloatingContext::computePosition const):
(WebCore::Layout::FloatingContext::floatingPosition const):
(WebCore::Layout::FloatingContext::initialVerticalPosition const):
(WebCore::Layout::FloatingContext::alignWithContainingBlock const):
(WebCore::Layout::FloatingContext::alignWithFloatings const):
(WebCore::Layout::FloatingPair::intersects const):
* layout/displaytree/DisplayBox.h:
(WebCore::Display::Box::rectWithMargin const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[INTL] Allow "unknown" formatToParts types
commit-queue@webkit.org [Wed, 1 Aug 2018 21:21:39 +0000 (21:21 +0000)]
[INTL] Allow "unknown" formatToParts types
https://bugs.webkit.org/show_bug.cgi?id=188176

Patch by Andy VanWagoner <andy@vanwagoner.family> on 2018-08-01
Reviewed by Darin Adler.

Originally extra unexpected field types were marked as "literal", since
the spec did not account for these. The ECMA 402 spec has since been updated
to specify "unknown" should be used in these cases.

Currently there is no known way to reach these cases, so no tests can
account for them. Theoretically they shoudn't exist, but they are specified,
just to be safe. Marking them as "unknown" instead of "literal" hopefully
will make such cases easy to identify if they ever happen.

* runtime/IntlDateTimeFormat.cpp:
(JSC::IntlDateTimeFormat::partTypeString):
* runtime/IntlNumberFormat.cpp:
(JSC::IntlNumberFormat::partTypeString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[LFC] Add FormattingContext::mapToAncestor geometry mapping function
zalan@apple.com [Wed, 1 Aug 2018 21:20:00 +0000 (21:20 +0000)]
[LFC] Add FormattingContext::mapToAncestor geometry mapping function
https://bugs.webkit.org/show_bug.cgi?id=188188

Reviewed by Antti Koivisto.

* layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::mapToAncestor):
* layout/FormattingContext.h:
* layout/displaytree/DisplayBox.cpp:
(WebCore::Display::Box::clone const):
* layout/displaytree/DisplayBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[INTL] Implement hourCycle in DateTimeFormat
commit-queue@webkit.org [Wed, 1 Aug 2018 21:19:27 +0000 (21:19 +0000)]
[INTL] Implement hourCycle in DateTimeFormat
https://bugs.webkit.org/show_bug.cgi?id=188006

Patch by Andy VanWagoner <andy@vanwagoner.family> on 2018-08-01
Reviewed by Darin Adler.

JSTests:

Removed fixed hourCycle expectations.

* test262/expectations.yaml:

Source/JavaScriptCore:

Implemented hourCycle, updating both the skeleton and the final pattern.
Changed resolveLocale to assume undefined options are not given and null
strings actually mean null, which removes the tag extension.

* runtime/CommonIdentifiers.h:
* runtime/IntlCollator.cpp:
(JSC::IntlCollator::initializeCollator):
* runtime/IntlDateTimeFormat.cpp:
(JSC::IntlDTFInternal::localeData):
(JSC::IntlDateTimeFormat::setFormatsFromPattern):
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::resolvedOptions):
* runtime/IntlDateTimeFormat.h:
* runtime/IntlObject.cpp:
(JSC::resolveLocale):

LayoutTests:

Added tests for hourCycle.

* js/intl-datetimeformat-expected.txt:
* js/script-tests/intl-datetimeformat.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[Curl] Bugfix on ResourceHandle::cancel()
Basuke.Suzuki@sony.com [Wed, 1 Aug 2018 21:16:45 +0000 (21:16 +0000)]
[Curl] Bugfix on ResourceHandle::cancel()
https://bugs.webkit.org/show_bug.cgi?id=188234

Reviewed by Darin Adler.
Trivial bug. The actual request was not cancelled correctly.

* platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::cancel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agonumber-toLocaleString.js test fails on ARM Linux buildbots
commit-queue@webkit.org [Wed, 1 Aug 2018 21:13:10 +0000 (21:13 +0000)]
number-toLocaleString.js test fails on ARM Linux buildbots
https://bugs.webkit.org/show_bug.cgi?id=154533

Patch by Andy VanWagoner <andy@vanwagoner.family> on 2018-08-01
Reviewed by Yusuke Suzuki.

Removed assumed default locale in Intl tests. The default is tested to
verify that it is a string, and a canonicalized language tag. All other
test cases explicitly use a locale when they expect a localized value.

* js/intl-collator-expected.txt:
* js/intl-datetimeformat-expected.txt:
* js/intl-default-locale-expected.txt:
* js/intl-default-locale.html:
* js/intl-numberformat-expected.txt:
* js/intl-pluralrules-expected.txt:
* js/script-tests/intl-collator.js:
* js/script-tests/intl-datetimeformat.js:
* js/script-tests/intl-numberformat.js:
* js/script-tests/intl-pluralrules.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[LFC][Floating] FloatingState should take the formatting root box.
zalan@apple.com [Wed, 1 Aug 2018 20:53:47 +0000 (20:53 +0000)]
[LFC][Floating] FloatingState should take the formatting root box.
https://bugs.webkit.org/show_bug.cgi?id=188214

Reviewed by Antti Koivisto.

This will be taken into use when FormattingContext takes all boxes in the coordinate system of the formatting root.

* layout/FloatingState.cpp:
(WebCore::Layout::FloatingState::FloatingState):
(WebCore::Layout::belongsToThisFloatingContext):
(WebCore::Layout::FloatingState::append):
* layout/FloatingState.h:
(WebCore::Layout::FloatingState::create):
* layout/LayoutContext.cpp:
(WebCore::Layout::LayoutContext::establishedFormattingState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[LFC][Floating] Align new floating with the bottom of the existing floatings.
zalan@apple.com [Wed, 1 Aug 2018 20:52:04 +0000 (20:52 +0000)]
[LFC][Floating] Align new floating with the bottom of the existing floatings.
https://bugs.webkit.org/show_bug.cgi?id=188213

Reviewed by Antti Koivisto.

When the incoming floating does not fit at all, align its top with the bottom of the existing floatings.

* layout/FloatingContext.cpp:
(WebCore::Layout::FloatingContext::floatingPosition const):
(WebCore::Layout::FloatingPair::bottom const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoAlways use MediaPlayback audio category when playing to AppleTV
eric.carlson@apple.com [Wed, 1 Aug 2018 20:48:58 +0000 (20:48 +0000)]
Always use MediaPlayback audio category when playing to AppleTV
https://bugs.webkit.org/show_bug.cgi?id=188230
<rdar://problem/42497809>

Reviewed by Jer Noble.

* platform/audio/cocoa/MediaSessionManagerCocoa.cpp:
(PlatformMediaSessionManager::updateSessionState): Check session.isPlayingToWirelessPlaybackTarget().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoJSArrayBuffer should have its own JSType
keith_miller@apple.com [Wed, 1 Aug 2018 20:33:48 +0000 (20:33 +0000)]
JSArrayBuffer should have its own JSType
https://bugs.webkit.org/show_bug.cgi?id=188231

Reviewed by Saam Barati.

* runtime/JSArrayBuffer.cpp:
(JSC::JSArrayBuffer::createStructure):
* runtime/JSCast.h:
* runtime/JSType.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoUse iPhone SE as the default simulated device
jbedard@apple.com [Wed, 1 Aug 2018 20:29:29 +0000 (20:29 +0000)]
Use iPhone SE as the default simulated device
https://bugs.webkit.org/show_bug.cgi?id=188227

Reviewed by Aakash Jain.

* Scripts/webkitpy/port/ios_simulator.py:
(IOSSimulatorPort):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoHardcode some system colors to avoid fingerprinting exposure.
timothy@apple.com [Wed, 1 Aug 2018 19:07:42 +0000 (19:07 +0000)]
Hardcode some system colors to avoid fingerprinting exposure.
https://bugs.webkit.org/show_bug.cgi?id=188203
rdar://problem/42781630

Reviewed by Tim Horton.

Source/WebCore:

Passes existing tests with the hardcoded blue system appearance.

* rendering/RenderTheme.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::systemColor const):
Adds special handling for some system colors. Fixes -apple-system-selected-text-background
to match the real selection color by using blendWithWhite().

LayoutTests:

* fast/css/apple-system-control-colors-expected.txt: Updated.
* fast/css/test-setting-canvas-color.html: Fixed for colors with alpha.
* platform/mac-highsierra/fast/css/apple-system-control-colors-expected.txt:
* platform/mac-sierra/fast/css/apple-system-control-colors-expected.txt: Updated.
* platform/mac/TestExpectations: Removed fast/css/test-setting-canvas-color.html.
* platform/mac/fast/css/apple-system-control-colors-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoWeb Inspector: Dark Mode: SourceCodeTextEditor thread indicator widget is too light
nvasilyev@apple.com [Wed, 1 Aug 2018 18:12:17 +0000 (18:12 +0000)]
Web Inspector: Dark Mode: SourceCodeTextEditor thread indicator widget is too light
https://bugs.webkit.org/show_bug.cgi?id=188119
<rdar://problem/42670811>

Reviewed by Matt Baker.

Make the background of the thread indicator widget darker.

Reduce the number of HTML elements and simplify CSS by removing the HTML element that drew an arrow and using clip-path on inline widgets instead.

* UserInterface/Views/DarkMode.css:
(@media (prefers-dark-interface)):
(.text-editor > .CodeMirror .execution-line):
(.text-editor > .CodeMirror .execution-range-highlight:not(.CodeMirror-selectedtext),):
* UserInterface/Views/SourceCodeTextEditor.css:
(.source-code.text-editor .CodeMirror-linewidget):
(.source-code.text-editor > .CodeMirror .line-indicator-widget.inline):
(@media (prefers-dark-interface)):
(.source-code.text-editor > .CodeMirror .thread-widget.inline):
* UserInterface/Views/SourceCodeTextEditor.js:
(WI.SourceCodeTextEditor.prototype._updateThreadIndicatorWidget):
(WI.SourceCodeTextEditor.prototype._updateIssueWidgetForIssues):
* UserInterface/Views/TextEditor.css:
(@media (prefers-dark-interface)):
(.text-editor > .CodeMirror .execution-line.primary .CodeMirror-linenumber::after):
* UserInterface/Views/Variables.css:
(:root):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoWeb Inspector: Dark Mode: disabled breakpoints banner is too light
nvasilyev@apple.com [Wed, 1 Aug 2018 18:09:38 +0000 (18:09 +0000)]
Web Inspector: Dark Mode: disabled breakpoints banner is too light
https://bugs.webkit.org/show_bug.cgi?id=188120
<rdar://problem/42671348>

Reviewed by Matt Baker.

* UserInterface/Views/DebuggerSidebarPanel.css:
(@media (prefers-dark-interface)):
(.sidebar > .panel.navigation.debugger .warning-banner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[iOS] Remove the delay before setting audio session category added in r233535
eric.carlson@apple.com [Wed, 1 Aug 2018 18:07:10 +0000 (18:07 +0000)]
[iOS] Remove the delay before setting audio session category added in r233535
https://bugs.webkit.org/show_bug.cgi?id=188225

Reviewed by Jer Noble.

* platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::beginInterruption): scheduleUpdateSessionState -> updateSessionState.
(WebCore::PlatformMediaSessionManager::addSession): Ditto.
(WebCore::PlatformMediaSessionManager::removeSession): Ditto.
(WebCore::PlatformMediaSessionManager::sessionStateChanged): Ditto.
(WebCore::PlatformMediaSessionManager::sessionCanProduceAudioChanged): Ditto.
(WebCore::PlatformMediaSessionManager::updateSessionState): Ditto.
(WebCore::PlatformMediaSessionManager::audioOutputDeviceChanged): Ditto.
(WebCore::PlatformMediaSessionManager::scheduleUpdateSessionState): Deleted.
* platform/audio/PlatformMediaSessionManager.h:

* platform/audio/cocoa/MediaSessionManagerCocoa.cpp:
(PlatformMediaSessionManager::updateSessionState):
(PlatformMediaSessionManager::scheduleUpdateSessionState): Deleted.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateClipRects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoAllow WebFramePolicyListenerProxy to be used multiple times
achristensen@apple.com [Wed, 1 Aug 2018 18:04:51 +0000 (18:04 +0000)]
Allow WebFramePolicyListenerProxy to be used multiple times
https://bugs.webkit.org/show_bug.cgi?id=188229

Reviewed by Chris Dumez.

This fixes a regression from r234210 in clients that misuse the API.

* UIProcess/WebFramePolicyListenerProxy.cpp:
(WebKit::WebFramePolicyListenerProxy::use):
(WebKit::WebFramePolicyListenerProxy::download):
(WebKit::WebFramePolicyListenerProxy::ignore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months ago[iOS] Color picker should have a border when presented in a popover
commit-queue@webkit.org [Wed, 1 Aug 2018 17:26:17 +0000 (17:26 +0000)]
[iOS] Color picker should have a border when presented in a popover
https://bugs.webkit.org/show_bug.cgi?id=188207

Patch by Aditya Keerthi <akeerthi@apple.com> on 2018-08-01
Reviewed by Wenson Hsieh.

The color picker should have a border when presented in a popover. This matches
the behavior of color pickers in other parts of iOS.

Since the popover will resize its view to fill its size, we first place the
color picker in a container view. The container view can then fill the popover,
while the smaller color picker is centered in it's container - creating the
appearance of a border.

* UIProcess/ios/forms/WKFormColorControl.mm:
(-[WKColorPopover initWithView:]):
* UIProcess/ios/forms/WKFormColorPicker.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoAdd TransformationMatrix::Identity
utatane.tea@gmail.com [Wed, 1 Aug 2018 16:01:00 +0000 (16:01 +0000)]
Add TransformationMatrix::Identity
https://bugs.webkit.org/show_bug.cgi?id=188204

Reviewed by Simon Fraser.

This patch adds TransformationMatrix::Identity, which is a static const variable holding an identity matrix.

No behavior change.

* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::transform const):
(WebCore::GraphicsLayer::childrenTransform const):
(): Deleted.
* platform/graphics/transforms/TransformationMatrix.cpp:
* platform/graphics/transforms/TransformationMatrix.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 months agoUnreviewed, rolling out r234443 and r234445.
commit-queue@webkit.org [Wed, 1 Aug 2018 15:47:59 +0000 (15:47 +0000)]
Unreviewed, rolling out r234443 and r234445.
https://bugs.webkit.org/show_bug.cgi?id=188224

Revision caused 3 api failures across all platforms.
(Requested by Truitt on #webkit).

Reverted changesets:

"Add configuration for automatic process pre-warming"
https://bugs.webkit.org/show_bug.cgi?id=187108
https://trac.webkit.org/changeset/234443

"Add configuration for automatic process pre-warming"
https://bugs.webkit.org/show_bug.cgi?id=187108
https://trac.webkit.org/changeset/234445

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234459 268f45cc-cd09-0410-ab3c-d52691b4dbfc