WebKit-https.git
9 years agoImplement flex-pack:distribute
ojan@chromium.org [Tue, 24 Jan 2012 06:26:54 +0000 (06:26 +0000)]
Implement flex-pack:distribute
https://bugs.webkit.org/show_bug.cgi?id=76864

Reviewed by Tony Chang.

Source/WebCore:

See http://dev.w3.org/csswg/css3-flexbox/#flex-pack.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexPack):
* css/CSSValueKeywords.in:
* rendering/RenderFlexibleBox.cpp:
(WebCore::initialPackingOffset):
(WebCore::packingSpaceBetweenChildren):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::layoutColumnReverse):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

* css3/flexbox/004-expected.txt:
* css3/flexbox/004.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement CSS clip property in CSSStyleApplyProperty.
macpherson@chromium.org [Tue, 24 Jan 2012 05:44:22 +0000 (05:44 +0000)]
Implement CSS clip property in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=74913

Reviewed by Andreas Kling.

No new tests / refactoring only.

* css/CSSPrimitiveValue.h:
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::convertToLength):
This new function aims to provide a single call for converting many CSSPrimitiveValue
values to Lengths. It is templated to allow the caller to specify which conversions
are appropriate depending on the context in which the value is used.
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyClip::applyInheritValue):
(WebCore::ApplyPropertyClip::applyInitialValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyClip::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agodecodeEscapeSequences() not correct for some encodings (GBK, Big5, ...).
tsepez@chromium.org [Tue, 24 Jan 2012 05:08:14 +0000 (05:08 +0000)]
decodeEscapeSequences() not correct for some encodings (GBK, Big5, ...).
https://bugs.webkit.org/show_bug.cgi?id=71316

Reviewed by Daniel Bates.

Source/WebCore:

Pass trailing unescaped bytes into the character set decoder to get correct
results in the presence of encodings which re-use ASCII values in sequences.

Tests: http/tests/navigation/anchor-frames-gbk.html
       http/tests/security/xssAuditor/iframe-onload-GBK-char.html
       http/tests/security/xssAuditor/img-onerror-GBK-char.html
       http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode.html
       http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode.html
       http/tests/security/xssAuditor/script-tag-Big5-char.html
       http/tests/security/xssAuditor/script-tag-Big5-char2.html

* platform/text/DecodeEscapeSequences.h:
(WebCore::Unicode16BitEscapeSequence::findInString):
(WebCore::Unicode16BitEscapeSequence::findEndOfRun):
(WebCore::Unicode16BitEscapeSequence::decodeRun):
(WebCore::URLEscapeSequence::findInString):
(WebCore::URLEscapeSequence::findEndOfRun):
(WebCore::URLEscapeSequence::decodeRun):
(WebCore::decodeEscapeSequences):

LayoutTests:

* http/tests/navigation/anchor-frames-gbk-expected.txt: Added.
* http/tests/navigation/anchor-frames-gbk.html: Added.
* http/tests/navigation/resources/frame-with-anchor-gbk.html: Added.
* http/tests/security/xssAuditor/iframe-onload-GBK-char-expected.txt: Added.
* http/tests/security/xssAuditor/iframe-onload-GBK-char.html: Added.
* http/tests/security/xssAuditor/img-onerror-GBK-char-expected.txt: Added.
* http/tests/security/xssAuditor/img-onerror-GBK-char.html: Added.
* http/tests/security/xssAuditor/resources/echo-intertag-decode-16bit-unicode.pl:
* http/tests/security/xssAuditor/script-tag-Big5-char-expected.txt: Added.
* http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode-expected.txt: Added.
* http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode.html: Added.
* http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-expected.txt: Added.
* http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode.html: Added.
* http/tests/security/xssAuditor/script-tag-Big5-char.html: Added.
* http/tests/security/xssAuditor/script-tag-Big5-char2-expected.txt: Added.
* http/tests/security/xssAuditor/script-tag-Big5-char2.html: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix a build break in a clean compile of the Chromium port (at least
abarth@webkit.org [Tue, 24 Jan 2012 05:04:53 +0000 (05:04 +0000)]
Fix a build break in a clean compile of the Chromium port (at least
reported by tbreisacher).

* css/CSSStyleDeclaration.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] QQuickWebView is initializing touch mode twice while being constructed
commit-queue@webkit.org [Tue, 24 Jan 2012 04:53:22 +0000 (04:53 +0000)]
[Qt][WK2] QQuickWebView is initializing touch mode twice while being constructed
https://bugs.webkit.org/show_bug.cgi?id=76859

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2012-01-23
Reviewed by Kenneth Rohde Christiansen.

Removing d->initializeTouch() from QQuickWebView::QQuickWebView()
since in QQuickWebViewPrivate::initialize() there is a call for
setUseTraditionalDesktopBehaviour(false), which will call initializeTouch.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::QQuickWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK][WK2] Make the LoadTracking and WebView test fixtures more flexible
mrobinson@webkit.org [Tue, 24 Jan 2012 04:40:30 +0000 (04:40 +0000)]
[GTK][WK2] Make the LoadTracking and WebView test fixtures more flexible
https://bugs.webkit.org/show_bug.cgi?id=76755

Reviewed by Alejandro G. Castro.

Always clear the loading events when loading new content in the load tracking
test. In the WebView test correctly handle loading HTML with a URL that isn't
"about:blank."

* UIProcess/API/gtk/tests/LoadTrackingTest.cpp:
(LoadTrackingTest::loadURI): Reset the class state when starting a new load.
(LoadTrackingTest::loadHtml): Ditto.
(LoadTrackingTest::loadPlainText): Ditto.
(LoadTrackingTest::loadRequest): Ditto.
* UIProcess/API/gtk/tests/LoadTrackingTest.h: Added new method definitions.
* UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:
(assertNormalLoadHappened): No longer clear loading events. The fixture handles that now.
(testLoadHtml): Update to reflect new method name.
(testLoadPlainText): Ditto.
(testLoadRequest): Ditto.
(testWebViewReload): Ditto.
* UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::loadHtml): Properly interpret the baseURL parameter.
* UIProcess/API/gtk/tests/WebViewTest.h: Make loading methods virtual.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Clean up old WebSharedWorker::startWorkerContext() method.
tsepez@chromium.org [Tue, 24 Jan 2012 04:38:29 +0000 (04:38 +0000)]
[chromium] Clean up old WebSharedWorker::startWorkerContext() method.
https://bugs.webkit.org/show_bug.cgi?id=76853

Reviewed by Darin Fisher.

* public/WebSharedWorker.h:
* src/WebSharedWorkerImpl.cpp:
* src/WebSharedWorkerImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] editing/deleting/5408255.html results are incorrect
commit-queue@webkit.org [Tue, 24 Jan 2012 04:23:41 +0000 (04:23 +0000)]
[GTK] editing/deleting/5408255.html results are incorrect
https://bugs.webkit.org/show_bug.cgi?id=53644

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-01-23
Reviewed by Martin Robinson.

Source/WebCore:

When the WEBKIT_TOP_LEVEL environment variable is set, resources
should be loaded from the source tree to which the variable is
pointing. This approach is used when performing testing on the
Gtk port.

No new tests, changes cause one test to pass.

* platform/graphics/gtk/ImageGtk.cpp:
(getPathToImageResource): Also make changes to the resource path
construction code on Windows.
(WebCore::Image::loadPlatformResource):

Tools:

WEBKIT_TOP_LEVEL environment variable is now set directly in either
WebKitTestRunner or DumpRenderTree through usage of a compilation-time
macro. This way both tools can be run outside the test harness without
the need to manually set the environment variable.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(getTopLevelPath):
* GNUmakefile.am:
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.setup_environ_for_server):
* WebKitTestRunner/GNUmakefile.am:
* WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
(WTR::InjectedBundle::platformInitialize):

LayoutTests:

Unskip newly-passing editing test.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in WebCore::RenderTableSection::rowLogicalHeightChanged
jchaffraix@webkit.org [Tue, 24 Jan 2012 04:15:06 +0000 (04:15 +0000)]
Crash in WebCore::RenderTableSection::rowLogicalHeightChanged
https://webkit.org/b/76842

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/table/crash-section-logical-height-changed-needsCellRecalc.html

The issue was that we would access our section's structure when it was dirty.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::rowLogicalHeightChanged):
Bail out if we need cells recalculation as our internal structure is not up-to-date
and we will recompute all the rows' heights as part of the recomputation anyway.

LayoutTests:

* fast/table/crash-section-logical-height-changed-needsCellRecalc-expected.txt: Added.
* fast/table/crash-section-logical-height-changed-needsCellRecalc.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebKit/chromium: [Chromium] Implement layoutTestController.workerThreadCount...
dslomov@google.com [Tue, 24 Jan 2012 04:07:56 +0000 (04:07 +0000)]
Source/WebKit/chromium: [Chromium] Implement layoutTestController.workerThreadCount in DRT
https://bugs.webkit.org/show_bug.cgi?id=74653.
Expose WebCore::WorkerThread::workerThreadCount() in API layer
for DumpRenderTree.

Reviewed by Darin Fisher.

* WebKit.gyp:
* public/WebWorkerInfo.h: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.
* src/WebWorkerInfo.cpp: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.
(WebKit::WebWorkerInfo::dedicatedWorkerCount):

Tools: [Chromium] Implement layoutTestController.workerThreadCount in DRT
https://bugs.webkit.org/show_bug.cgi?id=74653.

Reviewed by Darin Fisher.

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::workerThreadCount):
* DumpRenderTree/chromium/LayoutTestController.h:

LayoutTests: [Chromium] Implement layoutTestController.workerThreadCount in DRT
https://bugs.webkit.org/show_bug.cgi?id=74653.

Reviewed by Darin Fisher.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Refactoring] Make finish() of CodeGeneratorJS.pm empty
haraken@chromium.org [Tue, 24 Jan 2012 03:59:55 +0000 (03:59 +0000)]
[Refactoring] Make finish() of CodeGeneratorJS.pm empty
https://bugs.webkit.org/show_bug.cgi?id=76846

Reviewed by Adam Barth.

This is one of steps to stop rebuilding .h/.cpp files generated
by unchanged IDLs (bug 76836).

As a refactoring, we are planning to remove finish() from all
CodeGenerators. In this bug, we make finish() of CodeGeneratorJS.pm
empty.

No new tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(finish): Made it empty. We will remove finish() after
making finish() of all CodeGenerators empty.
(GenerateInterface): Modified to call WriteData().
(WriteData): Simple code refactoring.
Removed if(defined $IMPL).
Removed if(defined $HEADER).
Removed if(defined $DEPS).
$IMPL -> IMPL.
$HEADER -> HEADER.
$DEPS -> DEPS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r105676.
macpherson@chromium.org [Tue, 24 Jan 2012 03:55:17 +0000 (03:55 +0000)]
Unreviewed, rolling out r105676.
http://trac.webkit.org/changeset/105676
https://bugs.webkit.org/show_bug.cgi?id=76665

Breaks build on max due to compile warnings.

* runtime/JSObject.cpp:
(JSC::JSObject::finalize):
(JSC::JSObject::visitChildren):
(JSC::JSObject::allocatePropertyStorage):
* runtime/JSObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFine tune Web Intents Chromium API
commit-queue@webkit.org [Tue, 24 Jan 2012 03:20:08 +0000 (03:20 +0000)]
Fine tune Web Intents Chromium API
https://bugs.webkit.org/show_bug.cgi?id=76754

Patch by Greg Billock <gbillock@google.com> on 2012-01-23
Reviewed by Darin Fisher.

* public/WebIntent.h:
* public/WebIntentServiceInfo.h:
* src/WebIntent.cpp:
* src/WebIntentServiceInfo.cpp:
(WebKit::WebIntentServiceInfo::WebIntentServiceInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] updateRect is incorrect when contentBounds != bounds
shawnsingh@chromium.org [Tue, 24 Jan 2012 02:45:03 +0000 (02:45 +0000)]
[chromium] updateRect is incorrect when contentBounds != bounds
https://bugs.webkit.org/show_bug.cgi?id=72919

Reviewed by James Robinson.

Source/WebCore:

Unit test added to TiledLayerChromiumTest.cpp

The m_updateRect member in LayerChromium types is used to track
what was painted for that layer. For tiled layers (especially
image layers), the updateRect was being given with respect to the
size of the content, rather than the size of the layer. This patch
adds a conversion so that updateRect is always with respect to the
layer size, so that damage tracking will work correctly in those
cases.

* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateCompositorResources):

Source/WebKit/chromium:

* tests/TiledLayerChromiumTest.cpp:
(WTF::FakeTiledLayerWithScaledBounds::FakeTiledLayerWithScaledBounds):
(WTF::FakeTiledLayerWithScaledBounds::setContentBounds):
(WTF::FakeTiledLayerWithScaledBounds::contentBounds):
(WTF::FakeTiledLayerWithScaledBounds::updateRect):
(WTF::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Make "Copy as HTML" use the same copy functions as other copy methods.
commit-queue@webkit.org [Tue, 24 Jan 2012 02:39:00 +0000 (02:39 +0000)]
Web Inspector: Make "Copy as HTML" use the same copy functions as other copy methods.
https://bugs.webkit.org/show_bug.cgi?id=76706

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-01-23
Reviewed by Pavel Feldman.

Changed DOMAgent.copyNode to call getOuterHTML and use the callback function to
return the text to InspectorFrontendHost.copyText.  This will make all copy
functions use the same code path.

Not testable.

* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
* inspector/InspectorDOMAgent.h:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.copyNode.copy):
(WebInspector.DOMNode.prototype.copyNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake zoom multiplier float instead of double to match RenderStyle::effectiveZoom...
macpherson@chromium.org [Tue, 24 Jan 2012 02:36:19 +0000 (02:36 +0000)]
Make zoom multiplier float instead of double to match RenderStyle::effectiveZoom etc. and thus avoid unnecessary precision conversions.
https://bugs.webkit.org/show_bug.cgi?id=69490

Reviewed by Andreas Kling.

Covered by existing tests.

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLength):
Use float multiplier instead of double.
(WebCore::CSSPrimitiveValue::computeLengthDouble):
Use float multiplier instead of double.
* css/CSSPrimitiveValue.h:
Change type signatures of computeLength template prototype.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse copying collector for out-of-line JSObject property storage
mhahnenberg@apple.com [Tue, 24 Jan 2012 02:29:38 +0000 (02:29 +0000)]
Use copying collector for out-of-line JSObject property storage
https://bugs.webkit.org/show_bug.cgi?id=76665

Reviewed by Geoffrey Garen.

* runtime/JSObject.cpp:
(JSC::JSObject::visitChildren): Changed to use copyAndAppend whenever the property storage is out-of-line.
(JSC::JSObject::allocatePropertyStorage): Changed to use tryAllocateStorage/tryReallocateStorage as opposed to
operator new.
* runtime/JSObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium][WebSocket] Remove binary communication using WebData in WebKit API
toyoshim@chromium.org [Tue, 24 Jan 2012 02:18:55 +0000 (02:18 +0000)]
[Chromium][WebSocket] Remove binary communication using WebData in WebKit API
https://bugs.webkit.org/show_bug.cgi?id=76608

Reviewed by Darin Fisher.

* public/WebSocket.h: Remove BinaryTypeData definition and sendBinary(const WebData&).
* public/WebSocketClient.h: Remove didReceiveBinaryData(const WebData&).
* src/WebSocketImpl.cpp: Remove WebData related code and set default binary type as BinaryTypeBlob.
(WebKit::WebSocketImpl::WebSocketImpl): Remove sendBinary(const WebData&).
(WebKit::WebSocketImpl::didReceiveBinaryData): Remove WebData supporting code.
* src/WebSocketImpl.h: Remove sendBinary(const WebData&).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonrwt: make --chromium work like --qt
dpranke@chromium.org [Tue, 24 Jan 2012 02:09:36 +0000 (02:09 +0000)]
nrwt: make --chromium work like --qt
https://bugs.webkit.org/show_bug.cgi?id=76875

Reviewed by Adam Barth.

--chromium used to have to be handled differently from --qt
due to the way the PortFactory was implemented; there's not
really a good reason for that any more so this patch makes
things slightly more consistent and eliminates the
options.chromium flag (--chromium is now truly a synonym for
--platform chromium).

* Scripts/webkitpy/layout_tests/port/factory.py:
(PortFactory._default_port):
(PortFactory.get):
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
(FactoryTest.setUp):
(FactoryTest.test_chromium_mac):
(FactoryTest.test_chromium_linux):
(FactoryTest.test_chromium_win):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agorun-webkit-tests needs to propagate --chromium
dpranke@chromium.org [Tue, 24 Jan 2012 02:05:17 +0000 (02:05 +0000)]
run-webkit-tests needs to propagate --chromium
https://bugs.webkit.org/show_bug.cgi?id=76870

Reviewed by Eric Seidel.

run-webkit-tests removes '--chromium' argument from @ARGV when
determining which port to run, which means that that doesn't
propagate to new-run-webkit-tests. That's bad (and is handled
for the other ports by re-adding the flag, but apparently we're
just now noticing for Chromium).

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed test expectations fixes for a couple of window/frame tests.
eae@chromium.org [Tue, 24 Jan 2012 02:00:48 +0000 (02:00 +0000)]
Unreviewed test expectations fixes for a couple of window/frame tests.

* http/tests/security/cross-frame-access-put-expected.txt:
Updated expectations to reflect that window.frameElement now has the type
HTMLIFrameElement. The test itself has already been updated.

* platform/mac/fast/dom/Window/window-properties-expected.txt:
Added window.applicationCache.abort method.

* platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
Added DOMURL class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK][PATCH] More build silencing with (AM_V_...)
commit-queue@webkit.org [Tue, 24 Jan 2012 01:59:58 +0000 (01:59 +0000)]
[GTK][PATCH] More build silencing with (AM_V_...)
https://bugs.webkit.org/show_bug.cgi?id=76791

Patch by Priit Laes <plaes@plaes.org> on 2012-01-23
Reviewed by Gustavo Noronha Silva.

* GNUmakefile.am: Silence is golden...

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Implement SSL error handling QML API.
commit-queue@webkit.org [Tue, 24 Jan 2012 01:54:37 +0000 (01:54 +0000)]
[Qt] Implement SSL error handling QML API.
https://bugs.webkit.org/show_bug.cgi?id=76793

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-23
Reviewed by Simon Hausmann.

This patch implements support for accepting or rejecting invalid SSL
certificates from the QML API.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::handleCertificateVerificationRequest):
(QQuickWebViewExperimental::certificateVerificationDialog):
(QQuickWebViewExperimental::setCertificateVerificationDialog):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::certificateVerificationRequest):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/qt/QtDialogRunner.cpp:
(CertificateVerificationDialogContextObject::CertificateVerificationDialogContextObject):
(CertificateVerificationDialogContextObject::hostname):
(CertificateVerificationDialogContextObject::accept):
(CertificateVerificationDialogContextObject::reject):
(QtDialogRunner::initForCertificateVerification):
* UIProcess/qt/QtDialogRunner.h:
* UIProcess/qt/QtPageClient.cpp:
(QtPageClient::handleCertificateVerificationRequest):
* UIProcess/qt/QtPageClient.h:
* WebProcess/qt/QtNetworkAccessManager.cpp:
(WebKit::QtNetworkAccessManager::QtNetworkAccessManager):
(WebKit::QtNetworkAccessManager::onSslErrors):
* WebProcess/qt/QtNetworkAccessManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore build fixing after r105646.
bweinstein@apple.com [Tue, 24 Jan 2012 01:47:29 +0000 (01:47 +0000)]
More build fixing after r105646.

Source/JavaScriptCore:

* JavaScriptCore.exp:

Tools:

* TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
(TestWebKitAPI::TestNode::key):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMicroData: Remove ExceptionCode& from setAttribute() call.
commit-queue@webkit.org [Tue, 24 Jan 2012 01:36:56 +0000 (01:36 +0000)]
MicroData: Remove ExceptionCode& from setAttribute() call.
https://bugs.webkit.org/show_bug.cgi?id=76695

Patch by Arko Saha <nghq36@motorola.com> on 2012-01-23
Reviewed by Hajime Morita.

Changeset http://trac.webkit.org/changeset/103296 removed unused
ExceptionCode& argument from Element::setAttribute(QualifiedName).
Hence updating all calls to setAttribute() method in MicroData code.

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::setItemValueText):
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::setItemValueText):
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::setItemValueText):
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::setItemValueText):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::setItemValueText):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setItemValueText):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setItemValueText):
* html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::setItemValueText):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::setItemValueText):
* html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::setItemValueText):
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::setItemValueText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[windows] Convert usages of GetDC to HWndDC Part 2.
levin@chromium.org [Tue, 24 Jan 2012 01:31:05 +0000 (01:31 +0000)]
[windows] Convert usages of GetDC to HWndDC Part 2.
https://bugs.webkit.org/show_bug.cgi?id=76750

Reviewed by Adam Roben.

Source/WebKit/win:

* FullscreenVideoController.cpp:
(createCompatibleDCForWindow): Moved out the code which creates a DC for a window
to keep the same scope for the DC lifetime.
(FullscreenVideoController::draw):  Switch to using OwnPtr<HDC>
since createCompatibleDCForWindow returns a PassOwnPtr.
* WebNodeHighlight.cpp:
(WebNodeHighlight::update):
  Cleaned up leaks from calling GetDC without release.
  Note that there is a potential leak of hdc that previously existed
  and still does in an early exit scenario. (This could be easily fixed
  by using OwnPtr<HDC> but I was trying to keep this patch focused.)
* WebView.cpp:
(WebView::scrollBackingStore): Typical conversion.
(WebView::updateBackingStore): Reduced the scope of windowDC to be
right where it is being used.
(WebView::performLayeredWindowUpdate): Typical conversion.
(WebView::paintIntoBackingStore): Ditto.

Source/WebKit2:

* Shared/win/ShareableBitmapWin.cpp:
(WebKit::ShareableBitmap::windowsContext): Fix incorrect usage of OwnPtr<HDC> which
would do a DeleteDC instead of a ReleaseDC.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix - r105646 broke this.
barraclough@apple.com [Tue, 24 Jan 2012 01:21:51 +0000 (01:21 +0000)]
Unreviewed build fix - r105646 broke this.

* TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
(TestWebKitAPI::TestNode::TestNode):
(TestWebKitAPI::TestNode::key):
(TestWebKitAPI::RedBlackTreeTest::assertEqual):
(TestWebKitAPI::RedBlackTreeTest::assertSameValuesForKey):
(TestWebKitAPI::RedBlackTreeTest::testDriver):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix crash when a focused node is removed while in processing focusin event.
hayato@chromium.org [Tue, 24 Jan 2012 01:21:42 +0000 (01:21 +0000)]
Fix crash when a focused node is removed while in processing focusin event.
https://bugs.webkit.org/show_bug.cgi?id=76656

Reviewed by Dimitri Glazkov.

Source/WebCore:

Test: fast/events/focus-remove-focuesed-node.html

* dom/Document.cpp:
(WebCore::Document::setFocusedNode):

LayoutTests:

* fast/events/focus-remove-focuesed-node-expected.txt: Added.
* fast/events/focus-remove-focuesed-node.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSwitch media/audio-data-url.html layout test to base64-encoded WAV data.
scherkus@chromium.org [Tue, 24 Jan 2012 01:16:15 +0000 (01:16 +0000)]
Switch media/audio-data-url.html layout test to base64-encoded WAV data.
https://bugs.webkit.org/show_bug.cgi?id=76759

Reviewed by Eric Carlson.

* media/audio-data-url-expected.txt:
* media/audio-data-url.html:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r105658.
abarth@webkit.org [Tue, 24 Jan 2012 01:10:59 +0000 (01:10 +0000)]
Unreviewed, rolling out r105658.
http://trac.webkit.org/changeset/105658
https://bugs.webkit.org/show_bug.cgi?id=76883

We want this eventually, but not right at this moment
(Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-23

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add <(SHARED_INTERMEDIATE_DIR)/webkit to include path of targets that...
jamesr@google.com [Tue, 24 Jan 2012 01:09:29 +0000 (01:09 +0000)]
[chromium] Add <(SHARED_INTERMEDIATE_DIR)/webkit to include path of targets that depend on WebKit API so they pick up the copied headers in an onion build
https://bugs.webkit.org/show_bug.cgi?id=76879

Reviewed by Dirk Pranke.

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[windows] Convert usages of GetDC to HWndDC Part 1.
levin@chromium.org [Tue, 24 Jan 2012 01:07:41 +0000 (01:07 +0000)]
[windows] Convert usages of GetDC to HWndDC Part 1.
https://bugs.webkit.org/show_bug.cgi?id=76744

Reviewed by Adam Roben.

Source/WebCore:

No new functionality so no new tests.

* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::getFontDataForCharacters): Changed GetDC to HWndDC
and removed ReleaseDC.
(WebCore::createGDIFont): Ditto.
(WebCore::FontCache::getTraitsInFamily): Ditto.
* platform/graphics/win/FontPlatformDataWin.cpp:
(WebCore::FontPlatformData::FontPlatformData): Ditto.
* platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::SimpleFontData::platformInit): Ditto.
* platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::initGDIFont): Ditto.
(WebCore::SimpleFontData::containsCharacters): Ditto.
(WebCore::SimpleFontData::determinePitch): Ditto.
(WebCore::SimpleFontData::boundsForGDIGlyph): Ditto.
(WebCore::SimpleFontData::widthForGDIGlyph): Ditto.
(WebCore::SimpleFontData::scriptFontProperties): Ditto.
* platform/win/CursorWin.cpp:
(WebCore::createSharedCursor): Ditto.
* platform/win/DragImageCGWin.cpp:
(WebCore::scaleDragImage): Ditto.
(WebCore::createDragImageFromImage): Ditto.
* platform/win/DragImageWin.cpp:
(WebCore::createDragImageForLink): Ditto.
* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeImage): Ditto.

Source/WebKit/win:

* WebIconDatabase.cpp:
(createDIB): Changed GetDC to HWndDC and removed ReleaseDC.

Source/WebKit2:

* UIProcess/win/WebView.cpp:
(WebKit::WebView::flashBackingStoreUpdates): Typical conversion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Scrollbars do not respect the has-backward-stepper and has-forward-stepper...
commit-queue@webkit.org [Tue, 24 Jan 2012 00:54:05 +0000 (00:54 +0000)]
[GTK] Scrollbars do not respect the has-backward-stepper and has-forward-stepper properties
https://bugs.webkit.org/show_bug.cgi?id=76747

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-01-23
Reviewed by Gustavo Noronha Silva.

No new tests. Regressions are covered by existing tests, but testing
different GTK+ theme configurations is not possible yet.

* platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::backButtonRect): If there is no back stepper, return an empty rect.
(WebCore::ScrollbarThemeGtk::forwardButtonRect): If there is no forward stepper, return an empty rect.
(WebCore::ScrollbarThemeGtk::trackRect): Adjust track rect calculation to account for when there is
no steppers.
* platform/gtk/ScrollbarThemeGtk.h: New members describing whether there are primary steppers.
* platform/gtk/ScrollbarThemeGtk2.cpp:
(WebCore::ScrollbarThemeGtk::updateThemeProperties): Look at the theme to determine if there
are primary foward and back steppers.
* platform/gtk/ScrollbarThemeGtk3.cpp:
(WebCore::ScrollbarThemeGtk::updateThemeProperties): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r105396): drag state is not cleared after each drag
rniwa@webkit.org [Tue, 24 Jan 2012 00:47:28 +0000 (00:47 +0000)]
REGRESSION(r105396): drag state is not cleared after each drag
https://bugs.webkit.org/show_bug.cgi?id=76878

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Revert a part of r105396 that made performDragAndDrop not call clearDragState
when the default action was not prevented since it caused a regression.

I'm pretty certain always calling clearDragState in performDragAndDrop is wrong
but I can't think of a test case where this becomes a problem at the moment.
Since this area is not well tested, revert the change instead of making further
changes to the code base.

Tests: fast/events/clear-drag-state.html
       fast/events/clear-edit-drag-state.html

* page/EventHandler.cpp:
(WebCore::EventHandler::performDragAndDrop):

LayoutTests:

Add a regression test to ensure we don't fire extra dragenter event
on the second drag at an element that contains the dragged content.

* fast/events/clear-drag-state-expected.txt: Added.
* fast/events/clear-drag-state.html: Added.
* fast/events/clear-edit-drag-state-expected.txt: Added.
* fast/events/clear-edit-drag-state.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogarden-o-matic should support Chromium Mac Lion
abarth@webkit.org [Tue, 24 Jan 2012 00:41:01 +0000 (00:41 +0000)]
garden-o-matic should support Chromium Mac Lion
https://bugs.webkit.org/show_bug.cgi?id=76880

Reviewed by Eric Seidel.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixed typo in exception messages
commit-queue@webkit.org [Tue, 24 Jan 2012 00:40:11 +0000 (00:40 +0000)]
Fixed typo in exception messages
https://bugs.webkit.org/show_bug.cgi?id=76710

Patch by Thiago Marcos P. Santos <tmpsantos@gmail.com> on 2012-01-23
Reviewed by Alexey Proskuryakov.

* dom/DOMCoreException.cpp:
* fileapi/FileException.cpp:
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::postflightAndCommit):
* xml/XMLHttpRequestException.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAllow delayed DC allocation in HWndDC.
levin@chromium.org [Tue, 24 Jan 2012 00:35:29 +0000 (00:35 +0000)]
Allow delayed DC allocation in HWndDC.
https://bugs.webkit.org/show_bug.cgi?id=76737

Reviewed by Adam Roben.

No new functionality exposed so no new tests.

* platform/win/HWndDC.h: Changed this slightly to allow
for allocating a window DC after the initial creation since
this pattern occurrs in several places so this makes it easy to
replace them in an upcoming change.
(WebCore::HWndDC::HWndDC):
(WebCore::HWndDC::~HWndDC):
(WebCore::HWndDC::setHWnd):
(WebCore::HWndDC::clear):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMicroData: Compilation error while building Webkit with --microdata.
commit-queue@webkit.org [Tue, 24 Jan 2012 00:26:40 +0000 (00:26 +0000)]
MicroData: Compilation error while building Webkit with --microdata.
https://bugs.webkit.org/show_bug.cgi?id=76703

Patch by Arko Saha <nghq36@motorola.com> on 2012-01-23
Reviewed by Hajime Morita.

* dom/MicroDataItemList.cpp:
(WebCore::MicroDataItemList::MicroDataItemList):
(WebCore::MicroDataItemList::~MicroDataItemList):
* dom/MicroDataItemList.h:
* dom/NodeRareData.h:
(WebCore::NodeRareData::properties):
* html/HTMLPropertiesCollection.cpp:
(WebCore::HTMLPropertiesCollection::create):
(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
* html/HTMLPropertiesCollection.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Convert uses of GetDC to HWndDC.
levin@chromium.org [Tue, 24 Jan 2012 00:22:38 +0000 (00:22 +0000)]
[chromium] Convert uses of GetDC to HWndDC.
https://bugs.webkit.org/show_bug.cgi?id=76290

Reviewed by Dmitry Titov.

* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::createFontIndirectAndGetWinName):
(WebCore::fontContainsCharacter):
(WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::getTraitsInFamily):
* platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
(WebCore::FontPlatformData::scriptFontProperties):
* platform/graphics/chromium/FontUtilsChromiumWin.cpp:
(WebCore::FontMap::getAscent):
(WebCore::FontMap::getSpaceGlyph):
* platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
(WebCore::fillBMPGlyphs):
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::platformWidthForGlyph):
* platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::EnsureCachedDCCreated):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore::systemFontSize):
(WebCore::pointsToPixels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebsite: Reword WEBKITOUTPUTDIR documentation on Building WebKit page
commit-queue@webkit.org [Tue, 24 Jan 2012 00:13:19 +0000 (00:13 +0000)]
website: Reword WEBKITOUTPUTDIR documentation on Building WebKit page
https://bugs.webkit.org/show_bug.cgi?id=76544

Patch by Seo Sanghyeon <sh4.seo@samsung.com> on 2012-01-23
Reviewed by Darin Adler.

WEBKITOUTPUTDIR is not only for Windows.

* building/build.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocheck-webkit-style whitespace/operators triggers on overloaded division operator
eae@chromium.org [Tue, 24 Jan 2012 00:01:23 +0000 (00:01 +0000)]
check-webkit-style whitespace/operators triggers on overloaded division operator
https://bugs.webkit.org/show_bug.cgi?id=76650

Reviewed by Darin Adler.

* Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_operator_methods):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReduce throttling on video-buffering-repaints-controls test to prevent timeout.
commit-queue@webkit.org [Tue, 24 Jan 2012 00:00:55 +0000 (00:00 +0000)]
Reduce throttling on video-buffering-repaints-controls test to prevent timeout.
https://bugs.webkit.org/show_bug.cgi?id=76113

Also reduces flakiness by checking for a repaint between progress and
suspend events versus just between progress events.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-23
Reviewed by Adam Barth.

* http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
* http/tests/media/video-buffering-repaints-controls.html:
* platform/chromium-linux/http/tests/media/video-buffering-repaints-controls-expected.png:
* platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
* platform/chromium-win/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
* platform/gtk/http/tests/media/video-buffering-repaints-controls-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agorun-perf-tests should report server-side errors
rniwa@webkit.org [Mon, 23 Jan 2012 23:49:00 +0000 (23:49 +0000)]
run-perf-tests should report server-side errors
https://bugs.webkit.org/show_bug.cgi?id=76802

Reviewed by Tony Chang.

Report errors whenever server's response doesn't match "OK".

* Scripts/webkitpy/common/net/file_uploader.py:
(FileUploader.upload_single_text_file):
(FileUploader.upload_as_multipart_form_data):
(FileUploader._upload_data.callback):
(FileUploader):
(FileUploader._upload_data):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._upload_json):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_upload_json):
(test_upload_json.MockFileUploader.upload_single_text_file):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=75799
commit-queue@webkit.org [Mon, 23 Jan 2012 23:46:15 +0000 (23:46 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=75799
Calling intersectsNode on a detached range should throw.

Source/WebCore:

INVALID_STATE_ERR exception should be thrown if intersectsNode is called on a detached Range.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-23
Reviewed by Darin Adler.

Test: fast/dom/Range/range-intersectsNode-exception.html

* dom/Range.cpp:
(WebCore::Range::intersectsNode): Throwing INVALID_STATE_ERR exception if the range is detached.

LayoutTests:

Added test case to verify the exception thrown while calling intersectsNode on a detached range.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-23
Reviewed by Darin Adler.

* fast/dom/Range/range-intersectsNode-exception-expected.txt: Added.
* fast/dom/Range/range-intersectsNode-exception.html: Added.
* fast/dom/Range/range-intersectsNode-expected.txt:
* fast/dom/Range/resources/intersectsNode.js:  Modified the test case to catch the exception.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConvert DataTransferItem/DataTransferItemList back into an interface class
dcheng@chromium.org [Mon, 23 Jan 2012 23:35:44 +0000 (23:35 +0000)]
Convert DataTransferItem/DataTransferItemList back into an interface class
https://bugs.webkit.org/show_bug.cgi?id=76856

When Qt implemented the DataTransferItemList, a lot of logic was moved into the shared
classes since Chromium/Qt happened to implement it the same way. Now that I want to do some
refactoring/cleanup work to better implement DataTransferItemList in Chromium, we won't
share the same data anymore so it doesn't make sense to keep that code in a common location.

Reviewed by David Levin.

Covered by existing tests.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DataTransferItem.cpp:
* dom/DataTransferItem.h:
* dom/DataTransferItemList.cpp: Removed.
* dom/DataTransferItemList.h:
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::mayUpdateItems):
* platform/chromium/DataTransferItemChromium.cpp:
(WebCore::DataTransferItemChromium::create):
(WebCore::DataTransferItemChromium::DataTransferItemChromium):
(WebCore::DataTransferItemChromium::getAsString):
(WebCore::DataTransferItemChromium::getAsFile):
(WebCore::DataTransferItemChromium::clipboardChromium):
* platform/chromium/DataTransferItemChromium.h:
(WebCore::DataTransferItemChromium::kind):
(WebCore::DataTransferItemChromium::type):
* platform/chromium/DataTransferItemListChromium.cpp:
(WebCore::DataTransferItemListChromium::DataTransferItemListChromium):
* platform/chromium/DataTransferItemListChromium.h:
* platform/qt/DataTransferItemListQt.cpp:
(WebCore::DataTransferItemListQt::DataTransferItemListQt):
(WebCore::DataTransferItemListQt::length):
(WebCore::DataTransferItemListQt::item):
(WebCore::DataTransferItemListQt::deleteItem):
(WebCore::DataTransferItemListQt::clear):
(WebCore::DataTransferItemListQt::add):
* platform/qt/DataTransferItemListQt.h:
* platform/qt/DataTransferItemQt.cpp:
(WebCore::DataTransferItemQt::create):
(WebCore::DataTransferItemQt::DataTransferItemQt):
(WebCore::DataTransferItemQt::getAsString):
(WebCore::DataTransferItemQt::getAsFile):
* platform/qt/DataTransferItemQt.h:
(WebCore::DataTransferItemQt::kind):
(WebCore::DataTransferItemQt::type):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogetComputedStyle margin percentage test for CSS calc
mikelawther@chromium.org [Mon, 23 Jan 2012 23:32:40 +0000 (23:32 +0000)]
getComputedStyle margin percentage test for CSS calc
https://bugs.webkit.org/show_bug.cgi?id=76130

Reviewed by Darin Adler.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

* css3/calc/getComputedStyle-margin-percentage-expected.txt: Added.
* css3/calc/getComputedStyle-margin-percentage.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=76855
barraclough@apple.com [Mon, 23 Jan 2012 23:30:57 +0000 (23:30 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=76855
Implement a JIT-code aware sampling profiler for JSC

Reviewed by Geoff Garen.

Step 2: generalize RedBlackTree. The profiler is going to want tio use
a RedBlackTree, allow this class to work with subclasses of
RedBlackTree::Node, Node should not need to know the names of the m_key
and m_value fields (the subclass can provide a key() accessor), and
RedBlackTree does not need to know anything about ValueType.

* JavaScriptCore.exp:
* wtf/MetaAllocator.cpp:
(WTF::MetaAllocator::findAndRemoveFreeSpace):
(WTF::MetaAllocator::debugFreeSpaceSize):
(WTF::MetaAllocator::addFreeSpace):
* wtf/MetaAllocator.h:
(WTF::MetaAllocator::FreeSpaceNode::FreeSpaceNode):
(WTF::MetaAllocator::FreeSpaceNode::key):
* wtf/MetaAllocatorHandle.h:
(WTF::MetaAllocatorHandle::key):
* wtf/RedBlackTree.h:
(WTF::RedBlackTree::Node::successor):
(WTF::RedBlackTree::Node::predecessor):
(WTF::RedBlackTree::Node::parent):
(WTF::RedBlackTree::Node::setParent):
(WTF::RedBlackTree::Node::left):
(WTF::RedBlackTree::Node::setLeft):
(WTF::RedBlackTree::Node::right):
(WTF::RedBlackTree::Node::setRight):
(WTF::RedBlackTree::insert):
(WTF::RedBlackTree::remove):
(WTF::RedBlackTree::findExact):
(WTF::RedBlackTree::findLeastGreaterThanOrEqual):
(WTF::RedBlackTree::findGreatestLessThanOrEqual):
(WTF::RedBlackTree::first):
(WTF::RedBlackTree::last):
(WTF::RedBlackTree::size):
(WTF::RedBlackTree::treeMinimum):
(WTF::RedBlackTree::treeMaximum):
(WTF::RedBlackTree::treeInsert):
(WTF::RedBlackTree::leftRotate):
(WTF::RedBlackTree::rightRotate):
(WTF::RedBlackTree::removeFixup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed buildfix for ENABLE(MUTATION_OBSERVERS) following r105642.
kling@webkit.org [Mon, 23 Jan 2012 23:01:20 +0000 (23:01 +0000)]
Unreviewed buildfix for ENABLE(MUTATION_OBSERVERS) following r105642.

* css/CSSMutableStyleDeclaration.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agorun-perf-tests ignore Skipped list on chromium
rniwa@webkit.org [Mon, 23 Jan 2012 22:42:09 +0000 (22:42 +0000)]
run-perf-tests ignore Skipped list on chromium
https://bugs.webkit.org/show_bug.cgi?id=76764

Reviewed by Dirk Pranke.

Move skipped_perf_tests from WebKit port to Base port so that Chromium port
can also find skipped list. Chromium port only uses test_expectations.txt for
layout tests but performacne tests don't use test_expectations.txt so Chromium port
also needs to use Skipped list.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port._tests_from_skipped_file_contents):
(Port):
(Port._expectations_from_skipped_files):
(Port.skipped_perf_tests):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_skipped_perf_tests):
(PortTest.test_skipped_perf_tests.add_text_file):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._skipped_tests_for_unsupported_features):
(WebKitPort._skipped_file_search_paths):
(WebKitPort.skipped_layout_tests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate uniteIfNonZero to use isZero.
commit-queue@webkit.org [Mon, 23 Jan 2012 22:37:54 +0000 (22:37 +0000)]
Update uniteIfNonZero to use isZero.
https://bugs.webkit.org/show_bug.cgi?id=76637

Patch by Philip Rogers <pdr@google.com> on 2012-01-23
Reviewed by Darin Adler.

No new tests. (I found no existing codepath that would be affected by
this change but I think this change is still valuable in preventing
future bugs.)

* platform/graphics/FloatRect.cpp:
(WebCore::FloatRect::uniteIfNonZero):

The following change is a minor followup to
https://bugs.webkit.org/show_bug.cgi?id=76177#c12 and is not directly
related to the rest of this patch.
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::computeContainerBoundingBoxes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEliminate CSSElementStyleDeclaration
antti@apple.com [Mon, 23 Jan 2012 22:26:21 +0000 (22:26 +0000)]
Eliminate CSSElementStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=76848

Reviewed by Andreas Kling.

CSSElementStyleDeclaration has little functionality. It can merge with CSSMutableStyleDeclaration simplifying the code.

Having an element parent is mutually exclusive with having a css rule parent. We can keep them in a union. This also
shrinks all inline style declarations by one pointer.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMBinding.h:
(WebCore::root):
* css/CSSAllInOne.cpp:
* css/CSSElementStyleDeclaration.cpp: Removed.
* css/CSSElementStyleDeclaration.h: Removed.
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
* css/CSSMutableStyleDeclaration.h:
(WebCore::CSSMutableStyleDeclaration::createInline):
(WebCore::CSSMutableStyleDeclaration::createForSVGFontFaceElement):
(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
* css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):
(WebCore::CSSStyleDeclaration::parentStyleSheet):

    Merge the CSSElementStyleDeclaration::styleSheet() logic here.

* css/CSSStyleDeclaration.h:
(WebCore::CSSStyleDeclaration::parentRule):
(WebCore::CSSStyleDeclaration::clearParentRule):
(WebCore::CSSStyleDeclaration::parentElement):
(WebCore::CSSStyleDeclaration::clearParentElement):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):

    CSSStyleRule's style declaration can't have isElementStyleDeclaration set, the dead code can be removed.
    This is asserted in setDeclaration() and again implicitly in the destructor (by clearParentRule()).

* dom/StyledElement.cpp:
(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::destroyInlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::copyNonAttributeProperties):
* dom/StyledElement.h:
(WebCore::StyledElement::inlineStyleDecl):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
* editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI):
* html/ValidationMessage.cpp:
(WebCore::adjustBubblePosition):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlPanelElement::makeOpaque):
(WebCore::MediaControlPanelElement::makeTransparent):
* html/shadow/SliderThumbElement.cpp:
(WebCore::TrackLimiterElement::create):
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::SVGFontFaceElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r105640.
senorblanco@chromium.org [Mon, 23 Jan 2012 22:07:16 +0000 (22:07 +0000)]
Unreviewed, rolling out r105640.
http://trac.webkit.org/changeset/105640
https://bugs.webkit.org/show_bug.cgi?id=76849

Broke the chromium build.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agorolling chromium DEPS to r118713
senorblanco@chromium.org [Mon, 23 Jan 2012 21:41:51 +0000 (21:41 +0000)]
rolling chromium DEPS to r118713
https://bugs.webkit.org/show_bug.cgi?id=76849

Patch by Justin Novosad <junov@chromium.org> on 2012-01-23
Reviewed by Stephen White.

This is to pick up a change to skia build configuration

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the build after r105635.
aestes@apple.com [Mon, 23 Jan 2012 21:39:55 +0000 (21:39 +0000)]
Fix the build after r105635.

Source/JavaScriptCore:

* JavaScriptCore.exp:

Tools:

* TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove StackBounds from JSGlobalData
mhahnenberg@apple.com [Mon, 23 Jan 2012 21:36:18 +0000 (21:36 +0000)]
Remove StackBounds from JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=76310

Reviewed by Sam Weinig.

Removed StackBounds and the stack() function from JSGlobalData since it no
longer accessed any members of JSGlobalData.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* heap/MachineStackMarker.cpp:
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::gatherFromCurrentThread):
* parser/Parser.cpp:
(JSC::::Parser):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse OVERRIDE for PopupMenuClient's implementations
benjamin@webkit.org [Mon, 23 Jan 2012 21:35:24 +0000 (21:35 +0000)]
Use OVERRIDE for PopupMenuClient's implementations
https://bugs.webkit.org/show_bug.cgi?id=76774

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-23
Reviewed by Darin Adler.

* rendering/RenderMenuList.h: Also sort the methods to the same
order as PopupMenuClient.
* rendering/RenderTextControlSingleLine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement a JIT-code aware sampling profiler for JSC
barraclough@apple.com [Mon, 23 Jan 2012 21:08:34 +0000 (21:08 +0000)]
Implement a JIT-code aware sampling profiler for JSC
https://bugs.webkit.org/show_bug.cgi?id=76855

Rubber stanmped by Geoff Garen.

Mechanical change - pass CodeBlock through to the executable allocator,
such that we will be able to map ranges of JIT code back to their owner.

* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
* assembler/ARMAssembler.h:
* assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::executableCopy):
* assembler/AssemblerBufferWithConstantPool.h:
(JSC::AssemblerBufferWithConstantPool::executableCopy):
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::linkCode):
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::executableCopy):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::executableCopy):
* assembler/X86Assembler.h:
(JSC::X86Assembler::executableCopy):
(JSC::X86Assembler::X86InstructionFormatter::executableCopy):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGOSRExitCompiler.cpp:
* dfg/DFGRepatch.cpp:
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryCachePutByID):
* dfg/DFGThunks.cpp:
(JSC::DFG::osrExitGenerationThunkGenerator):
* jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::allocate):
* jit/ExecutableAllocator.h:
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::ExecutableAllocator::allocate):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITStubs.cpp:
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::finalize):
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBasic enhancements to StringBuilder
wangxianzhu@chromium.org [Mon, 23 Jan 2012 20:42:05 +0000 (20:42 +0000)]
Basic enhancements to StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=67081

Source/JavaScriptCore:

This change contains the following enhancements to StringBuilder,
for convenience, performance, testability, etc.:
- Change toStringPreserveCapacity() to const
- new public methods: capacity(), swap(), toAtomicString(), canShrink()
  and append(const StringBuilder&)
- == and != opearators to compare StringBuilders and a StringBuilder/String

Unit tests: Tools/TestWebKitAPI/Tests/WTF/StringBuilder.cpp

Reviewed by Darin Adler.

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/text/AtomicString.cpp:
(WTF::SubstringTranslator::hash):
(WTF::SubstringTranslator::equal):
(WTF::SubstringTranslator::translate):
(WTF::AtomicString::add):
(WTF::AtomicString::addSlowCase):
* wtf/text/AtomicString.h:
(WTF::AtomicString::AtomicString):
(WTF::AtomicString::add):
* wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::reifyString):
(WTF::StringBuilder::resize):
(WTF::StringBuilder::canShrink):
(WTF::StringBuilder::shrinkToFit):
* wtf/text/StringBuilder.h:
(WTF::StringBuilder::append):
(WTF::StringBuilder::toString):
(WTF::StringBuilder::toStringPreserveCapacity):
(WTF::StringBuilder::toAtomicString):
(WTF::StringBuilder::isEmpty):
(WTF::StringBuilder::capacity):
(WTF::StringBuilder::is8Bit):
(WTF::StringBuilder::swap):
(WTF::equal):
(WTF::operator==):
(WTF::operator!=):
* wtf/text/StringImpl.h:

Source/WebCore:

These changes are because we explicitly disallowed StringBuilder's
copy constructor and assignment operator, and the change of return
type of StringBuilder::toString().

Reviewed by Darin Adler.

No new tests. All layout tests and unit tests should run as before.

* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::setUpCookiesForQuickTime):
* svg/SVGPathStringBuilder.h:
(WebCore::SVGPathStringBuilder::cleanup):

Source/WebKit/chromium:

This change is because we explicitly disallowed StringBuilder's
copy constructor and assignment operator.

Reviewed by Darin Adler.

No new tests. All layout tests and unit tests should run as before.

* src/WebPageSerializerImpl.cpp:
(WebKit::WebPageSerializerImpl::encodeAndFlushBuffer):

Tools:

Reviewed by Darin Adler.

* TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add WebSolidColorLayer interface to draw non-textured color layers from...
wjmaclean@chromium.org [Mon, 23 Jan 2012 20:00:57 +0000 (20:00 +0000)]
[chromium] Add WebSolidColorLayer interface to draw non-textured color layers from Aura.
https://bugs.webkit.org/show_bug.cgi?id=75732

Reviewed by James Robinson.

Source/WebCore:

Add WebSolidColorLayer to paint solid-color layers without a backing texture.

Test: unit test for CCSolidColorLayerImpl.

* WebCore.gypi:
* platform/graphics/chromium/SolidColorLayerChromium.cpp: Added.
(WebCore::SolidColorLayerChromium::createCCLayerImpl):
(WebCore::SolidColorLayerChromium::create):
(WebCore::SolidColorLayerChromium::SolidColorLayerChromium):
(WebCore::SolidColorLayerChromium::~SolidColorLayerChromium):
* platform/graphics/chromium/SolidColorLayerChromium.h: Added.
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp: Added.
(WebCore::CCSolidColorLayerImpl::CCSolidColorLayerImpl):
(WebCore::CCSolidColorLayerImpl::~CCSolidColorLayerImpl):
(WebCore::CCSolidColorLayerImpl::quadTransform):
(WebCore::CCSolidColorLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.h: Added.
(WebCore::CCSolidColorLayerImpl::create):
(WebCore::CCSolidColorLayerImpl::layerTypeAsString):

Source/WebKit/chromium:

* WebKit.gyp:
* WebKit.gypi:
* public/platform/WebSolidColorLayer.h: Added.
* src/WebSolidColorLayer.cpp: Added.
(WebKit::WebSolidColorLayer::create):
(WebKit::WebSolidColorLayer::WebSolidColorLayer):
(WebKit::WebSolidColorLayer::setBackgroundColor):
* src/WebSolidColorLayerImpl.cpp: Added.
(WebKit::WebSolidColorLayerImpl::create):
(WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
(WebKit::WebSolidColorLayerImpl::~WebSolidColorLayerImpl):
* src/WebSolidColorLayerImpl.h: Added.
* tests/CCLayerTestCommon.cpp: Added.
(CCLayerTestCommon::completelyContains):
(CCLayerTestCommon::verifyQuadsExactlyCoverRect):
* tests/CCLayerTestCommon.h: Added.
* tests/CCSolidColorLayerImplTest.cpp: Added.
(CCLayerTestCommon::TEST):
* tests/CCTiledLayerImplTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate the baselines for a number of tests that use gradients. The new
abarth@webkit.org [Mon, 23 Jan 2012 19:39:15 +0000 (19:39 +0000)]
Update the baselines for a number of tests that use gradients.  The new
results are just slightly different than the old results.

* fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
* fast/gradients/border-image-gradient-expected.txt: Added.
* fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Added.
* platform/chromium-linux-x86/fast/gradients: Removed.
* platform/chromium-linux/fast/canvas/fillrect_gradient-expected.png:
* platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
* platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
* platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.png:
* platform/chromium-linux/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Removed.
* platform/chromium-linux/fast/gradients/css3-color-stops-expected.png: Removed.
* platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients-expected.png:
* platform/chromium-linux/fast/gradients/generated-gradients-expected.png:
* platform/chromium-linux/fast/gradients/simple-gradients-expected.png:
* platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png: Removed.
* platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png:
* platform/chromium-mac-leopard/fast/canvas/fillrect_gradient-expected.png:
* platform/chromium-mac-leopard/fast/gradients/generated-gradients-expected.png:
* platform/chromium-mac-leopard/fast/reflections/reflection-masks-expected.png:
* platform/chromium-mac-snowleopard/fast/canvas/fillrect_gradient-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement: Added.
* platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/gradients/border-image-gradient-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/gradients/css3-color-stops-expected.png:
* platform/chromium-mac-snowleopard/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/gradients/generated-gradients-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/gradients/simple-gradients-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/reflections/reflection-masks-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-2-expected.png:
* platform/chromium-mac-snowleopard/svg/filters/big-sized-filter-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png:
* platform/chromium-mac/fast/canvas/fillrect_gradient-expected.png: Removed.
* platform/chromium-mac/fast/canvas/gradient-add-second-start-end-stop-expected.png: Removed.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Removed.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
* platform/chromium-mac/fast/gradients/border-image-gradient-expected.png: Removed.
* platform/chromium-mac/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Removed.
* platform/chromium-mac/fast/gradients/css3-repeating-linear-gradients-expected.png: Removed.
* platform/chromium-mac/fast/gradients/generated-gradients-expected.png: Removed.
* platform/chromium-mac/fast/gradients/simple-gradients-expected.png: Removed.
* platform/chromium-mac/fast/reflections/reflection-masks-expected.png: Removed.
* platform/chromium-mac/svg/filters/big-sized-filter-expected.png: Removed.
* platform/chromium-win-vista/fast/gradients: Removed.
* platform/chromium-win-xp/svg/as-background-image: Removed.
* platform/chromium-win/fast/canvas/fillrect_gradient-expected.png:
* platform/chromium-win/fast/canvas/gradient-add-second-start-end-stop-expected.png:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.png:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.png:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png:
* platform/chromium-win/fast/gradients/border-image-gradient-expected.png:
* platform/chromium-win/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
* platform/chromium-win/fast/gradients/css3-color-stops-expected.png:
* platform/chromium-win/fast/gradients/css3-repeating-linear-gradients-expected.png:
* platform/chromium-win/fast/gradients/generated-gradients-expected.png:
* platform/chromium-win/fast/gradients/simple-gradients-expected.png:
* platform/chromium-win/fast/reflections/reflection-masks-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png:
* platform/chromium-win/svg/filters/big-sized-filter-expected.png:
* platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png:
* platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed.
* platform/gtk/fast/gradients/border-image-gradient-expected.txt: Removed.
* platform/gtk/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.
* platform/mac/fast/gradients/border-image-gradient-expected.txt: Removed.
* platform/mac/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.
* platform/qt/fast/gradients/border-image-gradient-expected.txt: Removed.
* platform/qt/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAttempt to fix Qt build.
antti@apple.com [Mon, 23 Jan 2012 17:20:02 +0000 (17:20 +0000)]
Attempt to fix Qt build.

Not reviewed.

* css/CSSElementStyleDeclaration.cpp:
* css/CSSElementStyleDeclaration.h:
(WebCore::CSSElementStyleDeclaration::createForSVGFontFaceElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove m_rootEditableElementForSelectionOnMouseDown off of HTMLAnchorElement.
kling@webkit.org [Mon, 23 Jan 2012 17:00:38 +0000 (17:00 +0000)]
Move m_rootEditableElementForSelectionOnMouseDown off of HTMLAnchorElement.
<http://webkit.org/b/76833>

Reviewed by Antti Koivisto.

Move HTMLAnchorElement::m_rootEditableElementForSelectionOnMouseDown to a rare
data-style hashmap, effectively shrinking HTMLAnchorElement by one CPU word.

The pointer is only used during interactive event handling, so it shouldn't have
any noticeable effects on web performance.

This reduces memory consumption by 256 kB (on 64-bit) when viewing the full
HTML5 spec at <http://whatwg.org/c>.

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::HTMLAnchorElement):
(WebCore::HTMLAnchorElement::~HTMLAnchorElement):
(WebCore::HTMLAnchorElement::defaultEventHandler):
(WebCore::HTMLAnchorElement::treatLinkAsLiveForEventType):
(WebCore::rootEditableElementMap):
(WebCore::HTMLAnchorElement::rootEditableElementForSelectionOnMouseDown):
(WebCore::HTMLAnchorElement::setRootEditableElementForSelectionOnMouseDown):
* html/HTMLAnchorElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEliminate CSSElementStyleDeclaration subclasses
antti@apple.com [Mon, 23 Jan 2012 16:49:10 +0000 (16:49 +0000)]
Eliminate CSSElementStyleDeclaration subclasses
https://bugs.webkit.org/show_bug.cgi?id=76827

Reviewed by Andreas Kling.

CSSInlineStyleDeclaration and FontFaceStyleDeclaration serve no real purpose.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSElementStyleDeclaration.cpp:
(WebCore::CSSElementStyleDeclaration::createForSVGFontFaceElement):
(WebCore::CSSElementStyleDeclaration::styleSheet):
* css/CSSElementStyleDeclaration.h:
(WebCore::CSSElementStyleDeclaration::createInline):
(WebCore::toCSSElementStyleDeclaration):
* css/CSSInlineStyleDeclaration.h: Removed.
* css/CSSMutableStyleDeclaration.cpp:
* dom/StyledElement.cpp:
(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::copyNonAttributeProperties):
* dom/StyledElement.h:
(WebCore::StyledElement::inlineStyleDecl):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
* editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI):
* html/ValidationMessage.cpp:
(WebCore::adjustBubblePosition):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlPanelElement::makeOpaque):
(WebCore::MediaControlPanelElement::makeTransparent):
* html/shadow/SliderThumbElement.cpp:
(WebCore::TrackLimiterElement::create):
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::SVGFontFaceElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, unskip now passing tests on GTK. Spotted by Zan Dobersek.
philn@webkit.org [Mon, 23 Jan 2012 16:45:45 +0000 (16:45 +0000)]
Unreviewed, unskip now passing tests on GTK. Spotted by Zan Dobersek.

* platform/gtk/Skipped: Unskip tests 5 tests using ArrayBuffer
which is no longer tied to 3D_CANVAS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed: annotate inspector's js so that it compiled.
pfeldman@chromium.org [Mon, 23 Jan 2012 16:37:16 +0000 (16:37 +0000)]
Not reviewed: annotate inspector's js so that it compiled.

* inspector/front-end/ElementsTreeOutline.js:
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.SuggestBox.prototype.upKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.downKeyPressed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, mark another test as flaky crash.
philn@webkit.org [Mon, 23 Jan 2012 16:32:56 +0000 (16:32 +0000)]
Unreviewed, mark another test as flaky crash.

* platform/gtk/test_expectations.txt:
editing/execCommand/19455.html is flaky, sometimes hitting an ASSERT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GStreamer] fix WebAudio build after r105431
philn@webkit.org [Mon, 23 Jan 2012 16:24:21 +0000 (16:24 +0000)]
[GStreamer] fix WebAudio build after r105431
https://bugs.webkit.org/show_bug.cgi?id=76819

Reviewed by Martin Robinson.

* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::copyGstreamerBuffersToAudioChannel): Use mutableData()
when copying.
* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcLoop): Drop constness when setting the buffer
data pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: add touch events to the event listeners list.
pfeldman@chromium.org [Mon, 23 Jan 2012 16:20:40 +0000 (16:20 +0000)]
Web Inspector: add touch events to the event listeners list.
https://bugs.webkit.org/show_bug.cgi?id=76830

Reviewed by Yury Semikhatsky.

* English.lproj/localizedStrings.js:
* inspector/InjectedScriptSource.js:
(.):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.EventListenerBreakpointsSidebarPane):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK gardening. Rebaseline after r105613, marked 3 svg
philn@webkit.org [Mon, 23 Jan 2012 15:52:06 +0000 (15:52 +0000)]
Unreviewed, GTK gardening. Rebaseline after r105613, marked 3 svg
flaky tests and added baselines for 15 tests.

* platform/gtk/css3/images/cross-fade-background-size-expected.txt: Added.
* platform/gtk/fast/backgrounds/mask-box-image-expected.txt: Added.
* platform/gtk/fast/borders/scaled-border-image-expected.txt: Added.
* platform/gtk/fast/css/text-overflow-input-expected.txt: Added.
* platform/gtk/fast/line-grid/line-grid-floating-expected.txt: Added.
* platform/gtk/fast/line-grid/line-grid-inside-columns-expected.txt: Added.
* platform/gtk/fast/line-grid/line-grid-into-floats-expected.txt: Added.
* platform/gtk/fast/line-grid/line-grid-positioned-expected.txt: Added.
* platform/gtk/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
* platform/gtk/svg/custom/relative-sized-image-expected.txt: Added.
* platform/gtk/svg/custom/transform-with-shadow-and-gradient-expected.txt: Added.
* platform/gtk/svg/filters/feImage-preserveAspectratio-expected.txt: Added.
* platform/gtk/svg/text/append-text-node-to-tspan-expected.txt: Added.
* platform/gtk/svg/text/modify-text-node-in-tspan-expected.txt: Added.
* platform/gtk/svg/text/remove-text-node-from-tspan-expected.txt: Added.
* platform/gtk/svg/text/remove-tspan-from-text-expected.txt: Added.
* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: inspector close button is missing in the dock-to-right mode.
pfeldman@chromium.org [Mon, 23 Jan 2012 15:47:26 +0000 (15:47 +0000)]
Web Inspector: inspector close button is missing in the dock-to-right mode.
https://bugs.webkit.org/show_bug.cgi?id=76829

Reviewed by Timothy Hatcher.

* inspector/front-end/inspector.js:
(WebInspector.set attached):
(WebInspector.get _setCompactMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening after r105613.
ossy@webkit.org [Mon, 23 Jan 2012 15:24:56 +0000 (15:24 +0000)]
[Qt] Unreviewed gardening after r105613.

* platform/qt/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Updated.
* platform/qt/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: IndexedDBModel should keep track of requests sent to the backend.
vsevik@chromium.org [Mon, 23 Jan 2012 15:17:04 +0000 (15:17 +0000)]
Web Inspector: IndexedDBModel should keep track of requests sent to the backend.
https://bugs.webkit.org/show_bug.cgi?id=76705

Reviewed by Pavel Feldman.

* inspector/Inspector.json:
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
* inspector/InspectorIndexedDBAgent.h:
* inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel):
(WebInspector.IndexedDBModel.prototype._frameDetached):
(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNamesForFrame):
(WebInspector.IndexedDBRequestManager):
(WebInspector.IndexedDBRequestManager.prototype.requestDatabaseNamesForFrame.innerCallback):
(WebInspector.IndexedDBRequestManager.prototype.requestDatabaseNamesForFrame):
(WebInspector.IndexedDBRequestManager.prototype._databaseNamesLoaded):
(WebInspector.IndexedDBRequestManager.prototype._requestId):
(WebInspector.IndexedDBRequestManager.prototype._frameDetached):
(WebInspector.IndexedDBRequestManager.prototype._reset):
(WebInspector.IndexedDBRequestManager.DatabasesForFrameRequest):
(WebInspector.IndexedDBDispatcher):
(WebInspector.IndexedDBDispatcher.prototype.databaseNamesLoaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Inspecting an element inside an iframe no longer works
pfeldman@chromium.org [Mon, 23 Jan 2012 15:10:01 +0000 (15:10 +0000)]
Web Inspector: Inspecting an element inside an iframe no longer works
https://bugs.webkit.org/show_bug.cgi?id=76808

Reviewed by Timothy Hatcher.

Source/WebCore:

Test: http/tests/inspector/inspect-element.html

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::innerParentNode):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.getChildNodes.mycallback):
(WebInspector.DOMNode.prototype.getChildNodes):
(WebInspector.DOMNode.prototype._setChildrenPayload):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._selectedNodeChanged):

LayoutTests:

* http/tests/inspector/inspect-element-expected.txt: Added.
* http/tests/inspector/inspect-element.html: Added.
* http/tests/inspector/resources/inspect-element-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: response.bodySize in HAR is invalid (negative) for cached resources
caseq@chromium.org [Mon, 23 Jan 2012 14:52:50 +0000 (14:52 +0000)]
Web Inspector: response.bodySize in HAR is invalid (negative) for cached resources
https://bugs.webkit.org/show_bug.cgi?id=76823

Reviewed by Yury Semikhatsky.

- fix response.bodySize for cached resources;
Also some drive-by fixes:
- pretty-print HAR when exported
- proper annotation for JSON.stringify()
- de-obfuscate a piece of code in TimelinePanel

* inspector/front-end/HAREntry.js:
(WebInspector.HAREntry.prototype.get responseBodySize):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._exportAll):
(WebInspector.NetworkLogView.prototype._exportResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Refactor GTK's accessibilitity code to be more modular
mario@webkit.org [Mon, 23 Jan 2012 14:45:23 +0000 (14:45 +0000)]
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

New files for the implementation of the AtkAction interface,
containing the related code from WebKitAccessibleWrapperAtk.cpp.

* accessibility/gtk/WebKitAccessibleInterfaceAction.cpp: Added.
(core):
(webkitAccessibleActionInterfaceInit):
(webkitAccessibleActionDoAction):
(webkitAccessibleActionGetNActions):
(webkitAccessibleActionGetDescription):
(webkitAccessibleActionGetKeybinding):
(webkitAccessibleActionGetName):
* accessibility/gtk/WebKitAccessibleInterfaceAction.h: Added.

* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code
related to the implementation of the AtkAction interface.

Add new files to build files.

* GNUmakefile.list.am: Add WebKitAccessibleInterfaceAction.[h|cpp].
* WebCore.gypi: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] run-gtk-tests randomly fails while running the xprop comand
mario@webkit.org [Mon, 23 Jan 2012 14:36:01 +0000 (14:36 +0000)]
[GTK] run-gtk-tests randomly fails while running the xprop comand
https://bugs.webkit.org/show_bug.cgi?id=76817

Reviewed by Gustavo Noronha Silva.

No need to use xprop to remove the AT_SPI_BUS property since
run-gtk-tests will always run new instances of Xvfb.

* Scripts/run-gtk-tests:
(TestRunner): Unskip TestWebKitAccessibility.
(TestRunner.run): Uncomment lines for launching the accessibility
bus and registry daemon, and remove lines for running xprop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Don't warn about override and final being C++11 extensions
vestbo@webkit.org [Mon, 23 Jan 2012 14:32:41 +0000 (14:32 +0000)]
[Qt] Don't warn about override and final being C++11 extensions

Clang will emit a warning when these extensions are used without passing
--std=c++11, but we use feature checking to decide if we have the right
extensions, so we can safely ignore these warnings. The XCode and Windows
project files have the same workaround.

The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
we only have one extra compiler for Objective-C, which is also used for
Objective-C++ sources, so we have to pass the flag, even if it doesn't
make sense for Objective-C.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed tweaking of test expectations: it should be IMAGE instead of IMAGE+TEXT.
antonm@chromium.org [Mon, 23 Jan 2012 14:12:43 +0000 (14:12 +0000)]
Unreviewed tweaking of test expectations: it should be IMAGE instead of IMAGE+TEXT.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed rebaseline after r105613 (SVG animation repaint issue...).
antonm@chromium.org [Mon, 23 Jan 2012 14:03:45 +0000 (14:03 +0000)]
Unreviewed rebaseline after r105613 (SVG animation repaint issue...).

* platform/chromium-mac-leopard/svg/custom/relative-sized-image-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/relative-sized-image-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSVG animation repaint issue with image and dynamic clipPath
zimmermann@webkit.org [Mon, 23 Jan 2012 12:48:12 +0000 (12:48 +0000)]
SVG animation repaint issue with image and dynamic clipPath
https://bugs.webkit.org/show_bug.cgi?id=76559

Reviewed by Zoltan Herczeg.

Source/WebCore:

Based on patch by Kelly Norton <knorton@google.com>. I extended the patch
to correctly handle relative length resolution as well.

RenderSVGImage doesn't react on setNeedsBoundariesUpdate() calls
and thus fails to update its boundaries in some cases.

The logic is also inconsistent, compared to the other renderers.
Fix that properly, by reusing the method used in RenderSVGViewportContainer.
Call calculateImageViewport() immediately, after initializing the LayoutRepainter.
Previously we resolved the image viewport in RenderSVGImage::updateFromElement. This is
wrong, as it queries the frameRect() of the RenderSVGRoot in a state, where the renderer
still needs layout, leading to wrong results.

I turned Kellys manual testcase into a predictable test, see svg/repaint/image-with-clip-path.svg
Relative sized image handling is tested in svg/custom/relative-sized-image.xhtml now.

Tests: svg/custom/relative-sized-image.xhtml
       svg/repaint/image-with-clip-path.svg

* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::RenderSVGImage):
(WebCore::RenderSVGImage::updateImageViewport):
(WebCore::RenderSVGImage::layout):
* rendering/svg/RenderSVGImage.h:
(WebCore::RenderSVGImage::setNeedsBoundariesUpdate):
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::svgAttributeChanged):

LayoutTests:

Update results after fixing RenderSVGImage repainting.

* platform/chromium-win/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
* platform/mac/svg/custom/relative-sized-image-expected.png: Added.
* platform/mac/svg/custom/relative-sized-image-expected.txt: Added.
* platform/mac/svg/repaint/image-with-clip-path-expected.png: Added.
* svg/custom/relative-sized-image.xhtml: Added.
* svg/repaint/image-with-clip-path-expected.txt: Added.
* svg/repaint/image-with-clip-path.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<feImage> has problems referencing local elements
zimmermann@webkit.org [Mon, 23 Jan 2012 12:42:42 +0000 (12:42 +0000)]
<feImage> has problems referencing local elements
https://bugs.webkit.org/show_bug.cgi?id=76800

Reviewed by Zoltan Herczeg.

Source/WebCore:

<feImage> referencing local elements are currently rendered into an ImageBuffer
by SVGFEImageElement, using the local coordinates of the referenced renderer.

This approach is buggy and should be avoided, by moving the rendering fully
into SVGFEImage, which takes care of respecting the correct transformations.

This fixes <feImage> + local references, which currently breaks two tests in trunk.
Covered by existing tests.

* rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
(WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::build):
* svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::FEImage):
(WebCore::FEImage::createWithImage):
(WebCore::FEImage::createWithIRIReference):
(WebCore::FEImage::determineAbsolutePaintRect):
(WebCore::FEImage::referencedRenderer):
(WebCore::FEImage::platformApplySoftware):
(WebCore::FEImage::externalRepresentation):
* svg/graphics/filters/SVGFEImage.h:
(WebCore::FEImage::~FEImage):
* svg/graphics/filters/SVGFilter.h:
(WebCore::SVGFilter::absoluteTransform):

LayoutTests:

Update svg/filters/feImage-reference-* results, which are fixed now.

* platform/chromium/test_expectations.txt : Updated.
* platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Update for marginal change.
* svg/filters/feImage-reference-invalidation-expected.png:
* svg/filters/feImage-reference-svg-primitive-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-01-23 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 23 Jan 2012 12:39:31 +0000 (12:39 +0000)]
2012-01-23  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Fix Mac build, by exporting a new symbol.

        * WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Refactor GTK's accessibilitity code to be more modular
mario@webkit.org [Mon, 23 Jan 2012 11:55:01 +0000 (11:55 +0000)]
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

Move common function returnString() from the wrapper and
hyperlink implementations to a new utility file.

* accessibility/gtk/WebKitAccessibleUtil.cpp: Added.
(returnString): Taken from WebKitAccessibleWrapperAtk.cpp and
WebKitAccessibleHyperlink.cpp
* accessibility/gtk/WebKitAccessibleUtil.h: Added.

* accessibility/gtk/WebKitAccessibleHyperlink.cpp: Remove local
implementation of returnString.
* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Ditto.

Add new files to build files.

* GNUmakefile.list.am: Add WebKitAccessibleUtil.[h|cpp].
* WebCore.gypi: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit fails IETC composition event types
ossy@webkit.org [Mon, 23 Jan 2012 11:51:20 +0000 (11:51 +0000)]
WebKit fails IETC composition event types
https://bugs.webkit.org/show_bug.cgi?id=76690

Unreviewed gardening after r105605.

* fast/events/ime-composition-events-001-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Refactor GTK's accessibilitity code to be more modular
mario@webkit.org [Mon, 23 Jan 2012 11:46:04 +0000 (11:46 +0000)]
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

Fix typo in class struct (parent class field had the wrong type),
fix coding style issues and update date in headers.

* accessibility/gtk/WebKitAccessibleHyperlink.cpp:
* accessibility/gtk/WebKitAccessibleHyperlink.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Refactor GTK's accessibilitity code to be more modular
mario@webkit.org [Mon, 23 Jan 2012 11:43:28 +0000 (11:43 +0000)]
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

Source/WebCore:

Rename WebKitAccessible's public functions to follow WebKit's
coding style and update callers.

* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleNew): Renamed from webkit_accessible_new.
(webkitAccessibleGetAccessibilityObject): Likewise.
(webkitAccessibleDetach):Likewise.
(webkitAccessibleGetFocusedElement): Likewise.
* accessibility/gtk/WebKitAccessibleWrapperAtk.h:

Update calls to WebKitAccessible's public functions.

* accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::detachWrapper): Update call.
(WebCore::AXObjectCache::attachWrapper): Ditto.
* accessibility/gtk/WebKitAccessibleHyperlink.cpp:
(core): Update call.

Source/WebKit/gtk:

Update callers to WebKitAccessible's public functions.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::getFocusedAccessibleElement):
(modifyAccessibilityValue):
(DumpRenderTreeSupportGtk::accessibilityHelpText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fix make distcheck.
carlosgc@webkit.org [Mon, 23 Jan 2012 11:17:26 +0000 (11:17 +0000)]
Unreviewed. Fix make distcheck.

* GNUmakefile.list.am: Add missing files, remove deleted files and
fix indentation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit fails IETC composition event types
bashi@chromium.org [Mon, 23 Jan 2012 10:41:29 +0000 (10:41 +0000)]
WebKit fails IETC composition event types
https://bugs.webkit.org/show_bug.cgi?id=76690

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Refactor GTK's accessibilitity code to be more modular
mario@webkit.org [Mon, 23 Jan 2012 10:21:03 +0000 (10:21 +0000)]
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

Source/WebCore:

Rename the file for the ATK AccessibilityObject wrapper to be more
coherent with the rest of the files in the same directory.

* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Renamed from
Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp.
(fallbackObject):
(returnString):
(core):
(webkit_accessible_get_name):
(webkit_accessible_get_description):
(setAtkRelationSetFromCoreObject):
(isRootObject):
(atkParentOfRootObject):
(webkit_accessible_get_parent):
(getNChildrenForTable):
(webkit_accessible_get_n_children):
(getChildForTable):
(webkit_accessible_ref_child):
(getIndexInParentForCellInRow):
(webkit_accessible_get_index_in_parent):
(addAttributeToSet):
(webkit_accessible_get_attributes):
(atkRole):
(webkit_accessible_get_role):
(selectionBelongsToObject):
(isTextWithCaret):
(setAtkStateSetFromCoreObject):
(webkit_accessible_ref_state_set):
(webkit_accessible_ref_relation_set):
(webkit_accessible_init):
(webkit_accessible_finalize):
(webkit_accessible_class_init):
(webkit_accessible_get_type):
(webkit_accessible_action_do_action):
(webkit_accessible_action_get_n_actions):
(webkit_accessible_action_get_description):
(webkit_accessible_action_get_keybinding):
(webkit_accessible_action_get_name):
(atk_action_interface_init):
(listObjectForSelection):
(optionFromList):
(optionFromSelection):
(webkit_accessible_selection_add_selection):
(webkit_accessible_selection_clear_selection):
(webkit_accessible_selection_ref_selection):
(webkit_accessible_selection_get_selection_count):
(webkit_accessible_selection_is_child_selected):
(webkit_accessible_selection_remove_selection):
(webkit_accessible_selection_select_all_selection):
(atk_selection_interface_init):
(utf8Substr):
(convertUniCharToUTF8):
(textForRenderer):
(textForObject):
(webkit_accessible_text_get_text):
(getGailTextUtilForAtk):
(getPangoLayoutForAtk):
(webkit_accessible_text_get_text_after_offset):
(webkit_accessible_text_get_text_at_offset):
(webkit_accessible_text_get_text_before_offset):
(webkit_accessible_text_get_character_at_offset):
(webkit_accessible_text_get_caret_offset):
(baselinePositionForRenderObject):
(getAttributeSetForAccessibilityObject):
(compareAttribute):
(attributeSetDifference):
(accessibilityObjectLength):
(getAccessibilityObjectForOffset):
(getRunAttributesFromAccesibilityObject):
(webkit_accessible_text_get_run_attributes):
(webkit_accessible_text_get_default_attributes):
(textExtents):
(webkit_accessible_text_get_character_extents):
(webkit_accessible_text_get_range_extents):
(webkit_accessible_text_get_character_count):
(webkit_accessible_text_get_offset_at_point):
(getSelectionOffsetsForObject):
(webkit_accessible_text_get_n_selections):
(webkit_accessible_text_get_selection):
(webkit_accessible_text_add_selection):
(webkit_accessible_text_set_selection):
(webkit_accessible_text_remove_selection):
(webkit_accessible_text_set_caret_offset):
(atk_text_interface_init):
(webkit_accessible_editable_text_set_run_attributes):
(webkit_accessible_editable_text_set_text_contents):
(webkit_accessible_editable_text_insert_text):
(webkit_accessible_editable_text_copy_text):
(webkit_accessible_editable_text_cut_text):
(webkit_accessible_editable_text_delete_text):
(webkit_accessible_editable_text_paste_text):
(atk_editable_text_interface_init):
(contentsToAtk):
(atkToContents):
(webkit_accessible_component_ref_accessible_at_point):
(webkit_accessible_component_get_extents):
(webkit_accessible_component_grab_focus):
(atk_component_interface_init):
(webkit_accessible_image_get_image_position):
(webkit_accessible_image_get_image_description):
(webkit_accessible_image_get_image_size):
(atk_image_interface_init):
(cell):
(cellIndex):
(cellAtIndex):
(webkit_accessible_table_ref_at):
(webkit_accessible_table_get_index_at):
(webkit_accessible_table_get_column_at_index):
(webkit_accessible_table_get_row_at_index):
(webkit_accessible_table_get_n_columns):
(webkit_accessible_table_get_n_rows):
(webkit_accessible_table_get_column_extent_at):
(webkit_accessible_table_get_row_extent_at):
(webkit_accessible_table_get_column_header):
(webkit_accessible_table_get_row_header):
(webkit_accessible_table_get_caption):
(webkit_accessible_table_get_column_description):
(webkit_accessible_table_get_row_description):
(atk_table_interface_init):
(webkitAccessibleHypertextGetLink):
(webkitAccessibleHypertextGetNLinks):
(webkitAccessibleHypertextGetLinkIndex):
(atkHypertextInterfaceInit):
(webkitAccessibleHyperlinkImplGetHyperlink):
(atkHyperlinkImplInterfaceInit):
(documentAttributeValue):
(webkit_accessible_document_get_attribute_value):
(webkit_accessible_document_get_attributes):
(webkit_accessible_document_get_locale):
(atk_document_interface_init):
(webkitAccessibleValueGetCurrentValue):
(webkitAccessibleValueGetMaximumValue):
(webkitAccessibleValueGetMinimumValue):
(webkitAccessibleValueSetCurrentValue):
(webkitAccessibleValueGetMinimumIncrement):
(atkValueInterfaceInit):
(GetAtkInterfaceTypeFromWAIType):
(getInterfaceMaskFromObject):
(getUniqueAccessibilityTypeName):
(getAccessibilityTypeFromObject):
(webkit_accessible_new):
(webkit_accessible_get_accessibility_object):
(webkit_accessible_detach):
(webkit_accessible_get_focused_element):
(objectFocusedAndCaretOffsetUnignored):
* accessibility/gtk/WebKitAccessibleWrapperAtk.h: Renamed from
Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.h.

Update the include for the AccessibilityObject wrapper header.

* accessibility/gtk/AXObjectCacheAtk.cpp: Update include.
* accessibility/gtk/WebKitAccessibleHyperlink.cpp: Ditto.
* accessibility/gtk/WebKitAccessibleHyperlink.h: Ditto.
* editing/gtk/FrameSelectionGtk.cpp:

Update filename for the ATK wrapper in build files.

* GNUmakefile.list.am: Updated.
* WebCore.gypi: Updated.

Source/WebKit/gtk:

Update the include for the AccessibilityObject wrapper header.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Update include.
* webkit/webkitwebframe.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Change how build-webkit decides when to do full incremental builds
vestbo@webkit.org [Mon, 23 Jan 2012 10:14:48 +0000 (10:14 +0000)]
[Qt] Change how build-webkit decides when to do full incremental builds

Instead of relying on update-webkit (which isn't run on the bots) to
decide when to do a full incremental build (make qmake), we let the
build-webkit script itself check the current SVN revision against the
previous build (by storing it in .webkit.config).

If the two differ we assume a full incremental build is needed, since
the new revisions might have introduced problematic things like new
Q_OBJECT macros. If not, we assume the developer is doing changes
locally, and revert to doing a plain 'make'.

In addition, when the build fails in the latter case, we inform the
developer of possible pitfalls and how to manually run 'make qmake'.

Reviewed by Ossy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed follow-up to r105596, added missing test resources.
caseq@chromium.org [Mon, 23 Jan 2012 10:09:47 +0000 (10:09 +0000)]
Unreviewed follow-up to r105596, added missing test resources.

* http/tests/inspector/resources/har-pages-iframe.html: Added.
* http/tests/inspector/resources/har-pages-navigation-target.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] run-gtk-tests randomly fails while running the xprop comand
mario@webkit.org [Mon, 23 Jan 2012 10:05:29 +0000 (10:05 +0000)]
[GTK] run-gtk-tests randomly fails while running the xprop comand
https://bugs.webkit.org/show_bug.cgi?id=76817

Reviewed by Philippe Normand.

Temporarily comment the lines related to launching the ATSPI bus
and registry daemon, which are making the bots to fail randomly.

* Scripts/run-gtk-tests:
(TestRunner): Skip TestWebKitAccessibility, as it won't run
properly if the ATSPI infrastructure is not properly initialized.
(TestRunner.run): Comment lines related to initialization of ATSPI.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: PageAgent.open() dosen't belong to the protocol.
pfeldman@chromium.org [Mon, 23 Jan 2012 10:04:10 +0000 (10:04 +0000)]
Web Inspector: PageAgent.open() dosen't belong to the protocol.
https://bugs.webkit.org/show_bug.cgi?id=74790

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/Inspector.json:
* inspector/InspectorFrontendClient.h:
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::openInNewTab):
* inspector/InspectorFrontendClientLocal.h:
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::openInNewTab):
* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.idl:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::navigate):
* inspector/InspectorPageAgent.h:
* inspector/front-end/ImageView.js:
(WebInspector.ImageView.prototype._openInNewTab):
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.openInNewTab):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._openInNewTab):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype.ondblclick):
* inspector/front-end/inspector.js:
(WebInspector.openResource):

Source/WebKit/chromium:

* public/WebDevToolsFrontendClient.h:
(WebKit::WebDevToolsFrontendClient::openInNewTab):
* src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::openInNewTab):
(WebKit::InspectorFrontendClientImpl::saveAs):
* src/InspectorFrontendClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r101742.
philn@webkit.org [Mon, 23 Jan 2012 09:59:08 +0000 (09:59 +0000)]
Unreviewed, GTK rebaseline after r101742.

* platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
* platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
* platform/gtk/fast/forms/placeholder-position-expected.txt:
* platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/gtk/fast/forms/search-styled-expected.txt:
* platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
* platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt:
* platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: DetailedHeapSnapshot: Replace the list of retainers with the expandabl...
loislo@chromium.org [Mon, 23 Jan 2012 09:23:48 +0000 (09:23 +0000)]
Web Inspector: DetailedHeapSnapshot: Replace the list of retainers with the expandable tree (to get rid of cycles)
https://bugs.webkit.org/show_bug.cgi?id=76813

Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotObjectNode):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotRetainmentDataGrid):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.reset):
(WebInspector.DetailedHeapshotView.prototype._startRetainersHeaderDragging):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype.createRetainingEdgesProvider):
(WebInspector.HeapSnapshotEdgesProvider):
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider):
(WebInspector.HeapSnapshotProxy.prototype.createRetainingEdgesProvider):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK gardening, marked 2 tests as flaky on Debug and
philn@webkit.org [Mon, 23 Jan 2012 09:13:23 +0000 (09:13 +0000)]
Unreviewed, GTK gardening, marked 2 tests as flaky on Debug and
unskipped another needing new baselines.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: HAR pageref attributes are wrong and inconsistent with pages array
caseq@chromium.org [Mon, 23 Jan 2012 09:02:56 +0000 (09:02 +0000)]
Web Inspector: HAR pageref attributes are wrong and inconsistent with pages array
https://bugs.webkit.org/show_bug.cgi?id=76398

Reviewed by Pavel Feldman.

Source/WebCore:

- introduce a notion of LoadPage;
- move page load times to LoadPage;
- associate network resources with LoadPage;
- export pages for all available resoruces to HAR, not just the last page;
- use page ids, not document URLs in HAR entries to refer to pages;
- use page URL as a title field of a HAR page;

* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel):
* inspector/front-end/HAREntry.js:
(WebInspector.HAREntry.prototype.build):
(WebInspector.HAREntry.prototype.get responseCompression):
(WebInspector.HARLog.prototype._buildPages):
(WebInspector.HARLog.prototype._convertPage):
(WebInspector.HARLog.prototype._pageEventTime):
* inspector/front-end/NetworkLog.js:
(WebInspector.NetworkLog):
(WebInspector.NetworkLog.prototype._mainFrameNavigated):
(WebInspector.NetworkLog.prototype._onResourceStarted):
(WebInspector.Page):
(WebInspector.Page.prototype.get id):
(WebInspector.Page.prototype.get url):
(WebInspector.Page.prototype.get contentLoadTime):
(WebInspector.Page.prototype.set contentLoadTime):
(WebInspector.Page.prototype.get loadTime):
(WebInspector.Page.prototype.set loadTime):
(WebInspector.Page.prototype.get startTime):
(WebInspector.Page.prototype._bindResource):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype.requestServedFromMemoryCache):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.get page):
(WebInspector.Resource.prototype.set page):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype.get page):
(WebInspector.PageDispatcher.prototype.domContentEventFired):
(WebInspector.PageDispatcher.prototype.loadEventFired):

LayoutTests:

* http/tests/inspector/resource-har-headers-expected.txt:
* http/tests/inspector/resource-parameters-expected.txt:
* platform/chromium/http/tests/inspector/resource-har-conversion-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK gardening, marked a test as flaky and unskipped
philn@webkit.org [Mon, 23 Jan 2012 08:58:25 +0000 (08:58 +0000)]
Unreviewed, GTK gardening, marked a test as flaky and unskipped
several needing new baselines.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows python test build fix.
rniwa@webkit.org [Mon, 23 Jan 2012 02:13:40 +0000 (02:13 +0000)]
Windows python test build fix.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-01-22 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sun, 22 Jan 2012 19:51:37 +0000 (19:51 +0000)]
2012-01-22  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Fix typo, which makes the style bot warn on every patch.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105591 268f45cc-cd09-0410-ab3c-d52691b4dbfc