WebKit-https.git
10 years ago2010-01-08 Luiz Agostini <luiz.agostini@openbossa.org>
eric@webkit.org [Fri, 8 Jan 2010 21:48:02 +0000 (21:48 +0000)]
2010-01-08  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Delegation client
        https://bugs.webkit.org/show_bug.cgi?id=32826

        Factory related code removed from QtAbstractWebPopup. Popups are now created
        by ChromeClientQt.
        Popup content information struct added to class QtAbstractWebPopup.
        PopupMenuClient is now hidden from higher layers.
        QtAbstractWebPopup now receives content information and font as parameters
        of method populate.
        QtFallbackWebPopup moved to WebKit/qt/WebCoreSupport.

        * WebCore.pro:
        * platform/qt/PopupMenuQt.cpp:
        (WebCore::PopupMenu::PopupMenu):
        (WebCore::getItems):
        (WebCore::PopupMenu::show):
        * platform/qt/QtAbstractWebPopup.cpp:
        (WebCore::QtAbstractWebPopup::QtAbstractWebPopup):
        (WebCore::QtAbstractWebPopup::popupDidHide):
        (WebCore::QtAbstractWebPopup::valueChanged):
        * platform/qt/QtAbstractWebPopup.h:
        (WebCore::QtAbstractWebPopup::Item::):
        * platform/qt/QtFallbackWebPopup.cpp: Removed.
        * platform/qt/QtFallbackWebPopup.h: Removed.
2010-01-08  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Delegation client
        https://bugs.webkit.org/show_bug.cgi?id=32826

        Added method createPopup to ChromeClientQt used to create popups.
        QtFallbackWebPopup moved from WebCore/platform/qt to
        WebKit/qt/WebCoreSupport.

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::createPopup):
        * WebCoreSupport/ChromeClientQt.h:
        * WebCoreSupport/QtFallbackWebPopup.cpp: Added.
        (WebCore::QtFallbackWebPopup::QtFallbackWebPopup):
        (WebCore::QtFallbackWebPopup::show):
        (WebCore::QtFallbackWebPopup::populate):
        (WebCore::QtFallbackWebPopup::showPopup):
        (WebCore::QtFallbackWebPopup::hidePopup):
        (WebCore::QtFallbackWebPopup::activeChanged):
        (WebCore::QtFallbackWebPopup::setParent):
        * WebCoreSupport/QtFallbackWebPopup.h: Added.
        (WebCore::QtFallbackWebPopup::hide):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-08 Yuzo Fujishima <yuzo@google.com>
eric@webkit.org [Fri, 8 Jan 2010 21:31:31 +0000 (21:31 +0000)]
2010-01-08  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Darin Adler.

        Skip invalid blocks in CSS property declarations.
        https://bugs.webkit.org/show_bug.cgi?id=31231
        https://bugs.webkit.org/show_bug.cgi?id=26619

        This patch makes the CSS parser skip property declarations containing invalid blocks.

        * fast/css/parsing-error-recovery-expected.txt: Added.
        * fast/css/parsing-error-recovery.html: Added.
2010-01-08  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Darin Adler.

        Skip invalid blocks in CSS property declarations.
        https://bugs.webkit.org/show_bug.cgi?id=31231
        https://bugs.webkit.org/show_bug.cgi?id=26619

        This patch makes the CSS parser skip property declarations containing invalid blocks.

        Test: fast/css/parsing-error-recovery.html

        * css/CSSGrammar.y:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Fixed media test failures caused by http://trac.webkit.org/changeset/52998.
cmarrin@apple.com [Fri, 8 Jan 2010 21:11:44 +0000 (21:11 +0000)]
    Fixed media test failures caused by trac.webkit.org/changeset/52998.
        The media controller on Windows now has a full-screen button, which changes
        the layout and therefore the test results. I regenerated them for
        Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Adam Roben.
bweinstein@apple.com [Fri, 8 Jan 2010 21:07:31 +0000 (21:07 +0000)]
Rubber-stamped by Adam Roben.

The Windows Release bots were having trouble with the xmlhttprequest tests, so
they were skipped (r50280). They all currently pass on my machine, so unskipping them now.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-08 Darin Fisher <darin@chromium.org>
darin@chromium.org [Fri, 8 Jan 2010 20:49:26 +0000 (20:49 +0000)]
2010-01-08  Darin Fisher  <darin@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Upstream webkit unit tests from the chromium repository
        https://bugs.webkit.org/show_bug.cgi?id=33351

        This adds one such test (for KURL) and sets up the test framework.

        Switch WebKit to build a static library on all platforms.  Add a
        webkit_unit_tests executable target that runs the unit tests and also
        ensures that we don't have any missing symbols (a function that WebKit
        as a shared library used to serve).

        Changes chromium_src_dir to ../../WebKit/chromium to match how
        WebCore.gyp defines that variable.

        * WebKit.gyp:
        * public/WebKitClient.h:
        (WebKit::WebKitClient::getPluginList): Remove bogus trailing semi-colon.
        (WebKit::WebKitClient::decrementStatsCounter): Remove bogus trailing semi-colon.
        (WebKit::WebKitClient::incrementStatsCounter): Remove bogus trailing semi-colon.
        (WebKit::WebKitClient::traceEventBegin): Remove bogus trailing semi-colon.
        (WebKit::WebKitClient::traceEventEnd): Remove bogus trailing semi-colon.
        (WebKit::WebKitClient::histogramCounts): Remove bogus trailing semi-colon.
        * tests: Added.
        * tests/KURLTest.cpp: Added.
        * tests/WebKitTest.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: CSS content not returned correctly in AX
cfleizach@apple.com [Fri, 8 Jan 2010 20:31:19 +0000 (20:31 +0000)]
AX: CSS content not returned correctly in AX
https://bugs.webkit.org/show_bug.cgi?id=33308

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/css-content-attribute.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement):

LayoutTests:

* platform/mac/accessibility/css-content-attribute-expected.txt: Added.
* platform/mac/accessibility/css-content-attribute.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@53000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-06 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 8 Jan 2010 19:58:18 +0000 (19:58 +0000)]
2010-01-06  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        transitions/shorthand-border-transitions.html is flaky
        https://bugs.webkit.org/show_bug.cgi?id=33276

        Yet another transitions test that doesn't give consistent
        wiggle room. Make all the wiggle rooms account for >=200ms
        instead of some that were only giving 100ms wiggle room.

        * transitions/shorthand-border-transitions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Implement full-screen video for Windows
cmarrin@apple.com [Fri, 8 Jan 2010 19:23:40 +0000 (19:23 +0000)]
    Implement full-screen video for Windows
        https://bugs.webkit.org/show_bug.cgi?id=31318

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed correction.
bfulgham@webkit.org [Fri, 8 Jan 2010 18:55:07 +0000 (18:55 +0000)]
Unreviewed correction.

Accidentally left unnecessary modification to hdcFromContext
in when landing r52995.

* WebFrame.cpp:
(hdcFromContext): Back out unneeded modification.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-08 Matt Perry <mpcomplete@chromium.org>
abarth@webkit.org [Fri, 8 Jan 2010 18:54:42 +0000 (18:54 +0000)]
2010-01-08  Matt Perry  <mpcomplete@chromium.org>

        Reviewed by Adam Barth.

        Fix a regression that removed a call to
        FrameLoaderClient::didDestroyScriptContextForFrame.
        https://bugs.webkit.org/show_bug.cgi?id=33347

        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::V8DOMWindowShell::disposeContextHandles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: WebKit plugins are not rendered during printing.
bfulgham@webkit.org [Fri, 8 Jan 2010 17:30:33 +0000 (17:30 +0000)]
WebCore: WebKit plugins are not rendered during printing.
https://bugs.webkit.org/show_bug.cgi?id=33022.

Reviewed by Adam Roben.

* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paintWindowedPluginIntoContext): Tell
  cairo printing surface to flush so that blank regions do
  not write over the plugin's paint operations.
* rendering/RenderLayer.cpp: Build fix.
(WebCore::RenderLayer::beginTransparencyLayers): Correct
  method signature missing for ColorSpace.

WebKit/win: Use correct cairo surface data type for handling print operations.
https://bugs.webkit.org/show_bug.cgi?id=33022.

Reviewed by Adam Roben.

* WebFrame.cpp:
(scaleFactor): Handle 'scale = 0' case.
(WebFrame::spoolPage): Use scaleFactor helper function.  Account for
 margin size in region passed to header/footer routines.
(WebFrame::spoolPages): Properly clean up Cairo surface.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow...
cfleizach@apple.com [Fri, 8 Jan 2010 17:24:11 +0000 (17:24 +0000)]
REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot
https://bugs.webkit.org/show_bug.cgi?id=33300

Reviewed by Eric Seidel.

WebCore:

* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilitySetPostedNotificationCallback:withContext:]):
(-[AccessibilityObjectWrapper accessibilityPostedNotification:]):

WebKitTools:

* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::~AccessibilityUIElement):
(_accessibilityNotificationCallback):
(AccessibilityUIElement::addNotificationListener):

LayoutTests:

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed trivail fix. Missing bugzilla link added to ChangeLog.(r52976)
ossy@webkit.org [Fri, 8 Jan 2010 14:27:25 +0000 (14:27 +0000)]
Unreviewed trivail fix. Missing bugzilla link added to ChangeLog.(r52976)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Kenneth Rohde Christiansen.
ossy@webkit.org [Fri, 8 Jan 2010 14:22:27 +0000 (14:22 +0000)]
Rubber-stamped by Kenneth Rohde Christiansen.

r52976 revealed this failure by re-ordering tests.

I do not have a Snow Leopard build to test with, so skipping this
and filed bug https://bugs.webkit.org/show_bug.cgi?id=33372

* platform/mac-snowleopard/Skipped: platform/mac/editing/input/devanagari-ligature.html skipped.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed trivial fix.
ossy@webkit.org [Fri, 8 Jan 2010 13:26:57 +0000 (13:26 +0000)]
Unreviewed trivial fix.

LayoutTests/media/video-error-abort.html moved to LayoutTests/http/tests/media/video-error-abort.html
by r52923, but wasn't renamed in this skiplist by this commit.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agor52976 revealed this failure by re-ordering tests.
ossy@webkit.org [Fri, 8 Jan 2010 13:08:14 +0000 (13:08 +0000)]
r52976 revealed this failure by re-ordering tests.
r52980 corrected the expected results file, but Windows still fails,
presumably due to another test still affecting this one.

Reviewed by Eric Seidel.

I do not have a windows build to test with, so skipping this
and filed bug https://bugs.webkit.org/show_bug.cgi?id=33374

* platform/win/Skipped: svg/W3C-SVG-1.1/filters-conv-01-f.svg skipped.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-08 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 8 Jan 2010 12:59:05 +0000 (12:59 +0000)]
2010-01-08  Eric Seidel  <eric@webkit.org>

        Reviewed by Simon Hausmann.

        commit-queue should run run-javascriptcore-tests
        https://bugs.webkit.org/show_bug.cgi?id=33376

        I also made it run the python and perl unit tests.

        * Scripts/webkitpy/steps/runtests.py:
        * Scripts/webkitpy/webkitport.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-08 Alejandro G. Castro <alex@igalia.com>
eric@webkit.org [Fri, 8 Jan 2010 12:46:48 +0000 (12:46 +0000)]
2010-01-08  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Threading problems with some of the tests
        https://bugs.webkit.org/show_bug.cgi?id=30814

        We are going to skip all the storage tests until we find the issue
        with the threading system in the gtk port.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-08 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 8 Jan 2010 12:09:42 +0000 (12:09 +0000)]
2010-01-08  Eric Seidel  <eric@webkit.org>

        No review, rolling out r52983.
        http://trac.webkit.org/changeset/52983
        https://bugs.webkit.org/show_bug.cgi?id=33321

        Broke 59 JavaScriptCore tests.  I don't think Kent knew about
        run-javascriptcore-tests.  Sadly neither does the commit-bot,
        yet.

        * runtime/RegExp.cpp:
        (JSC::RegExp::RegExp):
        * runtime/RegExp.h:
        (JSC::RegExp::flags):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-08 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Fri, 8 Jan 2010 11:54:29 +0000 (11:54 +0000)]
2010-01-08  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Xan Lopez.

        [GTK] loading test should use SoupServer instead of actual sites
        https://bugs.webkit.org/show_bug.cgi?id=33353

        Make all the loading tests use SoupServer, instead of fetching
        stuff from the Internet.

        * tests/testloading.c:
        (server_callback):
        (get_uri_for_path):
        (test_loading_status):
        (test_loading_error):
        (test_loading_cancelled):
        (load_wentback_status_changed_cb):
        (load_error_test):
        (test_loading_goback):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-08 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 8 Jan 2010 11:50:25 +0000 (11:50 +0000)]
2010-01-08  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Regex-based syntax highlighting is slow.

        https://bugs.webkit.org/show_bug.cgi?id=33330

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/JavaScriptHighlighterScheme.js: Removed.
        * inspector/front-end/JavaScriptTokenizer.js: Added.
        (WebInspector.JavaScriptTokenizer):
        (WebInspector.JavaScriptTokenizer.prototype.set line):
        (WebInspector.JavaScriptTokenizer.prototype.getCondition):
        (WebInspector.JavaScriptTokenizer.prototype.setCondition):
        (WebInspector.JavaScriptTokenizer.prototype._charAt):
        (WebInspector.JavaScriptTokenizer.prototype.nextToken):
        * inspector/front-end/JavaScriptTokenizer.re2js: Added.
        * inspector/front-end/TextEditorHighlighter.js:
        (WebInspector.TextEditorHighlighter):
        (WebInspector.TextEditorHighlighter.prototype.highlight):
        (WebInspector.TextEditorHighlighter.prototype._lex):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-08 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 8 Jan 2010 11:44:19 +0000 (11:44 +0000)]
2010-01-08  Eric Seidel  <eric@webkit.org>

        No review, rolling out r52981.
        http://trac.webkit.org/changeset/52981
        https://bugs.webkit.org/show_bug.cgi?id=33319

        Caused two JS tests to start failing:
        ecma_2/RegExp/properties-001.js and js1_2/regexp/toString.js

        * runtime/RegExpPrototype.cpp:
        (JSC::regExpProtoFuncToString):
2010-01-08  Eric Seidel  <eric@webkit.org>

        No review, rolling out r52981.
        http://trac.webkit.org/changeset/52981
        https://bugs.webkit.org/show_bug.cgi?id=33319

        Caused two JS tests to start failing:
        ecma_2/RegExp/properties-001.js and js1_2/regexp/toString.js

        * fast/js/kde/RegExp-expected.txt:
        * fast/js/kde/script-tests/RegExp.js:
        * fast/js/regexp-compile-expected.txt:
        * fast/js/script-tests/regexp-compile.js:
        * fast/regex/non-pattern-characters-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-08 Kent Hansen <kent.hansen@nokia.com>
eric@webkit.org [Fri, 8 Jan 2010 11:32:55 +0000 (11:32 +0000)]
2010-01-08  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Darin Adler.

        Don't store RegExp flags string representation
        https://bugs.webkit.org/show_bug.cgi?id=33321

        It's unused; the string representation is reconstructed from flags.

        * runtime/RegExp.cpp:
        (JSC::RegExp::RegExp):
        * runtime/RegExp.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-08 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 8 Jan 2010 11:23:27 +0000 (11:23 +0000)]
2010-01-08  Eric Seidel  <eric@webkit.org>

        Reviewed by Tor Arne Vestbø.

        media/unsupported-tracks.html is failing on Snow Leopard Release bot
        https://bugs.webkit.org/show_bug.cgi?id=32339

        * platform/mac-snowleopard/Skipped: Add this to join a bunch of other skipped media tests which time out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-08 Kent Hansen <kent.hansen@nokia.com>
eric@webkit.org [Fri, 8 Jan 2010 11:17:27 +0000 (11:17 +0000)]
2010-01-08  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Darin Adler.

        RegExp.prototype.toString returns "//" for empty regular expressions
        https://bugs.webkit.org/show_bug.cgi?id=33319

        "//" starts a single-line comment, hence "/(?:)/" should be used, according to ECMA.

        * runtime/RegExpPrototype.cpp:
        (JSC::regExpProtoFuncToString):
2010-01-08  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Darin Adler.

        RegExp.prototype.toString returns "//" for empty regular expressions
        https://bugs.webkit.org/show_bug.cgi?id=33319

        Add new test cases and adapt existing ones.

        * fast/js/kde/RegExp-expected.txt:
        * fast/js/kde/script-tests/RegExp.js:
        * fast/js/script-tests/regexp-compile.js:
        * fast/regex/non-pattern-characters-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-08 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 8 Jan 2010 10:22:27 +0000 (10:22 +0000)]
2010-01-08  Eric Seidel  <eric@webkit.org>

        Reviewed by Simon Hausmann.

        http/tests/uri/escaped-entity.html affects the output of svg/W3C-SVG-1.1/filters-conv-01-f.svg
        https://bugs.webkit.org/show_bug.cgi?id=32294

        * platform/mac/Skipped: Add http/tests/uri/escaped-entity.html to Skipped list since it affects later tests.
        * platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Check in correct results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 8 Jan 2010 10:12:53 +0000 (10:12 +0000)]
2010-01-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Darin Fisher.

        REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot
        https://bugs.webkit.org/show_bug.cgi?id=33300

        Skipping platform/mac/accessibility/aria-liveregions-notifications.html
        to make the bots green until Chris Fleizach can fix the AX Notification system
        to correctly unregister logging callbacks.

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRVCT compiler with "-Otime -O3" optimization tries to optimize out
hausmann@webkit.org [Fri, 8 Jan 2010 08:51:35 +0000 (08:51 +0000)]
RVCT compiler with "-Otime -O3" optimization tries to optimize out
inline new'ed pointers that are passed as arguments.
Proposed patch assigns new'ed pointer explicitly outside function call.

Patch by Norbert Leser <norbert.leser@nokia.com> on 2010-01-08
Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=33084

* API/JSClassRef.cpp:
(OpaqueJSClass::OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove an unnecessary cacheFlush from ARM_TRADITIONAL JIT
loki@webkit.org [Fri, 8 Jan 2010 08:01:40 +0000 (08:01 +0000)]
Remove an unnecessary cacheFlush from ARM_TRADITIONAL JIT
https://bugs.webkit.org/show_bug.cgi?id=33203

Reviewed by Gavin Barraclough.

* assembler/ARMAssembler.cpp: Remove obsolete linkBranch function.
(JSC::ARMAssembler::executableCopy): Inline a clean linkBranch code.
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::getLdrImmAddress): Use inline function.
(JSC::ARMAssembler::getLdrImmAddressOnPool): Ditto.
(JSC::ARMAssembler::patchPointerInternal): Remove an unnecessary cacheFlush.
(JSC::ARMAssembler::linkJump): Use patchPointerInternal instead of linkBranch.
(JSC::ARMAssembler::linkCall): Ditto.
(JSC::ARMAssembler::relinkCall): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRun the http and websocket tests after all other tests.
ossy@webkit.org [Fri, 8 Jan 2010 07:56:15 +0000 (07:56 +0000)]
Run the http and websocket tests after all other tests.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-07
Reviewed by Darin Adler.

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix for JSVALUE32 when ENABLE_JIT_OPTIMIZE* are disabled
loki@webkit.org [Fri, 8 Jan 2010 07:41:47 +0000 (07:41 +0000)]
Build fix for JSVALUE32 when ENABLE_JIT_OPTIMIZE* are disabled
https://bugs.webkit.org/show_bug.cgi?id=33311

Reviewed by Gavin Barraclough.

Move compileGetDirectOffset function to common part of JSVALUE32

* jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetDirectOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Mike Belshe <mbelshe@chromium.org>
eric@webkit.org [Fri, 8 Jan 2010 07:08:52 +0000 (07:08 +0000)]
2010-01-07  Mike Belshe  <mbelshe@chromium.org>

        Reviewed by Darin Adler.

        Fix Spdy casing to match style guide.

        https://bugs.webkit.org/show_bug.cgi?id=33326

        * platform/network/chromium/ResourceResponse.h:
        (WebCore::ResourceResponse::ResourceResponse):
        (WebCore::ResourceResponse::wasFetchedViaSPDY):
        (WebCore::ResourceResponse::setWasFetchedViaSPDY):
2010-01-07  Mike Belshe  <mbelshe@chromium.org>

        Reviewed by Darin Adler.

        Fix Spdy casing to match style guide.

        https://bugs.webkit.org/show_bug.cgi?id=33326

        * public/WebURLResponse.h:
        * src/WebURLResponse.cpp:
        (WebKit::WebURLResponse::wasFetchedViaSPDY):
        (WebKit::WebURLResponse::setWasFetchedViaSPDY):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Fri, 8 Jan 2010 06:54:26 +0000 (06:54 +0000)]
2010-01-07  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Maciej Stachowiak.

        Allow call sites to determine if ASSERT_* and LOG_* macros are operational
        https://bugs.webkit.org/show_bug.cgi?id=33020

        * wtf/Assertions.h: Set ASSERT_MSG_DISABLED, FATAL_DISABLED,
        ERROR_DISABLED, LOG_DISABLED to 1 if the compiler does not support
        variadic macros. Refactor for better readibility.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Fri, 8 Jan 2010 06:16:22 +0000 (06:16 +0000)]
2010-01-07  Daniel Bates  <dbates@rim.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=32987

        Added ENABLE_XHTMLMP flag. Disabled by default.

        * Configurations/FeatureDefines.xcconfig:
2010-01-07  Daniel Bates  <dbates@rim.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=32987

        Added ENABLE_XHTMLMP flag. Disabled by default.

        * features.gypi:
2010-01-07  Daniel Bates  <dbates@rim.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=32987

        Added ENABLE_XHTMLMP flag. Disabled by default.

        * Configurations/FeatureDefines.xcconfig:
2010-01-07  Daniel Bates  <dbates@rim.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=32987

        Added ENABLE_XHTMLMP flag. Disabled by default.

        * Configurations/FeatureDefines.xcconfig:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * config.h:
2010-01-07  Daniel Bates  <dbates@rim.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=32987

        Added ENABLE_XHTMLMP flag. Disabled by default.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Afonso R. Costa Jr. <afonso.costa@openbossa.org>
eric@webkit.org [Fri, 8 Jan 2010 05:54:45 +0000 (05:54 +0000)]
2010-01-07  Afonso R. Costa Jr.  <afonso.costa@openbossa.org>

        Reviewed by Darin Adler.

        As the bug https://bugs.webkit.org/show_bug.cgi?id=30034 is fixed,
        the zoomOrNot argument is unnecessary.

        * fast/dom/elementFromPoint-relative-to-viewport.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 8 Jan 2010 05:47:21 +0000 (05:47 +0000)]
2010-01-07  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Gavin Barraclough.

        [Symbian] Port ARM traditional JIT Trampolines to RVCT
        https://bugs.webkit.org/show_bug.cgi?id=30552

        Take the GCC implementation and mechanically convert
        it to RVCT syntax.

        Use 'bx rX' instead of 'mov pc, rX' when it is available.

        Developed in cooperation with Iain Campbell and Gabor Loki.

        * JavaScriptCore.pri: Extra step to generate RVCT stubs. The
        script generation intentionally executed all the time not just
        for RVCT targets.

        * create_rvct_stubs: Added. Perl script to expand precompiler macros
        for RVCT assembler - the template is defined in JITStubs.cpp.

        * jit/JITStubs.cpp:
        (JSC::ctiTrampoline):
        (JSC::ctiVMThrowTrampoline):
        (JSC::ctiOpThrowNotCaught):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Adam Barth <abarth@webkit.org>
eric@webkit.org [Fri, 8 Jan 2010 05:12:45 +0000 (05:12 +0000)]
2010-01-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Fix some test-webkitpy expectations
        https://bugs.webkit.org/show_bug.cgi?id=33345

        I forgot to change these when I added the CheckStyle step.

        * Scripts/webkitpy/commands/upload_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Adam Barth <abarth@webkit.org>
eric@webkit.org [Fri, 8 Jan 2010 04:58:10 +0000 (04:58 +0000)]
2010-01-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        webkit-patch edit-changelogs (or upload) will open blank files if run outside the root
        https://bugs.webkit.org/show_bug.cgi?id=33341

        Fix this by moving to the root directory before editing ChangeLogs.
        There is a related bug with CheckStyle.

        * Scripts/webkitpy/steps/checkstyle.py:
        * Scripts/webkitpy/steps/editchangelog.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRolled out http://trac.webkit.org/changeset/52778 due to rolling
slewis@apple.com [Fri, 8 Jan 2010 03:06:33 +0000 (03:06 +0000)]
Rolled out trac.webkit.org/changeset/52778 due to rolling
out http://trac.webkit.org/changeset/52756

* dom/Document.cpp:
(WebCore::Document::recalcStyle):
* editing/SelectionController.cpp:
(WebCore::SelectionController::layout):
(WebCore::SelectionController::recomputeCaretRect):
(WebCore::SelectionController::invalidateCaretRect):
(WebCore::SelectionController::paintCaret):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::attach):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::attach):
* page/Frame.cpp:
(WebCore::Frame::revealSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 8 Jan 2010 02:51:40 +0000 (02:51 +0000)]
2010-01-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Nikolas Zimmermann.

        media/unsupported-tracks.html is failing on Snow Leopard Release bot
        https://bugs.webkit.org/show_bug.cgi?id=32339

        This is a speculative fix.  I do not have a Snow Leopard machine to test on
        and I've not seen mention of someone being able to reproduce this locally.

        Prevent watchdog timer from firing after a test completes but before
        the next one starts, causing the error to appear in the next test.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (dump): Stop the watchdog before printing #EOF for the test content.
        We only need to care about the JavaScript of the test running too long
        or some hang in WebCore.  Any other failures will be covered by the calling
        script's own watchdog timer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 8 Jan 2010 02:22:18 +0000 (02:22 +0000)]
2010-01-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        commit-queue is stuck spinning due to exception
        https://bugs.webkit.org/show_bug.cgi?id=33358

        * Scripts/webkitpy/commands/queues.py:
         - Don't try to stringify the exception.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRollout http://trac.webkit.org/changeset/52756 due to a large performance regression.
slewis@apple.com [Fri, 8 Jan 2010 01:56:08 +0000 (01:56 +0000)]
Rollout trac.webkit.org/changeset/52756 due to a large performance regression.

WebCore:

* dom/Document.cpp:
(WebCore::Document::updateLayout):
* editing/SelectionController.cpp:
(WebCore::SelectionController::SelectionController):
(WebCore::SelectionController::setSelection):
* editing/SelectionController.h:
* page/Frame.cpp:
(WebCore::Frame::setCaretVisible):
(WebCore::Frame::selectionLayoutChanged):
(WebCore::Frame::caretBlinkTimerFired):
(WebCore::Frame::selectionBounds):
* page/FrameView.cpp:
(WebCore::FrameView::needsLayout):

LayoutTests:

* fast/forms/selection-layout-reentry-strange-case-expected.txt: Removed.
* fast/forms/selection-layout-reentry-strange-case.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago More build fix.
ap@apple.com [Fri, 8 Jan 2010 00:57:09 +0000 (00:57 +0000)]
    More build fix.

        * WebKitPrefix.h: Define JS_EXPORTCLASS here, as well (as empty).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a crash seen on the buildbots.
ggaren@apple.com [Fri, 8 Jan 2010 00:44:19 +0000 (00:44 +0000)]
Fix a crash seen on the buildbots.

Reviewed by Sam Weinig.

JavaScriptCore:

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init): Disable specific function tracking here,
instead of in WebCore, to ensure that the disabling happens before a
specific function can be registered.

WebCore:

* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase): Don't disable specific
function tracking here; it's too late, as some specific functions
may already have been tracked in the base class constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Mac build fix.
ap@apple.com [Fri, 8 Jan 2010 00:43:39 +0000 (00:43 +0000)]
    Mac build fix.

        * JavaScriptCore.exp: Export new JSGlobalData static data members.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 8 Jan 2010 00:36:10 +0000 (00:36 +0000)]
2010-01-07  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        SVGTextElement & friends need to implement svgAttributeChanged
        https://bugs.webkit.org/show_bug.cgi?id=33284

        Implement svgAttributeChanged() for SVGTextElement & SVGTRefElement. As <text> element contain children,
        childrenChanged() has to be implemented as well for SVGTextElement.

        Simplify SVGTransformable::parseTransformAttribute() code, clearing lists in the beginning
        and on error case, after parsing - previously the calling site had to take care of that.

        Tests: svg/dynamic-updates/SVGTRefElement-dom-href-attr.html
               svg/dynamic-updates/SVGTextElement-dom-transform-attr.html
               svg/dynamic-updates/SVGTextElement-svgdom-transform-prop.html

        * svg/SVGGradientElement.cpp:
        (WebCore::SVGGradientElement::parseMappedAttribute):
        * svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::parseMappedAttribute):
        * svg/SVGStyledTransformableElement.cpp:
        (WebCore::SVGStyledTransformableElement::parseMappedAttribute):
        * svg/SVGTRefElement.cpp:
        (WebCore::SVGTRefElement::svgAttributeChanged):
        * svg/SVGTRefElement.h:
        * svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::parseMappedAttribute):
        (WebCore::SVGTextElement::svgAttributeChanged):
        (WebCore::SVGTextElement::childrenChanged):
        * svg/SVGTextElement.h:
        * svg/SVGTextPositioningElement.cpp:
        (WebCore::SVGTextPositioningElement::svgAttributeChanged):
        * svg/SVGTextPositioningElement.h:
        * svg/SVGTransformable.cpp:
        (WebCore::SVGTransformable::parseTransformAttribute):
        * svg/SVGTransformable.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Mac build fix.
ap@apple.com [Fri, 8 Jan 2010 00:28:39 +0000 (00:28 +0000)]
    Mac build fix.

        * config.h: Define JS_EXPORTCLASS for JavaScriptGlue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPadding in popup menu gets lost with styled <select> in Windows.
bweinstein@apple.com [Fri, 8 Jan 2010 00:28:27 +0000 (00:28 +0000)]
Padding in popup menu gets lost with styled <select> in Windows.
Fixes <rdar://7285538>, and <http://webkit.org/b/33235>.

Reviewed by Adele Peterson.

[Win] Support padding-right on selects when webkit-appearance is off. Added a test
case for narrow selects with -webkit-appearance: none, and padding left and right to
show that both types of padding are honored.

* manual-tests/select-webkit-appearance-off-narrow-select.html: Added.
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::calculatePositionAndSize): Use clientPaddingRight instead of a hardcoded constant.
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::clientPaddingRight): If webkit-appearance is off, use padding-right instead of
the hardcoded constant.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Not reviewed, build fix.
ap@apple.com [Fri, 8 Jan 2010 00:24:15 +0000 (00:24 +0000)]
    Not reviewed, build fix.

        Windows buid fix - disable warning 4251 (class needs to have dll-interface to be used by
        clients of another class). WebCore doesn't use all methods of JSString, so
        we don't export all classes clients could theoretically access via JSString.

        * win/tools/vsprops/common.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Geoffrey Garen.
ap@apple.com [Fri, 8 Jan 2010 00:15:05 +0000 (00:15 +0000)]
    Reviewed by Geoffrey Garen.

        https://bugs.webkit.org/show_bug.cgi?id=33057
        REGRESSION(r49365): typeof(xhr.responseText) != "string" in Windows

        <rdar://problem/7296920> REGRESSION: WebKit fails to start PeaceKeeper benchmark

        Test: fast/js/webcore-string-comparison.html

        In r49365, some code was moved from JSString.cpp to JSString.h, and as a result, WebCore
        got a way to directly instantiate JSStrings over DLL borders. Since vftable for JSString was
        not exported, objects created from WebCore got a different vptr, and JavaScriptCore
        optimizations that relied on vptr of all JSString objects being equal failed.

        * config.h: Added a JS_EXPORTCLASS macro for exporting classes. It's currently the same as
        JS_EXPORTDATA, but it clearly needed a new name.

        * runtime/InitializeThreading.cpp:
        (JSC::initializeThreadingOnce):
        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::storeVPtrs):
        (JSC::JSGlobalData::JSGlobalData):
        (JSC::JSGlobalData::createNonDefault):
        (JSC::JSGlobalData::create):
        (JSC::JSGlobalData::sharedInstance):
        * runtime/JSGlobalData.h:
        Store vptrs just once, no need to repeatedly pick and copy them. This makes it possible to
        assert vptr correctness in object destructors (which don't have access to JSGlobalData,
        and even Heap::heap(this) will fail for fake objects created from storeVPtrs()).

        * runtime/JSArray.cpp: (JSC::JSArray::~JSArray): Assert that vptr is what we expect it to be.
        It's important to assert in destructor, because MSVC changes the vptr after constructor
        is invoked.
        * runtime/JSByteArray.cpp: (JSC::JSByteArray::~JSByteArray): Ditto.
        * runtime/JSByteArray.h: Ditto.
        * runtime/JSFunction.h: Ditto.
        * runtime/JSFunction.cpp: (JSC::JSFunction::~JSFunction): Ditto.

        * runtime/JSCell.h: (JSC::JSCell::setVPtr): Added a method to substitute vptr for another
        one.

        * runtime/JSString.h: Export JSString class together with its vftable, and tell other
        libraries tp import it. This is needed on platforms that have a separate JavaScriptCore
        dynamic library - and on Mac, we already did the export via JavaScriptCore.exp.
        (JSC::JSString::~JSString): Assert tha vptr is what we expect it to be.
        (JSC::fixupVPtr): Store a previously saved primary vftable pointer (do nothing if building
        JavaScriptCore itself).
        (JSC::jsSingleCharacterString): Call fixupVPtr in case this is call across DLL boundary.
        (JSC::jsSingleCharacterSubstring): Ditto.
        (JSC::jsNontrivialString): Ditto.
        (JSC::jsString): Ditto.
        (JSC::jsSubstring): Ditto.
        (JSC::jsOwnedString): Ditto.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export the new static
        JSGlobalData members that are used in WebCore via inline functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAccount for scale and current context position (as well as page
bfulgham@webkit.org [Thu, 7 Jan 2010 23:51:49 +0000 (23:51 +0000)]
Account for scale and current context position (as well as page
position) in the device context world transform passed to
plugins.  This is especially important for print surface DPI.
http://bugs.webkit.org/show_bug.cgi?id=32909.

Reviewed by Jon Honeycutt.

* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paintWindowedPluginIntoContext): Revise
  world context handling to include scaling and translation
  already set for the CTM.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't leak a JSStringRef within _accessibilityNotificationCallback.
mrowe@apple.com [Thu, 7 Jan 2010 23:44:51 +0000 (23:44 +0000)]
Don't leak a JSStringRef within _accessibilityNotificationCallback.

Reviewed by Jon Honeycutt.

* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(_accessibilityNotificationCallback): Have a JSRetainPtr adopt the JSStringRef so that it will be cleaned up
when it goes out of scope.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 7 Jan 2010 23:33:57 +0000 (23:33 +0000)]
2010-01-07  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Simon Fraser.

        REGRESSION (r48075): Clicking and dragging in a widget's text field doesn't create a selection; drags widget instead ( Translation, Weather, Ski Report )
        https://bugs.webkit.org/show_bug.cgi?id=33348
        <rdar://problem/7310616>

        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]): We only want to
        handle file: URLs for the user stylesheet now, so special-case the
        DashboardClient's funky user stylesheet URL by mapping it to the
        equivalent file URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 7 Jan 2010 22:55:01 +0000 (22:55 +0000)]
2010-01-07  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Generate V8 bindings header declarations for named and indexed accessors.

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
        * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
        * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
        * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
        * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
        * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
        * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
        * bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
        * bindings/v8/custom/V8NamedNodeMapCustom.cpp:
        * bindings/v8/custom/V8NodeListCustom.cpp:
        * bindings/v8/custom/V8StorageCustom.cpp:
        * bindings/v8/custom/V8StyleSheetListCustom.cpp:
        * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBetter build fix: use 'this->structure()', since 'structure' is a
ggaren@apple.com [Thu, 7 Jan 2010 22:36:05 +0000 (22:36 +0000)]
Better build fix: use 'this->structure()', since 'structure' is a
PassRefPtr, and therefore null.

* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix: avoid a name conflict by using the local 'structure' instead
ggaren@apple.com [Thu, 7 Jan 2010 22:27:20 +0000 (22:27 +0000)]
Build fix: avoid a name conflict by using the local 'structure' instead
of the member 'structure()'.

* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 7 Jan 2010 22:13:31 +0000 (22:13 +0000)]
2010-01-07  Simon Fraser  <simon.fraser@apple.com>

        Build fix.

        Add RenderEmbeddedObject.h/cpp to all the build systems.

        * Android.mk:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCoreSources.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 7 Jan 2010 22:07:36 +0000 (22:07 +0000)]
2010-01-07  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Safari memory usage skyrockets using new Google AdWords interface
        https://bugs.webkit.org/show_bug.cgi?id=33343

        The memory use was caused by the global object creating too many structures
        as it thrashed between different specific functions.

        * runtime/Structure.cpp:
        (JSC::Structure::Structure):
        (JSC::Structure::addPropertyTransition):
        (JSC::Structure::changePrototypeTransition):
        (JSC::Structure::despecifyFunctionTransition):
        (JSC::Structure::addAnonymousSlotsTransition):
        (JSC::Structure::getterSetterTransition):
        (JSC::Structure::toDictionaryTransition):
        (JSC::Structure::addPropertyWithoutTransition):
        (JSC::Structure::despecifyAllFunctions):
        * runtime/Structure.h:
        (JSC::Structure::disableSpecificFunctionTracking): Track a thrash count
        for specific functions. Disable specific function tracking once the
        thrash count has been hit.
2010-01-07  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Safari memory usage skyrockets using new Google AdWords interface
        https://bugs.webkit.org/show_bug.cgi?id=33343

        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::JSDOMWindowBase): Disabled specific function
        tracking for the window object, since there's no way to do direct
        method calls on the window object; they all go through the window shell.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 7 Jan 2010 21:57:12 +0000 (21:57 +0000)]
2010-01-07  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Kevin Decker, Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=33338
        Create a renderer for <object> and <embed>

        Add RenderEmbeddedObject, which derives from RenderPartObject, and is created for <object> and <embed>.
        Instances of RenderPartObject are now only allocated for iframes.

        Move object/embed-related code from RenderPartObject to RenderEmbeddedObject.

        * WebCore.xcodeproj/project.pbxproj:
        Add RenderEmbeddedObject.h/cpp

        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::createRenderer): Create a RenderEmbeddedObject.
        (WebCore::HTMLEmbedElement::updateWidget): Use toRenderEmbeddedObject()

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::createRenderer): Make a RenderEmbeddedObject for the plugin-proxy case.
        (WebCore::HTMLMediaElement::finishParsingChildren): Use toRenderEmbeddedObject() in the plugin-proxy code.

        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::createRenderer): Make a RenderEmbeddedObject
        (WebCore::HTMLObjectElement::updateWidget): Use toRenderEmbeddedObject()

        * page/FrameView.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::addWidgetToUpdate):
        (WebCore::FrameView::removeWidgetToUpdate):
        (WebCore::FrameView::updateWidgets):
        Objects in the m_widgetUpdateSet are only ever RenderEmbeddedObjects.

        * rendering/RenderEmbeddedObject.cpp: Added.
        * rendering/RenderEmbeddedObject.h: Added.
        Most of the code moved from RenderPartObject.

        * rendering/RenderObject.h:
        (WebCore::RenderObject::isEmbeddedObject): New method.

        * rendering/RenderPart.cpp:
        (WebCore::RenderPart::RenderPart): Initialize m_hasFallbackContent here, rather than in the derived classes.
        * rendering/RenderPart.h: Comments.

        * rendering/RenderPartObject.h:
        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::RenderPartObject): Clean up, code moved to base class, and removed object/embed-specific code.
        (WebCore::RenderPartObject::layout): Removed object/embed-specific code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 7 Jan 2010 21:47:46 +0000 (21:47 +0000)]
2010-01-07  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=33338
        Create a renderer for <object> and <embed>

        First part of this change: renderPartObject->updateWidget() is a no-op for iframe elements,
        so we don't need to call it here, and can thus remove the attach() override entirely.

        * html/HTMLIFrameElement.cpp:
        * html/HTMLIFrameElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-07 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 7 Jan 2010 21:36:58 +0000 (21:36 +0000)]
2009-01-07  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Migrate to canvas-based text viewer / editor that scales.

        https://bugs.webkit.org/show_bug.cgi?id=33001

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/JavaScriptHighlighterScheme.js: Added.
        (WebInspector.JavaScriptHighlighterScheme):
        * inspector/front-end/KeyboardShortcut.js:
        * inspector/front-end/TextEditor.js: Added.
        (WebInspector.TextEditor):
        (WebInspector.TextSelectionModel):
        (WebInspector.TextCursor):
        * inspector/front-end/TextEditorHighlighter.js: Added.
        (WebInspector.TextEditorHighlighter):
        (WebInspector.TextEditorHighlighter.prototype.highlight):
        (WebInspector.TextEditorHighlighter.prototype._lex):
        * inspector/front-end/TextEditorModel.js: Added.
        (WebInspector.TextRange):
        (WebInspector.TextRange.prototype.clone):
        (WebInspector.TextEditorModel):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Christian Sejersen <christian.webkit@gmail.com>
eric@webkit.org [Thu, 7 Jan 2010 21:32:13 +0000 (21:32 +0000)]
2010-01-07  Christian Sejersen  <christian.webkit@gmail.com>

        Reviewed by Darin Adler.

        document.title does not replace or remove space characters
        https://bugs.webkit.org/show_bug.cgi?id=27032

        * fast/dom/Document/document-title-get-expected.txt: Added.
        * fast/dom/Document/document-title-get.html: Added.
        * fast/dom/Document/script-tests/document-title-get.js: Added.
2010-01-07  Christian Sejersen  <christian.webkit@gmail.com>

        Reviewed by Darin Adler.

        document.title does not replace or remove space characters
        https://bugs.webkit.org/show_bug.cgi?id=27032

        Test: fast/dom/Document/document-title-get.html

        * dom/Document.cpp:
        (WebCore::Document::Document):
        Initialization of m_rawTitle
        (WebCore::canonicalizedTitle):
        Moved from DocumentLoader.cpp with minor edits
        (WebCore::Document::updateTitle):
        Ensures the title is canonicalized
        (WebCore::Document::setTitle):
        Uses m_rawTitle instaed of m_title
        (WebCore::Document::removeTitle):
        Uses m_rawTitle instead of m_title

        * dom/Document.h:
        Added m_rawTitle that stores the passed in title, m_title now stores the
        canonicalized title

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::setTitle):
        The title passed in is now canonicalized in Document.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Yuzo Fujishima <yuzo@google.com>
eric@webkit.org [Thu, 7 Jan 2010 20:58:14 +0000 (20:58 +0000)]
2010-01-07  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Darin Adler.

        Allow leading/trailing space for CSS nth-*() and lang().
        https://bugs.webkit.org/show_bug.cgi?id=17248

        For pseudo-classes :nth-*() and :lang(), space must be allowed after '(' and before ')'.
        See the bug comments for why we don't allow space at other places.

        * fast/css/css3-space-in-nth-and-lang.html: Added.
        * platform/mac/fast/css/css3-space-in-nth-and-lang-expected.txt: Added.
2010-01-07  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Darin Adler.

        Allow leading/trailing space for CSS nth-*() and lang().
        https://bugs.webkit.org/show_bug.cgi?id=17248

        For pseudo-classes :nth-*() and :lang(), space must be allowed after '(' and before ')'.
        See the bug comments for why we don't allow space at other places.

        * css/CSSGrammar.y:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Simon Fraser.
kdecker@apple.com [Thu, 7 Jan 2010 20:26:04 +0000 (20:26 +0000)]
    Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=33331
        (WebHostedNetscapePluginView should pass acceleratedCompositingEnabled bool to NetscapePluginHostManager when instantiating plug-ins)

        * Plugins/Hosted/NetscapePluginHostManager.h: Modify method signature for instantiatePlugin to include acceleratedCompositingEnabled bool.
        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::instantiatePlugin):
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView createPlugin]): Pass accelerated compositing status to NetscapePluginHostManage

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: contentEditable DIVs are not AX accessible
cfleizach@apple.com [Thu, 7 Jan 2010 20:24:53 +0000 (20:24 +0000)]
AX: contentEditable DIVs are not AX accessible
https://bugs.webkit.org/show_bug.cgi?id=33325

Reviewed by Beth Dakin.

WebCore:

Test: accessibility/contenteditable-hidden-div.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::canSetValueAttribute):

LayoutTests:

* accessibility/contenteditable-hidden-div-expected.txt: Added.
* accessibility/contenteditable-hidden-div.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 7 Jan 2010 20:20:37 +0000 (20:20 +0000)]
2010-01-07  Eric Carlson  <eric.carlson@apple.com>

        Unreviewed, build fix.

        Skip LayoutTests/http/tests/media/video-error-abort.html

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. roll-out r52917, r52932 and r52934.
ossy@webkit.org [Thu, 7 Jan 2010 20:18:23 +0000 (20:18 +0000)]
Unreviewed. roll-out r52917, r52932 and r52934.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 7 Jan 2010 20:08:19 +0000 (20:08 +0000)]
2010-01-07  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Resolve merge conflict.

        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::setContextDebugId):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 7 Jan 2010 20:00:38 +0000 (20:00 +0000)]
2010-01-07  Adam Barth  <abarth@webkit.org>

        No review, rolling out r52847.
        http://trac.webkit.org/changeset/52847
        https://bugs.webkit.org/show_bug.cgi?id=33232

        Might have caused a perf regression.  I'm rolling this out to see if it
        heals the perf bot.

        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::ScriptController):
        (WebCore::ScriptController::~ScriptController):
        (WebCore::ScriptController::updateSecurityOrigin):
        (WebCore::ScriptController::evaluateInIsolatedWorld):
        (WebCore::ScriptController::haveInterpreter):
        (WebCore::ScriptController::clearWindowShell):
        (WebCore::ScriptController::updateDocument):
        * bindings/v8/ScriptController.h:
        * bindings/v8/V8DOMWindowShell.cpp:
        * bindings/v8/V8DOMWindowShell.h:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::instantiateV8Object):
        (WebCore::V8DOMWrapper::convertDocumentToV8Object):
        (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
        * bindings/v8/V8IsolatedContext.cpp:
        (WebCore::V8IsolatedContext::V8IsolatedContext):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::V8Proxy):
        (WebCore::V8Proxy::~V8Proxy):
        (WebCore::V8Proxy::handleOutOfMemory):
        (WebCore::V8Proxy::evaluateInIsolatedWorld):
        (WebCore::V8Proxy::setInjectedScriptContextDebugId):
        (WebCore::V8Proxy::clearForClose):
        (WebCore::V8Proxy::clearForNavigation):
        (WebCore::V8Proxy::context):
        (WebCore::V8Proxy::mainWorldContext):
        (WebCore::V8Proxy::currentContext):
        (WebCore::V8Proxy::setContextDebugId):
        * bindings/v8/V8Proxy.h:
        (WebCore::V8Proxy::windowShell):
        * bindings/v8/WorldContextHandle.cpp:
        (WebCore::WorldContextHandle::adjustedContext):
2010-01-07  Adam Barth  <abarth@webkit.org>

        No review, rolling out r52847.
        http://trac.webkit.org/changeset/52847
        https://bugs.webkit.org/show_bug.cgi?id=33232

        Might have caused a perf regression.

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::detachedFromParent3):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed trivial fix.
ossy@webkit.org [Thu, 7 Jan 2010 19:45:58 +0000 (19:45 +0000)]
Unreviewed trivial fix.

LayoutTests/media/video-error-abort.html moved to LayoutTests/http/tests/media/video-error-abort.html
by r52923, but wasn't renamed in skiplist by this commit.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 7 Jan 2010 19:41:23 +0000 (19:41 +0000)]
2010-01-07  Eric Carlson  <eric.carlson@apple.com>

        Unreviewed, build fix.

        Add executable bit to video-throttled-load cgi.

        * http/tests/media/video-throttled-load.cgi: Added property svn:executable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Fix the Mac bots. Why is there no HTTPD PID file?
ossy@webkit.org [Thu, 7 Jan 2010 19:25:25 +0000 (19:25 +0000)]
Unreviewed. Fix the Mac bots. Why is there no HTTPD PID file?

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-07
* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix
mitz@apple.com [Thu, 7 Jan 2010 18:48:09 +0000 (18:48 +0000)]
Build fix

* WebCore.xcodeproj/project.pbxproj: Made TypesettingFeatures.h private.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoStore HTTPD PID in a variable to fix warnings if for some reason the pidfile gets...
ossy@webkit.org [Thu, 7 Jan 2010 18:33:00 +0000 (18:33 +0000)]
Store HTTPD PID in a variable to fix warnings if for some reason the pidfile gets deleted before httpd terminates.
This should fix the occasional warnings for uninitialized values on the Mac bots.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-07
Reviewed by Alexey Proskuryakov.

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdded Font::typesettingFeatures() and deployed it
mitz@apple.com [Thu, 7 Jan 2010 18:28:04 +0000 (18:28 +0000)]
Added Font::typesettingFeatures() and deployed it

Reviewed by Sam Weinig.

No change in funcitonality

* WebCore.xcodeproj/project.pbxproj: Added TypesettingFeatures.h.
* platform/graphics/Font.h:
(WebCore::Font::typesettingFeatures): Added. Determines the typesetting
    features from the text redndering mode.
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::canUseGlyphCache): Use typesettingFeatures().
* platform/graphics/SimpleFontData.h:
* platform/graphics/TypesettingFeatures.h: Added.
* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::disableLigatures): Take TypesettingFeatures instead of
    TextRenderingMode.
(WebCore::initializeATSUStyle): Ditto.
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI):
    Use typesettingFeatures().
* platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
    Ditto.
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::getCFStringAttributes): Take
    TypesettingFeatures instead of TextRenderingMode.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak): Use TypesettingFeatures().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 7 Jan 2010 18:08:42 +0000 (18:08 +0000)]
2010-01-07  Dimitri Glazkov  <dglazkov@chromium.org>

        No review, rolling out r52900.
        http://trac.webkit.org/changeset/52900
        https://bugs.webkit.org/show_bug.cgi?id=30055

        Broke over 30 SVG pixel tests.

        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Kenneth Rohde Christiansen.
hausmann@webkit.org [Thu, 7 Jan 2010 17:45:59 +0000 (17:45 +0000)]
Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] The library version number of the first package release is 4.7.0.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Allow the application to override online/offline network status
hausmann@webkit.org [Thu, 7 Jan 2010 17:29:22 +0000 (17:29 +0000)]
[Qt] Allow the application to override online/offline network status
https://bugs.webkit.org/show_bug.cgi?id=32684

Patch by Yael Aharon <yael.aharon@nokia.com> on 2010-01-07
Reviewed by Kenneth Rohde Christiansen.

WebCore:

Added API to NetworkStateNotifier for forcing network status.

* platform/network/NetworkStateNotifier.h:
* platform/network/qt/NetworkStateNotifierPrivate.h:
* platform/network/qt/NetworkStateNotifierQt.cpp:
(WebCore::NetworkStateNotifierPrivate::NetworkStateNotifierPrivate):
(WebCore::NetworkStateNotifierPrivate::onlineStateChanged):
(WebCore::NetworkStateNotifierPrivate::networkAccessPermissionChanged):
(WebCore::NetworkStateNotifier::updateState):
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
(WebCore::NetworkStateNotifier::setNetworkAccessAllowed):

WebKit/qt:

Add a setting so that applications can overide the network status.
Applications that use this setting still need to block network access
through QNAM.

* Api/qwebsettings.cpp:
(qt_networkAccessAllowed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed typo fix.
ossy@webkit.org [Thu, 7 Jan 2010 17:26:24 +0000 (17:26 +0000)]
Unreviewed typo fix.

* platform/gtk/Skipped: missing "l" suffix added to fast/repaint/subtree-layoutstate-transform.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoprospective bearer management build fix to get the include path correct
hausmann@webkit.org [Thu, 7 Jan 2010 17:14:42 +0000 (17:14 +0000)]
prospective bearer management build fix to get the include path correct

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 7 Jan 2010 16:38:03 +0000 (16:38 +0000)]
2010-01-07  Eric Carlson  <eric.carlson@apple.com>

        Unreviewed, build fix.

        https://bugs.webkit.org/show_bug.cgi?id=33323
        Skip new test on Tiger for now.

        * platform/mac-tiger/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Enable JIT in debug mode on win32 after r51141 fixed the crashes.
ossy@webkit.org [Thu, 7 Jan 2010 16:22:05 +0000 (16:22 +0000)]
[Qt] Enable JIT in debug mode on win32 after r51141 fixed the crashes.

Reviewed by Simon Hausmann.

* JavaScriptCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 7 Jan 2010 16:02:50 +0000 (16:02 +0000)]
2010-01-07  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=33272
        'abort' event still fired as a progress event

        rdar://6710625
        Test media/video-error-abort.html doesn't work

        Test: http/tests/media/video-error-abort.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::scheduleEvent): Incorporate code from enqueueEvent.
        (WebCore::HTMLMediaElement::loadInternal): Fix 'abort' event firing logic missed
        in https://bugs.webkit.org/show_bug.cgi?id=30513. Change order of initialization
        to match spec wording.
        * html/HTMLMediaElement.h: Remove enqueueEvent prototype.

2010-01-07  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=33272
        'abort' event still fired as a progress event

        rdar://6710625
        Test media/video-error-abort.html doesn't work

        * http/tests/media/video-error-abort-expected.txt: Copied from LayoutTests/media/video-error-abort-expected.txt.
        * http/tests/media/video-error-abort.html: Copied from LayoutTests/media/video-error-abort.html.
            Modified to run with slow loading cgi, add test to ensure that 'abort' event is not a
            progress event.
        * media/video-error-abort-expected.txt: Removed.
        * media/video-error-abort.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Kim Grönholm <kim.gronholm@nomovok.com>
eric@webkit.org [Thu, 7 Jan 2010 14:37:26 +0000 (14:37 +0000)]
2010-01-07  Kim Grönholm  <kim.gronholm@nomovok.com>

        Reviewed by Antti Koivisto.

        Wrong state and TouchLists in TouchEvents
        https://bugs.webkit.org/show_bug.cgi?id=32878

        Touch event tests changed to match the API and semantics of iPhone and
        Android. Each new touch point press dispatches a touchstart event with
        the pressed touch point(s) in the changedTouches list, and a release
        dispatches a touchend event with the released touch point(s) in
        changedTouches. Moved points dispatch a touchmove event, with the moved
        points in changedTouches. Old behaviour emitted only one touchstart when
        the first point was pressed and one touchend when the last point was
        released, and any events in between were touchmoves. New presses or
        releases could only be detected by comparing the lists touches and
        changedTouches.

        * fast/events/basic-touch-events-expected.txt:
        * fast/events/script-tests/basic-touch-events.js:
        (singleTouchSequence):
        (multiTouchSequence):
2010-01-07  Kim Grönholm  <kim.gronholm@nomovok.com>

        Reviewed by Antti Koivisto.

        Wrong state and TouchLists in TouchEvents
        https://bugs.webkit.org/show_bug.cgi?id=32878

        Touch events changed to match the API and semantics of iPhone and
        Android. Each new touch point press dispatches a touchstart event with
        the pressed touch point(s) in the changedTouches list, and a release
        dispatches a touchend event with the released touch point(s) in
        changedTouches. Moved points dispatch a touchmove event, with the moved
        points in changedTouches. Old behaviour emitted only one touchstart when
        the first point was pressed and one touchend when the last point was
        released, and any events in between were touchmoves. New presses or
        releases could only be detected by comparing the lists touches and
        changedTouches.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleTouchEvent):
        * page/EventHandler.h:
2010-01-07  Kim Grönholm  <kim.gronholm@nomovok.com>

        Reviewed by Antti Koivisto.

        Wrong state and TouchLists in TouchEvents
        https://bugs.webkit.org/show_bug.cgi?id=32878

        * DumpRenderTree/qt/EventSenderQt.cpp:
        (EventSender::touchStart):
        (EventSender::touchEnd):
        (EventSender::clearTouchPoints):
        * DumpRenderTree/qt/EventSenderQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 7 Jan 2010 13:43:28 +0000 (13:43 +0000)]
2010-01-07  Kent Tamura  <tkent@chromium.org>

        Reviewed by Maciej Stachowiak.

        Remove COM code generation stuff.
        https://bugs.webkit.org/show_bug.cgi?id=32854

        Remove the followings:
        - CodeGeenratorCOM.pm, COM code generator,
        - "#if !defined(LANGUAGE_COM) || !LANGUAGE_COM" in IDL files, and
        - UUID attributes in IDL files.

        * bindings/scripts/CodeGeneratorCOM.pm: Removed.
        * css/CSSCharsetRule.idl:
        * css/CSSFontFaceRule.idl:
        * css/CSSImportRule.idl:
        * css/CSSMediaRule.idl:
        * css/CSSPageRule.idl:
        * css/CSSPrimitiveValue.idl:
        * css/CSSRule.idl:
        * css/CSSRuleList.idl:
        * css/CSSStyleDeclaration.idl:
        * css/CSSStyleRule.idl:
        * css/CSSStyleSheet.idl:
        * css/CSSUnknownRule.idl:
        * css/CSSValue.idl:
        * css/CSSValueList.idl:
        * css/Counter.idl:
        * css/MediaList.idl:
        * css/RGBColor.idl:
        * css/Rect.idl:
        * css/StyleSheet.idl:
        * css/StyleSheetList.idl:
        * css/WebKitCSSKeyframeRule.idl:
        * css/WebKitCSSKeyframesRule.idl:
        * css/WebKitCSSTransformValue.idl:
        * dom/Attr.idl:
        * dom/CDATASection.idl:
        * dom/CharacterData.idl:
        * dom/Comment.idl:
        * dom/DOMImplementation.idl:
        * dom/Document.idl:
        * dom/DocumentFragment.idl:
        * dom/DocumentType.idl:
        * dom/Element.idl:
        * dom/Entity.idl:
        * dom/EntityReference.idl:
        * dom/Event.idl:
        * dom/EventListener.idl:
        * dom/EventTarget.idl:
        * dom/NamedNodeMap.idl:
        * dom/Node.idl:
        * dom/NodeList.idl:
        * dom/Notation.idl:
        * dom/ProcessingInstruction.idl:
        * dom/Text.idl:
        * html/HTMLAnchorElement.idl:
        * html/HTMLAppletElement.idl:
        * html/HTMLAreaElement.idl:
        * html/HTMLBRElement.idl:
        * html/HTMLBaseElement.idl:
        * html/HTMLBaseFontElement.idl:
        * html/HTMLBlockquoteElement.idl:
        * html/HTMLBodyElement.idl:
        * html/HTMLButtonElement.idl:
        * html/HTMLCanvasElement.idl:
        * html/HTMLCollection.idl:
        * html/HTMLDListElement.idl:
        * html/HTMLDirectoryElement.idl:
        * html/HTMLDivElement.idl:
        * html/HTMLDocument.idl:
        * html/HTMLElement.idl:
        * html/HTMLEmbedElement.idl:
        * html/HTMLFieldSetElement.idl:
        * html/HTMLFontElement.idl:
        * html/HTMLFormElement.idl:
        * html/HTMLFrameElement.idl:
        * html/HTMLFrameSetElement.idl:
        * html/HTMLHRElement.idl:
        * html/HTMLHeadElement.idl:
        * html/HTMLHeadingElement.idl:
        * html/HTMLHtmlElement.idl:
        * html/HTMLIFrameElement.idl:
        * html/HTMLImageElement.idl:
        * html/HTMLInputElement.idl:
        * html/HTMLIsIndexElement.idl:
        * html/HTMLLIElement.idl:
        * html/HTMLLabelElement.idl:
        * html/HTMLLegendElement.idl:
        * html/HTMLLinkElement.idl:
        * html/HTMLMapElement.idl:
        * html/HTMLMarqueeElement.idl:
        * html/HTMLMenuElement.idl:
        * html/HTMLMetaElement.idl:
        * html/HTMLModElement.idl:
        * html/HTMLOListElement.idl:
        * html/HTMLObjectElement.idl:
        * html/HTMLOptGroupElement.idl:
        * html/HTMLOptionElement.idl:
        * html/HTMLOptionsCollection.idl:
        * html/HTMLParagraphElement.idl:
        * html/HTMLParamElement.idl:
        * html/HTMLPreElement.idl:
        * html/HTMLQuoteElement.idl:
        * html/HTMLScriptElement.idl:
        * html/HTMLSelectElement.idl:
        * html/HTMLStyleElement.idl:
        * html/HTMLTableCaptionElement.idl:
        * html/HTMLTableCellElement.idl:
        * html/HTMLTableColElement.idl:
        * html/HTMLTableElement.idl:
        * html/HTMLTableRowElement.idl:
        * html/HTMLTableSectionElement.idl:
        * html/HTMLTextAreaElement.idl:
        * html/HTMLTitleElement.idl:
        * html/HTMLUListElement.idl:

2010-01-07  Kent Tamura  <tkent@chromium.org>

        Reviewed by Maciej Stachowiak.

        Remove COM code generation files.
        https://bugs.webkit.org/show_bug.cgi?id=32854

        * WebKit.vcproj/DerivedSources.make: Removed.
        * WebKit.vcproj/build-generated-files.sh: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix for Qt on Mac OS X
vestbo@webkit.org [Thu, 7 Jan 2010 13:15:04 +0000 (13:15 +0000)]
Unreviewed build fix for Qt on Mac OS X

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAndroid requires ability to increase layout delay
steveblock@google.com [Thu, 7 Jan 2010 12:16:25 +0000 (12:16 +0000)]
Android requires ability to increase layout delay

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Zoltan Horvath <zoltan@webkit.org>
zoltan@webkit.org [Thu, 7 Jan 2010 12:13:53 +0000 (12:13 +0000)]
2010-01-07  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Holger Freyther.

        [Mac] Build fix when FAST_MALLOC_MATCH_VALIDATION=1
        https://bugs.webkit.org/show_bug.cgi?id=33312

        Using of operator += cause compile error on Mac, so it is changed to
        "= static_cast<AllocAlignmentInteger*>(old_ptr) + 1".

        * wtf/FastMalloc.cpp:
        (WTF::TCMallocStats::realloc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReworked r52853 after r52876 rolled it out.
ossy@webkit.org [Thu, 7 Jan 2010 12:12:32 +0000 (12:12 +0000)]
Reworked r52853 after r52876 rolled it out.
Chomp the pid variable before passing it to kill and read the contents of
the pidfile in a platform independent manner.
First pach of https://bugs.webkit.org/show_bug.cgi?id=33153.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-07
Reviewed by Kenneth Rohde Christiansen.

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Chris Jerdonek <chris.jerdonek@gmail.com>
eric@webkit.org [Thu, 7 Jan 2010 11:50:44 +0000 (11:50 +0000)]
2010-01-07  Chris Jerdonek  <chris.jerdonek@gmail.com>

        Reviewed by Adam Barth.

        Created a module that runs the style package unit tests.

        https://bugs.webkit.org/show_bug.cgi?id=32973

        * Scripts/test-webkitpy:
        * Scripts/webkitpy/style/unittests.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Thu, 7 Jan 2010 11:35:40 +0000 (11:35 +0000)]
2010-01-07  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Some IDL files lack "," separators for extended attributes.
        https://bugs.webkit.org/show_bug.cgi?id=33190

        To find such mistakes, IDLParser.pm rejects whitespace characters in
        extended attribute names.

        * bindings/scripts/IDLParser.pm:
          parseExtendedAttributes rejects whitespace in a name.
        * css/WebKitCSSTransformValue.idl: Add missing ",".
        * dom/EventTarget.idl: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] need an API to suspend and resume active Javascript DOM objects.
hausmann@webkit.org [Thu, 7 Jan 2010 11:24:15 +0000 (11:24 +0000)]
[Qt] need an API to suspend and resume active Javascript DOM objects.
https://bugs.webkit.org/show_bug.cgi?id=31673

Patch by Yongjun Zhang  <yongjun.zhang@nokia.com>, Laszlo Gombos <laszlo.1.gombos@nokia.com> on 2010-01-07
Reviewed by Simon Hausmann.

Add suspend and resume DOM objects private API to QWebFrame.

* Api/qwebframe.cpp:
(qt_suspendActiveDOMObjects):
(qt_resumeActiveDOMObjects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Thu, 7 Jan 2010 10:52:04 +0000 (10:52 +0000)]
2010-01-07  Kent Tamura  <tkent@chromium.org>

        Reviewed by Adam Barth.

        Fix an issue that CodeGeneratorV8.pm doesnt handle HasIndexGetter of
        WebKitCSSTransformValue.idl correctly.
        https://bugs.webkit.org/show_bug.cgi?id=33193

        CodeGeneratorV8.pm doesn't handle inheritance very well and it
        tried to refer v8WebKitCSSTransformValueIndexedPropertyGetter(),
        which does not exist. Because WebKitCSSTransformValue inherits
        CSSValueList and CSSValueList already has HadIndexGetter, we don't
        need to do anything for WebKitCSSTransformValue about HasIndexGetter.

        * bindings/scripts/CodeGeneratorV8.pm:
          Reset $hasGetter for WebKitCSSTransformValue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 7 Jan 2010 10:22:40 +0000 (10:22 +0000)]
2010-01-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        Don't print a redundant message when confirming a diff
        https://bugs.webkit.org/show_bug.cgi?id=33315

        Instead of saying "ERROR: User declined" we should just exit because
        the use knows they just declined!

        * Scripts/webkitpy/steps/confirmdiff.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Zoltan Horvath <zoltan@webkit.org>
zoltan@webkit.org [Thu, 7 Jan 2010 10:19:38 +0000 (10:19 +0000)]
2010-01-07  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Holger Freyther.

        [Qt] Build fix when FAST_MALLOC_MATCH_VALIDATION=1
        https://bugs.webkit.org/show_bug.cgi?id=33312

        Remove pByte (committed in r42344 from #20422), because pByte doesn't
        exist and it is unnecessary.

        * wtf/FastMalloc.cpp:
        (WTF::TCMallocStats::realloc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 7 Jan 2010 10:12:54 +0000 (10:12 +0000)]
2010-01-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        Check style before uploading a patch
        https://bugs.webkit.org/show_bug.cgi?id=33314

        * Scripts/webkitpy/commands/upload.py:
        * Scripts/webkitpy/steps/checkstyle.py:
        * Scripts/webkitpy/steps/options.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 7 Jan 2010 09:51:01 +0000 (09:51 +0000)]
2010-01-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        Add prepare and post to webkit-patch main help
        https://bugs.webkit.org/show_bug.cgi?id=33313

        * Scripts/webkitpy/commands/upload.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 7 Jan 2010 08:57:10 +0000 (08:57 +0000)]
2010-01-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
        https://bugs.webkit.org/show_bug.cgi?id=33290

        Add the Chromium builders to our list of core builders and test that our regexps work.
        I also updated our regexp testing to make sure we cover all known builders at build.webkit.org.

        * Scripts/webkitpy/buildbot.py:
        * Scripts/webkitpy/buildbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 7 Jan 2010 08:49:25 +0000 (08:49 +0000)]
2010-01-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        bugzilla-tool needs a new name
        https://bugs.webkit.org/show_bug.cgi?id=28459

        Rename bugzilla-tool to webkit-patch.  Also, rename some commands to
        make more sense with the new name.

        * Scripts/bugzilla-tool: Removed.
        * Scripts/webkit-patch: Added.
        * Scripts/webkit-tools-completion.sh:
        * Scripts/webkitpy/bugzilla_unittest.py:
        * Scripts/webkitpy/commands/download.py:
        * Scripts/webkitpy/commands/download_unittest.py:
        * Scripts/webkitpy/commands/early_warning_system.py:
        * Scripts/webkitpy/commands/queries.py:
        * Scripts/webkitpy/commands/queues.py:
        * Scripts/webkitpy/commands/queues_unittest.py:
        * Scripts/webkitpy/commands/upload.py:
        * Scripts/webkitpy/commands/upload_unittest.py:
        * Scripts/webkitpy/queueengine.py:
        * Scripts/webkitpy/steps/completerollout.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-01-07 Chris Jerdonek <chris.jerdonek@gmail.com>
eric@webkit.org [Thu, 7 Jan 2010 08:36:52 +0000 (08:36 +0000)]
2010-01-07  Chris Jerdonek  <chris.jerdonek@gmail.com>

        Reviewed by Eric Seidel.

        Moved style-related modules to webkitpy.style sub-package.

        https://bugs.webkit.org/show_bug.cgi?id=32971

        * Scripts/check-webkit-style:
          - Updated import statement.

        * Scripts/test-webkitpy:
          - Updated import statements.

        * Scripts/webkitpy/cpp_style.py: Removed.
          - Moved to webkitpy/style.

        * Scripts/webkitpy/cpp_style_unittest.py: Removed.
          - Moved to webkitpy/style.

        * Scripts/webkitpy/style.py: Removed.
          - Moved to webkitpy/style/checker.py.

        * Scripts/webkitpy/style/__init__.py: Added.
          - Added containing webkitpy directory to package search path.

        * Scripts/webkitpy/style/checker.py: Copied from Scripts/webkitpy/style.py.
        * Scripts/webkitpy/style/checker_unittest.py: Copied from Scripts/webkitpy/style_unittest.py.
          - Updated import statement.

        * Scripts/webkitpy/style/cpp_style.py: Copied from Scripts/webkitpy/cpp_style.py.
        * Scripts/webkitpy/style/cpp_style_unittest.py: Copied from Scripts/webkitpy/cpp_style_unittest.py.
          - Update import statement.

        * Scripts/webkitpy/style/text_style.py: Copied from Scripts/webkitpy/text_style.py.
        * Scripts/webkitpy/style/text_style_unittest.py: Copied from Scripts/webkitpy/text_style_unittest.py.
        * Scripts/webkitpy/style_unittest.py: Removed.
          - Moved to webkitpy/style/checker_unittest.py.

        * Scripts/webkitpy/text_style.py: Removed.
          - Moved to webkitpy/style.

        * Scripts/webkitpy/text_style_unittest.py: Removed.
          - Moved to webkitpy/style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52906 268f45cc-cd09-0410-ab3c-d52691b4dbfc