WebKit-https.git
7 years ago[Qt] Skip new failing tests.
rgabor@webkit.org [Wed, 16 Nov 2011 14:54:01 +0000 (14:54 +0000)]
[Qt] Skip new failing tests.

Unreviewed gardening.

* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] new test inspector/extensions/extensions-sidebar.html crashing after r100433
rgabor@webkit.org [Wed, 16 Nov 2011 14:42:14 +0000 (14:42 +0000)]
[Qt] new test inspector/extensions/extensions-sidebar.html crashing after r100433
https://bugs.webkit.org/show_bug.cgi?id=72493

[Qt] http/tests/misc/onload-remove-iframe-crash-2.html crashing after r100311
https://bugs.webkit.org/show_bug.cgi?id=72491

Unreviewed gardening.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r100281 and r100437.
ossy@webkit.org [Wed, 16 Nov 2011 14:28:05 +0000 (14:28 +0000)]
Unreviewed, rolling out r100281 and r100437.
http://trac.webkit.org/changeset/100281
http://trac.webkit.org/changeset/100437
https://bugs.webkit.org/show_bug.cgi?id=72496

It made all plugin tests fail with paralel NRWT (Requested by
ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-16

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility...
hausmann@webkit.org [Wed, 16 Nov 2011 14:20:33 +0000 (14:20 +0000)]
[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions

Reviewed by Tor Arne Vestbø.

.:

* Source/api.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.

Source/JavaScriptCore:

* Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.

Source/WebCore:

* Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.

Tools:

* qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
magic here where we handle all TEMPLATE = lib .pro files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix path to module file in root project file
vestbo@webkit.org [Wed, 16 Nov 2011 14:17:24 +0000 (14:17 +0000)]
Fix path to module file in root project file

Reviewed by Simon Hausmann.

* WebKit.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayout Test inspector/extensions/extensions-events.html is flaky
caseq@chromium.org [Wed, 16 Nov 2011 14:08:28 +0000 (14:08 +0000)]
Layout Test inspector/extensions/extensions-events.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=72447

Reviewed by Yury Semikhatsky.

* inspector/extensions/extensions-events-expected.txt:
* inspector/extensions/extensions-events.html:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Pass screen refresh rate into compositor.
commit-queue@webkit.org [Wed, 16 Nov 2011 14:04:57 +0000 (14:04 +0000)]
[chromium] Pass screen refresh rate into compositor.
https://bugs.webkit.org/show_bug.cgi?id=71040

Patch by Iain Merrick <husky@google.com> on 2011-11-16
Reviewed by Tony Gentilcore.

Source/WebCore:

* platform/PlatformScreen.h:
* platform/chromium/PlatformScreenChromium.cpp:
(WebCore::screenRefreshRate):
* platform/chromium/PlatformSupport.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeImplOnImplThread):

Source/WebKit/chromium:

* public/WebScreenInfo.h:
(WebKit::WebScreenInfo::WebScreenInfo):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::screenRefreshRate):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening after r100281.
ossy@webkit.org [Wed, 16 Nov 2011 14:03:42 +0000 (14:03 +0000)]
[Qt] Unreviewed gardening after r100281.

* platform/qt/Skipped: Skip http/tests/plugins/third-party-cookie-accept-policy.html
again, because it makes all plugin related tests fail intermittently.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayoutTest fast/replaced/width100percent-textarea.html fails on Chromium Mac 10.6
steveblock@google.com [Wed, 16 Nov 2011 13:51:17 +0000 (13:51 +0000)]
LayoutTest fast/replaced/width100percent-textarea.html fails on Chromium Mac 10.6
https://bugs.webkit.org/show_bug.cgi?id=72494

Unreviewed gardening

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayout Test inspector/extensions/extensions-events.html is flaky
steveblock@google.com [Wed, 16 Nov 2011 13:13:10 +0000 (13:13 +0000)]
Layout Test inspector/extensions/extensions-events.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=72447

Unreviewed gardening

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] new test css3/flexbox/line-wrapping.html failing
rgabor@webkit.org [Wed, 16 Nov 2011 13:09:25 +0000 (13:09 +0000)]
[Qt] new test css3/flexbox/line-wrapping.html failing
https://bugs.webkit.org/show_bug.cgi?id=72490

Unreviewed gardening.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Extensions API] drop ExtensionSidebarPane.onUpdated, use callbacks...
caseq@chromium.org [Wed, 16 Nov 2011 12:56:21 +0000 (12:56 +0000)]
Web Inspector: [Extensions API] drop ExtensionSidebarPane.onUpdated, use callbacks instead
https://bugs.webkit.org/show_bug.cgi?id=72388

Reviewed by Pavel Feldman.

Source/WebCore:

Tests: inspector/extensions/extensions-panel.html
       inspector/extensions/extensions-sidebar.html

- fire ExtensionSidebarPane.on{Hidden,Shown} for non-iframe content (experssions/objects);
- drop ExtensionsSidebarPane.onUpdated, provide callback for setObject()/setExpression() instead;
- fix an exception when a page is replaced with object/expression.

 inspector/front-end/ExtensionAPI.js:
(injectedExtensionAPI.ExtensionSidebarPaneImpl):
(injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setExpression):
(injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setObject):
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionNotifierView):
(WebInspector.ExtensionNotifierView.prototype.wasShown):
(WebInspector.ExtensionNotifierView.prototype.willHide):
(WebInspector.ExtensionSidebarPane.prototype.setObject):
(WebInspector.ExtensionSidebarPane.prototype.setExpression):
(WebInspector.ExtensionSidebarPane.prototype.setPage):
(WebInspector.ExtensionSidebarPane.prototype._onEvaluate):
(WebInspector.ExtensionSidebarPane.prototype._makeObjectPropertiesView):
(WebInspector.ExtensionSidebarPane.prototype._setObject):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onSetSidebarContent.callback):
(WebInspector.ExtensionServer.prototype._onSetSidebarContent):
(WebInspector.ExtensionServer.prototype._dispatchCallback):
* inspector/front-end/View.js:
(WebInspector.View.prototype.detach):

LayoutTests:

- split LayoutTests/inspector/extensions.html into extensions-panel.html & extensions-sidebar.html.

* inspector/extensions/extensions-panel-expected.txt: Added.
* inspector/extensions/extensions-panel.html: Added.
* inspector/extensions/extensions-sidebar-expected.txt: Renamed from LayoutTests/inspector/extensions/extensions-expected.txt.
* inspector/extensions/extensions-sidebar.html: Renamed from LayoutTests/inspector/extensions/extensions.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExplicitly include unistd.h in TestNetscapePlugIn
commit-queue@webkit.org [Wed, 16 Nov 2011 12:52:06 +0000 (12:52 +0000)]
Explicitly include unistd.h in TestNetscapePlugIn
https://bugs.webkit.org/show_bug.cgi?id=72385

This is needed for the sleep() call in the indicateTestFailure method,
which seems to be implicitly available for other platforms. This is not
the case on Android.

Patch by Peter Beverloo <peter@chromium.org> on 2011-11-16
Reviewed by Steve Block.

* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Update Qt specific expected results.
rgabor@webkit.org [Wed, 16 Nov 2011 12:48:30 +0000 (12:48 +0000)]
[Qt] Update Qt specific expected results.

Unreviewed gardening.

* platform/qt/fast/loader/file-protocol-fragment-expected.png: Added.
* platform/qt/fast/loader/file-protocol-fragment-expected.txt:
* platform/qt/inspector: Added.
* platform/qt/inspector/console: Added.
* platform/qt/inspector/console/console-format-expected.png: Added.
* platform/qt/inspector/console/console-format-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCompositing LayoutTests failing on Chromium Mac
steveblock@google.com [Wed, 16 Nov 2011 12:33:04 +0000 (12:33 +0000)]
Compositing LayoutTests failing on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=72487

Unreviewed gardening

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayoutTest animations/animation-direction-normal.html fails on Chromium dbg bots
steveblock@google.com [Wed, 16 Nov 2011 11:57:09 +0000 (11:57 +0000)]
LayoutTest animations/animation-direction-normal.html fails on Chromium dbg bots
https://bugs.webkit.org/show_bug.cgi?id=72485

Unreviewed gardening

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
commit-queue@webkit.org [Wed, 16 Nov 2011 11:49:52 +0000 (11:49 +0000)]
[Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
https://bugs.webkit.org/show_bug.cgi?id=72384

Update to Android NDK r7, which was released last Friday. This adds
support for RTTI and the -mimplicit-it gcc flag, which are required to
respectively build ICU and Skia.

Patch by Peter Beverloo <peter@chromium.org> on 2011-11-16
Reviewed by Steve Block.

* Scripts/update-webkit-chromium:
* Scripts/webkitdirs.pm:
(buildChromiumMakefile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r100266.
hausmann@webkit.org [Wed, 16 Nov 2011 10:56:52 +0000 (10:56 +0000)]
Unreviewed, rolling out r100266.
http://trac.webkit.org/changeset/100266

Broke WTR.

.:

* Source/api.pri:

Source/JavaScriptCore:

* Target.pri:

Source/WebCore:

* Target.pri:

Tools:

* qmake/mkspecs/features/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][ARMv5] Websocket tests are fail, skip until fix
rgabor@webkit.org [Wed, 16 Nov 2011 10:51:34 +0000 (10:51 +0000)]
[Qt][ARMv5] Websocket tests are fail, skip until fix

Unreviewed, gardening.

* platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] fast/events/event-creation.html fails creating MediaStreamEvent
commit-queue@webkit.org [Wed, 16 Nov 2011 10:35:31 +0000 (10:35 +0000)]
[GTK] fast/events/event-creation.html fails creating MediaStreamEvent
https://bugs.webkit.org/show_bug.cgi?id=70720

Patch by Per-Erik Brodin <per-erik.brodin@ericsson.com> on 2011-11-16
Reviewed by Philippe Normand.

Source/WebCore:

Added missing overriding of Event::interfaceName()

* mediastream/MediaStreamEvent.cpp:
(WebCore::MediaStreamEvent::stream): Changed return value to raw pointer.
(WebCore::MediaStreamEvent::interfaceName): Added back from r98044.
* mediastream/MediaStreamEvent.h:
* mediastream/MediaStreamEvent.idl: Changed module name to "events".

LayoutTests:

* platform/gtk/Skipped: Unskipped fast/events/event-creation.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Do not hide accessibility root object from AT's
mario@webkit.org [Wed, 16 Nov 2011 09:46:36 +0000 (09:46 +0000)]
[GTK] Do not hide accessibility root object from AT's
https://bugs.webkit.org/show_bug.cgi?id=72390

Reviewed by Martin Robinson.

* tests/testatk.c:
(getWebAreaObject): New helper function, to bypass the new root
object in the accessibility hierarchy, since it's not usually
needed for the unit tests.
(testWebkitAtkCaretOffsets): Use getWebAreaObject().
(testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces): Ditto.
(testWebkitAtkComboBox): Ditto.
(testWebkitAtkEmbeddedObjects): Ditto.
(testWebkitAtkGetTextAtOffsetForms): Ditto.
(testWebkitAtkGetTextAtOffset): Ditto.
(testWebkitAtkGetTextAtOffsetNewlines): Ditto.
(testWebkitAtkGetTextAtOffsetTextarea): Ditto.
(testWebkitAtkGetTextAtOffsetTextInput): Ditto.
(testWebkitAtkGetTextAtOffsetWithSpecialCharacters): Ditto.
(testWebkitAtkGetTextInParagraphAndBodySimple): Ditto.
(testWebkitAtkGetTextInParagraphAndBodyModerate): Ditto.
(testWebkitAtkGetTextInTable): Ditto.
(testWebkitAtkGetHeadersInTable): Ditto.
(testWebkitAtkTextAttributes): Ditto.
(testWebkitAtkTextSelections): Ditto.
(testWebkitAtkGetExtents): Ditto.
(testWebkitAtkLayoutAndDataTables): Ditto.
(testWebkitAtkLinksWithInlineImages): Ditto.
(testWebkitAtkHypertextAndHyperlinks): Ditto.
(testWebkitAtkListsOfItems): Ditto.
(testWebkitAtkTextChangedNotifications): Ditto.
(testWebkitAtkParentForRootObject): New test, to make sure that
both top-down and bottom-up navigation among GTK and WebKit worlds
matches accordingly.
(main): Added new test.

* webkit/webkitwebview.cpp:
(webkit_web_view_get_accessible): Remove the hack introduced
because of bug 51932, to bypass the root object here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocheck-webkit-style broken by r99773: "Could not determine the port"
eric@webkit.org [Wed, 16 Nov 2011 09:06:49 +0000 (09:06 +0000)]
check-webkit-style broken by r99773: "Could not determine the port"
https://bugs.webkit.org/show_bug.cgi?id=72275

Reviewed by Adam Barth.

I will continue engaging hacks, until windows improves.

* Scripts/webkitpy/common/host.py:
 - Host uses self.executive instead of self._executive like Port does.
 - I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Update chromium expectations for compositing tests
jamesr@google.com [Wed, 16 Nov 2011 08:48:53 +0000 (08:48 +0000)]
[chromium] Update chromium expectations for compositing tests

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocheck-webkit-style broken by r99773: "Could not determine the port"
eric@webkit.org [Wed, 16 Nov 2011 08:41:36 +0000 (08:41 +0000)]
check-webkit-style broken by r99773: "Could not determine the port"
https://bugs.webkit.org/show_bug.cgi?id=72275

Reviewed by Adam Barth.

Engage windows hacks harder.

This is a speculative fix for ChromiumWin.  We're now
creating an SCM object much earlier, so we need to
engage our "awesome" windows hacks earlier.

* Scripts/webkitpy/common/host.py:
* Scripts/webkitpy/layout_tests/port/chromium_win.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Update chromium win and linux compositing baselines
jamesr@google.com [Wed, 16 Nov 2011 08:16:42 +0000 (08:16 +0000)]
[chromium] Update chromium win and linux compositing baselines
https://bugs.webkit.org/show_bug.cgi?id=72402

* platform/chromium-cg-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/layers-inside-overflow-scroll-expected.png.
* platform/chromium-linux/compositing/layers-inside-overflow-scroll-expected.png:
* platform/chromium-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
* platform/chromium-linux/compositing/overflow/scroll-ancestor-update-expected.png:
* platform/chromium-linux/compositing/self-painting-layers-expected.png:
* platform/chromium-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png: Renamed from LayoutTests/platform/chromium-mac/compositing/layers-inside-overflow-scroll-expected.png.
* platform/chromium-mac/compositing/overflow/overflow-compositing-descendant-expected.png: Removed.
* platform/chromium-mac/compositing/overflow/scroll-ancestor-update-expected.png: Removed.
* platform/chromium-mac/compositing/self-painting-layers-expected.png: Removed.
* platform/chromium-win/compositing/layers-inside-overflow-scroll-expected.png:
* platform/chromium-win/compositing/overflow/overflow-compositing-descendant-expected.png:
* platform/chromium-win/compositing/overflow/scroll-ancestor-update-expected.png:
* platform/chromium-win/compositing/self-painting-layers-expected.png:
* platform/chromium/compositing/overflow/overflow-compositing-descendant-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/overflow/overflow-compositing-descendant-expected.png.
* platform/chromium/compositing/overflow/scroll-ancestor-update-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/overflow/scroll-ancestor-update-expected.png.
* platform/chromium/compositing/self-painting-layers-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/self-painting-layers-expected.png.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Use GQuark's in the ATK wrapper to get and set arbitrary data
mario@webkit.org [Wed, 16 Nov 2011 08:16:33 +0000 (08:16 +0000)]
[GTK] Use GQuark's in the ATK wrapper to get and set arbitrary data
https://bugs.webkit.org/show_bug.cgi?id=72394

Reviewed by Martin Robinson.

No new functionality, no new tests needed.

* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_class_init): Initialize GQuarks.
(getGailTextUtilForAtk): Use gailTextUtilQuark.
(getPangoLayoutForAtk): Remove unused call to
g_object_set_data_full, since that data is no used anywhere.
(webkitAccessibleHyperlinkImplGetHyperlink): Use hyperlinkObjectQuark.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a "pass type" and "peek type" concept to HashTraits
darin@apple.com [Wed, 16 Nov 2011 08:06:09 +0000 (08:06 +0000)]
Add a "pass type" and "peek type" concept to HashTraits
https://bugs.webkit.org/show_bug.cgi?id=72473

Reviewed by Filip Pizlo.

* wtf/HashTraits.h: Added the pass type and peek type.
For OwnPtr, the pass type will be PassOwnPtr and the peek
type will be a raw pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix some hash traits that don't derive from the base hash traits
darin@apple.com [Wed, 16 Nov 2011 08:05:40 +0000 (08:05 +0000)]
Fix some hash traits that don't derive from the base hash traits
https://bugs.webkit.org/show_bug.cgi?id=72470

Reviewed by Filip Pizlo.

Hash traits structures need to derive from the base hash traits in
HashTraits.h, but some were not. This is needed for compatibility with
some additional traits we will be adding to make OwnPtr work with HashMap.

* runtime/Identifier.h: Make IdentifierMapIndexHashTraits derive from
HashTraits<int>. This enabled removal of all the members except for the
ones that control the empty value, because this is otherwise the same
as the standard int hash.

* runtime/SymbolTable.h: Changed SymbolTableIndexHashTraits to derive
from HashTraits<SymbolTableEntry> and removed redundant members.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSSShaders] Implement the style cached resources and computed style for the shader...
achicu@adobe.com [Wed, 16 Nov 2011 07:51:03 +0000 (07:51 +0000)]
[CSSShaders] Implement the style cached resources and computed style for the shader urls
https://bugs.webkit.org/show_bug.cgi?id=72378

Reviewed by Dean Jackson.

Source/WebCore:

Test: css3/filters/custom-filter-property-computed-style.html

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::valueForFilter):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::styleForKeyframe):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::styleForPage):
(WebCore::CSSStyleSelector::applyMatchedDeclarations):
(WebCore::CSSStyleSelector::styleShader):
(WebCore::CSSStyleSelector::cachedOrPendingStyleShaderFromValue):
(WebCore::CSSStyleSelector::loadPendingShaders):
(WebCore::CSSStyleSelector::createCustomFilterOperation):
(WebCore::CSSStyleSelector::createFilterOperations):
* css/CSSStyleSelector.h:
* css/WebKitCSSShaderValue.cpp:
(WebCore::WebKitCSSShaderValue::WebKitCSSShaderValue):
(WebCore::WebKitCSSShaderValue::~WebKitCSSShaderValue):
(WebCore::WebKitCSSShaderValue::cachedShader):
(WebCore::WebKitCSSShaderValue::cachedOrPendingShader):
* css/WebKitCSSShaderValue.h:
* loader/cache/CachedResource.cpp:
(WebCore::defaultPriorityForResourceType):
* loader/cache/CachedResource.h:
* loader/cache/CachedResourceLoader.cpp:
(WebCore::createResource):
(WebCore::CachedResourceLoader::requestShader):
(WebCore::CachedResourceLoader::checkInsecureContent):
(WebCore::CachedResourceLoader::canRequest):
* loader/cache/CachedResourceLoader.h:
* loader/cache/CachedShader.cpp:
(WebCore::CachedShader::CachedShader):
(WebCore::CachedShader::~CachedShader):
* loader/cache/CachedShader.h:
* platform/graphics/filters/CustomFilterOperation.h:
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::filter):
* rendering/style/StyleCachedShader.cpp:
(WebCore::StyleCachedShader::StyleCachedShader):
(WebCore::StyleCachedShader::cssValue):
* rendering/style/StyleCachedShader.h:
(WebCore::StyleCachedShader::create):
* rendering/style/StylePendingShader.h:
(WebCore::StylePendingShader::create):
(WebCore::StylePendingShader::cssValue):
(WebCore::StylePendingShader::cssShaderValue):
(WebCore::StylePendingShader::StylePendingShader):
* rendering/style/StyleShader.h:
(WebCore::StyleShader::~StyleShader):
(WebCore::StyleShader::isCachedShader):
(WebCore::StyleShader::isPendingShader):
(WebCore::StyleShader::StyleShader):

LayoutTests:

* css3/filters/custom-filter-property-computed-style-expected.txt: Added.
* css3/filters/custom-filter-property-computed-style.html: Added.
* css3/filters/script-tests/custom-filter-property-computed-style.js: Added.
(jsWrapperClass):
(expression):
(description):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Update chromium mac compositing baselines
jamesr@google.com [Wed, 16 Nov 2011 07:48:19 +0000 (07:48 +0000)]
[chromium] Update chromium mac compositing baselines
https://bugs.webkit.org/show_bug.cgi?id=72402

* platform/chromium-cg-mac-snowleopard/animations/3d/matrix-transform-type-animation-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/tiny-layer-rotated-expected.png: Added.
* platform/chromium-cg-mac/animations/3d/matrix-transform-type-animation-expected.png: Removed.
* platform/chromium-cg-mac/animations/3d/state-at-end-event-transform-expected.png: Removed.
* platform/chromium-mac-snowleopard/animations/3d/matrix-transform-type-animation-expected.png: Renamed from LayoutTests/platform/chromium-mac/animations/3d/matrix-transform-type-animation-expected.png.
* platform/chromium-mac-snowleopard/platform/chromium/compositing/huge-layer-rotated-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/huge-layer-rotated-expected.png.
* platform/chromium-mac-snowleopard/platform/chromium/compositing/tiny-layer-rotated-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/tiny-layer-rotated-expected.png.
* platform/chromium-win/platform/chromium/compositing/child-layer-3d-sorting-expected.txt: Removed.
* platform/chromium-win/platform/chromium/compositing/plugins/webplugin-alpha-expected.png: Added.
* platform/chromium-win/platform/chromium/compositing/plugins/webplugin-alpha-expected.txt: Added.
* platform/chromium-win/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt.
* platform/chromium/animations/3d/replace-filling-transform-expected.png: Renamed from LayoutTests/platform/chromium-mac/animations/3d/replace-filling-transform-expected.png.
* platform/chromium/animations/3d/state-at-end-event-transform-expected.png: Renamed from LayoutTests/platform/chromium-mac/animations/3d/state-at-end-event-transform-expected.png.
* platform/chromium/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.png.
* platform/chromium/platform/chromium/compositing/child-layer-3d-sorting-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.txt.
* platform/chromium/platform/chromium/compositing/layout-width-change-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/layout-width-change-expected.png.
* platform/chromium/platform/chromium/compositing/plugins/webplugin-alpha-expected.png: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/plugins/webplugin-alpha-expected.png.
* platform/chromium/platform/chromium/compositing/plugins/webplugin-alpha-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/plugins/webplugin-alpha-expected.txt.
* platform/chromium/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/compositing/plugins/webplugin-reflection-expected.txt.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add webkit_web_view_load_request() to WebKit2 GTK+ API
carlosgc@webkit.org [Wed, 16 Nov 2011 07:47:46 +0000 (07:47 +0000)]
[GTK] Add webkit_web_view_load_request() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=72380

Reviewed by Martin Robinson.

It adds an initial implementation of WebKitNetworkRequest
class that only contains a URI for now.

* GNUmakefile.am:
* UIProcess/API/gtk/WebKitNetworkRequest.cpp: Added.
(webkitNetworkRequestFinalize):
(webkitNetworkRequestGetProperty):
(webkitNetworkRequestSetProperty):
(webkit_network_request_class_init):
(webkit_network_request_init):
(webkit_network_request_new):
(webkit_network_request_get_uri):
* UIProcess/API/gtk/WebKitNetworkRequest.h: Added.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_load_request): Use WKPageLoadURLRequest() to load
the given WebKitNetworkRequest.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:
(testLoadRequest):
(beforeAll):
* UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::loadRequest):
* UIProcess/API/gtk/tests/WebViewTest.h:
* UIProcess/API/gtk/webkit2.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] [GTK] fast/css/webkit-mask-crash-fieldset-legend.html asserts WebKitWebProcess
sergio@webkit.org [Wed, 16 Nov 2011 07:24:21 +0000 (07:24 +0000)]
[WK2] [GTK] fast/css/webkit-mask-crash-fieldset-legend.html asserts WebKitWebProcess
https://bugs.webkit.org/show_bug.cgi?id=69510

Reviewed by Simon Fraser.

Source/WebCore:

End the current transparency layer before early returning from
paintMask() when there is a maskBoxImage which is still being
loaded. This will balance the previous call to
beginTransparencyLayer().

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintMask):

LayoutTests:

Unskipped tests that are now passing.

* platform/gtk/Skipped:
* platform/gtk-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r100375 and r100385.
ossy@webkit.org [Wed, 16 Nov 2011 07:23:17 +0000 (07:23 +0000)]
Unreviewed, rolling out r100375 and r100385.
http://trac.webkit.org/changeset/100375
http://trac.webkit.org/changeset/100385
https://bugs.webkit.org/show_bug.cgi?id=72465

They broke 32 bit builds on Qt (Requested by ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-15

* dfg/DFGOperations.cpp:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ArgList.cpp:
(JSC::ArgList::getSlice):
* runtime/ArgList.h:
(JSC::ArgList::ArgList):
* runtime/JSArray.cpp:
* runtime/JSArray.h:
* runtime/JSGlobalObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Land specific expectations for compositing tests
jamesr@google.com [Wed, 16 Nov 2011 07:19:24 +0000 (07:19 +0000)]
[chromium] Land specific expectations for compositing tests
https://bugs.webkit.org/show_bug.cgi?id=72402

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[TexMap][Qt] Start PageClientQ[Graphics]Widget::syncTimer only when the syncTimer
commit-queue@webkit.org [Wed, 16 Nov 2011 07:09:24 +0000 (07:09 +0000)]
[TexMap][Qt] Start PageClientQ[Graphics]Widget::syncTimer only when the syncTimer
is inactive.
https://bugs.webkit.org/show_bug.cgi?id=70407

Make sure we only activate the synchronization timer in
PageClientQWidget/PageClientQGraphicsWidget if it's not already active,
otherwise syncLayers may be called redundantly.

Patch by Huang Dongsung <luxtella@company100.net> on 2011-11-15
Reviewed by Noam Rosenthal.

* WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQWidget::markForSync):
(WebCore::PageClientQWidget::syncLayers):
(WebCore::PageClientQGraphicsWidget::syncLayers):
(WebCore::PageClientQGraphicsWidget::markForSync):
* WebCoreSupport/PageClientQt.h:
(WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDRT's uiElementAttributeValueCallback function is leaky
darin@apple.com [Wed, 16 Nov 2011 06:46:48 +0000 (06:46 +0000)]
DRT's uiElementAttributeValueCallback function is leaky
https://bugs.webkit.org/show_bug.cgi?id=72453

Reviewed by Dan Bernstein.

* DumpRenderTree/AccessibilityUIElement.cpp:
(uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIncorrect type checks in RenderTheme media code
darin@apple.com [Wed, 16 Nov 2011 06:46:27 +0000 (06:46 +0000)]
Incorrect type checks in RenderTheme media code
https://bugs.webkit.org/show_bug.cgi?id=72184

Reviewed by Eric Carlson.

No tests added. Ideally this patch should be revised to add tests!

* accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaControl::create): Use mediaControlElementType.
(WebCore::AccessibilityMediaControl::controlType): Ditto.
(WebCore::AccessibilityMediaTimeline::valueDescription): Use early return
rather than an assertion to check type of input element.

* html/shadow/MediaControlElements.cpp:
(WebCore::mediaControlElementType): Added. A type-safe way to get the
media control element type after checking isMediaControlElement but with
no other assumptions.
* html/shadow/MediaControlElements.h: Added mediaControlElementType.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintMediaPlayButton): Use mediaControlElementType.
(WebCore::RenderThemeEfl::paintMediaSeekBackButton): Use mediaControlElementType.
(WebCore::RenderThemeEfl::paintMediaSeekForwardButton): Use mediaControlElementType.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintMediaPlayButton): Check isMediaControlElement and
use mediaControlElementType.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMediaMuteButton): Ditto. Also remove uneeded
redundant null check.
(WebCore::RenderThemeMac::paintMediaPlayButton): Ditto.
(WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement edit-distance based reviewer recognition algorithm
rniwa@webkit.org [Wed, 16 Nov 2011 06:41:17 +0000 (06:41 +0000)]
Implement edit-distance based reviewer recognition algorithm
https://bugs.webkit.org/show_bug.cgi?id=72351

Reviewed by Eric Seidel.

Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
"build fix" to a reviewer's name (e.g. with with edit distance 9).

This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
the edit distance is implemented in edit_distance.py.

Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.

* Scripts/webkitpy/common/checkout/changelog.py:
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
* Scripts/webkitpy/common/config/committers.py:
* Scripts/webkitpy/common/config/committers_unittest.py:
* Scripts/webkitpy/common/editdistance.py: Added.
* Scripts/webkitpy/common/editdistance_unittest.py: Added.
* Scripts/webkitpy/tool/steps/validatereviewer.py:
* Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove the guard page from the addressable stack region on QNX.
staikos@webkit.org [Wed, 16 Nov 2011 06:21:01 +0000 (06:21 +0000)]
Remove the guard page from the addressable stack region on QNX.
https://bugs.webkit.org/show_bug.cgi?id=72455

Reviewed by Daniel Bates.

* wtf/StackBounds.cpp:
(WTF::StackBounds::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTowards 8 bit Strings - Update utf8() and ascii() methods for 8 bit strings
msaboff@apple.com [Wed, 16 Nov 2011 06:06:21 +0000 (06:06 +0000)]
Towards 8 bit Strings - Update utf8() and ascii() methods for 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=72323

Added 8 bit optimized paths for String and UString ascii() and utf8() methods.

Added String::characters8(), characters16() and is8Bit() helper methods.

Added an new Unicode::convertLatin1ToUTF8() method that works on
LChar (8 bit) strings that is a stripped down version of convertUTF16ToUTF8().

Reviewed by Geoff Garen.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/UString.cpp:
(JSC::UString::utf8):
* wtf/text/WTFString.cpp:
(WTF::String::ascii):
(WTF::String::utf8):
* wtf/text/WTFString.h:
(WTF::String::characters8):
(WTF::String::characters16):
(WTF::String::is8Bit):
(WTF::LChar):
(WTF::UChar):
* wtf/unicode/UTF8.cpp:
(WTF::Unicode::convertLatin1ToUTF8):
* wtf/unicode/UTF8.h:
* wtf/unicode/Unicode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove expected PASS expectations for compositing tests.
jamesr@google.com [Wed, 16 Nov 2011 05:46:55 +0000 (05:46 +0000)]
[chromium] Remove expected PASS expectations for compositing tests.

This will result in a temporary spike in the number of unexpected
PASSes reported by the bots, but will allow me to add specific
expectations for all the compositing tests instead of the current
blanket PASS FAIL line.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove failing expectations from various JS tests that now pass.
jamesr@google.com [Wed, 16 Nov 2011 05:40:22 +0000 (05:40 +0000)]
[chromium] Remove failing expectations from various JS tests that now pass.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake sure both the video and the track are ready to be tested before testing.
annacc@chromium.org [Wed, 16 Nov 2011 05:33:23 +0000 (05:33 +0000)]
Make sure both the video and the track are ready to be tested before testing.
https://bugs.webkit.org/show_bug.cgi?id=72269

Reviewed by Eric Carlson.

* media/track/track-cues-cuechange.html:
* media/track/track-cues-enter-exit.html:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] During tear down, prevent the WebGLLayerChromium instance from attempting...
commit-queue@webkit.org [Wed, 16 Nov 2011 05:12:33 +0000 (05:12 +0000)]
[chromium] During tear down, prevent the WebGLLayerChromium instance from attempting to stop a timer for a NULL context.
https://bugs.webkit.org/show_bug.cgi?id=72423

Patch by Jeff Timanus <twiz@chromium.org> on 2011-11-15
Reviewed by Kenneth Russell.

* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::setDrawingBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline generated WebCore bindings
mhahnenberg@apple.com [Wed, 16 Nov 2011 05:10:42 +0000 (05:10 +0000)]
Rebaseline generated WebCore bindings

Unreviewed build fix

No new tests.

* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::isObservable):
(WebCore::JSTestEventConstructorOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestEventConstructorOwner::finalize):
* bindings/scripts/test/JS/JSTestEventConstructor.h:
(WebCore::JSTestEventConstructor::clearImpl):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceOwner::finalize):
* bindings/scripts/test/JS/JSTestInterface.h:
(WebCore::JSTestInterface::clearImpl):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::isObservable):
(WebCore::JSTestMediaQueryListListenerOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestMediaQueryListListenerOwner::finalize):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(WebCore::JSTestMediaQueryListListener::clearImpl):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorOwner::finalize):
* bindings/scripts/test/JS/JSTestNamedConstructor.h:
(WebCore::JSTestNamedConstructor::clearImpl):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::isObservable):
(WebCore::JSTestObjOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestObjOwner::finalize):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore::JSTestObj::clearImpl):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::isObservable):
(WebCore::JSTestSerializedScriptValueInterfaceOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestSerializedScriptValueInterfaceOwner::finalize):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore::JSTestSerializedScriptValueInterface::clearImpl):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPatch removing duplicated code in the setup of the DrawingBuffer used
commit-queue@webkit.org [Wed, 16 Nov 2011 04:47:12 +0000 (04:47 +0000)]
Patch removing duplicated code in the setup of the DrawingBuffer used
to host the back-buffer for WebGL contents.
https://bugs.webkit.org/show_bug.cgi?id=72327

Patch by Jeff Timanus <twiz@chromium.org> on 2011-11-15
Reviewed by Kenneth Russell.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::readPixels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJS DOM wrappers depend on destructor to deref impl RefPtrs
mhahnenberg@apple.com [Wed, 16 Nov 2011 04:29:17 +0000 (04:29 +0000)]
JS DOM wrappers depend on destructor to deref impl RefPtrs
https://bugs.webkit.org/show_bug.cgi?id=72341

Reviewed by Sam Weinig.

No new tests.

Added clearing of impl RefPtrs to JS DOM wrapper nodes and removed the default
wrapperOwner function in favor of generating all WeakHandleOwners and wrapperOwner functions.

* bindings/js/JSCSSValueCustom.cpp:
(WebCore::JSCSSValueOwner::finalize):
* bindings/js/JSDOMBinding.h:
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNodeOwner::finalize):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSkip a failing webkitpy test on cygwin.
tony@chromium.org [Wed, 16 Nov 2011 04:28:41 +0000 (04:28 +0000)]
Skip a failing webkitpy test on cygwin.

* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] fix overlapping expectations
tony@chromium.org [Wed, 16 Nov 2011 04:17:00 +0000 (04:17 +0000)]
[chromium] fix overlapping expectations
https://bugs.webkit.org/show_bug.cgi?id=72458

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Share Highlight Code for Drawing Outlined Quad
commit-queue@webkit.org [Wed, 16 Nov 2011 03:54:12 +0000 (03:54 +0000)]
Web Inspector: Share Highlight Code for Drawing Outlined Quad
https://bugs.webkit.org/show_bug.cgi?id=72451

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2011-11-15
Reviewed by Timothy Hatcher.

* inspector/DOMNodeHighlighter.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r100308.
commit-queue@webkit.org [Wed, 16 Nov 2011 03:18:14 +0000 (03:18 +0000)]
Unreviewed, rolling out r100308.
http://trac.webkit.org/changeset/100308
https://bugs.webkit.org/show_bug.cgi?id=72450

Introduces WebGL conformance test regressions. (Requested by
twiz on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-15

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::readPixels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark a test as flakily failing.
pkasting@chromium.org [Wed, 16 Nov 2011 03:06:10 +0000 (03:06 +0000)]
Mark a test as flakily failing.
https://bugs.webkit.org/show_bug.cgi?id=66908

Unreviewed, gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRollout http://trac.webkit.org/changeset/99813, caused some crashes in
jamesr@google.com [Wed, 16 Nov 2011 03:01:06 +0000 (03:01 +0000)]
Rollout trac.webkit.org/changeset/99813, caused some crashes in
TiledLayerChromium::updateCompositorResources()

* WebCore.gypi:
* platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp: Removed.
* platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h: Removed.
* platform/graphics/chromium/CanvasLayerTextureUpdater.cpp: Removed.
* platform/graphics/chromium/CanvasLayerTextureUpdater.h: Removed.
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h: Removed.
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::prepareToUpdate):
* platform/graphics/chromium/LayerRendererChromium.cpp:
* platform/graphics/chromium/LayerTextureUpdater.h:
* platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: Renamed from Source/WebCore/platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp.
(WebCore::FrameBuffer::FrameBuffer::FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::~FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::initialize):
(WebCore::LayerTextureUpdaterCanvas::LayerTextureUpdaterCanvas):
(WebCore::LayerTextureUpdaterCanvas::paintContents):
(WebCore::LayerTextureUpdaterBitmap::create):
(WebCore::LayerTextureUpdaterBitmap::LayerTextureUpdaterBitmap):
(WebCore::LayerTextureUpdaterBitmap::sampledTexelFormat):
(WebCore::LayerTextureUpdaterBitmap::prepareToUpdate):
(WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
(WebCore::LayerTextureUpdaterSkPicture::create):
(WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::~LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::sampledTexelFormat):
(WebCore::LayerTextureUpdaterSkPicture::prepareToUpdate):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
* platform/graphics/chromium/LayerTextureUpdaterCanvas.h: Added.
(WebCore::LayerTextureUpdaterCanvas::contentRect):
(WebCore::LayerTextureUpdaterBitmap::orientation):
(WebCore::LayerTextureUpdaterSkPicture::orientation):
* platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp: Removed.
* platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h: Removed.
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::UpdatableTile::texture):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::protectTileTextures):
(WebCore::TiledLayerChromium::prepareToUpdate):
* platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore::CCTextureUpdater::append):
(WebCore::CCTextureUpdater::update):
* platform/graphics/chromium/cc/CCTextureUpdater.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r98887): ParserArena and Keywords leaking
darin@apple.com [Wed, 16 Nov 2011 02:53:09 +0000 (02:53 +0000)]
REGRESSION (r98887): ParserArena and Keywords leaking
https://bugs.webkit.org/show_bug.cgi?id=72428

Reviewed by Sam Weinig.

* parser/Lexer.h: Made Keywords destructor public since OwnPtr and PassOwnPtr
need to be able to destroy it.

* parser/Parser.cpp:
(JSC::Parser::Parser): Use get now that parserArena is an OwnPtr.

* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData): Use adoptPtr to initialize OwnPtr members.

* runtime/JSGlobalData.h: Make parserArena and keywords be OwnPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Fix overlapping expectations on chromium mac
jamesr@google.com [Wed, 16 Nov 2011 02:51:42 +0000 (02:51 +0000)]
[chromium] Fix overlapping expectations on chromium mac

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd the needed plumbing to parse display: -webkit-inline-grid
jchaffraix@webkit.org [Wed, 16 Nov 2011 02:49:07 +0000 (02:49 +0000)]
Add the needed plumbing to parse display: -webkit-inline-grid
https://bugs.webkit.org/show_bug.cgi?id=72438

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/css-grid-layout/display-grid-set-get.html

Added the needed constants and plugged everything together.
Again we treat display: -webkit-inline-grid like display: none
for the moment.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSValueKeywords.in:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
* rendering/style/RenderStyleConstants.h:

LayoutTests:

Integrated testing for display: -webkit-inline-grid into the existing test.

* fast/css-grid-layout/display-grid-set-get-expected.txt:
* fast/css-grid-layout/display-grid-set-get.html:
* fast/css-grid-layout/resources/display-grid-set-get.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Move setVisibleRect() calls into calculateDrawTransformAndVisibility()
wjmaclean@chromium.org [Wed, 16 Nov 2011 02:38:47 +0000 (02:38 +0000)]
[chromium] Move setVisibleRect() calls into calculateDrawTransformAndVisibility()
https://bugs.webkit.org/show_bug.cgi?id=72162

Reviewed by Kenneth Russell.

Refactoring of existing functionality, so uses existing tests.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayer):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::paintContentsIfDirty):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::walkLayersAndCalculateVisibleLayerRects):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransformsAndVisibility):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r100340.
pkasting@chromium.org [Wed, 16 Nov 2011 02:13:12 +0000 (02:13 +0000)]
Unreviewed, rolling out r100340.
http://trac.webkit.org/changeset/100340
https://bugs.webkit.org/show_bug.cgi?id=72448

Caused assertion failure in Win dbg canary. (Requested by
pkasting on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-15

Source/WebCore:

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::drawLayersInternal):
* platform/graphics/chromium/LayerRendererChromium.h:

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSwitch table indexing to unsigned
jchaffraix@webkit.org [Wed, 16 Nov 2011 02:03:54 +0000 (02:03 +0000)]
Switch table indexing to unsigned
https://bugs.webkit.org/show_bug.cgi?id=72083

Reviewed by Darin Adler.

No expected change in behavior.

All of the code is now using unsigned for indexing!

* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::layout):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::colElement):
(WebCore::RenderTable::cellAbove):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::splitColumn):
Added some ASSERTs to make sure we don't underflow. Looking at how
the different variables are populated, they should not be reached.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::colSpan):
(WebCore::RenderTableCell::rowSpan):
Those 2 functions promotes HTMLTableCellElement's int to unsigned
which should be fine as we make sure their are positive. Also HTML5
makes those 2 fields "unsigned long" which goes in the same direction.

* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::layout):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::nodeAtPoint):
Rewrote a couple of reverse iterating to be able to use unsigned
without overflowing.

* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::fullRecalc):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::insertSpanCell):
* rendering/AutoTableLayout.h:
* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):
(WebCore::RenderTable::recalcSections):
* rendering/RenderTable.h:
(WebCore::RenderTable::getColumnPos):
(WebCore::RenderTable::spanOfEffCol):
(WebCore::RenderTable::effColToCol):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::styleOrColLogicalWidth):
(WebCore::CollapsedBorders::nextBorder):
* rendering/RenderTableCell.h:
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::updateFromElement):
* rendering/RenderTableCol.h:
(WebCore::RenderTableCol::span):
(WebCore::RenderTableCol::setSpan):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addCell):
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderBefore):
(WebCore::RenderTableSection::calcOuterBorderAfter):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::paintObject):
(WebCore::RenderTableSection::appendColumn):
* rendering/RenderTableSection.h:
(WebCore::RenderTableSection::cellAt):
(WebCore::RenderTableSection::primaryCellAt):
(WebCore::RenderTableSection::getBaseline):
Mechanical change int -> unsigned.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoved another use of ArgList that baked in the assumption that arguments
ggaren@apple.com [Wed, 16 Nov 2011 01:53:29 +0000 (01:53 +0000)]
Removed another use of ArgList that baked in the assumption that arguments
are forward in the regiter file.

Reviewed by Sam Weinig.

* dfg/DFGOperations.cpp:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION): Use our new array creation API, instead of
working through ArgList.

* runtime/ArgList.h: Removed!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConsolidate the logic that creates run loop observers for flushing layer tree changes...
aestes@apple.com [Wed, 16 Nov 2011 01:52:24 +0000 (01:52 +0000)]
Consolidate the logic that creates run loop observers for flushing layer tree changes to CoreAnimation
https://bugs.webkit.org/show_bug.cgi?id=72106

Reviewed by Anders Carlsson.

Source/WebCore:

Add a class that encapsulates the logic of scheduling, enabling and
invalidating a run loop observer that fires before Core Animation's
commit observer. Clients can subclass LayerFlushSchedulerClient and
implement flushLayers(), which will be called by the observer.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/ca/LayerFlushScheduler.cpp: Added.
(WebCore::LayerFlushScheduler::suspend): Suspend scheduling by
invalidating the run loop observer. Keep a count of calls to suspend()
in m_suspendCount.
(WebCore::LayerFlushScheduler::resume): Decrement m_suspendCount.
Install the run loop observer when it reaches 0.
* platform/graphics/ca/LayerFlushSchedulerClient.h: Added.
(WebCore::LayerFlushSchedulerClient::~LayerFlushSchedulerClient):
* platform/graphics/ca/LayerFlushScheduler.h: Added.
* platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp: Added.
(LayerFlushScheduler::LayerFlushScheduler):
(LayerFlushScheduler::~LayerFlushScheduler):
(LayerFlushScheduler::runLoopObserverCallback): Call flushLayers() on
the LayerFlushSchedulerClient.
(LayerFlushScheduler::schedule): Install the run loop observer.
(LayerFlushScheduler::invalidate): Remove the run loop
observer if it is installed.

Source/WebKit/mac:

Remove code that schedules layer flushes and use LayerFlushScheduler instead.

* WebView/WebView.mm:
(-[WebView _close]): Invalidate the run loop observer and destroy the
LayerFlushController.
(LayerFlushController::flushLayers): Perform the work that
layerSyncRunLoopObserverCallBack used to do.
(-[WebView _scheduleCompositingLayerSync]): If layerFlushController has
yet to be created, create it, then schedule a layer flush.
* WebView/WebViewData.h:
(LayerFlushController::create): Create a LayerFlushController that
implements the LayerFlushSchedulerClient interface and contains a
LayerFlushScheduler with itself as the client.
* WebView/WebViewData.mm:
(LayerFlushController::scheduleLayerFlush):
(LayerFlushController::invalidateObserver):
(LayerFlushController::LayerFlushController):

Source/WebKit2:

Remove code that schedules layer flushes and use LayerFlushScheduler instead.

* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h: Replace
m_flushPendingLayerChangesRunLoopObserver with m_layerFlushScheduler
and implement the LayerFlushSchedulerClient interface.
* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:
(WebKit::LayerTreeHostCAMac::LayerTreeHostCAMac): Instantiate
m_layerFlushScheduler with the LayerTreeHost as the client.
(WebKit::LayerTreeHostCAMac::~LayerTreeHostCAMac):
(WebKit::LayerTreeHostCAMac::scheduleLayerFlush): Call LayerFlushScheduler::schedule().
(WebKit::LayerTreeHostCAMac::setLayerFlushSchedulingEnabled): Call
LayerFlushScheduler::suspend() or LayerFlushScheduler::resume().
(WebKit::LayerTreeHostCAMac::invalidate): Call LayerFlushScheduler::invalidate().
(WebKit::LayerTreeHostCAMac::flushLayers): Do the work that
flushPendingLayerChangesRunLoopObserverCallback() used to do.
(WebKit::LayerTreeHostCAMac::didPerformScheduledLayerFlush): Call LayerFlushScheduler::invalidate().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMaybe the reason we're fiddling with line endings is that this file
pkasting@chromium.org [Wed, 16 Nov 2011 01:51:17 +0000 (01:51 +0000)]
Maybe the reason we're fiddling with line endings is that this file
didn't set svn:eol-style.  Set it.

Unreviewed, gardening.

* fast/dom/Orientation/create-event-orientationchange-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark a test as flakily failing.
pkasting@chromium.org [Wed, 16 Nov 2011 01:47:18 +0000 (01:47 +0000)]
Mark a test as flakily failing.
https://bugs.webkit.org/show_bug.cgi?id=72447

Unreviewed, gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed; skipping fast/dom/Window/window-postmessage-arrays.html
dslomov@google.com [Wed, 16 Nov 2011 01:43:12 +0000 (01:43 +0000)]
Unreviewed; skipping fast/dom/Window/window-postmessage-arrays.html
until https://bugs.webkit.org/show_bug.cgi?id=72435 is fixed.

* platform/mac/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTestWebKitAPI should not put its resources in the root products directory
weinig@apple.com [Wed, 16 Nov 2011 01:41:33 +0000 (01:41 +0000)]
TestWebKitAPI should not put its resources in the root products directory
https://bugs.webkit.org/show_bug.cgi?id=72446

Reviewed by Anders Carlsson.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Change the copy resources phase to place the resources in a TestWebKitAPI.resources
directory.

* TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
(TEST_F):
* TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
(TestWebKitAPI::DeviceScaleFactorOnBack::url):
* TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
(TestWebKitAPI::DynamicDeviceScaleFactor::url):
* TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
(TestWebKitAPI::Util::createURLForResource):
Update calls to retrieve files from the bundle to look in the newly
created subdirectory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline after r100289
arv@chromium.org [Wed, 16 Nov 2011 01:36:17 +0000 (01:36 +0000)]
Rebaseline after r100289

Unreviewed.

* fast/dom/Orientation/create-event-orientationchange-expected.txt: Fix line endings

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a connection client to the WKContext, to notify when new connections to the WebPr...
weinig@apple.com [Wed, 16 Nov 2011 01:35:14 +0000 (01:35 +0000)]
Add a connection client to the WKContext, to notify when new connections to the WebProcess are established
https://bugs.webkit.org/show_bug.cgi?id=72433

Reviewed by Anders Carlsson.

* UIProcess/API/C/WKContext.cpp:
(WKContextSetConnectionClient):
* UIProcess/API/C/WKContext.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::initializeConnectionClient):
* UIProcess/WebContext.h:
Add connection client API.

* UIProcess/WebContextConnectionClient.cpp: Added.
(WebKit::WebContextConnectionClient::didCreateConnection):
* UIProcess/WebContextConnectionClient.h: Added.
Add basic implementation of the client. It is currently never triggered.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix a webkitpy test caused by renaming the accelerate-video flag in r100355.
tony@chromium.org [Wed, 16 Nov 2011 01:29:22 +0000 (01:29 +0000)]
Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[v8] Use throwError instead of compiling and running script in handleMaxRecursionDept...
adamk@chromium.org [Wed, 16 Nov 2011 01:27:52 +0000 (01:27 +0000)]
[v8] Use throwError instead of compiling and running script in handleMaxRecursionDepthExceeded
https://bugs.webkit.org/show_bug.cgi?id=72432

Reviewed by Adam Barth.

Source/WebCore:

* bindings/v8/V8Proxy.cpp:
(WebCore::handleMaxRecursionDepthExceeded):

LayoutTests:

Updated test that depends on the error message. The new message is a
strict improvement, as it includes the line number at which the
too-deep call was triggered. Also, we only expect a single error
message; it's not clear why the previous version generated a dup.

Also consolidate expectations, as the test does not differ per platform.

* platform/chromium-cg-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Removed.
* platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Removed.
* platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Removed.
* platform/chromium/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoved a use of ArgList that baked in the assumption that arguments
ggaren@apple.com [Wed, 16 Nov 2011 01:25:17 +0000 (01:25 +0000)]
Removed a use of ArgList that baked in the assumption that arguments
are forward in the regiter file.

Reviewed by Sam Weinig.

* dfg/DFGOperations.cpp:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION): Use new API.

* runtime/ArgList.cpp:
(JSC::ArgList::getSlice): No need to provide an arbitrary constructor --
getSlice can do the right thing by using its rights to private data.

* runtime/ArgList.h: Removed constructor that took a forward-contiguous
set of arguments.

* runtime/JSArray.cpp:
(JSC::JSArray::finishCreation):
* runtime/JSArray.h:
(JSC::JSArray::create):
* runtime/JSGlobalObject.h:
(JSC::constructArray): Added explicit support for creating an array from
a pre-allocated set of values, so we could stop relying on the ArgList
API we want to remove.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, fix test-webkitpy tests. Move the check for image results
tony@chromium.org [Wed, 16 Nov 2011 01:23:19 +0000 (01:23 +0000)]
Unreviewed, fix test-webkitpy tests.  Move the check for image results
earlier.

* Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPointer Lock: Refactoring: PointerLock.idl: Dropping webkit prefix
scheib@chromium.org [Wed, 16 Nov 2011 01:06:13 +0000 (01:06 +0000)]
Pointer Lock: Refactoring: PointerLock.idl: Dropping webkit prefix
https://bugs.webkit.org/show_bug.cgi?id=72431

Reviewed by Adam Barth.

* page/PointerLock.cpp:
(WebCore::PointerLock::lock):
(WebCore::PointerLock::unlock):
(WebCore::PointerLock::isLocked):
* page/PointerLock.h:
* page/PointerLock.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Fuse MainThread and CCThread
nduca@chromium.org [Wed, 16 Nov 2011 00:56:05 +0000 (00:56 +0000)]
[chromium] Fuse MainThread and CCThread
https://bugs.webkit.org/show_bug.cgi?id=72426

Reviewed by James Robinson.

Source/WebCore:

* WebCore.gypi:
* platform/graphics/chromium/LayerRendererChromium.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
* platform/graphics/chromium/cc/CCMainThread.cpp: Removed.
* platform/graphics/chromium/cc/CCMainThread.h: Removed.
* platform/graphics/chromium/cc/CCMainThreadTask.h: Removed.
* platform/graphics/chromium/cc/CCProxy.cpp:
(WebCore::CCProxy::setMainThread):
(WebCore::CCProxy::mainThread):
(WebCore::CCProxy::setImplThread):
(WebCore::CCProxy::implThread):
(WebCore::CCProxy::isMainThread):
(WebCore::CCProxy::isImplThread):
(WebCore::CCProxy::~CCProxy):
* platform/graphics/chromium/cc/CCProxy.h:
* platform/graphics/chromium/cc/CCScopedThreadProxy.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCScopedMainThreadProxy.h.
(WebCore::CCScopedThreadProxy::create):
(WebCore::CCScopedThreadProxy::postTask):
(WebCore::CCScopedThreadProxy::shutdown):
(WebCore::CCScopedThreadProxy::CCScopedThreadProxy):
(WebCore::CCScopedThreadProxy::runTaskIfNotShutdown):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::setNeedsAnimate):
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::onSwapBuffersCompleteOnImplThread):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::setVisible):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::obtainBeginFrameAndCommitTaskFromCCThread):
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnImplThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
(WebCore::CCThreadProxy::initializeImplOnImplThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

* WebKit.gyp:
* WebKit.gypi:
* src/CCMainThreadImpl.cpp: Removed.
* src/CCThreadImpl.cpp:
(WebKit::CCThreadImpl::CCThreadImpl):
* src/WebCompositorImpl.cpp:
(WebKit::WebCompositor::setThread):
* src/WebKit.cpp:
(WebKit::initializeWithoutV8):
(WebKit::shutdown):
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::endTest):
* tests/CCThreadTest.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJS Test Harness: Remove need to load external css file to reduce flakiness
arv@chromium.org [Wed, 16 Nov 2011 00:45:48 +0000 (00:45 +0000)]
JS Test Harness: Remove need to load external css file to reduce flakiness
https://bugs.webkit.org/show_bug.cgi?id=72295

Reviewed by Ojan Vafai.

Before this patch we pulled in the external CSS file using a link tag. Since this was created dynamically
it might not be loaded and applied when we dump the text for the test. Since the CSS contains white-space
pre-wrap the output was therefore different depending on this race condition. By changing this to use a
style element with the CSS inline there is no longer a race condition.

* css3/font-feature-settings-parsing.html: Change the order of script and stylesheets so that the injected style element does not affect the test.
* fast/css/counters/counter-cssText.html: Ditto.
* fast/css/counters/getCounterValue.html: Ditto.
* fast/dom/StyleSheet/gc-styleheet-wrapper.xhtml: Ditto.
* traversal/script-tests/exception-forwarding.js: Ditto.
* fast/dom/script-tests/domListEnumeration.js: Update the tests to use the right style elements.
* fast/js/resources/js-test-pre.js: Insert a style element with the css instead of a link element pointing to an external css file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
jamesr@google.com [Wed, 16 Nov 2011 00:43:50 +0000 (00:43 +0000)]
[chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
https://bugs.webkit.org/show_bug.cgi?id=72444

Reviewed by Adam Barth.

* DumpRenderTree/chromium/DumpRenderTree.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark a test as flakily failing.
pkasting@chromium.org [Wed, 16 Nov 2011 00:40:27 +0000 (00:40 +0000)]
Mark a test as flakily failing.
https://bugs.webkit.org/show_bug.cgi?id=72269

Unreviewed, gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPointer Lock: Refactor: MouseEvent.idl movementX/Y
scheib@chromium.org [Wed, 16 Nov 2011 00:34:00 +0000 (00:34 +0000)]
Pointer Lock: Refactor: MouseEvent.idl movementX/Y
https://bugs.webkit.org/show_bug.cgi?id=72427

- [Conditional...] vs #if defined
- Runtime enabled
- .movementX/Y prefixed with 'webkit'

Reviewed by Adam Barth.

No new tests.

* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webkitMovementXEnabled):
(WebCore::RuntimeEnabledFeatures::webkitMovementYEnabled):
* dom/MouseEvent.idl:
* dom/MouseRelatedEvent.h:
(WebCore::MouseRelatedEvent::webkitMovementX):
(WebCore::MouseRelatedEvent::webkitMovementY):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoimplement flex-align for flex-flow: column
ojan@chromium.org [Wed, 16 Nov 2011 00:29:12 +0000 (00:29 +0000)]
implement flex-align for flex-flow: column
https://bugs.webkit.org/show_bug.cgi?id=70754

Reviewed by David Hyatt.

Source/WebCore:

Tests: css3/flexbox/flex-align-column.html
       css3/flexbox/line-wrapping.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
When flexitems are column, they should size to the intrinsic width unless flex-flow is stretch.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::alignChildrenBlockDirection):
This was just using the wrong, non-flow-aware method.

LayoutTests:

* css3/flexbox/flex-align-column-expected.txt: Added.
* css3/flexbox/flex-align-column.html: Added.
Tests the basic flex-align cases with column.

* css3/flexbox/line-wrapping-expected.txt: Added.
* css3/flexbox/line-wrapping.html: Added.
This tests that wrapping inside flexitems uses the correct width.
Notably, auto-sizing properly falls back on the initial containing block.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark another test as flakily crashing.
pkasting@chromium.org [Wed, 16 Nov 2011 00:27:08 +0000 (00:27 +0000)]
Mark another test as flakily crashing.
https://bugs.webkit.org/show_bug.cgi?id=59552

Unreviewed, gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in JSC::DFG::OSRExitCompiler::compileExit(JSC::DFG::OSRExit const&, JSC::DFG...
fpizlo@apple.com [Wed, 16 Nov 2011 00:26:30 +0000 (00:26 +0000)]
Crash in JSC::DFG::OSRExitCompiler::compileExit(JSC::DFG::OSRExit const&, JSC::DFG::SpeculationRecovery*)
https://bugs.webkit.org/show_bug.cgi?id=72292

Reviewed by Geoff Garen.

We need to be careful about how we look for the baseline CodeBlock if we're lazy-compiling
an OSR exit after our CodeBlock has been jettisoned. In short, use CodeBlock::baselineVersion()
instead of CodeBlock::alternative().

No performance effect.

No tests because all of our heuristics work very hard to make sure that this never happens in
the first place. OSR exits are rare by design, and jettisoning of CodeBlocks (i.e. recompilation)
is even rarer. Furthermore, OSR exits after a CodeBlock has been jettisoned is rarer still
because the whole point of jettisoning is to bring the probability of future OSR exits to as
close to zero as possible. But even that isn't enough to trigger this bug; it requires the OSR
exit after a jettison to be the first of its kind; our whole design tries to ensure that
CodeBlocks tend to OSR exit at a handful (i.e. 1 in most cases) of points, and since jettisoning
is triggered by OSR, in most sane cases the OSR exits after jettison will not require lazy OSR
compilation. So this is a truly evil case, and any test for it would be quite fragile.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::specializationKind):
(JSC::CodeBlock::largeFailCountThreshold):
(JSC::CodeBlock::largeFailCountThresholdForLoop):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::baselineCodeBlockFor):
(JSC::DFG::AssemblyHelpers::baselineCodeBlock):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGOSRExitCompiler.cpp:
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[SOUP][WK2] Add initial WebCookieManagerSoup.cpp for webkit2
commit-queue@webkit.org [Wed, 16 Nov 2011 00:26:15 +0000 (00:26 +0000)]
[SOUP][WK2] Add initial WebCookieManagerSoup.cpp for webkit2
https://bugs.webkit.org/show_bug.cgi?id=72235

Patch by Jongseok Yang <js45.yang@samsung.com> on 2011-11-15
Reviewed by Gustavo Noronha Silva.

Add WebCookieManagerSoup.cpp and implement functions for the cookie accept policy.
It's required when using the soup network backend.
Remove WebCookieManagerEfl.cpp and WebCookieManagerGtk.cpp because GTK port and
EFL port use soup network backend without a network backend of their own.

* GNUmakefile.am:
* WebProcess/Cookies/efl/WebCookieManagerEfl.cpp: Removed.
* WebProcess/Cookies/gtk/WebCookieManagerGtk.cpp: Removed.
* WebProcess/Cookies/soup/WebCookieManagerSoup.cpp: Added.
(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agor100331 did not seem to commit precisely the right expectation.
pkasting@chromium.org [Wed, 16 Nov 2011 00:24:40 +0000 (00:24 +0000)]
r100331 did not seem to commit precisely the right expectation.
https://bugs.webkit.org/show_bug.cgi?id=72391

Unreviewed, gardening.

* fast/dom/Orientation/create-event-orientationchange-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed expectations update for compositing tests
jamesr@google.com [Wed, 16 Nov 2011 00:23:44 +0000 (00:23 +0000)]
[chromium] Unreviewed expectations update for compositing tests
https://bugs.webkit.org/show_bug.cgi?id=72402

Remove now-unnecessary expectations for compositing tests in chromium-gpu* directories and update
test_expectations.txt to un-SKIP compositing tests. Compositing tests are still marked as PASS FAIL
in order to ensure they pass on all bots before turning them on.

File list removed due to length.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSkip editing/pasteboard/data-transfer-items-image-png.html, a ref test, on platforms...
tony@chromium.org [Wed, 16 Nov 2011 00:20:03 +0000 (00:20 +0000)]
Skip editing/pasteboard/data-transfer-items-image-png.html, a ref test, on platforms that
don't currently support DataTransferItems.

* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark a test as flakily crashing.
pkasting@chromium.org [Wed, 16 Nov 2011 00:17:03 +0000 (00:17 +0000)]
Mark a test as flakily crashing.
https://bugs.webkit.org/show_bug.cgi?id=72436

Unreviewed, gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium baselines after http://trac.webkit.org/changeset/100324.
ojan@chromium.org [Wed, 16 Nov 2011 00:09:51 +0000 (00:09 +0000)]
Chromium baselines after trac.webkit.org/changeset/100324.

* platform/chromium-linux/css3/flexbox/repaint-rtl-column-expected.png:
* platform/chromium-win/css3/flexbox/repaint-rtl-column-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, better fix for ref tests failures on SL Intel bot.
tony@chromium.org [Wed, 16 Nov 2011 00:04:20 +0000 (00:04 +0000)]
Unreviewed, better fix for ref tests failures on SL Intel bot.
Revert the previous change and return None if pixel results from
either the test page or the expected page is missing.

* Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Merge chromium-gpu layout test configurations into non-gpu versions
jamesr@google.com [Wed, 16 Nov 2011 00:02:33 +0000 (00:02 +0000)]
[chromium] Merge chromium-gpu layout test configurations into non-gpu versions
https://bugs.webkit.org/show_bug.cgi?id=72402

Reviewed by Dirk Pranke.

Tools:

Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing
triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d
and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu
and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for
the normal compositing triggers since we currently run the compositing tests in only one configuration - with
compositing enabled.

Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this
patch should not impact any tests.

* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::setAcceleratedCompositingForVideoEnabled):
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
* DumpRenderTree/chromium/WebPreferences.h:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark a test as flakily failing.
pkasting@chromium.org [Tue, 15 Nov 2011 23:54:51 +0000 (23:54 +0000)]
Mark a test as flakily failing.
https://bugs.webkit.org/show_bug.cgi?id=72434

Unreviewed, gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename ReferrerPolicy to clarify its meaning
jochen@chromium.org [Tue, 15 Nov 2011 23:52:28 +0000 (23:52 +0000)]
Rename ReferrerPolicy to clarify its meaning
https://bugs.webkit.org/show_bug.cgi?id=72420

Reviewed by Nate Chapin.

Source/WebCore:

On the one hand, even if the ReferrerPolicy was set to SendReferrer, the
referrer wasn't necessarily send. On the other hand, I want to use the
name ReferrerPolicy when implementing the meta referrer tag.

No change in behavior expected so no test.

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::handleClick):
(WebCore::handleLinkClick):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::changeLocation):
(WebCore::FrameLoader::urlSelected):
(WebCore::FrameLoader::loadFrameRequest):
* loader/FrameLoader.h:
* loader/FrameLoaderTypes.h:
* loader/NavigationScheduler.cpp:
(WebCore::ScheduledHistoryNavigation::fire):
(WebCore::ScheduledFormSubmission::fire):
* page/ContextMenuController.cpp:
(WebCore::openNewWindow):
(WebCore::ContextMenuController::contextMenuItemSelected):
* WebCore.exp.in: updated.

Source/WebKit/chromium:

* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::loadFrameRequest):

Source/WebKit/mac:

* WebView/WebPDFView.mm:
(-[WebPDFView PDFViewWillClickOnLink:withURL:]):

Source/WebKit/qt:

* Api/qwebpage.cpp:
(openNewWindow):
(QWebPage::triggerAction):

Source/WebKit/win:

* WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::searchWithGoogle):

Source/WebKit2:

* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::searchWithGoogle):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::linkClicked):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, try to fix ref tests failures on SL Intel bot.
tony@chromium.org [Tue, 15 Nov 2011 23:50:57 +0000 (23:50 +0000)]
Unreviewed, try to fix ref tests failures on SL Intel bot.
It looks like ImageDiff isn't returning an image diff.

* Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed fix of ref-tests on GTK+.
tony@chromium.org [Tue, 15 Nov 2011 23:41:53 +0000 (23:41 +0000)]
Unreviewed fix of ref-tests on GTK+.
If a driver is never started, _xvfb_process is never set.

* Scripts/webkitpy/layout_tests/port/gtk.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoset a max-width on the codereview overall comments textarea
tony@chromium.org [Tue, 15 Nov 2011 23:40:57 +0000 (23:40 +0000)]
set a max-width on the codereview overall comments textarea
https://bugs.webkit.org/show_bug.cgi?id=72415

Reviewed by Ojan Vafai.

Otherwise, when resizing the textarea you can end up making wider, but
are no longer able to click the resize gripper to make it smaller
(it's under another div).

* PrettyPatch/PrettyPatch.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFactor out V8Proxy's max recursion depth handling code
adamk@chromium.org [Tue, 15 Nov 2011 23:34:04 +0000 (23:34 +0000)]
Factor out V8Proxy's max recursion depth handling code
https://bugs.webkit.org/show_bug.cgi?id=72422

Reviewed by Nate Chapin.

Previously, V8Proxy used slightly different code to handle stack limit
violations depending on whether they occured in runScript or
callFunction. As described in http://webkit.org/b/72063, I intend to
expand the usage of m_recursion when calling into script. This patch
is intended to unify the existing handling code, making it easier to
move elsewhere without causing unintended side-effects.

No tests changed, as the only change in behavior is the string passed
to RangeError in the runScript case, and it's not mentioned anywhere
in the LayoutTests.

* bindings/v8/V8Proxy.cpp:
(WebCore::handleMaxRecursionDepthExceeded):
(WebCore::V8Proxy::runScript): Use callFunction's factored-out code.
(WebCore::V8Proxy::callFunction): Simplify and factor out code into handleMaxRecursionDepthExceeded.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSkip failing ref tests on Qt.
tony@chromium.org [Tue, 15 Nov 2011 23:29:19 +0000 (23:29 +0000)]
Skip failing ref tests on Qt.

* platform/qt/Skipped: editing/pasteboard/data-transfer-items-image-png.html and
    fast/forms/file/file-input-reset.html are failing. See bugs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix windows build.
weinig@apple.com [Tue, 15 Nov 2011 23:27:10 +0000 (23:27 +0000)]
Fix windows build.

* win/WebKit2Generated.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark another test as flakily crashing.
pkasting@chromium.org [Tue, 15 Nov 2011 23:23:32 +0000 (23:23 +0000)]
Mark another test as flakily crashing.
https://bugs.webkit.org/show_bug.cgi?id=59552

Unreviewed, gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNSURLRequest leak beneath ResourceRequest::setStorageSession seen on Leaks bot.
jberlin@webkit.org [Tue, 15 Nov 2011 23:21:53 +0000 (23:21 +0000)]
NSURLRequest leak beneath ResourceRequest::setStorageSession seen on Leaks bot.
https://bugs.webkit.org/show_bug.cgi?id=72419

Reviewed by Adam Roben.

Adopt the copied NSURLRequest.

* platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::setStorageSession):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPage/layer flashes after GPU-accelerated CSS transition
commit-queue@webkit.org [Tue, 15 Nov 2011 23:07:48 +0000 (23:07 +0000)]
Page/layer flashes after GPU-accelerated CSS transition
https://bugs.webkit.org/show_bug.cgi?id=72343

LayerRendererChromium was resizing the window to 1x1 at initialization.
In some cases, there is no drawLayers before switching back to
software rendering. This left the window resized to 1x1 and the
following software paints would therefore not be visible. This change
moves the reshape call into drawLayers so that it will only be called
if rendering will occur.

Patch by John Bates <jbates@google.com> on 2011-11-15
Reviewed by James Robinson.

New test: CCLayerTreeHostImplTest.reshapeNotCalledUntilDraw.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::doViewportChanged):
(WebCore::LayerRendererChromium::drawLayersInternal):
* platform/graphics/chromium/LayerRendererChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd the needed plumbing to parse display: -webkit-grid
jchaffraix@webkit.org [Tue, 15 Nov 2011 23:05:28 +0000 (23:05 +0000)]
Add the needed plumbing to parse display: -webkit-grid
https://bugs.webkit.org/show_bug.cgi?id=72331

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/css-grid-layout/display-grid-set-get.html

Added parsing support for display: -webkit-grid. From a rendering perspective,
the value is equivalent to display: none until we properly implement it.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSValueKeywords.in:
* rendering/style/RenderStyleConstants.h:
Added the new CSS value and plumbed the parsing and style application of
the new value.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator EDisplay):
Added an ASSERT here as I bumped into some non-trivial issues due to bug 72296.
-wap-marquee was offsetting the new value and was wrongly casted by the CSSPrimitiveValueMapping
logic outside the EDisplay range which would lead to crashes.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
Fixed the indentation to follow our coding rules.

LayoutTests:

* fast/css-grid-layout/display-grid-set-get-expected.txt: Added.
* fast/css-grid-layout/display-grid-set-get.html: Added.
* fast/css-grid-layout/resources/display-grid-set-get.js: Added.
Test that setting the display to -webkit-grid (from JS or CSS) works
and we get the right value back.

* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
SKIP the css-grid-layout tests on all platforms for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100338 268f45cc-cd09-0410-ab3c-d52691b4dbfc