WebKit-https.git
7 years agoRename paintingGoesToWindow() to paintsIntoWindow()
simon.fraser@apple.com [Fri, 6 Apr 2012 22:55:45 +0000 (22:55 +0000)]
Rename paintingGoesToWindow() to paintsIntoWindow()
https://bugs.webkit.org/show_bug.cgi?id=83406

Reviewed by Dirk Schulze.

Rename paintingGoesToWindow() to paintsIntoWindow() to be consistent
with some future refactoring.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintsWithTransform):
(WebCore::RenderLayer::setBackingNeedsRepaint):
(WebCore::RenderLayer::setBackingNeedsRepaintInRect):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::containsPaintedContent):
(WebCore::RenderLayerBacking::paintsIntoWindow):
(WebCore::RenderLayerBacking::paintIntoLayer):
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::rootLayerAttachmentChanged):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):
* rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRoll out change to HTMLParserIdioms.cpp from 82857
simonjam@chromium.org [Fri, 6 Apr 2012 22:53:20 +0000 (22:53 +0000)]
Roll out change to HTMLParserIdioms.cpp from 82857
https://bugs.webkit.org/show_bug.cgi?id=83402

Change 82857 causes a DCHECK on fast/forms/number/ValidityState-typeMismatch-number.html

Darin suggested we roll out this file here: https://bugs.webkit.org/show_bug.cgi?id=82857#c20

Unreviewed, rolling out change that broke tests.

* html/parser/HTMLParserIdioms.cpp:
(WebCore::parseToDoubleForNumberType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRoll Chromium DEPS
fischman@chromium.org [Fri, 6 Apr 2012 22:49:11 +0000 (22:49 +0000)]
Roll Chromium DEPS
https://bugs.webkit.org/show_bug.cgi?id=83389

Unreviewed, just a DEPS roll (130110:131183)

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAllow site authors to override autofilled fields' colors.
isherman@chromium.org [Fri, 6 Apr 2012 22:48:44 +0000 (22:48 +0000)]
Allow site authors to override autofilled fields' colors.
https://bugs.webkit.org/show_bug.cgi?id=66032
http://code.google.com/p/chromium/issues/detail?id=46543

Reviewed by Simon Fraser.

Source/WebCore:

* css/html.css:
(input:-webkit-autofill): Remove !important declarations.

LayoutTests:

* fast/forms/input-autofilled-expected.txt:
* fast/forms/input-autofilled.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoProvide Obj-C private API to simplify markup.
enrica@apple.com [Fri, 6 Apr 2012 22:44:02 +0000 (22:44 +0000)]
Provide Obj-C private API to simplify markup.
https://bugs.webkit.org/show_bug.cgi?id=83334
<rdar://problem/11033861>

Reviewed by Sam Weinig.

Source/WebCore:

Added test in TestWebKitAPI

* WebCore.exp.in:
* editing/Editor.cpp:
(WebCore::Editor::simplifyMarkup): Exposing the new command through the editor.
* editing/Editor.h:

Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView _simplifyMarkup:endNode:]): Added.
* WebView/WebViewPrivate.h:

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/SimplifyMarkup.mm: Added.
(-[SimplifyMarkupTest webView:didFinishLoadForFrame:]):
* TestWebKitAPI/Tests/mac/verboseMarkup.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoclone baselines from platform/win to platform/chromium-win
dpranke@chromium.org [Fri, 6 Apr 2012 22:43:54 +0000 (22:43 +0000)]
clone baselines from platform/win to platform/chromium-win
https://bugs.webkit.org/show_bug.cgi?83394

Unreviewed, expectations change.

Copies the win baselines that chromium depends on into a
chromium dir, so that we can remove the dependency on win down
the road.

* platform/chromium-win/accessibility/aria-fallback-roles-expected.txt: Added.
* platform/chromium-win/accessibility/detached-object-notification-crash-expected.txt: Added.
* platform/chromium-win/accessibility/document-enabled-state-expected.txt: Added.
* platform/chromium-win/accessibility/document-role-expected.txt: Added.
* platform/chromium-win/accessibility/focus-events-expected.txt: Added.
* platform/chromium-win/accessibility/heading-elements-expected.txt: Added.
* platform/chromium-win/accessibility/img-alt-attribute-expected.txt: Added.
* platform/chromium-win/accessibility/linked-elements-expected.txt: Added.
* platform/chromium-win/accessibility/list-item-role-expected.txt: Added.
* platform/chromium-win/accessibility/list-marker-role-expected.txt: Added.
* platform/chromium-win/accessibility/list-role-expected.txt: Added.
* platform/chromium-win/accessibility/multiple-select-element-role-expected.txt: Added.
* platform/chromium-win/accessibility/option-element-position-and-size-expected.txt: Added.
* platform/chromium-win/accessibility/option-element-selection-and-focus-events-expected.txt: Added.
* platform/chromium-win/accessibility/parent-element-expected.txt: Added.
* platform/chromium-win/accessibility/scroll-to-anchor-expected.txt: Added.
* platform/chromium-win/accessibility/select-element-role-expected.txt: Added.
* platform/chromium-win/accessibility/select-element-valuechange-event-expected.txt: Added.
* platform/chromium-win/accessibility/selection-and-focus-expected.txt: Added.
* platform/chromium-win/accessibility/single-select-children-changed-expected.txt: Added.
* platform/chromium-win/accessibility/single-select-children-expected.txt: Added.
* platform/chromium-win/accessibility/text-role-expected.txt: Added.
* platform/chromium-win/compositing/plugins/composited-plugin-expected.txt: Added.
* platform/chromium-win/compositing/plugins/small-to-large-composited-plugin-expected.txt: Added.
* platform/chromium-win/editing/selection/anchor-focus2-expected.txt: Added.
* platform/chromium-win/editing/selection/anchor-focus3-expected.txt: Added.
* platform/chromium-win/editing/selection/collapse-selection-in-bidi-expected.txt: Added.
* platform/chromium-win/editing/selection/doubleclick-should-not-expand-across-lines-expected.txt: Added.
* platform/chromium-win/editing/selection/drag-text-delay-expected.txt: Added.
* platform/chromium-win/editing/selection/extend-selection-home-end-expected.txt: Added.
* platform/chromium-win/editing/selection/mixed-editability-10-expected.txt: Added.
* platform/chromium-win/editing/selection/shift-page-up-down-expected.txt: Added.
* platform/chromium-win/editing/selection/transformed-selection-rects-expected.txt: Added.
* platform/chromium-win/fast/css/zoom-body-scroll-expected.txt: Added.
* platform/chromium-win/fast/dom/Element/id-in-deletebutton-expected.txt: Added.
* platform/chromium-win/fast/dom/Window/window-properties-expected.txt: Added.
* platform/chromium-win/fast/dom/prototype-inheritance-2-expected.txt: Added.
* platform/chromium-win/fast/events/alt-numpad-expected.txt: Added.
* platform/chromium-win/fast/events/alt-space-scroll-expected.txt: Added.
* platform/chromium-win/fast/events/context-click-events-expected.txt: Added.
* platform/chromium-win/fast/events/double-dead-char-expected.txt: Added.
* platform/chromium-win/fast/events/keyLocation-numpad-expected.txt: Added.
* platform/chromium-win/fast/events/panScroll-click-hyperlink-expected.txt: Added.
* platform/chromium-win/fast/events/panScroll-correct-direction-expected.txt: Added.
* platform/chromium-win/fast/events/panScroll-event-fired-expected.txt: Added.
* platform/chromium-win/fast/events/panScroll-image-no-scroll-expected.txt: Added.
* platform/chromium-win/fast/events/panScroll-imageMap-href-no-scroll-expected.txt: Added.
* platform/chromium-win/fast/events/panScroll-imageMap-noHref-scroll-expected.txt: Added.
* platform/chromium-win/fast/events/panScroll-nested-divs-expected.txt: Added.
* platform/chromium-win/fast/events/panScroll-no-iframe-jump-expected.txt: Added.
* platform/chromium-win/fast/events/panScroll-preventDefault-expected.txt: Added.
* platform/chromium-win/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
* platform/chromium-win/fast/forms/select-popup-pagekeys-expected.txt: Added.
* platform/chromium-win/fast/images/support-broken-image-delegate-expected.txt: Added.
* platform/chromium-win/fast/js/global-constructors-expected.txt: Added.
* platform/chromium-win/fast/loader/stateobjects/state-url-sets-links-visited-expected.txt: Added.
* platform/chromium-win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
* platform/chromium-win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
* platform/chromium-win/fast/replaced/table-percent-height-text-controls-expected.txt: Added.
* platform/chromium-win/fast/text/capitalize-boundaries-expected.txt: Added.
* platform/chromium-win/fast/text/emphasis-combined-text-expected.txt: Added.
* platform/chromium-win/fast/text/emphasis-expected.png: Added.
* platform/chromium-win/fast/text/emphasis-expected.txt: Added.
* platform/chromium-win/fast/text/emphasis-vertical-expected.png: Added.
* platform/chromium-win/fast/text/emphasis-vertical-expected.txt: Added.
* platform/chromium-win/fast/text/fallback-traits-fixup-expected.txt: Added.
* platform/chromium-win/fast/text/international/hindi-whitespace-expected.png: Added.
* platform/chromium-win/fast/text/international/hindi-whitespace-expected.txt: Added.
* platform/chromium-win/fast/text/international/text-combine-image-test-expected.png: Added.
* platform/chromium-win/fast/text/international/text-combine-image-test-expected.txt: Added.
* platform/chromium-win/fast/text/international/vertical-text-glyph-test-expected.png: Added.
* platform/chromium-win/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
* platform/chromium-win/fast/text/international/vertical-text-metrics-test-expected.txt: Added.
* platform/chromium-win/fast/text/justify-ideograph-complex-expected.txt: Added.
* platform/chromium-win/fast/text/justify-ideograph-simple-expected.txt: Added.
* platform/chromium-win/fast/text/justify-ideograph-vertical-expected.txt: Added.
* platform/chromium-win/fast/text/uniscribe-item-boundary-crash-expected.txt: Added.
* platform/chromium-win/fast/text/uniscribe-missing-glyph-expected.txt: Added.
* platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
* platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
* platform/chromium-win/fast/writing-mode/border-vertical-lr-expected.png: Added.
* platform/chromium-win/fast/writing-mode/border-vertical-lr-expected.txt: Added.
* platform/chromium-win/fast/writing-mode/japanese-lr-selection-expected.png: Added.
* platform/chromium-win/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
* platform/chromium-win/fast/writing-mode/japanese-rl-selection-expected.png: Added.
* platform/chromium-win/fast/writing-mode/japanese-rl-selection-expected.txt: Added.
* platform/chromium-win/fast/writing-mode/text-orientation-basic-expected.png: Added.
* platform/chromium-win/fast/writing-mode/text-orientation-basic-expected.txt: Added.
* platform/chromium-win/fast/writing-mode/vertical-font-fallback-expected.txt: Added.
* platform/chromium-win/inverted-colors/non-composited-expected.png: Added.
* platform/chromium-win/inverted-colors/non-composited-expected.txt: Added.
* platform/chromium-win/platform/win/plugins/draws-gradient-expected.png: Added.
* platform/chromium-win/platform/win/plugins/draws-gradient-expected.txt: Added.
* platform/chromium-win/plugins/call-javascript-that-destroys-plugin-expected.txt: Added.
* platform/chromium-win/plugins/get-value-netscape-window-expected.txt: Added.
* platform/chromium-win/plugins/iframe-inside-overflow-expected.txt: Added.
* platform/chromium-win/plugins/npn-invalidate-rect-invalidates-window-expected.txt: Added.
* platform/chromium-win/plugins/npp-set-window-called-during-destruction-expected.txt: Added.
* platform/chromium-win/plugins/plugin-javascript-access-expected.txt: Added.
* platform/chromium-win/plugins/resize-from-plugin-expected.txt: Added.
* platform/chromium-win/plugins/visibility-hidden-expected.png: Added.
* platform/chromium-win/plugins/visibility-hidden-expected.txt: Added.
* platform/chromium-win/plugins/window-geometry-initialized-before-set-window-expected.txt: Added.
* platform/chromium-win/plugins/window-region-is-set-to-clip-rect-expected.txt: Added.
* platform/chromium-win/plugins/windowless-paint-rect-coordinates-expected.txt: Added.
* platform/chromium-win/printing/page-rule-in-media-query-expected.txt: Added.
* platform/chromium-win/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Percent/S11.5.3_A4_T6-expected.txt: Added.
* platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenamed
ggaren@apple.com [Fri, 6 Apr 2012 22:35:55 +0000 (22:35 +0000)]
Renamed

        WeakHeap => WeakSet
        HandleHeap => HandleSet

Reviewed by Sam Weinig.

These sets do have internal allocators, but it's confusing to call them
heaps because they're sub-objects of an object called "heap".

* heap/HandleHeap.cpp: Removed.
* heap/HandleHeap.h: Removed.
* heap/HandleSet.cpp: Copied from JavaScriptCore/heap/HandleHeap.cpp.
* heap/WeakHeap.cpp: Removed.
* heap/WeakHeap.h: Removed.
* heap/WeakSet.cpp: Copied from JavaScriptCore/heap/WeakHeap.cpp.
* heap/WeakSet.h: Copied from JavaScriptCore/heap/WeakHeap.h.

Plus global rename using grep.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonew-run-webkit-tests: fix bugs in 'mock' drt implementation
dpranke@chromium.org [Fri, 6 Apr 2012 22:30:37 +0000 (22:30 +0000)]
new-run-webkit-tests: fix bugs in 'mock' drt implementation
https://bugs.webkit.org/show_bug.cgi?id=83341

Reviewed by Eric Seidel.

The current implementation crashed in some circumstances for
reference tests and files that were missing expected results.
This patch fixes those cases and adds more unit tests; it is a
precursor to adding unit tests each port that actually uses this
code, in order to get better coverage of the port/*
implementations.

* Scripts/webkitpy/layout_tests/port/mock_drt.py:
(parse_options):
(MockDRT.input_from_line):
(MockDRT.output_for_test):
(MockDRT.run_one_test):
(MockChromiumDRT.input_from_line):
(MockChromiumDRT.output_for_test):
(MockChromiumDRT.run_one_test):
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockDRTTest.make_input_output):
(MockDRTTest.expected_output):
(MockDRTTest):
(MockDRTTest.assertTest):
(MockDRTTest.test_missing_image):
(MockDRTTest.test_missing_text):
(MockDRTTest.test_reftest_match):
(MockDRTTest.test_reftest_mismatch):
(MockChromiumDRTTest.expected_output):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening. This test is passing on chromium win and linux.
tony@chromium.org [Fri, 6 Apr 2012 22:24:49 +0000 (22:24 +0000)]
[chromium] Unreviewed gardening.  This test is passing on chromium win and linux.

* platform/chromium-linux-x86/fast/text/atsui-partial-selection-expected.png: Added.
* platform/chromium-win/fast/text/atsui-partial-selection-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGet rid of the useless flag PREEMPT_GEOLOCATION_PERMISSION
benjamin@webkit.org [Fri, 6 Apr 2012 22:23:32 +0000 (22:23 +0000)]
Get rid of the useless flag PREEMPT_GEOLOCATION_PERMISSION
https://bugs.webkit.org/show_bug.cgi?id=83325

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-06
Reviewed by Ryosuke Niwa.

Source/WebCore:

The flag WTF_USE_PREEMPT_GEOLOCATION_PERMISSION was added in r63742 but
was never disabled by anyone. Supporting this feature added complexity by
introducing two authorization scheme.

This patch removes WTF_USE_PREEMPT_GEOLOCATION_PERMISSION and the code supporting
granting the authorization after startUpdating().

* Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::GeoNotifier::runSuccessCallback): With the simplified
authorization code, we ensure stronger constraint on GeoNotifier::runSuccessCallback().
(WebCore::Geolocation::stop):
(WebCore::Geolocation::startRequest):
(WebCore::Geolocation::clearWatch):
(WebCore::Geolocation::setIsAllowed):
(WebCore::Geolocation::positionChanged): The case (!isAllowed()) was there
to support granting the authorization for WTF_USE_PREEMPT_GEOLOCATION_PERMISSION.
(WebCore::Geolocation::handlePendingPermissionNotifiers):
* Modules/geolocation/Geolocation.h:
(Geolocation):

Source/WebKit/blackberry:

* WebCoreSupport/AboutDataUseFeatures.in:

Source/WTF:

* wtf/Platform.h: Remove the flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed, rebaseline a test on Vista/Win7.
tony@chromium.org [Fri, 6 Apr 2012 22:16:08 +0000 (22:16 +0000)]
[chromium] Unreviewed, rebaseline a test on Vista/Win7.

* platform/chromium-linux/fast/encoding/invalid-UTF-8-expected.txt: Removed.
* platform/chromium-win/fast/encoding/invalid-UTF-8-expected.png:
* platform/chromium-win/fast/encoding/invalid-UTF-8-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBlock cross-origin iframe scroll to fragment.
tsepez@chromium.org [Fri, 6 Apr 2012 22:15:02 +0000 (22:15 +0000)]
Block cross-origin iframe scroll to fragment.
https://bugs.webkit.org/show_bug.cgi?id=73083

Reviewed by Adam Barth.

Add a restriction similar to what FF has done for all iframes for over a
year now. Our change is less disruptive in that it only does this in the
cross-orgin case, which is where the fragment scrolling is problematic.

Source/WebCore:

Test: http/tests/navigation/anchor-frames-cross-origin.html

* dom/Document.cpp:
(WebCore::Document::canBeAccessedByEveryAncestorFrame):
(WebCore):
* dom/Document.h:
(Document):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::finishedParsing):
(WebCore::FrameLoader::loadInSameDocument):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::shouldPerformFragmentNavigation):
(WebCore::FrameLoader::scrollToFragmentIfAllowed):
(WebCore):
* loader/FrameLoader.h:
(FrameLoader):

LayoutTests:

* http/tests/inspector/resource-parameters-expected.txt:
* http/tests/navigation/anchor-frames-cross-origin-expected.txt: Added.
* http/tests/navigation/anchor-frames-cross-origin.html: Added.
* http/tests/navigation/resources/frame-with-anchor-cross-origin.html: Added.
* http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt:
* http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-expected.txt:
* http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char-expected.txt:
* http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL-expected.txt:
* http/tests/security/xssAuditor/anchor-url-dom-write-location2-expected.txt:
* http/tests/security/xssAuditor/dom-write-location-inline-event-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebFullScreenManagerProxy::isFullScreen() will create an empty full screen window...
jer.noble@apple.com [Fri, 6 Apr 2012 21:49:11 +0000 (21:49 +0000)]
WebFullScreenManagerProxy::isFullScreen() will create an empty full screen window; steal focus.
https://bugs.webkit.org/show_bug.cgi?id=83388

Reviewed by Geoffrey Garen.

Calling WebFullScreenManagerProxy::isFullScreen() will create a WKFullScreenWindowController if
one does not already exist, since the -[WKView fullScreenWindowController] method will create-on-access.
Add a new call, -[WKView hasFullScreenWindowController], which does not auto-create the controller
and add that check to WebFullScreenManagerProxy::isFullScreen().

* UIProcess/API/mac/WKView.mm:
(-[WKView hasFullScreenWindowController]):
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/mac/WebFullScreenManagerProxyMac.mm:
(WebKit::WebFullScreenManagerProxy::isFullScreen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed, remove a passing test.
tony@chromium.org [Fri, 6 Apr 2012 21:48:33 +0000 (21:48 +0000)]
[chromium] Unreviewed, remove a passing test.
tables/mozilla/bugs/bug9024.html is passing on Leopard.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable webkit_unit_tests for commit queue and EWS while tracking failures
jamesr@google.com [Fri, 6 Apr 2012 21:45:50 +0000 (21:45 +0000)]
Enable webkit_unit_tests for commit queue and EWS while tracking failures
https://bugs.webkit.org/show_bug.cgi?id=83329

Reviewed by Adam Barth.

This adds a step to parse XML output from webkit_unit_tests and consider regressions in the PatchAnalysisTask so
the commit queue and EWS can reject patches that cause regressions.

* Scripts/webkitpy/common/config/ports.py:
(ChromiumPort.run_webkit_unit_tests_command):
* Scripts/webkitpy/common/config/ports_mock.py:
(MockPort.unit_tests_results_path):
* Scripts/webkitpy/common/net/layouttestresults.py:
(LayoutTestResults.__init__):
(LayoutTestResults.failing_tests):
(LayoutTestResults):
(LayoutTestResults.add_unit_test_failures):
* Scripts/webkitpy/common/net/unittestresults.py: Copied from Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py.
(UnitTestResults):
(UnitTestResults.results_from_string):
* Scripts/webkitpy/common/net/unittestresults_unittest.py: Added.
(UnitTestResultsTest):
(UnitTestResultsTest.test_nostring):
(UnitTestResultsTest.test_emptystring):
(UnitTestResultsTest.test_nofailures):
(test_onefailure):
(test_multiple_failures_per_test):
* Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
(MockCommitQueue.test_results):
(MockCommitQueue.archive_last_test_results):
(FailingTestCommitQueue.test_results):
(test_flaky_test_failure):
(test_failed_archive):
* Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
(LayoutTestResultsReader._create_unit_test_results):
(LayoutTestResultsReader.results):
* Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
(LayoutTestResultsReaderTest.test_missing_layout_test_results):
* Scripts/webkitpy/tool/bot/patchanalysistask.py:
(PatchAnalysisTaskDelegate.test_results):
(PatchAnalysisTaskDelegate.archive_last_test_results):
(PatchAnalysisTask._test):
(PatchAnalysisTask._build_and_test_without_patch):
(PatchAnalysisTask._test_patch):
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem.test_results):
(AbstractEarlyWarningSystem.archive_last_test_results):
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSytemTest._test_testing_ews):
* Scripts/webkitpy/tool/commands/queues.py:
(CommitQueue.test_results):
(CommitQueue.archive_last_test_results):
* Scripts/webkitpy/tool/commands/queues_unittest.py:
(CommitQueueTest.test_commit_queue):
(test_rollout):
(test_manual_reject_during_processing):
* Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
* Scripts/webkitpy/tool/steps/runtests_unittest.py:
(RunTestsTest.test_webkit_run_unit_tests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoForeground of apple.com/iphone video page visible during full screen animation.
jer.noble@apple.com [Fri, 6 Apr 2012 21:38:33 +0000 (21:38 +0000)]
Foreground of apple.com/iphone video page visible during full screen animation.
https://bugs.webkit.org/show_bug.cgi?id=83080

Reviewed by Simon Fraser.

Source/WebCore:

No new tests; updated fullscreen/full-screen-stacking-context.html

The apple.com/iphone video page uses a -webkit-mask: CSS style, which creates a stacking
context and causes the page to pop in front of the full screen renderer.  Add all the
styles suggested by the W3C full screen spec to the -webkit-full-screen-ancestor rule
to keep these stacking contexts from being created.

* css/fullscreen.css:
(:-webkit-full-screen-ancestor:not(iframe)):

LayoutTests:

* fullscreen/full-screen-stacking-context.html:
* platform/mac/fullscreen/full-screen-stacking-context-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoVirtualize createAnonymousBoxWithSameTypeAs.
inferno@chromium.org [Fri, 6 Apr 2012 21:32:55 +0000 (21:32 +0000)]
Virtualize createAnonymousBoxWithSameTypeAs.
https://bugs.webkit.org/show_bug.cgi?id=83229

Reviewed by Julien Chaffraix.

This helps to use the same function to create anonymous
table parts and in the future extend to more classes
derived from RenderBox.

The current switch case situation was going to be messy as
we will need to mix cases that were very dependent on the
class, so it made sense to add a virtual function.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::splitAnonymousBlocksAroundChild):
(WebCore::RenderBlock::createAnonymousBoxWithSameTypeAs):
* rendering/RenderBlock.h:
(RenderBlock):
* rendering/RenderBox.h:
(WebCore::RenderBox::createAnonymousBoxWithSameTypeAs):
(RenderBox):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::splitFlow):
* rendering/RenderTable.h:
(WebCore::RenderTable::createAnonymousBoxWithSameTypeAs):
* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::createAnonymousBoxWithSameTypeAs):
* rendering/RenderTableRow.h:
(WebCore::RenderTableRow::createAnonymousBoxWithSameTypeAs):
* rendering/RenderTableSection.h:
(WebCore::RenderTableSection::createAnonymousBoxWithSameTypeAs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[cg] REGRESSION (r101517): Animating the transform of a <rect> with shape-rendering...
timothy_horton@apple.com [Fri, 6 Apr 2012 21:31:02 +0000 (21:31 +0000)]
[cg] REGRESSION (r101517): Animating the transform of a <rect> with shape-rendering: crispEdges leaves behind garbage
https://bugs.webkit.org/show_bug.cgi?id=82963
<rdar://problem/11170476>

Reviewed by Simon Fraser.

CoreGraphics can inflate the stroke by 1px when drawing a rectangle
with antialiasing disabled at non-integer coordinates, we need to
compensate by inflating the RenderSVGRect repaint bounds by 1px.

No new tests, as this is not reproducible in DRT or WKTR.

* rendering/svg/RenderSVGRect.cpp:
(WebCore::RenderSVGRect::createShape):
(WebCore::RenderSVGRect::strokeBoundingBox):
* rendering/svg/RenderSVGRect.h:
(RenderSVGRect):

New Mac baselines for two tests which have SVG <rect>s with shape-rendering: crispEdges.

* platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
* platform/mac/svg/custom/shape-rendering-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTools: Enable MediaSource feature for DumpRenderTree so
commit-queue@webkit.org [Fri, 6 Apr 2012 21:19:26 +0000 (21:19 +0000)]
Tools: Enable MediaSource feature for DumpRenderTree so
MediaSource LayoutTests will pass for Chromium.
https://bugs.webkit.org/show_bug.cgi?id=83053

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-06
Reviewed by Dimitri Glazkov.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):

LayoutTests: Fix MediaSource LayoutTests to work with the new XHR behavior
that requires asynchronous requests for the 'arraybuffer'
responseType.
https://bugs.webkit.org/show_bug.cgi?id=83053

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-06
Reviewed by Dimitri Glazkov.

* http/tests/media/media-source/webm/video-media-source-errors.html:
* http/tests/media/media-source/webm/video-media-source-play.html:
* http/tests/media/media-source/webm/video-media-source-seek.html:
* http/tests/media/media-source/webm/video-media-source-state-changes.html:
* http/tests/media/media-source/webm/webm-media-source.js:
(getData.request.onload):
(createClusterGetFunction.return.if):
(createClusterGetFunction):
(loadWebMData):
(getCluster):
(appendCluster):
(getReadyStateName):
(expectSourceState):
(expectReadyState):
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAvoid trying to set filters on transform layers
simon.fraser@apple.com [Fri, 6 Apr 2012 21:17:55 +0000 (21:17 +0000)]
Avoid trying to set filters on transform layers
https://bugs.webkit.org/show_bug.cgi?id=83344

Reviewed by Dean Jackson.

Return early from GraphicsLayerCA::setFilters() when the filters
haven't changed. This avoids trying to clear filters on CALayers
which never had them, which should both help performance, and avoids
console spew related to setting shadow properties on transform layers.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setFilters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebGL content swapped at wrong time in threaded compositing mode
jamesr@google.com [Fri, 6 Apr 2012 21:15:55 +0000 (21:15 +0000)]
WebGL content swapped at wrong time in threaded compositing mode
https://bugs.webkit.org/show_bug.cgi?id=82275

Reviewed by Kenneth Russell.

Source/WebCore:

When using threaded compositing, we need to defer touching the texture ID being used by the compositor until the
appropriate point in the synchronization routine and not before. Specifically, there is no time at which it is
safe to manipulate the texture the compositor may be using from the main thread. This breaks up the presentation
path into a few pieces (depending on the context attributes) in order to maintain these invariants.

Depending on the context attributes and if we're in threaded mode, there are a few different possible back/front
buffer combinations:

- When the context is antialiased, we have a multisampled renderbuffer and associated framebuffer.
- In all cases, we have a color texture back buffer.
- When preserveDrawingBuffer is set or threaded compositing is enabled, we have a separate color texture as a
front buffer.

The resource update is in two phases. First, on the main thread, we prepare the back buffer. This resolves from
the multisampled FBO into the back color buffer if multisampled and swaps the front / back color buffer textures
if preserveDrawingBuffer is false and we're using separate front / back color buffers. Second, on the compositor
thread, we do a texture copy from the back to the front color buffer if preserveDrawingBuffer is true. After
these steps are complete the main thread is free to manipulate the back buffer color texture without affecting
any resources the compositor is using.

One incidental cleanup this patch also does is remove all state queries from DrawingBuffer::clearFramebuffer().

Tests: fast/canvas/webgl/webgl-composite-modes-repaint.html
       fast/canvas/webgl/webgl-composite-modes.html

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::clearIfComposited):
(WebCore::WebGLRenderingContext::restoreStateAfterClear):
(WebCore::WebGLRenderingContext::reshape):
(WebCore::WebGLRenderingContext::maybeRestoreContext):
* html/canvas/WebGLRenderingContext.h:
(WebGLRenderingContext):
* platform/graphics/blackberry/DrawingBufferBlackBerry.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore):
(WebCore::DrawingBuffer::prepareBackBuffer):
(WebCore::DrawingBuffer::requiresCopyFromBackToFrontBuffer):
(WebCore::DrawingBuffer::frontColorBuffer):
* platform/graphics/cairo/DrawingBufferCairo.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore):
(WebCore::DrawingBuffer::prepareBackBuffer):
(WebCore::DrawingBuffer::requiresCopyFromBackToFrontBuffer):
(WebCore::DrawingBuffer::frontColorBuffer):
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::generateColorTexture):
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::initialize):
(WebCore::DrawingBuffer::prepareBackBuffer):
(WebCore):
(WebCore::DrawingBuffer::requiresCopyFromBackToFrontBuffer):
(WebCore::DrawingBuffer::frontColorBuffer):
(WebCore::DrawingBuffer::platformLayer):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::WebGLLayerChromium):
(WebCore::WebGLLayerChromium::paintContentsIfDirty):
(WebCore::WebGLLayerChromium::updateCompositorResources):
(WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas):
(WebCore::WebGLLayerChromium::setNeedsDisplayRect):
(WebCore::WebGLLayerChromium::setDrawingBuffer):
* platform/graphics/chromium/WebGLLayerChromium.h:
(WebGLLayerChromium):
* platform/graphics/clutter/DrawingBufferClutter.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore):
(WebCore::DrawingBuffer::prepareBackBuffer):
(WebCore::DrawingBuffer::requiresCopyFromBackToFrontBuffer):
(WebCore::DrawingBuffer::frontColorBuffer):
* platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::initializeContext):
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::create):
(WebCore::DrawingBuffer::clear):
(WebCore::DrawingBuffer::clearFramebuffer):
(WebCore::DrawingBuffer::reset):
(WebCore::DrawingBuffer::discardResources):
* platform/graphics/gpu/DrawingBuffer.h:
(DrawingBuffer):
* platform/graphics/gpu/mac/DrawingBufferMac.mm:
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore):
(WebCore::DrawingBuffer::prepareBackBuffer):
(WebCore::DrawingBuffer::requiresCopyFromBackToFrontBuffer):
(WebCore::DrawingBuffer::frontColorBuffer):
* platform/graphics/gpu/qt/DrawingBufferQt.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::platformLayer):
(WebCore::DrawingBuffer::prepareBackBuffer):
(WebCore::DrawingBuffer::requiresCopyFromBackToFrontBuffer):
(WebCore):
(WebCore::DrawingBuffer::frontColorBuffer):

Source/WebKit/chromium:

* tests/WebGLLayerChromiumTest.cpp:
(WebKit::TEST):

LayoutTests:

Adds some pixel tests for compositing all different combinations of alpha/antialias/preserveDrawingBuffer on
WebGL content.

* fast/canvas/webgl/webgl-composite-modes-expected.png: Added.
* fast/canvas/webgl/webgl-composite-modes-expected.txt: Added.
* fast/canvas/webgl/webgl-composite-modes-repaint-expected.png: Added.
* fast/canvas/webgl/webgl-composite-modes-repaint-expected.txt: Added.
* fast/canvas/webgl/webgl-composite-modes-repaint.html: Added.
* fast/canvas/webgl/webgl-composite-modes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed, land some mac/win baselines for table tests after r111742.
tony@chromium.org [Fri, 6 Apr 2012 21:10:59 +0000 (21:10 +0000)]
[chromium] Unreviewed, land some mac/win baselines for table tests after r111742.

* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2123-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2509-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug34176-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug44505-expected.png:
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/scroll-inside-table-cell-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/scroll-relative-table-inside-table-cell-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2123-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2509-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug34176-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug44505-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
* platform/chromium-mac/fast/repaint/scroll-inside-table-cell-expected.png:
* platform/chromium-mac/fast/repaint/scroll-relative-table-inside-table-cell-expected.png:
* platform/chromium-mac/fast/table/cell-pref-width-invalidation-expected.txt: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug2123-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug2123-expected.txt: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug2509-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug2509-expected.txt: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug34176-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug34176-expected.txt: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug44505-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug44505-expected.txt:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug59252-expected.txt: Added.
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug7243-expected.txt: Added.
* platform/chromium-win/fast/repaint/scroll-inside-table-cell-expected.png:
* platform/chromium-win/fast/repaint/scroll-relative-table-inside-table-cell-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug44505-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug44505-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix after r113486 and r113487.
jchaffraix@webkit.org [Fri, 6 Apr 2012 20:41:20 +0000 (20:41 +0000)]
Unreviewed build fix after r113486 and r113487.

* rendering/RenderObject.cpp:
Added missing #include.

* rendering/RenderView.h:
Removed bad OVERRIDE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=81939
bdakin@apple.com [Fri, 6 Apr 2012 20:20:19 +0000 (20:20 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=81939
-webkit-image-set should update dynamically when the device scale factor
changes
-and corresponding-
<rdar://problem/11101108>

Reviewed by Darin Adler.

Source/WebCore:

New member variable to keep track of the scale factor.
* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::CSSImageSetValue):
(WebCore::CSSImageSetValue::bestImageForScaleFactor):

 Merge the two cachedImageSet functions. There was no need for two functions here.
(WebCore::CSSImageSetValue::cachedImageSet):

cachedOrPendingImageSet() now takes a Document as a parameter so that it can
access the deviceScaleFactor. If there is a cached image already and the
Document's deviceScaleFactor doesn't match m_scaleFactor, then m_imageSet is set
to a pending image so that the best fit image will be reassessed and then
loaded.
(WebCore::CSSImageSetValue::cachedOrPendingImageSet):
* css/CSSImageSetValue.h:
(WebCore):
(CSSImageSetValue):

cachedOrPendingImageSet() now takes a Document.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

StyleCachedImageSet should inherit from CachedImageClient just like
StyleCachedImage. It should add and remove itself as a client upon creation
and destruction, respectively.
* rendering/style/StyleCachedImageSet.cpp:
(WebCore::StyleCachedImageSet::StyleCachedImageSet):
(WebCore):
(WebCore::StyleCachedImageSet::~StyleCachedImageSet):
* rendering/style/StyleCachedImageSet.h:
(StyleCachedImageSet):

LayoutTests:

* fast/hidpi/image-set-background-dynamic.html: Added.
* fast/hidpi/image-set-border-image-dynamic.html: Added.
* fast/hidpi/image-set-in-content-dynamic.html: Added.
* platform/mac/fast/hidpi/image-set-background-dynamic-expected.png: Added.
* platform/mac/fast/hidpi/image-set-background-dynamic-expected.txt: Added.
* platform/mac/fast/hidpi/image-set-border-image-dynamic-expected.png: Added.
* platform/mac/fast/hidpi/image-set-border-image-dynamic-expected.txt: Added.
* platform/mac/fast/hidpi/image-set-in-content-dynamic-expected.png: Added.
* platform/mac/fast/hidpi/image-set-in-content-dynamic-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTurn on vibration support for BlackBerry.
staikos@webkit.org [Fri, 6 Apr 2012 20:12:41 +0000 (20:12 +0000)]
Turn on vibration support for BlackBerry.

Reviewed by Rob Buis.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium} Rebaseline some failing Leopard tests
schenney@chromium.org [Fri, 6 Apr 2012 20:07:27 +0000 (20:07 +0000)]
[Chromium} Rebaseline some failing Leopard tests
https://bugs.webkit.org/show_bug.cgi?id=83387

Unreviewed chromium test expectations update.

* platform/chromium-mac-leopard/fast/text/atsui-multiple-renderers-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/find-kana-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate LayoutUnit usage in RenderView
leviw@chromium.org [Fri, 6 Apr 2012 20:04:56 +0000 (20:04 +0000)]
Update LayoutUnit usage in RenderView
https://bugs.webkit.org/show_bug.cgi?id=83147

Reviewed by Julien Chaffraix.

Updating the usage of LayoutUnits in RenderView in preparation for sub-pixel layout. This mostly
affects paint and repaint functions, which take LayoutRects up to the RenderView level. This is
necessary as we continue to accumulate sub-pixel offsets up to this level.

No new tests. No change in behavior.

* rendering/RenderView.cpp:
(WebCore::RenderView::paint): Adding an assert that we're being called to paint on pixel
boundaries. We don't currently ever position RenderViews at sub-pixel offsets.
(WebCore::RenderView::shouldRepaint):
(WebCore::RenderView::repaintViewRectangle): Switching to a LayoutRect and cleaning up a fixme
that used decomposed offsets. Pixel snapping is applied before handing the rect up to the
FrameView.
(WebCore::RenderView::repaintRectangleInViewAndCompositedLayers): Pixel snapping before handing
the rect up to the Compositor.
(WebCore::RenderView::computeRectForRepaint):
(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::viewRect):
(WebCore::RenderView::unscaledDocumentRect):
* rendering/RenderView.h:
(RenderView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd autodetection of image orientation from EXIF information
timothy_horton@apple.com [Fri, 6 Apr 2012 20:02:59 +0000 (20:02 +0000)]
Add autodetection of image orientation from EXIF information
https://bugs.webkit.org/show_bug.cgi?id=19688
<rdar://problem/4126979> and <rdar://problem/11091578>

Original patch by David Carson and Eric Seidel.

Reviewed by Simon Fraser.

Add support for respecting EXIF image orientation, enabled by default for ImageDocuments.
The setting shouldRespectImageOrientation causes orientation to take effect for any image included via <img>.

Test: fast/images/exif-orientation.html, fast/images/exif-orientation-css.html

File list truncated because it's very long.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Race condition in layout test logging from window and worker
jsbell@chromium.org [Fri, 6 Apr 2012 19:58:53 +0000 (19:58 +0000)]
IndexedDB: Race condition in layout test logging from window and worker
https://bugs.webkit.org/show_bug.cgi?id=83378

The sequencing of logging directly from window vs. logging via posted events
from a worker is racy, making this test flake when run under Chromium. Removed
the sensitive logging on the window side; the test logic is unaffected as the
blocked/success event sequence would not be present if the window handler was
not run.

Reviewed by Tony Chang.

* storage/indexeddb/dont-commit-on-blocked-expected.txt:
* storage/indexeddb/dont-commit-on-blocked.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCorrect LayoutUnit usgae in RenderThemeQt and RenderThemeQStyle
leviw@chromium.org [Fri, 6 Apr 2012 19:54:28 +0000 (19:54 +0000)]
Correct LayoutUnit usgae in RenderThemeQt and RenderThemeQStyle
https://bugs.webkit.org/show_bug.cgi?id=83376

Reviewed by Eric Seidel.

Source/WebCore:

Correcting LayoutUnit usage in QT RenderTheme code.

No new tests. No change in behavior.

* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::convertToPaintingRect): Rounding the ancestor offset before
applying it to the pixel snapped partRect.
(WebCore::RenderThemeQt::paintSearchFieldCancelButton): Also rounding the ancestor
offset, and also pixel snapping the content rect before painting.

Source/WebKit/qt:

Calculating the progress animation using the pixel-snapped RenderProgress size instead
of the internal sub-pixel version.

* WebCoreSupport/RenderThemeQStyle.cpp:
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Rebaseline svg/clip-path/deep-nested-clip-in-mask* expectations
commit-queue@webkit.org [Fri, 6 Apr 2012 19:47:25 +0000 (19:47 +0000)]
[chromium] Rebaseline svg/clip-path/deep-nested-clip-in-mask* expectations
https://bugs.webkit.org/show_bug.cgi?id=83368

Unreviewed Chromium expectations rebaseline.

Patch by Florin Malita <fmalita@google.com> on 2012-04-06

* platform/chromium-mac-leopard/svg/clip-path/clip-path-pixelation-expected.png:
* platform/chromium-mac-leopard/svg/clip-path/deep-nested-clip-in-mask-expected.png:
* platform/chromium-mac-leopard/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png:
* platform/chromium-mac-snowleopard/svg/clip-path/clip-in-mask-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/clip-path/clip-path-pixelation-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/clip-path/deep-nested-clip-in-mask-expected.png:
* platform/chromium-mac-snowleopard/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png:
* platform/chromium-mac-snowleopard/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Removed.
* platform/chromium-mac/svg/clip-path/clip-in-mask-expected.png: Added.
* platform/chromium-mac/svg/clip-path/clip-path-pixelation-expected.png:
* platform/chromium-mac/svg/clip-path/deep-nested-clip-in-mask-expected.png: Added.
* platform/chromium-mac/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Added.
* platform/chromium-mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Added.
* platform/chromium-mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Added.
* platform/chromium-mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Added.
* platform/chromium-win/svg/clip-path/clip-in-mask-expected.png: Added.
* platform/chromium-win/svg/clip-path/deep-nested-clip-in-mask-expected.png: Added.
* platform/chromium-win/svg/clip-path/deep-nested-clip-in-mask-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/clip-path/deep-nested-clip-in-mask-expected.txt.
* platform/chromium-win/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Added.
* platform/chromium-win/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt.
* platform/chromium-win/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Added.
* platform/chromium-win/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Added.
* platform/chromium-win/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Added.
* platform/chromium/test_expectations.txt:
* platform/mac/svg/clip-path/clip-in-mask-expected.txt: Removed.
* platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt: Removed.
* platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt: Removed.
* platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt: Removed.
* platform/qt/svg/clip-path/clip-in-mask-expected.txt: Removed.
* platform/qt/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt: Removed.
* platform/qt/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt: Removed.
* platform/qt/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt: Removed.
* svg/clip-path/clip-in-mask-expected.txt: Renamed from LayoutTests/platform/gtk/svg/clip-path/clip-in-mask-expected.txt.
* svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt: Renamed from LayoutTests/platform/gtk/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt.
* svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt: Renamed from LayoutTests/platform/gtk/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt.
* svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt: Renamed from LayoutTests/platform/gtk/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFont-related tests are flaky on Chromium (sometimes glyphs don't draw)
schenney@chromium.org [Fri, 6 Apr 2012 19:43:55 +0000 (19:43 +0000)]
Font-related tests are flaky on Chromium (sometimes glyphs don't draw)
https://bugs.webkit.org/show_bug.cgi?id=66908

Unreviewed chromium test expectations update.

* platform/chromium-mac-snowleopard/svg/custom/svg-fonts-fallback-expected.png: Removed.
* platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.fontface.notinpage-expected.txt:
* platform/chromium-mac/svg/custom/svg-fonts-fallback-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocontext-lost.html is failing
kbr@google.com [Fri, 6 Apr 2012 19:43:22 +0000 (19:43 +0000)]
context-lost.html is failing
https://bugs.webkit.org/show_bug.cgi?id=81325

Reviewed by James Robinson.

Ensure that the DrawingBuffer does not attempt to restore the
TEXTURE_2D binding to an already-deleted texture.

Tested with layout test fast/canvas/webgl/context-lost.html as
well as WebGL conformance tests.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::loseContextImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r113267.
commit-queue@webkit.org [Fri, 6 Apr 2012 19:37:20 +0000 (19:37 +0000)]
Unreviewed, rolling out r113267.
http://trac.webkit.org/changeset/113267
https://bugs.webkit.org/show_bug.cgi?id=83384

causes dhtml perf regression (Requested by simonjam on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-06

Source/WebCore:

* dom/ChildListMutationScope.cpp:
(ChildListMutationScope::MutationAccumulator):
(WebCore::ChildListMutationScope::MutationAccumulator::isAddedNodeInOrder):
(WebCore::ChildListMutationScope::MutationAccumulator::childAdded):
(WebCore::ChildListMutationScope::MutationAccumulationRouter::childAdded):
* dom/ChildListMutationScope.h:
(WebCore::ChildListMutationScope::childAdded):
(MutationAccumulationRouter):
* dom/ContainerNode.cpp:
(WebCore):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::appendChild):
(WebCore::dispatchChildInsertionEvents):
(WebCore::updateTreeAfterInsertion):

LayoutTests:

* fast/events/domnodeinserted-entire-fragment-expected.txt: Removed.
* fast/events/domnodeinserted-entire-fragment.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago6 layout tests known to fail on Mac10.6 with CPU-Skia graphics
schenney@chromium.org [Fri, 6 Apr 2012 19:28:29 +0000 (19:28 +0000)]
6 layout tests known to fail on Mac10.6 with CPU-Skia graphics
https://bugs.webkit.org/show_bug.cgi?id=68436

Unreviewed Chromium test expectations update.

One of the files marked in this bug is a minor rebaselining. Done.

* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Removed.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline after Skia 2527 landed
schenney@chromium.org [Fri, 6 Apr 2012 19:19:02 +0000 (19:19 +0000)]
Rebaseline after Skia 2527 landed
https://bugs.webkit.org/show_bug.cgi?id=83375

Unreviewed update of Chromium test expectations.

Patch by Philip Rogers <pdr@google.com> on 2012-04-06

* platform/chromium-linux/svg/as-background-image/svg-as-background-5-expected.png:
* platform/chromium-linux/svg/filters/subRegion-one-effect-expected.png:
* platform/chromium-linux/svg/filters/subRegion-two-effects-expected.png:
* platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-5-expected.png:
* platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-5-expected.png:
* platform/chromium-mac/svg/as-background-image/svg-as-background-5-expected.png: Added.
* platform/chromium-mac/svg/filters/subRegion-one-effect-expected.png:
* platform/chromium-mac/svg/filters/subRegion-two-effects-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-5-expected.png:
* platform/chromium-win/svg/filters/subRegion-one-effect-expected.png:
* platform/chromium-win/svg/filters/subRegion-two-effects-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline after r109097
schenney@chromium.org [Fri, 6 Apr 2012 19:16:27 +0000 (19:16 +0000)]
Rebaseline after r109097
https://bugs.webkit.org/show_bug.cgi?id=79568

Unreviewed update of test expectations.

Patch by Philip Rogers <pdr@google.com> on 2012-04-06

* platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Removed.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline tests for wk62974
schenney@chromium.org [Fri, 6 Apr 2012 19:14:39 +0000 (19:14 +0000)]
Rebaseline tests for wk62974
https://bugs.webkit.org/show_bug.cgi?id=62974

Unreviewed test expectations update for Chromium.

Patch by Philip Rogers <pdr@google.com> on 2012-04-06

* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
* platform/chromium-linux/svg/text/text-altglyph-01-b-expected.png:
* platform/chromium-linux/svg/text/text-text-04-t-expected.png:
* platform/chromium-linux/svg/text/text-text-06-t-expected.png:
* platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.png:
* platform/chromium-mac-leopard/svg/text/text-altglyph-01-b-expected.png: Added.
* platform/chromium-mac-leopard/svg/text/text-text-04-t-expected.png: Added.
* platform/chromium-mac-leopard/svg/text/text-text-06-t-expected.png: Added.
* platform/chromium-mac-leopard/svg/wicd/test-rightsizing-b-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: Added.
* platform/chromium-mac/svg/text/text-altglyph-01-b-expected.png: Added.
* platform/chromium-mac/svg/text/text-text-04-t-expected.png: Added.
* platform/chromium-mac/svg/text/text-text-06-t-expected.png: Added.
* platform/chromium-mac/svg/wicd/test-rightsizing-b-expected.png: Added.
* platform/chromium-win-vista/svg/wicd: Removed.
* platform/chromium-win-vista/svg/wicd/test-rightsizing-b-expected.png: Removed.
* platform/chromium-win-xp/svg/wicd: Added.
* platform/chromium-win-xp/svg/wicd/test-rightsizing-b-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
* platform/chromium-win/svg/text/text-altglyph-01-b-expected.png:
* platform/chromium-win/svg/text/text-text-04-t-expected.png:
* platform/chromium-win/svg/text/text-text-06-t-expected.png:
* platform/chromium-win/svg/wicd/test-rightsizing-b-expected.png:
* platform/chromium-win/svg/wicd/test-rightsizing-b-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Layout Test svg/custom/oversized-pattern-scale.svg and svg/custom/transfor...
schenney@chromium.org [Fri, 6 Apr 2012 19:10:44 +0000 (19:10 +0000)]
[Chromium] Layout Test svg/custom/oversized-pattern-scale.svg and svg/custom/transformed-pattern-clamp-svg-root.svg are flaky
https://bugs.webkit.org/show_bug.cgi?id=68982

Unreviewed Chromium expectations update.

These tests now passing without issue.

* platform/chromium-linux/svg/custom/oversized-pattern-scale-expected.png: Removed.
* platform/chromium-mac/svg/custom/oversized-pattern-scale-expected.png: Added.
* platform/chromium-mac/svg/custom/transformed-pattern-clamp-svg-root-expected.png:
* platform/chromium-win/svg/custom/oversized-pattern-scale-expected.png:
* platform/chromium-win/svg/custom/transformed-pattern-clamp-svg-root-expected.png:
* platform/chromium/svg/custom/oversized-pattern-scale-expected.png: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnskip some tests that appear to be passing on GTK+ and add a
mrobinson@webkit.org [Fri, 6 Apr 2012 19:07:11 +0000 (19:07 +0000)]
Unskip some tests that appear to be passing on GTK+ and add a
new baseline to deal with whitespace issues.

* platform/gtk/Skipped: Unskip some tests passing locally.
* platform/gtk/plugins/document-open-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: ObjectStore/Index shouldn't hold reference to backing store
jsbell@chromium.org [Fri, 6 Apr 2012 19:06:47 +0000 (19:06 +0000)]
IndexedDB: ObjectStore/Index shouldn't hold reference to backing store
https://bugs.webkit.org/show_bug.cgi?id=83074

Source/WebCore:

We should be able to collect and close the leveldb backing store as soon as the database
connection is closed, but the IDBObjectStoreBackendImpl and IDBIndexBackendImpl were
holding RefPtrs, and those objects are kept alive by script references.

Replaced RefPtrs to the IDBBackingStore with pointers to the IDBDatabase. On the back end,
IDBDatabaseBackendImpl maintains a RefPtr to the IDBObjectStoreBackendImpl object, so
a raw pointer back is safe. On the front end, the IDBObjectStore maintains a RefPtr to
the IDBDatabase so script can navigate upwards. Ditto on both ends for the ObjectStore/Index
relationship. The frontend objects maintain RefPtrs to the backend objects, so the backend
objects and their owners are maintained as long as there's a script reference.

Also made IDBDatabaseBackendImpl handle a null IDBFactoryBackendImpl pointer, for testing.

Reviewed by Tony Chang.

Tests: webkit_unit_tests --gtest_filter="IDBDatabaseBackendTest.*"

* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::~IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores):
* Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):
(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::countInternal):
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::addingKeyAllowed):
* Modules/indexeddb/IDBIndexBackendImpl.h:
(WebCore::IDBIndexBackendImpl::create):
(IDBIndexBackendImpl):
(WebCore::IDBIndexBackendImpl::backingStore):
(WebCore::IDBIndexBackendImpl::databaseId):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::clearInternal):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
(WebCore::IDBObjectStoreBackendImpl::countInternal):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):
(WebCore::IDBObjectStoreBackendImpl::genAutoIncrementKey):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(WebCore::IDBObjectStoreBackendImpl::create):
(IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::backingStore):
(WebCore::IDBObjectStoreBackendImpl::databaseId):

Source/WebKit/chromium:

Reviewed by Tony Chang.

* WebKit.gypi:
* tests/IDBDatabaseBackendTest.cpp: Added.
(WebCore):
(MockIDBBackingStore):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix build warning on const long long to int implicit conversion.
jonlee@apple.com [Fri, 6 Apr 2012 18:56:50 +0000 (18:56 +0000)]
Fix build warning on const long long to int implicit conversion.

* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix LayoutUnit usage and rounding in RenderBlock and RenderEmbeddedObject
eae@chromium.org [Fri, 6 Apr 2012 18:55:54 +0000 (18:55 +0000)]
Fix LayoutUnit usage and rounding in RenderBlock and RenderEmbeddedObject
https://bugs.webkit.org/show_bug.cgi?id=83343

Reviewed by Eric Seidel.

Fix usage of LayoutUnits and rounding/pixel snapping in RenderBlock and
RenderEmbeddedObject in preparation for turing on subpixel support.

No new tests, no change in functionality.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::baselinePosition):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::nodeAtPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoZooming in SVGs in <object> is flakey
schenney@chromium.org [Fri, 6 Apr 2012 18:55:51 +0000 (18:55 +0000)]
Zooming in SVGs in <object> is flakey
https://bugs.webkit.org/show_bug.cgi?id=71673

Unreviewed Chromium test expectations update.

* platform/chromium-linux-x86/svg/zoom/page: Removed.
* platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Removed.
* platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
* platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
* platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
* platform/chromium-win-xp/svg/zoom/page: Removed.
* platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] crash in editing/selection/editable-html-element.html
mrobinson@webkit.org [Fri, 6 Apr 2012 18:50:37 +0000 (18:50 +0000)]
[GTK] crash in editing/selection/editable-html-element.html
https://bugs.webkit.org/show_bug.cgi?id=64530

Unskip and rebaseline a test.

* platform/gtk/Skipped: Unskip this test, because it's passing locally.
* platform/gtk/editing/selection/editable-html-element-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r65062): out of bound access in TextIterator (5 editing tests) on GTK
mrobinson@webkit.org [Fri, 6 Apr 2012 18:46:15 +0000 (18:46 +0000)]
REGRESSION(r65062): out of bound access in TextIterator (5 editing tests) on GTK
https://bugs.webkit.org/show_bug.cgi?id=63611

Unskip tests that are now passing and rebaseline ones which
have changed results.

* platform/gtk/Skipped:
* platform/gtk/editing/deleting/smart-delete-003-expected.txt:
* platform/gtk/editing/deleting/smart-delete-004-expected.txt:
* platform/gtk/editing/pasteboard/paste-text-008-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/10912476> HiDPI: Have canvas use a hidpi backing store, but downsampl...
mitz@apple.com [Fri, 6 Apr 2012 18:41:30 +0000 (18:41 +0000)]
<rdar://problem/10912476> HiDPI: Have canvas use a hidpi backing store, but downsample upon access

Reviewed by Sam Weinig.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig: Added ENABLE_HIGH_DPI_CANVAS.

Source/WebCore:

* Configurations/FeatureDefines.xcconfig: Added ENABLE_HIGH_DPI_CANVAS.

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig: Added ENABLE_HIGH_DPI_CANVAS.

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig: Added ENABLE_HIGH_DPI_CANVAS.

Tools:

* Scripts/build-webkit: Added high-dpi-canvas option to control ENABLE_HIGH_DPI_CANVAS.

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops: Added ENABLE_HIGH_DPI_CANVAS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate LayoutUnit usage in Editor and Frame
leviw@chromium.org [Fri, 6 Apr 2012 18:34:43 +0000 (18:34 +0000)]
Update LayoutUnit usage in Editor and Frame
https://bugs.webkit.org/show_bug.cgi?id=83278

Reviewed by Eric Seidel.

Frame and Editor both take input from the embedder, which passes along coordinates in screen
coordinates, which aren't fractional. Updating a few remaining functions to show this, and correcting
some inconsistencies in LayoutUnit usage.

No new tests. No change in behavior.

* editing/Editor.cpp:
(WebCore::Editor::rangeForPoint): windowToContents returns an IntPoint.
(WebCore::Editor::countMatchesForText): Using enclosingIntRect since we're (fake) repainting the entire
view rect.
* editing/Editor.h:
(Editor): Correcting mismatched function signature.
* page/Frame.cpp:
(WebCore::Frame::visiblePositionForPoint): Frame takes points in screen coordinates, usually from the
embedder. Changing these functions to be in IntPoints.
(WebCore::Frame::documentAtPoint): Ditto.
(WebCore::Frame::rangeForPoint): Ditto.
* page/Frame.h:
(Frame):
* platform/graphics/IntRect.h:
(enclosingIntRect): Adding an inline no-op copy of the FractionalLayoutRect method enclosingIntRect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayout Test svg/text/non-bmp-positioning-lists.svg is failing
schenney@chromium.org [Fri, 6 Apr 2012 18:34:23 +0000 (18:34 +0000)]
Layout Test svg/text/non-bmp-positioning-lists.svg is failing
https://bugs.webkit.org/show_bug.cgi?id=73494

Unreviewed Chromium test expectations.

The font is not right, but that's not what the test is testing.

* platform/chromium-linux/svg/text/non-bmp-positioning-lists-expected.png: Added.
* platform/chromium-linux/svg/text/non-bmp-positioning-lists-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/text/non-bmp-positioning-lists-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/text/non-bmp-positioning-lists-expected.txt: Added.
* platform/chromium-mac/svg/text/non-bmp-positioning-lists-expected.png: Added.
* platform/chromium-win/svg/text/non-bmp-positioning-lists-expected.png: Added.
* platform/chromium-win/svg/text/non-bmp-positioning-lists-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the GTK+ debug build.
mrobinson@webkit.org [Fri, 6 Apr 2012 18:30:42 +0000 (18:30 +0000)]
Fix the GTK+ debug build.

* Source/autotools/symbols.filter: Add a missing symbol to the symbols.list file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSVG filters incorrectly move elements
schenney@chromium.org [Fri, 6 Apr 2012 18:25:18 +0000 (18:25 +0000)]
SVG filters incorrectly move elements
https://bugs.webkit.org/show_bug.cgi?id=73643

Unreviewed Chromium test expectations update.

* platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png: Removed.
* platform/chromium-linux/svg/filters/filter-placement-issue-expected.png: Removed.
* platform/chromium-linux/svg/filters/filterRes2-expected.png: Removed.
* platform/chromium-mac/svg/filters/filter-placement-issue-expected.png: Added.
* platform/chromium-mac/svg/filters/filterRes2-expected.png: Modified property svn:mime-type.
* platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png:
* platform/chromium-win/svg/filters/filter-placement-issue-expected.png: Added.
* platform/chromium-win/svg/filters/filterRes2-expected.png:
* platform/chromium/test_expectations.txt:
* platform/efl/svg/as-background-image/svg-as-background-2-expected.txt: Removed.
* svg/as-background-image/svg-as-background-2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream API: Deleting the chromium bridge class MediaStreamCenterInternal
tommyw@google.com [Fri, 6 Apr 2012 18:23:56 +0000 (18:23 +0000)]
MediaStream API: Deleting the chromium bridge class MediaStreamCenterInternal
https://bugs.webkit.org/show_bug.cgi?id=83167

Reviewed by Adam Barth.

The situation before this patch is that we had a MediaStreamCenter.h with #ifdefs for the chromium specific
private class MediaStreamCenterInternal. This bridge class only shuffled calls between MediaStreamCenter and
WebMediaStreamCenter and was needed before the introduction of Platform.
To get rid of this now unnecessary class I had two alternatives:
1) Sprinkle platform/MediaStreamCenter.h with more #ifdefs, including around the class declaration.
2) Create an abstract base class that the chromium and gstreamer implementations overrides.
My personal preference is 2) since I strongly dislike #ifdefs. The drawback is that MediaStreamCenter now
has a vtable. However since all methods in this class are extremely low-usage it doesn't affect anything
in practice.

No code behaviour changes.

* GNUmakefile.am:
* GNUmakefile.list.am:
* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::setEnabled):
* Modules/mediastream/UserMediaRequest.cpp:
* Modules/mediastream/UserMediaRequest.h:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/chromium/support/WebMediaStreamSourcesRequest.cpp:
* platform/mediastream/MediaStreamCenter.cpp:
(WebCore::MediaStreamCenter::MediaStreamCenter):
(WebCore):
(WebCore::MediaStreamCenter::~MediaStreamCenter):
* platform/mediastream/MediaStreamCenter.h:
(WebCore):
(MediaStreamCenter):
* platform/mediastream/MediaStreamSourcesQueryClient.h: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.h.
(WebCore):
(MediaStreamSourcesQueryClient):
(WebCore::MediaStreamSourcesQueryClient::~MediaStreamSourcesQueryClient):
* platform/mediastream/chromium/MediaStreamCenterChromium.cpp:
(WebCore::MediaStreamCenter::instance):
(WebCore::MediaStreamCenterChromium::MediaStreamCenterChromium):
(WebCore::MediaStreamCenterChromium::~MediaStreamCenterChromium):
(WebCore::MediaStreamCenterChromium::queryMediaStreamSources):
(WebCore::MediaStreamCenterChromium::didSetMediaStreamTrackEnabled):
(WebCore::MediaStreamCenterChromium::didStopLocalMediaStream):
(WebCore::MediaStreamCenterChromium::didConstructMediaStream):
(WebCore::MediaStreamCenterChromium::constructSDP):
(WebCore):
(WebCore::MediaStreamCenterChromium::stopLocalMediaStream):
* platform/mediastream/chromium/MediaStreamCenterChromium.h: Renamed from Source/WebCore/platform/mediastream/chromium/MediaStreamCenterInternal.h.
(WebKit):
(WebCore):
(MediaStreamCenterChromium):
* platform/mediastream/chromium/MediaStreamCenterInternal.cpp: Removed.
* platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.cpp.
(WebCore):
(WebCore::MediaStreamCenter::instance):
(WebCore::MediaStreamCenterGStreamer::MediaStreamCenterGStreamer):
(WebCore::MediaStreamCenterGStreamer::~MediaStreamCenterGStreamer):
(WebCore::MediaStreamCenterGStreamer::queryMediaStreamSources):
(WebCore::MediaStreamCenterGStreamer::didSetMediaStreamTrackEnabled):
(WebCore::MediaStreamCenterGStreamer::didStopLocalMediaStream):
(WebCore::MediaStreamCenterGStreamer::didConstructMediaStream):
(WebCore::MediaStreamCenterGStreamer::constructSDP):
* platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h: Copied from Source/WebCore/platform/mediastream/MediaStreamCenter.h.
(WebCore):
(MediaStreamCenterGStreamer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShould disable preserves3D() for things that enforce flattening, like overflow and...
simon.fraser@apple.com [Fri, 6 Apr 2012 18:17:50 +0000 (18:17 +0000)]
Should disable preserves3D() for things that enforce flattening, like overflow and filters
https://bugs.webkit.org/show_bug.cgi?id=83337

Source/WebCore:

Reviewed by Dean Jackson.

The CSS3 Transforms spec says that some properties should cause flattening
of things with transform-style: preserve-3d. We currently do this as a side
effect of the GraphicsLayer structure, but we should really do it at the
RenderStyle level, as we do for other things like stacking context creation.

Test: compositing/overflow-trumps-transform-style.html

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

LayoutTests:

Reviewed by Dean Jackson.

Test for computed style and layer structure combining transform-style
with overflow.

* compositing/overflow-trumps-transform-style-expected.txt: Added.
* compositing/overflow-trumps-transform-style.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream API: MediaStreams stops proper cleanup to take place during a page reload.
tommyw@google.com [Fri, 6 Apr 2012 18:07:10 +0000 (18:07 +0000)]
MediaStream API: MediaStreams stops proper cleanup to take place during a page reload.
https://bugs.webkit.org/show_bug.cgi?id=83143

Reviewed by Adam Barth.

To fix this I have converted MediaStream and LocalMediaStream to be ActiveDOMObjects.

Have no idea how to write a test that succesfully verifies this. I have done manual testing
to verify that proper tear-down now takes place.

* Modules/mediastream/LocalMediaStream.cpp:
(WebCore::LocalMediaStream::create):
(WebCore::LocalMediaStream::stopFunction):
(WebCore):
* Modules/mediastream/LocalMediaStream.h:
(LocalMediaStream):
* Modules/mediastream/LocalMediaStream.idl:
* Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::scriptExecutionContext):
* Modules/mediastream/MediaStream.h:
(MediaStream):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Rounding issue on some RenderSVGPath values
schenney@chromium.org [Fri, 6 Apr 2012 18:06:29 +0000 (18:06 +0000)]
[chromium] Rounding issue on some RenderSVGPath values
https://bugs.webkit.org/show_bug.cgi?id=75367

Unreviewed Chromium expectations update.

These tests have been stable for a long time, and consistent across
all platforms. Whatever was causing previous flakiness is apparently
no longer happening.

* platform/chromium/svg/css/composite-shadow-example-expected.txt:
* platform/chromium/svg/css/composite-shadow-with-opacity-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] svg/text/text-style-recalc-crash.html times out
schenney@chromium.org [Fri, 6 Apr 2012 17:53:56 +0000 (17:53 +0000)]
[Chromium] svg/text/text-style-recalc-crash.html times out
https://bugs.webkit.org/show_bug.cgi?id=75696

Unreviewed Chromium test_expectations cleanup.

The test referenced by this bug has not failed in the current history of the flakiness board.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/10912476> Pixel access canvas APIs do not work transparently with...
mitz@apple.com [Fri, 6 Apr 2012 17:48:34 +0000 (17:48 +0000)]
<rdar://problem/10912476> Pixel access canvas APIs do not work transparently with high-DPI backing store
https://bugs.webkit.org/show_bug.cgi?id=83072

Reviewed by Simon Fraser.

Made getImageData, putImageData, and toDataURL downsample/upsample when pixels in the canvas
backing store are not in a 1:1 ratio to CSS pixels. This makes clients of these APIs
indifferent to the backing store resolution, up to sampling artifacts.

In order for this to work, ImageBuffer has to know and respect the resolutionScale
parameter. This change makes the Core Graphics-based implementation of ImageBuffer do this,
but on other platforms, resolutionScale values other than 1 will not work. Such platforms
should not enable the HIGH_DPI_CANVAS feature.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::HTMLCanvasElement): Updated a comment.
(WebCore::HTMLCanvasElement::createImageBuffer): Changed to create an ImageBuffer with
the desired resolution instead of 1.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage): Removed code that scaled the source rect,
since this is now handled at the ImageBuffer level.
(WebCore::CanvasRenderingContext2D::createImageData): Now returns ImageData of the requested
size regardless of the backing store resolution.
(WebCore::CanvasRenderingContext2D::getImageData): Ditto.
* platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::create): Removed some code that tried to apply the resolution scale
to the buffer after creating it, and changed to pass the resolution scale down to the
(platform-specific) constructor, which can apply it correctly.
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::ImageBuffer): Added a resolutionScale parameter, which is used to
compute the backing buffer size, and to apply a device scale factor to the context.
(WebCore::ImageBuffer::copyImage): Changed to return an image scaled down to the logical
size of the buffer.
(WebCore::ImageBuffer::getUnmultipliedImageData): Changed to pass the resolution scale to
ImageData::getData().
(WebCore::ImageBuffer::getPremultipliedImageData): Ditto.
(WebCore::ImageBuffer::putByteArray): Changed to pass the resolution scale to
ImageData::putData(). When drawing the byte array as an image, changed to preserve the base
CTM in the destination context (thus mapping from image data pixels to backing store pixels).
(WebCore::ImageBuffer::toDataURL): Fixed a CGColorSpace leak. Made the returned image have
the buffer’s logical size instead of the backing buffer’s size.
(WebCore::ImageDataToDataURL): Fixed a CGColorSpace leak.
* platform/graphics/cg/ImageBufferDataCG.cpp:
(WebCore::ImageBufferData::getData): Added a resolutionScale parameter. The source
coordinates are scaled by the value of that parameter, and a reverse scaling transform
is applied when copying from the backing store into the destination (either explicitly
using Accelerate or implicitly by drawing as an image). Since after scaling,
unpremultiplication and component permutation are done in-place, made the
non-Accelerate code that does these things safe in this case.
(WebCore::ImageBufferData::putData): Added a resolutionScale parameter. The destination
coordinates are scaled by the value of that parameter, and a scaling transform is applied
when copying from the source into the backing store (either explicitly using Accelerate or
implicitly by drawing as an image). Since after scaling, premultiplication and component
permutation are done in-place, made the non-Accelerate code that does these things safe in
this case.
* platform/graphics/cg/ImageBufferDataCG.h:
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/wince/ImageBufferWinCE.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/wx/ImageBufferWx.cpp:
(WebCore::ImageBuffer::ImageBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Draw debug borders for tiles on layers with skipsDraw
commit-queue@webkit.org [Fri, 6 Apr 2012 17:37:35 +0000 (17:37 +0000)]
[chromium] Draw debug borders for tiles on layers with skipsDraw
https://bugs.webkit.org/show_bug.cgi?id=83352

Patch by Dana Jansens <danakj@chromium.org> on 2012-04-06
Reviewed by Adrienne Walker.

The tiles are given the same color as other missing tiles.

* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::appendQuads):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix cast-align warnings in JSC
rwlbuis@webkit.org [Fri, 6 Apr 2012 17:35:52 +0000 (17:35 +0000)]
Fix cast-align warnings in JSC
https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by George Staikos.

Source/JavaScriptCore:

* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::computeJumpType):
(JSC::ARMv7Assembler::link):
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::linkCode):
* heap/MarkStack.cpp:
(JSC::SlotVisitor::copyAndAppend):
* runtime/JSArray.cpp:
(JSC::JSArray::visitChildren):
* wtf/RefCountedArray.h:
(WTF::RefCountedArray::Header::payload):

Source/WebCore:

* platform/graphics/WOFFFileFormat.cpp:
(WebCore::readUInt32):
(WebCore::readUInt16):
* platform/image-encoders/skia/JPEGImageEncoder.cpp:
(WebCore::preMultipliedBGRAtoRGB):
* platform/network/MIMESniffing.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStreamline strtod and fix some related problems
darin@apple.com [Fri, 6 Apr 2012 17:31:54 +0000 (17:31 +0000)]
Streamline strtod and fix some related problems
https://bugs.webkit.org/show_bug.cgi?id=82857

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

* parser/Lexer.cpp:
(JSC::Lexer<>::lex): Use parseDouble. Since we have already scanned the number
and we know it has only correct characters, leading spaces, trailing junk, and
trailing spaces are not a possibility. No need to add a trailing null character.

* runtime/JSGlobalObjectFunctions.cpp:
(JSC::parseInt): Changed overflow based 10 case to use parseDouble. No need
to allow trailing junk since the code above already allows only numeric digits
in the string. This code path is used only in unusual cases, so it's not
optimized for 8-bit strings, but easily could be.
(JSC::jsStrDecimalLiteral): Removed the allow trailing junk argument to this
function template because all the callers are OK with trailing junk. Use the
parseDouble function. No need to copy the data into a byte buffer, because
parseDouble handles that.
(JSC::toDouble): Got rid of the DisallowTrailingJunk argument to the
jsStrDecimalLiteral function template. That's OK because this function
already checks for trailing junk and handles it appropriately. The old code
path was doing it twice.
(JSC::parseFloat): Got rid of the AllowTrailingJunk argument to the
jsStrDecimalLiteral function template; the template allows junk unconditionally.

* runtime/LiteralParser.cpp:
(JSC::::Lexer::lexNumber): Use parseDouble. Since we have already scanned the number
and we know it has only correct characters, leading spaces, trailing junk, and
trailing spaces are not a possibility. No need to add a trailing null character.
No need to copy the data into a byte buffer, because parseDouble handles that.
We could optimize the UChar case even more because we know all the characters
are ASCII, but not doing that at this time.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Updated.

Source/WebCore:

Refactoring of code covered by existing tests.

* dom/ViewportArguments.cpp:
(WebCore::numericPrefix): Removed a confusing comment that just said
"we tolerate extra characters" in a roundabout way. Made the "ok"
argument optional. Changed to call the new version of charactersToFloat
that returns the number of characters parsed rather than using the
charactersToFloatIgnoringJunk/didReadNumber solution from before.
(WebCore::findSizeValue): Since numericPrefix is guaranteed to return 0
when it can't parse, removed the "ok" code. Also changed the unusual
syntax "float(1.0)" to just "1", which works just as well.
(WebCore::findScaleValue): Ditto.
(WebCore::findUserScalableValue): Ditto.

* html/parser/HTMLParserIdioms.cpp:
(WebCore::parseToDoubleForNumberType): Removed an unneeded code path
and replaced it with an assertion; toDouble no longer will return infinity
or not-a-number values.

Source/WTF:

Replaced the strtod function template with a parseDouble function, eliminating
the following unneeded features:

- need for a trailing null character and a call to strlen
- needless conversion of string lengths from size_t to int and back that created
  the possibility of incorrect truncation
- one level of function call; use inlining instead
- construction of the StringToDoubleConverter object; it was used to pass
  arguments that are known at compile time
- most of the StringToDoubleConverter::StringToDouble function's body; it was
  code we did not need
- parsing of Infinity and NaN at the strtod level; added recently when we moved
  from the old strtod to the new one, and not needed or helpful at this level
- multiple copies of code to narrow to single byte strings; in many cases
  this was done even when starting with an LChar string that is already
  single-byte, now we handle this with an overload of parseDouble

* wtf/dtoa.cpp:
Removed a long comment about the original strtod function that no longer
applies since we deleted that function long ago. Removed a lot of includes.
Removed the strtod function templates and its instantiations, since they
are now replaced by the parseDouble function.
(WTF::Internal::parseDoubleFromLongString): Added.
* wtf/dtoa.h:
Added an include of ASCIICType.h so we can use isASCII in a function in this
header. Left the heretofore unneeded include of double-conversion.h, since we
now want to use it in a function in this header. Removed the AllowTrailingJunkTag
and AllowTrailingSpacesTag enumerations and the strtod function template. Added
new parseDouble function, and inline implementation of it.

* wtf/dtoa/double-conversion.cc: Removed quite a bit of unused code, hardcoding
all the StringToDouble function arguments that come from data members so it can
be a much smaller static member function. Also changed the types of arguments
from int to size_t.
* wtf/dtoa/double-conversion.h: Removed most of the StringToDoubleConverter
class, leaving only the conversion function as a static member function.

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::toDouble): Got rid of didReadNumber.
(WTF::StringImpl::toFloat): Ditto.
* wtf/text/StringImpl.h: Ditto.
* wtf/text/WTFString.cpp:
(WTF::String::toDouble): Got rid of didReadNumber.
(WTF::String::toFloat): Ditto.
(WTF::toDoubleType): Rewrote this function to use parseDouble. Moved the code
to skip leading spaces here, because other callers of parseDouble don't want
to do that. Repurposed the check for an empty string so it's now the same
code shared by all the "parsed nothing" cases. Removed the code to convert
the buffer to ASCII for two reasons: (1) We don't need that code at all when
CharType is LChar, and (2) We now handle this through the two overloads for
the parseDouble function. Disallowing trailing junk is now handled here,
rather than inside parseDouble.
(WTF::charactersToDouble): Updated for changes to toDoubleType. Removed the
didReadNumber argument.
(WTF::charactersToFloat): Ditto. Also added overloads that return the parsed
length. These are a slightly more powerful way to do what didReadNumber was
used for before.

* wtf/text/WTFString.h: Added comments, eliminated didReadNumber, and added
overloads of charactersToFloat that replace charactersToFloatIgnoringJunk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Surface replica should have a separate quad in the render pass
commit-queue@webkit.org [Fri, 6 Apr 2012 17:29:11 +0000 (17:29 +0000)]
[chromium] Surface replica should have a separate quad in the render pass
https://bugs.webkit.org/show_bug.cgi?id=83287

Patch by Dana Jansens <danakj@chromium.org> on 2012-04-06
Reviewed by Adrienne Walker.

Generate separate quads for a RenderSurface and its replica. The replica
quad is drawn independently of the surface itself. This allows us to
cull each one independently.

Covered by existing tests.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawRenderSurfaceQuad):
(WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay):
* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::setScissorRect):
(WebCore):
(WebCore::CCRenderSurface::drawContents):
(WebCore::CCRenderSurface::drawReplica):
(WebCore::CCRenderSurface::hasReplica):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):
* platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.cpp:
(WebCore::CCRenderSurfaceDrawQuad::create):
(WebCore::CCRenderSurfaceDrawQuad::CCRenderSurfaceDrawQuad):
* platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.h:
(CCRenderSurfaceDrawQuad):
(WebCore::CCRenderSurfaceDrawQuad::isReplica):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderSVGRoot should inherit from RenderReplaced
schenney@chromium.org [Fri, 6 Apr 2012 17:22:37 +0000 (17:22 +0000)]
RenderSVGRoot should inherit from RenderReplaced
https://bugs.webkit.org/show_bug.cgi?id=76446

Unreviewed Chromium expectations update.

Second attempt, after the rebaseline tool put expectations in chromium-linux-x86 instead of chormium-linux.

* platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-container-expected.png: Removed.
* platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Removed.
* platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-root-expected.png: Removed.
* platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Removed.
* platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.png:
* platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
* platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.png:
* platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove JSC dependency from GregorianDateTime
paroga@webkit.org [Fri, 6 Apr 2012 17:10:11 +0000 (17:10 +0000)]
Remove JSC dependency from GregorianDateTime
https://bugs.webkit.org/show_bug.cgi?id=83290

Reviewed by Geoffrey Garen.

This allows us to move it to WTF later.

* runtime/DateConstructor.cpp:
(JSC::callDate):
* runtime/JSDateMath.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GObject bindings] Fix the coding style issues in the generated bindings
mrobinson@webkit.org [Fri, 6 Apr 2012 17:10:07 +0000 (17:10 +0000)]
[GObject bindings] Fix the coding style issues in the generated bindings
https://bugs.webkit.org/show_bug.cgi?id=82080

Reviewed by Kentaro Hara.

No new tests. This is covered by the binding tests.

* bindings/scripts/CodeGeneratorGObject.pm: Fix most style errors in the generated
  GObject code.
* bindings/scripts/test/GObject: Updated the expected results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove bogus assert from ChildListMutationScope
adamk@chromium.org [Fri, 6 Apr 2012 17:03:09 +0000 (17:03 +0000)]
Remove bogus assert from ChildListMutationScope
https://bugs.webkit.org/show_bug.cgi?id=83336

Reviewed by Ryosuke Niwa.

Source/WebCore:

This assert can trivially be triggered from script, but luckily the
code already behaves correctly without it.

* dom/ChildListMutationScope.cpp:
(WebCore::ChildListMutationScope::MutationAccumulator::enqueueMutationRecord):

LayoutTests:

Added a test that would trigger the assert.

* fast/mutation/observe-childList-expected.txt:
* fast/mutation/observe-childList.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r113442.
commit-queue@webkit.org [Fri, 6 Apr 2012 16:39:32 +0000 (16:39 +0000)]
Unreviewed, rolling out r113442.
http://trac.webkit.org/changeset/113442
https://bugs.webkit.org/show_bug.cgi?id=83373

for breaking JSC bindings compilation (Requested by pfeldman
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-06

* GNUmakefile.list.am:
* Target.pri:
* UseJSC.cmake:
* UseV8.cmake:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSMutationCallbackCustom.cpp: Added.
(WebCore):
(WebCore::JSMutationCallback::handleEvent):
* bindings/scripts/CodeGenerator.pm:
* bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForTypeInImpl):
(GenerateCallbackHeader):
(GenerateCallbackImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateCallbackHeader):
(GenerateCallbackImplementation):
* bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::callbackWithBoolean):
* bindings/scripts/test/JS/JSTestCallback.h:
(JSTestCallback):
* bindings/scripts/test/TestCallback.idl:
* bindings/scripts/test/V8/V8TestCallback.cpp:
(WebCore::V8TestCallback::callbackWithBoolean):
* bindings/scripts/test/V8/V8TestCallback.h:
(V8TestCallback):
* bindings/v8/custom/V8MutationCallbackCustom.cpp: Added.
(WebCore):
(WebCore::V8MutationCallback::handleEvent):
* dom/MutationCallback.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] Unskip the video track tests
commit-queue@webkit.org [Fri, 6 Apr 2012 16:13:11 +0000 (16:13 +0000)]
[Gtk] Unskip the video track tests
https://bugs.webkit.org/show_bug.cgi?id=82590

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-04-06
Reviewed by Martin Robinson.

Source/WebCore:

Enable the video track runtime feature for the Gtk port as well.

No new tests - existing ones will be unskipped.

* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):

LayoutTests:

Unskip passing video track tests and update expectations
where necessary.

* platform/gtk/Skipped:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCall Heap::discardAllCompiledCode() in low memory situations
msaboff@apple.com [Fri, 6 Apr 2012 16:09:22 +0000 (16:09 +0000)]
Call Heap::discardAllCompiledCode() in low memory situations
https://bugs.webkit.org/show_bug.cgi?id=83335

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Restructured Heap::discardAllCompiledCode() to do the "Is JavaScriptRunning?"
check inline so that it can be called directly without this check.

* heap/Heap.cpp:
(JSC::Heap::discardAllCompiledCode):
(JSC::Heap::collectAllGarbage):
* heap/Heap.h: Added JS_EXPORT_PRIVATE to discardAllCompiledCode() so it can be
called from WebCore.
(Heap):
* runtime/JSGlobalData.h: Removed unused " void discardAllCompiledCode()" declaration.
(JSGlobalData):

Source/WebCore:

Added call to discardAllCompiledCode() when under memory pressure.
We can re-JIT as needed.  This is similar to what we used to do when we did
a full GC which also cleaned up JIT code.  Doing a full GC typically didn't
help our memory situation, in fact it made things worse in the really low
memory situation as it caused more paging.

Added pass through discardAllCompiledCode() method to GCController.

* bindings/js/GCController.cpp:
(WebCore::GCController::discardAllCompiledCode):
(WebCore):
* bindings/js/GCController.h:
(GCController):
* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::releaseMemory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: on a single click in Timeline overview, make a minimal selection cente...
caseq@chromium.org [Fri, 6 Apr 2012 16:04:51 +0000 (16:04 +0000)]
Web Inspector: on a single click in Timeline overview, make a minimal selection centered around cursor
https://bugs.webkit.org/show_bug.cgi?id=82616

Reviewed by Pavel Feldman.

- center minimal selection on mouse cursor if the mouse hasn't moved (i.e. we had a click, not drag)

* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewWindow.prototype._endWindowSelectorDragging):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd CodeGenerator support for sequence<> in callbacks.
haraken@chromium.org [Fri, 6 Apr 2012 15:45:48 +0000 (15:45 +0000)]
Add CodeGenerator support for sequence<> in callbacks.
https://bugs.webkit.org/show_bug.cgi?id=83233

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-04-06
Reviewed by Kentaro Hara.

Tests: TestCallback.idl and fast/mutation/callback-arguments.html should pass even after
the changes.

* GNUmakefile.list.am: Removed unsued custom files V8MutationCallbackCustom.cpp
  and JSMutationCallbackCustom.cpp from builds.
* Target.pri: Ditto.
* UseJSC.cmake: Ditto.
* UseV8.cmake: Ditto.
* WebCore.gypi: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* bindings/js/JSMutationCallbackCustom.cpp: Removed.
* bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForTypeInImpl): Add proper header type.
(GenerateCallbackHeader): Generate declaration for the callback with sequence<T> argument.
(GenerateCallbackImplementation): Generate implementation for the callback with sequence<T> argument.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateCallbackHeader): Generate declaration for the callback with sequence<T> argument.
(GenerateCallbackImplementation): Generate implementation for the callback with sequence<T> argument.
* bindings/scripts/test/JS/JSTestCallback.cpp: Modified test results of run-bindings-tests.
(WebCore):
(WebCore::JSTestCallback::handleEvent):
* bindings/scripts/test/JS/JSTestCallback.h: Modified test results of run-bindings-tests.
(JSTestCallback):
* bindings/scripts/test/TestCallback.idl: Added test callback with sequence<> argument.
* bindings/scripts/test/V8/V8TestCallback.cpp: Modified test results of run-bindings-tests.
(WebCore):
(WebCore::V8TestCallback::handleEvent):
* bindings/scripts/test/V8/V8TestCallback.h: Modified test results of run-bindings-tests.
(V8TestCallback):
* bindings/v8/custom/V8MutationCallbackCustom.cpp: Removed.
* dom/MutationCallback.idl: Removed custom bindings using sequence<T>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r113431.
pfeldman@chromium.org [Fri, 6 Apr 2012 15:33:56 +0000 (15:33 +0000)]
Unreviewed, rolling out r113431.
http://trac.webkit.org/changeset/113431
https://bugs.webkit.org/show_bug.cgi?id=83372

for breaking at least Chromium compilation (Requested by
pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-06

* rendering/RenderView.cpp:
(WebCore::RenderView::paint):
(WebCore::RenderView::shouldRepaint):
(WebCore::RenderView::repaintViewRectangle):
(WebCore::RenderView::repaintRectangleInViewAndCompositedLayers):
(WebCore::RenderView::computeRectForRepaint):
(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::viewRect):
(WebCore::RenderView::unscaledDocumentRect):
* rendering/RenderView.h:
(RenderView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: CodeGeneratorInspector.py: completely switch all domains to 'strict...
pfeldman@chromium.org [Fri, 6 Apr 2012 15:30:18 +0000 (15:30 +0000)]
Web Inspector: CodeGeneratorInspector.py: completely switch all domains to 'strict' mode
https://bugs.webkit.org/show_bug.cgi?id=83332

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-04-06
Reviewed by Pavel Feldman.

Hardcoded list of domains is removed from generator. Partial domain sorting is dropped as unneeded.
Types with open propery list are introduced: validator allows undocumented properties for them.

Timeline domain code is patched to do runtimeCast in the last moment because true switching to
type-safe interfaces should take significant time and should be done separately.

* inspector/CodeGeneratorInspector.py:
(Generator.go):
(Generator.process_event):
(Generator.process_command):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willSendResourceRequest):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderSVGRoot should inherit from RenderReplaced
schenney@chromium.org [Fri, 6 Apr 2012 15:29:10 +0000 (15:29 +0000)]
RenderSVGRoot should inherit from RenderReplaced
https://bugs.webkit.org/show_bug.cgi?id=76446

Unreviewed Chromium test expectations update.

* platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-container-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-root-expected.png: Added.
* platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
* platform/chromium-linux-x86/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Added.
* platform/chromium-win-vista/svg/custom/mouse-move-on-svg-root-expected.png: Added.
* platform/chromium-win-vista/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
* platform/chromium-win-xp/svg/custom/mouse-move-on-svg-root-expected.png: Added.
* platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.png:
* platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.txt:
* platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
* platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
* platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.png:
* platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.txt:
* platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
* platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
* platform/chromium-win/svg/custom/pointer-events-text-css-transform-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: CodeGeneratorInspector.py: stop accepting raw InspectorObject in gener...
pfeldman@chromium.org [Fri, 6 Apr 2012 15:23:25 +0000 (15:23 +0000)]
Web Inspector: CodeGeneratorInspector.py: stop accepting raw InspectorObject in generated setters
https://bugs.webkit.org/show_bug.cgi?id=83327

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-04-06
Reviewed by Pavel Feldman.

Generator fixed to have strict types in generated setter methods.

Client code is switched from InspectorObject's and String's to generated types where
needed.

* inspector/CodeGeneratorInspector.py:
(AdHocTypeContext):
(format_setter_value_expression):
* inspector/ConsoleMessage.cpp:
(WebCore::messageSourceValue):
(WebCore::messageTypeValue):
(WebCore::messageLevelValue):
(WebCore::ConsoleMessage::addToFrontend):
* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources):
(WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):
* inspector/InspectorApplicationCacheAgent.h:
(InspectorApplicationCacheAgent):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
(WebCore::InspectorCSSAgent::detectOrigin):
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForNode):
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
* inspector/InspectorMemoryAgent.cpp:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::buildObjectForFrameTree):
* inspector/InspectorResourceAgent.cpp:
(WebCore::buildObjectForTiming):
(WebCore::buildObjectForCachedResource):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::buildObjectForStyle):
(WebCore::InspectorStyleSheet::create):
(WebCore::InspectorStyleSheet::InspectorStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForRule):
(WebCore::InspectorStyleSheet::resourceStyleSheetText):
(WebCore::InspectorStyleSheet::buildArrayForRuleList):
(WebCore::InspectorStyleSheetForInlineStyle::create):
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
* inspector/InspectorStyleSheet.h:
(InspectorCSSId):
(WebCore::InspectorCSSId::asProtocolValue): method is made template as now it returns 2 formally different types.
(InspectorStyleSheet):
(WebCore::InspectorStyleSheet::canBind):
(InspectorStyleSheetForInlineStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: highlight diff in the gutter, not in the line content.
pfeldman@chromium.org [Fri, 6 Apr 2012 15:17:50 +0000 (15:17 +0000)]
Web Inspector: highlight diff in the gutter, not in the line content.
https://bugs.webkit.org/show_bug.cgi?id=83371

Reviewed by Yury Semikhatsky.

Now that the editing mode is enabled by default, diff highlighting gets annoying.
I am moving it to the gutter (same decoration as before, but now coloring gutter only).

* inspector/front-end/TextViewer.js:
(WebInspector.TextEditorGutterPanel.prototype.textChanged):
* inspector/front-end/textViewer.css:
(.diff-container .webkit-added-line.webkit-line-number):
(.diff-container .webkit-removed-line.webkit-line-number):
(.diff-container .webkit-changed-line.webkit-line-number):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDifferentiate between SVG/CSS width/height attributes/properties
schenney@chromium.org [Fri, 6 Apr 2012 15:08:47 +0000 (15:08 +0000)]
Differentiate between SVG/CSS width/height attributes/properties
https://bugs.webkit.org/show_bug.cgi?id=76447

Unreviewed Chromium expectations update.

* platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-win-xp/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-win-xp/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-win-xp/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-win-xp/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
* platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png:
* platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt:
* platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png:
* platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
* platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png:
* platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt:
* platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png:
* platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: remove url from the saved urls map before the save action.
pfeldman@chromium.org [Fri, 6 Apr 2012 15:04:31 +0000 (15:04 +0000)]
Web Inspector: remove url from the saved urls map before the save action.
https://bugs.webkit.org/show_bug.cgi?id=83364

Reviewed by Yury Semikhatsky.

URL gets added back upon successful save anyways, but if user chooses cancel saving,
we stop bugging him with the save-as dialog.

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._exportAll):
(WebInspector.NetworkLogView.prototype._exportResource):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction.doSave):
(WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent.doSave):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._contextMenu):
(WebInspector.TextViewer.prototype._commitEditing):
* inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModel.prototype.saveToFile):
* inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: display frame details in popover on frame strip in Timeline panel
caseq@chromium.org [Fri, 6 Apr 2012 14:43:46 +0000 (14:43 +0000)]
Web Inspector: display frame details in popover on frame strip in Timeline panel
https://bugs.webkit.org/show_bug.cgi?id=83365

Reviewed by Pavel Feldman.

- added popovers for frame strips;
- factored out generateAggregatedInfo for reuse in the above;
- made frame event dividers thinner, darker and greyer.

* English.lproj/localizedStrings.js: Added "FPS" and "Frame"
* inspector/front-end/TimelineFrameController.js:
(WebInspector.TimelineFrameController.prototype._flushFrame): added startTimeOffset.
(WebInspector.TimelineFrameController.prototype._createSyntheticFrame): ditto.
* inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModel.prototype._updateBoundaries):
(WebInspector.TimelineModel.prototype.recordOffsetInSeconds):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._updateFrames): added link to frame to strip div.
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._getPopoverAnchor): handle frame anchors separately.
(WebInspector.TimelinePanel.prototype._mouseMove): ditto.
(WebInspector.TimelinePanel.prototype._showPopover):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):
(WebInspector.TimelinePresentationModel._generateAggregatedInfo): factored out for reuse.
(WebInspector.TimelinePresentationModel.generatePopupContentForFrame):
* inspector/front-end/inspectorCommon.css:
(.resources-dividers-label-bar):
* inspector/front-end/timelinePanel.css:
(.timeline .resources-event-divider.timeline-frame-divider): made divider thin and grey.
(.timeline-frame-strip): bumped z-index, added pointer-events: auto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: show "dirty" flag for CSS files edited in the resources panel.
pfeldman@chromium.org [Fri, 6 Apr 2012 14:27:29 +0000 (14:27 +0000)]
Web Inspector: show "dirty" flag for CSS files edited in the resources panel.
https://bugs.webkit.org/show_bug.cgi?id=83363

Reviewed by Yury Semikhatsky.

Added TextEdited notification into the editable source frame, listening to it
in the resources panel.

* inspector/front-end/ResourceView.js:
(WebInspector.EditableResourceSourceFrame.prototype._contentChanged):
(WebInspector.EditableResourceSourceFrame.prototype.isDirty):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype._appendRevision):
(WebInspector.FrameResourceTreeElement.prototype.sourceView):
(WebInspector.FrameResourceTreeElement.prototype._sourceViewTextEdited):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate LayoutUnit usage in RenderView
leviw@chromium.org [Fri, 6 Apr 2012 14:10:43 +0000 (14:10 +0000)]
Update LayoutUnit usage in RenderView
https://bugs.webkit.org/show_bug.cgi?id=83147

Reviewed by Julien Chaffraix.

Updating the usage of LayoutUnits in RenderView in preparation for sub-pixel layout. This mostly
affects paint and repaint functions, which take LayoutRects up to the RenderView level. This is
necessary as we continue to accumulate sub-pixel offsets up to this level.

No new tests. No change in behavior.

* rendering/RenderView.cpp:
(WebCore::RenderView::paint): Adding an assert that we're being called to paint on pixel
boundaries. We don't currently ever position RenderViews at sub-pixel offsets.
(WebCore::RenderView::shouldRepaint):
(WebCore::RenderView::repaintViewRectangle): Switching to a LayoutRect and cleaning up a fixme
that used decomposed offsets. Pixel snapping is applied before handing the rect up to the
FrameView.
(WebCore::RenderView::repaintRectangleInViewAndCompositedLayers): Pixel snapping before handing
the rect up to the Compositor.
(WebCore::RenderView::computeRectForRepaint):
(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::viewRect):
(WebCore::RenderView::unscaledDocumentRect):
* rendering/RenderView.h:
(RenderView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Text selection - Can't select texts
commit-queue@webkit.org [Fri, 6 Apr 2012 12:53:37 +0000 (12:53 +0000)]
[BlackBerry] Text selection - Can't select texts
https://bugs.webkit.org/show_bug.cgi?id=83355

Fix the problem of not sending out the result of the function
SelectionHandler::regionForTextQuads(). This regression issue
is introduced by the git commit f9446b7d671d48a833ab0acf12b1e20637e0a910.

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-04-06
Reviewed by George Staikos.

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::regionForTextQuads):
    Add code to return the function result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: hide popover on mouseout from anchor
caseq@chromium.org [Fri, 6 Apr 2012 12:49:55 +0000 (12:49 +0000)]
Web Inspector: hide popover on mouseout from anchor
https://bugs.webkit.org/show_bug.cgi?id=83362

Reviewed by Pavel Feldman.

- start hide popover timer when mouse moves out of popover anchor, as we won't receive mousemove events any more;
- factored out starting of popover kill timer to a method.

* inspector/front-end/Popover.js:
(WebInspector.PopoverHelper):
(WebInspector.PopoverHelper.prototype._mouseMove): Factored out StartHidePopoverTimer()
(WebInspector.PopoverHelper.prototype._mouseOut): Just call StartHidePopoverTimer() when mouse moves out of anchor.
(WebInspector.PopoverHelper.prototype._startHidePopoverTimer.doHide):
(WebInspector.PopoverHelper.prototype._startHidePopoverTimer):
(WebInspector.PopoverHelper.prototype._hidePopover): Reset hoverElement (aka anchor) when hiding popover.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unskipped some tests that now pass.
ossy@webkit.org [Fri, 6 Apr 2012 12:08:37 +0000 (12:08 +0000)]
[Qt] Unskipped some tests that now pass.

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-04-06
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Web Inspector: getEventListeners(window) crashes on NTP
caseq@chromium.org [Fri, 6 Apr 2012 12:07:11 +0000 (12:07 +0000)]
[Chromium] Web Inspector: getEventListeners(window) crashes on NTP
https://bugs.webkit.org/show_bug.cgi?id=83353

Reviewed by Pavel Feldman.

Source/WebCore:

* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::getEventListenersCallback):

LayoutTests:

* inspector/console/command-line-api-getEventListeners-expected.txt:
* inspector/console/command-line-api-getEventListeners.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTouch ChromeClient.h to fix Chromium build.
tkent@chromium.org [Fri, 6 Apr 2012 10:37:08 +0000 (10:37 +0000)]
Touch ChromeClient.h to fix Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=83258

* page/ChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [Qt][Mac] Skip new failing tests to paing the bot green.
ossy@webkit.org [Fri, 6 Apr 2012 10:26:32 +0000 (10:26 +0000)]
   [Qt][Mac] Skip new failing tests to paing the bot green.

* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Fri, 6 Apr 2012 10:04:33 +0000 (10:04 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-5.0/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
* platform/qt-5.0/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/qt-arm/Skipped: Skip new failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInitial LocalizedDateICU.cpp implementation
tkent@chromium.org [Fri, 6 Apr 2012 10:01:09 +0000 (10:01 +0000)]
Initial LocalizedDateICU.cpp implementation
https://bugs.webkit.org/show_bug.cgi?id=60868

Reviewed by Hajime Morita.

Source/WebCore:

Add LocalizedDateICU.cpp, which supports only Date type.  It uses a
short format because a date field is keyboard-editable.
e.g. 5/15/11 in US locale.

* WebCore.gyp/WebCore.gyp: Exclude LocalizedDateNone.cpp.
* WebCore.gypi: Add LocalizedDateICU.cpp.
* platform/text/LocalizedDateICU.cpp: Added.
(WebCore::parseLocalizedDate):
(WebCore::formatLocalizedDate):

LayoutTests:

* platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.txt:
* platform/chromium/fast/forms/date/date-input-visible-strings-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, update platform specific expected results.
ossy@webkit.org [Fri, 6 Apr 2012 09:02:48 +0000 (09:02 +0000)]
[Qt] Unreviewed gardening, update platform specific expected results.

* platform/qt/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:
* platform/qt/svg/as-image/img-preserveAspectRatio-support-2-expected.txt:
* platform/qt/svg/as-object/object-box-sizing-no-width-height-expected.txt:
* platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
* platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Fri, 6 Apr 2012 08:29:09 +0000 (08:29 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped: Unskip tests after r113323.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[REGRESSION] Refreshed autofill popup renders garbage
apavlov@chromium.org [Fri, 6 Apr 2012 07:58:18 +0000 (07:58 +0000)]
[REGRESSION] Refreshed autofill popup renders garbage
https://bugs.webkit.org/show_bug.cgi?id=83255
http://code.google.com/p/chromium/issues/detail?id=118374

The code used to update only the PopupContainer coordinates as if they were the coordinates relative
to the root view. Instead, a WebWidget positioned relative to the screen origin holds the PopupContainer,
so it is the WebWidget that should be positioned in PopupContainer::refresh(), and the PopupContainer's
location should be (0, 0) (and their sizes should always be equal).

Reviewed by Kent Tamura.

No new tests, as the popup appearance is not testable in WebKit.

* platform/chromium/PopupContainer.cpp:
(WebCore::PopupContainer::layoutAndCalculateWidgetRect): Variable renamed.
(WebCore::PopupContainer::showPopup): Use m_originalFrameRect rather than frameRect()
for passing into chromeClient.
(WebCore::PopupContainer::showInRect): Set up the correct frameRect() for the container.
(WebCore::PopupContainer::refresh): Resize the container and position the WebWidget correctly.
* platform/chromium/PopupContainer.h:
(PopupContainer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening after r113378. ENABLE(MUTATION_OBSERVERS) is disabled so
zherczeg@webkit.org [Fri, 6 Apr 2012 07:54:15 +0000 (07:54 +0000)]
[Qt] Unreviewed gardening after r113378. ENABLE(MUTATION_OBSERVERS) is disabled so
fast/mutation/clear-transient-without-delivery.html and
fast/mutation/transient-gc-crash.html have been skipped.

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-04-06
Reviewed by Zoltan Herczeg.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCalendar Picker: Add code to open/close the calendar picker
tkent@chromium.org [Fri, 6 Apr 2012 07:45:48 +0000 (07:45 +0000)]
Calendar Picker: Add code to open/close the calendar picker
https://bugs.webkit.org/show_bug.cgi?id=83258

Reviewed by Hajime Morita.

Source/WebCore:

No new tests. This code is not used because of no ENABLE_INPUT_TYPE_DATE.

* WebCore.gypi: Add existing header files.

* html/DateInputType.cpp:
(WebCore::DateInputType::DateInputType):
Moved from DateInputType.h because the constructor depends on
CalendarPickerElement.
(WebCore::DateInputType::createShadowSubtree):
Store a CalendarPickerElement object.
(WebCore::DateInputType::destroyShadowSubtree):
Release the CalendarPickerElement object.
(WebCore::DateInputType::handleBlurEvent):
Close the calendar picker when the input loses focus.
* html/DateInputType.h:
(DateInputType):
- Move the constructor definition to DateInputType.cpp
- Add function declarations
- Add m_pickerElement data member.

* html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::hostInput): A helper to get the host <input>.
(WebCore::CalendarPickerElement::defaultEventHandler):
If the element is clicked, open a calendar picker.
(WebCore::CalendarPickerElement::openPopup):
Opens a calendar picker by ChromeClient::openPagePopup().
(WebCore::CalendarPickerElement::closePopup):
Closes a calendar picker by ChromeClient::closePagePopup().
(WebCore::CalendarPickerElement::detach):
Closes a calendar picker when the element loses a renderer.

(WebCore::CalendarPickerElement::contentSize):
Provides the initial size of a popup.
(WebCore::addString): A helper for writeDocument().
(WebCore::addJavaScriptString): ditto.
(WebCore::addProperty): ditto.
(WebCore::CalendarPickerElement::writeDocument):
Provides the source of a popup. The function creates a complete HTML with:
- WebCore/Resources/calendarPicker.css
- WebCore/Resources/calendarPicker.js
- An object to pass localization strings and <input> state
(WebCore::CalendarPickerElement::setValueAndClosePopup):
Sets the value from a calendar picker to the <input>.
(WebCore::CalendarPickerElement::didClosePopup):
Clear the popup object.
* html/shadow/CalendarPickerElement.h:
(CalendarPickerElement): Add declarations.

* platform/text/LocalizedCalendarICU.cpp:
(WebCore::getFirstDayOfWeek): Make sure this is 0-base. UCAL_SUNDAY is 1.

Source/WebKit/chromium:

* features.gypi: Enable ENABLE_PAGE_POPUP for non-Android
platforms. This is needed because ENABLE_CALENDAR_PICKER now depends on
ENABLE_PAGE_POPUP.
* src/ChroemClientImpl.cpp: Add stubs.
(WebKit::ChromeClientImpl::openPagePopup):
(WebKit::ChromeClientImpl::closePagePopup):
* src/ChromeClientImpl.h: Add declarations of openPagePopup() and closePagePopup().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/11133179> and https://bugs.webkit.org/show_bug.cgi?id=74129
adele@apple.com [Fri, 6 Apr 2012 05:23:25 +0000 (05:23 +0000)]
<rdar://problem/11133179> and https://bugs.webkit.org/show_bug.cgi?id=74129
REGRESSION (SnowLeopard, 5.1.4): All WK2 horizontal scrollbars look broken

Patch by Dan Bernstein, Reviewed by Beth Dakin.

This code assumed that the current CTM wouldn't have extraneous operations built into it,
but this bug is evidence that that assumption was wrong. We should just get the base CTM instead
and apply the device scale factor to it.

No tests added since the SnowLeopard-style scrollbars aren't testable in our regression tests right now.

* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):
(WebCore::GraphicsContext::applyDeviceScaleFactor):
* platform/graphics/GraphicsContext.h: (GraphicsContext):
* platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::platformApplyDeviceScaleFactor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLeak in WebSocketChannel with workers/worker-reload.html
yutak@chromium.org [Fri, 6 Apr 2012 05:16:05 +0000 (05:16 +0000)]
Leak in WebSocketChannel with workers/worker-reload.html
https://bugs.webkit.org/show_bug.cgi?id=83345

Reviewed by David Levin.

A speculative fix of memory leaks caused by worker-reload.html.

No new tests, as this change imposes no functional change.

* Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::mainThreadDestroy):
Receive the peer as PassOwnPtr<> so the destructor of the task object can
delete the peer even if the task didn't run before main thread's cleanup period.
(WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
* Modules/websockets/WorkerThreadableWebSocketChannel.h:
(WorkerThreadableWebSocketChannel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocombine two arrays (coreExceptionNames and coreExceptionDescriptions) into one array
commit-queue@webkit.org [Fri, 6 Apr 2012 04:57:45 +0000 (04:57 +0000)]
combine two arrays (coreExceptionNames and coreExceptionDescriptions) into one array
https://bugs.webkit.org/show_bug.cgi?id=83141

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-04-05
Reviewed by Adam Barth.

No new tests required.

* dom/DOMCoreException.cpp:
(CoreException):
(WebCore):
(WebCore::DOMCoreException::initializeDescription):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline a couple tests for GTK+.
mrobinson@webkit.org [Fri, 6 Apr 2012 04:49:34 +0000 (04:49 +0000)]
Rebaseline a couple tests for GTK+.

* platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
* platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening; update expctations in fast/css-generated-content.
rakuco@webkit.org [Fri, 6 Apr 2012 04:26:50 +0000 (04:26 +0000)]
[EFL] Gardening; update expctations in fast/css-generated-content.

Mostly adapt to the size changes after the jhbuild and font
commits.

* platform/efl/fast/css-generated-content/003-expected.txt:
* platform/efl/fast/css-generated-content/009-expected.png:
* platform/efl/fast/css-generated-content/009-expected.txt:
* platform/efl/fast/css-generated-content/013-expected.png:
* platform/efl/fast/css-generated-content/013-expected.txt:
* platform/efl/fast/css-generated-content/014-expected.png:
* platform/efl/fast/css-generated-content/014-expected.txt:
* platform/efl/fast/css-generated-content/after-duplicated-after-split-expected.png:
* platform/efl/fast/css-generated-content/after-duplicated-after-split-expected.txt:
* platform/efl/fast/css-generated-content/inline-display-types-expected.png:
* platform/efl/fast/css-generated-content/inline-display-types-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening after r110072.
rakuco@webkit.org [Fri, 6 Apr 2012 04:26:27 +0000 (04:26 +0000)]
[EFL] Gardening after r110072.

* platform/efl/fast/clip/008-expected.png:
* platform/efl/fast/clip/008-expected.txt:
* platform/efl/fast/clip/011-expected.png:
* platform/efl/fast/clip/011-expected.txt:
* platform/efl/fast/clip/012-expected.png:
* platform/efl/fast/clip/012-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening after r112112.
rakuco@webkit.org [Fri, 6 Apr 2012 04:26:08 +0000 (04:26 +0000)]
[EFL] Gardening after r112112.

* platform/efl/css2.1/20110323/c543-txt-decor-000-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113409 268f45cc-cd09-0410-ab3c-d52691b4dbfc