kevino@webkit.org [Mon, 20 Jun 2011 18:30:42 +0000 (18:30 +0000)]
[wx] Unreviewed build fix, fix the codepaths run under each CPU type.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89264
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 20 Jun 2011 18:28:48 +0000 (18:28 +0000)]
2011-06-20 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Ojan Vafai.
FrameSelection::modify should take verticalDisplacement instead of verticalDistance
https://bugs.webkit.org/show_bug.cgi?id=62932
Added new VerticalDirection enum to the argument list of FrameSelection::modify that takes
verticalDistance. Also changed the type of verticalDistance from int to unsigned int
to accidentally pass a negative distance in the future.
* editing/EditorCommand.cpp:
(WebCore::verticalScrollDistance): Returns unsigned int instead of int.
(WebCore::executeMovePageDown): Calls FrameSelection::modify.
(WebCore::executeMovePageDownAndModifySelection): Ditto.
(WebCore::executeMovePageUp): Ditto.
(WebCore::executeMovePageUpAndModifySelection): Ditto.
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::modify): Takes VerticalDirection as an argument.
* editing/FrameSelection.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89263
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Mon, 20 Jun 2011 18:03:19 +0000 (18:03 +0000)]
2011-06-20 Stephen White <senorblanco@chromium.org>
Unreviewed, test_expectations fix.
Revert some unintentional changes from my last patch.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89262
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 20 Jun 2011 17:55:24 +0000 (17:55 +0000)]
2011-06-20 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Barth.
Don't use PassRefPtr variables in the V8 bindings generator
https://bugs.webkit.org/show_bug.cgi?id=62947
* bindings/scripts/CodeGeneratorV8.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89261
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 20 Jun 2011 17:54:45 +0000 (17:54 +0000)]
2011-06-20 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Several pyauto tests are failing because some infobars
https://bugs.webkit.org/show_bug.cgi?id=62968
This function used to evaluate script as if there was a user gesture
(due to the lack of a source URL). This patch re-introduces the user
gesture (this time explicitly), which causes the pyauto tests listed in
http://code.google.com/p/chromium/issues/detail?id=86397 to start
passing again. It's unclear whether this forced gesture is needed in
non-test scenarios.
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::executeScriptAndReturnValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89260
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Mon, 20 Jun 2011 17:52:58 +0000 (17:52 +0000)]
2011-06-20 Stephen White <senorblanco@chromium.org>
Unreviewed.
New baselines for tests affected by r62988.
* platform/chromium-linux-x86/svg/wicd/test-scalable-background-image2-expected.png: Removed.
* platform/chromium-linux/plugins/embed-attributes-style-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/text-text-08-b-expected.png:
* platform/chromium-linux/svg/batik/text/textDecoration-expected.png:
* platform/chromium-linux/svg/css/text-shadow-multiple-expected.png:
* platform/chromium-linux/svg/filters/sourceAlpha-expected.png:
* platform/chromium-linux/svg/text/text-text-08-b-expected.png:
* platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89259
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 20 Jun 2011 17:51:40 +0000 (17:51 +0000)]
2011-06-20 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
ASSERT in WebCore::HTMLToken::appendToAttributeName when visiting www.nba.com
https://bugs.webkit.org/show_bug.cgi?id=61774
* fast/parser/attributes-on-close-script-expected.txt: Added.
* fast/parser/attributes-on-close-script.html: Added.
2011-06-20 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
ASSERT in WebCore::HTMLToken::appendToAttributeName when visiting www.nba.com
https://bugs.webkit.org/show_bug.cgi?id=61774
This ASSERT triggers for the same underlying issue that causes
Bug 62971: When we tokenize a </script> tag, we don't realize that
we've already consumed the "</script>" from the input stream when we
extracted the previous token. That causes the source tracker to be
out-of-sync, triggering the incorrect view-source highlighting and this
ASSERT.
For now, let's just silence the assert while we work on Bug 62971.
Test: fast/parser/attributes-on-close-script.html
* html/parser/HTMLToken.h:
(WebCore::HTMLToken::appendToAttributeName):
(WebCore::AtomicHTMLToken::initializeAttributes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89258
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Mon, 20 Jun 2011 17:49:34 +0000 (17:49 +0000)]
2011-06-20 Juan C. Montemayor <jmont@apple.com>
Reviewed by Oliver Hunt.
No context for javascript parse errors.
https://bugs.webkit.org/show_bug.cgi?id=62613
Ran 'run-webkit-tests --reset' with 'fast/js/' and 'sputnik' to update
those tests with the new parser error messages.
The test 'fast/js/script-tests/parser-syntax-check.js' was fixed to
not fail with the new parser error messages.
* fast/dom/SelectorAPI/unknown-pseudo-expected.txt:
* fast/dom/javascript-url-exception-isolation-expected.txt:
* fast/encoding/meta-in-script-expected.txt:
* fast/events/window-onerror5-expected.txt:
* fast/events/window-onerror6-expected.txt:
* fast/js/assign-expected.txt:
* fast/js/basic-strict-mode-expected.txt:
* fast/js/break-ASI-expected.txt:
* fast/js/function-declaration-expected.txt:
* fast/js/function-toString-object-literals-expected.txt:
* fast/js/function-toString-parentheses-expected.txt:
* fast/js/js-continue-break-restrictions-expected.txt:
* fast/js/kde/garbage-n-expected.txt:
* fast/js/kde/parse-expected.txt:
* fast/js/kde/string-1-n-expected.txt:
* fast/js/kde/string-2-n-expected.txt:
* fast/js/mozilla/strict/12.14.1-expected.txt:
* fast/js/mozilla/strict/13.1-expected.txt:
* fast/js/mozilla/strict/regress-532254-expected.txt:
* fast/js/no-semi-insertion-at-end-of-script-expected.txt:
* fast/js/numeric-escapes-in-string-literals-expected.txt:
* fast/js/object-extra-comma-expected.txt:
* fast/js/object-literal-syntax-expected.txt:
* fast/js/parser-xml-close-comment-expected.txt:
* fast/js/postfix-syntax-expected.txt:
* fast/js/regexp-compile-crash-expected.txt:
* fast/js/removing-Cf-characters-expected.txt:
* fast/js/reserved-words-as-property-expected.txt:
* fast/js/script-tests/parser-syntax-check.js:
(runTest):
* fast/parser/entity-end-script-tag-expected.txt:
* fast/regex/non-pattern-characters-expected.txt:
* html5lib/runner-expected.txt:
* http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt:
* http/tests/workers/shared-worker-importScripts-expected.txt:
* http/tests/workers/worker-importScripts-expected.txt:
* inspector/console/console-log-syntax-error-expected.txt:
* inspector/debugger/debugger-autocontinue-on-syntax-error-expected.txt:
* java/lc3/JavaObject/JavaObjectToBoolean-001-n-expected.txt:
* loader/reload-subresource-when-type-changes-expected.txt:
* platform/mac/fast/tokenizer/002-expected.txt:
* platform/mac/fast/tokenizer/external-script-document-write_2-expected.txt:
* platform/mac/fast/tokenizer/script_extra_close-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T3-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T4-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T5-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.1_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.1_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.2_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.2_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.3-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.4-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.1_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.1_T3-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.2_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.2_T3-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.3_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.4_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T3-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T4-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A2_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A3-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A4_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A4_T4-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.10-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.11-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.12-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.13-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.14-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.15-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.16-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.17-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.19-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.20-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.21-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.22-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.23-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.24-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.25-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.3-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.4-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.5-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.6-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.7-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.8-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.9-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.10-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.11-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.16-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.27-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.5-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.6-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.7-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.9-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T10-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T3-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T4-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T5-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T6-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T7-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T8-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.7_Punctuators/S7.7_A2_T9-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.1_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.1_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.2_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.2_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A1.1_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A1.1_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A1.2_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A1.2_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A3.1_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A3.1_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A3.2_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A3.2_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.1_T4-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T3-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T4-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T5-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.4_String_Literals/S7.8.4_A7.2_T6-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.2_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.2_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.2_T3-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.2_T4-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.3_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.3_T3-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.5_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.5_T3-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.2_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.2_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.3_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.3_T3-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.5_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.5_T3-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A3.1_T7-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A3.1_T8-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A3.1_T9-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples/S7.9.2_A1_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples/S7.9.2_A1_T3-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples/S7.9.2_A1_T6-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A10_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A10_T4-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A10_T6-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A10_T8-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A11_T4-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A11_T8-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A4-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A5.1_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A5.3_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T10-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T3-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T4-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T5-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T6-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T7-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T8-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T9-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T3-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T4-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T5-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T6-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T7-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.4_T1-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.4_T2-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A9_T6-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A9_T7-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A9_T8-expected.txt:
* sputnik/Conformance/08_Types/8.2_The_Null_Type/S8.2_A2-expected.txt:
* sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A13_T1-expected.txt:
* sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A13_T2-expected.txt:
* sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A13_T3-expected.txt:
* sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A14_T1-expected.txt:
* sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A14_T2-expected.txt:
* sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A14_T3-expected.txt:
* sputnik/Conformance/11_Expressions/11.2_Left_Hand_Side_Expressions/11.2.4_Argument_Lists/S11.2.4_A1.3_T1-expected.txt:
* sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.1_Postfix_Increment_Operator/S11.3.1_A1.1_T1-expected.txt:
* sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.1_Postfix_Increment_Operator/S11.3.1_A1.1_T2-expected.txt:
* sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.1_Postfix_Increment_Operator/S11.3.1_A1.1_T3-expected.txt:
* sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.1_Postfix_Increment_Operator/S11.3.1_A1.1_T4-expected.txt:
* sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.2_Postfix_Decrement_Operator/S11.3.2_A1.1_T1-expected.txt:
* sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.2_Postfix_Decrement_Operator/S11.3.2_A1.1_T2-expected.txt:
* sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.2_Postfix_Decrement_Operator/S11.3.2_A1.1_T3-expected.txt:
* sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.2_Postfix_Decrement_Operator/S11.3.2_A1.1_T4-expected.txt:
* sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A2_T1-expected.txt:
* sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A3_T1-expected.txt:
* sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A3_T2-expected.txt:
* sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A3_T3-expected.txt:
* sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A3_T4-expected.txt:
* sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A3_T5-expected.txt:
* sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T1-expected.txt:
* sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T10-expected.txt:
* sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T11-expected.txt:
* sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T12-expected.txt:
* sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T13-expected.txt:
* sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T14-expected.txt:
* sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T15-expected.txt:
* sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T2-expected.txt:
* sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T3-expected.txt:
* sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T4-expected.txt:
* sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T5-expected.txt:
* sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T6-expected.txt:
* sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T7-expected.txt:
* sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T8-expected.txt:
* sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T9-expected.txt:
* sputnik/Conformance/12_Statement/12.1_Block/S12.1_A4_T1-expected.txt:
* sputnik/Conformance/12_Statement/12.1_Block/S12.1_A4_T2-expected.txt:
* sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T1-expected.txt:
* sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T2-expected.txt:
* sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T3-expected.txt:
* sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T4-expected.txt:
* sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T5-expected.txt:
* sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T6-expected.txt:
* sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T7-expected.txt:
* sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T8-expected.txt:
* sputnik/Conformance/12_Statement/12.4_Expression_Statement/S12.4_A1-expected.txt:
* sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A11-expected.txt:
* sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T1-expected.txt:
* sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T2-expected.txt:
* sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A8-expected.txt:
* sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A9_T3-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A12-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A13_T3-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A15-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T1-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T2-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T3-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T4-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T5-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T6-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A13_T3-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A15-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T1-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T2-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T3-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T4-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T5-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T6-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A11.1_T3-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A11_T3-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A12.1_T3-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A12_T3-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A4.1-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A4_T1-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A4_T2-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A7.1_T1-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A7.1_T2-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A7_T1-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A7_T2-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8.1_T1-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8.1_T2-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8.1_T3-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T1-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T2-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T3-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.4_The_for_in_Statement/S12.6.4_A13_T3-expected.txt:
* sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.4_The_for_in_Statement/S12.6.4_A15-expected.txt:
* sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T1-expected.txt:
* sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T2-expected.txt:
* sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T3-expected.txt:
* sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T4-expected.txt:
* sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T1-expected.txt:
* sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T2-expected.txt:
* sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T3-expected.txt:
* sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A6-expected.txt:
* sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A8_T1-expected.txt:
* sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A8_T2-expected.txt:
* sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T1-expected.txt:
* sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T2-expected.txt:
* sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T3-expected.txt:
* sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T4-expected.txt:
* sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T1-expected.txt:
* sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T2-expected.txt:
* sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T3-expected.txt:
* sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A6-expected.txt:
* sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A8_T1-expected.txt:
* sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A8_T2-expected.txt:
* sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T1-expected.txt:
* sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T10-expected.txt:
* sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T2-expected.txt:
* sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T3-expected.txt:
* sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T4-expected.txt:
* sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T5-expected.txt:
* sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T6-expected.txt:
* sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T7-expected.txt:
* sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T8-expected.txt:
* sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T9-expected.txt:
* sputnik/Conformance/13_Function_Definition/S13_A7_T3-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.2/15.1.2.1_eval/S15.1.2.1_A2_T2-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.4/15.3.4.2_Function.prototype.toString/S15.3.4.2_A1_T1-expected.txt:
2011-06-20 Juan C. Montemayor <jmont@apple.com>
Reviewed by Oliver Hunt.
No context for javascript parse errors.
https://bugs.webkit.org/show_bug.cgi?id=62613
Parse errors now show more details like:
"Unexpected token: ]"
or
"Expected token: while"
For reserved names, numbers, indentifiers, strings, lexer errors,
and EOFs, the following error messages are printed:
"Use of reserved word: super"
"Unexpected number: 42"
"Unexpected identifier: "
"Unexpected string: "foobar""
"Invalid token character sequence: \u4023"
"Unexpected EOF"
* parser/JSParser.cpp:
(JSC::JSParser::consume):
(JSC::JSParser::getToken):
(JSC::JSParser::getTokenName):
(JSC::JSParser::updateErrorMessageSpecialCase):
(JSC::JSParser::updateErrorMessage):
(JSC::JSParser::updateErrorWithNameAndMessage):
(JSC::jsParse):
(JSC::JSParser::JSParser):
(JSC::JSParser::parseProgram):
(JSC::JSParser::parseVarDeclarationList):
(JSC::JSParser::parseForStatement):
(JSC::JSParser::parseBreakStatement):
(JSC::JSParser::parseContinueStatement):
(JSC::JSParser::parseWithStatement):
(JSC::JSParser::parseTryStatement):
(JSC::JSParser::parseStatement):
(JSC::JSParser::parseFormalParameters):
(JSC::JSParser::parseFunctionInfo):
(JSC::JSParser::parseAssignmentExpression):
(JSC::JSParser::parsePrimaryExpression):
(JSC::JSParser::parseMemberExpression):
(JSC::JSParser::parseUnaryExpression):
* parser/JSParser.h:
* parser/Lexer.cpp:
(JSC::Lexer::lex):
* parser/Parser.cpp:
(JSC::Parser::parse):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89257
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Mon, 20 Jun 2011 17:49:13 +0000 (17:49 +0000)]
2011-06-20 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[UNIX] Don't use WebCore::PluginPackage to get plugin information
https://bugs.webkit.org/show_bug.cgi?id=62899
The problem is that both PluginPackage in WebCore and
NetscapePluginModule in webkit2 install their own netscape browser
functions and that can cause conflicts in some situations.
* Shared/Plugins/Netscape/NetscapePluginModule.h: Add helper
function to set plugin mime type descriptions.
* Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
(WebKit::NetscapePluginModule::setMIMEDescription): Helper
function to set plugin mime type descriptions.
(WebKit::NetscapePluginModule::getPluginInfo): Use
NetscapePluginModule instead of PluginPackage.
* UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp: Remove unneeded
header include.
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue): Do not try to get the XDisplay if the
plugin doesn't have a view. It fixes a crash with flash plugin and
matches WebCore.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89256
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Mon, 20 Jun 2011 17:35:31 +0000 (17:35 +0000)]
2011-06-20 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix WebKit2 GTK build after r89249.
* GtkLauncher/main.c:
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89255
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Mon, 20 Jun 2011 17:18:47 +0000 (17:18 +0000)]
2011-06-20 Andras Becsi <abecsi@webkit.org>
Unreviewed build fix.
[Qt][V8] Include missing UnusedParam.h.
No new tests needed.
* rendering/svg/SVGTextLayoutEngineSpacing.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89254
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Mon, 20 Jun 2011 17:01:53 +0000 (17:01 +0000)]
2011-06-20 Andras Becsi <abecsi@webkit.org>
Rubber-stamped by Csaba Osztrogonác.
[Qt][V8] Remove non-existing headers from project file.
No new tests needed.
* WebCore.pro: Remove ChildThreadDOMData.h and MainThreadDOMData.h,
since they have been already removed earlier from tree.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89253
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 20 Jun 2011 16:48:23 +0000 (16:48 +0000)]
2011-06-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: remove LayoutTestController::setTimelineProfilingEnabled.
https://bugs.webkit.org/show_bug.cgi?id=62994
* public/WebDevToolsAgent.h:
* src/WebDevToolsAgentImpl.cpp:
* src/WebDevToolsAgentImpl.h:
2011-06-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: remove LayoutTestController::setTimelineProfilingEnabled.
https://bugs.webkit.org/show_bug.cgi?id=62994
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-06-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: remove LayoutTestController::setTimelineProfilingEnabled.
https://bugs.webkit.org/show_bug.cgi?id=62994
* DumpRenderTree/LayoutTestController.cpp:
(closeWebInspectorCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
* DumpRenderTree/chromium/DRTDevToolsAgent.h:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89252
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Mon, 20 Jun 2011 16:40:08 +0000 (16:40 +0000)]
2011-06-20 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Split libWebCore into two libWebCore and libWebCoreGtk
https://bugs.webkit.org/show_bug.cgi?id=60539
libWebCore contains all the webcore files except the ones actually
using gtk while libWebCoreGtk contains only the files using
gtk. It allows us to build a common WebCore lib and two different
gtk WebCore libs depending on the gtk version. In WeKit2 gtk2 is
not supported, but the plugin process needs to be built using gtk2
because plugins like flash still use gtk2. For WebKit2, we build
the common libWebCore and two libWebCoreGtk, one using gtk3 and
the other one using gtk2.
* GNUmakefile.am:
* GNUmakefile.list.am:
2011-06-20 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Split libWebCore into two libWebCore and libWebCoreGtk
https://bugs.webkit.org/show_bug.cgi?id=60539
* GNUmakefile.am: Link to libWebCoreGtk.la too.
2011-06-20 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Split libWebCore into two libWebCore and libWebCoreGtk
https://bugs.webkit.org/show_bug.cgi?id=60539
* GNUmakefile.am: Link to libWebCoreGtk.la too.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89251
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 20 Jun 2011 16:37:46 +0000 (16:37 +0000)]
2011-06-20 Mike Reed <reed@google.com>
Reviewed by Stephen White.
[Skia] remove repeated calls to setColor, which ignored global-alpha (previous setupPaintFor... already set the color+alpha)
https://bugs.webkit.org/show_bug.cgi?id=62988
No new tests. removing redundant calls
* platform/graphics/chromium/FontLinux.cpp:
(WebCore::Font::drawGlyphs):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89250
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Mon, 20 Jun 2011 16:25:10 +0000 (16:25 +0000)]
2011-06-20 Lukasz Slachciak <l.slachciak@samsung.com>
Reviewed by Martin Robinson.
[GTK] General mechanism for adjusting WebKitWebSettings in GtkLauncher.
https://bugs.webkit.org/show_bug.cgi?id=55308
* GtkLauncher/main.c: Added general mechanism for adjusting WebKitWebSettings.
(parseOptionEntryCallback): Callback for parsing option entry.
(getOptionEntriesFromWebKitWebSettings): Basing on the WebKitWebSettings properties prepare
list of option entries.
(transformStringToBoolean): Transform function for boolean convertion used by parseOptionEntryCallback.
(transformStringToInt): Transform function for int convertion used by parseOptionEntryCallback.
(transformStringToFloat): Transform function for float convertion used by parseOptionEntryCallback.
(parseAdditionalOptions): Help function parsing additional commandline options.
(main): Added call to parseAdditionalOptions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89249
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Mon, 20 Jun 2011 15:50:29 +0000 (15:50 +0000)]
2011-06-19 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] ASSERTION FAILED: it != gFontDataCache->end() in FontCache.cpp:318
https://bugs.webkit.org/show_bug.cgi?id=62942
Fix the == operator overload of the FreeType FontPlatformData to properly make the
distinction between the hash table deleted value and the hash table empty value.
No new tests. This is covered by existing tests, which should no longer
hit assertions.
* platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::operator==): Reorder the logic for determining if two
FontPlatformData instances are equal. Do a pointer comparison on the Fontconfig patterns,
instead of using FcPatternEqual. If the two Fontconfig patterns have different pointers
they were created at different times and the overload should return false.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89248
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 20 Jun 2011 14:31:25 +0000 (14:31 +0000)]
2011-06-20 Mike Reed <reed@google.com>
Reviewed by Stephen White.
disable test in preparation for chromium change and new baseline
https://bugs.webkit.org/show_bug.cgi?id=62984
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89246
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Mon, 20 Jun 2011 14:10:42 +0000 (14:10 +0000)]
2011-06-20 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: It would be useful to be able to pause on element's style change.
https://bugs.webkit.org/show_bug.cgi?id=62982
Current workaround is to use mutation events but it's awkward and doesn't
compare _usability-wise_ to what could be implemented as native support in web inspector.
In complex applications, being able to see which code causes element to change its style is indispensable.
* inspector/debugger/dom-breakpoints.html:
* platform/chromium/inspector/debugger/dom-breakpoints-expected.txt:
2011-06-20 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: It would be useful to be able to pause on element's style change.
https://bugs.webkit.org/show_bug.cgi?id=62982
Current workaround is to use mutation events but it's awkward and doesn't
compare _usability-wise_ to what could be implemented as native support in web inspector.
In complex applications, being able to see which code causes element to change its style is indispensable.
* inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::didInvalidateStyleAttr):
* inspector/InspectorDOMDebuggerAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89245
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
chang.shu@nokia.com [Mon, 20 Jun 2011 13:55:42 +0000 (13:55 +0000)]
2011-06-20 Chang Shu <cshu@webkit.org>
unreviewed.
Unskip passing tests. The bug(42317) has been resolved for a long time.
* platform/qt-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89244
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 20 Jun 2011 13:15:42 +0000 (13:15 +0000)]
[WK2] Daily gardening.
* platform/mac-wk2/Skipped: Skip some tests bacause of missing animation pause API
and skip one test because of missing window.internals.createShadowContentElement.
* platform/qt-wk2/Skipped: Skip one failing SVG test after r89233.
* platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: Updated after r89233.
* platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt: Updated after r89233.
* platform/qt-wk2/fast/dom/prototype-inheritance-2-expected.txt: Updated after r89233.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89243
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Mon, 20 Jun 2011 12:48:34 +0000 (12:48 +0000)]
2011-06-20 Yuta Kitamura <yutak@chromium.org>
Unreviewed, add more Chromium expectations for tests which started to fail since r89233.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89242
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 20 Jun 2011 10:35:56 +0000 (10:35 +0000)]
2011-06-20 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Andreas Kling.
[Qt] [WK2] Compile error in ActivateFontsQt.cpp on Mac
https://bugs.webkit.org/show_bug.cgi?id=62869
Add QFont include to fix "incomlete type QFont" error.
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89241
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Mon, 20 Jun 2011 10:32:27 +0000 (10:32 +0000)]
2011-06-20 Yuta Kitamura <yutak@chromium.org>
Unreviewed, fix an error in the last edit of Chromium test_expectations.txt.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89240
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Mon, 20 Jun 2011 10:20:21 +0000 (10:20 +0000)]
2011-06-20 Yuta Kitamura <yutak@chromium.org>
Unreviewed, add new Chromium test expectations since r89233.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89239
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 20 Jun 2011 10:15:18 +0000 (10:15 +0000)]
[Qt][Mac] Skip failing tests.
* platform/qt-mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89238
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 20 Jun 2011 09:43:46 +0000 (09:43 +0000)]
[Qt] Unreviewed, update Qt specific expected results after r89233, and skip failing tests until fix.
Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths
from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085
* platform/qt/Skipped:
* platform/qt/fast/dom/Window/window-properties-expected.png: Added.
* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.png: Added.
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-2-expected.png: Added.
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-expected.png: Added.
* platform/qt/fast/dom/prototype-inheritance-expected.txt:
* platform/qt/fast/js/global-constructors-expected.png: Added.
* platform/qt/fast/js/global-constructors-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
* platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/render-elems-06-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/render-elems-07-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/render-elems-08-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
* platform/qt/svg/custom/glyph-transformation-with-hkern-expected.png: Added.
* platform/qt/svg/custom/glyph-transformation-with-hkern-expected.txt: Added.
* platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
* platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
* platform/qt/svg/custom/svg-features-expected.png: Added.
* platform/qt/svg/custom/svg-features-expected.txt: Added.
* platform/qt/svg/custom/svg-fonts-in-html-expected.png:
* platform/qt/svg/custom/svg-fonts-in-html-expected.txt:
* platform/qt/svg/foreignObject/text-tref-02-b-expected.png:
* platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:
* platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.png:
* platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
* platform/qt/svg/wicd/test-rightsizing-b-expected.png:
* platform/qt/svg/wicd/test-rightsizing-b-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89237
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ager@chromium.org [Mon, 20 Jun 2011 09:36:13 +0000 (09:36 +0000)]
2011-06-19 Mads Ager <ager@chromium.org>
Reviewed by Adam Barth.
[V8] Fix WebGL bindings for subarrays
https://bugs.webkit.org/show_bug.cgi?id=62864
Mark WebGL subarrays as independent of other DOM objects in the
V8 bindings. This allows us to clean them up independently which
greatly improves performance.
* bindings/v8/V8Proxy.h:
(WebCore::toV8Independent):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89236
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Mon, 20 Jun 2011 09:18:38 +0000 (09:18 +0000)]
2011-06-20 Yuta Kitamura <yutak@chromium.org>
Unreviewed build fix for Chromium Clang builders.
* platform/graphics/FontFallbackList.h: Declare SVGTextRunRenderingContext as class, not struct.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89235
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Mon, 20 Jun 2011 08:22:44 +0000 (08:22 +0000)]
2011-06-20 MORITA Hajime <morrita@google.com>
Unreviewed GTK build fix.
This change corrected syntax error on symbols.filter.
* Source/autotools/symbols.filter:
2011-06-20 MORITA Hajime <morrita@google.com>
Unreviewed GTK build fix.
This change touched the file to make the build happen.
* dom/EventTarget.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89234
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Mon, 20 Jun 2011 08:12:03 +0000 (08:12 +0000)]
2011-06-20 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085
* wtf/Platform.h: Force Qt-EWS into a full rebuild, otherwhise this patch breaks the EWS.
2011-06-20 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085
font substitution doesn't work for HTML text using SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=17608
Selection rects are wrong for text with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=25460
With @font-face, SVG fonts only work as primary, non-segmented
https://bugs.webkit.org/show_bug.cgi?id=32227
When using SVG fonts with @font-face word-spacing and text-align: justify are not being honored
https://bugs.webkit.org/show_bug.cgi?id=34236
SVG @font-face breaks text-overflow: ellipsis
https://bugs.webkit.org/show_bug.cgi?id=36840
REGRESSION: SVG Font selection problems
https://bugs.webkit.org/show_bug.cgi?id=41934
Tests: svg/custom/svg-fonts-fallback.xhtml (for bug 17608, extended the original test from Mark Ambachtsheer)
svg/custom/svg-fonts-segmented.xhtml (for bug 32227)
svg/custom/svg-fonts-word-spacing.html (for bug 34236, from Michael Lewis)
svg/text/select-text-svgfont.html (for bug 25460/41934, from Emil Schutte)
svg/text/text-overflow-ellipsis-svgfont.html (for 36840, from Emil Schutte)
Rewrite the SVG Fonts support to fully integrate within the GlyphPage concept and the "simple" code path used to render platform fonts.
That means the special logic for measuring text using SVG Fonts, calculating offset for positions, computing selection rects etc. is all gone now.
There's no difference anymore between using a native font or a SVG Font, in terms of these operations.
This makes text selection using SVG Fonts possible again.
* features.pri: Temporarily turn of SVG Fonts for Qt, as long as QRawFont support is not available and the fast path is disabled.
* page/DOMWindow.idl: Touched file to force Qt regenerating the bindings.
* platform/graphics/Font.cpp: Remove SVG Font special cases, the simple code path now handles SVG Fonts as well.
(WebCore::Font::drawText):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::width):
(WebCore::Font::selectionRectForText):
(WebCore::Font::offsetForPosition):
(WebCore::Font::codePath):
* platform/graphics/Font.h: Pass TextRun to drawGlyphBuffer/drawEmphasisMarks. Add new glyphDataAndPageForCharacter() method which returns a pair
std::pair<GlyphData, GlyphPage*>, so we know the associated GlyphPage for a certain GlyphData object, which is needed to properly
handle font fallback glyph matching for SVG Fonts..
(WebCore::Font::fontList): Add FontFallbackList accessor.
* platform/graphics/FontFallbackList.h: Add getters/setters for glyphPageZero -- SVG Fonts support needs access to these objects from SVGTextRunRenderingContext.
(WebCore::FontFallbackList::glyphPageZero):
(WebCore::FontFallbackList::glyphPages):
(WebCore::FontFallbackList::setGlyphPageZero):
(WebCore::FontFallbackList::setGlyphPages):
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::glyphDataForCharacter): Move implementation to glyphDataAndPageForCharacter(), and use that method from here.
(WebCore::Font::glyphDataAndPageForCharacter): Does the same as before, just returns an additional GlyphPage* pointer.
(WebCore::Font::getEmphasisMarkGlyphData): Remove SVG Fonts special case.
(WebCore::Font::drawGlyphBuffer): Ditto.
* platform/graphics/FontMetrics.h:
(WebCore::scaleEmToUnits): Refactored scaleEmToUnits free function from SimpleFontDataMac/CGWin to share with SVGFontData/SVGTextRunRenderingContext.
* platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::fill): Stop skipping SVG Fonts, they now also fill the GlyphPage using the glyphs defined in the SVG Font.
* platform/graphics/SVGGlyph.h: s/isValid/isPartOfLigature/. Its usage has been changed.
(WebCore::SVGGlyph::SVGGlyph):
(WebCore::SVGGlyph::operator==):
* platform/graphics/SimpleFontData.cpp: Change font size to be a float, not an int.
(WebCore::SimpleFontData::SimpleFontData):
* platform/graphics/SimpleFontData.h: Add new pure virtual methods to the AdditionalFontData interface, to be implemented in SVGFontData.
(WebCore::SimpleFontData::widthForGlyph): Call widthForSVGGlyph, if we encounter a SVG glyph.
* platform/graphics/TextRun.h:
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::glyphDataForCharacter):
(WebCore::WidthIterator::advance):
* platform/graphics/WidthIterator.h: Store several new members needed for SVG Fonts support (last processed glyph name used for kerning pair lookup)
and a map mapping each character of a text to its arabic-form (if needed, to perform SVG glyph selection for Arabic text).
(WebCore::WidthIterator::run):
(WebCore::WidthIterator::runWidthSoFar):
(WebCore::WidthIterator::lastGlyphName):
(WebCore::WidthIterator::setLastGlyphName):
(WebCore::WidthIterator::arabicForms):
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Use new scaleEmToUnits free function from FontMetrics.h.
* platform/graphics/mac/SimpleFontDataMac.mm: Ditto.
* platform/graphics/win/SimpleFontDataCGWin.cpp: Ditto.
* rendering/svg/SVGTextMetrics.cpp:
(WebCore::SVGTextMetrics::SVGTextMetrics):
(WebCore::constructTextRun):
(WebCore::SVGTextMetrics::measureCharacterRange):
* rendering/svg/SVGTextMetrics.h:
* rendering/svg/SVGTextRunRenderingContext.cpp: Remove drawTextUsingSVGFont/floatWidthUsingSVGFont/selectionRectForTextUsingSVGFont/offsetForPositionForTextUsingSVGFont.
(WebCore::firstParentRendererForNonTextNode): Don't assert node() exists, doesn't hold true for generated render objects.
(WebCore::renderObjectFromRun): Renamed from referencingRenderObjectFromRun.
(WebCore::SVGTextRunRenderingContext::floatWidthUsingSVGFont): Remove extra "extraCharsAvailable" parameter, now solves via TextRun::charactersLength().
(WebCore::calculateEmUnitToPixelScaleFactor): Add helper method.
(WebCore::SVGTextRunRenderingContext::drawSVGGlyphs): Main drawing method, this actually creates/renders Paths.
(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter): Part 1/2 of SVG Glyph selection code.
* rendering/svg/SVGTextRunRenderingContext.h:
* svg/SVGAltGlyphElement.cpp:
(WebCore::SVGAltGlyphElement::hasValidGlyphElement):
* svg/SVGAltGlyphElement.h:
* svg/SVGFontData.cpp:
(WebCore::calculateEmUnitToPixelScaleFactor): Add helper method.
(WebCore::SVGFontData::initializeFontData): Changed font size from int to float.
(WebCore::SVGFontData::widthForSVGGlyph): Lookup a SVGGlyph from a Glyph using the glyph table in SVGFontElement and calculate its width.
(WebCore::SVGFontData::applySVGGlyphSelection): Part 2/2 of SVG Glyph selection code.
(WebCore::SVGFontData::fillSVGGlyphPage): Fill GlyphPage using glyphs defined in the SVG Font.
* svg/SVGFontData.h:
* svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::registerLigaturesInGlyphCache): Enable ligature registration for the use within GlyphPage.
(WebCore::SVGFontElement::ensureGlyphCache):
* svg/SVGGlyphMap.h:
(WebCore::SVGGlyphMap::addGlyphByUnicodeString): Remove setting isValid, it's not needed anymore and gone.
* svg/svgtags.in: Surround vkern in ENABLE_SVG_FONTS block.
2011-06-20 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
https://bugs.webkit.org/show_bug.cgi?id=59085
font substitution doesn't work for HTML text using SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=17608
Selection rects are wrong for text with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=25460
With @font-face, SVG fonts only work as primary, non-segmented
https://bugs.webkit.org/show_bug.cgi?id=32227
When using SVG fonts with @font-face word-spacing and text-align: justify are not being honored
https://bugs.webkit.org/show_bug.cgi?id=34236
SVG @font-face breaks text-overflow: ellipsis
https://bugs.webkit.org/show_bug.cgi?id=36840
REGRESSION: SVG Font selection problems
https://bugs.webkit.org/show_bug.cgi?id=41934
Rewrite the SVG Fonts support to fully integrate within the GlyphPage concept and the "simple" code path used to render platform fonts.
That means the special logic for measuring text using SVG Fonts, calculating offset for positions, computing selection rects etc. is all gone now.
There's no difference anymore between using a native font or a SVG Font, in terms of these operations.
Update SVG pixel test baseline.
* platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
* platform/mac/svg/batik/text/textEffect-expected.png:
* platform/mac/svg/batik/text/textEffect-expected.txt:
* platform/mac/svg/batik/text/textEffect3-expected.png:
* platform/mac/svg/batik/text/textEffect3-expected.txt:
* platform/mac/svg/batik/text/xmlSpace-expected.png:
* platform/mac/svg/batik/text/xmlSpace-expected.txt:
* platform/mac/svg/custom/glyph-selection-lang-attribute-expected.png:
* platform/mac/svg/custom/glyph-selection-lang-attribute-expected.txt:
* platform/mac/svg/custom/svg-fonts-fallback-expected.png: Added.
* platform/mac/svg/custom/svg-fonts-fallback-expected.txt: Added.
* platform/mac/svg/custom/svg-fonts-segmented-expected.png: Added.
* platform/mac/svg/custom/svg-fonts-segmented-expected.txt: Added.
* platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.png:
* platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
* platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.png:
* platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
* platform/mac/svg/custom/svg-fonts-word-spacing-expected.png: Added.
* platform/mac/svg/custom/svg-fonts-word-spacing-expected.txt: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
* platform/mac/svg/foreignObject/text-tref-02-b-expected.png:
* platform/mac/svg/foreignObject/text-tref-02-b-expected.txt:
* platform/mac/svg/text/text-altglyph-01-b-expected.png:
* platform/mac/svg/text/text-altglyph-01-b-expected.txt:
* platform/mac/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
* platform/mac/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
* platform/mac/svg/text/text-text-04-t-expected.png:
* platform/mac/svg/text/text-text-04-t-expected.txt:
* platform/mac/svg/text/text-text-05-t-expected.png:
* platform/mac/svg/text/text-text-05-t-expected.txt:
* platform/mac/svg/text/text-text-06-t-expected.png:
* platform/mac/svg/text/text-text-06-t-expected.txt:
* platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.png:
* platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
* platform/mac/svg/wicd/test-rightsizing-b-expected.png:
* platform/mac/svg/wicd/test-rightsizing-b-expected.txt:
* svg/custom/resources/ABCFont.svg:
* svg/custom/svg-fonts-fallback.xhtml: Added.
* svg/custom/svg-fonts-segmented.xhtml: Added.
* svg/custom/svg-fonts-word-spacing.html: Added.
* svg/text/select-text-svgfont-expected.txt: Added.
* svg/text/select-text-svgfont.html: Added.
* svg/text/text-overflow-ellipsis-svgfont.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89233
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Mon, 20 Jun 2011 06:46:31 +0000 (06:46 +0000)]
2011-06-19 MORITA Hajime <morrita@google.com>
Unreviewed GTK build fix.
* Source/autotools/symbols.filter:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89232
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Mon, 20 Jun 2011 06:23:20 +0000 (06:23 +0000)]
2011-06-19 MORITA Hajime <morrita@google.com>
Unreviewed wincairo build fix.
* win/WebKit2CFLite.def:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89231
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Mon, 20 Jun 2011 05:08:10 +0000 (05:08 +0000)]
2011-06-19 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
The internals object should have createShadowContentElement()
https://bugs.webkit.org/show_bug.cgi?id=62432
* Source/autotools/symbols.filter: Added some more symbols necessary for
window.internals to function to the global symbol list.
2011-06-19 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
The internals object should have createShadowContentElement()
https://bugs.webkit.org/show_bug.cgi?id=62432
* fast/dom/shadow/create-content-element-expected.txt: Added.
* fast/dom/shadow/create-content-element.html: Added.
2011-06-19 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
The internals object should have createShadowContentElement()
https://bugs.webkit.org/show_bug.cgi?id=62432
This change:
- added Internals::createShadowContentElement(), which creates,
ShadowContentElement instance which includes all host children,
- added Internals::elementRenderTreeAsText() to help content layout testing, and
- Unabstracted ShadowContentElement by giving a default shouldInclude() implementation.
Test: fast/dom/shadow/create-content-element.html
* WebCore.exp.in:
* dom/ShadowContentElement.cpp:
(WebCore::ShadowContentElement::create): Added.
(WebCore::ShadowContentElement::ShadowContentElement):
(WebCore::ShadowContentElement::~ShadowContentElement):
(WebCore::ShadowContentElement::shouldInclude): Gave a default implementation which always returns true.
* dom/ShadowContentElement.h:
* html/HTMLSummaryElement.cpp:
(WebCore::SummaryContentElement::SummaryContentElement):
* rendering/RenderTreeAsText.cpp:
(WebCore::externalRepresentation): Factored out for supportin per-element render tree dump.
* rendering/RenderTreeAsText.h:
* testing/Internals.cpp:
(WebCore::Internals::createShadowContentElement): Added.
(WebCore::Internals::elementRenderTreeAsText): dded.
* testing/Internals.h:
* testing/Internals.idl:
2011-06-19 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
The internals object should have createShadowContentElement()
https://bugs.webkit.org/show_bug.cgi?id=62432
* win/WebKit2.def: Added some more symbols necessary for
window.internals to function to the global symbol list.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89230
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
keishi@webkit.org [Mon, 20 Jun 2011 04:47:20 +0000 (04:47 +0000)]
2011-06-19 Keishi Hattori <keishi@webkit.org>
Reviewed by Kent Tamura.
Clicking indeterminate checkbox should flip checkedness state
https://bugs.webkit.org/show_bug.cgi?id=62262
* fast/forms/checkbox-click-indeterminate-expected.txt: Added.
* fast/forms/checkbox-click-indeterminate.html: Added. Tests behavior when clicking indeterminate checkbox.
2011-06-19 Keishi Hattori <keishi@webkit.org>
Reviewed by Kent Tamura.
Clicking indeterminate checkbox should flip checkedness state
https://bugs.webkit.org/show_bug.cgi?id=62262
Test: fast/forms/checkbox-click-indeterminate.html
* html/CheckboxInputType.cpp:
(WebCore::CheckboxInputType::willDispatchClick): Changed to flip checked flag when indeterminate.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89229
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Mon, 20 Jun 2011 03:50:36 +0000 (03:50 +0000)]
2011-06-19 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Correct logic for putting errors on the correct line when handling JSONP
https://bugs.webkit.org/show_bug.cgi?id=62962
Add test case this time
* fast/js/parser-syntax-check-expected.txt:
* fast/js/script-tests/parser-syntax-check.js:
2011-06-19 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Correct logic for putting errors on the correct line when handling JSONP
https://bugs.webkit.org/show_bug.cgi?id=62962
Minor fix for the minor fix. *sigh*
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89228
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 20 Jun 2011 03:05:50 +0000 (03:05 +0000)]
2011-06-19 Adam Bergkvist <adam.bergkvist@ericsson.com>
Reviewed by Martin Robinson.
[GTK] Enable Media Stream feature and make it default on
https://bugs.webkit.org/show_bug.cgi?id=60394
* configure.ac:
2011-06-19 Adam Bergkvist <adam.bergkvist@ericsson.com>
Reviewed by Martin Robinson.
[GTK] Enable Media Stream feature and make it default on
https://bugs.webkit.org/show_bug.cgi?id=60394
Unskipped the Media Stream tests.
* platform/gtk/Skipped:
2011-06-19 Adam Bergkvist <adam.bergkvist@ericsson.com>
Reviewed by Martin Robinson.
[GTK] Enable Media Stream feature and make it default on
https://bugs.webkit.org/show_bug.cgi?id=60394
* GNUmakefile.am:
2011-06-19 Adam Bergkvist <adam.bergkvist@ericsson.com>
Reviewed by Martin Robinson.
[GTK] Enable Media Stream feature and make it default on
https://bugs.webkit.org/show_bug.cgi?id=60394
* Scripts/build-webkit:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89227
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Mon, 20 Jun 2011 02:57:36 +0000 (02:57 +0000)]
Minor fix to correct layout test results.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89226
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 20 Jun 2011 02:44:31 +0000 (02:44 +0000)]
2011-06-19 Ryosuke Niwa <rniwa@webkit.org>
Rolled DEPS.
* DEPS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89225
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 20 Jun 2011 02:26:37 +0000 (02:26 +0000)]
Roll out r89223 since it appears to have broken all of the builds.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89224
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 19 Jun 2011 21:07:33 +0000 (21:07 +0000)]
2011-06-19 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
RefPtr misused as argument type in a few classes
https://bugs.webkit.org/show_bug.cgi?id=62955
* dom/DataTransferItem.cpp:
(WebCore::DataTransferItem::DataTransferItem):
* dom/DataTransferItem.h:
* dom/DataTransferItems.cpp:
(WebCore::DataTransferItems::DataTransferItems):
* dom/DataTransferItems.h:
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring):
* editing/CompositeEditCommand.h:
* inspector/InspectorConsoleInstrumentation.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::addProfileImpl):
* inspector/InspectorInstrumentation.h:
* inspector/InspectorProfilerAgent.h:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::inspectorStyleForId):
(WebCore::InspectorStyleSheet::rememberInspectorStyle):
* inspector/InspectorStyleSheet.h:
* page/WebKitAnimationList.cpp:
(WebCore::WebKitAnimationList::append):
(WebCore::WebKitAnimationList::insertAnimation):
* page/WebKitAnimationList.h:
* svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::FEImage):
(WebCore::FEImage::create):
* svg/graphics/filters/SVGFEImage.h:
* svg/graphics/filters/SVGFilterBuilder.cpp:
(WebCore::SVGFilterBuilder::SVGFilterBuilder):
(WebCore::SVGFilterBuilder::add):
(WebCore::SVGFilterBuilder::appendEffectToEffectReferences):
* svg/graphics/filters/SVGFilterBuilder.h:
* websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::didConnectCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
* websockets/ThreadableWebSocketChannelClientWrapper.h:
* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::Peer::Peer):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::setWebSocketChannel):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
* websockets/WorkerThreadableWebSocketChannel.h:
Use PassRefPtr or raw pointer as appropriate for RefPtr arguments.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89223
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Sun, 19 Jun 2011 20:48:55 +0000 (20:48 +0000)]
2011-06-19 Dirk Schulze <krit@webkit.org>
Uneviewed.
SVGAnimatorFactory does not support SVGNumber
https://bugs.webkit.org/show_bug.cgi?id=62938
Add animation tests of previous patch to skip list for webkit2.
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89222
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 19 Jun 2011 20:48:17 +0000 (20:48 +0000)]
2011-06-19 Una Sabovic <una.sabovic@palm.com>
Reviewed by Darin Adler.
Optimization: avoid call to clearRect() when bgColor is valid when painting the root background in RenderBoxModelObject::paintFillLayerExtended
https://bugs.webkit.org/show_bug.cgi?id=62908
When root layers base color is fully transparent backgroundRect was cleared before bgColor is applied.
Instead of clearing the rect we apply CompositeCopy operation when painting the background color.
No new tests. This is an optimization, it doesn't change any existing functionality.
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::fillRect):
* platform/graphics/GraphicsContext.h:
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89221
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Sun, 19 Jun 2011 20:11:24 +0000 (20:11 +0000)]
2011-06-19 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGAnimatorFactory does not support SVGNumber
https://bugs.webkit.org/show_bug.cgi?id=62938
Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGNumber. With the new animator for the
With the new animator for SVGNumber we also support the scientific notation, and everything else that's supported by
the SVGNumber parsing, removing the SVGAnimate* specific number parsing functionality.
Moving the content of SVGAnimatedType header into its own cpp.
Changed behavior of parseNumberFromString(). It checks if the String simply consits of a number now. parseNumberFromString()
is using genericParseNumber() for parsing numbers. But this method just stops at the first char that does not belong to a number and
returns true. I added a check if the current char pointer is at the last char of the String and return false if not.
Tests: svg/animations/svgnumber-animation-1.html
svg/animations/svgnumber-animation-2.html
svg/animations/svgnumber-animation-3.html
* CMakeLists.txt: Added new files to build system.
* GNUmakefile.list.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* svg/SVGAllInOne.cpp: Ditto.
* svg/SVGAnimateElement.cpp: Use SVGAnimatedNumberAnimator for animations of SVGNumbers.
(WebCore::SVGAnimateElement::SVGAnimateElement):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::SVGAnimateElement::calculateFromAndToValues):
(WebCore::SVGAnimateElement::calculateFromAndByValues):
(WebCore::SVGAnimateElement::resetToBaseValue):
(WebCore::SVGAnimateElement::applyResultsToTarget):
(WebCore::SVGAnimateElement::calculateDistance):
* svg/SVGAnimateElement.h: Remove floats for value storage. This is done by SVGAnimatedTypes now.
* svg/SVGAnimatedNumber.cpp: Added. Animator for SVGNumbers.
(WebCore::SVGAnimatedNumberAnimator::SVGAnimatedNumberAnimator):
(WebCore::SVGAnimatedNumberAnimator::constructFromString):
(WebCore::SVGAnimatedNumberAnimator::calculateFromAndToValues):
(WebCore::SVGAnimatedNumberAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedNumberAnimator::calculateAnimatedValue):
(WebCore::SVGAnimatedNumberAnimator::calculateDistance):
* svg/SVGAnimatedNumber.h:
(WebCore::SVGAnimatedNumberAnimator::~SVGAnimatedNumberAnimator):
* svg/SVGAnimatedType.cpp: Added. Moved content from header to cpp.
(WebCore::SVGAnimatedType::SVGAnimatedType):
(WebCore::SVGAnimatedType::~SVGAnimatedType):
(WebCore::SVGAnimatedType::createAngle):
(WebCore::SVGAnimatedType::createLength):
(WebCore::SVGAnimatedType::createNumber):
(WebCore::SVGAnimatedType::angle):
(WebCore::SVGAnimatedType::length):
(WebCore::SVGAnimatedType::number):
(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):
* svg/SVGAnimatedType.h: Removed method create(). Allways call type specific create funtcions.
* svg/SVGAnimatorFactory.h:
(WebCore::SVGAnimatorFactory::create):
* svg/SVGParserUtilities.cpp:
(WebCore::parseNumberFromString): Check if String simply consits of a number. Return false otherwise.
2011-06-19 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGAnimatorFactory does not support SVGNumber
https://bugs.webkit.org/show_bug.cgi?id=62938
Added new tests to check behavior on SVGNumber animation.
* svg/animations/script-tests/svgnumber-animation-1.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgnumber-animation-2.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgnumber-animation-3.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/svgnumber-animation-1-expected.txt: Added.
* svg/animations/svgnumber-animation-1.html: Added.
* svg/animations/svgnumber-animation-2-expected.txt: Added.
* svg/animations/svgnumber-animation-2.html: Added.
* svg/animations/svgnumber-animation-3-expected.txt: Added.
* svg/animations/svgnumber-animation-3.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89220
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sun, 19 Jun 2011 19:47:45 +0000 (19:47 +0000)]
2011-06-17 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
JSONP is unnecessarily slow
https://bugs.webkit.org/show_bug.cgi?id=62920
JSONP has unfortunately become a fairly common idiom online, yet
it triggers very poor performance in JSC as we end up doing codegen
for a large number of property accesses that will
* only be run once, so the vast amount of logic we dump to handle
caching of accesses is unnecessary.
* We are doing codegen that is directly proportional to just
creating the object in the first place.
This patch extends the use of the literal parser to JSONP-like structures
in global code, handling a number of different forms I have seen online.
In an extreme case this improves performance of JSONP by more than 2x
due to removal of code generation and execution time, and a few optimisations
that I made to the parser itself.
* API/JSValueRef.cpp:
(JSValueMakeFromJSONString):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
(JSC::Interpreter::execute):
* parser/Lexer.cpp:
(JSC::Lexer::isKeyword):
* parser/Lexer.h:
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
* runtime/JSONObject.cpp:
(JSC::JSONProtoFuncParse):
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::tryJSONPParse):
(JSC::LiteralParser::makeIdentifier):
(JSC::LiteralParser::Lexer::lex):
(JSC::LiteralParser::Lexer::next):
(JSC::isSafeStringCharacter):
(JSC::LiteralParser::Lexer::lexString):
(JSC::LiteralParser::Lexer::lexNumber):
(JSC::LiteralParser::parse):
* runtime/LiteralParser.h:
(JSC::LiteralParser::LiteralParser):
(JSC::LiteralParser::tryLiteralParse):
(JSC::LiteralParser::Lexer::Lexer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89219
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Sun, 19 Jun 2011 18:32:13 +0000 (18:32 +0000)]
2011-06-19 Stephen White <senorblanco@chromium.org>
Unreviewed.
Marking several tests as crashing on Mac GPU.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89218
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Sun, 19 Jun 2011 18:16:52 +0000 (18:16 +0000)]
2011-06-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89198.
http://trac.webkit.org/changeset/89198
https://bugs.webkit.org/show_bug.cgi?id=62953
Chromium breakage on "Linux Tests" (Requested by senorblanco
on #webkit).
* Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89217
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Sun, 19 Jun 2011 17:00:27 +0000 (17:00 +0000)]
2011-06-18 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Separate concerns of loading file icons and choosing files.
https://bugs.webkit.org/show_bug.cgi?id=62931
Loading an icon and choosing files have similar async nature, but completely different
lifetimes: FileChooser should only exist when we are actually attempting to choose a file,
not anytime we need to render an input with a proper icon.
This patch introduces FileIconLoader, a separate abstraction for loading an icon, and removes
any notion of an icon from the FileChooser.
Also, the loaded icon is now stored on the RenderFileUploadControl, which better matches its
purpose.
Refactoring, covered by existing tests.
* CMakeLists.txt: Added FileIconLoader to build system.
* GNUmakefile.list.am: Ditto.
* WebCore.exp.in: Updated.
* WebCore.gypi: Added FileIconLoader to build system.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* loader/EmptyClients.h: Updated.
(WebCore::EmptyChromeClient::loadIconForFiles): Renamed function to better reflect what it does.
* page/Chrome.cpp:
(WebCore::Chrome::loadIconForFiles): Ditto.
* page/Chrome.h: Ditto.
* page/ChromeClient.h: Ditto.
* platform/FileChooser.cpp:
(WebCore::FileChooser::FileChooser): Removed now-unnecessary bool.
(WebCore::FileChooser::create): Removed the tangled web.
(WebCore::FileChooser::clear): Removed icon-related code.
(WebCore::FileChooser::chooseFiles): Ditto.
* platform/FileChooser.h:
* platform/FileIconLoader.cpp: Copied from Source/WebCore/platform/FileChooser.cpp.
(WebCore::FileIconLoaderClient::~FileIconLoaderClient): Added.
(WebCore::FileIconLoader::create): Added.
(WebCore::FileIconLoader::disconnectClient): Added.
(WebCore::FileIconLoader::notifyFinished): Added.
(WebCore::FileIconLoader::FileIconLoader): Added.
* platform/FileIconLoader.h: Copied from Source/WebCore/platform/FileChooser.cpp.
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::RenderFileUploadControl): Added new member initializations.
(WebCore::RenderFileUploadControl::~RenderFileUploadControl): Added FileIconLoader disconnect.s
(WebCore::RenderFileUploadControl::requestIcon): Added a helper.
(WebCore::RenderFileUploadControl::valueChanged): Changed to request an icon load.
(WebCore::RenderFileUploadControl::updateRendering): Added implementation of FileIconLoaderClient func.
(WebCore::RenderFileUploadControl::updateFromElement): Added clearing of icon.
(WebCore::RenderFileUploadControl::maxFilenameWidth): Changed to use new member directly.
(WebCore::RenderFileUploadControl::paintObject): Ditto.
(WebCore::RenderFileUploadControl::fileTextValue): Ditto.
* rendering/RenderFileUploadControl.h: Updated decls.
2011-06-18 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Separate concerns of loading file icons and choosing files.
https://bugs.webkit.org/show_bug.cgi?id=62931
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::loadIconForFiles): Renamed to better reflect the intent.
* src/ChromeClientImpl.h: Ditto.
* src/WebIconLoadingCompletionImpl.cpp:
(WebKit::WebIconLoadingCompletionImpl::WebIconLoadingCompletionImpl): Changed to use FileIconLoader.
(WebKit::WebIconLoadingCompletionImpl::didLoadIcon): Ditto.
* src/WebIconLoadingCompletionImpl.h: Dito.
2011-06-18 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Separate concerns of loading file icons and choosing files.
https://bugs.webkit.org/show_bug.cgi?id=62931
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::loadIconForFiles): Renamed.
* WebCoreSupport/ChromeClientEfl.h:
2011-06-18 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Separate concerns of loading file icons and choosing files.
https://bugs.webkit.org/show_bug.cgi?id=62931
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::loadIconForFiles): Renamed.
* WebCoreSupport/ChromeClientGtk.h:
2011-06-18 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Separate concerns of loading file icons and choosing files.
https://bugs.webkit.org/show_bug.cgi?id=62931
* WebCoreSupport/ChromeClientHaiku.cpp:
(WebCore::ChromeClientHaiku::loadIconForFiles): Renamed.
* WebCoreSupport/ChromeClientHaiku.h:
2011-06-18 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Separate concerns of loading file icons and choosing files.
https://bugs.webkit.org/show_bug.cgi?id=62931
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::loadIconForFiles): Renamed.
2011-06-18 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Separate concerns of loading file icons and choosing files.
https://bugs.webkit.org/show_bug.cgi?id=62931
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::loadIconForFiles): Renamed.
* WebCoreSupport/ChromeClientQt.h:
2011-06-18 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Separate concerns of loading file icons and choosing files.
https://bugs.webkit.org/show_bug.cgi?id=62931
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::loadIconForFiles): Renamed.
* WebCoreSupport/WebChromeClient.h:
2011-06-18 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Separate concerns of loading file icons and choosing files.
https://bugs.webkit.org/show_bug.cgi?id=62931
* WebCoreSupport/ChromeClientWinCE.cpp:
(WebKit::ChromeClientWinCE::loadIconForFiles): Renamed.
* WebCoreSupport/ChromeClientWinCE.h:
2011-06-18 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Separate concerns of loading file icons and choosing files.
https://bugs.webkit.org/show_bug.cgi?id=62931
* WebKitSupport/ChromeClientWx.cpp:
(WebCore::ChromeClientWx::chooseIconForFiles): Renamed.
* WebKitSupport/ChromeClientWx.h:
2011-06-18 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Separate concerns of loading file icons and choosing files.
https://bugs.webkit.org/show_bug.cgi?id=62931
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::loadIconForFiles): Renamed.
* WebProcess/WebCoreSupport/WebChromeClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89216
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Sun, 19 Jun 2011 13:42:30 +0000 (13:42 +0000)]
2011-06-19 Daniel Bates <dbates@webkit.org>
Fix change log entry; Change "should use password", "Git.push_local_commits_to_server"
to "should use passed" and "Git.push_local_commits_to_server()", respectively,
in the bug title for changeset 89209 <http://trac.webkit.org/changeset/89209>. Now
the bug title makes sense.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89215
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Sun, 19 Jun 2011 12:55:20 +0000 (12:55 +0000)]
2011-06-19 Michael Saboff <msaboff@apple.com>
Reviewed by Darin Adler.
Add notify handler to trigger MemoryPressureHandler in all builds
https://bugs.webkit.org/show_bug.cgi?id=62679
Removed SIGUSR2 trigger and added a notify trigger for the
MemoryPressureHandler. The notify trigger is enabled for all builds.
No test added as only added new memory pressure trigger.
* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::install):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89214
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Sun, 19 Jun 2011 10:53:03 +0000 (10:53 +0000)]
2011-06-19 Robert Hogan <robert@webkit.org>
Reviewed by Alexey Proskuryakov.
[Qt] Qt Counterpart for http://trac.webkit.org/changeset/42078
https://bugs.webkit.org/show_bug.cgi?id=62514
* platform/qt/Skipped: Unskip http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html
2011-06-19 Robert Hogan <robert@webkit.org>
Reviewed by Alexey Proskuryakov.
[Qt] Qt Counterpart for http://trac.webkit.org/changeset/42078
https://bugs.webkit.org/show_bug.cgi?id=62514
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::WebCoreSynchronousLoader::willSendRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89213
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 19 Jun 2011 04:13:49 +0000 (04:13 +0000)]
2011-06-18 Yufeng Shen <miletus@chromium.org>
Reviewed by Darin Fisher.
Adding "force" filed to Touch Event
https://bugs.webkit.org/show_bug.cgi?id=62766
* fast/events/touch/document-create-touch-expected.txt:
* fast/events/touch/script-tests/document-create-touch.js:
2011-06-18 Yufeng Shen <miletus@chromium.org>
Reviewed by Darin Fisher.
Adding "force" filed to Touch Event
https://bugs.webkit.org/show_bug.cgi?id=62766
* dom/Document.cpp:
(WebCore::Document::createTouch):
* dom/Document.h:
* dom/Document.idl:
* dom/Touch.cpp:
(WebCore::Touch::Touch):
* dom/Touch.h:
(WebCore::Touch::create):
(WebCore::Touch::webkitForce):
* dom/Touch.idl:
* page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent):
* platform/PlatformTouchPoint.h:
(WebCore::PlatformTouchPoint::force):
2011-06-18 Yufeng Shen <miletus@chromium.org>
Reviewed by Darin Fisher.
Adding "force" filed to Touch Event
https://bugs.webkit.org/show_bug.cgi?id=62766
* public/WebTouchPoint.h:
(WebKit::WebTouchPoint::WebTouchPoint):
* src/WebInputEventConversion.cpp:
(WebKit::PlatformTouchPointBuilder::PlatformTouchPointBuilder):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89212
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 19 Jun 2011 03:44:03 +0000 (03:44 +0000)]
2011-06-18 Eunmi Lee <eunmi15.lee@samsung.com>
Reviewed by Sam Weinig.
[EFL][WK2] add WebKit2 EFL port's NativeWebMouseEvent, NativeWebWheelEvent and NativeWebKeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=61993
Add native mouse and keyboard event classes to convert EFL's events to NativeWebEvent.
* Shared/NativeWebKeyboardEvent.h:
(WebKit::NativeWebKeyboardEvent::nativeEvent):
* Shared/NativeWebMouseEvent.h:
(WebKit::NativeWebMouseEvent::nativeEvent):
* Shared/NativeWebWheelEvent.h:
(WebKit::NativeWebWheelEvent::nativeEvent):
* Shared/efl/NativeWebKeyboardEventEfl.cpp: Added.
(WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent):
* Shared/efl/NativeWebMouseEventEfl.cpp: Added.
(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
* Shared/efl/NativeWebWheelEventEfl.cpp: Added.
(WebKit::NativeWebWheelEvent::NativeWebWheelEvent):
* Shared/efl/WebEventFactory.cpp: Added.
(WebKit::modifiersForEvent):
(WebKit::buttonForEvent):
(WebKit::clickCountForEvent):
(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebKeyboardEvent):
* Shared/efl/WebEventFactory.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89211
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 19 Jun 2011 03:42:48 +0000 (03:42 +0000)]
2011-06-18 Eunmi Lee <eunmi15.lee@samsung.com>
Reviewed by Sam Weinig.
[EFL][WK2] Add missing functions of EFL port's PageClientImpl
https://bugs.webkit.org/show_bug.cgi?id=62711
Three functions are added in the PageClient.h, so add them to the EFL's PageClientImpl.
* UIProcess/API/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::screenToWindow):
(WebKit::PageClientImpl::enterAcceleratedCompositingMode):
(WebKit::PageClientImpl::exitAcceleratedCompositingMode):
* UIProcess/API/efl/PageClientImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89210
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Sun, 19 Jun 2011 01:55:24 +0000 (01:55 +0000)]
2011-06-18 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
Git.push_local_commits_to_server should use password username and
password when we don't have cached credentials
https://bugs.webkit.org/show_bug.cgi?id=62941
Fixes a issue where Git.push_local_commits_to_server() would always look
for cached credentials regardless of whether a username and password
were passed as arguments. Instead, if given both a username and password
then we shouldn't look for cached credentials (since we were explicitly given
credentials).
* Scripts/webkitpy/common/checkout/scm/git.py:
* Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Added unit tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89209
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Sun, 19 Jun 2011 00:41:21 +0000 (00:41 +0000)]
2011-06-18 Daniel Bates <dbates@rim.com>
Rubber-stamped by Eric Seidel.
Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
https://bugs.webkit.org/show_bug.cgi?id=62767
Part 3 of 3
Remove the command-line option --skip-build now that the master BuildBot has been restarted
following <http://trac.webkit.org/changeset/89138>.
Instead, specify --no-build to get analogous functionality.
* Scripts/run-javascriptcore-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89208
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andrew@webkit.org [Sat, 18 Jun 2011 21:04:42 +0000 (21:04 +0000)]
2011-06-18 Andrew Wellington <andrew@webkit.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=62843
WebKit Mac API calls didReceiveAuthenticationChallenge instead of
didCancelAuthenticationChallenge
* WebView/WebView.mm:
(-[WebView _cacheResourceLoadDelegateImplementations]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89207
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Sat, 18 Jun 2011 20:36:47 +0000 (20:36 +0000)]
2011-06-18 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: fix test sorting
https://bugs.webkit.org/show_bug.cgi?id=58691
This changes the sorting to use a "natural" sort order such that
foo2.html sorts before foo13.html, and sorts the tests so
that all the tests in a directory are run before any test in a
subdirectory.
This change also adds a split() method to the filesystem since
that is needed to cluster files into a directory otherwise.
* Scripts/webkitpy/common/system/filesystem.py:
* Scripts/webkitpy/common/system/filesystem_mock.py:
* Scripts/webkitpy/layout_tests/layout_package/manager.py:
* Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89206
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Sat, 18 Jun 2011 20:34:57 +0000 (20:34 +0000)]
2011-06-18 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Rename Document::setContainsFullScreenElementRecursively
https://bugs.webkit.org/show_bug.cgi?id=62528
No new tests; no net change in functionality, so this is covered by existing tests.
The name of setContainsFullScreenElementRecursively is confusing, since it doesn't actually use
recursion, and it walks the ancestor tree instead of the descendent tree (as recursive might
otherwise imply). Move the function into Element, turn it into a member function, and change
the behavior so that the function operates on the called object's parents (as opposed to the
object itself).
* dom/Element.h:
* dom/Element.cpp:
(WebCore::parentCrossingFrameBoundaries): Added.
(WebCore::Element::setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries): Renamed and
moved from Document.
(WebCore::Element::willRemove): Use the newly renamed function.
(WebCore::Element::insertedIntoTree): Ditto.
* dom/Document.h:
* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement): Ditto.
(WebCore::Document::webkitWillExitFullScreenForElement): Ditto.
(WebCore::Document::fullScreenElementRemoved): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89205
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 18 Jun 2011 20:27:31 +0000 (20:27 +0000)]
2011-06-18 Alice Boxhall <aboxhall@chromium.org>
Reviewed by Chris Fleizach.
Accessibility description for an element should make use of aria-labelledby.
https://bugs.webkit.org/show_bug.cgi?id=61995
* accessibility/aria-labelledby-on-input.html:
* accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added.
* accessibility/aria-labelledby-overrides-aria-label.html: Added.
* accessibility/aria-labelledby-overrides-label-expected.txt:
* accessibility/aria-labelledby-overrides-label.html:
* accessibility/aria-labelledby-stay-within.html:
* platform/mac/accessibility/aria-labelledby-on-input-expected.txt:
2011-06-18 Alice Boxhall <aboxhall@chromium.org>
Reviewed by Chris Fleizach.
Accessibility description for an element should make use of aria-labelledby.
https://bugs.webkit.org/show_bug.cgi?id=61995
Tests: accessibility/aria-labelledby-overrides-aria-label.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::title): Don't return value from aria-labelledby.
(WebCore::AccessibilityRenderObject::ariaAccessibilityDescription): Return value from aria-labelledby in preference to value from aria-label.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89204
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 18 Jun 2011 20:18:04 +0000 (20:18 +0000)]
2011-06-18 Adam Bergkvist <adam.bergkvist@ericsson.com>
Reviewed by Tony Gentilcore.
Media Stream no-interface-object test should not have ReferenceError message in expected results
https://bugs.webkit.org/show_bug.cgi?id=60391
Fixed no-interface-object test to not include ReferenceError message in expected results
* fast/dom/MediaStream/no-interface-object-expected.txt:
* fast/dom/MediaStream/script-tests/no-interface-object.js:
(shouldThrowReferenceError):
(test):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89203
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
evan@chromium.org [Sat, 18 Jun 2011 20:10:14 +0000 (20:10 +0000)]
2011-06-18 Evan Martin <evan@chromium.org>
Reviewed by Darin Adler.
Compiler warning in double->int conversion in TestNetscapePlugIn
https://bugs.webkit.org/show_bug.cgi?id=51554
This code is providing a JS API for removing a property by numeric ID.
We get it from JS as a double, and must convert it to an int before using it.
Test: LayoutTests/plugins/npruntime/remove-property.html
* DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
(NPRuntimeRemoveProperty::TestObject::invoke):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89202
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sat, 18 Jun 2011 20:03:24 +0000 (20:03 +0000)]
2011-06-18 Patrick Gansterer <paroga@webkit.org>
Reviewed by Eric Seidel.
Don't exit webkit-patch when running on Win32 python
https://bugs.webkit.org/show_bug.cgi?id=55811
Most of the basic actions work in the meantime,
so let people play with in on Win32 now.
* Scripts/webkit-patch:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89201
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 18 Jun 2011 19:53:57 +0000 (19:53 +0000)]
2011-06-18 Christoph Mende <mende.christoph@gmail.com>
Reviewed by Darin Adler.
compilation fails with libpng-1.5
https://bugs.webkit.org/show_bug.cgi?id=61738
* platform/image-encoders/skia/PNGImageEncoder.cpp:
(WebCore::writeOutput): Use getter function instead of direct access
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89200
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeremy@chromium.org [Sat, 18 Jun 2011 19:52:34 +0000 (19:52 +0000)]
2011-06-18 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Eric Seidel.
Set text-align:-webkit-match-parent for li elements in the default style sheet.
https://bugs.webkit.org/show_bug.cgi?id=57232
* fast/css/list-item-text-align-expected.txt: Added.
* fast/css/list-item-text-align.html: Added.
2011-06-18 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Eric Seidel.
Set text-align:-webkit-match-parent for li elements in the default style sheet.
https://bugs.webkit.org/show_bug.cgi?id=57232
Test: fast/css/list-item-text-align.html
* css/html.css:
(li): Specify text-align:-webkit-match-parent .
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89199
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 18 Jun 2011 19:45:43 +0000 (19:45 +0000)]
2011-06-18 Alice Boxhall <aboxhall@chromium.org>
Reviewed by Ojan Vafai.
Convert json_results_generator.py to output version 4 JSON.
https://bugs.webkit.org/show_bug.cgi?id=60869
* Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89198
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 18 Jun 2011 19:43:47 +0000 (19:43 +0000)]
2011-06-18 Holger Hans Peter Freyther <holger@moiji-mobile.com>
Reviewed by Brent Fulgham.
[misc] JSC/wtf/text/*.h should not be included via #include ""
https://bugs.webkit.org/show_bug.cgi?id=60836
Adam Barth pointed out that one should not include files from
JavaScriptCore/wtf/text using #include "File.h". This change
is addressing it.
* CMakeListsEfl.txt: Remove JavaScriptCore/wtf/text.
* CMakeListsWinCE.txt: Remove JavaScriptCore/wtf/text.
* platform/graphics/freetype/FontCacheFreeType.cpp: Change CString.h include.
* platform/graphics/pango/FontCachePango.cpp: Change CString.h include.
* platform/graphics/wx/FontPlatformData.h: Change StringImpl.h include.
* platform/network/soup/ResourceHandleSoup.cpp: Change CString.h include.
* platform/network/soup/SocketStreamHandleSoup.cpp: Change CString.h include.
2011-06-18 Holger Hans Peter Freyther <holger@moiji-mobile.com>
Reviewed by Brent Fulgham.
[misc] JSC/wtf/text/*.h should not be included via #include ""
https://bugs.webkit.org/show_bug.cgi?id=60836
Adam Barth pointed out that one should not include files from
JavaScriptCore/wtf/text using #include "File.h". This change
is addressing it.
* WebEdit.cpp: Include file via <wtf/text/File.h>.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89197
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 18 Jun 2011 19:33:28 +0000 (19:33 +0000)]
2011-06-18 Berend-Jan Wever <skylined@chromium.org>
Reviewed by Eric Seidel.
Some names with spaces are incorrectly reported as not containing spaces
while running prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=55572
* Scripts/VCSUtils.pm: Updated CHANGE_LOG_NAME check for spaces to allow
non-alphanumeric characters in names.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89196
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Sat, 18 Jun 2011 19:24:47 +0000 (19:24 +0000)]
2011-06-18 Michael Saboff <msaboff@apple.com>
Reviewed by Eric Seidel.
Enhancement: New Script to Format malloc_history output as tree
https://bugs.webkit.org/show_bug.cgi?id=56378
New script to process malloc_history output to tree format.
* Scripts/malloc-tree: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89195
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 18 Jun 2011 18:50:53 +0000 (18:50 +0000)]
REGRESSION (r63854-63958): placeholder not shown for number inputs
https://bugs.webkit.org/show_bug.cgi?id=61095
Reviewed by Darin Adler.
Refactor HTMLInputElement supportsPlaceholder support to delegate to the
InputType. Make BaseTextInputType and NumberInputType return true, matching
the current HTML5 spec.
* html/BaseTextInputType.cpp:
(WebCore::BaseTextInputType::supportsPlaceholder):
* html/BaseTextInputType.h:
Add override implementation of supportsPlaceholder that returns true.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::supportsPlaceholder):
Delegate to the InputType.
* html/InputType.cpp:
(WebCore::InputType::supportsPlaceholder):
* html/InputType.h:
Add base implementation of supportsPlaceholder that returns false.
* html/NumberInputType.cpp:
(WebCore::NumberInputType::supportsPlaceholder):
* html/NumberInputType.h:
Add override implementation of supportsPlaceholder that returns true.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89194
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Sat, 18 Jun 2011 09:01:32 +0000 (09:01 +0000)]
[Qt][Mac] Skip failing tests.
* platform/qt-mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89193
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 18 Jun 2011 08:47:10 +0000 (08:47 +0000)]
2011-06-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89184.
http://trac.webkit.org/changeset/89184
https://bugs.webkit.org/show_bug.cgi?id=62927
It broke 22 tests on all bot (Requested by Ossy_weekend on
#webkit).
* API/JSValueRef.cpp:
(JSValueMakeFromJSONString):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
(JSC::Interpreter::execute):
* parser/Lexer.cpp:
* parser/Lexer.h:
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
* runtime/JSONObject.cpp:
(JSC::JSONProtoFuncParse):
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::Lexer::lex):
(JSC::isSafeStringCharacter):
(JSC::LiteralParser::Lexer::lexString):
(JSC::LiteralParser::Lexer::lexNumber):
(JSC::LiteralParser::parse):
* runtime/LiteralParser.h:
(JSC::LiteralParser::LiteralParser):
(JSC::LiteralParser::tryLiteralParse):
(JSC::LiteralParser::Lexer::Lexer):
(JSC::LiteralParser::Lexer::next):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89192
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 18 Jun 2011 08:42:50 +0000 (08:42 +0000)]
2011-06-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89154.
http://trac.webkit.org/changeset/89154
https://bugs.webkit.org/show_bug.cgi?id=62926
It broke debug build on Qt (Requested by Ossy_weekend on
#webkit).
* platform/qt/Skipped:
2011-06-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89154.
http://trac.webkit.org/changeset/89154
https://bugs.webkit.org/show_bug.cgi?id=62926
It broke debug build on Qt (Requested by Ossy_weekend on
#webkit).
* platform/network/qt/ResourceHandleQt.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89191
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 18 Jun 2011 08:25:42 +0000 (08:25 +0000)]
2011-06-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89189.
http://trac.webkit.org/changeset/89189
https://bugs.webkit.org/show_bug.cgi?id=62925
It broke Qt build (Requested by Ossy_weekend on #webkit).
* bindings/scripts/test/TestInterface.idl:
* bindings/scripts/test/TestSerializedScriptValueInterface.idl:
* css/CSSCharsetRule.idl:
* css/CSSFontFaceRule.idl:
* css/CSSImportRule.idl:
* css/CSSPageRule.idl:
* css/CSSRule.idl:
* css/CSSStyleRule.idl:
* css/CSSUnknownRule.idl:
* css/CSSValue.idl:
* css/Counter.idl:
* css/RGBColor.idl:
* css/Rect.idl:
* css/StyleSheet.idl:
* css/WebKitCSSKeyframeRule.idl:
* css/WebKitCSSTransformValue.idl:
* dom/Attr.idl:
* dom/CDATASection.idl:
* dom/ClientRect.idl:
* dom/Comment.idl:
* dom/DOMCoreException.idl:
* dom/DOMStringMap.idl:
* dom/DocumentType.idl:
* dom/Entity.idl:
* dom/EntityReference.idl:
* dom/EventException.idl:
* dom/GeneratedStream.idl:
* dom/MessageChannel.idl:
* dom/NodeIterator.idl:
* dom/Notation.idl:
* dom/ProcessingInstruction.idl:
* dom/RangeException.idl:
* dom/Touch.idl:
* dom/TreeWalker.idl:
* fileapi/DOMFileSystem.idl:
* fileapi/DOMFileSystemSync.idl:
* fileapi/DirectoryReaderSync.idl:
* fileapi/File.idl:
* fileapi/FileEntrySync.idl:
* fileapi/FileError.idl:
* fileapi/FileException.idl:
* fileapi/Metadata.idl:
* fileapi/OperationNotAllowedException.idl:
* fileapi/WebKitFlags.idl:
* html/DOMSettableTokenList.idl:
* html/HTMLAppletElement.idl:
* html/HTMLAreaElement.idl:
* html/HTMLBRElement.idl:
* html/HTMLBaseElement.idl:
* html/HTMLBaseFontElement.idl:
* html/HTMLBlockquoteElement.idl:
* html/HTMLBodyElement.idl:
* html/HTMLDListElement.idl:
* html/HTMLDataListElement.idl:
* html/HTMLDetailsElement.idl:
* html/HTMLDirectoryElement.idl:
* html/HTMLEmbedElement.idl:
* html/HTMLFontElement.idl:
* html/HTMLFormElement.idl:
* html/HTMLFrameElement.idl:
* html/HTMLFrameSetElement.idl:
* html/HTMLHRElement.idl:
* html/HTMLHeadElement.idl:
* html/HTMLHeadingElement.idl:
* html/HTMLHtmlElement.idl:
* html/HTMLIFrameElement.idl:
* html/HTMLImageElement.idl:
* html/HTMLIsIndexElement.idl:
* html/HTMLLIElement.idl:
* html/HTMLLabelElement.idl:
* html/HTMLLegendElement.idl:
* html/HTMLLinkElement.idl:
* html/HTMLMapElement.idl:
* html/HTMLMarqueeElement.idl:
* html/HTMLMenuElement.idl:
* html/HTMLMetaElement.idl:
* html/HTMLMeterElement.idl:
* html/HTMLModElement.idl:
* html/HTMLOListElement.idl:
* html/HTMLOptGroupElement.idl:
* html/HTMLOptionElement.idl:
* html/HTMLParagraphElement.idl:
* html/HTMLParamElement.idl:
* html/HTMLPreElement.idl:
* html/HTMLProgressElement.idl:
* html/HTMLQuoteElement.idl:
* html/HTMLScriptElement.idl:
* html/HTMLSourceElement.idl:
* html/HTMLStyleElement.idl:
* html/HTMLTableCaptionElement.idl:
* html/HTMLTableCellElement.idl:
* html/HTMLTableColElement.idl:
* html/HTMLTitleElement.idl:
* html/HTMLTrackElement.idl:
* html/HTMLUListElement.idl:
* html/ImageData.idl:
* html/MediaError.idl:
* html/SpellcheckRange.idl:
* html/TextMetrics.idl:
* html/ValidityState.idl:
* html/VoidCallback.idl:
* html/canvas/ArrayBuffer.idl:
* html/canvas/ArrayBufferView.idl:
* html/canvas/CanvasPattern.idl:
* html/canvas/CanvasPixelArray.idl:
* html/canvas/CanvasRenderingContext.idl:
* html/canvas/DataView.idl:
* html/canvas/OESStandardDerivatives.idl:
* html/canvas/OESTextureFloat.idl:
* html/canvas/WebGLActiveInfo.idl:
* html/canvas/WebGLBuffer.idl:
* html/canvas/WebGLContextAttributes.idl:
* html/canvas/WebGLFramebuffer.idl:
* html/canvas/WebGLProgram.idl:
* html/canvas/WebGLRenderbuffer.idl:
* html/canvas/WebGLShader.idl:
* html/canvas/WebGLTexture.idl:
* html/canvas/WebGLUniformLocation.idl:
* html/canvas/WebGLVertexArrayObjectOES.idl:
* html/canvas/WebKitLoseContext.idl:
* inspector/ScriptProfile.idl:
* inspector/ScriptProfileNode.idl:
* page/AbstractView.idl:
* page/BarInfo.idl:
* page/Coordinates.idl:
* page/Geoposition.idl:
* page/MemoryInfo.idl:
* page/NavigatorUserMediaError.idl:
* page/Performance.idl:
* page/PerformanceNavigation.idl:
* page/PerformanceTiming.idl:
* page/PositionError.idl:
* page/Screen.idl:
* page/SpeechInputEvent.idl:
* page/SpeechInputResult.idl:
* page/WebKitAnimation.idl:
* page/WebKitPoint.idl:
* page/WorkerNavigator.idl:
* plugins/DOMMimeType.idl:
* storage/Database.idl:
* storage/DatabaseSync.idl:
* storage/IDBAny.idl:
* storage/IDBCursorWithValue.idl:
* storage/IDBDatabaseError.idl:
* storage/IDBDatabaseException.idl:
* storage/IDBKey.idl:
* storage/IDBVersionChangeEvent.idl:
* storage/IDBVersionChangeRequest.idl:
* storage/SQLError.idl:
* storage/SQLException.idl:
* storage/SQLResultSet.idl:
* svg/SVGAElement.idl:
* svg/SVGAltGlyphElement.idl:
* svg/SVGAngle.idl:
* svg/SVGAnimateColorElement.idl:
* svg/SVGAnimateElement.idl:
* svg/SVGAnimateMotionElement.idl:
* svg/SVGAnimateTransformElement.idl:
* svg/SVGAnimatedAngle.idl:
* svg/SVGAnimatedBoolean.idl:
* svg/SVGAnimatedEnumeration.idl:
* svg/SVGAnimatedInteger.idl:
* svg/SVGAnimatedLength.idl:
* svg/SVGAnimatedLengthList.idl:
* svg/SVGAnimatedNumber.idl:
* svg/SVGAnimatedNumberList.idl:
* svg/SVGAnimatedPreserveAspectRatio.idl:
* svg/SVGAnimatedRect.idl:
* svg/SVGAnimatedString.idl:
* svg/SVGAnimatedTransformList.idl:
* svg/SVGCircleElement.idl:
* svg/SVGClipPathElement.idl:
* svg/SVGColor.idl:
* svg/SVGComponentTransferFunctionElement.idl:
* svg/SVGCursorElement.idl:
* svg/SVGDefsElement.idl:
* svg/SVGDescElement.idl:
* svg/SVGElement.idl:
* svg/SVGEllipseElement.idl:
* svg/SVGExternalResourcesRequired.idl:
* svg/SVGFEBlendElement.idl:
* svg/SVGFEColorMatrixElement.idl:
* svg/SVGFEComponentTransferElement.idl:
* svg/SVGFECompositeElement.idl:
* svg/SVGFEConvolveMatrixElement.idl:
* svg/SVGFEDiffuseLightingElement.idl:
* svg/SVGFEDisplacementMapElement.idl:
* svg/SVGFEDistantLightElement.idl:
* svg/SVGFEFloodElement.idl:
* svg/SVGFEFuncAElement.idl:
* svg/SVGFEFuncBElement.idl:
* svg/SVGFEFuncGElement.idl:
* svg/SVGFEFuncRElement.idl:
* svg/SVGFEImageElement.idl:
* svg/SVGFEMergeElement.idl:
* svg/SVGFEMergeNodeElement.idl:
* svg/SVGFEOffsetElement.idl:
* svg/SVGFEPointLightElement.idl:
* svg/SVGFESpecularLightingElement.idl:
* svg/SVGFESpotLightElement.idl:
* svg/SVGFETileElement.idl:
* svg/SVGFETurbulenceElement.idl:
* svg/SVGFilterPrimitiveStandardAttributes.idl:
* svg/SVGFitToViewBox.idl:
* svg/SVGFontElement.idl:
* svg/SVGFontFaceElement.idl:
* svg/SVGFontFaceFormatElement.idl:
* svg/SVGFontFaceNameElement.idl:
* svg/SVGFontFaceSrcElement.idl:
* svg/SVGFontFaceUriElement.idl:
* svg/SVGForeignObjectElement.idl:
* svg/SVGGElement.idl:
* svg/SVGGlyphElement.idl:
* svg/SVGGradientElement.idl:
* svg/SVGHKernElement.idl:
* svg/SVGImageElement.idl:
* svg/SVGLangSpace.idl:
* svg/SVGLength.idl:
* svg/SVGLengthList.idl:
* svg/SVGLineElement.idl:
* svg/SVGLinearGradientElement.idl:
* svg/SVGMPathElement.idl:
* svg/SVGMaskElement.idl:
* svg/SVGMatrix.idl:
* svg/SVGMetadataElement.idl:
* svg/SVGMissingGlyphElement.idl:
* svg/SVGNumber.idl:
* svg/SVGNumberList.idl:
* svg/SVGPaint.idl:
* svg/SVGPathSeg.idl:
* svg/SVGPathSegArcAbs.idl:
* svg/SVGPathSegArcRel.idl:
* svg/SVGPathSegClosePath.idl:
* svg/SVGPathSegCurvetoCubicAbs.idl:
* svg/SVGPathSegCurvetoCubicRel.idl:
* svg/SVGPathSegCurvetoCubicSmoothAbs.idl:
* svg/SVGPathSegCurvetoCubicSmoothRel.idl:
* svg/SVGPathSegCurvetoQuadraticAbs.idl:
* svg/SVGPathSegCurvetoQuadraticRel.idl:
* svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl:
* svg/SVGPathSegCurvetoQuadraticSmoothRel.idl:
* svg/SVGPathSegLinetoAbs.idl:
* svg/SVGPathSegLinetoHorizontalAbs.idl:
* svg/SVGPathSegLinetoHorizontalRel.idl:
* svg/SVGPathSegLinetoRel.idl:
* svg/SVGPathSegLinetoVerticalAbs.idl:
* svg/SVGPathSegLinetoVerticalRel.idl:
* svg/SVGPathSegList.idl:
* svg/SVGPathSegMovetoAbs.idl:
* svg/SVGPathSegMovetoRel.idl:
* svg/SVGPatternElement.idl:
* svg/SVGPoint.idl:
* svg/SVGPointList.idl:
* svg/SVGPolygonElement.idl:
* svg/SVGPolylineElement.idl:
* svg/SVGPreserveAspectRatio.idl:
* svg/SVGRadialGradientElement.idl:
* svg/SVGRect.idl:
* svg/SVGRectElement.idl:
* svg/SVGRenderingIntent.idl:
* svg/SVGScriptElement.idl:
* svg/SVGSetElement.idl:
* svg/SVGStopElement.idl:
* svg/SVGStringList.idl:
* svg/SVGSwitchElement.idl:
* svg/SVGSymbolElement.idl:
* svg/SVGTRefElement.idl:
* svg/SVGTSpanElement.idl:
* svg/SVGTextElement.idl:
* svg/SVGTextPathElement.idl:
* svg/SVGTextPositioningElement.idl:
* svg/SVGTitleElement.idl:
* svg/SVGTransform.idl:
* svg/SVGTransformList.idl:
* svg/SVGTransformable.idl:
* svg/SVGURIReference.idl:
* svg/SVGUnitTypes.idl:
* svg/SVGUseElement.idl:
* svg/SVGVKernElement.idl:
* svg/SVGViewElement.idl:
* svg/SVGViewSpec.idl:
* svg/SVGZoomAndPan.idl:
* svg/SVGZoomEvent.idl:
* testing/Internals.idl:
* webaudio/AudioChannelMerger.idl:
* webaudio/AudioChannelSplitter.idl:
* webaudio/AudioDestinationNode.idl:
* webaudio/AudioGain.idl:
* webaudio/AudioGainNode.idl:
* webaudio/AudioProcessingEvent.idl:
* webaudio/AudioSourceNode.idl:
* webaudio/BiquadFilterNode.idl:
* webaudio/ConvolverNode.idl:
* webaudio/DelayNode.idl:
* webaudio/DynamicsCompressorNode.idl:
* webaudio/HighPass2FilterNode.idl:
* webaudio/JavaScriptAudioNode.idl:
* webaudio/LowPass2FilterNode.idl:
* webaudio/OfflineAudioCompletionEvent.idl:
* workers/SharedWorker.idl:
* workers/SharedWorkerContext.idl:
* workers/WorkerLocation.idl:
* xml/XMLHttpRequestException.idl:
* xml/XMLHttpRequestProgressEvent.idl:
* xml/XPathException.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89190
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 18 Jun 2011 06:30:50 +0000 (06:30 +0000)]
2011-06-17 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Darin Adler.
Remove LegacyDefaultOptionalArguments flag from IDL files where it would not change behavior
https://bugs.webkit.org/show_bug.cgi?id=62904
After bug 62750, there are many IDL files that contain the new
LegacyDefaultOptionalArguments flag that don't actually need it.
Some examples:
- the IDL file contains no functions
- the IDL file contains only functions with no arguments
- the IDL file contains functions, *all* of which use the
[RequiresAllArguments=raise] extended attribute
This patch simplifies such IDL files by removing the
LegacyDefaultOptionalArguments flag and (if needed) removing the
[RequiresAllArguments=raise] extended attribute from each function
declaration. This patch does not make any required arguments optional
or any optional arguments required. It changes no behavior at all.
No new tests needed, all existing tests pass.
* bindings/scripts/test/TestInterface.idl:
* bindings/scripts/test/TestSerializedScriptValueInterface.idl:
* css/CSSCharsetRule.idl:
* css/CSSFontFaceRule.idl:
* css/CSSImportRule.idl:
* css/CSSPageRule.idl:
* css/CSSRule.idl:
* css/CSSStyleRule.idl:
* css/CSSUnknownRule.idl:
* css/CSSValue.idl:
* css/Counter.idl:
* css/RGBColor.idl:
* css/Rect.idl:
* css/StyleSheet.idl:
* css/WebKitCSSKeyframeRule.idl:
* css/WebKitCSSTransformValue.idl:
* dom/Attr.idl:
* dom/CDATASection.idl:
* dom/ClientRect.idl:
* dom/Comment.idl:
* dom/DOMCoreException.idl:
* dom/DOMStringMap.idl:
* dom/DocumentType.idl:
* dom/Entity.idl:
* dom/EntityReference.idl:
* dom/EventException.idl:
* dom/GeneratedStream.idl:
* dom/MessageChannel.idl:
* dom/NodeIterator.idl:
* dom/Notation.idl:
* dom/ProcessingInstruction.idl:
* dom/RangeException.idl:
* dom/Touch.idl:
* dom/TreeWalker.idl:
* fileapi/DOMFileSystem.idl:
* fileapi/DOMFileSystemSync.idl:
* fileapi/DirectoryReaderSync.idl:
* fileapi/File.idl:
* fileapi/FileEntrySync.idl:
* fileapi/FileError.idl:
* fileapi/FileException.idl:
* fileapi/Metadata.idl:
* fileapi/OperationNotAllowedException.idl:
* fileapi/WebKitFlags.idl:
* html/DOMSettableTokenList.idl:
* html/HTMLAppletElement.idl:
* html/HTMLAreaElement.idl:
* html/HTMLBRElement.idl:
* html/HTMLBaseElement.idl:
* html/HTMLBaseFontElement.idl:
* html/HTMLBlockquoteElement.idl:
* html/HTMLBodyElement.idl:
* html/HTMLDListElement.idl:
* html/HTMLDataListElement.idl:
* html/HTMLDetailsElement.idl:
* html/HTMLDirectoryElement.idl:
* html/HTMLEmbedElement.idl:
* html/HTMLFontElement.idl:
* html/HTMLFormElement.idl:
* html/HTMLFrameElement.idl:
* html/HTMLFrameSetElement.idl:
* html/HTMLHRElement.idl:
* html/HTMLHeadElement.idl:
* html/HTMLHeadingElement.idl:
* html/HTMLHtmlElement.idl:
* html/HTMLIFrameElement.idl:
* html/HTMLImageElement.idl:
* html/HTMLIsIndexElement.idl:
* html/HTMLLIElement.idl:
* html/HTMLLabelElement.idl:
* html/HTMLLegendElement.idl:
* html/HTMLLinkElement.idl:
* html/HTMLMapElement.idl:
* html/HTMLMarqueeElement.idl:
* html/HTMLMenuElement.idl:
* html/HTMLMetaElement.idl:
* html/HTMLMeterElement.idl:
* html/HTMLModElement.idl:
* html/HTMLOListElement.idl:
* html/HTMLOptGroupElement.idl:
* html/HTMLOptionElement.idl:
* html/HTMLParagraphElement.idl:
* html/HTMLParamElement.idl:
* html/HTMLPreElement.idl:
* html/HTMLProgressElement.idl:
* html/HTMLQuoteElement.idl:
* html/HTMLScriptElement.idl:
* html/HTMLSourceElement.idl:
* html/HTMLStyleElement.idl:
* html/HTMLTableCaptionElement.idl:
* html/HTMLTableCellElement.idl:
* html/HTMLTableColElement.idl:
* html/HTMLTitleElement.idl:
* html/HTMLTrackElement.idl:
* html/HTMLUListElement.idl:
* html/ImageData.idl:
* html/MediaError.idl:
* html/SpellcheckRange.idl:
* html/TextMetrics.idl:
* html/ValidityState.idl:
* html/VoidCallback.idl:
* html/canvas/ArrayBuffer.idl:
* html/canvas/ArrayBufferView.idl:
* html/canvas/CanvasPattern.idl:
* html/canvas/CanvasPixelArray.idl:
* html/canvas/CanvasRenderingContext.idl:
* html/canvas/DataView.idl:
* html/canvas/OESStandardDerivatives.idl:
* html/canvas/OESTextureFloat.idl:
* html/canvas/WebGLActiveInfo.idl:
* html/canvas/WebGLBuffer.idl:
* html/canvas/WebGLContextAttributes.idl:
* html/canvas/WebGLFramebuffer.idl:
* html/canvas/WebGLProgram.idl:
* html/canvas/WebGLRenderbuffer.idl:
* html/canvas/WebGLShader.idl:
* html/canvas/WebGLTexture.idl:
* html/canvas/WebGLUniformLocation.idl:
* html/canvas/WebGLVertexArrayObjectOES.idl:
* html/canvas/WebKitLoseContext.idl:
* inspector/ScriptProfile.idl:
* inspector/ScriptProfileNode.idl:
* page/AbstractView.idl:
* page/BarInfo.idl:
* page/Coordinates.idl:
* page/Geoposition.idl:
* page/MemoryInfo.idl:
* page/NavigatorUserMediaError.idl:
* page/Performance.idl:
* page/PerformanceNavigation.idl:
* page/PerformanceTiming.idl:
* page/PositionError.idl:
* page/Screen.idl:
* page/SpeechInputEvent.idl:
* page/SpeechInputResult.idl:
* page/WebKitAnimation.idl:
* page/WebKitPoint.idl:
* page/WorkerNavigator.idl:
* plugins/DOMMimeType.idl:
* storage/Database.idl:
* storage/DatabaseSync.idl:
* storage/IDBAny.idl:
* storage/IDBCursorWithValue.idl:
* storage/IDBDatabaseError.idl:
* storage/IDBDatabaseException.idl:
* storage/IDBKey.idl:
* storage/IDBVersionChangeEvent.idl:
* storage/IDBVersionChangeRequest.idl:
* storage/SQLError.idl:
* storage/SQLException.idl:
* storage/SQLResultSet.idl:
* svg/SVGAElement.idl:
* svg/SVGAltGlyphElement.idl:
* svg/SVGAngle.idl:
* svg/SVGAnimateColorElement.idl:
* svg/SVGAnimateElement.idl:
* svg/SVGAnimateMotionElement.idl:
* svg/SVGAnimateTransformElement.idl:
* svg/SVGAnimatedAngle.idl:
* svg/SVGAnimatedBoolean.idl:
* svg/SVGAnimatedEnumeration.idl:
* svg/SVGAnimatedInteger.idl:
* svg/SVGAnimatedLength.idl:
* svg/SVGAnimatedLengthList.idl:
* svg/SVGAnimatedNumber.idl:
* svg/SVGAnimatedNumberList.idl:
* svg/SVGAnimatedPreserveAspectRatio.idl:
* svg/SVGAnimatedRect.idl:
* svg/SVGAnimatedString.idl:
* svg/SVGAnimatedTransformList.idl:
* svg/SVGCircleElement.idl:
* svg/SVGClipPathElement.idl:
* svg/SVGColor.idl:
* svg/SVGComponentTransferFunctionElement.idl:
* svg/SVGCursorElement.idl:
* svg/SVGDefsElement.idl:
* svg/SVGDescElement.idl:
* svg/SVGElement.idl:
* svg/SVGEllipseElement.idl:
* svg/SVGExternalResourcesRequired.idl:
* svg/SVGFEBlendElement.idl:
* svg/SVGFEColorMatrixElement.idl:
* svg/SVGFEComponentTransferElement.idl:
* svg/SVGFECompositeElement.idl:
* svg/SVGFEConvolveMatrixElement.idl:
* svg/SVGFEDiffuseLightingElement.idl:
* svg/SVGFEDisplacementMapElement.idl:
* svg/SVGFEDistantLightElement.idl:
* svg/SVGFEFloodElement.idl:
* svg/SVGFEFuncAElement.idl:
* svg/SVGFEFuncBElement.idl:
* svg/SVGFEFuncGElement.idl:
* svg/SVGFEFuncRElement.idl:
* svg/SVGFEImageElement.idl:
* svg/SVGFEMergeElement.idl:
* svg/SVGFEMergeNodeElement.idl:
* svg/SVGFEOffsetElement.idl:
* svg/SVGFEPointLightElement.idl:
* svg/SVGFESpecularLightingElement.idl:
* svg/SVGFESpotLightElement.idl:
* svg/SVGFETileElement.idl:
* svg/SVGFETurbulenceElement.idl:
* svg/SVGFilterPrimitiveStandardAttributes.idl:
* svg/SVGFitToViewBox.idl:
* svg/SVGFontElement.idl:
* svg/SVGFontFaceElement.idl:
* svg/SVGFontFaceFormatElement.idl:
* svg/SVGFontFaceNameElement.idl:
* svg/SVGFontFaceSrcElement.idl:
* svg/SVGFontFaceUriElement.idl:
* svg/SVGForeignObjectElement.idl:
* svg/SVGGElement.idl:
* svg/SVGGlyphElement.idl:
* svg/SVGGradientElement.idl:
* svg/SVGHKernElement.idl:
* svg/SVGImageElement.idl:
* svg/SVGLangSpace.idl:
* svg/SVGLength.idl:
* svg/SVGLengthList.idl:
* svg/SVGLineElement.idl:
* svg/SVGLinearGradientElement.idl:
* svg/SVGMPathElement.idl:
* svg/SVGMaskElement.idl:
* svg/SVGMatrix.idl:
* svg/SVGMetadataElement.idl:
* svg/SVGMissingGlyphElement.idl:
* svg/SVGNumber.idl:
* svg/SVGNumberList.idl:
* svg/SVGPaint.idl:
* svg/SVGPathSeg.idl:
* svg/SVGPathSegArcAbs.idl:
* svg/SVGPathSegArcRel.idl:
* svg/SVGPathSegClosePath.idl:
* svg/SVGPathSegCurvetoCubicAbs.idl:
* svg/SVGPathSegCurvetoCubicRel.idl:
* svg/SVGPathSegCurvetoCubicSmoothAbs.idl:
* svg/SVGPathSegCurvetoCubicSmoothRel.idl:
* svg/SVGPathSegCurvetoQuadraticAbs.idl:
* svg/SVGPathSegCurvetoQuadraticRel.idl:
* svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl:
* svg/SVGPathSegCurvetoQuadraticSmoothRel.idl:
* svg/SVGPathSegLinetoAbs.idl:
* svg/SVGPathSegLinetoHorizontalAbs.idl:
* svg/SVGPathSegLinetoHorizontalRel.idl:
* svg/SVGPathSegLinetoRel.idl:
* svg/SVGPathSegLinetoVerticalAbs.idl:
* svg/SVGPathSegLinetoVerticalRel.idl:
* svg/SVGPathSegList.idl:
* svg/SVGPathSegMovetoAbs.idl:
* svg/SVGPathSegMovetoRel.idl:
* svg/SVGPatternElement.idl:
* svg/SVGPoint.idl:
* svg/SVGPointList.idl:
* svg/SVGPolygonElement.idl:
* svg/SVGPolylineElement.idl:
* svg/SVGPreserveAspectRatio.idl:
* svg/SVGRadialGradientElement.idl:
* svg/SVGRect.idl:
* svg/SVGRectElement.idl:
* svg/SVGRenderingIntent.idl:
* svg/SVGScriptElement.idl:
* svg/SVGSetElement.idl:
* svg/SVGStopElement.idl:
* svg/SVGStringList.idl:
* svg/SVGSwitchElement.idl:
* svg/SVGSymbolElement.idl:
* svg/SVGTRefElement.idl:
* svg/SVGTSpanElement.idl:
* svg/SVGTextElement.idl:
* svg/SVGTextPathElement.idl:
* svg/SVGTextPositioningElement.idl:
* svg/SVGTitleElement.idl:
* svg/SVGTransform.idl:
* svg/SVGTransformList.idl:
* svg/SVGTransformable.idl:
* svg/SVGURIReference.idl:
* svg/SVGUnitTypes.idl:
* svg/SVGUseElement.idl:
* svg/SVGVKernElement.idl:
* svg/SVGViewElement.idl:
* svg/SVGViewSpec.idl:
* svg/SVGZoomAndPan.idl:
* svg/SVGZoomEvent.idl:
* testing/Internals.idl:
* webaudio/AudioChannelMerger.idl:
* webaudio/AudioChannelSplitter.idl:
* webaudio/AudioDestinationNode.idl:
* webaudio/AudioGain.idl:
* webaudio/AudioGainNode.idl:
* webaudio/AudioProcessingEvent.idl:
* webaudio/AudioSourceNode.idl:
* webaudio/BiquadFilterNode.idl:
* webaudio/ConvolverNode.idl:
* webaudio/DelayNode.idl:
* webaudio/DynamicsCompressorNode.idl:
* webaudio/HighPass2FilterNode.idl:
* webaudio/JavaScriptAudioNode.idl:
* webaudio/LowPass2FilterNode.idl:
* webaudio/OfflineAudioCompletionEvent.idl:
* workers/SharedWorker.idl:
* workers/SharedWorkerContext.idl:
* workers/WorkerLocation.idl:
* xml/XMLHttpRequestException.idl:
* xml/XMLHttpRequestProgressEvent.idl:
* xml/XPathException.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89189
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Sat, 18 Jun 2011 06:12:39 +0000 (06:12 +0000)]
Build fix - fix chromium shared win builder
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89188
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Sat, 18 Jun 2011 05:30:53 +0000 (05:30 +0000)]
2011-06-17 Dirk Schulze <krit@webkit.org>
Reviewed by Rob Buis.
SVGAnimation should use direct unit animation for SVGAngle
https://bugs.webkit.org/show_bug.cgi?id=62807
Tests animation of SVGAngle with different units.
* svg/animations/script-tests/svgangle-animation-deg-to-grad.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgangle-animation-deg-to-rad.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgangle-animation-grad-to-deg.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgangle-animation-grad-to-rad.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgangle-animation-rad-to-deg.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgangle-animation-rad-to-grad.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/svgangle-animation-deg-to-grad-expected.txt: Added.
* svg/animations/svgangle-animation-deg-to-grad.html: Added.
* svg/animations/svgangle-animation-deg-to-rad-expected.txt: Added.
* svg/animations/svgangle-animation-deg-to-rad.html: Added.
* svg/animations/svgangle-animation-grad-to-deg-expected.txt: Added.
* svg/animations/svgangle-animation-grad-to-deg.html: Added.
* svg/animations/svgangle-animation-grad-to-rad-expected.txt: Added.
* svg/animations/svgangle-animation-grad-to-rad.html: Added.
* svg/animations/svgangle-animation-rad-to-deg-expected.txt: Added.
* svg/animations/svgangle-animation-rad-to-deg.html: Added.
* svg/animations/svgangle-animation-rad-to-grad-expected.txt: Added.
* svg/animations/svgangle-animation-rad-to-grad.html: Added.
2011-06-17 Dirk Schulze <krit@webkit.org>
Reviewed by Rob Buis.
SVGAnimation should use direct unit animation for SVGAngle
https://bugs.webkit.org/show_bug.cgi?id=62807
Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGAngle. We can animate the SVG primitive datatype SVGAngle
with different unit types now.
Removed number and unit parser from SVGAnimateElement. This is not needed anymore.
Tests: svg/animations/svgangle-animation-deg-to-grad.html
svg/animations/svgangle-animation-deg-to-rad.html
svg/animations/svgangle-animation-grad-to-deg.html
svg/animations/svgangle-animation-grad-to-rad.html
svg/animations/svgangle-animation-rad-to-deg.html
svg/animations/svgangle-animation-rad-to-grad.html
* CMakeLists.txt: Added SVGAnimatedAngle.cpp.
* GNUmakefile.list.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* svg/SVGAllInOne.cpp: Ditto.
* svg/SVGAnimateElement.cpp: Make use of SVGAnimator for AnimatedAngle.
(WebCore::SVGAnimateElement::SVGAnimateElement):
(WebCore::SVGAnimateElement::determineAnimatedAttributeType): Ditto.
(WebCore::SVGAnimateElement::calculateAnimatedValue): Ditto.
(WebCore::SVGAnimateElement::calculateFromAndToValues): Ditto.
(WebCore::SVGAnimateElement::calculateFromAndByValues): Ditto.
(WebCore::SVGAnimateElement::resetToBaseValue): Ditto.
(WebCore::SVGAnimateElement::applyResultsToTarget): Ditto.
(WebCore::SVGAnimateElement::calculateDistance): Ditto.
* svg/SVGAnimateElement.h:
* svg/SVGAnimatedAngle.cpp: Added. Added SVGAnimatedAngleAnimator for animation of SVGAngles.
(WebCore::SVGAnimatedAngleAnimator::SVGAnimatedAngleAnimator):
(WebCore::sharedSVGAngle):
(WebCore::SVGAnimatedAngleAnimator::constructFromString):
(WebCore::SVGAnimatedAngleAnimator::calculateFromAndToValues):
(WebCore::SVGAnimatedAngleAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedAngleAnimator::calculateAnimatedValue):
(WebCore::SVGAnimatedAngleAnimator::calculateDistance):
* svg/SVGAnimatedAngle.h:
(WebCore::SVGAnimatedAngleAnimator::~SVGAnimatedAngleAnimator):
* svg/SVGAnimatedLength.cpp:
(WebCore::sharedSVGLength): Use an ExceptionCode for SVGLength::setValueAsString.
* svg/SVGAnimatedType.h:
(WebCore::SVGAnimatedType::create):
(WebCore::SVGAnimatedType::createAngle):
(WebCore::SVGAnimatedType::createLength):
(WebCore::SVGAnimatedType::~SVGAnimatedType):
(WebCore::SVGAnimatedType::angle):
(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::SVGAnimatedType):
* svg/SVGAnimatorFactory.h:
(WebCore::SVGAnimatorFactory::create):
* svg/SVGLength.cpp:
(WebCore::SVGLength::setValueAsString): Added an ExceptionCode for consistency reasons and as preparation for future error handling.
* svg/SVGLength.h:
* svg/SVGParserUtilities.cpp:
(WebCore::parseNumberFromString): Added number parser for String objects.
* svg/SVGParserUtilities.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89187
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 18 Jun 2011 04:57:03 +0000 (04:57 +0000)]
2011-06-17 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Adding initial interfaces and stubs for track
https://bugs.webkit.org/show_bug.cgi?id=60379
This marks the first patch of a series to implement out-of-band
<track> support in WebKit. This patch adds some of the core header files
and their corresponding stub .cpp files.
No new tests because feature is hidden behind VIDEO_TRACK feature
define, which is turned off.
* CMakeLists.txt:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* html/CueIndex.cpp: Added.
* html/CueIndex.h: Added.
* html/LoadableTextTrack.cpp: Added.
* html/LoadableTextTrack.h: Added.
* html/LoadableTextTrackImpl.cpp: Added.
* html/LoadableTextTrackImpl.h: Added.
* html/MutableTextTrack.cpp: Added.
* html/MutableTextTrack.h: Added.
* html/MutableTextTrackImpl.cpp: Added.
* html/MutableTextTrackImpl.h: Added.
* html/TextTrack.cpp: Added.
* html/TextTrack.h: Added.
* html/TextTrackCue.cpp: Added.
* html/TextTrackCue.h: Added.
* html/TextTrackCueList.cpp: Added.
* html/TextTrackCueList.h: Added.
* html/TextTrackPrivate.h: Added.
* loader/CueLoader.cpp: Added.
* loader/CueLoader.h: Added.
* platform/track/CueParser.cpp: Added.
* platform/track/CueParser.h: Added.
* platform/track/CueParserPrivate.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89186
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 18 Jun 2011 04:41:55 +0000 (04:41 +0000)]
2011-06-17 Dmitry Lomov <dslomov@google.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=62653
[V8][Chromium] Make StringCache in V8 bindings per-isolate
This moves StringCache into V8BindingPerIsolateData.
* bindings/v8/V8Binding.cpp:
(WebCore::cachedStringCallback):
(WebCore::StringCache::remove):
(WebCore::StringCache::v8ExternalStringSlow):
* bindings/v8/V8Binding.h:
(WebCore::StringCache::StringCache):
(WebCore::StringCache::v8ExternalString):
(WebCore::StringCache::clearOnGC):
(WebCore::V8BindingPerIsolateData::stringCache):
(WebCore::v8ExternalString):
* bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::gcPrologue):
2011-06-17 Dmitry Lomov <dslomov@google.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=62653
[V8][Chromium] Make StringCache in V8 bindings per-isolate
This moves StringCache into V8BindingPerIsolateData.
* src/WebScriptController.cpp:
(WebKit::WebScriptController::enableV8SingleThreadMode): StringCache is now per-isolate, so ok in multithreaded contexts.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89185
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sat, 18 Jun 2011 04:25:57 +0000 (04:25 +0000)]
2011-06-17 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
JSONP is unnecessarily slow
https://bugs.webkit.org/show_bug.cgi?id=62920
JSONP has unfortunately become a fairly common idiom online, yet
it triggers very poor performance in JSC as we end up doing codegen
for a large number of property accesses that will
* only be run once, so the vast amount of logic we dump to handle
caching of accesses is unnecessary.
* We are doing codegen that is directly proportional to just
creating the object in the first place.
This patch extends the use of the literal parser to JSONP-like structures
in global code, handling a number of different forms I have seen online.
In an extreme case this improves performance of JSONP by more than 2x
due to removal of code generation and execution time, and a few optimisations
that I made to the parser itself.
* API/JSValueRef.cpp:
(JSValueMakeFromJSONString):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
(JSC::Interpreter::execute):
* parser/Lexer.cpp:
(JSC::Lexer::isKeyword):
* parser/Lexer.h:
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
* runtime/JSONObject.cpp:
(JSC::JSONProtoFuncParse):
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::tryJSONPParse):
(JSC::LiteralParser::makeIdentifier):
(JSC::LiteralParser::Lexer::lex):
(JSC::LiteralParser::Lexer::next):
(JSC::isSafeStringCharacter):
(JSC::LiteralParser::Lexer::lexString):
(JSC::LiteralParser::Lexer::lexNumber):
(JSC::LiteralParser::parse):
* runtime/LiteralParser.h:
(JSC::LiteralParser::LiteralParser):
(JSC::LiteralParser::tryLiteralParse):
(JSC::LiteralParser::Lexer::Lexer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89184
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Sat, 18 Jun 2011 02:38:45 +0000 (02:38 +0000)]
2011-06-17 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Assertion failure in SVGTextLayoutEngine constructor (!m_layoutAttributes.isEmpty())
https://bugs.webkit.org/show_bug.cgi?id=62884
* svg/custom/assert-empty-layout-attributes-expected.txt: Added.
* svg/custom/assert-empty-layout-attributes.svg: Added.
2011-06-17 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Assertion failure in SVGTextLayoutEngine constructor (!m_layoutAttributes.isEmpty())
https://bugs.webkit.org/show_bug.cgi?id=62884
Test: svg/custom/assert-empty-layout-attributes.svg
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): Added a early return here.
It is not needed to do the text layout algorithm if you don't have any layout information as
your size is (0, 0) anyway.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89183
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 18 Jun 2011 01:09:38 +0000 (01:09 +0000)]
2011-06-17 Dmitry Lomov <dslomov@google.com>
Reviewed by Daniel Bates.
https://bugs.webkit.org/show_bug.cgi?id=62918
Pass configuration to UnitTests step in master.cfg
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89182
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Sat, 18 Jun 2011 00:43:15 +0000 (00:43 +0000)]
2011-06-17 Alexey Proskuryakov <ap@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=62913
Use ICU search collator when available
<rdar://problem/8830218> Search on a webpage in Safari conflates some Czech characters
<rdar://problem/8468873> Safari search doesn't strip Hamza
This changes behaviors that depend on system language, and isn't practically testable.
* editing/TextIterator.cpp: (WebCore::createSearcher): Ask ICU for search collator, if available.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89181
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 17 Jun 2011 23:26:38 +0000 (23:26 +0000)]
2011-06-17 Ryosuke Niwa <rniwa@webkit.org>
Roll Chromium DEPS.
* DEPS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89180
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Fri, 17 Jun 2011 23:06:09 +0000 (23:06 +0000)]
[WinCairo] Unreviewed build fix after r89060 and r89161.
* Shared/win/WebCoreArgumentCodersWin.cpp: WinCairo build fixes
(1) Include proper header files for WinCairo build
(2) Exclude unused namespace declaration
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89179
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Fri, 17 Jun 2011 22:44:44 +0000 (22:44 +0000)]
2011-06-17 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89143.
http://trac.webkit.org/changeset/89143
https://bugs.webkit.org/show_bug.cgi?id=62912
Possible Chromeos test breakage (Requested by senorblanco on
#webkit).
* src/AsyncFileSystemChromium.cpp:
(WebCore::AsyncFileSystemChromium::virtualPathToFileSystemURL):
* src/WorkerAsyncFileSystemChromium.cpp:
(WebCore::WorkerAsyncFileSystemChromium::virtualPathToFileSystemURL):
* tests/KURLTest.cpp:
(ComponentCase::TEST):
2011-06-17 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89143.
http://trac.webkit.org/changeset/89143
https://bugs.webkit.org/show_bug.cgi?id=62912
Possible Chromeos test breakage (Requested by senorblanco on
#webkit).
* platform/KURLGoogle.cpp:
(WebCore::encodeWithURLEscapeSequences):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89178
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 17 Jun 2011 22:43:17 +0000 (22:43 +0000)]
2011-06-17 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Remove unused ArgumentEncoder and ArgumentDecoder functions
https://bugs.webkit.org/show_bug.cgi?id=62909
* Platform/CoreIPC/ArgumentDecoder.cpp:
* Platform/CoreIPC/ArgumentDecoder.h:
* Platform/CoreIPC/ArgumentEncoder.cpp:
* Platform/CoreIPC/ArgumentEncoder.h:
* Shared/win/PlatformCertificateInfo.cpp:
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
Replace calls to encodeBytes/decodeBytes with
encodeVariableLengthByteArray/decodeVariableLengthByteArray.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89177
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 17 Jun 2011 22:18:10 +0000 (22:18 +0000)]
2011-06-17 David Grogan <dgrogan@chromium.org>
Reviewed by Eric Seidel.
layout test for misalignment caused by float->int rounding error
https://bugs.webkit.org/show_bug.cgi?id=61906
Just the layout test demonstrating the problem. It will be a while
until I have cycles to play around with the fix started in
https://bugs.webkit.org/show_bug.cgi?id=22759. And it'd be nice to
know if this were fixed for free via the ongoing systemic int->float
refactoring.
* css1/units/rounding-expected.txt: Added.
* css1/units/rounding.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89176
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 17 Jun 2011 21:56:38 +0000 (21:56 +0000)]
2011-06-17 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Eric Seidel.
[EFL] Add Evas-based ImageDiff implementation.
https://bugs.webkit.org/show_bug.cgi?id=61942
Build system changes will be performed as soon as the complete
DumpRenderTree implementation is upstreamed.
* DumpRenderTree/efl/ImageDiff.cpp: Added.
(pixelFromImageData):
(differenceImageFromDifferenceBuffer):
(computeDistanceBetweenPixelComponents):
(calculatePixelDifference):
(calculateDifference):
(getTemporaryFile):
(printImage):
(printImageDifferences):
(resizeEcoreEvasIfNeeded):
(readImageFromStdin):
(parseCommandLineOptions):
(shutdownEfl):
(abortWithErrorMessage):
(initEfl):
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89175
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Fri, 17 Jun 2011 21:48:12 +0000 (21:48 +0000)]
2011-06-17 Tony Chang <tony@chromium.org>
Reviewed by Dirk Pranke.
[chromium] force rebaseline-chromium-webkit-tests to use the chromium port
https://bugs.webkit.org/show_bug.cgi?id=62907
This fixes a bug where the ImageDiff on the user's machine doesn't
match the logic used on the Chromium buildbots. This has the downside
of requiring that the Chromium ImageDiff is built, but it turns out
that even with --tolerance 0, the CG ImageDiff will allow small pixel
differences through.
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89174
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Fri, 17 Jun 2011 21:46:16 +0000 (21:46 +0000)]
[WinCairo] Unreviewed build correction.
* DumpRenderTree/win/DumpRenderTreeCairo.vsprops:
Update WinCairo property sheet to link against the Cairo DLL,
now that we are using a more recent Cairo build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89173
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Fri, 17 Jun 2011 21:20:44 +0000 (21:20 +0000)]
2011-06-17 Jer Noble <jer.noble@apple.com>
Reviewed by Ada Chan.
Playing video from the manifest crashes on Windows
https://bugs.webkit.org/show_bug.cgi?id=62901
No new tests. This will be covered by existing App Cache tests.
Two related fixes. 1) Null-check the CFStringRef and CFURLRef created in QTMovie::load() before
passing them to CFRelease(). 2) Use CFURL to create an appropriate file-URL on windows in
createFileURLForApplicationCacheResource.
* html/HTMLMediaElement.cpp:
(WebCore::createFileURLForApplicationCacheResource):
* platform/graphics/win/QTMovie.cpp:
(QTMovie::load):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89172
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 17 Jun 2011 20:52:15 +0000 (20:52 +0000)]
2011-06-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Moved some property access JIT code into property access JIT files
https://bugs.webkit.org/show_bug.cgi?id=62906
* jit/JITOpcodes.cpp:
* jit/JITOpcodes32_64.cpp:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89171
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 17 Jun 2011 20:51:25 +0000 (20:51 +0000)]
Yet another Qt build fix attempt.
* UIProcess/API/qt/ClientImpl.cpp:
* UIProcess/API/qt/qgraphicswkview.cpp:
* UIProcess/API/qt/qwkpage.cpp:
* UIProcess/API/qt/qwkpage_p.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89170
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Fri, 17 Jun 2011 20:43:59 +0000 (20:43 +0000)]
2011-06-17 Stephen White <senorblanco@chromium.org>
Unreviewed.
Some new chromium test expectations and updates.
* platform/chromium-mac-leopard/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89169
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 17 Jun 2011 20:41:50 +0000 (20:41 +0000)]
Another attempt at fixing the Qt build.
* UIProcess/API/qt/ClientImpl.cpp:
* UIProcess/API/qt/qgraphicswkview.cpp:
* UIProcess/API/qt/qwkcontext.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89168
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Fri, 17 Jun 2011 20:40:53 +0000 (20:40 +0000)]
Rubber Stamped by Sam Weinig.
Land a couple more regex tests.
* fast/regex/pcre-test-1-expected.txt:
* fast/regex/script-tests/pcre-test-1.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89167
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 17 Jun 2011 20:21:06 +0000 (20:21 +0000)]
Fix Qt build.
* WebProcess/ResourceCache/WebResourceCacheManager.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89166
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Fri, 17 Jun 2011 20:19:10 +0000 (20:19 +0000)]
2011-06-17 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Tests that we do not crash when unable to remove floats from
parent's next siblings blocks.
https://bugs.webkit.org/show_bug.cgi?id=62875
* fast/block/float/float-not-removed-from-next-sibling5-expected.txt: Added.
* fast/block/float/float-not-removed-from-next-sibling5.html: Added.
2011-06-17 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
When we lose ability to propagate floats, need to find topmost
parent with that overhanging float, and then iterate over its
sibling blocks to remove the float.
https://bugs.webkit.org/show_bug.cgi?id=62875
Test: fast/block/float/float-not-removed-from-next-sibling5.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::hasOverhangingFloat):
* rendering/RenderBlock.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89165
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 17 Jun 2011 20:08:30 +0000 (20:08 +0000)]
Windows build fix.
* UIProcess/win/WebView.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89164
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log