WebKit-https.git
5 years agoPause playback on exit fullscreen when inline playback not allowed.
jeremyj@apple.com [Fri, 2 May 2014 13:52:01 +0000 (13:52 +0000)]
Pause playback on exit fullscreen when inline playback not allowed.
https://bugs.webkit.org/show_bug.cgi?id=132450

Reviewed by Jer Noble.

Use correct method of determining if inline playback is allowed.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
Use m_mediaSession->requiresFullscreenForVideoPlayback to detect if inline playback is allowed.

* platform/ios/WebVideoFullscreenModelMediaElement.mm:
(WebVideoFullscreenModelMediaElement::requestExitFullscreen):
Prevent duplicate exit requests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION(r168118): [GTK] build broken due to shouldTrackVisitedLinks
commit-queue@webkit.org [Fri, 2 May 2014 12:03:07 +0000 (12:03 +0000)]
REGRESSION(r168118): [GTK] build broken due to shouldTrackVisitedLinks
https://bugs.webkit.org/show_bug.cgi?id=132447

Unreviewed GTK build fix.

shouldTrackVisitedLinks was removed on r168118.
Visited link coloring works as expected after this change.

Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-05-02

* UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformInitializeWebProcess): Remove
shouldTrackVisitedLinks parameter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CSS Blending] Remove support for non-separable blend modes from background-blend...
commit-queue@webkit.org [Fri, 2 May 2014 09:35:34 +0000 (09:35 +0000)]
[CSS Blending] Remove support for non-separable blend modes from background-blend-mode
https://bugs.webkit.org/show_bug.cgi?id=132327

Patch by Ion Rosca <rosca@adobe.com> on 2014-05-02
Reviewed by Dean Jackson.

Source/WebCore:
Removed support for non-separable background blend modes from the CSS parser.
Covered by existing tests.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseFillProperty):

LayoutTests:
* css3/compositing/background-blend-mode-gif-color-2.html:
* css3/compositing/background-blend-mode-gif-color.html:
* css3/compositing/background-blend-mode-gradient-color.html:
* css3/compositing/background-blend-mode-gradient-gradient.html:
* css3/compositing/background-blend-mode-gradient-image.html:
* css3/compositing/background-blend-mode-image-color.html:
* css3/compositing/background-blend-mode-image-image.html:
* css3/compositing/background-blend-mode-image-svg.html:
* css3/compositing/background-blend-mode-multiple-background-layers.html:
* css3/compositing/background-blend-mode-property-expected.txt:
* css3/compositing/background-blend-mode-property-parsing-expected.txt:
* css3/compositing/background-blend-mode-svg-color.html:
* css3/compositing/effect-background-blend-mode-tiled.html:
* css3/compositing/effect-background-blend-mode.html:
* css3/compositing/script-tests/background-blend-mode-property-parsing.js:
* css3/compositing/script-tests/background-blend-mode-property.js:
* platform/mac/css3/compositing/background-blend-mode-gif-color-2-expected.png:
* platform/mac/css3/compositing/background-blend-mode-gif-color-2-expected.txt:
* platform/mac/css3/compositing/background-blend-mode-gif-color-expected.png:
* platform/mac/css3/compositing/background-blend-mode-gif-color-expected.txt:
* platform/mac/css3/compositing/background-blend-mode-gradient-color-expected.png:
* platform/mac/css3/compositing/background-blend-mode-gradient-gradient-expected.png:
* platform/mac/css3/compositing/background-blend-mode-gradient-image-expected.png:
* platform/mac/css3/compositing/background-blend-mode-image-color-expected.png:
* platform/mac/css3/compositing/background-blend-mode-image-color-expected.txt:
* platform/mac/css3/compositing/background-blend-mode-image-image-expected.png:
* platform/mac/css3/compositing/background-blend-mode-image-image-expected.txt:
* platform/mac/css3/compositing/background-blend-mode-image-svg-expected.png:
* platform/mac/css3/compositing/background-blend-mode-multiple-background-layers-expected.png:
* platform/mac/css3/compositing/background-blend-mode-svg-color-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoClean up #include <OwnPtr.h>|<PassOwnPtr.h> in Supplementable classes
gyuyoung.kim@samsung.com [Fri, 2 May 2014 08:59:29 +0000 (08:59 +0000)]
Clean up #include <OwnPtr.h>|<PassOwnPtr.h> in Supplementable classes
https://bugs.webkit.org/show_bug.cgi?id=132466

Reviewed by Tim Horton.

Since r168144, Supplementable classes don't need to include OwnPtr.h or PassOwnPtr.h.
Clean up those inclusions.

No new tests, just clean up patch.

* Modules/encryptedmedia/CDMPrivate.h:
* Modules/gamepad/NavigatorGamepad.cpp:
* Modules/geolocation/GeolocationController.cpp:
(WebCore::GeolocationController::create): Deleted. Don't need to have a factory function.
* Modules/geolocation/GeolocationController.h:
* Modules/mediasource/MediaSource.h:
* Modules/mediastream/UserMediaController.h:
* Modules/notifications/NotificationCenter.h:
* Modules/notifications/NotificationController.cpp:
* Modules/quota/StorageErrorCallback.h:
* Modules/vibration/Vibration.h:
* Modules/webdatabase/Database.cpp:
* Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
* Modules/websockets/WebSocket.cpp:
* Modules/websockets/WebSocket.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMore 32-bit build fixes.
timothy_horton@apple.com [Fri, 2 May 2014 06:23:31 +0000 (06:23 +0000)]
More 32-bit build fixes.

* Misc/WebSharingServicePickerController.mm:
(-[WebSharingServicePickerController sharingService:didShareItems:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdded Radar link to the last ChangeLog entry.
mitz@apple.com [Fri, 2 May 2014 05:55:44 +0000 (05:55 +0000)]
Added Radar link to the last ChangeLog entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTemporarily "fix" the 32-bit build.
timothy_horton@apple.com [Fri, 2 May 2014 05:55:37 +0000 (05:55 +0000)]
Temporarily "fix" the 32-bit build.

* Misc/WebSharingServicePickerController.mm:
This will fail miserably at runtime, but we shouldn't ever get here in a 32-bit process.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFixed production builds for the iOS Simulator.
mitz@apple.com [Fri, 2 May 2014 05:53:08 +0000 (05:53 +0000)]
Fixed production builds for the iOS Simulator.

* Configurations/bmalloc.xcconfig: Include INSTALL_PATH_PREFIX in
PRIVATE_HEADERS_FOLDER_PATH when installing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove TiledBackingStore stuff from Frame
ryuan.choi@samsung.com [Fri, 2 May 2014 05:49:24 +0000 (05:49 +0000)]
Remove TiledBackingStore stuff from Frame
https://bugs.webkit.org/show_bug.cgi?id=132458

Reviewed by Andreas Kling.

Although TiledBackingStore is using for the CoordinatedGraphics,
CoordinatedGraphics does not use tiledBackingStore of Frame.

This patch removed TiledBackingStore related code of the Frame.

* page/Frame.cpp:
(WebCore::Frame::Frame):
(WebCore::Frame::setView):
(WebCore::Frame::setTiledBackingStoreEnabled): Deleted.
(WebCore::Frame::tiledBackingStorePaintBegin): Deleted.
(WebCore::Frame::tiledBackingStorePaint): Deleted.
(WebCore::Frame::tiledBackingStorePaintEnd): Deleted.
(WebCore::Frame::tiledBackingStoreContentsRect): Deleted.
(WebCore::Frame::tiledBackingStoreVisibleRect): Deleted.
(WebCore::Frame::tiledBackingStoreBackgroundColor): Deleted.
* page/Frame.h:
(WebCore::Frame::tiledBackingStore): Deleted.
* page/FrameView.cpp:
(WebCore::FrameView::repaintContentRectangle):
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setTiledBackingStoreEnabled): Deleted.
* page/Settings.h:
(WebCore::Settings::tiledBackingStoreEnabled): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION(r125251): It made svg/custom/use-instanceRoot-as-event-target.xhtml assert...
ap@apple.com [Fri, 2 May 2014 05:19:18 +0000 (05:19 +0000)]
REGRESSION(r125251): It made svg/custom/use-instanceRoot-as-event-target.xhtml assert and flakey
https://bugs.webkit.org/show_bug.cgi?id=93812

This is most likely fixed, unmarking the test.

* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMigrate all uses of DeviceMotionController and DeviceOrientationController to std...
mmaxfield@apple.com [Fri, 2 May 2014 04:23:34 +0000 (04:23 +0000)]
Migrate all uses of DeviceMotionController and DeviceOrientationController to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=132461

Unreviewed build fix.

No new tests.

* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
* platform/ios/DeviceMotionClientIOS.h:
(WebCore::DeviceMotionClientIOS::create): Deleted.
* platform/ios/DeviceOrientationClientIOS.h:
(WebCore::DeviceOrientationClientIOS::create): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUpdate service picker API usage.
beidson@apple.com [Fri, 2 May 2014 03:31:43 +0000 (03:31 +0000)]
Update service picker API usage.
<rdar://problem/16772674> and https://bugs.webkit.org/show_bug.cgi?id=132452

Reviewed by Tim Horton.

* Misc/WebSharingServicePickerController.h:
* Misc/WebSharingServicePickerController.mm:
(-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
  Factor out a common "didShare" handler that optionally validates whether the data represents an image.
(-[WebSharingServicePickerController sharingService:didShareItems:]): Update API usage, including marshalling
  on off-main thread call back to the main thread.

* WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::contextMenuForEvent): Update API usage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoConvert OwnPtr and PassOwnPtr uses to std::unique_ptr in Supplement
gyuyoung.kim@samsung.com [Fri, 2 May 2014 02:28:49 +0000 (02:28 +0000)]
Convert OwnPtr and PassOwnPtr uses to std::unique_ptr in Supplement
https://bugs.webkit.org/show_bug.cgi?id=132165

Reviewed by Darin Adler.

According to convert from PassOwnPtr to std::unique_ptr, provideTo() callers also begin
to use std::make_unique.

* Modules/battery/BatteryController.cpp:
(WebCore::provideBatteryTo):
* Modules/battery/BatteryController.h:
* Modules/battery/NavigatorBattery.cpp:
(WebCore::NavigatorBattery::from):
* Modules/gamepad/NavigatorGamepad.cpp:
(WebCore::NavigatorGamepad::from):
* Modules/geolocation/GeolocationController.cpp:
(WebCore::provideGeolocationTo):
* Modules/geolocation/GeolocationController.h:
* Modules/geolocation/NavigatorGeolocation.cpp:
(WebCore::NavigatorGeolocation::from):
* Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
(WebCore::DOMWindowIndexedDatabase::from):
* Modules/indexeddb/PageGroupIndexedDatabase.cpp:
(WebCore::PageGroupIndexedDatabase::from):
* Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.cpp:
(WebCore::WorkerGlobalScopeIndexedDatabase::from):
* Modules/mediastream/UserMediaController.cpp:
(WebCore::provideUserMediaTo):
(WebCore::UserMediaController::create): Deleted.
* Modules/mediastream/UserMediaController.h:
* Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
(WebCore::provideNavigatorContentUtilsTo):
(WebCore::NavigatorContentUtils::create): Deleted.
* Modules/navigatorcontentutils/NavigatorContentUtils.h:
* Modules/notifications/DOMWindowNotifications.cpp:
(WebCore::DOMWindowNotifications::from):
* Modules/notifications/NotificationController.cpp:
(WebCore::provideNotification):
(WebCore::NotificationController::create): Deleted.
* Modules/notifications/NotificationController.h:
* Modules/notifications/WorkerGlobalScopeNotifications.cpp:
(WebCore::WorkerGlobalScopeNotifications::from):
* Modules/proximity/DeviceProximityController.cpp:
(WebCore::provideDeviceProximityTo):
(WebCore::DeviceProximityController::create): Deleted.
* Modules/proximity/DeviceProximityController.h:
* Modules/quota/DOMWindowQuota.cpp:
(WebCore::DOMWindowQuota::from):
* Modules/quota/NavigatorStorageQuota.cpp:
(WebCore::NavigatorStorageQuota::from):
* Modules/quota/WorkerNavigatorStorageQuota.cpp:
(WebCore::WorkerNavigatorStorageQuota::from):
* Modules/speech/DOMWindowSpeechSynthesis.cpp:
(WebCore::DOMWindowSpeechSynthesis::from):
* Modules/speech/SpeechRecognitionController.cpp:
(WebCore::provideSpeechRecognitionTo):
* Modules/vibration/Vibration.cpp:
(WebCore::provideVibrationTo):
(WebCore::Vibration::create): Deleted.
* Modules/vibration/Vibration.h:
* dom/DeviceMotionController.cpp:
(WebCore::provideDeviceMotionTo):
(WebCore::DeviceMotionController::create): Deleted.
* dom/DeviceMotionController.h:
* dom/DeviceOrientationController.cpp:
(WebCore::provideDeviceOrientationTo):
(WebCore::DeviceOrientationController::create): Deleted.
* dom/DeviceOrientationController.h:
* page/SpeechInput.cpp:
(WebCore::provideSpeechInputTo):
(WebCore::SpeechInput::create): Deleted.
* page/SpeechInput.h:
* platform/Supplementable.h:
(WebCore::Supplement::provideTo):
(WebCore::Supplementable::provideSupplement):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::from):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCorrect case of environment variables in auto-version.sh scripts
bfulgham@apple.com [Fri, 2 May 2014 01:45:13 +0000 (01:45 +0000)]
Correct case of environment variables in auto-version.sh scripts
https://bugs.webkit.org/show_bug.cgi?id=132455

Reviewed by Dean Jackson.

Although we have historically used RC_PROJECTSOURCEVERSION in our scripts,
the actual environment variable is RC_ProjectSourceVersion. Old versions of
Cygwin converted this to all-caps by default, but this is no longer the case.
We need to use the proper case to avoid build failures.

* win/tools/scripts/auto-version.sh: Although we have historically coded
this as 'RC_PROJECTSOURCEVERSION', it is actually 'RC_ProjectSourceVersion'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (WebKit2) Need to support Learn button.
enrica@apple.com [Fri, 2 May 2014 01:40:13 +0000 (01:40 +0000)]
REGRESSION (WebKit2) Need to support Learn button.
https://bugs.webkit.org/show_bug.cgi?id=132454
<rdar://problem/16778889>

Reviewed by Benjamin Poulain.

For traditional Chinese we support the ability to add shortcuts
for typing. This is done by pressing the Learn button on the system
menu. This patch adds the necessary code to canPerformAction to enable
the button when appropriate as well as the implementation of the action
itself.
It also adds a check for the Replace button not to be shown when the
selection only contains CJ characters.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _addShortcut:]):
(-[WKContentView canPerformAction:withSender:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
ryuan.choi@samsung.com [Fri, 2 May 2014 01:21:53 +0000 (01:21 +0000)]
[EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
https://bugs.webkit.org/show_bug.cgi?id=132240

Reviewed by Anders Carlsson.

Source/WebKit/efl:
Since we moved to use TextureMapper, this option is meaningless now.
Removed ewk_view_setting_tiled_backing_store_enabled_{get|set} and related codes.

* ewk/ewk_view.cpp:
(ewk_view_setting_tiled_backing_store_enabled_set): Deleted.
(ewk_view_setting_tiled_backing_store_enabled_get): Deleted.
* ewk/ewk_view.h:
* tests/test_ewk_view.cpp:
(TEST_F): Deleted.

Tools:
Removed ewk_view_setting_tiled_backingstore related code.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(shouldUseTiledBackingStore): Deleted.
* EWebLauncher/main.c:
(windowCreate):
(parseUserArguments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSupport OS-version-specific install paths for WebKit.framework
andersca@apple.com [Fri, 2 May 2014 00:34:03 +0000 (00:34 +0000)]
Support OS-version-specific install paths for WebKit.framework
https://bugs.webkit.org/show_bug.cgi?id=132448
<rdar://problem/16784932>

Reviewed by Dan Bernstein.

Source/WebKit:
* WebKit.xcodeproj/project.pbxproj:
Add a build step to put a symlink in place from PrivateFrameworks to Frameworks.

Source/WebKit/mac:
* WebKitLegacy/WebKit.m:
Add version specific install names.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoHTMLMediaElement: Remove two unnecessary virtual overrides.
akling@apple.com [Fri, 2 May 2014 00:04:19 +0000 (00:04 +0000)]
HTMLMediaElement: Remove two unnecessary virtual overrides.
<https://webkit.org/b/132445>

Now that ENABLE_PLUGIN_PROXY_FOR_VIDEO is gone, we can remove
these overrides:

    - defaultEventHandler()
    - willRespondToMouseClickEvents()

Reviewed by Darin Adler.

* html/HTMLMediaElement.cpp:
* html/HTMLMediaElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoViewportConfiguration::minimumScale() uses the initial scale as initial value
benjamin@webkit.org [Thu, 1 May 2014 23:59:43 +0000 (23:59 +0000)]
ViewportConfiguration::minimumScale() uses the initial scale as initial value
https://bugs.webkit.org/show_bug.cgi?id=132451
<rdar://problem/16780111>

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-05-01
Reviewed by Enrica Casucci.

* page/ViewportConfiguration.cpp:
(WebCore::ViewportConfiguration::minimumScale):
The initial minimum scale was set to the initial scale, preventing some pages from zooming
out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS][WK2] Tweak the extended background exclusion for MobileSafari
benjamin@webkit.org [Thu, 1 May 2014 23:59:06 +0000 (23:59 +0000)]
[iOS][WK2] Tweak the extended background exclusion for MobileSafari
https://bugs.webkit.org/show_bug.cgi?id=132449

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-05-01
Reviewed by Beth Dakin.

Some tweaks for Mobile:
-Use UIViews instead of CALayers to have the same animation timing as the top views.
-The left extended background insets should not exclude the top and bottom insets.

Since this code is in the middle of 2 hot paths, also added some performance tweaks.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
In the normal case, we do not have extended background exclusion. To avoid creating a background view, we use
the scrollview to render the background.
The separate background view is created lazily if needed.

(-[WKWebView _updateScrollViewBackground]):
(-[WKWebView _frameOrBoundsChanged]):
(updateTopAndBottomExtendedBackgroundExclusionIfNecessary):
This create the top and bottom extended background view as needed and update their frames for the current insets.

(-[WKWebView _setObscuredInsets:]):
(-[WKWebView _setExtendedBackgroundExclusionInsets:]):
When an exclusion inset is needed, create a view for it, transfer the color from the ScrollView, and reset the color
of the scrollview.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoBuild fix for !ENABLE(BLOB) builds.
ap@apple.com [Thu, 1 May 2014 23:19:40 +0000 (23:19 +0000)]
Build fix for !ENABLE(BLOB) builds.

* fileapi/ThreadableBlobRegistry.cpp:
(WebCore::ThreadableBlobRegistry::registerBlobURL):
(WebCore::ThreadableBlobRegistry::registerBlobURLForSlice):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove size computation for Blob constructor into BlobRegistryImpl
ap@apple.com [Thu, 1 May 2014 23:09:27 +0000 (23:09 +0000)]
Move size computation for Blob constructor into BlobRegistryImpl
https://bugs.webkit.org/show_bug.cgi?id=132439

Reviewed by Sam Weinig.

Source/WebCore:
* Modules/websockets/WebSocket.cpp: (WebCore::WebSocket::didReceiveBinaryData):
Don't pass the size, anyone who cares can get it from BlobData.

* bindings/js/JSBlobCustom.cpp: (WebCore::JSBlobConstructor::constructJSBlob):
Updated for BlobBuilder changes.

* fileapi/Blob.cpp: (WebCore::Blob::Blob):
* fileapi/Blob.h: (WebCore::Blob::create):
No longer take a precomputed size with BlobData, BlobRegistry will compute it as
part of registration.

* fileapi/File.h:
* fileapi/File.cpp:
(WebCore::File::File): Don't pass a size (that's unknown anyway).
(WebCore::File::captureSnapshot): Deleted. Finally, only the registry is responsible
for snapshot tracking now (I doubt that either new or old code is particularly compliant).

* fileapi/ThreadableBlobRegistry.cpp:
(WebCore::ThreadableBlobRegistry::registerBlobURL):
* fileapi/ThreadableBlobRegistry.h:
Plumbing to make this version of registerBlobURL return a size. I may make size
calculation lazy and the function async later, but this is needed to move the behavior
to the right place first.

* fileapi/WebKitBlobBuilder.h:
* fileapi/WebKitBlobBuilder.cpp:
(WebCore::BlobBuilder::BlobBuilder):
(WebCore::BlobBuilder::append):
(WebCore::BlobBuilder::appendBytesData):
(WebCore::BlobBuilder::finalize):
(WebCore::BlobBuilder::getBlob): Deleted.
Don't track sizes or modification times, registry will do that with appropriate laziness.
Cleaned up the API - now that BlobBuilder is not exposed to JS as an object, it
does not need to be reusable.

* platform/network/BlobRegistry.h: Made this version of registerBlobURL return a size.
* platform/network/BlobRegistryImpl.h:
* platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::appendStorageItems): Assert that length computations are accurate.
(WebCore::BlobRegistryImpl::registerBlobURL): Compute a size to return, and record
modification time as necessary.

* xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseBlob): Don't pass the
size, which can be computed from data. Soon, I want to add a constructor that doesn't
require wrapping a single Vector as BlobData to construct a Blob.

Source/WebKit2:
Plumbing to make this version of registerBlobURL synchronous for now.
I expect to make it async again when data structures on client side are simplified.

* NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
(WebKit::NetworkBlobRegistry::registerBlobURL):
* NetworkProcess/FileAPI/NetworkBlobRegistry.h:
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::registerBlobURL):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* WebProcess/FileAPI/BlobRegistryProxy.cpp:
(WebKit::BlobRegistryProxy::registerBlobURL):
* WebProcess/FileAPI/BlobRegistryProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] audio and video should automatically play to active external device
eric.carlson@apple.com [Thu, 1 May 2014 22:54:40 +0000 (22:54 +0000)]
[iOS] audio and video should automatically play to active external device
https://bugs.webkit.org/show_bug.cgi?id=132428

Reviewed by Jer Noble.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Set
    AVPlayer.usesExternalPlaybackWhileExternalScreenIsActive.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION(168053): Repro crash navigating to another page after selecting phone
bdakin@apple.com [Thu, 1 May 2014 22:53:53 +0000 (22:53 +0000)]
REGRESSION(168053): Repro crash navigating to another page after selecting phone
numbers on a page
https://bugs.webkit.org/show_bug.cgi?id=132444
-and corresponding-
<rdar://problem/16787285>

Reviewed by Darin Adler.

Missing null-check.
* WebProcess/WebPage/mac/TelephoneNumberOverlayControllerMac.mm:
(WebKit::TelephoneNumberOverlayController::drawRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove WKBundleSetShouldTrackVisitedLinks and associate code
andersca@apple.com [Thu, 1 May 2014 22:03:54 +0000 (22:03 +0000)]
Remove WKBundleSetShouldTrackVisitedLinks and associate code
https://bugs.webkit.org/show_bug.cgi?id=132441

Reviewed by Sam Weinig.

* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetShouldTrackVisitedLinks): Deleted.
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setShouldTrackVisitedLinks): Deleted.
* WebProcess/InjectedBundle/InjectedBundle.h:
* WebProcess/WebPage/VisitedLinkTableController.cpp:
(WebKit::VisitedLinkTableController::addVisitedLink):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::setShouldTrackVisitedLinks): Deleted.
* WebProcess/WebProcess.h:
(WebKit::WebProcess::shouldTrackVisitedLinks): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agowindow.testRunner.keepWebHistory() should update the UI process state
andersca@apple.com [Thu, 1 May 2014 21:53:47 +0000 (21:53 +0000)]
window.testRunner.keepWebHistory() should update the UI process state
https://bugs.webkit.org/show_bug.cgi?id=132440

Reviewed by Dan Bernstein.

Source/WebKit2:
* UIProcess/API/C/WKPage.cpp:
(WKPageGetAddsVisitedLinks):
(WKPageSetAddsVisitedLinks):
* UIProcess/API/C/WKPagePrivate.h:

Tools:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::postSetAddsVisitedLinks):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::keepWebHistory):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r168046): [New Multicolumn] Selection into and out of column-span element...
hyatt@apple.com [Thu, 1 May 2014 21:00:19 +0000 (21:00 +0000)]
REGRESSION (r168046): [New Multicolumn] Selection into and out of column-span elements doesn't work
https://bugs.webkit.org/show_bug.cgi?id=132066

Reviewed by Oliver Hunt.

Make a new SelectionIterator struct that knows how to drill into and out of
column span placeholders. Also change spans to be selection roots (in the painting
sense).

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::isSelectionRoot):
(WebCore::RenderBlock::selectionGaps):
* rendering/RenderView.cpp:
(WebCore::SelectionIterator::SelectionIterator):
(WebCore::SelectionIterator::checkForSpanner):
(WebCore::SelectionIterator::current):
(WebCore::SelectionIterator::next):
(WebCore::RenderView::subtreeSelectionBounds):
(WebCore::RenderView::repaintSubtreeSelection):
(WebCore::RenderView::setSubtreeSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRoll out r60161.
fpizlo@apple.com [Thu, 1 May 2014 20:56:48 +0000 (20:56 +0000)]
Roll out r60161.

Rubber stamped by Mark Hahnenberg.

This breaks our debugging workflow.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::decode):
* UIProcess/mac/WebContextMac.mm:
(WebKit::registerUserDefaultsIfNeeded):
(WebKit::WebContext::platformInitializeWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDon't always make backing store for -webkit-backface-visibility:hidden
simon.fraser@apple.com [Thu, 1 May 2014 20:56:21 +0000 (20:56 +0000)]
Don't always make backing store for -webkit-backface-visibility:hidden
https://bugs.webkit.org/show_bug.cgi?id=132420

Reviewed by Sam Weinig.

Source/WebCore:
Previously, -webkit-backface-visibility:hidden unconditionally created
compositing layers with backing store. This results in high memory use
on pages with this style applied to many elements (a cargo-cult "optimization").

Fix by only having -webkit-backface-visibility:hidden create compositing layers
if some ancestor has a 3D transform. That's the only scenario in which the
element can be flipped around to reveal the back side, so the only time we need
to do compositing for this property. In future, we could be smarter, and only
consider 3D transforms in the current preserve-3d context.

Tests: compositing/backing/backface-visibility-in-3dtransformed.html
       compositing/backing/backface-visibility-in-transformed.html
       compositing/backing/backface-visibility.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::hitTestLayer):
* rendering/RenderLayer.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore):
(WebCore::RenderLayerCompositor::requiresCompositingForBackfaceVisibility):
* rendering/RenderLayerCompositor.h:

LayoutTests:
Dump layers for elements with backface-visibility: hidden with various types
of ancestors.

* compositing/backing/backface-visibility-expected.txt: Added.
* compositing/backing/backface-visibility-in-3dtransformed-expected.txt: Added.
* compositing/backing/backface-visibility-in-3dtransformed.html: Added.
* compositing/backing/backface-visibility-in-transformed-expected.txt: Added.
* compositing/backing/backface-visibility-in-transformed.html: Added.
* compositing/backing/backface-visibility.html: Added.
* inspector-protocol/layers/layers-anonymous.html: Don't use backface-visibility
for force a layer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWKWebView doesn't track visited links (for visited link coloring)
andersca@apple.com [Thu, 1 May 2014 20:39:55 +0000 (20:39 +0000)]
WKWebView doesn't track visited links (for visited link coloring)
https://bugs.webkit.org/show_bug.cgi?id=132438
<rdar://problem/16704519>

Reviewed by Dan Bernstein.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/API/APIHistoryClient.h:
(API::HistoryClient::addsVisitedLinks):
(API::HistoryClient::shouldTrackVisitedLinks): Deleted.
* UIProcess/API/C/WKContext.cpp:
(WKContextSetHistoryClient):
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _addsVisitedLinks]):
(-[WKWebView _setAddsVisitedLinks:]):
* UIProcess/API/Cocoa/WKWebViewPrivate.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:context:configuration:webView:]):
* UIProcess/Cocoa/HistoryClient.h:
* UIProcess/Cocoa/HistoryClient.mm:
(WebKit::HistoryClient::shouldTrackVisitedLinks): Deleted.
* UIProcess/VisitedLinkProvider.cpp:
(WebKit::VisitedLinkProvider::addVisitedLinkHashFromPage):
* UIProcess/VisitedLinkProvider.h:
* UIProcess/VisitedLinkProvider.messages.in:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::setHistoryClient):
(WebKit::WebContext::createNewWebProcess):
* UIProcess/WebContext.h:
(WebKit::WebContext::processes):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::addsVisitedLinks):
(WebKit::WebPageProxy::setAddsVisitedLinks):
* WebProcess/WebPage/VisitedLinkTableController.cpp:
(WebKit::VisitedLinkTableController::addVisitedLink):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS][WK2] The highlight view needs to be in WKWebView coordinates
benjamin@webkit.org [Thu, 1 May 2014 20:32:57 +0000 (20:32 +0000)]
[iOS][WK2] The highlight view needs to be in WKWebView coordinates
https://bugs.webkit.org/show_bug.cgi?id=132435
<rdar://problem/16708861>

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-05-01
Reviewed by Tim Horton.

_UIHighlightView needs to be in WKWebView coordinates so that it render unscaled for any page scale factor.
The view needs to be a child of WKContentView so that it moves/scales with the page.

To fix the issue, add an inverse transform root layer for the hightlight, and scale the coordinates to their
inverse scaled counterpart.

The scale is not updated live with the scaling of WKContentView but that should be fine since the view disappear
on any scaling operation (and I would prefer not add live painting during scaling animation).

* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanupInteraction]):
(-[WKContentView _didGetTapHighlightForRequest:color:WebCore::quads:WebCore::topLeftRadius:WebCore::topRightRadius:WebCore::bottomLeftRadius:WebCore::bottomRightRadius:WebCore::]):
(-[WKContentView _cancelInteraction]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoJavaScriptCore fails to build with some versions of clang
ggaren@apple.com [Thu, 1 May 2014 20:03:27 +0000 (20:03 +0000)]
JavaScriptCore fails to build with some versions of clang
https://bugs.webkit.org/show_bug.cgi?id=132436

Reviewed by Anders Carlsson.

* runtime/ArgumentsIteratorConstructor.cpp: Since we call
putDirectWithoutTransition, and it calls putWillGrowOutOfLineStorage,
and both are marked inline, it's valid for the compiler to decide
to inline both and emit neither in the binary. Therefore, we need
both inline definitions to be available in the translation unit at
compile time, or we'll try to link against a function that doesn't exist.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFinish updating ANGLE.
achristensen@apple.com [Thu, 1 May 2014 19:24:46 +0000 (19:24 +0000)]
Finish updating ANGLE.
https://bugs.webkit.org/show_bug.cgi?id=132434

Reviewed by Dean Jackson.

Source/ThirdParty/ANGLE:
* ANGLE.xcodeproj/project.pbxproj:
Removed Uniform.cpp which is no longer in ANGLE.
* changes.diff:
Added more changes from ANGLE which are already included in WebKit.

Updated ANGLE source files to e7a453a5bd76705ccb151117fa844846d4aa90af.  Long list of changes omitted.

Source/WebCore:
* CMakeLists.txt:
Removed Uniform.cpp which is no longer in ANGLE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (new multi-column): WebKit2.ResizeReversePaginatedWebView fails on debug...
hyatt@apple.com [Thu, 1 May 2014 19:10:56 +0000 (19:10 +0000)]
REGRESSION (new multi-column): WebKit2.ResizeReversePaginatedWebView fails on debug bots
https://bugs.webkit.org/show_bug.cgi?id=132429

Reviewed by Alexey Proskuryakov.

Make sure to get the column count directly from the column set.
I was returning the theoretical column count from the flow thread,
and that wasn't the right value.

* rendering/RenderMultiColumnSet.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::pageCount):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix handling of attributes prior to compiling shader
bfulgham@apple.com [Thu, 1 May 2014 19:02:49 +0000 (19:02 +0000)]
Fix handling of attributes prior to compiling shader
https://bugs.webkit.org/show_bug.cgi?id=132430

Reviewed by Dean Jackson.

Source/WebCore:
WebGL programs that called bindAttribLocations prior to compiling shader sources
would perform the bind using the non-hashed symbol name, but would later create
the attributes as hashed names. Consequently, the program would refer to
attributes that were never actually part of any shader, resulting in some amazing
display artifacts.

This patch adds a dictionary of hashed symbol names so that we can tell the WebGL
program the proper name that will be used when the shader is eventually compiled,
allowing the WebGL program to link against the proper symbol after compiling and
linking completes.

* platform/graphics/GraphicsContext3D.h:
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::generateHashedName): Function uses the ANGLE hashing
function to generate correct symbol.
(WebCore::GraphicsContext3D::mappedSymbolName): If we haven't compiled shaders yet, look
in our set of potentially unused attributes.
(WebCore::GraphicsContext3D::originalSymbolName): Ditto, for reverse lookup.

Source/WTF:
WebGL programs that called bindAttribLocations prior to compiling shader sources
would perform the bind using the non-hashed symbol name, but would later create
the attributes as hashed names. Consequently, the program would refer to
attributes that were never actually part of any shader, resulting in some amazing
display artifacts.

This patch adds a dictionary of hashed symbol names so that we can tell the WebGL
program the proper name that will be used when the shader is eventually compiled,
allowing the WebGL program to link against the proper symbol after compiling and
linking completes.

* wtf/HexNumber.h:
(WTF::appendUnsigned64AsHex): Add uint64_t-compatible hex->string converter.

LayoutTests:
* fast/canvas/webgl/gl-bind-attrib-location-before-compile-test-expected.txt: Added.
* fast/canvas/webgl/gl-bind-attrib-location-before-compile-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSubpixel rendering: Make selection gaps painting subpixel aware.
zalan@apple.com [Thu, 1 May 2014 18:49:37 +0000 (18:49 +0000)]
Subpixel rendering: Make selection gaps painting subpixel aware.
https://bugs.webkit.org/show_bug.cgi?id=132169

Reviewed by Simon Fraser.

Push selection gaps painting to device pixel boundaries instead of integral CSS pixel positions.

Source/WebCore:
Test: fast/inline/hidpi-selection-gap-on-subpixel-position.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::blockSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):

LayoutTests:
* fast/inline/hidpi-selection-gap-on-subpixel-position-expected.html: Added.
* fast/inline/hidpi-selection-gap-on-subpixel-position.html: Added. : &nbsp is needed to make
this test pass on WK2. Font rendering reports differences. 0.9 transparency is added so that
text selection code does modify the color's alpha channel and I can properly match it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoLink against bmalloc in production builds
ggaren@apple.com [Thu, 1 May 2014 18:31:35 +0000 (18:31 +0000)]
Link against bmalloc in production builds
https://bugs.webkit.org/show_bug.cgi?id=132413

Reviewed by Sam Weinig.

Production builders have been configured to handle this, so let's build
it.

* Configurations/WTF.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoReally remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
ddkilzer@apple.com [Thu, 1 May 2014 18:20:14 +0000 (18:20 +0000)]
Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
<http://webkit.org/b/132432>

Reviewed by Tim Horton.

.:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:
- Remove ENABLE_PLUGIN_PROXY_FOR_VIDEO as build option.

Source/WebCore:
* platform/graphics/wince/MediaPlayerPrivateWinCE.h: Remove
methods and ivar in ENABLE(PLUGIN_PROXY_FOR_VIDEO).

Tools:
* Scripts/webkitperl/FeatureList.pm: Remove support for
--plugin-proxy-for-video switch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CSS Grid Layout] Clamping the number of repetitions in repeat()
commit-queue@webkit.org [Thu, 1 May 2014 17:48:38 +0000 (17:48 +0000)]
[CSS Grid Layout] Clamping the number of repetitions in repeat()
https://bugs.webkit.org/show_bug.cgi?id=131023

Patch by Javier Fernandez <jfernandez@igalia.com> on 2014-05-01
Reviewed by Brent Fulgham.

Source/WebCore:
The ED suggests now to be able to clamp the number of repetitions when
using the repeat() function, taking precautions about excessive memory
usage.

The implemented max repetitions is 10K.

Test: fast/css-grid-layout/grid-element-repeat-max-repetitions.html

* css/CSSParser.cpp:
(WebCore::CSSParser::parseGridTrackRepeatFunction):

LayoutTests:
Test to ensure the number of repetitions used in the repeat() function
is clamped to 10K.

* fast/css-grid-layout/grid-element-repeat-max-repetitions-expected.txt: Added.
* fast/css-grid-layout/grid-element-repeat-max-repetitions.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r167964.
commit-queue@webkit.org [Thu, 1 May 2014 17:26:24 +0000 (17:26 +0000)]
Unreviewed, rolling out r167964.
https://bugs.webkit.org/show_bug.cgi?id=132431

Memory improvements should not regress memory usage (Requested
by olliej on #webkit).

Reverted changeset:

"Don't hold on to parameter BindingNodes forever"
https://bugs.webkit.org/show_bug.cgi?id=132360
http://trac.webkit.org/changeset/167964

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agofast/multicol/fixed-stack.html failing since introduction.
ap@apple.com [Thu, 1 May 2014 16:42:38 +0000 (16:42 +0000)]
fast/multicol/fixed-stack.html failing since introduction.
https://bugs.webkit.org/show_bug.cgi?id=132421

* TestExpectations: Changed expectation from Skip to ImageOnyFailure

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix trivial debug-only race-that-crashes in CallLinkStatus and explain why the remain...
fpizlo@apple.com [Thu, 1 May 2014 15:48:05 +0000 (15:48 +0000)]
Fix trivial debug-only race-that-crashes in CallLinkStatus and explain why the remaining races are totally awesome
https://bugs.webkit.org/show_bug.cgi?id=132427

Reviewed by Mark Hahnenberg.

* bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[MSE] Seeking between two buffered ranges enquues incorrect buffers.
jer.noble@apple.com [Thu, 1 May 2014 15:43:13 +0000 (15:43 +0000)]
[MSE] Seeking between two buffered ranges enquues incorrect buffers.
https://bugs.webkit.org/show_bug.cgi?id=132416

Reviewed by Eric Carlson.

std::equal_range(begin, end, value) will return an empty range if equal values cannot
be found. But the range is not necessarily [end, end).  It may be some other value n,
such that the empty range is [n, n). Check to see if the returned range is empty in
findSampleContainingPresentationTime() and its reverse version, and if so, explicitly
return presentationEnd() or reversePresentationEnd() respectively.

Drive-by fix: make the comparator functions take const& arguments to minimize object
creation.

* Modules/mediasource/SampleMap.cpp:
(WebCore::SampleIsLessThanMediaTimeComparator::operator()):
(WebCore::SampleIsGreaterThanMediaTimeComparator::operator()):
(WebCore::SampleMap::findSampleContainingPresentationTime):
(WebCore::SampleMap::reverseFindSampleContainingPresentationTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Unreviewed GTK gardening.
commit-queue@webkit.org [Thu, 1 May 2014 15:34:54 +0000 (15:34 +0000)]
[GTK] Unreviewed GTK gardening.
Rebaseline affected tests by the new multi-column mode that was
enabled on r168046, and later modified on r168076 and r168088.

Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-05-01

* platform/gtk/TestExpectations: Include two new flaky tests after
the new multi-colum mode and remove expectations for the ones that
now pass.

* platform/gtk/css3/unicode-bidi-isolate-basic-expected.txt:
* platform/gtk/fast/block/float/float-not-removed-from-next-sibling4-expected.png:
* platform/gtk/fast/block/float/float-not-removed-from-next-sibling4-expected.txt:
* platform/gtk/fast/borders/border-antialiasing-expected.txt:
* platform/gtk/fast/line-grid/line-grid-inside-columns-expected.txt:
* platform/gtk/fast/line-grid/line-grid-into-columns-expected.txt:
* platform/gtk/fast/multicol/block-axis-horizontal-bt-expected.txt:
* platform/gtk/fast/multicol/block-axis-horizontal-tb-expected.txt:
* platform/gtk/fast/multicol/block-axis-vertical-lr-expected.txt:
* platform/gtk/fast/multicol/block-axis-vertical-rl-expected.txt:
* platform/gtk/fast/multicol/border-padding-pagination-expected.png:
* platform/gtk/fast/multicol/border-padding-pagination-expected.txt:
* platform/gtk/fast/multicol/client-rects-expected.png:
* platform/gtk/fast/multicol/client-rects-expected.txt:
* platform/gtk/fast/multicol/client-rects-spanners-complex-expected.txt: Added.
* platform/gtk/fast/multicol/client-rects-spanners-expected.txt: Added.
* platform/gtk/fast/multicol/column-break-with-balancing-expected.txt:
* platform/gtk/fast/multicol/column-count-with-rules-expected.txt:
* platform/gtk/fast/multicol/column-rules-expected.png:
* platform/gtk/fast/multicol/column-rules-expected.txt:
* platform/gtk/fast/multicol/column-rules-stacking-expected.png:
* platform/gtk/fast/multicol/column-rules-stacking-expected.txt:
* platform/gtk/fast/multicol/columns-shorthand-parsing-expected.txt:
* platform/gtk/fast/multicol/float-avoidance-expected.txt:
* platform/gtk/fast/multicol/float-multicol-expected.png:
* platform/gtk/fast/multicol/float-multicol-expected.txt:
* platform/gtk/fast/multicol/float-paginate-complex-expected.txt:
* platform/gtk/fast/multicol/float-paginate-empty-lines-expected.txt:
* platform/gtk/fast/multicol/float-paginate-expected.txt:
* platform/gtk/fast/multicol/layers-in-multicol-expected.txt:
* platform/gtk/fast/multicol/layers-split-across-columns-expected.txt:
* platform/gtk/fast/multicol/margin-collapse-expected.txt:
* platform/gtk/fast/multicol/max-height-columns-block-expected.png:
* platform/gtk/fast/multicol/max-height-columns-block-expected.txt:
* platform/gtk/fast/multicol/nested-columns-expected.png:
* platform/gtk/fast/multicol/nested-columns-expected.txt:
* platform/gtk/fast/multicol/newmulticol/client-rects-expected.png: Added.
* platform/gtk/fast/multicol/newmulticol/client-rects-expected.txt:
* platform/gtk/fast/multicol/overflow-across-columns-expected.txt:
* platform/gtk/fast/multicol/overflow-across-columns-percent-height-expected.png:
* platform/gtk/fast/multicol/overflow-across-columns-percent-height-expected.txt:
* platform/gtk/fast/multicol/overflow-unsplittable-expected.png:
* platform/gtk/fast/multicol/overflow-unsplittable-expected.txt:
* platform/gtk/fast/multicol/paginate-block-replaced-expected.txt:
* platform/gtk/fast/multicol/pagination/BottomToTop-bt-expected.png: Added.
* platform/gtk/fast/multicol/pagination/BottomToTop-bt-expected.txt:
* platform/gtk/fast/multicol/pagination/BottomToTop-lr-expected.png: Added.
* platform/gtk/fast/multicol/pagination/BottomToTop-lr-expected.txt:
* platform/gtk/fast/multicol/pagination/BottomToTop-rl-expected.png: Added.
* platform/gtk/fast/multicol/pagination/BottomToTop-rl-expected.txt:
* platform/gtk/fast/multicol/pagination/BottomToTop-tb-expected.png: Added.
* platform/gtk/fast/multicol/pagination/BottomToTop-tb-expected.txt:
* platform/gtk/fast/multicol/pagination/LeftToRight-bt-expected.png: Added.
* platform/gtk/fast/multicol/pagination/LeftToRight-bt-expected.txt:
* platform/gtk/fast/multicol/pagination/LeftToRight-lr-expected.png: Added.
* platform/gtk/fast/multicol/pagination/LeftToRight-lr-expected.txt:
* platform/gtk/fast/multicol/pagination/LeftToRight-rl-expected.png: Added.
* platform/gtk/fast/multicol/pagination/LeftToRight-rl-expected.txt:
* platform/gtk/fast/multicol/pagination/LeftToRight-tb-expected.png: Added.
* platform/gtk/fast/multicol/pagination/LeftToRight-tb-expected.txt:
* platform/gtk/fast/multicol/pagination/RightToLeft-bt-expected.png: Added.
* platform/gtk/fast/multicol/pagination/RightToLeft-bt-expected.txt:
* platform/gtk/fast/multicol/pagination/RightToLeft-lr-expected.png: Added.
* platform/gtk/fast/multicol/pagination/RightToLeft-lr-expected.txt:
* platform/gtk/fast/multicol/pagination/RightToLeft-rl-expected.png: Added.
* platform/gtk/fast/multicol/pagination/RightToLeft-rl-expected.txt:
* platform/gtk/fast/multicol/pagination/RightToLeft-tb-expected.png: Added.
* platform/gtk/fast/multicol/pagination/RightToLeft-tb-expected.txt:
* platform/gtk/fast/multicol/pagination/TopToBottom-bt-expected.png: Added.
* platform/gtk/fast/multicol/pagination/TopToBottom-bt-expected.txt:
* platform/gtk/fast/multicol/pagination/TopToBottom-lr-expected.png: Added.
* platform/gtk/fast/multicol/pagination/TopToBottom-lr-expected.txt:
* platform/gtk/fast/multicol/pagination/TopToBottom-rl-expected.png: Added.
* platform/gtk/fast/multicol/pagination/TopToBottom-rl-expected.txt:
* platform/gtk/fast/multicol/pagination/TopToBottom-tb-expected.png: Added.
* platform/gtk/fast/multicol/pagination/TopToBottom-tb-expected.txt:
* platform/gtk/fast/multicol/positioned-split-expected.txt:
* platform/gtk/fast/multicol/positive-leading-expected.png:
* platform/gtk/fast/multicol/positive-leading-expected.txt:
* platform/gtk/fast/multicol/scrolling-overflow-expected.txt:
* platform/gtk/fast/multicol/shadow-breaking-expected.png:
* platform/gtk/fast/multicol/shadow-breaking-expected.txt:
* platform/gtk/fast/multicol/shrink-to-column-height-for-pagination-expected.png: Added.
* platform/gtk/fast/multicol/shrink-to-column-height-for-pagination-expected.txt:
* platform/gtk/fast/multicol/single-line-expected.txt:
* platform/gtk/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
* platform/gtk/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
* platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.png:
* platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.txt:
* platform/gtk/fast/multicol/span/anonymous-style-inheritance-expected.txt:
* platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
* platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
* platform/gtk/fast/multicol/span/clone-flexbox-expected.txt:
* platform/gtk/fast/multicol/span/clone-summary-expected.txt:
* platform/gtk/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
* platform/gtk/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
* platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
* platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
* platform/gtk/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
* platform/gtk/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
* platform/gtk/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
* platform/gtk/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
* platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
* platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
* platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.png:
* platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt:
* platform/gtk/fast/multicol/span/span-as-nested-inline-block-child-expected.txt:
* platform/gtk/fast/multicol/span/span-margin-collapsing-expected.txt:
* platform/gtk/fast/multicol/table-margin-collapse-expected.txt:
* platform/gtk/fast/multicol/table-vertical-align-expected.txt:
* platform/gtk/fast/multicol/unsplittable-inline-block-expected.txt:
* platform/gtk/fast/multicol/vertical-lr/border-padding-pagination-expected.png:
* platform/gtk/fast/multicol/vertical-lr/border-padding-pagination-expected.txt:
* platform/gtk/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt:
* platform/gtk/fast/multicol/vertical-lr/column-count-with-rules-expected.txt:
* platform/gtk/fast/multicol/vertical-lr/column-rules-expected.png:
* platform/gtk/fast/multicol/vertical-lr/column-rules-expected.txt:
* platform/gtk/fast/multicol/vertical-lr/float-avoidance-expected.txt:
* platform/gtk/fast/multicol/vertical-lr/float-multicol-expected.txt:
* platform/gtk/fast/multicol/vertical-lr/float-paginate-complex-expected.txt:
* platform/gtk/fast/multicol/vertical-lr/float-paginate-expected.txt:
* platform/gtk/fast/multicol/vertical-lr/nested-columns-expected.png:
* platform/gtk/fast/multicol/vertical-lr/nested-columns-expected.txt:
* platform/gtk/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt:
* platform/gtk/fast/multicol/vertical-rl/border-padding-pagination-expected.png:
* platform/gtk/fast/multicol/vertical-rl/border-padding-pagination-expected.txt:
* platform/gtk/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
* platform/gtk/fast/multicol/vertical-rl/column-count-with-rules-expected.txt:
* platform/gtk/fast/multicol/vertical-rl/column-rules-expected.png:
* platform/gtk/fast/multicol/vertical-rl/column-rules-expected.txt:
* platform/gtk/fast/multicol/vertical-rl/float-avoidance-expected.txt:
* platform/gtk/fast/multicol/vertical-rl/float-multicol-expected.txt:
* platform/gtk/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:
* platform/gtk/fast/multicol/vertical-rl/float-paginate-expected.txt:
* platform/gtk/fast/multicol/vertical-rl/nested-columns-expected.png:
* platform/gtk/fast/multicol/vertical-rl/nested-columns-expected.txt:
* platform/gtk/fast/multicol/vertical-rl/rule-style-expected.txt:
* platform/gtk/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt:
* platform/gtk/fast/overflow/paged-x-div-expected.txt:
* platform/gtk/fast/overflow/paged-x-div-with-column-gap-expected.txt:
* platform/gtk/fast/overflow/paged-x-on-root-expected.txt:
* platform/gtk/fast/overflow/paged-x-with-column-gap-expected.txt:
* platform/gtk/fast/overflow/paged-y-div-expected.txt:
* platform/gtk/fast/overflow/paged-y-on-root-expected.txt:
* platform/gtk/fast/repaint/multicol-repaint-expected.png:
* platform/gtk/fast/repaint/multicol-repaint-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSubpixel rendering: Inline text selection painting should not snap to integral CSS...
zalan@apple.com [Thu, 1 May 2014 13:31:46 +0000 (13:31 +0000)]
Subpixel rendering: Inline text selection painting should not snap to integral CSS pixel position.
https://bugs.webkit.org/show_bug.cgi?id=132164

Reviewed by Darin Adler.

Inline text selection painting now snaps to device pixels. It uses the same rounding logic as
other painting functions.

Source/WebCore:
Test: fast/inline/hidpi-select-inline-on-subpixel-position.html

* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paintSelection):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintSelection):
(WebCore::alignSelectionRectToDevicePixels): Deleted.
* rendering/InlineTextBox.h:

LayoutTests:
* fast/inline/hidpi-select-inline-on-subpixel-position-expected.html: Added.
* fast/inline/hidpi-select-inline-on-subpixel-position.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] There are many warnings with software backend
ryuan.choi@samsung.com [Thu, 1 May 2014 12:42:32 +0000 (12:42 +0000)]
[EFL] There are many warnings with software backend
https://bugs.webkit.org/show_bug.cgi?id=132422

Reviewed by Gyuyoung Kim.

Source/WebCore:
ecore_evas_gl_x11_window_get should be called when only engine is opengl_x11.

This patch refactors not to call unnecessary API by checking engine type.
In addition, removed unnecessary isUsingEcoreX().

* platform/efl/EflScreenUtilities.cpp:
(WebCore::applyFallbackCursor):
(WebCore::getEcoreXWindow):
(WebCore::isUsingEcoreX): Deleted.
* platform/efl/EflScreenUtilities.h:

Source/WebKit/efl:
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(ewk_view_cursor_set):

Source/WebKit2:
* UIProcess/API/efl/EwkView.cpp:
(EwkView::updateCursor):
(EwkView::transformToScreen):

Source/WTF:
* wtf/efl/EflTypedefs.h: Added Ecore_X_Window typedef

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago<rdar://problem/16780403> REGRESSION: Plugin tests failing on Mac/WebKit1.
mitz@apple.com [Thu, 1 May 2014 09:57:43 +0000 (09:57 +0000)]
<rdar://problem/16780403> REGRESSION: Plugin tests failing on Mac/WebKit1.

* WebKit.xcodeproj/project.pbxproj: Keep the WebKitPluginHost.app symlink in
WebKit.framework for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCalling createPattern with a broken image must throw an invalidstate error
cabanier@adobe.com [Thu, 1 May 2014 08:33:47 +0000 (08:33 +0000)]
Calling createPattern with a broken image must throw an invalidstate error
https://bugs.webkit.org/show_bug.cgi?id=132407

Reviewed by Dirk Schulze.

Source/WebCore:
Per the WebIDL spec, passing non-finite parameter to a method that
takes doubles, should generate a type error.

Tests:
* canvas/philip/tests/2d.imageData.create2.nonfinite.html:
* fast/canvas/canvas-2d-imageData-create-nonfinite.html:

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createImageData):

LayoutTests:
* canvas/philip/tests/2d.imageData.create2.nonfinite.html:
* fast/canvas/canvas-2d-imageData-create-nonfinite-expected.txt:
* fast/canvas/resources/canvas-2d-imageData-create-nonfinite.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSkip fast/multicol/fixed-stack.html
akling@apple.com [Thu, 1 May 2014 07:17:50 +0000 (07:17 +0000)]
Skip fast/multicol/fixed-stack.html
<https://webkit.org/b/132421>

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r168046): [New Multicolumn] LeftToRight-rl.html (and all the other revers...
hyatt@apple.com [Thu, 1 May 2014 06:44:54 +0000 (06:44 +0000)]
REGRESSION (r168046): [New Multicolumn] LeftToRight-rl.html (and all the other reversed/block-axis pagination tests) fail
https://bugs.webkit.org/show_bug.cgi?id=132419

Reviewed by Andreas Kling.

Source/WebCore:
* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::initialBlockOffsetForPainting):
Don't flip here. The old code needed to do that, but the new code doesn't.

LayoutTests:
* platform/mac/fast/multicol/pagination/LeftToRight-rl-expected.png:
* platform/mac/fast/multicol/pagination/TopToBottom-bt-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoVersioning.
matthew_hanson@apple.com [Thu, 1 May 2014 06:38:12 +0000 (06:38 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRoll out fix for https://bugs.webkit.org/show_bug.cgi?id=131637:
ap@apple.com [Thu, 1 May 2014 05:49:09 +0000 (05:49 +0000)]
Roll out fix for https://bugs.webkit.org/show_bug.cgi?id=131637:
Clean up unnecessary methods in the BackForwardClient interface

It broke a regression test and an API test.

Source/WebCore:
* WebCore.exp.in:
* history/BackForwardClient.h:
(WebCore::BackForwardClient::backItem):
(WebCore::BackForwardClient::currentItem):
(WebCore::BackForwardClient::forwardItem):
* history/BackForwardController.cpp:
(WebCore::BackForwardController::BackForwardController):
* history/BackForwardController.h:
(WebCore::BackForwardController::client):
* history/BackForwardList.cpp:
(WebCore::BackForwardList::BackForwardList):
(WebCore::BackForwardList::close):
* history/BackForwardList.h:
(WebCore::BackForwardList::create):
(WebCore::BackForwardList::page):
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::PageClients::PageClients):
* page/Page.h:

Source/WebKit/efl:
* ewk/ewk_history.cpp:
(ewk_history_clear):
(ewk_history_new):
(ewk_history_free):
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(ewk_view_history_enable_get):
(ewk_view_history_enable_set):
(ewk_view_history_get):

Source/WebKit/mac:
* History/WebBackForwardList.mm:
(-[WebBackForwardList initWithBackForwardList:]):
(-[WebBackForwardList init]):
(-[WebBackForwardList dealloc]):
(-[WebBackForwardList finalize]):
(-[WebBackForwardList setPageCacheSize:]):
(-[WebBackForwardList pageCacheSize]):
* History/WebBackForwardListInternal.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::canCachePage):
* WebView/WebFrameView.mm:
(-[WebFrameView keyDown:keyDown:]):
* WebView/WebView.mm:
(-[WebView _loadBackForwardListFromOtherView:]):
(-[WebView initWithCoder:]):
(-[WebView encodeWithCoder:]):
(-[WebView backForwardList]):
(-[WebView setMaintainsBackForwardList:]):

Source/WebKit/win:
* WebBackForwardList.cpp:
(WebBackForwardList::WebBackForwardList):
(WebBackForwardList::~WebBackForwardList):
(WebBackForwardList::createInstance):
* WebBackForwardList.h:
* WebView.cpp:
(WebView::backForwardList):
(WebView::canGoBack):
(WebView::canGoForward):
(WebView::loadBackForwardListFromOtherView):

Source/WebKit2:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/InjectedBundleBackForwardList.cpp:
(WebKit::InjectedBundleBackForwardList::clear):
* WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::WebBackForwardListProxy::WebBackForwardListProxy):
(WebKit::WebBackForwardListProxy::addItem):
(WebKit::WebBackForwardListProxy::goToItem):
(WebKit::WebBackForwardListProxy::itemAtIndex):
(WebKit::WebBackForwardListProxy::backListCount):
(WebKit::WebBackForwardListProxy::forwardListCount):
(WebKit::WebBackForwardListProxy::close):
(WebKit::WebBackForwardListProxy::clear):
* WebProcess/WebPage/WebBackForwardListProxy.h:
(WebKit::WebBackForwardListProxy::create):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
* WebProcess/WebPage/ios/WebBackForwardListProxyIOS.mm: Copied from Source/WebKit2/WebProcess/WebPage/ios/WebBackForwardListProxyIOS.mm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoOnly reveal selection service UI after a short delay.
beidson@apple.com [Thu, 1 May 2014 04:48:35 +0000 (04:48 +0000)]
Only reveal selection service UI after a short delay.
<rdar://problem/16777346> and https://bugs.webkit.org/show_bug.cgi?id=132418

Reviewed by Sam Weinig.

* WebProcess/WebPage/SelectionOverlayController.cpp:
(WebKit::SelectionOverlayController::SelectionOverlayController):
(WebKit::SelectionOverlayController::destroyOverlay): Also stop the hover timer.
(WebKit::SelectionOverlayController::selectionRectsDidChange): Mark the highlight as dirty.
(WebKit::SelectionOverlayController::hoverTimerFired): If the mouse is still over the highlight,
  set the visible flag and setNeedsDisplay().
* WebProcess/WebPage/SelectionOverlayController.h:

* WebProcess/WebPage/mac/SelectionOverlayControllerMac.mm:
(WebKit::SelectionOverlayController::drawRect): Recreate the highlight if it exists but
  is marked as dirty. After doing that, possibly reset the hover timer.
  Also, only performing the actual drawing if the visible flag is set.
(WebKit::SelectionOverlayController::mouseEvent): If the mouse moves on or off the highlight,
  start or stop the hover timer accordingly.
(WebKit::SelectionOverlayController::mouseHoverStateChanged): Handle starting/stopping the
  hover timer.
(WebKit::SelectionOverlayController::clearHighlight): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoKernel sysctl interface hw.activecpu don't exists on Linux.
commit-queue@webkit.org [Thu, 1 May 2014 04:20:16 +0000 (04:20 +0000)]
Kernel sysctl interface hw.activecpu don't exists on Linux.
https://bugs.webkit.org/show_bug.cgi?id=132286

Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-04-30
Reviewed by Filip Pizlo.

* Scripts/run-jsc-stress-tests: Redirect stderr to null when
calling sysctl over hw.activecpu

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMore iOS build fixing. MediaPlayerPrivateIOS is defunct and can be removed.
simon.fraser@apple.com [Thu, 1 May 2014 02:46:07 +0000 (02:46 +0000)]
More iOS build fixing. MediaPlayerPrivateIOS is defunct and can be removed.
Fix some build errors in other media files.

* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/MediaPlayer.cpp:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
* platform/graphics/ios/MediaPlayerPrivateIOS.h: Removed.
* platform/graphics/ios/MediaPlayerPrivateIOS.mm: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix the iOS build, which no longer needs these calls
simon.fraser@apple.com [Thu, 1 May 2014 02:46:03 +0000 (02:46 +0000)]
Fix the iOS build, which no longer needs these calls
to enter/exitFullscreen.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS][WK2] Animated resize incorrectly assumes the layout width is the same as the...
benjamin@webkit.org [Thu, 1 May 2014 02:44:52 +0000 (02:44 +0000)]
[iOS][WK2] Animated resize incorrectly assumes the layout width is the same as the view width
https://bugs.webkit.org/show_bug.cgi?id=132373
<rdar://problem/16762178>

Reviewed by Tim Horton.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
Fix a couple of bugs when the left/right obscured insets change, and/or when the minimum layout size
is narrower than the view itself.

In order:
-We need to perfom and update if the insets change since the unobscuredRect will also change.
-The min/max zoom scale should be based on the minimum layout size, that's the definition of minimum layout size
 in scrollview coordinate :)
-The old web view width in content coordinate could be narrower than the old view bounds if there are left or right
 insets.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove ENABLE_PLUGIN_PROXY_FOR_VIDEO
simon.fraser@apple.com [Thu, 1 May 2014 02:19:33 +0000 (02:19 +0000)]
Remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
https://bugs.webkit.org/show_bug.cgi?id=132396

Reviewed by Eric Carlson.

Source/JavaScriptCore:

Remove ENABLE_PLUGIN_PROXY_FOR_VIDEO and related code.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Remove ENABLE_PLUGIN_PROXY_FOR_VIDEO and related code.

* Configurations/FeatureDefines.xcconfig:
* WebCore.exp.in:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
* editing/TextIterator.cpp:
(WebCore::isRendererReplacedElement):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::parseAttribute):
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::setNeedWidgetUpdate): Deleted.
* html/HTMLMediaSession.cpp:
(WebCore::HTMLMediaSession::showPlaybackTargetPicker):
(WebCore::HTMLMediaSession::hasWirelessPlaybackTargets):
(WebCore::HTMLMediaSession::setHasPlaybackTargetAvailabilityListeners):
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::createElementRenderer):
(WebCore::HTMLVideoElement::didAttachRenderers):
(WebCore::HTMLVideoElement::parseAttribute):
(WebCore::HTMLVideoElement::setDisplayMode):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateSizes):
* loader/EmptyClients.cpp:
(WebCore::EmptyFrameLoaderClient::createMediaPlayerProxyPlugin): Deleted.
* loader/EmptyClients.h:
* loader/FrameLoaderClient.h:
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadPlugin):
(WebCore::SubframeLoader::loadMediaPlayerProxyPlugin): Deleted.
* loader/SubframeLoader.h:
* page/FrameView.cpp:
(WebCore::FrameView::updateEmbeddedObject):
* page/Settings.cpp:
(WebCore::Settings::setVideoPluginProxyEnabled): Deleted.
* page/Settings.h:
(WebCore::Settings::isVideoPluginProxyEnabled): Deleted.
* platform/graphics/GraphicsLayerClient.h:
(WebCore::GraphicsLayerClient::mediaLayerMustBeUpdatedOnMainThread): Deleted.
* platform/graphics/MediaPlayer.cpp:
(WebCore::installedMediaEngines):
(WebCore::MediaPlayer::MediaPlayer):
(WebCore::MediaPlayer::loadWithNextMediaEngine):
(WebCore::NullMediaPlayerPrivate::deliverNotification): Deleted.
(WebCore::NullMediaPlayerPrivate::setMediaPlayerProxy): Deleted.
(WebCore::NullMediaPlayerPrivate::setControls): Deleted.
(WebCore::MediaPlayer::deliverNotification): Deleted.
(WebCore::MediaPlayer::setMediaPlayerProxy): Deleted.
(WebCore::MediaPlayer::setControls): Deleted.
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::deliverNotification): Deleted.
(WebCore::MediaPlayerPrivateInterface::setMediaPlayerProxy): Deleted.
(WebCore::MediaPlayerPrivateInterface::setControls): Deleted.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::updateContentsRects):
(WebCore::GraphicsLayerCA::mediaLayerMustBeUpdatedOnMainThread): Deleted.
* platform/graphics/ca/GraphicsLayerCA.h:
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::canHaveChildren):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::mediaLayerMustBeUpdatedOnMainThread): Deleted.
* rendering/RenderLayerBacking.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForVideo):

Source/WebKit/mac:

Remove ENABLE_PLUGIN_PROXY_FOR_VIDEO and related code.

* Configurations/FeatureDefines.xcconfig:
* Plugins/WebPluginContainerPrivate.h:
* Plugins/WebPluginController.h:
* Plugins/WebPluginController.mm:
(-[WebPluginController dealloc]):
(-[WebPluginController plugInsAreRunning]):
(-[WebPluginController stopAllPlugins]):
(-[WebPluginController stopPluginsForPageCache]):
(-[WebPluginController restorePluginsFromCache]):
(-[WebPluginController addPlugin:]):
(-[WebPluginController destroyPlugin:]):
(-[WebPluginController destroyAllPlugins]):
(-[NSView isMediaPlugInProxyView]): Deleted.
(-[NSView setIsMediaPlugInProxyView:]): Deleted.
(-[WebPluginController mediaPlugInProxyViewCreated:]): Deleted.
(+[WebPluginController pluginViewHidden:]): Deleted.
(mediaProxyClient): Deleted.
(-[WebPluginController _webPluginContainerSetMediaPlayerProxy:forElement:]): Deleted.
(-[WebPluginController _webPluginContainerPostMediaPlayerNotification:forElement:]): Deleted.
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(pluginView):
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
(-[WebView _videoProxyPluginForMIMEType:]): Deleted.
* WebView/WebViewInternal.h:

Source/WebKit2:

Remove ENABLE_PLUGIN_PROXY_FOR_VIDEO and related code.

* Configurations/FeatureDefines.xcconfig:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createMediaPlayerProxyPlugin): Deleted.
(WebKit::WebFrameLoaderClient::hideMediaPlayerProxyPlugin): Deleted.
(WebKit::WebFrameLoaderClient::showMediaPlayerProxyPlugin): Deleted.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

Source/WTF:

Remove ENABLE_PLUGIN_PROXY_FOR_VIDEO and related code.

* wtf/FeatureDefines.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS WK2] Some accerated overflow-scroll doesn't scroll correctly
simon.fraser@apple.com [Thu, 1 May 2014 02:15:17 +0000 (02:15 +0000)]
[iOS WK2] Some accerated overflow-scroll doesn't scroll correctly
https://bugs.webkit.org/show_bug.cgi?id=132375

Reviewed by Tim Horton.

Source/WebCore:
We set the size of the scrolling layer (which becomes the bounds of
the UIScrollView) to a non-pixel-snapped padding box size, but the
size of the contents layer is an integral-snapped scroll size.
This would result in a fractional difference between the two, which
makes us thing that the element is scrollable when it really is not.

Fix by setting the size of the scroll layer to pixel snapped client size,
which is what we also use for scrollability computation.

Added some FIXMEs in code that requires pixel snapping.

Also use #if PLATFORM(IOS)/#else to bracket some code that never runs on iOS
but tries to do something similar to iOS-only code.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

LayoutTests:
New test that dumps compositing layers on iOS so we can see the sizes of the
scroll layers that get created.

* compositing/overflow/subpixel-overflow-expected.txt: Added.
* compositing/overflow/subpixel-overflow.html: Added.
* platform/ios-sim/compositing/overflow/subpixel-overflow-expected.txt: Added.
* platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
This is a progression; the old code failed to take the scrollbar width into
account, and the new code does.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRebaseline compositing/overflow tests for iOS.
simon.fraser@apple.com [Thu, 1 May 2014 02:15:15 +0000 (02:15 +0000)]
Rebaseline compositing/overflow tests for iOS.

* platform/ios-sim/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
* platform/ios-sim/compositing/overflow/composited-scrolling-paint-phases-expected.txt:
* platform/ios-sim/compositing/overflow/content-gains-scrollbars-expected.txt:
* platform/ios-sim/compositing/overflow/fixed-position-ancestor-clip-expected.txt:
* platform/ios-sim/compositing/overflow/overflow-scroll-expected.txt:
* platform/ios-sim/compositing/overflow/overflow-scrollbar-layers-expected.txt:
* platform/ios-sim/compositing/overflow/remove-overflow-crash2-expected.txt:
* platform/ios-sim/compositing/overflow/scrollbar-painting-expected.txt:
* platform/ios-sim/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt:
* platform/ios-sim/compositing/overflow/scrolling-without-painting-expected.txt:
* platform/ios-sim/compositing/overflow/textarea-scroll-touch-expected.txt:
* platform/ios-sim/compositing/overflow/updating-scrolling-content-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r168046): [New Multicolumn] Painting order is wrong for columns and fixed...
hyatt@apple.com [Thu, 1 May 2014 02:12:42 +0000 (02:12 +0000)]
REGRESSION (r168046): [New Multicolumn] Painting order is wrong for columns and fixed positioned elements
https://bugs.webkit.org/show_bug.cgi?id=132377

Reviewed by Simon Fraser.

Source/WebCore:
Added fast/multicol/fixed-stack.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldBeSelfPaintingLayer):
(WebCore::RenderLayer::shouldBeNormalFlowOnly):
Change the flow thread layer for multicolumn layout to be normal flow only and to
stay self-painting. This has the effect of keeping the flow thread layer grouped
with the enclosing multicolumn layer, and this keeps the paint order correct when
compositing kicks in (or when something would otherwise try to get between the
two layers).

LayoutTests:
* compositing/columns/composited-nested-columns-expected.txt:
* fast/multicol/fixed-stack-expected.html: Added.
* fast/multicol/fixed-stack.html: Added.
* fast/multicol/flipped-blocks-border-after-expected.txt:
* fast/multicol/progression-reverse-expected.txt:
* fast/multicol/single-line-expected.txt:
* fast/multicol/vertical-lr/rules-with-border-before-expected.txt:
* fast/multicol/vertical-rl/rule-style-expected.txt:
* fast/multicol/vertical-rl/rules-with-border-before-expected.txt:
* platform/mac/fast/multicol/client-rects-expected.txt:
* platform/mac/fast/multicol/client-rects-spanners-complex-expected.txt:
* platform/mac/fast/multicol/client-rects-spanners-expected.txt:
* platform/mac/fast/multicol/column-break-with-balancing-expected.txt:
* platform/mac/fast/multicol/column-count-with-rules-expected.txt:
* platform/mac/fast/multicol/float-paginate-complex-expected.txt:
* platform/mac/fast/multicol/layers-in-multicol-expected.txt:
* platform/mac/fast/multicol/layers-split-across-columns-expected.txt:
* platform/mac/fast/multicol/newmulticol/client-rects-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
* platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
* platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
* platform/mac/fast/multicol/span/span-margin-collapsing-expected.txt:
* platform/mac/fast/multicol/table-vertical-align-expected.txt:
* platform/mac/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt:
* platform/mac/fast/multicol/vertical-lr/column-count-with-rules-expected.txt:
* platform/mac/fast/multicol/vertical-lr/float-paginate-complex-expected.txt:
* platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
* platform/mac/fast/multicol/vertical-rl/column-count-with-rules-expected.txt:
* platform/mac/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] do not pause video when entering background while playing to external device
eric.carlson@apple.com [Thu, 1 May 2014 01:47:20 +0000 (01:47 +0000)]
[iOS] do not pause video when entering background while playing to external device
https://bugs.webkit.org/show_bug.cgi?id=132374

Reviewed by Jer Noble.

Source/WebCore:
* WebCore.exp.in: Update beginInterruption signature.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::canOverrideBackgroundPlaybackRestriction): New, return true when
    playing to external device.
* html/HTMLMediaElement.h:

* platform/audio/MediaSession.cpp:
(WebCore::MediaSession::beginInterruption): Add interruption type to beginInterruption.
* platform/audio/MediaSession.h:

* platform/audio/MediaSessionManager.cpp:
(WebCore::MediaSessionManager::beginInterruption): Ditto.
(WebCore::MediaSessionManager::applicationWillEnterBackground): Ditto.
(WebCore::MediaSessionManager::systemWillSleep): Ditto.
* platform/audio/MediaSessionManager.h:

* platform/audio/ios/AudioDestinationIOS.h:
* platform/audio/ios/MediaSessionManagerIOS.mm:
(-[WebMediaSessionHelper interruption:]): Ditto.

* platform/audio/mac/AudioDestinationMac.h: Make most methods private. Add
    canOverrideBackgroundPlaybackRestriction. Add missing overrides.
* testing/Internals.cpp:
(WebCore::Internals::beginMediaSessionInterruption): Pass interruption type.

Source/webkit:
* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoIf there are no services available, do not show the service controls UI
beidson@apple.com [Thu, 1 May 2014 01:18:52 +0000 (01:18 +0000)]
If there are no services available, do not show the service controls UI
<rdar://problem/16735665> and https://bugs.webkit.org/show_bug.cgi?id=132410

Reviewed by Tim Horton.

Add a lightweight class that lazily polls the appropriate APIs for whether or not appropriate services
are installed and usable on the system:
* UIProcess/mac/ServicesController.h: Added.
(WebKit::ServicesController::imageServicesExist):
(WebKit::ServicesController::selectionServicesExist):
* UIProcess/mac/ServicesController.mm: Added.
(WebKit::ServicesController::shared):
(WebKit::ServicesController::ServicesController):
(WebKit::ServicesController::refreshExistingServices):
(WebKit::ServicesController::refreshExistingServicesTimerFired):

Add "image services exist" and "selection services exist" parameters:
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:

* UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::refreshExistingServices): Called when the context menu proxy realizes that
  services no longer exist.
* UIProcess/WebContext.h:

Each WebProcess hangs on to its own copy of the flags for whether or not the services exist:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::setEnabledServices):
* WebProcess/WebProcess.h:
(WebKit::WebProcess::imageServicesExist):
(WebKit::WebProcess::selectionServicesExist):

* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu): If the menu creation failed, the set of services
  on the system must have changed. So ask the WebContext to refresh them.

* WebProcess/WebPage/SelectionOverlayController.cpp:
(WebKit::SelectionOverlayController::selectionRectsDidChange): If services don't exist, don't create an
  overlay (and destroy any existing overlay!)

* WebProcess/WebPage/mac/SelectionOverlayControllerMac.mm:
(WebKit::SelectionOverlayController::drawRect): If services don't exist, don't draw, and destroy the overlay.

* WebProcess/WebProcess.messages.in:
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTry yet again to fix the build.
andersca@apple.com [Thu, 1 May 2014 01:04:52 +0000 (01:04 +0000)]
Try yet again to fix the build.

* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAnother build fix attempt.
andersca@apple.com [Thu, 1 May 2014 00:53:42 +0000 (00:53 +0000)]
Another build fix attempt.

* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTry to fix the iOS build.
andersca@apple.com [Thu, 1 May 2014 00:44:36 +0000 (00:44 +0000)]
Try to fix the iOS build.

* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agohttps://bugs.webkit.org/show_bug.cgi?id=132415
barraclough@apple.com [Thu, 1 May 2014 00:27:14 +0000 (00:27 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=132415
Fix snapshotting on WebKit2

Reviewed by Geoff Garen

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):
    - Use a VisibilityToken to keep the process runnable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix PageVisibility on iOS
barraclough@apple.com [Thu, 1 May 2014 00:23:52 +0000 (00:23 +0000)]
Fix PageVisibility on iOS
https://bugs.webkit.org/show_bug.cgi?id=132393

Rubber stamped by Tim Horton

* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::isViewWindowActive):
(WebKit::PageClientImpl::isViewFocused):
(WebKit::PageClientImpl::isViewVisible):
(WebKit::PageClientImpl::isViewVisibleOrOccluded):
(WebKit::PageClientImpl::isVisuallyIdle):
    - m_contentView -> m_webView

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r167879 and r167942.
rego@igalia.com [Thu, 1 May 2014 00:12:59 +0000 (00:12 +0000)]
Unreviewed, rolling out r167879 and r167942.
https://bugs.webkit.org/show_bug.cgi?id=132408

OrderIterator changes caused regressions in flexbox (Requested
by rego on #webkit).

We're keeping the new layout test introduced in r167942
(fast/flexbox/order-iterator-crash.html) to avoid similar
regressions in the future.

Reverted changesets:

"OrderIterator refactoring to avoid extra loops"
https://bugs.webkit.org/show_bug.cgi?id=119061
http://trac.webkit.org/changeset/167879

"REGRESSION (r167879): Heap-use-after-free in
WebCore::RenderFlexibleBox"
https://bugs.webkit.org/show_bug.cgi?id=132337
http://trac.webkit.org/changeset/167942

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCursor gets thinner on empty lines.
enrica@apple.com [Thu, 1 May 2014 00:08:51 +0000 (00:08 +0000)]
Cursor gets thinner on empty lines.
https://bugs.webkit.org/show_bug.cgi?id=132411
<rdar://problem/15994556>

Reviewed by Benjamin Poulain.

RenderLineBreak::localCaretRect should not define
locally the constant caretWidth, but use the one from
RenderObject.h which knows about the differences between
iOS and the other platforms.

* rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::localCaretRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMake sure the "All" targets build WebKitLegacy, rather than WebKit.
simon.fraser@apple.com [Wed, 30 Apr 2014 23:58:49 +0000 (23:58 +0000)]
Make sure the "All" targets build WebKitLegacy, rather than WebKit.

Reviewed by Dan Bernstein/Anders Carlsson.

* WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme:
* WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS][WK2] Add a SPI to exclude the extended background from some areas of WKWebView
benjamin@webkit.org [Wed, 30 Apr 2014 23:45:27 +0000 (23:45 +0000)]
[iOS][WK2] Add a SPI to exclude the extended background from some areas of WKWebView
https://bugs.webkit.org/show_bug.cgi?id=132406
<rdar://problem/16762197>

Reviewed by Beth Dakin.

Move the extended background to a separate layer bellow the UIScrollView.

The geometry of that layer is then changed based on ExtendedBackgroundExclusionInsets
as needed.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
(-[WKWebView _updateScrollViewBackground]):
(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _setExtendedBackgroundExclusionInsets:]):
(-[WKWebView _extendedBackgroundExclusionInsets]):
(-[WKWebView pageExtendedBackgroundColor]): Deleted.
* UIProcess/API/Cocoa/WKWebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAnother build fix attempt.
andersca@apple.com [Wed, 30 Apr 2014 23:32:23 +0000 (23:32 +0000)]
Another build fix attempt.

* WebKit.xcodeproj/project.pbxproj:
Remove headers if it seems like the WKWebViewPrivate header imports itself.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAnother build fix.
andersca@apple.com [Wed, 30 Apr 2014 23:21:07 +0000 (23:21 +0000)]
Another build fix.

* WebKit.xcodeproj/project.pbxproj:
Remove WK headers from WebKit.framework as well when WebKitLegacy WK headers are encountered.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GStreamer] Use GstMetaVideo
vjaquez@igalia.com [Wed, 30 Apr 2014 23:17:36 +0000 (23:17 +0000)]
[GStreamer] Use GstMetaVideo
https://bugs.webkit.org/show_bug.cgi?id=132247

Reviewed by Philippe Normand.

In WebKitVideoSink we announce the usage of GstMetaVideo, but we do
not use it when handling the video frames. This might break
some decoders and filters that rely on buffer's meta, rather
that in the caps structures.

This patch enables the use of GstMetaVideo through the GstVideoFrame
API. And it is used everywhere the buffer mapping is required.

Also this patch changes to nullptr where zeros were used.

Also, compile conditionally the video buffer conversion when it is
ARGB/BGRA, since it is only required for the Cairo backend.

No new tests, already covered by current tests.

* platform/graphics/gstreamer/GStreamerUtilities.cpp:
(WebCore::getVideoSizeAndFormatFromCaps): init the GstVideoInfo before
used and remove caps fixate check since it is done by
gst_video_info_from_caps().
* platform/graphics/gstreamer/ImageGStreamer.h:
* platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
(ImageGStreamer::ImageGStreamer): use GstVideoFrame for buffer mapping
and unmapping.
(ImageGStreamer::~ImageGStreamer): ditto.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture): ditto.
(WebCore::MediaPlayerPrivateGStreamerBase::currentVideoSinkCaps):
return nullptr if failed.
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkRender): rely on GstVideoInfo rather than on the
caps. Use GstVideoFrame for buffer mapping and unmapping. Add guards
for buffer transformation, since it's only used by Cairo.
(webkitVideoSinkDispose): remove glib version guards.
(webkitVideoSinkSetCaps): update the value of the private
GstVideoInfo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK][GStreamer] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
vjaquez@igalia.com [Wed, 30 Apr 2014 23:16:48 +0000 (23:16 +0000)]
[GTK][GStreamer] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=132390

Reviewed by Philippe Normand.

Since EFL port use GLib 2.38 and GTK+, 2.33.2, I assume it is OK
remove, in GTK+ and GST, the existing glib version guards.

Source/WebCore:
No new tests, already covered by current tests.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkDispose):
(webkitVideoSinkFinalize): Deleted.

Source/WTF:
This code was rollback from r149879 because Qt MIPS used it. But since
Qt is gone, it is safe to remove now.

* wtf/gobject/GRefPtr.cpp:
(WTF::refGPtr): Deleted.
(WTF::derefGPtr): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTry to fix the build.
andersca@apple.com [Wed, 30 Apr 2014 23:07:37 +0000 (23:07 +0000)]
Try to fix the build.

* WebKit.xcodeproj/project.pbxproj:
Remove old WK forwarding headers from WebKitLegacy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoLet Xcode have its way with the WebKit workspace.
simon.fraser@apple.com [Wed, 30 Apr 2014 23:00:49 +0000 (23:00 +0000)]
Let Xcode have its way with the WebKit workspace.

* WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme:
* WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix build error when building for iOS simulator.
simon.fraser@apple.com [Wed, 30 Apr 2014 23:00:47 +0000 (23:00 +0000)]
Fix build error when building for iOS simulator.

* UIProcess/ios/ProcessAssertion.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUpdated ANGLE.
achristensen@apple.com [Wed, 30 Apr 2014 22:57:08 +0000 (22:57 +0000)]
Updated ANGLE.
https://bugs.webkit.org/show_bug.cgi?id=132367
<rdar://problem/16211451>

Reviewed by Dean Jackson.

Source/ThirdParty/ANGLE:
* ANGLE.plist:
Updated and xml encoded.
* ANGLE.xcodeproj/project.pbxproj:
Added needed new source files.
* changes.diff:
Added to keep track of differences between WebKit's copy of ANGLE and the master repository.

Updated ANGLE source files to e7a453a5bd76705ccb151117fa844846d4aa90af.  Long list of changes omitted.

Source/WebCore:
* CMakeLists.txt
Fixed ANGLE compiling with the update.
* platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):
Removed SH_MAP_LONG_VARIABLE_NAMES which is no longer defined in ANGLE.
See https://chromium.googlesource.com/angle/angle/+/3cdfcce86b38ef31a0afd71855887193a7924468
* platform/graphics/opengl/Extensions3DOpenGLES.h:
* platform/graphics/opengl/Extensions3DOpenGLES.cpp:
Updated type names from ANGLE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove Blob.slice() implementation into BlobRegistryImpl
ap@apple.com [Wed, 30 Apr 2014 22:52:30 +0000 (22:52 +0000)]
Move Blob.slice() implementation into BlobRegistryImpl
https://bugs.webkit.org/show_bug.cgi?id=132402

Reviewed by Anders Carlsson.

Source/WebCore:
Part or centralizing the responsibility for file size tracking.

* fileapi/Blob.cpp:
(WebCore::Blob::Blob):
(WebCore::Blob::slice): Deleted.
* fileapi/Blob.h:
(WebCore::Blob::slice):
* fileapi/ThreadableBlobRegistry.cpp:
(WebCore::ThreadableBlobRegistry::registerBlobURL):
(WebCore::ThreadableBlobRegistry::registerBlobURLForSlice):
(WebCore::registerBlobURLTask): Deleted.
(WebCore::registerBlobURLFromTask): Deleted.
* fileapi/ThreadableBlobRegistry.h:
* platform/network/BlobRegistry.h:
* platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::appendStorageItems):
(WebCore::BlobRegistryImpl::registerBlobURLForSlice):
(WebCore::BlobRegistryImpl::blobSize):
* platform/network/BlobRegistryImpl.h:

Source/WebKit2:
* NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
(WebKit::NetworkBlobRegistry::registerBlobURLForSlice):
* NetworkProcess/FileAPI/NetworkBlobRegistry.h:
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::registerBlobURLForSlice):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* WebProcess/FileAPI/BlobRegistryProxy.cpp:
(WebKit::BlobRegistryProxy::registerBlobURLForSlice):
* WebProcess/FileAPI/BlobRegistryProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoPhone number data detection UI is offset for iframes, pages with topContentInset
bdakin@apple.com [Wed, 30 Apr 2014 22:45:36 +0000 (22:45 +0000)]
Phone number data detection UI is offset for iframes, pages with topContentInset
https://bugs.webkit.org/show_bug.cgi?id=132372
-and corresponding-
<rdar://problem/16651235>

Reviewed by Tim Horton.

Make the overlay an OverlayType::Document, which will keep everything relative to
the main Document’s coordinates.
* WebProcess/WebPage/TelephoneNumberOverlayController.cpp:
(WebKit::TelephoneNumberOverlayController::createOverlayIfNeeded):

Make frames work by converting to the main  document’s coordinate space.
* WebProcess/WebPage/mac/TelephoneNumberOverlayControllerMac.mm:
(WebKit::TelephoneNumberOverlayController::drawRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed build fix after r168041.
bfulgham@apple.com [Wed, 30 Apr 2014 22:44:42 +0000 (22:44 +0000)]
Unreviewed build fix after r168041.

* WebCore.exp.in: Add missing iOS exports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoArgument flush formats should not be presumed to be JSValue since 'this' is weird
fpizlo@apple.com [Wed, 30 Apr 2014 22:22:11 +0000 (22:22 +0000)]
Argument flush formats should not be presumed to be JSValue since 'this' is weird
https://bugs.webkit.org/show_bug.cgi?id=132404

Reviewed by Michael Saboff.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCurrentBlock): Don't assume that arguments are flushed as JSValue. Use the logic for locals instead.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile): SetArgument "changes" the format because before this we wouldn't know we had arguments.
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile): Ditto.
* dfg/DFGValueSource.cpp:
(JSC::DFG::ValueSource::dumpInContext): Make this easier to dump.
* dfg/DFGValueSource.h:
(JSC::DFG::ValueSource::operator!): Make this easier to dump because Operands<T> uses T::operator!().
* ftl/FTLOSREntry.cpp:
(JSC::FTL::prepareOSREntry): This had a useful assertion for everything except 'this'.
* tests/stress/strict-to-this-int.js: Added.
(foo):
(Number.prototype.valueOf):
(test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed. Unnecessary explicit initialization of LayoutUnit from r167985.
roger_fong@apple.com [Wed, 30 Apr 2014 22:10:06 +0000 (22:10 +0000)]
Unreviewed. Unnecessary explicit initialization of LayoutUnit from r167985.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::determinePrimarySnapshottedPlugIn):
Darin points out that I can just use “/2” instead of “/LayoutUnit(2.0)”.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAlways-visible scrollbars continuously repaint after non-momentum scrollling
bdakin@apple.com [Wed, 30 Apr 2014 22:05:15 +0000 (22:05 +0000)]
Always-visible scrollbars continuously repaint after non-momentum scrollling
https://bugs.webkit.org/show_bug.cgi?id=132403
-and corresponding-
<rdar://problem/16553878>

Reviewed by Simon Fraser.

No longer universally opt into presentation value mode whenever the scroll
position changes on the scrolling thread. We really only want it for momentum
scrolls, and this will ensure that we always set it to NO once we have set it to
YES.
* page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::handleWheelEvent):
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):

Expose shouldUsePresentationValue.
* platform/mac/NSScrollerImpDetails.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoEnable snapshot tests on mac wk2.
roger_fong@apple.com [Wed, 30 Apr 2014 22:03:57 +0000 (22:03 +0000)]
Enable snapshot tests on mac wk2.
https://bugs.webkit.org/show_bug.cgi?id=131871.
Reviewed by Darin Adler.
* platform/mac-wk2/TestExpectations:
* platform/mac-wk2/plugins/snapshotting/autoplay-dominant-expected.txt:
* platform/mac-wk2/plugins/snapshotting/autoplay-plugin-blocked-by-image-expected.txt:
* platform/mac-wk2/plugins/snapshotting/autoplay-plugin-blocked-by-image-expected.txt:
* platform/mac-wk2/plugins/snapshotting/autoplay-similar-to-dominant-after-delay-expected.txt:
* platform/mac-wk2/plugins/snapshotting/autoplay-similar-to-dominant-expected.txt:
* platform/mac-wk2/plugins/snapshotting/quicktime-plugin-snapshotted-expected.txt:
* platform/mac-wk2/plugins/snapshotting/restart-expected.txt:
* platform/mac-wk2/plugins/snapshotting/set-plugin-size-to-tiny-expected.txt:
* platform/mac-wk2/plugins/snapshotting/simple-expected.txt:
* platform/mac-wk2/plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image-expected.txt:
* plugins/snapshotting/autoplay-dominant.html:
* plugins/snapshotting/autoplay-plugin-blocked-by-image.html:
* plugins/snapshotting/autoplay-plugin-mostly-blocked-by-image.html:
* plugins/snapshotting/autoplay-similar-to-dominant-after-delay.html:
* plugins/snapshotting/autoplay-similar-to-dominant.html:
* plugins/snapshotting/quicktime-plugin-snapshotted.html:
* plugins/snapshotting/restart.html:
* plugins/snapshotting/set-plugin-size-to-tiny.html:
* plugins/snapshotting/simple.html:
* plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit...
andersca@apple.com [Wed, 30 Apr 2014 22:02:19 +0000 (22:02 +0000)]
Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
https://bugs.webkit.org/show_bug.cgi?id=132399
<rdar://problem/15920046>

Reviewed by Dan Bernstein.

Source/WebCore:
Allow WebKitLegacy to link against WebCore.

* Configurations/WebCore.xcconfig:

Source/WebKit:
* WebKit.xcodeproj/project.pbxproj:
Add a new build target that builds the legacy WebKit API in WebKitLegacy.framework. This framework
is then re-exported by WebKit.framework, and its headers are copied to WebKit.framework. All the WebKitLegacy
headers are made private, and the MigrateHeadersFromWebKitLegacy.make Makefile will copy all the headers specified
in WEBKIT_PUBLIC_HEADERS to WebKit/Headers.

Source/WebKit/ios:
Import WebKitLegacy headers instead of WebKit headers.

* DefaultDelegates/WebDefaultFormDelegate.h:
* DefaultDelegates/WebDefaultFrameLoadDelegate.m:
* DefaultDelegates/WebDefaultResourceLoadDelegate.m:
* DefaultDelegates/WebDefaultUIKitDelegate.h:
* Misc/WebGeolocationProviderIOS.h:
* Misc/WebNSStringExtrasIPhone.h:
* WebCoreSupport/WebFrameIOS.h:
* WebCoreSupport/WebFrameIOS.mm:
* WebCoreSupport/WebFrameIPhone.h:
* WebCoreSupport/WebSelectionRect.h:
* WebCoreSupport/WebVisiblePosition.h:
* WebView/WebPDFViewIOS.h:
* WebView/WebPDFViewIOS.mm:
* WebView/WebPDFViewIPhone.h:
* WebView/WebPDFViewPlaceholder.h:
* WebView/WebPDFViewPlaceholder.mm:
* WebView/WebPlainWhiteView.h:
* WebView/WebUIKitDelegate.h:

Source/WebKit/mac:
* Carbon/CarbonUtils.h:
* Carbon/HIViewAdapter.h:
* Carbon/HIWebView.h:
Import WebKitLegacy headers instead of WebKit headers.

* Configurations/WebKit.xcconfig:
Move the definitions needed for building WebKitLegacy.framework to WebKitLegacy.xcconfig and
add the relevant definitions needed for re-exporting WebKitLegacy.framework.

* Configurations/WebKitLegacy.xcconfig:
Add definitions needed for building the "old" WebKit API as WebKitLegacy.framework.

* DOM/WebDOMOperations.h:
* DOM/WebDOMOperations.mm:
* DOM/WebDOMOperationsInternal.h:
* DOM/WebDOMOperationsPrivate.h:
* DefaultDelegates/WebDefaultContextMenuDelegate.h:
* DefaultDelegates/WebDefaultContextMenuDelegate.mm:
* DefaultDelegates/WebDefaultEditingDelegate.m:
* History/WebBackForwardListInternal.h:
* History/WebBackForwardListPrivate.h:
* History/WebHistoryItemPrivate.h:
* History/WebHistoryPrivate.h:
* History/WebURLsWithTitles.m:
Import WebKitLegacy headers instead of WebKit headers.

* MigrateHeaders.make:
Update header paths now that all WebKitLegacy headers are private.
Remove migration of WebKit2 headers, that is done by MigrateHeadersFromWebKitLegacy.make now.

* Misc/WebCoreStatistics.h:
* Misc/WebDownload.h:
* Misc/WebDownload.mm:
* Misc/WebDownloadInternal.h:
* Misc/WebElementDictionary.mm:
* Misc/WebIconDatabasePrivate.h:
* Misc/WebKit.h:
* Misc/WebKitErrors.m:
* Misc/WebKitErrorsPrivate.h:
* Misc/WebKitNSStringExtras.mm:
* Misc/WebLocalizableStrings.mm:
* Misc/WebNSDataExtras.m:
* Misc/WebNSDictionaryExtras.m:
* Misc/WebNSEventExtras.m:
* Misc/WebNSFileManagerExtras.mm:
* Misc/WebNSImageExtras.m:
* Misc/WebNSPasteboardExtras.mm:
* Misc/WebNSViewExtras.h:
* Misc/WebNSViewExtras.m:
* Panels/WebAuthenticationPanel.m:
* Panels/WebPanelAuthenticationHandler.m:
* Plugins/Hosted/HostedNetscapePluginStream.h:
* Plugins/Hosted/NetscapePluginInstanceProxy.h:
* Plugins/Hosted/WebKitPluginAgent.defs:
* Plugins/Hosted/WebKitPluginAgentReply.defs:
* Plugins/Hosted/WebKitPluginClient.defs:
* Plugins/Hosted/WebKitPluginHost.defs:
* Plugins/Hosted/WebKitPluginHostTypes.defs:
* Plugins/WebBaseNetscapePluginView.mm:
* Plugins/WebBasePluginPackage.h:
* Plugins/WebBasePluginPackage.mm:
* Plugins/WebNetscapeContainerCheckPrivate.h:
* Plugins/WebNetscapePluginEventHandlerCocoa.h:
* Plugins/WebNetscapePluginStream.h:
* Plugins/WebNetscapePluginView.h:
* Plugins/WebNetscapePluginView.mm:
* Plugins/WebPlugin.h:
* Plugins/WebPluginController.h:
* Plugins/WebPluginDatabase.h:
* Plugins/WebPluginPackage.h:
* Plugins/WebPluginPackage.mm:
* Plugins/WebPluginViewFactory.h:
* Plugins/WebPluginViewFactoryPrivate.h:
* Plugins/npapi.mm:
* Storage/WebDatabaseManagerPrivate.h:
* WebCoreSupport/WebContextMenuClient.mm:
* WebCoreSupport/WebFrameLoaderClient.mm:
* WebCoreSupport/WebFrameNetworkingContext.mm:
* WebCoreSupport/WebGeolocationClient.mm:
* WebCoreSupport/WebInspectorClient.mm:
* WebCoreSupport/WebJavaScriptTextInputPanel.m:
* WebCoreSupport/WebKeyGenerator.mm:
* WebInspector/WebInspectorPrivate.h:
* WebInspector/WebNodeHighlight.h:
* WebInspector/WebNodeHighlightView.h:
Import WebKitLegacy headers instead of WebKit headers.

* WebKitLegacy/MigrateHeadersFromWebKitLegacy.make: Added.
New makefile that handles copying WebKitLegacy headers to the WebKit framework, rewriting WebKitLegacy
imports to WebKit imports. (On iOS the WebKit headers just forward to the relevant WebKitLegacy headers).
On OS X, this also handles copying WebKit2 headers to the WebKit framework, rewriting WebKit2 imports to WebKit imports
and getting rid of C SPI imports.

* WebKitLegacy/MigrateHeadersToLegacy.make: Removed.
This is no longer needed.

* WebKitLegacy/WebKit.h: Added.
New umbrella header that imports the modern API if available, as well as the legacy API (using WebKit/WebKitLegacy.h).

* WebKitLegacy/WebKit.m:
This is an empty file so we'll have something to link.

* WebKitLegacy/WebKitPrivate.h:
New SPI header that imports the private headers of the modern API.

* WebView/WebDataSource.h:
* WebView/WebDataSource.mm:
* WebView/WebDataSourcePrivate.h:
* WebView/WebDelegateImplementationCaching.h:
* WebView/WebDocument.h:
* WebView/WebDocumentInternal.h:
* WebView/WebDocumentPrivate.h:
* WebView/WebEditingDelegate.h:
* WebView/WebEditingDelegatePrivate.h:
* WebView/WebFrameLoadDelegate.h:
* WebView/WebFrameLoadDelegatePrivate.h:
* WebView/WebFramePrivate.h:
* WebView/WebFrameView.h:
* WebView/WebFrameViewInternal.h:
* WebView/WebFrameViewPrivate.h:
* WebView/WebHTMLRepresentation.h:
* WebView/WebHTMLRepresentation.mm:
* WebView/WebHTMLRepresentationPrivate.h:
* WebView/WebHTMLView.h:
* WebView/WebHTMLView.mm:
* WebView/WebHTMLViewPrivate.h:
* WebView/WebPDFView.h:
* WebView/WebPolicyDelegatePrivate.h:
* WebView/WebPreferencesPrivate.h:
* WebView/WebResourcePrivate.h:
* WebView/WebUIDelegate.h:
* WebView/WebUIDelegatePrivate.h:
* WebView/WebView.h:
* WebView/WebView.mm:
* WebView/WebViewPrivate.h:
Import WebKitLegacy headers instead of WebKit headers.

* migrate-headers.sh:
Derived sources are put in DerivedSources/WebKitLegacy now.

Tools:
* Scripts/check-for-webkit-framework-include-consistency:
Allos WAK headers in WebKitLegacy as well as WebKit.

* TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
* TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
Update header imports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[New Multicolumn] Enable new multi-column mode
hyatt@apple.com [Wed, 30 Apr 2014 21:53:41 +0000 (21:53 +0000)]
[New Multicolumn] Enable new multi-column mode
https://bugs.webkit.org/show_bug.cgi?id=131825

Reviewed by Simon Fraser.

Source/WebKit/mac:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):

Source/WebKit2:
* Shared/WebPreferencesStore.h:

LayoutTests:
* compositing/columns/composited-columns-expected.txt:
* compositing/columns/composited-in-paginated-writing-mode-rl-expected.txt:
* compositing/columns/composited-nested-columns-expected.txt:
* compositing/columns/hittest-composited-in-paginated-expected.txt:
* fast/dom/Element/getBoundingClientRect-expected.txt:
* fast/dom/Element/getBoundingClientRect.html:
* fast/multicol/flipped-blocks-border-after-expected.txt:
* fast/multicol/pagination-h-horizontal-bt-expected.txt:
* fast/multicol/pagination-h-horizontal-tb-expected.txt:
* fast/multicol/pagination-h-vertical-lr-expected.txt:
* fast/multicol/pagination-h-vertical-rl-expected.txt:
* fast/multicol/pagination-v-horizontal-bt-expected.txt:
* fast/multicol/pagination-v-horizontal-tb-expected.txt:
* fast/multicol/pagination-v-vertical-lr-expected.txt:
* fast/multicol/pagination-v-vertical-rl-expected.txt:
* fast/multicol/progression-reverse-expected.txt:
* fast/multicol/single-line-expected.txt:
* fast/multicol/span/before-child-anonymous-column-block-expected.txt:
* fast/multicol/span/generated-child-split-flow-crash-expected.txt:
* fast/multicol/vertical-lr/rules-with-border-before-expected.txt:
* fast/multicol/vertical-rl/rule-style-expected.txt:
* fast/multicol/vertical-rl/rules-with-border-before-expected.txt:
* platform/mac/css3/unicode-bidi-isolate-basic-expected.png:
* platform/mac/css3/unicode-bidi-isolate-basic-expected.txt:
* platform/mac/fast/block/float/float-not-removed-from-next-sibling4-expected.png:
* platform/mac/fast/block/float/float-not-removed-from-next-sibling4-expected.txt:
* platform/mac/fast/borders/border-antialiasing-expected.png:
* platform/mac/fast/borders/border-antialiasing-expected.txt:
* platform/mac/fast/line-grid/line-align-left-edges-expected.png:
* platform/mac/fast/line-grid/line-align-right-edges-expected.png:
* platform/mac/fast/line-grid/line-grid-contains-value-expected.png:
* platform/mac/fast/line-grid/line-grid-floating-expected.png:
* platform/mac/fast/line-grid/line-grid-inside-columns-expected.png:
* platform/mac/fast/line-grid/line-grid-inside-columns-expected.txt:
* platform/mac/fast/line-grid/line-grid-into-columns-expected.png:
* platform/mac/fast/line-grid/line-grid-into-columns-expected.txt:
* platform/mac/fast/line-grid/line-grid-into-floats-expected.png:
* platform/mac/fast/line-grid/line-grid-positioned-expected.png:
* platform/mac/fast/multicol/block-axis-horizontal-bt-expected.txt:
* platform/mac/fast/multicol/block-axis-horizontal-tb-expected.txt:
* platform/mac/fast/multicol/block-axis-vertical-lr-expected.txt:
* platform/mac/fast/multicol/block-axis-vertical-rl-expected.txt:
* platform/mac/fast/multicol/border-padding-pagination-expected.png:
* platform/mac/fast/multicol/border-padding-pagination-expected.txt:
* platform/mac/fast/multicol/client-rects-expected.png:
* platform/mac/fast/multicol/client-rects-expected.txt:
* platform/mac/fast/multicol/column-break-with-balancing-expected.txt:
* platform/mac/fast/multicol/column-count-with-rules-expected.txt:
* platform/mac/fast/multicol/column-rules-expected.png:
* platform/mac/fast/multicol/column-rules-expected.txt:
* platform/mac/fast/multicol/column-rules-stacking-expected.txt:
* platform/mac/fast/multicol/columns-shorthand-parsing-expected.txt:
* platform/mac/fast/multicol/float-avoidance-expected.txt:
* platform/mac/fast/multicol/float-multicol-expected.txt:
* platform/mac/fast/multicol/float-paginate-complex-expected.txt:
* platform/mac/fast/multicol/float-paginate-empty-lines-expected.txt:
* platform/mac/fast/multicol/float-paginate-expected.txt:
* platform/mac/fast/multicol/layers-in-multicol-expected.png:
* platform/mac/fast/multicol/layers-in-multicol-expected.txt:
* platform/mac/fast/multicol/layers-split-across-columns-expected.txt:
* platform/mac/fast/multicol/margin-collapse-expected.txt:
* platform/mac/fast/multicol/max-height-columns-block-expected.png:
* platform/mac/fast/multicol/max-height-columns-block-expected.txt:
* platform/mac/fast/multicol/nested-columns-expected.png:
* platform/mac/fast/multicol/nested-columns-expected.txt:
* platform/mac/fast/multicol/overflow-across-columns-expected.txt:
* platform/mac/fast/multicol/overflow-across-columns-percent-height-expected.txt:
* platform/mac/fast/multicol/overflow-unsplittable-expected.txt:
* platform/mac/fast/multicol/paginate-block-replaced-expected.txt:
* platform/mac/fast/multicol/pagination/BottomToTop-bt-expected.txt:
* platform/mac/fast/multicol/pagination/BottomToTop-lr-expected.txt:
* platform/mac/fast/multicol/pagination/BottomToTop-rl-expected.txt:
* platform/mac/fast/multicol/pagination/BottomToTop-tb-expected.txt:
* platform/mac/fast/multicol/pagination/LeftToRight-bt-expected.txt:
* platform/mac/fast/multicol/pagination/LeftToRight-lr-expected.txt:
* platform/mac/fast/multicol/pagination/LeftToRight-rl-expected.png:
* platform/mac/fast/multicol/pagination/LeftToRight-rl-expected.txt:
* platform/mac/fast/multicol/pagination/LeftToRight-tb-expected.txt:
* platform/mac/fast/multicol/pagination/RightToLeft-bt-expected.txt:
* platform/mac/fast/multicol/pagination/RightToLeft-lr-expected.txt:
* platform/mac/fast/multicol/pagination/RightToLeft-rl-expected.txt:
* platform/mac/fast/multicol/pagination/RightToLeft-tb-expected.txt:
* platform/mac/fast/multicol/pagination/TopToBottom-bt-expected.png:
* platform/mac/fast/multicol/pagination/TopToBottom-bt-expected.txt:
* platform/mac/fast/multicol/pagination/TopToBottom-lr-expected.txt:
* platform/mac/fast/multicol/pagination/TopToBottom-rl-expected.txt:
* platform/mac/fast/multicol/pagination/TopToBottom-tb-expected.txt:
* platform/mac/fast/multicol/positioned-split-expected.txt:
* platform/mac/fast/multicol/positive-leading-expected.txt:
* platform/mac/fast/multicol/scrolling-overflow-expected.png:
* platform/mac/fast/multicol/scrolling-overflow-expected.txt:
* platform/mac/fast/multicol/shadow-breaking-expected.png:
* platform/mac/fast/multicol/shadow-breaking-expected.txt:
* platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.txt:
* platform/mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
* platform/mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
* platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.png:
* platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.txt:
* platform/mac/fast/multicol/span/anonymous-style-inheritance-expected.txt:
* platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
* platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
* platform/mac/fast/multicol/span/clone-flexbox-expected.txt:
* platform/mac/fast/multicol/span/clone-summary-expected.txt:
* platform/mac/fast/multicol/span/generated-child-split-flow-crash-expected.png:
* platform/mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
* platform/mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
* platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
* platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
* platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
* platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
* platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
* platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
* platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.png:
* platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
* platform/mac/fast/multicol/span/span-as-nested-inline-block-child-expected.txt:
* platform/mac/fast/multicol/span/span-margin-collapsing-expected.txt:
* platform/mac/fast/multicol/table-margin-collapse-expected.txt:
* platform/mac/fast/multicol/table-vertical-align-expected.txt:
* platform/mac/fast/multicol/unsplittable-inline-block-expected.txt:
* platform/mac/fast/multicol/vertical-lr/border-padding-pagination-expected.png:
* platform/mac/fast/multicol/vertical-lr/border-padding-pagination-expected.txt:
* platform/mac/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt:
* platform/mac/fast/multicol/vertical-lr/column-count-with-rules-expected.png:
* platform/mac/fast/multicol/vertical-lr/column-count-with-rules-expected.txt:
* platform/mac/fast/multicol/vertical-lr/column-rules-expected.png:
* platform/mac/fast/multicol/vertical-lr/column-rules-expected.txt:
* platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.txt:
* platform/mac/fast/multicol/vertical-lr/float-multicol-expected.txt:
* platform/mac/fast/multicol/vertical-lr/float-paginate-complex-expected.txt:
* platform/mac/fast/multicol/vertical-lr/float-paginate-expected.txt:
* platform/mac/fast/multicol/vertical-lr/nested-columns-expected.png:
* platform/mac/fast/multicol/vertical-lr/nested-columns-expected.txt:
* platform/mac/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt:
* platform/mac/fast/multicol/vertical-rl/border-padding-pagination-expected.png:
* platform/mac/fast/multicol/vertical-rl/border-padding-pagination-expected.txt:
* platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
* platform/mac/fast/multicol/vertical-rl/column-count-with-rules-expected.png:
* platform/mac/fast/multicol/vertical-rl/column-count-with-rules-expected.txt:
* platform/mac/fast/multicol/vertical-rl/column-rules-expected.png:
* platform/mac/fast/multicol/vertical-rl/column-rules-expected.txt:
* platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.txt:
* platform/mac/fast/multicol/vertical-rl/float-multicol-expected.txt:
* platform/mac/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:
* platform/mac/fast/multicol/vertical-rl/float-paginate-expected.txt:
* platform/mac/fast/multicol/vertical-rl/nested-columns-expected.png:
* platform/mac/fast/multicol/vertical-rl/nested-columns-expected.txt:
* platform/mac/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt:
* platform/mac/fast/overflow/paged-x-div-expected.png:
* platform/mac/fast/overflow/paged-x-div-expected.txt:
* platform/mac/fast/overflow/paged-x-div-with-column-gap-expected.png:
* platform/mac/fast/overflow/paged-x-div-with-column-gap-expected.txt:
* platform/mac/fast/overflow/paged-x-on-root-expected.png:
* platform/mac/fast/overflow/paged-x-on-root-expected.txt:
* platform/mac/fast/overflow/paged-x-with-column-gap-expected.png:
* platform/mac/fast/overflow/paged-x-with-column-gap-expected.txt:
* platform/mac/fast/overflow/paged-y-div-expected.png:
* platform/mac/fast/overflow/paged-y-div-expected.txt:
* platform/mac/fast/overflow/paged-y-on-root-expected.png:
* platform/mac/fast/overflow/paged-y-on-root-expected.txt:
* platform/mac/fast/repaint/multicol-repaint-expected.png:
* platform/mac/fast/repaint/multicol-repaint-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS WK2] Add test URL to crash reports for the UI process, clean up project
simon.fraser@apple.com [Wed, 30 Apr 2014 21:48:39 +0000 (21:48 +0000)]
[iOS WK2] Add test URL to crash reports for the UI process, clean up project
https://bugs.webkit.org/show_bug.cgi?id=131954

Reviewed by Darin Adler.

WebKitTestRunner was adding application-specific information to crash reports
to log the test path, but only in the web process. Fix it to also do this
for the UI process, for both iOS and OS X.

Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
both iOS and OS X.

Factored crash reprorter-related code into CrashReporterInfo, and call it from
a new TestController::platformWillRunTest() function on Mac and iOS.

Also remove Xcode-added unit test junk from the project.

* WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
(WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::runTest):
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::url):
* WebKitTestRunner/TestInvocation.h:
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
* WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
* WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
* WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
* WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
(WTR::testPathFromURL):
(WTR::setCrashReportApplicationSpecificInformationToURL):
* WebKitTestRunner/efl/TestControllerEfl.cpp:
(WTR::TestController::platformWillRunTest):
* WebKitTestRunner/gtk/TestControllerGtk.cpp:
(WTR::TestController::platformWillRunTest):
* WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::platformWillRunTest):
(WTR::TestController::setHidden):
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::platformWillRunTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix DRT assertion about mock scrollbars, which doesn't apply to iOS.
simon.fraser@apple.com [Wed, 30 Apr 2014 21:48:36 +0000 (21:48 +0000)]
Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.

Reviewed by Tim Horton.

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
(prepareConsistentTestingEnvironment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[New Multicolumn] ASSERTs in fast/dynamic/continuation-detach-crash.html
hyatt@apple.com [Wed, 30 Apr 2014 21:27:50 +0000 (21:27 +0000)]
[New Multicolumn] ASSERTs in fast/dynamic/continuation-detach-crash.html
https://bugs.webkit.org/show_bug.cgi?id=132392

Reviewed by Dean Jackson.

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::setRegionRangeForBox):
Add ASSERTs in case we ever try to set regions from the wrong flow thread
as part of the box's region range.

* rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::flowThreadDescendantInserted):
Add a bunch of code that handles the discovery of a span from an outer flow thread
being inserted into an inner flow thread. This forces us to delete that placeholder
and shift the outer spanning content into the inner flow thread in order to get a new
mapping/placeholder created in the inner flow thread.

(WebCore::RenderMultiColumnFlowThread::flowThreadRelativeWillBeRemoved):
Tighten this code to use the parent() just in case we change the invariant of
parent = containingBlock later.

* rendering/RenderMultiColumnFlowThread.h:
Add a static guard when shifting a spanner to prevent the outer flow thread from
thinking the spanner belongs to it when it gets punted out of the inner flow thread.
A better long-term solution might be to make the spanner map global instead of
per-flow thread.

* rendering/RenderMultiColumnSpannerPlaceholder.cpp:
(WebCore::RenderMultiColumnSpannerPlaceholder::RenderMultiColumnSpannerPlaceholder):
* rendering/RenderMultiColumnSpannerPlaceholder.h:
Cache the flow thread so that we can get back to it in order to detect if the
placeholder belongs to us or not.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::insertedIntoTree):
Notifications from insertedIntoTree are problematic, since this can be called during
the layout of the outer flow thread for content inside an inner flow thread that is
not getting a layout yet. This makes the currentFlowThread in the flow thread controller
inaccurate, so we have to add code to clear it out and put it back.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAX: Make "contenteditable" regions into AXTextAreas
cfleizach@apple.com [Wed, 30 Apr 2014 20:47:16 +0000 (20:47 +0000)]
AX: Make "contenteditable" regions into AXTextAreas
https://bugs.webkit.org/show_bug.cgi?id=132379

Reviewed by Mario Sanchez Prada.

Source/WebCore:
Make contenteditable regions into AXTextAreas. This will allow for a more standardized
interface for interaction with assistive technologies.

Test: accessibility/content-editable-as-textarea.html

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::hasContentEditableAttributeSet):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::contentEditableAttributeIsEnabled):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::documentBasedSelectedTextRange):
(WebCore::AccessibilityRenderObject::selectedText):
(WebCore::AccessibilityRenderObject::selectedTextRange):
(WebCore::AccessibilityRenderObject::renderObjectIsObservable):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::ariaSelectedTextRange): Deleted.
* accessibility/AccessibilityRenderObject.h:

LayoutTests:
* accessibility/content-editable-as-textarea.html: Added.
* platform/mac-mountainlion/accessibility/content-editable-as-textarea-expected.txt: Added.
* platform/mac/accessibility/content-editable-as-textarea-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoClean up unnecessary methods in the BackForwardClient interface
burg@cs.washington.edu [Wed, 30 Apr 2014 20:42:19 +0000 (20:42 +0000)]
Clean up unnecessary methods in the BackForwardClient interface
https://bugs.webkit.org/show_bug.cgi?id=131637

Reviewed by Andreas Kling.

Source/WebCore:
Demote back/current/forwardItem and iOS-specific methods from the
BackForwardClient interface. Convert the class to not be refcounted.

No new tests, no behavior was changed.

* WebCore.exp.in:
* history/BackForwardClient.h:
(WebCore::BackForwardClient::~BackForwardClient): Deleted.
(WebCore::BackForwardClient::backItem): Deleted.
(WebCore::BackForwardClient::currentItem): Deleted.
(WebCore::BackForwardClient::forwardItem): Deleted.
* history/BackForwardController.cpp:
(WebCore::BackForwardController::BackForwardController):
* history/BackForwardController.h: Take ownership of the passed BackForwardClient.
(WebCore::BackForwardController::client): Return a reference.
* history/BackForwardList.h: Remove the Page field, since it isn't used any more.
(WebCore::BackForwardList::create): Deleted.
* page/Page.h: Remove RefPtr from PageClient.
* page/Page.cpp:
(WebCore::PageClients::PageClients): Initialize client to nullptr.

Source/WebKit/efl:
Remove uses of reference counting for BackForwardList.
Use references to BackForwardClient instead of pointers.
Stop using BackForwardClient::page() since it was removed.

* ewk/ewk_history.cpp:
(ewk_history_clear):
(ewk_history_new):
(ewk_history_free):
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(ewk_view_history_enable_get):
(ewk_view_history_enable_set):
(ewk_view_history_get):

Source/WebKit/mac:
BackForwardClient instances now have ownership lifetime semantics, so
WebBackForwardList now explicitly deletes its inner BackForwardList.

Convert uses of WebCore::BackForwardList through backForward().client() to
accept references instead of pointers.

Use BackForwardController methods rather than directly operating with the
BackForwardClient where possible.

Remove page cache-related methods that are not used anywhere and that call
BackForwardClient::page(), which is removed by this change.

* History/WebBackForwardList.mm:
(-[WebBackForwardList initWithBackForwardList:]):
(-[WebBackForwardList init]):
(-[WebBackForwardList dealloc]):
(-[WebBackForwardList finalize]):
(-[WebBackForwardList setPageCacheSize]): Deleted.
(-[WebBackForwardList pageCacheSize]): Deleted.
(-[WebBackForwardList itemAtIndex:]): Deleted.
* History/WebBackForwardListInternal.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::canCachePage):
* WebView/WebFrameView.mm:
(-[WebFrameView keyDown:keyDown:]):
* WebView/WebView.mm:
(-[WebView _loadBackForwardListFromOtherView:]):
(-[WebView initWithCoder:]):
(-[WebView encodeWithCoder:]):
(-[WebView backForwardList]):
(-[WebView setMaintainsBackForwardList:]):

Source/WebKit/win:
Remove uses of reference counting for BackForwardList.
Use BackForwardController instead of BackForwardClient where possible.

* WebBackForwardList.cpp:
(WebBackForwardList::WebBackForwardList):
(WebBackForwardList::~WebBackForwardList):
(WebBackForwardList::createInstance):
* WebBackForwardList.h:
* WebView.cpp:
(WebView::backForwardList):
(WebView::canGoBack):
(WebView::canGoForward):
(WebView::loadBackForwardListFromOtherView):

Source/WebKit2:
Remove stubs for iOS-specific methods in the BackForwardClient interface.

Construct a WebBackForwardListProxy directly, and make the WebCore page
own the BackForwardClient instance. Convert uses of backForward().client()
to accept references instead of raw pointers.

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/InjectedBundleBackForwardList.cpp:
(WebKit::InjectedBundleBackForwardList::clear):
* WebProcess/WebPage/WebBackForwardListProxy.cpp: Store a reference to
WebCore::Page instead of a pointer.
(WebKit::WebBackForwardListProxy::WebBackForwardListProxy):
(WebKit::WebBackForwardListProxy::create): Deleted.
(WebKit::WebBackForwardListProxy::addItem):
(WebKit::WebBackForwardListProxy::goToItem):
(WebKit::WebBackForwardListProxy::itemAtIndex):
(WebKit::WebBackForwardListProxy::backListCount):
(WebKit::WebBackForwardListProxy::forwardListCount):
(WebKit::WebBackForwardListProxy::close):
(WebKit::WebBackForwardListProxy::clear):
(WebKit::WebBackForwardListProxy::isActive):
* WebProcess/WebPage/WebBackForwardListProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
* WebProcess/WebPage/ios/WebBackForwardListProxyIOS.mm: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: clean up and decompose InspectorBackend functionality
burg@cs.washington.edu [Wed, 30 Apr 2014 20:30:49 +0000 (20:30 +0000)]
Web Inspector: clean up and decompose InspectorBackend functionality
https://bugs.webkit.org/show_bug.cgi?id=132387

Reviewed by Joseph Pecoraro.

Aside from renaming variables and other minor cleanup, this patch
changes the following:

When calling a command, only store callback data when a callback is passed.
Use explicit model objects for the agent, event, enum, and commands.
Separate the agent models from encoding and decoding of JSON messages.

* UserInterface/Protocol/InspectorBackend.js:
(InspectorBackendClass):
(InspectorBackendClass.prototype.registerCommand):
(InspectorBackendClass.prototype.registerEnum):
(InspectorBackendClass.prototype.registerEvent):
(InspectorBackendClass.prototype.registerDomainDispatcher):
(InspectorBackendClass.prototype.dispatch):
(InspectorBackendClass.prototype.runAfterPendingDispatches):
(InspectorBackendClass.prototype._agentForDomain):
(InspectorBackendClass.prototype._registerSentCommand):
(InspectorBackendClass.prototype._dispatchCallback):
(InspectorBackendClass.prototype._dispatchEvent):
(InspectorBackendClass.prototype._invokeCommand):
(InspectorBackendClass.prototype._reportProtocolError):
(InspectorBackend.Agent):
(InspectorBackend.Agent.prototype.get domainName):
(InspectorBackend.Agent.prototype.set dispatcher):
(InspectorBackend.Agent.prototype.addEnum):
(InspectorBackend.Agent.prototype.addCommand):
(InspectorBackend.Agent.prototype.addEvent):
(InspectorBackend.Agent.prototype.getEvent):
(InspectorBackend.Agent.prototype.dispatchEvent):
(InspectorBackend.Command):
(InspectorBackend.Command.create):
(InspectorBackend.Command.prototype.get qualifiedName):
(InspectorBackend.Command.prototype.get commandName):
(InspectorBackend.Command.prototype.get callSignature):
(InspectorBackend.Command.prototype.get replySignature):
(InspectorBackend.Command.prototype.invoke):
(InspectorBackend.Command.prototype.supports):
(InspectorBackend.Command.prototype._invokeWithArguments):
(InspectorBackend.Event):
(InspectorBackend.Enum):
(InspectorBackendClass.prototype.callback): Deleted.
(InspectorBackendClass.prototype._registerPendingResponse): Deleted.
(InspectorBackendClass.prototype._invokeMethod): Deleted.
(InspectorBackendClass.prototype._getAgent): Deleted.
(InspectorBackendClass.prototype.reportProtocolError): Deleted.
(InspectorBackendCommand): Deleted.
(InspectorBackendCommand.create): Deleted.
(InspectorBackendCommand.prototype.invoke): Deleted.
(InspectorBackendCommand.prototype.supports): Deleted.
(InspectorBackendCommand.prototype._invokeWithArguments): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agocheck-for-inappropriate-macros-in-external-headers should get the product name, not...
andersca@apple.com [Wed, 30 Apr 2014 20:00:47 +0000 (20:00 +0000)]
check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
https://bugs.webkit.org/show_bug.cgi?id=132397

Reviewed by Dan Bernstein.

* Scripts/check-for-inappropriate-macros-in-external-headers:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix PageVisibility on iOS
barraclough@apple.com [Wed, 30 Apr 2014 19:52:26 +0000 (19:52 +0000)]
Fix PageVisibility on iOS
https://bugs.webkit.org/show_bug.cgi?id=132393

Reviewed by Andreas Kling.

Currently page visibility API doesn't work correctly on WK2 iOS for a few reasons,
the most significant of which being that the moment a WKWebView leaves the window
we'll suspend the content process, which removes the possibility for any notification
to be delivered. This patch addresses this issue, by allowing the process to run for
long enough for the notification to be delivered.

1) Introduce a new class, ProcessThrottler, to encapsulate the process suspension logic.
2) WebPageProxy uses ProcessThrottler::VisibilityToken to communicate visibility to the throttler.
3) WebPageProxy tracks pending didUpdateViewState messages to detect when the view state update in
   the web content process has completed.
4) Distiguish between 'Background' and 'Suspended' states in the ProcessAssertion.

* Shared/ChildProcessProxy.h:
    - moved m_assertion to NetworkProcessProxy / WebProcessProxy.
* UIProcess/Network/NetworkProcessProxy.h:
    - added m_assertion.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
    - initialize VisibilityToken state.
(WebKit::WebPageProxy::reattachToWebProcess):
    - reinitialize VisibilityToken state.
(WebKit::WebPageProxy::viewStateDidChange):
    - update VisibilityToken, increment m_pendingViewStateUpdates as necessary.
(WebKit::WebPageProxy::updateVisibilityToken):
    - update the VisibiliyToken based on page visibility, and whether an update is still pending.
(WebKit::WebPageProxy::didUpdateViewState):
    - detect when a view state change has completed in the web process, and update throttle state as necessary.
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::didUpdateViewState): Deleted.
    - moved to .cpp.
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
    - initialize m_throttler.
(WebKit::WebProcessProxy::didFinishLaunching):
    - notify the PageThrottler of the new connection.
* UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::throttler):
    - added accessor.
(WebKit::WebProcessProxy::updateProcessState): Deleted.
    - moved trottling login to ProcessThrottler.
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::isViewWindowActive):
(WebKit::PageClientImpl::isViewFocused):
(WebKit::PageClientImpl::isViewVisible):
(WebKit::PageClientImpl::isViewVisibleOrOccluded):
    - these should only be true when the view is in a window.
(WebKit::PageClientImpl::isVisuallyIdle):
    - this should only be true when the view is not in a window.
* UIProcess/ios/ProcessAssertion.h:
* UIProcess/ios/ProcessAssertion.mm:
(WebKit::flagsForState):
    - map from enum -> BKSAssertion flags values.
(WebKit::ProcessAssertion::ProcessAssertion):
    - use flagsForState (add support for Suspended state).
(WebKit::ProcessAssertion::setState):
    - use flagsForState (add support for Suspended state).
* UIProcess/ios/ProcessThrottler.h: Added.
(WebKit::ProcessThrottler::VisibilityToken::visibility):
    - accessor.
(WebKit::ProcessThrottler::VisibilityToken::setVisibility):
    - update Visibility value; update the token as necessary.
(WebKit::ProcessThrottler::ProcessThrottler):
    - constructor; does not take an assention until didConnnectToProcess is called.
(WebKit::ProcessThrottler::visibilityToken):
    - create a VisibilityToken.
(WebKit::ProcessThrottler::didConnnectToProcess):
    - take an assertion.
(WebKit::ProcessThrottler::weakPtr):
    - create a weak pointer, used for references from VisibilityToken to the throttler.
(WebKit::ProcessThrottler::assertionState):
    - determine the correct AssertionState for the process, based on current visibility.
(WebKit::ProcessThrottler::updateAssertion):
    - update assertion, called in response to visibility change.
* UIProcess/ios/ProcessThrottler.mm: Added.
(WebKit::ProcessThrottler::VisibilityToken::VisibilityToken):
    - constructor.
(WebKit::ProcessThrottler::VisibilityToken::~VisibilityToken):
    - set visibility to hidden to reset.
(WebKit::ProcessThrottler::VisibilityToken::hideTimerFired):
    - automatically decay from Hiding -> Hidden on a timeout.
(WebKit::ProcessThrottler::VisibilityToken::setVisibilityInternal):
    - update counters tracking visibility in ProcessThrottler.
* UIProcess/ios/WKContentView.mm:
(-[WKContentView didMoveToWindow]):
    - This affects all view state flags, not just the 'InWindow' state.
      If the view moves out of a window request a reply from the WebContent - we use this
      to detect when the page visibility event has completed.
* UIProcess/ios/WebProcessProxyIOS.mm:
(WebKit::WebProcessProxy::updateProcessState): Deleted.
    - removed.
* WebKit2.xcodeproj/project.pbxproj:
    - added new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoPreemptive header fixes for when WebKit.framework is going to provide the modern API
andersca@apple.com [Wed, 30 Apr 2014 19:47:41 +0000 (19:47 +0000)]
Preemptive header fixes for when WebKit.framework is going to provide the modern API
https://bugs.webkit.org/show_bug.cgi?id=132394

Reviewed by Dan Bernstein.

* UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h:
(NS_ENUM):
Delete WKNavigationType for now. Ultimately the entire delegate should be removed.

* UIProcess/API/Cocoa/WKPreferences.h:
Add a header guard so we can avoid importing WKPreferences.h more than once.

* WebKit2.xcodeproj/project.pbxproj:
_WKScriptWorld.h should be private, not public.
WKScriptMessagePrivate.h and WKUserContentControllerPrivate.h should be private, not project.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Mac, iOS] Support caption activation via JS webkitHasClosedCaptions method
bfulgham@apple.com [Wed, 30 Apr 2014 19:42:18 +0000 (19:42 +0000)]
[Mac, iOS] Support caption activation via JS webkitHasClosedCaptions method
https://bugs.webkit.org/show_bug.cgi?id=132320

Reviewed by Eric Carlson.

* Modules/mediacontrols/mediaControlsApple.css:
(video::-webkit-media-text-track-container .hidden): Added.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::configureTextTrackGroup): Added call to
new 'updateCaptionsContainer'.
(WebCore::HTMLMediaElement::updateCaptionContainer): Added.
* html/HTMLMediaElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Ensure UIProcess checks in to webinspectord after spawning a WebProcess
commit-queue@webkit.org [Wed, 30 Apr 2014 19:29:16 +0000 (19:29 +0000)]
Web Inspector: Ensure UIProcess checks in to webinspectord after spawning a WebProcess
https://bugs.webkit.org/show_bug.cgi?id=132389

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-04-30
Reviewed by Timothy Hatcher.

We aggregate WebProcess WebView's under the UIProcess. If the UIProcess
didn't connect to webinspectord these WebViews would have remained
hidden. Always have the UIProcess connect to webinspectord when it
spawns a WebProcess and may have a child process holding views that
it ultimately owns and should display under the UIProcess name.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168035 268f45cc-cd09-0410-ab3c-d52691b4dbfc