WebKit-https.git
10 years ago Fixed https://bugs.webkit.org/show_bug.cgi?id=23088.
cmarrin@apple.com [Fri, 16 Jan 2009 18:27:18 +0000 (18:27 +0000)]
    Fixed https://bugs.webkit.org/show_bug.cgi?id=23088.
        This was happening because I was calling setChanged() from inside updateRendering()
        which causes an infinite loop. I fixed this by deferring the setChanged to the next
        run loop iteration. That made it not infinite loop, but it still retriggers the
        transition forever. The problem is that there is both an 'all' and specific transition
        on 'opacity'. This tickled a bug in AnimationController which causes the opacity
        transition to get constantly cancelled and then retriggered. The problem is that
        the specific opacity transition has a duration of 0. I got rid of the logic to
        flush out 0 duration transitions and it is no longer constantly triggered. The
        logic to flush them was just an optimization, and you really need to keep them
        around to make the logic to override earlier animations by later ones work. And there is
        very little overhead in this case anyway, so the optimization was not that useful.

        I made a LayoutTest from the original testcase which tests both the infinite
        loop and constantly triggering animation cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 23385: crash at com.apple.WebCore • WebCore::HTMLAnchorElement::isKeyboardFocusable
cfleizach@apple.com [Fri, 16 Jan 2009 18:06:24 +0000 (18:06 +0000)]
Bug 23385: crash at com.apple.WebCore • WebCore::HTMLAnchorElement::isKeyboardFocusable
https://bugs.webkit.org/show_bug.cgi?id=23385

Option-tabbing on page with image map links causes crash

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Fri, 16 Jan 2009 17:13:18 +0000 (17:13 +0000)]
2009-01-16  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Simon Hausmann.

        [Qt] Increase popup focus delay time to a sensible 500 ms.

        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-16 Thiago Macieira <thiago.macieira@nokia.com>
ariya@webkit.org [Fri, 16 Jan 2009 15:44:41 +0000 (15:44 +0000)]
2009-01-16  Thiago Macieira  <thiago.macieira@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Fixes QString and 8-bit mix fixes.

        Details:  Make sure we use QLatin1String where appropriate (and don't
        use QString when not necessary)

        * platform/graphics/qt/ImageDecoderQt.cpp:
        (WebCore::ImageDecoderQt::create):
        * platform/graphics/qt/SimpleFontDataQt.cpp:
        (WebCore::SimpleFontData::platformInit):
        * platform/qt/FileSystemQt.cpp:
        (WebCore::openTemporaryFile):
        * platform/qt/LoggingQt.cpp:
        (WebCore::InitializeLoggingChannelsIfNecessary):
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::extraMediaControlsStyleSheet):
        * plugins/qt/PluginDataQt.cpp:
        (WebCore::PluginData::initPlugins):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Windows build fix
aroben@apple.com [Fri, 16 Jan 2009 15:27:31 +0000 (15:27 +0000)]
    Windows build fix

        * wrec/WRECParser.cpp:
        (JSC::WREC::Parser::parseParentheses): Removed unreachable code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Fri, 16 Jan 2009 15:16:34 +0000 (15:16 +0000)]
2009-01-16  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=22452

        When plugins are disabled, plugin data should not be available for
        the page. This ensures that navigator.plugins would not see the
        additional MIME types supported by the plugins.

        * page/Page.cpp:
        (WebCore::Page::pluginData):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::shouldUsePlugin):
        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::updateWidget):

2009-01-16  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Adam Roben.

        [Qt] Prevent crash if plugin data is NULL.

        * WebCoreSupport/FrameLoaderClientQt.cpp: NULL check.
        (WebCore::FrameLoaderClientQt::objectContentType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Got rid of .idl file in Resources for bug https://bugs.webkit.org/show_bug...
cmarrin@apple.com [Fri, 16 Jan 2009 15:09:17 +0000 (15:09 +0000)]
    Got rid of .idl file in Resources for bug https://bugs.webkit.org/show_bug.cgi?id=21421.
        Also fixed the test case to work on ppc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Fri, 16 Jan 2009 11:02:22 +0000 (11:02 +0000)]
2009-01-16  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Simon Hausmann.

        [Qt] Per-line cursor movement tests depend on platform-specific font
        metrics. Remove them to avoid test failures on different platforms.

        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::cursorMovements):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Fri, 16 Jan 2009 10:12:45 +0000 (10:12 +0000)]
2009-01-16  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Simon Hausmann.

        http://www.qtsoftware.com/developer/task-tracker/index_html?id=219344&method=entry

        [Qt] API documentation for QWebPage::WebAction enum.

        * Api/qwebpage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Fri, 16 Jan 2009 10:00:31 +0000 (10:00 +0000)]
2009-01-16  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Another attempt at fixing the Qt build.

        * bridge/qt/qt_instance.cpp:
        (JSC::Bindings::QtInstance::getInstance):

        * Api/qwebframe.cpp:
        (QWebFrame::addToJavaScriptWindowObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-16 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 16 Jan 2009 08:35:06 +0000 (08:35 +0000)]
2009-01-16  David Hyatt  <hyatt@apple.com>

        Fix for 1.85% PLT regression.  Since asking if a frame is "complete" actually aggressively decodes
        the frame, we add an optimization when advancing animations.  If we have received all of the animated
        image's data, then obviously we can go ahead and advance safely.  This prevents the first draw of an image
        from decoding two frames' worth of data in the case where all of the image's data has been received.

        While this fixes the cached case, there could in fact be a regression on the uncached PLT from this change
        as well.  It's not immediately clear how that regression would be fixed, though, and it would likely be
        a much smaller percentage of that overall uncached time.

        Reviewed by Dan Bernstein

        * platform/graphics/BitmapImage.cpp:
        (WebCore::BitmapImage::startAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScriptCore:
ggaren@apple.com [Fri, 16 Jan 2009 08:01:44 +0000 (08:01 +0000)]
JavaScriptCore:

2009-01-15  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Fixed <rdar://problem/6471394> REGRESSION (r39164): Discarding quantifier
        on assertion gives incorrect result (23075)

        https://bugs.webkit.org/show_bug.cgi?id=23075

        * pcre/pcre_compile.cpp:
        (compileBranch): Throw away an assertion if it's followed by a quantifier
        with a 0 minimum, to match SpiderMonkey, v8, and the ECMA spec.

        * wrec/WRECParser.cpp:
        (JSC::WREC::Parser::parseParentheses): Fall back on PCRE for the rare
        case of an assertion with a quantifier with a 0 minimum, since we
        don't handle quantified subexpressions yet, and in this special case,
        we can't just throw away the quantifier.

LayoutTests:

2009-01-15  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Added a test for <rdar://problem/6471394> REGRESSION (r39164): Discarding
        quantifier on assertion gives incorrect result (23075)

        * fast/regex/quantified-assertions-expected.txt:
        * fast/regex/resources/quantified-assertions.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Anders Carlsson.
ap@webkit.org [Fri, 16 Jan 2009 07:44:19 +0000 (07:44 +0000)]
    Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=23349
        Don't store obsolete caches in disk storage

        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::ResourceLoader):
        (WebCore::ResourceLoader::load):
        (WebCore::ResourceLoader::scheduleLoadFallbackResourceFromApplicationCache):
        * loader/ResourceLoader.h:
        Don't maintain m_wasLoadedFromApplicationCache, which was never used.

        * loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::addResource):
        Assert that only implicit and dynamic resources can be added after the cache has been fully
        loaded and stored to disk database.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::cacheDestroyed): Don't remove non-newest caches from disk
        database, as this is now done whenever the cache becomes obsolete.
        (WebCore::ApplicationCacheGroup::setNewestCache): Remove an obsolete cache from disk storage.

        * loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::cacheGroupDestroyed):
        A cache group that has never been saved should not be remembered in m_cacheHostSet. Changed
        the check to no longer rely on savedNewestCachePointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-15 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Fri, 16 Jan 2009 06:52:13 +0000 (06:52 +0000)]
2009-01-15  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Add support in ResultType to track that the results of bitops
        are always of type int32_t.

        * parser/Nodes.cpp:
        (JSC::ReadModifyResolveNode::emitBytecode):
        (JSC::ReadModifyDotNode::emitBytecode):
        (JSC::ReadModifyBracketNode::emitBytecode):
        * parser/Nodes.h:
        (JSC::ExpressionNode::):
        (JSC::BooleanNode::):
        (JSC::NumberNode::):
        (JSC::StringNode::):
        (JSC::PrePostResolveNode::):
        (JSC::TypeOfResolveNode::):
        (JSC::TypeOfValueNode::):
        (JSC::UnaryPlusNode::):
        (JSC::NegateNode::):
        (JSC::BitwiseNotNode::):
        (JSC::LogicalNotNode::):
        (JSC::MultNode::):
        (JSC::DivNode::):
        (JSC::ModNode::):
        (JSC::SubNode::):
        (JSC::LeftShiftNode::):
        (JSC::RightShiftNode::):
        (JSC::UnsignedRightShiftNode::):
        (JSC::LessNode::):
        (JSC::GreaterNode::):
        (JSC::LessEqNode::):
        (JSC::GreaterEqNode::):
        (JSC::InstanceOfNode::):
        (JSC::EqualNode::):
        (JSC::NotEqualNode::):
        (JSC::StrictEqualNode::):
        (JSC::NotStrictEqualNode::):
        (JSC::BitAndNode::):
        (JSC::BitOrNode::):
        (JSC::BitXOrNode::):
        (JSC::LogicalOpNode::):
        * parser/ResultType.h:
        (JSC::ResultType::isInt32):
        (JSC::ResultType::isNotNumber):
        (JSC::ResultType::booleanType):
        (JSC::ResultType::numberType):
        (JSC::ResultType::numberTypeCanReuse):
        (JSC::ResultType::numberTypeCanReuseIsInt32):
        (JSC::ResultType::stringOrNumberTypeCanReuse):
        (JSC::ResultType::stringType):
        (JSC::ResultType::unknownType):
        (JSC::ResultType::forAdd):
        (JSC::ResultType::forBitOp):
        (JSC::OperandTypes::OperandTypes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-15 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Fri, 16 Jan 2009 06:51:20 +0000 (06:51 +0000)]
2009-01-15  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Add support for integer addition, subtraction and multiplication
        in JIT code on x86-64.

        * assembler/MacroAssembler.h:
        (JSC::MacroAssembler::mul32):
        (JSC::MacroAssembler::sub32):
        (JSC::MacroAssembler::joMul32):
        (JSC::MacroAssembler::joSub32):
        * jit/JIT.cpp:
        (JSC::JIT::privateCompileMainPass):
        (JSC::JIT::privateCompileSlowCases):
        * jit/JIT.h:
        * jit/JITArithmetic.cpp:
        (JSC::JIT::compileFastArith_op_add):
        (JSC::JIT::compileFastArithSlow_op_add):
        (JSC::JIT::compileFastArith_op_mul):
        (JSC::JIT::compileFastArithSlow_op_mul):
        (JSC::JIT::compileFastArith_op_sub):
        (JSC::JIT::compileFastArithSlow_op_sub):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/5870656> selectorText and cssText are clipped for :nth-child() and...
timothy@apple.com [Fri, 16 Jan 2009 04:53:22 +0000 (04:53 +0000)]
<rdar://problem/5870656> selectorText and cssText are clipped for :nth-child() and :nth-of-type()

WebCore:

2009-01-15  Dimitri Dupuis-Latour  <dupuislatour@apple.com>

        <rdar://problem/5870656> selectorText and cssText are clipped for :nth-child() and :nth-of-type();

        Reviewed by Timothy Hatcher.

        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::selectorText):

LayoutTests:

2009-01-15  Dimitri Dupuis-Latour  <dupuislatour@apple.com>

        Added testcases for all CSS3 pseudo-classes and pseudo-elements

        <rdar://problem/5870656> selectorText and cssText are clipped for :nth-child() and :nth-of-type();

        Reviewed by Timothy Hatcher.

        * fast/dom/css-selectorText-expected.txt:
        * fast/dom/css-selectorText.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-15 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Fri, 16 Jan 2009 03:20:35 +0000 (03:20 +0000)]
2009-01-15  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff Garen.

        On x86-64 allow JSImmediate to encode 64-bit double precision values.
        This patch only affects builds that set USE(ALTERNATE_JSIMMEDIATE).
        Updates the implementation of JSValuePtr:: and JSImmediate:: methods
        that operate on neumeric values to be be aware of the new representation.
        When this representation is in use, the class JSNumberCell is redundant
        and is compiled out.

        The format of the new immediate representation is documented in JSImmediate.h.

        * JavaScriptCore.exp:
        * assembler/MacroAssembler.h:
        (JSC::MacroAssembler::subPtr):
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::):
        (JSC::X86Assembler::subq_rr):
        (JSC::X86Assembler::movq_rr):
        (JSC::X86Assembler::ucomisd_rr):
        (JSC::X86Assembler::X86InstructionFormatter::twoByteOp64):
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::cti_op_stricteq):
        (JSC::Interpreter::cti_op_nstricteq):
        * jit/JIT.cpp:
        (JSC::JIT::compileOpStrictEq):
        (JSC::JIT::privateCompileMainPass):
        (JSC::JIT::privateCompileSlowCases):
        * jit/JIT.h:
        * jit/JITArithmetic.cpp:
        (JSC::JIT::compileFastArith_op_lshift):
        (JSC::JIT::compileFastArith_op_rshift):
        (JSC::JIT::compileFastArith_op_bitand):
        (JSC::JIT::compileFastArith_op_mod):
        (JSC::JIT::compileFastArith_op_add):
        (JSC::JIT::compileFastArith_op_mul):
        (JSC::JIT::compileFastArith_op_post_inc):
        (JSC::JIT::compileFastArith_op_post_dec):
        (JSC::JIT::compileFastArith_op_pre_inc):
        (JSC::JIT::compileFastArith_op_pre_dec):
        (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate):
        (JSC::JIT::compileBinaryArithOp):
        * jit/JITInlineMethods.h:
        (JSC::JIT::emitJumpIfBothJSCells):
        (JSC::JIT::emitJumpIfEitherNumber):
        (JSC::JIT::emitJumpIfNotEitherNumber):
        (JSC::JIT::emitJumpIfImmediateIntegerNumber):
        (JSC::JIT::emitJumpIfNotImmediateIntegerNumber):
        (JSC::JIT::emitJumpIfNotImmediateIntegerNumbers):
        (JSC::JIT::emitJumpSlowCaseIfNotImmediateIntegerNumber):
        (JSC::JIT::emitJumpSlowCaseIfNotImmediateIntegerNumbers):
        (JSC::JIT::emitFastArithDeTagImmediate):
        (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
        (JSC::JIT::emitFastArithReTagImmediate):
        (JSC::JIT::emitFastArithIntToImmNoCheck):
        * runtime/JSCell.h:
        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData):
        * runtime/JSImmediate.cpp:
        (JSC::JSImmediate::toThisObject):
        (JSC::JSImmediate::toObject):
        (JSC::JSImmediate::toString):
        * runtime/JSImmediate.h:
        (JSC::wtf_reinterpret_cast):
        (JSC::JSImmediate::isNumber):
        (JSC::JSImmediate::isIntegerNumber):
        (JSC::JSImmediate::isDoubleNumber):
        (JSC::JSImmediate::isPositiveIntegerNumber):
        (JSC::JSImmediate::areBothImmediateIntegerNumbers):
        (JSC::JSImmediate::makeInt):
        (JSC::JSImmediate::makeDouble):
        (JSC::JSImmediate::doubleValue):
        (JSC::doubleToBoolean):
        (JSC::JSImmediate::toBoolean):
        (JSC::JSImmediate::getTruncatedUInt32):
        (JSC::JSImmediate::makeOutOfIntegerRange):
        (JSC::JSImmediate::from):
        (JSC::JSImmediate::getTruncatedInt32):
        (JSC::JSImmediate::toDouble):
        (JSC::JSImmediate::getUInt32):
        (JSC::JSValuePtr::isInt32Fast):
        (JSC::JSValuePtr::isUInt32Fast):
        (JSC::JSValuePtr::areBothInt32Fast):
        (JSC::JSFastMath::canDoFastBitwiseOperations):
        (JSC::JSFastMath::xorImmediateNumbers):
        (JSC::JSFastMath::canDoFastRshift):
        (JSC::JSFastMath::canDoFastUrshift):
        (JSC::JSFastMath::rightShiftImmediateNumbers):
        (JSC::JSFastMath::canDoFastAdditiveOperations):
        (JSC::JSFastMath::addImmediateNumbers):
        (JSC::JSFastMath::subImmediateNumbers):
        * runtime/JSNumberCell.cpp:
        (JSC::jsNumberCell):
        * runtime/JSNumberCell.h:
        (JSC::createNumberStructure):
        (JSC::isNumberCell):
        (JSC::asNumberCell):
        (JSC::jsNumber):
        (JSC::JSValuePtr::isDoubleNumber):
        (JSC::JSValuePtr::getDoubleNumber):
        (JSC::JSValuePtr::isNumber):
        (JSC::JSValuePtr::uncheckedGetNumber):
        (JSC::jsNaN):
        (JSC::JSValuePtr::getNumber):
        (JSC::JSValuePtr::numberToInt32):
        (JSC::JSValuePtr::numberToUInt32):
        * runtime/JSValue.h:
        * runtime/NumberConstructor.cpp:
        (JSC::numberConstructorNegInfinity):
        (JSC::numberConstructorPosInfinity):
        (JSC::numberConstructorMaxValue):
        (JSC::numberConstructorMinValue):
        * runtime/NumberObject.cpp:
        (JSC::constructNumber):
        * runtime/NumberObject.h:
        * runtime/Operations.h:
        (JSC::JSValuePtr::equal):
        (JSC::JSValuePtr::equalSlowCaseInline):
        (JSC::JSValuePtr::strictEqual):
        (JSC::JSValuePtr::strictEqualSlowCaseInline):
        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
justin.garcia@apple.com [Fri, 16 Jan 2009 02:15:11 +0000 (02:15 +0000)]
WebCore:

2009-01-15  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/6444148> Styling a selection that ends in a line break can sometimes style what's after the break

        If the range to style ended at [node, 0] or inside node (and if for some reason the node didn't get split),
        applyInlineStyle would style node.

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyInlineStyle): Rename pastLast to pastEndNode, since it doesn't come from
        Range::pastLastNode() anymore.  pastEndNode is the node after the last one that is fully selected, since
        the work done in the loop that follows should only be performed on fully selected nodes.
        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::doApply): Explicitly handle insertion into containers and after non-text nodes.
        Those were handled accidently before.
        * editing/htmlediting.cpp:
        (WebCore::caretMaxOffset): In various places we call this with a container and expect to be given the number
        of children in that container, so I changed it to match that.  RenderBR and RenderObject::caretMaxOffset() should
        also be eliminated since maxDeepOffset handles non-text nodes.

LayoutTests:

2009-01-15  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/6444148> Styling a selection that ends in a line break can sometimes style what's after the break

        * editing/execCommand/6444148-expected.txt: Added.
        * editing/execCommand/6444148.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-15 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 16 Jan 2009 00:53:41 +0000 (00:53 +0000)]
2009-01-15  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        <rdar://problem/6045018>
        REGRESSION (r34838): JavaScript objects appear to be leaked after loading google.com

        Subtract the number of JSStrings cached in SmallStrings when calculating the
        number of live JSObjects.

        * runtime/Collector.cpp:
        (JSC::Heap::objectCount):
        * runtime/SmallStrings.cpp:
        (JSC::SmallStrings::count):
        * runtime/SmallStrings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-15 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 16 Jan 2009 00:29:38 +0000 (00:29 +0000)]
2009-01-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoffrey Garen.

        Get rid of the dreaded BindingLanguage once and for all. Also get rid of Instance::getInstance.

        * bridge/c/c_instance.h:
        * bridge/jni/jni_instance.h:
        * bridge/objc/objc_instance.h:
        * bridge/qt/qt_instance.h:
        * bridge/runtime.cpp:
        * bridge/runtime.h:
        * bridge/runtime_object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-15 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 16 Jan 2009 00:24:24 +0000 (00:24 +0000)]
2009-01-15  Sam Weinig  <sam@webkit.org>

        Fix Qt build.

        * runtime/Collector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-15 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 16 Jan 2009 00:03:00 +0000 (00:03 +0000)]
2009-01-15  David Hyatt  <hyatt@apple.com>

        Eliminate an extra virtual function call that occurs for every single RenderText by moving the SVG-specific
        code that was placed into RenderText::styleDidChange into RenderSVGInlineText::styleDidChange.

        Reviewed by Oliver Hunt

        * rendering/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::styleDidChange):
        * rendering/RenderSVGInlineText.h:
        * rendering/RenderText.cpp:
        (WebCore::RenderText::styleDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-15 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 16 Jan 2009 00:01:41 +0000 (00:01 +0000)]
2009-01-15  Anders Carlsson  <andersca@apple.com>

        Another attempt at fixing the Qt build.

        * bridge/qt/qt_instance.cpp:
        (JSC::Bindings::QtInstance::getOwnPropertySlot):
        (JSC::Bindings::QtInstance::put):
        * bridge/qt/qt_instance.h:
        * bridge/runtime.h:
        (JSC::Bindings::Instance::getOwnPropertySlot):
        (JSC::Bindings::Instance::put):
        * bridge/runtime_object.cpp:
        (JSC::RuntimeObjectImp::getOwnPropertySlot):
        (JSC::RuntimeObjectImp::put):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-15 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 15 Jan 2009 23:49:55 +0000 (23:49 +0000)]
2009-01-15  Sam Weinig  <sam@webkit.org>

        Reviewed by Gavin Barraclough.

        Fix crash seen running fast/canvas.

        Make sure to mark the ScopeNode and CodeBlock being created
        in the re-parse for exception information.

        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
        * parser/Nodes.h:
        (JSC::ScopeNode::mark):
        * runtime/Collector.cpp:
        (JSC::Heap::collect):
        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData):
        * runtime/JSGlobalData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-15 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 15 Jan 2009 23:48:25 +0000 (23:48 +0000)]
2009-01-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Add QtInstance::getInstance and start using it.

        * bridge/qt/qt_instance.cpp:
        (JSC::Bindings::QtRuntimeObjectImp::mark):
        (JSC::Bindings::QtRuntimeObjectImp::classInfo):
        (JSC::Bindings::):
        (JSC::Bindings::QtInstance::getInstance):
        * bridge/qt/qt_instance.h:
        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::convertValueToQVariant):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-15 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 15 Jan 2009 23:38:59 +0000 (23:38 +0000)]
2009-01-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add the ability for Instance objects to override getOwnPropertySlot/put for runtime objects.

        * bridge/qt/qt_instance.cpp:
        (JSC::Bindings::QtInstance::getOwnPropertySlot):
        (JSC::Bindings::QtInstance::put):
        * bridge/qt/qt_instance.h:
        * bridge/runtime.h:
        (JSC::Bindings::Instance::getOwnPropertySlot):
        (JSC::Bindings::Instance::put):
        * bridge/runtime_object.cpp:
        (JSC::RuntimeObjectImp::getOwnPropertySlot):
        (JSC::RuntimeObjectImp::put):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-15 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 15 Jan 2009 23:30:00 +0000 (23:30 +0000)]
2009-01-15  Anders Carlsson  <andersca@apple.com>

        Fix the QT build.

        * bridge/qt/qt_instance.cpp:
        (JSC::Bindings::QtInstance::createRuntimeObject):
        * bridge/qt/qt_instance.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-15 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 15 Jan 2009 23:11:14 +0000 (23:11 +0000)]
2009-01-15  David Hyatt  <hyatt@apple.com>

        Fix for <rdar://problem/6500278> REGRESSION: 3.5% of samples on iBench in WebCore::Frame::setZoomFactor

        setZoomFactor was supposed to bail if both the zoom factor and mode were the same.  The mode check was
        buggy and doing the wrong thing.

        Reviewed by Darin Adler

        * page/Frame.cpp:
        (WebCore::Frame::setZoomFactor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-15 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 15 Jan 2009 22:58:07 +0000 (22:58 +0000)]
2009-01-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoffrey Garen.

        Make Instance::createRuntimeObject a virtual function and override it for QtInstance.

        * bindings/js/JSPluginElementFunctions.cpp:
        (WebCore::getRuntimeObject):
        * bridge/c/c_utility.cpp:
        (JSC::Bindings::convertNPVariantToValue):
        * bridge/jni/jni_instance.cpp:
        (JavaInstance::invokeMethod):
        * bridge/jni/jni_jsobject.mm:
        (JavaJSObject::convertJObjectToValue):
        * bridge/jni/jni_runtime.cpp:
        (JavaField::valueFromInstance):
        (JavaArray::valueAt):
        * bridge/objc/objc_utility.mm:
        (JSC::Bindings::convertObjcValueToValue):
        * bridge/qt/qt_instance.cpp:
        (JSC::Bindings::QtInstance::getRuntimeObject):
        (JSC::Bindings::QtInstance::createRuntimeObject):
        * bridge/qt/qt_instance.h:
        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::convertQVariantToValue):
        (JSC::Bindings::QtConnectionObject::execute):
        * bridge/runtime.cpp:
        (JSC::Bindings::Instance::createRuntimeObject):
        * bridge/runtime.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-15 Craig Schlenter <craig.schlenter@gmail.com>
ap@webkit.org [Thu, 15 Jan 2009 21:31:59 +0000 (21:31 +0000)]
2009-01-15  Craig Schlenter  <craig.schlenter@gmail.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=23347
        Compilation of JavaScriptCore/wtf/ThreadingPthreads.cpp fails on Linux

        * wtf/ThreadingPthreads.cpp: included limits.h as INT_MAX is defined there.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-15 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 15 Jan 2009 21:30:17 +0000 (21:30 +0000)]
2009-01-15  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=23354
        Fix up graphics/chromium files to account for Uniscribe style scrubbing.

        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::windowsCanHandleTextDrawing):
        (WebCore::Font::selectionRectForComplexText):
        (WebCore::Font::drawComplexText):
        (WebCore::Font::floatWidthForComplexText):
        (WebCore::Font::offsetForPositionForComplexText):
        * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
        (WebCore::fillNonBMPGlyphs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-15 David Levin <levin@chromium.org>
dglazkov@chromium.org [Thu, 15 Jan 2009 21:24:18 +0000 (21:24 +0000)]
2009-01-15  David Levin  <levin@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=23333
        Adjust due to a name change that happened in a WebKit.

        * svg/graphics/skia/SVGPaintServerPatternSkia.cpp:
        (WebCore::SVGPaintServerPattern::setup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 23225: REGRESSION: Assertion failure in reparseInPlace() (m_sourceElements) at...
oliver@apple.com [Thu, 15 Jan 2009 21:15:24 +0000 (21:15 +0000)]
Bug 23225: REGRESSION: Assertion failure in reparseInPlace() (m_sourceElements) at sfgate.com
<https://bugs.webkit.org/show_bug.cgi?id=23225> <rdar://problem/6487432>

Reviewed by Geoff Garen

Character position for open and closing brace was incorrectly referencing m_position to
record their position in a source document, however this is unsafe as BOMs may lead to
m_position being an arbitrary position from the real position of the current character.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-15 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 15 Jan 2009 20:52:05 +0000 (20:52 +0000)]
2009-01-15  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23340
        Add remaining bits of graphics/chromium.

        * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Added.
        (WebCore::scaleEmToUnits):
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::platformDestroy):
        (WebCore::SimpleFontData::smallCapsFontData):
        (WebCore::SimpleFontData::containsCharacters):
        (WebCore::SimpleFontData::determinePitch):
        (WebCore::SimpleFontData::platformWidthForGlyph):
        * platform/graphics/chromium/SimpleFontDataLinux.cpp: Added.
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::platformDestroy):
        (WebCore::SimpleFontData::smallCapsFontData):
        (WebCore::SimpleFontData::containsCharacters):
        (WebCore::SimpleFontData::determinePitch):
        (WebCore::SimpleFontData::platformWidthForGlyph):
        * platform/graphics/chromium/ThemeHelperChromiumWin.cpp: Added.
        (WebCore::ThemeHelperWin::ThemeHelperWin):
        (WebCore::ThemeHelperWin::~ThemeHelperWin):
        * platform/graphics/chromium/ThemeHelperChromiumWin.h: Added.
        (WebCore::ThemeHelperWin::):
        (WebCore::ThemeHelperWin::context):
        (WebCore::ThemeHelperWin::rect):
        * platform/graphics/chromium/UniscribeHelper.cpp: Added.
        (WebCore::treatAsSpace):
        (WebCore::containsMissingGlyphs):
        (WebCore::setLogFontAndStyle):
        (WebCore::UniscribeHelper::UniscribeHelper):
        (WebCore::UniscribeHelper::~UniscribeHelper):
        (WebCore::UniscribeHelper::initWithOptionalLengthProtection):
        (WebCore::UniscribeHelper::width):
        (WebCore::UniscribeHelper::justify):
        (WebCore::UniscribeHelper::characterToX):
        (WebCore::UniscribeHelper::xToCharacter):
        (WebCore::UniscribeHelper::draw):
        (WebCore::UniscribeHelper::firstGlyphForCharacter):
        (WebCore::UniscribeHelper::fillRuns):
        (WebCore::UniscribeHelper::shape):
        (WebCore::UniscribeHelper::fillShapes):
        (WebCore::UniscribeHelper::fillScreenOrder):
        (WebCore::UniscribeHelper::adjustSpaceAdvances):
        (WebCore::UniscribeHelper::applySpacing):
        (WebCore::UniscribeHelper::advanceForItem):
        * platform/graphics/chromium/UniscribeHelper.h: Added.
        (WebCore::UniscribeHelper::directionalOverride):
        (WebCore::UniscribeHelper::setDirectionalOverride):
        (WebCore::UniscribeHelper::inhibitLigate):
        (WebCore::UniscribeHelper::setInhibitLigate):
        (WebCore::UniscribeHelper::letterSpacing):
        (WebCore::UniscribeHelper::setLetterSpacing):
        (WebCore::UniscribeHelper::spaceWidth):
        (WebCore::UniscribeHelper::setSpaceWidth):
        (WebCore::UniscribeHelper::wordSpacing):
        (WebCore::UniscribeHelper::setWordSpacing):
        (WebCore::UniscribeHelper::setAscent):
        (WebCore::UniscribeHelper::init):
        (WebCore::UniscribeHelper::tryToPreloadFont):
        (WebCore::UniscribeHelper::Shaping::Shaping):
        (WebCore::UniscribeHelper::Shaping::glyphLength):
        (WebCore::UniscribeHelper::Shaping::charLength):
        (WebCore::UniscribeHelper::Shaping::effectiveAdvances):
        (WebCore::UniscribeHelper::nextWinFontData):
        (WebCore::UniscribeHelper::resetFontIndex):
        * platform/graphics/chromium/UniscribeHelperTextRun.cpp: Added.
        (WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun):
        (WebCore::UniscribeHelperTextRun::tryToPreloadFont):
        (WebCore::UniscribeHelperTextRun::nextWinFontData):
        (WebCore::UniscribeHelperTextRun::resetFontIndex):
        * platform/graphics/chromium/UniscribeHelperTextRun.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-15 Adele Peterson <adele@apple.com>
adele@apple.com [Thu, 15 Jan 2009 19:54:29 +0000 (19:54 +0000)]
2009-01-15  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=21799
        <rdar://problem/6310684> Crash in dumpFramesAsText() when running http/tests/security/cross-origin-xsl-BLOCKED.html

        Return S_OK or E_FAIL based on the result from CreateInstance.
        This was causing DumpRenderTree to not realize it had just gotten a null documentElement.

        * DOMCoreClasses.cpp: Made all functions that return the result of CreateInstance consistent.
        (DOMNode::parentNode):
        (DOMNode::ownerDocument):
        (DOMNodeList::item):
        (DOMDocument::documentElement):
        (DOMDocument::createElement):
        (DOMDocument::getElementsByTagName):
        (DOMDocument::getElementsByTagNameNS):
        (DOMDocument::getElementById):
        (DOMDocument::getComputedStyle):
        (DOMDocument::createEvent):
        (DOMElement::style):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Fixed Windows project file after https://bugs.webkit.org/show_bug.cgi?id=21421
cmarrin@apple.com [Thu, 15 Jan 2009 19:44:46 +0000 (19:44 +0000)]
   Fixed Windows project file after https://bugs.webkit.org/show_bug.cgi?id=21421

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-15 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 15 Jan 2009 19:25:29 +0000 (19:25 +0000)]
2009-01-15  Brady Eidson  <beidson@apple.com>

        Reviewed by Dan Bernstein

        Fix problem where a URL visited as non-GET once is flagged as non-GET forever.

        * History/WebHistory.mm:
        (-[WebHistory _visitedURL:withTitle:method:wasFailure:]): Always update the HTTPNonGet
          flag for all loads with an HTTP Method

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-15 Aaron Boodman <aa@chromium.org>
dglazkov@chromium.org [Thu, 15 Jan 2009 19:25:15 +0000 (19:25 +0000)]
2009-01-15  Aaron Boodman  <aa@chromium.org>

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=15279
        Right clicking over text (or multiple spaces) auto selects the word
        (or multiple spaces) under it, which is not a desirable effect for some
        platforms.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::sendContextMenuEvent):
        Don't select words on right-click on Chromium.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoVersioning.
mrowe@apple.com [Thu, 15 Jan 2009 19:08:15 +0000 (19:08 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-15 Darin Fisher <darin@chromium.org>
darin@chromium.org [Thu, 15 Jan 2009 09:27:52 +0000 (09:27 +0000)]
2009-01-15  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23345
        SharedBuffer.h should include wtf/OwnPtr.h

        * platform/SharedBuffer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Bug 23338: Make "Streamline Inspector Source" build script check for a direct...
ddkilzer@apple.com [Thu, 15 Jan 2009 05:46:30 +0000 (05:46 +0000)]
    Bug 23338: Make "Streamline Inspector Source" build script check for a directory before using it

        <https://bugs.webkit.org/show_bug.cgi?id=23338>

        Reviewed by Timothy Hatcher.

        * WebCore.xcodeproj/project.pbxproj: Check to see if
        "${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector"
        exists before trying to change directories into it and then
        deleting, modifying and adding files to it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Bug 23153: JSC build always touches JavaScriptCore/docs/bytecode.html
ddkilzer@apple.com [Thu, 15 Jan 2009 05:40:30 +0000 (05:40 +0000)]
    Bug 23153: JSC build always touches JavaScriptCore/docs/bytecode.html

        <https://bugs.webkit.org/show_bug.cgi?id=23153>

        Reviewed by Darin Adler.

        Instead of building bytecode.html into ${SRCROOT}/docs/bytecode.html, build it
        into ${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore/docs/bytecode.html.

        Also fixes make-bytecode-docs.pl to actually generate documentation.

        * DerivedSources.make: Changed bytecode.html to be built into local docs
        directory in ${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore.
        * JavaScriptCore.xcodeproj/project.pbxproj: Added "/docs" to the end of the
        "mkdir -p" command so that the docs subdirectory is automatically created.
        * docs/make-bytecode-docs.pl: Changed BEGIN_OPCODE to DEFINE_OPCODE so that
        documentation is actually generated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Thu, 15 Jan 2009 05:24:25 +0000 (05:24 +0000)]
Reviewed by Kevin Ollivier.

Fixing wx compilation for wx 2.9/trunk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowx build fix. Adding WebKitCSSMatrix.
kevino@webkit.org [Thu, 15 Jan 2009 05:05:53 +0000 (05:05 +0000)]
wx build fix. Adding WebKitCSSMatrix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoProspective build fix for Qt following r39922.
treat@webkit.org [Thu, 15 Jan 2009 03:27:44 +0000 (03:27 +0000)]
Prospective build fix for Qt following r39922.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Updated layout test results after adding WebKitCSSMatrix (r39922)
ddkilzer@apple.com [Thu, 15 Jan 2009 02:52:15 +0000 (02:52 +0000)]
    Updated layout test results after adding WebKitCSSMatrix (r39922)

        * fast/dom/Window/window-properties-expected.txt:
        * fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-14 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 15 Jan 2009 02:30:48 +0000 (02:30 +0000)]
2009-01-14  Darin Adler  <darin@apple.com>

        Fix debug build.

        * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
        (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
        Use ASSERT_UNUSED.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-14 Pierre-Olivier Latour <pol@apple.com>
pol@apple.com [Thu, 15 Jan 2009 02:16:44 +0000 (02:16 +0000)]
2009-01-14  Pierre-Olivier Latour  <pol@apple.com>

        Added missing reference images for pixel tests (generated on iMac Intel with 10.5.5 + QT 7.5.5).

        * platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.checksum: Added.
        * platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
        * platform/mac/fast/events/pointer-events-2-expected.checksum: Added.
        * platform/mac/fast/events/pointer-events-2-expected.png: Added.
        * platform/mac/fast/events/pointer-events-expected.checksum: Added.
        * platform/mac/fast/events/pointer-events-expected.png: Added.
        * platform/mac/fast/media/mq-animation-expected.checksum: Added.
        * platform/mac/fast/media/mq-animation-expected.png: Added.
        * platform/mac/fast/media/mq-transform-01-expected.checksum: Added.
        * platform/mac/fast/media/mq-transform-01-expected.png: Added.
        * platform/mac/fast/media/mq-transform-02-expected.checksum: Added.
        * platform/mac/fast/media/mq-transform-02-expected.png: Added.
        * platform/mac/fast/media/mq-transform-03-expected.checksum: Added.
        * platform/mac/fast/media/mq-transform-03-expected.png: Added.
        * platform/mac/fast/media/mq-transform-04-expected.checksum: Added.
        * platform/mac/fast/media/mq-transform-04-expected.png: Added.
        * platform/mac/fast/media/mq-transition-expected.checksum: Added.
        * platform/mac/fast/media/mq-transition-expected.png: Added.
        * platform/mac/http/tests/security: Added.
        * platform/mac/http/tests/security/dataTransfer-set-data-file-url-expected.checksum: Added.
        * platform/mac/http/tests/security/dataTransfer-set-data-file-url-expected.png: Added.
        * platform/mac/http/tests/webarchive: Added.
        * platform/mac/http/tests/webarchive/test-css-url-encoding-expected.checksum: Added.
        * platform/mac/http/tests/webarchive/test-css-url-encoding-expected.png: Added.
        * platform/mac/http/tests/webarchive/test-css-url-encoding-shift-jis-expected.checksum: Added.
        * platform/mac/http/tests/webarchive/test-css-url-encoding-shift-jis-expected.png: Added.
        * platform/mac/http/tests/webarchive/test-css-url-encoding-utf-8-expected.checksum: Added.
        * platform/mac/http/tests/webarchive/test-css-url-encoding-utf-8-expected.png: Added.
        * platform/mac/http/tests/webarchive/test-preload-resources-expected.checksum: Added.
        * platform/mac/http/tests/webarchive/test-preload-resources-expected.png: Added.
        * platform/mac/media/video-zoom-expected.checksum: Added.
        * platform/mac/media/video-zoom-expected.png: Added.
        * platform/mac/webarchive/test-css-url-resources-in-stylesheets-expected.checksum: Added.
        * platform/mac/webarchive/test-css-url-resources-in-stylesheets-expected.png: Added.
        * platform/mac/webarchive/test-css-url-resources-inline-styles-expected.checksum: Added.
        * platform/mac/webarchive/test-css-url-resources-inline-styles-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
adele@apple.com [Thu, 15 Jan 2009 02:05:25 +0000 (02:05 +0000)]
WebCore:

2009-01-14  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23335
        <rdar://problem/6247650> Update <input type="search"> for RenderThemeWin

        No new tests added.  In the future, we need to update DumpRenderTree to be able to run with different RenderThemes and
        we'll need a separate set of results for different themes.

        * css/themeWin.css: Renable search fields.  Added new rules for sub-element placement.

        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::textBlockWidth): Consider margin set on the sub-elements when computing the
        desired width for the text block.

        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::supportsFocus): Treat SearchFieldPart the same as TextFieldPart.
        (WebCore::RenderThemeWin::determineState): ditto.
        (WebCore::RenderThemeWin::getClassicThemeData): ditto.
        (WebCore::RenderThemeWin::getThemeData): ditto.
        (WebCore::RenderThemeWin::paintSearchFieldCancelButton): Draw a scaled, vertically centered, version of the new artwork.
        (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration): ditto.
        (WebCore::RenderThemeWin::paintSearchFieldResultsButton): ditto.
        (WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle): Set the scaled width and height.
        (WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationStyle): ditto.
        (WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle): ditto.

WebKit/win:

2009-01-14  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23335
        <rdar://problem/6247650> Update <input type="search"> for RenderThemeWin

        Added artwork.

        * WebKit.vcproj/WebKit.rc:
        * WebKit.vcproj/WebKit.vcproj:
        * WebKit.vcproj/resource.h:
        * WebKit.vcproj/searchCancel.png: Added.
        * WebKit.vcproj/searchCancelPressed.png: Added.
        * WebKit.vcproj/searchMagnifier.png: Added.
        * WebKit.vcproj/searchMagnifierResults.png: Added.
        * WebKitDLL.cpp:(loadResourceIntoBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-14 Alp Toker <alp@nuanti.com>
alp@webkit.org [Thu, 15 Jan 2009 01:53:00 +0000 (01:53 +0000)]
2009-01-14  Alp Toker  <alp@nuanti.com>

        GTK+ build fix following r39922.
        Add WebKitCSSMatrix to the build system.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Implemented 2D WebKitCSSMatrix
cmarrin@apple.com [Thu, 15 Jan 2009 01:29:37 +0000 (01:29 +0000)]
    Implemented 2D WebKitCSSMatrix
        https://bugs.webkit.org/show_bug.cgi?id=21421

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-14 Michael Moss <mmoss@chromium.org>
eric@webkit.org [Thu, 15 Jan 2009 00:55:06 +0000 (00:55 +0000)]
2009-01-14  Michael Moss  <mmoss@chromium.org>

        Reviewed by Eric Seidel.

        Workaround a skia limitation on repeated patterns, and remove extra
        transformations applied to pattern.
        https://bugs.webkit.org/show_bug.cgi?id=23332

        Fixes:
        LayoutTests/fast/canvas/patternfill-repeat.html
        LayoutTests/svg/W3C-SVG-1.1/pservers-grad-06-b.svg

        * platform/graphics/skia/PatternSkia.cpp:
        (WebCore::Pattern::createPlatformPattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-14 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 15 Jan 2009 00:31:31 +0000 (00:31 +0000)]
2009-01-14  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Implement InvokeDefault, Construct, GetProperty and SetProperty.

        Fully implement marshalValue.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCInvokeDefault):
        (WKPCConstruct):
        (WKPCGetProperty):
        (WKPCSetProperty):
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::evaluate):
        (WebKit::NetscapePluginInstanceProxy::invoke):
        (WebKit::NetscapePluginInstanceProxy::invokeDefault):
        (WebKit::NetscapePluginInstanceProxy::construct):
        (WebKit::NetscapePluginInstanceProxy::getProperty):
        (WebKit::NetscapePluginInstanceProxy::setProperty):
        (WebKit::NetscapePluginInstanceProxy::marshalValue):
        (WebKit::NetscapePluginInstanceProxy::demarshalValue):
        * Plugins/Hosted/WebKitPluginClient.defs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix https://bugs.webkit.org/show_bug.cgi?id=23334
mrowe@apple.com [Thu, 15 Jan 2009 00:26:46 +0000 (00:26 +0000)]
Fix https://bugs.webkit.org/show_bug.cgi?id=23334
Bug 23334: Compile failure in XMLTokenizerLibxml2.cpp

Include wtf/UnusedParam.h to get UNUSED_PARAM.

* dom/XMLTokenizerLibxml2.cpp:
(WebCore::hackAroundLibXMLEntityBug):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-14 David Levin <levin@chromium.org>
dglazkov@chromium.org [Wed, 14 Jan 2009 23:50:17 +0000 (23:50 +0000)]
2009-01-14  David Levin  <levin@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=23333
        Platform code fixes. These compensate for changes in platform
        callbacks from WebKit and minor API tweaks.

        I enumerated a few below.

        * platform/graphics/chromium/FontCacheChromiumWin.cpp:
        fontExists has been gone since r34794.

        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::paintSkBitmap):

        (WebCore::FrameData::clear):
        r39751 changes this api to take and return a bool.

        (WebCore::Image::drawPattern):
        * platform/graphics/skia/PathSkia.cpp:
        (WebCore::Path::apply):
        (WebCore::boundingBoxForCurrentStroke):
        (WebCore::Path::strokeContains):
        * svg/graphics/skia/RenderPathSkia.cpp: Removed due to r39805.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix for Qt from Dmitry Titov.
treat@webkit.org [Wed, 14 Jan 2009 23:40:56 +0000 (23:40 +0000)]
Build fix for Qt from Dmitry Titov.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-14 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 14 Jan 2009 23:37:04 +0000 (23:37 +0000)]
2009-01-14  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Demarshal arguments and pass them to the JS call.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCInvoke):
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::invoke):
        (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
        (WebKit::NetscapePluginInstanceProxy::demarshalValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-14 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 14 Jan 2009 23:22:06 +0000 (23:22 +0000)]
2009-01-14  Darin Adler  <darin@apple.com>

        Reviewed by Beth Dakin.

        Try to fix regression test failures seen on Leopard; possibly new to 10.5.6.

        * http/tests/misc/willCacheResponse-delegate-callback-expected.txt: Removed.
        This test has enough Mac specifics in it that I don't think it makes sense to have cross-platform results.

        * platform/mac-tiger/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
        Copied from http/tests/misc/willCacheResponse-delegate-callback-expected.txt.

        * platform/mac/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
        Copied from http/tests/misc/willCacheResponse-delegate-callback-expected.txt.
        Updated with non-Tiger results. The order of delegate calls has changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago BUILD FIX: Use COM API on Windows in LayoutTestController::setIconDatabaseEna...
ddkilzer@apple.com [Wed, 14 Jan 2009 23:19:19 +0000 (23:19 +0000)]
    BUILD FIX: Use COM API on Windows in LayoutTestController::setIconDatabaseEnabled()

        Rubber-stamped by Alice Liu.

        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::setIconDatabaseEnabled): Use COM API
        to get the shared WebIconDatabase.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/6496520> REGRESSION: In Mail, a crash occurs when attempting to displ...
mrowe@apple.com [Wed, 14 Jan 2009 22:26:03 +0000 (22:26 +0000)]
<rdar://problem/6496520> REGRESSION: In Mail, a crash occurs when attempting to display a mail message

Move WebArchive and WebResource to use the same approach for initializing themselves on the main thread
that WebView uses.

Reviewed by Timothy Hatcher.

* WebView/WebArchive.mm:
(-[WebArchive initWithMainResource:subresources:subframeArchives:]): Use _webkit_performSelectorOnMainThread:withObject:.
(-[WebArchive _initWithArguments:]):
* WebView/WebResource.mm:
(-[WebResource _initWithArguments:]): Unbox the BOOL argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-14 Jeremy Moskovich <jeremy@chromium.org>
eric@webkit.org [Wed, 14 Jan 2009 22:22:29 +0000 (22:22 +0000)]
2009-01-14  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Eric Seidel.

        <https://bugs.webkit.org/show_bug.cgi?id=16829>
        Implement NPN_SetException()

        This mirrors the implementation in the obj-c bindings.

        Test: plugins/netscape-throw-exception.html

        * bridge/NP_jsobject.cpp:
        (_NPN_SetException):
        * bridge/c/c_instance.cpp:
        (JSC::Bindings::getExceptionString):
        (JSC::Bindings::CInstance::setGlobalException):
        (JSC::Bindings::CInstance::moveGlobalExceptionToExecState):
        (JSC::Bindings::CInstance::invokeMethod):
        (JSC::Bindings::CInstance::invokeDefaultMethod):
        (JSC::Bindings::CInstance::invokeConstruct):
        (JSC::Bindings::CInstance::getPropertyNames):
        * bridge/c/c_instance.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Disabling webarchive/test-link-rel-icon.html due to various buildbot failures
ddkilzer@apple.com [Wed, 14 Jan 2009 22:18:24 +0000 (22:18 +0000)]
    Disabling webarchive/test-link-rel-icon.html due to various buildbot failures

        Bug 23331: LayoutTests/webarchive/test-link-rel-icon.html fails in different ways on buildbots
        <https://bugs.webkit.org/show_bug.cgi?id=23331>

        * webarchive/test-link-rel-icon.html: Removed.
        * webarchive/test-link-rel-icon.html-disabled: Renamed from LayoutTests/webarchive/test-link-rel-icon.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 22903: REGRESSION (r36267): visiting this site reliably crashes WebKit nightly
oliver@apple.com [Wed, 14 Jan 2009 22:14:55 +0000 (22:14 +0000)]
Bug 22903: REGRESSION (r36267): visiting this site reliably crashes WebKit nightly

Reviewed by Cameron Zwarich

EvalCodeBlock's do not reference the functions that are declared inside the eval
code, this means that simply marking the EvalCodeBlock through the global object
is insufficient to mark the declared functions.  This patch corrects this by
explicitly marking the CodeBlocks of all the functions declared in the cached
EvalNode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-14 Pierre-Olivier Latour <pol@apple.com>
pol@apple.com [Wed, 14 Jan 2009 21:58:08 +0000 (21:58 +0000)]
2009-01-14  Pierre-Olivier Latour  <pol@apple.com>

        Fixed build warning when LIBXML_VERSION >= 20627.

        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::hackAroundLibXMLEntityBug):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-14 Dmitry Titov <dimich@chromium.org>
ap@webkit.org [Wed, 14 Jan 2009 21:57:30 +0000 (21:57 +0000)]
2009-01-14  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=23312
        Implement MessageQueue::waitForMessageTimed()
        Also fixed ThreadCondition::timedWait() to take absolute time, as discussed on webkit-dev.
        Win32 version of timedWait still has to be implemented.

        * wtf/MessageQueue.h:
        (WTF::MessageQueueWaitResult: new enum for the result of MessageQueue::waitForMessageTimed.
        (WTF::MessageQueue::waitForMessage):
        (WTF::MessageQueue::waitForMessageTimed): New method.
        * wtf/Threading.h:
        * wtf/ThreadingGtk.cpp:
        (WTF::ThreadCondition::timedWait): changed to use absolute time instead of interval.
        * wtf/ThreadingNone.cpp:
        (WTF::ThreadCondition::timedWait): ditto.
        * wtf/ThreadingPthreads.cpp:
        (WTF::ThreadCondition::timedWait): ditto.
        * wtf/ThreadingQt.cpp:
        (WTF::ThreadCondition::timedWait): ditto.
        * wtf/ThreadingWin.cpp:
        (WTF::ThreadCondition::timedWait): ditto. The actual Win32 code is still to be implemented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-13 Dmitry Titov <dimich@chromium.org>
ddkilzer@apple.com [Wed, 14 Jan 2009 21:48:23 +0000 (21:48 +0000)]
2009-01-13  Dmitry Titov  <dimich@chromium.org>

        Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=23304
        Fix svn-apply to match svn-unapply to recognize added files in 'git diff' patches.

        * Scripts/svn-apply: Added a check (similar to svn-unapply) to recognize added files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago BUILD FIX: Implement LayoutTestController::setIconDatabaseEnabled(bool) for GTK
ddkilzer@apple.com [Wed, 14 Jan 2009 21:24:02 +0000 (21:24 +0000)]
    BUILD FIX: Implement LayoutTestController::setIconDatabaseEnabled(bool) for GTK

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (runTest): Added call to reset the icon database to match Mac
        and Windows ports.
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setIconDatabaseEnabled): Implemented
        stub method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Anders Carlsson.
ap@webkit.org [Wed, 14 Jan 2009 21:13:00 +0000 (21:13 +0000)]
    Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=23326
        Resources are never deleted from application cache disk database

        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::openDatabase): Create a trigger that deletes resources when
        a cache is deleted. Note that this change doesn't require bumping schema version. We should
        consider switching to foreign keys and cascade delete instead of triggers in the future.
        (WebCore::ApplicationCacheStorage::remove): Added a comment explaining why it's sufficient
        to only remove the cache itself.
        (WebCore::ApplicationCacheStorage::empty): Don't delete from CacheResources, now that this
        is done automatically when a cache is deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Bug 22795: favicons should be saved to webarchives
ddkilzer@apple.com [Wed, 14 Jan 2009 21:08:01 +0000 (21:08 +0000)]
    Bug 22795: favicons should be saved to webarchives

        <https://bugs.webkit.org/show_bug.cgi?id=22795>

        Reviewed by Darin Adler.

WebCore:

        Test: webarchive/test-link-rel-icon.html

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::addSubresourceAttributeURLs): Do not add
        favicon URLs to the list since no ArchiveResource or CachedResource
        is ever created for them.
        * loader/archive/cf/LegacyWebArchive.cpp:
        (WebCore::LegacyWebArchive::create): Handle favicons as a special
        case for all main resources.
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::close): Actually close the SQLite database
        so that isOpen() returns false when called.  Added an ASSERT() for
        good measure.

WebKitTools:

        * DumpRenderTree/LayoutTestController.cpp:
        (setIconDatabaseEnabledCallback): Added.
        (setJavaScriptProfilingEnabledCallback): Realphabetized.
        (LayoutTestController::staticFunctions): Added entry for calling
        LayoutTestController.setIconDatabaseEnabled(bool) from JavaScript.
        * DumpRenderTree/LayoutTestController.h:
        (setIconDatabaseEnabledCallback): Added declaration.
        (setJavaScriptProfilingEnabledCallback): Realphabetized.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (runTest): Disable the icon database before each test.
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::setIconDatabaseEnabled): Added.
        (LayoutTestController::setJavaScriptProfilingEnabled): Realphabetized.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (runTest): Disable the icon database before each test.
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::setIconDatabaseEnabled): Added.

LayoutTests:

        Note that this test case contains a workaround for Bug 21026 and
        <rdar://problem/6240826> which may be removed once that is fixed.

        * webarchive/resources/favicon.ico: Copied from LayoutTests/fast/images/resources/favicon.ico.
        * webarchive/test-link-rel-icon-expected.webarchive: Added.
        * webarchive/test-link-rel-icon.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-14 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 14 Jan 2009 19:52:21 +0000 (19:52 +0000)]
2009-01-14  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23328
        Upstream remaining files from platform/chromium/

        * platform/chromium/CursorChromium.cpp:
        (WebCore::pointerCursor):
        (WebCore::crossCursor):
        (WebCore::handCursor):
        (WebCore::iBeamCursor):
        (WebCore::waitCursor):
        (WebCore::helpCursor):
        (WebCore::eastResizeCursor):
        (WebCore::northResizeCursor):
        (WebCore::northEastResizeCursor):
        (WebCore::northWestResizeCursor):
        (WebCore::southResizeCursor):
        (WebCore::southEastResizeCursor):
        (WebCore::southWestResizeCursor):
        (WebCore::westResizeCursor):
        (WebCore::northSouthResizeCursor):
        (WebCore::eastWestResizeCursor):
        (WebCore::northEastSouthWestResizeCursor):
        (WebCore::northWestSouthEastResizeCursor):
        (WebCore::columnResizeCursor):
        (WebCore::rowResizeCursor):
        (WebCore::middlePanningCursor):
        (WebCore::eastPanningCursor):
        (WebCore::northPanningCursor):
        (WebCore::northEastPanningCursor):
        (WebCore::northWestPanningCursor):
        (WebCore::southPanningCursor):
        (WebCore::southEastPanningCursor):
        (WebCore::southWestPanningCursor):
        (WebCore::westPanningCursor):
        (WebCore::moveCursor):
        (WebCore::verticalTextCursor):
        (WebCore::cellCursor):
        (WebCore::contextMenuCursor):
        (WebCore::aliasCursor):
        (WebCore::progressCursor):
        (WebCore::noDropCursor):
        (WebCore::copyCursor):
        (WebCore::noneCursor):
        (WebCore::notAllowedCursor):
        (WebCore::zoomInCursor):
        (WebCore::zoomOutCursor):
        * platform/chromium/DragDataRef.h: Added.
        * platform/chromium/DragImageChromium.cpp: Added.
        (WebCore::dragImageSize):
        (WebCore::deleteDragImage):
        (WebCore::scaleDragImage):
        (WebCore::dissolveDragImageToFraction):
        (WebCore::createDragImageFromImage):
        (WebCore::createDragImageIconForCachedImage):
        * platform/chromium/DragImageRef.h:
        * platform/chromium/KeyCodeConversion.h: Added.
        * platform/chromium/KeyCodeConversionGtk.cpp: Added.
        (WebCore::windowsKeyCodeForKeyEvent):
        * platform/chromium/KeyboardCodes.h: Added.
        * platform/chromium/KeyboardCodesPosix.h: Added.
        (WebCore::):
        * platform/chromium/KeyboardCodesWin.h: Added.
        (WebCore::):
        * platform/chromium/Language.cpp: Added.
        (WebCore::defaultLanguage):
        * platform/chromium/LinkHashChromium.cpp: Added.
        (WebCore::visitedLinkHash):
        * platform/chromium/MimeTypeRegistryChromium.cpp: Added.
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
        (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
        (WebCore::MIMETypeRegistry::getMIMETypeForPath):
        (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding):
        (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedMediaMIMEType):
        (WebCore::MIMETypeRegistry::isJavaAppletMIMEType):
        (WebCore::dummyHashSet):
        (WebCore::MIMETypeRegistry::getSupportedImageMIMETypes):
        (WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes):
        (WebCore::MIMETypeRegistry::getSupportedImageMIMETypesForEncoding):
        (WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes):
        (WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes):
        * platform/chromium/PasteboardChromium.cpp: Added.
        (WebCore::Pasteboard::generalPasteboard):
        (WebCore::Pasteboard::Pasteboard):
        (WebCore::Pasteboard::clear):
        (WebCore::Pasteboard::writeSelection):
        (WebCore::Pasteboard::writeURL):
        (WebCore::Pasteboard::writeImage):
        (WebCore::Pasteboard::canSmartReplace):
        (WebCore::Pasteboard::plainText):
        (WebCore::Pasteboard::documentFragment):
        * platform/chromium/PasteboardPrivate.h:
        * platform/chromium/PlatformCursor.h: Added.
        (WebCore::PlatformCursor::):
        (WebCore::PlatformCursor::PlatformCursor):
        (WebCore::PlatformCursor::customImage):
        (WebCore::PlatformCursor::hotSpot):
        (WebCore::PlatformCursor::type):
        * platform/chromium/PlatformKeyboardEventChromium.cpp: Added.
        (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
        (WebCore::PlatformKeyboardEvent::currentCapsLockState):
        * platform/chromium/PlatformScreenChromium.cpp: Added.
        (WebCore::screenDepth):
        (WebCore::screenDepthPerComponent):
        (WebCore::screenIsMonochrome):
        (WebCore::screenRect):
        (WebCore::screenAvailableRect):
        * platform/chromium/PlatformWidget.h:
        * platform/chromium/PopupMenuChromium.cpp: Added.
        (WebCore::PopupListBox::selectedIndex):
        (WebCore::PopupListBox::numItems):
        (WebCore::PopupListBox::setBaseWidth):
        (WebCore::PopupListBox::setTextOnIndexChange):
        (WebCore::PopupListBox::setAcceptOnAbandon):
        (WebCore::PopupListBox::):
        (WebCore::PopupListBox::ListItem::ListItem):
        (WebCore::PopupListBox::PopupListBox):
        (WebCore::PopupListBox::~PopupListBox):
        (WebCore::PopupListBox::disconnectClient):
        (WebCore::PopupListBox::scrollToRevealSelection):
        (WebCore::constructRelativeMouseEvent):
        (WebCore::constructRelativeWheelEvent):
        (WebCore::PopupContainer::create):
        (WebCore::PopupContainer::PopupContainer):
        (WebCore::PopupContainer::~PopupContainer):
        (WebCore::PopupContainer::showPopup):
        (WebCore::PopupContainer::hidePopup):
        (WebCore::PopupContainer::layout):
        (WebCore::PopupContainer::handleMouseDownEvent):
        (WebCore::PopupContainer::handleMouseMoveEvent):
        (WebCore::PopupContainer::handleMouseReleaseEvent):
        (WebCore::PopupContainer::handleWheelEvent):
        (WebCore::PopupContainer::handleKeyEvent):
        (WebCore::PopupContainer::hide):
        (WebCore::PopupContainer::paint):
        (WebCore::PopupContainer::paintBorder):
        (WebCore::PopupContainer::isInterestedInEventForKey):
        (WebCore::PopupContainer::show):
        (WebCore::PopupContainer::setTextOnIndexChange):
        (WebCore::PopupContainer::setAcceptOnAbandon):
        (WebCore::PopupContainer::refresh):
        (WebCore::PopupListBox::handleMouseDownEvent):
        (WebCore::PopupListBox::handleMouseMoveEvent):
        (WebCore::PopupListBox::handleMouseReleaseEvent):
        (WebCore::PopupListBox::handleWheelEvent):
        (WebCore::PopupListBox::isInterestedInEventForKey):
        (WebCore::PopupListBox::handleKeyEvent):
        (WebCore::PopupListBox::hostWindow):
        (WebCore::PopupListBox::invalidateRect):
        (WebCore::stripLeadingWhiteSpace):
        (WebCore::PopupListBox::typeAheadFind):
        (WebCore::PopupListBox::paint):
        (WebCore::PopupListBox::paintRow):
        (WebCore::PopupListBox::getRowFont):
        (WebCore::PopupListBox::abandon):
        (WebCore::PopupListBox::pointToRowIndex):
        (WebCore::PopupListBox::acceptIndex):
        (WebCore::PopupListBox::selectIndex):
        (WebCore::PopupListBox::setOriginalIndex):
        (WebCore::PopupListBox::getRowHeight):
        (WebCore::PopupListBox::getRowBounds):
        (WebCore::PopupListBox::invalidateRow):
        (WebCore::PopupListBox::scrollToRevealRow):
        (WebCore::PopupListBox::isSelectableItem):
        (WebCore::PopupListBox::adjustSelectedIndex):
        (WebCore::PopupListBox::updateFromElement):
        (WebCore::PopupListBox::layout):
        (WebCore::PopupListBox::clear):
        (WebCore::PopupListBox::isPointInBounds):
        (WebCore::PopupMenu::PopupMenu):
        (WebCore::PopupMenu::~PopupMenu):
        (WebCore::PopupMenu::show):
        (WebCore::PopupMenu::hide):
        (WebCore::PopupMenu::updateFromElement):
        (WebCore::PopupMenu::itemWritingDirectionIsNatural):
        * platform/chromium/PopupMenuChromium.h: Added.
        (WebCore::PopupContainer::listBox):
        * platform/chromium/PopupMenuPrivate.h: Added.
        * platform/chromium/SSLKeyGeneratorChromium.cpp: Added.
        (WebCore::supportedKeySizes):
        * platform/chromium/ScrollbarThemeChromium.cpp: Added.
        (WebCore::ScrollbarTheme::nativeTheme):
        (WebCore::ScrollbarThemeChromium::ScrollbarThemeChromium):
        (WebCore::ScrollbarThemeChromium::~ScrollbarThemeChromium):
        (WebCore::ScrollbarThemeChromium::themeChanged):
        (WebCore::ScrollbarThemeChromium::hasThumb):
        (WebCore::ScrollbarThemeChromium::backButtonRect):
        (WebCore::ScrollbarThemeChromium::forwardButtonRect):
        (WebCore::ScrollbarThemeChromium::trackRect):
        (WebCore::ScrollbarThemeChromium::paintTrackBackground):
        (WebCore::ScrollbarThemeChromium::paintTickmarks):
        (WebCore::ScrollbarThemeChromium::paintScrollCorner):
        (WebCore::ScrollbarThemeChromium::shouldCenterOnThumb):
        (WebCore::ScrollbarThemeChromium::buttonSize):
        * platform/chromium/ScrollbarThemeChromium.h: Added.
        (WebCore::ScrollbarThemeChromium::hasButtons):
        * platform/chromium/ScrollbarThemeChromiumLinux.cpp: Added.
        (WebCore::ScrollbarThemeChromium::scrollbarThickness):
        (WebCore::ScrollbarThemeChromium::invalidateOnMouseEnterExit):
        (WebCore::initMozState):
        (WebCore::paintScrollbarWidget):
        (WebCore::ScrollbarThemeChromium::paintTrackPiece):
        (WebCore::ScrollbarThemeChromium::paintButton):
        (WebCore::ScrollbarThemeChromium::paintThumb):
        * platform/chromium/ScrollbarThemeChromiumWin.cpp:
        * platform/chromium/SearchPopupMenuChromium.cpp: Added.
        (WebCore::SearchPopupMenu::SearchPopupMenu):
        (WebCore::SearchPopupMenu::enabled):
        (WebCore::SearchPopupMenu::saveRecentSearches):
        (WebCore::SearchPopupMenu::loadRecentSearches):
        * platform/chromium/SharedTimerChromium.cpp: Added.
        (WebCore::setSharedTimerFiredFunction):
        (WebCore::setSharedTimerFireTime):
        (WebCore::stopSharedTimer):
        * platform/chromium/TemporaryLinkStubs.cpp: Added.
        (WebCore::signedPublicKeyAndChallengeString):
        (WebCore::getSupportedKeySizes):
        (WebCore::KURL::fileSystemPath):
        (WebCore::SharedBuffer::createWithContentsOfFile):
        (WTF::scheduleDispatchFunctionsOnMainThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-14 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 14 Jan 2009 19:40:04 +0000 (19:40 +0000)]
2009-01-14  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23321
        Upstream more bits of graphics/chromium.

        * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: Added.
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::operator=):
        (WebCore::FontPlatformData::~FontPlatformData):
        (WebCore::FontPlatformData::RefCountedHFONT::~RefCountedHFONT):
        (WebCore::FontPlatformData::hashTableDeletedFontValue):
        (WebCore::FontPlatformData::scriptFontProperties):
        * platform/graphics/chromium/FontPlatformDataChromiumWin.h: Added.
        (WebCore::FontPlatformData::isHashTableDeletedValue):
        (WebCore::FontPlatformData::hfont):
        (WebCore::FontPlatformData::size):
        (WebCore::FontPlatformData::hash):
        (WebCore::FontPlatformData::operator==):
        (WebCore::FontPlatformData::scriptCache):
        (WebCore::FontPlatformData::RefCountedHFONT::create):
        (WebCore::FontPlatformData::RefCountedHFONT::hfont):
        (WebCore::FontPlatformData::RefCountedHFONT::hash):
        (WebCore::FontPlatformData::RefCountedHFONT::operator==):
        (WebCore::FontPlatformData::RefCountedHFONT::RefCountedHFONT):
        * platform/graphics/chromium/FontPlatformDataLinux.cpp: Added.
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::~FontPlatformData):
        (WebCore::FontPlatformData::operator=):
        (WebCore::FontPlatformData::setupPaint):
        (WebCore::FontPlatformData::operator==):
        (WebCore::FontPlatformData::hash):
        (WebCore::FontPlatformData::isFixedPitch):
        * platform/graphics/chromium/FontPlatformDataLinux.h: Added.
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::size):
        (WebCore::FontPlatformData::isHashTableDeletedValue):
        (WebCore::FontPlatformData::hashTableDeletedFontValue):
        * platform/graphics/chromium/FontUtilsChromiumWin.cpp: Added.
        (WebCore::):
        (WebCore::FontMap::getAscent):
        (WebCore::FontMap::FontData::FontData):
        (WebCore::getFontFamilyForScript):
        (WebCore::getFallbackFamily):
        (WebCore::getDerivedFontData):
        (WebCore::getStyleFromLogfont):
        * platform/graphics/chromium/FontUtilsChromiumWin.h: Added.
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-14 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 14 Jan 2009 19:37:19 +0000 (19:37 +0000)]
2009-01-14  Darin Adler  <darin@apple.com>

        Reviewed by Oliver Hunt.

        Fix crash I ran into while printing. I was unable to reproduce it, but also,
        it's clear there's no guarantee that the frame will be non-zero in this case,
        so it seems fine to check it.

        * WebView/WebHTMLView.mm: (-[WebHTMLView reapplyStyles]): Check frame for zero
        and don't do anything with it if it's zero.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove errant WARNING from WebCore/ChangeLog.
dglazkov@chromium.org [Wed, 14 Jan 2009 19:25:55 +0000 (19:25 +0000)]
Remove errant WARNING from WebCore/ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-14 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 14 Jan 2009 19:23:43 +0000 (19:23 +0000)]
2009-01-14  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23325
        Upstream even more graphics/chromium bits.

        WARNING: NO TEST CASES ADDED OR CHANGED

        * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: Added.
        (WebCore::fillEmptyGlyphs):
        (WebCore::initSpaceGlyph):
        (WebCore::fillBMPGlyphs):
        (WebCore::fillNonBMPGlyphs):
        (WebCore::GlyphPage::fill):
        * platform/graphics/chromium/GlyphPageTreeNodeLinux.cpp: Added.
        (WebCore::GlyphPage::fill):
        * platform/graphics/chromium/IconChromiumLinux.cpp: Added.
        (WebCore::Icon::Icon):
        (WebCore::Icon::~Icon):
        (WebCore::Icon::createIconForFile):
        (WebCore::Icon::createIconForFiles):
        (WebCore::Icon::paint):
        * platform/graphics/chromium/IconChromiumMac.cpp: Added.
        (WebCore::Icon::createIconForFile):
        (WebCore::Icon::createIconForFiles):
        (WebCore::Icon::~Icon):
        (WebCore::Icon::paint):
        * platform/graphics/chromium/IconChromiumWin.cpp: Added.
        (WebCore::Icon::Icon):
        (WebCore::Icon::~Icon):
        (WebCore::Icon::createIconForFile):
        (WebCore::Icon::createIconForFiles):
        (WebCore::Icon::paint):
        * platform/graphics/chromium/ImageBufferData.h: Added.
        * platform/graphics/chromium/ImageChromiumMac.mm: Added.
        (WebCore::Image::loadPlatformResource):
        (WebCore::BitmapImage::initPlatformData):
        (WebCore::BitmapImage::invalidatePlatformData):
        * platform/graphics/chromium/MediaPlayerPrivateChromium.h: Added.
        * platform/graphics/chromium/PlatformIcon.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-14 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 14 Jan 2009 19:11:15 +0000 (19:11 +0000)]
2009-01-14  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23323
        Upstream platform/text/chromium/

        * platform/text/chromium: Added.
        * platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp: Added.
        (WebCore::currentTextBreakLocaleID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-14 Dean McNamee <deanm@chromium.org>
oliver@apple.com [Wed, 14 Jan 2009 19:07:48 +0000 (19:07 +0000)]
2009-01-14  Dean McNamee  <deanm@chromium.org>

        Reviewed by Darin Adler and Oliver hunt.

        Correctly match allocation functions by implementing a custom deref().

        https://bugs.webkit.org/show_bug.cgi?id=23315

        * runtime/ByteArray.h:
        (JSC::ByteArray::deref):
        (JSC::ByteArray::ByteArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-14 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 14 Jan 2009 19:02:19 +0000 (19:02 +0000)]
2009-01-14  Darin Fisher  <darin@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=23324
        Move platform/chromium/EditorChromium.cpp into editing/chromium/

        * editing/chromium: Added.
        * editing/chromium/EditorChromium.cpp: Copied from platform/chromium/EditorChromium.cpp.
        * platform/chromium/EditorChromium.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate copyright year in version resources.
sfalken@apple.com [Wed, 14 Jan 2009 18:56:32 +0000 (18:56 +0000)]
Update copyright year in version resources.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-14 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 14 Jan 2009 18:34:53 +0000 (18:34 +0000)]
2009-01-14  Darin Fisher  <darin@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=23320
        Make it possible to use notImplemented outside of the WebCore namespace

        * platform/NotImplemented.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
darin@apple.com [Wed, 14 Jan 2009 18:23:37 +0000 (18:23 +0000)]
WebCore:

2009-01-14  Nigel Tao  <nigel.tao.gnome@gmail.com>

        Reviewed by Darin Adler.

        - fix https://bugs.webkit.org/show_bug.cgi?id=22476
        Check that the document's SecurityOrigin canLoadLocalResources,
        when pages try to put NSFilenamesPboardtype data on the clipboard,
        by calling event.dataTransfer.setData('URL', 'file:///foo/bar');

        Tests: http/tests/security/dataTransfer-set-data-file-url.html
               platform/mac/editing/pasteboard/dataTransfer-set-data-file-url.html

        * platform/mac/ClipboardMac.mm:
        (WebCore::ClipboardMac::setData):

LayoutTests:

2009-01-14  Nigel Tao  <nigel.tao.gnome@gmail.com>

        Reviewed by Darin Adler.

        - tests for https://bugs.webkit.org/show_bug.cgi?id=22476
        Added tests that calling dataTransfer.setData('URL', aFileUrl)
        only puts NSFilenamesPboardtype data on the clipboard if called
        from a locally served page.

        * http/tests/security/dataTransfer-set-data-file-url-expected.txt: Added.
        * http/tests/security/dataTransfer-set-data-file-url.html: Added.
        * platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.txt: Added.
        * platform/mac/editing/pasteboard/dataTransfer-set-data-file-url.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScriptCore:
mitz@apple.com [Wed, 14 Jan 2009 18:18:30 +0000 (18:18 +0000)]
JavaScriptCore:

        Reviewed by John Sullivan.

        - update copyright

        * Info.plist:

JavaScriptGlue:

        Reviewed by John Sullivan.

        - update copyright

        * Info.plist:

WebCore:

        Reviewed by John Sullivan.

        - update copyright

        * Info.plist:

WebKit/mac:

        Reviewed by John Sullivan.

        - update copyright

        * Info.plist:

WebKit/win:

        Reviewed by John Sullivan.

        - update copyright

        * WebKit.resources/Info.plist:
        * WebKit.vcproj/WebKit.rc:

WebKitTools:

        Reviewed by John Sullivan.

        - update copyright

        * DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist:
        * WebKitLauncher/Info.plist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@webkit.org [Wed, 14 Jan 2009 17:58:58 +0000 (17:58 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=23316
        Application cache updating always fails with an assertion

        Test: http/tests/appcache/update-cache.html

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::documentLoaderDestroyed): Correctly handle the case where
        multiple caches survive the last DocumentLoader destruction, preventing a crash in release
        builds.
        (WebCore::ApplicationCacheGroup::setNewestCache): Removed a bogus assertion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@webkit.org [Wed, 14 Jan 2009 17:19:50 +0000 (17:19 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=23313
        appcache/offline-access.html fails frequently

        * http/tests/appcache/resources/offline-access-frame.html:
        Make sure that the test runs, even if the cache update finishes before we install event listeners.

        * http/tests/appcache/offline-access-expected.txt:
        * http/tests/appcache/offline-access.html:
        Don't dump frame content, as it is timing dependent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-14 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Wed, 14 Jan 2009 13:56:35 +0000 (13:56 +0000)]
2009-01-14  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] Unit tests for text selection and editing actions of QWebPage.
        The following are tested:
            - the actions are not NULL
            - the actions are disabled when contentEditable is false
            - the actions are enabled when contentEditable is true

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-14 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Wed, 14 Jan 2009 13:48:19 +0000 (13:48 +0000)]
2009-01-14  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Fix failing assertion when pressing an extra mouse button on a
        QWebView.

        Mice with more than three buttons - for example with a dedicated
        "back" button - can generate Qt::XButton1 or Button2.
        WebCore::MouseButton contains only Left, Middle and Right, so in
        Qt's PlatformMouseEvent we map to NoButton, resulting in a mouse
        press or release even with no button set. That triggers an assertion
        in EventTargetNode::dispatchMouseEvent requiring that either a button
        is set or it is just a mouse move event, which is correct.

        In QWebPage decide not to dispatch such mouse events where we cannot
        map the mouse button to a WebCore::MouseButton.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-14 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Wed, 14 Jan 2009 13:34:19 +0000 (13:34 +0000)]
2009-01-14  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon Hausmann.

        http://www.qtsoftware.com/developer/task-tracker/index_html?id=241144&method=entry

        [Qt] Create actions for text selection and editing for QWebPage.
        Also properly disable and enable them when contentEditable is toggled.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::updateAction):
        (QWebPagePrivate::updateEditorActions):
        (QWebPage::action):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-14 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Wed, 14 Jan 2009 12:39:38 +0000 (12:39 +0000)]
2009-01-14  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon Hausmann.

        [Qt] Unit tests for cursor movements. The following are tested:
            - the actions are not NULL
            - the actions are disabled when contentEditable is false
            - the actions are enabled when contentEditable is true
            - the cursor moves properly when the actions are triggered

        * tests/qwebpage/tst_qwebpage.cpp:
        (CursorTrackedPage::CursorTrackedPage):
        (CursorTrackedPage::selectedText):
        (CursorTrackedPage::selectionStartOffset):
        (CursorTrackedPage::selectionEndOffset):
        (CursorTrackedPage::isSelectionCollapsed):
        (tst_QWebPage::cursorMovements):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Release build fix.
ap@webkit.org [Wed, 14 Jan 2009 09:02:43 +0000 (09:02 +0000)]
    Release build fix.

        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::storeUpdatedType): Use ASSERT_UNUSED.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Anders Carlsson.
ap@webkit.org [Wed, 14 Jan 2009 07:17:39 +0000 (07:17 +0000)]
    Reviewed by Anders Carlsson.

        Test: http/tests/appcache/xhr-foreign-resource.html

        https://bugs.webkit.org/show_bug.cgi?id=23256
        Implement application cache foreign entries

        * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache):
        Removed a misplaced check for foreign resources that prevented them from being loaded altogether.

        * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache):
        If a document that was loaded from appcache should be associated with a different cache,
        mark the resource as foreign in the original cache and start over.

        * loader/appcache/ApplicationCacheResource.cpp: (WebCore::ApplicationCacheResource::addType):
        This function can now be called after a cache is stored, so it no longer asserts the opposite.

        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::cacheGroupForURL): Fix database pass to correctly ignore
        in-memory caches that were already rejected.
        (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): Ditto.
        (WebCore::ApplicationCacheStorage::storeUpdatedType): Added a function that updates type of
        an already stored cached resource.

        * loader/appcache/ApplicationCacheStorage.h: Added storeUpdatedType().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@webkit.org [Wed, 14 Jan 2009 07:14:18 +0000 (07:14 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=23286
        Add a test for non-ASCII URIs in application cache

        * http/tests/appcache/cyrillic-uri-expected.txt: Added.
        * http/tests/appcache/cyrillic-uri.html: Added.
        * http/tests/appcache/resources/cyrillic-uri-form.html: Added.
        * http/tests/appcache/resources/cyrillic-uri.manifest: Added.
        * http/tests/appcache/resources/intercept: Added.
        * http/tests/appcache/resources/intercept/.htaccess: Added.
        * http/tests/appcache/resources/print-uri.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScriptCore:
bdakin@apple.com [Wed, 14 Jan 2009 01:44:28 +0000 (01:44 +0000)]
JavaScriptCore:

2009-01-13  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin Adler and Oliver Hunt.

        <rdar://problem/6489314> REGRESSION: Business widget's front side
        fails to render correctly when flipping widget

        The problem here is that parseInt was parsing NaN as 0. This patch
        corrects that by parsing NaN as NaN. This matches our old behavior
        and Firefox.

        * runtime/JSGlobalObjectFunctions.cpp:
        (JSC::globalFuncParseInt):

LayoutTests:

2009-01-13  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin Adler and Oliver Hunt.

        Updated test and results for <rdar://problem/6489314> REGRESSION:
        Business widget's front side fails to render correctly when
        flipping widget

        parseInt(NaN) should be NaN.
        * fast/js/numeric-conversion-expected.txt:
        * fast/js/resources/numeric-conversion.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the Tiger WebCore build after r39880.
mrowe@apple.com [Wed, 14 Jan 2009 01:24:27 +0000 (01:24 +0000)]
Fix the Tiger WebCore build after r39880.

* editing/Editor.cpp:
(WebCore::Editor::markBadGrammar):
* loader/mac/DocumentLoaderMac.cpp:
(WebCore::DocumentLoader::schedule):
(WebCore::DocumentLoader::unschedule):
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelection):
* platform/mac/WebCoreObjCExtras.mm:
(WebCoreObjCFinalizeOnMainThread):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::schedule):
(WebCore::ResourceHandle::unschedule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-13 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 14 Jan 2009 00:16:19 +0000 (00:16 +0000)]
2009-01-13  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Bug 23102: turn on unused parameter warnings in WebCore
        https://bugs.webkit.org/show_bug.cgi?id=23102

        Last step: Turn on the warning and fix the last few instances.

        * Configurations/Base.xcconfig: Removed -Wno-unused-parameter from
        WARNING_CFLAGS_BASE, so the unused parameter warning will fire.

        * bindings/js/JSDOMWindowBase.cpp:
        (jsDOMWindowBaseMessageChannel): Separate the version for use when
        CHANNEL_MESSAGING is turned off, so we can omit the argument names.
        It would be better to not even have this property in that case,
        rather than having the function return undefined, but I don't know
        how to do that with the bindings script.

        * bindings/scripts/CodeGeneratorJS.pm: Leave out argument names in
        functions where they're not used (the SVG context, and the property
        name in the index getter). Use UNUSED_PARAM where arguments are
        sometimes not used.

        * bridge/runtime_object.cpp:
        (JSC::RuntimeObjectImp::put): Use UNUSED_PARAM for non-QT.

        * css/MediaQueryEvaluator.cpp:
        (WebCore::animationMediaFeatureEval): Omit argument names for style and frame.
        (WebCore::transitionMediaFeatureEval): Ditto.
        (WebCore::transform_2dMediaFeatureEval): Ditto.
        (WebCore::transform_3dMediaFeatureEval): Ditto.

        * dom/make_names.pl: Leave out the createdByParser property name in
        cases where it's not used.

        * inspector/JavaScriptDebugServer.cpp:
        (WebCore::JavaScriptDebugServer::setJavaScriptPaused): Separate the
        version for the Mac platform so we can omit the argument names.

        * loader/EmptyClients.h:
        (WebCore::EmptyChromeClient::contentsSizeChanged): Removed argument name.

        * loader/FrameLoaderClient.h:
        (WebCore::FrameLoaderClient::shouldUsePluginDocument): Commented out
        argument name.

        * loader/icon/IconFetcher.cpp:
        (WebCore::IconFetcher::didReceiveResponse): Use ASSERT_UNUSED.
        (WebCore::IconFetcher::didReceiveData): Ditto.
        (WebCore::IconFetcher::didFinishLoading): Ditto.
        (WebCore::IconFetcher::didFail): Ditto.

        * platform/KURL.cpp:
        (WebCore::assertProtocolIsGood): Separate out the NDEBUG version so
        we can omit the argument names.

        * platform/Timer.cpp:
        (WebCore::TimerHeapIterator::checkConsistency): Use ASSERT_UNUSED.

        * platform/graphics/GlyphBuffer.h:
        (WebCore::GlyphBuffer::offsetAt): Use UNUSED_PARAM in the non-WIN case.
        (WebCore::GlyphBuffer::add): Use UNUSED_PARAM in the non-CAIRO case.

        * platform/graphics/cg/ImageSourceCG.cpp:
        (WebCore::ImageSource::clear): Removed argument name.

        * rendering/SVGRenderSupport.cpp:
        (WebCore::prepareToRenderSVGContent): Use UNUSED_PARAM when SVG_FILTERS
        is not enabled.
        (WebCore::finishRenderSVGContent): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-13 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Wed, 14 Jan 2009 00:15:36 +0000 (00:15 +0000)]
2009-01-13  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Fix for: https://bugs.webkit.org/show_bug.cgi?id=23292

        Implementation of two argument canDoFastAdditiveOperations does not correlate well with reality.

        * runtime/JSImmediate.h:
        (JSC::JSFastMath::canDoFastAdditiveOperations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Implemented https://bugs.webkit.org/show_bug.cgi?id=23298
cmarrin@apple.com [Tue, 13 Jan 2009 22:47:14 +0000 (22:47 +0000)]
    Implemented https://bugs.webkit.org/show_bug.cgi?id=23298
        Simple fix to convertToLength to catch style==null cases

        * css/CSSStyleSelector.cpp:
        (WebCore::convertToLength):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKitTools:
andersca@apple.com [Tue, 13 Jan 2009 22:36:59 +0000 (22:36 +0000)]
WebKitTools:

2009-01-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add NPRuntime test.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
        (testNPRuntime):
        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
        * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
        (NPP_New):
        (NPP_GetValue):

LayoutTests:

2009-01-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add NPRuntime test.

        * plugins/npruntime-expected.txt: Added.
        * plugins/npruntime.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Mark Rowe.
eric@webkit.org [Tue, 13 Jan 2009 21:15:26 +0000 (21:15 +0000)]
    Reviewed by Mark Rowe.

        Speculative fix for an Uninitialized Memory Read (UMR)
        seen by purify in chormium's equivalent V8 file.

        * bindings/js/JSSVGPODTypeWrapper.h:
        (WebCore::PODTypeWrapperCacheInfo::PODTypeWrapperCacheInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-13 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 13 Jan 2009 20:55:04 +0000 (20:55 +0000)]
2009-01-13  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        Land portions of platform/graphics/chromium.
        https://bugs.webkit.org/show_bug.cgi?id=23297

        * platform/graphics/chromium/FontCustomPlatformData.cpp: Added.
        (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
        (WebCore::FontCustomPlatformData::fontPlatformData):
        (WebCore::EOTStream::EOTStream):
        (WebCore::EOTStream::read):
        (WebCore::readEmbedProc):
        (WebCore::createUniqueFontName):
        (WebCore::createFontCustomPlatformData):
        * platform/graphics/chromium/FontCustomPlatformData.h: Added.
        (WebCore::FontCustomPlatformData::FontCustomPlatformData):
        * platform/graphics/chromium/FontLinux.cpp: Added.
        (WebCore::Font::drawGlyphs):
        (WebCore::Font::drawComplexText):
        (WebCore::Font::floatWidthForComplexText):
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForComplexText):
        * platform/graphics/chromium/FontPlatformData.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-08 Yongjun Zhang <yongjun.zhang@nokia.com>
hausmann@webkit.org [Tue, 13 Jan 2009 20:44:07 +0000 (20:44 +0000)]
2009-01-08  Yongjun Zhang  <yongjun.zhang@nokia.com>

        Reviewed by Simon Hausmann.

        https://bugs.webkit.org/show_bug.cgi?id=23187

        Update webview with the intersected rect.

        In ChromeClientQt::repaint, view should be updated with the
        intersected rect, not the whole windowRect;

        This generally is not a problem for normal viewport setup where
        viewport size is the same as the qwebview widget size.  However, if we
        set the viewport size smaller than qwebkit widget, we will see
        unwanted painting outside the viewport.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-01-13 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Tue, 13 Jan 2009 20:43:03 +0000 (20:43 +0000)]
2009-01-13  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Tor Arne Vestbø.

        [Qt] Missing piece from my previous commit:
        Disable and enable the cursor navigation actions when contentEditable
        is changed.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::updateEditorActions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39873 268f45cc-cd09-0410-ab3c-d52691b4dbfc