caseq@chromium.org [Thu, 10 Mar 2011 16:14:53 +0000 (16:14 +0000)]
2011-03-10 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: better names for HAR export commands
https://bugs.webkit.org/show_bug.cgi?id=56097
Rename Export to HAR to Copy entry/network log as HAR
Expose Copy as HAR unconditionally, remove related settings entry.
* English.lproj/localizedStrings.js:
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype._contextMenu):
* inspector/front-end/Settings.js:
2011-03-10 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: better names for HAR export commands
https://bugs.webkit.org/show_bug.cgi?id=56097
* src/js/DevTools.js: removed override for resourceExportEnabled
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Thu, 10 Mar 2011 15:57:37 +0000 (15:57 +0000)]
2011-03-10 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
https://bugs.webkit.org/show_bug.cgi?id=48636
Fix a typo in features.pri that turns on this feature on mobile
devices by default.
* features.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Thu, 10 Mar 2011 15:38:50 +0000 (15:38 +0000)]
2011-03-10 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Invalid expected parameter list in CSSAgent.setSelectorText() callback (CSSStyleModel.js)
https://bugs.webkit.org/show_bug.cgi?id=56092
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.setRuleSelector):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80719
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 10 Mar 2011 15:17:57 +0000 (15:17 +0000)]
2011-03-10 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: rolling out r80478 and its follow ups for breaking
inspector and engadget.com.
https://bugs.webkit.org/show_bug.cgi?id=49401
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::performTask):
(WebCore::Document::postTask):
* dom/Document.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::setDefersLoading):
* manual-tests/database-callback-deferred.html: Removed.
* page/PageGroupLoadDeferrer.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
(WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
2011-03-10 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: rolling out r80478 and its follow ups for breaking
inspector and engadget.com.
https://bugs.webkit.org/show_bug.cgi?id=49401
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 10 Mar 2011 15:11:05 +0000 (15:11 +0000)]
2011-03-10 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip 1 more svg test failing by one pixel in 32-bits
Debug, see bug 39022.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80717
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Thu, 10 Mar 2011 14:52:44 +0000 (14:52 +0000)]
2011-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Kenneth Rohde Christiansen.
Tiled backing store's delegated scroll request uses incorrect convention
https://bugs.webkit.org/show_bug.cgi?id=56011
Use a point instead of delta, when relaying the scroll request from
ScrollView::setScrollPosition.
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::delegatedScrollRequested):
* page/Chrome.cpp:
(WebCore::Chrome::delegatedScrollRequested):
* page/Chrome.h:
* page/ChromeClient.h:
* platform/HostWindow.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::setScrollPosition):
2011-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Kenneth Rohde Christiansen.
Tiled backing store's delegated scroll request uses incorrect convention
https://bugs.webkit.org/show_bug.cgi?id=56011
Adapt internal API to match the change from delta to point on the
WebCore side, and convert the point to a delta for the public API.
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::delegatedScrollRequested):
* WebCoreSupport/ChromeClientQt.h:
2011-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Kenneth Rohde Christiansen.
Tiled backing store's delegated scroll request uses incorrect convention
https://bugs.webkit.org/show_bug.cgi?id=56011
Adapt all of the internal API to match the delta to point
conversion at the WebCore side.
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::pageDidRequestScroll):
* UIProcess/API/qt/qwkpage_p.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::pageDidRequestScroll):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::delegatedScrollRequested):
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::pageDidRequestScroll):
* WebProcess/WebPage/WebPage.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 10 Mar 2011 14:51:41 +0000 (14:51 +0000)]
2011-03-10 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] unittests/testapplicationcache crashes
https://bugs.webkit.org/show_bug.cgi?id=56083
Removed the webkit_application_cache_get_database_directory_path
API as the underlying ApplicationCacheStorage doesn't allow
setting the cache path multiple times.
* tests/testapplicationcache.c:
(main):
* webkit/webkitapplicationcache.cpp:
(webkit_application_cache_get_database_directory_path):
* webkit/webkitapplicationcache.h:
* webkit/webkitglobals.cpp:
(webkitInit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Thu, 10 Mar 2011 14:34:44 +0000 (14:34 +0000)]
2011-03-10 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Andreas Kling.
[WK2] Make non-transparent windowless plugins paint on X11
https://bugs.webkit.org/show_bug.cgi?id=55660
Implement painting for non-transparent windowless X11 plugins.
The essence of the logic has been adapted from WebCore.
The implementation is stubbed for GTK and working only on Qt
but it should be really easy to finish it for GTK.
* WebKit2.pro:
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue): Handle X11 specific values that are necessary.
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin): Initialize the X11 specific
members that has been added.
(WebKit::NetscapePlugin::callSetWindow): Always set the x and y coordinates
of the NP_Window to 0 on X11 since we are using a backings store as the
painting area for the plugin.
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp: Removed in favour
of a common implementation for X11.
* WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp: Ditto.
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Added.
(WebKit::getPluginDisplay):
Platform specific static getters.
(WebKit::x11Display):
(WebKit::displayDepth):
(WebKit::rootWindowID):
(WebKit::x11Screen):
(WebKit::NetscapePlugin::platformPostInitialize): Set up the visual
settings and the colormap for the plugin.
(WebKit::NetscapePlugin::platformDestroy):
(WebKit::NetscapePlugin::platformInvalidate): Remained stub.
(WebKit::NetscapePlugin::platformGeometryDidChange): Create a new
pixmap that fits the geometry.
(WebKit::NetscapePlugin::platformPaint): Propagate a paint event
to the plugin, sync with it if necessary and draw the pixmap to
the screen.
(WebKit::toNP): Remained stub.
(WebKit::NetscapePlugin::platformHandleMouseEvent): Remained stub.
(WebKit::NetscapePlugin::platformHandleWheelEvent): Remained stub.
(WebKit::NetscapePlugin::platformSetFocus): Remained stub.
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent): Remained stub.
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent): Remained stub.
(WebKit::NetscapePlugin::platformHandleKeyboardEvent): Remained stub.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createPlugin): Hack. Inject wmode=opaque
key-value pair to the plugin parameters to force Flash to act in
non-transparent windowless mode. Qt also doing this in WebCore.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 10 Mar 2011 14:26:25 +0000 (14:26 +0000)]
2011-03-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: brush up DOM agent API.
https://bugs.webkit.org/show_bug.cgi?id=56093
* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.nodeWithId.processChildren):
(initialize_ElementTest.InspectorTest.nodeWithId.documentRequested):
(initialize_ElementTest.InspectorTest.nodeWithId):
(initialize_ElementTest.InspectorTest.dumpDOMAgentTree.dump):
(initialize_ElementTest.InspectorTest.dumpDOMAgentTree):
(initialize_ElementTest):
* inspector/elements/elements-panel-rewrite-href.html:
* inspector/elements/elements-panel-search.html:
* inspector/elements/elements-panel-selection-on-refresh.html:
* inspector/elements/mutate-unknown-node.html:
2011-03-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: brush up DOM agent API.
https://bugs.webkit.org/show_bug.cgi?id=56093
* inspector/Inspector.idl:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::childNodes):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::outerHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
* inspector/InspectorDOMAgent.h:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype.hasAttributes):
(WebInspector.DOMNode.prototype.nodeType):
(WebInspector.DOMNode.prototype.nodeName):
(WebInspector.DOMNode.prototype.setNodeName):
(WebInspector.DOMNode.prototype.localName):
(WebInspector.DOMNode.prototype.nodeValue):
(WebInspector.DOMNode.prototype.setNodeValue):
(WebInspector.DOMNode.prototype.setAttribute):
(WebInspector.DOMNode.prototype.attributes):
(WebInspector.DOMNode.prototype.removeAttribute):
(WebInspector.DOMNode.prototype.childNodes.mycallback):
(WebInspector.DOMNode.prototype.childNodes):
(WebInspector.DOMNode.prototype.outerHTML):
(WebInspector.DOMNode.prototype.setOuterHTML):
(WebInspector.DOMNode.prototype.removeNode):
(WebInspector.DOMNode.prototype.copyNode):
(WebInspector.DOMNode.prototype.path):
(WebInspector.DOMNode.prototype._setAttributesPayload):
(WebInspector.DOMNode.prototype._addAttribute):
(WebInspector.DOMAgent.prototype._characterDataModified):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
(WebInspector.ElementsPanel.prototype.decorateNodeLabel):
(WebInspector.ElementsPanel.prototype.handleCopyEvent):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.findTreeElement):
(WebInspector.ElementsTreeElement):
(WebInspector.ElementsTreeElement.prototype.updateChildren):
(WebInspector.ElementsTreeElement.prototype._updateChildren):
(WebInspector.ElementsTreeElement.prototype._startEditingTarget):
(WebInspector.ElementsTreeElement.prototype._startEditing):
(WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
(WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.moveToNextAttributeIfNeeded):
(WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
(WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted):
(WebInspector.ElementsTreeElement.prototype._attributeHTML):
():
* inspector/front-end/EventListenersSidebarPane.js:
():
* inspector/front-end/MetricsSidebarPane.js:
* inspector/front-end/StylesSidebarPane.js:
* inspector/front-end/utilities.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80713
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 10 Mar 2011 14:09:02 +0000 (14:09 +0000)]
2011-03-10 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] run-gtk-tests doesn't fail if a test crashes
https://bugs.webkit.org/show_bug.cgi?id=56089
* Scripts/run-gtk-tests: gtester -k exits with a 0 exit status
even if a test crashes. So run the tests individually and if a
test fails remember its exit code so run-gtk-test fails too, if
required.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 10 Mar 2011 13:44:04 +0000 (13:44 +0000)]
2011-03-10 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip 2 more flacky tests on GTK 32-bits Release.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80711
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Thu, 10 Mar 2011 13:28:32 +0000 (13:28 +0000)]
2011-03-09 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [STYLES] Editing a property value adds a word for any property value that uses a paren
https://bugs.webkit.org/show_bug.cgi?id=56002
* inspector/front-end/StylesSidebarPane.js: Introduce an additional check.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80710
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Thu, 10 Mar 2011 13:05:59 +0000 (13:05 +0000)]
2011-03-09 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: use DebuggerPresentation instead of DebuggerModel in source frame delegate.
https://bugs.webkit.org/show_bug.cgi?id=56034
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._sourceLocationToActualLocation):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.SourceFrameDelegateForScriptsPanel):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.updateBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.removeBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.findBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.continueToLine):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
(WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition):
(WebInspector.SourceFrame.prototype._contextMenu.else.setBreakpointEnabled):
(WebInspector.SourceFrame.prototype._contextMenu):
(WebInspector.SourceFrame.prototype._mouseDown):
(WebInspector.SourceFrameDelegate.prototype.removeBreakpoint):
(WebInspector.SourceFrameDelegate.prototype.updateBreakpoint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80709
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Thu, 10 Mar 2011 12:42:39 +0000 (12:42 +0000)]
2011-03-09 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: elements dom tree - word wrap toggle
https://bugs.webkit.org/show_bug.cgi?id=44311
A "Word Wrap" option is now shown in a context menu for the entire DOM tree content area
and persisted into application settings.
* English.lproj/localizedStrings.js:
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._contextMenuEventFired):
(WebInspector.ElementsPanel.prototype._contextMenuEventFired.toggleWordWrap):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline):
(WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
(WebInspector.ElementsTreeOutline.prototype.populateContextMenu):
(WebInspector.ElementsTreeElement.prototype.onreveal):
* inspector/front-end/Settings.js:
(WebInspector.Settings):
* inspector/front-end/inspector.css:
(#elements-content.nowrap):
(#elements-content > ol):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 10 Mar 2011 12:28:29 +0000 (12:28 +0000)]
2011-03-10 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip 1 more svg test failing by one pixel in 32-bits
Debug, see bug 39022.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80707
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 10 Mar 2011 12:26:34 +0000 (12:26 +0000)]
2011-03-10 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip 2 more svg tests failing by one pixel in 32-bits
Release, see bug 39022.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Thu, 10 Mar 2011 12:21:22 +0000 (12:21 +0000)]
2011-03-09 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: re-implement breakpoints sidebar pane based on debugger presentation model.
https://bugs.webkit.org/show_bug.cgi?id=55823
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint.didLoadSnippet):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.removeBreakpoint):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.highlightBreakpoint):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.clearBreakpointHighlight):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._createBreakpointItemId):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointClicked):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointCheckboxClicked):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._contextMenu):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.reset):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._revealHiddenBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
(WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation):
(WebInspector.DebuggerPresentationModel.prototype.reset):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._breakpointAdded):
(WebInspector.ScriptsPanel.prototype._breakpointRemoved):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype.reset):
(WebInspector.ScriptsPanel.prototype._clearInterface):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Thu, 10 Mar 2011 12:11:00 +0000 (12:11 +0000)]
2011-03-10 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: Highlighter refactoring
https://bugs.webkit.org/show_bug.cgi?id=56015
* inspector/editor/highlighter-basics-expected.txt:
* inspector/editor/highlighter-basics.html:
* inspector/editor/highlighter-long-line.html:
* inspector/editor/highlighter-paste-in-comment-expected.txt:
* inspector/editor/highlighter-paste-in-comment.html:
2011-03-10 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: Highlighter refactoring
https://bugs.webkit.org/show_bug.cgi?id=56015
* inspector/front-end/TextEditorHighlighter.js:
(WebInspector.TextEditorHighlighter):
(WebInspector.TextEditorHighlighter.prototype.set mimeType):
(WebInspector.TextEditorHighlighter.prototype.highlight):
(WebInspector.TextEditorHighlighter.prototype.updateHighlight):
(WebInspector.TextEditorHighlighter.prototype._highlightInChunks):
(WebInspector.TextEditorHighlighter.prototype._highlightLines):
(WebInspector.TextEditorHighlighter.prototype._selectHighlightState):
(WebInspector.TextEditorHighlighter.prototype._clearHighlightState):
* inspector/front-end/TextViewer.js:
(WebInspector.TextEditorMainPanel.prototype._buildChunks):
(WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jknotten@chromium.org [Thu, 10 Mar 2011 11:28:08 +0000 (11:28 +0000)]
2011-03-10 John Knottenbelt <jknotten@chromium.org>
Reviewed by Andreas Kling.
[Qt] Skip fast/dom/Geolocation/page-reload-cancel-permission-requests.html pending implementation of LayoutTestController::numberOfPendingGeolocationPermissionRequests
https://bugs.webkit.org/show_bug.cgi?id=56087
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Thu, 10 Mar 2011 11:24:07 +0000 (11:24 +0000)]
2011-03-05 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move breakpoint column adjustment to debugger model.
https://bugs.webkit.org/show_bug.cgi?id=55821
Test: inspector/debugger/debug-inlined-scripts.html
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpoint):
* inspector/front-end/SourceFrameContent.js:
(WebInspector.SourceFrameContent.prototype.sourceFrameLineNumberToActualLocation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jknotten@chromium.org [Thu, 10 Mar 2011 10:15:49 +0000 (10:15 +0000)]
2011-02-16 John Knottenbelt <jknotten@chromium.org>
Reviewed by Dmitry Titov.
Detach Geolocation from Frame when Page destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52877
Ensure that all geolocation permission requests are cancelled
when the page is detached from its frame.
* fast/dom/Geolocation/page-reload-cancel-permission-requests-expected.txt: Added.
* fast/dom/Geolocation/page-reload-cancel-permission-requests.html: Added.
* fast/dom/Geolocation/resources/page-reload-cancel-permission-requests-inner.html: Added.
* fast/dom/Geolocation/script-tests/page-reload-cancel-permission-requests.js: Added.
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt-wk2/Skipped:
2011-01-21 John Knottenbelt <jknotten@chromium.org>
Reviewed by Dmitry Titov.
Detach Geolocation from Frame when Page destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52877
On Page destruction, any outstanding Geolocation permission
requests should be cancelled, because the Geolocation can only
access the client indirectly via m_frame->page().
Page destruction is signalled by a call to the
Frame::pageDestroyed() method. This explictly calls
DOMWindow::resetGeolocation which ultimately calls Geolocation::reset.
Geolocation::reset() detaches from the GeolocationController,
cancels requests, watches and single shots, and sets the
permission state back to Unknown.
Frame::pageDestroyed() is also called by FrameLoader even though
the page is not destroyed. We should still cancel permission
requests, because the GeolocationClient will become inaccessible
to the Geolocation object after this call.
Frame::transferChildFrameToNewDocument also indirectly calls
Geolocation::reset when the frame is reparented between
pages. Ideally we would like the Geolocation's activities to
continue after reparenting, see bug
https://bugs.webkit.org/show_bug.cgi?id=55577
Since GeolocationController is owned by Page, and all Geolocation
objects will now unsubscribe from the GeolocationController on
pageDetached(), we no longer need to call stopUpdating() from the
GeolocationController's destructor. Instead we can simply assert
that there should be no no observers. See related bug
https://bugs.webkit.org/show_bug.cgi?id=52216 .
Introduced new method 'numberOfPendingPermissionRequests' on
GeolocationClientMock to count the number of outstanding pending
permission requests. This provides a reusable implementation for
client-based implementations of the LayoutTestController's
numberOfPendingGeolocationPermissionRequests method.
Test: fast/dom/Geolocation/page-reload-cancel-permission-requests.html
* page/DOMWindow.cpp:
(WebCore::DOMWindow::resetGeolocation):
* page/DOMWindow.h:
* page/Frame.cpp:
(WebCore::Frame::pageDestroyed):
(WebCore::Frame::transferChildFrameToNewDocument):
* page/Geolocation.cpp:
(WebCore::Geolocation::~Geolocation):
(WebCore::Geolocation::page):
(WebCore::Geolocation::reset):
(WebCore::Geolocation::disconnectFrame):
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):
* page/Geolocation.h:
* page/GeolocationController.cpp:
(WebCore::GeolocationController::~GeolocationController):
* page/Navigator.cpp:
(WebCore::Navigator::resetGeolocation):
* page/Navigator.h:
* platform/mock/GeolocationClientMock.cpp:
(WebCore::GeolocationClientMock::numberOfPendingPermissionRequests):
* platform/mock/GeolocationClientMock.h:
2011-01-26 John Knottenbelt <jknotten@chromium.org>
Reviewed by Dmitry Titov.
Detach Geolocation from Frame when Page destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52877
Add accessors to the WebGeolocationClientMock to allow the number of
pending geolocation permission requests to be queried.
* public/WebGeolocationClientMock.h:
* src/WebGeolocationClientMock.cpp:
(WebKit::WebGeolocationClientMock::numberOfPendingPermissionRequests):
2011-01-26 John Knottenbelt <jknotten@chromium.org>
Reviewed by Dmitry Titov.
Detach Geolocation from Frame when Page destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52877
Extend the layout test controller to expose the number of pending
geolocation requests, so that we can test that the requests have
been cancelled on page close.
* DumpRenderTree/LayoutTestController.cpp:
(numberOfPendingGeolocationPermissionRequestsCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::numberOfPendingGeolocationPermissionRequests):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::numberOfPendingGeolocationPermissionRequests):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::numberOfPendingGeolocationPermissionRequests):
* DumpRenderTree/mac/UIDelegate.h:
* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::numberOfPendingGeolocationPermissionRequests):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::numberOfPendingGeolocationPermissionRequests):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::numberOfPendingGeolocationPermissionRequests):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80701
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 10 Mar 2011 09:57:37 +0000 (09:57 +0000)]
Unreviewed.
Add Qt specific expected files for tests introduced in r80622 and r80682.
* platform/qt/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
* platform/qt/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
* platform/qt/fast/dom/scroll-reveal-left-overflow-expected.txt: Added.
* platform/qt/fast/dom/scroll-reveal-top-overflow-expected.checksum: Added.
* platform/qt/fast/dom/scroll-reveal-top-overflow-expected.png: Added.
* platform/qt/fast/dom/scroll-reveal-top-overflow-expected.txt: Added.
* platform/qt/fast/dynamic/dirty-float-in-clean-line-expected.checksum: Added.
* platform/qt/fast/dynamic/dirty-float-in-clean-line-expected.png: Added.
* platform/qt/fast/dynamic/dirty-float-in-clean-line-expected.txt: Added.
* platform/qt/fast/dynamic/float-at-line-break-expected.checksum: Added.
* platform/qt/fast/dynamic/float-at-line-break-expected.png: Added.
* platform/qt/fast/dynamic/float-at-line-break-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80700
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 10 Mar 2011 09:33:11 +0000 (09:33 +0000)]
2011-03-10 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip fast/js/large-expressions.html on GTK.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80699
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 10 Mar 2011 09:23:17 +0000 (09:23 +0000)]
2011-03-10 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip jquery/effects.html on GTK.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80698
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 10 Mar 2011 09:11:30 +0000 (09:11 +0000)]
2011-03-10 Adam Barth <abarth@webkit.org>
Partial revert of http://trac.webkit.org/changeset/80670. This test
has been failing sporatically since it was changed in that revision.
* platform/mac/accessibility/aria-expanded-notifications.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80697
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Thu, 10 Mar 2011 08:33:11 +0000 (08:33 +0000)]
2011-03-10 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Adler.
Able to move nodes across documents
https://bugs.webkit.org/show_bug.cgi?id=19524
Makes cross-document appendChild, insertBefore, Range.insertNode and Range.surroundContents work.
This matches Gecko and the new Dom Core spec. There are a number of Range methods where we don't
match Gecko or the spec that will need to be updated in a following patch.
* dom/html/level1/core/hc_elementwrongdocumenterr-expected.txt:
* dom/html/level1/core/hc_namednodemapwrongdocumenterr-expected.txt:
* dom/xhtml/level1/core/hc_elementwrongdocumenterr-expected.txt:
* dom/xhtml/level1/core/hc_namednodemapwrongdocumenterr-expected.txt:
* fast/dom/move-nodes-across-documents-expected.txt: Added.
* fast/dom/move-nodes-across-documents.html: Added.
2011-03-10 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Adler.
Able to move nodes across documents
https://bugs.webkit.org/show_bug.cgi?id=19524
Makes cross-document appendChild, insertBefore, Range.insertNode and Range.surroundContents work.
This matches Gecko and the new Dom Core spec. There are a number of Range methods where we don't
match Gecko or the spec that will need to be updated in a following patch.
Test: fast/dom/move-nodes-across-documents.html
* dom/Element.cpp:
(WebCore::Element::removeAttributeNode):
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::setNamedItem):
* dom/Node.cpp:
(WebCore::Node::setDocumentRecursively):
(WebCore::checkAcceptChild):
(WebCore::Node::checkReplaceChild):
* dom/Range.cpp:
(WebCore::Range::insertNode):
(WebCore::Range::surroundContents):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80696
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 10 Mar 2011 07:31:13 +0000 (07:31 +0000)]
Not reviewed.
Reverting crash catching code, the bug being hunted was fixed by
http://trac.webkit.org/changeset/80686
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::setAutoLoadImages):
(WebCore::CachedResourceLoader::load):
(WebCore::CachedResourceLoader::loadDone):
(WebCore::CachedResourceLoader::preload):
(WebCore::CachedResourceLoader::requestPreload):
* loader/cache/CachedResourceLoader.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80695
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Thu, 10 Mar 2011 06:54:17 +0000 (06:54 +0000)]
Unreviewed, build fix.
* StringsNotToBeLocalized.txt: Add function names I forgot.
* platform/win/SystemInfo.cpp: #if out some uncalled functions on WinCE,
since they don't compile anyway. Use ZeroMemory() instead of "= {0}"
since Qt is stupid and (sometimes?!) warns about it.
(WebCore::windowsVersion):
(WebCore::processorArchitecture):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80694
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Thu, 10 Mar 2011 06:31:32 +0000 (06:31 +0000)]
Add UA string tags for Windows 64.
https://bugs.webkit.org/show_bug.cgi?id=55226
Reviewed by Ryosuke Niwa.
* StringsNotToBeLocalized.txt:
* platform/win/SystemInfo.cpp:
(WebCore::osVersionForUAString):
(WebCore::isWOW64):
(WebCore::processorArchitecture):
(WebCore::architectureTokenForUAString):
(WebCore::windowsVersionForUAString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80693
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Thu, 10 Mar 2011 06:15:13 +0000 (06:15 +0000)]
2011-03-09 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed: tweaking of Chromium test_expectations.txt
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80692
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Thu, 10 Mar 2011 05:38:47 +0000 (05:38 +0000)]
2011-03-09 Daniel Bates <dbates@rim.com>
Attempt to fix the WinCE build after changeset 80684 <http://trac.webkit.org/changeset/80684>
(Bug #56041<https://bugs.webkit.org/show_bug.cgi?id=56041>).
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute): Substitute variable callFrame for exec in call to createSyntaxError().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Thu, 10 Mar 2011 04:50:57 +0000 (04:50 +0000)]
Unreviewed, attempted build fix.
* WebCore.pri: Try to update include path for Qt Windows build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80690
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Thu, 10 Mar 2011 04:24:34 +0000 (04:24 +0000)]
Unreviewed, build fix.
* platform/win/SystemInfo.cpp:
(WebCore::windowsVersionForUAString): Fix const conversion warning on Qt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Thu, 10 Mar 2011 04:19:56 +0000 (04:19 +0000)]
Unify Windows version checks.
https://bugs.webkit.org/show_bug.cgi?id=55979
Reviewed by Mihai Parparita.
Source/WebCore:
* GNUmakefile.am: Fix spaces -> tabs.
* StringsNotToBeLocalized.txt:
* WebCore.pro: Add SystemInfo.* to Qt build.
* platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::invalidateOnMouseEnterExit):
(WebCore::ScrollbarThemeChromiumWin::getThemeState):
(WebCore::ScrollbarThemeChromiumWin::getThemeArrowState):
* platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
(WebCore::fillBMPGlyphs):
* platform/win/CursorWin.cpp:
(WebCore::createSharedCursor):
* platform/win/ScrollbarThemeWin.cpp:
(WebCore::ScrollbarThemeWin::ScrollbarThemeWin):
* platform/win/SystemInfo.cpp: Add full-fledged version check and UA string helper function.
(WebCore::windowsVersion):
(WebCore::windowsVersionForUAString):
* platform/win/SystemInfo.h: Add full-fledged version check and UA string helper function.
* rendering/RenderThemeChromiumWin.cpp:
(WebCore::getNonClientMetrics):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::getThemeData):
(WebCore::RenderThemeWin::paintMenuList):
(WebCore::RenderThemeWin::paintMenuListButton):
Source/WebKit/gtk:
* webkit/webkitwebsettings.cpp:
(webkitOSVersion):
Source/WebKit/qt:
* Api/qwebpage.cpp:
(QWebPage::userAgentForUrl):
Source/WebKit/win:
* WebView.cpp:
(WebView::standardUserAgentWithApplicationName):
(webKitVersionString):
Source/WebKit2:
* UIProcess/win/WebPageProxyWin.cpp:
(WebKit::WebPageProxy::standardUserAgent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 10 Mar 2011 03:30:57 +0000 (03:30 +0000)]
2011-03-09 Mihai Parparita <mihaip@chromium.org>
JSC now implements Object.freeze/seal (as of r80378) and correct
expectations have been checked in, therefore we now pass more
ietestcenter tests.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80687
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 10 Mar 2011 02:55:02 +0000 (02:55 +0000)]
2011-03-09 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Gentilcore.
REGRESSION (r74807): memory corruption after CachedResourceLoader refactoring
https://bugs.webkit.org/show_bug.cgi?id=53045
Copy the URL out of the CachedResource that is being revalidated, so
that we can still use it (in m_validatedURLs) after removing the
resource from the memory cache, which may delete it.
No new tests, since I was not able to trigger this locally (in a layout
test or otherwise).
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::revalidateResource):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80686
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Thu, 10 Mar 2011 02:23:58 +0000 (02:23 +0000)]
VO reporting incorrect list count for macworld.com/news.html
https://bugs.webkit.org/show_bug.cgi?id=56064
Reviewed by Beth Dakin.
Source/WebCore:
<li> tags should not be ignored, because they provide valuable information
to screen readers.
Test: platform/mac/accessibility/list-items-ignored.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
LayoutTests:
* platform/mac/accessibility/list-items-ignored-expected.txt: Added.
* platform/mac/accessibility/list-items-ignored.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80685
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 10 Mar 2011 02:22:50 +0000 (02:22 +0000)]
Bug 56041 - RexExp constructor should only accept flags "gim"
Fix for issues introduced in r80667.
Reviewed by Sam Weinig.
Source/JavaScriptCore:
Invalid flags to a RegExp literal are a late syntax error!
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addRegExp):
- Pass a PassRefPtr<RegExp>
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addRegExp):
(JSC::BytecodeGenerator::emitNewRegExp):
* bytecompiler/BytecodeGenerator.h:
- Pass a PassRefPtr<RegExp>
* bytecompiler/NodesCodegen.cpp:
(JSC::RegExpNode::emitBytecode):
- Should not be ASSERTing that the flags are valid - this is a late(er) error.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- Need to check for error from RegExp constructor.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- Need to check for error from RegExp constructor.
* runtime/RegExp.h:
(JSC::RegExp::isValid):
- Make isValid check that the regexp was created with valid flags.
* runtime/RegExpKey.h:
- Since we'll not create RegExp objects with invalid flags, separate out the deleted value.
LayoutTests:
* fast/regex/script-tests/parentheses.js:
* fast/regex/script-tests/pcre-test-1.js:
- Providing invalid flags to RegExp literals is an error in ES5.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80684
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Thu, 10 Mar 2011 02:21:53 +0000 (02:21 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=56068
<rdar://problem/9058245> WebKit2: Can't uncheck 'Spelling and Grammar' contextual items
Reviewed by Anders Carlsson.
* UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::contextMenuItemSelected):
Add cases for ContextMenuItemTagCorrectSpellingAutomatically, ContextMenuItemTagCheckSpellingWhileTyping,
and ContextMenuItemTagCheckGrammarWithSpelling
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80683
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 10 Mar 2011 01:56:27 +0000 (01:56 +0000)]
Source/WebCore: <rdar://problem/8733254> Float disappears after incremental layout
Fixed the original bug and a copule more issues noticed while doing so.
Reviewed by Dave Hyatt.
Tests: fast/dynamic/dirty-float-in-clean-line.html
fast/dynamic/float-at-line-break.html
fast/dynamic/float-from-empty-line.html
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren): If findNextLineBreak() returned an empty line,
update the line break info of the last line with the new line break position. This is tested
by float-from-empty-line.html.
(WebCore::RenderBlock::checkFloatsInCleanLine): Factored out code from determineStartPosition()
into this new function.
(WebCore::RenderBlock::determineStartPosition): Call checkFloatsInCleanLine().
(WebCore::RenderBlock::determineEndPosition): When iterating over lines, check clean lines with
floats, as they may yet become dirty because of the floats. This is tested by
dirty-float-in-clean-line.html.
(WebCore::RenderBlock::findNextLineBreak): If a float fits on the line, and the current line
break is at the float, advance it to after the float. Otherwise, if the line gets dirty and the
next one does not, the float will not make it into any line. This is tested by
float-at-line-break.html.
LayoutTests: <rdar://problem/8733254> Float disappears after incremental layout
Reviewed by Dave Hyatt.
* fast/dynamic/dirty-float-in-clean-line-expected.checksum: Added.
* fast/dynamic/dirty-float-in-clean-line-expected.png: Added.
* fast/dynamic/dirty-float-in-clean-line-expected.txt: Added.
* fast/dynamic/dirty-float-in-clean-line.html: Added.
* fast/dynamic/float-at-line-break-expected.checksum: Added.
* fast/dynamic/float-at-line-break-expected.png: Added.
* fast/dynamic/float-at-line-break-expected.txt: Added.
* fast/dynamic/float-at-line-break.html: Added.
* fast/dynamic/float-from-empty-line-expected.checksum: Added.
* fast/dynamic/float-from-empty-line-expected.png: Added.
* fast/dynamic/float-from-empty-line-expected.txt: Added.
* fast/dynamic/float-from-empty-line.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80682
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 10 Mar 2011 01:46:41 +0000 (01:46 +0000)]
2011-03-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
selectionStart reports wrong caret position when the last characters are newlines
https://bugs.webkit.org/show_bug.cgi?id=56061
The bug was caused by SelectionController::setSelection's not calling
notifyRendererOfSelectionChange when old selection was equal to new selection.
Because InsertLineBreakCommand inserts a text node with a single LF before the caret,
this condition holds after the command is executed. However, the values of
selectionStart and selectionEnd still need to be updated in this case because
the offsets counted from the beginning of textarea have been increased by 1.
* editing/SelectionController.cpp:
(WebCore::SelectionController::setSelection): Call notifyRendererOfSelectionChange
when m_selection = s.
* manual-tests/selection-start-after-inserting-line-break-in-textarea.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80679
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 10 Mar 2011 01:21:58 +0000 (01:21 +0000)]
2011-03-09 Martin Robinson <mrobinson@igalia.com>
Add some new GTK+ test results.
* platform/gtk/fast/blockflow/text-orientation-basic-expected.checksum: Added.
* platform/gtk/fast/blockflow/text-orientation-basic-expected.png: Added.
* platform/gtk/fast/blockflow/text-orientation-basic-expected.txt: Added.
* platform/gtk/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
* platform/gtk/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
* platform/gtk/fast/dom/scroll-reveal-left-overflow-expected.txt: Added.
* platform/gtk/fast/dom/scroll-reveal-top-overflow-expected.checksum: Added.
* platform/gtk/fast/dom/scroll-reveal-top-overflow-expected.png: Added.
* platform/gtk/fast/dom/scroll-reveal-top-overflow-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80678
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 10 Mar 2011 00:49:50 +0000 (00:49 +0000)]
2011-03-09 Tony Chang <tony@chromium.org>
Unreviewed, third and final set of baselines for chromium linux lucid x86_64.
These are small rounding differences.
https://bugs.webkit.org/show_bug.cgi?id=55527
* platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum: Added.
* platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Added.
* platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Added.
* platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/paths-data-12-t-expected.checksum: Added.
* platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Added.
* platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Added.
* platform/chromium-linux-x86_64/svg/hixie/perf/001-expected.checksum: Added.
* platform/chromium-linux-x86_64/svg/hixie/perf/001-expected.png: Added.
* platform/chromium-linux-x86_64/svg/hixie/perf/001-expected.txt: Added.
* platform/chromium-linux-x86_64/svg/hixie/perf/002-expected.checksum: Added.
* platform/chromium-linux-x86_64/svg/hixie/perf/002-expected.png: Added.
* platform/chromium-linux-x86_64/svg/hixie/perf/002-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80677
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 10 Mar 2011 00:43:25 +0000 (00:43 +0000)]
2011-03-09 Tony Chang <tony@chromium.org>
Unreviewed, land a second set of baselines for chromium linux lucid x86_64.
These are differences due to a newer freetype and a few rounding
differences in gradients.
https://bugs.webkit.org/show_bug.cgi?id=55527
* platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove01-expected.checksum: Added.
* platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove01-expected.png: Added.
* platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove02-expected.checksum: Added.
* platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove02-expected.png: Added.
* platform/chromium-linux-x86_64/fast/borders/borderRadiusRidge01-expected.checksum: Added.
* platform/chromium-linux-x86_64/fast/borders/borderRadiusRidge01-expected.png: Added.
* platform/chromium-linux-x86_64/fast/images/animated-svg-as-image-expected.checksum: Added.
* platform/chromium-linux-x86_64/fast/images/animated-svg-as-image-expected.png: Added.
* platform/chromium-linux-x86_64/fast/text/international/bidi-mirror-he-ar-expected.checksum: Added.
* platform/chromium-linux-x86_64/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
* platform/chromium-linux-x86_64/fast/text/international/danda-space-expected.checksum: Added.
* platform/chromium-linux-x86_64/fast/text/international/danda-space-expected.png: Added.
* platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.checksum: Added.
* platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png: Added.
* platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum: Added.
* platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
* platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/struct-frag-02-t-expected.checksum: Added.
* platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png: Added.
* platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/text-text-01-b-expected.checksum: Added.
* platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Added.
* platform/chromium-linux-x86_64/svg/batik/text/textFeatures-expected.checksum: Added.
* platform/chromium-linux-x86_64/svg/batik/text/textFeatures-expected.png: Added.
* platform/chromium-linux-x86_64/svg/batik/text/textLayout-expected.checksum: Added.
* platform/chromium-linux-x86_64/svg/batik/text/textLayout-expected.png: Added.
* platform/chromium-linux-x86_64/svg/custom/js-late-clipPath-and-object-creation-expected.checksum: Added.
* platform/chromium-linux-x86_64/svg/custom/js-late-clipPath-and-object-creation-expected.png: Added.
* platform/chromium-linux-x86_64/svg/custom/js-late-clipPath-creation-expected.checksum: Added.
* platform/chromium-linux-x86_64/svg/custom/js-late-clipPath-creation-expected.png: Added.
* platform/chromium-linux-x86_64/svg/custom/js-late-gradient-creation-expected.checksum: Added.
* platform/chromium-linux-x86_64/svg/custom/js-late-gradient-creation-expected.png: Added.
* platform/chromium-linux-x86_64/svg/custom/js-late-pattern-creation-expected.checksum: Added.
* platform/chromium-linux-x86_64/svg/custom/js-late-pattern-creation-expected.png: Added.
* platform/chromium-linux-x86_64/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Added.
* platform/chromium-linux-x86_64/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
* platform/chromium-linux-x86_64/svg/custom/svg-curve-with-relative-cordinates-expected.checksum: Added.
* platform/chromium-linux-x86_64/svg/custom/svg-curve-with-relative-cordinates-expected.png: Added.
* platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.checksum: Added.
* platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png: Added.
* platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.checksum: Added.
* platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png: Added.
* platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.checksum: Added.
* platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png: Added.
* platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.checksum: Added.
* platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.png: Added.
* platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.checksum: Added.
* platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png: Added.
* platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.checksum: Added.
* platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png: Added.
* platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.checksum: Added.
* platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png: Added.
* platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.checksum: Added.
* platform/chromium-linux-x86_64/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png: Added.
* platform/chromium-linux-x86_64/svg/text/text-text-01-b-expected.checksum: Added.
* platform/chromium-linux-x86_64/svg/text/text-text-01-b-expected.png: Added.
* platform/chromium-linux-x86_64/transforms/2d/transform-borderbox-expected.checksum: Added.
* platform/chromium-linux-x86_64/transforms/2d/transform-borderbox-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80676
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 10 Mar 2011 00:39:12 +0000 (00:39 +0000)]
Reviewed by Dan Bernstein.
Frequent crashes when printing in WebPageProxy::setAutodisplay
https://bugs.webkit.org/show_bug.cgi?id=56057
<rdar://problem/9053290>
* UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _delayedResumeAutodisplayTimerFired]):
Null check the page, there is no reason for it to still exist.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80675
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 10 Mar 2011 00:29:32 +0000 (00:29 +0000)]
Windows build fix part 2.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80674
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 10 Mar 2011 00:29:03 +0000 (00:29 +0000)]
2011-03-09 Tony Chang <tony@chromium.org>
Unreviewed, first set of baselines for chromium linux lucid x86_64.
These are just small rounding differences.
https://bugs.webkit.org/show_bug.cgi?id=55527
* platform/chromium-linux-x86_64/fast/repaint/moving-shadow-on-container-expected.txt: Added.
* platform/chromium-linux-x86_64/fast/repaint/moving-shadow-on-path-expected.txt: Added.
* platform/chromium-linux-x86_64/svg/css/composite-shadow-example-expected.txt: Added.
* platform/chromium-linux-x86_64/svg/css/composite-shadow-with-opacity-expected.txt: Added.
* platform/chromium-linux-x86_64/svg/css/stars-with-shadow-expected.txt: Added.
* platform/chromium-linux-x86_64/svg/custom/use-on-symbol-inside-pattern-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80673
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Thu, 10 Mar 2011 00:18:08 +0000 (00:18 +0000)]
2011-03-09 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
Bad cast in HTMLTreeBuilder::processStartTag
https://bugs.webkit.org/show_bug.cgi?id=55955
* fast/parser/self-closing-foreign-content-expected.txt: Added.
* fast/parser/self-closing-foreign-content.html: Added.
2011-03-09 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
Bad cast in HTMLTreeBuilder::processStartTag
https://bugs.webkit.org/show_bug.cgi?id=55955
Test: fast/parser/self-closing-foreign-content.html
When the parser encounters an svg or mathml root element, it places the
insertion mode into InForeignContentMode. However, if the root element
is self-closing (e.g. <svg />) then the element is never placed on the
open elements stack. This leaves the parser in an inconsistent state
where it is in InForeignContentMode but no foreign content is in the
open element stack.
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody): If a self-closing
foreign element is inserted into the tree, do not set the insertion
mode to InForeignContentMode.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80672
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 10 Mar 2011 00:17:47 +0000 (00:17 +0000)]
Windows build fix part 1.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80671
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Thu, 10 Mar 2011 00:16:07 +0000 (00:16 +0000)]
2011-03-09 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Mihai Parparita.
Fix some potentially flaky tests
https://bugs.webkit.org/show_bug.cgi?id=56049
These tests were not resilient to parser yields for reasons explained below.
* media/video-src-plus-source.html: loadstart or loadmetadata could have fired before
the waitForEvent() calls. So define them prior to the <video> element.
* platform/mac/accessibility/aria-expanded-notifications.html: The aria events could
have fired before successfullyParsed was set, so run the test in the onload handler.
* plugins/npruntime/npruntime.html: The plugin could have been loaded before
successfullyParsed was set, so set it before including the plugin.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80670
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 10 Mar 2011 00:15:39 +0000 (00:15 +0000)]
Qt build fix.
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertQVariantToValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80669
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Thu, 10 Mar 2011 00:03:38 +0000 (00:03 +0000)]
2011-03-09 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
REGRESSION (r80320): Assertion failure when processing mis-nested foreign content.
https://bugs.webkit.org/show_bug.cgi?id=55982
* fast/parser/fragment-foreign-content-misnested-expected.txt: Added.
* fast/parser/fragment-foreign-content-misnested.html: Added.
2011-03-09 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
REGRESSION (r80320): Assertion failure when processing mis-nested foreign content.
https://bugs.webkit.org/show_bug.cgi?id=55982
Test: fast/parser/fragment-foreign-content-misnested.html
It is a parse error to encounter certain start tags while the parser's
insertion mode is InForeignContentMode (e.g. <br>). In these cases, we
are to pop open elements off the HTMLElementStack until a foreign
content scope marker is encountered. Before the change in r80320 to not
insert a fake HTML element during fragment parsing, said fake HTML
element counted as a foreign content scope marker.
With r80320, no fake HTML element is inserted and the stack is popped
until empty in cases where no other element claims to be a foreign
content scope marker. Fix this by treating the DocumentFragment as a
foreign content scope marker.
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isForeignContentScopeMarker): Take a
ContainerNode* instead of a Element*.
(WebCore::HTMLElementStack::popUntilForeignContentScopeMarker): Pass
topNode() to isForeignContentScopeMarker() instead of top().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80668
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 9 Mar 2011 23:04:27 +0000 (23:04 +0000)]
Bug 56041 - RexExp constructor should only accept flags "gim"
We also should be passing the flags around as a bitfield rather than a string,
and should not have redundant, incompatible code for converting the string to a bitfield!
Reviewed by Darin Adler.
Source/JavaScriptCore:
* JavaScriptCore.exp:
* bytecompiler/NodesCodegen.cpp:
(JSC::RegExpNode::emitBytecode):
- Need to parse flags string to enum.
* runtime/RegExp.cpp:
(JSC::regExpFlags):
(JSC::RegExp::RegExp):
(JSC::RegExp::create):
- Add method to parse flags string to enum, change constructor/create args to take enum.
* runtime/RegExp.h:
(JSC::RegExp::global):
(JSC::RegExp::ignoreCase):
(JSC::RegExp::multiline):
- Change to use new enum values.
* runtime/RegExpCache.cpp:
(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::create):
* runtime/RegExpCache.h:
- Changed to use regExpFlags enum instead of int/const UString&.
* runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
- Add use new enum parsing, check for error.
* runtime/RegExpKey.h:
(JSC::RegExpKey::RegExpKey):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
- Pass NoFlags value instead of empty string.
(JSC::regExpProtoFuncCompile):
- Add use new enum parsing, check for error.
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
- Pass NoFlags value instead of empty string.
Source/WebCore:
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::readTerminal):
- Need to parse flags string back to enum.
LayoutTests:
* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T1-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T2-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T3-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T4-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T5-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T6-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T7-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T8-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.4/S15.10.4.1_A5_T9-expected.txt:
- Check in passing results!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80667
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 9 Mar 2011 22:46:49 +0000 (22:46 +0000)]
2011-03-09 Martin Robinson <mrobinson@igalia.com>
jquery/manipulation.html fails after r80598
https://bugs.webkit.org/show_bug.cgi?id=56019
Skip jquery test failing on the GTK+ debug bots. Move another
failing test to the appropriate section.
* platform/gtk/Skipped: Update skipped list.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80666
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 9 Mar 2011 22:27:43 +0000 (22:27 +0000)]
2011-03-09 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium]: Regression - Explicitly copy compositing properties from LayerChromium to CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=56021
Adds a test for basic functionality of the backface-visibility
property.
* compositing/backface-visibility-expected.checksum: Added.
* compositing/backface-visibility-expected.png: Added.
* compositing/backface-visibility-expected.txt: Added.
* compositing/backface-visibility.html: Added.
2011-03-09 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium]: Regression - Explicitly copy compositing properties from LayerChromium to CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=56021
Initializes the m_doubleSided flag of LayerChromiums to the default
value of true so the back sides of layers without
backface-visibility:hidden are rendered.
Test: compositing/backface-visibility.html
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80665
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 9 Mar 2011 22:22:05 +0000 (22:22 +0000)]
Restore lists layout test to its pre-text-orientation patch results now that ex units are fixed for vertical text.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80664
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreip@google.com [Wed, 9 Mar 2011 22:21:00 +0000 (22:21 +0000)]
2011-03-09 Andrei Popescu <andreip@google.com>
Unreviewed, build fix.
[Chromium] test_expectations.txt needs updating to expect crashes in tests
that trigger the assertion in FontCache::releaseFontData.
https://bugs.webkit.org/show_bug.cgi?id=56051
We have started seeing an assertion failure in FontCache.cpp:310 after r80582.
It is unclear whether r80582 caused the assertion or whether the problem was
already present at r80582 just made it manifest itself more often. Update the
test_expectations.txt file while we're investigating.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80663
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 9 Mar 2011 22:20:34 +0000 (22:20 +0000)]
<rdar://problem/9110316> REGRESSION: 'ex' unit broken for vertical text
Reviewed by Dan Bernstein.
Fall back to the verticalRightOrientation data when obtaining the x-height for vertically oriented
text. That way we use the same metrics as for horizontal.
This fixes regressions in fast/lists and fast/overflow vertical text tests.
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformBoundsForGlyph):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80662
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 9 Mar 2011 22:07:16 +0000 (22:07 +0000)]
Unreviewed build correction.
* UIProcess/DrawingAreaProxy.messages.in: Exclude the other
method using LayerTreeContext for non-accelerated composition case.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80661
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xji@chromium.org [Wed, 9 Mar 2011 21:47:30 +0000 (21:47 +0000)]
2011-03-09 Xiaomei Ji <xji@chromium.org>
Unreviewed.
Rebaseline after r80622.
* platform/chromium-linux/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
* platform/chromium-linux/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
* platform/chromium-linux/fast/dom/scroll-reveal-top-overflow-expected.checksum: Added.
* platform/chromium-linux/fast/dom/scroll-reveal-top-overflow-expected.png: Added.
* platform/chromium-mac/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
* platform/chromium-mac/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
* platform/chromium-mac/fast/dom/scroll-reveal-left-overflow-expected.txt: Added.
* platform/chromium-mac/fast/dom/scroll-reveal-top-overflow-expected.txt: Added.
* platform/chromium-win/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
* platform/chromium-win/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
* platform/chromium-win/fast/dom/scroll-reveal-left-overflow-expected.txt: Added.
* platform/chromium-win/fast/dom/scroll-reveal-top-overflow-expected.checksum: Added.
* platform/chromium-win/fast/dom/scroll-reveal-top-overflow-expected.png: Added.
* platform/chromium-win/fast/dom/scroll-reveal-top-overflow-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80660
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Wed, 9 Mar 2011 21:18:58 +0000 (21:18 +0000)]
2011-03-09 Abhishek Arya <inferno@chromium.org>
Unreviewed. Rebaselining after text orientation change in r80582.
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80659
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 9 Mar 2011 20:25:24 +0000 (20:25 +0000)]
2011-03-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
REGRESSION: crash in nextLinePosition when extending selection forward by line in an empty document
https://bugs.webkit.org/show_bug.cgi?id=56004
Added a regression test.
* editing/selection/extend-by-line-in-empty-document-expected.txt: Added.
* editing/selection/extend-by-line-in-empty-document.html: Added.
2011-03-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
REGRESSION: crash in nextLinePosition when extending selection forward by line in an empty document
https://bugs.webkit.org/show_bug.cgi?id=56004
The crash was caused by the false assumption that rootEditableElement() or documentElement()
always return non-null pointer. Fixed the bug by adding an early exit.
Test: editing/selection/extend-by-line-in-empty-document.html
* editing/visible_units.cpp:
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80658
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 9 Mar 2011 19:49:16 +0000 (19:49 +0000)]
Hide Leaks Viewer's URL prompt by default
We will show it as needed. I think I left it visible by default by accident after doing some
testing.
Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
URL is passed as a query parameter, but does
Reviewed by Simon Fraser.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80657
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 9 Mar 2011 19:42:12 +0000 (19:42 +0000)]
Don't use Element.classList or box-shadow in Leaks Viewer
They aren't supported by Safari 5. Luckily we have substitutes for them!
Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
Reviewed by Simon Fraser.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
(#url-prompt): Use -webkit-box-shadow instead of box-shadow.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
(LeaksViewer.urlPromptButtonClicked):
(LeaksViewer._displayURLPrompt):
(LeaksViewer._setLoadingIndicatorHidden):
Use add/removeStyleClass (from utilities.js) instead of Element.classList.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80656
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Wed, 9 Mar 2011 19:21:30 +0000 (19:21 +0000)]
2011-03-09 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: it should be possible to copy stack trace from call stack sidebar pane.
https://bugs.webkit.org/show_bug.cgi?id=56024
* English.lproj/localizedStrings.js:
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane):
(WebInspector.CallStackSidebarPane.prototype.update):
(WebInspector.CallStackSidebarPane.prototype._contextMenu):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80655
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 9 Mar 2011 19:17:44 +0000 (19:17 +0000)]
Patch FontPlatformDataLinux to properly initialize and copy orientation/text-orientation in all
places. Make sure text-orientation is specified in the lookups/creation in FontCustomPlatformData
and FontCache.
Reviewed by Darin Adler.
* platform/graphics/chromium/FontPlatformDataLinux.cpp:
(WebCore::FontPlatformData::FontPlatformData):
* platform/graphics/chromium/FontPlatformDataLinux.h:
(WebCore::FontPlatformData::FontPlatformData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80654
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Wed, 9 Mar 2011 19:14:12 +0000 (19:14 +0000)]
2011-03-09 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
JavaNPObject should not use JNI directly
https://bugs.webkit.org/show_bug.cgi?id=56009
We move the JNI code to access a Java object's fields into
a new JavaInstance::getField() method.
No new tests, refactoring only.
* bridge/jni/v8/JavaInstanceV8.cpp:
(JavaInstance::getField):
* bridge/jni/v8/JavaInstanceV8.h:
* bridge/jni/v8/JavaNPObjectV8.cpp:
(JSC::Bindings::JavaNPObjectGetProperty):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80653
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 9 Mar 2011 18:55:08 +0000 (18:55 +0000)]
Add a link to the Leaks Viewer tool on the build.webkit.org homepage
Rubber-stamped by David Kilzer.
* BuildSlaveSupport/build.webkit.org-config/templates/root.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80652
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 9 Mar 2011 18:50:39 +0000 (18:50 +0000)]
Add a Leaks Viewer tool to build.webkit.org
This tool parses leaks from the files generated by the leaks bot and displays them in a
view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
code).
The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
be passed to the tool via the "url" query parameter.
Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
Inspector's Heavy profile view. But it's still pretty useful as-is.
Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots
Reviewed by Darin Adler.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
(#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
(#url-prompt): This is the prompt itself.
(#loading-indicator):
(#loading-indicator > img):
These show a spinner in the bottom-right when we're loading a leaks file.
(.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
as percentages.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
(LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
URL if one wasn't given to us as a query parameter).
(LeaksViewer.get loading):
(LeaksViewer.set loading):
(LeaksViewer.get url):
(LeaksViewer.set url):
Pretty simple accessors.
(LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
prompt.
(LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
(LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
the profile to the Web Inspector code once it's been created.
(LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
(LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
(LeaksViewer._updateTitle): Set our title based on our URL and loading status.
(getResource): Helper function to fetch a resource via XHR and pass it to a callback.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.
(WebInspector.UIString): Just a simple implementation since this tool isn't localized.
(ProfilerAgent.getProfile): Store the callback.
(ProfilerAgent.profileReady): Call the callback.
(monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
count and total leak counts as real values, not percentages or milliseconds.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.
(onmessage): Create a profile based on the leaks file and pass it back to our caller.
(parseLeaks): Extract call stacks out of a leaks file.
(createNode): Helper function to create a new empty profile node.
(createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
WebInspector.ProfileView.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80651
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Wed, 9 Mar 2011 18:24:32 +0000 (18:24 +0000)]
Update expected results of svg/css/getComputedStyle-basic after r80582.
* svg/css/getComputedStyle-basic-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80650
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Wed, 9 Mar 2011 18:21:10 +0000 (18:21 +0000)]
2011-03-09 Mihai Parparita <mihaip@chromium.org>
Update chromium-gpu expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80649
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 9 Mar 2011 18:19:42 +0000 (18:19 +0000)]
Update lists vertical tests after text-orientation landing.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80648
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Wed, 9 Mar 2011 18:17:17 +0000 (18:17 +0000)]
2011-03-09 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
NPAPI - jvalue conversion should not be in JavaInstance
https://bugs.webkit.org/show_bug.cgi?id=55967
No new tests, refactoring only.
* bridge/jni/v8/JavaInstanceV8.cpp:
(JavaInstance::invokeMethod):
* bridge/jni/v8/JavaInstanceV8.h:
* bridge/jni/v8/JavaNPObjectV8.cpp:
(JSC::Bindings::JavaNPObjectInvoke):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80647
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 9 Mar 2011 18:06:10 +0000 (18:06 +0000)]
Change plugins to use their own executable on Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=55991
Reviewed by Anders Carlsson.
* Configurations/PluginProcess.xcconfig: Copied from Source/WebKit2/Configurations/WebProcess.xcconfig.
* PluginProcess/Info.plist: Copied from Source/WebKit2/WebProcess/Info.plist.
Add files necessary for adding PluginProcess.app.
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
Launch the PluginProcess.app when launching a plugin process.
* WebKit2.xcodeproj/project.pbxproj:
Add new executable and new files, removes some unneeded copying
and duplicate compiling of files.
* WebProcess/Info.plist:
Sorted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80646
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Wed, 9 Mar 2011 18:03:14 +0000 (18:03 +0000)]
Update expected results of computed-style and computed-style-without-renderer after
r80582.
* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80645
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 9 Mar 2011 17:47:15 +0000 (17:47 +0000)]
Unreviewed.
jquery/manipulation.html fails after r80598
https://bugs.webkit.org/show_bug.cgi?id=56019
* platform/qt/Skipped:Add jquery tests to make buildbots happier.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80644
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Wed, 9 Mar 2011 16:41:43 +0000 (16:41 +0000)]
Use the Cookie Storage from the Private Browsing Storage Session directly
https://bugs.webkit.org/show_bug.cgi?id=55986
Reviewed by Adam Roben.
Source/WebCore:
* WebCore.exp.in:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
* platform/network/mac/CookieStorageMac.mm:
(WebCore::setCookieStoragePrivateBrowsingEnabled):
Just copy the cookie storage from the private browsing storage session.
* platform/network/cf/CookieStorageCFNet.cpp:
(WebCore::setCookieStoragePrivateBrowsingEnabled):
Ditto.
Source/WebKit/mac:
* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Source/WebKit2:
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
WebKitLibraries:
* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80643
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 9 Mar 2011 16:15:33 +0000 (16:15 +0000)]
Combine multiple --ignore-tests values
https://bugs.webkit.org/show_bug.cgi?id=56016
Reviewed by Adam Roben.
* Scripts/old-run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80642
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Wed, 9 Mar 2011 14:49:49 +0000 (14:49 +0000)]
2011-03-09 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Fixed a crash in InspectorInstrumentation::didReceiveResponse() when loader is null (broken in r80639)
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80641
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Wed, 9 Mar 2011 14:02:55 +0000 (14:02 +0000)]
2011-03-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: pass explicit agent references to InspectorBackendDispatcher
https://bugs.webkit.org/show_bug.cgi?id=55820
* http/tests/inspector-enabled/open-close-open-expected.txt:
* http/tests/inspector-enabled/open-close-open.html:
* http/tests/inspector/inspector-test.js:
():
2011-03-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: pass explicit agent references to InspectorBackendDispatcher
https://bugs.webkit.org/show_bug.cgi?id=55820
* inspector/CodeGeneratorInspector.pm:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::dispatchMessageFromFrontend):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80640
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Wed, 9 Mar 2011 13:40:08 +0000 (13:40 +0000)]
2011-03-09 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: resource errors are not reported before front-end is opened
https://bugs.webkit.org/show_bug.cgi?id=55939
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didReceiveResourceResponse):
(WebCore::InspectorInstrumentation::didFailLoading):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80639
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Wed, 9 Mar 2011 13:34:37 +0000 (13:34 +0000)]
2011-03-09 Alejandro G. Castro <alex@igalia.com>
Fix compilation after r80596, add soup Download stubs.
* GNUmakefile.am:
* WebProcess/Downloads/soup/DownloadSoup.cpp: Added.
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::cancel):
(WebKit::Download::platformInvalidate):
(WebKit::Download::didDecideDestination):
(WebKit::Download::platformDidFinish):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80638
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Wed, 9 Mar 2011 13:32:34 +0000 (13:32 +0000)]
2011-03-09 Alejandro G. Castro <alex@igalia.com>
Fix GTK+ compilation after r80619. Add WebFullScreenManager.
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80637
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Wed, 9 Mar 2011 13:05:35 +0000 (13:05 +0000)]
2011-03-09 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed: assign bug entries to Chromium test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80636
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hans@chromium.org [Wed, 9 Mar 2011 12:05:48 +0000 (12:05 +0000)]
2011-03-08 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Add BackingStoreType parameter to IDBFactoryBackendInterface::open
https://bugs.webkit.org/show_bug.cgi?id=55948
Add a parameter that allows for selection of alternative backing store
implementations.
No new tests: no new functionality.
* storage/IDBFactory.cpp:
(WebCore::IDBFactory::open):
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open):
* storage/IDBFactoryBackendImpl.h:
* storage/IDBFactoryBackendInterface.h:
2011-03-08 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Add BackingStoreType parameter to IDBFactoryBackendInterface::open
https://bugs.webkit.org/show_bug.cgi?id=55948
Add a parameter that allows for selection of alternative backing store
implementations.
* public/WebIDBFactory.h:
(WebKit::WebIDBFactory::open):
* src/AssertMatchingEnums.cpp:
* src/IDBFactoryBackendProxy.cpp:
(WebCore::IDBFactoryBackendProxy::open):
* src/IDBFactoryBackendProxy.h:
* src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::open):
* src/WebIDBFactoryImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80635
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Wed, 9 Mar 2011 11:52:23 +0000 (11:52 +0000)]
2011-03-09 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Move fast/canvas/rgba-parsing.html to the group of
tests failing due to rounding color problems in cairo/pixman.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80634
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Wed, 9 Mar 2011 11:09:20 +0000 (11:09 +0000)]
2011-03-08 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Factor out JNI method call to be used by both JSC and V8
https://bugs.webkit.org/show_bug.cgi?id=55966
No new tests, refactoring only.
* bridge/jni/JNIUtility.cpp:
(JSC::Bindings::callJNIMethod):
* bridge/jni/JNIUtility.h:
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::invokeMethod):
* bridge/jni/v8/JavaInstanceV8.cpp:
(JavaInstance::invokeMethod):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80633
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Wed, 9 Mar 2011 11:01:57 +0000 (11:01 +0000)]
2011-03-09 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [Text editor] Regression in handling DOMNodeInserted/DOMNodeRemoved events
https://bugs.webkit.org/show_bug.cgi?id=55818
* inspector/front-end/TextViewer.js:
(WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80632
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Wed, 9 Mar 2011 10:53:51 +0000 (10:53 +0000)]
2011-03-09 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed: more vertical text fallout for the chromium test expectations.
Also, a rebaseline.
* platform/chromium-mac/fast/lists/003-vertical-expected.checksum: Added.
* platform/chromium-mac/fast/lists/003-vertical-expected.png: Added.
* platform/chromium-mac/fast/lists/003-vertical-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80631
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Wed, 9 Mar 2011 10:00:08 +0000 (10:00 +0000)]
2011-03-09 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Web Inspector: we don't need to transfer objectId and hasChildren for primitive values.
https://bugs.webkit.org/show_bug.cgi?id=55998
* inspector/protocol/console-agent-expected.txt:
* inspector/protocol/runtime-agent-expected.txt:
2011-03-09 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Web Inspector: we don't need to transfer objectId and hasChildren for primitive values.
https://bugs.webkit.org/show_bug.cgi?id=55998
* inspector/InjectedScriptSource.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80630
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 9 Mar 2011 09:57:38 +0000 (09:57 +0000)]
2011-03-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: watch expressions should show string values in quotes.
https://bugs.webkit.org/show_bug.cgi?id=55846
* http/tests/inspector/inspector-test.js:
(initialize_InspectorTest):
* inspector/console/console-dir-expected.txt:
* inspector/console/console-dir.html:
* inspector/debugger/debugger-expand-scope-expected.txt:
* inspector/debugger/debugger-expand-scope.html:
* platform/chromium/inspector/console/console-dir-expected.txt:
* platform/chromium/inspector/debugger/debugger-expand-scope-expected.txt:
2011-03-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: watch expressions should show string values in quotes.
https://bugs.webkit.org/show_bug.cgi?id=55846
* inspector/InjectedScriptSource.js:
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.update):
* inspector/front-end/RemoteObject.js:
(WebInspector.LocalJSONObject.prototype.get description):
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype.update):
* inspector/front-end/inspector.css:
(.console-formatted-string, .console-formatted-regexp):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80629
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 9 Mar 2011 09:53:56 +0000 (09:53 +0000)]
2011-03-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: "length" getter is invoked upon console object formatting.
https://bugs.webkit.org/show_bug.cgi?id=55220
* inspector/console/console-format-expected.txt:
* inspector/console/console-format.html:
* platform/chromium/inspector/console/console-format-expected.txt:
2011-03-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: "length" getter is invoked upon console object formatting.
https://bugs.webkit.org/show_bug.cgi?id=55220
* inspector/InjectedScriptSource.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80628
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Wed, 9 Mar 2011 09:25:51 +0000 (09:25 +0000)]
2011-03-09 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed: yet more tweaking of the chromium test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80627
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Wed, 9 Mar 2011 09:07:19 +0000 (09:07 +0000)]
2011-03-09 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed: fix chromium test expectations file.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80626
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Wed, 9 Mar 2011 08:46:03 +0000 (08:46 +0000)]
2011-03-09 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed: update chromium test expectations
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80625
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xji@chromium.org [Wed, 9 Mar 2011 06:58:49 +0000 (06:58 +0000)]
2011-03-08 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove groupName from objectId.
https://bugs.webkit.org/show_bug.cgi?id=55825
* inspector/protocol/runtime-agent-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80624
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Wed, 9 Mar 2011 06:32:41 +0000 (06:32 +0000)]
2011-03-08 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove groupName from objectId.
https://bugs.webkit.org/show_bug.cgi?id=55825
* inspector/protocol/runtime-agent-expected.txt:
2011-03-08 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove groupName from objectId.
https://bugs.webkit.org/show_bug.cgi?id=55825
* inspector/InjectedScriptSource.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80623
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xji@chromium.org [Wed, 9 Mar 2011 06:23:37 +0000 (06:23 +0000)]
2011-03-08 Xiaomei Ji <xji@chromium.org>
Reviewed by David Hyatt.
Fix Regression: Content not drawn when scrolling horizontally in an RTL page.
https://bugs.webkit.org/show_bug.cgi?id=55077.
* fast/dom/scroll-reveal-left-overflow.html: Added.
* fast/dom/scroll-reveal-top-overflow.html: Added.
* platform/mac/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
* platform/mac/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
* platform/mac/fast/dom/scroll-reveal-left-overflow-expected.txt: Added.
* platform/mac/fast/dom/scroll-reveal-top-overflow-expected.checksum: Added.
* platform/mac/fast/dom/scroll-reveal-top-overflow-expected.png: Added.
* platform/mac/fast/dom/scroll-reveal-top-overflow-expected.txt: Added.
2011-03-08 Xiaomei Ji <xji@chromium.org>
Reviewed by David Hyatt.
Fix Regression: Content not drawn when scrolling horizontally in an RTL page.
https://bugs.webkit.org/show_bug.cgi?id=55077.
Inside ScrollView::calculateOverhangAreasForPainting(), when scroll position
is negative, should include the position value into overhang rectangle's
starting position.
Tests: fast/dom/scroll-reveal-left-overflow.html
fast/dom/scroll-reveal-top-overflow.html
* platform/ScrollView.cpp:
(WebCore::ScrollView::calculateOverhangAreasForPainting):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80622
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 9 Mar 2011 05:57:29 +0000 (05:57 +0000)]
Bug 55994 - Functions on Array.prototype should check length first.
These methods are designed to work on generic objects too, and if 'length'
is a getter that throws an exception, ensure this is correctly thrown
(even if other exceptions would be thrown, too).
Reviewed by Sam Weinig
Source/JavaScriptCore:
Make the length check the first thing we do.
This change shows a progression on SunSpider on my machine, but this is likely bogus.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):
LayoutTests:
Added test cases.
* fast/js/array-proto-func-length-getter-except-expected.txt: Added.
* fast/js/array-proto-func-length-getter-except.html: Added.
* fast/js/script-tests/array-proto-func-length-getter-except.js: Added.
(lengthGetter):
(test):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80621
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Wed, 9 Mar 2011 05:57:23 +0000 (05:57 +0000)]
2011-03-08 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Add templatized CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}()
https://bugs.webkit.org/show_bug.cgi?id=55351
By using some template magic CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}()
can be called on an array A without the caller explicitly specifying the size of A.
No functionality was changed. So no new tests.
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::getPropertyValue): Modified to call templatized variants of
CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}().
(WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Renamed second argument from "number" to "size"
to better reflect its purpose - to be the size of the passed array.
(WebCore::CSSMutableStyleDeclaration::getShorthandValue): Ditto.
(WebCore::CSSMutableStyleDeclaration::getCommonValue): Ditto.
(WebCore::CSSMutableStyleDeclaration::cssText): Modified to call templatized variant of CSSMutableStyleDeclaration::getShorthandValue().
* css/CSSMutableStyleDeclaration.h:
(WebCore::CSSMutableStyleDeclaration::getShorthandValue): Added templatized function that can determine
the size of a passed array. Changed type of second argument to size_t since it represents the size of
an array.
(WebCore::CSSMutableStyleDeclaration::getCommonValue): Ditto.
(WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80620
268f45cc-cd09-0410-ab3c-
d52691b4dbfc