leandro@webkit.org [Fri, 18 Jun 2010 19:16:09 +0000 (19:16 +0000)]
2010-06-18 Leandro Pereira <leandro@profusion.mobi>
[EFL] Unreviewed build fix.
* wtf/CMakeLists.txt: Add MD5.cpp.
2010-06-18 Leandro Pereira <leandro@profusion.mobi>
[EFL] Unreviewed build fix.
* CMakeLists.txt: Add inspector/ScriptBreakpoint.cpp.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61426
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Fri, 18 Jun 2010 19:11:26 +0000 (19:11 +0000)]
Update copyright header.
Rubber-stamped by Sam Weinig.
* html/HTMLLinkElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61425
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Fri, 18 Jun 2010 19:03:07 +0000 (19:03 +0000)]
WebCore: <rdar://problem/8091385> Prevent a crash in WebCore when removing a stylesheet link element in
in a listener to its beforeload event.
https://bugs.webkit.org/show_bug.cgi?id=40742
Reviewed by Dan Bernstein.
Postpone loading of link elements until after they have been inserted into the DOM and
attached. This prevents DOM mutations triggered by beforeload handlers from firing in the
midst of DOM insertion, which can lead to assertion failures and crashes.
Test: fast/dom/beforeload/remove-link-in-beforeload-listener.html
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement): Initialize m_shouldProcessAfterAttach to false.
(WebCore::HTMLLinkElement::processCallback): Add a static callback function which calls
HTMLLinkElement::process().
(WebCore::HTMLLinkElement::insertedIntoDocument): Instead of calling process() directly, set
m_shouldProcessAfterAttach to true to indicate that process() should be called after attach().
(WebCore::HTMLLinkElement::removedFromDocument): Set m_shouldProcessAfterAttach to false.
(WebCore::HTMLLinkElement::attach): If m_shouldProcessAfterAttach is true, register
HTMLLinkElement::processCallback() as a post-attach callback.
* html/HTMLLinkElement.h: Add m_shouldProcessAfterAttach.
(WebCore::HTMLLinkElement::canLazyAttach): Override canLazyAttach() to return false to
indicate that a full attach should be performed. This ensures the post-attach callbacks are
fired.
LayoutTests: <rdar://problem/8091385> Test that removing a stylesheet link element in a listener to its
beforeload event does not crash WebCore.
https://bugs.webkit.org/show_bug.cgi?id=40742
Reviewed by Dan Bernstein.
* fast/dom/beforeload/remove-link-in-beforeload-listener-expected.txt: Added.
* fast/dom/beforeload/remove-link-in-beforeload-listener.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61424
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 18 Jun 2010 18:40:44 +0000 (18:40 +0000)]
Unreviewed. Update Qt specific expected files after r61418.
* platform/qt/editing/pasteboard/paste-text-005-expected.txt:
* platform/qt/editing/pasteboard/paste-text-006-expected.txt:
* platform/qt/editing/pasteboard/paste-text-007-expected.txt:
* platform/qt/editing/pasteboard/paste-text-014-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61423
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Fri, 18 Jun 2010 18:18:08 +0000 (18:18 +0000)]
Unreviewed. Windows build fix.
AX: presentational role needs to be inherited by required elements
https://bugs.webkit.org/show_bug.cgi?id=40132
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::inheritsPresentationalRole):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61422
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Fri, 18 Jun 2010 17:58:42 +0000 (17:58 +0000)]
AX: presentational role needs to be inherited by required elements
https://bugs.webkit.org/show_bug.cgi?id=40132
Reviewed by David Kilzer.
WebCore:
Test: platform/mac/accessibility/inherited-presentational-lists.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::inheritsPresentationalRole):
* accessibility/AccessibilityRenderObject.h:
(WebCore::AccessibilityRenderObject::node):
LayoutTests:
* platform/mac/accessibility/inherited-presentational-lists-expected.txt: Added.
* platform/mac/accessibility/inherited-presentational-lists.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61421
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 18 Jun 2010 17:54:44 +0000 (17:54 +0000)]
Fix GTK build after reflection change.
* bindings/scripts/CodeGeneratorGObject.pm: Changed code
that emits setters to convey the correct type of the attribute.
The GObject code generator takes a different approach to attributes
than the others, so it's hacked a bit to make it more like them.
We should find a way to share more code between the different generators.
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
Updated to expect correct results.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61420
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 18 Jun 2010 17:42:35 +0000 (17:42 +0000)]
2010-06-18 Yury Semikhatsky <yurys@chromium.org>
Unreviewed: Qt build fix.
* inspector/InspectorController.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61419
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justin.garcia@apple.com [Fri, 18 Jun 2010 17:35:50 +0000 (17:35 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=39798
No selection change notification for editing operation that doesn't change the selection's DOM position
Reviewed by Ojan Vafai.
WebCore:
Some editing operations change the selection visually without affecting its position within
the DOM. This was previously known to occur for certain typing commands, but it can also
occur for some Pastes and changes to block style.
* editing/Editor.cpp:
(WebCore::Editor::appliedEditing):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::reappliedEditing):
(WebCore::Editor::changeSelectionAfterCommand):
* editing/Editor.h:
LayoutTests:
block-style-001.html demonstrated the bug, so no new tests have been added.
* platform/mac/editing/execCommand/format-block-expected.txt:
* platform/mac/editing/execCommand/outdent-selection-expected.txt:
* platform/mac/editing/pasteboard/paste-text-005-expected.txt:
* platform/mac/editing/pasteboard/paste-text-006-expected.txt:
* platform/mac/editing/pasteboard/paste-text-007-expected.txt:
* platform/mac/editing/pasteboard/paste-text-014-expected.txt:
* platform/mac/editing/style/apple-style-editable-mix-expected.txt:
* platform/mac/editing/style/block-style-001-expected.txt:
* platform/mac/editing/style/block-style-002-expected.txt:
* platform/mac/editing/style/block-style-003-expected.txt:
* platform/mac/editing/style/create-block-for-style-005-expected.txt:
* platform/mac/editing/style/create-block-for-style-006-expected.txt:
* platform/mac/editing/style/create-block-for-style-008-expected.txt:
* platform/mac/editing/style/relative-font-size-change-002-expected.txt:
* platform/mac/editing/style/relative-font-size-change-003-expected.txt:
* platform/mac/editing/style/relative-font-size-change-004-expected.txt:
* platform/mac/editing/style/table-selection-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61418
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
atwilson@chromium.org [Fri, 18 Jun 2010 17:22:23 +0000 (17:22 +0000)]
Roll chromium DEPS 50089:50171
https://bugs.webkit.org/show_bug.cgi?id=40842
Reviewed by Dumitru Daniliuc.
* DEPS:
Update chromium_rev to r50171 to remove downstream reference to WebFrame::clearName().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61417
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leandro@webkit.org [Fri, 18 Jun 2010 17:12:14 +0000 (17:12 +0000)]
2010-06-18 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Unreviewed build fix.
[EFL] Build break on Debug build.
https://bugs.webkit.org/show_bug.cgi?id=40810
* CMakeLists.txt: Add CSSPreloadScanner.cpp
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61416
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 18 Jun 2010 16:59:49 +0000 (16:59 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=40803
TestNetscapePlugin has an incorrect implementation of "property" property
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Don't
pass a static string back, it's going to be released by NPAPI implementation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61415
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 18 Jun 2010 16:51:49 +0000 (16:51 +0000)]
2010-06-18 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: persist breakpoints in inspector settings.
https://bugs.webkit.org/show_bug.cgi?id=14190
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::setSessionSettings):
(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::setBreakpoint):
(WebCore::InspectorController::removeBreakpoint):
(WebCore::InspectorController::didParseSource):
(WebCore::InspectorController::breakpointsSettingKey):
(WebCore::InspectorController::loadBreakpoints):
(WebCore::InspectorController::saveBreakpoints):
* inspector/InspectorController.h:
* inspector/InspectorValues.cpp:
(WebCore::InspectorValue::parseJSON):
* inspector/InspectorValues.h:
* inspector/ScriptBreakpoint.cpp: Added.
(WebCore::ScriptBreakpoint::sourceBreakpointsFromInspectorObject):
(WebCore::ScriptBreakpoint::inspectorObjectFromSourceBreakpoints):
* inspector/ScriptBreakpoint.h:
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.addBreakpoint):
(WebInspector.BreakpointManager.prototype.restoredBreakpoint):
(WebInspector.BreakpointManager.prototype.breakpointsForSourceID):
(WebInspector.BreakpointManager.prototype.breakpointsForURL):
(WebInspector.BreakpointManager.prototype._addBreakpoint):
* inspector/front-end/inspector.js:
(WebInspector.restoredBreakpoint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61414
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 18 Jun 2010 16:47:54 +0000 (16:47 +0000)]
2010-06-18 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Implement additional DOM attribute reflection for bindings
https://bugs.webkit.org/show_bug.cgi?id=39936
- Added support for [Reflect] for long, unsigned long, and boolean
attributes.
- Fixed code that set attributes like this: <video controls="controls">
to instead set them like this: <video controls>.
- Added lots more uses of [Reflect].
- Removed now-unneeded [ConvertFromString].
- Made [Reflect] imply [ConvertNullToNullString] so we can get rid
of most uses of the latter.
- Made [Reflect] automatically lowercase the name of the reflected
content attribute to minimize the need to specify a custom content
attribute name.
One thing this patch does *not* do is remove the unneeded functions
in the various DOM classes that are no longer used by the bindings.
We should do that in a followup.
* bindings/scripts/CodeGenerator.pm: Added new functions so code
can be shared across bindings, GetterExpressionPrefix and
SetterExpressionPrefix. We can do a lot more refactoring like
this in the future.
* bindings/scripts/CodeGeneratorCPP.pm: Removed unneeded
ConvertFromString handling, changed to use the new
GetterExpressionPrefix and SetterExpressionPrefix functions
to better handle reflected DOM attributes.
* bindings/scripts/CodeGeneratorGObject.pm: Removed unneeded
ConvertFromString handling, changed to use the new
GetterExpressionPrefix and SetterExpressionPrefix functions
to better handle reflected DOM attributes. Fixed a few things
in the output so the .cpp file will have more WebKit style.
The .h file should be GTK style, but the .cpp file can be the
standard WebKit style eventually.
* bindings/scripts/CodeGeneratorJS.pm: Changed to use the new
GetterExpressionPrefix and SetterExpressionPrefix functions
and removed a now-unneeded IsSVGAnimatedType special case since
the new functions take care of it. Made reflected attributes
automatically convert null to the null string without a
separate ConvertNullToNullString attribute.
* bindings/scripts/CodeGeneratorObjC.pm: Changed to use the new
GetterExpressionPrefix and SetterExpressionPrefix functions
and removed a now-unneeded IsSVGAnimatedType special case since
the new functions take care of it. Redid the special cases for
ownerDocument and for operator to fit better with the new code
paths. Removed unneeded ConvertFromString handling.
* bindings/scripts/CodeGeneratorV8.pm: Changed to use the new
GetterExpressionPrefix and SetterExpressionPrefix functions
and removed a now-unneeded IsSVGAnimatedType special case since
the new functions take care of it. Made reflected attributes
automatically convert null to the null string without a
separate ConvertNullToNullString attribute.
* bindings/scripts/test/TestObj.idl: Added some test cases for
content attribute reflection and for exceptions in string-typed
attributes.
* bindings/scripts/test/CPP/WebKitDOMTestObj.cpp: Updated.
* bindings/scripts/test/CPP/WebKitDOMTestObj.h: Ditto.
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
* bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
* bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
* bindings/scripts/test/JS/JSTestObj.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
* bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
* dom/Element.cpp:
(WebCore::Element::getIntegralAttribute): Added.
(WebCore::Element::setIntegralAttribute): Added.
(WebCore::Element::getUnsignedIntegralAttribute): Added.
(WebCore::Element::setUnsignedIntegralAttribute): Added.
* dom/Element.h: Added new attribute get/set functions for bindings.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::isURLAttribute): Added. Returns true for
srcAttr.
* html/HTMLMediaElement.h: Added isURLAttribute.
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::isURLAttribute): Changed to call
HTMLMediaElement::isURLAttribute before checking for posterAttr.
* html/HTMLAnchorElement.idl:
* html/HTMLAppletElement.idl:
* html/HTMLAreaElement.idl:
* html/HTMLBRElement.idl:
* html/HTMLBaseElement.idl:
* html/HTMLBaseFontElement.idl:
* html/HTMLBlockquoteElement.idl:
* html/HTMLBodyElement.idl:
* html/HTMLButtonElement.idl:
* html/HTMLDListElement.idl:
* html/HTMLDirectoryElement.idl:
* html/HTMLDivElement.idl:
* html/HTMLElement.idl:
* html/HTMLEmbedElement.idl:
* html/HTMLFontElement.idl:
* html/HTMLFormElement.idl:
* html/HTMLFrameElement.idl:
* html/HTMLFrameSetElement.idl:
* html/HTMLHRElement.idl:
* html/HTMLHeadElement.idl:
* html/HTMLHeadingElement.idl:
* html/HTMLHtmlElement.idl:
* html/HTMLIFrameElement.idl:
* html/HTMLImageElement.idl:
* html/HTMLInputElement.idl:
* html/HTMLIsIndexElement.idl:
* html/HTMLLIElement.idl:
* html/HTMLLabelElement.idl:
* html/HTMLLegendElement.idl:
* html/HTMLLinkElement.idl:
* html/HTMLMapElement.idl:
* html/HTMLMediaElement.idl:
* html/HTMLMenuElement.idl:
* html/HTMLMetaElement.idl:
* html/HTMLModElement.idl:
* html/HTMLOListElement.idl:
* html/HTMLObjectElement.idl:
* html/HTMLOptGroupElement.idl:
* html/HTMLOptionElement.idl:
* html/HTMLParagraphElement.idl:
* html/HTMLParamElement.idl:
* html/HTMLPreElement.idl:
* html/HTMLQuoteElement.idl:
* html/HTMLScriptElement.idl:
* html/HTMLStyleElement.idl:
* html/HTMLTableCaptionElement.idl:
* html/HTMLTableCellElement.idl:
* html/HTMLTableColElement.idl:
* html/HTMLTableElement.idl:
* html/HTMLTableRowElement.idl:
* html/HTMLTableSectionElement.idl:
* html/HTMLTextAreaElement.idl:
* html/HTMLUListElement.idl:
* html/HTMLVideoElement.idl:
* svg/SVGElement.idl:
Added more uses of [Reflect]. Got rid of uses of [ConvertNullToNullString] that
are now unneeded since [Reflect] now implies that. Changed formatting to be
simpler and consistent without all the lining up and multiple lines.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61413
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Fri, 18 Jun 2010 16:39:59 +0000 (16:39 +0000)]
Remove some unnecessary checks that cause compiler warnings.
https://bugs.webkit.org/show_bug.cgi?id=40772
Reviewed by Dimitri Glazkov.
* bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
(WebCore::V8SQLResultSetRowList::itemCallback):
* bindings/v8/npruntime.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61412
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 18 Jun 2010 16:11:20 +0000 (16:11 +0000)]
2010-06-18 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: Implement 'takeHeapSnapshot' in InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=40834
* bindings/js/ScriptProfiler.h:
(WebCore::ScriptProfiler::takeHeapSnapshot):
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::takeHeapSnapshot):
* bindings/v8/ScriptProfiler.h:
* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::takeHeapSnapshot):
* inspector/InspectorBackend.h:
* inspector/InspectorBackend.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::takeHeapSnapshot):
* inspector/InspectorController.h:
* src/js/HeapProfilerPanel.js:
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
* src/js/InspectorControllerImpl.js:
(devtools.InspectorBackendImpl):
* src/js/ProfilerAgent.js:
(devtools.ProfilerAgent.prototype.startProfiling):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61411
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 18 Jun 2010 15:55:44 +0000 (15:55 +0000)]
REGRESSION (r61379?): Assertion failure in Element::getURLAttribute() when accessing the src attribute of a script element
https://bugs.webkit.org/show_bug.cgi?id=40831
Reviewed by Anders Carlsson.
WebCore:
Test: fast/dom/HTMLScriptElement/isURLAttribute.html
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::isURLAttribute): Check for the 'src' attribute.
LayoutTests:
* fast/dom/HTMLScriptElement/isURLAttribute-expected.txt: Added.
* fast/dom/HTMLScriptElement/isURLAttribute.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61410
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 18 Jun 2010 15:54:23 +0000 (15:54 +0000)]
2010-06-18 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, expectations update.
New baselines after http://trac.webkit.org/changeset/61393.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61409
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 18 Jun 2010 15:46:24 +0000 (15:46 +0000)]
2010-06-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r61405.
http://trac.webkit.org/changeset/61405
https://bugs.webkit.org/show_bug.cgi?id=40838
broke chromium mac compile (Requested by tonyg-cr1 on
#webkit).
* fast/js/parser-high-byte-character-expected.txt: Removed.
* fast/js/parser-high-byte-character.html: Removed.
* fast/js/script-tests/parser-high-byte-character.js: Removed.
2010-06-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r61405.
http://trac.webkit.org/changeset/61405
https://bugs.webkit.org/show_bug.cgi?id=40838
broke chromium mac compile (Requested by tonyg-cr1 on
#webkit).
* bindings/v8/ScriptSourceCode.h:
(WebCore::ScriptSourceCode::ScriptSourceCode):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::compileScript):
(WebCore::V8Proxy::evaluate):
* bindings/v8/V8Proxy.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61408
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leandro@webkit.org [Fri, 18 Jun 2010 15:44:24 +0000 (15:44 +0000)]
2010-06-18 Leandro Pereira <leandro@profusion.mobi>
Unreviewed.
Adding myself to the committers list.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61407
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 18 Jun 2010 15:14:10 +0000 (15:14 +0000)]
2010-06-18 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Fix WebGLRenderingContext helper functions find{Texture/Renderbuffer/Buffer}
https://bugs.webkit.org/show_bug.cgi?id=40176
* fast/canvas/webgl/gl-object-get-calls-expected.txt: Test name == 0 cases, and test getVertexAttrib return original WebGLBuffer object.
* fast/canvas/webgl/script-tests/gl-object-get-calls.js: Ditto.
2010-06-18 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Fix WebGLRenderingContext helper functions find{Texture/Renderbuffer/Buffer}
https://bugs.webkit.org/show_bug.cgi?id=40176
* html/canvas/WebGLBuffer.cpp: Remove constructor with existing name.
* html/canvas/WebGLBuffer.h: Ditto.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getVertexAttrib): Use findBuffer instead of creating a new WebGLBuffer.
(WebCore::WebGLRenderingContext::findTexture): Deal with name == 0 case and return raw pointer.
(WebCore::WebGLRenderingContext::findRenderbuffer): Ditto.
(WebCore::WebGLRenderingContext::findBuffer): Find WebGLBuffer object using given name.
* html/canvas/WebGLRenderingContext.h: Add findBuffer function declaration, change return type to raw pointer.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61406
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 18 Jun 2010 15:00:29 +0000 (15:00 +0000)]
2010-06-18 Tony Gentilcore <tonyg@chromium.org>
Reviewed by David Levin.
Persist V8's ScriptData to the memory cache.
https://bugs.webkit.org/show_bug.cgi?id=38661
When V8 ScriptData caching was originally submitted it causes crashes
in external scripts with high-byte characters. This new test crashes on
the original code, but now passes.
* fast/js/parser-high-byte-character-expected.txt: Added.
* fast/js/parser-high-byte-character.html: Added.
* fast/js/script-tests/parser-high-byte-character.js: Added.
(runTest):
2010-06-18 Tony Gentilcore <tonyg@chromium.org>
Reviewed by David Levin.
Persist V8's ScriptData to the memory cache.
https://bugs.webkit.org/show_bug.cgi?id=38661
This stores V8's ScriptData in the memory cache and also causes the
network platform layer to be notified of the available cacheable
metadata.
Chromium's morejs benchmark showed a ~7% improvement when this was
originally submitted (before it had to be rolled back).
Test: fast/js/parser-high-byte-character.html
* bindings/v8/ScriptSourceCode.h:
(WebCore::ScriptSourceCode::ScriptSourceCode):
(WebCore::ScriptSourceCode::cachedScript):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::compileScript):
(WebCore::V8Proxy::precompileScript):
(WebCore::V8Proxy::evaluate):
* bindings/v8/V8Proxy.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61405
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jun 2010 13:35:28 +0000 (13:35 +0000)]
[Qt] Fix documentation for the declarative module import.
Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.
* declarative/qdeclarativewebview.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61404
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Fri, 18 Jun 2010 13:09:59 +0000 (13:09 +0000)]
2010-06-18 Dirk Schulze <krit@webkit.org>
Not reviewed. Rebaseline gtk results.
* platform/gtk/Skipped:
* platform/gtk/svg/custom/broken-internal-references-expected.txt:
* platform/gtk/svg/filters/filter-on-filter-for-text-expected.txt:
* platform/gtk/svg/filters/filter-on-tspan-expected.txt:
* platform/gtk/svg/text/text-hkern-expected.txt:
* platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt:
* platform/gtk/svg/text/text-vkern-expected.txt:
* platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61403
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Fri, 18 Jun 2010 12:50:21 +0000 (12:50 +0000)]
2010-06-18 Anton Muhin <antonm@chromium.org>
Reviewed by Dimitri Glazkov.
[v8] Finish migration to new named property query API
https://bugs.webkit.org/show_bug.cgi?id=40771
Remove definition which allowed gradual transition to new API.
See https://bugs.webkit.org/show_bug.cgi?id=40303 for first phase.
Requires V8 roll.
* DEPS:
2010-06-18 Anton Muhin <antonm@chromium.org>
Reviewed by Dimitri Glazkov.
[v8] Finish migration to new named property query API
https://bugs.webkit.org/show_bug.cgi?id=40771
Remove definition which allowed gradual transition to new API.
See https://bugs.webkit.org/show_bug.cgi?id=40303 for first phase.
* config.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61402
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 18 Jun 2010 12:50:16 +0000 (12:50 +0000)]
2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Rebaseline win results.
* platform/win/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt: Added.
* platform/win/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
* platform/win/svg/custom/broken-internal-references-expected.txt:
* platform/win/svg/custom/clip-path-referencing-use2-expected.txt:
* platform/win/svg/custom/image-with-transform-clip-filter-expected.txt:
* platform/win/svg/custom/junk-data-expected.txt: Added.
* platform/win/svg/custom/missing-xlink-expected.txt: Added.
* platform/win/svg/filters/feColorMatrix-values-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61401
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jun 2010 12:38:41 +0000 (12:38 +0000)]
Fix documentation issue on the onAlert handler.
Fix compilation issue with QT_NO_ACTION.
Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.
* declarative/qdeclarativewebview.cpp:
* declarative/qdeclarativewebview_p.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61400
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 18 Jun 2010 12:34:22 +0000 (12:34 +0000)]
2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Rebaseline mac-snowleopard results.
* platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
* platform/mac/svg/custom/junk-data-expected.txt:
* platform/mac/svg/custom/missing-xlink-expected.txt:
* platform/mac/svg/text/text-intro-05-t-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61399
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 18 Jun 2010 12:28:27 +0000 (12:28 +0000)]
2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Rebaseline mac-tiger test results.
* platform/mac-tiger/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
* platform/mac-tiger/svg/hixie/text/003-expected.txt:
* platform/mac-tiger/svg/hixie/text/003a-expected.txt:
* platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
* platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61398
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 18 Jun 2010 12:27:27 +0000 (12:27 +0000)]
2010-06-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: bring XHR console records back.
- adds "Enable XHR Monitor" / "Disable XHR Monitor" actions to the console's context menu
- make the chosen option persist in the settings.
https://bugs.webkit.org/show_bug.cgi?id=40799
* English.lproj/localizedStrings.js:
* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::disableSearchingForNode):
(WebCore::InspectorBackend::enableMonitoringXHR):
(WebCore::InspectorBackend::disableMonitoringXHR):
* inspector/InspectorBackend.h:
* inspector/InspectorBackend.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::setMonitoringXHR):
(WebCore::InspectorController::didLoadResourceFromMemoryCache):
(WebCore::InspectorController::identifierForInitialRequest):
(WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
(WebCore::InspectorController::ensureSettingsLoaded):
* inspector/InspectorController.h:
* inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::monitoringXHRWasEnabled):
(WebCore::InspectorFrontend::monitoringXHRWasDisabled):
* inspector/InspectorFrontend.h:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._handleContextMenuEvent):
(WebInspector.ConsoleView.prototype._registerShortcuts):
* inspector/front-end/InjectedScript.js:
(injectedScriptConstructor.):
* inspector/front-end/InspectorBackendStub.js:
(.WebInspector.InspectorBackendStub):
(.WebInspector.InspectorBackendStub.prototype.enableMonitoringXHR):
(.WebInspector.InspectorBackendStub.prototype.disableMonitoringXHR):
* inspector/front-end/inspector.js:
(WebInspector.monitoringXHRWasEnabled):
(WebInspector.monitoringXHRWasDisabled):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::didFinishLoading):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61397
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 18 Jun 2010 12:25:14 +0000 (12:25 +0000)]
2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Rebaselined Qt test results.
* platform/qt/svg/custom/broken-internal-references-expected.txt:
* platform/qt/svg/custom/empty-mask-expected.txt:
* platform/qt/svg/custom/mask-invalidation-expected.txt:
* platform/qt/svg/custom/stroke-width-large-expected.txt:
* platform/qt/svg/custom/text-xy-updates-SVGList-expected.txt:
* platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
* platform/qt/svg/dom/altGlyph-dom-expected.txt: Added.
* platform/qt/svg/filters/feColorMatrix-values-expected.txt:
* platform/qt/svg/filters/feComposite-expected.txt:
* platform/qt/svg/filters/filter-on-tspan-expected.txt:
* platform/qt/svg/filters/sourceAlpha-expected.txt:
* platform/qt/svg/text/lengthAdjust-text-metrics-expected.txt: Added.
* platform/qt/svg/text/selection-background-color-expected.txt:
* platform/qt/svg/text/selection-doubleclick-expected.txt:
* platform/qt/svg/text/selection-styles-expected.txt:
* platform/qt/svg/text/selection-tripleclick-expected.txt:
* platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
* platform/qt/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61396
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jun 2010 12:23:20 +0000 (12:23 +0000)]
REGRESSION(r60958) [Qt] qwebpage::inputMethods auto-test fails
https://bugs.webkit.org/show_bug.cgi?id=40830
Reviewed by Antti Koivisto.
When activating a regular input method field, always set or unset the ImhHiddenText
input method hint.
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::setInputMethodState):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61395
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 18 Jun 2010 11:37:00 +0000 (11:37 +0000)]
2010-06-18 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
* platform/chromium/test_expectations.txt:
Merge text_expectations.txt of Chromium tree.
Mainly for <progress> and <meter>.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61394
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 18 Jun 2010 11:18:44 +0000 (11:18 +0000)]
2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Modernize SVG Text code, following the HTML design
https://bugs.webkit.org/show_bug.cgi?id=40663
SVG Text does not support subpixel positioning
https://bugs.webkit.org/show_bug.cgi?id=12172
RenderSVGText can't do partial repaints
https://bugs.webkit.org/show_bug.cgi?id=15386
HTML and SVG need to share more text painting code
https://bugs.webkit.org/show_bug.cgi?id=15644
Rewrite SVG Text rendering, only keeping the layout of the actual characters/chunks as it was.
We're now drawing SVG Text very similar to HTML Text, utilizing the SVGInlineFlowBox/SVGInlineTextBox structure,
instead of painting all text content of a <text> element from the SVGRootInlineBox, as it was the last years.
Rough overview of the changes:
- Partial repainting support for text selections (startPos/endPos are respected), no more redrawing of the whole <text> content while selecting
- Subpixel positioning (near pixel-perfect rendering for all W3C tests that contain text, finally!)
-> much better textPath results, characters now align as expected, as all rounding hacks are disabled for SVG text runs, and subpixel precision is used while painting
- No more custom handling of selection, the standard methods offsetFromPosition() / selectionRectForText() are used instead.
- Selection works as expected on stretched/squeezed text (lengthAdjust="spacingAndGlyphs"), takes 'includePartialGlyphs' into account - just like HTML text
- Correct text decoration drawing (proper with and positions and rendering-order, underline/overline before text, strike-through afterwards)
- Proper sizing of all InlineBoxes, starting from the SVGRootInlineBox, down to every single flow & text box
-> correct DRT results, no more weird negative offsets of text runs, etc. Looks exactly like the HTML text test results.
- Rewritten SVGTextContentElement API to take per-character / per-chunk transformations into account.
- Speeeeeed! Drawing is much faster now.
Add 24 new testcases covering basic selection features and the SVGTextContentElement API. Each test draws a half-opaque red rectangle, calculated using
SVGTextContentElement API to highlight the area that is supposed to be selected. Then eventSender API is utilized to move the mouse to the calculated
start origin, holding it down and moving it to the end position.
A detailed list of tests that show progression, can be found in the corresponding LayoutTests/ChangeLog.
Note that this requires a rebaselining of all SVG tests containing text elements.
Tests: svg/hixie/text/001.xml (moved from svg/hixie/text/001-broken.xml)
svg/text/lengthAdjust-text-metrics.html
svg/text/select-textLength-spacing-squeeze-1.svg
svg/text/select-textLength-spacing-squeeze-2.svg
svg/text/select-textLength-spacing-squeeze-3.svg
svg/text/select-textLength-spacing-squeeze-4.svg
svg/text/select-textLength-spacing-stretch-1.svg
svg/text/select-textLength-spacing-stretch-2.svg
svg/text/select-textLength-spacing-stretch-3.svg
svg/text/select-textLength-spacing-stretch-4.svg
svg/text/select-textLength-spacingAndGlyphs-squeeze-1.svg
svg/text/select-textLength-spacingAndGlyphs-squeeze-2.svg
svg/text/select-textLength-spacingAndGlyphs-squeeze-3.svg
svg/text/select-textLength-spacingAndGlyphs-squeeze-4.svg
svg/text/select-textLength-spacingAndGlyphs-stretch-1.svg
svg/text/select-textLength-spacingAndGlyphs-stretch-2.svg
svg/text/select-textLength-spacingAndGlyphs-stretch-3.svg
svg/text/select-textLength-spacingAndGlyphs-stretch-4.svg
svg/text/select-x-list-1.svg
svg/text/select-x-list-2.svg
svg/text/select-x-list-3.svg
svg/text/select-x-list-4.svg
svg/text/select-x-list-with-tspans-1.svg
svg/text/select-x-list-with-tspans-2.svg
svg/text/select-x-list-with-tspans-3.svg
svg/text/select-x-list-with-tspans-4.svg
* rendering/InlineBox.h: Remove not needed isInlineBox() method.
(WebCore::InlineBox::isInlineTextBox): Constify this method.
(WebCore::InlineBox::isSVGInlineTextBox): Added, with ENABLE(SVG) guards, just like the existing isSVGRootInlineBox().
(WebCore::InlineBox::isSVGRootInlineBox): Constify this method.
(WebCore::InlineBox::calculateBoundaries): Added, with ENABLE(SVG) guards, used to calculate the whole boundaries of a InlineText/FlowBox, only used in SVG text.
* rendering/InlineFlowBox.h: Devirtualize placeBoxesHorizontally(), SVG no more overrides it.
* rendering/InlineTextBox.h: Virtualize selectionStartEnd() - SVGInlineTextBox needs to change start/endPositions based on the current text chunk part that it's rendering.
SVGTextChunkLayoutInfo.h contains a detailed documentation what a SVGTextChunk/SVGTextChunkPart is, and why they are necessary.
(WebCore::InlineTextBox::isInlineTextBox): Constify this method.
* rendering/RenderBlock.h:
(WebCore::RenderBlock::forceLayoutInlineChildren): Add helper method, used only by RenderSVGText, to use a simplified layout strategy, which is a big speed win.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeHorizontalPositionsForLine): Remove all isSVGText() special cases, as this function is not called anymore for SVG text.
(WebCore::RenderBlock::layoutInlineChildren): Don't call computeHorizontalPositionsForLine() for SVG text. computePerCharacterLayoutInformation() overrides it anyway.
* rendering/RenderSVGInline.cpp: Remove custom absoluteRects/absoluteQuads code, all shared with RenderInline now.
(WebCore::RenderSVGInline::clippedOverflowRectForRepaint): Added, forward to SVGRenderBase, just like all other non-text SVG renderers do.
(WebCore::RenderSVGInline::computeRectForRepaint): Ditto.
(WebCore::RenderSVGInline::mapLocalToContainer): Ditto
* rendering/RenderSVGInline.h:
* rendering/RenderSVGInlineText.cpp: Remove destroy() hack, which called setNeedsLayoutAndPrefWidthsRecalc/repaint on destruction.
As repaint rects work properly now, this hack is no longer necessary, it was only hiding the real problem.
(WebCore::RenderSVGInlineText::styleDidChange): Don't skip RenderText::styleDidChange() anymore, which automatically schedules layout changes for us.
(WebCore::RenderSVGInlineText::localCaretRect): Remove outdated comment, localCaretRect() is not yet needed in SVG text code.
* rendering/RenderSVGInlineText.h: Remove custom absoluteRects/absoluteQuads/selectionRectForRepaint/positionForPoint/destroy/computeRectForRepaint* code, all shared with RenderText now.
* rendering/RenderSVGText.cpp:
(WebCore::RenderSVGText::mapLocalToContainer): Take x/y translation into account, but do NOT include in localToParentTransform(), as that would affect rendering.
(WebCore::RenderSVGText::layout): Use super-simplified layout strategy, removing a lot of uncessary stuff done by RenderBlock, that SVG does not need.
(WebCore::RenderSVGText::absoluteRects): Remove dead-code, retreving the RenderSVGRoot* object, not necessary since a longer time.
(WebCore::RenderSVGText::absoluteQuads): Ditto.
(WebCore::RenderSVGText::paint): Early exit if we're not in PaintPhaseForeground/PaintPhaseSelfOutline. We're not interessted in other phases.
(WebCore::RenderSVGText::strokeBoundingBox): Fix stroke width calculation, no need to special case SVGFonts.
* rendering/RenderSVGText.h: Remove updateFirstLineBlock/updateFirstLetter overrides, the new RenderSVGText::layout() code, doesn't use these methods at all.
We asked RenderBlock to layout before, which was calling updateFirstLetter & co, this is gone now, as it was all not needed.
(WebCore::RenderSVGText::objectBoundingBox): Directly return the frameRect here, inlined for speed.
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::verticallyAlignBoxes): Early-exit if we're a SVGRootInlineBox. SVG handles this on its own.
* rendering/RootInlineBox.h: Devirtualize verticallyAlignBoxes(), SVG no longer overrides it. Remove virtual computePerCharacterLayoutInformation() method, only lives in SVGRootInlineBox now.
* rendering/SVGCharacterData.h: Remove no longer needed SVGTextDecorationInfo.
* rendering/SVGCharacterLayoutInfo.cpp: Don't pass a reference to a Vector<SVGChar> to SVGCharacterLayoutInfo, let it create it.
(WebCore::SVGCharacterLayoutInfo::SVGCharacterLayoutInfo):
* rendering/SVGCharacterLayoutInfo.h:
* rendering/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::paint): Ask children to paint.
(WebCore::SVGInlineFlowBox::calculateBoundaries): Calculate boundaries by uniting all direct children boundaries.
* rendering/SVGInlineFlowBox.h: Remove placeBoxesHorizontally, which does not get called anymore, and does not need to be overriden.
* rendering/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::SVGInlineTextBox): Don't use abbrevations for variable names, initialize new member variables.
(WebCore::SVGInlineTextBox::measureCharacter): New helper function extracted from buildLayoutInformation, replacing calculateGlyphWidth/Height.
(WebCore::SVGInlineTextBox::offsetForPosition): Implement this method by utilizing Font::offsetForPosition(), but respecting the text chunk parts.
(WebCore::SVGInlineTextBox::positionForOffset): No change here, still not used.
(WebCore::SVGInlineTextBox::selectionRect): Rewritten, utilizing Font::selectionRectForText(), taking text chunk parts into account, and the supplied startPos/endPos.
(WebCore::SVGInlineTextBox::paint): Rewritten, to handle paint servers much more elegant, than the old solution. See code for details, too much to explain here.
(WebCore::SVGInlineTextBox::acquirePaintingResource): Helper function, used from paint().
(WebCore::SVGInlineTextBox::releasePaintingResource): Ditto.
(WebCore::SVGInlineTextBox::prepareGraphicsContextForTextPainting): Ditto.
(WebCore::SVGInlineTextBox::restoreGraphicsContextAfterTextPainting): Ditto.
(WebCore::SVGInlineTextBox::constructTextRun): Helper function centralizing the creation of a TextRun object, used to draw/measure SVG text.
(WebCore::SVGInlineTextBox::mapStartEndPositionsIntoChunkPartCoordinates): Important helper function, mapping a startPos/endPos from InlineTextBox
coordinate space to the SVGInlineTextBox, respecting the current text chunk part.
(WebCore::SVGInlineTextBox::selectionStartEnd): Call InlineTextBox::selectionStartEnd(), and apply post fixes when m_currentChunkPart is set. (called when painting a selected chunk part)
(WebCore::positionOffsetForDecoration): Refactored from old paintDecoration() code.
(WebCore::thicknessForDecoration): Ditto.
(WebCore::findRenderObjectDefininingTextDecoration): Ditto.
(WebCore::SVGInlineTextBox::paintDecoration): Ditto. (Can not share the code with HTML, as we need floating point precision, and directly call fillRect, instead of drawHighlightForText.)
(WebCore::SVGInlineTextBox::paintDecorationWithStyle): Ditto.
(WebCore::SVGInlineTextBox::paintSelection): New method, painting text selections with floating-point precision.
(WebCore::SVGInlineTextBox::paintText): New method, painting text with floating-point precision, correctly handling selected text, removing the need for special SVG text sub-paint phases.
(GlyphFill/StrokeSelectionPhase, GlyphFill/StrokePhase)
(WebCore::SVGInlineTextBox::buildLayoutInformation): Use new measureCharacter() helper function, renamed some variables, to avoid abbrevations.
(WebCore::SVGInlineTextBox::calculateGlyphBoundaries): Rewritten to use new measureCharacter() helper function.
(WebCore::SVGInlineTextBox::calculateBoundaries): Rewritten to take text chunk parts into account, serves as central method used to layout InlineBoxes (see SVGRootInlineBox.)
* rendering/SVGInlineTextBox.h:
(WebCore::SVGInlineTextBox::isSVGInlineTextBox): Added.
(WebCore::SVGInlineTextBox::setHeight): Rename variable, to avoid abbrevations.
(WebCore::SVGInlineTextBox::chunkTransformation): New helper function, returning the transformation, that gets applied to the complete text chunk, if any.
(WebCore::SVGInlineTextBox::setChunkTransformation): New helper function used by SVGRrootInlineBox, to set the chunk transformation, during text chunk part propagation phase.
(WebCore::SVGInlineTextBox::addChunkPartInformation): Ditto.
(WebCore::SVGInlineTextBox::svgTextChunkParts): Ditto.
* rendering/SVGRootInlineBox.cpp: Virtually rewritten, to be designed more like HTMLs RootInlineBox, diving into children for painting.
(WebCore::SVGRootInlineBox::paint): Ask children to paint, nothing more. No more traversing through the SVGTextChunks, figuring out which part to render, this is done in layout phase now.
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): Completly redesigned, see SVGTextChunkLayoutInfo.h for a high-level overview.
(WebCore::SVGRootInlineBox::buildLayoutInformation): Just small cleanups, nothing changed here.
(WebCore::SVGRootInlineBox::layoutChildBoxes): New helper function, extracted from old layoutInlineBoxes().
(WebCore::SVGRootInlineBox::layoutRootBox): Ditto.
(WebCore::SVGRootInlineBox::propagateTextChunkPartInformation): Key-concept of the new design, builds "text chunk parts" and propagates that knownledge to all child SVGInlineTextBoxes.
* rendering/SVGRootInlineBox.h:
(WebCore::SVGRootInlineBox::isSVGRootInlineBox): Constified method.
(WebCore::SVGRootInlineBox::setHeight): Change variable name, to avoid abbrevations.
* rendering/SVGTextChunkLayoutInfo.cpp: Remove if 0, enable compilation.
* rendering/SVGTextChunkLayoutInfo.h: Add large comment explaining text chunk parts, the key concept of the new design. Remove SVGTextChunkWalker & friends, no longer used.
(WebCore::SVGTextChunkPart::SVGTextChunkPart):
(WebCore::SVGTextChunkPart::isValid):
(WebCore::SVGTextChunk::SVGTextChunk):
(WebCore::SVGTextChunkLayoutInfo::SVGTextChunkLayoutInfo):
(WebCore::SVGTextChunkLayoutInfo::textChunks):
* rendering/SVGTextLayoutUtilities.cpp:
(WebCore::cummulatedWidthOfInlineBoxCharacterRange):
(WebCore::cummulatedHeightOfInlineBoxCharacterRange):
(WebCore::svgTextRunForInlineTextBox): Disable rounding hacks, explain parameters with comments, why they have which values.
* rendering/SVGTextLayoutUtilities.h: Remove SVGTextPaintSubphase and SVGTextPaintInfo.
* rendering/SVGTextQuery.cpp: Remove if 0, enable compilation.
* rendering/SVGTextQuery.h: Ditto.
* svg/SVGStyledElement.cpp: Very important change! Do not treat CSS attributes as recognized attributes, that would lead to setNeedsLayout() calls, reducing performance!
This hack existed, as we were not dealing with text updates correctly, now that RenderSVGInlineText::styleDidChange is fixed, it's no longer necessary.
(WebCore::SVGStyledElement::isKnownAttribute):
* svg/SVGTextContentElement.cpp: Completely remove the SVGTextContentElement API, that manually traversed all text chunks, instead use the new SVGTextQuery API.
(WebCore::SVGTextContentElement::getNumberOfChars):
(WebCore::SVGTextContentElement::getComputedTextLength):
(WebCore::SVGTextContentElement::getSubStringLength):
(WebCore::SVGTextContentElement::getStartPositionOfChar):
(WebCore::SVGTextContentElement::getEndPositionOfChar):
(WebCore::SVGTextContentElement::getExtentOfChar):
(WebCore::SVGTextContentElement::getRotationOfChar):
(WebCore::SVGTextContentElement::getCharNumAtPosition):
* svg/SVGTextElement.cpp: Very important change! Do not calls setNeedsLayout() on RenderSVGText, if childrenChanged() has been called.
* svg/SVGTextElement.h: Completly remove childrenChanged() - no longer necessary, updates work as expected without it now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61393
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 18 Jun 2010 10:41:32 +0000 (10:41 +0000)]
2010-06-18 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by David Levin.
Fix compilation when filters are disabled. Revision r60689
changed the signature of SVGRenderBase::prepareToRenderSVGContent()
but didn't change the unsused parameters when filters are disabled.
https://bugs.webkit.org/show_bug.cgi?id=40625
No new tests. Compilation fix.
* rendering/SVGRenderSupport.cpp:
(WebCore::SVGRenderBase::prepareToRenderSVGContent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61392
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 18 Jun 2010 10:28:46 +0000 (10:28 +0000)]
2010-06-18 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
noAccess url schemes block access to inline stylesheets
https://bugs.webkit.org/show_bug.cgi?id=32309
Test that data URLs can access their inline style sheets.
* http/tests/security/data-url-inline.css-expected.txt: Added.
* http/tests/security/data-url-inline.css.html: Added.
2010-06-18 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
noAccess url schemes block access to inline stylesheets
https://bugs.webkit.org/show_bug.cgi?id=32309
Instead of using baseURL() to grab the security context we should just
use finalURL directly. When I wrote the original patch that added this
security check, finalURL didn't exist yet.
If finalURL is an empty URL, that means we generated the style sheet
from text that didn't have a URL. It would be slightly safer to store
a bit on CSSStyleSheet indicating whether it came from an inline style
sheet, but I think this check is fairly accurate.
Test: http/tests/security/data-url-inline.css.html
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::cssRules):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61391
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 18 Jun 2010 09:31:34 +0000 (09:31 +0000)]
2010-06-18 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Remove unneeded custom code for WebSocket.send
https://bugs.webkit.org/show_bug.cgi?id=38180
We don't appear to require a custom binding here. The old function was
wacky in two ways:
1) It required all of its arguments.
2) If the toString of its argument threw, it would catch the exception
and re-throw a different exception.
I've kept the first behavior but changed the second (and documented it
with a test).
Test: websocket/tests/send-throw.html
* bindings/js/JSWebSocketCustom.cpp:
* bindings/v8/custom/V8WebSocketCustom.cpp:
* websockets/WebSocket.idl:
2010-06-18 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Remove unneeded custom code for WebSocket.send
https://bugs.webkit.org/show_bug.cgi?id=38180
Test what happens when you pass an object to WebSocket.send that throws
when you convert it to a string.
* websocket/tests/script-tests/send-throw.js: Added.
(endTest):
(FIRST_MESSAGE_TO_SEND.toString):
(ws.onopen):
(ws.onclose):
(timeOutCallback):
* websocket/tests/send-throw-expected.txt: Added.
* websocket/tests/send-throw.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61390
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 18 Jun 2010 09:18:04 +0000 (09:18 +0000)]
WebKit: [qt] Better check for the declarative plugin inclusion.
Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.
* WebKit.pro:
WebKit/qt: [Qt] Change the target path to QtWebKit.
Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.
* declarative/declarative.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61389
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Fri, 18 Jun 2010 09:16:22 +0000 (09:16 +0000)]
Move isAvailable()/setIsAvailable() from Database/DatabaseSync to AbstractDatabase.
https://bugs.webkit.org/show_bug.cgi?id=39041
Reviewed by Adam Barth.
WebCore:
* WebCore.base.exp
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::openDatabaseEnabled):
(WebCore::RuntimeEnabledFeatures::openDatabaseSyncEnabled):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::openDatabase):
* storage/AbstractDatabase.cpp:
(WebCore::AbstractDatabase::isAvailable):
(WebCore::AbstractDatabase::setIsAvailable):
* storage/AbstractDatabase.h:
* storage/Database.cpp:
* storage/Database.h:
* storage/DatabaseSync.cpp:
* storage/DatabaseSync.h:
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::openDatabase):
(WebCore::WorkerContext::openDatabaseSync):
* workers/WorkerContext.h:
WebKit/chromium:
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableDatabase):
(WebKit::WebRuntimeFeatures::isDatabaseEnabled):
WebKit/gtk:
* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
(webkit_get_cache_model):
WebKit/mac:
* WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]):
WebKit/qt:
* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
WebKit/win:
* WebView.cpp:
(WebView::notifyPreferencesChanged):
WebKit/wx:
* WebView.cpp:
(wxWebView::SetDatabasesEnabled):
(wxWebView::AreDatabasesEnabled):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61388
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 18 Jun 2010 09:01:04 +0000 (09:01 +0000)]
2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Try to turn Gtk 32-bit Linux Debug green again.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61387
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 18 Jun 2010 08:58:22 +0000 (08:58 +0000)]
2010-06-18 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Fix the namespace indent for HTML5Lexer. This patch changes
white-space only.
* html/HTML5Lexer.h:
(WebCore::HTML5Lexer::):
(WebCore::HTML5Lexer::lineNumber):
(WebCore::HTML5Lexer::columnNumber):
(WebCore::HTML5Lexer::state):
(WebCore::HTML5Lexer::setState):
(WebCore::HTML5Lexer::skipLeadingNewLineForListing):
(WebCore::HTML5Lexer::InputStreamPreprocessor::InputStreamPreprocessor):
(WebCore::HTML5Lexer::InputStreamPreprocessor::nextInputCharacter):
(WebCore::HTML5Lexer::InputStreamPreprocessor::peek):
(WebCore::HTML5Lexer::InputStreamPreprocessor::advance):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61386
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ukai@chromium.org [Fri, 18 Jun 2010 08:28:00 +0000 (08:28 +0000)]
Unreviewed test breakage fix.
WebSocket: resume should not process buffer if already processing.
https://bugs.webkit.org/show_bug.cgi?id=39340
MessageLoop runs in main thread, so we don't need to use timer in worker thread.
Also, we should not use Timer in worker thread.
* websockets/ThreadableWebSocketChannelClientWrapper.h:
(WebCore::ThreadableWebSocketChannelClientWrapper::resume):
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61385
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 18 Jun 2010 06:58:58 +0000 (06:58 +0000)]
2010-06-17 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r61379.
http://trac.webkit.org/changeset/61379
https://bugs.webkit.org/show_bug.cgi?id=40813
Broke multiple tests on all platforms (Requested by tkent on
#webkit).
* bindings/scripts/CodeGenerator.pm:
* bindings/scripts/CodeGeneratorCPP.pm:
* bindings/scripts/CodeGeneratorGObject.pm:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorObjC.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::attrWithException):
(WebDOMTestObj::setAttrWithException):
(WebDOMTestObj::attrWithSetterException):
(WebDOMTestObj::attrWithGetterException):
(WebDOMTestObj::setAttrWithGetterException):
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
(webkit_dom_test_callback_callback_with_class1param):
(webkit_dom_test_callback_callback_with_class2param):
(webkit_dom_test_callback_callback_with_non_bool_return_type):
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_void_method):
(webkit_dom_test_obj_void_method_with_args):
(webkit_dom_test_obj_int_method):
(webkit_dom_test_obj_int_method_with_args):
(webkit_dom_test_obj_obj_method):
(webkit_dom_test_obj_obj_method_with_args):
(webkit_dom_test_obj_method_that_requires_all_args):
(webkit_dom_test_obj_method_that_requires_all_args_and_throws):
(webkit_dom_test_obj_serialized_value):
(webkit_dom_test_obj_method_with_exception):
(webkit_dom_test_obj_with_dynamic_frame):
(webkit_dom_test_obj_with_dynamic_frame_and_arg):
(webkit_dom_test_obj_with_dynamic_frame_and_optional_arg):
(webkit_dom_test_obj_with_dynamic_frame_and_user_gesture):
(webkit_dom_test_obj_with_dynamic_frame_and_user_gesture_asad):
(webkit_dom_test_obj_with_script_state_void):
(webkit_dom_test_obj_with_script_state_obj):
(webkit_dom_test_obj_with_script_state_void_exception):
(webkit_dom_test_obj_with_script_state_obj_exception):
(webkit_dom_test_obj_with_script_execution_context):
(webkit_dom_test_obj_method_with_optional_arg):
(webkit_dom_test_obj_method_with_non_optional_arg_and_optional_arg):
(webkit_dom_test_obj_method_with_non_optional_arg_and_two_optional_args):
(webkit_dom_test_obj_get_read_only_int_attr):
(webkit_dom_test_obj_get_read_only_string_attr):
(webkit_dom_test_obj_get_read_only_test_obj_attr):
(webkit_dom_test_obj_get_int_attr):
(webkit_dom_test_obj_set_int_attr):
(webkit_dom_test_obj_get_long_long_attr):
(webkit_dom_test_obj_set_long_long_attr):
(webkit_dom_test_obj_get_unsigned_long_long_attr):
(webkit_dom_test_obj_set_unsigned_long_long_attr):
(webkit_dom_test_obj_get_string_attr):
(webkit_dom_test_obj_set_string_attr):
(webkit_dom_test_obj_get_test_obj_attr):
(webkit_dom_test_obj_set_test_obj_attr):
(webkit_dom_test_obj_get_attr_with_exception):
(webkit_dom_test_obj_set_attr_with_exception):
(webkit_dom_test_obj_get_attr_with_setter_exception):
(webkit_dom_test_obj_set_attr_with_setter_exception):
(webkit_dom_test_obj_get_attr_with_getter_exception):
(webkit_dom_test_obj_set_attr_with_getter_exception):
(webkit_dom_test_obj_get_script_string_attr):
(webkit_dom_test_obj_get_conditional_attr1):
(webkit_dom_test_obj_set_conditional_attr1):
(webkit_dom_test_obj_get_conditional_attr2):
(webkit_dom_test_obj_set_conditional_attr2):
(webkit_dom_test_obj_get_conditional_attr3):
(webkit_dom_test_obj_set_conditional_attr3):
(webkit_dom_test_obj_get_description):
(webkit_dom_test_obj_get_id):
(webkit_dom_test_obj_set_id):
(webkit_dom_test_obj_get_hash):
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::):
(WebCore::jsTestObjAttrWithException):
(WebCore::jsTestObjAttrWithSetterException):
(WebCore::jsTestObjAttrWithGetterException):
(WebCore::setJSTestObjAttrWithException):
(WebCore::setJSTestObjAttrWithGetterException):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj attrWithException]):
(-[DOMTestObj setAttrWithException:]):
(-[DOMTestObj attrWithSetterException]):
(-[DOMTestObj attrWithGetterException]):
(-[DOMTestObj setAttrWithGetterException:]):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::attrWithExceptionAttrGetter):
(WebCore::TestObjInternal::attrWithExceptionAttrSetter):
(WebCore::TestObjInternal::attrWithSetterExceptionAttrGetter):
(WebCore::TestObjInternal::attrWithGetterExceptionAttrGetter):
(WebCore::TestObjInternal::attrWithGetterExceptionAttrSetter):
(WebCore::TestObjInternal::overloadedMethodCallback):
(WebCore::):
* dom/Element.cpp:
* dom/Element.h:
* html/HTMLAnchorElement.idl:
* html/HTMLAppletElement.idl:
* html/HTMLAreaElement.idl:
* html/HTMLBRElement.idl:
* html/HTMLBaseElement.idl:
* html/HTMLBaseFontElement.idl:
* html/HTMLBlockquoteElement.idl:
* html/HTMLBodyElement.idl:
* html/HTMLButtonElement.idl:
* html/HTMLDListElement.idl:
* html/HTMLDirectoryElement.idl:
* html/HTMLDivElement.idl:
* html/HTMLElement.idl:
* html/HTMLEmbedElement.idl:
* html/HTMLFontElement.idl:
* html/HTMLFormElement.idl:
* html/HTMLFrameElement.idl:
* html/HTMLFrameSetElement.idl:
* html/HTMLHRElement.idl:
* html/HTMLHeadElement.idl:
* html/HTMLHeadingElement.idl:
* html/HTMLHtmlElement.idl:
* html/HTMLIFrameElement.idl:
* html/HTMLImageElement.idl:
* html/HTMLInputElement.idl:
* html/HTMLIsIndexElement.idl:
* html/HTMLLIElement.idl:
* html/HTMLLabelElement.idl:
* html/HTMLLegendElement.idl:
* html/HTMLLinkElement.idl:
* html/HTMLMapElement.idl:
* html/HTMLMediaElement.idl:
* html/HTMLMenuElement.idl:
* html/HTMLMetaElement.idl:
* html/HTMLModElement.idl:
* html/HTMLOListElement.idl:
* html/HTMLObjectElement.idl:
* html/HTMLOptGroupElement.idl:
* html/HTMLOptionElement.idl:
* html/HTMLParagraphElement.idl:
* html/HTMLParamElement.idl:
* html/HTMLPreElement.idl:
* html/HTMLQuoteElement.idl:
* html/HTMLScriptElement.idl:
* html/HTMLStyleElement.idl:
* html/HTMLTableCaptionElement.idl:
* html/HTMLTableCellElement.idl:
* html/HTMLTableColElement.idl:
* html/HTMLTableElement.idl:
* html/HTMLTableRowElement.idl:
* html/HTMLTableSectionElement.idl:
* html/HTMLTextAreaElement.idl:
* html/HTMLUListElement.idl:
* html/HTMLVideoElement.idl:
* svg/SVGElement.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61384
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Fri, 18 Jun 2010 06:42:23 +0000 (06:42 +0000)]
2010-06-17 Rob Buis <rwlbuis@gmail.com>
Reviewed by Dave Hyatt.
CSS3 "Property is declared twice in rule" test fails
https://bugs.webkit.org/show_bug.cgi?id=36282
Filter out duplicate properties in style declaration.
Test: fast/css/duplicate-property-in-rule.html
* css/CSSMutableStyleDeclaration.cpp: Filter out duplicate properties
(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Discard negative padding values
* css/CSSStyleSelector.cpp: Remove negative padding check
(WebCore::CSSStyleSelector::applyProperty):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61383
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 18 Jun 2010 06:11:23 +0000 (06:11 +0000)]
2010-06-17 MORITA Hajime <morrita@google.com>
Unreviewed. Fixed a path of meter-element.html on Skipped list.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61382
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Fri, 18 Jun 2010 06:05:50 +0000 (06:05 +0000)]
Adding a test case to change-version.html + minor clean-ups.
https://bugs.webkit.org/show_bug.cgi?id=40604
Reviewed by Adam Barth.
* storage/change-version.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61381
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 18 Jun 2010 06:00:42 +0000 (06:00 +0000)]
2010-06-17 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
* platform/chromium/test_expectations.txt:
Update <meter> tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61380
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 18 Jun 2010 05:57:39 +0000 (05:57 +0000)]
2010-06-17 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Implement additional DOM attribute reflection for bindings
https://bugs.webkit.org/show_bug.cgi?id=39936
- Added support for [Reflect] for long, unsigned long, and boolean
attributes.
- Fixed code that set attributes like this: <video controls="controls">
to instead set them like this: <video controls>.
- Added lots more uses of [Reflect].
- Removed now-unneeded [ConvertFromString].
- Made [Reflect] imply [ConvertNullToNullString] so we can get rid
of most uses of the latter.
- Made [Reflect] automatically lowercase the name of the reflected
content attribute to minimize the need to specify a custom content
attribute name.
One thing this patch does *not* do is remove the unneeded functions
in the various DOM classes that are no longer used by the bindings.
We should do that in a followup.
* bindings/scripts/CodeGenerator.pm: Added new functions so code
can be shared across bindings, GetterExpressionPrefix and
SetterExpressionPrefix. We can do a lot more refactoring like
this in the future.
* bindings/scripts/CodeGeneratorCPP.pm: Removed unneeded
ConvertFromString handling, changed to use the new
GetterExpressionPrefix and SetterExpressionPrefix functions
to better handle reflected DOM attributes.
* bindings/scripts/CodeGeneratorGObject.pm: Removed unneeded
ConvertFromString handling, changed to use the new
GetterExpressionPrefix and SetterExpressionPrefix functions
to better handle reflected DOM attributes. Fixed a few things
in the output so the .cpp file will have more WebKit style.
The .h file should be GTK style, but the .cpp file can be the
standard WebKit style eventually.
* bindings/scripts/CodeGeneratorJS.pm: Changed to use the new
GetterExpressionPrefix and SetterExpressionPrefix functions
and removed a now-unneeded IsSVGAnimatedType special case since
the new functions take care of it. Made reflected attributes
automatically convert null to the null string without a
separate ConvertNullToNullString attribute.
* bindings/scripts/CodeGeneratorObjC.pm: Changed to use the new
GetterExpressionPrefix and SetterExpressionPrefix functions
and removed a now-unneeded IsSVGAnimatedType special case since
the new functions take care of it. Redid the special cases for
ownerDocument and for operator to fit better with the new code
paths. Removed unneeded ConvertFromString handling.
* bindings/scripts/CodeGeneratorV8.pm: Changed to use the new
GetterExpressionPrefix and SetterExpressionPrefix functions
and removed a now-unneeded IsSVGAnimatedType special case since
the new functions take care of it. Made reflected attributes
automatically convert null to the null string without a
separate ConvertNullToNullString attribute.
* bindings/scripts/test/TestObj.idl: Added some test cases for
content attribute reflection and for exceptions in string-typed
attributes.
* bindings/scripts/test/CPP/WebKitDOMTestObj.cpp: Updated.
* bindings/scripts/test/CPP/WebKitDOMTestObj.h: Ditto.
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
* bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
* bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
* bindings/scripts/test/JS/JSTestObj.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
* bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
* dom/Element.cpp:
(WebCore::Element::getIntegralAttribute): Added.
(WebCore::Element::setIntegralAttribute): Added.
(WebCore::Element::getUnsignedIntegralAttribute): Added.
(WebCore::Element::setUnsignedIntegralAttribute): Added.
* dom/Element.h: Added new attribute get/set functions for bindings.
* html/HTMLAnchorElement.idl:
* html/HTMLAppletElement.idl:
* html/HTMLAreaElement.idl:
* html/HTMLBRElement.idl:
* html/HTMLBaseElement.idl:
* html/HTMLBaseFontElement.idl:
* html/HTMLBlockquoteElement.idl:
* html/HTMLBodyElement.idl:
* html/HTMLButtonElement.idl:
* html/HTMLDListElement.idl:
* html/HTMLDirectoryElement.idl:
* html/HTMLDivElement.idl:
* html/HTMLElement.idl:
* html/HTMLEmbedElement.idl:
* html/HTMLFontElement.idl:
* html/HTMLFormElement.idl:
* html/HTMLFrameElement.idl:
* html/HTMLFrameSetElement.idl:
* html/HTMLHRElement.idl:
* html/HTMLHeadElement.idl:
* html/HTMLHeadingElement.idl:
* html/HTMLHtmlElement.idl:
* html/HTMLIFrameElement.idl:
* html/HTMLImageElement.idl:
* html/HTMLInputElement.idl:
* html/HTMLIsIndexElement.idl:
* html/HTMLLIElement.idl:
* html/HTMLLabelElement.idl:
* html/HTMLLegendElement.idl:
* html/HTMLLinkElement.idl:
* html/HTMLMapElement.idl:
* html/HTMLMediaElement.idl:
* html/HTMLMenuElement.idl:
* html/HTMLMetaElement.idl:
* html/HTMLModElement.idl:
* html/HTMLOListElement.idl:
* html/HTMLObjectElement.idl:
* html/HTMLOptGroupElement.idl:
* html/HTMLOptionElement.idl:
* html/HTMLParagraphElement.idl:
* html/HTMLParamElement.idl:
* html/HTMLPreElement.idl:
* html/HTMLQuoteElement.idl:
* html/HTMLScriptElement.idl:
* html/HTMLStyleElement.idl:
* html/HTMLTableCaptionElement.idl:
* html/HTMLTableCellElement.idl:
* html/HTMLTableColElement.idl:
* html/HTMLTableElement.idl:
* html/HTMLTableRowElement.idl:
* html/HTMLTableSectionElement.idl:
* html/HTMLTextAreaElement.idl:
* html/HTMLUListElement.idl:
* html/HTMLVideoElement.idl:
* svg/SVGElement.idl:
Added more uses of [Reflect]. Got rid of uses of [ConvertNullToNullString] that
are now unneeded since [Reflect] now implies that. Changed formatting to be
simpler and consistent without all the lining up and multiple lines.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61379
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 18 Jun 2010 05:48:31 +0000 (05:48 +0000)]
2010-06-17 MORITA Hajime <morrita@google.com>
Unreviewed. Disabled meter-element.html temporally.
We need to rebaseline it.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61378
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 18 Jun 2010 05:35:39 +0000 (05:35 +0000)]
2010-06-17 MORITA Hajime <morrita@google.com>
Unreviewd, fixed a build break.
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61377
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 18 Jun 2010 05:13:19 +0000 (05:13 +0000)]
2010-06-15 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
<meter> should allow styling for each gauge-level and component
https://bugs.webkit.org/show_bug.cgi?id=40280
- Updated expectations because both rendering result, render tree structure,
html.css was changed.
* fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html: Added.
* fast/dom/HTMLMeterElement/meter-styles.html: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
* platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.checksum:
* platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.png:
* platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt:
* platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
* platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
* platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
* platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
* platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
* platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
* platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
* platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
* platform/win/Skipped:
2010-06-16 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
<meter> should allow styling for each gauge-level and component
https://bugs.webkit.org/show_bug.cgi?id=40280
- Introduced following new pseudo classes for <meter> element.
- -webkit-meter-horizontal-bar
- -webkit-meter-vertical-bar
- -webkit-meter-horizontal-optimum-value
- -webkit-meter-vertical-optimum-value
- -webkit-meter-horizontal-suboptimal-value
- -webkit-meter-vertical-suboptimal-value
- -webkit-meter-horizontal-even-less-good-value
- -webkit-meter-vertical-even-less-good-value
- Introduced 2 shadow nodes for RenderMeter to handle CSS styling.
one for bar part and another for value part.
- Removed RenderTheme::paintMeter() implementation because it can be
handled by styled painting without RenderTheme.
- Pulled RenderIndicator up to super class from RenderProgress,
then make RenderMeter a subclass of it.
- Moved shadow related methods from RenderProgress to ShadowBlockElement
to share it with RenderMeter.
- Added rules for html.css for new pseudo classes.
Tests: fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html
fast/dom/HTMLMeterElement/meter-styles.html
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
(WebCore::CSSSelector::):
* css/html.css:
(meter::-webkit-meter-horizontal-bar):
(meter::-webkit-meter-vertical-bar):
(meter::-webkit-meter-horizontal-optimum-value):
(meter::-webkit-meter-horizontal-suboptimal-value):
(meter::-webkit-meter-horizontal-even-less-good-value):
(meter::-webkit-meter-vertical-optimum-value):
(meter::-webkit-meter-vertical-suboptimal-value):
(meter::-webkit-meter-vertical-even-less-good-value):
* rendering/RenderIndicator.cpp: Added.
(WebCore::RenderIndicator::RenderIndicator):
(WebCore::RenderIndicator::~RenderIndicator):
(WebCore::RenderIndicator::layout):
(WebCore::RenderIndicator::styleDidChange):
(WebCore::RenderIndicator::updateFromElement):
(WebCore::RenderIndicator::hasParts):
(WebCore::RenderIndicator::requestLayoutForParts):
* rendering/RenderIndicator.h: Added.
(WebCore::RenderIndicator::requiresForcedStyleRecalcPropagation):
* rendering/RenderMeter.cpp:
(WebCore::RenderMeter::RenderMeter):
(WebCore::RenderMeter::~RenderMeter):
(WebCore::RenderMeter::layoutParts): Added.
(WebCore::RenderMeter::shouldHaveParts): Added.
(WebCore::RenderMeter::valueRatio): Added.
(WebCore::RenderMeter::barPartRect): Added.
(WebCore::RenderMeter::valuePartRect): Added.
(WebCore::RenderMeter::isHorizontal): Added.
(WebCore::RenderMeter::valuePseudoId): Added.
(WebCore::RenderMeter::barPseudoId): Added.
(WebCore::RenderMeter::updatePartsState): Added.
* rendering/RenderMeter.h:
* rendering/RenderProgress.cpp:
(WebCore::RenderProgress::RenderProgress):
(WebCore::RenderProgress::updateFromElement):
(WebCore::RenderProgress::paint):
(WebCore::RenderProgress::layoutParts): Added.
(WebCore::RenderProgress::shouldHaveParts): Added.
(WebCore::RenderProgress::updatePartsState):
(WebCore::RenderProgress::valuePartRect):
* rendering/RenderProgress.h:
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isControlStyled):
(WebCore::RenderTheme::paintMeter):
* rendering/RenderTheme.h:
(WebCore::RenderTheme::supportsMeter): Added.
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::supportsMeter): Added.
* rendering/ShadowElement.cpp:
(WebCore::ShadowBlockElement::layoutAsPart): Added.
(WebCore::ShadowBlockElement::updateStyleForPart): Added.
(WebCore::ShadowBlockElement::createForPart): Added.
(WebCore::ShadowBlockElement::createStyleForPart): Added.
(WebCore::ShadowBlockElement::partShouldHaveStyle): Added.
* rendering/ShadowElement.h:
* rendering/style/RenderStyleConstants.h:
(WebCore::):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61376
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ukai@chromium.org [Fri, 18 Jun 2010 04:30:17 +0000 (04:30 +0000)]
2010-06-17 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket: resume should not process buffer if already processing.
https://bugs.webkit.org/show_bug.cgi?id=39340
Reviewed by Alexey Proskuryakov.
* websocket/tests/alert-in-event-handler-expected.txt: Added.
* websocket/tests/alert-in-event-handler.html: Added.
* websocket/tests/script-tests/alert-in-event-handler.js: Added.
* websocket/tests/send2_wsh.py: Added.
2010-06-17 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket: resume should not process buffer if already processing.
https://bugs.webkit.org/show_bug.cgi?id=39340
Test: websocket/tests/alert-in-event-handler.html
While running an event handler of WebSocket object, it may be suspended
and resumed in various reason. e.g. alert() will suspend/resume
ActiveDOM objects. In chromium, sending IPC message would also
suspend/resume ActiveDOM objects.
If resume process pending buffer in this case, another event might
be fired while running the initial event handler.
Thus, resume should not process pending buffer immediately.
Pending buffer would be processed after the current task has been
finished.
* websockets/ThreadableWebSocketChannelClientWrapper.h:
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::resume):
Just set one shot timer for resumeTimerFired() if not yet set.
(WebCore::WebSocketChannel::resumeTimerFired):
Process pending event after resume was called.
* websockets/WebSocketChannel.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61375
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 18 Jun 2010 04:14:08 +0000 (04:14 +0000)]
2010-06-17 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
REGRESSION(HTML5 parser): editing/selection/leave-requested-block.html can fail or crash
https://bugs.webkit.org/show_bug.cgi?id=40764
HTML5ScriptRunner was careful to only call CachedResource::addClient
for cases where the resource was not already loaded. This was to
avoid getting synchronous notifyFinished callbacks from inside
addClient. (The old HTMLDocumentParser also has hacks to work around
addClient's synchronous notifyFinished behavior for already-loaded
resources as well.)
It turns out that CachedResource will mark itself as purgeable if it
has no clients, thus it could have its data cleared (but itself not
deleted) in the case where we yield back to the runloop to wait for
CSS to load before executing the loaded script.
The fix is to act more like the old parser and always call addClient
on every CachedScript we load. But unlike the old parser, we're
careful not to re-enter from addClient -> notifyFinished
using guards in HTML5DocumentParser::watchForLoad.
I do not know how to make a CachedResource purge itself
from a LayoutTest, so this is not currently testable.
If anyone knows how I'm happy to make a test.
* html/HTML5DocumentParser.cpp:
(WebCore::HTML5DocumentParser::watchForLoad):
- It is now expected to call watchForLoad with a loaded script.
(WebCore::HTML5DocumentParser::notifyFinished):
- Now that watchForLoad is called with loaded scripts, notifyFinished
may be be called from addClient, thus we may be in the middle of
script execution when it's called. It's OK. We pass the call
along to HTML5ScriptRunner::executeScriptsWaitingForLoad
and it knows how to ignore the call in that case.
* html/HTML5DocumentParser.h:
- Document these member variables more.
* html/HTML5ScriptRunner.cpp:
(WebCore::HTML5ScriptRunner::~HTML5ScriptRunner):
(WebCore::HTML5ScriptRunner::executePendingScript):
(WebCore::HTML5ScriptRunner::hasScriptsWaitingForLoad):
(WebCore::HTML5ScriptRunner::watchForLoad):
- Set the pending script to RegisteringForWatch state before
watching and WatchingForLoad after.
(WebCore::HTML5ScriptRunner::stopWatchingForLoad):
- Set the pending script to NotWatchingForLoad.
(WebCore::HTML5ScriptRunner::executeScriptsWaitingForLoad):
- Assert that callers checked hasScriptsWaitingForLoad()
(WebCore::HTML5ScriptRunner::requestScript):
* html/HTML5ScriptRunner.h:
(WebCore::HTML5ScriptRunner::PendingScript::):
(WebCore::HTML5ScriptRunner::PendingScript::PendingScript):
(WebCore::HTML5ScriptRunner::PendingScript::watchingForLoad):
* html/HTML5ScriptRunnerHost.h:
- Document the new expectations of watchForLoad
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61374
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 18 Jun 2010 04:02:54 +0000 (04:02 +0000)]
2010-06-17 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
* platform/chromium/test_expectations.txt:
Some tests in fast/repaint/ work fine on Mac.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61373
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 18 Jun 2010 03:40:42 +0000 (03:40 +0000)]
2010-06-17 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Eric Seidel.
Prevent HTML5PreloadScanner from loading resources in <noscript> tags.
https://bugs.webkit.org/show_bug.cgi?id=40779
No new tests. Will create a layout test in a subsequent patch.
* html/HTML5PreloadScanner.cpp:
(WebCore::HTML5PreloadScanner::processToken):
* html/HTML5TreeBuilder.cpp:
(WebCore::HTML5TreeBuilder::adjustedLexerState):
(WebCore::HTML5TreeBuilder::passTokenToLegacyParser):
(WebCore::HTML5TreeBuilder::isScriptingFlagEnabled):
* html/HTML5TreeBuilder.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61372
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 18 Jun 2010 02:53:32 +0000 (02:53 +0000)]
2010-06-17 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r61368.
http://trac.webkit.org/changeset/61368
https://bugs.webkit.org/show_bug.cgi?id=40806
Well, actually, it still fails :( (Requested by abarth on
#webkit).
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61371
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 18 Jun 2010 02:48:27 +0000 (02:48 +0000)]
2010-06-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTML5PreloadScanner parses <script> in DataState
https://bugs.webkit.org/show_bug.cgi?id=40804
The ScriptDataState is handled separately from the rest of the lexer
state changes because it's more complicted in the tree builder. The
easiest thing is to just handle it separately in the preloader too.
* html/HTML5PreloadScanner.cpp:
(WebCore::HTML5PreloadScanner::processToken):
2010-06-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTML5PreloadScanner parses <script> in DataState
https://bugs.webkit.org/show_bug.cgi?id=40804
Remove the aforementioned hack that was working around this bug. As a
nice side effect, we get test coverage for this bug. :)
* fast/preloader/image.html:
* fast/preloader/link.html:
* fast/preloader/script.html:
* fast/preloader/style.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61370
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 18 Jun 2010 02:39:55 +0000 (02:39 +0000)]
Unreviewed, test expectation fix.
* platform/chromium/test_expectations.txt: fast/preloader/*.html
fail because of no dumpResourceResponseMIMETypes(),
stripNullFromTextNodes.html have not failed recently.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61369
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 18 Jun 2010 02:31:18 +0000 (02:31 +0000)]
2010-06-17 Adam Barth <abarth@webkit.org>
Unreviewed.
I bet this test passes now. :)
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61368
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 18 Jun 2010 02:21:25 +0000 (02:21 +0000)]
2010-06-17 Adam Barth <abarth@webkit.org>
Unreviewed.
Skip fast/preloader tests on GTK and Qt because they don't implement
dumpResourceResponseMIMETypes.
* platform/gtk/Skipped:
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61367
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 18 Jun 2010 02:01:00 +0000 (02:01 +0000)]
2010-06-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add CSS scanning to HTML5PreloadScanner
https://bugs.webkit.org/show_bug.cgi?id=40802
This patch just cribs the CSS preload scanning algorithm from the old
preload scanner. We also invented a way of testing the preload
scanner.
Tests: fast/preloader/image.html
fast/preloader/link.html
fast/preloader/script.html
fast/preloader/style.html
* Android.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/CSSPreloadScanner.cpp: Added.
(WebCore::isWhitespace):
(WebCore::CSSPreloadScanner::CSSPreloadScanner):
(WebCore::CSSPreloadScanner::reset):
(WebCore::CSSPreloadScanner::scan):
(WebCore::CSSPreloadScanner::tokenize):
(WebCore::CSSPreloadScanner::emitRule):
* html/CSSPreloadScanner.h: Added.
(WebCore::CSSPreloadScanner::):
* html/HTML5PreloadScanner.cpp:
(WebCore::HTML5PreloadScanner::HTML5PreloadScanner):
(WebCore::HTML5PreloadScanner::processToken):
(WebCore::HTML5PreloadScanner::scanningBody):
* html/HTML5PreloadScanner.h:
2010-06-17 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add CSS scanning to HTML5PreloadScanner
https://bugs.webkit.org/show_bug.cgi?id=40802
Add a testing framework for the preload scanner. These test cover
basic preloader behavior. They have a small hack to work around a bug
in the preload scanner discovered while writing the tests. I'll fix
the bug and remove the hack in a followup patch.
* fast/preloader/image-expected.txt: Added.
* fast/preloader/image.html: Added.
* fast/preloader/link-expected.txt: Added.
* fast/preloader/link.html: Added.
* fast/preloader/resources/image1.png: Added.
* fast/preloader/resources/link1.css: Added.
* fast/preloader/resources/script1.js: Added.
* fast/preloader/resources/style1.css: Added.
* fast/preloader/script-expected.txt: Added.
* fast/preloader/script.html: Added.
* fast/preloader/style-expected.txt: Added.
* fast/preloader/style.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61366
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 18 Jun 2010 01:24:21 +0000 (01:24 +0000)]
2010-06-17 Abhishek Arya <inferno@chromium.org>
Reviewed by David Kilzer.
(Landed by Dirk Pranke).
Check for a null frame before setting drag selection.
https://bugs.webkit.org/show_bug.cgi?id=38893
Same Layout test as https://bugs.webkit.org/show_bug.cgi?id=37168.
Test: editing/pasteboard/drag-drop-iframe-refresh-crash.html
Note that you need to run the test manually 20-30 times for the crash
to reproduce.
* editing/SelectionController.cpp:
(WebCore::SelectionController::setSelection):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61365
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 18 Jun 2010 00:53:16 +0000 (00:53 +0000)]
2010-06-17 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Get rid of the the unused imageSize of ImageDecoderQt::internalHandleCurrentImage()
https://bugs.webkit.org/show_bug.cgi?id=40620
Remove an unused variable.
* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::internalHandleCurrentImage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61364
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 18 Jun 2010 00:39:39 +0000 (00:39 +0000)]
2010-06-17 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] cleanup redundant DEPS value and remove buildbot cleanup code
https://bugs.webkit.org/show_bug.cgi?id=40615
* DEPS: tools/data_pack was listed twice for linux (harmless, but unnecessary)
2010-06-17 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] cleanup redundant DEPS value and remove buildbot cleanup code
https://bugs.webkit.org/show_bug.cgi?id=40615
* Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61363
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 18 Jun 2010 00:29:19 +0000 (00:29 +0000)]
Fix a race condition during startup where we would never send the InitializeConnection message to the server.
Reviewed by Sam Weinig.
* Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::open):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61362
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 18 Jun 2010 00:24:06 +0000 (00:24 +0000)]
2010-06-17 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Darin Fisher.
[Chromium API] Implement WebSandboxSupport on OS X and add stubs to allow
OOP loading of fonts.
https://bugs.webkit.org/show_bug.cgi?id=40544
* platform/chromium/ChromiumBridge.h: Add prototype for loadFont()
2010-06-17 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Darin Fisher.
[Chromium API] Implement WebSandboxSupport on OS X and add stubs to allow
OOP loading of fonts.
https://bugs.webkit.org/show_bug.cgi?id=40544
* WebKit.gyp: Add mac WebSandboxSupport.h
* public/mac/WebSandboxSupport.h: Added.
* src/ChromiumBridge.cpp:
(WebCore::ChromiumBridge::loadFont):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61361
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 18 Jun 2010 00:00:57 +0000 (00:00 +0000)]
2010-06-17 Nicolas Weber <thakis@chromium.org>
Reviewed by Eric Seidel.
Fix various warnings that are reported when building with clang
https://bugs.webkit.org/show_bug.cgi?id=40503
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::labelElementContainer):
* accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::parentTable):
* bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo):
* bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
(WebCore::):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::):
* bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
(WebCore::):
* css/CSSStyleSheet.h:
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::getNamedElements):
* inspector/InspectorValues.cpp:
(WebCore::InspectorObject::getObject):
(WebCore::InspectorObject::getArray):
* page/animation/AnimationBase.h:
* platform/graphics/BitmapImage.h:
(WTF::):
* platform/graphics/mac/FontPlatformData.h:
* rendering/RenderBlock.h:
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::ellipsisBox):
* storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::storageArea):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61360
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 17 Jun 2010 23:39:23 +0000 (23:39 +0000)]
2010-06-17 Kwang Yul Seo <skyul@company100.net>
Reviewed by Pavel Feldman.
Add ENABLE(INSPECTOR) guard for m_sessionSettings
https://bugs.webkit.org/show_bug.cgi?id=40611
Build fix.
* inspector/InspectorController.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61359
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Thu, 17 Jun 2010 23:28:41 +0000 (23:28 +0000)]
WebKit2:
Rolling out http://trac.webkit.org/changeset/61297 due to build errors.
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: Removed.
* WebProcess/InjectedBundle/API/c/WKBundlePage.h: Removed.
* WebProcess/InjectedBundle/InjectedBundlePageClient.cpp: Removed.
* WebProcess/InjectedBundle/InjectedBundlePageClient.h: Removed.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/WebPage.h:
* mac/WebKit2.exp:
* win/WebKit2.vcproj:
WebKitTools:
Rolling out http://trac.webkit.org/changeset/61297 due to build errors.
* MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
* MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c.
* MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61358
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 17 Jun 2010 23:25:48 +0000 (23:25 +0000)]
2010-06-17 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add FIXME to explain HTMLDocumentParser's forceSynchronous bool
https://bugs.webkit.org/show_bug.cgi?id=40609
No functional change, just adding comment.
* dom/Document.cpp:
(WebCore::Document::write):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61357
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 17 Jun 2010 23:25:08 +0000 (23:25 +0000)]
2010-06-17 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, Chromium expectations update.
* platform/chromium-mac/fast/js/missing-title-end-tag-js-expected.checksum: Added.
* platform/chromium-mac/fast/js/missing-title-end-tag-js-expected.png: Added.
* platform/chromium-win-xp/fast/text/atsui-spacing-features-expected.checksum: Changed
* platform/chromium-win-xp/fast/text/atsui-spacing-features-expected.png: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61356
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Thu, 17 Jun 2010 23:04:33 +0000 (23:04 +0000)]
2010-06-17 Stephen White <senorblanco@chromium.org>
Unreviewed; expectations fix.
This updates the pixel test baselines after r61341, and removes them
from test_expectations.
* platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
* platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.png:
* platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
* platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
* platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
* platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
* platform/chromium-linux/fast/backgrounds/size/backgroundSize11-expected.checksum: Added.
* platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.checksum:
* platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.png:
* platform/chromium-linux/fast/backgrounds/size/backgroundSize16-expected.checksum:
* platform/chromium-linux/fast/backgrounds/size/backgroundSize16-expected.png:
* platform/chromium-linux/fast/backgrounds/size/backgroundSize19-expected.checksum: Added.
* platform/chromium-linux/fast/backgrounds/size/backgroundSize22-expected.checksum: Added.
* platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum: Removed.
* platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
* platform/chromium-linux/fast/css/value-list-out-of-bounds-crash-expected.checksum:
* platform/chromium-linux/fast/css/value-list-out-of-bounds-crash-expected.png: Removed.
* platform/chromium-linux/fast/events/pointer-events-2-expected.checksum:
* platform/chromium-linux/fast/events/pointer-events-2-expected.png:
* platform/chromium-linux/fast/forms/input-type-change-expected.checksum:
* platform/chromium-linux/fast/forms/input-type-change-expected.png:
* platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.checksum:
* platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
* platform/chromium-linux/fast/replaced/image-sizing-expected.checksum:
* platform/chromium-linux/fast/replaced/image-sizing-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/bugs/bug101674-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug101674-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug11026-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug11026-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug14929-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug14929-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/bugs/bug2981-2-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug2981-2-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug4093-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug4093-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug4284-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug4284-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/bugs/bug625-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.checksum:
* platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.png:
* platform/chromium-linux/tables/mozilla/core/bloomberg-expected.checksum:
* platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
* platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
* platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/core/misc-expected.checksum:
* platform/chromium-linux/tables/mozilla/core/misc-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.checksum:
* platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/other/cell_widths-expected.checksum:
* platform/chromium-linux/tables/mozilla/other/cell_widths-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/97619-expected.checksum:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/97619-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Removed.
* platform/chromium-mac/fast/backgrounds/size/backgroundSize16-expected.checksum: Removed.
* platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
* platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.png:
* platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
* platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
* platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
* platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize01-expected.checksum:
* platform/chromium-win/fast/backgrounds/size/backgroundSize01-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.checksum:
* platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.checksum:
* platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize05-expected.checksum:
* platform/chromium-win/fast/backgrounds/size/backgroundSize05-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.checksum:
* platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize07-expected.checksum:
* platform/chromium-win/fast/backgrounds/size/backgroundSize07-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize08-expected.checksum:
* platform/chromium-win/fast/backgrounds/size/backgroundSize08-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize09-expected.checksum:
* platform/chromium-win/fast/backgrounds/size/backgroundSize09-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize10-expected.checksum:
* platform/chromium-win/fast/backgrounds/size/backgroundSize10-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize11-expected.checksum:
* platform/chromium-win/fast/backgrounds/size/backgroundSize11-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize12-expected.checksum:
* platform/chromium-win/fast/backgrounds/size/backgroundSize12-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.checksum:
* platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.checksum:
* platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.checksum:
* platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize16-expected.checksum:
* platform/chromium-win/fast/backgrounds/size/backgroundSize16-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.checksum:
* platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.checksum:
* platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.checksum:
* platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize20-expected.checksum:
* platform/chromium-win/fast/backgrounds/size/backgroundSize20-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize21-expected.checksum:
* platform/chromium-win/fast/backgrounds/size/backgroundSize21-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.checksum:
* platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.png:
* platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum:
* platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
* platform/chromium-win/fast/css/value-list-out-of-bounds-crash-expected.checksum:
* platform/chromium-win/fast/css/value-list-out-of-bounds-crash-expected.png:
* platform/chromium-win/fast/events/pointer-events-2-expected.checksum:
* platform/chromium-win/fast/events/pointer-events-2-expected.png:
* platform/chromium-win/fast/forms/input-type-change-expected.checksum:
* platform/chromium-win/fast/forms/input-type-change-expected.png:
* platform/chromium-win/fast/replaced/absolute-image-sizing-expected.checksum:
* platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
* platform/chromium-win/fast/replaced/image-sizing-expected.checksum:
* platform/chromium-win/fast/replaced/image-sizing-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug101674-expected.checksum:
* platform/chromium-win/tables/mozilla/bugs/bug101674-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug11026-expected.checksum:
* platform/chromium-win/tables/mozilla/bugs/bug11026-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug1188-expected.checksum:
* platform/chromium-win/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug1296-expected.checksum:
* platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug1430-expected.checksum:
* platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug14929-expected.checksum:
* platform/chromium-win/tables/mozilla/bugs/bug14929-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug15544-expected.checksum:
* platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug2981-2-expected.checksum:
* platform/chromium-win/tables/mozilla/bugs/bug2981-2-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug4093-expected.checksum:
* platform/chromium-win/tables/mozilla/bugs/bug4093-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug4284-expected.checksum:
* platform/chromium-win/tables/mozilla/bugs/bug4284-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug4427-expected.checksum:
* platform/chromium-win/tables/mozilla/bugs/bug4427-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug56563-expected.checksum:
* platform/chromium-win/tables/mozilla/bugs/bug56563-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug625-expected.checksum:
* platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug6404-expected.checksum:
* platform/chromium-win/tables/mozilla/bugs/bug6404-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug97383-expected.checksum:
* platform/chromium-win/tables/mozilla/bugs/bug97383-expected.png:
* platform/chromium-win/tables/mozilla/core/bloomberg-expected.checksum:
* platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
* platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
* platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
* platform/chromium-win/tables/mozilla/core/misc-expected.checksum:
* platform/chromium-win/tables/mozilla/core/misc-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
* platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
* platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
* platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
* platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
* platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
* platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
* platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.checksum:
* platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
* platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.checksum:
* platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
* platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.checksum:
* platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
* platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
* platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
* platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
* platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
* platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
* platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
* platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
* platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
* platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.checksum:
* platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
* platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.checksum:
* platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
* platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
* platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
* platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
* platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
* platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
* platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
* platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.checksum:
* platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
* platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
* platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.checksum:
* platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
* platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.checksum:
* platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
* platform/chromium-win/tables/mozilla/other/cell_widths-expected.checksum:
* platform/chromium-win/tables/mozilla/other/cell_widths-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/97619-expected.checksum:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/97619-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
* platform/chromium/test_expectations.txt:
* platform/mac-leopard/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum:
* platform/mac-leopard/css2.1/t0804-c5510-padn-00-b-ag-expected.png:
* platform/mac-leopard/tables/mozilla/bugs/bug1430-expected.checksum:
* platform/mac-leopard/tables/mozilla/bugs/bug1430-expected.png:
* platform/mac-leopard/tables/mozilla/bugs/bug14929-expected.checksum:
* platform/mac-leopard/tables/mozilla/bugs/bug14929-expected.png:
* platform/mac-leopard/tables/mozilla/bugs/bug23235-expected.checksum:
* platform/mac-leopard/tables/mozilla/bugs/bug23235-expected.png:
* platform/mac-leopard/tables/mozilla/bugs/bug2981-2-expected.checksum:
* platform/mac-leopard/tables/mozilla/bugs/bug2981-2-expected.png:
* platform/mac-leopard/tables/mozilla/bugs/bug4427-expected.checksum:
* platform/mac-leopard/tables/mozilla/bugs/bug4427-expected.png:
* platform/mac-leopard/tables/mozilla/bugs/bug6404-expected.checksum:
* platform/mac-leopard/tables/mozilla/bugs/bug6404-expected.png:
* platform/mac-leopard/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
* platform/mac-leopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
* platform/mac-leopard/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
* platform/mac-leopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
* platform/mac-leopard/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
* platform/mac-leopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
* platform/mac-leopard/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
* platform/mac-leopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
* platform/mac-leopard/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
* platform/mac-leopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
* platform/mac-leopard/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
* platform/mac-leopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
* platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
* platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
* platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
* platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
* platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
* platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
* platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
* platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
* platform/mac-leopard/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
* platform/mac-leopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
* platform/mac-leopard/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
* platform/mac-leopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
* platform/mac-leopard/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
* platform/mac-leopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
* platform/mac-leopard/tables/mozilla/marvin/thead_valign_top-expected.checksum:
* platform/mac-leopard/tables/mozilla/marvin/thead_valign_top-expected.png:
* platform/mac-leopard/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
* platform/mac-leopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
* platform/mac-leopard/tables/mozilla_expected_failures/bugs/97619-expected.checksum:
* platform/mac-leopard/tables/mozilla_expected_failures/bugs/97619-expected.png:
* platform/mac/css2.1/t0905-c414-flt-01-d-g-expected.checksum:
* platform/mac/css2.1/t0905-c414-flt-01-d-g-expected.png:
* platform/mac/css2.1/t090501-c414-flt-02-d-g-expected.checksum:
* platform/mac/css2.1/t090501-c414-flt-02-d-g-expected.png:
* platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
* platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.png:
* platform/mac/css2.1/t090501-c414-flt-ln-01-d-g-expected.checksum:
* platform/mac/css2.1/t090501-c414-flt-ln-01-d-g-expected.png:
* platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
* platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
* platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
* platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
* platform/mac/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.checksum:
* platform/mac/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.png:
* platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum:
* platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png:
* platform/mac/css2.1/t1004-c5524-width-00-b-g-expected.checksum:
* platform/mac/css2.1/t1004-c5524-width-00-b-g-expected.png:
* platform/mac/css2.1/t100801-c544-valgn-02-d-agi-expected.checksum:
* platform/mac/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
* platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
* platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
* platform/mac/css2.1/t100801-c544-valgn-04-d-agi-expected.checksum:
* platform/mac/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
* platform/mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.checksum:
* platform/mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize01-expected.checksum:
* platform/mac/fast/backgrounds/size/backgroundSize01-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize05-expected.checksum:
* platform/mac/fast/backgrounds/size/backgroundSize05-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize06-expected.checksum:
* platform/mac/fast/backgrounds/size/backgroundSize06-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize07-expected.checksum:
* platform/mac/fast/backgrounds/size/backgroundSize07-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize08-expected.checksum:
* platform/mac/fast/backgrounds/size/backgroundSize08-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize09-expected.checksum:
* platform/mac/fast/backgrounds/size/backgroundSize09-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize10-expected.checksum:
* platform/mac/fast/backgrounds/size/backgroundSize10-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize11-expected.checksum:
* platform/mac/fast/backgrounds/size/backgroundSize11-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize12-expected.checksum:
* platform/mac/fast/backgrounds/size/backgroundSize12-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum:
* platform/mac/fast/backgrounds/size/backgroundSize16-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize17-expected.checksum:
* platform/mac/fast/backgrounds/size/backgroundSize17-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize18-expected.checksum:
* platform/mac/fast/backgrounds/size/backgroundSize18-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize19-expected.checksum:
* platform/mac/fast/backgrounds/size/backgroundSize19-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize20-expected.checksum:
* platform/mac/fast/backgrounds/size/backgroundSize20-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize21-expected.checksum:
* platform/mac/fast/backgrounds/size/backgroundSize21-expected.png:
* platform/mac/fast/backgrounds/size/backgroundSize22-expected.checksum:
* platform/mac/fast/backgrounds/size/backgroundSize22-expected.png:
* platform/mac/fast/backgrounds/size/zero-expected.checksum:
* platform/mac/fast/backgrounds/size/zero-expected.png:
* platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum:
* platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
* platform/mac/fast/canvas/canvas-as-image-expected.checksum:
* platform/mac/fast/canvas/canvas-as-image-expected.png:
* platform/mac/fast/css/value-list-out-of-bounds-crash-expected.checksum:
* platform/mac/fast/css/value-list-out-of-bounds-crash-expected.png:
* platform/mac/fast/forms/input-type-change-expected.checksum:
* platform/mac/fast/forms/input-type-change-expected.png:
* platform/mac/fast/replaced/001-expected.checksum:
* platform/mac/fast/replaced/001-expected.png:
* platform/mac/fast/replaced/002-expected.checksum:
* platform/mac/fast/replaced/002-expected.png:
* platform/mac/fast/replaced/003-expected.checksum:
* platform/mac/fast/replaced/003-expected.png:
* platform/mac/fast/replaced/absolute-image-sizing-expected.checksum:
* platform/mac/fast/replaced/absolute-image-sizing-expected.png:
* platform/mac/fast/replaced/image-sizing-expected.checksum:
* platform/mac/fast/replaced/image-sizing-expected.png:
* platform/mac/tables/mozilla/bugs/bug11026-expected.checksum:
* platform/mac/tables/mozilla/bugs/bug11026-expected.png:
* platform/mac/tables/mozilla/bugs/bug1188-expected.checksum:
* platform/mac/tables/mozilla/bugs/bug1188-expected.png:
* platform/mac/tables/mozilla/bugs/bug1296-expected.checksum:
* platform/mac/tables/mozilla/bugs/bug1296-expected.png:
* platform/mac/tables/mozilla/bugs/bug15544-expected.checksum:
* platform/mac/tables/mozilla/bugs/bug15544-expected.png:
* platform/mac/tables/mozilla/bugs/bug4093-expected.checksum:
* platform/mac/tables/mozilla/bugs/bug4093-expected.png:
* platform/mac/tables/mozilla/bugs/bug4284-expected.checksum:
* platform/mac/tables/mozilla/bugs/bug4284-expected.png:
* platform/mac/tables/mozilla/bugs/bug4523-expected.checksum:
* platform/mac/tables/mozilla/bugs/bug4523-expected.png:
* platform/mac/tables/mozilla/bugs/bug56563-expected.checksum:
* platform/mac/tables/mozilla/bugs/bug56563-expected.png:
* platform/mac/tables/mozilla/bugs/bug86708-expected.checksum:
* platform/mac/tables/mozilla/bugs/bug86708-expected.png:
* platform/mac/tables/mozilla/bugs/bug97383-expected.checksum:
* platform/mac/tables/mozilla/bugs/bug97383-expected.png:
* platform/mac/tables/mozilla/core/misc-expected.checksum:
* platform/mac/tables/mozilla/core/misc-expected.png:
* platform/mac/tables/mozilla/marvin/td_valign_bottom-expected.checksum:
* platform/mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
* platform/mac/tables/mozilla/marvin/td_valign_middle-expected.checksum:
* platform/mac/tables/mozilla/marvin/td_valign_middle-expected.png:
* platform/mac/tables/mozilla/marvin/td_valign_top-expected.checksum:
* platform/mac/tables/mozilla/marvin/td_valign_top-expected.png:
* platform/mac/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
* platform/mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
* platform/mac/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
* platform/mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
* platform/mac/tables/mozilla/marvin/th_valign_middle-expected.checksum:
* platform/mac/tables/mozilla/marvin/th_valign_middle-expected.png:
* platform/mac/tables/mozilla/marvin/th_valign_top-expected.checksum:
* platform/mac/tables/mozilla/marvin/th_valign_top-expected.png:
* platform/mac/tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
* platform/mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
* platform/mac/tables/mozilla/marvin/tr_valign_middle-expected.checksum:
* platform/mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
* platform/mac/tables/mozilla/marvin/tr_valign_top-expected.checksum:
* platform/mac/tables/mozilla/marvin/tr_valign_top-expected.png:
* platform/mac/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
* platform/mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61355
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 17 Jun 2010 22:25:02 +0000 (22:25 +0000)]
2010-06-17 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, expectations update.
Added pixel results for Chromium.
* platform/chromium-win/fast/js/missing-title-end-tag-js-expected.checksum: Added.
* platform/chromium-win/fast/js/missing-title-end-tag-js-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61354
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Thu, 17 Jun 2010 22:19:45 +0000 (22:19 +0000)]
2010-06-13 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
WebCore EventHandler needs to take account of onLoad events fired
before layout() complete
https://bugs.webkit.org/show_bug.cgi?id=40102
WebCore 'cheats' by firing onLoad events before the frame's layout
has been performed. This can result in event listeners performing
operations that depend on the document's final layout, such as
scrolling operations.
When scrolling a frameview in eventhandler ensure the layout is complete.
* platform/qt/Skipped: Unskip editing/input/page-up-down-scrolls.html
2010-06-13 Robert Hogan <robert@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
WebCore EventHandler needs to take account of onLoad events
fired before layout() complete
https://bugs.webkit.org/show_bug.cgi?id=40102
WebCore 'cheats' by firing onLoad events before the frame's layout
has been performed. This can result in event listeners performing
operations that depend on the document's final layout, such as
scrolling operations.
When scrolling a frameview in eventhandler ensure the layout is complete.
* page/EventHandler.cpp:
(WebCore::EventHandler::scrollRecursively):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61353
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Thu, 17 Jun 2010 22:06:01 +0000 (22:06 +0000)]
Add the error codes defined in the async DB spec to SQLError.idl and SQLError.h.
https://bugs.webkit.org/show_bug.cgi?id=40748
Reviewed by Dimitri Glazkov.
WebCore:
Test: storage/sql-error-codes.html
* storage/SQLError.h:
(WebCore::SQLError::):
* storage/SQLError.idl:
* storage/SQLStatement.cpp:
(WebCore::SQLStatement::execute):
(WebCore::SQLStatement::setDatabaseDeletedError):
(WebCore::SQLStatement::setVersionMismatchedError):
(WebCore::SQLStatement::setFailureDueToQuota):
(WebCore::SQLStatement::lastExecutionFailedDueToQuota):
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::deliverTransactionCallback):
(WebCore::SQLTransaction::handleCurrentStatementError):
(WebCore::SQLTransaction::deliverStatementCallback):
(WebCore::SQLTransaction::postflightAndCommit):
LayoutTests:
* platform/chromium/storage/sql-error-codes-expected.txt: Added.
* storage/sql-error-codes-expected.txt: Added.
* storage/sql-error-codes.html: Added.
* storage/sql-error-codes.js: Added.
(finishTest):
(transactionErrorCallback):
(transactionSuccessCallback):
(testTransaction):
(testTransactionThrowsException):
(testTransactionFailureBecauseOfStatementFailure):
(testInvalidStatement):
(testIncorrectNumberOfBindParameters):
(testBindParameterOfWrongType.badString.toString):
(testBindParameterOfWrongType):
(testQuotaExceeded):
(testVersionMismatch.db.transaction):
(testVersionMismatch):
(runTest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61352
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Thu, 17 Jun 2010 21:41:50 +0000 (21:41 +0000)]
2010-06-17 Robert Hogan <robert@webkit.org>
[Qt] Build fix
Unreviewed.
Remove includes in qdeclarativewebview*.* that rely on an installation
of QtWebKit.
* declarative/qdeclarativewebview.cpp:
* declarative/qdeclarativewebview_p.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61351
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 17 Jun 2010 21:32:33 +0000 (21:32 +0000)]
2010-06-17 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, expectations update.
Updating Chromium expectations after http://trac.webkit.org/changeset/61128.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61350
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Thu, 17 Jun 2010 21:15:19 +0000 (21:15 +0000)]
2010-06-17 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Jian Li.
Fix CRLF ending conversion in StringBlobItem.
https://bugs.webkit.org/show_bug.cgi?id=40736
Also: fix referencing uninitialized member bug and slice length bug
in hybrid blob case.
Tests will be added when we add BlobBuilder jsc bindings.
* platform/BlobItem.cpp:
(WebCore::StringBlobItem::convertToCString):
(WebCore::DataRangeBlobItem::DataRangeBlobItem):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61349
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Thu, 17 Jun 2010 20:59:09 +0000 (20:59 +0000)]
2010-06-17 Robert Hogan <robert@webkit.org>
Unreviewed, rolling out r61346.
http://trac.webkit.org/changeset/61346
https://bugs.webkit.org/show_bug.cgi?id=33333
Broke inspector tests on Qt
* platform/qt/Skipped:
2010-06-17 Robert Hogan <robert@webkit.org>
Unreviewed, rolling out r61346.
http://trac.webkit.org/changeset/61346
https://bugs.webkit.org/show_bug.cgi?id=33333
Broke inspector tests on Qt
* Api/qwebpage.cpp:
(QWebPage::javaScriptConsoleMessage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61348
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 17 Jun 2010 20:44:28 +0000 (20:44 +0000)]
2010-06-17 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, expectations update.
Removed obsolete Win XP expectations.
* platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.checksum: Removed.
* platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.png: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61347
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Thu, 17 Jun 2010 20:39:04 +0000 (20:39 +0000)]
2010-06-17 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] pass plugins/open-and-close-window-with-plugin.html on Qt
Capture logDestroy messages from the test plugin. DRT's WebPage
is already destroyed by the time they are emitted.
https://bugs.webkit.org/show_bug.cgi?id=33333
Unskip:
plugins/open-and-close-window-with-plugin.html
plugins/geturlnotify-during-document-teardown.html
* platform/qt/Skipped:
2010-06-17 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] pass plugins/open-and-close-window-with-plugin.html on Qt
Capture logDestroy messages from the test plugin. DRT's WebPage
is already destroyed by the time they are emitted.
https://bugs.webkit.org/show_bug.cgi?id=33333
Unskip:
plugins/open-and-close-window-with-plugin.html
plugins/geturlnotify-during-document-teardown.html
* Api/qwebpage.cpp:
(QWebPage::javaScriptConsoleMessage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61346
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 17 Jun 2010 20:28:01 +0000 (20:28 +0000)]
2010-06-17 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, rolling out r61340.
http://trac.webkit.org/changeset/61340
https://bugs.webkit.org/show_bug.cgi?id=36282
Broke several editing tests.
* fast/css/duplicate-property-in-rule-expected.txt: Removed.
* fast/css/duplicate-property-in-rule.html: Removed.
2010-06-17 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, rolling out r61340.
http://trac.webkit.org/changeset/61340
https://bugs.webkit.org/show_bug.cgi?id=36282
Broke several editing tests.
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61345
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 17 Jun 2010 20:25:45 +0000 (20:25 +0000)]
2010-06-17 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, expectations update.
More clean up from the HTML5 parser spin-up.
* platform/chromium-linux/fast/dom/stripNullFromTextNodes-expected.txt: Removed.
* platform/chromium-mac/css1/box_properties/float_elements_in_series-expected.checksum:
* platform/chromium-mac/css1/box_properties/float_elements_in_series-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61344
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Thu, 17 Jun 2010 20:14:28 +0000 (20:14 +0000)]
Add optional contentType parameter to Blob.slice per latest File API spec.
https://bugs.webkit.org/show_bug.cgi?id=40647
Reviewed by David Levin.
WebCore:
Tested by http/tests/local/resources/send-sliced-dragged-file.html.
* html/Blob.cpp:
(WebCore::Blob::slice):
* html/Blob.h:
* html/Blob.idl:
LayoutTests:
Updated the test for the optional parameter.
* http/tests/local/resources/send-sliced-dragged-file.js:
* http/tests/local/send-sliced-dragged-file-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61343
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jesus@webkit.org [Thu, 17 Jun 2010 20:02:22 +0000 (20:02 +0000)]
Add viewport meta tag support to QtWebKit API layer
[Qt] QtWebKit does not support viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=39902
Patch by Jesus Sanchez-Palencia <jesus@webkit.org>, Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-06-01
Reviewed by Simon Hausmann.
WebCore:
Add windowRect() to page client.
* platform/qt/QWebPageClient.h:
WebKit/qt:
This implements didReceiveViewportArguments in our ChromeClientQt
which is hooked up with QWebPage::viewportChangeRequested().
This signal does not affect the current default behavior.
The documentation of the signal explains how to make use of this new feature.
* Api/qwebframe_p.h:
(QWebFramePrivate::QWebFramePrivate):
Store information about whether the page has been laid out or not.
* Api/qwebpage.cpp:
(QWebPage::viewportChangeRequested):
* Api/qwebpage_p.h:
Added class QtViewportHintsPrivate.
* Api/qwebpage.h:
(QWebPage::setPreferredContentsSize):
Improved documentation and now only layout if the page had already
passed layout phase.
Added class QWebPage::ViewportHints.
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::windowRect):
Modified to work as intended by the DOM, for both QWebView
and QGraphicsWebView.
(WebCore::ChromeClientQt::didReceiveViewportArguments):
Emits the signal QWebPage::viewportChangeRequested.
* WebCoreSupport/ChromeClientQt.h:
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):
Update information about whether the page has been laid out or not.
If the page has been laid out we ignore any further viewport meta data.
* WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQWidget::windowRect):
(WebCore::PageClientQGraphicsWidget::windowRect):
(WebCore::PageClientQGraphicsWidget::graphicsItemVisibleRect):
* WebCoreSupport/PageClientQt.h:
The PageClient is now responsible for providing the right window rect.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61342
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Thu, 17 Jun 2010 19:50:36 +0000 (19:50 +0000)]
2010-06-17 Stephen White <senorblanco@chromium.org>
Reviewed by David Levin.
Fix for slow multiple animated resize issue.
https://bugs.webkit.org/show_bug.cgi?id=38233
The timer-based resize quality approach implemented in
http://trac.webkit.org/changeset/34210 is a good idea, but doesn't
scale to multiple images with animated resizes. This fix unifies all
outstanding resize timers into a single timer, and removes the "use
last quality" check (which doesn't work when images are overlapping).
It also refactors the copy of this code implemented in
RenderBoxModelObject in http://trac.webkit.org/changeset/53949.
This improves Safari performance for the following IE9 platform demos on my C2D MacPro (10.5):
http://ie.microsoft.com/testdrive/Performance/01FlyingImages/Default.html (4->60fps)
http://ie.microsoft.com/testdrive/Performance/10FlickrExplorer/Default.html (3->16fps)
http://ie.microsoft.com/testdrive/Performance/11BrowserFlip/Default.html (9->60fps)
* rendering/RenderBoxModelObject.cpp:
(WebCore::ImageQualityController::ImageQualityController):
Unify all timers into a single timer, rename RenderBoxModelScaleObserver
to ImageQualityController, and remove the resize quality "stickness",
since it doesn't work with multiple outstanding resizes.
(WebCore::ImageQualityController::objectDestroyed):
gImages global is now m_lastPaintTimeMap member.
(WebCore::ImageQualityController::highQualityRepaintTimerFired):
Function made non-static; repaint all pending resizes (not just one).
(WebCore::ImageQualityController::restartTimer):
Added function to restart timer at 1.05x threshold.
(WebCore::imageQualityController):
Static function to return singleton.
(WebCore::ImageQualityController::shouldPaintAtLowQuality):
Use m_lastPaintTimeMap, not gImages global. Implement new timer
algorithm. Remove resize "stickiness".
(WebCore::RenderBoxModelObject::shouldPaintAtLowQuality):
Implement shouldPaintAtLowQuality, which pulls out "this" and passes
the call to the ImageQualityController.
(WebCore::RenderBoxModelObject::~RenderBoxModelObject):
Call ImageQualityController singleton's objectDestroyed() instead of
old static function.
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Modify shouldPaintAtLowQuality() call to match new class name and
function signature.
* rendering/RenderBoxModelObject.h:
Expose shouldPaintAtLowQuality as a member function.
* rendering/RenderImage.cpp:
(WebCore::RenderImage::~RenderImage):
No need to call objectDestroyed() here anymore, since the
RenderBoxModelObject destructor will do this for us.
(WebCore::RenderImage::paintIntoRect):
Rip out RenderImageScaleObserver, and call
RenderBoxModelObject::shouldPaintAtLowQuality() instead.
2010-06-17 Stephen White <senorblanco@chromium.org>
Reviewed by David Levin.
Temporarily modify test_expectations.txt to add tests broken by
https://bugs.webkit.org/show_bug.cgi?id=38233
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61341
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Thu, 17 Jun 2010 19:32:04 +0000 (19:32 +0000)]
2010-06-17 Rob Buis <rwlbuis@gmail.com>
Reviewed by Dave Hyatt.
CSS3 "Property is declared twice in rule" test fails
https://bugs.webkit.org/show_bug.cgi?id=36282
Filter out duplicate properties in style declaration.
Test: fast/css/duplicate-property-in-rule.html
* css/CSSMutableStyleDeclaration.cpp: Filter out duplicate properties
(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Discard negative padding values
* css/CSSStyleSelector.cpp: Remove negative padding check
(WebCore::CSSStyleSelector::applyProperty):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61340
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Thu, 17 Jun 2010 18:14:56 +0000 (18:14 +0000)]
2010-06-17 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Clean up error conditions for Typed Arrays
https://bugs.webkit.org/show_bug.cgi?id=40755
* bindings/js/JSArrayBufferCustom.cpp:
(WebCore::JSArrayBufferConstructor::constructJSArrayBuffer):
- Fixed handling of NaN/+inf/-inf lengths. Throw RangeError for too-large or negative lengths.
* bindings/js/JSArrayBufferViewHelper.h:
(WebCore::constructArrayBufferView):
- Changed all error code paths to throw exceptions. Clarified exception types.
* bindings/js/JSFloat32ArrayCustom.cpp:
(WebCore::JSFloat32ArrayConstructor::constructJSFloat32Array):
- Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
* bindings/js/JSInt16ArrayCustom.cpp:
(WebCore::JSInt16ArrayConstructor::constructJSInt16Array):
- Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
* bindings/js/JSInt32ArrayCustom.cpp:
(WebCore::JSInt32ArrayConstructor::constructJSInt32Array):
- Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
* bindings/js/JSInt8ArrayCustom.cpp:
(WebCore::JSInt8ArrayConstructor::constructJSInt8Array):
- Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
* bindings/js/JSUint16ArrayCustom.cpp:
(WebCore::JSUint16ArrayConstructor::constructJSUint16Array):
- Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
* bindings/js/JSUint32ArrayCustom.cpp:
(WebCore::JSUint32ArrayConstructor::constructJSUint32Array):
- Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
* bindings/js/JSUint8ArrayCustom.cpp:
(WebCore::JSUint8ArrayConstructor::constructJSUint8Array):
- Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
* bindings/v8/custom/V8ArrayBufferCustom.cpp:
(WebCore::V8ArrayBuffer::constructorCallback):
- Fixed handling of NaN/+inf/-inf lengths. Throw RangeError for too-large or negative lengths.
Clarified exception types.
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArray):
- Clarified exception types and throwing of exceptions along all error code paths.
* html/canvas/TypedArrayBase.h:
(WebCore::TypedArrayBase::create):
- Added necessary null checks during allocation.
2010-06-17 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Clean up error conditions for Typed Arrays
https://bugs.webkit.org/show_bug.cgi?id=40755
* fast/canvas/webgl/array-unit-tests-expected.txt:
- Updated test expectations.
* fast/canvas/webgl/array-unit-tests.html:
- Added tests for overloaded ArrayBufferView constructors taking null,
and improperly aligned offsets. Improved precision of tests causing
INDEX_SIZE_ERR to be thrown.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61339
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
chang.shu@nokia.com [Thu, 17 Jun 2010 17:46:41 +0000 (17:46 +0000)]
2010-06-17 Shu Chang <chang.shu@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix the link error on symbian with ENABLE_JIT=0.
1. Add "#if ENABLE(JIT)" in the header file;
2. Put feature enable/disable logic to a common.pri so
that both JavaScriptCore.pri and WebCore.pri can share.
https://bugs.webkit.org/show_bug.cgi?id=40780
* JavaScriptCore.pri:
* jit/ExecutableAllocator.h:
2010-06-17 Shu Chang <chang.shu@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix the link error on symbian with ENABLE_JIT=0.
1. Add "#if ENABLE(JIT)" in the header file;
2. Put feature enable/disable logic to a common.pri so
that both JavaScriptCore.pri and WebCore.pri can share.
https://bugs.webkit.org/show_bug.cgi?id=40780
* common.pri: Added.
2010-06-17 Shu Chang <chang.shu@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix the link error on symbian with ENABLE_JIT=0.
1. Add "#if ENABLE(JIT)" in the header file;
2. Put feature enable/disable logic to a common.pri so
that both JavaScriptCore.pri and WebCore.pri can share.
https://bugs.webkit.org/show_bug.cgi?id=40780
* WebCore.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61338
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Thu, 17 Jun 2010 17:39:54 +0000 (17:39 +0000)]
2010-06-17 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Differences in error reporting for overloaded methods causing fast/canvas/webgl/texImageTest.html to fail
https://bugs.webkit.org/show_bug.cgi?id=40750
Added V8Proxy::throwTypeError() and throwSyntaxError for parity
with JSC::throwTypeError() and throwSyntaxError. Changed
CodeGeneratorV8.pm to use throwTypeError for overload resolution
failures. Revised CodeGeneratorJS.pm to use throwVMTypeError
instead of manual call to JSValue::encode. Deleted now-unnecessary
Chromium expectations for fast/canvas/webgl/texImageTest.html.
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::throwTypeError):
(WebCore::V8Proxy::throwSyntaxError):
* bindings/v8/V8Proxy.h:
2010-06-17 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Differences in error reporting for overloaded methods causing fast/canvas/webgl/texImageTest.html to fail
https://bugs.webkit.org/show_bug.cgi?id=40750
Added V8Proxy::throwTypeError() and throwSyntaxError for parity
with JSC::throwTypeError() and throwSyntaxError. Changed
CodeGeneratorV8.pm to use throwTypeError for overload resolution
failures. Revised CodeGeneratorJS.pm to use throwVMTypeError
instead of manual call to JSValue::encode. Deleted now-unnecessary
Chromium expectations for fast/canvas/webgl/texImageTest.html.
* platform/chromium-mac/fast/canvas/webgl/texImageTest-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61337
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 17 Jun 2010 17:24:03 +0000 (17:24 +0000)]
2010-06-17 Martin Robinson <mrobinson@igalia.com>
Unreviewed.
tables/mozilla/images/adforce_imgis_com.html was removed after r61289. Remove
it from the GTK+ skipped list.
* platform/gtk/Skipped: Remove a defunct test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61336
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Thu, 17 Jun 2010 17:23:31 +0000 (17:23 +0000)]
2010-06-17 Darin Fisher <darin@chromium.org>
Reviewed by Brady Eidson.
If Page::goToItem is passed a HistoryItem that is the current item,
then the page should be loaded again.
https://bugs.webkit.org/show_bug.cgi?id=40660
* loader/HistoryController.cpp:
(WebCore::HistoryController::recursiveGoToItem): Add a check to
recursiveGoToItem that matches the one in FrameLoader::loadItem.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61335
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 17 Jun 2010 17:06:13 +0000 (17:06 +0000)]
2010-06-17 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Build fix for DragDataBrew
https://bugs.webkit.org/show_bug.cgi?id=40610
http://trac.webkit.org/changeset/60957 was not applied to DragDataBrew.cpp.
Add FilenameConversionPolicy argument to DragData::containsURL and DragData::asURL.
* platform/brew/DragDataBrew.cpp:
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61334
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 17 Jun 2010 16:53:51 +0000 (16:53 +0000)]
2010-06-17 Zhenyao Mo <zmo@google.com>
Reviewed by David Levin.
Rename internalformat to internalFormat
https://bugs.webkit.org/show_bug.cgi?id=40149
* html/canvas/WebGLFramebuffer.cpp: Rename internalformat to internalFormat.
(WebCore::WebGLFramebuffer::getColorBufferFormat):
* html/canvas/WebGLRenderbuffer.cpp: Ditto.
(WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
* html/canvas/WebGLRenderbuffer.h: Ditto.
(WebCore::WebGLRenderbuffer::setInternalFormat):
(WebCore::WebGLRenderbuffer::getInternalFormat):
* html/canvas/WebGLRenderingContext.cpp: Ditto.
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::framebufferRenderbuffer):
(WebCore::WebGLRenderingContext::getRenderbufferParameter):
(WebCore::WebGLRenderingContext::renderbufferStorage):
(WebCore::WebGLRenderingContext::texImage2DBase):
(WebCore::WebGLRenderingContext::isTexInternalFormatColorBufferCombinationValid):
* html/canvas/WebGLRenderingContext.h: Ditto.
* html/canvas/WebGLTexture.cpp: Ditto.
(WebCore::WebGLTexture::WebGLTexture):
* html/canvas/WebGLTexture.h: Ditto.
(WebCore::WebGLTexture::setInternalFormat):
(WebCore::WebGLTexture::getInternalFormat):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61333
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 17 Jun 2010 16:39:38 +0000 (16:39 +0000)]
2010-06-17 Zhenyao Mo <zmo@google.com>
Reviewed by David Levin.
Remove input parameter validation for "level" upper limit in *tex* functions
https://bugs.webkit.org/show_bug.cgi?id=40603
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateTexFuncParameters): Don't check for "level" upper limit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61332
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 17 Jun 2010 16:26:13 +0000 (16:26 +0000)]
2010-06-17 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Eric Seidel.
Clean EFL header files in order to diminish the compilation time with
EFL from subversion. We remove the EFL includes from header files and use
forward declarations, including the headers in correspondent source
files when needed. This causes only the needed source files to be
recompiled in case a new version of EFL is installed instead of
triggering a recompilation of almost all WebCore/WebKit.
https://bugs.webkit.org/show_bug.cgi?id=40575
No new functionalities, so no new tests.
* CMakeListsEfl.txt:
* platform/PlatformKeyboardEvent.h: forward declaration.
* platform/PlatformMouseEvent.h: forward declaration and change method
signature to not require enum.
* platform/PlatformWheelEvent.h: forward declaration.
* platform/Widget.h: forward declaration.
* platform/efl/PlatformKeyboardEventEfl.cpp: include needed header.
* platform/efl/PlatformMouseEventEfl.cpp:
(WebCore::PlatformMouseEvent::setClickCount): change method signature
as mentioned above.
* platform/efl/PlatformWheelEventEfl.cpp: include needed header.
* platform/efl/RenderThemeEfl.cpp: include needed header
* platform/efl/RenderThemeEfl.h: forward declaration.
* platform/efl/ScrollbarEfl.cpp: include needed header.
* platform/efl/ScrollbarEfl.h: forward declaration.
* platform/efl/WidgetEfl.cpp: include needed header.
* platform/graphics/FloatRect.h: remove unused method.
* platform/graphics/Icon.h: forward declaration.
* platform/graphics/IntRect.h: remove unused method.
* platform/graphics/efl/FloatRectEfl.cpp: Removed. This file was
implementing an unused method.
* platform/graphics/efl/IntRectEfl.cpp: Removed. This file was
implementing an unused method.
2010-06-17 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Eric Seidel.
Clean EFL header files in order to diminish the compilation time with
EFL from subversion. We remove the EFL includes from header files and use
forward declarations, including the headers in correspondent source
files when needed. This causes only the needed source files to be
recompiled in case a new version of EFL is installed instead of
triggering a recompilation of almost all WebCore/WebKit.
https://bugs.webkit.org/show_bug.cgi?id=40575
* efl/WebCoreSupport/ChromeClientEfl.cpp: include needed header.
* efl/WebCoreSupport/ChromeClientEfl.h: forward declaration.
* efl/WebCoreSupport/EditorClientEfl.h: forward declaration.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61331
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 17 Jun 2010 16:25:37 +0000 (16:25 +0000)]
2010-06-17 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, test expectations update.
* platform/chromium-mac/fast/dom/wrapper-classes-expected.txt:
* platform/chromium-win/fast/dom/wrapper-classes-expected.txt: Updated results after r61322.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61330
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 17 Jun 2010 15:51:29 +0000 (15:51 +0000)]
One more try at fix for Chromium build.
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell): Use set again instead of =.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61329
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 17 Jun 2010 15:45:14 +0000 (15:45 +0000)]
Fix Chromium build.
I didn't realize that neither Chromium nor Qt share the DumpRenderTree
code with all the other platforms! Wow, that should be fixed at some point.
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell): Changed back to using "new".
* DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61328
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 17 Jun 2010 15:16:04 +0000 (15:16 +0000)]
Unreviewed Qt build fix.
LayoutTestController in the Qt DRT is not using refs :)
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61327
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log