WebKit-https.git
9 years agoWebKit2: Implement TextChecker on Windows
jberlin@webkit.org [Mon, 11 Apr 2011 18:00:07 +0000 (18:00 +0000)]
WebKit2: Implement TextChecker on Windows
https://bugs.webkit.org/show_bug.cgi?id=57862

Reviewed by Anders Carlsson.

Part 6: Update the Spelling UI with the spelling and grammar mistakes.

* UIProcess/API/C/win/WKAPICastWin.h:
(WebKit::toAPI):
Make it possible to go from a WebCore::GrammarDetail to a WebGrammarDetail.

* UIProcess/API/C/win/WKGrammarDetail.cpp:
(WKGrammarDetailCreate):
(WKGrammarDetailGetLocation):
(WKGrammarDetailGetLength):
(WKGrammarDetailCopyGuesses):
(WKGrammarDetailCopyUserDescription):
* UIProcess/API/C/win/WKGrammarDetail.h:

* UIProcess/API/C/win/WKTextChecker.cpp:
(WKTextCheckerCheckSpelling):
Tell the WebTextChecker.
* UIProcess/API/C/win/WKTextChecker.h:

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::contextMenuItemSelected):
If the show/hide spelling UI is selected and the spelling UI is not showing, make sure to
advance to the next misspelling (in this case, the first).
This behavior matches that in WebCore and WKView.mm.
(WebKit::WebPageProxy::advanceToNextMisspelling):
Make this function const since it does not modify the WebPageProxy and making it const
allows WebTextChecker::checkSpelling to take a const WebPageProxy.
(WebKit::WebPageProxy::spellDocumentTag):
(WebKit::WebPageProxy::updateSpellingUIWithMisspelledWord):
(WebKit::WebPageProxy::updateSpellingUIWithGrammarString):
* UIProcess/WebPageProxy.h:

* UIProcess/TextChecker.h:
* UIProcess/win/TextCheckerWin.cpp:
(WebKit::TextChecker::uniqueSpellDocumentTag):
Tell the TextCheckerClient which WebPageProxy this tag is for.
(WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
Tell the TextCheckerClient.
(WebKit::TextChecker::updateSpellingUIWithGrammarString):
Ditto.
* UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::uniqueSpellDocumentTag):
Add the new argument that is unused by this port.
(WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
Ditto.
(WebKit::TextChecker::updateSpellingUIWithGrammarString):
Ditto.
* UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::TextChecker::uniqueSpellDocumentTag):
Ditto.
(WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
Ditto.
(WebKit::TextChecker::updateSpellingUIWithGrammarString):
Ditto.
* UIProcess/qt/TextCheckerQt.cpp:
(WebKit::TextChecker::uniqueSpellDocumentTag):
Ditto.
(WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
Ditto.
(WebKit::TextChecker::updateSpellingUIWithGrammarString):
Ditto.

* UIProcess/win/WebGrammarDetail.cpp:
(WebKit::WebGrammarDetail::create):
(WebKit::WebGrammarDetail::WebGrammarDetail):
(WebKit::WebGrammarDetail::guesses):
* UIProcess/win/WebGrammarDetail.h:
(WebKit::WebGrammarDetail::location):
(WebKit::WebGrammarDetail::length):
(WebKit::WebGrammarDetail::userDescription):

* UIProcess/win/WebTextChecker.cpp:
(WebKit::WebTextChecker::checkSpelling):
Tell the page to advance to the next misspelling. This matches the WK1 WebView.cpp logic.

* UIProcess/win/WebTextChecker.h:
* UIProcess/win/WebTextCheckerClient.cpp:
(WebKit::WebTextCheckerClient::uniqueSpellDocumentTag):
(WebKit::WebTextCheckerClient::toggleSpellingUIIsShowing):
(WebKit::WebTextCheckerClient::updateSpellingUIWithMisspelledWord):
(WebKit::WebTextCheckerClient::updateSpellingUIWithGrammarString):
* UIProcess/win/WebTextCheckerClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAssertion failure in CanvasRenderingContext2D::State::fontsNeedUpdate when invalidati...
mitz@apple.com [Mon, 11 Apr 2011 17:45:16 +0000 (17:45 +0000)]
Assertion failure in CanvasRenderingContext2D::State::fontsNeedUpdate when invalidating the font cache after opening canvas/philip/tests/initial.reset.2dstate.html (occurs on Qt debug test bot)
https://bugs.webkit.org/show_bug.cgi?id=58229

Reviewed by Alexey Proskuryakov.

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::State): Added copy constructor, to register the copy with
the font selector if needed.
(WebCore::CanvasRenderingContext2D::State::operator=): Added assignment constructor, to handle
registration with the font selector as needed.
* html/canvas/CanvasRenderingContext2D.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Mon, 11 Apr 2011 17:39:11 +0000 (17:39 +0000)]
2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        [GTK] ARIA tables not exposing cells as HTML tables do
        https://bugs.webkit.org/show_bug.cgi?id=57463

        Unskipped passing test and added GTK-specific expectations.

        * platform/gtk/Skipped: Unskip accessibility test.
        * platform/gtk/accessibility/aria-table-hierarchy-expected.txt: Added.
2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        [GTK] ARIA tables not exposing cells as HTML tables do
        https://bugs.webkit.org/show_bug.cgi?id=57463

        Expose cells for ARIA grids consistently with HTML tables in GTK,
        keeping the same behaviour for the other platforms.

        * accessibility/AccessibilityARIAGrid.cpp:
        (WebCore::AccessibilityARIAGrid::addChild): Add the row's children
        to the accessibility hierarchy when accessibility objects for rows
        are ignoring accessibility, otherwise add the row.
        (WebCore::AccessibilityARIAGrid::addChildren): Do not check at
        this point whether every child of the table ignores or not
        accessibility, letting addChild() make the proper decision later.

        * accessibility/AccessibilityARIAGridCell.cpp:
        (WebCore::AccessibilityARIAGridCell::parentTable): Consider that
        rows could be ignoring accessibility, hence the parent could be
        retrieved in the first call to parentObjectUnignored().
        (WebCore::AccessibilityARIAGridCell::rowIndexRange): Ditto.
        (WebCore::AccessibilityARIAGridCell::columnIndexRange): Ditto..

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (atkRole): Map ColumnHeader and RowHeader to ATK_ROLE_TABLE_CELL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 11 Apr 2011 17:23:36 +0000 (17:23 +0000)]
2011-04-11  Dimitri Glazkov  <dglazkov@chromium.org>

        [GTK] Update expectations after r83445.

        * platform/gtk/fast/layers/video-layer-expected.txt: Updated.
        * platform/gtk/media/video-empty-source-expected.txt: Updated.
        * platform/gtk/media/video-no-audio-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Thouraya ANDOLSI <thouraya.andolsi@st.com>
commit-queue@webkit.org [Mon, 11 Apr 2011 17:11:38 +0000 (17:11 +0000)]
2011-04-11  Thouraya ANDOLSI  <thouraya.andolsi@st.com>

        Reviewed by Oliver Hunt.

        SH4 JIT SUPPORT.
        https://bugs.webkit.org/show_bug.cgi?id=44329

        Add JIT remaining part for SH4 platforms.

        * assembler/MacroAssemblerSH4.h:
        * jit/JIT.h:
        * jit/JITInlineMethods.h:
        * jit/JITOpcodes32_64.cpp:
        * jit/JITPropertyAccess32_64.cpp:
        * jit/JITStubs.cpp:
        * jit/JITStubs.h:
        * jit/JSInterfaceJIT.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Sergio Villar Senin <svillar@igalia.com>
commit-queue@webkit.org [Mon, 11 Apr 2011 16:35:00 +0000 (16:35 +0000)]
2011-04-11  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Fix make distcheck
        https://bugs.webkit.org/show_bug.cgi?id=58224

        Removed a file that is no longer in the source tree.

        * GNUmakefile.list.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 11 Apr 2011 16:32:36 +0000 (16:32 +0000)]
2011-04-11  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Martin Robinson.

        REGRESSION(r83397): Most GTK media controls are hidden when no valid source is specified
        https://bugs.webkit.org/show_bug.cgi?id=58204

        Covered by existing tests.

        * platform/gtk/RenderThemeGtk.h:
        (WebCore::RenderThemeGtk::hasOwnDisabledStateHandlingFor): Let GTK handle
            the the state of media controls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 11 Apr 2011 16:26:08 +0000 (16:26 +0000)]
2011-04-11  Dimitri Glazkov  <dglazkov@chromium.org>

        Remove obsolete comment, which was mistakenly landed in r83397.

        Though potentially a work of art, the comment lost its functional meaning a long time ago.

        * html/shadow/MediaControls.cpp:
        (WebCore::MediaControls::create): Removed comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-05 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Mon, 11 Apr 2011 15:56:50 +0000 (15:56 +0000)]
2011-04-05  Hans Wennborg  <hans@chromium.org>

        Reviewed by Steve Block.

        IndexedDB: Introduce skeleton for LevelDB backend
        https://bugs.webkit.org/show_bug.cgi?id=57827

        No new tests: no new functionality (yet).

        * WebCore.gyp/WebCore.gyp:
            Add dependency on leveldb when ENABLE_LEVELDB=1 in feature_defines.
        * WebCore.gypi:
            Add new files.
        * storage/IDBBackingStore.h:
        (WebCore::IDBBackingStore::ObjectStoreRecordIdentifier::~ObjectStoreRecordIdentifier):
            Introduce abstract type ObjectStoreRecordIdentifier. The SQLite
            backend uses integers to refer to a specific row in a table, but
            the LevelDB backend will use something else.
        * storage/IDBDatabaseBackendImpl.cpp:
        (WebCore::IDBDatabaseBackendImpl::createObjectStore):
        (WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal):
        (WebCore::IDBDatabaseBackendImpl::deleteObjectStoreInternal):
        (WebCore::IDBDatabaseBackendImpl::loadObjectStores):
            Change functions to pass along the database id for operations that
            concern object stores. We want to be able to group object stores
            ids per database.
        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::IDBFactoryBackendImpl::open):
            Decide which backend to use based on the backingStoreType
            parameter.
        * storage/IDBIndexBackendImpl.cpp:
        (WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):
        (WebCore::IDBIndexBackendImpl::openCursorInternal):
        (WebCore::IDBIndexBackendImpl::getInternal):
        (WebCore::IDBIndexBackendImpl::addingKeyAllowed):
        * storage/IDBIndexBackendImpl.h:
        (WebCore::IDBIndexBackendImpl::create):
            Pass database and object store id to backend functions concerning
            indexes.
        * storage/IDBLevelDBBackingStore.cpp: Added.
        (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
        (WebCore::IDBLevelDBBackingStore::~IDBLevelDBBackingStore):
        (WebCore::IDBLevelDBBackingStore::open):
        (WebCore::IDBLevelDBBackingStore::extractIDBDatabaseMetaData):
        (WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData):
        (WebCore::IDBLevelDBBackingStore::getObjectStores):
        (WebCore::IDBLevelDBBackingStore::createObjectStore):
        (WebCore::IDBLevelDBBackingStore::deleteObjectStore):
        (WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
        (WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
        (WebCore::IDBLevelDBBackingStore::clearObjectStore):
        (WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
        (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
        (WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
        (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
        (WebCore::IDBLevelDBBackingStore::getIndexes):
        (WebCore::IDBLevelDBBackingStore::createIndex):
        (WebCore::IDBLevelDBBackingStore::deleteIndex):
        (WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
        (WebCore::IDBLevelDBBackingStore::deleteIndexDataForRecord):
        (WebCore::IDBLevelDBBackingStore::getObjectViaIndex):
        (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
        (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
        (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
        (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
        (WebCore::IDBLevelDBBackingStore::openIndexCursor):
        (WebCore::IDBLevelDBBackingStore::createTransaction):
        * storage/IDBLevelDBBackingStore.h: Added.
            Add an empty implementation of the LevelDB backend.
        * storage/IDBObjectStoreBackendImpl.cpp:
            Keep track of database id, use the new RecordIdentifier.
        (WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
        (WebCore::IDBObjectStoreBackendImpl::getInternal):
        (WebCore::IDBObjectStoreBackendImpl::putInternal):
        (WebCore::IDBObjectStoreBackendImpl::deleteInternal):
        (WebCore::IDBObjectStoreBackendImpl::clearInternal):
        (WebCore::populateIndex):
        (WebCore::IDBObjectStoreBackendImpl::createIndex):
        (WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
        (WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
        (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
        (WebCore::IDBObjectStoreBackendImpl::loadIndexes):
        (WebCore::IDBObjectStoreBackendImpl::genAutoIncrementKey):
        * storage/IDBObjectStoreBackendImpl.h:
        (WebCore::IDBObjectStoreBackendImpl::create):
        (WebCore::IDBObjectStoreBackendImpl::databaseId):
        * storage/IDBSQLiteBackingStore.cpp:
        (WebCore::IDBSQLiteBackingStore::open):
        (WebCore::IDBSQLiteBackingStore::createObjectStore):
        (WebCore::IDBSQLiteBackingStore::deleteObjectStore):
        (WebCore::IDBSQLiteBackingStore::getObjectStoreRecord):
        (WebCore::IDBSQLiteBackingStore::putObjectStoreRecord):
        (WebCore::IDBSQLiteBackingStore::clearObjectStore):
        (WebCore::IDBSQLiteBackingStore::deleteObjectStoreRecord):
        (WebCore::IDBSQLiteBackingStore::nextAutoIncrementNumber):
        (WebCore::IDBSQLiteBackingStore::keyExistsInObjectStore):
        (WebCore::IDBSQLiteBackingStore::forEachObjectStoreRecord):
        (WebCore::IDBSQLiteBackingStore::getIndexes):
        (WebCore::IDBSQLiteBackingStore::createIndex):
        (WebCore::IDBSQLiteBackingStore::deleteIndex):
        (WebCore::IDBSQLiteBackingStore::putIndexDataForRecord):
        (WebCore::IDBSQLiteBackingStore::deleteIndexDataForRecord):
        (WebCore::IDBSQLiteBackingStore::getObjectViaIndex):
        (WebCore::IDBSQLiteBackingStore::getPrimaryKeyViaIndex):
        (WebCore::IDBSQLiteBackingStore::keyExistsInIndex):
        (WebCore::IDBSQLiteBackingStore::openObjectStoreCursor):
        (WebCore::IDBSQLiteBackingStore::openIndexKeyCursor):
        (WebCore::IDBSQLiteBackingStore::openIndexCursor):
        * storage/IDBSQLiteBackingStore.h:
2011-04-05  Hans Wennborg  <hans@chromium.org>

        Reviewed by Steve Block.

        IndexedDB: Introduce skeleton for LevelDB backend
        https://bugs.webkit.org/show_bug.cgi?id=57827

        * features.gypi:
            Add ENABLE_LEVELDB=0.
        * public/WebIDBFactory.h:
        (WebKit::WebIDBFactory::open):
            Remove pre-roll open() function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] HTML5 Drag and Drop demos not working
benjamin.poulain@nokia.com [Mon, 11 Apr 2011 14:50:12 +0000 (14:50 +0000)]
[Qt] HTML5 Drag and Drop demos not working
https://bugs.webkit.org/show_bug.cgi?id=56486

Reviewed by Andreas Kling.

Handling the drop with JavaScript was not working with Qt because if the action is ignored
in response to DragEnter, no further events are sent to the view.

Drag and drop is defined and used differently by webpages. The drag move events are determining
what action should take place. To adopt this behavior for Qt, we always accept drag enter events
on the widget.

* Api/qwebpage.cpp:
(QWebPagePrivate::dragEnterEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Mon, 11 Apr 2011 14:45:14 +0000 (14:45 +0000)]
2011-04-11  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Duplicate CSS properties are reported for non-lowercase property names in the Styles sidebar
        https://bugs.webkit.org/show_bug.cgi?id=58226

        * inspector/styles/get-set-stylesheet-text-expected.txt:
        * inspector/styles/get-set-stylesheet-text.html:
2011-04-11  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Duplicate CSS properties are reported for non-lowercase property names in the Styles sidebar
        https://bugs.webkit.org/show_bug.cgi?id=58226

        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyle::populateAllProperties):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Mon, 11 Apr 2011 13:44:39 +0000 (13:44 +0000)]
2011-04-11  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] REGRESSION(83122): tst_QWebElement::style() fails
        https://bugs.webkit.org/show_bug.cgi?id=58032

        According to the documentation of QWebElement the styleProperty method should
        not respect style inheritance and other CSS rules for the InlineStyle enum.

        r83122 fixed this behaviour.

        * tests/qwebelement/tst_qwebelement.cpp:
        (tst_QWebElement::style): Fix the expected color for QWebElement::InlineStyle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Mon, 11 Apr 2011 13:41:27 +0000 (13:41 +0000)]
2011-04-11  Andreas Kling  <andreas.kling@nokia.com>

        Build fix after r83436.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-07 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 11 Apr 2011 13:40:38 +0000 (13:40 +0000)]
2011-04-07  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: get rid of source frame delegates for resources panel.
        https://bugs.webkit.org/show_bug.cgi?id=58041

        Use TextViewer configured with a domain-specific delegate to show/edit resource contents in resources panel.

        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView.createResourceView):
        (WebInspector.ResourceView.resourceViewTypeMatchesResource):
        (WebInspector.ResourceSourceFrame):
        (WebInspector.ResourceSourceFrame.prototype.get resource):
        (WebInspector.ResourceSourceFrame.prototype.contentEditable):
        (WebInspector.ResourceSourceFrame.prototype._requestContent):
        (WebInspector.CSSSourceFrame):
        (WebInspector.CSSSourceFrame.prototype.contentEditable):
        (WebInspector.CSSSourceFrame.prototype._editContent):
        (WebInspector.CSSSourceFrame.prototype._editContent.handleInfos):
        (WebInspector.CSSSourceFrame.prototype._saveStyleSheet):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._ensureContentLoaded):
        (WebInspector.SourceFrame.prototype._requestContent):
        (WebInspector.SourceFrame.prototype._handleSave):
        (WebInspector.SourceFrame.prototype._editContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Mon, 11 Apr 2011 13:37:54 +0000 (13:37 +0000)]
2011-04-11  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Regression : r83051 Oxygen's lineedits are not rendered properly
        https://bugs.webkit.org/show_bug.cgi?id=58076

        State_Sunken is more generic than pressed. It is used by items such as frames or
        line edits because they are "sunken" frames (e.g. QLineEdit). It can be required
        by some style like Oxygen. Therefore only in the mobile theme we check if the object
        is pressed.

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::paintTextField):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Mon, 11 Apr 2011 13:11:33 +0000 (13:11 +0000)]
2011-04-11  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Benjamin Poulain.

        [Qt] dumpResourceResponseMIMETypes shouldn't strip URL query string.

        * platform/qt/Skipped: Unskip http/tests/loading/preload-append-scan.php
2011-04-11  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Benjamin Poulain.

        [Qt] dumpResourceResponseMIMETypes shouldn't strip URL query string.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse): Use KURL::lastPathComponent()
        for the dumpResourceResponseMIMETypes display string instead of QFileInfo::fileName().
        This is in line with the Mac port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 11 Apr 2011 12:30:57 +0000 (12:30 +0000)]
2011-04-11  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add support for optional output parameters.
        https://bugs.webkit.org/show_bug.cgi?id=58207

        Output parameters such as "redirectResponse" are optional, but
        do not allow specifying them as such.

        * inspector/CodeGeneratorInspector.pm:
        * inspector/Inspector.json:
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::buildObjectForResourceResponse):
        (WebCore::buildObjectForCachedResource):
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
        * inspector/generate-inspector-idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 11 Apr 2011 11:45:08 +0000 (11:45 +0000)]
2011-04-11  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: refactor / document call frames in debugger domain.
        https://bugs.webkit.org/show_bug.cgi?id=58187

        Note that we are not special casing with(element) and with(document) anymore
        and do not tell user that it is "Event target" and "Event document". Strictly speaking,
        we should not have done it for with(element) not necessarily being related to an event.

        * English.lproj/localizedStrings.js:
        * inspector/InjectedScriptSource.js:
        * inspector/Inspector.json:
        * inspector/front-end/ScopeChainSidebarPane.js:
        (WebInspector.ScopeChainSidebarPane.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 11 Apr 2011 08:57:10 +0000 (08:57 +0000)]
2011-04-11  Alejandro G. Castro  <alex@igalia.com>

        Skipped another test that requires dumpResourceResponseMIMETypes.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 11 Apr 2011 08:47:25 +0000 (08:47 +0000)]
2011-04-11  Kent Tamura  <tkent@chromium.org>

        [Chromium] Update test expectation.
        - http/tests/loading/preload-append-scan.php is flaky.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 11 Apr 2011 07:42:48 +0000 (07:42 +0000)]
2011-04-11  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK media tests rebaseline after r83397.

        * platform/gtk/fast/layers/video-layer-expected.txt:
        * platform/gtk/media/video-empty-source-expected.txt:
        * platform/gtk/media/video-zoom-controls-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 11 Apr 2011 07:33:36 +0000 (07:33 +0000)]
2011-04-11  Kent Tamura  <tkent@chromium.org>

        [Chromium] test expectation update
        - Revert expectations of mask-excessive-malloc.svg and pattern-excessive-malloc.svg.
        - first-of-type-pseudo-class.html is flaky.
        - The merged frame-element-name.html is flaky.
        - ancestor-overflow-change.html is failing on GPU.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-10 ChangSeok Oh <shivamidow@gmail.com>
commit-queue@webkit.org [Mon, 11 Apr 2011 06:57:24 +0000 (06:57 +0000)]
2011-04-10  ChangSeok Oh  <shivamidow@gmail.com>

        Reviewed by Eric Seidel.

        Make correspondence of file name related with event to other port.
        https://bugs.webkit.org/show_bug.cgi?id=57416

        Some file names are changed to make correspondence naming rule.
        Keyboard, mouse and wheel event file names for GTK port have been different from other ports.
        This has made user hard to find a specific file related with event for GTK port.

        No test required. This patch just changes some file names.

        * GNUmakefile.list.am:
        * platform/gtk/KeyEventGtk.cpp: Removed.
        * platform/gtk/MouseEventGtk.cpp: Removed.
        * platform/gtk/PlatformKeyboardEventGtk.cpp: Added.
        * platform/gtk/PlatformMouseEventGtk.cpp: Added.
        * platform/gtk/PlatformWheelEventGtk.cpp: Added.
        * platform/gtk/WheelEventGtk.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-10 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 11 Apr 2011 06:12:44 +0000 (06:12 +0000)]
2011-04-10  Kent Tamura  <tkent@chromium.org>

        [Chromium] Update expectations.
        - Remove deprecated entry
        - Add ancestor-overflow-change.html for GPU.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 11 Apr 2011 06:10:10 +0000 (06:10 +0000)]
2011-04-10  Simon Fraser  <simon.fraser@apple.com>

        Revert the FloatRect.cpp part of r83422, since
        clampToInteger() is broken for some inputs. I filed
        https://bugs.webkit.org/show_bug.cgi?id=58216

        * platform/graphics/FloatRect.cpp:
        (WebCore::safeFloatToInt):
        (WebCore::enclosingIntRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed.
mjs@apple.com [Mon, 11 Apr 2011 05:51:54 +0000 (05:51 +0000)]
Not reviewed.

Remove extra inadvertantly commiteed changes from last change.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-10 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 11 Apr 2011 05:49:27 +0000 (05:49 +0000)]
2011-04-10  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        REGRESSION: WebProcess spews sandboxing violations for outbound network traffic
        https://bugs.webkit.org/show_bug.cgi?id=58215
        <rdar://problem/9251695>

        * WebProcess/com.apple.WebProcess.sb: Restore some previously removed rules.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 11 Apr 2011 05:22:20 +0000 (05:22 +0000)]
2011-04-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Maciej Stachowiak.

        Car model dropdowns at audiusa.com lay out incorrectly with compositing enabled
        https://bugs.webkit.org/show_bug.cgi?id=56660

        When overflow on an element changes, we need to inform compositing
        layers which create and position an "ancestor clipping" layer based
        on that overflow. Do this by triggering a rebuild of compositing layers
        when overflow changes on a layer whose stacking context has compositing
        descendants. (We can't just check whether the layer itself has compositing
        descendants, because overflow follows the render tree, but compositing
        follows the z-order tree.)

        Test: compositing/geometry/ancestor-overflow-change.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::styleChanged):
        * rendering/RenderLayer.h:
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-10 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 11 Apr 2011 05:08:32 +0000 (05:08 +0000)]
2011-04-10  Kent Tamura  <tkent@chromium.org>

        [Chromium] Update test expectation.
        svg/W3C-SVG-1.1/masking-intro-01-f.svg is crashing on Mac and Linux too.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 11 Apr 2011 04:51:42 +0000 (04:51 +0000)]
2011-04-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Ariya Hidayat.

        Allow ShadowBlur to re-use the last buffer if it already contains the correct shadow
        https://bugs.webkit.org/show_bug.cgi?id=58161

        ShadowBlur already has a singleton scratch buffer that is re-used
        between shadows. Enhance use of this scratch buffer to avoid drawing
        and blurring the shadow if the results will match what is already
        in the buffer.

        Cleaned up ShadowBlur code to remove beginShadowLayer() and endShadowLayer(),
        which ended up with little reusable code after adding the re-use logic.

        * platform/graphics/FloatRect.cpp:
        (WebCore::enclosingIntRect): Replace safeFloatToInt() with the existing
        clampToInteger() from MathExtras.h

        * platform/graphics/FloatSize.h:
        (WebCore::expandedIntSize): New method to safely ceil() the size.

        * platform/graphics/RoundedIntRect.h:
        Add operator== for Radii and RoundedIntRect.

        * platform/graphics/ShadowBlur.cpp:
        (WebCore::ScratchBuffer::ScratchBuffer):
        (WebCore::ScratchBuffer::setLastShadowValues):
        (WebCore::ScratchBuffer::setLastInsetShadowValues):
        (WebCore::ScratchBuffer::matchesLastShadow):
        (WebCore::ScratchBuffer::matchesLastInsetShadow):
        (WebCore::ScratchBuffer::clearScratchBuffer):
        Have the scratch buffer remember what shadow parameters were used
        to render the buffer contents.

        (WebCore::ShadowBlur::drawShadowBuffer):
        Renamed from endShadowLayer(), and only contains the drawing
        logic now.

        (WebCore::ShadowBlur::drawRectShadow):
        Promote some code from beginShadowLayer().

        (WebCore::ShadowBlur::drawInsetShadow):
        Promote some code from beginShadowLayer().

        (WebCore::ShadowBlur::drawRectShadowWithoutTiling):
        (WebCore::ShadowBlur::drawInsetShadowWithoutTiling):
        (WebCore::ShadowBlur::drawInsetShadowWithTiling):
        (WebCore::ShadowBlur::drawRectShadowWithTiling):
        These methods now check to see if the buffer already matches
        their required parameters, and avoid work if it does.

        (WebCore::ShadowBlur::blurShadowBuffer):
        Factored some code into this new method.

        (WebCore::ShadowBlur::blurAndColorShadowBuffer):
        Minor refactoring.

        * platform/graphics/ShadowBlur.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-10 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 11 Apr 2011 04:44:50 +0000 (04:44 +0000)]
2011-04-10  Kent Tamura  <tkent@chromium.org>

        [Chromium] Update test expectations.
        - absolute-sized-document-no-scrollbars.svg is flaky on Linux
        - font-update.html is failing on Windows GPU and Linux GPU.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-10 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 11 Apr 2011 04:09:14 +0000 (04:09 +0000)]
2011-04-10  Kent Tamura  <tkent@chromium.org>

        [Chromium] Fix build errors on "Win Shared Builder (dbg)"

        * WebKit.gyp: Exclude WebFrameTest.cpp for WEBKIT_DLL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix: Updated for file move.
ggaren@apple.com [Mon, 11 Apr 2011 04:00:42 +0000 (04:00 +0000)]
Build fix: Updated for file move.

* bindings/js/GCController.cpp:
* bindings/js/ScriptGCEvent.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMoved Heap.h and Heap.cpp to the heap folder, because anything less
ggaren@apple.com [Mon, 11 Apr 2011 03:54:22 +0000 (03:54 +0000)]
Moved Heap.h and Heap.cpp to the heap folder, because anything less
would be uncivilized.

Rubber-stamped by Beth Dakin.

Source/JavaScriptCore:

* Android.mk:
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* heap/Heap.cpp: Copied from JavaScriptCore/runtime/Heap.cpp.
* heap/Heap.h: Copied from JavaScriptCore/runtime/Heap.h.
* runtime/Heap.cpp: Removed.
* runtime/Heap.h: Removed.

Source/WebCore:

* ForwardingHeaders/heap/Heap.h: Copied from WebCore/ForwardingHeaders/runtime/Heap.h.
* ForwardingHeaders/runtime/Heap.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-10 Luke Macpherson <macpherson@chromium.org>
commit-queue@webkit.org [Mon, 11 Apr 2011 03:49:38 +0000 (03:49 +0000)]
2011-04-10  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Simon Fraser.

        Rename CSSStyleApplyProperty::inherit,initial,value applyInheritValue,applyInitialValue,applyValue
        https://bugs.webkit.org/show_bug.cgi?id=58212

        No new tests - function renaming only / no functionality changes.

        * css/CSSStyleApplyProperty.cpp:
        Rename all instances of inherit, initial and value.
        * css/CSSStyleApplyProperty.h:
        Rename all instances of inherit, initial and value.
        * css/CSSStyleSelector.cpp:
        Rename all instances of inherit, initial and value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-10 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
commit-queue@webkit.org [Mon, 11 Apr 2011 02:35:38 +0000 (02:35 +0000)]
2011-04-10  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>

        Reviewed by Eric Seidel.

        Require no undefined symbols during compilation.

        [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
        https://bugs.webkit.org/show_bug.cgi?id=54896

        Add -Wl,--no-undefined to catch missing symbols early.

        * WebProcess.pro:
2011-04-10  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>

        Reviewed by Eric Seidel.

        Require no undefined symbols during compilation.

        [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
        https://bugs.webkit.org/show_bug.cgi?id=54896

        Add -Wl,--no-undefined to catch missing symbols early.

        * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
        * WebKitTestRunner/qt/WebKitTestRunner.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-10 Mike Lawther <mikelawther@chromium.org>
commit-queue@webkit.org [Mon, 11 Apr 2011 02:31:42 +0000 (02:31 +0000)]
2011-04-10  Mike Lawther  <mikelawther@chromium.org>

        Reviewed by Ojan Vafai.

        flex/bison tokens and grammar for CSS calc
        https://bugs.webkit.org/show_bug.cgi?id=54412

        Only the 'errors' and 'regression' tests pass as intended right now. As of this
        patch, none of the actual calculations are expected to work, since only
        the lexing/grammar stage is present.

        * css3/calc/calc-errors-expected.txt: Added.
        * css3/calc/calc-errors.html: Added.
        * css3/calc/lexer-regression-57581-2-expected.txt: Added.
        * css3/calc/lexer-regression-57581-2.html: Added.
        * css3/calc/lexer-regression-57581-3-expected.txt: Added.
        * css3/calc/lexer-regression-57581-3.html: Added.
        * css3/calc/lexer-regression-57581-expected.txt: Added.
        * css3/calc/lexer-regression-57581.html: Added.
        * css3/calc/minmax-errors-expected.txt: Added.
        * css3/calc/minmax-errors.html: Added.
        * css3/calc/simple-calcs-expected.txt: Added.
        * css3/calc/simple-calcs.html: Added.
        * css3/calc/simple-minmax-expected.txt: Added.
        * css3/calc/simple-minmax.html: Added.
2011-04-10  Mike Lawther  <mikelawther@chromium.org>

        Reviewed by Ojan Vafai.

        flex/bison tokens and grammar for CSS calc
        https://bugs.webkit.org/show_bug.cgi?id=54412

        Tests: css3/calc/calc-errors.html
               css3/calc/lexer-regression-57581-2.html
               css3/calc/lexer-regression-57581-3.html
               css3/calc/lexer-regression-57581.html
               css3/calc/minmax-errors.html
               css3/calc/nested-rounded-corners.html
               css3/calc/simple-calcs.html
               css3/calc/simple-minmax.html

        * css/CSSGrammar.y:
        * css/CSSParserValues.cpp:
        (WebCore::CSSParserValueList::insertValueAt):
        (WebCore::CSSParserValueList::extend):
        * css/CSSParserValues.h:
        * css/tokenizer.flex:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-10 Alice Boxhall <aboxhall@chromium.org>
commit-queue@webkit.org [Mon, 11 Apr 2011 02:21:40 +0000 (02:21 +0000)]
2011-04-10  Alice Boxhall  <aboxhall@chromium.org>

        Reviewed by Ryosuke Niwa.

        Change EventHandler::updateSelectionForMouseDrag to take a HitTestResult only.
        https://bugs.webkit.org/show_bug.cgi?id=57923

        Change EventHandler::updateSelectionForMouseDrag to take a HitTestResult
        rather than a Node* and an IntPoint&, as the selection may actually not
        extend into the Node found by the HitTest.

        No new tests. Refactoring only.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseDraggedEvent):
        (WebCore::EventHandler::updateSelectionForMouseDrag):
        * page/EventHandler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-10 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 11 Apr 2011 02:10:15 +0000 (02:10 +0000)]
2011-04-10  Kent Tamura  <tkent@chromium.org>

        [Chromium] Update expectations for r83360.

        * platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.checksum: Removed.
        * platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
        * platform/chromium-linux/fast/box-shadow/inset-expected.png:
        * platform/chromium-mac-leopard/fast/box-shadow/inset-expected.png: Added.
        * platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.checksum: Removed.
        * platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png: Removed.
        * platform/chromium-mac/fast/box-shadow/inset-expected.checksum: Removed.
        * platform/chromium-mac/fast/box-shadow/inset-expected.png: Removed.
        * platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.checksum: Removed.
        * platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
        * platform/chromium-win/fast/box-shadow/inset-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-10 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 11 Apr 2011 01:49:57 +0000 (01:49 +0000)]
2011-04-10  Kent Tamura  <tkent@chromium.org>

        Unreviewed, rolling out r83353.
        http://trac.webkit.org/changeset/83353
        https://bugs.webkit.org/show_bug.cgi?id=58106

        The new test doesn't pass on all Chromium platforms.

        * editing/pasteboard/data-transfer-items-image-png-expected.html: Removed.
        * editing/pasteboard/data-transfer-items-image-png.html: Removed.
2011-04-10  Kent Tamura  <tkent@chromium.org>

        Unreviewed, rolling out r83353.
        http://trac.webkit.org/changeset/83353
        https://bugs.webkit.org/show_bug.cgi?id=58106

        The new test doesn't pass on all Chromium platforms.

        * dom/DataTransferItem.h:
        * dom/DataTransferItem.idl:
        * platform/chromium/ClipboardMimeTypes.cpp:
        * platform/chromium/ClipboardMimeTypes.h:
        * platform/chromium/DataTransferItemChromium.cpp:
        (WebCore::DataTransferItemChromium::getAsString):
        * platform/chromium/DataTransferItemChromium.h:
        * platform/chromium/PlatformBridge.h:
2011-04-10  Kent Tamura  <tkent@chromium.org>

        Unreviewed, rolling out r83353.
        http://trac.webkit.org/changeset/83353
        https://bugs.webkit.org/show_bug.cgi?id=58106

        The new test doesn't pass on all Chromium platforms.

        * DEPS:
        * src/PlatformBridge.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-10 Daniel Bates <dbates@rim.com>
commit-queue@webkit.org [Mon, 11 Apr 2011 01:45:29 +0000 (01:45 +0000)]
2011-04-10  Daniel Bates  <dbates@rim.com>

        Reviewed by Eric Seidel.

        Add layout test to ensure that window.name returns {"_blank", "_parent", "_self", "_top"}
        for a frame of the same name
        https://bugs.webkit.org/show_bug.cgi?id=58189

        Extracted common code from files LayoutTests/fast/frames/resources/frame-element-name-{left, right}.html
        into LayoutTests/fast/frames/resources/frame-element-name.html so that we can use this logic
        to test frames with arbitrary names.

        * fast/frames/frame-element-name-expected.txt:
        * fast/frames/frame-element-name.html: Modified to use resources/frame-element-name.html; Added
          test cases for "_blank", "_parent", "_self", and "_top".
        * fast/frames/resources/frame-element-name-left.html: Removed; Instead, pass expectedName to
          resources/frame-element-name.html
        * fast/frames/resources/frame-element-name-right.html: Ditto.
        * fast/frames/resources/frame-element-name.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Mon, 11 Apr 2011 01:35:33 +0000 (01:35 +0000)]
2011-04-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Eric Carlson.

        [EFL] Add seek forward / backward buttons to MediaControl UI.
        https://bugs.webkit.org/show_bug.cgi?id=56810

        Add seek forward / backward buttons to media control. And, change formType name
        for media control.

        * platform/efl/RenderThemeEfl.cpp:
        (WebCore::RenderThemeEfl::edjeGroupFromFormType):
        (WebCore::RenderThemeEfl::emitMediaButtonSignal):
        (WebCore::RenderThemeEfl::paintMediaMuteButton):
        (WebCore::RenderThemeEfl::paintMediaPlayButton):
        (WebCore::RenderThemeEfl::paintMediaSeekBackButton):
        (WebCore::RenderThemeEfl::paintMediaSeekForwardButton):
        * platform/efl/RenderThemeEfl.h:
2011-04-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Eric Carlson.

        [EFL] Add seek forward / backward buttons to MediaControl UI.
        https://bugs.webkit.org/show_bug.cgi?id=56810

        Add seek forward / backward buttons to media control.

        * DefaultTheme/default.edc:
        * DefaultTheme/widget/mediacontrol/seekbackwardbutton/seekbackward_button.edc: Added.
        * DefaultTheme/widget/mediacontrol/seekbackwardbutton/seekbackwardbutton.png: Added.
        * DefaultTheme/widget/mediacontrol/seekforwardbutton/seekforward_button.edc: Added.
        * DefaultTheme/widget/mediacontrol/seekforwardbutton/seekforwardbutton.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-10 Chris Guillory <chris.guillory@google.com>
commit-queue@webkit.org [Mon, 11 Apr 2011 01:23:58 +0000 (01:23 +0000)]
2011-04-10  Chris Guillory  <chris.guillory@google.com>

        Reviewed by Eric Seidel.

        Remove unused function declaration in PlatformContextSkia.h.
        https://bugs.webkit.org/show_bug.cgi?id=55983

        * platform/graphics/skia/PlatformContextSkia.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Unreviewed build fix. Remove collector dirs from the list of build dirs.
kevino@webkit.org [Sun, 10 Apr 2011 22:30:20 +0000 (22:30 +0000)]
[wx] Unreviewed build fix. Remove collector dirs from the list of build dirs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-10 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 10 Apr 2011 22:07:33 +0000 (22:07 +0000)]
2011-04-10  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Darin Adler.

        Remove duplicated code from AtomicString::fromUTF8()
        https://bugs.webkit.org/show_bug.cgi?id=53711

        * JavaScriptCore.exp:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * wtf/text/AtomicString.cpp:
        (WTF::AtomicString::fromUTF8Internal):
        * wtf/text/AtomicString.h:
        (WTF::AtomicString::fromUTF8):
        * wtf/unicode/UTF8.cpp:
        (WTF::Unicode::calculateStringHashAndLengthFromUTF8):
        * wtf/unicode/UTF8.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-10 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 10 Apr 2011 21:57:22 +0000 (21:57 +0000)]
2011-04-10  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed build fix for !ENABLE(XSLT) after r82562.

        * dom/XMLDocumentParserLibxml2.cpp:
        (WebCore::XMLDocumentParser::doEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-10 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sun, 10 Apr 2011 21:38:13 +0000 (21:38 +0000)]
2011-04-10  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Carlson.

        fast/layers/video-layer.html needs expectations update
        https://bugs.webkit.org/show_bug.cgi?id=58203

        * platform/win/fast/layers/video-layer-expected.txt: Updated result after r83397.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed.
mjs@apple.com [Sun, 10 Apr 2011 21:26:48 +0000 (21:26 +0000)]
Not reviewed.

Fix build (at least on Lion) by adding some newish header files to
PrivateHeaders.

* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-10 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 10 Apr 2011 21:00:17 +0000 (21:00 +0000)]
2011-04-10  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed build fix for !ENABLE(XSLT) after r82562.

        * xml/XMLTreeViewer.cpp: Readded #if ENABLE(XSLT).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKitTestRunner needs a more-complete implementation of eventSender
jberlin@webkit.org [Sun, 10 Apr 2011 18:06:57 +0000 (18:06 +0000)]
WebKitTestRunner needs a more-complete implementation of eventSender
https://bugs.webkit.org/show_bug.cgi?id=42194

Add another test that depends on eventSender.keyDown (fast/dom/hidden-iframe-no-focus.html
added in r83356) to the mac-wk2 skipped list to get the bots green.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Unreviewed build fix. Add Source/JavaScriptCore/heap to the list of directories.
kevino@webkit.org [Sun, 10 Apr 2011 17:37:48 +0000 (17:37 +0000)]
[wx] Unreviewed build fix. Add Source/JavaScriptCore/heap to the list of directories.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-10 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sun, 10 Apr 2011 17:35:54 +0000 (17:35 +0000)]
2011-04-10  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Anders Carlsson.

        REGRESSION(r83256): Text-decoration bleeds into shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=58205

        * platform/chromium/test_expectations.txt: Removed the test that starts
            passing after this change.
2011-04-10  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Anders Carlsson.

        REGRESSION(r83256): Text-decoration bleeds into shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=58205

        Now that the shadow root is a never-styled element, we need to walk to
        parent to find out if we're inside of a shadow DOM subtree.

        Test: media/controls-styling.html

        * css/CSSStyleSelector.cpp:
        (WebCore::isAtShadowBoundary): Added helper function.
        (WebCore::CSSStyleSelector::adjustRenderStyle): Changed to use the helper.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-10 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sun, 10 Apr 2011 16:45:17 +0000 (16:45 +0000)]
2011-04-10  Dimitri Glazkov  <dglazkov@chromium.org>

        Temporarily add a failing test, while I am fixing it.

        * platform/chromium/test_expectations.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r83384): Change to chromium.py is resulting in failures of the test framew...
levin@chromium.org [Sun, 10 Apr 2011 16:00:51 +0000 (16:00 +0000)]
REGRESSION(r83384): Change to chromium.py is resulting in failures of the test framework on linux.
https://bugs.webkit.org/show_bug.cgi?id=58201

Reviewed by Dimitri Glazkov.

* Scripts/webkitpy/layout_tests/port/chromium.py: Commented out the assert for now,
and filed bug 58202.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-07 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sun, 10 Apr 2011 14:57:13 +0000 (14:57 +0000)]
2011-04-07  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Carlson.

        [Meta] Convert HTMLMediaElement to use the new shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=53020

        This conversion is non-trivial, for several reasons:

        1) Since HTMLMediaElement now hosts the shadow DOM for controls, hiding
        and showing controls does not result in destroying and re-creating the
        shadow DOM tree. Instead, the tree is created as needed and shown/hidden
        using inline styles.

        2) Instead of detaching/attaching on each style change, the control parts
        are now using a set of higher fidelity callbacks that notify MediaControls
        about changes to which it should react. Each reaction results in hiding,
        showing, or changing the state of the control parts using inline styles
        and DOM APIs.

        3) Hiding and showing controls is accomplished using inline styles, rather
        than wiring rendererIsNeeded, because renderers are now re-created less
        frequently.

        4) Instead of constantly querying RenderTheme about visibility of a particular
        control part, we let the theme determine which parts are supported and
        which parts are visible in certain conditions.

        5) Custom hit-testing, event forwarding, and style updates are completely
        removed, since they are now unnecessary.

        6) Fading controls in/out is now done as CSS animation, since shadow DOM
        supports it.

        Test: manual-tests/media-controls.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9215280> Detached canvas draws with incorrect font
mitz@apple.com [Sun, 10 Apr 2011 06:29:26 +0000 (06:29 +0000)]
<rdar://problem/9215280> Detached canvas draws with incorrect font

Reviewed by Beth Dakin.

Source/WebCore:

Test: fast/canvas/font-update.html

The existing mechanism for updating the font in a canvas 2D context was lacking in at least
two ways: it neglected to update fonts in all but the topmost state in the stack, and since it
was based on HTMLCanvasElemen's attach() and recalcStyle(), it did not work when the element
was not attached.

This change takes the responsibility for font updates away from the canvas element and gives it
to the canvas context and its graphics state.

* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::registerForInvalidationCallbacks): Added. Adds to the set of registered
font selector clients.
(WebCore::CSSFontSelector::unregisterForInvalidationCallbacks): Added. Removes from the set of
registered font selector clients.
(WebCore::CSSFontSelector::dispatchInvalidationCallbacks): Calls fontsNeedUpdate() on all registered
clients and forces a style recalc on the document.
(WebCore::CSSFontSelector::fontLoaded): Changed to call dispatchInvalidationCallbacks().
(WebCore::CSSFontSelector::fontCacheInvalidated): Ditto.
* css/CSSFontSelector.h:
* html/HTMLCanvasElement.cpp: Removed overrides of attach() and recalcStyle().
* html/HTMLCanvasElement.h:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::~State): Added. Unregisters with the font selector.
(WebCore::CanvasRenderingContext2D::State::fontsNeedUpdate): Added. Called by the font selector
when its fonts need to be updated. Updates the font.
(WebCore::CanvasRenderingContext2D::setFont): Registers the state with the font selector.
* html/canvas/CanvasRenderingContext2D.h:
* platform/graphics/FontSelector.h:
(WebCore::FontSelectorClient::~FontSelectorClient):

LayoutTests:

* fast/canvas/font-update-expected.checksum: Added.
* fast/canvas/font-update-expected.png: Added.
* fast/canvas/font-update-expected.txt: Added.
* fast/canvas/font-update.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-09 David Levin <levin@chromium.org>
levin@chromium.org [Sun, 10 Apr 2011 06:17:24 +0000 (06:17 +0000)]
2011-04-09  David Levin  <levin@chromium.org>

        Unreviewed, rolling out r83394.
        http://trac.webkit.org/changeset/83394
        https://bugs.webkit.org/show_bug.cgi?id=53625

        Patch was incorrect as noted in the bug.

        * Scripts/svn-apply:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agosvn-apply and/or patch(1) has trouble applying patches that makes changes to files...
levin@chromium.org [Sun, 10 Apr 2011 05:57:58 +0000 (05:57 +0000)]
svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings
https://bugs.webkit.org/show_bug.cgi?id=53625

Reviewed by Adam Barth.

* Scripts/svn-apply: Ensure that the portions of patches
which are for vcproj/vsprops files has DOS line endings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-09 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sun, 10 Apr 2011 04:18:15 +0000 (04:18 +0000)]
2011-04-09  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.
        https://bugs.webkit.org/show_bug.cgi?id=58193

        Suppress a whole bunch of Win Vista failures until they can be
        triaged and/or rebaselined.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed.
ggaren@apple.com [Sun, 10 Apr 2011 03:55:42 +0000 (03:55 +0000)]
Not reviewed.

Try recommitting some things svn left out of my last commit.

* bridge/qt/qt_runtime.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed.
ggaren@apple.com [Sun, 10 Apr 2011 03:53:45 +0000 (03:53 +0000)]
Not reviewed.

Try recommitting some things svn left out of my last commit.

* WebProcess/Plugins/Netscape/NPJSObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed.
ggaren@apple.com [Sun, 10 Apr 2011 03:50:32 +0000 (03:50 +0000)]
Not reviewed.

Try recommitting some things svn left out of my last commit.

* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::evaluate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed.
ggaren@apple.com [Sun, 10 Apr 2011 03:47:56 +0000 (03:47 +0000)]
Not reviewed.

Try recommitting some things svn left out of my last commit.

* ForwardingHeaders/collector: Removed.
* ForwardingHeaders/collector/handles: Removed.
* ForwardingHeaders/collector/handles/Global.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed.
ggaren@apple.com [Sun, 10 Apr 2011 03:41:08 +0000 (03:41 +0000)]
Not reviewed.

Try recommitting some things svn left out of its last commit.

* heap/Handle.h:
(JSC::HandleBase::operator!):
(JSC::HandleBase::HandleBase):
(JSC::HandleBase::slot):
(JSC::HandleBase::setSlot):
(JSC::Handle::Handle):
* heap/HandleHeap.cpp:
(JSC::HandleHeap::markWeakHandles):
(JSC::HandleHeap::finalizeWeakHandles):
(JSC::HandleHeap::isValidWeakNode):
* heap/HandleHeap.h:
(JSC::HandleHeap::globalData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-09 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sun, 10 Apr 2011 03:01:30 +0000 (03:01 +0000)]
2011-04-09  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.
        https://bugs.webkit.org/show_bug.cgi?id=58193

        Suppress a whole bunch of Win 7 failures until they can be
        triaged and/or rebaselined.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-02 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sun, 10 Apr 2011 02:33:19 +0000 (02:33 +0000)]
2011-04-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Ojan Vafai.

        Implement proper handling of mouseover/mouseout events in regard to shadow DOM boundaries.
        https://bugs.webkit.org/show_bug.cgi?id=55515

        * fast/events/shadow-boundary-crossing-expected.txt: Updated expectations.
        * fast/events/shadow-boundary-crossing.html: Added new test for mouseover/mouseout handling.
2011-04-08  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Ojan Vafai.

        Implement proper handling of mouseover/mouseout events in regard to shadow DOM boundaries.
        https://bugs.webkit.org/show_bug.cgi?id=55515

        This implements XBL 2.0's specified handling of mouseover/mouseout events:
        http://dev.w3.org/2006/xbl2/Overview.html#the-mouseover-and-mouseout-events

        To do this, we:
        1) calculate lowest common ancestor between relatedTarget and target, and
           the nearest boundaries around them: the outer (common) boundary, and the
           inner (specific to relatedTarget) boundary. Then, we
        2) ensure that events only propagate up to the common boundary (or
           all the way if boundary is not found), while
        3) updating relatedTarget be the inner boundary.

        We also detect the most common case when no common boundary could exist
        and provide a fast path to short-circuit most of the boundary detection
        logic.

        Test: fast/events/shadow-boundary-crossing.html

        * dom/EventDispatcher.cpp:
        (WebCore::EventDispatcher::adjustToShadowBoundaries): Added a helper to determine lowest
            common ancestor, the boundaries around it, and compute adjustments
            to relatedTarget and event target ancestor chain.
        (WebCore::ancestorsCrossShadowBoundaries): Added.
        (WebCore::EventDispatcher::adjustRelatedTarget): Changed to calculate
            inner/outer shadow DOM boundaries and adjust ancestors chain accordingly.
        (WebCore::EventDispatcher::EventDispatcher): Added flag initializer
        (WebCore::EventDispatcher::ensureEventAncestors): Renamed from getEventAncestors,
            converted to use initialization flag, rather than testing for empty.
        * dom/EventDispatcher.h: Adjusted decls.
        * dom/MouseEvent.cpp:
        (WebCore::MouseEventDispatchMediator::dispatchEvent): Changed to send event
            to adjustRelatedTarget.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-08 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sun, 10 Apr 2011 02:32:07 +0000 (02:32 +0000)]
2011-04-08  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        A few heap-related renames and file moves.

        WeakGCPtr<T> => Weak<T>
        Global<T> => Strong<T>
        collector/ => heap/
        collector/* => heap/*
        runtime/WeakGCPtr.h => heap/Weak.h

        (Eventually, even more files should move into the heap directory. Like
        Heap.h and Heap.cpp, for example.)

        * API/JSClassRef.h:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * GNUmakefile.list.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.pri:
        * JavaScriptCore.pro:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
        * JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
        * JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * bytecode/SamplingTool.h:
        * bytecompiler/BytecodeGenerator.h:
        * collector: Removed.
        * collector/handles: Removed.
        * collector/handles/Global.h: Removed.
        * collector/handles/Handle.h: Removed.
        * collector/handles/HandleHeap.cpp: Removed.
        * collector/handles/HandleHeap.h: Removed.
        * collector/handles/HandleStack.cpp: Removed.
        * collector/handles/HandleStack.h: Removed.
        * collector/handles/Local.h: Removed.
        * collector/handles/LocalScope.h: Removed.
        * heap: Copied from collector.
        * heap/Handle.h: Copied from collector/handles/Handle.h.
        * heap/HandleHeap.cpp: Copied from collector/handles/HandleHeap.cpp.
        * heap/HandleHeap.h: Copied from collector/handles/HandleHeap.h.
        * heap/HandleStack.cpp: Copied from collector/handles/HandleStack.cpp.
        * heap/HandleStack.h: Copied from collector/handles/HandleStack.h.
        * heap/Local.h: Copied from collector/handles/Local.h.
        * heap/LocalScope.h: Copied from collector/handles/LocalScope.h.
        * heap/Strong.h: Copied from collector/handles/Global.h.
        (JSC::Strong::Strong):
        (JSC::Strong::~Strong):
        (JSC::Strong::operator=):
        * heap/Weak.h: Copied from runtime/WeakGCPtr.h.
        (JSC::Weak::Weak):
        (JSC::Weak::~Weak):
        * heap/handles: Removed.
        * interpreter/RegisterFile.h:
        * jit/JITStubs.cpp:
        (JSC::JITThunks::hostFunctionStub):
        * jit/JITStubs.h:
        * runtime/Structure.h:
        * runtime/WeakGCPtr.h: Removed.
2011-04-08  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        A few heap-related renames and file moves.

        WeakGCPtr<T> => Weak<T>
        Global<T> => Strong<T>
        collector/ => heap/
        collector/* => heap/*
        runtime/WeakGCPtr.h => heap/Weak.h

        (Eventually, even more files should move into the heap directory. Like
        Heap.h and Heap.cpp, for example.)

        * JSRun.h:
        * JSValueWrapper.h:
2011-04-08  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        A few heap-related renames and file moves.

        WeakGCPtr<T> => Weak<T>
        Global<T> => Strong<T>
        collector/ => heap/
        collector/* => heap/*
        runtime/WeakGCPtr.h => heap/Weak.h

        (Eventually, even more files should move into the heap directory. Like
        Heap.h and Heap.cpp, for example.)

        * CMakeLists.txt:
2011-04-08  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        A few heap-related renames and file moves.

        WeakGCPtr<T> => Weak<T>
        Global<T> => Strong<T>
        collector/ => heap/
        collector/* => heap/*
        runtime/WeakGCPtr.h => heap/Weak.h

        (Eventually, even more files should move into the heap directory. Like
        Heap.h and Heap.cpp, for example.)

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
        (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
        (WebKit::NetscapePluginInstanceProxy::evaluate):
        * WebView/WebScriptDebugger.h:
2011-04-08  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        A few heap-related renames and file moves.

        WeakGCPtr<T> => Weak<T>
        Global<T> => Strong<T>
        collector/ => heap/
        collector/* => heap/*
        runtime/WeakGCPtr.h => heap/Weak.h

        (Eventually, even more files should move into the heap directory. Like
        Heap.h and Heap.cpp, for example.)

        * CMakeLists.txt:
        * ForwardingHeaders/collector: Removed.
        * ForwardingHeaders/heap: Copied from ForwardingHeaders/collector.
        * ForwardingHeaders/heap/Strong.h: Copied from ForwardingHeaders/collector/handles/Global.h.
        * ForwardingHeaders/heap/Weak.h: Copied from ForwardingHeaders/runtime/WeakGCPtr.h.
        * ForwardingHeaders/runtime/WeakGCPtr.h: Removed.
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcproj/copyForwardingHeaders.cmd:
        * bindings/js/JSCallbackData.h:
        * bindings/js/JSCustomVoidCallback.h:
        * bindings/js/JSDOMWindowBase.h:
        * bindings/js/JSDOMWindowShell.cpp:
        (WebCore::JSDOMWindowShell::setWindow):
        * bindings/js/JSDataGridDataSource.h:
        * bindings/js/JSEventListener.h:
        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::ScheduledAction):
        * bindings/js/ScheduledAction.h:
        * bindings/js/ScriptCachedFrameData.cpp:
        (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
        * bindings/js/ScriptCachedFrameData.h:
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::createWindowShell):
        * bindings/js/ScriptController.h:
        * bindings/js/ScriptObject.h:
        * bindings/js/ScriptState.h:
        * bindings/js/ScriptValue.cpp:
        * bindings/js/ScriptValue.h:
        * bindings/js/ScriptWrappable.h:
        * bindings/js/WorkerScriptController.cpp:
        (WebCore::WorkerScriptController::initScript):
        * bindings/js/WorkerScriptController.h:
        * bridge/jsc/BridgeJSC.h:
        * bridge/qt/qt_runtime.h:
        * bridge/runtime_root.h:
        * xml/XMLHttpRequest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-09 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sun, 10 Apr 2011 00:30:54 +0000 (00:30 +0000)]
2011-04-09  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        It looks like NRWT has not been stopping DRT/TestShell
        instances properly on windows, probably for a long time.
        This would go a long way to explaining why we often have
        processes lying around :)

        https://bugs.webkit.org/show_bug.cgi?id=57807

        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-09 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 9 Apr 2011 23:07:05 +0000 (23:07 +0000)]
2011-04-09  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        new-run-webkit-tests: Mac SL tests failing on the bot
        https://bugs.webkit.org/show_bug.cgi?id=58192

        Mark tests as needing triage/investigation for failing
        on NRWT bot.

        * platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-09 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 9 Apr 2011 22:24:02 +0000 (22:24 +0000)]
2011-04-09  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by James Robinson.

        Add a diagram, explaning how  an event's relatedTarget interact with shadow DOM boundaries.
        https://bugs.webkit.org/show_bug.cgi?id=58190

        * misc/related-target-and-shadow-dom.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] One more attempt to make Qt-WK2 bot happy.
ossy@webkit.org [Sat, 9 Apr 2011 18:30:35 +0000 (18:30 +0000)]
[Qt][WK2] One more attempt to make Qt-WK2 bot happy.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-09 Keith Kyzivat <keith.kyzivat@nokia.com>
kbalazs@webkit.org [Sat, 9 Apr 2011 17:58:53 +0000 (17:58 +0000)]
2011-04-09  Keith Kyzivat  <keith.kyzivat@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Don't link against fontconfig or X11 if embedded
        https://bugs.webkit.org/show_bug.cgi?id=58104

        * Source/WebKit.pri: Add qpa=>embedded as it should be across all builds.
2011-04-09  Keith Kyzivat  <keith.kyzivat@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Don't link against fontconfig or X11 if embedded
        https://bugs.webkit.org/show_bug.cgi?id=58104

        No functional change so no new tests.

        * WebCore.pri: qpa=>embedded should be done very early so all cases of embedded are uniform.
2011-04-09  Keith Kyzivat  <keith.kyzivat@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Don't link against fontconfig or X11 if embedded
        https://bugs.webkit.org/show_bug.cgi?id=58104

        * DumpRenderTree/qt/DumpRenderTree.pro: fontconfig !included in embedded
        * QtTestBrowser/QtTestBrowser.pro: ditto
        * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: ditto
        * WebKitTestRunner/qt/WebKitTestRunner.pro: ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Make Qt bots happier. :)
ossy@webkit.org [Sat, 9 Apr 2011 17:24:32 +0000 (17:24 +0000)]
[Qt] Make Qt bots happier. :)

* platform/qt-wk2/Skipped: Remove non-existent tests.
* platform/qt/Skipped: Add new tests without Qt specific expected files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed trivial fix after r83344.
ossy@webkit.org [Sat, 9 Apr 2011 17:14:10 +0000 (17:14 +0000)]
[Qt] Unreviewed trivial fix after r83344.

* WebCore.pro: Update HEADERS list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Make Qt-WK2 buildbot green on http://webkit.sed.hu
ossy@webkit.org [Sat, 9 Apr 2011 17:04:38 +0000 (17:04 +0000)]
[Qt][WK2] Make Qt-WK2 buildbot green on webkit.sed.hu

* platform/qt-wk2/Skipped: Add failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-09 Jon Lee <jonlee@apple.com>
commit-queue@webkit.org [Sat, 9 Apr 2011 08:31:00 +0000 (08:31 +0000)]
2011-04-09  Jon Lee  <jonlee@apple.com>

        Reviewed by Beth Dakin.

        Overlay scrollbar flashes in scrollable <textarea> with each keystroke (58180)
        https://bugs.webkit.org/show_bug.cgi?id=58180
        <rdar://problem/9047984>

        * platform/mac/ScrollAnimatorMac.mm:
        (WebCore::ScrollAnimatorMac::immediateScrollToPoint): Check that there is a change before submitting
        (WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
        (WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-09 Sreeram Ramachandran <sreeram@google.com>
commit-queue@webkit.org [Sat, 9 Apr 2011 08:01:20 +0000 (08:01 +0000)]
2011-04-09  Sreeram Ramachandran  <sreeram@google.com>

        Reviewed by Ryosuke Niwa.

        Gather data on modal dialogs shown during unload events
        https://bugs.webkit.org/show_bug.cgi?id=58115

        Add a new method to the ChromeClient API to allow clients to receive
        notifications of modal dialogs dispatched during page dismissal events.
        The new method has a default empty definition; only chromium overrides
        it to keep track of histograms.

        No tests because this is a no-op for all ports except chromium (and it's
        not clear how to test chromium histograms from webkit).

        * page/Chrome.cpp:
        (WebCore::isDuringPageDismissal):
        (WebCore::willRunModalDialog):
        (WebCore::Chrome::runJavaScriptAlert):
        (WebCore::Chrome::runJavaScriptConfirm):
        (WebCore::Chrome::runJavaScriptPrompt):
        (WebCore::Chrome::willRunModalHTMLDialog):
        * page/Chrome.h:
        * page/ChromeClient.h:
        (WebCore::ChromeClient::willRunModalDialogDuringPageDismissal):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::showModalDialog):
2011-04-09  Sreeram Ramachandran  <sreeram@google.com>

        Reviewed by Ryosuke Niwa.

        Gather data on modal dialogs shown during unload events
        https://bugs.webkit.org/show_bug.cgi?id=58115

        Implementation of the new API to receive notifications of modal dialogs
        dispatched during unload events. Count the notifications through a histogram.

        No tests because it's not clear how to test chromium histograms from webkit.

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::willRunModalDialogDuringPageDismissal):
        * src/ChromeClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNo need to compile .js files, that is what the JIT is for.
mitz@apple.com [Sat, 9 Apr 2011 04:41:09 +0000 (04:41 +0000)]
No need to compile .js files, that is what the JIT is for.

* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-08 David Humphrey <david.humphrey@senecac.on.ca>
commit-queue@webkit.org [Sat, 9 Apr 2011 03:05:18 +0000 (03:05 +0000)]
2011-04-08  David Humphrey  <david.humphrey@senecac.on.ca>

        Reviewed by Eric Carlson.

        Fix call order of media element muted and play(), such that setting muted before play() works.
        https://bugs.webkit.org/show_bug.cgi?id=57673
        https://code.google.com/p/chromium/issues/detail?id=70777

        Manual test added: manual-tests/media-muted.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::updatePlayState):
        * manual-tests/media-muted.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-08 Alexey Proskuryakov <ap@apple.com>
ap@apple.com [Sat, 9 Apr 2011 01:59:20 +0000 (01:59 +0000)]
2011-04-08  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Darin Adler.

        WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
        https://bugs.webkit.org/show_bug.cgi?id=58175
        <rdar://problem/9060555>

        * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
        should be changed to match WebKit2.
2011-04-08  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Darin Adler.

        WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
        https://bugs.webkit.org/show_bug.cgi?id=58175
        <rdar://problem/9060555>

        The problem is that command handling should be different for events that come as keyDown:
        and those that come as performKeyEquivalent:. WebKit1 only tries custom "key bindings"
        when handling a keyDown:, letting a performKeyEquivalent: run through the whole responder
        chain first.

        This would be very difficult to implement in WebKit2 because of how it re-sends the same
        event after web process handling. Luckily, we can both fix the bug and make the behavior
        more robust by not hardcoding key combinations.

        * WebProcess/WebPage/WebPage.h: Edit performNonEditingBehaviorForSelector.
        * WebProcess/WebPage/mac/WebPageMac.mm:
        (WebKit::WebPage::executeKeypressCommandsInternal): When executing commands, also try
        executing editor commands in their non-editing meaning, which is usually scrolling.
        (WebKit::WebPage::performNonEditingBehaviorForSelector): Naive implementation with a chain
        of ifs, which is hopefully ok performance-wise for a dozen check.
        (WebKit::WebPage::performDefaultBehaviorForKeyEvent): Only kept two commands here that I
        couldn't easily move.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttp/tests/loading/preload-append-scan.php is failing on Windows
jhoneycutt@apple.com [Sat, 9 Apr 2011 01:39:27 +0000 (01:39 +0000)]
http/tests/loading/preload-append-scan.php is failing on Windows
https://bugs.webkit.org/show_bug.cgi?id=58178

Reviewed by Brian Weinstein.

* DumpRenderTree/win/DumpRenderTree.cpp:
(lastPathComponent):
Use CFURL API to find the last path component, rather than
PathFindFileName(), because the latter will include the query string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-08 Nat Duca <nduca@chromium.org>
commit-queue@webkit.org [Sat, 9 Apr 2011 01:36:34 +0000 (01:36 +0000)]
2011-04-08  Nat Duca  <nduca@chromium.org>

        Reviewed by David Levin.

        [chromium] Fix windows assertion on ~CCThread
        https://bugs.webkit.org/show_bug.cgi?id=58153

        Because ~CCThread uses waitForThreadCompletion,
        calling detachThread is not necessary.

        * platform/graphics/chromium/cc/CCThread.cpp:
        (WebCore::CCThread::runLoop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2: Show the substitutions panel on Mac and make sure the menu items titles are
jberlin@webkit.org [Sat, 9 Apr 2011 01:31:30 +0000 (01:31 +0000)]
WebKit2: Show the substitutions panel on Mac and make sure the menu items titles are
updated correctly.
https://bugs.webkit.org/show_bug.cgi?id=58179

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKView.mm:
(-[WKView validateUserInterfaceItem:]):
The title of the context menu item should be opposite of whether or not the spelling panel
is visible.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::contextMenuItemSelected):
If the "Show/Hide" Substitutions item is selected, call toggleSubstitutionsPanelIsShowing.
(WebKit::WebPageProxy::substitutionsPanelIsShowing):
Ask the TextChecker.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:

* UIProcess/TextChecker.h:
* UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::substitutionsPanelIsShowing):
As the shared NSSpellChecker if the substitutionsPanel is visible.
(WebKit::TextChecker::toggleSubstitutionsPanelIsShowing):
Order the substitutionsPanel out or front (copied from WKView.mm).

* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
(WebKit::WebEditorClient::substitutionsPanelIsShowing):
Send a sync message to the UI process to find out.
It needs to be sync because the editor code relies on the value returned.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixed a bug where right-to-left frames incorrectly reported that they were pinned...
mitz@apple.com [Sat, 9 Apr 2011 00:57:35 +0000 (00:57 +0000)]
Fixed a bug where right-to-left frames incorrectly reported that they were pinned to the left
when they were actually not.

Reviewed by Adele Peterson.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didChangeScrollOffsetForMainFrame): Do not assume that the minimum scroll offset
is zero, because it is not.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix broken sentence in WebCore/Change of my rollout r83365.
jianli@chromium.org [Sat, 9 Apr 2011 00:55:54 +0000 (00:55 +0000)]
Fix broken sentence in WebCore/Change of my rollout r83365.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReviewed by Dmitry Titov.
aa@chromium.org [Sat, 9 Apr 2011 00:54:36 +0000 (00:54 +0000)]
Reviewed by Dmitry Titov.

Re-land http://trac.webkit.org/changeset/83007. This works
without changes after https://bugs.webkit.org/show_bug.cgi?id=58110.

https://bugs.webkit.org/show_bug.cgi?id=58096

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-08 Jian Li <jianli@chromium.org>
jianli@chromium.org [Sat, 9 Apr 2011 00:52:34 +0000 (00:52 +0000)]
2011-04-08  Jian Li  <jianli@chromium.org>

        Unreviewed, rolling out r83348.
        http://trac.webkit.org/changeset/83348
        https://bugs.webkit.org/show_bug.cgi?id=49508

        Breaks layout tests in QT, Win7 and Chromium.

        * fast/forms/cursor-at-editable-content-boundary-expected.txt: Removed.
        * fast/forms/cursor-at-editable-content-boundary.html: Removed.
2011-04-08  Jian Li  <jianli@chromium.org>

        Unreviewed, rolling out r83348.
        http://trac.webkit.org/changeset/83348
        https://bugs.webkit.org/show_bug.cgi?id=49508

        Breaks

        * rendering/RenderText.cpp:
        (WebCore::RenderText::localCaretRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the Windows build.
andersca@apple.com [Sat, 9 Apr 2011 00:28:00 +0000 (00:28 +0000)]
Fix the Windows build.

* UIProcess/win/WebView.cpp:
(WebKit::WebView::Drop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2: Implement TextChecker on Windows
jberlin@webkit.org [Sat, 9 Apr 2011 00:18:01 +0000 (00:18 +0000)]
WebKit2: Implement TextChecker on Windows
https://bugs.webkit.org/show_bug.cgi?id=57862

Reviewed by Anders Carlsson.

Part 5: Implement the code show and hide the Spelling UI via the context menu item (both
Windows and Mac).

* UIProcess/API/C/win/WKTextChecker.h:
Add the new WKTextCheckerClient funtions.

* UIProcess/API/mac/WKView.mm:
(-[WKView validateUserInterfaceItem:]):
The title of the context menu item should be opposite of whether or not the spelling panel
is visible.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::contextMenuItemSelected):
If the "Show/Hide Spelling and Grammar" item is selected, call toggleSpellingUIIsShowing.
(WebKit::WebPageProxy::spellingUIIsShowing):
Call through to TextChecker.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:

* UIProcess/TextChecker.h:
       * UIProcess/win/TextCheckerWin.cpp:
(WebKit::TextChecker::spellingUIIsShowing):
Call the TextCheckerClient.
(WebKit::TextChecker::toggleSpellingUIIsShowing):
Ditto.
* UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::spellingUIIsShowing):
Ask the shared NSSpellChecker if the spellingPanel is visible.
(WebKit::TextChecker::toggleSpellingUIIsShowing):
Order the spellingPanel out or front (copied from WKView.mm).
* UIProcess/qt/TextCheckerQt.cpp:
(WebKit::TextChecker::spellingUIIsShowing):
Call notImplemented.
(WebKit::TextChecker::toggleSpellingUIIsShowing):
Ditto.
* UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::TextChecker::spellingUIIsShowing):
Ditto.
(WebKit::TextChecker::toggleSpellingUIIsShowing):
Ditto.

* UIProcess/win/WebTextCheckerClient.cpp:
(WebKit::WebTextCheckerClient::spellingUIIsShowing):
Call the client.
(WebKit::WebTextCheckerClient::toggleSpellingUIIsShowing):
Ditto.
* UIProcess/win/WebTextCheckerClient.h:

* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::spellingUIIsShowing):
Send a sync message to the UI process to find out.
It needs to be sync because the Editor code relies on the value returned.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-08 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 9 Apr 2011 00:04:50 +0000 (00:04 +0000)]
2011-04-08  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Sandboxing doesn't work if a local file is dropped on the content area
        https://bugs.webkit.org/show_bug.cgi?id=58177
        <rdar://problem/9019253>

        When performing a drag and the dragging pasteboard contains a local file, create a
        sandbox extension and pass it along. If we end up loading the file, the sandbox extension
        tracker will consume the extension.

        * UIProcess/API/mac/WKView.mm:
        (maybeCreateSandboxExtensionFromPasteboard):
        Add helper function.

        (-[WKView performDragOperation:]):
        Create a sandbox extension handle and pass it to performDrag.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::dragEntered):
        (WebKit::WebPageProxy::dragUpdated):
        (WebKit::WebPageProxy::dragExited):
        Pass an empty sandbox extension handle to performDragControllerAction.

        (WebKit::WebPageProxy::performDrag):
        Pass the sandbox extension handle along to performDragControllerAction.

        (WebKit::WebPageProxy::performDragControllerAction):
        Send along the sandbox extension handle.

        * WebProcess/WebCoreSupport/WebDragClient.cpp:
        (WebKit::WebDragClient::willPerformDragDestinationAction):
        If the destination action is a load action, call WebPage::willPerformLoadDragDestinationAction.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::performDragControllerAction):
        Create a sandbox extension.

        (WebKit::WebPage::willPerformLoadDragDestinationAction):
        If we have a sandbox extension, pass it along to the sandbox extension tracker.

        (WebKit::WebPage::SandboxExtensionTracker::willPerformLoadDragDestinationAction):
        Call setPendingProvisionalSandboxExtension.

        (WebKit::WebPage::SandboxExtensionTracker::beginLoad):
        Call setPendingProvisionalSandboxExtension.

        (WebKit::WebPage::SandboxExtensionTracker::setPendingProvisionalSandboxExtension):
        Factor code from beginLoad out into a separate function.

        * WebProcess/WebPage/WebPage.messages.in:
        PerformDragControllerAction now takes a sandbox extension handle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert "2011-04-08 Dirk Pranke <dpranke@chromium.org>"
jianli@chromium.org [Sat, 9 Apr 2011 00:02:34 +0000 (00:02 +0000)]
Revert "2011-04-08  Dirk Pranke  <dpranke@chromium.org>"

This reverts commit 78a47b96232b89bedf2e2c98794bbac8e19b905a.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-08 MORITA Hajime <morrita@google.com>
morrita@google.com [Sat, 9 Apr 2011 00:00:51 +0000 (00:00 +0000)]
2011-04-08  MORITA Hajime  <morrita@google.com>

        Reviewed by Simon Fraser.

        Negative spread should not make a sharp corner rounded
        https://bugs.webkit.org/show_bug.cgi?id=58162

        Updated the result. This new result matches other browsers behavior.

        * platform/mac/fast/box-shadow/inset-expected.checksum:
        * platform/mac/fast/box-shadow/inset-expected.png:
2011-04-08  MORITA Hajime  <morrita@google.com>

        Reviewed by Simon Fraser.

        Negative spread should not make a sharp corner rounded
        https://bugs.webkit.org/show_bug.cgi?id=58162

        Handled inset shadow path for rounded and non-rounded rect
        differently as normal shadow path is doing.

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintBoxShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 8 Apr 2011 23:54:45 +0000 (23:54 +0000)]
2011-04-07  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Martin Robinson.

        REGRESSION (r77034-r77220): CSS box-shadow no longer renders on PowerPC
        https://bugs.webkit.org/show_bug.cgi?id=55180

        The endianness #ifdef in ShadowBlur was unnecessary and harmful. The
        data we get back from ImageBuffer::getImageData() do not vary in
        endianness.

        * platform/graphics/ShadowBlur.cpp:
        (WebCore::ShadowBlur::blurLayerImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=58151
alice.liu@apple.com [Fri, 8 Apr 2011 23:51:03 +0000 (23:51 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=58151
Crash after closing a Webview, in WebKit!WebCore::WindowMessageBroadcaster::SubclassedWndProc

Reviewed by Adam Roben.

* UIProcess/win/WebView.cpp:
(WebKit::WebView::close):
Resolve a difference between old WebKit WebView and WebKit2 WebView by destroying and clearing
out WebKit2 WebView's HWND when closing. Not doing so was causing the WebView to remain in the
list of WindowMessageBroadcaster listeners, and after closing the WebView, WindowMessageBroadcaster
would message a dead WebView and crash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-08 Erik Arvidsson <arv@chromium.org>
arv@chromium.org [Fri, 8 Apr 2011 23:37:33 +0000 (23:37 +0000)]
2011-04-08  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Dimitri Glazkov.

        IFrame is getting the focus even though it is hidden
        https://bugs.webkit.org/show_bug.cgi?id=55861

        * fast/dom/hidden-iframe-no-focus-expected.txt: Added.
        * fast/dom/hidden-iframe-no-focus.html: Added.
2011-04-08  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Dimitri Glazkov.

        IFrame is getting the focus even though it is hidden
        https://bugs.webkit.org/show_bug.cgi?id=55861

        Test: fast/dom/hidden-iframe-no-focus.html

        * html/HTMLFrameOwnerElement.cpp:
        (WebCore::HTMLFrameOwnerElement::isKeyboardFocusable):
        * html/HTMLFrameOwnerElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-08 Jeff Timanus <twiz@chromium.org>
commit-queue@webkit.org [Fri, 8 Apr 2011 23:01:29 +0000 (23:01 +0000)]
2011-04-08  Jeff Timanus  <twiz@chromium.org>

        Reviewed by Kenneth Russell.

        Fall back to software rendering for Canvas2D when requesting a DrawingBuffer larger than supported by the GL environment.
        https://bugs.webkit.org/show_bug.cgi?id=57768

        * platform/chromium/test_expectations.txt:
2011-04-08  Jeff Timanus  <twiz@chromium.org>

        Reviewed by Kenneth Russell.

        Fall back to software rendering for Canvas2D when requesting a DrawingBuffer larger than supported by the GL environment.
        https://bugs.webkit.org/show_bug.cgi?id=57768

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
        (WebCore::CanvasRenderingContext2D::reset):
        * platform/graphics/gpu/DrawingBuffer.cpp:
        (WebCore::DrawingBuffer::reset):
        * platform/graphics/gpu/DrawingBuffer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-08 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 8 Apr 2011 23:00:32 +0000 (23:00 +0000)]
2011-04-08  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        Make the drag operations be different functions
        https://bugs.webkit.org/show_bug.cgi?id=58169

        Since we want performDrag to take a sandbox extension, separate the four
        drag operations out into different functions. No functionality change.

        * UIProcess/API/mac/WKView.mm:
        (-[WKView draggingEntered:]):
        (-[WKView draggingUpdated:]):
        (-[WKView draggingExited:]):
        (-[WKView performDragOperation:]):
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::dragEntered):
        (WebKit::WebPageProxy::dragUpdated):
        (WebKit::WebPageProxy::dragExited):
        (WebKit::WebPageProxy::performDrag):
        * UIProcess/WebPageProxy.h:
        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::DragEnter):
        (WebKit::WebView::DragOver):
        (WebKit::WebView::DragLeave):
        (WebKit::WebView::Drop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-08 Daniel Cheng <dcheng@chromium.org>
dcheng@chromium.org [Fri, 8 Apr 2011 22:59:33 +0000 (22:59 +0000)]
2011-04-08  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Dmitry Titov.

        [chromium] Implement image/png support in DataTransferItems
        https://bugs.webkit.org/show_bug.cgi?id=58106

        Add a reftest to verify that the various bits in the pipeline work as expected.

        * editing/pasteboard/data-transfer-items-image-png-expected.html: Added.
        * editing/pasteboard/data-transfer-items-image-png.html: Added.
2011-04-08  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Dmitry Titov.

        [chromium] Implement image/png support in DataTransferItems
        https://bugs.webkit.org/show_bug.cgi?id=58106

        This patch implements DataTransferItem::getAsFile() using Blobs. In
        addition, plumbing for image/png has been added so image paste will be
        supported as long as the renderer makes that data available.

        Tests: editing/pasteboard/data-transfer-items-image-png.html

        * dom/DataTransferItem.h:
        * dom/DataTransferItem.idl:
        * platform/chromium/ClipboardMimeTypes.cpp:
        * platform/chromium/ClipboardMimeTypes.h:
        * platform/chromium/DataTransferItemChromium.cpp:
        (WebCore::DataTransferItemChromium::getAsString):
        (WebCore::DataTransferItemChromium::getAsFile):
        * platform/chromium/DataTransferItemChromium.h:
        * platform/chromium/PlatformBridge.h:
2011-04-08  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Dmitry Titov.

        [chromium] Implement image/png support in DataTransferItems
        https://bugs.webkit.org/show_bug.cgi?id=58106

        Add glue for reading image data from clipboard.

        * DEPS:
        * src/PlatformBridge.cpp:
        (WebCore::PlatformBridge::clipboardReadImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-08 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 8 Apr 2011 22:42:20 +0000 (22:42 +0000)]
2011-04-08 MORITA Hajime  <morrita@google.com>

        Unreviewed windows build fix.

        * editing/SpellingCorrectionController.h:
        (WebCore::SpellingCorrectionController::UNLESS_ENABLED):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImprove lifetime management of nodes in ReplaceNodeWithSpanCommand.
enrica@apple.com [Fri, 8 Apr 2011 22:39:42 +0000 (22:39 +0000)]
Improve lifetime management of nodes in ReplaceNodeWithSpanCommand.
https://bugs.webkit.org/show_bug.cgi?id=57595
<rdar://problem/9222122>

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: editing/style/bold-with-dom-changes.html

* editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):

LayoutTests:

* editing/style/bold-with-dom-changes-expected.txt: Added.
* editing/style/bold-with-dom-changes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83351 268f45cc-cd09-0410-ab3c-d52691b4dbfc