WebKit-https.git
10 years ago2010-05-02 Joseph Pecoraro <joepeck@webkit.org>
eric@webkit.org [Sun, 2 May 2010 21:42:05 +0000 (21:42 +0000)]
2010-05-02  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Old Style trimWhitespace() should be trim()
        https://bugs.webkit.org/show_bug.cgi?id=38441

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-02 Tasuku Suzuki <tasuku.suzuki@nokia.com>
eric@webkit.org [Sun, 2 May 2010 21:31:27 +0000 (21:31 +0000)]
2010-05-02  Tasuku Suzuki  <tasuku.suzuki@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Fix compilation with QT_NO_LINEEDIT
        https://bugs.webkit.org/show_bug.cgi?id=38324

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::~RenderThemeQt):
        (WebCore::RenderThemeQt::findFrameLineWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-02 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sun, 2 May 2010 20:18:48 +0000 (20:18 +0000)]
2010-05-02  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: Touch inspector controller to kick windows tests.

        * inspector/InspectorController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-02 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sun, 2 May 2010 18:32:02 +0000 (18:32 +0000)]
2010-05-02  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: IMG nodes are being added to the DOM tree late, sometimes hiding the revealed element.

        https://bugs.webkit.org/show_bug.cgi?id=38432

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeOutline.prototype._onmousemove):
        (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
        (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
        (WebInspector.ElementsTreeElement.prototype.updateTitle):
        (WebInspector.ElementsTreeElement.prototype._attributeHTML):
        ():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-02 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sun, 2 May 2010 16:30:24 +0000 (16:30 +0000)]
2010-05-02  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG hkern implementation incomplete
        https://bugs.webkit.org/show_bug.cgi?id=38407

        Test: svg/text/text-hkern.svg

        The current SVG hkern implementation is incomplete and partly wrong. We pass the ACID3 test
        by accident.
        The new implementation supports all glyph and unicode combinations that are allowed by the Spec
        and fixes various of bugs. The parser moved from SVGFontElement to the general parsing code in
        SVGParserUtilities.
        Some clean-up makes the code more readable and reuseable for the upcoming vkern implementation.
        hkern support for text on path is missing and will be added by a following patch.
        Unicode strings of hkern elements are just parsed once and not on every glyph again anymore.

        * rendering/SVGRootInlineBox.cpp:
        (WebCore::calculateCSSKerning):
        (WebCore::applySVGKerning):
        (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
        * svg/SVGFontElement.cpp:
        (WebCore::stringMatchesUnicodeRange):
        (WebCore::stringMatchesGlyphName):
        (WebCore::matches):
        (WebCore::SVGFontElement::getHorizontalKerningPairForStringsAndGlyphs):
        * svg/SVGFontElement.h:
        * svg/SVGHKernElement.cpp:
        (WebCore::SVGHKernElement::buildHorizontalKerningPair):
        * svg/SVGHKernElement.h:
        * svg/SVGParserUtilities.cpp:
        (WebCore::parseGlyphName):
        (WebCore::parseUnicodeRange):
        (WebCore::parseKerningUnicodeString):
        * svg/SVGParserUtilities.h:
2010-05-02  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG hkern implementation incomplete
        https://bugs.webkit.org/show_bug.cgi?id=38407

        The hkern patch fixes some very old bugs in some tests of the official
        SVG Test suite. Added a new test to check correct behavior on different
        use cases of textin SVG.

        * platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
        * platform/mac/svg/text/kerning-expected.checksum:
        * platform/mac/svg/text/kerning-expected.png:
        * platform/mac/svg/text/text-hkern-expected.checksum: Added.
        * platform/mac/svg/text/text-hkern-expected.png: Added.
        * platform/mac/svg/text/text-hkern-expected.txt: Added.
        * svg/text/text-hkern.svg: Added.
2010-05-02  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG hkern implementation incomplete
        https://bugs.webkit.org/show_bug.cgi?id=38407

        We support hkern now. Mention this in the SVG status page.

        * projects/svg/status.xml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-02 Pavel Feldman <pfeldman@chromium.org>
eric@webkit.org [Sun, 2 May 2010 15:27:53 +0000 (15:27 +0000)]
2010-05-02  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: debugger shortcuts are processed twice if source frame has focus.

        https://bugs.webkit.org/show_bug.cgi?id=38431

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame):
        (WebInspector.SourceFrame.prototype._createViewerIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Build fix on Japanese Windows.
tkent@chromium.org [Sun, 2 May 2010 15:03:12 +0000 (15:03 +0000)]
Unreviewed. Build fix on Japanese Windows.
Replace a non-ASCII character in a comment with an ASCII character.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-02 Kartikaya Gupta <kagupta@rim.com>
eric@webkit.org [Sun, 2 May 2010 12:47:07 +0000 (12:47 +0000)]
2010-05-02  Kartikaya Gupta  <kagupta@rim.com>

        Reviewed by George Staikos.

        When running the IDL file through the preprocessor, wait for the preprocessor subcommand to fully terminate before continuing. Without this, if multiple IDL files are parsed in a tight loop, the code dies after 64 IDL files because it exhausts the available system resources.

        https://bugs.webkit.org/show_bug.cgi?id=37888

        No new tests. None needed.

        * bindings/scripts/IDLParser.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-02 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Sun, 2 May 2010 12:26:39 +0000 (12:26 +0000)]
2010-05-02  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        [Qt] Enable JIT for QtWebKit on Symbian
        https://bugs.webkit.org/show_bug.cgi?id=38339

        JIT on Symbian has been stable for quite some time, it
        is time to turn it on by default.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-02 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
eric@webkit.org [Sun, 2 May 2010 12:05:20 +0000 (12:05 +0000)]
2010-05-02  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>

        Reviewed by Eric Seidel.

        [Qt] Build error in GraphicsContext3DQt.cpp
        https://bugs.webkit.org/show_bug.cgi?id=38382

        Removed duplicate implementation of isGLES2Compliant from
        GraphicsContext3DQt.cpp. Removed deprecated API stuff for
        texImage2D/texSubImage2D.
        * platform/graphics/qt/GraphicsContext3DQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-02 Garret Kelly <gdk@chromium.org>
eric@webkit.org [Sun, 2 May 2010 11:54:17 +0000 (11:54 +0000)]
2010-05-02  Garret Kelly  <gdk@chromium.org>

        Reviewed by David Levin.

        Make the Touch RuntimeEnabledFeature disabled by default.
        https://bugs.webkit.org/show_bug.cgi?id=38392

        * bindings/generic/RuntimeEnabledFeatures.cpp: Disable the Touch feature by default.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Fix a build failure by r58647.
tkent@chromium.org [Sun, 2 May 2010 11:29:44 +0000 (11:29 +0000)]
Unreviewed.  Fix a build failure by r58647.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-02 Benjamin Poulain <benjamin.poulain@nokia.com>
eric@webkit.org [Sun, 2 May 2010 08:55:04 +0000 (08:55 +0000)]
2010-05-02  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] QWebPage::userAgentForUrl is terrible API
        https://bugs.webkit.org/show_bug.cgi?id=33875

        Simplify the creation of the user agent string to avoid some
        overhead for each loaded url.

        The static part of the user agent is cached so it only have
        to be made once.
        This creation has been made in order to simplify the code.

        The two variable: application name and current language are
        set dynamically when needed.
        The default locale is non longer created if the widget locale
        is used.

        * Api/qwebpage.cpp:
        (QWebPage::userAgentForUrl):
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::userAgentApplicationName):
        (tst_QWebPage::userAgentLocaleChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-02 Michael Nordman <michaeln@google.com>
eric@webkit.org [Sun, 2 May 2010 08:39:21 +0000 (08:39 +0000)]
2010-05-02  Michael Nordman  <michaeln@google.com>

        Reviewed by Dmitry Titov.

        Define two new ResourceRequestBase TargetTypes for worker and shared worker
        main resources. Use the new target types where appropiate. Add logic to marshal
        the target type specified by requests initiated on a background worker thread.

        https://bugs.webkit.org/show_bug.cgi?id=38295

        No new tests. This doesn't have script visible artifacts.

        * platform/network/ResourceRequestBase.cpp: marshal the values
        (WebCore::ResourceRequestBase::adopt):
        (WebCore::ResourceRequestBase::copyData):
        * platform/network/ResourceRequestBase.h:  define the types
        (WebCore::ResourceRequestBase::):
        * workers/DefaultSharedWorkerRepository.cpp: use TargetIsSharedWorker
        (WebCore::SharedWorkerScriptLoader::load):
        * workers/Worker.cpp: use TargetIsWorker
        (WebCore::Worker::Worker):
        * workers/WorkerContext.cpp: use TargetIsScript for importScripts
        (WebCore::WorkerContext::importScripts):
        * workers/WorkerScriptLoader.cpp: add a data member for the target type
        (WebCore::WorkerScriptLoader::WorkerScriptLoader):
        (WebCore::WorkerScriptLoader::createResourceRequest):
        * workers/WorkerScriptLoader.h:
2010-05-02  Michael Nordman  <michaeln@google.com>

        Reviewed by Dmitry Titov.

        Define two new ResourceRequestBase TargetTypes for worker and shared worker
        main resources. Use the new target types where appropiate. Add logic to marshal
        the target type specified by requests initiated on a background worker thread.

        https://bugs.webkit.org/show_bug.cgi?id=38295

        * src/SharedWorkerRepository.cpp:  use TargetIsSharedWorker
        (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-02 Marcus Bulach <bulach@chromium.org>
eric@webkit.org [Sun, 2 May 2010 08:12:47 +0000 (08:12 +0000)]
2010-05-02  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        [chromium] Upstream test expectations for:
        http/tests/loading/basic-auth-resend-wrong-credentials.html
        https://bugs.webkit.org/show_bug.cgi?id=38387

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-02 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Sun, 2 May 2010 08:01:33 +0000 (08:01 +0000)]
2010-05-02  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] GraphicsLayer: animation incorrect when scrolling
        https://bugs.webkit.org/show_bug.cgi?id=38371

        This is a regression introduced with the invalidate-on-scroll code path, that uses QGraphicsWebViewPrivate::update()
        instead of QGraphicsWebViewPrivate::scroll(). The patch makes sure that the scrolling position is correct on
        each content update - this shouldn't have a performance impact - the only overhead is an additional value-test on each update.

        Tested by http://www.the-art-of-web.com/css/css-animation/

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-02 Ben Murdoch <benm@google.com>
eric@webkit.org [Sun, 2 May 2010 07:50:41 +0000 (07:50 +0000)]
2010-05-02  Ben Murdoch  <benm@google.com>

        Reviewed by Darin Adler.

        fast/events/touch has non-standard script test wrappers
        https://bugs.webkit.org/show_bug.cgi?id=38084

        Tidy up the touch event layout tests. Make the script-tests TEMPLATE.html
        generate asynchronous style tests using js-test-post-function.js and move
        the non-standard synchronous test into the resources directory.

        * fast/events/touch/basic-multi-touch-events.html: Regenerate from TEMPLATE.html
        * fast/events/touch/basic-single-touch-events.html: ditto.
        * fast/events/touch/send-oncancel-event.html: ditto.
        * fast/events/touch/touch-target.html: ditto.
        * fast/events/touch/create-touch-event.html: Link to script in resources rather than
            script-tests as this test is not generated from TEMPLATE.html.
        * fast/events/touch/resources/create-touch-event.js: Copied from LayoutTests/fast/events/touch/script-tests/create-touch-event.js.
        * fast/events/touch/script-tests/TEMPLATE.html: Update to generate asynchronous tests.
        * fast/events/touch/script-tests/create-touch-event.js: Removed.
        * fast/events/touch/script-tests/touch-target.js: Refactor to work with new wrapper
            generated from TEMPLATE.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-02 Rafael Weinstein <rafaelw@chromium.org>
eric@webkit.org [Sun, 2 May 2010 07:23:16 +0000 (07:23 +0000)]
2010-05-02  Rafael Weinstein  <rafaelw@chromium.org>

        Reviewed by Darin Fisher.

        Include WebWindowFeatures in call to WebViewClient::createView.
        https://bugs.webkit.org/show_bug.cgi?id=38301

        * public/WebViewClient.h:
        (WebKit::WebViewClient::createView):
        * public/WebWindowFeatures.h:
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::createWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-02 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Sun, 2 May 2010 07:12:35 +0000 (07:12 +0000)]
2010-05-02  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Adele Peterson.

        Webkit doesn't compile with 3D-canvas enabled and video disabled
        https://bugs.webkit.org/show_bug.cgi?id=38297

        Added a #ifdef ENABLE(VIDEO) to WebGL code

        No new tests: compile fix.

        * bindings/js/JSWebGLRenderingContextCustom.cpp:
        (WebCore::JSWebGLRenderingContext::texImage2D):
        (WebCore::JSWebGLRenderingContext::texSubImage2D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-01 Evan Stade <estade@chromium.org>
eric@webkit.org [Sun, 2 May 2010 07:01:31 +0000 (07:01 +0000)]
2010-05-01  Evan Stade  <estade@chromium.org>

        Reviewed by David Levin.

        [chromium] Skia needs to fade DragImages
        https://bugs.webkit.org/show_bug.cgi?id=38008

        tested by DragImageTest

        * platform/chromium/DragImageChromiumSkia.cpp:
        (WebCore::dissolveDragImageToFraction):implement
        (WebCore::createDragImageFromImage):deep copy instead of shallow
2010-05-01  Evan Stade  <estade@chromium.org>

        Reviewed by David Levin

        [chromium] Skia needs to fade DragImages
        https://bugs.webkit.org/show_bug.cgi?id=38008

        * tests/DragImageTest.cpp:
        (DragImageTest.CreateDragImage): test that the drag image is a deep copy

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Not reviewed.
ap@apple.com [Sun, 2 May 2010 05:27:34 +0000 (05:27 +0000)]
    Not reviewed.

        More shortening of Sputnik paths.

        * fast/js/sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples: Copied from fast/js/sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples_of_Automatic_Semicolon_Insertion.
        * fast/js/sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples_of_Automatic_Semicolon_Insertion: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-01 James Robinson <jamesr@chromium.org>
eric@webkit.org [Sun, 2 May 2010 05:07:00 +0000 (05:07 +0000)]
2010-05-01  James Robinson  <jamesr@chromium.org>

        Reviewed by Eric Seidel.

        Add fast/repaint/fixed-move-after-keyboard-scroll.html to skipped list pending investigation
        https://bugs.webkit.org/show_bug.cgi?id=38416

        * platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Land test case that was supposed to be in r53607.
ddkilzer@apple.com [Sun, 2 May 2010 01:25:53 +0000 (01:25 +0000)]
    Land test case that was supposed to be in r53607.

    2010-01-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Stylesheet href property shows redirected URL unlike other browsers
        https://bugs.webkit.org/show_bug.cgi?id=33683

        Test whether the href property of style sheets contains the original or
        final URL of the redirect chain that lead to the style sheet.

        I couldn't figure out how to test the XSLStyleSheet parts of this
        change.  There didn't seem to be DOM bindings for the href property
        here.  If I missed it, please let me know.

        * http/tests/security/stylesheet-href-redirect-expected.txt: Added.
        * http/tests/security/stylesheet-href-redirect.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-01 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Sat, 1 May 2010 22:44:25 +0000 (22:44 +0000)]
2010-05-01  Daniel Bates  <dbates@rim.com>

        Reviewed by Chris Jerdonek.

        https://bugs.webkit.org/show_bug.cgi?id=38423

        Adds infrastructure to change the file mode of a file using
        the appropriate SCM-specific routines.

        No functionality was changed, so no new tests.

        * Scripts/VCSUtils.pm: Added subroutines scmToggleExecutableBit,
        scmAddExecutableBit, and scmRemoveExecutableBit.
        * Scripts/svn-apply: Check for the hash key executableBitDelta
        and toggle the executable bit.
        * Scripts/svn-unapply: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-01 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sat, 1 May 2010 20:23:35 +0000 (20:23 +0000)]
2010-05-01  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Sam Weinig.

        REGRESSION (r58273): Visited links do not change color immediately when Cmd-clicked
        https://bugs.webkit.org/show_bug.cgi?id=38422
        <rdar://problem/7921778>

        Tests:
            manual-tests/visited-link-new-window.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::initElement): Only cache the visited link state
        when invoked as part of a helper call to styleForElement or pseudoStyleForElement,
        to avoid caching the visited link state beyond the scope of a single style lookup.
        (WebCore::CSSStyleSelector::styleForElement): Adjust for above change.
        (WebCore::CSSStyleSelector::pseudoStyleForElement): Adjust for above change.
        * css/CSSStyleSelector.h:
        (WebCore::CSSStyleSelector::styleForElement): Change so "visited link helper mode"
        can't accidentally be called from outside CSSStyleSelector itself.
        (WebCore::CSSStyleSelector::pseudoStyleForElement): ditto
        * manual-tests/visited-link-new-window.html: Added. I could not figure out any way
        to make an automated test that supports visited link coloring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove number parsing code out of HTMLInputElement.
yael.aharon@nokia.com [Sat, 1 May 2010 12:06:35 +0000 (12:06 +0000)]
Move number parsing code out of HTMLInputElement.
https://bugs.webkit.org/show_bug.cgi?id=38203

Reviewed by Darin Adler.

The numebr parsing code follows HTML5 parsing rules and should be available outside of HTMLInputElement.
No new tests as no new functionality was introduced.

* html/HTMLInputElement.cpp:
* html/HTMLInputElement.h:
* html/HTMLParser.cpp:
* html/HTMLParser.h:
* html/StepRange.cpp:
* html/ValidityState.cpp:
* rendering/RenderSlider.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-01 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sat, 1 May 2010 10:42:04 +0000 (10:42 +0000)]
2010-05-01  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Oliver Hunt.

        [GTK] GObject DOM bindings
        https://bugs.webkit.org/show_bug.cgi?id=33590

        Test webkit_dom_document_get_links.

        * tests/testdomdocument.c:
        (test_dom_document_get_links):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-01 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sat, 1 May 2010 10:40:45 +0000 (10:40 +0000)]
2010-05-01  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Oliver Hunt.

        [GTK] GObject DOM bindings
        https://bugs.webkit.org/show_bug.cgi?id=33590

        Unify more logic to skip functions into SkipFunction, and
        whitelist the two [Custom] methods in HTMLCollection.idl.

        * bindings/scripts/CodeGeneratorGObject.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix up width/height differences in smart-paste-00* results
robert@webkit.org [Sat, 1 May 2010 10:20:06 +0000 (10:20 +0000)]
[Qt] Fix up width/height differences in smart-paste-00* results

        Unreviewed fix to height/width rendering differences in results added
        by r58631.

        [Qt] Fix up width/height differences in smart-paste-00* results

        https://bugs.webkit.org/show_bug.cgi?id=38136

        * platform/qt/editing/pasteboard/smart-paste-001-expected.txt:
        * platform/qt/editing/pasteboard/smart-paste-002-expected.txt:
        * platform/qt/editing/pasteboard/smart-paste-003-expected.txt:
        * platform/qt/editing/pasteboard/smart-paste-004-expected.txt:
        * platform/qt/editing/pasteboard/smart-paste-005-expected.txt:
        * platform/qt/editing/pasteboard/smart-paste-006-expected.txt:
        * platform/qt/editing/pasteboard/smart-paste-007-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Add smart paste support
robert@webkit.org [Sat, 1 May 2010 10:02:49 +0000 (10:02 +0000)]
[Qt] Add smart paste support
2010-05-01  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Add smart paste support

        https://bugs.webkit.org/show_bug.cgi?id=38136

        Add platform specific results.

        Unskip tests:
         editing/pasteboard/smart-paste-001.html
         editing/pasteboard/smart-paste-002.html
         editing/pasteboard/smart-paste-003.html
         editing/pasteboard/smart-paste-004.html
         editing/pasteboard/smart-paste-005.html
         editing/pasteboard/smart-paste-006.html
         editing/pasteboard/smart-paste-007.html

        * platform/qt/Skipped:
        * platform/qt/editing/pasteboard/smart-paste-001-expected.txt: Added.
        * platform/qt/editing/pasteboard/smart-paste-002-expected.txt: Added.
        * platform/qt/editing/pasteboard/smart-paste-003-expected.txt: Added.
        * platform/qt/editing/pasteboard/smart-paste-004-expected.txt: Added.
        * platform/qt/editing/pasteboard/smart-paste-005-expected.txt: Added.
        * platform/qt/editing/pasteboard/smart-paste-006-expected.txt:
        * platform/qt/editing/pasteboard/smart-paste-007-expected.txt: Added.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::QWebPagePrivate): Enable smart paste support by default.

        * WebCore.pro:
        * editing/qt/SmartReplaceQt.cpp: Added.
        (WebCore::isCharacterSmartReplaceExempt):
        * platform/qt/PasteboardQt.cpp:
        (WebCore::Pasteboard::writeSelection):
        (WebCore::Pasteboard::canSmartReplace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-30 Yoshiki Hayashi <yhayashi@google.com>
hamaji@chromium.org [Sat, 1 May 2010 07:07:03 +0000 (07:07 +0000)]
2010-04-30  Yoshiki Hayashi  <yhayashi@google.com>

        Reviewed by Shinichiro Hamaji.

        https://bugs.webkit.org/show_bug.cgi?id=38249

        Fixes an issue where border height and padding height are ignored when computing vertically shrinking flexbox's height.

        * fast/flexbox/child-flexing-expected.txt: Added.
        * fast/flexbox/child-flexing.html: Added.
2010-04-30  Yoshiki Hayashi  <yhayashi@google.com>

        Reviewed by Shinichiro Hamaji.

        https://bugs.webkit.org/show_bug.cgi?id=38249

        Fixes an issue where border height and padding height are ignored when computing vertically shrinking flexbox's height.

        Test: fast/flexbox/child-flexing.html

        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::allowedChildFlex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-30 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Sat, 1 May 2010 05:34:28 +0000 (05:34 +0000)]
2010-04-30  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        Add layoutTestController.setPrinting()
        https://bugs.webkit.org/show_bug.cgi?id=37203

        * platform/mac/Skipped:
        * platform/mac/printing/media-queries-print-expected.txt:
2010-04-30  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        Add layoutTestController.setPrinting()
        https://bugs.webkit.org/show_bug.cgi?id=37203

        Use the renderer's width insteead of screen's width as the width of
        a screen depends on machines.

        * rendering/RenderTreeAsText.cpp:
        (WebCore::externalRepresentation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-30 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sat, 1 May 2010 03:09:01 +0000 (03:09 +0000)]
2010-04-30  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Missing INSPECTOR Guard in Console::lastWMLErrorMessage
        https://bugs.webkit.org/show_bug.cgi?id=38366

        Console::lastWMLErrorMessage is only available if WML is enabled, however
        its implementation only makes sense as long as INSPECTOR is enabled
        as well. So this adds the ENABLE(INSPECTOR) guard in the function. A
        browser without ENABLE(INSPECTOR) will always get an empty result.

        * page/Console.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-28 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sat, 1 May 2010 02:54:08 +0000 (02:54 +0000)]
2010-04-28  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Oliver Hunt.

        <input type="search"> with uneven padding causes text clipping
        https://bugs.webkit.org/show_bug.cgi?id=38160

        * fast/css/input-search-padding.html: Added.
        * platform/mac/fast/css/input-search-padding-expected.checksum: Added.
        * platform/mac/fast/css/input-search-padding-expected.png: Added.
        * platform/mac/fast/css/input-search-padding-expected.txt: Added.

2010-04-28  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Oliver Hunt.

        <input type="search"> with uneven padding causes text clipping
        https://bugs.webkit.org/show_bug.cgi?id=38160

        Test: fast/css/input-search-padding.html

        An <input type="search"> contains an inner block, which is explicitly
        centered in RenderTextControlSingleLine based on the height of the element.
        However, the clipping rect was not using the set location, and instead
        calculated off of the top border and padding alone. This also vertically
        centers the Caps Lock indicator.

        * rendering/RenderTextControl.cpp: moved controlClipRect implementation to RenderTextControlSingleLine
        * rendering/RenderTextControl.h: allow a subclass implementation of controlClipRect, removed redundant hasControlClip implementation, and moved controlClipRect
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::paint): vertically center the Caps Lock indicator
        (WebCore::RenderTextControlSingleLine::controlClipRect): use the set location of the anonymous inner block instead
        * rendering/RenderTextControlSingleLine.h: allow for an implementation of controlClipRect for <input type="search">

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the build.
weinig@apple.com [Sat, 1 May 2010 01:01:06 +0000 (01:01 +0000)]
Fix the build.

* Platform/CoreIPC/mac/ConnectionMac.cpp: Add missing #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCaret may fail to blink if a focus handler brings up a modal dialog
jhoneycutt@apple.com [Sat, 1 May 2010 00:49:01 +0000 (00:49 +0000)]
Caret may fail to blink if a focus handler brings up a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=38372

Reviewed by Darin Adler.

WebCore:

* manual-tests/onfocus-alert-blinking-caret.html: Added.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
Moved the call to setCaretBlinkingSuspended() from here...
(WebCore::EventHandler::handleMousePressEvent):
... to here. This makes us suspend caret blinking before dispatching the
mouse down event. If dispatching the mouse down event allows the message
loop to run, we want mouse up events received in that message loop to be
able to resume caret blinking.
(WebCore::EventHandler::lostMouseCapture):
We've lost mouse capture and won't be notified of mouse up events;
resume caret blinking.

* page/EventHandler.h:
Declare lostMouseCapture().

WebKit/win:

* WebView.cpp:
(WebView::handleMouseEvent):
If the message is WM_CANCELMODE, which indicates that we our capturing
of mouse events has been cancelled, tell the EventHandler.
It's possible to re-enter this function if handling a mouse event allows
the message loop to run; moved up the call to setMouseActivated(), so
that if we do re-enter this function, the later mouse event will not be
considered as activating the window.
(WebView::WebViewWndProc):
Handle WM_CANCELMODE by calling handleMouseEvent().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=38413
weinig@apple.com [Sat, 1 May 2010 00:22:24 +0000 (00:22 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=38413
Add callback based API to get the textual representation of the RenderTree.

Reviewed by Anders Carlsson.

- Also ensures that any pending callbacks are invalidated if the WebPage
  closes (expectedly or unexpectedly).
- A follow up patch will unify the callback mechanism with a common base
  class.

* Shared/CoreIPCSupport/WebPageMessageKinds.h:
(WebPageMessage::):
* Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
(WebPageProxyMessage::):
* UIProcess/API/C/WKPage.cpp:
(WKPageRunJavaScriptInMainFrame_f):
(WKPageRenderTreeExternalRepresentation_f):
(callRenderTreeExternalRepresentationBlockAndDispose):
(disposeRenderTreeExternalRepresentationBlock):
(WKPageRenderTreeExternalRepresentation):
* UIProcess/API/C/WKPagePrivate.h: Added.
* UIProcess/RenderTreeExternalRepresentationCallback.cpp: Added.
(WebKit::generateCallbackID):
(WebKit::RenderTreeExternalRepresentationCallback::RenderTreeExternalRepresentationCallback):
(WebKit::RenderTreeExternalRepresentationCallback::~RenderTreeExternalRepresentationCallback):
(WebKit::RenderTreeExternalRepresentationCallback::performCallbackWithReturnValue):
(WebKit::RenderTreeExternalRepresentationCallback::invalidate):
* UIProcess/RenderTreeExternalRepresentationCallback.h: Added.
(WebKit::RenderTreeExternalRepresentationCallback::create):
(WebKit::RenderTreeExternalRepresentationCallback::callbackID):
* UIProcess/ScriptReturnValueCallback.cpp:
(WebKit::ScriptReturnValueCallback::~ScriptReturnValueCallback):
(WebKit::ScriptReturnValueCallback::performCallbackWithReturnValue):
(WebKit::ScriptReturnValueCallback::invalidate):
* UIProcess/ScriptReturnValueCallback.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::getRenderTreeExternalRepresentation):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didRunJavaScriptInMainFrame):
(WebKit::WebPageProxy::didGetRenderTreeExternalRepresentation):
(WebKit::WebPageProxy::processDidExit):
* UIProcess/WebPageProxy.h:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getRenderTreeExternalRepresentation):
(WebKit::WebPage::didReceiveMessage):
* WebProcess/WebPage/WebPage.h:
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-30 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 30 Apr 2010 23:54:24 +0000 (23:54 +0000)]
2010-04-30  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/7477071> REGRESSION: Bad flicker when wheel-scrolling Google Maps, iPad gallery and other sites

        Sites that frequently toggle content in and out of compositing layers (like http://www.tumblr.com/boothed)
        can cause flickering because of unsychronized compositing layer and view-based updates. There were two
        underlying issues:

        1. On SnowLeopard, AppKit can throttle window updates, thus breaking an assumption that
           NSView drawing will happen on the runloop cycle after a repaint. This provided a window
           for the layerSyncRunLoopObserver to fire and commit layer changes too early.

           Fix this by having the layerSyncRunLoopObserver in WebView check to see if a display is pending,
           and not commit layer changes in that case. We'll commit layer changes later when we
           finally draw.

        2. The change in r49269 was wrong; it was attempting to fix an issue that was actually caused
           by -drawRects: coming in for page snapshots. The correct approach is to avoid hitting the
           synchronization and update disabling code in WebHTMLView for draws that are not to the screen.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView drawRect:]):
        * WebView/WebView.mm:
        (layerSyncRunLoopObserverCallBack):
        (-[WebView _scheduleCompositingLayerSync]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Enabled accelerated compositing in DRT for Windows
cmarrin@apple.com [Fri, 30 Apr 2010 23:42:04 +0000 (23:42 +0000)]
    Enabled accelerated compositing in DRT for Windows
        https://bugs.webkit.org/show_bug.cgi?id=38404

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, build fix.
dglazkov@chromium.org [Fri, 30 Apr 2010 23:30:31 +0000 (23:30 +0000)]
Unreviewed, build fix.

[Chromium] Added a simple IdentifierRep struct and removed dependency on
IdentifierRep.h.

* bindings/v8/V8NPObject.cpp: Added simple IdentifierRep struct.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, expectations update.
dglazkov@chromium.org [Fri, 30 Apr 2010 23:30:24 +0000 (23:30 +0000)]
Unreviewed, expectations update.

[Chromium] More missing pixel test results.

* platform/chromium-mac/fast/borders/svg-as-border-image-2-expected.checksum: Added.
* platform/chromium-mac/fast/borders/svg-as-border-image-expected.checksum: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-30 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 30 Apr 2010 23:25:38 +0000 (23:25 +0000)]
2010-04-30  James Robinson  <jamesr@chromium.org>

        Unreviewed. Add Chromium expectations for a bunch of repaint tests that we now pass (yay!)

        * platform/chromium-linux/fast/repaint/fixed-child-move-after-scroll-expected.checksum: Added.
        * platform/chromium-linux/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
        * platform/chromium-linux/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.checksum: Added.
        * platform/chromium-linux/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
        * platform/chromium-linux/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.checksum: Added.
        * platform/chromium-linux/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
        * platform/chromium-linux/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum: Added.
        * platform/chromium-linux/fast/repaint/fixed-move-after-keyboard-scroll-expected.png: Added.
        * platform/chromium-linux/fast/repaint/fixed-move-after-scroll-expected.checksum: Added.
        * platform/chromium-linux/fast/repaint/fixed-move-after-scroll-expected.png: Added.
        * platform/chromium-mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.png: Added.
        * platform/chromium-win/fast/repaint/fixed-child-move-after-scroll-expected.checksum: Added.
        * platform/chromium-win/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
        * platform/chromium-win/fast/repaint/fixed-child-move-after-scroll-expected.txt: Added.
        * platform/chromium-win/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.checksum: Added.
        * platform/chromium-win/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
        * platform/chromium-win/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt: Added.
        * platform/chromium-win/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.checksum: Added.
        * platform/chromium-win/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
        * platform/chromium-win/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt: Added.
        * platform/chromium-win/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum: Added.
        * platform/chromium-win/fast/repaint/fixed-move-after-keyboard-scroll-expected.png: Added.
        * platform/chromium-win/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt: Added.
        * platform/chromium-win/fast/repaint/fixed-move-after-scroll-expected.checksum: Added.
        * platform/chromium-win/fast/repaint/fixed-move-after-scroll-expected.png: Added.
        * platform/chromium-win/fast/repaint/fixed-move-after-scroll-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=38406
weinig@apple.com [Fri, 30 Apr 2010 23:06:45 +0000 (23:06 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=38406
Add support for sending messages with a size greater than 4096 bytes

Reviewed by Anders Carlsson.

Adds support by putting message bodies that are larger than 4096 bytes
in OOL memory.

* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::sendSyncMessage):
(CoreIPC::Connection::dispatchMessages):
* Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::OutgoingMessage::OutgoingMessage):
(CoreIPC::Connection::OutgoingMessage::messageID):
(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):
* Platform/CoreIPC/MessageID.h:
(CoreIPC::MessageID::):
(CoreIPC::MessageID::MessageID):
(CoreIPC::MessageID::equalIgnoringFlags):
(CoreIPC::MessageID::copyAddingFlags):
(CoreIPC::MessageID::fromInt):
(CoreIPC::MessageID::toInt):
(CoreIPC::MessageID::isMessageBodyOOL):
* Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::sendOutgoingMessage):
(CoreIPC::createArgumentDecoder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, build fix.
dglazkov@chromium.org [Fri, 30 Apr 2010 23:00:48 +0000 (23:00 +0000)]
Unreviewed, build fix.

[Chromium] Remove bridge/ from include paths.

* WebCore.gyp/WebCore.gyp: Removed bridge/ from include path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Convert m_documentUnderMouse, m_dragInitiator to RefPtr.
ddkilzer@apple.com [Fri, 30 Apr 2010 22:54:03 +0000 (22:54 +0000)]
WebCore: Convert m_documentUnderMouse, m_dragInitiator to RefPtr.
Eliminated unused m_dragInitiator accessor to prevent dereferencing.
https://bugs.webkit.org/show_bug.cgi?id=37618

Patch by Abhishek Arya <inferno@chromium.org> on 2010-04-30
Reviewed by David Kilzer.

Test: editing/pasteboard/drag-drop-iframe-refresh-crash.html

* page/DragController.cpp:
(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::concludeEditDrag):
* page/DragController.h:
(WebCore::DragController::draggingImageURL):
(WebCore::DragController::documentUnderMouse):

LayoutTests: Tests for a crash when an image drag-drop operation happens inside a continuously refreshing iframe.
https://bugs.webkit.org/show_bug.cgi?id=37618

Patch by Abhishek Arya <inferno@chromium.org> on 2010-04-30
Reviewed by David Kilzer.

* editing/pasteboard/drag-drop-iframe-refresh-crash-expected.txt: Added.
* editing/pasteboard/drag-drop-iframe-refresh-crash.html: Added.
* editing/resources/drag-drop.html: Added.
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 30 Apr 2010 22:26:31 +0000 (22:26 +0000)]
2010-04-29  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        Calls FrameView::scrollPositionChanged whenever a ScrollView is scrolled
        https://bugs.webkit.org/show_bug.cgi?id=38286

        When a ScrollView's  scroll position is changed, we have to call
        FrameView::scrollPositionChanged to generate repaint invalidation for
        fixed position elements.  This ends up getting called indirectly when
        the ScrollView has a platformWidget through the port layer
        (see WebHTMLView.mm's _frameOrBoundsChanged method for how the mac
        port does it) but not when there is no platformWidget.

        This is tested by the fast/repaint/fixed-* tests when run in pixel
        mode.

        Test: fast/repaint/fixed-move-after-keyboard-scroll.html

        * page/FrameView.h:
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::valueChanged):
        * platform/ScrollView.h:
        (WebCore::ScrollView::scrollPositionChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPart of the previous part (forgot to save).
andersca@apple.com [Fri, 30 Apr 2010 22:22:44 +0000 (22:22 +0000)]
Part of the previous part (forgot to save).

* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView stopTimers]):
(-[WebNetscapePluginView startTimers]):
(-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]):
(-[WebNetscapePluginView _containerCheckResult:contextInfo:]):
(-[WebNetscapePluginView cancelCheckIfAllowedToLoadURL:]):
(-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
(-[WebNetscapePluginView unscheduleTimer:]):
(-[WebNetscapePluginView getVariable:forURL:value:length:]):
(-[WebNetscapePluginView setVariable:forURL:value:length:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse C99 integer types in more places.
andersca@apple.com [Fri, 30 Apr 2010 22:20:29 +0000 (22:20 +0000)]
Use C99 integer types in more places.

Reviewed by Darin Adler.

WebCore:

* manual-tests/NPN_Invoke/main.c:
(NPP_New):
(NPP_NewStream):
(NPP_WriteReady):
(NPP_Write):
(NPP_HandleEvent):
(functionPointerForTVector):
* plugins/mac/PluginViewMac.cpp:
(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::handlePostReadFile):

WebKit/mac:

* Plugins/WebNetscapePluginView.mm:
(getNPRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, expectations update.
dglazkov@chromium.org [Fri, 30 Apr 2010 22:18:19 +0000 (22:18 +0000)]
Unreviewed, expectations update.

[Chromium] Add more missing pixel results.

* platform/chromium-win/transforms/svg-vs-css-expected.checksum: Added.
* platform/chromium-win/transforms/svg-vs-css-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-30 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 30 Apr 2010 22:03:14 +0000 (22:03 +0000)]
2010-04-30  Darin Adler  <darin@apple.com>

        Reviewed by Oliver Hunt.

        Remove unused scrollRectIntoViewRecursively function
        https://bugs.webkit.org/show_bug.cgi?id=38403

        * page/Chrome.cpp:
        (WebCore::Chrome::scrollRectIntoView): Moved comment here that was previously
        in the scrollRectIntoViewRecursively function.

        * platform/ScrollView.cpp: Get rid scrollRectIntoViewRecursively.
        * platform/ScrollView.h: Ditto. Fix comment that refers to the two functions.
        Also correct all uses of the term "method" to use the C++ term "function" and
        got rid of double spaces after periods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Tiger build.
andersca@apple.com [Fri, 30 Apr 2010 21:59:13 +0000 (21:59 +0000)]
Fix Tiger build.

* Plugins/WebBaseNetscapePluginStream.h:
* Plugins/WebBaseNetscapePluginStream.mm:
(WebNetscapePluginStream::startStream):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAnother Qt build fix.
andersca@apple.com [Fri, 30 Apr 2010 21:42:18 +0000 (21:42 +0000)]
Another Qt build fix.

* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::platformGetValueStatic):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAnother 32-bit build fix.
andersca@apple.com [Fri, 30 Apr 2010 21:35:50 +0000 (21:35 +0000)]
Another 32-bit build fix.

* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, expectations updated.
dglazkov@chromium.org [Fri, 30 Apr 2010 21:34:16 +0000 (21:34 +0000)]
Unreviewed, expectations updated.

[Chromium] Add missing pixel results.

* platform/chromium-linux/fast/borders/svg-as-border-image-2-expected.checksum: Added.
* platform/chromium-linux/fast/borders/svg-as-border-image-expected.checksum: Added.
* platform/chromium-linux/transforms/svg-vs-css-expected.checksum: Added.
* platform/chromium-linux/transforms/svg-vs-css-expected.png: Added.
* platform/chromium-mac/svg/custom/mask-changes-expected.checksum: Added.
* platform/chromium-mac/svg/custom/mask-changes-expected.png: Added.
* platform/chromium-mac/transforms/svg-vs-css-expected.checksum: Added.
* platform/chromium-win/fast/borders/svg-as-border-image-2-expected.checksum: Added.
* platform/chromium-win/fast/borders/svg-as-border-image-2-expected.png: Added.
* platform/chromium-win/fast/borders/svg-as-border-image-expected.checksum: Added.
* platform/chromium-win/fast/borders/svg-as-border-image-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix GTK+ build.
andersca@apple.com [Fri, 30 Apr 2010 21:23:59 +0000 (21:23 +0000)]
Try to fix GTK+ build.

* DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
(webkit_test_plugin_new_stream):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd back TRUE, FALSE and NULL macros. They were not meant to be removed!
andersca@apple.com [Fri, 30 Apr 2010 21:13:22 +0000 (21:13 +0000)]
Add back TRUE, FALSE and NULL macros. They were not meant to be removed!

* bridge/npapi.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/38364> MIME typo in LayoutTests/http/tests/security/xss-DENIED...
ddkilzer@apple.com [Fri, 30 Apr 2010 21:04:49 +0000 (21:04 +0000)]
<webkit.org/b/38364> MIME typo in LayoutTests/http/tests/security/xss-DENIED-mime-type-execute-as-html.html

Reviewed by NOBODY (OOPS!).

* http/tests/security/xss-DENIED-mime-type-execute-as-html.html:
Fixed MIME typo from "application-javascript" to
"application/javascript".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix the Qt build this time.
andersca@apple.com [Fri, 30 Apr 2010 21:04:46 +0000 (21:04 +0000)]
Try to fix the Qt build this time.

* plugins/qt/PluginPackageQt.cpp:
(WebCore::staticPluginQuirkRequiresGtkToolKit_NPN_GetValue):
(WebCore::PluginPackage::NPVersion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoYet another build fix.
andersca@apple.com [Fri, 30 Apr 2010 21:03:36 +0000 (21:03 +0000)]
Yet another build fix.

* plugins/gtk/PluginPackageGtk.cpp:
(WebCore::PluginPackage::NPVersion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix 32-bit build (again).
andersca@apple.com [Fri, 30 Apr 2010 21:02:14 +0000 (21:02 +0000)]
Fix 32-bit build (again).

* Plugins/WebNetscapeContainerCheckContextInfo.h:
* Plugins/WebNetscapeContainerCheckContextInfo.mm:
(-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]):
(-[WebNetscapeContainerCheckContextInfo checkRequestID]):
(-[WebNetscapeContainerCheckContextInfo callback]):
* Plugins/WebNetscapePluginPackage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix build.
andersca@apple.com [Fri, 30 Apr 2010 20:55:18 +0000 (20:55 +0000)]
Fix build.

* bridge/npapi.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Add WebFileSystem interface and hook up with all FileSystem methods.
jianli@chromium.org [Fri, 30 Apr 2010 20:50:52 +0000 (20:50 +0000)]
[chromium] Add WebFileSystem interface and hook up with all FileSystem methods.
https://bugs.webkit.org/show_bug.cgi?id=38228

Reviewed by Darin Fisher.

WebCore:

* platform/chromium/ChromiumBridge.h:
* platform/chromium/FileSystemChromium.cpp:
(WebCore::openFile):
(WebCore::closeFile):
(WebCore::seekFile):
(WebCore::truncateFile):
(WebCore::readFromFile):
(WebCore::writeToFile):

WebKit/chromium:

* WebKit.gyp:
* public/WebFileSystem.h: Added.
* public/WebKitClient.h:
(WebKit::WebKitClient::fileSystem):
* src/ChromiumBridge.cpp:
(WebCore::ChromiumBridge::fileExists):
(WebCore::ChromiumBridge::deleteFile):
(WebCore::ChromiumBridge::deleteEmptyDirectory):
(WebCore::ChromiumBridge::getFileSize):
(WebCore::ChromiumBridge::getFileModificationTime):
(WebCore::ChromiumBridge::directoryName):
(WebCore::ChromiumBridge::pathByAppendingComponent):
(WebCore::ChromiumBridge::makeAllDirectories):
(WebCore::ChromiumBridge::getAbsolutePath):
(WebCore::ChromiumBridge::isDirectory):
(WebCore::ChromiumBridge::filePathToURL):
(WebCore::ChromiumBridge::openFile):
(WebCore::ChromiumBridge::closeFile):
(WebCore::ChromiumBridge::seekFile):
(WebCore::ChromiumBridge::truncateFile):
(WebCore::ChromiumBridge::readFromFile):
(WebCore::ChromiumBridge::writeToFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 30 Apr 2010 20:49:10 +0000 (20:49 +0000)]
2010-04-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Final part of

        https://bugs.webkit.org/show_bug.cgi?id=20784
        move npapi.h to C99 integer types

        * bridge/npapi.h:
        Remove the old types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-30 Sheriff Bot <webkit.review.bot@gmail.com>
eric@webkit.org [Fri, 30 Apr 2010 20:25:27 +0000 (20:25 +0000)]
2010-04-30  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r58569.
        http://trac.webkit.org/changeset/58569
        https://bugs.webkit.org/show_bug.cgi?id=38399

        This broke the GTK bots due to bad GC behavior (Requested by
        ericu on #webkit).

        * fast/workers/change-version-handle-reuse-worker-expected.txt: Removed.
        * fast/workers/change-version-handle-reuse-worker.html: Removed.
        * fast/workers/execute-sql-args-worker-expected.txt: Removed.
        * fast/workers/execute-sql-args-worker.html: Removed.
        * fast/workers/resources/database-worker-controller.js: Removed.
        * fast/workers/resources/database-worker.js: Removed.
        * storage/change-version-handle-reuse-expected.txt:
        * storage/change-version-handle-reuse.html:
        * storage/change-version-handle-reuse.js: Removed.
        * storage/execute-sql-args.html:
        * storage/execute-sql-args.js: Removed.
2010-04-30  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r58569.
        http://trac.webkit.org/changeset/58569
        https://bugs.webkit.org/show_bug.cgi?id=38399

        This broke the GTK bots due to bad GC behavior (Requested by
        ericu on #webkit).

        * bindings/js/JSWorkerContextCustom.cpp:
        * bindings/v8/custom/V8WorkerContextCustom.cpp:
        * storage/Database.idl:
        * storage/SQLError.idl:
        * storage/SQLResultSet.idl:
        * storage/SQLResultSetRowList.idl:
        * storage/SQLTransaction.idl:
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::openDatabase):
        * workers/WorkerContext.h:
        (WebCore::WorkerContext::databaseExceededQuota):
        * workers/WorkerContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix 32-bit build.
andersca@apple.com [Fri, 30 Apr 2010 20:11:30 +0000 (20:11 +0000)]
Fix 32-bit build.

* Plugins/WebNetscapeContainerCheckContextInfo.h:
* Plugins/WebNetscapeContainerCheckContextInfo.mm:
(-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]):
* Plugins/WebNetscapeContainerCheckPrivate.h:
* Plugins/WebNetscapePluginPackage.mm:
(functionPointerForTVector):
* Plugins/WebNetscapePluginView.mm:
(PluginTimer::PluginTimer):
(-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]):
(-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-30 Yaar Schnitman <yaar@chromium.org>
yaar@chromium.org [Fri, 30 Apr 2010 19:36:40 +0000 (19:36 +0000)]
2010-04-30  Yaar Schnitman  <yaar@chromium.org>

        Not Reviewed.

        Updating expectations for svg-as-border-*
        https://bugs.webkit.org/show_bug.cgi?id=38398

        * platform/chromium-win/fast/borders/svg-as-border-image-2-expected.txt: Added.
        * platform/chromium-win/fast/borders/svg-as-border-image-expected.txt: Added.
        * platform/chromium-win/transforms/svg-vs-css-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Not reviewed.
ap@apple.com [Fri, 30 Apr 2010 19:25:59 +0000 (19:25 +0000)]
    Not reviewed.

        * platform/mac-tiger/Skipped: Added two tests that fail on buidbot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix GTK+ build.
andersca@apple.com [Fri, 30 Apr 2010 19:25:03 +0000 (19:25 +0000)]
Fix GTK+ build.

* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::handlePostReadFile):
(WebCore::PluginView::platformGetValueStatic):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix build.
andersca@apple.com [Fri, 30 Apr 2010 19:23:48 +0000 (19:23 +0000)]
Fix build.

* DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Qt build.
andersca@apple.com [Fri, 30 Apr 2010 19:18:03 +0000 (19:18 +0000)]
Fix Qt build.

* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::handlePostReadFile):
(WebCore::PluginView::platformGetValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 30 Apr 2010 19:17:03 +0000 (19:17 +0000)]
2010-04-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Timothy Hatcher.

        Next step towards fixing

        https://bugs.webkit.org/show_bug.cgi?id=20784
        move npapi.h to C99 integer types

        Use the C99 types everywhere. The "old" types are still around but will be removed
        in a subsequent commit.

        * Plugins/WebBaseNetscapePluginStream.h:
        * Plugins/WebBaseNetscapePluginStream.mm:
        (WebNetscapePluginStream::deliverData):
        * Plugins/WebNetscapePluginView.h:
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
        (-[WebNetscapePluginView getAuthenticationInfoWithProtocol:host:port:scheme:realm:username:usernameLength:password:passwordLength:]):
        * Plugins/npapi.mm:
        (NPN_MemAlloc):
        (NPN_MemFlush):
        (NPN_PostURLNotify):
        (NPN_PostURL):
        (NPN_Write):
        (NPN_ScheduleTimer):
        (NPN_UnscheduleTimer):
        (NPN_GetValueForURL):
        (NPN_SetValueForURL):
        (NPN_GetAuthenticationInfo):
        (WKN_CheckIfAllowedToLoadURL):
        (WKN_CancelCheckIfAllowedToLoadURL):
2010-04-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Timothy Hatcher.

        Next step towards fixing

        https://bugs.webkit.org/show_bug.cgi?id=20784
        move npapi.h to C99 integer types

        Use the C99 types everywhere. The "old" types are still around but will be removed
        in a subsequent commit.

        * bridge/npapi.h:
        (_NPCocoaEvent::):
        * plugins/PluginPackage.h:
        * plugins/PluginStream.cpp:
        (WebCore::PluginStream::deliverData):
        * plugins/PluginStream.h:
        * plugins/PluginView.cpp:
        (WebCore::PluginView::postURLNotify):
        (WebCore::PluginView::postURL):
        (WebCore::PluginView::write):
        (WebCore::PluginView::handlePost):
        * plugins/PluginView.h:
        * plugins/PluginViewNone.cpp:
        (WebCore::PluginView::handlePostReadFile):
        * plugins/npapi.cpp:
        (NPN_MemAlloc):
        (NPN_MemFlush):
        (NPN_PostURLNotify):
        (NPN_PostURL):
        (NPN_Write):
        * plugins/npfunctions.h:
        * plugins/win/PluginPackageWin.cpp:
        (WebCore::PluginPackage::NPVersion):
        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginView::handlePostReadFile):
2010-04-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Timothy Hatcher.

        Next step towards fixing

        https://bugs.webkit.org/show_bug.cgi?id=20784
        move npapi.h to C99 integer types

        Use the C99 types everywhere. The "old" types are still around but will be removed
        in a subsequent commit.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
        (int32VariantToIdentifier):
        (doubleVariantToIdentifier):
        (testIdentifierToInt):
        (testGetIntIdentifier):
        * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
        (NPP_New):
        (NPP_NewStream):
        (NPP_WriteReady):
        (NPP_Write):
        (NPP_HandleEvent):
        * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
        (NPP_New):
        (NPP_NewStream):
        (NPP_WriteReady):
        (NPP_Write):
        (NPP_HandleEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake all image decoders set the "failed" bit if an image could not be
pkasting@chromium.org [Fri, 30 Apr 2010 19:00:07 +0000 (19:00 +0000)]
Make all image decoders set the "failed" bit if an image could not be
completely decoded, but no more data is coming.  The ICO and BMP
decoders already did this.
https://bugs.webkit.org/show_bug.cgi?id=35411

Reviewed by David Levin.

"Failed" does not cause the image to not be displayed, it simply causes
us to not bother to try to decode again if future requests are made, and
for some decoders, lets the decoder clean up some of its temporary
objects.

No layout tests because this does not change the visible output of decoding in any way.

* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::frameComplete): Return whether the frame could be marked as complete.
(WebCore::GIFImageDecoder::decode): Fail if read() needs more data (and thus returns false) and no more is coming.
* platform/image-decoders/gif/GIFImageDecoder.h:
* platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::do_lzw): Instead of returning true for buffer underrun and false for failure, return false for both and set the failure flag on failure.
(GIFImageReader::read): Ditto.
* platform/image-decoders/gif/GIFImageReader.h:
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::):
(WebCore::JPEGImageReader::decode): See do_lzw() comment above.
(WebCore::JPEGImageDecoder::decode): Fail if decode() needs more data (and thus returns false) and no more is coming.
* platform/image-decoders/jpeg/JPEGImageDecoder.h:
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageReader::decode): Return true for decode success, false for buffer underrun or decode failure, and set the failure flag on decode failure.
(WebCore::PNGImageDecoder::decode): See JPEGImageDecoder::decode() comment above.
* platform/image-decoders/png/PNGImageDecoder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] fast/frames/flattening/frameset-flattening-subframesets.html fails intermittentl...
ossy@webkit.org [Fri, 30 Apr 2010 18:39:31 +0000 (18:39 +0000)]
[Qt] fast/frames/flattening/frameset-flattening-subframesets.html fails intermittently on Qt bot
https://bugs.webkit.org/show_bug.cgi?id=37334

* platform/qt/Skipped: fast/frames/flattening/frameset-flattening-subframesets.html skipped until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Not reviewed.
ap@apple.com [Fri, 30 Apr 2010 18:33:24 +0000 (18:33 +0000)]
    Not reviewed.

        Enable Sputnik tests on Tiger.

        * platform/mac-tiger/Skipped: Only skip tests that fail for me on Tiger/PPC, and Unicode tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7902467> - Audio plays upon loading of npr.org but shouldn't
beidson@apple.com [Fri, 30 Apr 2010 18:24:17 +0000 (18:24 +0000)]
<rdar://problem/7902467> - Audio plays upon loading of npr.org but shouldn't

Reviewed by Eric Carlson.

No new tests. (Currently no way to test such site specific hack behavior)

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::asyncEventTimerFired): If the event to be dispatched is the canplay
  event, wrap the dispatch with m_dispatchingCanPlayEvent set.
(WebCore::HTMLMediaElement::play): If m_dispatchingCanPlayEvent is true and the site is npr.org,
  don't perform the play().
* html/HTMLMediaElement.h: Add m_dispatchingCanPlayEvent member.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Part of <rdar://problem/6649734> Text repainting does not account for glyphs...
mitz@apple.com [Fri, 30 Apr 2010 17:50:39 +0000 (17:50 +0000)]
WebCore: Part of <rdar://problem/6649734> Text repainting does not account for glyphs which draw outside the typographic bounds of the font
https://bugs.webkit.org/show_bug.cgi?id=6274

Reviewed by Adele Peterson.

Account for glyph overflow of characters in the range U+1E00..U+2000, but without sending them
through the complex text code path. Instead, introduce a variant of the fast path that tracks
glyph overflow.

* platform/graphics/Font.cpp:
(WebCore::Font::drawText): Use codePath().
(WebCore::Font::floatWidth): Use codePath(). Pass the GlyphOverflow pointer through to
floatWidthForSimpleText() if the code path is SimpleWithGlyphOverflow.
(WebCore::Font::selectionRectForText): Use codePath().
(WebCore::Font::offsetForPosition): Ditto.
* platform/graphics/Font.h: Replaced canUseGlyphCache() with codePath(). Added a GlyphOverflow
parameter to floatWidthForSimpleText().
* platform/graphics/FontFastPath.cpp:
Removed ROMAN_AND_GREEK_DIACRITICS_CAN_USE_GLYPH_CACHE.
(WebCore::Font::codePath): Renamed canUseGlyphCache() to this. Where it used to return false,
it now returns Complex. Where it used to return true, it now returns Simple, except for
the range U+1E00..U+2000, where it now returns SimpleWithGlyphOverflow.
(WebCore::Font::floatWidthForSimpleText): Added a GlyphOverflow parameter. If not 0, have the
width iterator account for glyph bounds, then update the GlyphOverflow accordingly.
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::WidthIterator): Added boolean parameter telling the width iterator
whether to account for glyph bounds. Initialize m_accountForGlyphBounds accordingly. Initialize
m_maxGlyphBoundingBoxY, m_minGlyphBoundingBoxY, m_firstGlyphOverflow and m_lastGlyphOverflow.
(WebCore::WidthIterator::advance): If accounting for glyph bounds, update the above member variables.
* platform/graphics/WidthIterator.h:
(WebCore::WidthIterator::maxGlyphBoundingBoxY): Added this accessor.
(WebCore::WidthIterator::minGlyphBoundingBoxY): Ditto.
(WebCore::WidthIterator::firstGlyphOverflow): Ditto.
(WebCore::WidthIterator::lastGlyphOverflow): Ditto.

LayoutTests: Updated results for <rdar://problem/6649734> Text repainting does not account for glyphs which draw outside the typographic bounds of the font
https://bugs.webkit.org/show_bug.cgi?id=6274

Reviewed by Adele Peterson.

* platform/mac/fast/repaint/stacked-diacritics-expected.checksum:
* platform/mac/fast/repaint/stacked-diacritics-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-30 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Fri, 30 Apr 2010 17:23:24 +0000 (17:23 +0000)]
2010-04-30  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Reversed the order of the CSSMatrix.multiply method
        https://bugs.webkit.org/show_bug.cgi?id=38337

        * css/WebKitCSSMatrix.cpp:
        (WebCore::WebKitCSSMatrix::multiply):
        * platform/graphics/transforms/TransformationMatrix.cpp:

        These are the existing tests for 2D and 3D CSSMatrix and SVGMatrix.
        I've added tests missing between the two styles and now do tests
        that confirm that SVGMatrix and CSSMatrix both multiply the same.

        This also adds a new test from Simon which compares SVG to CSS matrixes.
        This is a pixel test for mac only.

        * platform/mac/transforms/svg-vs-css-expected.checksum: Added.
        * platform/mac/transforms/svg-vs-css-expected.png: Added.
        * platform/mac/transforms/svg-vs-css-expected.txt: Added.
        * svg/dom/SVGMatrix-interface-expected.txt:
        * svg/dom/SVGMatrix-interface.xhtml:
        * transforms/cssmatrix-2d-interface-expected.txt:
        * transforms/cssmatrix-2d-interface.xhtml:
        * transforms/cssmatrix-3d-interface-expected.txt:
        * transforms/cssmatrix-3d-interface.xhtml:
        * transforms/svg-vs-css.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Attempt to fix the Chromium Mac build after the last commit.
kevino@webkit.org [Fri, 30 Apr 2010 16:56:15 +0000 (16:56 +0000)]
Unreviewed. Attempt to fix the Chromium Mac build after the last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, expectations update.
dglazkov@chromium.org [Fri, 30 Apr 2010 16:35:25 +0000 (16:35 +0000)]
Unreviewed, expectations update.

[Chromium] Provide expectations for svg/custom/repaint-stroke-width-changes.svg,
which was added in http://trac.webkit.org/changeset/58570/.

* platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.checksum: Added.
* platform/chromium-mac/svg/custom/repaint-stroke-width-changes-expected.checksum: Added.
* platform/chromium-mac/svg/custom/repaint-stroke-width-changes-expected.png: Added.
* platform/chromium-win/svg/custom/repaint-stroke-width-changes-expected.checksum: Added.
* platform/chromium-win/svg/custom/repaint-stroke-width-changes-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReviewed by Dan Bernstein.
kevino@webkit.org [Fri, 30 Apr 2010 16:33:01 +0000 (16:33 +0000)]
Reviewed by Dan Bernstein.

Allow other ports to compile ATSUI and CoreText functions in SimpleFontData for Mac.
https://bugs.webkit.org/show_bug.cgi?id=38334

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-30 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 30 Apr 2010 16:09:18 +0000 (16:09 +0000)]
2010-04-30  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Beth Dakin.

        Update image results for SVG as CSS border image tests
        https://bugs.webkit.org/show_bug.cgi?id=37028

        Improve the tests for SVG in border image to use an image that is not a solid color,
        and by adding comparison elements with PNG-based borders.

        Remove unused "green rect" SVG files.

        Update Mac pixel results, and remove Chromium pixel results with the expectation
        that someone will commit new ones.

        * fast/borders/resources/green-fixed-size-rect.svg: Removed.
        * fast/borders/resources/green-relative-size-rect.svg: Removed.
        * fast/borders/resources/large-tiles.png: Added.
        * fast/borders/resources/tiles-fixed-size.svg: Added.
        * fast/borders/resources/tiles-relative-size.svg: Added.
        * fast/borders/resources/tiles.png: Added.
        * fast/borders/svg-as-border-image-2.html:
        * fast/borders/svg-as-border-image.html:
        * platform/chromium-win/fast/borders/svg-as-border-image-2-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/svg-as-border-image-2-expected.png: Removed.
        * platform/chromium-win/fast/borders/svg-as-border-image-2-expected.txt: Removed.
        * platform/chromium-win/fast/borders/svg-as-border-image-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/svg-as-border-image-expected.png: Removed.
        * platform/chromium-win/fast/borders/svg-as-border-image-expected.txt: Removed.
        * platform/mac/fast/borders/svg-as-border-image-2-expected.checksum:
        * platform/mac/fast/borders/svg-as-border-image-2-expected.png:
        * platform/mac/fast/borders/svg-as-border-image-2-expected.txt:
        * platform/mac/fast/borders/svg-as-border-image-expected.checksum:
        * platform/mac/fast/borders/svg-as-border-image-expected.png:
        * platform/mac/fast/borders/svg-as-border-image-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, expectations tweak.
dglazkov@chromium.org [Fri, 30 Apr 2010 15:53:22 +0000 (15:53 +0000)]
Unreviewed, expectations tweak.

[Chromium] Defer Sputnik tests.

* platform/chromium/test_expectations.txt: Tagged fast/js/sputnik with DEFER.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-30 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Fri, 30 Apr 2010 15:46:01 +0000 (15:46 +0000)]
2010-04-30  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Simon Fraser.

        SHOULD NEVER BE REACHED assertion loading forbes.com
        https://bugs.webkit.org/show_bug.cgi?id=38272

        * printing/pseudo-class-outside-page-expected.txt: Added.
        * printing/pseudo-class-outside-page.html: Added.
2010-04-30  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Simon Fraser.

        SHOULD NEVER BE REACHED assertion loading forbes.com
        https://bugs.webkit.org/show_bug.cgi?id=38272

        Ignore page media related pseudo classes.

        Test: printing/pseudo-class-outside-page.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChanged Steve Block from committer to reviewer.
steveblock@google.com [Fri, 30 Apr 2010 15:22:22 +0000 (15:22 +0000)]
Changed Steve Block from committer to reviewer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-30 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 30 Apr 2010 15:11:50 +0000 (15:11 +0000)]
2010-04-30  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. While I'm at it: Update prototype-inheritance-2-expected.txt result, it's failing since CSSPageRule has been introduced.

        * platform/win/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-30 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 30 Apr 2010 15:08:25 +0000 (15:08 +0000)]
2010-04-30  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Windows fails on svg/custom/mask-changes.svg. Trying to fix the test which is really flawed. Shows a DRT difference between Mac/Win.

        * svg/custom/mask-changes.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-30 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Fri, 30 Apr 2010 13:34:21 +0000 (13:34 +0000)]
2010-04-30  Jeremy Orlow  <jorlow@chromium.org>

        Unreviewed.  Fixing a missed test from https://bugs.webkit.org/show_bug.cgi?id=38331

        * fast/events/init-events-expected.txt:
        * fast/events/script-tests/init-events.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 30 Apr 2010 13:31:59 +0000 (13:31 +0000)]
2010-04-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed, build fix.

        Fix compiler warning "suggest parentheses around"

        No new tests as there is no new functionality.

        * svg/SVGAnimateElement.cpp:
        (WebCore::SVGAnimateElement::calculateFromAndToValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Unreviewed. Regression fix.
tkent@chromium.org [Fri, 30 Apr 2010 11:49:06 +0000 (11:49 +0000)]
WebCore: Unreviewed. Regression fix.

Revert a part of r58564 to be compatible with prior behavior
https://bugs.webkit.org/show_bug.cgi?id=38383

* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::forwardEvent):
 r58564 made a region check for the cancel button stricter, but it
 made some tests failing on Chromium. So, relax the check again.

LayoutTests: Unreviewed.

Revert a part of r58564 to be compatible with prior behavior
https://bugs.webkit.org/show_bug.cgi?id=38383

* platform/chromium/test_expectations.txt: Remove expectations added by r58568.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Fri, 30 Apr 2010 11:26:31 +0000 (11:26 +0000)]
2010-04-29  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        Change StorageEvent.uri to StorageEvent.url to match the spec
        https://bugs.webkit.org/show_bug.cgi?id=38331

        Change the existing tests to test 'url' rather than 'uri'.

        * storage/domstorage/events/documentURI-expected.txt:
        * storage/domstorage/events/script-tests/documentURI.js:
        (step2):
        (step3):
        * storage/domstorage/localstorage/resources/iframe-events-second.html:
        * storage/domstorage/sessionstorage/resources/iframe-events-second.html:
2010-04-29  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        Change StorageEvent.uri to StorageEvent.url to match the spec
        https://bugs.webkit.org/show_bug.cgi?id=38331

        As I mentioned in http://www.mail-archive.com/public-webapps@w3.org/msg08495.html
        WebKit is the only one who places the document's URL in a 'uri' property
        rather than a 'url' property.  Even though we've shipped several versions of
        browsers with the old name, we probably should change this to comply with the
        spec.

        This stuff is covered by existing tests.

        * storage/StorageEvent.cpp:
        (WebCore::StorageEvent::create):
        (WebCore::StorageEvent::StorageEvent):
        (WebCore::StorageEvent::initStorageEvent):
        * storage/StorageEvent.h:
        (WebCore::StorageEvent::url):
        * storage/StorageEvent.idl:
2010-04-29  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        Change StorageEvent.uri to StorageEvent.url to match the spec
        https://bugs.webkit.org/show_bug.cgi?id=38331

        Get rid of a stale FIXME and combine 2 lines that needn't be split.

        * src/StorageEventDispatcherImpl.cpp:
        (WebCore::StorageEventDispatcherImpl::dispatchStorageEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-30 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 30 Apr 2010 11:22:30 +0000 (11:22 +0000)]
2010-04-30  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        REGRESSION: RenderPath does not handle repaints correctly anymore if bounds changed
        https://bugs.webkit.org/show_bug.cgi?id=38385

        The last SVG performance patch broke repainting if bounds of a RenderPath get smaller.
        It would only repaint the smaller part, not the original larger bounds.

        Remove all lazy calculation of the repaint rects, instead calculate object/strokeBoundingBox and repaintRectInLocalCoordinates
        once in layout - after LayoutRepainter grabbed the initial bounds, before calling repaintAfterLayout(). We can now inline
        all these functions, and save a lot of m_path.isEmpty() checks, which are expensive. No need to store a seperated markerBoundingBox(),
        combine with strokeBoundingBox() -> save one FloatRect per RenderPath. Move strokeBoundingBox() from SVGRenderBase to RenderObject,
        right next to objectBoundingBox() - to save unnecessary toSVGRenderBase() calls. Completly remove this method.

        Overall this is a regression fix, a performance improvement and saves memory. Something for everyone.

        Tests: svg/custom/repaint-stroke-width-changes.svg

        * rendering/RenderObject.cpp: Added strokeBoundingBox() here, to avoid the toSVGRenderBase() dance.
        (WebCore::RenderObject::strokeBoundingBox):
        * rendering/RenderObject.h: Ditto.
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::RenderPath):
        (WebCore::RenderPath::layout): Fix regression, do repainting correctly, by recalculating the boundaries, if needed, instead of nulling them.
        (WebCore::RenderPath::paint): Cache SVGRenderStyle in local variable, remove no longer valid FIXME.
        (WebCore::RenderPath::calculateMarkerBoundsIfNeeded): Return a FloatRect, to avoid having to store the marker bounding box seperated.
        (WebCore::RenderPath::styleWillChange): Mark boundaries as dirty.
        (WebCore::RenderPath::updateCachedBoundaries): New function to (re-)calculate all cached boundaries, only called from layout().
        * rendering/RenderPath.h: Rename cached rect variables to have more sensible names.
        (WebCore::RenderPath::objectBoundingBox): Inlined, just returns the cached value - no more lazy creation. Huge speedup as this is hot code.
        (WebCore::RenderPath::strokeBoundingBox): Ditto.
        (WebCore::RenderPath::repaintRectInLocalCoordinates): Ditto.
        * rendering/RenderSVGBlock.h: Remove toSVGRenderBase() method.
        * rendering/RenderSVGImage.h: Ditto.
        * rendering/RenderSVGInline.cpp: No need to call toSVGRenderBase() just to get the strokeBoundingBox(). Unifies code to retrieve bounding boxes.
        (WebCore::RenderSVGInline::strokeBoundingBox):
        * rendering/RenderSVGInline.h: Remove toSVGRenderBase() method.
        * rendering/RenderSVGModelObject.h: Ditto.
        * rendering/RenderSVGResourceFilter.cpp: No need to call toSVGRenderBase() anymore, just grab the strokeBoundingBox() from the RenderObject.
        (WebCore::RenderSVGResourceFilter::applyResource):
        * rendering/RenderSVGText.h: Remove toSVGRenderBase() method.
        * rendering/SVGRenderSupport.h: Ditto. Remove markerBoundingBox() method, now combined with strokeBoundingBox().
        (WebCore::SVGRenderBase::strokeBoundingBox):
        * rendering/SVGRootInlineBox.h: Remove toSVGRenderBase() method.
        * rendering/style/SVGRenderStyle.h: Add hasMarkers() helper method, to avoid doing unnecessary work in RenderPath.
        (WebCore::SVGRenderStyle::hasMarkers):

2010-04-30  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        REGRESSION: RenderPath does not handle repaints correctly anymore if bounds changed
        https://bugs.webkit.org/show_bug.cgi?id=38385

        Add new test covering the repaint problem. Influences some marker results, that can be safely ignored.

        * platform/mac/svg/custom/circular-marker-reference-1-expected.txt:
        * platform/mac/svg/custom/circular-marker-reference-3-expected.txt:
        * platform/mac/svg/custom/circular-marker-reference-4-expected.txt:
        * platform/mac/svg/custom/repaint-stroke-width-changes-expected.checksum: Added.
        * platform/mac/svg/custom/repaint-stroke-width-changes-expected.png: Added.
        * platform/mac/svg/custom/repaint-stroke-width-changes-expected.txt: Added.
        * svg/custom/repaint-stroke-width-changes.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-30 Eric Uhrhane <ericu@chromium.org>
eric@webkit.org [Fri, 30 Apr 2010 11:11:11 +0000 (11:11 +0000)]
2010-04-30  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by Dmitry Titov.

        Add bindings for async DB API in Workers.
        https://bugs.webkit.org/show_bug.cgi?id=34992

        * storage/change-version-handle-reuse.html: Refactored to share code with the worker version of the test.
        * storage/change-version-handle-reuse-expected.html: Removed reference to reloading, which this test doesn't do.
        * storage/change-version-handle-reuse.js: This is the extracted shared core of the test.
        * storage/execute-sql-args.html: Refactored to share code with the worker version of the test.
        * storage/execute-sql-args.js: This is the extracted shared core of the test.

        These are the worker versions of the tests; they're tiny shims around shared code.
        * fast/workers/execute-sql-args-worker-expected.txt: Added.
        * fast/workers/execute-sql-args-worker.html: Added.
        * fast/workers/change-version-handle-reuse-worker-expected.txt: Added.
        * fast/workers/change-version-handle-reuse-worker.html: Added.
        This file gets included from worker database tests; it does all the boilerplate that's needed on the DOM side.
        * fast/workers/resources/database-worker-controller.js: Added.
        This file is the boilerplate for the worker side of the database tests.  It will import and run the actual test on command, and will report back completion and exceptions.
        * fast/workers/resources/database-worker.js: Added.
2010-04-30  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by Dmitry Titov.

        Add bindings for async DB API in Workers.
        https://bugs.webkit.org/show_bug.cgi?id=34992

        Tests: storage/change-version-handle-reuse-worker.html
               storage/execute-sql-args-worker.html

        * bindings/js/JSWorkerContextCustom.cpp: Add openDatabase binding.
        (WebCore::JSWorkerContext::openDatabase):

        * bindings/v8/custom/V8WorkerContextCustom.cpp: Add openDatabase stub; Chromium will need work both in V8 and in the browser process before we can turn this on there.
        (WebCore::V8WorkerContext::openDatabaseCallback):

        Add NoStaticTables flags to all objects now shared with workers.
        * storage/Database.idl:
        * storage/SQLError.idl:
        * storage/SQLResultSet.idl:
        * storage/SQLResultSetRowList.idl:
        * storage/SQLTransaction.idl:

        * workers/WorkerContext.h: Add databaseExceededQuota.
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::databaseExceededQuota): Add stub implementation for testing; you just get 5MB for now.
        (WebCore::WorkerContext::openDatabase): Remove invalid assertion.

        Add the IDL for the call to openDatabase.
        * workers/WorkerContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewd, update test expectations.
ukai@chromium.org [Fri, 30 Apr 2010 10:06:12 +0000 (10:06 +0000)]
Unreviewd, update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=38383

Start failing after WebKit r58563:r58565
- fast/forms/search-abs-pos-cancel-button.html
- fast/forms/search-cancel-button-mouseup.html
- fast/forms/search-rtl.html
- fast/forms/search-zoomed.html

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Fix wrong bug numbers in ChangeLogs for r58564.
tkent@chromium.org [Fri, 30 Apr 2010 09:24:36 +0000 (09:24 +0000)]
Unreviewed.  Fix wrong bug numbers in ChangeLogs for r58564.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-30 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Fri, 30 Apr 2010 09:14:28 +0000 (09:14 +0000)]
2010-04-30  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        Unnecessary PrintContext::end() calls
        https://bugs.webkit.org/show_bug.cgi?id=38247

        Refactoring only, so no new tests.

        * page/PrintContext.cpp:
        (WebCore::PrintContext::pageNumberForElement):
        (WebCore::PrintContext::numberOfPages):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewd, test expectations cleanup.
ukai@chromium.org [Fri, 30 Apr 2010 08:48:47 +0000 (08:48 +0000)]
Unreviewd, test expectations cleanup.

media/video-empty-source.html passes since r58480:r58515 (win), r58489 (linux), r58488:458490 (mac)
fast/backround/svg-as-background-6.html passes since r58488:r58490 (mac)
fast/repaint/caret-outside-block.html passes since r58414:r58415 (mac)
fast/replaced/border-radius-clip.html passes since r58543 (win, linux)
fast/images/svg-as-tiled-background.html passes r58488:r58490 (mac)
fast/text/line-breaks.html passes since r58480:r58515 (win)
fast/backgrounds/svg-as-background-2.html passes since r58480:r58515 (win), r58489 (linux), r58488:r58490 (mac)

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement interactive behavior of spin buttons.
tkent@chromium.org [Fri, 30 Apr 2010 08:45:49 +0000 (08:45 +0000)]
Implement interactive behavior of spin buttons.
https://bugs.webkit.org/show_bug.cgi?id=27968

Reviewed by Adele Peterson.

WebCore:

Introduce SpinButtonElement. It is a shadow element class for
spin buttons. If the upper side of the element is clicked, calls
HTMLInputElement::stepUpFromRenderer(1). If the lower button is
clicked, calls HTMLInputElement::stepUpFromRenderer(-1).

SpinButtonElement tracks the mouse pointer position, and
RenderTheme sets ControlStates::SpinUpState if the pointer is on
the upper side.

Test: platform/mac/fast/forms/input-number-click.html

* dom/Element.h:
(WebCore::Element::isSpinButtonElement):
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
 Remove an assertion. lastEditablePositionBeforePositionInRoot() can
 return null in a case that m_end is at a shadow element (a spin button)
 and baseRoot is another shadow element (inner text block) in the same
 node (an INPUT element).
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::stepUpFromRenderer):
* html/HTMLInputElement.h:
(WebCore::HTMLInputElement::hasSpinButton):
 Add types supporting step attribute except RANGE.
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::nodeAtPoint):
(WebCore::RenderTextControlSingleLine::forwardEvent):
(WebCore::RenderTextControlSingleLine::preferredContentWidth):
(WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
* rendering/RenderTextControlSingleLine.h:
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::controlStatesForRenderer):
(WebCore::RenderTheme::isSpinUpButtonPartPressed):
(WebCore::RenderTheme::isSpinUpButtonPartHovered):
* rendering/RenderTheme.h:
* rendering/TextControlInnerElements.cpp:
(WebCore::SpinButtonElement::SpinButtonElement):
(WebCore::SpinButtonElement::defaultEventHandler):
* rendering/TextControlInnerElements.h:
(WebCore::SpinButtonElement::isSpinButtonElement):
(WebCore::SpinButtonElement::isEnabledFormControl):
(WebCore::SpinButtonElement::onUpButton):

LayoutTests:

* platform/mac/fast/forms/input-number-click-expected.txt: Added.
* platform/mac/fast/forms/input-number-click.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-30 Yael Aharon <yael.aharon@nokia.com>
eric@webkit.org [Fri, 30 Apr 2010 08:41:39 +0000 (08:41 +0000)]
2010-04-30  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Enable DOMWindow constructor for HTMLProgressElement
        https://bugs.webkit.org/show_bug.cgi?id=38333

        Update expected test results after this change

        * platform/qt/fast/dom/Window/window-properties-expected.txt:
        * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
        * platform/qt/fast/dom/prototype-inheritance-expected.txt:
        * platform/qt/fast/js/global-constructors-expected.txt:
2010-04-30  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Enable DOMWindow constructor for HTMLProgressElement
        https://bugs.webkit.org/show_bug.cgi?id=38333

        Add ENABLE_PROGRESS_TAG to FEATURES_DEFINES_JAVASCRIPT.

        * WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 30 Apr 2010 07:56:38 +0000 (07:56 +0000)]
2010-04-29  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Add codegen support for unsigned right shift
        https://bugs.webkit.org/show_bug.cgi?id=38375

        Expose unsigned right shift in the macro assembler, and make use of it
        from the jit.  Currently if the result is outside the range 0..2^31-1
        we simply fall back to the slow case, even in JSVALUE64 and JSVALUE32_64
        where technically we could still return an immediate value.

        * assembler/MacroAssemblerARM.h:
        (JSC::MacroAssemblerARM::urshift32):
        * assembler/MacroAssemblerARMv7.h:
        (JSC::MacroAssemblerARMv7::urshift32):
        * assembler/MacroAssemblerX86Common.h:
        (JSC::MacroAssemblerX86Common::urshift32):
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::):
        (JSC::X86Assembler::shrl_i8r):
        (JSC::X86Assembler::shrl_CLr):
           Add unsigned right shift to the x86 assembler
        * jit/JIT.cpp:
        (JSC::JIT::privateCompileMainPass):
        (JSC::JIT::privateCompileSlowCases):
           op_rshift no longer simply get thrown to a stub function
        * jit/JIT.h:
        * jit/JITArithmetic.cpp:
        (JSC::JIT::emit_op_urshift):
        (JSC::JIT::emitSlow_op_urshift):
          JSVALUE32 and JSVALUE64 implementation.  Only supports
          double lhs in JSVALUE64.
        * jit/JITArithmetic32_64.cpp:
        (JSC::JIT::emit_op_rshift):
        (JSC::JIT::emitSlow_op_rshift):
        (JSC::JIT::emit_op_urshift):
        (JSC::JIT::emitSlow_op_urshift):
          Refactor right shift code to have shared implementation between signed
          and unsigned versions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-30 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 30 Apr 2010 07:45:09 +0000 (07:45 +0000)]
2010-04-30  Kent Tamura  <tkent@chromium.org>

        Reviewed by Adele Peterson.

        Mac implementation of outer-spin-button appearance, and anonymous
        element generation for <input type=number>.
        https://bugs.webkit.org/show_bug.cgi?id=32813

        input-appearance-spinbutton.html checks the appearances of various
        sizes of spin-buttons. input-appearance-spinbutton-size.html
        checks a spin-button height is equal to or less than the
        corresponding text field height.

        * platform/mac/fast/forms/input-appearance-spinbutton-expected.checksum: Added.
        * platform/mac/fast/forms/input-appearance-spinbutton-expected.png: Added.
        * platform/mac/fast/forms/input-appearance-spinbutton-expected.txt: Added.
        * platform/mac/fast/forms/input-appearance-spinbutton-size-expected.txt: Added.
        * platform/mac/fast/forms/input-appearance-spinbutton-size.html: Added.
        * platform/mac/fast/forms/input-appearance-spinbutton.html: Added.
2010-04-30  Kent Tamura  <tkent@chromium.org>

        Reviewed by Adele Peterson.

        Mac implementation of outer-spin-button appearance, and anonymous
        element generation for <input type=number>.
        https://bugs.webkit.org/show_bug.cgi?id=32813

        The implementation uses NSStepperCell. Like the other Mac
        controls, it has only three candidates for sizes.

        The editable block of an input element is shrunk, and the
        anonymous block for a spin button is put on the right of the
        editable block.

        Tests: platform/mac/fast/forms/input-appearance-spinbutton-size.html
               platform/mac/fast/forms/input-appearance-spinbutton.html

        * dom/Element.cpp:
        (WebCore::Element::pseudoStyleCacheIsInvalid):
        * dom/InputElement.h:
        (WebCore::InputElement::hasSpinButton):
        * html/HTMLInputElement.h:
        (WebCore::HTMLInputElement::hasSpinButton): Return true for NUMBER type.
        * platform/mac/ThemeMac.mm:
        (WebCore::sizeFromNSControlSize): Split the main part of sizeFromFont()
          to this in order to use stepperControlSizeForFont() instead of
          controlSizeForFont().
        (WebCore::sizeFromFont): Just calls sizeFromNSControlSize() with
          sizeFromFont(). No behavior changes.
        (WebCore::stepperSizes): Returns sizes for mini, small, and regular.
        (WebCore::stepperControlSizeForFont):
          Dedicated version of controlSizeForFont().
        (WebCore::stepper): Returns NSStepperCell object with specified settings.
        (WebCore::paintStepper):
        (WebCore::ThemeMac::controlSize): Support for OuterSpinButton.
        (WebCore::ThemeMac::minimumControlSize): ditto.
        (WebCore::ThemeMac::inflateControlPaintRect): ditto.
        (WebCore::ThemeMac::paint): ditto.
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintBoxDecorations):
          Move the content to paintBoxDecorationsWithSize().
        (WebCore::RenderBox::paintBoxDecorationsWithSize):
        * rendering/RenderBox.h: Declare paintBoxDecorationsWithSize().
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
        (WebCore::RenderTextControlSingleLine::paintBoxDecorations):
          Call paintBoxDecorationsWithSize() with smaller width by decorationWidthRight().
        (WebCore::RenderTextControlSingleLine::addFocusRingRects):
          Add a rectangle of which width is smaller by decorationWidthRight().
        (WebCore::RenderTextControlSingleLine::layout):
          Adjust m_outerSpinButton position.
        (WebCore::RenderTextControlSingleLine::styleDidChange):
        (WebCore::RenderTextControlSingleLine::textBlockWidth):
        (WebCore::RenderTextControlSingleLine::decorationWidthRight):
        (WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight):
        (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
          Creates an element for m_outerSpinButton if it is needed.
        (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
        (WebCore::RenderTextControlSingleLine::createOuterSpinButtonStyle):
        * rendering/RenderTextControlSingleLine.h: Declare new methods and m_outerSpinButton.
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::adjustRepaintRect): Support for OuterSpinButton.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58561 268f45cc-cd09-0410-ab3c-d52691b4dbfc