13 years ago2008-04-16 Anatoli Papirovski <apapirovski@mac.com>
jchaffraix@webkit.org [Wed, 16 Apr 2008 19:47:55 +0000 (19:47 +0000)]
2008-04-16  Anatoli Papirovski  <apapirovski@mac.com>

        Reviewed by David.

        Optimized the calculation of background-size.

        * rendering/RenderBox.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix Bug 17228: console.{log,warn,info,error} should support format strings...
aroben@apple.com [Wed, 16 Apr 2008 19:34:53 +0000 (19:34 +0000)]
    Fix Bug 17228: console.{log,warn,info,error} should support format strings, variable arguments


        Reviewed by Tim Hatcher.

        Test: manual-tests/inspector/console-log-formatting.html

        * page/inspector/Console.js:
        (WebInspector.ConsoleMessage): Pass any extra arguments down to
        (WebInspector.ConsoleMessage._format): This method constructs
        this.formattedMessage. We treat the first parameter as a format
        string. Any parameters that have not been used after substituting into
        the format string are concatenated together, separated by spaces.
        (WebInspector.ConsoleMessage.toMessageElement): Updated to use
        (WebInspector.ConsoleMessage.toString): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Make String.format return an array of unused substitutions
aroben@apple.com [Wed, 16 Apr 2008 19:34:29 +0000 (19:34 +0000)]
    Make String.format return an array of unused substitutions

        String.format now returns an object with two properties:
        formattedResult and unusedSubstitutions.

        Reviewed by Tim Hatcher.

        * page/inspector/utilities.js:
        (String.vsprintf): Updated for changes to String.format. We throw away
        the array of unused substitutions.
        (String.format): Changed to keep track of which substitutions are used
        when formatting. We then return both the formatted result and the
        array of unused substitutions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Generalize String.format some more
aroben@apple.com [Wed, 16 Apr 2008 19:34:07 +0000 (19:34 +0000)]
    Generalize String.format some more

        String.format now takes an initial value and an append function which
        it uses to build the result. Each time a token is processed,
        append(valueSoFar, newValue) is called.

        Reviewed by Tim Hatcher.

        * page/inspector/utilities.js:
        (String.vsprintf): Pass the empty string for the initial value, and
        a function that concatenates two strings as the append function.
        (String.format): Use initialValue and append to build the result
        instead of only working with strings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add String.format
aroben@apple.com [Wed, 16 Apr 2008 19:20:21 +0000 (19:20 +0000)]
    Add String.format

        String.format is a more generic form of String.vsprintf that takes a
        set of formatter functions, one for each supported format specifier.
        Each formatter function is passed the relevant token and substitution
        value, and returns the formatted result.

        Reviewed by Tim Hatcher.

        * page/inspector/utilities.js:
        (String.standardFormatters): Added.
        (String.vsprintf): Changed to call through to String.format.
        (String.format): Added. Most of the code came from String.vsprintf,
        except that we use the passed-in formatters to format the
        substitutions rather than hard-coding how to handle each format

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Refactor String.vsprintf to separate tokenizing and substituting
aroben@apple.com [Wed, 16 Apr 2008 19:19:57 +0000 (19:19 +0000)]
    Refactor String.vsprintf to separate tokenizing and substituting

        This will eventually be useful for the various console methods that
        take a format string.

        Reviewed by Tim Hatcher.

        * page/inspector/utilities.js:
        (String.tokenizeFormatString): Added. This uses the format parsing
        code from String.vsprintf but just returns an array of "string" and
        "specifier" tokens.
        (String.vsprintf): Now calls String.tokenizeFormatString and processes
        the tokens one at a time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Pass all arguments to console.{log,warn,info,error} into the Inspector's JS
aroben@apple.com [Wed, 16 Apr 2008 19:19:29 +0000 (19:19 +0000)]
    Pass all arguments to console.{log,warn,info,error} into the Inspector's JS

        Part of Bug 17228: console.{log,warn,info,error} should support format
        strings, variable arguments

        We don't use the extra arguments yet.

        Reviewed by Tim Hatcher.

        * page/Console.cpp:
        (WebCore::Console::error): Pass the arguments list to
        (WebCore::Console::info): Ditto.
        (WebCore::Console::log): Ditto.
        (WebCore::Console::warn): Ditto.
        * page/InspectorController.cpp:
        (WebCore::ConsoleMessage::ConsoleMessage): Added a new constructor
        that takes an ExecState and a List instead of a String. We wrap and
        store the JSValues from the List in a Vector<ProtectedPtr<JSValue> >.
        (WebCore::InspectorController::addMessageToConsole): Added an overload
        that takes an ExecState and a List.
        (WebCore::InspectorController::addConsoleMessage): Moved code here
        from addMessageToConsole. Both overloads of addMessageToConsole now
        call this helper method.
        (WebCore::InspectorController::addScriptConsoleMessage): Updated for
        the new parameter order of WebInspector.ConsoleMessage. If the
        ConsoleMessage has a non-empty wrappedArguments Vector, we use that
        instead of the ConsoleMessage's message String.
        * page/InspectorController.h:
        * page/inspector/Console.js:
        (WebInspector.ConsoleMessage): Removed the explicit message parameter.
        We now get the message from the unnamed 5th parameter.
        * page/inspector/Resource.js: Updated for the change to
        WebInspector.ConsoleMessage's parameter order.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Change calls to Chrome::addMessageToConsole to use Console::addMessage
aroben@apple.com [Wed, 16 Apr 2008 19:19:00 +0000 (19:19 +0000)]
    Change calls to Chrome::addMessageToConsole to use Console::addMessage

        Part of Bug 17228: console.{log,warn,info,error} should support format
        strings, variable arguments

        Console now takes care of calling ChromeClient::addMessageToConsole
        for the appropriate messages (i.e., just messages from JavaScript). If
        you ever want to add a message to the console, Console is the place to
        do it.

        Reviewed by Darin Adler.

        * WebCore.xcodeproj/project.pbxproj: Mark Console.h Private.
        * page/Chrome.cpp: Removed addMessageToConsole
        * page/Chrome.h: Moved MessageSource/MessageLevel to Console.h.
        * page/Console.cpp:
        (WebCore::Console::addMessage): Added. Calls
        ChromeClient::addMessageToConsole for JS messages, and calls
        InspectorController::addMessageToConsole for all messages.
        (WebCore::Console::error): Changed to call directly to
        InspectorController in addition to ChromeClient.
        (WebCore::Console::info): Ditto.
        (WebCore::Console::log): Ditto.
        (WebCore::Console::warn): Ditto.
        * page/Console.h: Added MessageSource/MessageLevel enums from Chrome.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Pass JSConsole's arguments unmodified to Console
aroben@apple.com [Wed, 16 Apr 2008 19:18:11 +0000 (19:18 +0000)]
    Pass JSConsole's arguments unmodified to Console

        Part of Bug 17228: console.{log,warn,info,error} should support format
        strings, variable arguments

        All of JSConsole's methods are now custom, so that we can pass the
        arguments unmodified to Console. Console now handles calling
        toString() on the first argument. Later it will pass the arguments off
        to InspectorController.

        There should be no behavioral changes caused by this patch.

        Reviewed by Darin Adler.

        * ForwardingHeaders/kjs/list.h: Added.
        * GNUmakefile.am: Added JSConsoleCustom.cpp to the project.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * WebCoreSources.bkl: Ditto.
        * bindings/js/JSConsoleCustom.cpp: Added.
        * page/Console.cpp: Changed all methods to take an ExecState* and a
        const List&. The first item in the List is toString()ed and passed to
        * page/Console.h:
        * page/Console.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-16 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Wed, 16 Apr 2008 19:08:03 +0000 (19:08 +0000)]
2008-04-16  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Sam and Geoff.

        -<rdar://problem/5770054> JavaScript profiler (10928)
        Inital profiler prototype

        * GNUmakefile.am: Added new files to project
        * JavaScriptCore.pri: Ditto
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto
        * JavaScriptCore.xcodeproj/project.pbxproj: Ditto
        * JavaScriptCoreSources.bkl: Ditto
        * kjs/config.h: Put compiling flag in here.
        * kjs/function.cpp: Instrument calling the function eval().
        * kjs/interpreter.cpp: Instrument evaluating global scopes.
        * kjs/object.cpp: Instrument JS function calls.
        * profiler: Added.
        * profiler/FunctionCallProfile.cpp: Added.
        (KJS::FunctionCallProfile::willExecute): Call right before the JS function or executing context is executed to start the profiler's timer.
        (KJS::FunctionCallProfile::didExecute): Call right after the JS function or executing context is executed to stop the profiler's timer.
        (KJS::FunctionCallProfile::addChild): Add a child to the current FunctionCallProfile if it isn't already a child of the current FunctionalCallProfile.
        (KJS::FunctionCallProfile::findChild): Return the child that matches the given name if there is one.
        (KJS::FunctionCallProfile::printDataSampleStyle): Print the current profiled information in a format that matches sample's output.
        * profiler/FunctionCallProfile.h: Added.
        * profiler/Profiler.cpp: Added.
        (KJS::Profiler::sharedProfiler): Return global singleton (may change due to multi-threading concerns)
        (KJS::Profiler::startProfiling): Don't start collecting profiling information until the user starts the profiler. Also don't clear old prfiled data until the profiler is restarted.
        (KJS::Profiler::stopProfiling): Stop collecting profile information.
        (KJS::Profiler::willExecute): Same as above.
        (KJS::Profiler::didExecute): Same as above.
        (KJS::Profiler::insertStackNamesInTree): Follow the stack of the given names and if a sub-stack is not in the current tree, add it.
        (KJS::Profiler::getStackNames): Get the names from the different passed in parameters and order them as a stack.
        (KJS::Profiler::getFunctionName): Get the function name from the given parameter.
        (KJS::Profiler::printDataSampleStyle): Print the current profiled information in a format that matches sample's output.
        * profiler/Profiler.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
weinig@apple.com [Wed, 16 Apr 2008 18:41:54 +0000 (18:41 +0000)]

2008-04-16  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        - Remove kjs_ prefix from strtod, dtoa, and freedtoa and put it
          in the KJS namespace.
        - Make strtod, dtoa, and freedtoa c++ functions instead of extern "C".
        - Remove mode switching from dtoa.  ~2% improvement on test 26.
        - Removes all unnecessary #defines from dtoa code.

        * JavaScriptCore.exp:
        * kjs/dtoa.cpp:
        * kjs/dtoa.h:
        * kjs/function.cpp:
        * kjs/lexer.cpp:
        * kjs/number_object.cpp:
        * kjs/ustring.cpp:


2008-04-16  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Rename kjs_strtod to KJS::strtod.

        * platform/text/String.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
ap@webkit.org [Wed, 16 Apr 2008 17:30:13 +0000 (17:30 +0000)]
    Reviewed by Adam.

        XML+XSLT pages in iframe contains document.location of a parent window

        Test: fast/xsl/subframe-location.html

        * xml/XSLTProcessor.cpp:
        (WebCore::XSLTProcessor::createDocumentFromSource): Set resulting document URL before opening
        it, so that the document loader picks a correct URL, too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap@webkit.org [Wed, 16 Apr 2008 17:23:24 +0000 (17:23 +0000)]
    Reviewed by Darin.

        Get rid of static execForCompareByStringForQSort in array_instance.cpp.

        No change on SunSpider, CelticKane or iBench JavaScript.

        * kjs/array_instance.cpp:
        Switch slow case to std::sort, so that ExecState can be passed in a comparator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber-stamped by John Sullivan.
mitz@apple.com [Wed, 16 Apr 2008 15:30:56 +0000 (15:30 +0000)]
    Rubber-stamped by John Sullivan.

        - remove unreachable code which was added in r8802

        * rendering/RenderText.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
ap@webkit.org [Wed, 16 Apr 2008 15:26:37 +0000 (15:26 +0000)]
    Reviewed by Adam Roben.

        MSVC build fix.

        * kjs/CommonIdentifiers.cpp:
        * kjs/CommonIdentifiers.h:
        * kjs/Parser.cpp:
        * kjs/Parser.h:
        * kjs/identifier.cpp:
        * kjs/lexer.h:
        * wtf/ThreadSpecific.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
ap@webkit.org [Wed, 16 Apr 2008 14:31:40 +0000 (14:31 +0000)]
    Build fix.

        * kjs/date_object.cpp:
        * kjs/date_object.h:
        Don't include DateMath.h from date_object.h, as the latter is used from WebCore, while
        where the former is not available.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdds a script resource icon. Update the CSS icon to better match the script icon.
timothy@apple.com [Wed, 16 Apr 2008 13:49:37 +0000 (13:49 +0000)]
Adds a script resource icon. Update the CSS icon to better match the script icon.


Rubber-stamped by Adele Peterson.

* page/inspector/Images/resourceCSSIcon.png: Updated.
* page/inspector/Images/resourceJSIcon.png: Added.
* page/inspector/inspector.css: Changed the script icon rule to reference the new image.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-16 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Wed, 16 Apr 2008 12:51:07 +0000 (12:51 +0000)]
2008-04-16  Holger Hans Peter Freyther  <zecke@selfish.org>

        Unreviewed build fix for MSVC. It does not want to have
        WTF in the KJS namespace.

        * kjs/CommonIdentifiers.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-16 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Wed, 16 Apr 2008 12:26:29 +0000 (12:26 +0000)]
2008-04-16  Holger Hans Peter Freyther  <zecke@selfish.org>

        Unreviewed build fix for gcc.

        ::msToGregorianDateTime  is not known to it.

        * kjs/date_object.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver Hunt.
ap@webkit.org [Wed, 16 Apr 2008 09:58:04 +0000 (09:58 +0000)]
    Reviewed by Oliver Hunt.

        Initialize threadMapMutex safely (as already done in ThreadingWin).

        * wtf/ThreadingGtk.cpp:
        * wtf/ThreadingPthreads.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix ChangeLog spelling.
ap@webkit.org [Wed, 16 Apr 2008 09:44:13 +0000 (09:44 +0000)]
Fix ChangeLog spelling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
ap@webkit.org [Wed, 16 Apr 2008 09:41:23 +0000 (09:41 +0000)]
    Reviewed by Adam Roben.

        Cache Gregorian date/time structure on DateInstance objects for 1.027x SunSpider speedup
        (1.65x on date-format-xparb, 1.13x on date-format-tofte).

        * kjs/DateMath.h:
        (KJS::GregorianDateTime::copyFrom): Added. It presumably makes sense to keep GregorianDateTime
        Noncopiable, so it's not just operator=.

        * kjs/date_object.h: Added a per-object cache.

        * kjs/date_object.cpp:
        Use the cache when converting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap@webkit.org [Wed, 16 Apr 2008 09:30:01 +0000 (09:30 +0000)]
    Reviewed by Darin.

        Implement an abstraction for thread-specific storage, use it to get rid of some static objects.

        SunSpider results were not conclusive, possibly up to 0.2% slowdown.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        Added ThreadSpecific.h

        * wtf/ThreadSpecific.h: Added.
        Only implemented for platforms that use pthreads.

        * kjs/CommonIdentifiers.cpp:
        * kjs/CommonIdentifiers.h:
        * kjs/InitializeThreading.cpp:
        * kjs/Parser.cpp:
        * kjs/Parser.h:
        * kjs/identifier.cpp:
        * kjs/identifier.h:
        * kjs/lexer.cpp:
        * kjs/lexer.h:
        Make static instances per-thread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by hyatt.
eric@webkit.org [Wed, 16 Apr 2008 07:53:21 +0000 (07:53 +0000)]
    Reviewed by hyatt.

        Fix leaky ImageBuffer code.

        * platform/graphics/GeneratedImage.cpp:
        * platform/graphics/ImageBuffer.h:
        * platform/graphics/cg/ImageBufferCG.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
justin.garcia@apple.com [Wed, 16 Apr 2008 05:30:13 +0000 (05:30 +0000)]

2008-04-15  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Oliver.

        <rdar://problem/5665299> REGRESSION (r27369): Paste text into a contenteditable div creates a contenteditable div for each line (16661)

        * editing/markup.cpp:
        (WebCore::createFragmentFromText): Don't use clones of the enclosing block to hold
        paragraphs if the enclosing block is the root editable element.


2008-04-15  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Oliver.

        <rdar://problem/5665299> REGRESSION (r27369): Paste text into a contenteditable div creates a contenteditable div for each line (16661)

        * editing/pasteboard/5665299-expected.txt: Added.
        * editing/pasteboard/5665299.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDon't treat the misnamed NSAccessibilitySortButtonRole as an accessibility role.
mrowe@apple.com [Wed, 16 Apr 2008 03:36:56 +0000 (03:36 +0000)]
Don't treat the misnamed NSAccessibilitySortButtonRole as an accessibility role.
It is really a subrole of NSAccessibilityButtonRole.  As it is not used inside WebCore
there is no change in behaviour as a result of doing this. This fixes <rdar://problem/5866444>.

Reviewed by Jon Honeycutt.

* page/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::canSetFocusAttribute): Remove SortButtonRole as it is unused.
* page/AccessibilityObject.h: Ditto.
* page/mac/AccessibilityObjectWrapper.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-15 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 16 Apr 2008 01:56:03 +0000 (01:56 +0000)]
2008-04-15  Anders Carlsson  <andersca@apple.com>

        Fix leaks seen on bot.

        * loader/SubstituteResource.h:
        Add a virtual destructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-15 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 16 Apr 2008 01:10:59 +0000 (01:10 +0000)]
2008-04-15  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders Carlsson

        Fix for <rdar://problem/5820819> - Crash sometime occurs when interrupting a load.

        Each SubresourceLoader has a client.  That client is often a Loader::Host object.
        The Loader/Host/CachedResource system predates our ref-counting and ownership models, and therefore manages
        object lifetime manually.

        The cause of this crash was that we would sometimes call "didFail()" on a Host object twice - Once when
        beginning the new navigation, and once when the new navigation is committed.

        The problem is after the first time Host::didFail() gets called, the Host is almost always deleted shortly
        thereafter.  But the SubresourceLoader had a dangling pointer to the Host which is now invalid.

        I explored a few options to fix this bug.  The one that was most obviously "clean" was to call cancel() on
        the SubresourceLoader itself, which would end up calling Host::didFail() and doing the appropriate cache

        This problem with that approach was that it had other side effects - when you cut off a load that had already
        partially displayed in the WebView, images that hadn't finished loading would be invalidated and immediately
        turn into broken image icons.  This was visually jarring and pretty unacceptable.

        So I decided to follow a much simpler approach, which was to have the Host clear the client pointer from each
        SubresourceLoader before it forgets about it.  This leaves things the same visually and fixes the crash.

        Note that the layout test for this - if possible - will require other enhancements to DRT including possibly
        adding support for window.stop(). That task is non-trivial, and is documented in <rdar://problem/5061826>

        * loader/SubresourceLoader.h:
        (WebCore::SubresourceLoader::clearClient): Add a method to clear the SubresourceLoaderClient.  This is
          perfectly safe to do on an in-flight SubresourceLoader as they are already designed to be client-less,
          and already null-check the client before calling it.

        * loader/loader.cpp:
        (WebCore::Loader::Host::didFail): The SubresourceLoader itself might not be finished loading and might decide
          to call into its client later.  Since the client has no guaranteed lifetime and is liable to be deleted
          after didFail() is called, call clearClient() on the SubresourceLoader so such an invalid call can't happen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
kdecker@apple.com [Tue, 15 Apr 2008 23:48:14 +0000 (23:48 +0000)]
    Reviewed by Anders.

        <rdar://problem/5412759> CrashTracer: [USER] 22 crashes in Safari at com.apple.quicktime.webplugin: NPN_SetValue + 15403

        In certain situations, code in WebBasePluginPackage would load a plug-in only for the explicit reason of asking it to create a
        preference file, but wouldn't actually unload the bundle. This created problems for the QuickTime WebKit plug-in by unloading
        a bundle out from underneath itself.

        * Plugins/WebBasePluginPackage.h: Added unload method.
        * Plugins/WebBasePluginPackage.m:
        (-[WebBasePluginPackage unload]): Added new method. Currently, only Netscape plug-ins support unload.
        (-[WebBasePluginPackage pListForPath:createFile:]): Added a call to unload.
        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage unload]): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-15 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 15 Apr 2008 23:24:57 +0000 (23:24 +0000)]
2008-04-15  Anders Carlsson  <andersca@apple.com>

        Add missing ;

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
andersca@apple.com [Tue, 15 Apr 2008 23:16:43 +0000 (23:16 +0000)]

2008-04-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.


        * Configurations/JavaScriptCore.xcconfig:


2008-04-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Add empty files for the application cache.

        * Configurations/WebCore.xcconfig:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcproj/build-generated-files.sh:

        * WebCore.xcodeproj/project.pbxproj:
        * loader/appcache: Added.
        * loader/appcache/ApplicationCache.cpp: Added.
        * loader/appcache/ApplicationCache.h: Added.
        * loader/appcache/ApplicationCacheGroup.cpp: Added.
        * loader/appcache/ApplicationCacheGroup.h: Added.
        * loader/appcache/ApplicationCacheResource.cpp: Added.
        * loader/appcache/ApplicationCacheResource.h: Added.
        * loader/appcache/DOMApplicationCache.cpp: Added.
        * loader/appcache/DOMApplicationCache.h: Added.
        * loader/appcache/DOMApplicationCache.idl: Added.
        * loader/appcache/ManifestParser.cpp: Added.
        * loader/appcache/ManifestParser.h: Added.


2008-04-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.


        * Configurations/WebKit.xcconfig:


2008-04-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.


        * WebKit.vcproj/WebKit.vcproj:


2008-04-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.


        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-15 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 15 Apr 2008 22:27:59 +0000 (22:27 +0000)]
2008-04-15  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        - <rdar://problem/5792587> AJAX (XMLHttpRequest) support for the Inspector (17776)
        - Add XMLHttpRequest support to the inspector.

        * English.lproj/InspectorLocalizedStrings.js: Specify capitalization
        instead of using text-transform because XHR must capitalize all the letters.
        * page/inspector/Resource.js: Assume XHRs are textType even though this
        may not always be true.
        Also add the XHR category and let all mime types be consistent with it.
        * page/inspector/ResourcesPanel.js: Set the XHR category color.
        * page/inspector/inspector.css: Make XHRs yellow and fonts red because
        XHRs are more common than fonts and yellow next to orange (scripts) is
        not as harsh on the eyes as red next to orange.
        * page/inspector/inspector.js: Specify capitalization again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-15 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Tue, 15 Apr 2008 21:31:11 +0000 (21:31 +0000)]
2008-04-15  David Hyatt  <hyatt@apple.com>

        Fix the zoom property so that it works properly with font-size.

        Reviewed by John Sullivan

        Added fast/css/zoom-font-size.html

        * css/CSSStyleSelector.cpp:
        * css/CSSStyleSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixes the bug where a resource view could still be shown after the inspected
timothy@apple.com [Tue, 15 Apr 2008 20:56:43 +0000 (20:56 +0000)]
Fixes the bug where a resource view could still be shown after the inspected
page navigates to another page.


Reviewed by Adam Roben.

* page/inspector/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.reset): Close the visible resource.
Iterate over all the resources and zero errors and warnings and delete the
resource view and tree element. Removes all children of resourceViews. Passes
true to _updateGraphDividersIfNeeded to force an immediate update.
(WebInspector.ResourcesPanel.prototype.removeResource): Added. Closes
the resource view if it is visible. Removes the resource from the _resources
array. Removes the tree element from the outline tree. Zeros out the errors
and warnings properties. Deletes the tree element and resource view properties.
(WebInspector.ResourcesPanel.prototype.closeVisibleResource): Null check
this._calculator for times when reset is called before the calculator is set.
* page/inspector/inspector.js:
(WebInspector.removeResource): Call ResourcesPanel.removeResource.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-15 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 15 Apr 2008 20:55:37 +0000 (20:55 +0000)]
2008-04-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Rename "archive" to "substitute" in a couple of places.

        * loader/DocumentLoader.cpp:
        * loader/DocumentLoader.h:
        * loader/ResourceLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-15 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 15 Apr 2008 19:44:40 +0000 (19:44 +0000)]
2008-04-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Move the URL, response and data to SubstituteResource.

        * loader/SubstituteResource.h:
        * loader/archive/ArchiveResource.cpp:
        * loader/archive/ArchiveResource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-15 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Tue, 15 Apr 2008 19:21:38 +0000 (19:21 +0000)]
2008-04-15  David Hyatt  <hyatt@apple.com>


        Make sure to ignore zoom:0.  That is not supposed to actually do anything.  It's a hack in IE
        to cause an element to set "hasLayout."

        Reviewed by Anders

        Added fast/css/zoom-property-parsing.html

        * css/CSSParser.cpp:
        * css/CSSStyleSelector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-15 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 15 Apr 2008 19:03:19 +0000 (19:03 +0000)]
2008-04-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Add a (currently empty) SubstituteResource class and make ArchiveResource inherit from it.

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * loader/SubstituteResource.h: Added.
        * loader/archive/ArchiveResource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-15 Antti Koivisto <antti@apple.com>
antti@apple.com [Tue, 15 Apr 2008 18:49:54 +0000 (18:49 +0000)]
2008-04-15  Antti Koivisto  <antti@apple.com>

        Reviewed by Geoff.

        Fix <rdar://problem/5862921>
        REGRESSION: Leak in SVGSVGElement::SVGSVGElement

        In these strange days RefCounted starts with count of one.

        * svg/SVGSVGElement.cpp:
        * svg/animation/SMILTimeContainer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
hyatt@apple.com [Tue, 15 Apr 2008 18:15:06 +0000 (18:15 +0000)]

2008-04-15  Anatoli Papirovski  <apapirovski@mac.com>

        Reviewed by hyatt

        [CSS1, CSS3] Fixed the background-origin calculation for root elements
        (background-size and background-position are affected), r10794
        [CSS3] Fixed the background-size transformation where width is specified in percentage and height is left to auto

        Test: fast/backgrounds/background-origin-root-element.html

        * rendering/RenderBox.cpp:


2008-04-15  Anatoli Papirovski  <apapirovski@mac.com>

        Reviewed by hyatt

        Added test case for background-origin calculation on root elements
        (background-repeat and background-size), r10794 [CSS1 + CSS3]

        * fast/backgrounds/background-origin-root-element.html: Added.
        * platform/mac/fast/backgrounds/background-origin-root-element-expected.checksum: Added.
        * platform/mac/fast/backgrounds/background-origin-root-element-expected.png: Added.
        * platform/mac/fast/backgrounds/background-origin-root-element-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-15 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 15 Apr 2008 17:54:18 +0000 (17:54 +0000)]
2008-04-15  Brady Eidson  <beidson@apple.com>

        Reviewed by John Sullivan

        Do a more complete job adding the "WebArchiveDebugMode" pref

        * WebView/WebPreferences.m: Add both getter *and* setter
        (-[WebPreferences webArchiveDebugModeEnabled]):
        (-[WebPreferences setWebArchiveDebugModeEnabled:]):
        * WebView/WebPreferencesPrivate.h:

        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]): Call the renamed getter

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixes the regression where the error and warning counts did not show up in the Resources
timothy@apple.com [Tue, 15 Apr 2008 17:24:22 +0000 (17:24 +0000)]
Fixes the regression where the error and warning counts did not show up in the Resources
sidebar next to resources.


Reviewed by Adam Roben.

* page/inspector/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.addMessageToResource): Increment errors or warnings
on the resource. Set the bubbleText to the total of the errors and warnings. Add a error
or warning class to the bubble.
(WebInspector.ResourcesPanel.prototype.clearMessages): Zero out the errors and warnings
properties on each resource. Set the bubbleText back to an empty string.
* page/inspector/SidebarTreeElement.js:
(WebInspector.SidebarTreeElement): Create a statusElement.
(WebInspector.SidebarTreeElement.prototype.get bubbleText): Return _bubbleText.
(WebInspector.SidebarTreeElement.prototype.set bubbleText): Create bubbleElement if needed.
Assign the value to _bubbleText and bubbleElement.textContent.
(WebInspector.SidebarTreeElement.prototype.onattach): Append statusElement to _listItemNode.
* page/inspector/inspector.css: Style rules for bubbles and status elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixes the regression where error and warning bubbles would not be added
timothy@apple.com [Tue, 15 Apr 2008 17:24:09 +0000 (17:24 +0000)]
Fixes the regression where error and warning bubbles would not be added
to the source view of a resource.


Reviewed by Adam Roben.

* css/view-source.css:
(.webkit-html-message-bubble): Add a min-height to make sure the border-radius
has enough room to apply.
* page/inspector/Console.js:
(WebInspector.Console.prototype.addMessage): Removed code that added messages
to resource panels and incremented error and warning counts on resources.
Now just call ResourcesPanel.addMessageToResource after assigning the resource
to the console message.
(WebInspector.Console.prototype.clearMessages): Removed code that cleared error
and warning counts from resources an call ResourcesPanel.clearMessages.
* page/inspector/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.addMessageToResource): Call addMessage
on the resource's view, if it is implemented.
(WebInspector.ResourcesPanel.prototype.clearMessages): Call clearMessages
on all the resource views for the ones that implement it.
(WebInspector.ResourcesPanel.prototype.refreshResource): Call _resourceView
to make the resource's view if needed. Use a local view variable.
(WebInspector.ResourcesPanel.prototype._resourceView): Added helper function
to create a resource view if needed.
* page/inspector/SourceView.js:
(WebInspector.SourceView.prototype.setupSourceFrameIfNeeded): Delete the
_frameNeedsSetup property at the beginning to prevent recursion. Get the
length of the messages array when assigning the local length variable.
(WebInspector.SourceView.prototype.addMessage): Renamed from addMessageToSource.
(WebInspector.SourceView.prototype.clearMessages): Added. Clear all the message
bubbles that might be sprinkled in the source. Also clears the messages array.
(WebInspector.SourceView.prototype._addMessageToSource): Create the image
element in the Inspector's document so we can use relative image URLs. Then
adopt the image element into the frame's document.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
beidson@apple.com [Tue, 15 Apr 2008 17:07:58 +0000 (17:07 +0000)]

2008-04-15  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        Hook up event dispatching for window.localStorage changes.

        Tests: storage/domstorage/localstorage/enumerate-storage.html

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::dispatchStorageEvent): Walk every Page in the PageGroup, adding
          each Frame that matches the storage area's security origin to a Vector.  Then dispatch
          the StorageEvent to each Frame in the Vector

        * storage/SessionStorage.cpp:
        (WebCore::SessionStorage::dispatchStorageEvent): Adopt the technique used in LocalStorage,
          which is to only add the Frames to the Vector if their security origin matches


2008-04-15  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        Hook up event dispatching for window.localStorage changes.
        Now a meaningful LayoutTest suite can be landed for window.localStorage.

        * storage/domstorage/localstorage/enumerate-storage-expected.txt: Added.
        * storage/domstorage/localstorage/enumerate-storage.html: Added.
        * storage/domstorage/localstorage/iframe-events-expected.txt: Added.
        * storage/domstorage/localstorage/iframe-events.html: Added.
        * storage/domstorage/localstorage/index-get-and-set-expected.txt: Added.
        * storage/domstorage/localstorage/index-get-and-set.html: Added.
        * storage/domstorage/localstorage/onstorage-attribute-markup-expected.txt: Added.
        * storage/domstorage/localstorage/onstorage-attribute-markup.html: Added.
        * storage/domstorage/localstorage/onstorage-attribute-setattribute-expected.txt: Added.
        * storage/domstorage/localstorage/onstorage-attribute-setattribute.html: Added.
        * storage/domstorage/localstorage/resources: Added.
        * storage/domstorage/localstorage/resources/clearLocalStorage.js: Added.
        * storage/domstorage/localstorage/resources/iframe-events-second.html: Added.
        * storage/domstorage/localstorage/resources/window-open-second.html: Added.
        * storage/domstorage/localstorage/simple-events-expected.txt: Added.
        * storage/domstorage/localstorage/simple-events.html: Added.
        * storage/domstorage/localstorage/simple-usage-expected.txt: Added.
        * storage/domstorage/localstorage/simple-usage.html: Added.
        * storage/domstorage/localstorage/window-open-expected.txt: Added.
        * storage/domstorage/localstorage/window-open.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAriya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Tue, 15 Apr 2008 11:51:38 +0000 (11:51 +0000)]
Ariya Hidayat  <ariya.hidayat@trolltech.com>

fix potential crash when loading image(s)

Crash may occur. If compiled with 4.3, the variable is not initialized.
This fix solves https://bugs.webkit.org/show_bug.cgi?id=17174

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSimon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Tue, 15 Apr 2008 10:51:24 +0000 (10:51 +0000)]
Simon Hausmann <hausmann@webkit.org>

Update the micro focus for input methods as soon as the composition mode changes
or the caret/selection changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSimon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Tue, 15 Apr 2008 10:51:08 +0000 (10:51 +0000)]
Simon Hausmann <hausmann@webkit.org>

Don't use QDir, QString or any locale sensitive function before constructing Q(Core)Application,
it yields undefined behaviour or wrong default codec initialization.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoOlivier Goffart <ogoffart@trolltech.com>
hausmann@webkit.org [Tue, 15 Apr 2008 10:50:54 +0000 (10:50 +0000)]
Olivier Goffart <ogoffart@trolltech.com>

Fixes: copy to clipboard when selecting, and paste when clicking with the middle button

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMichael Brasser <michael.brasser@trolltech.com>
hausmann@webkit.org [Tue, 15 Apr 2008 10:29:15 +0000 (10:29 +0000)]
Michael Brasser <michael.brasser@trolltech.com>

Add basic input method support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSimon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Tue, 15 Apr 2008 10:28:55 +0000 (10:28 +0000)]
Simon Hausmann <hausmann@webkit.org>

Added (QWebFrame|QWebView)::textZoomFactor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMichael Brasser <michael.brasser@trolltech.com>
hausmann@webkit.org [Tue, 15 Apr 2008 10:28:37 +0000 (10:28 +0000)]
Michael Brasser <michael.brasser@trolltech.com>

Added simple scrolling API to QWebFrame.

The intent is that it works similar to QAbstractScrollArea.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoOlivier Goffart <ogoffart@trolltech.com>
hausmann@webkit.org [Tue, 15 Apr 2008 10:12:57 +0000 (10:12 +0000)]
Olivier Goffart <ogoffart@trolltech.com>

Fixes: implement the OpenFrameInNewWindow action.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix compilation with Qt namespaces
hausmann@webkit.org [Tue, 15 Apr 2008 09:40:59 +0000 (09:40 +0000)]
Fix compilation with Qt namespaces

Qt can be configured to have all of its classes inside a specified namespaces.
This is for example used in plugin/component environments like Eclipse.

This change makes it possible to let the Qt port compile against a namespaced
Qt by the use of macros Qt provides to properly forward declare Qt classes in
the namespace.

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-14 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 15 Apr 2008 00:47:39 +0000 (00:47 +0000)]
2008-04-14  Brady Eidson  <beidson@apple.com>

        Fix up a recent Changelog comment that I never updated

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
beidson@apple.com [Tue, 15 Apr 2008 00:45:03 +0000 (00:45 +0000)]

2008-04-14  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        Lay the underpinnings for LocalStorage.

        For now, this just exposes window.localStorage to the dom which returns an in-memory Storage object, much
        like SessionStorage.  The primary difference at this point is that the object returned is shared globally,
        and isn't copied for new top-level browsing contexts like SessionStorage.

        Later, I'll add proper event dispatch and a persistent storage backing.

        * GNUmakefile.am:
        * WebCore.base.exp:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::mark): Mark the optionalLocalStorage

        * page/DOMWindow.cpp:
        * page/DOMWindow.h:

        * storage/LocalStorage.cpp: Added.
        * storage/LocalStorage.h: Added.

        * storage/SessionStorage.cpp: Refactor to use the client interface for event dispatching for sessionStorage objects
        * storage/SessionStorage.h:

        * storage/StorageArea.cpp: Add a client parameter, and call to the client when an item is changed or removed.
        * storage/StorageArea.h:

        * storage/StorageAreaClient.h: Added.  Break out "itemChanged" and "itemRemoved" to a StorageAreaClient
          This way, both SessionStorage and LocalStorage areas can have different behavior on changes with
          that behavior managed from a central location.


2008-04-14  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        As underpinnings for LocalStorage are laid, it is exposed to the dom - update the relevant layout tests.

        * fast/dom/Window/window-properties-expected.txt:
        * storage/domstorage/window-attributes-exist-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
beidson@apple.com [Tue, 15 Apr 2008 00:40:33 +0000 (00:40 +0000)]

2008-04-14  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        Add a hidden pref to debug WebArchive loading.  With this pref on, when loading a WebArchive,
        if the resource isn't in the ArchiveResourceCollection, the loader will not fall back to the
        network and will instead fail the load as "cancelled."

        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::load): Do the check here.

        * page/Settings.cpp:
        * page/Settings.h:


2008-04-14  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        Add a hidden pref to debug WebArchive loading.  With this pref on, when loading a WebArchive,
        if the resource isn't in the ArchiveResourceCollection, the loader will not fall back to the
        network and will instead fail the load as "cancelled."

        * WebView/WebPreferenceKeysPrivate.h:

        * WebView/WebPreferences.m:
        (+[WebPreferences initialize]):
        (-[WebPreferences _webArchiveDebugModeEnabled]):
        * WebView/WebPreferencesPrivate.h:

        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-14 Antti Koivisto <antti@apple.com>
antti@apple.com [Mon, 14 Apr 2008 23:55:19 +0000 (23:55 +0000)]
2008-04-14  Antti Koivisto  <antti@apple.com>

        Reviewed by Eric.

        Some preparations for additive animations and animations in <use>.
        - Disallow animation elements in instance trees.
        - Fix buggy SVGUseElement::removeDisallowedElementsFromSubtree(), make it
          public and static
        - Invoke it from SVGElementInstance::updateInstance() to clean up the instance tree
          there as well.
        - Add mechanism for blocking instance updates when an animation changes
          the referenced tree.

        The added assert in SVGSMILElement::insertedIntoDocument() verifies the fixes
        with the existing test cases.

        * svg/SVGAElement.cpp:
        * svg/SVGElementInstance.cpp:
        * svg/SVGStyledElement.cpp:
        * svg/SVGStyledElement.h:
        * svg/SVGUseElement.cpp:
        * svg/SVGUseElement.h:
        * svg/animation/SVGSMILElement.cpp:
        * svg/animation/SVGSMILElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Don't let the inspected page overwrite properties of JS objects in the Inspector
aroben@apple.com [Mon, 14 Apr 2008 23:46:40 +0000 (23:46 +0000)]
    Don't let the inspected page overwrite properties of JS objects in the Inspector



        Reviewed by Sam Weinig and Geoff Garen.

        Tests (contributed by Adam Barth and Collin Jackson):

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        Added new files to the projects.

        * bindings/js/JSQuarantinedObjectWrapper.cpp: Added.
        (WebCore::JSQuarantinedObjectWrapper::asWrapper): Converts a JSValue
        into a JSQuarantinedObjectWrapper, if the JSValue is in fact a
        (WebCore::JSQuarantinedObjectWrapper::cachedValueGetter): Callback to
        be used with PropertySlot.
        Hold onto the object we're wrapping and its global object. Pass the
        wrapped prototype up to the JSObject constructor.
        Returns true if our underlying object originated from the same global
        object as the passed-in ExecState.
        Wraps and moves an exception from our underlying ExecState to the
        passed-in one.
        (WebCore::JSQuarantinedObjectWrapper::mark): Marks ourselves and the
        objects we're holding references to.

        JSObject overrides. These each check the appropriate permission before
        allowing the call to proceed. We wrap all outgoing values using
        m_wrapOutgoingValue, and we prepare all incoming values with the
        virtual prepareIncomingValue function. If an exception is raised when
        calling the underlying object, we transfer the exception in wrapped
        form to the passed-in ExecState.

        * bindings/js/JSQuarantinedObjectWrapper.h: Added.
        (WebCore::JSQuarantinedObjectWrapper::className): We return the
        underlying object's class name so that we can successfully masquerade
        as that underlying object when, e.g., Object.prototype.toString is
        called on us.

        These virtual methods let subclasses define the allowed operations on
        the wrapped object. By default all operations are disabled.

        * bindings/js/JSInspectedObjectWrapper.cpp: Added. This subclass of
        JSQuarantinedObjectWrapper is used to wrap objects from the inspected
        page being passed to the Inspector.
        (WebCore::JSInspectedObjectWrapper::wrap): Wraps the passed-in object
        if needed and returns the wrapper. If this object has been wrapped
        previously we'll return the old wrapper rather than make a new one.
        (WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper): Add
        ourselves to the wrapper map.
        (WebCore::JSInspectedObjectWrapper::~JSInspectedObjectWrapper): Remove
        ourselves from the wrapper map.
        (WebCore::JSInspectedObjectWrapper::prepareIncomingValue): Ensure that
        any objects passed to the inspected object are either wrappers around
        objects from the inspected page (in which case we unwrap them so that
        the inspected page never sees the wrapper), or wrapped callbacks from
        the Inspector.
        * bindings/js/JSInspectedObjectWrapper.h: Added.
        These all return true so that the Inspector can use objects from the
        inspected page however it needs.
        (WebCore::JSInspectedObjectWrapper::wrapOutgoingValue): Wrap all
        outgoing values as JSInspectedObjectWrappers.

        * bindings/js/JSInspectorCallbackWrapper.cpp: Added. This subclass of
        JSQuarantinedObjectWrapper is used to wrap callbacks that the
        Inspector passes to the inspected page (e.g., for event listeners or
        client-side storage callbacks).
        (WebCore::JSInspectorCallbackWrapper::wrap): Wraps the passed-in
        object if needed and returns the wrapper. If this object has been
        wrapped previously we'll return the old wrapper rather than make a new
        (WebCore::JSInspectorCallbackWrapper::JSInspectorCallbackWrapper): Add
        ourselves to the wrapper map.
        Remove ourselves from the wrapper map.
        (WebCore::JSInspectorCallbackWrapper::prepareIncomingValue): Ensure
        that values passed from the inspected page to an Inspector callback
        are wrapped in JSInspectedObjectWrappers. We also allow the inspected
        page to pass ourselves in (which will happen in the case of a
        client-side storage callback, where the callback itself is passed as
        the `this` object). In this case we unwrap ourselves so that the
        Inspector doesn't have to deal with the wrapper.
        * bindings/js/JSInspectorCallbackWrapper.h: Added.
        This is the only allowed operation on a JSInspectorCallbackWrapper.
        (WebCore::JSInspectorCallbackWrapper::wrapOutgoingValue): Wrap all
        outgoing values as JSInspectorCallbackWrappers.

        * page/InspectorController.cpp:
        (WebCore::getResourceDocumentNode): Wrap the Document before passing
        it to the Inspector.
        (WebCore::highlightDOMNode): Unwrap the Node that the Inspector passed
        to us.
        (WebCore::databaseTableNames): Unwrap the Database that the Inspector
        passed to us.
        (WebCore::inspectedWindow): Wrap the Window before passing it to the
        (WebCore::InspectorController::focusNode): Wrap the Node before
        passing it to the Inspector.
        (WebCore::wrapCallback): Wraps the passed-in callback in a
        (WebCore::InspectorController::addDatabaseScriptResource): Wrap the
        Database beore pasing it to the Inspector.
        (WebCore::InspectorController::windowScriptObjectAvailable): Add the
        new wrapCallback function to the InspectorController JS object.

        * page/inspector/ElementsPanel.js:
        (WebInspector.ElementsPanel.reset): Wrap the contentLoaded callback.

        * page/inspector/DatabaseQueryView.js:
        * page/inspector/DatabaseTableView.js:
        Pass null instead of an empty array to executeSql since we're no
        longer allowed to pass any unwrapped objects to the inspected page.
        We now wrap all callbacks being passed to the inspected page using

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Use prototypes/constructors from the inspected page when operating on objects...
aroben@apple.com [Mon, 14 Apr 2008 23:45:37 +0000 (23:45 +0000)]
    Use prototypes/constructors from the inspected page when operating on objects from the inspected page

        Reviewed by Tim Hatcher.

        * page/inspector/Console.js:
        (WebInspector.ConsolePanel._format): Use the Node constructor from the
        inspected Window with the instanceof operator.
        * page/inspector/ElementsPanel.js:
        (WebInspector.DOMNodeTreeElement._attributeEditingCommitted): Use the
        Element prototype from the inspected Window instead of the Element
        prototype from this Window.
        * page/inspector/inspector.js:
        (WebInspector.performSearch): Ditto for Document prototype.
        * page/inspector/utilities.js:
        (Object.type): Now takes an optional Window parameter that is used to
        find the built-in constructors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Don't store objects from the Inspector on CSSStyleRules from the inspected...
aroben@apple.com [Mon, 14 Apr 2008 23:45:00 +0000 (23:45 +0000)]
    Don't store objects from the Inspector on CSSStyleRules from the inspected page

        Reviewed by Tim Hatcher.

        * page/inspector/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.update): Don't store raw CSSStyleRules
        from the inspected page in the styleRules array. Instead, always use a
        wrapper object. This will keep us from setting Inspector objects as
        properties of inspected objects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixes a regression where clicking a resource URL in the Console would not
timothy@apple.com [Mon, 14 Apr 2008 22:47:03 +0000 (22:47 +0000)]
Fixes a regression where clicking a resource URL in the Console would not
show the resource in the Resources panel.


Reviewed by Adam Roben.

* page/inspector/Console.js:
(WebInspector.Console.prototype._messagesClicked): Removed console-message-url
handling to show resources. This is now handled by WebInspector.showResourceForURL.
(WebInspector.ConsoleMessage.prototype.toMessageElement): Add the webkit-html-resource-link
class name to the URL anchor. Also add the line number as a property to the anchor.
* page/inspector/ResourcesPanel.js:
(WebInspector.ResourcesPanel): Add a reference to the tree element to each calculator.
(WebInspector.ResourcesPanel.prototype.showResource): Select and reveal the resource in
the sidebar. Call showLine on the resource view if it is implemented.
(WebInspector.ResourcesPanel.prototype.closeVisibleResource): Select the current calculator's
tree element in the sidebar.
(WebInspector.ResourcesPanel.prototype._graphSelected): Call closeVisibleResource after
the calculator changes since closeVisibleResource uses the calculator.
* page/inspector/SourceView.js:
(WebInspector.SourceView.prototype.sourceRow): Early return if the line is null/zero.
(WebInspector.SourceView.prototype.showLine):  Renamed from showSourceLine.
* page/inspector/inspector.css:
(body.console-visible #main-panels): Made the bottom 24px to match
the height of #main-status-bar.
(.console-message-url): Make the color important so it wins over
the .webkit-html-resource-link rule.
(.resource-view .resource-view-content): Made more generic from .image
so all resource views get sized correctly.
(.resource-view.image .resource-view-content): Removed.
* page/inspector/inspector.js:
(WebInspector.documentClick): Pass the line number from the anchor to
(WebInspector.showResourceForURL): Add line number support. Pass the line
to ResourcesPanel.showResource.
(WebInspector.addMainEventListeners): Use bind for the event listeners.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-14 Xan Lopez <xan@gnome.org>
alp@webkit.org [Mon, 14 Apr 2008 20:18:18 +0000 (20:18 +0000)]
2008-04-14  Xan Lopez  <xan@gnome.org>

        Reviewed by Alp Toker.

        Bug 17917: Cookie support for HTTP soup backend

        Initial implementation of cookies for the http soup backend.

        Moved CookieJarGtk to CookieJarSoup in network/soup and left the original
        one as CookieJarCurl in network/curl.

        Bumped the libsoup required version to 2.23 for cookie support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-14 Holger Freyther <zecke@selfish.org>
alp@webkit.org [Mon, 14 Apr 2008 20:06:02 +0000 (20:06 +0000)]
2008-04-14  Holger Freyther  <zecke@selfish.org>

        Reviewed by Alp Toker.

        Enable Page caching and create FrameViews on the fly

        Create the FrameView on the fly and cache pages

        - Keep a copy of the GtkAdjustment to be able to reuse it for the
        - Do not initially create a FrameView and update the WebKit code to
          cope with not having a view.
        - Cache seven pages by default.

        * platform/gtk/ScrollViewGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-14 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 14 Apr 2008 19:55:07 +0000 (19:55 +0000)]
2008-04-14  David Hyatt  <hyatt@apple.com>

        Add a new optimized layout path for positioned objects that move.  Also avoid always marking the <html>
        object for layout when it has a percentage height, since the RenderView already does that when its size

        Reviewed by mjs

        * rendering/RenderBlock.cpp:
        * rendering/RenderBox.h:
        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:
        * rendering/RenderStyle.cpp:
        * rendering/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd generated gradients layout test.
hyatt@apple.com [Mon, 14 Apr 2008 19:30:13 +0000 (19:30 +0000)]
Add generated gradients layout test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd generated gradients layout test.
hyatt@apple.com [Mon, 14 Apr 2008 19:29:57 +0000 (19:29 +0000)]
Add generated gradients layout test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-14 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 14 Apr 2008 19:28:53 +0000 (19:28 +0000)]
2008-04-14  David Hyatt  <hyatt@apple.com>

        Add support for gradients in the CSS content property.

        Reviewed by olliej

        Added fast/gradients/generated-gradients.html

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * css/CSSParser.cpp:
        * css/CSSStyleSelector.cpp:
        * css/CSSStyleSelector.h:
        * html/HTMLImageElement.cpp:
        * rendering/RenderContainer.cpp:
        * rendering/RenderImage.cpp:
        * rendering/RenderImage.h:
        * rendering/RenderImageGeneratedContent.cpp: Added.
        * rendering/RenderImageGeneratedContent.h: Added.
        * rendering/RenderObject.cpp:
        * rendering/RenderStyle.cpp:
        * rendering/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-14 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 14 Apr 2008 18:48:16 +0000 (18:48 +0000)]
2008-04-14  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Don't leak the prototype class.

        * API/JSClassRef.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix build.
sfalken@apple.com [Mon, 14 Apr 2008 18:33:39 +0000 (18:33 +0000)]
    Fix build.

        * wtf/ThreadingWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-14 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 14 Apr 2008 18:09:40 +0000 (18:09 +0000)]
2008-04-14  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam, but Anders too, and he was more thorough in his review
        and thats the only reason Sam beat him

        Swap the Page and SecurityOrigin arguments when creating a StorageArea.

        SecurityOrigin is really the primary identifying characteristic of a StorageArea,
        and StorageAreas that represent LocalStorage won't have an owner Page.

        * storage/SessionStorage.cpp:

        * storage/StorageArea.cpp:
        (WebCore::StorageArea::dispatchStorageEvent): Null check m_page here, as in the future
          it might be null
        * storage/StorageArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoForgot to land InspectorLocalizedStrings.js with my last commit.
timothy@apple.com [Mon, 14 Apr 2008 17:09:12 +0000 (17:09 +0000)]
Forgot to land InspectorLocalizedStrings.js with my last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd support for changing the sort order of the resources. The two sorting
timothy@apple.com [Mon, 14 Apr 2008 17:05:29 +0000 (17:05 +0000)]
Add support for changing the sort order of the resources. The two sorting
methods supported current are Time and Size.

Reviewed by Adam Roben.

* page/inspector/Images/statusbarMenuButton.png: Added.
* page/inspector/Images/statusbarMenuButtonSelected.png: Added.
* page/inspector/ResourcesPanel.js:
(WebInspector.ResourcesPanel): Create the status bar menu button and
setup the event listener to call _changeSortingFunction. Each option in
the select references a sorting function.
(WebInspector.ResourcesPanel.get statusBarItems): Add the sorting menu to the
items returned.
(WebInspector.ResourcesPanel._changeSortingFunction): Set the sorting function
to the selected option's function in the sorting menu.
* page/inspector/inspector.css: Added CSS rules for select elements in status bars.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd support for toggling between small and large resource rows
timothy@apple.com [Mon, 14 Apr 2008 17:05:19 +0000 (17:05 +0000)]
Add support for toggling between small and large resource rows

in the Resources panel.

Reviewed by Adam Roben.

* English.lproj/InspectorLocalizedStrings.js: Added new tooltip string.
* page/inspector/Images/largerResourcesButtons.png: Added.
* page/inspector/Images/resourceDocumentIconSmall.png: Added.
* page/inspector/Images/resourcePlainIconSmall.png: Added.
* page/inspector/ResourcesPanel.js:
(WebInspector.ResourcesPanel): Create the status bar button and
setup the event listener to call _toggleLargerResources.
(WebInspector.ResourcesPanel.get statusBarItems): Return the status bar button.
(WebInspector.ResourcesPanel._toggleLargerResources): Toggle the class names
for the resources children list and the status bar button.
* page/inspector/inspector.css: New style rules for small resources
and the status bar item.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago<rdar://problem/5854572> REGRESSION: AXPosition seems to be flipped in nightly build
cfleizach@apple.com [Mon, 14 Apr 2008 16:46:27 +0000 (16:46 +0000)]
<rdar://problem/5854572> REGRESSION: AXPosition seems to be flipped in nightly build
AX was using the wrong method to determine the view to use to create the screen position

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
ap@webkit.org [Mon, 14 Apr 2008 16:30:13 +0000 (16:30 +0000)]
    Reviewed by Adam Roben.

        FastMalloc doesn't release thread-specific data on Windows

        * wtf/ThreadingWin.cpp:
        (WTF::threadMapMutex): (WTF::initializeThreading): Call threadMapMutex once to initialize the static safely.
        (WTF::ThreadFunctionInvocation::ThreadFunctionInvocation): Added a structure to wrap thread entry point and arguments.
        (WTF::wtfThreadEntryPoint): Make sure to end all WTF threads with pthread_exit(), to give pthreads-win32 a chance to call
        destructors of thread-specific data.
        (WTF::createThread): Use _beginthreadex instead of CreateThread, because MSDN says so. Also removed a call to CreateEvent,
        for which I could see no reason at all.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-14 David Smith <catfish.man@gmail.com>
dsmith@webkit.org [Mon, 14 Apr 2008 16:24:01 +0000 (16:24 +0000)]
2008-04-14  David Smith  <catfish.man@gmail.com>

        Reviewed by Timothy Hatcher.

        - Fix https://bugs.webkit.org/show_bug.cgi?id=14258
        Response time vs. download time should be shown in the network profile

        * page/inspector/Resource.js: Change the sorting function to sort by response received time.
        * page/inspector/ResourcesPanel.js: Hook up the existing infrastructure to two bars instead of one; one for the total time, one for the time post-response.
        * page/inspector/inspector.css: Add a new rule to make the waiting bar have a lower opacity, and change the total bar opacity to handle the overlap

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Touched a file to make JavaScriptCore.vcproj rebuild.
ap@webkit.org [Mon, 14 Apr 2008 16:08:15 +0000 (16:08 +0000)]
    Touched a file to make JavaScriptCore.vcproj rebuild.

        * wtf/MathExtras.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Windows build fix
aroben@apple.com [Mon, 14 Apr 2008 15:25:05 +0000 (15:25 +0000)]
    Windows build fix

        Rubberstamped by Alexey Proskuryakov.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Disable
        the "potentially uninitialized variable" warning for grammar.cpp, as
        it seems to be incorrect. yylval gets initialized by the lexer, but
        MSVC doesn't seem to understand this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-14 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Mon, 14 Apr 2008 11:50:21 +0000 (11:50 +0000)]
2008-04-14  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Ap.

        Bug 17403: WebKit Creates Invalid Xhtml Links with Ajax

        The previous code had callbacks for the normal parsing (full document) and fragment parsing.
        The difference was induced by the method we were using which did not accept a xmlParserCtxt.
        The code has been refactored to allow us to share the callbacks between the different cases.
        A drawback is that we have to use xmlParseContent which is an internal libxml method and thus
        some internal intialization is done in WebCore.

        Test: fast/parser/ampersand-escaped-parseXMLFragment.xhtml

        * dom/XMLTokenizer.cpp:
        (WebCore::createStringParser): Moved didInit in the global scope as it is shared by the
        2 create methods.

        (WebCore::createMemoryParser): Create a memory parser similar to the previous code.
        Initialize the xmlParserContext to call xmlParseContent in parseXMLDocumentFragment.

        (WebCore::XMLTokenizer::initializeParserContext): Check m_parsingFragment to know
        which create method to call.

        * dom/XMLTokenizer.h: Added parseXMLDocumentFragment as a friend of XMLTokenizer.

2008-04-14  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Ap.

        Layout test for http://bugs.webkit.org/show_bug.cgi?id=17403:
        WebKit Creates Invalid Xhtml Links with Ajax

        * fast/parser/ampersand-escaped-parseXMLFragment-expected.txt: Added.
        * fast/parser/ampersand-escaped-parseXMLFragment.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric.
rwlbuis@webkit.org [Mon, 14 Apr 2008 06:53:48 +0000 (06:53 +0000)]
    Reviewed by Eric.

        tspan in link not working

        Implement SVG Errata: "The 'a' element may contain any
        element that its parent may contain, except itself."

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-13 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 14 Apr 2008 06:23:50 +0000 (06:23 +0000)]
2008-04-13  David Hyatt  <hyatt@apple.com>

        Fix for bug 18466, WebKit exhibits slow performance on Opera DHTML benchmark.  Improve layout's rect
        invalidation code to only invalidate a single unioned rect once enough individual little rects have
        been detected.

        Reviewed by olliej

        * page/FrameView.cpp:
        * page/FrameView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver.
eric@webkit.org [Mon, 14 Apr 2008 05:51:10 +0000 (05:51 +0000)]
    Reviewed by Oliver.

        Fix spelling error in function name, no test case.

        * svg/SVGTextContentElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver.
eric@webkit.org [Mon, 14 Apr 2008 05:22:50 +0000 (05:22 +0000)]
    Reviewed by Oliver.

        Build fix for +SVG_ANIMATION -SVG_FOREIGN_OBJECT build, no tests.

        * svg/SVGAnimateMotionElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-13 Jan Michael Alonzo <jmalonzo@unpluggable.com>
alp@webkit.org [Mon, 14 Apr 2008 02:46:47 +0000 (02:46 +0000)]
2008-04-13  Jan Michael Alonzo  <jmalonzo@unpluggable.com>

        Reviewed by Oliver Hunt.

        [Gtk] Build breaks if SVG is enabled but SVG Fonts disabled

        * svg/SVGAltGlyphElement.idl: Add SVG_FONTS in Conditional

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-13 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Mon, 14 Apr 2008 01:49:04 +0000 (01:49 +0000)]
2008-04-13  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by David.

        More SVG filters build fix.

        * svg/graphics/filters/SVGFEImage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-13 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sun, 13 Apr 2008 17:47:10 +0000 (17:47 +0000)]
2008-04-13  David Hyatt  <hyatt@apple.com>

        Fix build bustage on the filters SVG code path (not built by default).

        * svg/SVGFEImageElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-13 Dan Winship <danw@gnome.org>
alp@webkit.org [Sun, 13 Apr 2008 17:38:21 +0000 (17:38 +0000)]
2008-04-13  Dan Winship  <danw@gnome.org>

        Reviewed by Alp Toker.

        return body data incrementally from libsoup backend

        Fix libsoup backend to pass data to the loader incrementally
        rather than all at once at the end.

        * platform/network/soup/ResourceHandleSoup.cpp
        (ResourceHandle::start): connect to "got-headers" and "got-chunk"
        signals on the message
        (gotHeadersCallback): call client->didReceiveResponse() from here
        (gotChunkCallback): call client->didReceiveData() from here
        (finishedCallback): renamed from dataCallback. mostly just calls
        client->didFinishLoading() now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Jessica Kahn.
mitz@apple.com [Sun, 13 Apr 2008 16:57:07 +0000 (16:57 +0000)]
    Reviewed by Jessica Kahn.

        - remove duplicate condition in canHaveChildrenForEditing()

        * editing/htmlediting.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
mitz@apple.com [Sun, 13 Apr 2008 15:56:35 +0000 (15:56 +0000)]
    Reviewed by Darin Adler.

        - fix http://bugs.webkit.org/show_bug.cgi?id=18307
          <rdar://problem/5842546> REGRESSION (r31620): Incorrect Hiragino Kaku Gothic, font-weight:500

        Test: fast/css/font-weight-1.html

        * platform/graphics/mac/FontCacheMac.mm:
        (WebCore::toAppKitFontWeight): Adjusted the mapping to cover the AppKit
        weight range from 2 to 12, because AppKit weight 1 never occurs. The
        new mapping matches font-weight: n00 to ISO weight Wn.
        * platform/mac/WebFontCache.mm:
        (betterChoice): Changed the midpoint used when deciding between two
        candidates that deviate from the desired weight by the same amount.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-12 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sun, 13 Apr 2008 08:16:23 +0000 (08:16 +0000)]
2008-04-12  David Hyatt  <hyatt@apple.com>

        Memory management cleanup for the new StyleCachedImage and StyleGeneratedImage classes.  Make the back end
        values hold refptrs to cached front end values.  This will avoid malloc churn as RenderStyles get

        Reviewed by olliej

        * css/CSSCursorImageValue.cpp:
        * css/CSSCursorImageValue.h:
        * css/CSSImageGeneratorValue.cpp:
        * css/CSSImageGeneratorValue.h:
        * css/CSSImageValue.cpp:
        * css/CSSImageValue.h:
        * css/CSSStyleSelector.cpp:
        * css/CSSStyleSelector.h:
        * rendering/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-12 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Sun, 13 Apr 2008 03:38:12 +0000 (03:38 +0000)]
2008-04-12  Julien Chaffraix  <jchaffraix@webkit.org>

        Not reviewed, Qt build fix.

        * dom/XMLTokenizer.cpp:
        * platform/graphics/qt/GraphicsContextQt.cpp:
        * platform/qt/ClipboardQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd list item gradient test.
hyatt@apple.com [Sun, 13 Apr 2008 00:26:08 +0000 (00:26 +0000)]
Add list item gradient test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd list item gradient test.
hyatt@apple.com [Sun, 13 Apr 2008 00:25:54 +0000 (00:25 +0000)]
Add list item gradient test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-12 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sun, 13 Apr 2008 00:25:35 +0000 (00:25 +0000)]
2008-04-12  David Hyatt  <hyatt@apple.com>

        Add support for list-style-image gradients.  Also improve the image comparisons between two RenderStyles
        to not mistakenly believe that images have changed.

        Reviewed by olliej

        Added fast/gradients/list-item-gradient.html

        * css/CSSComputedStyleDeclaration.cpp:
        * css/CSSParser.cpp:
        * css/CSSStyleSelector.cpp:
        * rendering/RenderListMarker.cpp:
        * rendering/RenderListMarker.h:
        * rendering/RenderStyle.cpp:
        * rendering/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-04-12 Matt Lilek <webkit@mattlilek.com>
pewtermoose@webkit.org [Sat, 12 Apr 2008 23:01:57 +0000 (23:01 +0000)]
2008-04-12  Matt Lilek  <webkit@mattlilek.com>

        Not reviewed, build fix.

        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - Windows build fix
mitz@apple.com [Sat, 12 Apr 2008 22:46:13 +0000 (22:46 +0000)]
    - Windows build fix

        * platform/win/ClipboardWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agowx build fix. Update clip to take a FloatRect.
kevino@webkit.org [Sat, 12 Apr 2008 22:37:24 +0000 (22:37 +0000)]
wx build fix. Update clip to take a FloatRect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd a missing null check to stop crashing when a border image is examined but null.
hyatt@apple.com [Sat, 12 Apr 2008 08:33:19 +0000 (08:33 +0000)]
Add a missing null check to stop crashing when a border image is examined but null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand results for border gradient tests.
hyatt@apple.com [Sat, 12 Apr 2008 08:12:30 +0000 (08:12 +0000)]
Land results for border gradient tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd complex border image gradient test.
hyatt@apple.com [Sat, 12 Apr 2008 08:11:59 +0000 (08:11 +0000)]
Add complex border image gradient test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31839 268f45cc-cd09-0410-ab3c-d52691b4dbfc