WebKit-https.git
9 years agoUpgrade WordPress's Akismet plug-in to the latest version.
mrowe@apple.com [Tue, 15 Nov 2011 00:21:53 +0000 (00:21 +0000)]
Upgrade WordPress's Akismet plug-in to the latest version.

* blog/wp-content/plugins/akismet:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTest getting / setting display: -webkit-flexbox and -webkit-flexbox-inline
jchaffraix@webkit.org [Tue, 15 Nov 2011 00:20:14 +0000 (00:20 +0000)]
Test getting / setting display: -webkit-flexbox and -webkit-flexbox-inline
https://bugs.webkit.org/show_bug.cgi?id=72318

Reviewed by Tony Chang.

Test that covers the change for bug 72296 and also increase our flexbox coverage.

* css3/flexbox/display-flexbox-set-get-expected.txt: Added.
* css3/flexbox/display-flexbox-set-get.html: Added.
* css3/flexbox/resources/display-flexbox-set-get.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd buffering to handle mismatch between hardware buffer size and webaudio render...
commit-queue@webkit.org [Tue, 15 Nov 2011 00:18:44 +0000 (00:18 +0000)]
Add buffering to handle mismatch between hardware buffer size and webaudio render size
https://bugs.webkit.org/show_bug.cgi?id=71949

Patch by Raymond Toy <rtoy@google.com> on 2011-11-14
Reviewed by Kenneth Russell.

* src/AudioDestinationChromium.cpp:
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
Create the FIFO for buffering.
(WebCore::AudioDestinationChromium::render):  Get rid of
m_renderCountPerCallback and let the FIFO consume function produce
the appropriate nubmer of calls to the webaudio producer.  Also
remove the rounding of the callback size so we use whatever the
hardware returns.  Removed maximumCallbackBufferSize and use
fifoSize to set the FIFO size.
(WebCore::AudioDestinationChromium::FIFO::FIFO):
(WebCore::AudioDestinationChromium::FIFO::consume):
(WebCore::AudioDestinationChromium::FIFO::findWrapLengths):
(WebCore::AudioDestinationChromium::FIFO::fillBuffer):
Implementation of new FIFO class.
* src/AudioDestinationChromium.h:
(WebCore::AudioDestinationChromium::FIFO::updateIndex):
Define new FIFO class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate one file that was missed.
mrowe@apple.com [Tue, 15 Nov 2011 00:16:59 +0000 (00:16 +0000)]
Update one file that was missed.

* blog/wp-settings.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFurther changes and cleanup to JSString.h and cpp.
msaboff@apple.com [Tue, 15 Nov 2011 00:16:59 +0000 (00:16 +0000)]
Further changes and cleanup to JSString.h and cpp.

Reviewed by Darin Adler.

* runtime/JSString.cpp:
(JSC::JSString::resolveRope): Change PassRefPtr to RefPtr.  Eliminated exec in slow case calls.
(JSC::JSString::resolveRopeSlowCase8): Darin and I agreed that this should have 8 in name.
(JSC::JSString::resolveRopeSlowCase): Removed exec parameter.
* runtime/JSString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpgrade WordPress to v3.2.1.
mrowe@apple.com [Tue, 15 Nov 2011 00:12:56 +0000 (00:12 +0000)]
Upgrade WordPress to v3.2.1.

* blog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDateMath.cpp should not depend on JavaScriptCore
abarth@webkit.org [Tue, 15 Nov 2011 00:04:53 +0000 (00:04 +0000)]
DateMath.cpp should not depend on JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=71747

Reviewed by Darin Adler.

This patch moves the JSC-specific parts of DateMath into JSDateMath in
JavaScriptCore.  There shouldn't be any behavior change.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* runtime/DateConstructor.cpp:
* runtime/DateConversion.cpp:
* runtime/DateInstance.cpp:
* runtime/DateInstanceCache.h:
* runtime/DatePrototype.cpp:
* runtime/InitializeThreading.cpp:
* runtime/JSDateMath.cpp: Copied from Source/JavaScriptCore/wtf/DateMath.cpp.
(JSC::timeToMS):
(JSC::msToSeconds):
* runtime/JSDateMath.h: Copied from Source/JavaScriptCore/wtf/DateMath.h.
* wtf/DateMath.cpp:
(WTF::isLeapYear):
(WTF::msToDays):
(WTF::msToMinutes):
(WTF::msToHours):
(WTF::parseDateFromNullTerminatedCharacters):
(WTF::makeRFC2822DateString):
* wtf/DateMath.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Update ewk_frame_script_execute to return the result for JavaScript
commit-queue@webkit.org [Tue, 15 Nov 2011 00:01:15 +0000 (00:01 +0000)]
[EFL] Update ewk_frame_script_execute to return the result for JavaScript
https://bugs.webkit.org/show_bug.cgi?id=65972

Patch by Jongseok Yang <js45.yang@samsung.com> on 2011-11-14
Reviewed by Antonio Gomes.

It executes the javascript and converts the result to a string using toString.
And it returns the memory-allocated pointer for the value.

* ewk/ewk_frame.cpp:
(ewk_frame_script_execute):
* ewk/ewk_frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Don't special-case "data" URLs in drag-and-drop logic
abarth@webkit.org [Tue, 15 Nov 2011 00:00:00 +0000 (00:00 +0000)]
Source/WebCore: Don't special-case "data" URLs in drag-and-drop logic
https://bugs.webkit.org/show_bug.cgi?id=72322

Reviewed by Eric Seidel.

See the bug for more details.

Test: editing/pasteboard/drag-drop-to-data-url.html

* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::canReceiveDragData):

LayoutTests: Cross-origin drag-and-drop prevention ineffective
https://bugs.webkit.org/show_bug.cgi?id=72322

Reviewed by Eric Seidel.

Split drag-drop-dead-frame.html into two tests: one that tests for the
previous crash and one that tests out data URL drag-and-drop behavior.

* editing/pasteboard/drag-drop-dead-frame.html:
* editing/pasteboard/drag-drop-to-data-url-expected.txt: Added.
* editing/pasteboard/drag-drop-to-data-url.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTowards 8 bit strings - Add 8 bit handling to JSString Ropes
msaboff@apple.com [Mon, 14 Nov 2011 23:51:06 +0000 (23:51 +0000)]
Towards 8 bit strings - Add 8 bit handling to JSString Ropes
https://bugs.webkit.org/show_bug.cgi?id=72317

Added bit to track that a rope is made up of all 8 bit fibers.
Created an 8 bit path (fast and slow cases) to handle 8 bit
only ropes.

Reviewed by Oliver Hunt.

* runtime/JSString.cpp:
(JSC::JSString::resolveRope):
(JSC::JSString::resolveRopeSlowCase8):
(JSC::JSString::resolveRopeSlowCase16):
* runtime/JSString.h:
(JSC::RopeBuilder::finishCreation):
(JSC::RopeBuilder::is8Bit):
(JSC::jsSubstring8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoA little bit of function call cleanup
ggaren@apple.com [Mon, 14 Nov 2011 23:16:27 +0000 (23:16 +0000)]
A little bit of function call cleanup
https://bugs.webkit.org/show_bug.cgi?id=72314

Reviewed by Oliver Hunt.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCall): Renamed callFrame to registerOffset
because this value doesn't give you the offset of the callee's call frame.

(JSC::BytecodeGenerator::emitReturn): Tightened to use equality instead
of greater-than. Removed comment since its reasoning was wrong.

(JSC::BytecodeGenerator::emitConstruct): Updated for rename mentioned above.

(JSC::BytecodeGenerator::isArgumentNumber): Provided a more precise way
to ask this question, giving the bytecode generator more freedom to change
internal implementation details.

* bytecompiler/BytecodeGenerator.h: Reduced default vector capacity because
16 was overkill.
(JSC::CallArguments::registerOffset): Updated for rename mentioned above.

* bytecompiler/NodesCodegen.cpp:
(JSC::CallArguments::CallArguments):
(JSC::CallArguments::newArgument): Factored out argument allocation into
a helper function, so I can change it later.

(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode): Use helper function mentioned above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Pipe compositor commit/swap up to WebWidgetClient
enne@google.com [Mon, 14 Nov 2011 23:10:16 +0000 (23:10 +0000)]
[chromium] Pipe compositor commit/swap up to WebWidgetClient
https://bugs.webkit.org/show_bug.cgi?id=72041

Reviewed by Darin Fisher.

Source/WebCore:

* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::didCommitAndDrawFrame):
(WebCore::CCLayerTreeHost::didCompleteSwapBuffers):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doComposite):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::onSwapBuffersCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
(WebCore::CCThreadProxy::didCommitAndDrawFrame):
(WebCore::CCThreadProxy::didCompleteSwapBuffers):
* platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

* public/WebWidgetClient.h:
(WebKit::WebWidgetClient::didCommitAndDrawCompositorFrame):
(WebKit::WebWidgetClient::didCompleteSwapBuffers):
* src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::didCommitAndDrawFrame):
(WebKit::WebLayerTreeViewImpl::didCompleteSwapBuffers):
* src/WebLayerTreeViewImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::didCommitAndDrawFrame):
(WebKit::WebViewImpl::didCompleteSwapBuffers):
* src/WebViewImpl.h:
* tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHostClient::didCommitAndDrawFrame):
(WTF::MockLayerTreeHostClient::didCompleteSwapBuffers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove the CSS3_FLEXBOX compile time flag and enable on all ports
tony@chromium.org [Mon, 14 Nov 2011 22:51:50 +0000 (22:51 +0000)]
Remove the CSS3_FLEXBOX compile time flag and enable on all ports
https://bugs.webkit.org/show_bug.cgi?id=72196

Reviewed by Ojan Vafai.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSFlexValue.cpp:
* css/CSSFlexValue.h:
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFlex):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSValue.cpp:
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
* css/CSSValue.h:
* css/CSSValueKeywords.in:
* rendering/RenderFlexibleBox.cpp:
* rendering/RenderFlexibleBox.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
* rendering/RenderObject.h:
(WebCore::RenderObject::isFlexibleBoxIncludingDeprecated):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleFlexibleBoxData.cpp:
* rendering/style/StyleFlexibleBoxData.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:

Source/WebKit/chromium:

* features.gypi:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/build-webkit:

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/10424154> testRegExp should not be installed as part of JavaScriptCore
mrowe@apple.com [Mon, 14 Nov 2011 22:47:29 +0000 (22:47 +0000)]
<rdar://problem/10424154> testRegExp should not be installed as part of JavaScriptCore

testRegExp and testapi.js were being installed in the JavaScriptCore framework.
As test-only tools they shouldn't be installed there by default, only when
FORCE_TOOL_INSTALL is set to YES.

This patch incorprorates a few related changes:
1) Make the jsc and testRegExp targets be configured via .xcconfig files.
2) Sets up testRegExp so that SKIP_INSTALL is YES by default, and only NO when
   FORCE_TOOL_INSTALL is YES.
3) Switches the testapi target to using a script build phase to install testapi.js
   so that the installation will be skipped when SKIP_INSTALL is YES. I'm not sure
   why this isn't the built-in behavior when a Copy Files build phase has "Copy only
   when installing" checked, but it doesn't seem to be.
4) Other random cleanup such as removing a bogus group that refers to files that do
   not exist, moving testRegExp.cpp in to the tests group, etc.

Reviewed by Geoff Garen.

* Configurations/JSC.xcconfig: Added.
* Configurations/TestRegExp.xcconfig: Added.
* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] setPageScaleFactor and associated methods should take scaling limits into...
fsamuel@chromium.org [Mon, 14 Nov 2011 22:47:05 +0000 (22:47 +0000)]
[Chromium] setPageScaleFactor and associated methods should take scaling limits into account
https://bugs.webkit.org/show_bug.cgi?id=72176

Source/WebKit/chromium:

Reviewed by Darin Fisher.

A couple of changes:

1. setPageScaleFactorLimits now affects the behavior of other scaling methods
   including setPageScaleFactor.
2. setPageScaleFactorPreservingScrollOffset introduced that scales the scroll offset
   along with the page, preserving the scroll position within the page bounds.

* public/WebView.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::computePageScaleFactorWithinLimits):
(WebKit::WebViewImpl::clampOffsetAtScale):
(WebKit::WebViewImpl::setPageScaleFactorPreservingScrollOffset):
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::setPageScaleFactorLimits):
(WebKit::WebViewImpl::applyScrollAndScale):
* src/WebViewImpl.h:

LayoutTests:

Reviewed by Darin Fisher.

Rebaselined some tests that broke because we now clamp pageScaleFactor to 0.25 (these test at 0.2).

Since this is a Chromium only change, the new baselines are only for Chromium.

* platform/chromium-linux/fast/repaint/scale-page-shrink-expected.png:
* platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt: Added.
* platform/chromium/fast/repaint/background-scaling-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/repaint/scale-page-shrink-expected.png.
* platform/chromium/fast/repaint/background-scaling-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTowards 8 bit strings - Add 8 bit paths to StringImpl methods
msaboff@apple.com [Mon, 14 Nov 2011 22:42:36 +0000 (22:42 +0000)]
Towards 8 bit strings - Add 8 bit paths to StringImpl methods
https://bugs.webkit.org/show_bug.cgi?id=72290

Added 8 bit patchs to StringImpl to number and find methods.

Reviewed by Oliver Hunt.

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::toIntStrict):
(WTF::StringImpl::toUIntStrict):
(WTF::StringImpl::toInt64Strict):
(WTF::StringImpl::toUInt64Strict):
(WTF::StringImpl::toIntPtrStrict):
(WTF::StringImpl::toInt):
(WTF::StringImpl::toUInt):
(WTF::StringImpl::toInt64):
(WTF::StringImpl::toUInt64):
(WTF::StringImpl::toIntPtr):
(WTF::StringImpl::toDouble):
(WTF::StringImpl::toFloat):
(WTF::StringImpl::find):
(WTF::StringImpl::reverseFind):
* wtf/text/WTFString.cpp:
(WTF::toIntegralType):
(WTF::lengthOfCharactersAsInteger):
(WTF::charactersToIntStrict):
(WTF::charactersToUIntStrict):
(WTF::charactersToInt64Strict):
(WTF::charactersToUInt64Strict):
(WTF::charactersToIntPtrStrict):
(WTF::charactersToInt):
(WTF::charactersToUInt):
(WTF::charactersToInt64):
(WTF::charactersToUInt64):
(WTF::charactersToIntPtr):
(WTF::toDoubleType):
(WTF::charactersToDouble):
(WTF::charactersToFloat):
* wtf/text/WTFString.h:
(WTF::find):
(WTF::reverseFind):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMouse Lock: Renaming to 'Pointer Lock': Runtime Enable Flags
scheib@chromium.org [Mon, 14 Nov 2011 22:39:48 +0000 (22:39 +0000)]
Mouse Lock: Renaming to 'Pointer Lock': Runtime Enable Flags
https://bugs.webkit.org/show_bug.cgi?id=72303

Reviewed by Darin Fisher.

Source/WebCore:

* bindings/generic/RuntimeEnabledFeatures.cpp:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webkitPointerLockEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitPointerLockEnabled):
(WebCore::RuntimeEnabledFeatures::webkitPointerEnabled):
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setPointerLockEnabled):
(WebCore::Settings::PointerLockEnabled):

Source/WebKit/chromium:

* public/WebRuntimeFeatures.h:
* public/WebSettings.h:
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enablePointerLock):
(WebKit::WebRuntimeFeatures::isPointerLockEnabled):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setPointerLockEnabled):
* src/WebSettingsImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPlatform-specific results for r100177
robert@webkit.org [Mon, 14 Nov 2011 22:32:51 +0000 (22:32 +0000)]
Platform-specific results for r100177

Unreviewed gardening.

* platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt.
* platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-002-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-002-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-margins-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt.
* platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt.
* platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/css2.1/20110323/table-caption-optional-002-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt.
* platform/chromium-cg-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/fast/table/multiple-captions-display-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/table/multiple-captions-display-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/fast/table/prepend-in-anonymous-table-expected.txt: Copied from LayoutTests/platform/gtk/fast/table/prepend-in-anonymous-table-expected.txt.
* platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.txt: Added.
* platform/chromium-cg-mac/tables/mozilla_expected_failures/other/test4-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/table/dynamic-caption-add-before-child-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/dynamic-caption-add-before-child-expected.png.
* platform/chromium-mac-snowleopard/fast/table/multiple-captions-display-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/multiple-captions-display-expected.png.
* platform/chromium-mac-snowleopard/fast/table/prepend-in-anonymous-table-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/prepend-in-anonymous-table-expected.png.
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/other/test4-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla_expected_failures/other/test4-expected.png.
* platform/chromium-win/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
* platform/chromium-win/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/border-spacing-applies-to-015-expected.txt.
* platform/chromium-win/css2.1/20110323/table-caption-001-expected.png: Added.
* platform/chromium-win/css2.1/20110323/table-caption-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt.
* platform/chromium-win/css2.1/20110323/table-caption-002-expected.png: Added.
* platform/chromium-win/css2.1/20110323/table-caption-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-002-expected.txt.
* platform/chromium-win/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
* platform/chromium-win/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt.
* platform/chromium-win/css2.1/20110323/table-caption-margins-001-expected.png: Added.
* platform/chromium-win/css2.1/20110323/table-caption-margins-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt.
* platform/chromium-win/css2.1/20110323/table-caption-optional-001-expected.png: Added.
* platform/chromium-win/css2.1/20110323/table-caption-optional-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt.
* platform/chromium-win/css2.1/20110323/table-caption-optional-002-expected.png: Added.
* platform/chromium-win/css2.1/20110323/table-caption-optional-002-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt.
* platform/chromium-win/fast/table/dynamic-caption-add-before-child-expected.png:
* platform/chromium-win/fast/table/multiple-captions-display-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.png:
* platform/gtk/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
* platform/gtk/css2.1/20110323/table-caption-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt.
* platform/gtk/css2.1/20110323/table-caption-002-expected.txt: Added.
* platform/gtk/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
* platform/gtk/css2.1/20110323/table-caption-margins-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt.
* platform/gtk/css2.1/20110323/table-caption-optional-001-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt.
* platform/gtk/css2.1/20110323/table-caption-optional-002-expected.txt: Copied from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt.
* platform/gtk/fast/table/dynamic-caption-add-before-child-expected.txt:
* platform/gtk/fast/table/multiple-captions-display-expected.txt:
* platform/gtk/fast/table/prepend-in-anonymous-table-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:
* platform/qt/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
* platform/qt/css2.1/20110323/table-caption-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt.
* platform/qt/css2.1/20110323/table-caption-002-expected.txt: Added.
* platform/qt/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
* platform/qt/css2.1/20110323/table-caption-margins-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt.
* platform/qt/css2.1/20110323/table-caption-optional-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt.
* platform/qt/css2.1/20110323/table-caption-optional-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt.
* platform/qt/fast/table/dynamic-caption-add-before-child-expected.txt:
* platform/qt/fast/table/multiple-captions-display-expected.txt:
* platform/qt/fast/table/prepend-in-anonymous-table-expected.txt:
* platform/qt/tables/mozilla_expected_failures/other/test4-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonew-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug...
commit-queue@webkit.org [Mon, 14 Nov 2011 22:29:04 +0000 (22:29 +0000)]
new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
Override LOCALE to en_US.

Patch by John Yani <vanuan@gmail.com> on 2011-11-14
Reviewed by Eric Seidel.

* Scripts/webkitpy/layout_tests/port/base.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r100176.
commit-queue@webkit.org [Mon, 14 Nov 2011 22:25:51 +0000 (22:25 +0000)]
Unreviewed, rolling out r100176.
http://trac.webkit.org/changeset/100176
https://bugs.webkit.org/show_bug.cgi?id=72309

it broke the Mac builds (missing symbols) in a non-obvious way
(Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-14

Source/WebCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
* html/canvas/WebGLExperimentalCompressedTextures.cpp: Removed.
* html/canvas/WebGLExperimentalCompressedTextures.h: Removed.
* html/canvas/WebGLExperimentalCompressedTextures.idl: Removed.
* html/canvas/WebGLExtension.h:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
* html/canvas/WebGLRenderingContext.h:
* platform/graphics/Extensions3D.h:
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/efl/GraphicsContext3DEfl.cpp:
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
* platform/graphics/qt/GraphicsContext3DQt.cpp:

Source/WebKit/chromium:

* public/WebGraphicsContext3D.h:
* src/GraphicsContext3DChromium.cpp:
* src/GraphicsContext3DPrivate.h:
* tests/MockWebGraphicsContext3D.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIntermittent asserts in TextureMapperGL::bindSurface on MiniBrowser startup
commit-queue@webkit.org [Mon, 14 Nov 2011 22:22:02 +0000 (22:22 +0000)]
Intermittent asserts in TextureMapperGL::bindSurface on MiniBrowser startup
https://bugs.webkit.org/show_bug.cgi?id=72299

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-11-14
Reviewed by Noam Rosenthal.

Added check that clipping rect is valid.
Clear GL error that might remain from QT GL operations.
Added GL error assert for scissor test operations.

* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::paintToCurrentGLContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoremove -wap-marquee css propery value
tony@chromium.org [Mon, 14 Nov 2011 21:55:38 +0000 (21:55 +0000)]
remove -wap-marquee css propery value
https://bugs.webkit.org/show_bug.cgi?id=72296

Reviewed by Adam Barth.

This css value is no longer used.

* css/CSSValueKeywords.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJS Test Harness: Remove one more reference to non existing js-test-post-function.js
arv@chromium.org [Mon, 14 Nov 2011 21:49:51 +0000 (21:49 +0000)]
JS Test Harness: Remove one more reference to non existing js-test-post-function.js
https://bugs.webkit.org/show_bug.cgi?id=72307

Reviewed by Ojan Vafai.

* storage/indexeddb/mozilla/delete-result.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOnly send progress notifications for the main frame
andersca@apple.com [Mon, 14 Nov 2011 21:48:23 +0000 (21:48 +0000)]
Only send progress notifications for the main frame
https://bugs.webkit.org/show_bug.cgi?id=72302

Reviewed by Sam Weinig.

Since it's impossible in the API to tell which frame the progress notifications are for, just send them to the main frame for now.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::postProgressStartedNotification):
(WebKit::WebFrameLoaderClient::postProgressEstimateChangedNotification):
(WebKit::WebFrameLoaderClient::postProgressFinishedNotification):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] build-webkit silently drops the features flags
jchaffraix@webkit.org [Mon, 14 Nov 2011 21:45:52 +0000 (21:45 +0000)]
[Chromium] build-webkit silently drops the features flags
https://bugs.webkit.org/show_bug.cgi?id=72293

Reviewed by Tony Chang.

Chromium still ignores @features but now we give a warning!

* Scripts/build-webkit: Check if one of the features is different
from the default and print a warning in this case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in RenderTableSection::splitColumn
jchaffraix@webkit.org [Mon, 14 Nov 2011 21:21:43 +0000 (21:21 +0000)]
Crash in RenderTableSection::splitColumn
https://bugs.webkit.org/show_bug.cgi?id=70171

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/crash-splitColumn-2.html
       fast/table/crash-splitColumn-3.html
       fast/table/crash-splitColumn.html

The old code would not take into account the fact that each RenderTableSection
can set its m_needsCellRecalc flag independently of the rest.

This means that you cannot assume that you can always split or append columns to
all the sections. Our approach is to skip sections needing cell recalc in several
parts of the code as they will be properly reset to the table's representations
during a cell recalc.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):
Skip sections needing cell recalc as they will be properly updated later.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addCell):
Ignore a section needing cell recalc as addCell will be called after sync'ing
the internal column representation in recalcCells.

(WebCore::RenderTableSection::recalcCells):
Clear the flag at the beginning of the function to activate the previous functions.
Added a comment as to why this is fine.

(WebCore::RenderTableSection::appendColumn):
Added an ASSERT. If we need cell recalc, we should NEVER update m_grid outside
of recalcCells().

LayoutTests:

Added a couple of tests where different sections get their
m_needsCellRecalc set independently.

* fast/table/crash-splitColumn-2-expected.txt: Added.
* fast/table/crash-splitColumn-2.html: Added.
* fast/table/crash-splitColumn-3-expected.txt: Added.
* fast/table/crash-splitColumn-3.html: Added.
* fast/table/crash-splitColumn-expected.txt: Added.
* fast/table/crash-splitColumn.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove the concept of an empty SecurityOrigin
abarth@webkit.org [Mon, 14 Nov 2011 20:58:30 +0000 (20:58 +0000)]
Remove the concept of an empty SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=72287

Reviewed by Eric Seidel.

Source/WebCore:

This concept is fragile and doesn't exist in the specs.  Previous
patches have removed most of the code relying upon this function.  This
patch removes a couple stragglers.

* page/DOMWindow.cpp:
(WebCore::DOMWindow::postMessage):
    - This check should really be about unique origins because it
      doesn't make sense to target postMessages at unique origins, as
      explained in the comment.
* page/SecurityOrigin.cpp:
* page/SecurityOrigin.h:

Source/WebKit/chromium:

I'll rename the API in a subsequent patch.

* src/WebSecurityOrigin.cpp:
(WebKit::WebSecurityOrigin::isEmpty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSecurityContext::isSecureTransitionTo should not refer to empty security origins
abarth@webkit.org [Mon, 14 Nov 2011 20:56:15 +0000 (20:56 +0000)]
SecurityContext::isSecureTransitionTo should not refer to empty security origins
https://bugs.webkit.org/show_bug.cgi?id=72277

Reviewed by Eric Seidel.

Now that we're tracking the "failed to initialized SecurityOrigin"
state explicitly, we should use that to determine whether we can make a
secure transition.

* dom/SecurityContext.cpp:
(WebCore::SecurityContext::isSecureTransitionTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMouse Lock: Renaming to 'Pointer Lock': ENABLE Flags
scheib@chromium.org [Mon, 14 Nov 2011 20:50:14 +0000 (20:50 +0000)]
Mouse Lock: Renaming to 'Pointer Lock': ENABLE Flags
https://bugs.webkit.org/show_bug.cgi?id=72286

Reviewed by Adam Barth.

Source/JavaScriptCore:

* wtf/Platform.h:

Source/WebCore:

* bindings/generic/RuntimeEnabledFeatures.cpp:
* bindings/generic/RuntimeEnabledFeatures.h:
* dom/MouseEvent.idl:
* dom/MouseRelatedEvent.h:
* page/MouseLockable.cpp:
* page/MouseLockable.h:
* page/MouseLockable.idl:
* page/Navigator.cpp:
* page/Navigator.h:
* page/Navigator.idl:
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:

Source/WebKit/chromium:

* features.gypi:
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableMouseLockAPI):
(WebKit::WebRuntimeFeatures::isMouseLockAPIEnabled):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setMouseLockEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed; skipping newly failing tests which need rebaselining.
jer.noble@apple.com [Mon, 14 Nov 2011 20:48:27 +0000 (20:48 +0000)]
Unreviewed; skipping newly failing tests which need rebaselining.

Added skipped tests; tracked by https://bugs.webkit.org/show_bug.cgi?id=72297.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove TextTrackCueIndex and TextTrackCueSet. No longer needed.
annacc@chromium.org [Mon, 14 Nov 2011 20:46:51 +0000 (20:46 +0000)]
Remove TextTrackCueIndex and TextTrackCueSet.  No longer needed.
https://bugs.webkit.org/show_bug.cgi?id=72216

Reviewed by Sam Weinig.

No new tests. No new functionality.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* html/TextTrackCueIndex.cpp: Removed.
* html/TextTrackCueIndex.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS 2.1 failure: border-spacing-applies-to-015.htm
robert@webkit.org [Mon, 14 Nov 2011 20:41:04 +0000 (20:41 +0000)]
CSS 2.1 failure: border-spacing-applies-to-015.htm
https://bugs.webkit.org/show_bug.cgi?id=69773

Reviewed by David Hyatt.

Source/WebCore:

The CSS test suite expects UAs to allow multiple captions per table.
Replace m_caption with a Vector called m_captions.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::addChild):
(WebCore::RenderTable::removeChild):
(WebCore::RenderTable::adjustLogicalHeightForCaption):
(WebCore::RenderTable::layout):
(WebCore::RenderTable::addOverflowFromChildren):
(WebCore::RenderTable::paintObject):
(WebCore::RenderTable::subtractCaptionRect):
(WebCore::RenderTable::computePreferredLogicalWidths):
(WebCore::RenderTable::nextColElement):
(WebCore::RenderTable::colElement):
(WebCore::RenderTable::recalcCaption):
(WebCore::RenderTable::recalcSections):
(WebCore::RenderTable::overflowClipRect):
(WebCore::RenderTable::nodeAtPoint):
* rendering/RenderTable.h:

LayoutTests:

* css2.1/20110323/border-spacing-applies-to-015.htm: Added. Now passes!
* css2.1/20110323/table-caption-001.htm: Added. Passed anyway.
* css2.1/20110323/table-caption-002.htm: Added. Now passes!
* css2.1/20110323/table-caption-horizontal-alignment-001.htm: Added. Passed anyway.
* css2.1/20110323/table-caption-margins-001.htm: Added. Passed anyway.
* css2.1/20110323/table-caption-optional-001.htm: Added. Passed anyway.
* css2.1/20110323/table-caption-optional-002.htm: Added. Passed anyway.
* fast/table/dynamic-caption-add-before-child.xhtml: Extra captions now appear in result
                                                     so remove their FAIL notices.
* fast/table/multiple-captions-crash-expected.txt: Result reflects extra captions.
* fast/table/multiple-captions-crash2-expected.txt: Result reflects extra captions.
* fast/table/multiple-captions-display.xhtml: Extra captions now appear in result
                                              so remove their FAIL notices.
* platform/chromium-linux/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/table-caption-001-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/table-caption-001-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/table-caption-002-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/table-caption-002-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/table-caption-margins-001-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/table-caption-optional-001-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/table-caption-optional-002-expected.txt: Added.
* platform/chromium-linux/fast/table/dynamic-caption-add-before-child-expected.png:
  Result reflects extra captions.
* platform/chromium-linux/fast/table/multiple-captions-display-expected.png:
  Result reflects extra captions.
* platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.png:
  Result reflects extra caption.
* platform/chromium-win/fast/table/dynamic-caption-add-before-child-expected.txt:
  Result reflects extra captions.
* platform/chromium-win/fast/table/multiple-captions-display-expected.txt:
  Result reflects extra captions.
* platform/chromium-win/fast/table/prepend-in-anonymous-table-expected.txt:
  Result reflects extra caption.
* platform/chromium-win/tables/mozilla_expected_failures/other/test4-expected.txt:
  Result reflects extra caption.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement WEBGL_EXPERIMENTAL_compressed_textures WebGL extension
commit-queue@webkit.org [Mon, 14 Nov 2011 20:24:13 +0000 (20:24 +0000)]
Implement WEBGL_EXPERIMENTAL_compressed_textures WebGL extension
https://bugs.webkit.org/show_bug.cgi?id=72086

Patch by Gregg Tavares <gman@google.com> on 2011-11-14
Reviewed by Kenneth Russell.

Source/WebCore:

No new tests. Will write final test once on hardware.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
* html/canvas/WebGLExperimentalCompressedTextures.cpp: Added.
(WebCore::WebGLExperimentalCompressedTextures::WebGLExperimentalCompressedTextures):
(WebCore::WebGLExperimentalCompressedTextures::~WebGLExperimentalCompressedTextures):
(WebCore::WebGLExperimentalCompressedTextures::getName):
(WebCore::WebGLExperimentalCompressedTextures::create):
(WebCore::WebGLExperimentalCompressedTextures::supported):
(WebCore::WebGLExperimentalCompressedTextures::validateCompressedTexFormat):
(WebCore::WebGLExperimentalCompressedTextures::validateCompressedTexFuncData):
(WebCore::WebGLExperimentalCompressedTextures::validateCompressedTexSubDimensions):
(WebCore::WebGLExperimentalCompressedTextures::compressedTexImage2D):
(WebCore::WebGLExperimentalCompressedTextures::compressedTexSubImage2D):
(WebCore::WebGLExperimentalCompressedTextures::getCompressedTextureFormats):
* html/canvas/WebGLExperimentalCompressedTextures.h: Added.
* html/canvas/WebGLExperimentalCompressedTextures.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
* html/canvas/WebGLExtension.h:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
* html/canvas/WebGLRenderingContext.h:
* platform/graphics/Extensions3D.h:
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):

Source/WebKit/chromium:

* public/WebGraphicsContext3D.h:
* src/GraphicsContext3DChromium.cpp:
* src/GraphicsContext3DPrivate.h:
* tests/MockWebGraphicsContext3D.h:
(WebKit::MockWebGraphicsContext3D::compressedTexImage2D):
(WebKit::MockWebGraphicsContext3D::compressedTexSubImage2D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=72280
barraclough@apple.com [Mon, 14 Nov 2011 20:23:23 +0000 (20:23 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=72280

Rubber stamped by Geoff Garen.

Fix 32-bit Lion.

* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveAndCommit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agorun-leaks does not work on Lion?
ddkilzer@apple.com [Mon, 14 Nov 2011 20:08:53 +0000 (20:08 +0000)]
run-leaks does not work on Lion?
<http://webkit.org/b/71059>
<rdar://problem/10428527>

Reviewed by Adam Roben.

The output of leaks(1) changed again in Lion to move the
"leaks Report Version: 2.0" line from the first line of the
output to just above the "Process " lines that run-leaks is
interested in parsing.  This required using a more generic
algorithm to find the start of the "Process " lines.

* Scripts/run-leaks:
(parseLeaksOutput): Make the code to skip headers more generic.
* Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Added.
* Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Added.
* Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] MediaStream API: Adding a sources() method to WebMediaStreamDescriptor
commit-queue@webkit.org [Mon, 14 Nov 2011 20:04:53 +0000 (20:04 +0000)]
[chromium] MediaStream API: Adding a sources() method to WebMediaStreamDescriptor
https://bugs.webkit.org/show_bug.cgi?id=72116

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-14
Reviewed by Darin Fisher.

* public/WebMediaStreamDescriptor.h:
* public/WebMediaStreamSource.h:
* src/WebMediaStreamDescriptor.cpp:
(WebKit::WebMediaStreamDescriptor::sources):
* src/WebMediaStreamSource.cpp:
(WebKit::WebMediaStreamSource::operator=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Return more complete error and exception messages when a
michaeln@google.com [Mon, 14 Nov 2011 19:46:46 +0000 (19:46 +0000)]
Source/WebCore: Return more complete error and exception messages when a
WebSQLDatabase function fails. Produce console logging
for openDatabase() errors and vacuum errors. Add a lastErrorMessage
accessor to the DatabaseSync interface.
https://bugs.webkit.org/show_bug.cgi?id=71575

Reviewed by David Levin.

Yes, see LayoutTests/ChangeLog in this patch.

* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::SQLiteDatabase):
(WebCore::SQLiteDatabase::open):
(WebCore::SQLiteDatabase::close):
(WebCore::SQLiteDatabase::lastError):
(WebCore::SQLiteDatabase::lastErrorMsg):
(WebCore::SQLiteDatabase:: runVacuumCommand):
(WebCore::SQLiteDatabase:: runIncrementalVacuumCommand):
Reflect errors in the open() method in lastError() and lastErrorMsg().
Return an error codes for runVacuumCommand() and runIncrementalVacuumCommand().

* platform/sql/SQLiteDatabase.h:
* storage/AbstractDatabase.cpp:
(WebCore::formatErrorMessage):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::logErrorMessage):
During openAndVerify, produce formatted error messages that include what was being done, the sqlite error code,
and the sqlite error message. Add a helper to log message to the console.

* storage/AbstractDatabase.h:
* storage/ChangeVersionWrapper.cpp:
(WebCore::ChangeVersionWrapper::performPreflight):
(WebCore::ChangeVersionWrapper::performPostflight):
* storage/Database.cpp:
(WebCore::Database::openDatabase):
(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::performOpenAndVerify):
* storage/Database.h:
* storage/DatabaseSync.cpp:
(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::runTransaction):
* storage/DatabaseSync.h:
(WebCore::DatabaseSync::lastErrorMessage):
(WebCore::DatabaseSync::setLastErrorMessage):
* storage/DatabaseSync.idl:
Add a lastErrorMessage attribute so javascript callers can
retrieve more detailed information about what went wrong.

* storage/DatabaseTask.cpp:
(WebCore::Database::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::Database::DatabaseOpenTask::doPerformTask):
* storage/DatabaseTask.h:
(WebCore::Database::DatabaseOpenTask::create):
Return an errorMessage in addition to the exception code.

* storage/SQLError.h:
(WebCore::SQLError::create):
Add helpers to produced formatted error messages.

* storage/SQLStatement.cpp:
(WebCore::SQLStatement::execute):
* storage/SQLStatementSync.cpp:
(WebCore::SQLStatementSync::execute):
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::postflightAndCommit):
* storage/SQLTransactionSync.cpp:
(WebCore::SQLTransactionSync::executeSQL):
(WebCore::SQLTransactionSync::begin):
(WebCore::SQLTransactionSync::execute):
(WebCore::SQLTransactionSync::commit):

LayoutTests: Update layout tests for  new websql error messages and console logging.
https://bugs.webkit.org/show_bug.cgi?id=71575

Reviewed by David Levin.

* fast/workers/storage/change-version-handle-reuse-worker-expected.txt:
* fast/workers/storage/executesql-accepts-only-one-statement-sync.html:
* fast/workers/storage/executesql-accepts-only-one-statement-sync-expected.txt:
* fast/workers/storage/open-database-creation-callback-sync-expected.txt:
* fast/workers/storage/open-database-set-empty-version-sync-expected.txt:
* fast/workers/storage/test-authorizer-expected.txt:
* fast/workers/storage/transaction-in-transaction-sync.html:
* fast/workers/storage/transaction-in-transaction-sync-expected.txt:
* storage/change-version-handle-reuse-expected.txt:
* storage/open-database-creation-callback-expected.txt:
* storage/open-database-set-empty-version-expected.txt:
* storage/private-browsing-noread-nowrite-expected.txt:
* storage/test-authorizer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago32-bit Build fix: declare virtual register indices to be int rather than
ggaren@apple.com [Mon, 14 Nov 2011 19:44:32 +0000 (19:44 +0000)]
32-bit Build fix: declare virtual register indices to be int rather than
unsigned, since they can be positive or negative.

For better clarity, explicitly use ReturnPC instead of -1 as the "invalid"
state, since we'll never load and operate on the ReturnPC as a JS value.

* jit/JIT.cpp:
(JSC::JIT::JIT):
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::emitLoadTag):
(JSC::JIT::emitLoadPayload):
(JSC::JIT::emitLoad):
(JSC::JIT::emitLoad2):
(JSC::JIT::emitLoadDouble):
(JSC::JIT::emitLoadInt32ToDouble):
(JSC::JIT::emitStore):
(JSC::JIT::emitStoreInt32):
(JSC::JIT::emitStoreAndMapInt32):
(JSC::JIT::emitStoreCell):
(JSC::JIT::emitStoreBool):
(JSC::JIT::emitStoreDouble):
(JSC::JIT::map):
(JSC::JIT::unmap):
(JSC::JIT::isMapped):
(JSC::JIT::getMappedPayload):
(JSC::JIT::getMappedTag):
(JSC::JIT::emitJumpSlowCaseIfNotJSCell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix typo.
abarth@webkit.org [Mon, 14 Nov 2011 19:39:30 +0000 (19:39 +0000)]
Fix typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSecurityOrigin inheritance should depend on document URL, not on "emptiness" of the...
abarth@webkit.org [Mon, 14 Nov 2011 19:33:02 +0000 (19:33 +0000)]
SecurityOrigin inheritance should depend on document URL, not on "emptiness" of the SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=72283

Reviewed by Sam Weinig.

This change aligns our implementation more closely with the spec.  I
don't think this change has an observable effects, but it moves us
closer to removing the concept of an empty security origin.

* dom/Document.cpp:
(WebCore::shouldInheritSecurityOriginFromOwner):
(WebCore::Document::initSecurityContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unused m_data member from UStringSourceProvider
msaboff@apple.com [Mon, 14 Nov 2011 19:26:41 +0000 (19:26 +0000)]
Remove unused m_data member from UStringSourceProvider
https://bugs.webkit.org/show_bug.cgi?id=72289

Removed unused m_data member from UStringSourceProvider.

Reviewed by Oliver Hunt.

* parser/SourceProvider.h:
(JSC::UStringSourceProvider::UStringSourceProvider):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTowards 8 Bit Strings: Templatize YARR Parser
msaboff@apple.com [Mon, 14 Nov 2011 19:25:40 +0000 (19:25 +0000)]
Towards 8 Bit Strings: Templatize YARR Parser
https://bugs.webkit.org/show_bug.cgi?id=72288

Changed Yarr::Parser to be a template based on character type.

Reviewed by Oliver Hunt.

* yarr/YarrParser.h:
(JSC::Yarr::Parser::Parser):
(JSC::Yarr::parse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago32-bit build fix: Removed unused declaration.
ggaren@apple.com [Mon, 14 Nov 2011 19:23:36 +0000 (19:23 +0000)]
32-bit build fix: Removed unused declaration.

* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStandardized the JS calling convention
ggaren@apple.com [Mon, 14 Nov 2011 19:21:40 +0000 (19:21 +0000)]
Standardized the JS calling convention
https://bugs.webkit.org/show_bug.cgi?id=72221

Reviewed by Oliver Hunt.

This patch standardizes the calling convention so that the caller always
sets up the callee's CallFrame. Adjustments for call type, callee type,
argument count, etc. now always take place after that initial setup.

This is a step toward reversing the argument order, but also has these
immediate benefits (measured on x64):

(1) 1% benchmark speedup across the board.

(2) 50% code size reduction in baseline JIT function calls.

(3) 1.5x speedup for single-dispatch .apply forwarding.

(4) 1.1x speedup for multi-dispatch .apply forwarding.

This change affected the baseline JIT most, since the baseline JIT had
lots of ad hoc calling conventions for different caller / callee types.

* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::branchPtr):
(JSC::MacroAssemblerX86_64::branchAddPtr): Optimize compare to 0 into
a test, like other assemblers do. (I added some compares to 0, and didn't
want them to be slow.)

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump): Merged op_load_varargs into op_call_varargs so
op_call_varargs could share code generation with other forms of op_call.
This is also a small optimization, since op_*varargs no longer have to
pass arguments to each other through the register file.

(JSC::CallLinkInfo::unlink):
* bytecode/CodeBlock.h: Added a new call type: CallVarargs. This allows
us to link functions called through .apply syntax. We need to distinguish
CallVarargs from Call because CallVarargs changes its argument count
on each inovcation, so we must always link to the argument count checking
version of the callee.

* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCallVarargs):
* bytecompiler/BytecodeGenerator.h: Merged op_load_varargs into op_call_varargs.

* bytecompiler/NodesCodegen.cpp:
(JSC::ApplyFunctionCallDotNode::emitBytecode): Ditto. Also, simplified
some of this bytecode generation to remove redundant copies.

* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::emitCall): Added a new call type: CallVarargs.
DFG doesn't support this type, but its code needs to change slightly
to accomodate a 3-state variable.

Stopped passing the argument count in regT1 because this is non-standard.
(The argument count goes in the CallFrame. This trades speed on the slow
path for speed and code size on the fast path, and simplicity on all paths.
A good trade, in my opinion.)

* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction): Tweaked code to make CallFrame
setup more obvious when single-stepping. Also, updated for argument count
not being in regT1.

* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addJSCall):
(JSC::DFG::JITCompiler::JSCallRecord::JSCallRecord): Added a new call
type: CallVarargs.

* dfg/DFGOperations.cpp: Do finish CallFrame setup in one place before
doing anything else. Don't check for stack overflow because we have no callee
registers, and our caller has already checked for its own registers.

* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgLinkFor): We can link to our callee even if our argument
count doesn't match -- we just need to link to the argument count checking
version.

* interpreter/CallFrameClosure.h:
(JSC::CallFrameClosure::setArgument): BUG FIX: When supplying too many
arguments from C++, we need to supply a full copy of the arguments prior
to the subset copy that matches our callee's argument count. (That is what
the standard calling convention would have produced in JS.) I would have
split this into its own patch, but I couldn't find a way to get the JIT
to fail a regression test in this area without my patch applied.

* interpreter/Interpreter.cpp: Let the true code bomb begin!

(JSC::eval): Fixed up this helper function to operate on eval()'s CallFrame,
and not eval()'s caller frame. We no longer leave the CallFrame pointing
to eval()'s caller during a call to eval(), since that is not standard.

(JSC::loadVarargs): Factored out a shared helper function for use by JIT
and interpreter because half the code means one quarter the bugs -- in my
programming, at least.

(JSC::Interpreter::execute): Removed a now-unused way to invoke eval.

(JSC::Interpreter::privateExecute): Removed an invalid ASSERT following
putDirect, because it got in the way of my testing. (When putting a
function, the cached base of a PutPropertySlot can be 0 to signify "do
not optimize".)

op_call_eval: Updated for new, standard eval calling convention.

op_load_varargs: Merged op_load_varargs into op_call_varargs.

op_call_varags: Updated for new, standard eval calling convention. Don't
check for stack overflow because the loadVarargs helper function already
checked.

* interpreter/Interpreter.h:
(JSC::Interpreter::execute): Headers are fun and educational!

* interpreter/RegisterFile.cpp:
(JSC::RegisterFile::growSlowCase):
* interpreter/RegisterFile.h:
(JSC::RegisterFile::grow): Factored out the slow case into a slow
case because it was cramping the style of my fast case.

* jit/JIT.cpp:
(JSC::JIT::privateCompile): Moved initialization of
RegisterFile::CodeBlock to make it more obvious when debugging. Removed
assumption that argument count is in regT1, as above. Removed call to
restoreArgumentReference() because the JITStubCall abstraction does this for us.

(JSC::JIT::linkFor): Link even if we miss on argument count, as above.

* jit/JIT.h:
* jit/JITCall32_64.cpp:
(JSC::JIT::emitSlow_op_call):
(JSC::JIT::emitSlow_op_call_eval):
(JSC::JIT::emitSlow_op_call_varargs):
(JSC::JIT::emitSlow_op_construct):
(JSC::JIT::emit_op_call_eval):
(JSC::JIT::emit_op_call_varargs): Share all function call code generation.
Don't count call_eval when accounting for linkable function calls because
eval doesn't link. (Its fast path is to perform the eval.)

(JSC::JIT::compileLoadVarargs): Ported this inline copying optimization
to our new calling convention. The key to this optimization is the
observation that, in a function that declares no arguments, if any
arguments are passed, they all end up right behind 'this'.

(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase): Factored out eval for a little clarity.

(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase): If you are still with me, dear reader,
this is the whole point of my patch. The caller now unconditionally moves
the CallFrame forward and fills in the data it knows before taking any
branches to deal with weird caller/callee pairs.

This also means that there is almost no slow path for calls -- it all
gets folded into the shared virtual call stub. The only things remaining
in the slow path are the rare case counter and a call to the stub.

* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall): Updated for values being in
different registers or in memory, based on our new standard calling
convention.

Added a shared path for calling out to CTI helper functions for non-JS
calls.

* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_method_check): method_check emits its own code and
the following get_by_id's code, so it needs to add both when informing
result chaining of its result. This is important because the standard
calling convention can now take advantage of this chaining.

* jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::emit_op_call_eval):
(JSC::JIT::emit_op_call_varargs):
(JSC::JIT::emitSlow_op_call):
(JSC::JIT::emitSlow_op_call_eval):
(JSC::JIT::emitSlow_op_call_varargs):
(JSC::JIT::emitSlow_op_construct): Observe, as I write all of my code a
second time, now with 64 bits.

* jit/JITStubs.cpp:
(JSC::throwExceptionFromOpCall):
(JSC::jitCompileFor):
(JSC::arityCheckFor):
(JSC::lazyLinkFor): A lot of mechanical changes here for one purpose:
Exceptions thrown in the middle of a function call now use a shared helper
function (throwExceptionFromOpCall). This function understands that the
CallFrame currently points to the callEE, and the exception must be
thrown by the callER. (The old calling convention would often still have
the CallFrame pointing at the callER at the point of an exception. That
is not the way of our new, standard calling convention.)

(JSC::op_call_eval): Finish standard CallFrame setup before calling
our eval helper function, which now depends on that setup.

* runtime/Arguments.h:
(JSC::Arguments::length): Renamed numProvidedArguments() to length()
because that's what other objects call it, and the difference made our
new loadVarargs helper function hard to read.

* runtime/Executable.cpp:
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal): Interpreter build
fixes.

* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncApply): Honor Arguments::MaxArguments even when
the .apply call_varargs optimization fails. (This bug appears on layout
tests when you disable the optimization.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove getParameter from HTMLAnchorElement and Location
arv@chromium.org [Mon, 14 Nov 2011 19:14:48 +0000 (19:14 +0000)]
Remove getParameter from HTMLAnchorElement and Location
https://bugs.webkit.org/show_bug.cgi?id=71966

Reviewed by Adam Barth.

Source/WebCore:

* html/HTMLAnchorElement.cpp: Removed getParameter.
* html/HTMLAnchorElement.h: Ditto.
* html/HTMLAnchorElement.idl: Ditto.
* page/Location.cpp: Ditto.
* page/Location.h: Ditto.
* page/Location.idl: Ditto.

LayoutTests:

* fast/dom/HTMLAnchorElement/get-parameter-expected.txt: Removed.
* fast/dom/HTMLAnchorElement/get-parameter.html: Removed.
* fast/dom/Window/window-appendages-cleared-expected.txt:
* fast/dom/Window/window-properties-expected.txt:
* fast/dom/anchor-getParameter-expected.txt: Removed.
* fast/dom/anchor-getParameter.html: Removed.
* http/tests/misc/location-getParameter-expected.txt: Removed.
* http/tests/misc/location-getParameter.html: Removed.
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/qt-5.0/Skipped:
* platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/win/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove RequiresAllArguments
arv@chromium.org [Mon, 14 Nov 2011 19:11:57 +0000 (19:11 +0000)]
Remove RequiresAllArguments
https://bugs.webkit.org/show_bug.cgi?id=71503

Reviewed by Adam Barth.

Source/WebCore:

This removes RequiresAllArguments from the idl files as well as from the code generators.
For window.move/resize/scroll we now match IE and treat missing arguments as 0.
For Clipboard we now match Gecko and IE and throw an exception when setData is called with too few arguments.

Test: fast/events/drag-and-drop-set-drag-data-arguments.html

* bindings/js/JSSVGLengthCustom.cpp:
(WebCore::JSSVGLength::convertToSpecifiedUnits):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateArgumentsCountCheck): Remove RequiresAllArguments.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateArgumentsCountCheck): Ditto.
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
* dom/Clipboard.idl: Remove [RequireAllArguments] from setData which actually means we now require all arguments and throw instead of silently fail.
* page/DOMWindow.idl: Treat missing arguments as 0 which makes us match IE.
* websockets/WebSocket.idl: Comment changes only.

LayoutTests:

* fast/dom/Window/window-resize-and-move-arguments-expected.txt:
* fast/dom/Window/window-resize-and-move-arguments.html: Treat missing arguments as 0.
* fast/dom/Window/window-scroll-arguments-expected.txt:
* fast/dom/Window/window-scroll-arguments.html: Ditto.
* fast/events/drag-and-drop-set-drag-data-arguments-expected.txt: Added.
* fast/events/drag-and-drop-set-drag-data-arguments.html: Added. This tests that we get an exception when called with too few arguments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] MediaStream API: Allow for null WebPeerConnectionHandler
commit-queue@webkit.org [Mon, 14 Nov 2011 18:06:35 +0000 (18:06 +0000)]
[chromium] MediaStream API: Allow for null WebPeerConnectionHandler
https://bugs.webkit.org/show_bug.cgi?id=72114

Fixing crash if WebKitPlatformSupport returns a null WebPeerConnectionHandler
to PeerConnectionHandlerInternal.

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-14
Reviewed by Adam Barth.

* bridge/PeerConnectionHandlerInternal.cpp:
(WebCore::PeerConnectionHandlerInternal::PeerConnectionHandlerInternal):
(WebCore::PeerConnectionHandlerInternal::produceInitialOffer):
(WebCore::PeerConnectionHandlerInternal::handleInitialOffer):
(WebCore::PeerConnectionHandlerInternal::processSDP):
(WebCore::PeerConnectionHandlerInternal::processPendingStreams):
(WebCore::PeerConnectionHandlerInternal::sendDataStreamMessage):
(WebCore::PeerConnectionHandlerInternal::stop):
(WebCore::PeerConnectionHandlerInternal::didCompleteICEProcessing):
(WebCore::PeerConnectionHandlerInternal::didGenerateSDP):
(WebCore::PeerConnectionHandlerInternal::didReceiveDataStreamMessage):
(WebCore::PeerConnectionHandlerInternal::didAddRemoteStream):
(WebCore::PeerConnectionHandlerInternal::didRemoveRemoteStream):
* public/WebKitPlatformSupport.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMissing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
commit-queue@webkit.org [Mon, 14 Nov 2011 17:56:41 +0000 (17:56 +0000)]
Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
https://bugs.webkit.org/show_bug.cgi?id=72088

Patch by Lei Zhang <thestig@chromium.org> on 2011-11-14
Reviewed by Tony Chang.

* DumpRenderTree/chromium/AccessibilityUIElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement MediaController.
jer.noble@apple.com [Mon, 14 Nov 2011 17:55:16 +0000 (17:55 +0000)]
Implement MediaController.
https://bugs.webkit.org/show_bug.cgi?id=71408

Reviewed by Eric Carlson.

Source/JavaScriptCore:

Change the definition of WTF_USE_COREAUDIO to exclude Windows completely, as
CoreAudioClock.h is not available there.

* wtf/Platform.h:

Source/WebCore:

Tests: media/media-controller-playback.html
       media/media-controller.html

Adds support for the MediaController DOM object, and the mediagroup and mediacontroller
HTMLMediaElement attributes.

MediaController is an DOM object which synchronizes playback of multiple HTMLMediaElements. It can
either be created by a page script and assigned to a HTMLMediaElement using the controller property,
or all HTMLMediaElements with identical mediagroup attributes will have a MediaController assigned
automatically.

Add an abstract interface implemented by both MediaController and HTMLMediaElement.
* html/MediaControllerInterface.h: Added.
(WebCore::MediaControllerInterface::~MediaControllerInterface):

Add the MediaController object and IDL.
* html/MediaController.cpp: Added.
(mediaGroupToMediaControllerMap):
(MediaController::mediaControllerForMediaGroup):
(MediaController::create):
(MediaController::MediaController):
(MediaController::~MediaController):
(MediaController::addMediaElement):
(MediaController::removeMediaElement):
(MediaController::containsMediaElement):
(MediaController::buffered):
(MediaController::seekable):
(MediaController::played):
(MediaController::duration):
(MediaController::currentTime):
(MediaController::setCurrentTime):
(MediaController::play):
(MediaController::pause):
(MediaController::setDefaultPlaybackRate):
(MediaController::setPlaybackRate):
(MediaController::setVolume):
(MediaController::setMuted):
(MediaController::reportControllerState):
(MediaController::updateReadyState):
(MediaController::updatePlaybackState):
(MediaController::updateMediaElements):
(MediaController::scheduleEvent):
(MediaController::asyncEventTimerFired):
(MediaController::scriptExecutionContext):
(MediaController::hasAudio):
(MediaController::hasVideo):
(MediaController::hasClosedCaptions):
(MediaController::setClosedCaptionsVisible):
(MediaController::supportsScanning):
(MediaController::beginScrubbing):
(MediaController::endScrubbing):
(MediaController::canPlay):
(MediaController::isLiveStream):
(MediaController::hasSource):
(MediaController::returnToRealtime):
(MediaController::isBlocked):
(MediaController::hasEnded):
* html/MediaController.h: Added.
(WebCore::MediaController::mediaGroup):
(WebCore::MediaController::paused):
(WebCore::MediaController::defaultPlaybackRate):
(WebCore::MediaController::playbackRate):
(WebCore::MediaController::volume):
(WebCore::MediaController::muted):
(WebCore::MediaController::readyState):
(WebCore::MediaController::playbackState):
(WebCore::MediaController::supportsFullscreen):
(WebCore::MediaController::isFullscreen):
(WebCore::MediaController::enterFullscreen):
(WebCore::MediaController::closedCaptionsVisible):
(WebCore::MediaController::refEventTarget):
(WebCore::MediaController::derefEventTarget):
(WebCore::MediaController::toMediaController):
(WebCore::MediaController::eventTargetData):
(WebCore::MediaController::ensureEventTargetData):
* html/MediaController.idl: Added.

Add convenience functions to TimeRanges which can calculate intersections and
unions between TimeRanges objects.
* html/TimeRanges.cpp:
(TimeRanges::copy):
(TimeRanges::invert):
(TimeRanges::intersectWith):
(TimeRanges::unionWith):
* html/TimeRanges.h:

Add MediaControllerConstructor to the Window object.
* page/DOMWindow.idl:

Add the two new attribute names, mediagroup and controller.
* html/HTMLAttributeNames.in:

Add support for the new attributes, and add overridden behavior when a media element
has a current media controller:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::parseMappedAttribute):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::setCurrentTime):
(WebCore::HTMLMediaElement::setPlaybackRate):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::togglePlayState):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::seekable):
(WebCore::HTMLMediaElement::potentiallyPlaying):
(WebCore::HTMLMediaElement::endedPlayback):
(WebCore::HTMLMediaElement::updateVolume):
(WebCore::HTMLMediaElement::updatePlayState):
(WebCore::HTMLMediaElement::userCancelledLoad):
(WebCore::HTMLMediaElement::mediaGroup):
(WebCore::HTMLMediaElement::setMediaGroup):
(WebCore::HTMLMediaElement::controller):
(WebCore::HTMLMediaElement::setController):
(WebCore::HTMLMediaElement::updateMediaController):
(WebCore::HTMLMediaElement::isBlockedOnMediaController):
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::hasSource):
(WebCore::HTMLMediaElement::isLiveStream):
* html/HTMLMediaElement.idl:
* bindings/js/JSHTMLMediaElementCustom.cpp: Added.
(WebCore::JSHTMLMediaElement::setMediaController):

Add convenience functions to store a mapping of media-elements-per-document to allow
a quick lookup of media elements with the same media group within a given document:
* html/HTMLMediaElement.cpp:
(WebCore::documentToElementSetMap):
(WebCore::addElementToDocumentMap):
(WebCore::removeElementFromDocumentMap):

Add a function "seekable" which returns a TimeRanges containing the seekable time ranges
in a media element.  By default this is a single range of [0, maxTimeSeekable].
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::seekable):
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::seekable):

Support functions to cast between MediaController and EventTarget.
* bindings/js/JSEventTarget.cpp:
(WebCore::toJS):
* dom/EventTarget.cpp:
(WebCore::EventTarget::toMediaController):
* dom/EventTarget.h:

Fixed an infinite-recursion bug due to a collision between WTF::currentTime and
ClockGeneric::currentTime:
* platform/ClockGeneric.cpp:
(ClockGeneric::ClockGeneric):
(ClockGeneric::setCurrentTime):
(ClockGeneric::currentTime):
(ClockGeneric::setPlayRate):
(ClockGeneric::start):
(ClockGeneric::stop):
(ClockGeneric::now):
* platform/ClockGeneric.h:

Boilerplate to support creating the derived sources for MediaController and adding new sources
to the project:
* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:

LayoutTests:

* media/media-controller-expected.txt: Added.
* media/media-controller-playback-expected.txt: Added.
* media/media-controller-playback.html: Added.
* media/media-controller.html: Added.
* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
scherkus@chromium.org [Mon, 14 Nov 2011 17:44:33 +0000 (17:44 +0000)]
[Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
https://bugs.webkit.org/show_bug.cgi?id=72147

Reviewed by Adam Barth.

Tools:

* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMultiple foreign objects not rendered
commit-queue@webkit.org [Mon, 14 Nov 2011 17:31:31 +0000 (17:31 +0000)]
Multiple foreign objects not rendered
https://bugs.webkit.org/show_bug.cgi?id=72151

Patch by Florin Malita <fmalita@google.com> on 2011-11-14
Reviewed by Adam Barth.

Source/WebCore:

SVG end tags need to be case-adjusted (just like their start counterparts).

Test: svg/foreignObject/multiple-foreign-objects.html

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processEndTag):

LayoutTests:

* html5lib/runner-expected.txt: Rebaselined.
* platform/chromium/html5lib/runner-expected.txt: Rebaselined.
* svg/custom/use-multiple-on-nested-disallowed-font-expected.txt: Rebaselined.
* svg/foreignObject/multiple-foreign-objects-expected.png: Added.
* svg/foreignObject/multiple-foreign-objects-expected.txt: Added.
* svg/foreignObject/multiple-foreign-objects.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFlaky Test: http/tests/inspector/resource-tree/resource-tree-frame-add.html
tonyg@chromium.org [Mon, 14 Nov 2011 17:29:22 +0000 (17:29 +0000)]
Flaky Test: http/tests/inspector/resource-tree/resource-tree-frame-add.html
https://bugs.webkit.org/show_bug.cgi?id=59771

* platform/chromium/test_expectations.txt: Expect test to flakily timeout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Cleanup QML tests.
alexis.menard@openbossa.org [Mon, 14 Nov 2011 17:16:26 +0000 (17:16 +0000)]
[Qt][WK2] Cleanup QML tests.
https://bugs.webkit.org/show_bug.cgi?id=72259

Reviewed by Simon Hausmann.

Cleanup QML tests. This patch removes the duplicates after the merge of both views.
I also isolated the desktop specific bits into its own directory.

* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_download.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_download.qml.
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml.
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_messaging.qml.
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationPolicyForUrl.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_navigationPolicyForUrl.qml.
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgressSignal.qml: Removed.
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadZeroSizeView.qml: Removed.
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml: Removed.
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_load.qml: Removed.
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadFail.qml: Removed.
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadNegativeSizeView.qml: Removed.
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgress.qml: Removed.
* UIProcess/API/qt/tests/qmltests/WebView/tst_loadFail.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadFail.qml.
* UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgress.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgress.qml.
* UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgressSignal.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgressSignal.qml.
* UIProcess/API/qt/tests/qmltests/WebView/tst_loadZeroSizeView.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadZeroSizeView.qml.
* UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_preferences.qml.
* UIProcess/API/qt/tests/qmltests/WebView/tst_properties.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml.
* UIProcess/API/qt/tests/qmltests/qmltests.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd support for the caretBrowsingEnabled preference in WebKit2
mario@webkit.org [Mon, 14 Nov 2011 17:05:31 +0000 (17:05 +0000)]
Add support for the caretBrowsingEnabled preference in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=72266

Reviewed by Chris Fleizach.

Source/WebCore:

* WebCore.exp.in: Exported settings for setCaretBrowsingEnabled.

Source/WebKit2:

* Shared/WebPreferencesStore.h: Add caretBrowsingEnabled getter
and setter macro.
* UIProcess/API/C/WKPreferences.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetCaretBrowsingEnabled): Added.
(WKPreferencesGetCaretBrowsingEnabled): Added.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Update the
caretBrowsingEnabledKey preference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WIN] Remove dependency on pthread from FastMalloc
paroga@webkit.org [Mon, 14 Nov 2011 17:01:39 +0000 (17:01 +0000)]
[WIN] Remove dependency on pthread from FastMalloc
https://bugs.webkit.org/show_bug.cgi?id=72098

Reviewed by Adam Roben.

All pthread calls are already ported to native Windows calls.
Use the native version for all OS(WINDOWS) to remove the
runtime dependency on the pthread dll.

* wtf/FastMalloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTests occasionally report missing expectations
tonyg@chromium.org [Mon, 14 Nov 2011 16:59:15 +0000 (16:59 +0000)]
Tests occasionally report missing expectations
https://bugs.webkit.org/show_bug.cgi?id=72039

* platform/chromium/test_expectations.txt: Expect test to flakily report missing expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agomedia/track/track-webvtt-tc004-magic-header.html flakily times out
tonyg@chromium.org [Mon, 14 Nov 2011 16:52:52 +0000 (16:52 +0000)]
media/track/track-webvtt-tc004-magic-header.html flakily times out
https://bugs.webkit.org/show_bug.cgi?id=72279

* platform/chromium/test_expectations.txt: Expect test to flakily timeout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove expected crashes for skia-gpu canvas from test expectations
commit-queue@webkit.org [Mon, 14 Nov 2011 16:45:08 +0000 (16:45 +0000)]
Remove expected crashes for skia-gpu canvas from test expectations
https://bugs.webkit.org/show_bug.cgi?id=72183

Patch by Brian Salomon <bsalomon@google.com> on 2011-11-14
Reviewed by Stephen White.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTests occasionally report missing expectations
tonyg@chromium.org [Mon, 14 Nov 2011 16:41:02 +0000 (16:41 +0000)]
Tests occasionally report missing expectations
https://bugs.webkit.org/show_bug.cgi?id=72039

* platform/chromium/test_expectations.txt: Expect test to flakily report missing expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Plumb through partial swap
fsamuel@chromium.org [Mon, 14 Nov 2011 16:30:49 +0000 (16:30 +0000)]
[chromium] Plumb through partial swap
https://bugs.webkit.org/show_bug.cgi?id=72028

Patch by Jonathan Backer <backer@chromium.org> on 2011-11-14
Reviewed by Kenneth Russell.

Source/WebCore:

* platform/graphics/chromium/Extensions3DChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):

Source/WebKit/chromium:

* public/WebGraphicsContext3D.h:
* src/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::postSubBufferCHROMIUM):
* src/GraphicsContext3DChromium.cpp:
* src/GraphicsContext3DPrivate.h:
* tests/MockWebGraphicsContext3D.h:
(WebKit::MockWebGraphicsContext3D::postSubBufferCHROMIUM):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: expose iframe window to the onShown event handler of panels & sidebars
caseq@chromium.org [Mon, 14 Nov 2011 16:29:34 +0000 (16:29 +0000)]
Web Inspector: expose iframe window to the onShown event handler of panels & sidebars
https://bugs.webkit.org/show_bug.cgi?id=72268

Reviewed by Pavel Feldman.

Source/WebCore:

- replace IFrameView with ExtensionView;
- inherit both ExtensionPanel and ExtensionSidebarPane from ExtensionView in the API;
- move Panel.{onShow|onHide} to ExtensionView, effectively disabling show/hide notifications for non-extension panels and enabling it for sidebar panes;
- expose iframe's window object in the onShow event handler.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.sh:
* inspector/front-end/ExtensionAPI.js:
(injectedExtensionAPI.ExtensionViewImpl.dispatchShowEvent):
(injectedExtensionAPI):
(injectedExtensionAPI.PanelWithSidebarImpl):
(injectedExtensionAPI.ExtensionPanelImpl):
(injectedExtensionAPI.ExtensionSidebarPaneImpl):
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionView):
(WebInspector.ExtensionView.prototype.wasShown):
(WebInspector.ExtensionView.prototype.willHide):
(WebInspector.ExtensionView.prototype._onLoad):
(WebInspector.ExtensionPanel):
(WebInspector.ExtensionSidebarPane.prototype.setPage):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype.notifyViewShown):
(WebInspector.ExtensionServer.prototype.notifyViewHidden):
(WebInspector.ExtensionServer.prototype._onCreatePanel):
* inspector/front-end/IFrameView.js: Removed.
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.wasShown):
(WebInspector.Panel.prototype.willHide):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

LayoutTests:

* inspector/extensions/extensions-api-expected.txt:
* inspector/extensions/extensions-events-expected.txt:
* inspector/extensions/extensions-events.html:
* inspector/extensions/extensions-expected.txt:
* platform/chromium/inspector/extensions/extensions-api-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed evening gardening. Try to make the bot green.
ossy@webkit.org [Mon, 14 Nov 2011 16:22:43 +0000 (16:22 +0000)]
[Qt] Unreviewed evening gardening. Try to make the bot green.

* platform/qt/Skipped: Skip failing tets
 - fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html because of missing D&D support
 - fast/events/drag-text-with-clear.html because of missing D&D support
 - http/tests/misc/xslt-bad-import.html because of https://bugs.webkit.org/show_bug.cgi?id=72252
 - inspector/timeline and inspector/user-metrics.html because of https://bugs.webkit.org/show_bug.cgi?id=72274
 - svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html because of https://bugs.webkit.org/show_bug.cgi?id=52810

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: add 'Show function definition' context menu item for function values
yurys@chromium.org [Mon, 14 Nov 2011 15:56:03 +0000 (15:56 +0000)]
Web Inspector: add 'Show function definition' context menu item for function values
https://bugs.webkit.org/show_bug.cgi?id=72265

Allow navigating to JavaScript function definition using context menu.

Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.rawLocationToUILocation):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.update):
(WebInspector.ObjectPropertyTreeElement.prototype._functionContextMenuEventFired):
(WebInspector.ObjectPropertyTreeElement.prototype._functionContextMenuEventFired.revealFunction):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.showFunctionDefinition):
* inspector/front-end/inspector.js:
(WebInspector.showPanelForAnchorNavigation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed: update platform/gtk/Skipped because a newly-added
dmazzoni@google.com [Mon, 14 Nov 2011 15:44:57 +0000 (15:44 +0000)]
Unreviewed: update platform/gtk/Skipped because a newly-added
failing test is due to general accessibility testing issues
on GTK, not due to this particular test.
https://bugs.webkit.org/show_bug.cgi?id=72249

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] security/crypto-random-values-types.html is flaky on win
tonyg@chromium.org [Mon, 14 Nov 2011 15:33:58 +0000 (15:33 +0000)]
[chromium] security/crypto-random-values-types.html is flaky on win
https://bugs.webkit.org/show_bug.cgi?id=72272

* platform/chromium/test_expectations.txt: Mark test as flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Crash in webkit::npapi::PluginInstance::NPP_SetWindow
tonyg@chromium.org [Mon, 14 Nov 2011 15:17:16 +0000 (15:17 +0000)]
[chromium] Crash in webkit::npapi::PluginInstance::NPP_SetWindow
https://bugs.webkit.org/show_bug.cgi?id=72271

* platform/chromium/test_expectations.txt: Expect test to crash sometimes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agomedia/track/track-cues-cuechange.html is flaky
tonyg@chromium.org [Mon, 14 Nov 2011 14:53:36 +0000 (14:53 +0000)]
media/track/track-cues-cuechange.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=72269

* platform/chromium/test_expectations.txt: Mark test as flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, unskipping passing test.
vsevik@chromium.org [Mon, 14 Nov 2011 14:29:27 +0000 (14:29 +0000)]
Unreviewed, unskipping passing test.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: console's protocol payload does not have url and line properties.
pfeldman@chromium.org [Mon, 14 Nov 2011 14:14:27 +0000 (14:14 +0000)]
Web Inspector: console's protocol payload does not have url and line properties.
https://bugs.webkit.org/show_bug.cgi?id=72256

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/console/console-url-and-line.html

* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::ConsoleMessage):
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl):

LayoutTests:

* inspector/console/console-url-and-line-expected.txt: Added.
* inspector/console/console-url-and-line.html: Added.
* inspector/protocol/console-agent-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Two inspector tests timeout on mac
tonyg@chromium.org [Mon, 14 Nov 2011 14:06:59 +0000 (14:06 +0000)]
[chromium] Two inspector tests timeout on mac
https://bugs.webkit.org/show_bug.cgi?id=72264

* platform/chromium/test_expectations.txt: Expect appcache-iframe-manifests and script-formatter to timeout on mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [regression r99960] null callback access.
pfeldman@chromium.org [Mon, 14 Nov 2011 14:03:24 +0000 (14:03 +0000)]
Web Inspector: [regression r99960] null callback access.
https://bugs.webkit.org/show_bug.cgi?id=72263

Reviewed by Yury Semikhatsky.

* inspector/CodeGeneratorInspector.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unbreak the build on Mac OS X
vestbo@webkit.org [Mon, 14 Nov 2011 13:19:29 +0000 (13:19 +0000)]
[Qt] Unbreak the build on Mac OS X

QMacStyle is guarded by Q_WS_MAC, which is not the case for QPA. Until
that's been fixed in Qt we have to use the same guards in WebKit, not
Q_OS_MAC.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs
vestbo@webkit.org [Mon, 14 Nov 2011 13:19:12 +0000 (13:19 +0000)]
[Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Disable plugins on X11 for WK2
hausmann@webkit.org [Mon, 14 Nov 2011 13:06:13 +0000 (13:06 +0000)]
[Qt] Disable plugins on X11 for WK2

Reviewed by Kenneth Rohde Christiansen.

Currently plugins are in-process and they crash in the likely case of
a plugin installation that uses Qt 4, which beautifully clashes with the
Qt 5 based QtWebProcess.

* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Replace use of QApplication with QGuiApplication.
hausmann@webkit.org [Mon, 14 Nov 2011 13:01:03 +0000 (13:01 +0000)]
[Qt] Replace use of QApplication with QGuiApplication.

Reviewed by Tor Arne Vestbø.

Source/JavaScriptCore:

* wtf/qt/compat/qguiapplication.h:
(QGuiApplication::styleHints): Introduce styleHints wrapper hack.

Source/WebCore:

Replace use of QApplication by QGuiApplication where applicable.

* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeQt::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeQt::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeQt::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeQt::platformFocusRingColor):
(WebCore::RenderThemeQt::systemColor):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::getMediaControlForegroundColor):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::caretBlinkInterval):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add support for config tests for Qt 5
vestbo@webkit.org [Mon, 14 Nov 2011 12:58:46 +0000 (12:58 +0000)]
[Qt] Add support for config tests for Qt 5

This allows us to build and run configure-tests at build
time to determine if a given platform feature is available.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Remove reference to QWebNavigationController
caio.oliveira@openbossa.org [Mon, 14 Nov 2011 12:46:56 +0000 (12:46 +0000)]
[Qt] Remove reference to QWebNavigationController
https://bugs.webkit.org/show_bug.cgi?id=72257

Reviewed by Simon Hausmann.

QWebNavigationController was removed in r99946, this is just a leftover.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
* UIProcess/API/qt/qquickwebview_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTests occasionally report missing expectations
tonyg@chromium.org [Mon, 14 Nov 2011 12:44:43 +0000 (12:44 +0000)]
Tests occasionally report missing expectations
https://bugs.webkit.org/show_bug.cgi?id=72039

* platform/chromium/test_expectations.txt: Expect form-associated-element-crash3 to flakily go MISSING.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Fix incorrect usage of ASSERT in CCLayerTreeHostTest
commit-queue@webkit.org [Mon, 14 Nov 2011 12:41:03 +0000 (12:41 +0000)]
[chromium] Fix incorrect usage of ASSERT in CCLayerTreeHostTest
https://bugs.webkit.org/show_bug.cgi?id=72026

ASSERT is stripped out in release builds so it shouldn't be used
in unit tests, except when calling debug-only functions like
isMainThread().

Replacing with ASSERT_TRUE (or EXPECT_TRUE in constructors, where
we can't return a value).

Patch by Iain Merrick <husky@google.com> on 2011-11-14
Reviewed by Tony Gentilcore.

* tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHost::MockLayerTreeHost):
(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsCommit):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsRedraw):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::doBeginTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CMAKE] Add the UseV8.cmake to WebCore.
commit-queue@webkit.org [Mon, 14 Nov 2011 12:20:19 +0000 (12:20 +0000)]
[CMAKE] Add the UseV8.cmake to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=72000

Patch by Jaehoon Jeong <jh4u.jeong@samsung.com> on 2011-11-14
Reviewed by Daniel Bates.

Add the UseV8.cmake to WebCore to build bindings of V8 and
generate JavaScript codes given IDL input.

* UseV8.cmake: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] the QQuickWebView should support double-tap to zoom
kenneth@webkit.org [Mon, 14 Nov 2011 11:55:36 +0000 (11:55 +0000)]
[Qt] the QQuickWebView should support double-tap to zoom
https://bugs.webkit.org/show_bug.cgi?id=72030

Reviewed by Andreas Kling.

* UIProcess/qt/QtViewInterface.cpp:
* UIProcess/qt/QtViewInterface.h:
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
* UIProcess/qt/QtViewportInteractionEngine.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::didFindZoomableArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttp/tests/inspector/resource-tree/appcache-iframe-manifests.html failing on some...
vsevik@chromium.org [Mon, 14 Nov 2011 11:52:50 +0000 (11:52 +0000)]
http/tests/inspector/resource-tree/appcache-iframe-manifests.html failing on some chromium bots after r99988
https://bugs.webkit.org/show_bug.cgi?id=72177

Reviewed by Tony Gentilcore.

Added waitForFrameManifestURLAndStatus() call for the second frame
with manifestId=1, fixed sort functions in appcache-test.js

* http/tests/inspector/resource-tree/appcache-iframe-manifests.html:
* http/tests/inspector/resource-tree/appcache-test.js:
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords):
(initialize_ApplicationCacheTest):
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Remove the QStyle dependency in Qt's mobile theme https://bugs.webkit.org/show_b...
hausmann@webkit.org [Mon, 14 Nov 2011 11:49:47 +0000 (11:49 +0000)]
[Qt] Remove the QStyle dependency in Qt's mobile theme https://bugs.webkit.org/show_bug.cgi?id=67773

This refactoring splits up RenderThemeQt with two
subclasses, a QStyle-backed one, and a Mobile version
that uses the old mobile theme for now.

QStyle availability is detected at compile time, and
its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
environment variable.

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-11-11
Reviewed by Simon Hausmann.

Source/WebCore:

Covered by the existing tests.

* Target.pri:
* platform/qt/QtMobileWebStyle.cpp: Removed. The relevant logic
now lives within RenderThemeQtMobile.
* platform/qt/QtMobileWebStyle.h: Removed. Ditto.
* platform/qt/RenderThemeQStyle.cpp: Added.
(WebCore::initStyleOption):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::fallbackStyle):
(WebCore::RenderThemeQStyle::qStyle):
(WebCore::RenderThemeQStyle::findFrameLineWidth):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::adjustTextFieldStyle):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):
* platform/qt/RenderThemeQStyle.h: Added.
(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::drawPrimitive):
(WebCore::StylePainterQStyle::drawControl):
(WebCore::StylePainterQStyle::drawComplexControl):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::isControlStyled):
(WebCore::RenderThemeQt::inflateButtonRect):
(WebCore::RenderThemeQt::adjustRepaintRect):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::adjustMenuListStyle):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::adjustProgressBarStyle):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQt::paintMediaFullscreenButton):
(WebCore::RenderThemeQt::paintMediaMuteButton):
(WebCore::RenderThemeQt::paintMediaPlayButton):
(WebCore::RenderThemeQt::paintMediaCurrentTime):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeQt::paintMediaSliderTrack):
(WebCore::RenderThemeQt::paintMediaSliderThumb):
(WebCore::RenderThemeQt::adjustSliderThumbSize):
(WebCore::RenderThemeQt::caretBlinkInterval):
(WebCore::RenderThemeQt::fileListNameForWidth):
(WebCore::StylePainter::StylePainter):
(WebCore::StylePainter::init):
(WebCore::StylePainter::~StylePainter):
* platform/qt/RenderThemeQt.h:
(WebCore::RenderThemeQt::useMobileTheme):
(WebCore::StylePainter::isValid):
* platform/qt/RenderThemeQtMobile.cpp: Added.
(WebCore::drawRectangularControlBackground):
(WebCore::RenderThemeQtMobile::getStylePainter):
(WebCore::StylePainterMobile::StylePainterMobile):
(WebCore::StylePainterMobile::drawChecker):
(WebCore::StylePainterMobile::findChecker):
(WebCore::StylePainterMobile::drawRadio):
(WebCore::StylePainterMobile::findRadio):
(WebCore::StylePainterMobile::drawMultipleComboButton):
(WebCore::StylePainterMobile::drawSimpleComboButton):
(WebCore::StylePainterMobile::getButtonImageSize):
(WebCore::StylePainterMobile::findComboButton):
(WebCore::StylePainterMobile::drawLineEdit):
(WebCore::StylePainterMobile::drawCheckBox):
(WebCore::StylePainterMobile::drawRadioButton):
(WebCore::StylePainterMobile::drawPushButton):
(WebCore::StylePainterMobile::drawComboBox):
(WebCore::RenderThemeQtMobile::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQtMobile::RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::~RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::isControlStyled):
(WebCore::RenderThemeQtMobile::popupInternalPaddingBottom):
(WebCore::RenderThemeQtMobile::computeSizeBasedOnStyle):
(WebCore::RenderThemeQtMobile::adjustButtonStyle):
(WebCore::RenderThemeQtMobile::setButtonPadding):
(WebCore::RenderThemeQtMobile::paintButton):
(WebCore::RenderThemeQtMobile::adjustTextFieldStyle):
(WebCore::RenderThemeQtMobile::paintTextField):
(WebCore::RenderThemeQtMobile::adjustMenuListStyle):
(WebCore::RenderThemeQtMobile::setPopupPadding):
(WebCore::RenderThemeQtMobile::paintMenuList):
(WebCore::RenderThemeQtMobile::paintMenuListButton):
(WebCore::RenderThemeQtMobile::animationDurationForProgressBar):
(WebCore::RenderThemeQtMobile::paintProgressBar):
(WebCore::RenderThemeQtMobile::paintSliderTrack):
(WebCore::RenderThemeQtMobile::paintSliderThumb):
(WebCore::RenderThemeQtMobile::checkMultiple):
(WebCore::RenderThemeQtMobile::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQtMobile::adjustSliderThumbSize):
* platform/qt/RenderThemeQtMobile.h: Added.
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeQt::paint):
(WebCore::ScrollbarThemeQt::scrollbarThickness):
(WebCore::ScrollbarThemeQt::paintScrollCorner):

Source/WebKit/qt:

* Api/qwebpage.cpp:
(QWebPage::swallowContextMenuEvent):
* tests/tests.pri:

Tools:

* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
* qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
based on availability of QtWidgets.
* qmake/mkspecs/features/webcore.prf: cleanup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] r99963 causes inspector/debugger/script-formatter.html to fail text diff
apavlov@chromium.org [Mon, 14 Nov 2011 11:49:29 +0000 (11:49 +0000)]
[chromium] r99963 causes inspector/debugger/script-formatter.html to fail text diff
https://bugs.webkit.org/show_bug.cgi?id=72204

The concatenate_script_formatter_worker_js action (along with concatenate_heap_snapshot_worker_js)
did not depend on their 'input_file' files and, hence, did not get invoked on their input_file changes.

Reviewed by Yury Semikhatsky.

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Possible crash when destroying after called widgetSizeChanged.
ryuan.choi@samsung.com [Mon, 14 Nov 2011 11:24:26 +0000 (11:24 +0000)]
[GTK] Possible crash when destroying after called widgetSizeChanged.
https://bugs.webkit.org/show_bug.cgi?id=72237

Reviewed by Martin Robinson.

Crash can occur when ChromeclientGtk is removed before calling repaintEverythingSoonTimeout
registered by widgetSizeChanged.
This patch remove the m_repaintSoonSourceId glib source before destruction
of the ChromeClientGtk to prevent the above crash.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::chromeDestroyed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit...
tonyg@chromium.org [Mon, 14 Nov 2011 11:15:05 +0000 (11:15 +0000)]
ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
https://bugs.webkit.org/show_bug.cgi?id=59552

* platform/chromium/test_expectations.txt: Expect cross-frame-access-custom.html to CRASH or PASS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r100116.
tonyg@chromium.org [Mon, 14 Nov 2011 10:53:49 +0000 (10:53 +0000)]
Unreviewed, rolling out r100116.
http://trac.webkit.org/changeset/100116

r100104 was rolled out, so no longer needed

* Scripts/run-bindings-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r100104.
tonyg@chromium.org [Mon, 14 Nov 2011 10:48:35 +0000 (10:48 +0000)]
Unreviewed, rolling out r100104.
http://trac.webkit.org/changeset/100104
https://bugs.webkit.org/show_bug.cgi?id=72247

broke windows builds

* Scripts/check-webkit-style:
* Scripts/webkitpy/common/checkout/checkout_unittest.py:
* Scripts/webkitpy/common/checkout/deps.py:
* Scripts/webkitpy/common/checkout/scm/__init__.py:
* Scripts/webkitpy/common/checkout/scm/detection.py:
* Scripts/webkitpy/common/checkout/scm/git.py:
* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
* Scripts/webkitpy/common/checkout/scm/svn.py:
* Scripts/webkitpy/common/host.py:
* Scripts/webkitpy/common/host_mock.py:
* Scripts/webkitpy/layout_tests/controllers/manager.py:
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/mock_drt.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
* Scripts/webkitpy/tool/servers/rebaselineserver.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSecurityContext should track whether the SecurityOrigin has been initialized
abarth@webkit.org [Mon, 14 Nov 2011 10:26:49 +0000 (10:26 +0000)]
SecurityContext should track whether the SecurityOrigin has been initialized
https://bugs.webkit.org/show_bug.cgi?id=72250

Reviewed by Eric Seidel.

This patch is another step towards https://bugs.webkit.org/show_bug.cgi?id=71745.

One of the things we use "empty" SecurityOrigins for is detecting
whether a Document's SecurityOrigin has been initialized.  In this
patch, we track that state directly on SecurityContext (which is a base
class of Document), moving us closer to removing the concept of an
empty SecurityOrigin.

* dom/Document.cpp:
(WebCore::Document::initSecurityContext):
* dom/SecurityContext.cpp:
(WebCore::SecurityContext::SecurityContext):
(WebCore::SecurityContext::setSecurityOrigin):
* dom/SecurityContext.h:
(WebCore::SecurityContext::didFailToInitializeSecurityOrigin):
(WebCore::SecurityContext::haveInitializedSecurityOrigin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, build fix after r100104. run-binding-tests broke.
philn@webkit.org [Mon, 14 Nov 2011 10:00:08 +0000 (10:00 +0000)]
Unreviewed, build fix after r100104. run-binding-tests broke.

* Scripts/run-bindings-tests: Explicitely use scm.detection.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fix make distcheck build.
carlosgc@webkit.org [Mon, 14 Nov 2011 09:50:06 +0000 (09:50 +0000)]
Unreviewed. Fix make distcheck build.

Source/JavaScriptCore:

* GNUmakefile.list.am: Add missing files.

Source/WebCore:

* GNUmakefile.list.am: Add missing files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Give HTML ContextMenu a more Native look
commit-queue@webkit.org [Mon, 14 Nov 2011 09:40:37 +0000 (09:40 +0000)]
Web Inspector: Give HTML ContextMenu a more Native look
https://bugs.webkit.org/show_bug.cgi?id=72207

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2011-11-14
Reviewed by Pavel Feldman.

* inspector/front-end/SoftContextMenu.js:
(.WebInspector.SoftContextMenu.prototype._createMenuItem):
Give the checkmark a class name so that it can be styled more
with CSS instead of with JavaScript.

* inspector/front-end/inspector.css:
(.soft-context-menu): tweak the border and shadow.
(.soft-context-menu-item): tweak the font size and positioning.
(.soft-context-menu-separator): tweak the whitespace.
(.soft-context-menu-item-mouse-over): solid blue for non-mac platforms.
(body.platform-mac .soft-context-menu-item-mouse-over): gradient for mac platforms.
(.soft-context-menu-item-checkmark): gray color normally.
(.soft-context-menu-item-mouse-over .soft-context-menu-item-checkmark): white on hover.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: function remote objetct should provide access to function position...
yurys@chromium.org [Mon, 14 Nov 2011 09:27:25 +0000 (09:27 +0000)]
Web Inspector: function remote objetct should provide access to function position in the script
https://bugs.webkit.org/show_bug.cgi?id=71808

Source/JavaScriptCore:

Exposed accessor for function source code.

Reviewed by Pavel Feldman.

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/JSFunction.cpp:
(JSC::JSFunction::sourceCode):
* runtime/JSFunction.h:

Source/WebCore:

Added Debugger.getFunctionLocation command for resolving function location including
start line, column and script id.

Reviewed by Pavel Feldman.

Test: inspector/debugger/function-location.html

* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::functionLocation):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::functionLocationCallback):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::getFunctionLocation):
* inspector/InjectedScript.h:
* inspector/InjectedScriptHost.idl:
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::getFunctionLocation):
* inspector/InspectorDebuggerAgent.h:

LayoutTests:

Added test for Debugger.getFunctionLocation command.

Reviewed by Pavel Feldman.

* inspector/debugger/function-location-expected.txt: Added.
* inspector/debugger/function-location.html: Added.
* platform/chromium/inspector/debugger/function-location-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening after r100050
ossy@webkit.org [Mon, 14 Nov 2011 09:25:37 +0000 (09:25 +0000)]
[Qt] Unreviewed gardening after r100050
https://bugs.webkit.org/show_bug.cgi?id=72251

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-11-14

* platform/qt/Skipped: editing/spelling/spelling-unified-emulation.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCannot select multiple options by mouse dragging in <select multiple="multiple" size...
commit-queue@webkit.org [Mon, 14 Nov 2011 09:18:25 +0000 (09:18 +0000)]
Cannot select multiple options by mouse dragging in <select multiple="multiple" size="7"> list
https://bugs.webkit.org/show_bug.cgi?id=70496

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2011-11-14
Reviewed by Kent Tamura.

Source/WebCore:

Select Multiple options in a select element with a mouse drag when no. of options
are less than the no. specified in size attribute.
Other browsers(IE, Opera, Firefox) support this feature

Test: fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
Handled mouse move event with Left button pressed. We select the options under mouse
when mouse drag happens and the select element cannot autoscroll.

LayoutTests:

Select Multiple options in a select element with a mouse drag when no. of options
are less than the no. specified in size attribute.
Other browsers(IE, Opera, Firefox) support this feature.

* fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size-expected.txt: Added.
* fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [chromium] list dedicated workers in case inspector opened post-worker...
yurys@chromium.org [Mon, 14 Nov 2011 09:16:06 +0000 (09:16 +0000)]
Web Inspector: [chromium] list dedicated workers in case inspector opened post-worker creation.
https://bugs.webkit.org/show_bug.cgi?id=72020

Source/WebCore:

Collect information about dedicated workers even when inspector is closed. This
way we can list all dedicated workers if the front-end opens later.

Reviewed by Pavel Feldman.

Test: http/tests/inspector-enabled/dedicated-workers-list.html

* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didStartWorkerContext):
* inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::setFrontend):
(WebCore::InspectorWorkerAgent::restore):
(WebCore::InspectorWorkerAgent::clearFrontend):
(WebCore::InspectorWorkerAgent::setWorkerInspectionEnabled):
(WebCore::InspectorWorkerAgent::didStartWorkerContext):
(WebCore::InspectorWorkerAgent::workerContextTerminated):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannelsForExistingWorkers):
(WebCore::InspectorWorkerAgent::destroyWorkerFrontendChannels):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannel):
* inspector/InspectorWorkerAgent.h:

LayoutTests:

Reviewed by Pavel Feldman.

* http/tests/inspector-enabled/dedicated-workers-list-expected.txt: Added.
* http/tests/inspector-enabled/dedicated-workers-list.html: Added.
* http/tests/inspector-enabled/resources/dedicated-worker.js: Added.
(doWork):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild breaks with --no-javascript-debugger --no-inspector
commit-queue@webkit.org [Mon, 14 Nov 2011 09:14:44 +0000 (09:14 +0000)]
Build breaks with --no-javascript-debugger --no-inspector
https://bugs.webkit.org/show_bug.cgi?id=72228

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-11-14
Reviewed by Simon Hausmann.

Source/WebCore:

* workers/WorkerMessagingProxy.cpp:
(WebCore::PostMessageToPageInspectorTask::performTask):
(WebCore::WorkerMessagingProxy::connectToInspector):
* workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):

Source/WebKit2:

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove all custom constructors of Events in V8
haraken@chromium.org [Mon, 14 Nov 2011 08:27:48 +0000 (08:27 +0000)]
Remove all custom constructors of Events in V8
https://bugs.webkit.org/show_bug.cgi?id=72074

Reviewed by Adam Barth.

V8 has [ConstructorTemplate=Event] IDL, which generates
Event constructors. This patch removes all the custom constructors
in V8EventConstructors.cpp and generates them using
[ConstructorTemplate=Event] IDL.

Tests: fast/events/constructors/before-load-event-constructor.html
       fast/events/constructors/close-event-constructor.html
       fast/events/constructors/custom-event-constructor.html
       fast/events/constructors/error-event-constructor.html
       fast/events/constructors/event-constructors.html
       fast/events/constructors/hash-change-event-constructor.html
       fast/events/constructors/message-event-constructor.html
       fast/events/constructors/overflow-event-constructor.html
       fast/events/constructors/page-transition-event-constructor.html
       fast/events/constructors/pop-state-event-constructor.html
       fast/events/constructors/progress-event-constructor.html
       fast/events/constructors/track-event-constructor.html
       fast/events/constructors/webkit-animation-event-constructor.html
       fast/events/constructors/webkit-transition-event-constructor.html

* Target.pri: Removed V8EventConstructors.cpp.
* WebCore.gypi: Ditto.
* bindings/v8/custom/V8EventConstructors.cpp: Removed.
* dom/BeforeLoadEvent.idl: Replaced [V8CustomConstructor] with [V8ConstructorTemplate=Event]. Added [InitializedByConstructor] IDL to attributes that can be initialized by the generated constructor.
* dom/CustomEvent.idl: Ditto.
* dom/ErrorEvent.idl: Ditto.
* dom/HashChangeEvent.idl: Ditto.
* dom/MessageEvent.idl: Ditto.
* dom/OverflowEvent.idl: Ditto.
* dom/PageTransitionEvent.idl: Ditto.
* dom/PopStateEvent.idl: Ditto.
* dom/ProgressEvent.idl: Ditto.
* dom/WebKitAnimationEvent.idl: Ditto.
* dom/WebKitTransitionEvent.idl: Ditto.
* html/track/TrackEvent.idl: Ditto.
* websockets/CloseEvent.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK baselines for 2 new svg tests.
philn@webkit.org [Mon, 14 Nov 2011 08:20:35 +0000 (08:20 +0000)]
Unreviewed, GTK baselines for 2 new svg tests.

* platform/gtk/svg/repaint/filter-child-repaint-expected.txt: Added.
* platform/gtk/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WX] Make FontPlatformData::m_size private
paroga@webkit.org [Mon, 14 Nov 2011 08:16:07 +0000 (08:16 +0000)]
[WX] Make FontPlatformData::m_size private
https://bugs.webkit.org/show_bug.cgi?id=72214

Reviewed by Andreas Kling.

Also change the order of member variables to match
the order in the constructor to fix many warnings.

* platform/graphics/wx/FontPlatformData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100106 268f45cc-cd09-0410-ab3c-d52691b4dbfc