WebKit-https.git
6 years agoLayout Test editing/deleting/password-delete-performance.html is failing
rniwa@webkit.org [Sat, 23 Nov 2013 04:50:45 +0000 (04:50 +0000)]
Layout Test editing/deleting/password-delete-performance.html is failing
https://bugs.webkit.org/show_bug.cgi?id=124781

Reviewed by Alexey Proskuryakov.

PerformanceTests:

Add a new performance test to replace editing/deleting/password-delete-performance.html.
We skip this test by default since it's a micro benchmark.

* Interactive/DeletingInPasswordField.html: Added.
* Skipped:

LayoutTests:

Removed the test that has been timing out.

* TestExpectations:
* editing/deleting/password-delete-performance.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAttempt build fixes for 32-bit after 159724.
timothy_horton@apple.com [Sat, 23 Nov 2013 03:43:57 +0000 (03:43 +0000)]
Attempt build fixes for 32-bit after 159724.

There's probably a better fix, but this will work for now.

* UIProcess/API/mac/WKView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpstream iOS WebKit2 to OpenSource (part 3).
enrica@apple.com [Sat, 23 Nov 2013 03:29:50 +0000 (03:29 +0000)]
Upstream iOS WebKit2 to OpenSource (part 3).
https://bugs.webkit.org/show_bug.cgi?id=124803

Reviewed by Anders Carlsson and Tim Horton.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoJSC Obj-C API should have real documentation
mhahnenberg@apple.com [Sat, 23 Nov 2013 02:54:31 +0000 (02:54 +0000)]
JSC Obj-C API should have real documentation
https://bugs.webkit.org/show_bug.cgi?id=124805

Reviewed by Geoffrey Garen.

Massaging the header comments into proper headerdocs.

* API/JSContext.h:
* API/JSExport.h:
* API/JSManagedValue.h:
* API/JSValue.h:
* API/JSVirtualMachine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Can't drag full-screen video to another monitor
jer.noble@apple.com [Sat, 23 Nov 2013 00:57:51 +0000 (00:57 +0000)]
[Mac] Can't drag full-screen video to another monitor
https://bugs.webkit.org/show_bug.cgi?id=124798

Reviewed by Geoffrey Garen.

Source/WebCore:

Make full screen windows movable by default. Previously, we wanted non-movable full screen
windows since they were in the same space and were just placed atop non-full screen windows.
Now that all our supported Mac platforms have explicit full screen support, we can remove this
non-movable restriction.

* platform/mac/WebCoreFullScreenWindow.mm:
(-[WebCoreFullScreenWindow initWithContentRect:styleMask:backing:defer:]):

Source/WebKit2:

Make full screen windows resizable by default. This allows the window to be resized when
moved between monitors with different resolutions.

* UIProcess/API/mac/WKView.mm:
(-[WKView createFullScreenWindow]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCodeBlock::m_numCalleeRegisters shouldn't also mean frame size, frame size needed...
fpizlo@apple.com [Sat, 23 Nov 2013 00:36:55 +0000 (00:36 +0000)]
CodeBlock::m_numCalleeRegisters shouldn't also mean frame size, frame size needed for exit, or any other unrelated things
https://bugs.webkit.org/show_bug.cgi?id=124793

Reviewed by Mark Hahnenberg.

Now m_numCalleeRegisters always refers to the number of locals that the attached
bytecode uses. It never means anything else.

For frame size, we now have it lazily computed from m_numCalleeRegisters for the
baseline engines and we have it stored in DFG::CommonData for the optimizing JITs.

For frame-size-needed-at-exit, we store that in DFG::CommonData, too.

The code no longer implies that there is any arithmetic relationship between
m_numCalleeRegisters and frameSize. Previously it implied that the latter is greater
than the former.

The code no longer implies that there is any arithmetic relationship between the
frame Size and the frame-size-needed-at-exit. Previously it implied that the latter
is greater that the former.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::frameRegisterCount):
* bytecode/CodeBlock.h:
* dfg/DFGCommonData.h:
(JSC::DFG::CommonData::CommonData):
(JSC::DFG::CommonData::requiredRegisterCountForExecutionAndExit):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::frameRegisterCount):
(JSC::DFG::Graph::requiredRegisterCountForExit):
(JSC::DFG::Graph::requiredRegisterCountForExecutionAndExit):
* dfg/DFGGraph.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
* dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
* ftl/FTLLink.cpp:
(JSC::FTL::link):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
* ftl/FTLOSREntry.cpp:
(JSC::FTL::prepareOSREntry):
* interpreter/CallFrame.cpp:
(JSC::CallFrame::frameExtentInternal):
* interpreter/JSStackInlines.h:
(JSC::JSStack::pushFrame):
* jit/JIT.h:
(JSC::JIT::frameRegisterCountFor):
* jit/JITOperations.cpp:
* llint/LLIntEntrypoint.cpp:
(JSC::LLInt::frameRegisterCountFor):
* llint/LLIntEntrypoint.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Win] Clean up ColorSpace handling in Windows code
bfulgham@apple.com [Sat, 23 Nov 2013 00:17:11 +0000 (00:17 +0000)]
[Win] Clean up ColorSpace handling in Windows code
https://bugs.webkit.org/show_bug.cgi?id=124795

Reviewed by Tim Horton.

Functionality covered by existing fast/css/color test suite.

* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::safeRGBColorSpaceRef): Handle case of Windows CG implementation not
handling sRGB correctly.
(WebCore::sRGBColorSpaceRef): Use new helper function.
* platform/graphics/win/FontCGWin.cpp:
(WebCore::Font::drawGlyphs): Pass correct color space to fill functions.
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::platformInit): Initialize color space to value passed
via the style to the constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2] Another build fix for NetworkProcess on iOS
benjamin@webkit.org [Sat, 23 Nov 2013 00:07:55 +0000 (00:07 +0000)]
[WK2] Another build fix for NetworkProcess on iOS
https://bugs.webkit.org/show_bug.cgi?id=124797

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-11-22
Reviewed by Alexey Proskuryakov.

* NetworkProcess/NetworkResourceLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2] Fix the build of the NetworkProcess on iOS
benjamin@webkit.org [Fri, 22 Nov 2013 23:47:49 +0000 (23:47 +0000)]
[WK2] Fix the build of the NetworkProcess on iOS
https://bugs.webkit.org/show_bug.cgi?id=124794

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-11-22
Reviewed by Alexey Proskuryakov.

* NetworkProcess/AsynchronousNetworkLoaderClient.cpp:
(WebKit::AsynchronousNetworkLoaderClient::didReceiveBuffer):
* NetworkProcess/NetworkResourceLoader.h:
* NetworkProcess/SynchronousNetworkLoaderClient.cpp:
(WebKit::SynchronousNetworkLoaderClient::willSendRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWebCrypto algorithms should check that key algorithm matches
ap@apple.com [Fri, 22 Nov 2013 23:43:54 +0000 (23:43 +0000)]
WebCrypto algorithms should check that key algorithm matches
https://bugs.webkit.org/show_bug.cgi?id=123628

Reviewed by Anders Carlsson.

No change in behavior yet, because we have one algorithm per key class.
Will be tested once more algorithms are added.

* WebCore.xcodeproj/project.pbxproj: Updated for file renames.

* bindings/js/JSCryptoAlgorithmDictionary.cpp:
(WebCore::createRsaKeyParamsWithHash):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):
* bindings/js/JSCryptoKeySerializationJWK.cpp:
(WebCore::createRSAKeyParametersWithHash):
(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm):
* crypto/CryptoAlgorithmParameters.h:
(WebCore::CryptoAlgorithmParameters::ENUM_CLASS):
* crypto/parameters/CryptoAlgorithmRsaKeyParamsWithHash.h: Copied from Source/WebCore/crypto/parameters/CryptoAlgorithmRsaSsaKeyParams.h.
* crypto/parameters/CryptoAlgorithmRsaSsaKeyParams.h: Removed.
Renamed RsaSsaKeyParams to RsaKeyParamsWithHash, because other algorithms (like RSA-OAEP)
are in the same boat. Depending on where the spec goes, we might need to introduce
algorithm specific RSA parameter classes later, but let's reduce copy/pasted code at
least for now.

* crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp: Moved to the correct directory.
* crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp: Copied from Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp.
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign): Factored out Mac specific
code, leaving type casting to cross-platform files.
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify): Ditto.

* crypto/CryptoAlgorithmRegistry.h:
(WebCore::CryptoAlgorithmRegistry::registerAlgorithm):
* crypto/mac/CryptoAlgorithmRegistryMac.cpp:
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
Reduce copy/pasting in registration code.

* crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
(WebCore::CryptoAlgorithmAES_CBC::keyAlgorithmMatches): Check key type and algorithm.
(WebCore::CryptoAlgorithmAES_CBC::encrypt): Cross platform type casting code.
Maybe we'll find a way to autogenerate or eliminate it one day.
(WebCore::CryptoAlgorithmAES_CBC::decrypt): Ditto.

* crypto/algorithms/CryptoAlgorithmAES_CBC.h:
* crypto/algorithms/CryptoAlgorithmHMAC.cpp:
(WebCore::CryptoAlgorithmHMAC::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):
* crypto/algorithms/CryptoAlgorithmHMAC.h:
* crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::importKey):
* crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
* crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:
(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):
* crypto/mac/CryptoAlgorithmHMACMac.cpp:
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):
Same changes for all algorithms that have keys.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Review enabled/disabled CSS features for release builds
rego@igalia.com [Fri, 22 Nov 2013 22:57:02 +0000 (22:57 +0000)]
[GTK] Review enabled/disabled CSS features for release builds
https://bugs.webkit.org/show_bug.cgi?id=124791

Reviewed by Martin Robinson.

Enable and disable some CSS features according to what last versions of
Safari ship or not.

* Source/autotools/SetupWebKitFeatures.m4: Enable ENABLE_CSS_REGIONS and
ENABLE_CSS_STICKY_POSITION. Disable ENABLE_CSS_EXCLUSIONS and
ENABLE_CSS_SHAPES.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove the remaining page loader clients out into separate files
andersca@apple.com [Fri, 22 Nov 2013 22:52:12 +0000 (22:52 +0000)]
Move the remaining page loader clients out into separate files
https://bugs.webkit.org/show_bug.cgi?id=124792

Reviewed by Dan Bernstein.

* UIProcess/API/C/WKPage.h:
* UIProcess/API/C/WKPageContextMenuClient.h: Added.
* UIProcess/API/C/WKPageFindClient.h: Added.
* UIProcess/API/C/WKPageFindMatchesClient.h: Added.
* UIProcess/API/C/WKPageFormClient.h: Added.
* UIProcess/API/C/WKPageLoaderClient.h:
* UIProcess/API/C/WKPagePolicyClient.h: Added.
* UIProcess/API/C/WKPageUIClient.h: Added.
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFire "change" event on TextTrackList when a TextTrack's mode changes
commit-queue@webkit.org [Fri, 22 Nov 2013 22:24:26 +0000 (22:24 +0000)]
Fire "change" event on TextTrackList when a TextTrack's mode changes
https://bugs.webkit.org/show_bug.cgi?id=124789

Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-22
Reviewed by Eric Carlson.

Source/WebCore:

Since AudioTrackList and VideoTrackList already have this event, the
interesting bits are in TrackListBase::scheduleChangeEvent(), and we
just need to call it for TextTrackList changes.

Test: media/track/track-change-event.html

* html/HTMLMediaElement.cpp:
(HTMLMediaElement::textTrackModeChanged): Call TrackListBase::scheduleChangeEvent().
* html/track/TextTrackList.idl: Add onchange event listener.

LayoutTests:

* media/track/track-change-event-expected.txt: Added.
* media/track/track-change-event.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCombine SymbolTable and SharedSymbolTable
fpizlo@apple.com [Fri, 22 Nov 2013 22:03:56 +0000 (22:03 +0000)]
Combine SymbolTable and SharedSymbolTable
https://bugs.webkit.org/show_bug.cgi?id=124761

Reviewed by Geoffrey Garen.

SymbolTable was never used directly; we now always used SharedSymbolTable. So, this
gets rid of SymbolTable and renames SharedSymbolTable to SymbolTable.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::symbolTable):
* bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedFunctionExecutable::symbolTable):
(JSC::UnlinkedCodeBlock::symbolTable):
(JSC::UnlinkedCodeBlock::finishCreation):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::symbolTable):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGStackLayoutPhase.cpp:
(JSC::DFG::StackLayoutPhase::run):
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::symbolTableFor):
* runtime/Arguments.h:
(JSC::Arguments::finishCreation):
* runtime/Executable.h:
(JSC::FunctionExecutable::symbolTable):
* runtime/JSActivation.h:
(JSC::JSActivation::create):
(JSC::JSActivation::JSActivation):
(JSC::JSActivation::registersOffset):
(JSC::JSActivation::allocationSize):
* runtime/JSSymbolTableObject.h:
(JSC::JSSymbolTableObject::symbolTable):
(JSC::JSSymbolTableObject::JSSymbolTableObject):
(JSC::JSSymbolTableObject::finishCreation):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::JSVariableObject):
* runtime/SymbolTable.cpp:
(JSC::SymbolTable::destroy):
(JSC::SymbolTable::SymbolTable):
* runtime/SymbolTable.h:
(JSC::SymbolTable::create):
(JSC::SymbolTable::createStructure):
* runtime/VM.cpp:
(JSC::VM::VM):
* runtime/VM.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove WKPageLoaderClient out into a separate header
andersca@apple.com [Fri, 22 Nov 2013 21:59:32 +0000 (21:59 +0000)]
Move WKPageLoaderClient out into a separate header
https://bugs.webkit.org/show_bug.cgi?id=124790

Reviewed by Dan Bernstein.

* UIProcess/API/C/WKPage.h:
* UIProcess/API/C/WKPageLoaderClient.h: Added.
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd TextTrackList::getTrackById().
commit-queue@webkit.org [Fri, 22 Nov 2013 21:44:22 +0000 (21:44 +0000)]
Add TextTrackList::getTrackById().
https://bugs.webkit.org/show_bug.cgi?id=124785

Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-22
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-id.html

* html/track/TextTrackList.cpp: Add getTrackById()
(TextTrackList::getTrackById):
* html/track/TextTrackList.h: Same.
* html/track/TextTrackList.idl: Same.

LayoutTests:

Update this test to make it more interesting. It now checks that the "id"
changes when the <track> id changes, makes sure TextTrack::id is readonly,
and looks the track up by id with getTrackById().

* media/track/track-id-expected.txt:
* media/track/track-id.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSpeculative Mountain Lion build fix.
dino@apple.com [Fri, 22 Nov 2013 21:22:50 +0000 (21:22 +0000)]
Speculative Mountain Lion build fix.

* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate openDocument:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove residual references to "dynamicGlobalObject".
mark.lam@apple.com [Fri, 22 Nov 2013 21:09:25 +0000 (21:09 +0000)]
Remove residual references to "dynamicGlobalObject".
https://bugs.webkit.org/show_bug.cgi?id=124787.

Reviewed by Filip Pizlo.

* JavaScriptCore.order:
* interpreter/CallFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix Mountain Lion bug.
andersca@apple.com [Fri, 22 Nov 2013 20:57:50 +0000 (20:57 +0000)]
Fix Mountain Lion bug.

* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate openDocument:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMiniBrowser should use the blocks-based NSOpenPanel API
andersca@apple.com [Fri, 22 Nov 2013 20:38:42 +0000 (20:38 +0000)]
MiniBrowser should use the blocks-based NSOpenPanel API
https://bugs.webkit.org/show_bug.cgi?id=124786

Reviewed by Simon Fraser.

* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate frontmostBrowserWindowController]):
Account for windows that don't have a BrowserWindowController.

(-[BrowserAppDelegate openDocument:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEnsure that arity fixups honor stack alignment requirements.
mark.lam@apple.com [Fri, 22 Nov 2013 20:31:38 +0000 (20:31 +0000)]
Ensure that arity fixups honor stack alignment requirements.
https://bugs.webkit.org/show_bug.cgi?id=124756.

Reviewed by Geoffrey Garen.

The LLINT and all the JITs rely on CommonSlowPaths::arityCheckFor() to
compute the arg count adjustment for the arity fixup. We take advantage
of this choke point and introduce the stack alignment padding there in
the guise of additional args.

The only cost of this approach is that the padding will also be
initialized to undefined values as if they were args. Since arity fixups
are considered a slow path that is rarely taken, this cost is not a
concern.

* runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::arityCheckFor):
* runtime/VM.h:
(JSC::VM::isSafeToRecurse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBytecodeGenerator should align the stack according to native conventions
fpizlo@apple.com [Fri, 22 Nov 2013 20:18:18 +0000 (20:18 +0000)]
BytecodeGenerator should align the stack according to native conventions
https://bugs.webkit.org/show_bug.cgi?id=124735

Source/JavaScriptCore:

Reviewed by Mark Lam.

Rolling this back in because it actually fixed fast/dom/gc-attribute-node.html, but
our infrastructure misleads peole into thinking that fixing a test constitutes
breaking it.

* bytecompiler/BytecodeGenerator.h:
(JSC::CallArguments::registerOffset):
(JSC::CallArguments::argumentCountIncludingThis):
* bytecompiler/NodesCodegen.cpp:
(JSC::CallArguments::CallArguments):

LayoutTests:

Reviewed by Mark Lam.

* platform/mac/fast/dom/gc-attribute-node-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix 32-bit build.
andersca@apple.com [Fri, 22 Nov 2013 20:06:42 +0000 (20:06 +0000)]
Fix 32-bit build.

* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController dealloc]):
(-[WKBrowsingContextController _initWithPageRef:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDebug builds unconditionally dump remote layer tree transactions to stderr.
mitz@apple.com [Fri, 22 Nov 2013 19:48:03 +0000 (19:48 +0000)]
Debug builds unconditionally dump remote layer tree transactions to stderr.

Reviewed by Sam Weinig.

* Platform/Logging.h: Declared RemoteLayerTree logging channel.
* Shared/mac/RemoteLayerTreeTransaction.h: Declared description().
* Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::dump): Changed to use description().
(WebKit::RemoteLayerTreeTransaction::description): Returns a CString with the description.
* UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::commit): Changed to use logging instead of calling dump().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] When the <box> value is set, derive radii from border-radius
hmuller@adobe.com [Fri, 22 Nov 2013 19:35:07 +0000 (19:35 +0000)]
[CSS Shapes] When the <box> value is set, derive radii from border-radius
https://bugs.webkit.org/show_bug.cgi?id=124228

Reviewed by Dean Jackson.

Source/WebCore:

Add support for BoxShape elliptical corners.

Tests: fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-001.html
       fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-002.html

* platform/graphics/FloatRoundedRect.h:
(WebCore::FloatRoundedRect::bottomLeftCorner): Corrected a copy-and-pasteO.
* rendering/shapes/BoxShape.cpp:
(WebCore::BoxShape::getExcludedIntervals): Returned interval now depends on the top and bottom of the line.
* rendering/shapes/Shape.cpp:
(WebCore::Shape::createShape): Rounded rect parameters are now specified with a RoundedRect parameter.
* rendering/shapes/Shape.h:
* rendering/shapes/ShapeInfo.cpp:
(WebCore::::computedShape): Pass style's rounded border to createShape().

LayoutTests:

* fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-001-expected.txt: Added.
* fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-001.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-002-expected.txt: Added.
* fast/shapes/shape-outside-floats/shape-outside-rounded-boxes-002.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSend out the right KVO callbacks when the page title changes
andersca@apple.com [Fri, 22 Nov 2013 19:33:44 +0000 (19:33 +0000)]
Send out the right KVO callbacks when the page title changes
https://bugs.webkit.org/show_bug.cgi?id=124753

Reviewed by Simon Fraser.

* UIProcess/API/mac/WKBrowsingContextController.mm:
(PageLoadStateObserver::PageLoadStateObserver):
New class that sends the right KVO notifications when the load state changes.

(-[WKBrowsingContextController dealloc]):
Remove the observer.

(-[WKBrowsingContextController _initWithPageRef:]):
Allocate the observer and add it.

* UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::~PageLoadState):
Assert that we don't have any observers left.

(WebKit::PageLoadState::addObserver):
Add the observer to the list.

(WebKit::PageLoadState::removeObserver):
Remove the observer from the list.

(WebKit::PageLoadState::reset):
Call title change callbacks.

(WebKit::PageLoadState::setTitle):
Ditto.

(WebKit::PageLoadState::callObserverCallback):
Helper function to dispatch callbacks to observers.

* UIProcess/PageLoadState.h:
Add new members.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGet rid of CodeBlock::dumpStatistics()
fpizlo@apple.com [Fri, 22 Nov 2013 18:24:04 +0000 (18:24 +0000)]
Get rid of CodeBlock::dumpStatistics()
https://bugs.webkit.org/show_bug.cgi?id=124762

Reviewed by Mark Hahnenberg.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::~CodeBlock):
* bytecode/CodeBlock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r159690.
commit-queue@webkit.org [Fri, 22 Nov 2013 17:46:12 +0000 (17:46 +0000)]
Unreviewed, rolling out r159690.
http://trac.webkit.org/changeset/159690
https://bugs.webkit.org/show_bug.cgi?id=124782

Broke webkitpy tests (Requested by ap on #webkit).

* Scripts/webkitpy/tool/bot/queueengine.py:
(QueueEngine.run):
(QueueEngine._open_work_log):
(QueueEngine._ensure_work_log_closed):
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem.review_patch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSeveral missing/incorrect guards for LOG_DISABLED=0 against Release build (Mac)
commit-queue@webkit.org [Fri, 22 Nov 2013 17:44:03 +0000 (17:44 +0000)]
Several missing/incorrect guards for LOG_DISABLED=0 against Release build (Mac)
https://bugs.webkit.org/show_bug.cgi?id=78735

Patch by Andres Gomez <agomez@igalia.com> on 2013-11-22
Reviewed by Mario Sanchez Prada.

In a "Debug" build the CString.h header comes from another
indirect dependency. Now, we explicitly add this missing include.

* page/CaptionUserPreferencesMediaAF.cpp: Explicitly adding
missing include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoLayout Test editing/deleting/password-delete-performance.html is failing
ap@apple.com [Fri, 22 Nov 2013 17:38:33 +0000 (17:38 +0000)]
Layout Test editing/deleting/password-delete-performance.html is failing
https://bugs.webkit.org/show_bug.cgi?id=124781

* TestExpectations: Skipped it, running a test that almost always times out makes little sense.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r159652.
commit-queue@webkit.org [Fri, 22 Nov 2013 17:34:04 +0000 (17:34 +0000)]
Unreviewed, rolling out r159652.
http://trac.webkit.org/changeset/159652
https://bugs.webkit.org/show_bug.cgi?id=124778

broke fast/dom/gc-attribute-node.html (Requested by ap on
#webkit).

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
* bytecompiler/BytecodeGenerator.h:
(JSC::CallArguments::registerOffset):
(JSC::CallArguments::argumentCountIncludingThis):
* bytecompiler/NodesCodegen.cpp:
(JSC::CallArguments::CallArguments):
(JSC::CallArguments::newArgument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[curl] Fix of SSL certificate chain storage
commit-queue@webkit.org [Fri, 22 Nov 2013 17:27:59 +0000 (17:27 +0000)]
[curl] Fix of SSL certificate chain storage
https://bugs.webkit.org/show_bug.cgi?id=124768

Patch by Robert Sipka <sipka@inf.u-szeged.hu> on 2013-11-22
Reviewed by Brent Fulgham.

Change the certificates storage type into ListHashSet
from HashSet to keep the chain order in each case.
This ensures that there is no difference between the stored
and the recieved certificate chain.

* platform/network/curl/SSLHandle.cpp:
(WebCore::allowsAnyHTTPSCertificateHosts):
(WebCore::sslIgnoreHTTPSCertificate):
(WebCore::pemData):
(WebCore::certVerifyCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Win] Avoid deadlock when interacting with some AVFoundationCF content
bfulgham@apple.com [Fri, 22 Nov 2013 17:23:21 +0000 (17:23 +0000)]
[Win] Avoid deadlock when interacting with some AVFoundationCF content
<rdar://problem/15482977> and https://bugs.webkit.org/show_bug.cgi?id=124752

Prevent deadlock caused by conflict over the "mapLock" mutex. Notification handling in the file,
which modify assets and make other changes, are required to happen on the main thread. This
patch enforces this requirement.

Reviewed by Eric Carlson.

* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::NotificationCallbackData::NotificationCallbackData): Added
(WebCore::AVFWrapper::processNotification): Moved logic from 'notificationCallback', which was
sometimes happening on a background thread.
(WebCore::AVFWrapper::notificationCallback): Dispatch calls to main thread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEWS creates 0 byte sized log files
commit-queue@webkit.org [Fri, 22 Nov 2013 16:26:27 +0000 (16:26 +0000)]
EWS creates 0 byte sized log files
https://bugs.webkit.org/show_bug.cgi?id=107606

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-11-22
Reviewed by Ryosuke Niwa.

There was a modification in r138264, that tried to make less log,
because some of the messeges were duplicated. After this the EWS
created the log file (with the same name as the bugID) but doesn't
write anything into it, even if there were errors during the build.
From now only creates the log file only if there is some error.

* Scripts/webkitpy/tool/bot/queueengine.py:
(QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
there is nothing to log. Open the log file only if a ScriptError was raised to
avoid to make empty log files for bugs.
(QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
because of changes in r138264. Teeing is used for locally testing purposes and
this feature is not used anymore.
(QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output
teeing anymore. It is a necessary change because of QueueEngine._open_work_log
change.
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
to be able to handle it in QueueEngine.run. Without this change, the existing
exception handler never run (the process_work_item method never raise ScriptError)
We can get the error message only from the ScriptError at this point.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImport more W3C tests for parsing template elements
rniwa@webkit.org [Fri, 22 Nov 2013 16:07:31 +0000 (16:07 +0000)]
Import more W3C tests for parsing template elements
https://bugs.webkit.org/show_bug.cgi?id=124763

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Imported more W3c tests for HTML template element at 12a1164ae919f29f6ba2d0c8a63f0eafb6b599aa
after applying fixes proposed at https://github.com/w3c/web-platform-tests/pull/442.

* html-templates/definitions/template-contents-expected.txt: Added.
* html-templates/definitions/template-contents-owner-document-type-expected.txt: Added.
* html-templates/definitions/template-contents-owner-document-type.html: Added.
* html-templates/definitions/template-contents-owner-test-001-expected.txt: Added.
* html-templates/definitions/template-contents-owner-test-001.html: Added.
* html-templates/definitions/template-contents-owner-test-002-expected.txt: Added.
* html-templates/definitions/template-contents-owner-test-002.html: Added.
* html-templates/definitions/template-contents.html: Added.
* html-templates/innerhtml-on-templates/innerhtml-expected.txt: Added.
* html-templates/innerhtml-on-templates/innerhtml.html: Added.
* html-templates/parsing-html-templates/additions-to-foster-parenting/template-is-a-foster-parent-element-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-foster-parenting/template-is-a-foster-parent-element.html: Added.
* html-templates/parsing-html-templates/additions-to-foster-parenting/template-is-not-a-foster-parent-element-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-foster-parenting/template-is-not-a-foster-parent-element.html: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/generating-of-implied-end-tags-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/generating-of-implied-end-tags.html: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-body-token-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-body-token.html: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-frameset-token-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-frameset-token.html: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-head-token-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-head-token.html: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-html-token-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/ignore-html-token.html: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/start-tag-body-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/start-tag-body.html: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/start-tag-html-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/start-tag-html.html: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/template-end-tag-without-start-one-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-the-in-body-insertion-mode/template-end-tag-without-start-one.html: Added.
* html-templates/parsing-html-templates/additions-to-the-in-frameset-insertion-mode/end-tag-frameset-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-the-in-frameset-insertion-mode/end-tag-frameset.html: Added.
* html-templates/parsing-html-templates/additions-to-the-in-head-insertion-mode/generating-of-implied-end-tags-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-the-in-head-insertion-mode/generating-of-implied-end-tags.html: Added.
* html-templates/parsing-html-templates/additions-to-the-in-head-insertion-mode/template-end-tag-without-start-one-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-the-in-head-insertion-mode/template-end-tag-without-start-one.html: Added.
* html-templates/parsing-html-templates/additions-to-the-in-table-insertion-mode/end-tag-table-expected.txt: Added.
* html-templates/parsing-html-templates/additions-to-the-in-table-insertion-mode/end-tag-table.html: Added.
* html-templates/parsing-html-templates/appending-to-a-template/template-child-nodes-expected.txt: Added.
* html-templates/parsing-html-templates/appending-to-a-template/template-child-nodes.html: Added.
* html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-body-context-expected.txt: Added.
* html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-body-context.html: Added.
* html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-context-expected.txt: Added.
* html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-context.html: Added.
* html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-row-context-expected.txt: Added.
* html-templates/parsing-html-templates/clearing-the-stack-back-to-a-given-context/clearing-stack-back-to-a-table-row-context.html: Added.
* html-templates/parsing-html-templates/creating-an-element-for-the-token/template-owner-document-expected.txt: Added.
* html-templates/parsing-html-templates/creating-an-element-for-the-token/template-owner-document.html: Added.

LayoutTests:

Updated the testharness.js/css to bc4639ba51b62158d94bb4fc6884b23453f3f7a1.

* resources/testharness.css:
* resources/testharness.js:
* resources/testharnessreport.js: Use innerText instead of innerHTML to avoid interpreting markup inside
the status and message as HTML.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WinCairo] Compile error when ACCELERATED_COMPOSITING is not used.
commit-queue@webkit.org [Fri, 22 Nov 2013 16:01:48 +0000 (16:01 +0000)]
[WinCairo] Compile error when ACCELERATED_COMPOSITING is not used.
https://bugs.webkit.org/show_bug.cgi?id=124773

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-22
Reviewed by Brent Fulgham.

* rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations): Added USE(ACCELERATED_COMPOSITING) guard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Fri, 22 Nov 2013 15:12:16 +0000 (15:12 +0000)]
Unreviewed GTK gardening.
Rebaselining after r159575 and r159579.

* platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
* platform/gtk/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
* platform/gtk/editing/deleting/delete-by-word-001-expected.txt: Added.
* platform/gtk/editing/deleting/delete-by-word-002-expected.txt: Added.
* platform/gtk/editing/input/option-page-up-down-expected.txt: Added.
* platform/gtk/editing/input/scroll-viewport-page-up-down-expected.txt: Added.
* platform/gtk/editing/undo/undo-deleteWord-expected.txt: Added.
* platform/gtk/fast/block/float/024-expected.txt:
* platform/gtk/fast/block/margin-collapse/025-expected.txt:
* platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Fri, 22 Nov 2013 15:00:39 +0000 (15:00 +0000)]
Unreviewed GTK gardening.
Adding failure expectations for tests that regressed with r159572.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Grid Layout] Improve content-sized track layout
svillar@igalia.com [Fri, 22 Nov 2013 11:03:32 +0000 (11:03 +0000)]
[CSS Grid Layout] Improve content-sized track layout
https://bugs.webkit.org/show_bug.cgi?id=124408

Reviewed by Dean Jackson.

PerformanceTests:

From Blink r156122 by <jchaffraix@chromium.org>

New test to check the performance of layouting grids with content sized tracks.

* Layout/auto-grid-lots-of-data.html: Added.

Source/WebCore:

Test: fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html

From Blink r156122 & r157633 by <jchaffraix@chromium.org>

Added a couple of optimizations to speed up the layout of content
based tracks. The idea is to narrow down the conditions for
relayouting when the height of a grid area changes. We basically
just need to layout tracks with percentage heights as they're the
only ones that change.

A new performance test is attached to demonstrate the effect of
these optimizations. We get a ~1000% improvement on a i7 M620
going from 14.5 runs/s to 165 runs/s.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::logicalContentHeightForChild):
(WebCore::RenderGrid::layoutGridItems):

LayoutTests:

From Blink r157633 by <jchaffraix@chromium.org>

New test to verify that grid items with percentage logical
{min|max}-height resolve their sizes properly.

* fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic-expected.txt: Added.
* fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Grid Layout] Run the content-sized tracks sizing algorithm only when required
svillar@igalia.com [Fri, 22 Nov 2013 09:25:01 +0000 (09:25 +0000)]
[CSS Grid Layout] Run the content-sized tracks sizing algorithm only when required
https://bugs.webkit.org/show_bug.cgi?id=124039

Reviewed by Dean Jackson.

PerformanceTests:

From Blink r156028 and r156168 by <jchaffraix@chromium.org>.

New performance tests for layouts in grids with fixed size tracks.

* Layout/fixed-grid-lots-of-data.html: Added.

Source/WebCore:

The current code runs the content sized track sizing algorithm all
the time, which forces a layout even when the track is not
content-sized. This change improves the situation by applying two
optimizations. In the first one, we bail out the algorithm if we
detect that we don't need to run it. And by the second one we
reduce the amount of recomputations by only iterating over the
content sized tracks instead of all of them. Both changes follow
the ideas introduced in Blink r156028 and r156168 by
<jchaffraix@chromium.org>.

As we changed the way we iterate over children (we use the
GridIterator now) the way they're stored in the RenderGrid changes
too. If a item spans through several "cells" inside the grid, we
will have a reference to it on each of them.

These two changes account for a ~3200% improvement on a i7 M620 in
the test that accompanies this change (15.5 vs 520 run/s).

New perf test: PerformanceTests/Layout/fixed-grid-lots-of-data.html

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks): Keep track
of content sized tracks and only iterate over them.
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
Early return if there are no tracks to pass to the algorithm.
* rendering/RenderGrid.h:
* rendering/style/GridLength.h:
(WebCore::GridLength::isContentSized):
* rendering/style/GridTrackSize.h:
(WebCore::GridTrackSize::isContentSized):

LayoutTests:

From Blink r156028 and r156168 by <jchaffraix@chromium.org>.

Subtle baseline change due to grids triggering less layouts, which
changes the frame rects between 2 subsequent layouts thus changing
the repaint rectangles.

* fast/css-grid-layout/grid-item-change-column-repaint-expected.txt:
* fast/css-grid-layout/grid-item-change-row-repaint-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] Move code after early break in RenderRegion::repaintFlowThreadContentRe...
rego@igalia.com [Fri, 22 Nov 2013 09:22:50 +0000 (09:22 +0000)]
[CSS Regions] Move code after early break in RenderRegion::repaintFlowThreadContentRectangle
https://bugs.webkit.org/show_bug.cgi?id=124743

Reviewed by Mihnea Ovidenie.

No new tests, covered by existing tests.

* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::repaintFlowThreadContentRectangle): Variable
flippedFlowThreadPortionRect is not used before the early break, so we
can move it after and save some unneeded operations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] Use hasOverflowClip() in RenderRegion
rego@igalia.com [Fri, 22 Nov 2013 08:28:26 +0000 (08:28 +0000)]
[CSS Regions] Use hasOverflowClip() in RenderRegion
https://bugs.webkit.org/show_bug.cgi?id=124746

Reviewed by Mihnea Ovidenie.

Implement the suggested FIXME in RenderRegion using hasOverflowClip().

No new tests, covered by existing tests.

* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::overflowRectForFlowThreadPortion): Use
hasOverflowClip().
(WebCore::RenderRegion::rectFlowPortionForBox): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove ANGLEGenerated from Windows build.
commit-queue@webkit.org [Fri, 22 Nov 2013 05:12:47 +0000 (05:12 +0000)]
Remove ANGLEGenerated from Windows build.
https://bugs.webkit.org/show_bug.cgi?id=124759

Patch by Alex Christensen <achristensen@webkit.org> on 2013-11-21
Reviewed by Darin Adler.

Source/ThirdParty/ANGLE:

* ANGLE.vcxproj/ANGLEGenerated.vcxproj: Removed.
* ANGLE.vcxproj/ANGLEGenerated.vcxproj.filters: Removed.

Source/WebKit:

* WebKit.vcxproj/WebKit.sln:
Remove references to ANGLEGenerated.vcxproj.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMap the dir attribute to the CSS direction property.
commit-queue@webkit.org [Fri, 22 Nov 2013 05:03:26 +0000 (05:03 +0000)]
Map the dir attribute to the CSS direction property.
https://bugs.webkit.org/show_bug.cgi?id=124572.

Patch by Frédéric Wang <fred.wang@free.fr> on 2013-11-21
Reviewed by Darin Adler.

Source/WebCore:

Test: mathml/presentation/mstyle-css-attributes.html

* mathml/MathMLElement.cpp:
(WebCore::MathMLElement::isPresentationAttribute): reorder attributes
(WebCore::MathMLElement::collectStyleForPresentationAttribute): reorder tags that accept dir
(WebCore::MathMLElement::isMathMLToken): add an inline function to test that a tag corresponds to a MathML Token Element.
* mathml/MathMLElement.h:

Follow-up work to address Darin's comments.

LayoutTests:

* mathml/presentation/direction-overall-expected.html: test that dir does not apply to msqrt
* mathml/presentation/direction-overall.html:
* mathml/presentation/mstyle-css-attributes-expected.html: Added.
* mathml/presentation/mstyle-css-attributes.html: Added.

Add more tests for presentation attributes on mstyle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove ENABLE_WORKERS
commit-queue@webkit.org [Fri, 22 Nov 2013 05:01:46 +0000 (05:01 +0000)]
Remove ENABLE_WORKERS
https://bugs.webkit.org/show_bug.cgi?id=105784

.:

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

* Source/autotools/SetupWebKitFeatures.m4:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/WebCore:

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

Source/WebKit:

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/efl:

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

* ewk/ewk_settings.cpp:
(ewk_settings_memory_cache_clear):

Source/WebKit/win:

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

* WebWorkersPrivate.cpp:
(WebWorkersPrivate::workerThreadCount):

Source/WTF:

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

* wtf/FeatureDefines.h:
* wtf/nix/FeatureDefinesNix.h:

Tools:

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

* Scripts/webkitperl/FeatureList.pm:

WebKitLibraries:

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.

* win/tools/vsprops/FeatureDefines.props:
* win/tools/vsprops/FeatureDefinesCairo.props:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Win] Unreviewed build fix after r159632.
alex.christensen@flexsim.com [Fri, 22 Nov 2013 04:42:11 +0000 (04:42 +0000)]
[Win] Unreviewed build fix after r159632.

* platform/network/curl/SSLHandle.cpp:
(WebCore::certVerifyCallback):
Fixed template syntax.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix a typo (requriements->requirements).
fpizlo@apple.com [Fri, 22 Nov 2013 04:24:22 +0000 (04:24 +0000)]
Fix a typo (requriements->requirements).

* runtime/StackAlignment.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTry to fix buildbot Dashboard for people who have not hidden anything.
darin@apple.com [Fri, 22 Nov 2013 04:22:49 +0000 (04:22 +0000)]
Try to fix buildbot Dashboard for people who have not hidden anything.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
Add a null check for hidden platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove chrome/chromium related things from webkitpy.
commit-queue@webkit.org [Fri, 22 Nov 2013 04:17:22 +0000 (04:17 +0000)]
Remove chrome/chromium related things from webkitpy.
https://bugs.webkit.org/show_bug.cgi?id=124493

Patch by Peter Szanka <h868064@stud.u-szeged.hu> on 2013-11-21
Reviewed by Darin Adler.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(PortTest.assert_mock_port_works):
* Scripts/webkitpy/port/base.py:
(Port.to.setup_environ_for_server):
* Scripts/webkitpy/port/mac_unittest.py:
(test_tests_for_other_platforms):
* Scripts/webkitpy/port/mock_drt.py:
(MockTestShell.output_for_test):
* Scripts/webkitpy/tool/bot/irc_command.py:
(Restart.execute):
* Scripts/webkitpy/tool/bot/ircbot_unittest.py:
(IRCBotTest.test_help):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Fix build after r159656
commit-queue@webkit.org [Fri, 22 Nov 2013 04:05:13 +0000 (04:05 +0000)]
[EFL][WK2] Fix build after r159656
https://bugs.webkit.org/show_bug.cgi?id=124755

Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-11-21
Reviewed by Gyuyoung Kim.

Page title was moved to page load state.

* UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:
(WebKit::WebInspectorServer::buildPageList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix.
alex.christensen@flexsim.com [Fri, 22 Nov 2013 03:56:50 +0000 (03:56 +0000)]
Unreviewed build fix.

* src/libGLESv2/Constants.h: Added from checkout a60e0805721f62c28a55faf2df74472cc5fc91fc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIn filereader.py, process_file() should throw instead of exiting directly when the...
commit-queue@webkit.org [Fri, 22 Nov 2013 03:49:50 +0000 (03:49 +0000)]
In filereader.py, process_file() should throw instead of exiting directly when the file doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=124717

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-21
Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/style/filereader.py:
(TextFileReader.process_file):
* Scripts/webkitpy/style/filereader_unittest.py:
(TextFileReaderTest.test_process_file__does_not_exist):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: [CSS Shapes] Refactor highlighting code to decrease Shapes API surface
betravis@adobe.com [Fri, 22 Nov 2013 03:17:15 +0000 (03:17 +0000)]
Web Inspector: [CSS Shapes] Refactor highlighting code to decrease Shapes API surface
https://bugs.webkit.org/show_bug.cgi?id=124737

Reviewed by Timothy Hatcher.

Source/WebCore:

Add a virtual method to Shapes, buildPath, that can be used to build the
path (in the Shape coordinate system) for display in the Inspector. This allows us
to remove methods such as type(), polygon(), and logicalRx/Ry() which exposed the
inner workings of the Shapes classes. Also covers the addition of the BoxShape type.

Refactoring, existing test is inspector-protocol/model/highlight-shape-outside.html.

* inspector/InspectorOverlay.cpp:
(WebCore::appendPathCommandAndPoints): Points need to be translated from shape space
to renderer space using ShapeInfo.
(WebCore::buildObjectForShapeOutside): Add the ShapeOutsideInfo to the path info struct.
* rendering/shapes/BoxShape.cpp:
(WebCore::BoxShape::buildPath): Build the path for a BoxShape.
* rendering/shapes/BoxShape.h:
* rendering/shapes/PolygonShape.cpp:
(WebCore::PolygonShape::buildPath): Build the path for a PolygonShape.
* rendering/shapes/PolygonShape.h:
* rendering/shapes/RasterShape.h:
* rendering/shapes/RectangleShape.cpp:
(WebCore::RectangleShape::buildPath): Build the path for a RectangleShape.
* rendering/shapes/RectangleShape.h:
* rendering/shapes/Shape.h:

LayoutTests:

The shapes paths are now drawn in shape-coordinate space before being translated to
renderer space. With different writing modes, shapes may have their coordinates
translated. For example, a rectangle specified as four points [top left, top right,
bottom right, bottom left] in vertical-lr space would appear as [top left, bottom left,
bottom right, top right] in horizontal-tb space. Adjusting the previous tests, and
adding a test for the new box value.

* inspector-protocol/model/highlight-shape-outside-expected.txt:
* inspector-protocol/model/highlight-shape-outside.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCodeBlock::m_numCalleeRegisters need to honor native stack alignment.
mark.lam@apple.com [Fri, 22 Nov 2013 03:12:13 +0000 (03:12 +0000)]
CodeBlock::m_numCalleeRegisters need to honor native stack alignment.
https://bugs.webkit.org/show_bug.cgi?id=124754.

Reviewed by Filip Pizlo.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::newRegister):
* dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago<https://webkit.org/b/124702> Stop overriding VALID_ARCHS.
mrowe@apple.com [Fri, 22 Nov 2013 03:04:12 +0000 (03:04 +0000)]
<https://webkit.org/b/124702> Stop overriding VALID_ARCHS.

All modern versions of Xcode set it appropriately for our needs.

Reviewed by Alexey Proskuryakov.

Source/JavaScriptCore:

* Configurations/Base.xcconfig:

Source/WebCore:

* Configurations/Base.xcconfig:

Source/WebInspectorUI:

* Configurations/Base.xcconfig:

Source/WebKit/mac:

* Configurations/Base.xcconfig:

Source/WebKit2:

* Configurations/Base.xcconfig:

Tools:

* MiniBrowser/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agowebkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element
commit-queue@webkit.org [Fri, 22 Nov 2013 03:01:55 +0000 (03:01 +0000)]
webkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element
https://bugs.webkit.org/show_bug.cgi?id=124676

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-21
Reviewed by Daniel Bates.

checkForArgumentAndRemoveFromArrayRef functions was removing wrong
elements when there were more then one occurrence of that argument.
E.g: Checking for 'a' in {a, b, a, c}, the resulting array would be
{b, a}, when it should be {b, c}.

* Scripts/webkitdirs.pm:
(checkForArgumentAndRemoveFromArrayRef): bugfix mentioned above.
* Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
Added; Unit tests for webkitdirs::checkForArgumentAndRemoveFromArrayRef function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Unreviewed buildfix after r159614 and r159656.
ryumiel@company100.net [Fri, 22 Nov 2013 03:01:26 +0000 (03:01 +0000)]
[GTK] Unreviewed buildfix after r159614 and r159656.

Source/WebCore:

* bindings/gobject/WebKitDOMCustom.cpp: Add missing header

Source/WebKit2:

* UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
(WebKit::WebInspectorServer::buildPageList): Use the page load state to get page title.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix WinCairo unreachable code warnings in SimpleLineLayout.cpp
commit-queue@webkit.org [Fri, 22 Nov 2013 02:59:45 +0000 (02:59 +0000)]
Fix WinCairo unreachable code warnings in SimpleLineLayout.cpp
https://bugs.webkit.org/show_bug.cgi?id=124704

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-21
Reviewed by Antti Koivisto.

Fix unreachable code warnings using conditional directives.

* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago<https://webkit.org/b/124701> Fix an error in a few Xcode configuration setting files.
mrowe@apple.com [Fri, 22 Nov 2013 02:57:41 +0000 (02:57 +0000)]
<https://webkit.org/b/124701> Fix an error in a few Xcode configuration setting files.

Reviewed by Alexey Proskuryakov.

Source/JavaScriptCore:

* Configurations/Base.xcconfig:

Source/ThirdParty/ANGLE:

* Configurations/Base.xcconfig:

Source/WebCore:

* Configurations/Base.xcconfig:

Source/WebKit/mac:

* Configurations/Base.xcconfig:

Source/WebKit2:

* Configurations/Base.xcconfig:

Source/WTF:

* Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate build-webkit after r159550.
rniwa@webkit.org [Fri, 22 Nov 2013 02:56:22 +0000 (02:56 +0000)]
Update build-webkit after r159550.

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago<https://webkit.org/b/124700> Fix some deprecation warnings.
mrowe@apple.com [Fri, 22 Nov 2013 02:55:19 +0000 (02:55 +0000)]
<https://webkit.org/b/124700> Fix some deprecation warnings.

Reviewed by Anders Carlsson.

Source/WebCore:

* platform/mac/HTMLConverter.mm:
(fileWrapperForURL): Move off a deprecated NSFileWrapper method.

Source/WebKit/mac:

* Plugins/WebNetscapePluginStream.mm:
(WebNetscapePluginStream::startStream): Move off a deprecated NSData method.
* WebView/WebDataSource.mm:
(-[WebDataSource _fileWrapperForURL:]): Move off a deprecated NSFileWrapper method.
* WebView/WebHTMLView.mm:
(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.

Source/WebKit2:

* UIProcess/API/mac/WKView.mm:
(-[WKView namesOfPromisedFilesDroppedAtDestination:]): Move off a deprecated NSFileWrapper method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Layout tests with editing need to be rebaselined.
commit-queue@webkit.org [Fri, 22 Nov 2013 02:53:04 +0000 (02:53 +0000)]
[EFL] Layout tests with editing need to be rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=124751

Unreviewed, EFL rebaseline.

editing/input/reveal-caret-of-multiline-contenteditable.html test is rebaselined after r137239.
editing/selection/5354455-2.html test is rebaselined after r133000.
Rebaseline the expected results to suit editing-related performance in EFL.

Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-21

* platform/efl-wk1/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
* platform/efl/editing/selection/5354455-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate apple builders.
lforschler@apple.com [Fri, 22 Nov 2013 02:38:21 +0000 (02:38 +0000)]
Update apple builders.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImport some W3C tests for HTML template element
rniwa@webkit.org [Fri, 22 Nov 2013 02:20:08 +0000 (02:20 +0000)]
Import some W3C tests for HTML template element
https://bugs.webkit.org/show_bug.cgi?id=124699

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Imported the shared resources for web-platform-tests/html-templates as well as tests under
serializing-html-templates and template-element at a274ad93ef5dc02ac042e0a5d58327d4135178ac.

* ChangeLog: Added.
* html-templates/resources/end-template-tag-in-body.html: Added.
* html-templates/resources/end-template-tag-in-head.html: Added.
* html-templates/resources/frameset-end-tag.html: Added.
* html-templates/resources/head-template-contents-div-no-end-tag.html: Added.
* html-templates/resources/head-template-contents-table-no-end-tag.html: Added.
* html-templates/resources/html-start-tag.html: Added.
* html-templates/resources/template-child-nodes-div.xhtml: Added.
* html-templates/resources/template-child-nodes-nested.xhtml: Added.
* html-templates/resources/template-contents-attribute.html: Added.
* html-templates/resources/template-contents-body.html: Added.
* html-templates/resources/template-contents-div-no-end-tag.html: Added.
* html-templates/resources/template-contents-empty.html: Added.
* html-templates/resources/template-contents-frameset.html: Added.
* html-templates/resources/template-contents-head.html: Added.
* html-templates/resources/template-contents-html.html: Added.
* html-templates/resources/template-contents-nested.html: Added.
* html-templates/resources/template-contents-table-no-end-tag.html: Added.
* html-templates/resources/template-contents-text.html: Added.
* html-templates/resources/template-contents.html: Added.
* html-templates/resources/template-descendant-body.html: Added.
* html-templates/resources/template-descendant-frameset.html: Added.
* html-templates/resources/template-descendant-head.html: Added.
* html-templates/resources/two-templates.html: Added.
* html-templates/serializing-html-templates/outerhtml-expected.txt: Added.
* html-templates/serializing-html-templates/outerhtml.html: Added.
* html-templates/template-element/content-attribute-expected.txt: Added.
* html-templates/template-element/content-attribute.html: Added.
* html-templates/template-element/node-document-changes-expected.txt: Added.
* html-templates/template-element/node-document-changes.html: Added.
* html-templates/template-element/template-as-a-descendant-expected.txt: Added.
* html-templates/template-element/template-as-a-descendant.html: Added.
* html-templates/template-element/template-content-expected.txt: Added.
* html-templates/template-element/template-content-node-document-expected.txt: Added.
* html-templates/template-element/template-content-node-document.html: Added.
* html-templates/template-element/template-content.html: Added.
* html-templates/template-element/template-descendant-body-expected.txt: Added.
* html-templates/template-element/template-descendant-body.html: Added.
* html-templates/template-element/template-descendant-frameset-expected.txt: Added.
* html-templates/template-element/template-descendant-frameset.html: Added.
* html-templates/template-element/template-descendant-head-expected.txt: Added.
* html-templates/template-element/template-descendant-head.html: Added.
* html-templates/testcommon.js: Added.

LayoutTests:

* imported/w3c/: Added.
* platform/win/TestExpectations: Skip the imported tests since the template element is disabled on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDon't fetch hidden platforms on build.webkit.org/dashboard
dino@apple.com [Fri, 22 Nov 2013 02:12:12 +0000 (02:12 +0000)]
Don't fetch hidden platforms on build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=124750

Reviewed by Tim Horton.

If a platform is hidden, don't fetch its data. If it
becomes unhidden, try to fetch immediately (unless
you've recently fetched).

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDidn't mean to commit this.
andersca@apple.com [Fri, 22 Nov 2013 01:29:28 +0000 (01:29 +0000)]
Didn't mean to commit this.

* UIProcess/PageLoadState.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening to hide annoying *.user files when.
bfulgham@apple.com [Fri, 22 Nov 2013 01:16:31 +0000 (01:16 +0000)]
Unreviewed gardening to hide annoying *.user files when.

* ANGLE.vcxproj: Added property svn:ignore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove page title handling to the page load state
andersca@apple.com [Fri, 22 Nov 2013 01:13:02 +0000 (01:13 +0000)]
Move page title handling to the page load state
https://bugs.webkit.org/show_bug.cgi?id=124748

Reviewed by Dan Bernstein.

* UIProcess/API/C/WKPage.cpp:
(WKPageCopyTitle):
* UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::reset):
(WebKit::PageLoadState::didCommitLoad):
(WebKit::PageLoadState::title):
(WebKit::PageLoadState::setTitle):
* UIProcess/PageLoadState.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveTitleForFrame):
* UIProcess/WebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoARM64: Implement push/pop equivalents in LLInt
msaboff@apple.com [Fri, 22 Nov 2013 01:11:54 +0000 (01:11 +0000)]
ARM64: Implement push/pop equivalents in LLInt
https://bugs.webkit.org/show_bug.cgi?id=124721

Reviewed by Filip Pizlo.

Added pushLRAndFP and popLRAndFP that push and pop the link register and frame pointer register.
These ops emit code just like what the compiler emits in the prologue and epilogue.  Also changed
pushCalleeSaves and popCalleeSaves to use the same store pair and load pair instructions to do
the actually pushing and popping.  Finally changed the implementation of push and pop to raise
an exception since we don't have (or need) a single register push or pop.

* llint/LowLevelInterpreter64.asm:
* offlineasm/arm64.rb:
* offlineasm/instructions.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoJSC: Removed unused opcodes from offline assembler
msaboff@apple.com [Fri, 22 Nov 2013 00:46:09 +0000 (00:46 +0000)]
JSC: Removed unused opcodes from offline assembler
https://bugs.webkit.org/show_bug.cgi?id=124749

Reviewed by Mark Hahnenberg.

Removed the unused, X86 only peekq and pokeq.

* offlineasm/instructions.rb:
* offlineasm/x86.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(159395) Fix branch8(…, AbsoluteAddress, …) in ARM64 MacroAssembler
msaboff@apple.com [Fri, 22 Nov 2013 00:31:55 +0000 (00:31 +0000)]
REGRESSION(159395) Fix branch8(…, AbsoluteAddress, …) in ARM64 MacroAssembler
https://bugs.webkit.org/show_bug.cgi?id=124688

Reviewed by Geoffrey Garen.

Changed handling of the address for the load8() in the branch8(AbsoluteAddress) to be like
the rest of the branchXX(AbsoluteAddress) fucntions.

* assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::branch8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBytecodeGenerator should align the stack according to native conventions
fpizlo@apple.com [Thu, 21 Nov 2013 23:55:58 +0000 (23:55 +0000)]
BytecodeGenerator should align the stack according to native conventions
https://bugs.webkit.org/show_bug.cgi?id=124735

Reviewed by Mark Lam.

* bytecompiler/BytecodeGenerator.h:
(JSC::CallArguments::registerOffset):
(JSC::CallArguments::argumentCountIncludingThis):
* bytecompiler/NodesCodegen.cpp:
(JSC::CallArguments::CallArguments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] Build fix; export symbol for WebCore::provideDeviceOrientationTo()
dbates@webkit.org [Thu, 21 Nov 2013 23:24:39 +0000 (23:24 +0000)]
[iOS] Build fix; export symbol for WebCore::provideDeviceOrientationTo()

Add the symbol __ZN7WebCore26provideDeviceOrientationToEPNS_4PageEPNS_23DeviceOrientationClientE.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard
dbates@webkit.org [Thu, 21 Nov 2013 23:21:35 +0000 (23:21 +0000)]
Add !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard
https://bugs.webkit.org/show_bug.cgi?id=124741

Reviewed by Alexey Proskuryakov.

Add !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard around code that is unused
when building with feature NETWORK_CFDATA_ARRAY_CALLBACK.

Additionally, add a declaration for allocateSegment() with attribute WARN_UNUSED_RETURN
to have the compiler warn when the return value of this function is unused. Together with
warnings treated as errors this change will prevent a memory leak.

* platform/SharedBuffer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove unused functions from WebCore and WebKit2
dbates@webkit.org [Thu, 21 Nov 2013 23:20:38 +0000 (23:20 +0000)]
Remove unused functions from WebCore and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=124739

Reviewed by Alexey Proskuryakov.

Source/WebCore:

* editing/markup.cpp: Remove unused functions isHTMLBlockElement and
ancestorToRetainStructureAndAppearanceWithNoRenderer.
* rendering/InlineElementBox.cpp: Append newline to the end of the file.

Source/WebKit2:

Remove unused functions autoreleased({WKURLRequestRef, WKURLResponseRef}).

* UIProcess/API/mac/WKBrowsingContextController.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoOnly generate isObservable() when IDL specifies GenerateIsReachable
dbates@webkit.org [Thu, 21 Nov 2013 23:19:25 +0000 (23:19 +0000)]
Only generate isObservable() when IDL specifies GenerateIsReachable
https://bugs.webkit.org/show_bug.cgi?id=124729

Reviewed by Geoffrey Garen.

We should only generate the static inline function isObservable() when the IDL
specifies GenerateIsReachable. Otherwise, this function is unused.

Added a new test IDL TestGenerateIsReachable.idl and expected results to test that
we generate isObservable() when an IDL specifies GenerateIsReachable. Additionally,
rebased existing test results.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/test/CPP/WebDOMTestGenerateIsReachable.cpp: Added.
* bindings/scripts/test/CPP/WebDOMTestGenerateIsReachable.h: Added.
* bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachable.cpp: Added.
* bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachable.h: Added.
* bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachablePrivate.h: Added.
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: Removed unused function isObservable().
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Ditto.
* bindings/scripts/test/JS/JSTestEventConstructor.cpp: Ditto.
* bindings/scripts/test/JS/JSTestEventTarget.cpp: Ditto.
* bindings/scripts/test/JS/JSTestException.cpp: Ditto.
* bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp: Added.
* bindings/scripts/test/JS/JSTestGenerateIsReachable.h: Added.
* bindings/scripts/test/JS/JSTestInterface.cpp: Removed unused function isObservable().
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Ditto.
* bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp: Ditto.
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.
* bindings/scripts/test/JS/JSTestTypedefs.cpp: Ditto.
* bindings/scripts/test/JS/JSattribute.cpp: Ditto.
* bindings/scripts/test/JS/JSreadonly.cpp: Ditto.
* bindings/scripts/test/ObjC/DOMTestGenerateIsReachable.h: Added.
* bindings/scripts/test/ObjC/DOMTestGenerateIsReachable.mm: Added.
* bindings/scripts/test/ObjC/DOMTestGenerateIsReachableInternal.h: Added.
* bindings/scripts/test/TestGenerateIsReachable.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRename PlatformCertificateInfo to CertificateInfo
ossy@webkit.org [Thu, 21 Nov 2013 22:31:08 +0000 (22:31 +0000)]
Rename PlatformCertificateInfo to CertificateInfo
https://bugs.webkit.org/show_bug.cgi?id=124150

Reviewed by Darin Adler.

* GNUmakefile.list.am:
* NetworkProcess/AsynchronousNetworkLoaderClient.cpp:
(WebKit::AsynchronousNetworkLoaderClient::didReceiveResponse):
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcess.messages.in:
* NetworkProcess/NetworkResourceLoader.cpp:
* NetworkProcess/mac/NetworkProcessMac.mm:
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
* NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
* PlatformEfl.cmake:
* PlatformGTK.cmake:
* Shared/API/c/mac/WKCertificateInfoMac.mm:
(WKCertificateInfoCreateWithCertficateChain):
(WKCertificateInfoGetCertificateChain):
* Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::tryUseCertificateInfoForChallenge):
(WebKit::AuthenticationManager::useCredentialForChallenge):
* Shared/Authentication/AuthenticationManager.h:
* Shared/Authentication/AuthenticationManager.messages.in:
* Shared/Authentication/mac/AuthenticationManager.mac.mm:
(WebKit::AuthenticationManager::tryUseCertificateInfoForChallenge):
* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
* Shared/WebCertificateInfo.h:
(WebKit::WebCertificateInfo::create):
(WebKit::WebCertificateInfo::certificateInfo):
(WebKit::WebCertificateInfo::WebCertificateInfo):
* Shared/mac/CertificateInfo.h: Renamed from Source/WebKit2/Shared/mac/PlatformCertificateInfo.h.
(WebKit::CertificateInfo::certificateChain):
* Shared/mac/CertificateInfo.mm: Renamed from Source/WebKit2/Shared/mac/PlatformCertificateInfo.mm.
(WebKit::CertificateInfo::CertificateInfo):
(WebKit::CertificateInfo::encode):
(WebKit::CertificateInfo::decode):
(WebKit::CertificateInfo::dump):
* Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):
* Shared/soup/CertificateInfo.cpp: Renamed from Source/WebKit2/Shared/soup/PlatformCertificateInfo.cpp.
(WebKit::CertificateInfo::CertificateInfo):
(WebKit::CertificateInfo::~CertificateInfo):
(WebKit::CertificateInfo::encode):
(WebKit::CertificateInfo::decode):
* Shared/soup/CertificateInfo.h: Renamed from Source/WebKit2/Shared/soup/PlatformCertificateInfo.h.
(WebKit::CertificateInfo::certificate):
(WebKit::CertificateInfo::tlsErrors):
* Shared/soup/WebCoreArgumentCodersSoup.cpp:
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):
* UIProcess/API/gtk/WebKitCertificateInfo.cpp:
(webkitCertificateInfoGetCertificateInfo):
* UIProcess/API/gtk/WebKitCertificateInfoPrivate.h:
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_get_tls_info):
* UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
(WebKit::AuthenticationChallengeProxy::useCredential):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::allowSpecificHTTPSCertificateForHost):
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didCommitLoad):
* UIProcess/WebFrameProxy.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):
* WebProcess/Network/WebResourceLoader.h:
* WebProcess/Network/WebResourceLoader.messages.in:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:
* WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::allowSpecificHTTPSCertificateForHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][GTK][WK2] Build fix after r159641
ossy@webkit.org [Thu, 21 Nov 2013 22:28:34 +0000 (22:28 +0000)]
[EFL][GTK][WK2] Build fix after r159641
https://bugs.webkit.org/show_bug.cgi?id=124742

Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-11-21
Reviewed by Csaba Osztrogonác.

Should fetch activeURL from page load state.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewUpdateURI):
* UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:
(WebKit::WebInspectorServer::buildPageList):
* UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
(WebKit::WebInspectorServer::buildPageList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a new mode to extend the tile cache beyond the page
bdakin@apple.com [Thu, 21 Nov 2013 21:57:53 +0000 (21:57 +0000)]
Add a new mode to extend the tile cache beyond the page
https://bugs.webkit.org/show_bug.cgi?id=124216

Reviewed by Simon Fraser.

This patch makes it possible to give the tile cache a margin of tiles. If there is
a margin of tiles, this patch paints those tiles with the background color. Note
that this patch does not actually give the tile cache a margin at this time.

You opt into a margined tiled cache by called setTileMargins() with number of
pixels that the margin on that side should be.
* platform/graphics/TiledBacking.h:
* platform/graphics/ca/mac/TileController.h:
* platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::TileController):
(WebCore::TileController::tilesWouldChangeForVisibleRect):

TileController::bounds() now computes the bounds INCLUDING the margin.
(WebCore::TileController::bounds):

adjustRectAtTileIndexForMargin() is a new function that is required to get the
rect size for tiles in the margin right. rectForTileIndex() assumes all tiles
strive to be the size of m_tileSize, but now margin tiles will be whatever the
margin sizes were set to.
(WebCore::TileController::adjustRectAtTileIndexForMargin):
(WebCore::TileController::rectForTileIndex):

This is another instance where m_tileSize is not always the right size to use.
(WebCore::TileController::getTileIndexRangeForRect):

The tile coverage rect now might include the margin tiles. Only include them in
slow-scrolling mode if the current position is within one tile of the edge.
(WebCore::TileController::computeTileCoverageRect):

tileSizeForCoverageRect() does not make sense in a world where the coverage rect
will include margin. Instead, this patch implements the current strategy more
explicitly by returning the visibleRect in the slow scrolling case, and in the
process this patch also re-names tileSizeForCoverageRect() to computeTileSize()
since it no longer takes a coverageRect.
(WebCore::TileController::computeTileSize):
(WebCore::TileController::revalidateTiles):

New setters and getters for the tile margins on each side.
(WebCore::TileController::setTileMargins):
(WebCore::TileController::hasMargins):
(WebCore::TileController::topMarginHeight):
(WebCore::TileController::bottomMarginHeight):
(WebCore::TileController::leftMarginWidth):
(WebCore::TileController::rightMarginWidth):

New function to add margin onto the composited bounds if there is one.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::tiledBackingHasMargin):
(WebCore::RenderLayerBacking::paintContents):
(WebCore::RenderLayerBacking::compositedBoundsIncludingMargin):
* rendering/RenderLayerBacking.h:

Do not set masks to bounds if there is a margin on the root layer.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::mainFrameBackingIsTiledWithMargin):
* rendering/RenderLayerCompositor.h:

Allow background color to paint into the margin tiles.
* rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImplement WebCrypto wrapKey
ap@apple.com [Thu, 21 Nov 2013 21:55:20 +0000 (21:55 +0000)]
Implement WebCrypto wrapKey
https://bugs.webkit.org/show_bug.cgi?id=124738

Reviewed by Anders Carlsson.

Source/WebCore:

Tests: crypto/subtle/aes-cbc-wrap-rsa-non-extractable.html
       crypto/subtle/aes-cbc-wrap-rsa.html

* bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::exportKey): Factored out the actual operation that can be chained with
encryption for wrapKey.
(WebCore::JSSubtleCrypto::exportKey):
(WebCore::JSSubtleCrypto::wrapKey):
(WebCore::JSSubtleCrypto::unwrapKey): Fixed a memory leak in failure code path.

* crypto/SubtleCrypto.idl: Added wrapKey.

LayoutTests:

* crypto/subtle/aes-cbc-wrap-rsa-expected.txt: Added.
* crypto/subtle/aes-cbc-wrap-rsa-non-extractable-expected.txt: Added.
* crypto/subtle/aes-cbc-wrap-rsa-non-extractable.html: Added.
* crypto/subtle/aes-cbc-wrap-rsa.html: Added.

* crypto/subtle/aes-export-key-expected.txt:
* crypto/subtle/hmac-export-key-expected.txt:
There is no longer a console message, the error is in an exception.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, preemptive build fix.
fpizlo@apple.com [Thu, 21 Nov 2013 21:11:06 +0000 (21:11 +0000)]
Unreviewed, preemptive build fix.

* runtime/StackAlignment.h:
(JSC::stackAlignmentBytes):
(JSC::stackAlignmentRegisters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoJSC should know what the stack alignment conventions are
fpizlo@apple.com [Thu, 21 Nov 2013 21:07:59 +0000 (21:07 +0000)]
JSC should know what the stack alignment conventions are
https://bugs.webkit.org/show_bug.cgi?id=124736

Reviewed by Mark Lam.

* GNUmakefile.list.am:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/StackAlignment.h: Added.
(JSC::stackAlignmentBytes):
(JSC::stackAlignmentRegisters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFetch all page loading related URLs from the page load state
andersca@apple.com [Thu, 21 Nov 2013 20:30:35 +0000 (20:30 +0000)]
Fetch all page loading related URLs from the page load state
https://bugs.webkit.org/show_bug.cgi?id=124732

Reviewed by Dan Bernstein.

* UIProcess/API/C/WKPage.cpp:
(WKPageCopyActiveURL):
(WKPageCopyProvisionalURL):
(WKPageCopyCommittedURL):
* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController unreachableURL]):
* UIProcess/PageLoadState.h:
(WebKit::PageLoadState::provisionalURL):
(WebKit::PageLoadState::url):
(WebKit::PageLoadState::unreachableURL):
* UIProcess/WebPageProxy.cpp:
* UIProcess/WebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdded test for :hover and javascript events on the visual overflow of a region.
stavila@adobe.com [Thu, 21 Nov 2013 20:03:05 +0000 (20:03 +0000)]
Added test for :hover and javascript events on the visual overflow of a region.

[CSS Regions] Content in a region's visible overflow does not trigger :hover state, nor JavaScript events
https://bugs.webkit.org/show_bug.cgi?id=112010

Reviewed by Antti Koivisto.

* fast/regions/hover-and-js-in-visual-overflow-expected.html: Added.
* fast/regions/hover-and-js-in-visual-overflow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoHook up WebProcess-side of getOrEstablishIDBDatabaseMetadata
beidson@apple.com [Thu, 21 Nov 2013 20:00:13 +0000 (20:00 +0000)]
Hook up WebProcess-side of getOrEstablishIDBDatabaseMetadata
https://bugs.webkit.org/show_bug.cgi?id=124698

Reviewed by Anders Carlsson.

With this change the IDB API in WebKit2 using the DatabaseProcess finally does something observable:
window.indexedDB.open() sends an error to Javascript.

* DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:
(WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata): Continue calling back to the
  WebProcess with dummy data, but include the request ID for reference.
* DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
* DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:

Add a new class that wraps a completion callback function and gives it a unique integer identifier.
It also allows for wrapping an abort callback function (in case a connection is lost, for example).
It is templated to flexibly handle any callback function signature.
* Shared/AsyncRequest.cpp: Added.
(WebKit::generateRequestID):
(WebKit::AsyncRequest::AsyncRequest):
(WebKit::AsyncRequest::~AsyncRequest):
(WebKit::AsyncRequest::setAbortHandler):
(WebKit::AsyncRequest::requestAborted):
(WebKit::AsyncRequest::clearAbortHandler):
* Shared/AsyncRequest.h: Added.
(WebKit::AsyncRequest::requestID):
(WebKit::AsyncRequest::requestCompleted):

* WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::WebIDBServerConnection::getOrEstablishIDBDatabaseMetadata): Wrap the completion handler in an
  AsyncRequest and save off the request for later use.
(WebKit::WebIDBServerConnection::didGetOrEstablishIDBDatabaseMetadata): Send the results to the AsyncRequest.
* WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
* WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove activeURL getter to PageLoadState
andersca@apple.com [Thu, 21 Nov 2013 19:43:57 +0000 (19:43 +0000)]
Move activeURL getter to PageLoadState
https://bugs.webkit.org/show_bug.cgi?id=124690

Reviewed by Tim Horton.

* UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::activeURL):
* UIProcess/PageLoadState.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::activeURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImplement WebCrypto unwrapKey
ap@apple.com [Thu, 21 Nov 2013 19:05:43 +0000 (19:05 +0000)]
Implement WebCrypto unwrapKey
https://bugs.webkit.org/show_bug.cgi?id=124725

Reviewed by Anders Carlsson.

Source/WebCore:

Tests: crypto/subtle/aes-cbc-unwrap-failure.html
       crypto/subtle/aes-cbc-unwrap-rsa.html

* bindings/js/JSCryptoAlgorithmDictionary.cpp:
* bindings/js/JSCryptoAlgorithmDictionary.h:
Removed calls for wrap/unwrap parameter parsing, these are just the same as encrypt/decrypt.

* bindings/js/JSCryptoOperationData.cpp:
(WebCore::cryptoOperationDataFromJSValue):
* bindings/js/JSCryptoOperationData.h:
* crypto/CryptoKeySerialization.h:
More Vector<char> elimination.

* bindings/js/JSDOMPromise.cpp:
* bindings/js/JSDOMPromise.h:
Removed unneccessary copy constructor and assignment operator, they are no diffdrent
than compiler generated ones.

* bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::cryptoKeyUsagesFromJSValue): Minor style fixes.
(WebCore::JSSubtleCrypto::encrypt): Ditto.
(WebCore::JSSubtleCrypto::decrypt): Ditto.
(WebCore::JSSubtleCrypto::sign): Ditto.
(WebCore::JSSubtleCrypto::verify): Ditto.
(WebCore::JSSubtleCrypto::generateKey): Ditto.
(WebCore::importKey): Separated actual import operation and the parts that read
arguments from ExecState, and call the promise. Logically, this should be outside
of bindings code even, but JWK makes that quite challenging.
(WebCore::JSSubtleCrypto::importKey): This only does the more mundane arguments
and return parts now.
(WebCore::JSSubtleCrypto::exportKey): Minor style fixes.
(WebCore::JSSubtleCrypto::unwrapKey): Chain decrypt and import.

* crypto/CryptoAlgorithm.cpp:
(WebCore::CryptoAlgorithm::encryptForWrapKey):
(WebCore::CryptoAlgorithm::decryptForUnwrapKey):
* crypto/CryptoAlgorithm.h:
There are algorithms that expose wrap/unwrap, but not encrypt/decrypt. These will
override these new functions, and leave encrypt/decrypt to raise NOT_SUPPORTED_ERR.

* crypto/SubtleCrypto.idl: Added unwrapKey.

LayoutTests:

* crypto/subtle/aes-cbc-unwrap-failure-expected.txt: Added.
* crypto/subtle/aes-cbc-unwrap-failure.html: Added.
* crypto/subtle/aes-cbc-unwrap-rsa-expected.txt: Added.
* crypto/subtle/aes-cbc-unwrap-rsa.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r159633.
commit-queue@webkit.org [Thu, 21 Nov 2013 19:02:08 +0000 (19:02 +0000)]
Unreviewed, rolling out r159633.
http://trac.webkit.org/changeset/159633
https://bugs.webkit.org/show_bug.cgi?id=124726

it broke 10 webkitpy tests (Requested by dino_ on #webkit).

* Scripts/webkitpy/style/checker.py:
(check_webkit_style_configuration):
(CheckerDispatcher.dispatch):
(StyleProcessorConfiguration):
(StyleProcessorConfiguration.__init__):
(StyleProcessorConfiguration.write_style_error):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[MIPS] Build fails since r159545.
commit-queue@webkit.org [Thu, 21 Nov 2013 18:32:11 +0000 (18:32 +0000)]
[MIPS] Build fails since r159545.
https://bugs.webkit.org/show_bug.cgi?id=124716

Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-11-21
Reviewed by Michael Saboff.

Add missing implementations in MacroAssembler and LLInt for MIPS.

* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::sync):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::store8):
(JSC::MacroAssemblerMIPS::memoryFence):
* offlineasm/mips.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoClean up WebKit2 initialization
simon.fraser@apple.com [Thu, 21 Nov 2013 18:21:02 +0000 (18:21 +0000)]
Clean up WebKit2 initialization
https://bugs.webkit.org/show_bug.cgi?id=124696

Reviewed by Sam Weinig.

Call InitializeWebKit2() everywhere we need to do one-time
initialization in WebKit2, rather than having a hotch-potch
of init code.

* Shared/APIObject.cpp:
(API::Object::Object):
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
* UIProcess/Launcher/mac/ProcessLauncherMac.mm: Removed an unused #include.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove the stderr_write attribute from StyleProcessorConfiguration.
commit-queue@webkit.org [Thu, 21 Nov 2013 17:44:19 +0000 (17:44 +0000)]
Remove the stderr_write attribute from StyleProcessorConfiguration.
https://bugs.webkit.org/show_bug.cgi?id=124703

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-11-21
Reviewed by Brent Fulgham.

* Scripts/webkitpy/style/checker.py:
(check_webkit_style_configuration):
(CheckerDispatcher.dispatch):
(StyleProcessorConfiguration):
(StyleProcessorConfiguration.__init__):
(StyleProcessorConfiguration.write_style_error):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[curl]Improve ssl certificate storage and check
commit-queue@webkit.org [Thu, 21 Nov 2013 17:43:06 +0000 (17:43 +0000)]
[curl]Improve ssl certificate storage and check
https://bugs.webkit.org/show_bug.cgi?id=124569

Patch by Robert Sipka <sipka@inf.u-szeged.hu> on 2013-11-21
Reviewed by Brent Fulgham.

Storage and check the whole certificate chain, not just the root certificate.

* platform/network/curl/SSLHandle.cpp:
(WebCore::allowsAnyHTTPSCertificateHosts):
(WebCore::sslIgnoreHTTPSCertificate):
(WebCore::pemData):
(WebCore::certVerifyCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReverted r159603, as it appears to have caused Safari’s Web processes to crash on...
mitz@apple.com [Thu, 21 Nov 2013 17:41:39 +0000 (17:41 +0000)]
Reverted r159603, as it appears to have caused Safari’s Web processes to crash on launch.

Requested by Sam Weinig.

* Scripts/webkit2/messages.py:
(struct_or_class):
* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
* Shared/mac/ObjCObjectGraphCoders.h:
* Shared/mac/ObjCObjectGraphCoders.mm:
(WebKit::ObjCObjectGraphEncoder::baseEncode):
(WebKit::WebContextObjCObjectGraphEncoderImpl::WebContextObjCObjectGraphEncoderImpl):
(WebKit::WebContextObjCObjectGraphEncoderImpl::encode):
(WebKit::InjectedBundleObjCObjectGraphEncoderImpl::encode):
(WebKit::WebContextObjCObjectGraphEncoder::WebContextObjCObjectGraphEncoder):
(WebKit::WebContextObjCObjectGraphEncoder::encode):
* UIProcess/WebConnectionToWebProcess.cpp:
(WebKit::WebConnectionToWebProcess::encodeMessageBody):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::createWebPage):
(WebKit::WebContext::postMessageToInjectedBundle):
(WebKit::WebContext::didReceiveSyncMessage):
* UIProcess/WebContextUserMessageCoders.h:
(WebKit::WebContextUserMessageEncoder::WebContextUserMessageEncoder):
(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):
* UIProcess/WebPageGroup.cpp:
* UIProcess/WebPageGroup.h:
(WebKit::WebPageGroup::sendToAllProcessesInGroup):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
(WebKit::WebPageProxy::loadPlainTextString):
(WebKit::WebPageProxy::loadWebArchiveData):
(WebKit::WebPageProxy::postMessageToInjectedBundle):
(WebKit::WebPageProxy::initializeCreationParameters):
* UIProcess/WebPageProxy.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::disconnect):
(WebKit::WebProcessProxy::createWebPage):
* UIProcess/WebProcessProxy.h:
* WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::decode):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::webPageGroup):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WinCairo] Building ANGLE libraries fails.
commit-queue@webkit.org [Thu, 21 Nov 2013 17:36:32 +0000 (17:36 +0000)]
[WinCairo] Building ANGLE libraries fails.
https://bugs.webkit.org/show_bug.cgi?id=124679

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-21
Reviewed by Brent Fulgham.

Source/ThirdParty/ANGLE:

Added/removed files to/from project, and re-added constants.h file.

* ANGLE.vcxproj/libEGL.vcxproj:
* ANGLE.vcxproj/libEGL.vcxproj.filters:
* ANGLE.vcxproj/libGLESv2.vcxproj:
* ANGLE.vcxproj/libGLESv2.vcxproj.filters:
* ANGLE.vcxproj/libGLESv2Common.props:
* ANGLE.vcxproj/translator_common.vcxproj:
* ANGLE.vcxproj/translator_common.vcxproj.filters:
* ANGLE.vcxproj/translator_glsl.vcxproj:
* ANGLE.vcxproj/translator_glsl.vcxproj.filters:
* ANGLE.vcxproj/translator_hlsl.vcxproj:
* ANGLE.vcxproj/translator_hlsl.vcxproj.filters:
* src/libGLESv2/libGLESv2.def:

Source/WebKit:

* WebKit.vcxproj/WebKit/WebKitCFLite.props: Link with translator_hlsl.lib.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix sh4 build after r159545.
commit-queue@webkit.org [Thu, 21 Nov 2013 17:11:35 +0000 (17:11 +0000)]
Fix sh4 build after r159545.
https://bugs.webkit.org/show_bug.cgi?id=124713

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-21
Reviewed by Michael Saboff.

Add missing implementations in macro assembler and LLINT for sh4.

* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::load8):
(JSC::MacroAssemblerSH4::store8):
(JSC::MacroAssemblerSH4::memoryFence):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::synco):
* offlineasm/sh4.rb: Handle "memfence" opcode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdded test for the overflow of a region being painted across multiple tiles.
stavila@adobe.com [Thu, 21 Nov 2013 16:50:50 +0000 (16:50 +0000)]
Added test for the overflow of a region being painted across multiple tiles.
Added test for correct repainting of a region's overflow.

[CSS Regions] Overflow areas from regions do not redraw
https://bugs.webkit.org/show_bug.cgi?id=117329

Reviewed by Antti Koivisto.

* fast/regions/regions-overflow-tile-expected.html: Added.
* fast/regions/regions-overflow-tile.html: Added.
* fast/repaint/repaint-regions-overflow-expected.txt: Added.
* fast/repaint/repaint-regions-overflow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] Float get sliced if its container has forced break and is less tall...
stavila@adobe.com [Thu, 21 Nov 2013 15:43:37 +0000 (15:43 +0000)]
[CSS Regions] Float get sliced if its container has forced break and is less tall than float
https://bugs.webkit.org/show_bug.cgi?id=124205

Added test for the case when a float is overflowing a region due to a forced break.

Reviewed by Antti Koivisto.

* fast/regions/float-slicing-on-forced-break-expected.html: Added.
* fast/regions/float-slicing-on-forced-break.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix hover area for divs with css transforms
commit-queue@webkit.org [Thu, 21 Nov 2013 15:17:08 +0000 (15:17 +0000)]
Fix hover area for divs with css transforms
https://bugs.webkit.org/show_bug.cgi?id=124647

Patch by Mihai Maerean <mmaerean@adobe.com> on 2013-11-21
Reviewed by Allan Sandfeld Jensen.

Source/WebCore:

Non transformed layers are now being hit last, not through or in-between transformed layers.
The paint order says that the divs creating stacking contexts (including transforms) are painted after the
other siblings so they should be hit tested in the reverse order. Also, a rotated div in a non-rotated parent
should be hit in its entire area, not hit its parent's background, even if the z-coordinate is negative where
the mouse is located.

Test: transforms/3d/hit-testing/hover-rotated-negative-z.html

* rendering/RenderLayer.cpp:
(WebCore::computeZOffset):

LayoutTests:

* transforms/3d/hit-testing/hover-rotated-negative-z.html: Added.
* transforms/3d/hit-testing/hover-rotated-negative-z-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCreated test for positioned fragmented content which overflows the regions.
stavila@adobe.com [Thu, 21 Nov 2013 14:58:20 +0000 (14:58 +0000)]
Created test for positioned fragmented content which overflows the regions.

[CSS Regions] Fragmented content that is relatively positioned get sliced (and overflows in the next region)
https://bugs.webkit.org/show_bug.cgi?id=117122

Reviewed by Antti Koivisto.

* fast/regions/positioned-fragmented-content-expected.html: Added.
* fast/regions/positioned-fragmented-content.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdded test for visual overflow with transformed content in regions.
stavila@adobe.com [Thu, 21 Nov 2013 14:57:14 +0000 (14:57 +0000)]
Added test for visual overflow with transformed content in regions.

[CSS Regions] Transform applied to content node causes overflow to be hidden
https://bugs.webkit.org/show_bug.cgi?id=116242

Reviewed by Antti Koivisto.

* fast/regions/region-visual-overflow-transform-expected.html: Added.
* fast/regions/region-visual-overflow-transform.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159624 268f45cc-cd09-0410-ab3c-d52691b4dbfc