WebKit-https.git
8 years agoUnify SVG's animation and target tracking systems.
pdr@google.com [Fri, 7 Dec 2012 00:21:57 +0000 (00:21 +0000)]
Unify SVG's animation and target tracking systems.
https://bugs.webkit.org/show_bug.cgi?id=102655

Reviewed by Dirk Schulze.

Source/WebCore:

This patch unifies our animation target tracking system and regular target tracking system.
This simplifies the code, fixes a bug, and cleans up a historically security-sensitive area.

Background: When <use>, <mpath>, <animate>, etc. reference another element using
xlink:href="#id", we need to track when #id changes to #otherId, when #id is removed, etc.
This bookkeeping of element -> target is done in SVGDocumentExtensions. Additionally, when
a target changes that causes layout (e.g., rect.x is changed), all dependent elements with
renderers are notified (<animate> has no renderer and will not use this).

Previously, xlink:href changes were lazily resolved when targetElement() was called, target
changes were tracked using the animation tracking framework, and pending targets did not
work (e.g., <animate xlink:href="#p"><!--animate is now pending #p --><rect id="p"/>).

After this patch, we no longer lazily resolve targetElement() but instead change it when
our xlink:href attribute changes. Instead of using the animation tracking framework in
SVGDocumentExtensions, we now use the regular target tracking framework. Lastly, by using
the regular target tracking framework we are able to hook into the pending resource handling
which fixes a bug (see the test).

A test has been added to test that the order of animation elements does not matter. A second
test has been added to show we do not regress a pending-while-pending case.

Tests: svg/animations/svg-animation-order.html
       svg/custom/svg-pending-twice.html

* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::setTargetElement):

    setTargetElement and setAttributeName now work similarly. When the corresponding attribute
    changes, we update our internal state (target or attributeName) and save it instead of
    looking these values up on each iteration.

(WebCore::SVGAnimateElement::setAttributeName):
(WebCore):
(WebCore::SVGAnimateElement::resetAnimatedPropertyType):
* svg/SVGAnimateElement.h:
(SVGAnimateElement):
* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::setAttributeType):
(WebCore::SVGAnimationElement::setTargetElement):
(WebCore::SVGAnimationElement::setAttributeName):
* svg/SVGAnimationElement.h:
(SVGAnimationElement):
* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::~SVGDocumentExtensions):
(WebCore):
* svg/SVGDocumentExtensions.h:
(SVGDocumentExtensions):
* svg/SVGElement.cpp:
(WebCore::SVGElement::~SVGElement):
(WebCore::SVGElement::removedFrom):
(WebCore::SVGElement::attributeChanged):
* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::invalidateAllInstancesOfElement):

    This can be removed after r131631 landed.

* svg/SVGMPathElement.cpp:
(WebCore::SVGMPathElement::buildPendingResource):
* svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::buildPendingResource):

    A bug was discovered in review with our resource tracking in a pending-while-pending
    case. SVGMpathElement and SVGTextPathElement have been updated to fix this as well.

* svg/animation/SVGSMILElement.cpp:

    The changes in SVGSMILElement should look very similar to SVGFEImageElement,
    SVGMPathElement, etc. The idea is to build pending resources when added or
    removed from the document, or when the href attribute changes.

(WebCore::SVGSMILElement::~SVGSMILElement):
(WebCore):
(WebCore::SVGSMILElement::clearResourceReferences):
(WebCore::SVGSMILElement::buildPendingResource):
(WebCore::SVGSMILElement::insertedInto):
(WebCore::SVGSMILElement::removedFrom):
(WebCore::SVGSMILElement::svgAttributeChanged):
(WebCore::SVGSMILElement::setAttributeName):
(WebCore::SVGSMILElement::setTargetElement):
* svg/animation/SVGSMILElement.h:
(WebCore):
(WebCore::SVGSMILElement::targetElement):
(SVGSMILElement):

LayoutTests:

* svg/animations/svg-animation-order-expected.html: Added.
* svg/animations/svg-animation-order.html: Added.
* svg/custom/svg-pending-twice-expected.html: Added.
* svg/custom/svg-pending-twice.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRetry snapshots if they are too empty
jonlee@apple.com [Fri, 7 Dec 2012 00:10:23 +0000 (00:10 +0000)]
Retry snapshots if they are too empty
https://bugs.webkit.org/show_bug.cgi?id=104174
<rdar://problem/12820146>

Reviewed by Simon Fraser.

Source/WebCore:

* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::updateSnapshot): Change the state machine check so that even
when the plug-in is displaying a snapshot, the snapshot can still be updated. This allows for the
retries to be drawn.

Source/WebKit2:

* WebProcess/Plugins/PluginView.h: Add a new variable that keeps track of the number of times we've
retried to come up with a snapshot.
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::PluginView): Initialize the count to 0.
(WebKit::isAlmostSolidColor): Figure out if the image is almost a solid color by overlaying
a grid of dots, and calculate the differences among them. If the average color difference is greater than
a threshold, we consider it to have meaningful content. For now we expect a minimum size and a specific
bitmap image format, otherwise we return early.
(WebKit::PluginView::pluginSnapshotTimerFired): If we have a snapshot image to look at, and if it is
evaluated to be too empty, then try again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Enable Resource Timing and User Timing
simonjam@chromium.org [Thu, 6 Dec 2012 23:50:44 +0000 (23:50 +0000)]
[Chromium] Enable Resource Timing and User Timing
https://bugs.webkit.org/show_bug.cgi?id=103788

Reviewed by Tony Gentilcore.

Source/WebKit/chromium:

* features.gypi:

LayoutTests:

* http/tests/w3c/webperf/submission/resource-timing/html/test_resource_iframe_navigation.html: Removed. Incomplete, shouldn't have been submitted.
* platform/chromium/TestExpectations: Remove 'Skip' expectations and add expected failures for iframes.
* platform/chromium/fast/dom/Window/window-properties-performance-expected.txt: Added. Now includes User Timing and Resource Timing properties.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[HTMLTemplateElement] make content readonly and cloneNode(deep) clone content
adamk@chromium.org [Thu, 6 Dec 2012 23:47:58 +0000 (23:47 +0000)]
[HTMLTemplateElement] make content readonly and cloneNode(deep) clone content
https://bugs.webkit.org/show_bug.cgi?id=104181

Reviewed by Adam Barth.

Source/WebCore:

Note that this patch also adds IDL attributes/custom code to tie the lifetime
of the content DocumentFragment wrapper to the lifetime of the template element wrapper
via a hidden JS property.

Based on a patch by Rafael Weinstein.

Test: fast/dom/HTMLTemplateElement/contentWrappers.html

* DerivedSources.cpp:
* Target.pri:
* UseJSC.cmake:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSHTMLTemplateElementCustom.cpp: Copied from Source/WebCore/html/HTMLTemplateElement.idl.
(WebCore):
(WebCore::JSHTMLTemplateElement::content):
* bindings/scripts/CodeGeneratorV8.pm: Add support for new V8CacheAttributeForGC attribute.
* dom/Element.h:
(Element): Annotate cloneNode() with OVERRIDE
* html/HTMLTemplateElement.cpp:
(WebCore::HTMLTemplateElement::cloneNode):
* html/HTMLTemplateElement.h:
(HTMLTemplateElement): override cloneNode
* html/HTMLTemplateElement.idl: Make content readonly and add custom attributes.

LayoutTests:

* fast/dom/HTMLTemplateElement/cloneNode-expected.txt:
* fast/dom/HTMLTemplateElement/cloneNode.html:
* fast/dom/HTMLTemplateElement/contentWrappers-expected.txt: Added.
* fast/dom/HTMLTemplateElement/contentWrappers.html: Added.
* fast/dom/HTMLTemplateElement/ownerDocument-expected.txt:
* fast/dom/HTMLTemplateElement/ownerDocument.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium rebaseline for r136885.
eae@chromium.org [Thu, 6 Dec 2012 23:31:39 +0000 (23:31 +0000)]
Unreviewed chromium rebaseline for r136885.

* platform/chromium-mac-lion/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
* platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
* platform/efl-wk1/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
* platform/efl/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fixing the email order to work correctly with bugzilla.
vivek.vg@samsung.com [Thu, 6 Dec 2012 23:30:37 +0000 (23:30 +0000)]
Unreviewed. Fixing the email order to work correctly with bugzilla.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, Apple Win Debug build fix.
tony@chromium.org [Thu, 6 Dec 2012 23:28:45 +0000 (23:28 +0000)]
Unreviewed, Apple Win Debug build fix.

* win/WebKit2.def.in: Add 2 symbols that are needed by the debug build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] when forwarding events through the WebPluginContainer, create a UserGestur...
jochen@chromium.org [Thu, 6 Dec 2012 23:20:12 +0000 (23:20 +0000)]
[chromium] when forwarding events through the WebPluginContainer, create a UserGestureIndicator if processing a user gesture
https://bugs.webkit.org/show_bug.cgi?id=104306

Reviewed by Dimitri Glazkov.

Source/WebKit/chromium:

In http://trac.webkit.org/changeset/65964 a UserGestureIndicator was
introduced in chromium's WebKit layer intended to fix a problem with
plugins, however, it also affected regular event handling, so I removed
it in http://trac.webkit.org/changeset/128273. Turns out it still is a
problem for plugins. This change adds the UserGestureIndicator back,
however, only for the WebPluginContainer.

* public/WebInputEvent.h:
(WebInputEvent):
(WebKit::WebInputEvent::isUserGestureEventType):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::handleEvent):

Tools:

* DumpRenderTree/chromium/TestWebPlugin.cpp:
(TestWebPlugin::TestWebPlugin):
(TestWebPlugin::handleInputEvent): add support for printing the user gesture status
* DumpRenderTree/chromium/TestWebPlugin.h:
(TestWebPlugin):

LayoutTests:

* platform/chromium/plugins/user-gesture-expected.txt: Added.
* platform/chromium/plugins/user-gesture.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Windows, WinCairo] Unreviewed build correction.
bfulgham@webkit.org [Thu, 6 Dec 2012 23:02:11 +0000 (23:02 +0000)]
[Windows, WinCairo] Unreviewed build correction.

Exclude 'DocumentSharedObjectPool.cpp' from build, since it is
built as part of DOMAllInOne.cpp.  The build (besides wasting
time) generates a bunch of build warnings for duplicate symbols.

* WebCore.vcproj/WebCore.vcproj: Mark DocumentSharedObjectPool.cpp
to not build independently of DOMAllInOne.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Abort transactions because of leveldb errors part 4
dgrogan@chromium.org [Thu, 6 Dec 2012 22:56:26 +0000 (22:56 +0000)]
IndexedDB: Abort transactions because of leveldb errors part 4
https://bugs.webkit.org/show_bug.cgi?id=103964

Reviewed by Tony Chang.

Source/WebCore:

deleteDatabase, open, and deleteObjectStore will now fire more aborts
and errors in case of leveldb problems

* Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::getVarInt): Make return value indicate leveldb error.
(WebCore::getString): ditto.
(WebCore::IDBBackingStore::getIDBDatabaseMetaData):
Change return value to indicate leveldb error.

(WebCore::IDBBackingStore::deleteDatabase):
Already had the desired return value semantics. As a consumer of
getIDBDatabaseMetadata, will return an error (causing an abort) more
often.

(WebCore::IDBBackingStore::deleteObjectStore):
Needed return value change. Will return error to DatabaseBackend to
indicate leveldb problems.

* Modules/indexeddb/IDBBackingStore.h:
(IDBBackingStore):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::openInternal):
Pass leveldb errors up to callers, who already handle internal errors.

(WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreOperation::perform):
Abort transaction if there were leveldb problems deleting an object
store.

Source/WebKit/chromium:

* tests/IDBFakeBackingStore.h:
  Update one overridden method signature, delete another.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonew-run-webkit-tests --lint-test-files seems to be broken
dpranke@chromium.org [Thu, 6 Dec 2012 22:45:34 +0000 (22:45 +0000)]
new-run-webkit-tests --lint-test-files seems to be broken
https://bugs.webkit.org/show_bug.cgi?id=104296

Unreviewed, build fix.

My recent refactoring caused me to not initialize the printer
before calling lint(); this patch restructures the code to make
the lint routine self-contained and do all the work necessary.
This will also make it easier to move this code out into a standalone
file.

* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(lint):
(main):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(LintTest.test_all_configurations):
(LintTest.test_lint_test_files):
(LintTest.test_lint_test_files__errors):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTell heap that we've released all the compiled code.
oliver@apple.com [Thu, 6 Dec 2012 22:36:12 +0000 (22:36 +0000)]
Tell heap that we've released all the compiled code.

Reviewed by Geoff Garen.

When we discard compiled code, inform the heap that we've
released an entire object graph.  This informs the heap that
it might want to perform a GC soon.

* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::discardAllCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Add webkitErrorMessage to IDBTransaction
dgrogan@chromium.org [Thu, 6 Dec 2012 22:33:57 +0000 (22:33 +0000)]
IndexedDB: Add webkitErrorMessage to IDBTransaction
https://bugs.webkit.org/show_bug.cgi?id=104199

Reviewed by Tony Chang.

Source/WebCore:

Don't drop error messages on the floor.

Expose an error message on IDBTransaction to give developers more
information than the opaque error code currently available. This is
exactly what is done in IDBRequest.

Tests - transaction-error.html

* Modules/indexeddb/IDBDatabaseError.h:
(WebCore::IDBDatabaseError::create):
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::uncaughtExceptionInEventHandler):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::setError):
(WebCore):
(WebCore::IDBTransaction::webkitErrorMessage):
(WebCore::IDBTransaction::onAbort):
* Modules/indexeddb/IDBTransaction.h:
(IDBTransaction):
* Modules/indexeddb/IDBTransaction.idl:

LayoutTests:

Test for webkitErrorMessage in the three circumstances that can
generate one:
1) Bubble from operation error
2) Uncaught exception in operation event handler
3) Asynchronous abort from the backend

And fix a FIXME in the test.

* storage/indexeddb/resources/transaction-error.js:
(testErrorFromRequest.trans.onabort):
(testErrorFromRequest):
(testErrorFromException.trans.onabort):
(testErrorFromException):
(testErrorFromCommit.trans.oncomplete.request.onupgradeneeded.trans.onabort):
(testErrorFromCommit.trans.oncomplete.request.onupgradeneeded):
(testErrorFromCommit.trans.oncomplete):
(testErrorFromCommit):
* storage/indexeddb/transaction-error-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoXMLHttpRequest Content-Type should be taken from Blob type
commit-queue@webkit.org [Thu, 6 Dec 2012 22:32:46 +0000 (22:32 +0000)]
XMLHttpRequest Content-Type should be taken from Blob type
https://bugs.webkit.org/show_bug.cgi?id=99983

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-12-06
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Fix XMLHttpRequest::send(Blob*) method, so that the Content-Type is set according to W3C specification.
http://www.w3.org/TR/XMLHttpRequest/#the-send-method

Added test that check if content type is set correctly when blob object is sent.

Test: http/tests/xmlhttprequest/post-blob-content-type.html

* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):
    Set correct MIME type for Blob objects.
* WebCore.vcproj/WebCore.vcproj:
    Added ParsedContentType to project file.

LayoutTests:

Added tests that check if content type is set correctly when blob object is sent.

* http/tests/xmlhttprequest/post-blob-content-type-expected.txt: Added.
* http/tests/xmlhttprequest/post-blob-content-type.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] IndexedDB: storage/indexeddb/resources/cursor-advance.html flaky in conten...
jsbell@chromium.org [Thu, 6 Dec 2012 22:30:06 +0000 (22:30 +0000)]
[Chromium] IndexedDB: storage/indexeddb/resources/cursor-advance.html flaky in content_shell after WK136782
https://bugs.webkit.org/show_bug.cgi?id=104292

Reviewed by Tony Chang.

Test had a read-only transaction depending on the completion of a prior read-write transaction,
which is not guaranteed by the spec. Switch from triggering the second transaction into the
oncomplete of the first.

* storage/indexeddb/resources/cursor-advance.js:
(populateObjectStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake LazyDecodingPixelRef inherit from skia::LazyPixelRef so that cc thread can access it
commit-queue@webkit.org [Thu, 6 Dec 2012 22:21:27 +0000 (22:21 +0000)]
Make LazyDecodingPixelRef inherit from skia::LazyPixelRef so that cc thread can access it
https://bugs.webkit.org/show_bug.cgi?id=103555

Patch by Min Qin <qinmin@chromium.org> on 2012-12-06
Reviewed by Stephen White.

Expose LazyDecodingPixelRef to the cc thread by inheriting from skia::LazyPixelRef.
No test added for now as impl side paiting is still WIP.

* platform/graphics/chromium/LazyDecodingPixelRef.cpp:
(WebCore::LazyDecodingPixelRef::LazyDecodingPixelRef):
(WebCore::LazyDecodingPixelRef::PrepareToDecode):
(WebCore):
(WebCore::LazyDecodingPixelRef::Decode):
* platform/graphics/chromium/LazyDecodingPixelRef.h:
(LazyDecodingPixelRef):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, rebaselining http/tests/media/video-buffered-range-contains...
scherkus@chromium.org [Thu, 6 Dec 2012 22:21:13 +0000 (22:21 +0000)]
[Chromium] Unreviewed, rebaselining http/tests/media/video-buffered-range-contains-currentTime.html
https://bugs.webkit.org/show_bug.cgi?id=104300

* platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
* platform/chromium-mac-lion/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
* platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
* platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
* platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Track private browsing session in network process
ap@apple.com [Thu, 6 Dec 2012 22:14:38 +0000 (22:14 +0000)]
    Track private browsing session in network process
        https://bugs.webkit.org/show_bug.cgi?id=104281

        Reviewed by Jessie Berlin.

        Added ensure/destroy messages that match what's done in WebProcess. Also similarly,
        ensuring a private session may happen on demand if network process has been restarted
        after a crash, or if private browsing is enabled via a persistent preference.

        Eventually, we should find a way to share code between WebFrameNetworkingContext
        and RemoteNetworkingContext.

        * NetworkProcess/NetworkProcess.cpp:
        (WebKit::NetworkProcess::initializeNetworkProcess):
        (WebKit::NetworkProcess::ensurePrivateBrowsingSession):
        (WebKit::NetworkProcess::destroyPrivateBrowsingSession):
        * NetworkProcess/NetworkProcess.h:
        * NetworkProcess/NetworkProcess.messages.in:
        * NetworkProcess/mac/RemoteNetworkingContext.h:
        (RemoteNetworkingContext):
        * NetworkProcess/mac/RemoteNetworkingContext.mm:
        (WebKit::privateBrowsingStorageSessionIdentifierBase):
        (WebKit::RemoteNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
        (WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
        (WebKit::RemoteNetworkingContext::destroyPrivateBrowsingSession):
        * Shared/Network/NetworkProcessCreationParameters.cpp:
        (WebKit::NetworkProcessCreationParameters::encode):
        (WebKit::NetworkProcessCreationParameters::decode):
        * Shared/Network/NetworkProcessCreationParameters.h:
        (NetworkProcessCreationParameters):
        * UIProcess/Network/mac/NetworkProcessProxyMac.mm:
        (WebKit::NetworkProcessProxy::platformInitializeNetworkProcess):
        * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
        (WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::initializeWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Make an Isolate mandatory in v8UnsignedInteger()
haraken@chromium.org [Thu, 6 Dec 2012 22:10:11 +0000 (22:10 +0000)]
[V8] Make an Isolate mandatory in v8UnsignedInteger()
https://bugs.webkit.org/show_bug.cgi?id=104235

Reviewed by Adam Barth.

No tests. No change in behavior.

* bindings/v8/ArrayValue.cpp:
(WebCore::ArrayValue::get):
* bindings/v8/V8Binding.h:
(WebCore::v8UnsignedInteger):
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[New Multicolumn] Add requiresBalancing booleans to track which column sets need...
hyatt@apple.com [Thu, 6 Dec 2012 22:08:33 +0000 (22:08 +0000)]
[New Multicolumn] Add requiresBalancing booleans to track which column sets need to rebalance.
https://bugs.webkit.org/show_bug.cgi?id=104297

Reviewed by Simon Fraser.

Add requiresBalancing booleans to RenderMultiColumnBlock and RenderMultiColumnSet. For now the former is just propagated
to the latter, but eventually RenderMultiColumnSets will have a notion of balancing that has to be independent of the
owning block (e.g., maybe only the last set rebalances, or maybe only a set that contains the content between two forced
breaks wants to rebalance, etc.).

* rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
(WebCore::RenderMultiColumnBlock::checkForPaginationLogicalHeightChange):
(WebCore::RenderMultiColumnBlock::ensureColumnSets):
* rendering/RenderMultiColumnBlock.h:
(WebCore::RenderMultiColumnBlock::requiresBalancing):
(RenderMultiColumnBlock):
* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
* rendering/RenderMultiColumnSet.h:
(WebCore::RenderMultiColumnSet::requiresBalancing):
(WebCore::RenderMultiColumnSet::setRequiresBalancing):
(RenderMultiColumnSet):
(WebCore::toRenderMultiColumnSet):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agointernals.settings.setEnableCompositingForFixedPosition() should be called before...
wangxianzhu@chromium.org [Thu, 6 Dec 2012 22:00:46 +0000 (22:00 +0000)]
internals.settings.setEnableCompositingForFixedPosition() should be called before onload
https://bugs.webkit.org/show_bug.cgi?id=104277

Fixed some tests that set enableCompositingForFixedPosition in onload handler which may not take effect because it is too late.
Leave the image mismatches to bug 96839.

Reviewed by Simon Fraser.

* compositing/geometry/fixed-position-composited-page-scale-down.html:
* compositing/geometry/fixed-position-composited-page-scale-scroll.html:
* compositing/geometry/fixed-position-composited-page-scale.html:
* compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
* compositing/geometry/fixed-position-iframe-composited-page-scale.html:
* compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
* compositing/geometry/fixed-position-transform-composited-page-scale.html:
* compositing/layer-creation/fixed-position-out-of-view.html:
* platform/chromium/TestExpectations: Mark the original flaky image mismatch as constantly failure. Add one image mismatch caused by this change but because of incorrect baseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Remove ENABLE_GLIB_SUPPORT CMake variable
commit-queue@webkit.org [Thu, 6 Dec 2012 21:58:01 +0000 (21:58 +0000)]
[EFL] Remove ENABLE_GLIB_SUPPORT CMake variable
https://bugs.webkit.org/show_bug.cgi?id=104278

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-12-06
Reviewed by Brent Fulgham.

.:

The variable is unnecessary as glib is a required dependency
for the EFL port and glib is not used by other ports building
with CMake.

* Source/cmake/OptionsEfl.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

The conditional is not required as it is always set for EFL.

* PlatformEfl.cmake:

Source/WebKit2:

The guards are not required as it is always set for EFL.

* PlatformEfl.cmake:
* UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::scanPlugin):
* WebProcess/efl/WebProcessMainEfl.cpp:
(WebKit::WebProcessMainEfl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r136871.
eae@chromium.org [Thu, 6 Dec 2012 21:41:27 +0000 (21:41 +0000)]
Unreviewed, rolling out r136871.
http://trac.webkit.org/changeset/136871
https://bugs.webkit.org/show_bug.cgi?id=104293

crashes on bots and memory leaks (Requested by esprehn on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06

* dom/Document.h:
(WebCore::Node::treeScope):
* dom/Element.cpp:
(WebCore::Element::createRareData):
* dom/ElementRareData.h:
(ElementRareData):
(WebCore::ElementRareData::ElementRareData):
* dom/Node.cpp:
(WebCore::Node::setTreeScope):
(WebCore::Node::ensureRareData):
(WebCore::Node::createRareData):
(WebCore::Node::clearRareData):
* dom/Node.h:
(WebCore::NodeRareDataBase::~NodeRareDataBase):
(WebCore::NodeRareDataBase::NodeRareDataBase):
(NodeRareDataBase):
(WebCore::Node::renderer):
(WebCore::Node::setRenderer):
(Node):
(WebCore::Node::hasRareData):
* dom/NodeRareData.h:
(WebCore::NodeRareData::NodeRareData):
(NodeRareData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove non-v8 binding files from WebCore.gypi
adamk@chromium.org [Thu, 6 Dec 2012 21:26:27 +0000 (21:26 +0000)]
Remove non-v8 binding files from WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=104288

Reviewed by Adam Barth.

Since the gyp build is only used by the Chromium project,
there's no need for cpp, gobject, objc, or jsc bindings
in these build files.

* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG profiler should be helpful about gem installation
fpizlo@apple.com [Thu, 6 Dec 2012 21:22:03 +0000 (21:22 +0000)]
DFG profiler should be helpful about gem installation
https://bugs.webkit.org/show_bug.cgi?id=104217

Reviewed by Oliver Hunt.

'json' and 'highline' are not installed by default on the ruby distributions with
which I am familiar, and the default error messages don't make me happy. This makes
display-profiler-output print a helpful message if those gems are not found.

* Scripts/display-profiler-output:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed gardening.
senorblanco@chromium.org [Thu, 6 Dec 2012 21:21:27 +0000 (21:21 +0000)]
[Chromium] Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoProfiler should print a helpful message if you pass the wrong arguments
fpizlo@apple.com [Thu, 6 Dec 2012 21:20:30 +0000 (21:20 +0000)]
Profiler should print a helpful message if you pass the wrong arguments
https://bugs.webkit.org/show_bug.cgi?id=104222

Reviewed by Oliver Hunt.

* Scripts/display-profiler-output:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r135082): Restore the ability to insert author level style sheets from...
tony@chromium.org [Thu, 6 Dec 2012 21:19:12 +0000 (21:19 +0000)]
REGRESSION(r135082): Restore the ability to insert author level style sheets from script
https://bugs.webkit.org/show_bug.cgi?id=104042

Reviewed by Antti Koivisto.

.:

Update exports for Internals.cpp.

* Source/autotools/symbols.filter:

Source/WebCore:

Add DocumentStyleSheetCollection::addAuthorSheet so embedders can allow scripts
to insert author level styles. Expose the method to window.interals for testing.

Test: userscripts/insert-stylesheets.html

* WebCore.exp.in: Update exports for Internals.cpp.
* WebCore.order: Update exports for Internals.cpp.
* dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::addAuthorSheet): Add the stylesheet and force a style recalc.
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets): Include author level styles.
(WebCore::DocumentStyleSheetCollection::reportMemoryUsage): Include author styles.
* dom/DocumentStyleSheetCollection.h:
(WebCore::DocumentStyleSheetCollection::documentAuthorStyleSheets): Accessor.
(DocumentStyleSheetCollection): Keep track of author styles added by script.
* testing/Internals.cpp:
(WebCore::Internals::insertAuthorCSS): Testing addAuthorSheet.
(WebCore::Internals::insertUserCSS): Testing addUserSheet.
* testing/Internals.h:
* testing/Internals.idl: Add addAuthorSheet and addUserSheet.

Source/WebKit/chromium:

* src/WebDocument.cpp:
(WebKit::WebDocument::insertUserStyleSheet): Use addAuthorSheet if an author level script is requested.

Source/WebKit2:

Update exports for Internals.cpp.

* win/WebKit2.def.in:

LayoutTests:

Add a test that makes sure that an author level style is set.

* userscripts/insert-stylesheets-expected.txt: Added.
* userscripts/insert-stylesheets.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed gardening.
senorblanco@chromium.org [Thu, 6 Dec 2012 21:15:45 +0000 (21:15 +0000)]
[Chromium] Unreviewed gardening.

effect-reference-hw.html is failing (lighting has a Y-flip), but people
seem tempted to rebaseline it.  Put the software result in its place
for now, and mark it failing, so people aren't tempted to rebaseline it.

* platform/chromium-linux/css3/filters/effect-reference-hw-expected.png: Removed.
* platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
* platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add some null-checks for the touch-lists in TouchEvent
commit-queue@webkit.org [Thu, 6 Dec 2012 21:13:24 +0000 (21:13 +0000)]
[chromium] Add some null-checks for the touch-lists in TouchEvent
https://bugs.webkit.org/show_bug.cgi?id=104098

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-12-06
Reviewed by Adam Barth.

It is possible for the touch-lists to be NULL in a TouchEvent. V8TouchEvent checks for NULL
touches(), targetTouches() and changedTouches(). So do the same for WebMouseEventBuilder.

* src/WebInputEventConversion.cpp:
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
* tests/WebInputEventConversionTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAllow for CCing a secondary email address from watchlists
ojan@chromium.org [Thu, 6 Dec 2012 21:09:58 +0000 (21:09 +0000)]
Allow for CCing a secondary email address from watchlists
https://bugs.webkit.org/show_bug.cgi?id=104286

Reviewed by Dirk Pranke.

Change my watchlist CC address so I can filter these separately from
when people explicitly CC me and update the watchlist parser to allow that.

* Scripts/webkitpy/common/config/committers.py:
* Scripts/webkitpy/common/config/watchlist:
* Scripts/webkitpy/common/watchlist/watchlistparser.py:
(WatchListParser._validate):
* Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
(WatchListParserTest.test_cc_rule_with_invalid_email):
(WatchListParserTest.test_cc_rule_with_secondary_email):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, skip a new test because of missing test font.
ossy@webkit.org [Thu, 6 Dec 2012 20:40:24 +0000 (20:40 +0000)]
[Qt] Unreviewed gardening, skip a new test because of missing test font.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed gardening.
senorblanco@chromium.org [Thu, 6 Dec 2012 20:31:07 +0000 (20:31 +0000)]
[Chromium] Unreviewed gardening.

* platform/chromium-linux/fast/borders/border-radius-constraints-expected.png:
* platform/chromium-linux/fast/borders/mixed-border-styles-radius-expected.png:
* platform/chromium-linux/fast/css/background-clip-radius-values-expected.png:
* platform/chromium-mac-lion/fast/borders/border-radius-constraints-expected.png:
* platform/chromium-mac-lion/fast/css/background-clip-radius-values-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/borders/border-radius-constraints-expected.png:
* platform/chromium-mac/fast/borders/border-radius-constraints-expected.png:
* platform/chromium-mac/fast/borders/mixed-border-styles-radius-expected.png:
* platform/chromium-mac/fast/css/background-clip-radius-values-expected.png:
* platform/chromium-win/fast/borders/border-radius-constraints-expected.png:
* platform/chromium-win/fast/borders/mixed-border-styles-radius-expected.png:
* platform/chromium-win/fast/css/background-clip-radius-values-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCreate only NodeRareDataBase when setting TreeScope
commit-queue@webkit.org [Thu, 6 Dec 2012 20:16:22 +0000 (20:16 +0000)]
Create only NodeRareDataBase when setting TreeScope
https://bugs.webkit.org/show_bug.cgi?id=104202

Patch by Elliott Sprehn <esprehn@gmail.com> on 2012-12-06
Reviewed by Dimitri Glazkov.

Move many fields from NodeRareData into NodeRareDataBase and rename it
UncommonNodeData and add a flag to determine if a UncommonNodeData is
actually a full NodeRareData instance. By moving fields up from NodeRareData
we ensure that this new flag in the base class doesn't make NodeRareData
grow in size.

We then make setting the tree scope only allocate the UncommonNodeData
instead of creating the full NodeRareData or ElementRareData. This is
important because when putting nodes into ShadowRoot or any descendant
we must associate the node with a tree scope which adds rare data to the
node making NodeRareData and ElementRareData not very rare.

On 64bit, this reduces the overhead per element from 136 bytes to
32 bytes for a 76% savings, and on other nodes from 64 bytes to 32 bytes
for a 50% savings.

No new tests, no change in behavior.

* dom/Document.h:
(WebCore::Node::treeScope):
* dom/Element.cpp:
(WebCore::Element::createRareData):
* dom/ElementRareData.h:
(ElementRareData):
(WebCore::ElementRareData::ElementRareData):
* dom/Node.cpp:
(WebCore::Node::setTreeScope):
(WebCore::Node::ensureRareData):
(WebCore::Node::createRareData):
(WebCore::Node::clearRareData):
* dom/Node.h:
(WebCore::UncommonNodeData::create):
(UncommonNodeData):
(WebCore::UncommonNodeData::~UncommonNodeData):
(WebCore::UncommonNodeData::isNodeRareData):
(WebCore::UncommonNodeData::UncommonNodeData):
(WebCore::Node::renderer):
(WebCore::Node::setRenderer):
(Node):
(WebCore::Node::hasRareData):
(WebCore::Node::hasUncommonNodeData):
* dom/NodeRareData.h:
(WebCore::NodeRareData::NodeRareData):
(NodeRareData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed gardening.
senorblanco@chromium.org [Thu, 6 Dec 2012 20:13:09 +0000 (20:13 +0000)]
[Chromium] Unreviewed gardening.

Add some bug IDs to failing tests, and restore some old expectations.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Remove IDBDatabaseException.idl
jsbell@chromium.org [Thu, 6 Dec 2012 20:11:42 +0000 (20:11 +0000)]
IndexedDB: Remove IDBDatabaseException.idl
https://bugs.webkit.org/show_bug.cgi?id=102961

Reviewed by Adam Barth.

Delete the IDL and references to it. No longer needed as a enum member
in the autogenerated ExceptionCodeDescription.h so removed from the ".in"
file; only direct references are retained in the autogenerated cpp file.

Ideally the code generator would handle these new-style DOMExceptions,
but we don't have any other examples yet to know what pattern to follow.

No new tests - just removing dead code.

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Modules/indexeddb/IDBDatabaseException.idl: Removed.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMExceptions.in:
* dom/make_dom_exceptions.pl:
(generateImplementation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium rebaselines.
eae@chromium.org [Thu, 6 Dec 2012 20:02:19 +0000 (20:02 +0000)]
Unreviewed chromium rebaselines.

* platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Removed.
* platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/masks: Removed.
* platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png: Removed.
* platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/shadows: Removed.
* platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png: Removed.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/iframes: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/iframes/composited-iframe-alignment-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNew pixel baselines for fast/backgrounds/gradient-background-leakage.html
junov@google.com [Thu, 6 Dec 2012 19:54:39 +0000 (19:54 +0000)]
New pixel baselines for fast/backgrounds/gradient-background-leakage.html
https://bugs.webkit.org/show_bug.cgi?id=103896

Unreviewed

* platform/chromium-linux/fast/backgrounds/gradient-background-leakage-expected.png:
* platform/chromium-mac/fast/backgrounds/gradient-background-leakage-expected.png:
* platform/chromium/TestExpectations:
* platform/efl-wk1/fast/backgrounds: Added.
* platform/efl-wk1/fast/backgrounds/gradient-background-leakage-expected.png: Added.
* platform/efl/fast/backgrounds/gradient-background-leakage-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] Drain the CSSValuePool on memory pressure.
akling@apple.com [Thu, 6 Dec 2012 19:48:25 +0000 (19:48 +0000)]
[Mac] Drain the CSSValuePool on memory pressure.
<http://webkit.org/b/104274>

Reviewed by Antti Koivisto.

Add a drain() mechanism to CSSValuePool and call it when we're under memory pressure.

* WebCore.xcodeproj/project.pbxproj:
* css/CSSValuePool.cpp:
(WebCore::CSSValuePool::drain):
* css/CSSValuePool.h:
* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::releaseMemory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening.
yael@webkit.org [Thu, 6 Dec 2012 19:47:37 +0000 (19:47 +0000)]
Unreviewed gardening.

Add expected results for transforms/3d tests that are producing correct resulta.

* platform/efl/TestExpectations:
* platform/efl/transforms/3d: Added.
* platform/efl/transforms/3d/general: Added.
* platform/efl/transforms/3d/general/perspective-non-layer-expected.png: Added.
* platform/efl/transforms/3d/general/perspective-non-layer-expected.txt: Added.
* platform/efl/transforms/3d/general/perspective-units-expected.png: Added.
* platform/efl/transforms/3d/general/perspective-units-expected.txt: Added.
* platform/efl/transforms/3d/hit-testing: Added.
* platform/efl/transforms/3d/hit-testing/backface-hit-test-expected.png: Added.
* platform/efl/transforms/3d/hit-testing/backface-hit-test-expected.txt: Added.
* platform/efl/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.png: Added.
* platform/efl/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.txt: Added.
* platform/efl/transforms/3d/point-mapping: Added.
* platform/efl/transforms/3d/point-mapping/3d-point-mapping-2-expected.png: Added.
* platform/efl/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt: Added.
* platform/efl/transforms/3d/point-mapping/3d-point-mapping-3-expected.png: Added.
* platform/efl/transforms/3d/point-mapping/3d-point-mapping-3-expected.txt: Added.
* platform/efl/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
* platform/efl/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
* platform/efl/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt: Added.
* platform/efl/transforms/3d/point-mapping/3d-point-mapping-expected.png: Added.
* platform/efl/transforms/3d/point-mapping/3d-point-mapping-expected.txt: Added.
* platform/efl/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png: Added.
* platform/efl/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt: Added.
* platform/efl/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
* platform/efl/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix a bad rebaseline
schenney@chromium.org [Thu, 6 Dec 2012 19:35:01 +0000 (19:35 +0000)]
Fix a bad rebaseline

Unreviewed expectations fix.

This test is apparently flaky and I put in the wrong flake.

* platform/chromium-mac-lion/svg/custom/mask-invalidation-expected.png: Removed.
* platform/chromium-win/svg/custom/mask-invalidation-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix, last patch rolled out logic that is now needed on ToT.
oliver@apple.com [Thu, 6 Dec 2012 19:34:27 +0000 (19:34 +0000)]
Build fix, last patch rolled out logic that is now needed on ToT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove gyp config for incomplete and unused Apple Mac gyp build
adamk@chromium.org [Thu, 6 Dec 2012 19:33:33 +0000 (19:33 +0000)]
Remove gyp config for incomplete and unused Apple Mac gyp build
https://bugs.webkit.org/show_bug.cgi?id=104068

Reviewed by Adam Barth.

As part of the removal, move some files to the proper sections
of the gypi file.

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Expose acceleratedCompositingForScrollableFramesEnabled in WebKit API
wangxianzhu@chromium.org [Thu, 6 Dec 2012 19:27:44 +0000 (19:27 +0000)]
[Chromium] Expose acceleratedCompositingForScrollableFramesEnabled in WebKit API
https://bugs.webkit.org/show_bug.cgi?id=104272

We may need the API to enable compositing scrollable frames in Chromium.

Reviewed by Darin Fisher.

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setAcceleratedCompositingForScrollableFramesEnabled):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove harmful string->function cache
oliver@apple.com [Thu, 6 Dec 2012 19:26:20 +0000 (19:26 +0000)]
Remove harmful string->function cache
https://bugs.webkit.org/show_bug.cgi?id=104193

Reviewed by Alexey Proskuryakov.

Remove the string->function code cache that turned out to actually
be quite harmful.

* runtime/CodeCache.cpp:
(JSC::CodeCache::getFunctionCodeBlock):
* runtime/CodeCache.h:
(JSC::CodeCache::clear):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Fix QWebKitTest's notification of device pixel ratio change
abecsi@webkit.org [Thu, 6 Dec 2012 19:21:14 +0000 (19:21 +0000)]
[Qt][WK2] Fix QWebKitTest's notification of device pixel ratio change
https://bugs.webkit.org/show_bug.cgi?id=104269

Unreviewed, trivialy fixing last minute change.

Move signal emission to the correct place.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::onComponentComplete):
* UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::PageViewportControllerClientQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Add GL_CHROMIUM_async_pixel_transfers extension support.
commit-queue@webkit.org [Thu, 6 Dec 2012 19:06:31 +0000 (19:06 +0000)]
[Chromium] Add GL_CHROMIUM_async_pixel_transfers extension support.
https://bugs.webkit.org/show_bug.cgi?id=103995

Patch by David Reveman <reveman@chromium.org> on 2012-12-06
Reviewed by Kenneth Russell.

Add asyncTexImage2DCHROMIUM and asyncTexSubImage2DCHROMIUM to
WebGraphicsContext3D.h.

* chromium/public/WebGraphicsContext3D.h:
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::asyncTexImage2DCHROMIUM):
(WebKit::WebGraphicsContext3D::asyncTexSubImage2DCHROMIUM):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Exclusions] Add support for computing the first included interval position.
commit-queue@webkit.org [Thu, 6 Dec 2012 19:05:15 +0000 (19:05 +0000)]
[CSS Exclusions] Add support for computing the first included interval position.
https://bugs.webkit.org/show_bug.cgi?id=103327

Source/WebCore:

Patch by Hans Muller <hmuller@adobe.com> on 2012-12-06
Reviewed by Levi Weintraub.

If the first "word" in a line doesn't fit within the shape-inside when lineTop
is the top of the shape's logical bounding box, adjust lineTop downwards to where
the word fits.  Currently only rounded rectangle shapes are supported.

Added ExclusionShape::firstIncludedIntervalLogicalTop(). The new virtual method
computes the topmost/leftmost location where a line segment with the specified
minLogicalIntervalSize will fit within the exclusion shape and returns the
corresponding logical Y coordinate.  The result is additionally constrained to
be at or below minLogicalIntervalTop. If the segment will not fit anywhere within
the shape, then false is returned.

During layout, minLogicalIntervalTop is the nominal top of the line being laid
out within the exclusion shape.

RenderBlock::layoutRunsAndFloatsInRange() now calls a new ExclusionShapeInsideInfo
method, adjustLogicalLineTop(), which uses firstIncludedIntervalLogicalTop() to
decide if the logical top of the line has to be moved downwards, for the first
word to fit within the exclusion shape.

Tests: fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-001.html
       fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-002.html

* rendering/ExclusionPolygon.cpp:
(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): This is a stub implementation.
* rendering/ExclusionPolygon.h:
* rendering/ExclusionRectangle.cpp:
(WebCore::ellipseXIntercept): Added spaces to conform to webkit style and to be consistent with ellipseYIntercept()
(WebCore::ellipseYIntercept): Compute an ellipse's Y intercept for an X coordinate.
(WebCore::ExclusionRectangle::firstIncludedIntervalLogicalTop): See the description above.
* rendering/ExclusionRectangle.h:
* rendering/ExclusionShape.h:
(ExclusionShape):
(WebCore::ExclusionShape::logicalTopForMinY): Internal to logical coordinate conversion.
* rendering/ExclusionShapeInsideInfo.cpp:
(WebCore::ExclusionShapeInsideInfo::adjustLogicalLineTop): A new method that updates m_lineTop with firstIncludedIntervalPosition().
* rendering/ExclusionShapeInsideInfo.h:
(ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::logicalLineTop): This is just a cover for the private m_lineTop field.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Added code that restarts the layout loop if it's necessary to adjust the line's logicalTop.
(WebCore::RenderBlock::restartLayoutRunsAndFloatsInRange): Factored newly common code into this helper function.

LayoutTests:

Test the rounded rectangle support for adjusting the top of a line downwards
when the first word doesn't fit within the shape.

Patch by Hans Muller <hmuller@adobe.com> on 2012-12-06
Reviewed by Levi Weintraub.

* fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-001-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-001.html: Added.
* fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-002-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-002.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Add myself to committers.py.
mvujovic@adobe.com [Thu, 6 Dec 2012 18:59:27 +0000 (18:59 +0000)]
Unreviewed. Add myself to committers.py.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline some expectations
schenney@chromium.org [Thu, 6 Dec 2012 18:24:33 +0000 (18:24 +0000)]
Rebaseline some expectations

Unreviewed expectations update

These test have expectations but apparently just need rebaselines.
Some may still be flakey.

* platform/chromium-linux/fast/canvas/canvas-incremental-repaint-expected.png:
* platform/chromium-linux/svg/css/group-with-shadow-expected.png:
* platform/chromium-linux/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
* platform/chromium-mac-lion/fast/canvas/canvas-incremental-repaint-expected.png:
* platform/chromium-mac-lion/svg/css/group-with-shadow-expected.png:
* platform/chromium-mac-lion/svg/custom/mask-invalidation-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/transform-with-shadow-and-gradient-expected.png: Removed.
* platform/chromium-mac/fast/canvas/canvas-incremental-repaint-expected.png:
* platform/chromium-mac/svg/css/group-with-shadow-expected.png:
* platform/chromium-mac/svg/custom/radialGradient-focal-radius-expected.png: Added.
* platform/chromium-mac/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
* platform/chromium-win-xp/svg/css/group-with-shadow-expected.png:
* platform/chromium-win/fast/canvas/canvas-incremental-repaint-expected.png:
* platform/chromium-win/svg/css/group-with-shadow-expected.png:
* platform/chromium-win/svg/custom/mask-invalidation-expected.png:
* platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.png:
* platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
* platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.png:
* platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
* platform/chromium-win/svg/custom/radialGradient-focal-radius-expected.png: Added.
* platform/chromium-win/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
* platform/chromium/svg/custom/radialGradient-focal-radius-expected.png: Removed.
* platform/chromium/svg/custom/transform-with-shadow-and-gradient-expected.png: Removed.
* platform/efl-wk1/svg/custom: Added.
* platform/efl-wk1/svg/custom/radialGradient-focal-radius-expected.png: Added.
* platform/efl/svg/custom/radialGradient-focal-radius-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Optimize binary size by removing dead sections on unix/gcc
commit-queue@webkit.org [Thu, 6 Dec 2012 18:18:31 +0000 (18:18 +0000)]
[EFL] Optimize binary size by removing dead sections on unix/gcc
https://bugs.webkit.org/show_bug.cgi?id=102827

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-12-06
Reviewed by Kenneth Rohde Christiansen.

Turn on -ffunction-sections -fdata-sections --gc-section flags
on unix for the gcc toolchain for release builds to optimize binary
size for the Efl port.

* Source/cmake/OptionsEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTest expectations update
schenney@chromium.org [Thu, 6 Dec 2012 18:10:02 +0000 (18:10 +0000)]
Test expectations update
https://bugs.webkit.org/show_bug.cgi?id=104007

Unreviewed expectations update.

* platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Should apply link highlight to largest enclosing node with a handCursor.
wjmaclean@chromium.org [Thu, 6 Dec 2012 18:02:36 +0000 (18:02 +0000)]
[chromium] Should apply link highlight to largest enclosing node with a handCursor.
https://bugs.webkit.org/show_bug.cgi?id=104264

Reviewed by Adrienne Walker.

Source/WebKit/chromium:

Link highlights sometimes only apply to part of a link, if we select an enclosed
node (e.g. font changes in link text). The highlight should be applied to the
largest enclosing node that still has handCursor set.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::bestTouchLinkNode):

LayoutTests:

Add layout test to cover new functionality.

* platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested.html: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested-expected.png: Added.
* platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Fix QWebKitTest's notification of device pixel ratio change
abecsi@webkit.org [Thu, 6 Dec 2012 17:53:26 +0000 (17:53 +0000)]
[Qt][WK2] Fix QWebKitTest's notification of device pixel ratio change
https://bugs.webkit.org/show_bug.cgi?id=104269

Reviewed by Kenneth Rohde Christiansen.

Since the ViewportInfoItem of MiniBrowser is created before the
WebView finishes construction, thus before the viewport controller
has been instantiated, the shown device pixel ratio was incorrect.
Additionally QWebKitTest's notification signal was also not emitted
when the value changed.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
* UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::PageViewportControllerClientQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse ownerNode() instead of base() in HTMLCollection
rniwa@webkit.org [Thu, 6 Dec 2012 17:52:50 +0000 (17:52 +0000)]
Use ownerNode() instead of base() in HTMLCollection
https://bugs.webkit.org/show_bug.cgi?id=104244

Reviewed by Adam Barth.

Use ownerNode() instead of base() in HTMLCollection to match LiveNodeList.
Notice that the definition of base(), which this patch removes, is "return ownerNode()".

* bindings/js/JSHTMLFormControlsCollectionCustom.cpp:
(WebCore::getNamedItems):
* bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::JSHTMLOptionsCollection::indexSetter):
(WebCore::JSHTMLOptionsCollection::remove):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateOpaqueRootForGC):
* bindings/scripts/IDLAttributes.txt:
* bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp:
(WebCore::getNamedItems):
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::removeCallback):
(WebCore::V8HTMLOptionsCollection::indexedPropertySetter):
* dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::ownerNode):
* dom/WebKitNamedFlow.h:
(WebKitNamedFlow):
* dom/WebKitNamedFlow.idl:
* html/HTMLAllCollection.idl:
* html/HTMLCollection.h:
(HTMLCollection):
* html/HTMLCollection.idl:
* html/HTMLFormControlsCollection.cpp:
(WebCore::HTMLFormControlsCollection::HTMLFormControlsCollection):
(WebCore::HTMLFormControlsCollection::create):
(WebCore::HTMLFormControlsCollection::formControlElements):
(WebCore::HTMLFormControlsCollection::formImageElements):
(WebCore::HTMLFormControlsCollection::namedItem):
(WebCore::HTMLFormControlsCollection::updateNameCache):
* html/HTMLFormControlsCollection.idl:
* html/HTMLNameCollection.cpp:
(WebCore::HTMLNameCollection::~HTMLNameCollection):
(WebCore::HTMLNameCollection::virtualItemAfter):
* html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::add):
(WebCore::HTMLOptionsCollection::remove):
(WebCore::HTMLOptionsCollection::selectedIndex):
(WebCore::HTMLOptionsCollection::setSelectedIndex):
(WebCore::HTMLOptionsCollection::setLength):
* html/HTMLOptionsCollection.idl:
* html/HTMLPropertiesCollection.cpp:
(WebCore::HTMLPropertiesCollection::updateRefElements):
(WebCore::HTMLPropertiesCollection::namedItem):
* html/HTMLTableRowsCollection.cpp:
(WebCore::HTMLTableRowsCollection::virtualItemAfter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUndoManager layout tests should be removed
zandobersek@gmail.com [Thu, 6 Dec 2012 17:49:46 +0000 (17:49 +0000)]
UndoManager layout tests should be removed
https://bugs.webkit.org/show_bug.cgi?id=104246

Reviewed by Adam Barth.

The UndoManager feature support was removed from the source tree
in r133326. The layout tests should be removed as well. As with
the feature implementation, these too can be restored back when needed.

* editing/undomanager: Removed.
* editing/undomanager/automatic-transaction-attribute-expected.txt: Removed.
* editing/undomanager/automatic-transaction-attribute.html: Removed.
* editing/undomanager/automatic-transaction-data-expected.txt: Removed.
* editing/undomanager/automatic-transaction-data.html: Removed.
* editing/undomanager/automatic-transaction-node-expected.txt: Removed.
* editing/undomanager/automatic-transaction-node.html: Removed.
* editing/undomanager/document-has-undomanager-expected.txt: Removed.
* editing/undomanager/document-has-undomanager.html: Removed.
* editing/undomanager/domtransaction-survives-gc-expected.txt: Removed.
* editing/undomanager/domtransaction-survives-gc.html: Removed.
* editing/undomanager/undomanager-isolated-world-expected.txt: Removed.
* editing/undomanager/undomanager-isolated-world.html: Removed.
* editing/undomanager/undomanager-item-expected.txt: Removed.
* editing/undomanager/undomanager-item.html: Removed.
* editing/undomanager/undomanager-reenter-expected.txt: Removed.
* editing/undomanager/undomanager-reenter.html: Removed.
* editing/undomanager/undomanager-transact-expected.txt: Removed.
* editing/undomanager/undomanager-transact.html: Removed.
* editing/undomanager/undomanager-undo-redo-expected.txt: Removed.
* editing/undomanager/undomanager-undo-redo.html: Removed.
* editing/undomanager/undoscopehost-use-after-free-expected.txt: Removed.
* editing/undomanager/undoscopehost-use-after-free.html: Removed.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt-4.8/TestExpectations:
* platform/qt-mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
commit-queue@webkit.org [Thu, 6 Dec 2012 17:43:33 +0000 (17:43 +0000)]
[EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
https://bugs.webkit.org/show_bug.cgi?id=104139

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-12-06
Reviewed by Kenneth Rohde Christiansen.

Resize the window back to 800x600 between tests.
This should be a no-op if the test did not resize the window.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] Unreviewed gardening after r136415.
alexis@webkit.org [Thu, 6 Dec 2012 17:07:02 +0000 (17:07 +0000)]
[Mac] Unreviewed gardening after r136415.

r136415 enables the CSS3 background position offsets therefore this
expected png needs to be updated with the new result (the correct one
actually). It was not failing on the bot as the Apple Mac bot does not
seem to run pixel tests.

* platform/mac/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSpeech Recognition API: Change the error code to a string on SpeechRecognitionError
tommyw@google.com [Thu, 6 Dec 2012 16:59:58 +0000 (16:59 +0000)]
Speech Recognition API: Change the error code to a string on SpeechRecognitionError
https://bugs.webkit.org/show_bug.cgi?id=104254

Reviewed by Adam Barth.

Source/WebCore:

SpeechRecognitionError::code (numeric value) has been changed to SpeechRecognitionError::error (string)
in the latest specification.

http://dvcs.w3.org/hg/speech-api/raw-file/tip/speechapi.html#speechreco-error

Existing tests modified to cover this patch.

* Modules/speech/SpeechRecognitionError.cpp:
(WebCore::ErrorCodeToString):
(WebCore):
(WebCore::SpeechRecognitionError::create):
(WebCore::SpeechRecognitionError::SpeechRecognitionError):
* Modules/speech/SpeechRecognitionError.h:
(SpeechRecognitionErrorInit):
(WebCore::SpeechRecognitionError::error):
(SpeechRecognitionError):
* Modules/speech/SpeechRecognitionError.idl:

Source/WebKit/chromium:

Minor WebCore type changes.

* src/AssertMatchingEnums.cpp:
* src/SpeechRecognitionClientProxy.cpp:
(WebKit::SpeechRecognitionClientProxy::didReceiveError):

Tools:

Changes the mock error function to take a string instead of an int.

* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::setMockSpeechRecognitionError):
* DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
(WebTestRunner::ErrorTask::ErrorTask):
(MockWebSpeechRecognizer::setError):
* DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
(MockWebSpeechRecognizer):

LayoutTests:

Adjusting tests.

* fast/events/constructors/speech-recognition-error-constructor-expected.txt:
* fast/events/constructors/speech-recognition-error-constructor.html:
* fast/speech/scripted/speechrecognition-errors-expected.txt:
* fast/speech/scripted/speechrecognition-errors.html:
* fast/speech/scripted/speechrecognitionerror-basics-expected.txt:
* fast/speech/scripted/speechrecognitionerror-basics.html:
* platform/chromium/fast/events/constructors/speech-recognition-error-constructor-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSVG <use> element inside an svg-as-image fails
schenney@chromium.org [Thu, 6 Dec 2012 16:53:10 +0000 (16:53 +0000)]
SVG <use> element inside an svg-as-image fails
https://bugs.webkit.org/show_bug.cgi?id=104007

Reviewed by Eric Seidel.

Upon redraw, SVGImage calls layout on the document it is drawing into
the image if the image, provided it believes the redraw does not need
to be delayed. Unfortunately, when an SVG <use> element is modified
(by animation, say) and regenerates its shadow tree, the destructors
invoke redraw, causing the SVGImage to call layout on something that
is in the process of being deleted. That's bad.

This change causes SVGImage to always delay the redraw. It is the most robust
way to protect against this problem, as there may be any number of
ways to cause this issue (a node being deleted in an svg-as-image
target) and this protects against them all.

The test case crashes in Asan Chromium.

Source/WebCore:

Test: svg/as-image/animated-use-as-image-crash.html

* svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::imageContentChanged): Always redraw on the timer.

LayoutTests:

* platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.png: Changed as a result of this change.
* svg/as-image/animated-use-as-image-crash-expected.txt: Added.
* svg/as-image/animated-use-as-image-crash.html: Added.
* svg/as-image/resources/animated-href-on-use.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, update an expected file.
ossy@webkit.org [Thu, 6 Dec 2012 16:41:34 +0000 (16:41 +0000)]
[Qt] Unreviewed gardening, update an expected file.

* platform/qt/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTextTrack's .cues not ordered correctly when two cues have the same .startTime
commit-queue@webkit.org [Thu, 6 Dec 2012 15:23:10 +0000 (15:23 +0000)]
TextTrack's .cues not ordered correctly when two cues have the same .startTime
https://bugs.webkit.org/show_bug.cgi?id=103266

Patch by Antoine Quint <graouts@apple.com> on 2012-12-06
Reviewed by Eric Carlson.

Source/WebCore:

Adding a new method TextTrackCueList::updateCueIndex() to update the list of
cues after changing the .startTime or .endTime of a TextTrackCue. I elected to
add a new method to TextTrackCueList rather than calling remove() and then add()
on the list from TextTrack::cueDidChange() so that the nature of the operation
is abstracted and we can easily change the way we keep the cue list sorted at
a later time should we choose to.

* html/track/TextTrack.cpp:
(WebCore::TextTrack::cueDidChange):
* html/track/TextTrackCueList.cpp:
(WebCore::TextTrackCueList::updateCueIndex):
(WebCore):
* html/track/TextTrackCueList.h:
(TextTrackCueList):

LayoutTests:

Unskip an Opera test that we now pass. Note that the original test has two issues that prompted
changes in this patch. The first issue is https://www.w3.org/Bugs/Public/show_bug.cgi?id=20066
and I've elected to comment the sub-test that fails and tracking turning it back on when the test
is corrected with https://bugs.webkit.org/show_bug.cgi?id=104255. The second issue was in the sub-test
that revealed the failure covered by this bug and had an issue acknowledged by the author
(see https://www.w3.org/Bugs/Public/show_bug.cgi?id=20066) so I fixed it in our repository.

* media/track/opera/interfaces/TextTrack/cues-expected.txt: Added.
* media/track/opera/interfaces/TextTrack/cues.html:
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] QWebView uses the mobile style and doesn't follow Qt's style
pierre.rossi@gmail.com [Thu, 6 Dec 2012 15:01:28 +0000 (15:01 +0000)]
[Qt] QWebView uses the mobile style and doesn't follow Qt's style
https://bugs.webkit.org/show_bug.cgi?id=104134

Reviewed by Simon Hausmann.

Another issue introduced by r136235.
Fix the order of initialization of the styleFactory and creation of the
WebCore Page. Since the latter has a RenderTheme member and the creation
of the appropriate RenderTheme type (QStyle-backed) is dependant on having
first initialized the theme factory function, we need to postpone this just
a little bit.

* WebCoreSupport/QWebPageAdapter.cpp:
(QWebPageAdapter::QWebPageAdapter):
(QWebPageAdapter::initializeWebCorePage): Added.
* WebCoreSupport/QWebPageAdapter.h:
* WidgetApi/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate): call initializeWebCorePage only after
having initialized WebKitWidgets related logic (QStyle hooks in this case).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r136788.
commit-queue@webkit.org [Thu, 6 Dec 2012 14:56:26 +0000 (14:56 +0000)]
Unreviewed, rolling out r136788.
http://trac.webkit.org/changeset/136788
https://bugs.webkit.org/show_bug.cgi?id=104260

Asserts on EFL WebKit2 Debug bot (Requested by yael on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06

* UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::setLayerState):
(WebKit::LayerTreeRenderer::setRootLayerID):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r136795.
commit-queue@webkit.org [Thu, 6 Dec 2012 14:45:50 +0000 (14:45 +0000)]
Unreviewed, rolling out r136795.
http://trac.webkit.org/changeset/136795
https://bugs.webkit.org/show_bug.cgi?id=104257

Asserts on EFL WebKit2 Debug bot (Requested by yael on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06

* UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::setRootLayerID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Fix destination path in Source/PlatformEfl.cmake
commit-queue@webkit.org [Thu, 6 Dec 2012 14:11:05 +0000 (14:11 +0000)]
[EFL] Fix destination path in Source/PlatformEfl.cmake
https://bugs.webkit.org/show_bug.cgi?id=104237

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2012-12-06
Reviewed by Laszlo Gombos.

Remove InspectorBackendCommands.js when copying it for the consistency in Source/PlatformEfl.cmake.

* Source/PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Thu, 6 Dec 2012 14:04:44 +0000 (14:04 +0000)]
Unreviewed GTK gardening.

Adding missing platform-specific baselines.

* platform/gtk/fast/text/decorations-with-text-combine-expected.png: Added.
* platform/gtk/fast/text/decorations-with-text-combine-expected.txt: Added.
* platform/gtk/fast/text/orientation-sideways-expected.png: Added.
* platform/gtk/fast/text/orientation-sideways-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][Mac] Fix libxslt and libxml2 config tests
abecsi@webkit.org [Thu, 6 Dec 2012 14:02:31 +0000 (14:02 +0000)]
[Qt][Mac] Fix libxslt and libxml2 config tests
https://bugs.webkit.org/show_bug.cgi?id=104164

Reviewed by Simon Hausmann.

Source/WebCore:

Since libxml2 is a dependency for libxslt and is not used
standalone the configurations for it should also depend on
whether XSLT is enabled.
Also avoid using pkg-config on Mac, instead use direct
include paths and add needed libraries to the linker.

No new tests needed.

* WebCore.pri:

Tools:

We should not use pkg-config on Mac instead use direct include
paths and add needed libraries to the linker options to detect
libxslt and libxml2 provided by the system.
Previously we would always fall back to qtxmlpatterns.

* qmake/config.tests/libxml2/libxml2.pro:
* qmake/config.tests/libxslt/libxslt.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Fix the build if the path contains "+" character
ossy@webkit.org [Thu, 6 Dec 2012 13:55:54 +0000 (13:55 +0000)]
[Qt] Fix the build if the path contains "+" character
https://bugs.webkit.org/show_bug.cgi?id=104120

Reviewed by Tor Arne Vestbø.

The second parameter of qmake's replace() is regular expression, so
we have to escape special characters in paths passed to replace().

* qmake/mkspecs/features/default_post.prf:
* qmake/mkspecs/features/default_pre.prf:
* qmake/mkspecs/features/functions.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][Qt] fast/regions/autowidth-normalflow-maxwidth.html is failing
commit-queue@webkit.org [Thu, 6 Dec 2012 13:54:32 +0000 (13:54 +0000)]
[EFL][Qt] fast/regions/autowidth-normalflow-maxwidth.html is failing
https://bugs.webkit.org/show_bug.cgi?id=104160

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-12-06
Reviewed by Kenneth Rohde Christiansen.

The test fast/regions/autowidth-normalflow-maxwidth.html is failing for EFL and Qt
because the test expects that the text of the test would fit in 400 pixels,
but both for Qt and for EFL, the text requires more than that.
Changed the test and the expectation ref-test to allow 450 pixels.

* fast/regions/autowidth-normalflow-maxwidth-expected.html:
* fast/regions/autowidth-normalflow-maxwidth.html:
* platform/efl-wk2/TestExpectations:
* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInternals.getElementByIdInShadowRoot is nonsense now.
shinyak@chromium.org [Thu, 6 Dec 2012 13:38:47 +0000 (13:38 +0000)]
Internals.getElementByIdInShadowRoot is nonsense now.
https://bugs.webkit.org/show_bug.cgi?id=104241

Reviewed by Kent Tamura.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

Since we have ShadowRoot.getElementById() now, we don't need Internals.getElementByIdInShadowRoot, which is
the same functionality of ShadowRoot.getElementById().

Test: fast/dom/shadow/get-element-by-id-in-shadow-root.html

* WebCore.exp.in:
* testing/Internals.cpp:
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit2:

* win/WebKit2.def.in:

LayoutTests:

* fast/dom/shadow/get-element-by-id-in-shadow-root-expected.txt:
* fast/dom/shadow/get-element-by-id-in-shadow-root.html:
* fast/dom/shadow/resources/shadow-dom.js: Uses ShadowRoot.getElementById() instead.
(getNodeInShadowTreeStack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Context clients should unregister themselves when destroyed
christophe.dumez@intel.com [Thu, 6 Dec 2012 13:11:24 +0000 (13:11 +0000)]
[EFL][WK2] Context clients should unregister themselves when destroyed
https://bugs.webkit.org/show_bug.cgi?id=104113

Reviewed by Kenneth Rohde Christiansen.

Make sure the context clients (History and Download clients)
unregister themselves when destroyed to make sure their
callback functions are never called after the client objects
have been destroyed (i.e. when the parent Ewk_Context has
been destroyed).

This addresses crashing issues after a Ewk_Context object
gets unref'd and destroyed.

* UIProcess/efl/ContextHistoryClientEfl.cpp:
(WebKit::ContextHistoryClientEfl::ContextHistoryClientEfl):
(WebKit):
(WebKit::ContextHistoryClientEfl::~ContextHistoryClientEfl):
* UIProcess/efl/ContextHistoryClientEfl.h:
(ContextHistoryClientEfl):
* UIProcess/efl/DownloadManagerEfl.cpp:
(WebKit::DownloadManagerEfl::~DownloadManagerEfl):
(WebKit):
* UIProcess/efl/DownloadManagerEfl.h:
(DownloadManagerEfl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Active texture state gets corrupted after updating graphics surface contents.
commit-queue@webkit.org [Thu, 6 Dec 2012 12:32:02 +0000 (12:32 +0000)]
[EFL] Active texture state gets corrupted after updating graphics surface contents.
https://bugs.webkit.org/show_bug.cgi?id=104248.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-06
Reviewed by Kenneth Rohde Christiansen.

GraphicsContext3DPrivate::copyToGraphicsSurface() doesn't restore the previously bound texture
after copying texture contents. This corrupts the texture state.

Existing Tests should cover this.

* platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(GraphicsContext3DPrivate::copyToGraphicsSurface):
* platform/graphics/opengl/GLPlatformSurface.cpp:
(WebCore::GLPlatformSurface::updateContents):
* platform/graphics/opengl/GLPlatformSurface.h:
(GLPlatformSurface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Goto panel shortcuts and description are reversed
apavlov@chromium.org [Thu, 6 Dec 2012 12:29:34 +0000 (12:29 +0000)]
Web Inspector: Goto panel shortcuts and description are reversed
https://bugs.webkit.org/show_bug.cgi?id=103988

Reviewed by Pavel Feldman.

Swap the square brackets in the shortcuts.

* inspector/front-end/inspector.js:
(WebInspector._registerShortcuts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r136825.
commit-queue@webkit.org [Thu, 6 Dec 2012 12:13:59 +0000 (12:13 +0000)]
Unreviewed, rolling out r136825.
http://trac.webkit.org/changeset/136825
https://bugs.webkit.org/show_bug.cgi?id=104251

It made 100+ test fail on Qt-WK2 pixel bot, and 1800+ test
flakey on Qt-WK2 non-pixel bot (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r136818.
commit-queue@webkit.org [Thu, 6 Dec 2012 11:51:26 +0000 (11:51 +0000)]
Unreviewed, rolling out r136818.
http://trac.webkit.org/changeset/136818
https://bugs.webkit.org/show_bug.cgi?id=104249

simulatedClick does not work as per #chrmium irc. (Requested
by hayato on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06

Source/WebCore:

* dom/EventDispatcher.cpp:
(WebCore::EventRelatedTargetAdjuster::adjust):
* dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::create):
(WebCore::MouseEventDispatchMediator::MouseEventDispatchMediator):
(WebCore::MouseEventDispatchMediator::dispatchEvent):
* dom/MouseEvent.h:
(MouseEventDispatchMediator):
* dom/Node.cpp:
(WebCore::Node::dispatchEvent):

LayoutTests:

* fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
* fast/dom/shadow/shadow-dom-event-dispatching.html:
* fast/events/dispatch-synthetic-mouseevent-expected.txt: Removed.
* fast/events/dispatch-synthetic-mouseevent.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed, fix baselines for plugins/npp-set-window-called-during-destruc...
podivilov@chromium.org [Thu, 6 Dec 2012 11:13:33 +0000 (11:13 +0000)]
[chromium] Unreviewed, fix baselines for plugins/npp-set-window-called-during-destruction.html on win7.

* platform/chromium-linux/plugins/npp-set-window-called-during-destruction-expected.txt: Removed.
* platform/chromium-win-xp/plugins/npp-set-window-called-during-destruction-expected.txt: Removed.
* platform/chromium-win/plugins/npp-set-window-called-during-destruction-expected.txt:
* platform/win/plugins/npp-set-window-called-during-destruction-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Test expectation update
tkent@chromium.org [Thu, 6 Dec 2012 10:48:59 +0000 (10:48 +0000)]
[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=104210
https://bugs.webkit.org/show_bug.cgi?id=103869

* platform/chromium-linux/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium-linux/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-linux/fast/forms/date/date-appearance-pseudo-elements-expected.png:
* platform/chromium-linux/fast/forms/datetime/datetime-appearance-l10n-expected.png:
* platform/chromium-linux/fast/forms/month/month-appearance-basic-expected.png:
* platform/chromium-linux/fast/forms/month/month-appearance-l10n-expected.png:
* platform/chromium-linux/fast/forms/month/month-appearance-pseudo-elements-expected.png:
* platform/chromium-linux/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-linux/fast/forms/time/time-appearance-pseudo-elements-expected.png:
* platform/chromium-linux/fast/forms/week/week-appearance-basic-expected.png:
* platform/chromium-linux/fast/forms/week/week-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-lion/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium-mac-lion/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-mac-lion/fast/forms/date/date-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-lion/fast/forms/datetime/datetime-appearance-l10n-expected.png:
* platform/chromium-mac-lion/fast/forms/month/month-appearance-basic-expected.png:
* platform/chromium-mac-lion/fast/forms/month/month-appearance-l10n-expected.png:
* platform/chromium-mac-lion/fast/forms/month/month-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-lion/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-mac-lion/fast/forms/time/time-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-lion/fast/forms/week/week-appearance-basic-expected.png:
* platform/chromium-mac-lion/fast/forms/week/week-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/datetime/datetime-appearance-l10n-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-l10n-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-pseudo-elements-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-pseudo-elements-expected.png:
* platform/chromium-mac/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-mac/fast/forms/date/date-appearance-pseudo-elements-expected.png:
* platform/chromium-mac/fast/forms/month/month-appearance-l10n-expected.png:
* platform/chromium-mac/fast/forms/month/month-appearance-pseudo-elements-expected.png:
* platform/chromium-mac/fast/forms/time/time-appearance-pseudo-elements-expected.png:
* platform/chromium-mac/fast/forms/week/week-appearance-pseudo-elements-expected.png:
* platform/chromium-win-xp/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-win-xp/fast/forms/month/month-appearance-l10n-expected.png:
* platform/chromium-win/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium-win/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-win/fast/forms/date/date-appearance-pseudo-elements-expected.png:
* platform/chromium-win/fast/forms/datetime/datetime-appearance-l10n-expected.png:
* platform/chromium-win/fast/forms/month/month-appearance-basic-expected.png:
* platform/chromium-win/fast/forms/month/month-appearance-l10n-expected.png:
* platform/chromium-win/fast/forms/month/month-appearance-pseudo-elements-expected.png:
* platform/chromium-win/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-win/fast/forms/time/time-appearance-pseudo-elements-expected.png:
* platform/chromium-win/fast/forms/week/week-appearance-basic-expected.png:
* platform/chromium-win/fast/forms/week/week-appearance-pseudo-elements-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Update test expectations
tkent@chromium.org [Thu, 6 Dec 2012 10:25:52 +0000 (10:25 +0000)]
[Chromium] Update test expectations
https://bugs.webkit.org/show_bug.cgi?id=103853
https://bugs.webkit.org/show_bug.cgi?id=103869

* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
commit-queue@webkit.org [Thu, 6 Dec 2012 10:08:29 +0000 (10:08 +0000)]
[EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
https://bugs.webkit.org/show_bug.cgi?id=104139

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-12-06
Reviewed by Kenneth Rohde Christiansen.

Resize the window back to 800x600 between tests.
This should be a no-op if the test did not resize the window.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[v8] Fix hidden property name of V8ArrayBufferView flag.
commit-queue@webkit.org [Thu, 6 Dec 2012 09:49:09 +0000 (09:49 +0000)]
[v8] Fix hidden property name of V8ArrayBufferView flag.
https://bugs.webkit.org/show_bug.cgi?id=104099

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-12-06
Reviewed by Kentaro Hara.

Fix hidden property name of V8ArrayBufferView hidden copy method.

* bindings/v8/V8HiddenPropertyName.h:
(WebCore):
* bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
(WebCore::getHiddenCopyMethod):
(WebCore::installHiddenCopyMethod):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fixed a wrong comment landed in r136822.
haraken@chromium.org [Thu, 6 Dec 2012 09:38:38 +0000 (09:38 +0000)]
Unreviewed. Fixed a wrong comment landed in r136822.

* bindings/v8/V8Binding.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Implement deprecatedV8String()
haraken@chromium.org [Thu, 6 Dec 2012 09:19:09 +0000 (09:19 +0000)]
[V8] Implement deprecatedV8String()
https://bugs.webkit.org/show_bug.cgi?id=104230

Reviewed by Adam Barth.

To make an Isolate mandatory in v8String(), we implement
deprecatedV8String() for call sites that don't have
an Isolate. Eventually we want to kill the method though.

No tests. No change in behavior.

* bindings/scripts/test/V8/V8TestCallback.cpp:
(WebCore::V8TestCallback::callbackWithClass2Param):
* bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::getKey):
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::get):
(WebCore::set):
* bindings/v8/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::evaluate):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::compileAndRunScript):
(WebCore::ScriptController::bindToWindowObject):
(WebCore::ScriptController::disableEval):
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::setScriptSource):
(WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled):
(WebCore::ScriptDebugServer::compileScript):
* bindings/v8/ScriptFunctionCall.cpp:
(WebCore::ScriptCallArgumentHandler::appendArgument):
(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::start):
(WebCore::ScriptProfiler::stop):
(WebCore::ScriptProfiler::takeHeapSnapshot):
* bindings/v8/ScriptSourceCode.cpp:
(WebCore::ScriptSourceCode::compileScript):
* bindings/v8/V8Binding.h:
(WebCore):
(WebCore::deprecatedV8String):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::namedItemAdded):
(WebCore::V8DOMWindowShell::namedItemRemoved):
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
* bindings/v8/V8WindowErrorHandler.cpp:
(WebCore::V8WindowErrorHandler::callListenerFunction):
* bindings/v8/V8WorkerContextErrorHandler.cpp:
(WebCore::V8WorkerContextErrorHandler::callListenerFunction):
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
* bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
(WebCore::installHiddenCopyMethod):
(WebCore::copyElements):
* bindings/v8/custom/V8CustomXPathNSResolver.cpp:
(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::getEventListenersCallback):
* bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::createInjectedScript):
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPage popup should align to the right when the anchor element is rtl
keishi@webkit.org [Thu, 6 Dec 2012 09:03:28 +0000 (09:03 +0000)]
Page popup should align to the right when the anchor element is rtl
https://bugs.webkit.org/show_bug.cgi?id=104219

Reviewed by Kent Tamura.

Page popup should align to the right edge of the anchor element when the anchor element is rtl.

No new tests. Mock page popup can't test popup window position.

* Resources/pagepopups/pickerCommon.js:
(_adjustWindowRectHorizontally): Align to the right edge when anchor element is rtl. Removed some redundant lines.
(setWindowRect): If the window is hidden we want to move first then resize so the popup doesn't flicker.
(isWindowHidden): Returns true if the window is hidden using hideWindow().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Make an Isolate mandatory for v8StringOrNull() and v8StringOrUndefined()
haraken@chromium.org [Thu, 6 Dec 2012 09:01:57 +0000 (09:01 +0000)]
[V8] Make an Isolate mandatory for v8StringOrNull() and v8StringOrUndefined()
https://bugs.webkit.org/show_bug.cgi?id=104213

Reviewed by Adam Barth.

All call sites of v8StringOrNull() and v8StringOrUndefined() have an Isolate.

No tests. No change in behavior.

* bindings/v8/V8Binding.h:
(WebCore::v8StringOrNull):
(WebCore::v8StringOrUndefined):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Implement deprecatedV8Integer(int i)
haraken@chromium.org [Thu, 6 Dec 2012 08:57:44 +0000 (08:57 +0000)]
[V8] Implement deprecatedV8Integer(int i)
https://bugs.webkit.org/show_bug.cgi?id=104220

Reviewed by Adam Barth.

To make an Isolate mandatory in v8Integer(), we implement
deprecatedV8Integer(int i) for call sites that don't have
an Isolate. Eventually we want to kill deprecatedV8Integer(int i).

No new tests. No change in behavior.

* bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):
* bindings/v8/NPV8Object.cpp:
(_NPN_Enumerate):
* bindings/v8/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::addListener):
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::compileScript):
* bindings/v8/ScriptSourceCode.cpp:
(WebCore::ScriptSourceCode::compileScript):
* bindings/v8/V8Binding.h:
(WebCore):
(WebCore::deprecatedV8Integer):
* bindings/v8/V8DOMConfiguration.cpp:
(WebCore::V8DOMConfiguration::batchConfigureConstants):
* bindings/v8/V8NPUtils.cpp:
(WebCore::convertNPVariantToV8Object):
* bindings/v8/V8Utilities.cpp:
(WebCore::createHiddenDependency):
(WebCore::removeHiddenDependency):
* bindings/v8/V8WindowErrorHandler.cpp:
(WebCore::V8WindowErrorHandler::callListenerFunction):
* bindings/v8/V8WorkerContextErrorHandler.cpp:
(WebCore::V8WorkerContextErrorHandler::callListenerFunction):
* bindings/v8/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::addListener):
* bindings/v8/custom/V8MutationCallbackCustom.cpp:
(WebCore::V8MutationCallback::handleEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEvent's relatedTarget re-targeting does not occur for manually fired mouse events...
hayato@chromium.org [Thu, 6 Dec 2012 08:52:47 +0000 (08:52 +0000)]
Event's relatedTarget re-targeting does not occur for manually fired mouse events created by event.initMouseEvent().
https://bugs.webkit.org/show_bug.cgi?id=102681

Reviewed by Dimitri Glazkov.

Source/WebCore:

Make sure that event's relatedTarget re-targeting occurs for mouse
events created by event.initMouseEvent().  Since user-generated
mouse events can have a relatedTarget which is same to the target
node, the algorithm which calculates event's ancestors is also
updated so that ancestors are not shrunk wrongly.

Test: fast/events/dispatch-synthetic-mouseevent.html
      fast/dom/shadow/shadow-dom-event-dispatching.html

* dom/EventDispatcher.cpp:
(WebCore::EventRelatedTargetAdjuster::adjust):
* dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::create):
(WebCore::MouseEventDispatchMediator::MouseEventDispatchMediator):
(WebCore::MouseEventDispatchMediator::dispatchEvent):
* dom/MouseEvent.h:
(WebCore::MouseEventDispatchMediator::isSyntheticMouseEvent):
(MouseEventDispatchMediator):
* dom/Node.cpp:
(WebCore::Node::dispatchEvent):

LayoutTests:

* fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
* fast/dom/shadow/shadow-dom-event-dispatching.html:
* fast/events/dispatch-synthetic-mouseevent-expected.txt: Added.
* fast/events/dispatch-synthetic-mouseevent.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[JSC] Check whether property is an array before attempting conversion to array in...
commit-queue@webkit.org [Thu, 6 Dec 2012 08:50:56 +0000 (08:50 +0000)]
[JSC] Check whether property is an array before attempting conversion to array in JSDictionary
https://bugs.webkit.org/show_bug.cgi?id=96614

Patch by Michael Pruett <michael@68k.org> on 2012-12-06
Reviewed by Kentaro Hara.

JSDictionary should check whether the property being accessed in get()
is an array before attempting to convert the value to an array.

Previously calling get() with a result type of Vector<String> when
the named property could not be converted to an array would generate
an exception.

Tests: storage/indexeddb/*

* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
* bindings/js/JSDictionary.h:
(WebCore::JSDictionary::tryGetPropertyAndResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Pass Isolate to toDOMStringList()
haraken@chromium.org [Thu, 6 Dec 2012 08:47:18 +0000 (08:47 +0000)]
[V8] Pass Isolate to toDOMStringList()
https://bugs.webkit.org/show_bug.cgi?id=104224

Reviewed by Adam Barth.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(JSValueToNative):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::overloadedMethod6Callback):
(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(WebCore::TestObjV8Internal::stringArrayFunctionCallback):
* bindings/v8/V8Binding.cpp:
(WebCore::toDOMStringList):
* bindings/v8/V8Binding.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove JSDependentRetained.h and V8DependentRetained.h
haraken@chromium.org [Thu, 6 Dec 2012 08:43:22 +0000 (08:43 +0000)]
Remove JSDependentRetained.h and V8DependentRetained.h
https://bugs.webkit.org/show_bug.cgi?id=104232

Reviewed by Adam Barth.

Although (JS|V8)DependentRetained.h were introduced for MutationObservers,
they are not going to be used (See the discussion in bug 95519).
We can remove them.

No tests. No change in behavior.

* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDependentRetained.h: Removed.
* bindings/v8/V8DependentRetained.h: Removed.
* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::V8PerIsolateData):
* bindings/v8/V8PerIsolateData.h:
(V8PerIsolateData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTurn pixel tests in dom/xhtml/level3/core into reftests
zandobersek@gmail.com [Thu, 6 Dec 2012 08:32:16 +0000 (08:32 +0000)]
Turn pixel tests in dom/xhtml/level3/core into reftests
https://bugs.webkit.org/show_bug.cgi?id=103809

Reviewed by Dirk Pranke.

Turn 15 pixel tests under dom/xhtml/level3/core into reftests.
The reference files are tailored so they present the same output that
the pixel baselines (being removed) do.

* dom/xhtml/level3/core/canonicalform08-expected.html: Added.
* dom/xhtml/level3/core/canonicalform09-expected.html: Added.
* dom/xhtml/level3/core/documentgetinputencoding03-expected.html: Added.
* dom/xhtml/level3/core/entitygetinputencoding02-expected.html: Added.
* dom/xhtml/level3/core/entitygetxmlversion02-expected.html: Added.
* dom/xhtml/level3/core/nodegetbaseuri05-expected.html: Added.
* dom/xhtml/level3/core/nodegetbaseuri07-expected.html: Added.
* dom/xhtml/level3/core/nodegetbaseuri09-expected.html: Added.
* dom/xhtml/level3/core/nodegetbaseuri10-expected.html: Added.
* dom/xhtml/level3/core/nodegetbaseuri11-expected.html: Added.
* dom/xhtml/level3/core/nodegetbaseuri15-expected.html: Added.
* dom/xhtml/level3/core/nodegetbaseuri17-expected.html: Added.
* dom/xhtml/level3/core/nodegetbaseuri18-expected.html: Added.
* dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.html: Added.
* dom/xhtml/level3/core/nodelookupprefix19-expected.html: Added.
* The now-unnecessary pixel and render tree baselines: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Replace v8String("symbol") with v8::String::NewSymbol("symbol")
haraken@chromium.org [Thu, 6 Dec 2012 08:31:55 +0000 (08:31 +0000)]
[V8] Replace v8String("symbol") with v8::String::NewSymbol("symbol")
https://bugs.webkit.org/show_bug.cgi?id=104209

Reviewed by Adam Barth.

V8 can look up symbols faster than strings.

No tests. No change in behavior.

* bindings/v8/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::caller):
(WebCore::JavaScriptCallFrame::sourceID):
(WebCore::JavaScriptCallFrame::line):
(WebCore::JavaScriptCallFrame::column):
(WebCore::JavaScriptCallFrame::functionName):
(WebCore::JavaScriptCallFrame::scopeChain):
(WebCore::JavaScriptCallFrame::scopeType):
(WebCore::JavaScriptCallFrame::thisObject):
(WebCore::JavaScriptCallFrame::evaluate):
(WebCore::JavaScriptCallFrame::restart):
* bindings/v8/V8ThrowException.cpp:
(WebCore::domExceptionStackGetter):
(WebCore::domExceptionStackSetter):
(WebCore::V8ThrowException::setDOMException):
* bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
(WebCore::V8InspectorFrontendHost::platformCallback):
* bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:
(WebCore::V8JavaScriptCallFrame::typeAccessorGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r136784 and r136802.
commit-queue@webkit.org [Thu, 6 Dec 2012 08:20:59 +0000 (08:20 +0000)]
Unreviewed, rolling out r136784 and r136802.
http://trac.webkit.org/changeset/136784
http://trac.webkit.org/changeset/136802
https://bugs.webkit.org/show_bug.cgi?id=104231

breaks chromium canary (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06

Source/Platform:

* Platform.gypi:
* chromium/public/linux/WebThemeEngine.h: Added.
(WebKit):
(WebThemeEngine):
(ScrollbarTrackExtraParams):
(ButtonExtraParams):
(TextFieldExtraParams):
(MenuListExtraParams):
(SliderExtraParams):
(InnerSpinButtonExtraParams):
(ProgressBarExtraParams):
(WebKit::WebThemeEngine::getSize):
(WebKit::WebThemeEngine::paint):

Source/WebCore:

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/chromium/PlatformThemeChromiumLinux.cpp: Added.
(WebCore):
(WebCore::PlatformThemeChromiumLinux::setScrollbarColors):
(WebCore::clamp):
(WebCore::PlatformThemeChromiumLinux::saturateAndBrighten):
(WebCore::PlatformThemeChromiumLinux::outlineColor):
(WebCore::PlatformThemeChromiumLinux::paintArrowButton):
* platform/chromium/PlatformThemeChromiumLinux.h: Added.
(WebCore):
(PlatformThemeChromiumLinux):
(WebCore::PlatformThemeChromiumLinux::thumbInactiveColor):
(WebCore::PlatformThemeChromiumLinux::thumbActiveColor):
(WebCore::PlatformThemeChromiumLinux::trackColor):
(WebCore::PlatformThemeChromiumLinux::PlatformThemeChromiumLinux):
* platform/chromium/ScrollbarThemeChromiumLinux.cpp: Added.
(WebCore):
(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumLinux::paintButton):
(WebCore::ScrollbarThemeChromiumLinux::paintThumb):
(WebCore::ScrollbarThemeChromiumLinux::shouldCenterOnThumb):
(WebCore::ScrollbarThemeChromiumLinux::buttonSize):
(WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
* platform/chromium/ScrollbarThemeChromiumLinux.h: Added.
(ScrollbarThemeChromiumLinux):
* rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::extraDefaultStyleSheet):
* rendering/RenderThemeChromiumAndroid.h:
* rendering/RenderThemeChromiumLinux.cpp: Added.
(WebCore):
(WebCore::getWebThemeState):
(WebCore::RenderThemeChromiumLinux::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux):
(WebCore::RenderThemeChromiumLinux::~RenderThemeChromiumLinux):
(WebCore::RenderThemeChromiumLinux::systemColor):
(WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet):
(WebCore::RenderThemeChromiumLinux::controlSupportsTints):
(WebCore::RenderThemeChromiumLinux::activeListBoxSelectionBackgroundColor):
(WebCore::RenderThemeChromiumLinux::activeListBoxSelectionForegroundColor):
(WebCore::RenderThemeChromiumLinux::inactiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeChromiumLinux::inactiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeChromiumLinux::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumLinux::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumLinux::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeChromiumLinux::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeChromiumLinux::sliderTickSize):
(WebCore::RenderThemeChromiumLinux::sliderTickOffsetFromTrackCenter):
(WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
(WebCore::RenderThemeChromiumLinux::supportsControlTints):
(WebCore::RenderThemeChromiumLinux::setCaretBlinkInterval):
(WebCore::RenderThemeChromiumLinux::caretBlinkIntervalInternal):
(WebCore::RenderThemeChromiumLinux::setSelectionColors):
(WebCore::RenderThemeChromiumLinux::paintCheckbox):
(WebCore::RenderThemeChromiumLinux::setCheckboxSize):
(WebCore::RenderThemeChromiumLinux::paintRadio):
(WebCore::RenderThemeChromiumLinux::setRadioSize):
(WebCore::RenderThemeChromiumLinux::paintButton):
(WebCore::RenderThemeChromiumLinux::paintTextField):
(WebCore::RenderThemeChromiumLinux::paintMenuList):
(WebCore::RenderThemeChromiumLinux::paintSliderTrack):
(WebCore::RenderThemeChromiumLinux::paintSliderThumb):
(WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeChromiumLinux::paintInnerSpinButton):
(WebCore::RenderThemeChromiumLinux::paintProgressBar):
(WebCore::RenderThemeChromiumLinux::shouldOpenPickerWithF4Key):
* rendering/RenderThemeChromiumLinux.h: Added.
(WebCore):
(RenderThemeChromiumLinux):

Source/WebKit/chromium:

* WebKit.gyp:
* public/linux/WebRenderTheme.h: Added.
(WebKit):
* public/platform/linux/WebThemeEngine.h: Added.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setScrollbarColors):
(WebKit::WebViewImpl::setSelectionColors):
* src/linux/WebRenderTheme.cpp: Added.
(WebKit):
(WebKit::setCaretBlinkInterval):

Tools:

* Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd win8/* to Chromium DEPS (r171376)
tasak@google.com [Thu, 6 Dec 2012 07:46:31 +0000 (07:46 +0000)]
Add win8/* to Chromium DEPS (r171376)
https://bugs.webkit.org/show_bug.cgi?id=104228

Reviewed by Hajime Morita.

Since updated chromium DEPS to r171376, now printing/printing.gyp
requires win8/* for windows build.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Test expectation update
tkent@chromium.org [Thu, 6 Dec 2012 07:37:58 +0000 (07:37 +0000)]
[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=103869

* platform/chromium/TestExpectations:
Fix duplicated entries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Title of "Record Timeline" status button on "Timeline
commit-queue@webkit.org [Thu, 6 Dec 2012 07:28:05 +0000 (07:28 +0000)]
Web Inspector: Title of "Record Timeline" status button on "Timeline
Panel" should reflect the recording state.
https://bugs.webkit.org/show_bug.cgi?id=104108

Patch by Sankeerth V S <sankeerth.vs@samsung.com> on 2012-12-05
Reviewed by Alexander Pavlov.

Title should be toggled between "Record"/"Stop" to reflect current
state of the Status bar button.

No new tests as UI related change.

* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.get _toggleTimelineButtonClicked):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoINPUT_MULTIPLE_FIELDS_UI doesn't show digits well in RTL locales
tkent@chromium.org [Thu, 6 Dec 2012 07:10:22 +0000 (07:10 +0000)]
INPUT_MULTIPLE_FIELDS_UI doesn't show digits well in RTL locales
https://bugs.webkit.org/show_bug.cgi?id=103869

Reviewed by Hajime Morita.

Source/WebCore:

We need to use display:inline elements to wrap sub-fields and static
text in DateTimeEditElement children to apply the Unicode Bidi
Algorithm.

Because we can't use display:inline-block for them, we can't specify
min-width CSS property for them. We stop using customStyleForRenderer of
sub-fields to specify each of their widths, and use
customStyleForRenderer of DateTimeEditElement to specify the total
required width. A sub-field width shrink and grow so that the width fits
to the field value, and a DateTimeEditElement doesn't.

No new tests. Coverred by existing tests, especially
fast/forms/datetime/datetime-appearance-l10n.html shows "23:59"
correctly.

* css/html.css:
(input::-webkit-datetime-edit-year-field):
- Make this display:inline to apply the Unicode Bidi Algorithm.
- Use padding instead of margin because of ease of width computation.
  Also, the focus apparance gets better by padding.
- Don't allow to specify font property here because of ease of width
  computation.
- Remove text-align:center. It doesn't work for display:inline.
(input::-webkit-datetime-edit-text):
- Make this display:inline to apply the Unicode Bidi Algorithm.
- Don't allow to specify font property here because of ease of width
  computation.

* html/shadow/DateTimeEditElement.h:
(DateTimeEditElement): Declare customStyleForRenderer.
* html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::DateTimeEditElement):
Enable customStyleForRenderer.
(WebCore::DateTimeEditElement::customStyleForRenderer):
Compute required width with a font for this element and child maximum
widths, and set it to min-width style.
The resultant width value can be inaccurate if a page author specifies
padding, border, margin, etc. to ::-webkit-datetime-edit-*-field or
::-webkit-datetime-edit-text. In such case, the page author should specify
wider width to <input>.

* dom/Element.h:
(Element): Add isDateTimeFieldElement to do static_cast<DateTimeFieldElement> safely.
* dom/Element.cpp:
(WebCore::Element::isDateTimeFieldElement): Added.

* html/shadow/DateTimeFieldElement.h:
(DateTimeFieldElement): Declare isDateTimeFieldElement and maximumWidth.
* html/shadow/DateTimeFieldElement.cpp:
(WebCore::DateTimeFieldElement::isDateTimeFieldElement):
Added. Returns true.
(WebCore::DateTimeFieldElement::maximumWidth):
Added. Returns padding width.

* html/shadow/DateTimeSymbolicFieldElement.h:
(DateTimeSymbolicFieldElement):
Remove customStyleForRenderer, and declare maximumWidth.
* html/shadow/DateTimeSymbolicFieldElement.cpp:
(WebCore::DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement):
Disable customStyleForRenderer.
(WebCore::DateTimeSymbolicFieldElement::maximumWidth):
Added. Returns the expected maximum width with the specified font.

* html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement):
Remove customStyleForRenderer, declare maximumWidth, and make m_placeholder
non-const because it is updated in the constructor.
* html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
Disable customStyleForRenderer.
If a numeric value for this field is LTR and the whole direction is RTL,
wrap the placeholder string with left-to-right-mark and
right-to-left-mark so that it is handled as LTR. Without this,
sub-fields order would be changed when the content of a field is changed
from a placeholder to a numeric value.
(WebCore::DateTimeNumericFieldElement::maximumWidth):
Added. Returns the expected maximum width with the specified font.

LayoutTests:

- Year fields and month fields are shrunk because we stop specifying
  min-width.
- Focus rectangle for sub-fields get larger.

* fast/forms/date-multiple-fields/date-multiple-fields-mouse-events.html:
Need to update mouse click positions because we have some position/width
changes in sub-fields.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-mouse-events.html:
Ditto.
* fast/forms/month-multiple-fields/month-multiple-fields-mouse-events.html:
Ditto.
* platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium-mac/fast/forms/datetime/datetime-l10n-expected.png:
* platform/chromium-mac/fast/forms/month/month-appearance-basic-expected.png:
* platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-mac/fast/forms/week/week-appearance-basic-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd myself to watch changes in PerformanceTests/*.
rniwa@webkit.org [Thu, 6 Dec 2012 06:36:23 +0000 (06:36 +0000)]
Add myself to watch changes in PerformanceTests/*.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] DRT on Windows crashes when a testcase has a progress element in indetermi...
shinyak@chromium.org [Thu, 6 Dec 2012 06:33:10 +0000 (06:33 +0000)]
[Chromium] DRT on Windows crashes when a testcase has a progress element in indeterminate state
https://bugs.webkit.org/show_bug.cgi?id=102459

Reviewed by Dimitri Glazkov.

Tools:

Since WebThemeControlDRTWin::markState does not consider indeterminate state, DRT caused a crash.

* DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
(WebThemeControlDRTWin::markState):

LayoutTests:

* fast/dom/HTMLProgressElement/progress-element-indeterminate-crash-expected.txt: Added.
* fast/dom/HTMLProgressElement/progress-element-indeterminate-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Shadow] Performance tests for ShadowDOM distribution
shinyak@chromium.org [Thu, 6 Dec 2012 06:31:22 +0000 (06:31 +0000)]
[Shadow] Performance tests for ShadowDOM distribution
https://bugs.webkit.org/show_bug.cgi?id=103617

Reviewed by Dimitri Glazkov.

We would like to measure ShadowDOM distribution performance in various cases.
In this patch, we add performance tests for several distribution patterns.

* ShadowDOM/ContentReprojection.html: Added.
* ShadowDOM/DistributionWithMultipleShadowRoots.html: Added.
* ShadowDOM/LargeDistributionWithLayout.html: Added.
* ShadowDOM/MultipleInsertionPoints.html: Added.
* ShadowDOM/ShadowReprojection.html: Added.
* ShadowDOM/SmallDistributionWithLayout.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136805 268f45cc-cd09-0410-ab3c-d52691b4dbfc