2008-09-15  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff Garen.

        Inline code generation of eq_null/neq_null for CTI.  Uses vptr checking for
        StringObjectsThatAreMasqueradingAsBeingUndefined.  In the long run, the
        masquerading may be handled differently (through the StructureIDs - see bug
        #20823).

        >1% on v8-tests.

        * VM/CTI.cpp:
        (JSC::CTI::emitJumpSlowCaseIfIsJSCell):
        (JSC::CTI::privateCompileMainPass):
        (JSC::CTI::privateCompileSlowCases):
        * VM/CTI.h:
        * VM/Machine.cpp:
        (JSC::Machine::Machine):
        (JSC::Machine::cti_op_eq_null):
        (JSC::Machine::cti_op_neq_null):
        * VM/Machine.h:
        (JSC::Machine::doesMasqueradesAsUndefined):
        * kjs/JSWrapperObject.h:
        (JSC::JSWrapperObject::):
        (JSC::JSWrapperObject::JSWrapperObject):
        * kjs/StringObject.h:
        (JSC::StringObject::StringObject):
        * kjs/StringObjectThatMasqueradesAsUndefined.h:
        (JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-15  David Smith  <catfish.man@gmail.com>

        "Just do it"'d by Mark Rowe

        https://bugs.webkit.org/show_bug.cgi?id=20856
        Add missing license header

        * dom/NodeRenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-15  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Rubber-stamped by Oliver Hunt.

        r36427 broke CodeBlock::dump() by changing the number of arguments to
        op_construct without changing the code that prints it. This patch fixes
        it by printing the additional argument.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * VM/CodeBlock.cpp:
        (JSC::CodeBlock::dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-15  Dean Jackson  <dino@apple.com>

        Reviewed by Tim Hatcher.

        Add default constructor for ShadowData
        https://bugs.webkit.org/show_bug.cgi?id=20757

        Test: transitions/shadow.html

        * rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-15  Dean Jackson  <dino@apple.com>

        Reviewed by Tim Hatcher.

        RenderStyle should update keyframes.
        http://bugs.webkit.org/show_bug.cgi?id=20756

        * rendering/style/RenderStyle.cpp:
        (WebCore::StyleRareNonInheritedData::updateKeyframes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-15  Dean Jackson  <dino@apple.com>

        Reviewed by Tim Hatcher.

        Unnecessary ASSERT in ImplicitAnimation destructor.
        https://bugs.webkit.org/show_bug.cgi?id=20817

        * page/animation/ImplicitAnimation.cpp:
        (WebCore::ImplicitAnimation::~ImplicitAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit:

2008-09-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        Merge WebNetscapePluginStream into WebBaseNetscapePluginStream.

        * WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-09-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        Merge WebNetscapePluginStream into WebBaseNetscapePluginStream.

        * Plugins/WebBaseNetscapePluginStream.h:
        * Plugins/WebBaseNetscapePluginStream.mm:
        (-[WebBaseNetscapePluginStream initWithFrameLoader:]):
        (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
        (-[WebBaseNetscapePluginStream dealloc]):
        (-[WebBaseNetscapePluginStream finalize]):
        (-[WebBaseNetscapePluginStream start]):
        (-[WebBaseNetscapePluginStream stop]):
        (-[WebBaseNetscapePluginStream cancelLoadWithError:]):
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView pluginView:receivedResponse:]):
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
        * Plugins/WebNetscapePluginEmbeddedView.mm:
        * Plugins/WebNetscapePluginStream.h: Removed.
        * Plugins/WebNetscapePluginStream.mm: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Oops. Forgot this file in previous commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-15  Dean Jackson  <dino@apple.com>

        Reviewed by Tim Hatcher.

        Tests for -webkit-transform
        https://bugs.webkit.org/show_bug.cgi?id=20771

        * transforms/2d/compound-2d-transforms-expected.txt: Added.
        * transforms/2d/compound-2d-transforms.html: Added.
        * transforms/2d/compound-transforms-vs-containers.html: Added.
        * transforms/2d/transform-2d-expected.txt: Added.
        * transforms/2d/transform-2d.html: Added.
        * transforms/2d/transform-accuracy-expected.txt: Added.
        * transforms/2d/transform-accuracy.html: Added.
        * transforms/2d/transform-borderbox.html: Added.
        * transforms/2d/transform-origin-borderbox.html: Added.
        * transforms/2d/resources/transform-test-utils.js: Added.
        * platform/mac/transforms/2d/compound-transforms-vs-containers-expected.txt: Added.
        * platform/mac/transforms/2d/transform-borderbox-expected.txt: Added.
        * platform/mac/transforms/2d/transform-origin-borderbox-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix Win build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Simon.

Yahoo assumes non-RFC compliant HTTP redirect behaviour. QtWebKit is (more)
compliant, so broken. I think the Yahoo-assumed behaviour is real-world standard.

Basically, Yahoo's login procedure for flickr looks like this:
1. load flickr.com, click "sign in"
2. this is a Yahoo page with a form
(https://login.yahoo.com/config/login?.src=flickr...)
when you click the "Sign In" button, the form submits to a yahoo.com POST URL
3. The POST returns with a 302 (redirect) to another yahoo.com URL
4. If you POST the redirected Location:, it all breaks. Yahoo assumes you will
convert the method to GET, which works fine but is definitely not
RFC-compliant. It would be compliant for 303, and the RFC says that many
implementations treat 302 and 303 the same way (for HTTP/1.0 compliance), but
converting to GET is explicitly wrong for 302.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-15  Dean Jackson  <dino@apple.com>

        Reviewed by Tim Hatcher

        Tests for animations.
        https://bugs.webkit.org/show_bug.cgi?id=20789

        * animations/animation-test-helpers.js: Added.
        * animations/generic-from-to-expected.txt: Added.
        * animations/generic-from-to.html: Added.
        * animations/multiple-animations-expected.txt: Added.
        * animations/multiple-animations.html: Added.
        * animations/multiple-keyframes-expected.txt: Added.
        * animations/multiple-keyframes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Simon.

Fix plugin extension info. It was returning the mimetype where the
extension was given.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-15  Dean Jackson  <dino@apple.com>

        Reviewed by Tim Hatcher

        Coding style violation!!!! Cleanup AnimationBase.cpp

        * page/animation/AnimationBase.cpp:
        (WebCore::blendFunc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-15  David Hyatt  <hyatt@apple.com>

        Move all hit testing code for scrollbars into the base class.  Refactor
        it to accommodate all platform-specific behaviors using virtual ScrollbarTheme
        functions.

        No platform is using this code yet.  Although it has been moved and compiles
        (even on Mac), it is not being used on any platform.

        Reviewed by Sam Weinig

        * platform/ScrollBar.cpp:
        (WebCore::Scrollbar::autoscrollPressedPart):
        (WebCore::Scrollbar::startTimerIfNeeded):
        (WebCore::Scrollbar::handleMouseMoveEvent):
        (WebCore::Scrollbar::handleMouseOutEvent):
        (WebCore::Scrollbar::handleMouseReleaseEvent):
        (WebCore::Scrollbar::handleMousePressEvent):
        * platform/ScrollBar.h:
        (WebCore::Scrollbar::handleContextMenuEvent):
        * platform/ScrollbarTheme.h:
        (WebCore::ScrollbarTheme::hitTest):
        (WebCore::ScrollbarTheme::invalidateOnMouseEnterExit):
        (WebCore::ScrollbarTheme::invalidatePart):
        (WebCore::ScrollbarTheme::shouldCenterOnThumb):
        (WebCore::ScrollbarTheme::centerOnThumb):
        (WebCore::ScrollbarTheme::thumbPosition):
        (WebCore::ScrollbarTheme::thumbLength):
        (WebCore::ScrollbarTheme::trackLength):
        (WebCore::ScrollbarTheme::initialAutoscrollTimerDelay):
        (WebCore::ScrollbarTheme::autoscrollTimerDelay):
        * platform/Widget.h:
        (WebCore::Widget::parent):
        * platform/mac/PlatformScrollBar.h:
        (WebCore::PlatformScrollbar::handleMouseMoveEvent):
        (WebCore::PlatformScrollbar::handleMouseOutEvent):
        (WebCore::PlatformScrollbar::handleMousePressEvent):
        (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::convertFromContainingWindow):
        * platform/win/ScrollbarThemeWin.cpp:
        (WebCore::ScrollbarThemeWin::invalidateOnMouseEnterExit):
        * platform/win/ScrollbarThemeWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Sam Weinig.

        - fix <rdar://problem/5842247> Single long breakable word takes O(n^2) to lay out

        Cache the next breakable position for text nodes in InlineIterator.

        * rendering/bidi.cpp:
        (WebCore::InlineIterator::InlineIterator):
        (WebCore::InlineIterator::increment):
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-15  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein

        Fix assertion and integral pixel issue when creating subimages.
        https://bugs.webkit.org/show_bug.cgi?id=20786

        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Build fix

        * kjs/StructureID.cpp: Removed a stray semicolon.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-15  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon.

        Implment seek() and clean up and improve debugging output

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-15  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Simon.

        Remove bogus Q_ASSERTs from the MediaPlayer Phonon implementation

        m_mediaObject, m_audioOutput, m_videoWidget get created in the
        c'tor and will only be deleted in the c'tor. The Q_ASSERTs would
        only check if we use the MediaPlayerPrivate after it has been deleted.

Acked-by: Tor Arne Vestbø <tavestbo@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore:

2008-09-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Maciej.

        <rdar://problem/6163988>
        https://bugs.webkit.org/show_bug.cgi?id=20457
        Canvas: createPattern crashes WebKit in WTF::RefPtr<WebCore::Image>::operator!() const + 9 with a 1D pattern

        Check the width and height and throw an exception if any of them are 0.

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::createPattern):

LayoutTests:

2008-09-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Maciej.

        <rdar://problem/6163988>
        https://bugs.webkit.org/show_bug.cgi?id=20457
        Canvas: createPattern crashes WebKit in WTF::RefPtr<WebCore::Image>::operator!() const + 9 with a 1D pattern

        Add test for createPattern where the canvas passed in has a zero height/width.

        * fast/canvas/canvas-with-incorrect-args-expected.txt:
        * fast/canvas/canvas-with-incorrect-args.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-15  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon.

        Render media element controls with antialiasing enabled

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-15  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Upon non fatal error, switch to the pause state (so that playback can continue)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-15  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon.

        Don't set WTF_USE_JSC in WebCore.pro now that it's set in config.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-15  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon.

        Make QtInstance::create() private and fix caching

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-15  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej Stachowiak.

        Fix a crash in fast/js/exception-expression-offset.html caused by not
        updating all mentions of the length of op_construct in r36427.

        * VM/Machine.cpp:
        (JSC::Machine::cti_op_construct_NotJSConstruct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-15  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Cameron Zwarich.

        - fix layout test failure introduced by fix for 20849

        (The failing test was fast/js/delete-then-put.html)

        * kjs/JSObject.cpp:
        (JSC::JSObject::removeDirect): Clear enumeration cache
        in the dictionary case.
        * kjs/JSObject.h:
        (JSC::JSObject::putDirect): Ditto.
        * kjs/StructureID.h:
        (JSC::StructureID::clearEnumerationCache): Inline to handle the
        clear.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-15  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Cameron Zwarich.

        - fix JSC test failures introduced by fix for 20849

        * kjs/PropertyMap.cpp:
        (JSC::PropertyMap::getEnumerablePropertyNames): Use the correct count.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-15  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej Stachowiak.

        Bug 20851: REGRESSION (r36410): fast/js/kde/GlobalObject.html fails
        <https://bugs.webkit.org/show_bug.cgi?id=20851>

        r36410 introduced an optimization for parseInt() that is incorrect when
        its argument is larger than the range of a 32-bit integer. If the
        argument is a number that is not an immediate integer, then the correct
        behaviour is to return the floor of its value, unless it is an infinite
        value, in which case the correct behaviour is to return 0.

        JavaScriptCore:

        * kjs/JSGlobalObjectFunctions.cpp:
        (JSC::globalFuncParseInt):

        LayoutTests:

        * fast/js/numeric-conversion-expected.txt:
        * fast/js/resources/numeric-conversion.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix Qt build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-15  David Smith  <catfish.man@gmail.com>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=20180

        >2x speedup on querySelector[All] with :nth-child by removing the collectRulesOnly argument on SelectorChecker.
        With collectRulesOnly set to true (the default) an optimization is turned off, and no callers were intentionally leaving it true.
        querySelector[All] assumed that the default was probably the right way to go, and so ended up being slow.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::CSSStyleSelector):
        (WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker):
        * css/CSSStyleSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Make sure ScrollbarThemeQt.cpp accurately reflects copyright information, since it contains code from PlatformScrollbarQt.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix Qt build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-15  Sam Weinig  <sam@webkit.org>

        Reviewed by Maciej Stachowiak.

        Patch for https://bugs.webkit.org/show_bug.cgi?id=20849
        Cache property names for getEnumerablePropertyNames in the StructureID.

        ~0.5% speedup on Sunspider overall (9.7% speedup on string-fasta).  ~1% speedup
        on the v8 test suite.

        * kjs/JSObject.cpp:
        (JSC::JSObject::getPropertyNames):
        * kjs/PropertyMap.cpp:
        (JSC::PropertyMap::getEnumerablePropertyNames):
        * kjs/PropertyMap.h:
        * kjs/StructureID.cpp:
        (JSC::StructureID::StructureID):
        (JSC::StructureID::getEnumerablePropertyNames):
        * kjs/StructureID.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Refactor painting of the native windows scrollbar and prepare for code sharing with the Aqua windows scrollbar.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-14  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Cameron Zwarich.

        - speed up JS construction by extracting "prototype" lookup so PIC applies.

        ~0.5% speedup on SunSpider
        Speeds up some of the V8 tests as well, most notably earley-boyer.

        * VM/CTI.cpp:
        (JSC::CTI::compileOpCall): Account for extra arg for prototype.
        (JSC::CTI::privateCompileMainPass): Account for increased size of op_construct.
        * VM/CodeGenerator.cpp:
        (JSC::CodeGenerator::emitConstruct): Emit separate lookup to get prototype property.
        * VM/Machine.cpp:
        (JSC::Machine::privateExecute): Expect prototype arg in op_construct.
        (JSC::Machine::cti_op_construct_JSConstruct): ditto
        (JSC::Machine::cti_op_construct_NotJSConstruct): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Moving all resource graphs under the same container for future scalable feature.
        This is a speedup on resize but maybe a loss on changing the sorting function.

        https://bugs.webkit.org/show_bug.cgi?id=20555

        Reviewed by Timothy Hatcher.

        * page/inspector/ResourcesPanel.js: Added a container for all resource graphs.
        Added WebInspector.ResourceGraph. No more _updateGraphBars on resize.
        * page/inspector/inspector.css: Edited corresponding rules and removed unnecessaries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Eric Seidel.

        Add a protected destructor for RefCounted.

        It is wrong to call its destructor directly, because (1) this should be taken care of by
        deref(), and (2) many classes that use RefCounted have non-virtual destructors.

        No change in behavior.

        * wtf/RefCounted.h: (WTF::RefCounted::~RefCounted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix Qt bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=20738
        compareBoundaryPoints gives incorrect results

        Test: fast/dom/Range/compareBoundaryPoints-2.html

        * dom/Range.cpp: (WebCore::Range::compareBoundaryPoints): Correct meanings of START_TO_END
        and END_TO_START.
        * page/DOMSelection.cpp: (WebCore::DOMSelection::addRange): Updated for this change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-14  Maciej Stachowiak  <mjs@apple.com>

        Unreviewed build fix.

        Trying again.

        * bindings/js/JSQuarantinedObjectWrapper.cpp:
        (WebCore::JSQuarantinedObjectWrapper::hasInstance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-14  Maciej Stachowiak  <mjs@apple.com>

        Unreviewed build fix.

        Blind attempt to fix build. Correct parameters for hasInstance.

        * bindings/js/JSQuarantinedObjectWrapper.cpp:
        (WebCore::JSQuarantinedObjectWrapper::hasInstance):
        * bindings/js/JSQuarantinedObjectWrapper.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore:

        Rubber-stamped by Sam Weinig.

        - revert <http://trac.webkit.org/changeset/36382> because it exposed
          <https://bugs.webkit.org/show_bug.cgi?id=20846> and resulted in crashes
          on Tiger.

        * platform/graphics/mac/FontCacheMac.mm:
        (WebCore::FontCache::getFontDataForCharacters):
        (WebCore::FontCache::getLastResortFallbackFont):

LayoutTests:

        Rubber-stamped by Sam Weinig.

        - revert <http://trac.webkit.org/changeset/36382> because it exposed
          <https://bugs.webkit.org/show_bug.cgi?id=20846> and resulted in crashes
          on Tiger.

        * platform/mac/fast/text/last-resort-font-expected.checksum: Removed.
        * platform/mac/fast/text/last-resort-font-expected.png: Removed.
        * platform/mac/fast/text/last-resort-font-expected.txt: Removed.
        * platform/mac/fast/text/last-resort-font.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Now with all new and improved Changelog in the correct order.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-14  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Cameron Zwarich.

        - split the "prototype" lookup for hasInstance into opcode stream so it can be cached

        ~5% speedup on v8 earley-boyer test

        * API/JSCallbackObject.h: Add a parameter for the pre-looked-up prototype.
        * API/JSCallbackObjectFunctions.h:
        (JSC::::hasInstance): Ditto.
        * API/JSValueRef.cpp:
        (JSValueIsInstanceOfConstructor): Look up and pass in prototype.
        * JavaScriptCore.exp:
        * VM/CTI.cpp:
        (JSC::CTI::privateCompileMainPass): Pass along prototype.
        * VM/CodeBlock.cpp:
        (JSC::CodeBlock::dump): Print third arg.
        * VM/CodeGenerator.cpp:
        (JSC::CodeGenerator::emitInstanceOf): Implement this, now that there
        is a third argument.
        * VM/CodeGenerator.h:
        * VM/Machine.cpp:
        (JSC::Machine::privateExecute): Pass along the prototype.
        (JSC::Machine::cti_op_instanceof): ditto
        * kjs/JSObject.cpp:
        (JSC::JSObject::hasInstance): Expect to get a pre-looked-up prototype.
        * kjs/JSObject.h:
        * kjs/nodes.cpp:
        (JSC::InstanceOfNode::emitCode): Emit a get_by_id of the prototype
        property and pass that register to instanceof.
        * kjs/nodes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-14  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Cameron Zwarich.

        - split the "prototype" lookup for hasInstance into opcode stream so it can be cached

        ~5% speedup on v8 earley-boyer test

        * API/JSCallbackObject.h: Add a parameter for the pre-looked-up prototype.
        * API/JSCallbackObjectFunctions.h:
        (JSC::::hasInstance): Ditto.
        * API/JSValueRef.cpp:
        (JSValueIsInstanceOfConstructor): Look up and pass in prototype.
        * JavaScriptCore.exp:
        * VM/CTI.cpp:
        (JSC::CTI::privateCompileMainPass): Pass along prototype.
        * VM/CodeBlock.cpp:
        (JSC::CodeBlock::dump): Print third arg.
        * VM/CodeGenerator.cpp:
        (JSC::CodeGenerator::emitInstanceOf): Implement this, now that there
        is a third argument.
        * VM/CodeGenerator.h:
        * VM/Machine.cpp:
        (JSC::Machine::privateExecute): Pass along the prototype.
        (JSC::Machine::cti_op_instanceof): ditto
        * kjs/JSObject.cpp:
        (JSC::JSObject::hasInstance): Expect to get a pre-looked-up prototype.
        * kjs/JSObject.h:
        * kjs/nodes.cpp:
        (JSC::InstanceOfNode::emitCode): Emit a get_by_id of the prototype
        property and pass that register to instanceof.
        * kjs/nodes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Add ScrollbarThemeComposite for use by ScrollbarThemeSafari and ScrollbarThemeWin

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix Qt build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix Win build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-14  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Sam Weinig.

        Remove unnecessary virtual function call from cti_op_call_JSFunction -
        ~5% on richards, ~2.5% on v8-tests, ~0.5% on sunspider.

        * VM/Machine.cpp:
        (JSC::Machine::cti_op_call_JSFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-14  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej Stachowiak.

        Bug 20827: the 'typeof' operator is slow
        <https://bugs.webkit.org/show_bug.cgi?id=20827>

        Optimize the 'typeof' operator when its result is compared to a constant
        string.

        This is a 5.5% speedup on the V8 Earley-Boyer test.

        JavaScriptCore:

        * VM/CTI.cpp:
        (JSC::CTI::privateCompileMainPass):
        * VM/CodeBlock.cpp:
        (JSC::CodeBlock::dump):
        * VM/CodeGenerator.cpp:
        (JSC::CodeGenerator::emitEqualityOp):
        * VM/CodeGenerator.h:
        * VM/Machine.cpp:
        (JSC::jsIsObjectType):
        (JSC::jsIsFunctionType):
        (JSC::Machine::privateExecute):
        (JSC::Machine::cti_op_is_undefined):
        (JSC::Machine::cti_op_is_boolean):
        (JSC::Machine::cti_op_is_number):
        (JSC::Machine::cti_op_is_string):
        (JSC::Machine::cti_op_is_object):
        (JSC::Machine::cti_op_is_function):
        * VM/Machine.h:
        * VM/Opcode.h:
        * kjs/nodes.cpp:
        (JSC::BinaryOpNode::emitCode):
        (JSC::EqualNode::emitCode):
        (JSC::StrictEqualNode::emitCode):
        * kjs/nodes.h:

        LayoutTests:

        * fast/js/resources/typeof-codegen-crash.js: Added.
        * fast/js/typeof-codegen-crash-expected.txt: Added.
        * fast/js/typeof-codegen-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-14  Alp Toker  <alp@nuanti.com>

        https://bugs.webkit.org/show_bug.cgi?id=20320
        [GTK] A white rectangle is visible behind widgets with rounded corners

        Sync bundled gtk2drawing.c to the latest version from Mozilla (coding
        style exempt).

        Requested by Michael Monreal.

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::RenderThemeGtk):
        * platform/gtk/gtk2drawing.c:
        (moz_gtk_set_widget_name):
        (ensure_window_widget):
        (setup_widget_prototype):
        (ensure_button_arrow_widget):
        (moz_gtk_get_combo_box_inner_button):
        (moz_gtk_get_combo_box_button_inner_widgets):
        (ensure_combo_box_widgets):
        (moz_gtk_get_combo_box_entry_inner_widgets):
        (moz_gtk_get_combo_box_entry_arrow):
        (ensure_combo_box_entry_widgets):
        (ensure_toolbar_widget):
        (ensure_tooltip_widget):
        (ensure_menu_bar_widget):
        (ensure_menu_bar_item_widget):
        (ensure_menu_popup_widget):
        (ensure_menu_item_widget):
        (ensure_image_menu_item_widget):
        (ensure_menu_separator_widget):
        (ensure_check_menu_item_widget):
        (ensure_tree_header_cell_widget):
        (ensure_scrolled_window_widget):
        (moz_gtk_button_paint):
        (moz_gtk_init):
        (moz_gtk_button_get_inner_border):
        (moz_gtk_toggle_paint):
        (calculate_button_inner_rect):
        (calculate_arrow_rect):
        (moz_gtk_scrollbar_button_paint):
        (moz_gtk_scrollbar_thumb_paint):
        (moz_gtk_caret_paint):
        (moz_gtk_entry_paint):
        (moz_gtk_treeview_paint):
        (moz_gtk_tree_header_cell_paint):
        (moz_gtk_combo_box_paint):
        (moz_gtk_downarrow_paint):
        (moz_gtk_combo_box_entry_button_paint):
        (moz_gtk_toolbar_paint):
        (moz_gtk_tab_scroll_arrow_paint):
        (moz_gtk_menu_bar_paint):
        (moz_gtk_menu_item_paint):
        (moz_gtk_get_widget_border):
        (moz_gtk_get_combo_box_entry_button_size):
        (moz_gtk_get_tab_scroll_arrow_size):
        (moz_gtk_get_downarrow_size):
        (moz_gtk_images_in_menus):
        (moz_gtk_widget_paint):
        (moz_gtk_shutdown):
        * platform/gtk/gtkdrawing.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-14  Sam Weinig  <sam@webkit.org>

        Reviewed by Cameron Zwarich.

        Patch for https://bugs.webkit.org/show_bug.cgi?id=20844
        Speed up parseInt for numbers

        Sunspider reports this as 1.029x as fast overall and 1.37x as fast on string-unpack-code.
        No change on the v8 suite.

        * kjs/JSGlobalObjectFunctions.cpp:
        (JSC::globalFuncParseInt): Don't convert numbers to strings just to
        convert them back to numbers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-14  David Hyatt  <hyatt@apple.com>

        Convert Mac, Gtk, wx and Qt over to the new ScrollbarTheme for
        painting.  Mac and Gtk themes don't do anything and just let the
        underlying widget paint.  Qt now uses the theme to paint.  wx doesn't
        do anything yet.

        Reviewed by Sam Weinig

        * platform/ScrollBar.cpp:
        (WebCore::Scrollbar::paint):
        * platform/ScrollBar.h:
        (WebCore::Scrollbar::value):
        (WebCore::Scrollbar::visibleSize):
        (WebCore::Scrollbar::maximum):
        (WebCore::Scrollbar::lineStep):
        (WebCore::Scrollbar::pageStep):
        (WebCore::Scrollbar::pixelStep):
        (WebCore::Scrollbar::pressedPart):
        (WebCore::Scrollbar::hoveredPart):
        (WebCore::Scrollbar::theme):
        * platform/ScrollbarTheme.h:
        (WebCore::ScrollbarTheme::paint):
        (WebCore::ScrollbarTheme::scrollbarThickness):
        (WebCore::ScrollbarTheme::supportsControlTints):
        (WebCore::ScrollbarTheme::themeChanged):
        * platform/gtk/PlatformScrollBar.h:
        * platform/gtk/PlatformScrollBarGtk.cpp:
        * platform/mac/PlatformScrollBar.h:
        * platform/mac/PlatformScrollBarMac.mm:
        * platform/qt/PlatformScrollBar.h:
        * platform/qt/PlatformScrollBarQt.cpp:
        * platform/qt/ScrollbarThemeQt.cpp:
        (WebCore::styleOptionSlider):
        * platform/qt/ScrollbarThemeQt.h:
        (WebCore::ScrollbarThemeQt::paint):
        * platform/win/PlatformScrollBarSafari.cpp:
        (WebCore::PlatformScrollbar::paint):
        * platform/win/ScrollbarThemeSafari.h:
        (WebCore::ScrollbarThemeSafari::supportsControlTints):
        * platform/wx/PlatformScrollBar.h:
        * platform/wx/TemporaryLinkStubs.cpp:
        (PlatformScrollbar::~PlatformScrollbar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-14  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver Hunt.

        Bug 20816: op_lesseq should be optimized
        <https://bugs.webkit.org/show_bug.cgi?id=20816>

        Add a loop_if_lesseq opcode that is similar to the loop_if_less opcode.

        This is a 9.4% speedup on the V8 Crypto benchmark.

        * VM/CTI.cpp:
        (JSC::CTI::privateCompileMainPass):
        (JSC::CTI::privateCompileSlowCases):
        * VM/CodeBlock.cpp:
        (JSC::CodeBlock::dump):
        * VM/CodeGenerator.cpp:
        (JSC::CodeGenerator::emitJumpIfTrue):
        * VM/Machine.cpp:
        (JSC::Machine::privateExecute):
        (JSC::Machine::cti_op_loop_if_lesseq):
        * VM/Machine.h:
        * VM/Opcode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-14  Sam Weinig  <sam@webkit.org>

        Qt build fix.

        * platform/qt/PlatformScrollBarQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

JavaScriptCore:

2008-09-14  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Remove extraneous semicolons.

        * kjs/nodes.cpp:
        (JSC::PrefixResolveNode::emitCode):
        * wtf/FastMalloc.cpp:
        (WTF::TCMalloc_PageHeap::GrowHeap):

WebCore:

2008-09-14  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Remove extraneous semicolons.

        * bindings/scripts/CodeGeneratorObjC.pm:
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::tokenizeRelAttribute):
        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::charsetAttributeValue):
        (WebCore::HTMLScriptElement::typeAttributeValue):
        * platform/graphics/qt/GradientQt.cpp:
        (WebCore::Gradient::platformGradient):
        * platform/qt/ScrollViewQt.cpp:
        (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::updateScrollbars):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintEllipsisBoxes):
        * svg/SVGPathSegList.cpp:
        (WebCore::SVGPathSegList::toPathData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-14  Sam Weinig  <sam@webkit.org>

        Qt build fix.

        * platform/qt/ScrollViewQt.cpp:
        (WebCore::ScrollView::updateScrollbars):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-14  Sam Weinig  <sam@webkit.org>

        Qt build fix.

        * platform/qt/PlatformScrollBarQt.cpp:
        (WebCore::PlatformScrollbar::PlatformScrollbar):
        (WebCore::PlatformScrollbar::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-14  Sam Weinig  <sam@webkit.org>

        Reviewed by Cameron Zwarich.

        Cleanup Sampling code.

        * VM/CTI.cpp:
        (JSC::CTI::emitCall):
        (JSC::CTI::privateCompileMainPass):
        * VM/CTI.h:
        (JSC::CTI::execute):
        * VM/SamplingTool.cpp:
        (JSC::):
        (JSC::SamplingTool::run):
        (JSC::SamplingTool::dump):
        * VM/SamplingTool.h:
        (JSC::SamplingTool::callingHostFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Bug 20821: Cache property transitions to speed up object initialization
https://bugs.webkit.org/show_bug.cgi?id=20821

Reviewed by Cameron Zwarich.

Implement a transition cache to improve the performance of new properties
being added to objects.  This is extremely beneficial in constructors and
shows up as a 34% improvement on access-binary-trees in SunSpider (0.8%
overall)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix Qt bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix Windows bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix Mac build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-13  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Gtk build fix, not reviewed.

        * platform/gtk/PlatformScrollBarGtk.cpp:
        (PlatformScrollbar::PlatformScrollbar):
        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollView::updateScrollbars):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Eliminate Scrollbar's setRect method.  Clients can now just use the Widget base class method, setFrameGeometry instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Remove setEnabled from all Scrollbar subclasses that were just using their Widget base class methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Remove width()/height() from Scrollbar and subclasses that just need to use the Widget method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Remove now unused methods from GTK scrollbars.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Remove now unused methods from GTK scrollbars.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Move stopTimerIfNeeded out of PlatformScrollbar destructors and into Scrollbar's destructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix Qt build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-13  David Hyatt  <hyatt@apple.com>

        Move maximum() from Qt's PlatformScrollbar to be a cross-platform
        function on Scrollbar.  Fixes Qt build bustage.

        Reviewed by Sam Weinig

        * platform/ScrollBar.h:
        (WebCore::Scrollbar::orientation):
        (WebCore::Scrollbar::value):
        (WebCore::Scrollbar::maximum):
        * platform/qt/PlatformScrollBar.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix Qt bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix wx bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix Qt bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix Qt, Gtk, and Mac build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix Qt bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix Mac bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore:

        Reviewed by Sam Weinig.

        - use the LastResort font for missing glyphs instead of showing the
          primary font's missing glyph

        Test: platform/mac/fast/text/last-resort-font.html

        * platform/graphics/mac/FontCacheMac.mm:
        (WebCore::FontCache::getFontDataForCharacters): Changed to return the
        last resort font if a substitute font cannot be found.
        (WebCore::FontCache::getLastResortFallbackFont): Removed an outdated
        comment (the user's preferred standard font is included in the search
        thanks to code in FontCache::getFontData()) and changed to return the
        LastResort font.

LayoutTests:

        Reviewed by Sam Weinig.

        - test that the LastResort font is used for missing glyphs rather than
          the primary font's missing glyph

        * platform/mac/fast/text/last-resort-font-expected.checksum: Added.
        * platform/mac/fast/text/last-resort-font-expected.png: Added.
        * platform/mac/fast/text/last-resort-font-expected.txt: Added.
        * platform/mac/fast/text/last-resort-font.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Add ScrollbarTheme to control scrollbar metrics (and eventually hit testing and rendering.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Add ScrollbarTheme to control scrollbar metrics (and eventually hit testing and rendering.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-13  Adrien Nader  <camaradetux@gmail.com>

        Gtk build fix, not reviewed.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

<rdar://problem/5060439> Web elements should have an AXTopLevelUIElement

expose AXTopLevelUIElement as an attribute

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix Qt build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix wx build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix Qt build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Timothy Hatcher.

        - fix <rdar://problem/6171280> REGRESSION (r35667): Assertion failure in WebCore::FrameView::scheduleRelayout() when releasing a page with counters from the b/f cache

        No regression test because the back/forward cache is disabled in DumpRenderTree

        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::invalidateCounters): Bail out if the document
        is being destroyed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix Mac build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix Qt build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

wx build fixes for new methods recently introduced.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

more scrollbar refactoring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

More scrollbar refactoring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-09-12  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej Stachowiak.

        Bug 20819: JSValue::isObject() is slow
        <https://bugs.webkit.org/show_bug.cgi?id=20819>

        Optimize JSCell::isObject() and JSCell::isString() by making them
        non-virtual calls that rely on the StructureID type information.

        This is a 0.7% speedup on SunSpider and a 1.0% speedup on the V8
        benchmark suite.

        * JavaScriptCore.exp:
        * kjs/JSCell.cpp:
        * kjs/JSCell.h:
        (JSC::JSCell::isObject):
        (JSC::JSCell::isString):
        * kjs/JSObject.cpp:
        * kjs/JSObject.h:
        * kjs/JSString.cpp:
        * kjs/JSString.h:
        (JSC::JSString::JSString):
        * kjs/StructureID.h:
        (JSC::StructureID::type):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Fix Mac build.

        * css/CSSStyleSelector.cpp:
        (WebCore::getTransformOperationType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix Windows build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Cleaning up LayoutTests/ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Cleaning up WebCore/ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Roll out r36360 as it broke all non-Mac builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36363 268f45cc-cd09-0410-ab3c-d52691b4dbfc