WebKit-https.git
8 years agoRemove [LegacyParent] from CodeGeneratorGObject.pm, and rename it to [JSLegacyParent]
haraken@chromium.org [Fri, 3 Feb 2012 09:54:53 +0000 (09:54 +0000)]
Remove [LegacyParent] from CodeGeneratorGObject.pm, and rename it to [JSLegacyParent]
https://bugs.webkit.org/show_bug.cgi?id=77706

Reviewed by Adam Barth.

This patch removes dead code about [LegacyParent] from CodeGeneratorGObject.pm,
and renames [LegacyParent] to [JSLegacyParent].

No tests. No changes in behavior.

* bindings/scripts/CodeGeneratorGObject.pm:
(Generate):
* bindings/scripts/CodeGeneratorJS.pm:
(GetParentClassName):
(GenerateHeader):
(GenerateImplementation):
* page/DOMWindow.idl:
* workers/WorkerContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: preserve elements panel selection upon node drag'n'drop
pfeldman@chromium.org [Fri, 3 Feb 2012 09:28:00 +0000 (09:28 +0000)]
Web Inspector: preserve elements panel selection upon node drag'n'drop
https://bugs.webkit.org/show_bug.cgi?id=77722

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/elements/move-node.html

* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype._markRevision):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._ondrop):
(WebInspector.ElementsTreeOutline.prototype._doMove.callback):
(WebInspector.ElementsTreeOutline.prototype._doMove):

LayoutTests:

* inspector/elements/move-node-expected.txt: Added.
* inspector/elements/move-node.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Reimplement DETAILS and SUMMARY using selector query.
commit-queue@webkit.org [Fri, 3 Feb 2012 08:30:59 +0000 (08:30 +0000)]
Source/WebCore:        Reimplement DETAILS and SUMMARY using selector query.
https://bugs.webkit.org/show_bug.cgi?id=75930

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-03
Reviewed by Hajime Morita.

DETAILS is reimplemented using content element and its fallback feature.
We don't need to recreate DOM even if SUMMARY is removed from or added into DETAILS.

No new tests, should be covered by existing tests.

* html/HTMLDetailsElement.cpp:
(WebCore::DetailsSummaryElement::fallbackSummary):
  Takes fallback element of content summary.
(DetailsSummaryElement):
(WebCore::DetailsSummaryElement::create):
  Creates a fallback element also.
(WebCore):
(WebCore::HTMLDetailsElement::create):
(WebCore::HTMLDetailsElement::HTMLDetailsElement):
(WebCore::HTMLDetailsElement::createShadowSubtree):
(WebCore::HTMLDetailsElement::findMainSummary):
(WebCore::HTMLDetailsElement::parseMappedAttribute):
(WebCore::HTMLDetailsElement::childShouldCreateRenderer):
(WebCore::HTMLDetailsElement::toggleOpen):
* html/HTMLDetailsElement.h:
(HTMLDetailsElement):
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::isMainSummary):

LayoutTests: Reimplement DETAILS and SUMMARY using selector query.
https://bugs.webkit.org/show_bug.cgi?id=75930

Since the implementation of DETAILS shadow tree, the path of caret position is also changed.

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-03
Reviewed by Hajime Morita.

* platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
* platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash when trying to add a timer to a detached document.
jochen@chromium.org [Fri, 3 Feb 2012 08:19:06 +0000 (08:19 +0000)]
Crash when trying to add a timer to a detached document.
https://bugs.webkit.org/show_bug.cgi?id=77692

Reviewed by Alexey Proskuryakov.

In http://webkit.org/b/77370, a timer is fired on a detached document.
Since a document clears all timers when it is detached, and it
shouldn't be possible to add a timer to a detached document, we crash
if this should happen anyway. This will hopefully result in an easier
to debug crash dump.

* page/DOMTimer.cpp:
(WebCore::DOMTimer::DOMTimer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStop calling Element::ensureShadowRoot in Internals.
commit-queue@webkit.org [Fri, 3 Feb 2012 08:16:33 +0000 (08:16 +0000)]
Stop calling Element::ensureShadowRoot in Internals.
https://bugs.webkit.org/show_bug.cgi?id=77612

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-03
Reviewed by Hajime Morita.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

We want to check a shadow root is built-in or created by users to support multiple shadow subtrees.
But Element::ensureShadowRoot() makes it difficult, because it doesn't care about the returning shadow element
is built-in or user generated, so let's remove Element::ensureShadowRoot().

As a first step, this patch removes ensureShadowRoot() in Internals.

No new tests, because no changes in behavior.

* WebCore.exp.in:
* testing/Internals.cpp:
(WebCore::Internals::ensureShadowRoot):

Source/WebKit2:

Exports symbols.

* win/WebKit2.def:
* win/WebKit2CFLite.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<http://webkit.org/b/77717> Makefile should provide control over output verbosity
mrowe@apple.com [Fri, 3 Feb 2012 07:44:38 +0000 (07:44 +0000)]
<webkit.org/b/77717> Makefile should provide control over output verbosity

Allow the filtering of the output of our Makefile to be configured via a user default
and overriden via a command-line argument to make.

The Makefile takes the verbosity from BuildTranscriptVerbosity default in the
org.webkit.BuildConfiguration domain. The supported values are "default", "quiet"
and "noisy". "default" maintains the existing behavior of only filtering out
the setenv lines from Xcode's shell script build phases. "quiet" filters all output
through filter-build-webkit. "noisy" provides unfiltered output. The verbosity can
be overriden for a single invocation of make by specifying the VERBOSITY variable
on the make command line.

To always get full output:
defaults write org.webkit.BuildConfiguration BuildTranscriptVerbosity noisy

To always get filtered ouptut:
defaults write org.webkit.BuildConfiguration BuildTranscriptVerbosity quiet

To get full output for a single build:
make VERBOSITY=noisy

Reviewed by Dan Bernstein.

* Makefile.shared:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Always show percents together with counters in heap inspector.
commit-queue@webkit.org [Fri, 3 Feb 2012 07:37:09 +0000 (07:37 +0000)]
Web Inspector: Always show percents together with counters in heap inspector.
https://bugs.webkit.org/show_bug.cgi?id=77434

Source/WebCore:

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-02
Reviewed by Pavel Feldman.

* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype._toPercentString):
(WebInspector.HeapSnapshotGridNode.prototype._createValueCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.createCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotConstructorNode.prototype.createCell):
(WebInspector.HeapSnapshotConstructorNode.prototype.get data):
(WebInspector.HeapSnapshotDiffNode.prototype.get data):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotContainmentDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotDiffDataGrid):
(WebInspector.HeapSnapshotDominatorsDataGrid):
(WebInspector.DetailedHeapshotView.prototype._mouseDownInContentsGrid):
(WebInspector.DetailedHeapshotView.prototype.get _isShowingAsPercent):
(WebInspector.DetailedHeapshotView.prototype._percentClicked):
* inspector/front-end/heapProfiler.css:
(.detailed-heapshot-view .data-grid span.percent-column):

LayoutTests:

Added parseInt conversion as counters are now strings not ints.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-02-02
Reviewed by Pavel Feldman.

* inspector/profiler/detailed-heapshots-comparison-show-all.html:
* inspector/profiler/detailed-heapshots-comparison-show-next.html:
* inspector/profiler/detailed-heapshots-summary-show-all.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse content-language from http-equiv to set document locale and font
commit-queue@webkit.org [Fri, 3 Feb 2012 07:30:20 +0000 (07:30 +0000)]
Use content-language from http-equiv to set document locale and font
https://bugs.webkit.org/show_bug.cgi?id=76701

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-02-02
Reviewed by Darin Adler.

Source/WebCore:

So far, only content-language set through http-equiv is used; the HTTP Content-Language
header is not yet supported.

Tests: fast/text/content-language-case-insensitivity.html
       fast/text/content-language-mapped-to-webkit-locale.html
       fast/text/international/content-language-font-selection-expected.html
       fast/text/international/content-language-font-selection.html
       fast/text/international/content-language-with-subtags-expected.html
       fast/text/international/content-language-with-subtags.html

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForDocument): Use content language when selecting initial font.
* dom/Document.cpp:
(WebCore::Document::setContentLanguage): Recalculate style so language is taken into account.
(WebCore):
* dom/Document.h:
(Document):

LayoutTests:

Add tests that content-language from http-equiv sets document locale and is used in font selection.

* fast/text/content-language-case-insensitivity-expected.txt: Added.
* fast/text/content-language-case-insensitivity.html: Added.
* fast/text/content-language-mapped-to-webkit-locale-expected.txt: Added.
* fast/text/content-language-mapped-to-webkit-locale.html: Added.
* fast/text/international/content-language-font-selection-expected.html: Added.
* fast/text/international/content-language-font-selection.html: Added.
* fast/text/international/content-language-with-subtags-expected.html: Added.
* fast/text/international/content-language-with-subtags.html: Added.
* fast/text/lang-mapped-to-webkit-locale-expected.txt:
* fast/text/lang-mapped-to-webkit-locale.xhtml: Fix some style issues.
* fast/text/xml-lang-ignored-in-html-expected.txt:
* fast/text/xml-lang-ignored-in-html.html: Fix some style issues.
* platform/efl/Skipped: Skip tests using overridePreference("WebKit*FontMap"...) on non-Chromium ports.
* platform/gtk-wk2/Skipped: Ditto.
* platform/gtk/Skipped: Ditto.
* platform/mac/Skipped: Ditto.
* platform/qt/Skipped: Ditto.
* platform/win/Skipped: Ditto.
* platform/wincairo/Skipped: Ditto.
* platform/wk2/Skipped: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening after r106554.
ossy@webkit.org [Fri, 3 Feb 2012 07:12:45 +0000 (07:12 +0000)]
[Qt] Unreviewed gardening after r106554.

* platform/qt/Skipped: Skip one more failing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r106620.
ossy@webkit.org [Fri, 3 Feb 2012 06:59:53 +0000 (06:59 +0000)]
Unreviewed, rolling out r106620.
http://trac.webkit.org/changeset/106620
https://bugs.webkit.org/show_bug.cgi?id=77716

It broke non ENABLE(3D_RENDERING) builds (Requested by
Ossy_morning on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-02

Source/WebCore:

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* platform/graphics/GraphicsContext.h:
(WebCore):
(GraphicsContext):
* platform/graphics/cairo/TextureMapperCairo.cpp:
(WebCore::TextureMapper::create):
(WebCore):
* platform/graphics/opengl/TextureMapperGL.cpp:
(Entry):
(DirectlyCompositedImageRepository):
(WebCore::TextureMapperGLData::DirectlyCompositedImageRepository::findOrCreate):
(WebCore::TextureMapperGLData::DirectlyCompositedImageRepository::deref):
(WebCore::TextureMapperGLData::DirectlyCompositedImageRepository::DirectlyCompositedImageRepository):
(WebCore::TextureMapperGLData::DirectlyCompositedImageRepository::~DirectlyCompositedImageRepository):
(TextureMapperGLData):
(BitmapTextureGL):
(WebCore::BitmapTextureGL::isOpaque):
(WebCore::BitmapTextureGL::pack):
(WebCore::BitmapTextureGL::unpack):
(WebCore::BitmapTextureGL::isPacked):
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::BitmapTextureGL::reset):
(WebCore::BitmapTextureGL::beginPaint):
(WebCore::BitmapTextureGL::endPaint):
(WebCore):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::BitmapTextureGL::updateRawContents):
(WebCore::BitmapTextureGL::setContentsToImage):
(WebCore::BitmapTextureGL::destroy):
(WebCore::TextureMapperGL::bindSurface):
* platform/graphics/opengl/TextureMapperGL.h:
(TextureMapperGL):
(WebCore::TextureMapperGL::allowSurfaceForRoot):
(BGRA32PremultimpliedBuffer):
(WebCore::BGRA32PremultimpliedBuffer::~BGRA32PremultimpliedBuffer):
(WebCore):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
* platform/graphics/qt/GraphicsContextQt.cpp:
* platform/graphics/qt/TextureMapperQt.cpp: Added.
(WebCore):
(WebCore::BitmapTextureQt::destroy):
(WebCore::BitmapTextureQt::reset):
(WebCore::BitmapTextureQt::beginPaint):
(WebCore::BitmapTextureQt::endPaint):
(WebCore::BitmapTextureQt::updateContents):
(WebCore::BitmapTextureQt::save):
(WebCore::BitmapTextureQt::setContentsToImage):
(WebCore::BitmapTextureQt::pack):
(WebCore::BitmapTextureQt::unpack):
(WebCore::TextureMapperQt::beginClip):
(WebCore::TextureMapperQt::endClip):
(WebCore::TextureMapperQt::viewportSize):
(WebCore::TextureMapperQt::TextureMapperQt):
(WebCore::TextureMapperQt::setGraphicsContext):
(WebCore::TextureMapperQt::graphicsContext):
(WebCore::TextureMapperQt::bindSurface):
(WebCore::TextureMapperQt::drawTexture):
(WebCore::TextureMapper::create):
(WebCore::TextureMapperQt::createTexture):
(WebCore::BitmapTextureQt::BitmapTextureQt):
(WebCore::TextureMapperQt::beginPainting):
(WebCore::TextureMapperQt::endPainting):
(BGRA32PremultimpliedBufferQt):
(WebCore::BGRA32PremultimpliedBufferQt::beginPaint):
(WebCore::BGRA32PremultimpliedBufferQt::endPaint):
(WebCore::BGRA32PremultimpliedBufferQt::data):
(WebCore::BGRA32PremultimpliedBuffer::create):
(WebCore::uidForImage):
* platform/graphics/qt/TextureMapperQt.h: Added.
(WebCore):
(BitmapTextureQt):
(WebCore::BitmapTextureQt::~BitmapTextureQt):
(WebCore::BitmapTextureQt::size):
(WebCore::BitmapTextureQt::isValid):
(WebCore::BitmapTextureQt::sourceRect):
(WebCore::BitmapTextureQt::isPacked):
(WebCore::BitmapTextureQt::painter):
(TextureMapperQt):
(WebCore::TextureMapperQt::allowSurfaceForRoot):
(WebCore::TextureMapperQt::initialize):
(WebCore::TextureMapperQt::create):
(WebCore::TextureMapperQt::currentPainter):
* platform/graphics/texmap/TextureMapper.cpp:
* platform/graphics/texmap/TextureMapper.h:
(WebCore::BitmapTexture::BitmapTexture):
(WebCore::BitmapTexture::allowOfflineTextureUpload):
(BitmapTexture):
(WebCore::BitmapTexture::pack):
(WebCore::BitmapTexture::unpack):
(WebCore::BitmapTexture::isPacked):
(WebCore::BitmapTexture::updateRawContents):
(WebCore::BitmapTexture::beginPaintMedia):
(WebCore::BitmapTexture::save):
(WebCore::BitmapTexture::lock):
(WebCore::BitmapTexture::unlock):
(WebCore::BitmapTexture::isLocked):
(TextureMapper):
(WebCore::TextureMapper::viewportSize):
(WebCore::TextureMapper::setViewportSize):
(WebCore::TextureMapper::allowPartialUpdates):
(WebCore::TextureMapper::isOpenGLBacked):
(WebCore::TextureMapper::setTransform):
(WebCore::TextureMapper::transform):
* platform/graphics/texmap/TextureMapperImageBuffer.cpp: Removed.
* platform/graphics/texmap/TextureMapperImageBuffer.h: Removed.
* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::renderContent):
(WebCore::TextureMapperNode::setContentsTileBackBuffer):
* platform/graphics/texmap/TextureMapperNode.h:
(TextureMapperNode):

Source/WebKit/qt:

* Api/qwebframe.cpp:
(QWebFramePrivate::renderCompositedLayers):
* WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQWidget::setRootGraphicsLayer):
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):

Source/WebKit2:

* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::paintToGraphicsContext):
(WebKit::LayerTreeHostProxy::createImage):
(WebKit::LayerTreeHostProxy::ensureRootLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogradient tests for CSS3 calc
mikelawther@chromium.org [Fri, 3 Feb 2012 06:44:54 +0000 (06:44 +0000)]
gradient tests for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75822

Reviewed by Hajime Morita.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

* css3/calc/css3-radial-gradients-expected-mismatch.html: Added.
* css3/calc/css3-radial-gradients.html: Added.
* css3/calc/gradient-color-stops-expected-mismatch.html: Added.
* css3/calc/gradient-color-stops.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoColorInputType needs to use ensureInlineStyleDecl
keishi@webkit.org [Fri, 3 Feb 2012 05:44:35 +0000 (05:44 +0000)]
ColorInputType needs to use ensureInlineStyleDecl
https://bugs.webkit.org/show_bug.cgi?id=77699

Reviewed by Kent Tamura.

Because WebCore internally should use the more specific CSSMutableStyleDeclaration
http://trac.webkit.org/changeset/105739

* html/ColorInputType.cpp:
(WebCore::ColorInputType::updateColorSwatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Add contentsSize flag into ewk_tiled_backing_store's private data.
commit-queue@webkit.org [Fri, 3 Feb 2012 05:42:14 +0000 (05:42 +0000)]
[EFL] Add contentsSize flag into ewk_tiled_backing_store's private data.
https://bugs.webkit.org/show_bug.cgi?id=77586

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2012-02-02
Reviewed by Andreas Kling.

As both zoom and content size change are identified by model flag,
ewk_tiled_backing_store can not detect the conflict between them.
In order to prevent conflict between zoom and contents size change,
contentsSize flag is newly added.

* ewk/ewk_tiled_backing_store.cpp:
(_Ewk_Tiled_Backing_Store_Item):
(_Ewk_Tiled_Backing_Store_Data):
(_ewk_tiled_backing_store_smart_calculate):
(ewk_tiled_backing_store_contents_resize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSimplify SelectorChecker::checkSelector and checkOneSelector
rolandsteiner@chromium.org [Fri, 3 Feb 2012 05:29:33 +0000 (05:29 +0000)]
Simplify SelectorChecker::checkSelector and checkOneSelector
https://bugs.webkit.org/show_bug.cgi?id=77697

Make use of Element::previous/nextElementSibling.
Made those methods inline.
Simplify code in checkSelector and checkOneSelector, esp. for first/nth/nth-last/last/only-child implementations.

Reviewed by Andreas Kling.

No new tests. (refactoring)

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector):
(WebCore::SelectorChecker::checkOneSelector):
* dom/Element.cpp:
* dom/Element.h:
(WebCore::Element::previousElementSibling):
(WebCore):
(WebCore::Element::nextElementSibling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoColorChooserClient is missing a virtual destructor
keishi@webkit.org [Fri, 3 Feb 2012 05:26:17 +0000 (05:26 +0000)]
ColorChooserClient is missing a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=77698

Reviewed by Kent Tamura.

* platform/ColorChooserClient.h:
(WebCore::ColorChooserClient::~ColorChooserClient): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove OVERRIDE from ColorInputType::valueAsColor
keishi@webkit.org [Fri, 3 Feb 2012 05:14:40 +0000 (05:14 +0000)]
Remove OVERRIDE from ColorInputType::valueAsColor
https://bugs.webkit.org/show_bug.cgi?id=77701

Reviewed by Kent Tamura.

* html/ColorInputType.h:
(WebCore::ColorInputType::valueAsColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport 'disabled' attribute on SVGStyleElement
commit-queue@webkit.org [Fri, 3 Feb 2012 04:51:18 +0000 (04:51 +0000)]
Support 'disabled' attribute on SVGStyleElement
https://bugs.webkit.org/show_bug.cgi?id=52130

Source/WebCore:

Adding disabled property to SVGStyleElement, which
mirrors the functionality added to HTMLStyleElement
for DOM1. The disabled property reflects and sets
the disabled state of its style sheet.

Based off of patch for bug 25287

Patch by Bear Travis <betravis@adobe.com> on 2012-02-02
Reviewed by Dirk Schulze.

Test: svg/dom/SVGStyleElement/disable-svg-style-element.html

* svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::disabled):
(WebCore):
(WebCore::SVGStyleElement::setDisabled):
* svg/SVGStyleElement.h:
(SVGStyleElement):
* svg/SVGStyleElement.idl:

LayoutTests:

Test the disabled property of an svg style element.
Based off of the patch for bug 25287.

Patch by Bear Travis <betravis@adobe.com> on 2012-02-02
Reviewed by Dirk Schulze.

* svg/dom/SVGStyleElement/disable-svg-style-element-expected.txt: Added.
* svg/dom/SVGStyleElement/disable-svg-style-element.html: Added.
* svg/dom/SVGStyleElement/script-tests/disable-svg-style-element.js: Added.
(createStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake ShadowRoot interface inherit DocumentFragment interface in IDL.
hayato@chromium.org [Fri, 3 Feb 2012 04:37:07 +0000 (04:37 +0000)]
Make ShadowRoot interface inherit DocumentFragment interface in IDL.
https://bugs.webkit.org/show_bug.cgi?id=77511

Reviewed by Kentaro Hara.

This patch contains only the change of IDL to isolate issues.
Other changes, such as tests for querySelector of ShadowRoot, will be added in follow-up patches.

No tests. No change in behavior.

* dom/ShadowRoot.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCheck parameters to biquad filters
commit-queue@webkit.org [Fri, 3 Feb 2012 04:08:50 +0000 (04:08 +0000)]
Check parameters to biquad filters
https://bugs.webkit.org/show_bug.cgi?id=71413

Source/WebCore:

Patch by Raymond Toy <rtoy@google.com> on 2012-02-02
Reviewed by Kenneth Russell.

Tests added for each filter type and for the limiting cases for
each filter type.

* platform/audio/Biquad.cpp:
(WebCore::Biquad::setLowpassParams):
(WebCore::Biquad::setHighpassParams):
(WebCore::Biquad::setLowShelfParams):
(WebCore::Biquad::setHighShelfParams):
(WebCore::Biquad::setPeakingParams):
(WebCore::Biquad::setAllpassParams):
(WebCore::Biquad::setNotchParams):
(WebCore::Biquad::setBandpassParams):
Check for invalid parameters and clip them to something sensible.
Also check for the limiting cases and try to use the limiting form
of the z-transform for the biquad.  Some issues cannot be
consistently handled because the z-transform is not continuous as
the parameters approach the limit.

LayoutTests:

Patch by Raymond Toy <rtoy@chromium.org> on 2012-02-02
Reviewed by Kenneth Russell.

* webaudio/biquad-allpass-expected.txt: Added
* webaudio/biquad-allpass.html: Added
* webaudio/biquad-bandpass-expected.txt: Added
* webaudio/biquad-bandpass.html: Added
* webaudio/biquad-highpass-expected.txt: Added
* webaudio/biquad-highpass.html: Added
* webaudio/biquad-highshelf-expected.txt: Added
* webaudio/biquad-highshelf.html: Added
* webaudio/biquad-lowpass-expected.txt: Added
* webaudio/biquad-lowpass.html: Added
* webaudio/biquad-lowshelf-expected.txt: Added
* webaudio/biquad-lowshelf.html: Added
* webaudio/biquad-notch-expected.txt: Added
* webaudio/biquad-notch.html: Added
* webaudio/biquad-peaking-expected.txt: Added
* webaudio/biquad-peaking.html: Added
* webaudio/resources/biquad-testing.js: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][Texmap] Refactor TextureMapper API to use ImageBuffers when possible.
noam.rosenthal@nokia.com [Fri, 3 Feb 2012 04:00:29 +0000 (04:00 +0000)]
[Qt][Texmap] Refactor TextureMapper API to use ImageBuffers when possible.
https://bugs.webkit.org/show_bug.cgi?id=77148

Reviewed by Martin Robinson.

Source/WebCore:

Removed TextureMapperQt, and instead created a TextureMapperImageBuffer class,
which responds to an "Software" mode of TextureMapper, instead of creating subclasses
of TextureMapper directly. This allows using the software fallback of TextureMapper by any
sort.

To make the ImageBuffer backend easier, content updates to BitmapTexture can now use either
an image, or a raw data pointer. The raw data pointer is provided for performance reasons,
as converting data to/from Image references in Qt generates unnecessary deep copies of the
image data.

Also, functions that use TransformationMatrix were added to GraphicsContext, to allow for
3D transforms in cross platform code.
After this patch everything renders the same. An additional bug report was created to allow
ImageBuffer shallow image copies: https://bugs.webkit.org/show_bug.cgi?id=77689

Covered extensively by existing tests, no behavioral changes.

* Target.pri:
* platform/graphics/GraphicsContext.cpp:
* platform/graphics/GraphicsContext.h:
(WebCore):
(GraphicsContext):
* platform/graphics/cairo/TextureMapperCairo.cpp:
* platform/graphics/opengl/TextureMapperGL.cpp:
(TextureMapperGLData):
(BitmapTextureGL):
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::BitmapTextureGL::reset):
(WebCore):
(WebCore::swizzleBGRAToRGBA):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::BitmapTextureGL::destroy):
(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapper::platformCreateAccelerated):
* platform/graphics/opengl/TextureMapperGL.h:
(TextureMapperGL):
(WebCore::TextureMapperGL::accelerationMode):
(WebCore):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore):
(WebCore::GraphicsContext::get3DTransform):
(WebCore::GraphicsContext::concat3DTransform):
(WebCore::GraphicsContext::set3DTransform):
* platform/graphics/qt/TextureMapperQt.cpp: Removed.
* platform/graphics/qt/TextureMapperQt.h: Removed.
* platform/graphics/texmap/TextureMapper.cpp:
(WebCore):
(BitmapTextureImageBuffer):
(TextureMapperImageBuffer):
* platform/graphics/texmap/TextureMapper.h:
(WebCore::BitmapTexture::BitmapTexture):
(BitmapTexture):
(WebCore::BitmapTexture::bpp):
(WebCore::BitmapTexture::isOpaque):
(WebCore::TextureMapper::setGraphicsContext):
(WebCore::TextureMapper::graphicsContext):
(TextureMapper):
(WebCore::TextureMapper::TextureMapper):
(WebCore::TextureMapper::platformCreateAccelerated):
* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::renderContent):
(WebCore::TextureMapperNode::setContentsTileBackBuffer):
* platform/graphics/texmap/TextureMapperNode.h:
(TextureMapperNode):

Source/WebKit/qt:

Use TextureMapper::create instead of creating TextureMapperGL/TextureMapperQt directly.

* Api/qwebframe.cpp:
(QWebFramePrivate::renderCompositedLayers):
* WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQWidget::setRootGraphicsLayer):
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):

Source/WebKit2:

Use TextureMapper::create instead of creating TextureMapperGL/TextureMapperQt directly.
Remove calls to unused API.

* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::paintToGraphicsContext):
(WebKit::LayerTreeHostProxy::createImage):
(WebKit::LayerTreeHostProxy::ensureRootLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactoring: Share test drivers of shadow content tests.
commit-queue@webkit.org [Fri, 3 Feb 2012 03:33:10 +0000 (03:33 +0000)]
Refactoring: Share test drivers of shadow content tests.
https://bugs.webkit.org/show_bug.cgi?id=77584

Extracts shared test code from content-element-move.html and content-element-select-dynamic.html.
This test framework will be used a few more times.

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-02
Reviewed by Hajime Morita.

* fast/dom/resources/shadow-test-driver.js: Added.
(log):
(cleanUp):
(removeContainerLines):
(check):
(createSpanWithText):
(createContentWithSelect):
(appendShadow):
(appendShadowDeep):
(doTestIfLeft.callIfDone):
(doneTest):
(doTest):
* fast/dom/shadow/content-element-move.html:
* fast/dom/shadow/content-element-select-dynamic.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename checkNodeSecurity and allowsAccessFromFrame to have sensible names
abarth@webkit.org [Fri, 3 Feb 2012 03:23:45 +0000 (03:23 +0000)]
Rename checkNodeSecurity and allowsAccessFromFrame to have sensible names
https://bugs.webkit.org/show_bug.cgi?id=75796

Reviewed by Eric Seidel.

As requested by Darin Adler, this patch renames these functions be
clear that we're asking whether the access should be allowed rather
than explicitly allowing the access.

* bindings/generic/BindingSecurity.h:
(BindingSecurity):
(WebCore::::shouldAllowAccessToNode):
(WebCore::::allowSettingFrameSrcToJavascriptUrl):
* bindings/js/JSDOMBinding.cpp:
(WebCore::shouldAllowAccessToNode):
(WebCore::shouldAllowAccessToFrame):
* bindings/js/JSDOMBinding.h:
(WebCore):
* bindings/js/JSHTMLFrameElementCustom.cpp:
(WebCore::allowSettingJavascriptURL):
* bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::getOwnPropertySlotDelegate):
(WebCore::JSHistory::getOwnPropertyDescriptorDelegate):
(WebCore::JSHistory::putDelegate):
(WebCore::JSHistory::deleteProperty):
(WebCore::JSHistory::getOwnPropertyNames):
* bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::getOwnPropertySlotDelegate):
(WebCore::JSLocation::getOwnPropertyDescriptorDelegate):
(WebCore::JSLocation::putDelegate):
(WebCore::JSLocation::deleteProperty):
(WebCore::JSLocation::getOwnPropertyNames):
(WebCore::JSLocation::toStringFunction):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::canAccessFromCurrentOrigin):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertyDescriptorBody):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateFunctionCallback):
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObject::getOwnPropertyDescriptor):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjContentDocument):
(WebCore::jsTestObjPrototypeFunctionGetSVGDocument):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::contentDocumentAttrGetter):
(WebCore::TestObjInternal::getSVGDocumentCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] add support for --makeargs to the ninja-based build
jochen@chromium.org [Fri, 3 Feb 2012 03:18:53 +0000 (03:18 +0000)]
[chromium] add support for --makeargs to the ninja-based build
https://bugs.webkit.org/show_bug.cgi?id=77688

Reviewed by Adam Barth.

* Scripts/webkitdirs.pm:
(buildChromiumNinja):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRun tests in serial on SnowLeopard to avoid CFURLCache crashes
eric@webkit.org [Fri, 3 Feb 2012 03:03:16 +0000 (03:03 +0000)]
Run tests in serial on SnowLeopard to avoid CFURLCache crashes
https://bugs.webkit.org/show_bug.cgi?id=75145

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.default_child_processes):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(test_operating_system):
(test_default_child_processes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Make gtk+ symbols available to WidgetBackingStoreCairo.cpp
commit-queue@webkit.org [Fri, 3 Feb 2012 02:53:09 +0000 (02:53 +0000)]
[GTK] Make gtk+ symbols available to WidgetBackingStoreCairo.cpp
https://bugs.webkit.org/show_bug.cgi?id=77679

WidgetBackingStoreCairo.cpp uses GTK+ symbols, so we need it in
webcoregtk_sources instead of webcore_sources.

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-02
Reviewed by Martin Robinson.

* GNUmakefile.list.am: Move WidgetBackingStoreCairo.cpp to webcoregtk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, removing an unnecessarily JS_PRIVATE_EXPORT annotation.
morrita@google.com [Fri, 3 Feb 2012 02:52:47 +0000 (02:52 +0000)]
Unreviewed, removing an unnecessarily JS_PRIVATE_EXPORT annotation.

* interpreter/Interpreter.h:
(Interpreter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStyleRecalc should occur when shadow root exists and light children are changed.
commit-queue@webkit.org [Fri, 3 Feb 2012 02:47:04 +0000 (02:47 +0000)]
StyleRecalc should occur when shadow root exists and light children are changed.
https://bugs.webkit.org/show_bug.cgi?id=76262

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-02
Reviewed by Hajime Morita.

Source/WebCore:

When light children is changed, the element included in HTMLContentElement may also be changed.
So we have to recalculate inclusion of content element again.

Test: fast/dom/shadow/shadow-contents-fallback-dynamic.html

* dom/Element.cpp:
(WebCore::Element::childrenChanged):

LayoutTests:

Tests for dynamic content fallback.
Also, unnecessary RenderText objects in previous test expectations were removed.

* fast/dom/shadow/shadow-contents-fallback-dynamic-expected.txt: Added.
* fast/dom/shadow/shadow-contents-fallback-dynamic.html: Added.
* platform/chromium-win/fast/html/details-remove-child-2-expected.txt:
* platform/gtk/fast/html/details-remove-child-2-expected.txt:
* platform/mac/fast/html/details-remove-child-2-expected.txt:
* platform/qt/fast/html/details-remove-child-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonoteGrainOn needs more tests
commit-queue@webkit.org [Fri, 3 Feb 2012 02:40:49 +0000 (02:40 +0000)]
noteGrainOn needs more tests
https://bugs.webkit.org/show_bug.cgi?id=77225

Patch by Raymond Toy <rtoy@google.com> on 2012-02-02
Reviewed by Kenneth Russell.

* webaudio/note-grain-on-play.html: Added.
* webaudio/note-grain-on-play-expected.txt: Added.
* webaudio/note-grain-on-timing.html: Refactored to use new
functions in note-grain-on-testing.js.
* webaudio/note-grain-on-timing-expected.txt: Updated.
* webaudio/resources/audio-testing.js:
(grainLengthInSampleFrames):  Utility to compute length of a grain
in samples.
* webaudio/resources/note-grain-on-testing.js: Added.
(createSignalBuffer):
(findStartAndEndSamples):
(playGrain):
(playAllGrains):
(verifyStarAndtEndTimes): Common functions for note-grain-on-play and
note-grain-on-timing tests to use.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTypo in sample-accurate-scheduling layout test?
commit-queue@webkit.org [Fri, 3 Feb 2012 02:28:17 +0000 (02:28 +0000)]
Typo in sample-accurate-scheduling layout test?
https://bugs.webkit.org/show_bug.cgi?id=75996

Patch by Raymond Toy <rtoy@google.com> on 2012-02-02
Reviewed by Kenneth Russell.

* webaudio/sample-accurate-scheduling-expected.txt: Updated
* webaudio/sample-accurate-scheduling.html: Fix typo, add test for
expected number of events.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAvoid crashing renderer when GPU process dies by not caching textures between video...
commit-queue@webkit.org [Fri, 3 Feb 2012 02:13:25 +0000 (02:13 +0000)]
Avoid crashing renderer when GPU process dies by not caching textures between video frames.
https://bugs.webkit.org/show_bug.cgi?id=77654

Patch by Ami Fischman <fischman@chromium.org> on 2012-02-02
Reviewed by James Robinson.

* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd ScrollingTree class
andersca@apple.com [Fri, 3 Feb 2012 02:04:51 +0000 (02:04 +0000)]
Add ScrollingTree class
https://bugs.webkit.org/show_bug.cgi?id=77695

Reviewed by Andreas Kling.

* WebCore.xcodeproj/project.pbxproj:
Add new files.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::ScrollingCoordinator):
Create a scrolling tree.

(WebCore::ScrollingCoordinator::~ScrollingCoordinator):
Assert that the scrolling tree is null.

(WebCore::ScrollingCoordinator::pageDestroyed):
Null out the scrolling tree member variable and tell it to invalidate itself.

* page/scrolling/ScrollingTree.cpp: Added.

(WebCore::ScrollingTree::invalidate):
Null out the scrolling coordinator, breaking the reference cycle between the scrolling
coordinator and the scrolling tree.

* page/scrolling/ScrollingTree.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Don't use uint
commit-queue@webkit.org [Fri, 3 Feb 2012 01:49:28 +0000 (01:49 +0000)]
[GTK] Don't use uint
https://bugs.webkit.org/show_bug.cgi?id=77678

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-02
Reviewed by Martin Robinson.

With the MingGW cross compiler toolchain in Fedora, uint wasn't
defined, so use unsigned int instead.

* WebCoreSupport/ChromeClientGtk.h:
(ChromeClient): Use unsigned int instead of uint

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactor plugin drawing to be more data driven
commit-queue@webkit.org [Fri, 3 Feb 2012 01:35:29 +0000 (01:35 +0000)]
Refactor plugin drawing to be more data driven
https://bugs.webkit.org/show_bug.cgi?id=76715

Patch by Tim Dresser <tdresser@chromium.org> on 2012-02-02
Reviewed by James Robinson.

CCPluginLayerImpl no longer handles drawing itself, but produces a list of CCPluginDrawQuads.
These quads are then drawn by LayerRendererChromium.

CCLayerImpl::willDraw(LayerRendererChromium*) is called directly before appendQuads.
This allows for CCLayerImpl objects to allocate textures before appendQuads is called.

This is a refactor, so no new tests were added.
Flash was tested manually on Linux and Mac.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::PluginProgramBinding::set):
(PluginProgramBinding):
(WebCore):
(WebCore::TexStretchPluginProgramBinding::set):
(TexStretchPluginProgramBinding):
(WebCore::TexTransformPluginProgramBinding::set):
(TexTransformPluginProgramBinding):
(WebCore::LayerRendererChromium::drawPluginQuad):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::willDraw):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
* platform/graphics/chromium/cc/CCPluginDrawQuad.cpp:
(WebCore::CCPluginDrawQuad::create):
(WebCore::CCPluginDrawQuad::CCPluginDrawQuad):
* platform/graphics/chromium/cc/CCPluginDrawQuad.h:
(CCPluginDrawQuad):
(WebCore::CCPluginDrawQuad::uvRect):
(WebCore::CCPluginDrawQuad::textureId):
(WebCore::CCPluginDrawQuad::flipped):
(WebCore::CCPluginDrawQuad::ioSurfaceWidth):
(WebCore::CCPluginDrawQuad::ioSurfaceHeight):
(WebCore::CCPluginDrawQuad::ioSurfaceTextureId):
* platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::willDraw):
(WebCore::CCPluginLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCPluginLayerImpl.h:
(CCPluginLayerImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] eliminate JavaScriptCore.exp
morrita@google.com [Fri, 3 Feb 2012 01:01:59 +0000 (01:01 +0000)]
[Mac] eliminate JavaScriptCore.exp
https://bugs.webkit.org/show_bug.cgi?id=72854

Reviewed by Darin Adler.

- Removed exp files and corresponding makefile entries.
- Changed the build configuration no to use exp file.

* Configurations/JavaScriptCore.xcconfig:
* DerivedSources.make:
* JavaScriptCore.JSVALUE32_64only.exp: Removed.
* JavaScriptCore.JSVALUE64only.exp: Removed.
* JavaScriptCore.exp: Removed.
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoV8 idl code generator doesn't handle SerializedScriptValue attributes properly.
haraken@chromium.org [Fri, 3 Feb 2012 00:47:44 +0000 (00:47 +0000)]
V8 idl code generator doesn't handle SerializedScriptValue attributes properly.
https://bugs.webkit.org/show_bug.cgi?id=77295

Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-29
Reviewed by Kentaro Hara.

Only the case of one (and only one) SerializedScriptValue attribute was
handled, and it was deserialized eagerly in the constructor instead of
generating getters/setters. This patch gets rid of that behavior and
generates the getters and setters instead (similar to what the JSC
generator does).
Also handle the case of SSV attributes with [CachedAttribute]
declaration, caching the deserialized value in a hidden attribute on the
object.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(GenerateToV8Converters):
(JSValueToNative):
(NativeToJSValue):
* bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
(WebDOMTestSerializedScriptValueInterface::setValue):
(WebDOMTestSerializedScriptValueInterface::readonlyValue):
(WebDOMTestSerializedScriptValueInterface::cachedValue):
(WebDOMTestSerializedScriptValueInterface::setCachedValue):
(WebDOMTestSerializedScriptValueInterface::cachedReadonlyValue):
* bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:
(WebDOMTestSerializedScriptValueInterface):
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
(webkit_dom_test_serialized_script_value_interface_set_value):
(webkit_dom_test_serialized_script_value_interface_get_readonly_value):
(webkit_dom_test_serialized_script_value_interface_get_cached_value):
(webkit_dom_test_serialized_script_value_interface_set_cached_value):
(webkit_dom_test_serialized_script_value_interface_get_cached_readonly_value):
(webkit_dom_test_serialized_script_value_interface_get_property):
(webkit_dom_test_serialized_script_value_interface_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
():
(WebCore::jsTestSerializedScriptValueInterfaceReadonlyValue):
(WebCore):
(WebCore::jsTestSerializedScriptValueInterfaceCachedValue):
(WebCore::jsTestSerializedScriptValueInterfaceCachedReadonlyValue):
(WebCore::JSTestSerializedScriptValueInterface::put):
(WebCore::setJSTestSerializedScriptValueInterfaceValue):
(WebCore::setJSTestSerializedScriptValueInterfaceCachedValue):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(JSTestSerializedScriptValueInterface):
(JSTestSerializedScriptValueInterfacePrototype):
(WebCore):
* bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
* bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:
(-[DOMTestSerializedScriptValueInterface setValue:]):
(-[DOMTestSerializedScriptValueInterface readonlyValue]):
(-[DOMTestSerializedScriptValueInterface cachedValue]):
(-[DOMTestSerializedScriptValueInterface setCachedValue:]):
(-[DOMTestSerializedScriptValueInterface cachedReadonlyValue]):
* bindings/scripts/test/TestSerializedScriptValueInterface.idl:
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceInternal::valueAttrGetter):
(TestSerializedScriptValueInterfaceInternal):
(WebCore::TestSerializedScriptValueInterfaceInternal::valueAttrSetter):
(WebCore::TestSerializedScriptValueInterfaceInternal::readonlyValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceInternal::cachedValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceInternal::cachedValueAttrSetter):
(WebCore::TestSerializedScriptValueInterfaceInternal::cachedReadonlyValueAttrGetter):
():
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBMW Car Configuration Page doesn't work (Only manifests in Chromium)
abarth@webkit.org [Fri, 3 Feb 2012 00:26:10 +0000 (00:26 +0000)]
BMW Car Configuration Page doesn't work (Only manifests in Chromium)
https://bugs.webkit.org/show_bug.cgi?id=77312

Reviewed by Dimitri Glazkov.

When we autogenerated the event factory, we missed the check for
whether touch events were enabled at runtime:
http://trac.webkit.org/changeset/97933/trunk/Source/WebCore/dom/Document.cpp

This patch adds the check back.

Unfortunately, there isn't a testing frame work for
RuntimeEnabledFeatures.  The main difficulty is that these static bools
need to be set when WebKit is initialized and can't be changed (which
is why they're not part of WebCore::Settings).  To test them properly,
we'd need a testing framework that booted up WebKit for each test.

We could test this particular change (which doesn't need the bool to be
constant through the runtime of WebKit), but that would create a
sandtrap for future patches who might thing that this testing framework
can really be used to test RuntimeEnabledFeatures.

The net result is that Chromium is going to end up living with the
non-default codepath for these settings being untested, which will lead
to regressions like this one.  If we ened up with a bunch of these
regressions, we'll likely end up with a testing framework similar to
Chromium's browsers_tests, which create a fresh subprocess for each
test.

* dom/EventFactory.in:
* dom/make_event_factory.pl:
(defaultItemFactory):
(generateImplementation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix up test expectations for two tests that now pass.
commit-queue@webkit.org [Fri, 3 Feb 2012 00:24:56 +0000 (00:24 +0000)]
Fix up test expectations for two tests that now pass.
https://bugs.webkit.org/show_bug.cgi?id=77256

Patch by Raymond Toy <rtoy@google.com> on 2012-02-02
Reviewed by Eric Seidel.

* platform/chromium/test_expectations.txt:
webaudio/audiobuffersource-playbackrate.html and
webaudio/gain.html pass on windows now after the fix for bug
76659. Delete these.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Use SkCanvas::flush in skia port
commit-queue@webkit.org [Fri, 3 Feb 2012 00:06:57 +0000 (00:06 +0000)]
[Chromium] Use SkCanvas::flush in skia port
https://bugs.webkit.org/show_bug.cgi?id=77463

Patch by Justin Novosad <junov@chromium.org> on 2012-02-02
Reviewed by Stephen White.

Code cleanup in skia port. Using SkCanvas::flush to remove
unnecessary dependency on GrContext.  Removed unnecessary inclusions
and forward declarations of GrContext in several source files.

* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/LayerRendererChromium.cpp:
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCProxy.h:
* platform/graphics/skia/PlatformContextSkia.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRunning a Web Worker on about:blank crashes the interpreter
benjamin@webkit.org [Thu, 2 Feb 2012 23:42:26 +0000 (23:42 +0000)]
Running a Web Worker on about:blank crashes the interpreter
https://bugs.webkit.org/show_bug.cgi?id=77593

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-02-02
Reviewed by Michael Saboff.

Source/JavaScriptCore:

The method Interpreter::execute() was crashing on empty programs because
the assumption is made the source is not null.

This patch shortcut the execution when the String is null to avoid invalid
memory access.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):

LayoutTests:

The Worker thread should not crash if running on an empty page.
The timer is necessary to give a chance for the thread to start.

* fast/workers/empty-worker-nocrash-expected.txt: Added.
* fast/workers/empty-worker-nocrash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoVersioning.
lforschler@apple.com [Thu, 2 Feb 2012 23:41:11 +0000 (23:41 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Use win32 native threading
commit-queue@webkit.org [Thu, 2 Feb 2012 23:36:40 +0000 (23:36 +0000)]
[GTK] Use win32 native threading
https://bugs.webkit.org/show_bug.cgi?id=77676

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-02
Reviewed by Martin Robinson.

r97269 switched from glib threading to pthreads, breaking win32 GTK+.
This is a follow up, removing some leftovers in ThreadSpecific.h and
switching win32 to use the native threading in ThreadingWin.cpp.

* GNUmakefile.list.am: Compile in win32 native threading support
* wtf/ThreadSpecific.h: Remove GTK+-specific definitions
(ThreadSpecific):
(WTF::::destroy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoretrieveCallerFromVMCode should call trueCallerFrame
fpizlo@apple.com [Thu, 2 Feb 2012 23:18:13 +0000 (23:18 +0000)]
retrieveCallerFromVMCode should call trueCallerFrame
https://bugs.webkit.org/show_bug.cgi?id=77684

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::retrieveCallerFromVMCode):

LayoutTests:

Rubber stamped by Oliver Hunt.

* fast/js/dfg-inline-function-dot-caller-expected.txt: Added.
* fast/js/dfg-inline-function-dot-caller.html: Added.
* fast/js/script-tests/dfg-inline-function-dot-caller.js: Added.
(resultArray):
(object.nonInlineable.nonInlineable.if):
(object.nonInlineable):
(object.inlineable):
(makeInlinableCall):
(g):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Implement current executable path finding for win32
commit-queue@webkit.org [Thu, 2 Feb 2012 23:03:45 +0000 (23:03 +0000)]
[GTK] Implement current executable path finding for win32
https://bugs.webkit.org/show_bug.cgi?id=77677

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-02
Reviewed by Martin Robinson.

The WTF helper for getting the binary path that was added in r101710
left out the win32 implementation. Fix this.

* wtf/gobject/GlibUtilities.cpp:
(getCurrentExecutablePath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThrowing away bytecode and then reparsing during DFG optimization is just
fpizlo@apple.com [Thu, 2 Feb 2012 22:55:12 +0000 (22:55 +0000)]
Throwing away bytecode and then reparsing during DFG optimization is just
plain wrong and makes things crash
https://bugs.webkit.org/show_bug.cgi?id=77680
<rdar://problem/10798490>

Reviewed by Oliver Hunt.

This is the minimal surgical fix: it removes the code that triggered bytecode
throw-away. Once we're confident that this is a good idea, we can kill all of
the code that implements the feature.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::discardBytecodeLater):
(JSC::CodeBlock::addValueProfile):
* jit/JITDriver.h:
(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTurn on CSS Filters on Windows
aestes@apple.com [Thu, 2 Feb 2012 22:50:42 +0000 (22:50 +0000)]
Turn on CSS Filters on Windows
https://bugs.webkit.org/show_bug.cgi?id=76667

Source/WebCore:

Turning on CSS_FILTERS flag for Windows and fixed a couple of resultant build errors

Patch by Chris Marrin <cmarrin@apple.com> on 2012-02-02
Reviewed by Adele Peterson.

* WebCore.vcproj/copyForwardingHeaders.cmd:
* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayer::setFilters):
(PlatformCALayer::filtersCanBeComposited):

WebKitLibraries:

Turned on CSS_FILTERS for Windows

Patch by Chris Marrin <cmarrin@apple.com> on 2012-02-02
Reviewed by Adele Peterson.

* win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests:

Skipped filter test files not supported on Windows

Patch by Chris Marrin <cmarrin@apple.com> on 2012-02-02
Reviewed by Adele Peterson.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClear shown notifications when context is no longer active
jonlee@apple.com [Thu, 2 Feb 2012 22:16:14 +0000 (22:16 +0000)]
Clear shown notifications when context is no longer active
https://bugs.webkit.org/show_bug.cgi?id=77363
<rdar://problem/10568907>

Reviewed by Darin Adler.

Source/WebCore:

* notifications/NotificationPresenter.h: Add new virtual function to clear notifications
associated with a given execution context. By default the notifications are left alone, as
before. Individual implementations can override to allow notifications to clear them.

* notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::disconnectFrame): When disconnecting the page from the frame, we
call clearNotifications().
* page/Frame.cpp:
(WebCore::Frame::pageDestroyed): When the page is destroyed, tell the DOM window to reset notifications.

Source/WebKit/win:

* WebCoreSupport/WebDesktopNotificationsDelegate.h:
(WebDesktopNotificationsDelegate): Add previously missing virtual functions.
* WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
(WebDesktopNotificationsDelegate::notificationControllerDestroyed):
(WebDesktopNotificationsDelegate::cancelRequestsForPermission):

Source/WebKit2:

* WebProcess/WebCoreSupport/WebNotificationClient.cpp:
(WebKit::WebNotificationClient::clearNotifications): Forward the call to
WebNotificationManager.
* WebProcess/WebCoreSupport/WebNotificationClient.h:
(WebNotificationClient):

* WebProcess/Notifications/WebNotificationManager.h: Add an additional map that maps
all notifications associated with a given ScriptExecutionContext instance.
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show): Create a map entry for the notification's
context if it doesn't exist already, and note that notification's ID. Also, correct
the return value of show() if notifications are not enabled, to return false.
(WebKit::WebNotificationManager::didCloseNotifications): When the notification is closed,
we remove that notification from the map.
(WebKit::WebNotificationManager::clearNotifications): Use the map entry for the given
context, and pass that along to the proxy so that all of the notifications with those IDs
can be cleared. In the meantime, we remove that context's map entry.

* UIProcess/Notifications/WebNotificationManagerProxy.messages.in: New ClearNotifications()
message.
* UIProcess/Notifications/WebNotificationManagerProxy.h:
* UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::clearNotifications): Forward the call to the provider.
Then remove this proxy's entries for the given notification IDs.

* UIProcess/Notifications/WebNotificationProvider.cpp:
(WebKit::WebNotificationProvider::clearNotifications): Convert the vector of IDs to a mutable
array.
* UIProcess/Notifications/WebNotificationProvider.h:
(WebNotificationProvider):

* UIProcess/API/C/WKNotificationProvider.h: Add WK API to tell the platform to clear the notifications.

Remove the #if guard since they already exist in WebNotificationManager functions:
* WebProcess/WebCoreSupport/WebNotificationClient.cpp:
(WebKit::WebNotificationClient::show):
(WebKit::WebNotificationClient::cancel):
(WebKit::WebNotificationClient::notificationObjectDestroyed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago nrwt shouldn't blow up when there are errors in test_expectations.txt
dpranke@chromium.org [Thu, 2 Feb 2012 21:55:08 +0000 (21:55 +0000)]
   nrwt shouldn't blow up when there are errors in test_expectations.txt
       https://bugs.webkit.org/show_bug.cgi?id=73603

       Reviewed by Ojan Vafai.

       This change removes the distinction between 'errors' and 'warnings'
       in the test expectations parser. Now, any problem is a
       'warning', and if we are linting the file, warnings become fatal (errors).

This will allow a normal run-webkit-tests run to proceed even if
there are bad lines.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(ParseError.__init__):
(ParseError.__str__):
(ParseError.__repr__):
(TestExpectationSerializer.to_string):
(TestExpectationParser._parse_modifiers):
(TestExpectationParser._parse_expectations):
(TestExpectationParser._check_modifiers_against_expectations):
(TestExpectationParser._tokenize):
(TestExpectationLine.__init__):
(TestExpectationLine.is_invalid):
(TestExpectationsModel.add_expectation_line):
(TestExpectationsModel._already_seen_better_match):
(TestExpectations.__init__):
(TestExpectations._report_warnings):
(TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(assert_bad_expectations):
(test_parse_warning):
(test_overrides__duplicate):
(ExpectationSyntaxTests.test_missing_expectation):
(ExpectationSyntaxTests.test_missing_colon):
(ExpectationSyntaxTests.test_too_many_colons):
(ExpectationSyntaxTests.test_too_many_equals_signs):
(ExpectationSyntaxTests.test_unrecognized_expectation):
(SemanticTests.test_bug_format):
(SemanticTests.test_bad_bugid):
(SemanticTests.test_slow_and_timeout):
(test_ambiguous):
(test_more_modifiers):
(test_order_in_file):
(test_macro_overrides):
(RebaseliningTest.assertRemove):
(TestExpectationParserTests.test_tokenize_blank):
(TestExpectationParserTests.test_tokenize_missing_colon):
(TestExpectationParserTests.test_tokenize_extra_colon):
(TestExpectationParserTests.test_tokenize_empty_comment):
(TestExpectationParserTests.test_tokenize_comment):
(TestExpectationParserTests.test_tokenize_missing_equal):
(TestExpectationParserTests.test_tokenize_extra_equal):
(TestExpectationParserTests.test_tokenize_valid):
(TestExpectationParserTests.test_tokenize_valid_with_comment):
(TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
(TestExpectationSerializerTests.test_unparsed_to_string):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(lint):
* Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker.check_test_expectations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRelease build debugging should be easier
fpizlo@apple.com [Thu, 2 Feb 2012 21:49:50 +0000 (21:49 +0000)]
Release build debugging should be easier
https://bugs.webkit.org/show_bug.cgi?id=77669

Reviewed by Gavin Barraclough.

* assembler/ARMAssembler.h:
(ARMAssembler):
(JSC::ARMAssembler::debugOffset):
* assembler/ARMv7Assembler.h:
(ARMv7Assembler):
(JSC::ARMv7Assembler::debugOffset):
(ARMInstructionFormatter):
(JSC::ARMv7Assembler::ARMInstructionFormatter::debugOffset):
* assembler/AbstractMacroAssembler.h:
(AbstractMacroAssembler):
(JSC::AbstractMacroAssembler::debugOffset):
* assembler/AssemblerBuffer.h:
(AssemblerBuffer):
(JSC::AssemblerBuffer::debugOffset):
* assembler/LinkBuffer.h:
(LinkBuffer):
(JSC::LinkBuffer::debugSize):
* assembler/MIPSAssembler.h:
(MIPSAssembler):
(JSC::MIPSAssembler::debugOffset):
* assembler/X86Assembler.h:
(X86Assembler):
(JSC::X86Assembler::debugOffset):
(X86InstructionFormatter):
(JSC::X86Assembler::X86InstructionFormatter::debugOffset):
* bytecode/CodeBlock.cpp:
(JSC):
* bytecode/CodeBlock.h:
(CodeBlock):
* bytecode/CodeOrigin.h:
(CodeOrigin):
(JSC):
(JSC::CodeOrigin::inlineStack):
* bytecode/DFGExitProfile.h:
(JSC::DFG::exitKindToString):
* bytecode/DataFormat.h:
(JSC::dataFormatToString):
* bytecode/PredictedType.cpp:
(JSC):
(JSC::predictionToString):
* bytecode/PredictedType.h:
(JSC):
* bytecode/ValueRecovery.h:
(ValueRecovery):
(JSC::ValueRecovery::dump):
* bytecompiler/BytecodeGenerator.cpp:
(JSC):
(JSC::BytecodeGenerator::setDumpsGeneratedCode):
(JSC::BytecodeGenerator::dumpsGeneratedCode):
(JSC::BytecodeGenerator::generate):
* dfg/DFGAbstractValue.h:
(StructureAbstractValue):
(JSC::DFG::StructureAbstractValue::dump):
(AbstractValue):
(JSC::DFG::AbstractValue::dump):
* dfg/DFGAssemblyHelpers.h:
(DFG):
(AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::debugCall):
* dfg/DFGFPRInfo.h:
(FPRInfo):
(JSC::DFG::FPRInfo::debugName):
* dfg/DFGGPRInfo.h:
(GPRInfo):
(JSC::DFG::GPRInfo::debugName):
* dfg/DFGGraph.cpp:
(DFG):
* dfg/DFGGraph.h:
(Graph):
* dfg/DFGNode.h:
(DFG):
(JSC::DFG::arithNodeFlagsAsString):
(Node):
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::dumpChildren):
* dfg/DFGOSRExit.cpp:
(DFG):
(JSC::DFG::OSRExit::dump):
* dfg/DFGOSRExit.h:
(OSRExit):
* runtime/JSValue.cpp:
(JSC):
(JSC::JSValue::description):
* runtime/JSValue.h:
(JSValue):
* wtf/BitVector.cpp:
(WTF):
(WTF::BitVector::dump):
* wtf/BitVector.h:
(BitVector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGetters and setters cause line numbers in errors/console.log to be offset for the...
oliver@apple.com [Thu, 2 Feb 2012 21:19:53 +0000 (21:19 +0000)]
Getters and setters cause line numbers in errors/console.log to be offset for the whole file
https://bugs.webkit.org/show_bug.cgi?id=77675

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Our default literal parsing logic doesn't handle the extra work required for
getters and setters.  When it encounters one, it rolls back the lexer and
then switches to a more complete parsing function.  Unfortunately it was only
winding back the character position, and was ignoring the line number and
other lexer data.  This led to every getter and setter causing the line number
to be incorrectly incremented leading to increasingly incorrect numbers for
the rest of the file.

* parser/Parser.cpp:
(JSC::::parseObjectLiteral):

LayoutTests:

Add getter and setter line number tests.

* fast/js/exception-linenums-expected.txt:
* fast/js/script-tests/exception-linenums.js:
(firstPropIsGetter.get getter):
(secondPropIsGetter.prop.1.get getter):
(firstPropIsSetter.set setter):
(secondPropIsSetter.prop.1.set setter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe overhang area layer should have a linen background
andersca@apple.com [Thu, 2 Feb 2012 21:18:37 +0000 (21:18 +0000)]
The overhang area layer should have a linen background
https://bugs.webkit.org/show_bug.cgi?id=77670
<rdar://problem/10797727>

Reviewed by Andreas Kling.

* page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinator::scrollByOnScrollingThread):
Add an #ifdef so that scroll position clamping can be disabled. This will be
removed once rubber-banding works properly.

* platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::setUpOverhangAreasLayerContents):
Add new empty function.

* platform/mac/ScrollbarThemeMac.h:
(ScrollbarThemeMac):
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::linenBackgroundColor):
Helper function for getting the CGColorRef that represents the linen background color.

(WebCore::ScrollbarThemeMac::setUpOverhangAreasLayerContents):
Set the linen background color as the overhang areas layer background color.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
Call ScrollbarTheme::setUpOverhangAreasLayerContents.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2012-02-02 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 2 Feb 2012 21:15:51 +0000 (21:15 +0000)]
2012-02-02  Nate Chapin  <japhet@chromium.org>

        Unreviewed, chromium expectations update.
        Remove custom chromium-mac expectation for fast/canvas/fillPath-shadow.html,
        since it's failing the same way as chromium win/linux.

        * platform/chromium-mac/fast/canvas/canvas-fillPath-shadow-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r106566.
commit-queue@webkit.org [Thu, 2 Feb 2012 21:10:12 +0000 (21:10 +0000)]
Unreviewed, rolling out r106566.
http://trac.webkit.org/changeset/106566
https://bugs.webkit.org/show_bug.cgi?id=77673

Broke the Windows build (Requested by jessieberlin on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-02

Source/WebCore:

* WebCore.vcproj/copyForwardingHeaders.cmd:
* platform/graphics/ca/win/PlatformCALayerWin.cpp:

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests:

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2012-02-02 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Thu, 2 Feb 2012 21:04:44 +0000 (21:04 +0000)]
2012-02-02  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed, updating Chromium test expectations.
        https://bugs.webkit.org/show_bug.cgi?id=73681

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r106543.
rniwa@webkit.org [Thu, 2 Feb 2012 21:03:42 +0000 (21:03 +0000)]
Unreviewed, rolling out r106543.
http://trac.webkit.org/changeset/106543
https://bugs.webkit.org/show_bug.cgi?id=77671

Made tests less stable (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-02

PerformanceTests:

* resources/init.html: Removed.

Tools:

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner):
(PerfTestsRunner.__init__):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.TestDriver.run_test):
(run_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2012-02-02 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 2 Feb 2012 21:00:26 +0000 (21:00 +0000)]
2012-02-02  Nate Chapin  <japhet@chromium.org>

        Unreviewed, chromium expectations update.
        Mark some touch event tests as crashing, since they're
        asserting as of r106554.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] MediaStream API: Adding the embedding code for MediaStreamCenter
tommyw@google.com [Thu, 2 Feb 2012 20:53:58 +0000 (20:53 +0000)]
[chromium] MediaStream API: Adding the embedding code for MediaStreamCenter
https://bugs.webkit.org/show_bug.cgi?id=73130

Reviewed by Darin Fisher.

Source/WebCore:

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

* mediastream/UserMediaClient.h:
(UserMediaClient):
* mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::didCompleteQuery):
* mediastream/UserMediaRequest.h:
(UserMediaRequest):
(WebCore::UserMediaRequest::audio):
(WebCore::UserMediaRequest::video):
(WebCore::UserMediaRequest::cameraPreferenceUser):
(WebCore::UserMediaRequest::cameraPreferenceEnvironment):
* platform/mediastream/MediaStreamCenter.cpp:
(WebCore):
(WebCore::MediaStreamCenter::queryMediaStreamSources):
* platform/mediastream/MediaStreamCenter.h:
(WebCore):
(MediaStreamSourcesQueryClient):
(MediaStreamCenter):

Source/WebKit/chromium:

* WebKit.gyp:
* bridge/MediaStreamCenter.cpp: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.
(WebCore):
(WebCore::MediaStreamCenter::MediaStreamCenter):
(WebCore::MediaStreamCenter::~MediaStreamCenter):
(WebCore::MediaStreamCenter::queryMediaStreamSources):
(WebCore::MediaStreamCenter::didSetMediaStreamTrackEnabled):
(WebCore::MediaStreamCenter::didStopLocalMediaStream):
(WebCore::MediaStreamCenter::didConstructMediaStream):
* bridge/MediaStreamCenterInternal.cpp: Added.
(WebCore):
(WebCore::MediaStreamCenterInternal::MediaStreamCenterInternal):
(WebCore::MediaStreamCenterInternal::~MediaStreamCenterInternal):
(WebCore::MediaStreamCenterInternal::queryMediaStreamSources):
(WebCore::MediaStreamCenterInternal::didSetMediaStreamTrackEnabled):
(WebCore::MediaStreamCenterInternal::didStopLocalMediaStream):
(WebCore::MediaStreamCenterInternal::didConstructMediaStream):
(WebCore::MediaStreamCenterInternal::stopLocalMediaStream):
* bridge/MediaStreamCenterInternal.h: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.
(WebKit):
(WebCore):
(MediaStreamCenterInternal):
* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKit::WebKitPlatformSupport::createMediaStreamCenter):
* public/platform/WebMediaStreamCenter.h: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.
(WebKit):
(WebMediaStreamCenter):
(WebKit::WebMediaStreamCenter::~WebMediaStreamCenter):
* public/platform/WebMediaStreamCenterClient.h: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.
(WebKit):
(WebMediaStreamCenterClient):
(WebKit::WebMediaStreamCenterClient::~WebMediaStreamCenterClient):
* public/platform/WebMediaStreamComponent.h: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.
(WebCore):
(WebKit):
(WebMediaStreamComponent):
(WebKit::WebMediaStreamComponent::WebMediaStreamComponent):
(WebKit::WebMediaStreamComponent::~WebMediaStreamComponent):
(WebKit::WebMediaStreamComponent::isNull):
* public/platform/WebMediaStreamDescriptor.h:
(WebKit):
(WebMediaStreamDescriptor):
* public/platform/WebMediaStreamSourcesRequest.h: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.
(WebCore):
(WebKit):
(WebMediaStreamSourcesRequest):
(WebKit::WebMediaStreamSourcesRequest::WebMediaStreamSourcesRequest):
(WebKit::WebMediaStreamSourcesRequest::~WebMediaStreamSourcesRequest):
(WebKit::WebMediaStreamSourcesRequest::isNull):
* src/UserMediaClientImpl.h:
(UserMediaClientImpl):
* src/WebMediaStreamComponent.cpp: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.
(WebKit):
(WebKit::WebMediaStreamComponent::WebMediaStreamComponent):
(WebKit::WebMediaStreamComponent::operator=):
(WebKit::WebMediaStreamComponent::reset):
(WebKit::WebMediaStreamComponent::operator PassRefPtr<MediaStreamComponent>):
(WebKit::WebMediaStreamComponent::operator MediaStreamComponent*):
(WebKit::WebMediaStreamComponent::isEnabled):
(WebKit::WebMediaStreamComponent::source):
* src/WebMediaStreamDescriptor.cpp:
(WebKit::WebMediaStreamDescriptor::WebMediaStreamDescriptor):
(WebKit):
(WebKit::WebMediaStreamDescriptor::audioSources):
(WebKit::WebMediaStreamDescriptor::videoSources):
* src/WebMediaStreamSourcesRequest.cpp: Copied from Source/WebKit/chromium/src/UserMediaClientImpl.h.
(WebKit):
(WebKit::WebMediaStreamSourcesRequest::WebMediaStreamSourcesRequest):
(WebKit::WebMediaStreamSourcesRequest::reset):
(WebKit::WebMediaStreamSourcesRequest::audio):
(WebKit::WebMediaStreamSourcesRequest::video):
(WebKit::WebMediaStreamSourcesRequest::didCompleteQuery):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConstant values to set "distanceModel" are undefined
commit-queue@webkit.org [Thu, 2 Feb 2012 20:46:43 +0000 (20:46 +0000)]
Constant values to set "distanceModel" are undefined
https://bugs.webkit.org/show_bug.cgi?id=74273

Patch by Raymond Toy <rtoy@google.com> on 2012-02-02
Reviewed by Kenneth Russell.

Source/WebCore:

Tests: webaudio/distance-exponential.html
       webaudio/distance-inverse.html
       webaudio/distance-linear.html

* webaudio/AudioPannerNode.h: Define enum for the new constants
for the distance models.
* webaudio/AudioPannerNode.idl: Define matching constants for the
distance models.

LayoutTests:

* webaudio/distance-exponential-expected.txt: Added.
* webaudio/distance-exponential.html: Added.
* webaudio/distance-inverse-expected.txt: Added.
* webaudio/distance-inverse.html: Added.
* webaudio/distance-linear-expected.txt: Added.
* webaudio/distance-linear.html: Added.
* webaudio/resources/distance-model-testing.js: Added.
(createImpulseBuffer):
(linearDistance):
(exponentialDistance):
(inverseDistance):
(createGraph):
(startSources):
(equalPowerGain):
(checkDistanceResult.return.renderedBuffer):
(checkDistanceResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIllegal panner model values should throw an exception
commit-queue@webkit.org [Thu, 2 Feb 2012 20:29:20 +0000 (20:29 +0000)]
Illegal panner model values should throw an exception
https://bugs.webkit.org/show_bug.cgi?id=77235

Patch by Raymond Toy <rtoy@google.com> on 2012-02-02
Reviewed by Kenneth Russell.

Source/WebCore:

Modified existing panner-set-model test to catch exceptions.
Debug build should not crash anymore.

* webaudio/AudioPannerNode.cpp:
(WebCore::AudioPannerNode::setPanningModel):  Throw exception for
invalid model values.
* webaudio/AudioPannerNode.h:
(AudioPannerNode): Update declaration
* webaudio/AudioPannerNode.idl: Setting panner model can throw
exception.

LayoutTests:

* webaudio/panner-set-model-expected.txt: Updated.
* webaudio/panner-set-model.html: Catch the errors that are thrown
for invalid panning model values.
* platform/chromium/test_expectations.txt: Remove test that no
longer crashes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2012-02-02 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 2 Feb 2012 20:02:39 +0000 (20:02 +0000)]
2012-02-02  Nate Chapin  <japhet@chromium.org>

        Unreviewed, chromium expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=77664
bdakin@apple.com [Thu, 2 Feb 2012 20:02:23 +0000 (20:02 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=77664
Add API tests for didNewFirstVisuallyNonEmptyLayout

Reviewed by Darin Adler.

Two new tests.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::didForceRepaint):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Added.
(TestWebKitAPI):
(NewFirstVisuallyNonEmptyLayoutFailsTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::NewFirstVisuallyNonEmptyLayoutFailsTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Added.
(TestWebKitAPI):
(NewFirstVisuallyNonEmptyLayoutTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::NewFirstVisuallyNonEmptyLayoutTest):
(TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium rebaseline after r106543.
rniwa@webkit.org [Thu, 2 Feb 2012 19:49:31 +0000 (19:49 +0000)]
Chromium rebaseline after r106543.

* platform/chromium/fast/events/remove-target-with-shadow-in-drag-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename [ConvertUndefinedOrNullToNullString] to
haraken@chromium.org [Thu, 2 Feb 2012 19:24:23 +0000 (19:24 +0000)]
Rename [ConvertUndefinedOrNullToNullString] to
[TreatNullAs=EmptyString, TreatUndefinedAs=EmptyString]
https://bugs.webkit.org/show_bug.cgi?id=77611

Reviewed by Adam Barth.

This patch renames [ConvertUndefinedOrNullToNullString] to
[TreatNullAs=EmptyString, TreatUndefinedAs=EmptyString], according to the spec
(http://dev.w3.org/2006/webapi/WebIDL/#TreatNullAs,
http://dev.w3.org/2006/webapi/WebIDL/#TreatUndefinedAs).

No tests. No changes in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(JSValueToNative):
* bindings/scripts/CodeGeneratorV8.pm:
(GetNativeTypeFromSignature):
* dom/DOMImplementation.idl:
* dom/Document.idl:
* fileapi/Blob.idl:
* fileapi/DirectoryEntry.idl:
* fileapi/DirectoryEntrySync.idl:
* fileapi/Entry.idl:
* fileapi/EntrySync.idl:
* fileapi/WebKitBlobBuilder.idl:
* html/HTMLButtonElement.idl:
* html/HTMLCanvasElement.idl:
* html/HTMLFieldSetElement.idl:
* html/HTMLInputElement.idl:
* html/HTMLKeygenElement.idl:
* html/HTMLObjectElement.idl:
* html/HTMLOutputElement.idl:
* html/HTMLSelectElement.idl:
* html/HTMLTextAreaElement.idl:
* page/Console.idl:
* page/DOMWindow.idl:

* bindings/scripts/test/TestObj.idl: No changes in run-bindings-tests results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix type punning warning in HashTable.h debug builds
commit-queue@webkit.org [Thu, 2 Feb 2012 19:12:48 +0000 (19:12 +0000)]
Fix type punning warning in HashTable.h debug builds
https://bugs.webkit.org/show_bug.cgi?id=77422

Patch by Andy Wingo <wingo@igalia.com> on 2012-02-02
Reviewed by Gavin Barraclough.

* wtf/HashTable.h (WTF::HashTable::checkKey): Fix type punning
warning appearing in debug builds with gcc-4.6.2 on GNU/Linux.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Thu, 2 Feb 2012 19:06:16 +0000 (19:06 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-02

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNPAPI will not send mouse up events when mouse is outside plugin area
andersca@apple.com [Thu, 2 Feb 2012 19:03:29 +0000 (19:03 +0000)]
NPAPI will not send mouse up events when mouse is outside plugin area
https://bugs.webkit.org/show_bug.cgi?id=77657
<rdar://problem/10160674>

Reviewed by Andreas Kling.

Source/WebCore:

Export EventHandler::setCapturingMouseEventsNode.

* WebCore.exp.in:

Source/WebKit2:

Use EventHandler::setCapturingMouseEventsNode to ensure we get all the mouse events when the mouse is down.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::handleEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Unreviewed gardening.
ossy@webkit.org [Thu, 2 Feb 2012 18:59:09 +0000 (18:59 +0000)]
[Qt][WK2] Unreviewed gardening.
https://bugs.webkit.org/show_bug.cgi?id=67485

* platform/qt-wk2/Skipped:
  - fast/dom/Window/window-properties.html: unskip, it needed only update
  - fast/text/complex-preferred-logical-widths.html: unskip, it passes now
  - http/tests/loading/empty-urls.html: unskip, it doesn't exist now
  - http/tests/loading/progress-finished-callback.html: move to the correct place
* platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Thu, 2 Feb 2012 18:37:36 +0000 (18:37 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped: Unskip a now passing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPaint the Qt Mac bot green.
ossy@webkit.org [Thu, 2 Feb 2012 18:08:55 +0000 (18:08 +0000)]
Paint the Qt Mac bot green.

* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove remaining implementation from CSSStyleDeclaration to subclasses
antti@apple.com [Thu, 2 Feb 2012 18:08:08 +0000 (18:08 +0000)]
Move remaining implementation from CSSStyleDeclaration to subclasses
https://bugs.webkit.org/show_bug.cgi?id=77621

Reviewed by Andreas Kling.

This leaves CSSStyleDeclaration a near-pure CSSOM interface.

* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::isCSSPropertyName):
(WebCore::JSCSSStyleDeclaration::putDelegate):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::parentRule):
(WebCore):
* css/CSSComputedStyleDeclaration.h:
(CSSComputedStyleDeclaration):
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::contextStyleSheet):
(WebCore):
(WebCore::CSSMutableStyleDeclaration::parentRule):
* css/CSSMutableStyleDeclaration.h:
(WebCore::CSSMutableStyleDeclaration::isInlineStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::parentRuleInternal):
(WebCore::CSSMutableStyleDeclaration::clearParentRule):
(CSSMutableStyleDeclaration):
(WebCore::CSSMutableStyleDeclaration::parentElement):
(WebCore::CSSMutableStyleDeclaration::clearParentElement):
(WebCore::CSSMutableStyleDeclaration::parentStyleSheet):
* css/CSSParser.cpp:
(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseDeclaration):
* css/CSSStyleDeclaration.cpp:
(WebCore):
* css/CSSStyleDeclaration.h:
(CSSStyleDeclaration):
(WebCore::CSSStyleDeclaration::parentStyleSheet):
(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):

    Eliminate unnecessary call to CSSMutableStyleDeclaration::parentStyleSheet()

* css/CSSStyleRule.h:
(WebCore::CSSStyleRule::setDeclaration):
* css/CSSStyleSelector.cpp:
(WebCore::isInsideRegionRule):
(WebCore::CSSStyleSelector::applyDeclaration):
* css/WebKitCSSKeyframeRule.cpp:
(WebCore::WebKitCSSKeyframeRule::setDeclaration):
* page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):
(WebCore::PageSerializer::serializeCSSStyleSheet):
(WebCore::PageSerializer::retrieveResourcesForCSSRule):
(WebCore::PageSerializer::retrieveResourcesForCSSDeclaration):
* page/PageSerializer.h:

    Eliminate unnecessary call to CSSMutableStyleDeclaration::parentStyleSheet()

(WebCore):
(PageSerializer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] One more unreviewed gardening after r106487
ossy@webkit.org [Thu, 2 Feb 2012 18:03:20 +0000 (18:03 +0000)]
[Qt] One more unreviewed gardening after r106487
https://bugs.webkit.org/show_bug.cgi?id=77628

* platform/qt-5.0/Skipped:
* platform/qt-wk2/Skipped:
* platform/qt/Skipped: Skip new crashing tests after r106554.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTurn on CSS Filters on Windows
cmarrin@apple.com [Thu, 2 Feb 2012 17:58:45 +0000 (17:58 +0000)]
Turn on CSS Filters on Windows
https://bugs.webkit.org/show_bug.cgi?id=76667

Source/WebCore:

Turning on CSS_FILTERS flag for Windows and fixed a couple of resultant build errors

Reviewed by Adele Peterson.

* WebCore.vcproj/copyForwardingHeaders.cmd:
* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayer::setFilters):
(PlatformCALayer::filtersCanBeComposited):

WebKitLibraries:

Turned on CSS_FILTERS for Windows

Reviewed by Adele Peterson.

* win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests:

Skipped filter test files not supported on Windows

Reviewed by Adele Peterson.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove ScrollingThread to its own file
andersca@apple.com [Thu, 2 Feb 2012 17:44:16 +0000 (17:44 +0000)]
Move ScrollingThread to its own file
https://bugs.webkit.org/show_bug.cgi?id=77652

Reviewed by Sam Weinig.

This just shuffles some classes around and makes ScrollingCoordinator call into ScrollingThread.
Hopefully we'll be able to make ScrollingThread use the new WebCore::RunLoop class eventually.

* WebCore.xcodeproj/project.pbxproj:
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::handleWheelEvent):
* page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
* page/scrolling/ScrollingThread.cpp: Added.
(WebCore):
(WebCore::ScrollingThread::ScrollingThread):
(WebCore::ScrollingThread::isCurrentThread):
(WebCore::ScrollingThread::dispatch):
(WebCore::ScrollingThread::shared):
(WebCore::ScrollingThread::createThreadIfNeeded):
(WebCore::ScrollingThread::threadCallback):
(WebCore::ScrollingThread::threadBody):
(WebCore::ScrollingThread::dispatchFunctionsFromScrollingThread):
* page/scrolling/ScrollingThread.h: Added.
(WebCore):
(ScrollingThread):
* page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinator::scrollByOnScrollingThread):
(WebCore::ScrollingCoordinator::updateMainFrameScrollLayerPositionOnScrollingThread):
* page/scrolling/mac/ScrollingThreadMac.mm: Added.
(WebCore):
(WebCore::ScrollingThread::initializeRunLoop):
(WebCore::ScrollingThread::wakeUpRunLoop):
(WebCore::ScrollingThread::threadRunLoopSourceCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium baselines for new tests in r106551.
tonyg@chromium.org [Thu, 2 Feb 2012 17:39:43 +0000 (17:39 +0000)]
Unreviewed chromium baselines for new tests in r106551.

* platform/chromium-mac-leopard/svg/custom/glyph-selection-arabic-forms-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
* platform/chromium-mac-leopard/svg/custom/glyph-selection-bidi-mirror-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/glyph-selection-non-bmp-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/glyph-selection-arabic-forms-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/custom/glyph-selection-bidi-mirror-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/custom/glyph-selection-non-bmp-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/glyph-selection-non-bmp-expected.txt: Added.
* platform/chromium-win/svg/custom/glyph-selection-arabic-forms-expected.png: Added.
* platform/chromium-win/svg/custom/glyph-selection-bidi-mirror-expected.png: Added.
* platform/chromium-win/svg/custom/glyph-selection-non-bmp-expected.png: Added.
* platform/chromium-win/svg/custom/glyph-selection-non-bmp-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r106551.
commit-queue@webkit.org [Thu, 2 Feb 2012 17:20:15 +0000 (17:20 +0000)]
Unreviewed, rolling out r106551.
http://trac.webkit.org/changeset/106551
https://bugs.webkit.org/show_bug.cgi?id=77648

Breaking mac and gtk tests due to font differences. (Requested
by _pdr_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-02

Source/WebCore:

* platform/graphics/SVGGlyph.cpp:
(WebCore::charactersWithArabicForm):
* svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):
* svg/SVGFontData.h:
(SVGFontData):

LayoutTests:

* svg/custom/glyph-selection-arabic-forms-expected.png: Removed.
* svg/custom/glyph-selection-arabic-forms-expected.txt: Removed.
* svg/custom/glyph-selection-arabic-forms.svg: Removed.
* svg/custom/glyph-selection-bidi-mirror-expected.png: Removed.
* svg/custom/glyph-selection-bidi-mirror-expected.txt: Removed.
* svg/custom/glyph-selection-bidi-mirror.svg: Removed.
* svg/custom/glyph-selection-non-bmp-expected.png: Removed.
* svg/custom/glyph-selection-non-bmp-expected.txt: Removed.
* svg/custom/glyph-selection-non-bmp.svg: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Remove check for ENABLE_GTK_PLUGINS_SUPPORT
kubo@profusion.mobi [Thu, 2 Feb 2012 17:15:01 +0000 (17:15 +0000)]
[EFL] Remove check for ENABLE_GTK_PLUGINS_SUPPORT
https://bugs.webkit.org/show_bug.cgi?id=77647

Reviewed by Martin Robinson.

There is no clear reason why this check was in place (it came with the
upstreaming of the port), but ENABLE_GTK_PLUGINS_SUPPORT is not set
anywhere, and the build system does not even check for the presence of
GTK+ when building.

* ewk/ewk_main.cpp:
(_ewk_init_body):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd myself as a reviewer.
msaboff@apple.com [Thu, 2 Feb 2012 16:59:17 +0000 (16:59 +0000)]
Add myself as a reviewer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [REGRESSION] Slow continuous DOM traversal with Up/Down keys
apavlov@chromium.org [Thu, 2 Feb 2012 16:40:15 +0000 (16:40 +0000)]
Web Inspector: [REGRESSION] Slow continuous DOM traversal with Up/Down keys
https://bugs.webkit.org/show_bug.cgi?id=77643

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/updates-during-dom-traversal.html

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate):

LayoutTests:

* inspector/styles/updates-during-dom-traversal-expected.txt: Added.
* inspector/styles/updates-during-dom-traversal.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] WebKitWebView won't work in a GtkOffscreenWindow
commit-queue@webkit.org [Thu, 2 Feb 2012 16:28:14 +0000 (16:28 +0000)]
[GTK] WebKitWebView won't work in a GtkOffscreenWindow
https://bugs.webkit.org/show_bug.cgi?id=76911

Patch by Claudio Saavedra  <csaavedra@igalia.com> and Martin Robinson <mrobinson@igalia.com> on 2012-02-02
Reviewed by Philippe Normand.

Source/WebCore:

* platform/gtk/GtkUtilities.cpp:
(WebCore::widgetIsOnscreenToplevelWindow): Added this helper.
* platform/gtk/GtkUtilities.h:
(WebCore): Added helper declaration.

Source/WebKit/gtk:

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::windowRect): Use the new widgetIsOnscreenToplevelWindow helper.
(WebKit::ChromeClient::setWindowRect): Ditto.
(WebKit::ChromeClient::unfocus): Ditto.
(WebKit::ChromeClient::runOpenPanel): Ditto.
* tests/testwebview.c: Added a test to ensure that loading a page in an offscreen window does not crash.
* webkit/webkitglobals.cpp:
(currentToplevelCallback):
* webkit/webkitwebframe.cpp:
(webkit_web_frame_print_full):
(webkit_web_frame_print):
* webkit/webkitwebview.cpp:
(webkit_web_view_focus_in_event):
(webkit_web_view_script_dialog):

Source/WebKit2:

* UIProcess/API/gtk/WebKitUIClient.cpp:
(getWindowFrame): Use the new helper.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewCreateJavaScriptDialog): Ditto
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseRealize): Ditto.
(webkitWebViewBaseSizeAllocate): Ditto.
(webkitWebViewBaseFocusInEvent): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofast/speech/bubble-position.html fails on mac
tonyg@chromium.org [Thu, 2 Feb 2012 15:53:23 +0000 (15:53 +0000)]
fast/speech/bubble-position.html fails on mac
https://bugs.webkit.org/show_bug.cgi?id=77641

Unreviewed expectations update.

* platform/chromium/test_expectations.txt: Test introduced by 106438, never passed on mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][Mac] Unreviewed gardening, skip new failing tests to paint the bot green.
ossy@webkit.org [Thu, 2 Feb 2012 15:48:54 +0000 (15:48 +0000)]
[Qt][Mac] Unreviewed gardening, skip new failing tests to paint the bot green.

* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed rebaseline of imperceptible shadow change.
tonyg@chromium.org [Thu, 2 Feb 2012 15:27:19 +0000 (15:27 +0000)]
Unreviewed rebaseline of imperceptible shadow change.

* platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-clipped-slices-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening after r106551.
ossy@webkit.org [Thu, 2 Feb 2012 15:13:02 +0000 (15:13 +0000)]
[Qt] Unreviewed gardening after r106551.

* platform/qt/Skipped: Skip new tests because of missing testfonts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Update active and hover state on touch release.
commit-queue@webkit.org [Thu, 2 Feb 2012 15:09:48 +0000 (15:09 +0000)]
Source/WebCore: Update active and hover state on touch release.
https://bugs.webkit.org/show_bug.cgi?id=77620

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-02
Reviewed by Kenneth Rohde Christiansen.

* rendering/HitTestRequest.h:
(WebCore::HitTestRequest::move):
(WebCore::HitTestRequest::release):
(WebCore::HitTestRequest::touchEvent):
(WebCore::HitTestRequest::mouseEvent):
(WebCore::HitTestRequest::touchMove):
(WebCore::HitTestRequest::touchRelease):
    Rename the enum values in HitTestRequest to be mouse/touch
    agnostic, and add value for recognizing touch events.
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::nodeAtPoint): Update for HitTestRequest rename.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTest): ditto
(WebCore::RenderLayer::updateHoverActiveState): Reset hoverstate on touch release.
* page/EventHandler.cpp:
(WebCore::EventHandler::updateSelectionForMouseDrag): Update for HitTestRequest rename.
(WebCore::EventHandler::handleMouseMoveEvent): ditto
(WebCore::EventHandler::handleMouseReleaseEvent): ditto
(WebCore::EventHandler::hoverTimerFired): ditto
(WebCore::EventHandler::dragSourceEndedAt): ditto
(WebCore::EventHandler::handleTouchEvent): Hittest touch release to reset
    active and hover states and add touch enum to all touch hittests.

Source/WebKit/chromium: Update enum name for HitTestRequest::RequestType
https://bugs.webkit.org/show_bug.cgi?id=77620

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-02-02
Reviewed by Kenneth Rohde Christiansen.

* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::visiblePositionForWindowPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening after r106487
ossy@webkit.org [Thu, 2 Feb 2012 14:47:21 +0000 (14:47 +0000)]
[Qt] Unreviewed gardening after r106487
https://bugs.webkit.org/show_bug.cgi?id=77628

Patch by J├ínos Badics <dicska@gmail.com> on 2012-02-02

* platform/qt-wk2/Skipped: Skip the test made fast/events/resize-subframe.html timeout.
* platform/qt/fast/events/remove-target-with-shadow-in-drag-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: enable editing of selected rows on single click in elements panel.
pfeldman@chromium.org [Thu, 2 Feb 2012 14:28:39 +0000 (14:28 +0000)]
Web Inspector: enable editing of selected rows on single click in elements panel.
https://bugs.webkit.org/show_bug.cgi?id=77627

Reviewed by Vsevolod Vlasov.

* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype.onattach):
(WebInspector.ElementsTreeElement.prototype.onselect):
(WebInspector.ElementsTreeElement.prototype._mouseDown):
* inspector/front-end/treeoutline.js:
(TreeElement.prototype.selectOnMouseDown):
(TreeElement.prototype.select):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix mirroring with SVG fonts
commit-queue@webkit.org [Thu, 2 Feb 2012 14:27:10 +0000 (14:27 +0000)]
Fix mirroring with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=77067

Patch by Philip Rogers <pdr@google.com> on 2012-02-02
Reviewed by Nikolas Zimmermann.

Source/WebCore:

SVG fonts were incorrectly handling mirrored characters in bidi text.
In this change I added the function createStringWithMirroredCharacters
which handles mirroring the characters when selecting glyphs for SVG
fonts. I also made a small cosmetic change in the function
charactersWithArabicForm, changing the bool parameter "mirror" to "rtl"
which better reflects what it actually does.

Several new tests were added to test mirroring with SVG fonts in the
presence of Arabic forms and non-BMP characters.

Tests: svg/custom/glyph-selection-arabic-forms.svg
       svg/custom/glyph-selection-bidi-mirror.svg
       svg/custom/glyph-selection-non-bmp.svg

* platform/graphics/SVGGlyph.cpp:
(WebCore::charactersWithArabicForm):
* svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):
(WebCore::SVGFontData::createStringWithMirroredCharacters):
* svg/SVGFontData.h:
(SVGFontData):

LayoutTests:

SVG fonts were incorrectly handling mirrored characters in bidi text.
In this change I added the function createStringWithMirroredCharacters
which handles mirroring the characters when selecting glyphs for SVG
fonts. I also made a small cosmetic change in the function
charactersWithArabicForm, changing the bool parameter "mirror" to "rtl"
which better reflects what it actually does.

Several new tests were added to test mirroring with SVG fonts in the
presence of Arabic forms and non-BMP characters.

* svg/custom/glyph-selection-arabic-forms-expected.txt: Added.
* svg/custom/glyph-selection-arabic-forms.svg: Added.
* svg/custom/glyph-selection-bidi-mirror-expected.txt: Added.
* svg/custom/glyph-selection-bidi-mirror.svg: Added.
* svg/custom/glyph-selection-non-bmp-expected.txt: Added.
* svg/custom/glyph-selection-non-bmp.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: add experiment for single click styles editing.
pfeldman@chromium.org [Thu, 2 Feb 2012 14:25:15 +0000 (14:25 +0000)]
Web Inspector: add experiment for single click styles editing.
https://bugs.webkit.org/show_bug.cgi?id=77624

Reviewed by Vsevolod Vlasov.

* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertyTreeElement.prototype.onattach):
(WebInspector.StylePropertyTreeElement.prototype._mouseDown):
(WebInspector.StylePropertyTreeElement.prototype._resetMouseDownElement):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.selectElement.context):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd myself as a commiter
kkristof@inf.u-szeged.hu [Thu, 2 Feb 2012 14:13:36 +0000 (14:13 +0000)]
Add myself as a commiter

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, marking a new test as flaky on GTK.
philn@webkit.org [Thu, 2 Feb 2012 13:58:20 +0000 (13:58 +0000)]
Unreviewed, marking a new test as flaky on GTK.

* platform/gtk/test_expectations.txt:
fast/forms/radio/radio-group.html fails on and off.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake the tap highlighting work for all test cases
kenneth@webkit.org [Thu, 2 Feb 2012 13:53:57 +0000 (13:53 +0000)]
Make the tap highlighting work for all test cases
https://bugs.webkit.org/show_bug.cgi?id=77626

Reviewed by Simon Hausmann.

Clean up of the current code to make it more generic. Now uses
addFocusRingRects for finding the areas to highlight.

Tested by current manual tests.

* page/GestureTapHighlighter.cpp:
(WebCore::GestureTapHighlighter::pathForNodeHighlight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK rebaseline and skipping 3 new test failures.
philn@webkit.org [Thu, 2 Feb 2012 13:42:07 +0000 (13:42 +0000)]
Unreviewed, GTK rebaseline and skipping 3 new test failures.

* platform/gtk/Skipped:
* platform/gtk/fast/events/remove-target-with-shadow-in-drag-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Gtk] atk_text_get_text_at_offset() sometimes fails to provide the correct line
mario@webkit.org [Thu, 2 Feb 2012 13:18:09 +0000 (13:18 +0000)]
[Gtk] atk_text_get_text_at_offset() sometimes fails to provide the correct line
https://bugs.webkit.org/show_bug.cgi?id=72382

Reviewed by Martin Robinson.

Source/WebCore:

Do not add unnecesary blanks at the end of a line of text.

* accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
(textForRenderer): Do not just append a '\n' at the end of a line
if the linebreak for that line was already considered.

Source/WebKit/gtk:

New unit test to ensure the right line is retrieved for the first
position of each line in a multiline preformatted portion of text.

* tests/testatk.c:
(testWebkitAtkGetTextAtOffsetWithPreformattedText): New unit test.
(main): Add the new unit test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRegions should ignore the saved currentRenderFlowThread during repainting
commit-queue@webkit.org [Thu, 2 Feb 2012 10:25:25 +0000 (10:25 +0000)]
Regions should ignore the saved currentRenderFlowThread during repainting
because if there are imbricated flow threads, it might end using the wrong one.

[CSSRegions] Assert failure in RenderView::computeRectForRepaint
https://bugs.webkit.org/show_bug.cgi?id=77430

Patch by Raul Hudea <rhudea@adobe.com> on 2012-02-02
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/imbricated-flow-threads-crash.html

* rendering/RenderFlowThread.cpp:
(CurrentRenderFlowThreadDisabler):
(WebCore::CurrentRenderFlowThreadDisabler::CurrentRenderFlowThreadDisabler):
(WebCore::CurrentRenderFlowThreadDisabler::~CurrentRenderFlowThreadDisabler):
(WebCore):
(WebCore::RenderFlowThread::repaintRectangleInRegions):

LayoutTests:

* fast/regions/imbricated-flow-threads-crash-expected.txt: Added.
* fast/regions/imbricated-flow-threads-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[PerformanceTests] tests have dependencies
rniwa@webkit.org [Thu, 2 Feb 2012 10:24:29 +0000 (10:24 +0000)]
[PerformanceTests] tests have dependencies
https://bugs.webkit.org/show_bug.cgi?id=77506

Reviewed by Hajime Morita.

PerformanceTests:

* resources/init.html: Added.

Tools:

Load an initialization page before each test after starting a DRT so that
warming up DRT won't affect the performance test results.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner):
(PerfTestsRunner.__init__):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.TestDriver.run_test):
(test_initial_page_loaded):
(test_initial_page_loaded.run_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCleanup: Move chrome-specific filesystem type handling code (for FileSystem API)...
kinuko@chromium.org [Thu, 2 Feb 2012 09:31:21 +0000 (09:31 +0000)]
Cleanup: Move chrome-specific filesystem type handling code (for FileSystem API) under chromium directory (re-landing r105395)
https://bugs.webkit.org/show_bug.cgi?id=76551

Source/WebCore:

Reviewed by David Levin.

Moved the implementation of crackFileSystemURL() and toURL() from
WebCore/fileapi/DOMFileSystemBase into WebCore/platform/AsyncFileSystem
so that each platform can extend/implement their behavior if necessary.

No new tests as it has no functional changes.

* fileapi/DOMFileSystemBase.cpp: Moved crackFileSystemURL() to AsyncFileSystem.
* fileapi/DOMFileSystemBase.h:
(DOMFileSystemBase):
* fileapi/EntryBase.cpp: Moved toURL() to AsyncFileSystem.
(WebCore::EntryBase::toURL):
* page/DOMWindow.cpp: Made corresponding callsite changes.
(WebCore::DOMWindow::webkitRequestFileSystem):
(WebCore::DOMWindow::webkitResolveLocalFileSystemURL):
* page/DOMWindow.h:
* platform/AsyncFileSystem.cpp:
(WebCore::AsyncFileSystem::isValidType): Added.
* platform/AsyncFileSystem.h:
(AsyncFileSystem):
* workers/WorkerContext.cpp: Made corresponding callsite changes.
(WebCore::WorkerContext::webkitRequestFileSystem):
(WebCore::WorkerContext::webkitRequestFileSystemSync):
(WebCore::WorkerContext::webkitResolveLocalFileSystemURL):
(WebCore::WorkerContext::webkitResolveLocalFileSystemSyncURL):
* workers/WorkerContext.h:

Source/WebKit/chromium:

* src/AssertMatchingEnums.cpp: Removed the matching assertion for AsyncFileSystem::External (as now we directly use WebFileSystem::TypeExternal).
* src/AsyncFileSystemChromium.cpp:
(WebCore::AsyncFileSystem::crackFileSystemURL): Added.
(WebCore::AsyncFileSystem::isValidType): Added.
(WebCore::AsyncFileSystemChromium::toURL): Added.
* src/AsyncFileSystemChromium.h:
(AsyncFileSystemChromium):
* src/WorkerAsyncFileSystemChromium.cpp: Made this subclass of AsyncFileSystemChromium (rather than that of AsyncFileSystem)
(WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium):
* src/WorkerAsyncFileSystemChromium.h:
(WorkerAsyncFileSystemChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: pause on uncaugh exceptions state is not properly restored
yurys@chromium.org [Thu, 2 Feb 2012 09:12:47 +0000 (09:12 +0000)]
Web Inspector: pause on uncaugh exceptions state is not properly restored
https://bugs.webkit.org/show_bug.cgi?id=77558

'Pause on exceptions' state is now stored in InspectorState object so that it is
properly restored on inspected process change.

Reviewed by Vsevolod Vlasov.

* inspector/InspectorDebuggerAgent.cpp:
(DebuggerAgentState):
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::disable):
(WebCore::InspectorDebuggerAgent::restore):
(WebCore::InspectorDebuggerAgent::setPauseOnExceptions):
(WebCore):
(WebCore::InspectorDebuggerAgent::setPauseOnExceptionsImpl):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRe-land r106442 per Adam's suggestion. We'll do both restarting DRT and loading a...
rniwa@webkit.org [Thu, 2 Feb 2012 08:27:21 +0000 (08:27 +0000)]
Re-land r106442 per Adam's suggestion. We'll do both restarting DRT and loading a fake test first.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(create_runner):
(test_run_passing_test):
(test_run_silent_test):
(test_run_failed_test):
(test_run_tonguey_test):
(test_run_timeout_test):
(test_run_crash_test):
(test_run_test_set_kills_drt_per_run):
(test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
(test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
(test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe third argument of addEventListener/removeEventListener of PeerConnection should...
haraken@chromium.org [Thu, 2 Feb 2012 08:23:59 +0000 (08:23 +0000)]
The third argument of addEventListener/removeEventListener of PeerConnection should be optional
https://bugs.webkit.org/show_bug.cgi?id=77606

Reviewed by Adam Barth.

Source/WebCore:

This patch corrects a typo in PeerConnection.idl, i.e. [optional] => [Optional].

Test: fast/mediastream/peerconnection-eventlistener-optional-argument.html

* mediastream/PeerConnection.idl:

LayoutTests:

The added test confirms if the third argument of addEventListener() and
removeEventListener() is optional.

* fast/mediastream/peerconnection-eventlistener-optional-argument-expected.txt: Added.
* fast/mediastream/peerconnection-eventlistener-optional-argument.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohidden attribute on <input type=file /> suppresses the file selection dialog
commit-queue@webkit.org [Thu, 2 Feb 2012 08:09:07 +0000 (08:09 +0000)]
hidden attribute on <input type=file /> suppresses the file selection dialog
https://bugs.webkit.org/show_bug.cgi?id=58208

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-02-02
Reviewed by Ryosuke Niwa.

.:

* ManualTests/input-file-hidden-open-dialog-on-click.html: Added.
Adding manual test as the file dialog opens only in User gesture.

Source/WebCore:

We want to allow opening file dialog on hidden element when click() is called
on the element. The behaviour is similar to Firefox and IE.

Added manual test as the file dialog opens only on user gesture.

* html/FileInputType.cpp:
(WebCore::FileInputType::handleDOMActivateEvent):
Removed renderer check as input can be hidden.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GStreamer] FFTFrame implementation
philn@webkit.org [Thu, 2 Feb 2012 08:04:02 +0000 (08:04 +0000)]
[GStreamer] FFTFrame implementation
https://bugs.webkit.org/show_bug.cgi?id=73545

Reviewed by Chris Rogers.

.:

* configure.ac: Enable the WebAudio option again and remove
libfftw checks.

Source/WebCore:

FFTFrame implementation based on GStreamer's FFT processing
library.

No new tests, existing WebAudio tests cover this.

* GNUmakefile.am:
* GNUmakefile.list.am:
* platform/audio/FFTFrame.h:
* platform/audio/FFTFrameStub.cpp:
* platform/audio/gstreamer/FFTFrameGStreamer.cpp: Added.
(WebCore::FFTFrame::FFTFrame):
(WebCore::FFTFrame::initialize):
(WebCore::FFTFrame::cleanup):
(WebCore::FFTFrame::~FFTFrame):
(WebCore::FFTFrame::multiply):
(WebCore::FFTFrame::doFFT):
(WebCore::FFTFrame::doInverseFFT):
(WebCore::FFTFrame::realData):
(WebCore::FFTFrame::imagData):

Source/WebKit/gtk:

* GNUmakefile.am: Remove libfftw compilation flags.

Source/WebKit2:

* GNUmakefile.am: Remove libfftw compilation flags.

LayoutTests:

* webaudio/resources/convolution-testing.js:
(checkTail1): Adapt convolution threshold for GStreamerFFTFrame
implementation, as advised by Chris Rogers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@106537 268f45cc-cd09-0410-ab3c-d52691b4dbfc