WebKit-https.git
12 years ago Copy dependencies of ImageDiff, DumpRenderTree in post-build step.
sfalken@apple.com [Tue, 6 May 2008 00:45:03 +0000 (00:45 +0000)]
    Copy dependencies of ImageDiff, DumpRenderTree in post-build step.

        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * DumpRenderTree/win/ImageDiff.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 6 May 2008 00:01:19 +0000 (00:01 +0000)]
2008-05-05  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        -<rdar://problem/5770054> JavaScript profiler (10928)
        -Begininings of a UI for the Profiler in the WebInspector.

        * English.lproj/InspectorLocalizedStrings.js: Add new strings to be
        localized.
        * page/inspector/DatabasesPanel.js: Changed the name of the Databae's
        results table to be more generic as it is now also used by the profiler.
        * page/inspector/Images/glossySelected.png: Added.
        * page/inspector/Images/profilesIcon.png: Added.
        * page/inspector/Images/treeUpTriangleBlack.png: Added.
        * page/inspector/Images/treeUpTriangleWhite.png: Added.
        * page/inspector/ProfileView.js: Added. Sets up the header of the table.
        * page/inspector/ProfilesPanel.js: Added.
        * page/inspector/ProfilesPanel.js: Added. Sets up the containers of the
        profiler's content.
        * page/inspector/inspector.css: Change database-result-table to be more
        generic as well as add the styles needed by the profiler.
        * page/inspector/inspector.html: Add profiler support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 5 May 2008 23:42:43 +0000 (23:42 +0000)]
2008-05-05  Brady Eidson  <beidson@apple.com>

        Change by Darin, reviewed by Brady

        Small efficiency improvement Darin just spotted

        * storage/StorageMap.cpp:
        (WebCore::StorageMap::setItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Antti Koivisto <antti@apple.com>
antti@apple.com [Mon, 5 May 2008 23:31:01 +0000 (23:31 +0000)]
2008-05-05  Antti Koivisto  <antti@apple.com>

        Reviewed by Anders.

        Fix https://bugs.webkit.org/show_bug.cgi?id=18899
        Bug 18899: REGRESSION (r32871): Non-Safari crash in WTF::HashTable on startup

        * loader/loader.cpp:
        (WebCore::Loader::Loader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 5 May 2008 23:04:53 +0000 (23:04 +0000)]
2008-05-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Fix for <rdar://problem/5884383>
        Escape look-a-like characters from the the entire url.

        * Misc/WebNSURLExtras.mm:
        (escapeUnsafeCharacters):
        (-[NSURL _web_userVisibleString]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 5 May 2008 22:57:51 +0000 (22:57 +0000)]
2008-05-05  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        Fix a bug in StorageMap iterator tracking where the iterator was not successfully
        invalidated at an appropriate time.

        * storage/StorageMap.cpp:
        (WebCore::StorageMap::setItem): ALWAYS invalidate it here

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justin.garcia@apple.com [Mon, 5 May 2008 22:50:56 +0000 (22:50 +0000)]
WebCore:

2008-05-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin.

        <rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end

        Disable Range mutation on document modifications in Tiger and Leopard Mail,
        since they do their own mutation which interferes with ours.

        * WebCore.base.exp:
        * dom/Document.cpp:
        (WebCore::Document::nodeChildrenChanged):
        (WebCore::Document::nodeWillBeRemoved):
        (WebCore::Document::textInserted):
        (WebCore::Document::textRemoved):
        (WebCore::Document::textNodesMerged):
        (WebCore::Document::textNodeSplit):
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::disableRangeMutationForOldAppleMail):
        * page/Settings.h:
        (WebCore::Settings::rangeMutationDisabledForOldAppleMail):

WebKit/mac:

2008-05-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin.

        <rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end

        * WebView/WebView.mm:
        (-[WebView _updateSettingsFromPreferences:]): Disable Range mutation on changes to
        the document for Tiger and Leopard Mail.  There is code in Mail that does it, and
        the two interfere.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Mon, 5 May 2008 22:47:21 +0000 (22:47 +0000)]
WebCore:

2008-05-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Tim Hatcher.

        Make the Inspector's localizable strings file match the format used by Dashboard widgets.

        * English.lproj/InspectorLocalizedStrings.js: Removed.
        * English.lproj/localizedStrings.js: Added.
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * page/inspector/inspector.js:

WebKit/mac:

2008-05-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Tim Hatcher.

        Make the Inspector's localizable strings file match the format used by Dashboard widgets.

        * WebCoreSupport/WebInspectorClient.mm:
        (WebInspectorClient::localizedStringsURL):

WebKit/win:

2008-05-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Tim Hatcher.

        Make the Inspector's localizable strings file match the format used by Dashboard widgets.

        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorClient::localizedStringsURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Mon, 5 May 2008 20:51:32 +0000 (20:51 +0000)]
2008-05-05  Steve Falkenburg  <sfalken@apple.com>

        Add WebPreference for application chrome mode.

        Reviewed by Dave Hyatt.

        * Interfaces/IWebPreferencesPrivate.idl:
        * WebPreferenceKeysPrivate.h:
        * WebPreferences.cpp:
        (WebPreferences::initializeDefaultSettings):
        (WebPreferences::inApplicationChromeMode):
        (WebPreferences::setApplicationChromeMode):
        * WebPreferences.h:
        * WebView.cpp:
        (WebView::notifyPreferencesChanged):

2008-05-05  Steve Falkenburg  <sfalken@apple.com>

        Add support for default button appearance.
        Add WebCore setting for app chrome mode.

        Reviewed by Dave Hyatt.

        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        * css/CSSValueKeywords.in: Added default-button value keyword.
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::setApplicationChromeMode):
        * page/Settings.h:
        (WebCore::Settings::inApplicationChromeMode):
        * rendering/RenderButton.cpp:
        (WebCore::RenderButton::RenderButton):
        (WebCore::RenderButton::setStyle):
        (WebCore::RenderButton::timerFired):
        * rendering/RenderButton.h:
        * rendering/RenderStyle.h:
        (WebCore::):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::adjustStyle):
        (WebCore::RenderTheme::paint):
        (WebCore::RenderTheme::paintBorderOnly):
        (WebCore::RenderTheme::paintDecorations):
        (WebCore::RenderTheme::isControlStyled):
        (WebCore::RenderTheme::isDefault):
        * rendering/RenderTheme.h:
        (WebCore::):
        * rendering/RenderThemeSafari.cpp:
        (WebCore::RenderThemeSafari::determineState):
        (WebCore::RenderThemeSafari::adjustRepaintRect):
        (WebCore::RenderThemeSafari::adjustButtonStyle):
        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::supportsFocus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Adele Peterson <adele@apple.com>
adele@apple.com [Mon, 5 May 2008 20:35:15 +0000 (20:35 +0000)]
2008-05-05  Adele Peterson  <adele@apple.com>

        Reviewed by Adam.

        Look for the right ImageDiff executable for debug builds.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap@webkit.org [Mon, 5 May 2008 18:29:09 +0000 (18:29 +0000)]
    Reviewed by Darin.

        https://bugs.webkit.org/show_bug.cgi?id=11947
        nbsps should be converted to entities in innerHTML

        https://bugs.webkit.org/show_bug.cgi?id=18769
        replacing &nbsp; with spaces using regexp creates inconsistent result

        Tests: fast/dom/innerHTML-nbsp.html
               fast/dom/innerHTML-escaping-attribute.html

        * editing/markup.cpp:
        (WebCore::appendAttributeValue):
        (WebCore::escapeContentText):
        (WebCore::appendEscapedContent):
        Added U+00a0/nbsp to the list of characters to escape.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
hyatt@apple.com [Mon, 5 May 2008 18:26:17 +0000 (18:26 +0000)]
WebCore:

2008-05-05  David Hyatt  <hyatt@apple.com>

        Fix for https://bugs.webkit.org/show_bug.cgi?id=18821.  Fix some bugs in both get/PutImageData of <canvas>.

        Reviewed by Eric

        New tests added in fast/canvas/

        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::ImageBuffer::getImageData):
        (WebCore::ImageBuffer::putImageData):

LayoutTests:

2008-05-05  David Hyatt  <hyatt@apple.com>

        Fix for https://bugs.webkit.org/show_bug.cgi?id=18821, putImageData incorrect when data has alpha.

        Reviewed by Eric

        * fast/canvas/canvas-alphaImageData-behavior-expected.txt: Added.
        * fast/canvas/canvas-alphaImageData-behavior.html: Added.
        * fast/canvas/canvas-alphaImageData-behavior.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 5 May 2008 16:59:05 +0000 (16:59 +0000)]
2008-05-05  Darin Adler  <darin@apple.com>

        Reviewed by John Sullivan.

        - fix debug-only leak seen on buildbot

        * wtf/HashTable.h:
        (WTF::HashTable::checkKey): After writing an empty value in, but before constructing a
        deleted value on top of it, call the destructor so the empty value doesn't leak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 5 May 2008 16:47:21 +0000 (16:47 +0000)]
2008-05-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Jess.

        Apparently preflighting can cause hangs for some reason. Revert this for now.

        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage _initWithPath:]):
        * Plugins/WebPluginPackage.m:
        (-[WebPluginPackage initWithPath:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 5 May 2008 16:44:16 +0000 (16:44 +0000)]
2008-05-05  Darin Adler  <darin@apple.com>

        * Scripts/run-webkit-tests: Ignore a Java leak showing up in the WebKit
        leak tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 5 May 2008 16:34:03 +0000 (16:34 +0000)]
2008-05-05  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - https://bugs.webkit.org/show_bug.cgi?id=18789
          fix some shouldCloseWithWindow edge cases

        * WebView/WebView.mm:
        (-[WebView viewWillMoveToWindow:]): Fix bug where we would stop observing the
        NSWindowWillCloseNotification if the view was moved out of the window but still
        had that window set as the host window. Also make sure this function doesn't do
        anything if the WebView is already closed.
        (-[WebView setHostWindow:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber-stamped by Adam Roben.
mitz@apple.com [Mon, 5 May 2008 16:31:24 +0000 (16:31 +0000)]
    Rubber-stamped by Adam Roben.

        - fix test failure due to Windows' preference for Mac results over
          generic results

        * platform/win/editing/selection/move-left-right-expected.txt: Copied from LayoutTests/editing/selection/move-left-right-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Mon, 5 May 2008 16:27:51 +0000 (16:27 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18809
          Forms with block level generated content and absolutely positioned labels break inline layout (fixed on reflow)

        Test: fast/block/basic/adding-near-anonymous-block.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::addChildToFlow): When adding a floating or
        positioned object, if it follows an anonymous block, put it
        inside the anonymous block. When adding an inline, check if it comes
        after an anonymous block and put it in the anonymous block.

LayoutTests:

        Reviewed by Dave Hyatt.

        - test, updated test and updated results for https://bugs.webkit.org/show_bug.cgi?id=18809
          Forms with block level generated content and absolutely positioned labels break inline layout (fixed on reflow)

        * fast/block/basic/adding-near-anonymous-block.html: Added.
        * media/video-controls-rendering.html: Changed to work around
        https://bugs.webkit.org/show_bug.cgi?id=18857 which now affects this
        test in its original form.
        * platform/mac/css1/box_properties/clear-expected.txt:
        * platform/mac/fast/block/basic/adding-near-anonymous-block-expected.checksum: Added.
        * platform/mac/fast/block/basic/adding-near-anonymous-block-expected.png: Added.
        * platform/mac/fast/block/basic/adding-near-anonymous-block-expected.txt: Added.
        * platform/mac/fast/forms/input-align-image-expected.txt:
        * platform/mac/media/audio-controls-rendering-expected.txt:
        * platform/mac/media/video-controls-rendering-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug51140-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-05 Antti Koivisto <antti@apple.com>
antti@apple.com [Mon, 5 May 2008 16:09:00 +0000 (16:09 +0000)]
2008-05-05  Antti Koivisto  <antti@apple.com>

        Reviewed by Darin.

        Speculative fix for <rdar://problem/5906790>
        Crash in Loader::servePendingRequests() due to hash table being modified during iteration

        I don't know how to reproduce this. It would require the load to fail (or succeed)
        synchronously, something that should not usually happen.

        * loader/loader.cpp:
        (WebCore::Loader::Loader):
        (WebCore::Loader::load):
        (WebCore::Loader::servePendingRequests):
        (WebCore::Loader::cancelRequests):
        (WebCore::Loader::Host::Host):
        * loader/loader.h:
        (WebCore::Loader::Host::name):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAriya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Mon, 5 May 2008 10:26:33 +0000 (10:26 +0000)]
Ariya Hidayat  <ariya.hidayat@trolltech.com>

In the Qt's DumpRenderTree, adjust the web view properly (because W3C SVG
tests expect to be 480x360)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAriya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Mon, 5 May 2008 09:59:34 +0000 (09:59 +0000)]
Ariya Hidayat  <ariya.hidayat@trolltech.com>

Disable SVG As Image support in the Qt port again, as it
requires more work. Right now the chrome client is
assumed to be a ChromeClientQt, which the SVG Image support
changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Mon, 5 May 2008 05:30:44 +0000 (05:30 +0000)]
Reviewed by Kevin Ollivier.

Allow events to specify the ID of the particular wxWebView they are to be sent to.

https://bugs.webkit.org/show_bug.cgi?id=18659

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-02 Antti Koivisto <antti@apple.com>
antti@apple.com [Mon, 5 May 2008 04:46:26 +0000 (04:46 +0000)]
2008-05-02  Antti Koivisto  <antti@apple.com>

        Reviewed by Mitz.

        Test for <rdar://problem/5840475>
        CrashTracer: [USER] 2 crashes in Safari at com.apple.WebCore: WebCore::RenderBlock::insertPositionedObject

        * fast/transforms/container-transform-crash-expected.txt: Added.
        * fast/transforms/container-transform-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-02 Antti Koivisto <antti@apple.com>
antti@apple.com [Mon, 5 May 2008 04:44:54 +0000 (04:44 +0000)]
2008-05-02  Antti Koivisto  <antti@apple.com>

        Reviewed by Mitz.

        Fix <rdar://problem/5840475>
        CrashTracer: [USER] 2 crashes in Safari at com.apple.WebCore: WebCore::RenderBlock::insertPositionedObject

        Non-block objects can have transforms so containingBlock() could end up returning null.
        RenderObject::container() needs to match.

        Test: fast/transforms/container-transform-crash.html

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::containingBlock):
        (WebCore::RenderObject::container):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-04 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 5 May 2008 01:48:09 +0000 (01:48 +0000)]
2008-05-04  Sam Weinig  <sam@webkit.org>

        Roll out r32851.  It broke tiger builds.

        * bindings/objc/DOMUtility.mm:
        (KJS::createDOMWrapper):
        (WebCore::createDOMWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Sun, 4 May 2008 22:03:42 +0000 (22:03 +0000)]
WebCore:

        Reviewed by Sam Weinig.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18879
          <rdar://problem/5909481> Reproducible crash when removing a gradient

        Test: fast/gradients/crash-on-remove.html

        * css/CSSImageGeneratorValue.cpp:
        (WebCore::CSSImageGeneratorValue::CSSImageGeneratorValue):
        (WebCore::CSSImageGeneratorValue::addClient): Added a call to ref() the
        value.
        (WebCore::CSSImageGeneratorValue::removeClient): Added code to deref()
        the value.

LayoutTests:

        Reviewed by Sam Weinig.

        - test for https://bugs.webkit.org/show_bug.cgi?id=18879
          <rdar://problem/5909481> Reproducible crash when removing a gradient

        * fast/gradients/crash-on-remove-expected.txt: Added.
        * fast/gradients/crash-on-remove.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-04 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 4 May 2008 21:52:43 +0000 (21:52 +0000)]
2008-05-04  Sam Weinig  <sam@webkit.org>

        Reviewed by Maciej Stachowiak.

        Don't print out the full url.

        * fast/dom/Window/dom-access-from-closure-iframe-expected.txt:
        * fast/dom/Window/dom-access-from-closure-window-expected.txt:
        * fast/dom/Window/resources/dom-access-from-closure-iframe-child.html:
        * fast/dom/Window/resources/dom-access-from-closure-window-child.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Make parameters match for WebChromeClient::addMessageToConsole()
ddkilzer@apple.com [Sun, 4 May 2008 21:52:21 +0000 (21:52 +0000)]
    Make parameters match for WebChromeClient::addMessageToConsole()

        Reviewed by John.

        * WebCoreSupport/WebChromeClient.h:
        (WebChromeClient::addMessageToConsole): Renamed sourceID parameter
        to sourceURL to match implementation in WebChromeClient.mm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-03 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 4 May 2008 21:29:03 +0000 (21:29 +0000)]
2008-05-03  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Move createDOMWrapper(JSObject* object) out of the KJS namespace and into
        the WebCore namespace now that the required compilers don't freak out about
        this anymore.

        * bindings/objc/DOMUtility.mm:
        (WebCore::createDOMWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam.
rwlbuis@webkit.org [Sun, 4 May 2008 06:36:19 +0000 (06:36 +0000)]
    Reviewed by Sam.

        https://bugs.webkit.org/show_bug.cgi?id=18652
        onchange events don't seem to fire for input[type=range] controls.

        Fire changeEvent when clicking the slider outside the current
        thumb position.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-03 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 4 May 2008 01:04:29 +0000 (01:04 +0000)]
2008-05-03  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Remove unused enums from JSDOMWindowBase.

        * bindings/js/JSDOMWindowBase.h:
        (WebCore::JSDOMWindowBase::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-03 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 4 May 2008 00:59:14 +0000 (00:59 +0000)]
2008-05-03  Sam Weinig  <sam@webkit.org>

        Real build fix.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-03 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 4 May 2008 00:48:40 +0000 (00:48 +0000)]
2008-05-03  Sam Weinig  <sam@webkit.org>

        Build fix.

        * bindings/js/kjs_events.cpp:
        (WebCore::JSAbstractEventListener::handleEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-03 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 4 May 2008 00:36:06 +0000 (00:36 +0000)]
2008-05-03  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Add tests that show our behavior when using closures from a global object
        whose frame has been navigated.

        Related to https://bugs.webkit.org/show_bug.cgi?id=17249.

        * fast/dom/Window/closure-access-after-navigation-iframe-expected.txt: Added.
        * fast/dom/Window/closure-access-after-navigation-iframe.html: Added.
        * fast/dom/Window/closure-access-after-navigation-window-expected.txt: Added.
        * fast/dom/Window/closure-access-after-navigation-window.html: Added.
        * fast/dom/Window/dom-access-from-closure-iframe-expected.txt: Added.
        * fast/dom/Window/dom-access-from-closure-iframe.html: Added.
        * fast/dom/Window/dom-access-from-closure-window-expected.txt: Added.
        * fast/dom/Window/dom-access-from-closure-window.html: Added.
        * fast/dom/Window/resources/closure-access-after-navigation-iframe-child-1.html: Added.
        * fast/dom/Window/resources/closure-access-after-navigation-iframe-child-2.html: Added.
        * fast/dom/Window/resources/closure-access-after-navigation-window-child-1.html: Added.
        * fast/dom/Window/resources/closure-access-after-navigation-window-child-2.html: Added.
        * fast/dom/Window/resources/dom-access-from-closure-iframe-child.html: Added.
        * fast/dom/Window/resources/dom-access-from-closure-window-child.html: Added.
        * fast/dom/Window/resources/notify-opener-done.html: Added.
        * fast/dom/Window/resources/notify-parent-done.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-03 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 4 May 2008 00:02:10 +0000 (00:02 +0000)]
2008-05-03  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Geoffrey Garen.

        Rename JSDOMWindowWrapper to JSDOMWindowShell.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Eric.
rwlbuis@webkit.org [Sat, 3 May 2008 06:44:58 +0000 (06:44 +0000)]
    Reviewed by Eric.

        https://bugs.webkit.org/show_bug.cgi?id=18568
        background: currentColor fails

        Implement currentColor from CSS3 color module.

        Tests: fast/css/background-currentcolor.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca@apple.com [Sat, 3 May 2008 00:44:21 +0000 (00:44 +0000)]
WebCore:

2008-05-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark.

        Turns out calling locationInWindow on keyboard events will not throw an exception,
        but the point returned is completely bogus, so remove coordinates from the keyboard event struct.

        * bridge/npapi.h:
        (_NPCocoaEvent::):

WebKit/mac:

2008-05-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark.

        Various Cocoa event model and 64-bit plug-in fixes.

        * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
        (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
        Set click count.

        (WebNetscapePluginEventHandlerCocoa::flagsChanged):
        (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
        Don't try to get the mouse location for keyboard events.

        * Plugins/WebPluginPackage.m:
        (-[WebPluginPackage initWithPath:]):
        Preflight the bundle so we won't show 32-bit WebKit plug-ins when running as 64-bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 3 May 2008 00:21:05 +0000 (00:21 +0000)]
2008-05-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark.

        Add an "x86_64" make rule.

        * Makefile.shared:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-02 Benjamin Otte <otte@gnome.org>
alp@webkit.org [Fri, 2 May 2008 23:10:41 +0000 (23:10 +0000)]
2008-05-02  Benjamin Otte  <otte@gnome.org>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=18856
        [GTK] variable initialization missing

        Not initializing the m_needsXEmbed variable could have very funny
        results. Most often those results would be crashes.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::PluginView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-02 Jan Michael Alonzo <jmalonzo@unpluggable.com>
alp@webkit.org [Fri, 2 May 2008 22:21:09 +0000 (22:21 +0000)]
2008-05-02  Jan Michael Alonzo  <jmalonzo@unpluggable.com>

        Reviewed by Eric.

        https://bugs.webkit.org/show_bug.cgi?id=18811
        Enable dashboard and offline web apps in autotools

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoffrey Garen.
ap@webkit.org [Fri, 2 May 2008 20:05:47 +0000 (20:05 +0000)]
    Reviewed by Geoffrey Garen.

        Get rid of static data in nodes.cpp (well, at least of non-debug one).

        No measurable change on SunSpider.

        * kjs/InitializeThreading.cpp:
        (KJS::initializeThreadingOnce):
        * kjs/nodes.cpp:
        (KJS::newTrackedObjects):
        (KJS::trackedObjectExtraRefCounts):
        (KJS::initializeNodesThreading):
        (KJS::ParserRefCounted::ParserRefCounted):
        (KJS::ParserRefCounted::ref):
        (KJS::ParserRefCounted::deref):
        (KJS::ParserRefCounted::refcount):
        (KJS::ParserRefCounted::deleteNewObjects):
        * kjs/nodes.h:
        Made newTrackedObjects and trackedObjectExtraRefCounts per-thread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca@apple.com [Fri, 2 May 2008 19:23:50 +0000 (19:23 +0000)]
WebCore:

2008-05-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Name the event union so it will work in plain C.

        * bridge/npapi.h:
        (_NPCocoaEvent::):

WebKit/mac:

2008-05-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        The event union is now named.

        * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
        (WebNetscapePluginEventHandlerCocoa::drawRect):
        (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
        (WebNetscapePluginEventHandlerCocoa::flagsChanged):
        (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
        (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
        (WebNetscapePluginEventHandlerCocoa::focusChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 2 May 2008 18:15:53 +0000 (18:15 +0000)]
2008-05-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark.

        Make sure that 32-bit only plug-ins aren't shown when running as 64-bit.

        Call preflightAndReturnError on the bundle, which will check if any of the architectures
        in the bundle match the current architecture.

        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage _initWithPath:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap@webkit.org [Fri, 2 May 2008 18:10:33 +0000 (18:10 +0000)]
    Reviewed by Darin.

        Move call stack depth counter to global object.

        * kjs/ExecState.h: (KJS::ExecState::functionCallDepth): Added a recursion depth counter to
        per-thread data.
        * kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init): Initialize PerThreadData.functionCallDepth.
        * kjs/JSGlobalObject.h: (KJS::JSGlobalObject::perThreadData): Made the result non-const.

        * kjs/object.cpp:
        (KJS::throwStackSizeExceededError): Moved throwError to a separate function, since it is now
        the only thing in JSObject::call that needs a PIC branch.
        (KJS::JSObject::call): Use a per-thread variable instead of local static for recursion depth
        tracking.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
mitz@apple.com [Fri, 2 May 2008 17:53:59 +0000 (17:53 +0000)]
    Reviewed by Adam Roben.

        - add an option to svn-apply to set the reviewer name in change logs

        * Scripts/svn-apply: Added a [-r|--reviewer name] option.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Fri, 2 May 2008 16:15:25 +0000 (16:15 +0000)]
WebCore:

        Reviewed by John Sullivan.

        - render text shadows with zero offset, as the shadow can be seen behind
          the text if the text is translucent

        Test: fast/text/shadow-no-blur.html

        * platform/graphics/mac/FontMac.mm:
        (WebCore::Font::drawComplexText): Removed the isEmpty() condition on the
        shadow offset. Since isEmpty() is also true for sizes that have one or
        more non-positive components, this also ensures that subpixel
        antialiasing of the text is maintained with shadows in all directions.
        (WebCore::Font::drawGlyphs): Ditto.
        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::Font::drawGlyphs): Ditto.

LayoutTests:

        Reviewed by John Sullivan.

        - add pixel test for text shadows with zero blur and various offsets,
          including zero offset

        * fast/text/shadow-no-blur.html: Added.
        * platform/mac/fast/text/shadow-no-blur-expected.checksum: Added.
        * platform/mac/fast/text/shadow-no-blur-expected.png: Added.
        * platform/mac/fast/text/shadow-no-blur-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-02 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Fri, 2 May 2008 14:48:36 +0000 (14:48 +0000)]
2008-05-02  Tor Arne Vestbø  <tavestbo@trolltech.com>

Updated Qt layout-tests to match changes in font metrics.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAriya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Fri, 2 May 2008 14:09:47 +0000 (14:09 +0000)]
Ariya Hidayat <ariya.hidayat@trolltech.com>

Build the Qt port with SVG Use and As Image support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAriya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Fri, 2 May 2008 13:40:34 +0000 (13:40 +0000)]
Ariya Hidayat <ariya.hidayat@trolltech.com>

Fixed potential crash on SVG animation (added more checks to the assert).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Fri, 2 May 2008 13:21:36 +0000 (13:21 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

Doc: Mention that you have to enable plugins in QWebSettings for them to work.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber-stamped by John Sullivan.
ap@webkit.org [Fri, 2 May 2008 13:07:43 +0000 (13:07 +0000)]
    Rubber-stamped by John Sullivan.

        Fix a debug-only crash in layout tests.

        * loader/CachedResource.cpp:
        (WebCore::CachedResource::~CachedResource): Don't call resourceForURL() for null URLs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Qt build on Windows when Phonon is enabled for Audio/Video support
hausmann@webkit.org [Fri, 2 May 2008 12:07:18 +0000 (12:07 +0000)]
Fix the Qt build on Windows when Phonon is enabled for Audio/Video support

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Qt build, add ExecState where required.
hausmann@webkit.org [Fri, 2 May 2008 11:04:26 +0000 (11:04 +0000)]
Fix the Qt build, add ExecState where required.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Qt/Win build.
hausmann@webkit.org [Fri, 2 May 2008 10:32:49 +0000 (10:32 +0000)]
Fix the Qt/Win build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap@webkit.org [Fri, 2 May 2008 10:29:47 +0000 (10:29 +0000)]
    Reviewed by Darin.

        Make JavaScriptGlue and JavaScriptCore API functions implicitly call initializeThreading
        for the sake of non-WebKit clients.

JavaScriptCore:
        * API/JSBase.cpp:
        (JSGarbageCollect):
        * API/JSContextRef.cpp:
        (JSGlobalContextCreate):
        These are the JavaScriptCore API bottlenecks. There are a few other JSStringRef
        and JSClassRef functions that can be called earlier, but they do not do anything that
        requires initializeThreading.

        * kjs/InitializeThreading.cpp:
        (KJS::doInitializeThreading):
        (KJS::initializeThreading):
        On Darwin, make the initialization happen under pthread_once, since there is no guarantee
        that non-WebKit clients won't try to call this function re-entrantly.

        * kjs/InitializeThreading.h:
        * wtf/Threading.h:
        Spell out initializeThreading contract.

        * wtf/ThreadingPthreads.cpp: (WTF::isMainThread): Make sure that results are correct on
        Darwin, even if threading was initialized from a secondary thread.

JavaScriptGlue:
        * JavaScriptGlue.cpp:
        (JSRunCreate):
        (JSCollect):
        (JSCreateJSArrayFromCFArray):
        (JSLockInterpreter):
        These are all possible JavaScriptGlue entry points.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoffrey Garen.
ap@webkit.org [Fri, 2 May 2008 10:07:53 +0000 (10:07 +0000)]
    Reviewed by Geoffrey Garen.

        https://bugs.webkit.org/show_bug.cgi?id=18826
        Make JavaScript heap per-thread

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-02 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Fri, 2 May 2008 09:55:43 +0000 (09:55 +0000)]
2008-05-02  Ariya Hidayat  <ariya.hidayat@trolltech.com>

Reviewed by Simon.

Build the Qt port with SVG Animation support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Maciej Stachowiak.
mitz@apple.com [Fri, 2 May 2008 07:55:04 +0000 (07:55 +0000)]
    Reviewed by Maciej Stachowiak.

        - Mac build fix

        * wtf/StrHash.h: Added header guards and removed #include "config.h".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix for Qt/Gtk. Don't declare NP_InitializeFuncPtr twice
hausmann@webkit.org [Fri, 2 May 2008 07:39:35 +0000 (07:39 +0000)]
Build fix for Qt/Gtk. Don't declare NP_InitializeFuncPtr twice
with different signatures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Fri, 2 May 2008 06:37:23 +0000 (06:37 +0000)]
Reviewed by Kevin Ollivier.

Explicitly set the pen style in wx port to keep pen style changes from affecting URL underline or text field drawing.

https://bugs.webkit.org/show_bug.cgi?id=18775

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Fri, 2 May 2008 06:24:18 +0000 (06:24 +0000)]
Reviewed by Kevin Ollivier.

Implement popup menu support for wx port.

https://bugs.webkit.org/show_bug.cgi?id=18776

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago #include <wtf/StrHash.h> in identifier.cpp.
adachan@apple.com [Fri, 2 May 2008 05:48:24 +0000 (05:48 +0000)]
    #include <wtf/StrHash.h> in identifier.cpp.

        Reviewed by Maciej.

        * kjs/identifier.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Eric Seidel.
kevino@webkit.org [Fri, 2 May 2008 05:16:42 +0000 (05:16 +0000)]
Reviewed by Eric Seidel.

Make sure we properly set the button for all mouse events, not just mouse down, set the click count to 0 for non-click events, and finally set the timestamp.

https://bugs.webkit.org/show_bug.cgi?id=18464

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-01 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 2 May 2008 03:00:36 +0000 (03:00 +0000)]
2008-05-01  Sam Weinig  <sam@webkit.org>

        Add missing result.

        * fast/canvas/canvas-path-with-inf-nan-dimensions-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-01 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 2 May 2008 02:34:52 +0000 (02:34 +0000)]
2008-05-01  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe (in his infinite wisdom).

        Auto-generate the JSXSLTProcessor binding.

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::getValueProperty):
        * bindings/js/JSDOMWindowBase.h:
        (WebCore::JSDOMWindowBase::):
        * bindings/js/JSXSLTProcessor.cpp: Removed.
        * bindings/js/JSXSLTProcessor.h: Removed.
        * xml/XSLTProcessor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Fri, 2 May 2008 02:08:43 +0000 (02:08 +0000)]
WebCore:

2008-05-01  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        Fixes:
          - https://bugs.webkit.org/show_bug.cgi?id=17249
            Incorrect lexical scope after navigation leads to UXSS
            <rdar://problem/5738497>

          - https://bugs.webkit.org/show_bug.cgi?id=16824
            Script authorization should follow lexical (not dynamic) scope
            <rdar://problem/5683032>

        This patch changes us to perform same-origin checks based on the lexical global object)
        rather than dynamic global object, which is now possible we don't re-use the window on
        navigations, but rather switch in a new one and re-use the outer shell.  This is both
        more secure and conforms with the HTML5 specification.  Now that all the checks are
        done based on the lexical global object, we can remove the SecurityOrigin::Reason
        concept, as it was only around to work around an ebay.com bug that required the check to
        be done that way.

        An important thing to note is that we currently implement a stricter than necessary policy
        and perform the same-origin check based on the currently active global object to avoid leaking
        the document in cases when the target frame is navigated before access.  This will be fixed in
        an upcoming patch.

        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::allowsAccessFrom):
        (WebCore::JSDOMWindowBase::allowsAccessFromNoErrorMessage):
        (WebCore::JSDOMWindowBase::allowsAccessFromPrivate):
        (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage):
        (WebCore::JSDOMWindowBase::printErrorMessage):
        (WebCore::asJSDOMWindow):
        * bindings/js/JSDOMWindowBase.h:
        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::checkOrigin):
        (WebCore::CanvasRenderingContext2D::createPattern):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::begin):
        (WebCore::FrameLoader::write):
        (WebCore::FrameLoader::setOpener):
        (WebCore::FrameLoader::shouldAllowNavigation):
        * page/DOMWindow.h:
        (WebCore::DOMWindow::setSecurityOrigin):
        (WebCore::DOMWindow::securityOrigin):
        (WebCore::DOMWindow::setURL):
        (WebCore::DOMWindow::url):
        * platform/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::canAccess):
        (WebCore::SecurityOrigin::isSecureTransitionTo):
        * platform/SecurityOrigin.h:

LayoutTests:

2008-05-01  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        * http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt:
        * http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt:
        * http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt:
        * http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt:
        * http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt:
        * http/tests/security/listener/xss-window-onclick-shortcut-expected.txt:
        * http/tests/security/xss-eval-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca@apple.com [Fri, 2 May 2008 01:34:28 +0000 (01:34 +0000)]
WebCore:

2008-05-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark.

        Enable 64-bit NPAPI plugins.

        * WebCore.xcodeproj/project.pbxproj:
        Don't remove NPAPI related symbols from the 64-bit .exp file.

        * bridge/npruntime.h:
        Remove now unnecessary #error.

WebKit/mac:

2008-05-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark.

        64-bit NPAPI plugin build fixes.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
        (-[WebBaseNetscapePluginView updateAndSetWindow]):
        (-[WebBaseNetscapePluginView start]):
        (-[WebBaseNetscapePluginView windowBecameKey:]):
        * Plugins/WebNetscapeDeprecatedFunctions.c:
        * Plugins/WebNetscapeDeprecatedFunctions.h:
        * Plugins/WebNetscapePluginEventHandler.mm:
        (WebNetscapePluginEventHandler::create):
        * Plugins/WebNetscapePluginEventHandlerCarbon.h:
        * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
        * Plugins/WebPluginDatabase.m:
        (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-01 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Fri, 2 May 2008 01:10:18 +0000 (01:10 +0000)]
2008-05-01  Steve Falkenburg  <sfalken@apple.com>

        Build fix.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-01 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 2 May 2008 01:02:59 +0000 (01:02 +0000)]
2008-05-01  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Oliver (a while ago)

        - just a wee bit more bindings speedup

        Store the per-document Node --> JS wrapper cache in the document
        instead of an external hashtable.

        * bindings/js/kjs_binding.cpp:
        (WebCore::ScriptInterpreter::getDOMNodeForDocument):
        (WebCore::ScriptInterpreter::forgetDOMNodeForDocument):
        (WebCore::ScriptInterpreter::putDOMNodeForDocument):
        (WebCore::ScriptInterpreter::forgetAllDOMNodesForDocument):
        (WebCore::ScriptInterpreter::markDOMNodesForDocument):
        * dom/Document.h:
        (WebCore::Document::wrapperCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca@apple.com [Fri, 2 May 2008 00:15:44 +0000 (00:15 +0000)]
WebCore:

2008-05-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Tim.

        Remove duplicate npfunctions.h header from WebKit.

        * WebCore.xcodeproj/project.pbxproj:
        Add npfunctions.h and set its role to private.

        * plugins/npfunctions.h:
        Merge Mac specific changes.

WebKit:

2008-05-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Tim.

        Remove npfunctions.h

        * WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-05-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Tim.

        Remove duplicate npfunctions.h header from WebKit.

        * MigrateHeaders.make:
        Migrate npfunctions.h

        * Plugins/npfunctions.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-01 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 1 May 2008 23:58:33 +0000 (23:58 +0000)]
2008-05-01  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        Rename toJSDOMWindow(KJS::JSGlobalObject) to asJSDOMWindow, as all it does is
        cast.

        * bindings/js/JSCustomVoidCallback.cpp:
        (WebCore::toVoidCallback):
        * bindings/js/JSCustomXPathNSResolver.cpp:
        (WebCore::JSCustomXPathNSResolver::create):
        * bindings/js/JSDOMApplicationCacheCustom.cpp:
        (WebCore::JSDOMApplicationCache::add):
        (WebCore::JSDOMApplicationCache::remove):
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::allowPopUp):
        (WebCore::createWindow):
        (WebCore::windowProtoFuncOpen):
        (WebCore::asJSDOMWindow):
        * bindings/js/JSDOMWindowBase.h:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::setLocation):
        (WebCore::JSDOMWindow::postMessage):
        * bindings/js/JSDatabaseCustom.cpp:
        (WebCore::JSDatabase::changeVersion):
        (WebCore::JSDatabase::transaction):
        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::setLocation):
        * bindings/js/JSLocationCustom.cpp:
        (WebCore::navigateIfAllowed):
        (WebCore::JSLocation::setHref):
        (WebCore::JSLocation::replace):
        (WebCore::JSLocation::reload):
        (WebCore::JSLocation::assign):
        * bindings/js/JSSQLTransactionCustom.cpp:
        (WebCore::JSSQLTransaction::executeSql):
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::open):
        * page/JavaScriptDebugServer.cpp:
        (WebCore::toPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-01 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 1 May 2008 23:58:04 +0000 (23:58 +0000)]
2008-05-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        Disable an SVG font test that crashes.

        http://bugs.webkit.org/show_bug.cgi?id=18830 tracks fixing the crash.

        * svg/W3C-SVG-1.1/fonts-glyph-02-t.svg: Removed.
        * svg/W3C-SVG-1.1/fonts-glyph-02-t.svg-disabled: Copied from svg/W3C-SVG-1.1/fonts-glyph-02-t.svg.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Thu, 1 May 2008 23:54:13 +0000 (23:54 +0000)]
WebCore:

2008-05-01  Anatoli Papirovski  <apapirovski@mac.com>

        Reviewed by Dave Hyatt.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18347
          Absolutely positioned image percentage width does not respect container's padding

        Test: fast/replaced/absolute-position-percentage-width.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcReplacedWidthUsing):

LayoutTests:

2008-05-01  Anatoli Papirovski  <apapirovski@mac.com>

        Reviewed by Dave Hyatt.

        - added a test case for https://bugs.webkit.org/show_bug.cgi?id=18347
          Absolutely positioned image percentage width does not respect container's padding

        * fast/replaced/absolute-position-percentage-width.html: Added.
        * platform/mac/fast/replaced/absolute-position-percentage-width-expected.checksum: Added.
        * platform/mac/fast/replaced/absolute-position-percentage-width-expected.png: Added.
        * platform/mac/fast/replaced/absolute-position-percentage-width-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - Windows build fix
mitz@apple.com [Thu, 1 May 2008 23:36:29 +0000 (23:36 +0000)]
    - Windows build fix

        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::Font::drawGlyphs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-01 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 1 May 2008 23:33:44 +0000 (23:33 +0000)]
2008-05-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by John.

        Add null checks for the event handler.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView stopTimers]):
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
mitz@apple.com [Thu, 1 May 2008 23:10:36 +0000 (23:10 +0000)]
    Reviewed by Darin Adler.

        - make synthetic bold and synthetic italics work in GDI text
        - account for synthetic bold in complex text on Windows

        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::Font::drawGlyphs): Adjusted the text rectangle's x coordinates
        to fit italics. Added a skew transform for synthetic italics and a
        second paint pass for synthetic bold.
        * platform/graphics/win/SimpleFontDataWin.cpp:
        (WebCore::SimpleFontData::widthForGDIGlyph): Added the synthetic bold
        offset.
        * platform/graphics/win/UniscribeController.cpp:
        (WebCore::UniscribeController::shapeAndPlaceItem): Added the synthetic
        bold offset.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-01 Alp Toker <alp@nuanti.com>
alp@webkit.org [Thu, 1 May 2008 22:53:26 +0000 (22:53 +0000)]
2008-05-01  Alp Toker  <alp@nuanti.com>

        Qt/Win build fix attempt following plugin changes. Add missing return
        statements.

        Also fixes some newly introduced coding style issues in the Qt port.

        * platform/qt/FileSystemQt.cpp:
        (WebCore::openTemporaryFile):
        (WebCore::closeFile):
        (WebCore::writeToFile):
        (WebCore::unloadModule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-01 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 1 May 2008 22:21:26 +0000 (22:21 +0000)]
2008-05-01  Anders Carlsson  <andersca@apple.com>

        Fix 64-bit build.

        * Plugins/WebNetscapePluginEventHandlerCocoa.h:
        * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
        * WebCoreSupport/WebFrameLoaderClient.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-01 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 1 May 2008 22:01:21 +0000 (22:01 +0000)]
2008-05-01  Anders Carlsson  <andersca@apple.com>

        Fix build.

        * Plugins/npfunctions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber-stamped by Sam Weinig.
eric@webkit.org [Thu, 1 May 2008 21:28:48 +0000 (21:28 +0000)]
    Rubber-stamped by Sam Weinig.

        Mark a couple UTF16 files as binary so windows-svn doesn't mutilate them on checkout.

        * fast/xsl/xslt-enc16.xml: add svn:mime-type application/octet-stream
        * fast/xsl/xslt-enc16to16.xml: add svn:mime-type application/octet-stream

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-01 Anders Carlsson <andersca@apple.com>
ddkilzer@apple.com [Thu, 1 May 2008 20:43:56 +0000 (20:43 +0000)]
2008-05-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Export methods needed to subclass Widget.  (See r32770.)

        * WebCore.base.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoVersioning.
mrowe@apple.com [Thu, 1 May 2008 20:25:21 +0000 (20:25 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoVersioning.
mrowe@apple.com [Thu, 1 May 2008 19:59:09 +0000 (19:59 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-01 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 1 May 2008 19:42:24 +0000 (19:42 +0000)]
2008-05-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Forward mouse move events to the Netscape plug-in view.

        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView handleMouseMoved:]):
        New method that just calls the current event handler.

        * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
        (WebNetscapePluginEventHandlerCocoa::flagsChanged):
        NSFlagsChanged is not a regular keyboard event and some of the NSEvent accessors
        don't work on it so don't call them.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (NetscapePluginWidget::NetscapePluginWidget):
        New Widget subclass to be used for Netscape plug-ins.

        (NetscapePluginWidget::handleEvent):
        Forward NSMouseMoved events to the plug-in.

        (WebFrameLoaderClient::createPlugin):
        Wrap the plug-in view in a NetscapePluginWidget.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-01 Alice Liu <alice.liu@apple.com>
alice.liu@apple.com [Thu, 1 May 2008 19:15:34 +0000 (19:15 +0000)]
2008-05-01  Alice Liu  <alice.liu@apple.com>

        Rubber-stamped by Sam Weinig.

        fast/events/tabindex-focus-blur-all.html was timing out on some machines
        Make this test faster by not doing += on innerHTML.

        * fast/events/resources/tabindex-focus-blur-all.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCleaned up ugly if/else statement.
ddkilzer@apple.com [Thu, 1 May 2008 18:52:13 +0000 (18:52 +0000)]
Cleaned up ugly if/else statement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Clean up configuration usage in run-webkit-tests
ddkilzer@apple.com [Thu, 1 May 2008 18:34:46 +0000 (18:34 +0000)]
    Clean up configuration usage in run-webkit-tests

        Reviewed by Adam.

        * Scripts/run-webkit-tests: Parse configuration switches using
        passedConfiguration() from webkitdirs.pm like every other script.
        Note that we must still call setConfiguration() afterwards in
        case the --configuration switch was used.  Use $configurationOption
        when running build-dumprendertree instead of recreating the switch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-01 Marc Ordinas i Llopis <marc.ordinasillopis@collabora.co.uk>
alp@webkit.org [Thu, 1 May 2008 18:15:39 +0000 (18:15 +0000)]
2008-05-01  Marc Ordinas i Llopis  <marc.ordinasillopis@collabora.co.uk>

        Reviewed by Alp Toker.
        Qt parts OK'ed by Simon Hausmann.

        Based on work by several authors.

        https://bugs.webkit.org/show_bug.cgi?id=14750
        Added support for NPAPI plugins on Gtk and Qt-x11 ports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-01 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 1 May 2008 18:14:51 +0000 (18:14 +0000)]
2008-05-01  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Turn off deprecated warnings for WebNetscapePluginEventHandlerCarbon.mm.

        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-01 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 1 May 2008 18:09:49 +0000 (18:09 +0000)]
2008-05-01  Sam Weinig  <sam@webkit.org>

        Update results with -webkit-box-reflect values.

        * fast/css/computed-style-expected.txt:
        * fast/css/computed-style-without-renderer-expected.txt:
        * svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
weinig@apple.com [Thu, 1 May 2008 17:48:31 +0000 (17:48 +0000)]
JavaScriptCore:

2008-05-01  Sam Weinig  <sam@webkit.org>

        Fix build.

        * JavaScriptCore.xcodeproj/project.pbxproj:

WebCore:

2008-05-01  Sam Weinig  <sam@webkit.org>

        Fix build.

        * ForwardingHeaders/wtf/StrHash.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-01 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 1 May 2008 17:15:49 +0000 (17:15 +0000)]
2008-05-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Move management of cache groups to ApplicationCacheStorage. Also,
        application caches now start out with a null group and will have their group set
        when the cache has finished loading.

        * loader/appcache/ApplicationCache.cpp:
        (WebCore::ApplicationCache::ApplicationCache):
        Initialize m_group to 0.

        (WebCore::ApplicationCache::~ApplicationCache):
        Null check the group.

        (WebCore::ApplicationCache::setGroup):
        New method for setting the group.

        * loader/appcache/ApplicationCache.h:
        (WebCore::ApplicationCache::create):
        Remove the group argument.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::~ApplicationCacheGroup):
        Let the storage know that the cache group has been destroyed.

        (WebCore::ApplicationCacheGroup::cacheForMainRequest):
        Call into the storage.

        (WebCore::ApplicationCacheGroup::selectCache):
        Call into the storage.

        (WebCore::ApplicationCacheGroup::documentLoaderDestroyed):
        When there are no document loaders associated with the cache group,
        set the newest cache to 0.

        (WebCore::ApplicationCacheGroup::cacheDestroyed):
        Delete the group if there are no associated caches.

        (WebCore::ApplicationCacheGroup::setNewestCache):
        New method that will set the newest cache and associate the group with the cache.

        (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
        Call setNewestCache instead.

        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::urlHostHash):
        Move host hash method here.

        (WebCore::ApplicationCacheStorage::findOrCreateCacheGroup):
        New method that finds a cache group with a given manifest URL or creates a new one.

        (WebCore::ApplicationCacheStorage::cacheGroupForURL):
        New method that returns a cache group for a given URL.

        (WebCore::ApplicationCacheStorage::cacheGroupDestroyed):
        When the cache group has been destroyed, remove it from the hash map.

        * loader/appcache/ApplicationCacheStorage.h:
        Add new methods.I b

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-01 Dan Winship <danw@gnome.org>
alp@webkit.org [Thu, 1 May 2008 16:50:00 +0000 (16:50 +0000)]
2008-05-01  Dan Winship  <danw@gnome.org>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=18490
        Add mostly-working file: support and mostly-broken ftp: support to
        the soup backend.

        * platform/network/soup/ResourceHandleSoup.cpp (start): after
        doing basic checks, delegate to one of three submethods
        (startData): handles data: URLs
        (startHttp): handles http: and https: URLs, via libsoup
        (startGio, etc): handles file: and ftp: URLs, via gio. Lots of
        FIXMEs detailing the parts that don't fully work yet.

        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleInternal.h: add new member
        variables for gio-based loading

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-01 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Thu, 1 May 2008 16:32:32 +0000 (16:32 +0000)]
2008-05-01  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Darin.

        <rdar://problem/5770054> JavaScript profiler (10928)
        - Fix "sample" output so that it can be imported into Instruments
        - Also keep track of number of times a function is profiled.

        * JavaScriptCore.xcodeproj/project.pbxproj: Add StrHash.h which needed
        to be pulled out of identifier.cpp so that it could be used by the
        profiler and identifiers.
        * kjs/identifier.cpp: Ditto.
        * profiler/FunctionCallProfile.cpp:
        (KJS::FunctionCallProfile::printDataInspectorStyle): Inspector style
        printing should show microseconds.
        (KJS::FunctionCallProfile::printDataSampleStyle): Sample style printing
        now counts the number of times a function is in the stack tree and does
        not print microseconds since that does not make sense for a sampler.
        * profiler/FunctionCallProfile.h: Keep track of number of times a
        function is profiled.
        (KJS::FunctionCallProfile::numberOfCalls):
        * profiler/Profiler.cpp:
        (KJS::functionNameCountPairComparator): Comparator for sort function in
        printDataSampleStyle.
        (KJS::Profiler::printDataSampleStyle): Print the number of times that a
        function is listed in the stack tree in order of most times listed.
        * wtf/HashCountedSet.h: Added copyToVector since it didn't exist and is
        a more standard way to copy a HashSet to a Vector. I added on variant
        that takes a pair as the Vector's type and so the HashCountedSet simply
        fills in that pair with its internal pair, and another variant that
        takes a Vector of the type of the HashCountedSet and only fills in the
        Vector with the first element of the pair.
        (WTF::copyToVector):
        * wtf/StrHash.h: Added.
        (WTF::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-01 Alp Toker <alp@nuanti.com>
alp@webkit.org [Thu, 1 May 2008 15:56:18 +0000 (15:56 +0000)]
2008-05-01  Alp Toker  <alp@nuanti.com>

        Rubber-stamped by Anders.

        GTK+ build fix for changes in r32752. Use int32, not int32_t types in
        npapi.h.

        Additional fix to use same signedness in npapi.h and Mac for the
        interval parameter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-30 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Thu, 1 May 2008 02:01:33 +0000 (02:01 +0000)]
2008-04-30  Julien Chaffraix  <jchaffraix@webkit.org>

        Qt 4.3 build fix.

        Fixes a brace error that made Qt 4.4 build but not Qt 4.3.

        * Api/qwebview.cpp:
        (QWebView::event):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca@apple.com [Thu, 1 May 2008 00:28:17 +0000 (00:28 +0000)]
WebCore:

2008-04-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Add new Cocoa event model type declarations.

        * bridge/npapi.h:

WebKit:

2008-04-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Add Cocoa event handler.

        * WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-04-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Add new Cocoa event model and the NPN_ScheduleTimer/NPN_UnscheduleTimer methods.

        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (PluginTimer::PluginTimer):
        (PluginTimer::start):
        (PluginTimer::fired):
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
        (-[WebBaseNetscapePluginView stopTimers]):
        (-[WebBaseNetscapePluginView restartTimers]):
        (-[WebBaseNetscapePluginView scrollWheel:]):
        (-[WebBaseNetscapePluginView flagsChanged:]):
        (-[WebBaseNetscapePluginView start]):
        (-[WebBaseNetscapePluginView eventModel]):
        (-[WebBaseNetscapePluginView fini]):
        (-[WebBaseNetscapePluginView getVariable:value:]):
        (-[WebBaseNetscapePluginView setVariable:value:]):
        (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
        (-[WebBaseNetscapePluginView unscheduleTimer:]):
        * Plugins/WebBaseNetscapePluginViewInternal.h:
        * Plugins/WebBaseNetscapePluginViewPrivate.h:
        * Plugins/WebNetscapePluginEventHandler.h:
        * Plugins/WebNetscapePluginEventHandler.mm:
        (WebNetscapePluginEventHandler::create):
        * Plugins/WebNetscapePluginEventHandlerCarbon.h:
        * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
        (WebNetscapePluginEventHandlerCarbon::scrollWheel):
        (WebNetscapePluginEventHandlerCarbon::flagsChanged):
        (WebNetscapePluginEventHandlerCarbon::platformWindow):
        * Plugins/WebNetscapePluginEventHandlerCocoa.h: Added.
        (WebNetscapePluginEventHandlerCocoa::startTimers):
        (WebNetscapePluginEventHandlerCocoa::stopTimers):
        * Plugins/WebNetscapePluginEventHandlerCocoa.mm: Added.
        (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
        (WebNetscapePluginEventHandlerCocoa::drawRect):
        (WebNetscapePluginEventHandlerCocoa::mouseDown):
        (WebNetscapePluginEventHandlerCocoa::mouseDragged):
        (WebNetscapePluginEventHandlerCocoa::mouseEntered):
        (WebNetscapePluginEventHandlerCocoa::mouseExited):
        (WebNetscapePluginEventHandlerCocoa::mouseMoved):
        (WebNetscapePluginEventHandlerCocoa::mouseUp):
        (WebNetscapePluginEventHandlerCocoa::scrollWheel):
        (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
        (WebNetscapePluginEventHandlerCocoa::keyDown):
        (WebNetscapePluginEventHandlerCocoa::keyUp):
        (WebNetscapePluginEventHandlerCocoa::flagsChanged):
        (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
        (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
        (WebNetscapePluginEventHandlerCocoa::focusChanged):
        (WebNetscapePluginEventHandlerCocoa::platformWindow):
        (WebNetscapePluginEventHandlerCocoa::sendEvent):
        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage load]):
        * Plugins/npapi.m:
        (NPN_ScheduleTimer):
        (NPN_UnscheduleTimer):
        * Plugins/npfunctions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-30 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Thu, 1 May 2008 00:08:14 +0000 (00:08 +0000)]
2008-04-30  Beth Dakin  <bdakin@apple.com>

        Reviewed by Sam Weinig.

        This patch does three things:
        1. Adds support for the "img" ARIA role
        2. Switches over to a HashMap for converting ARIA role attributes
        to WebCore's AccessibilityRole type.
        3. Fixes a crash in the new ARIA code that I ran into while
        browsing with VoiceOver enabled.

        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::headingLevel): This is the crash
        fix. Make sure the node's renderer is not null before looking up
        its corresponding AccessibilityObject in the cache.
        (WebCore::AccessibilityObject::accessibilityIsIgnored): Account for
        ARIA images.
        (WebCore::createARIARoleMap): Switch to HashMap, and add "img" to
        the Map.
        (WebCore::RoleEntry::): Same.
        (WebCore::ariaRoleToWebCoreRole): Same.
        (WebCore::AccessibilityObject::ariaRoleAttribute): Same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-30 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 30 Apr 2008 23:16:13 +0000 (23:16 +0000)]
2008-04-30  Brady Eidson  <beidson@apple.com>

        Fix my WebPreferences revert check-in

        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-30 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 30 Apr 2008 22:33:23 +0000 (22:33 +0000)]
2008-04-30  Brady Eidson  <beidson@apple.com>

        Rubberstamped by John Sullivan

        Revert the remainder of my original preferences changes from last week.
        They caused a massive PLT regression (too many notifications being sent out
        or listened to that weren't previously) and it's not in my schedule to refine
        the preferences code instead of working on my feature!

        * WebView/WebView.mm:
        (-[WebView _updateSettingsFromPreferences:]):
        (-[WebView _commonInitializationWithFrameName:groupName:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@32746 268f45cc-cd09-0410-ab3c-d52691b4dbfc