WebKit-https.git
8 years agoREGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
jhoneycutt@apple.com [Wed, 25 May 2011 21:56:21 +0000 (21:56 +0000)]
REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
https://bugs.webkit.org/show_bug.cgi?id=61428
<rdar://problem/9457006>

Reviewed by Adam Roben.

Source/WebKit2:

The crash occurs when Flash posts a message to a window that it
creates, and in processing the message, it calls NPN_Evaluate to
evaluate JavaScript that removes the plug-in from the page. Flash then
crashes when we return to Flash code.

* Platform/WorkItem.h:
(DerefWorkItem::DerefWorkItem):
Initialize m_ptr.
(DerefWorkItem::execute):
Deref the object.
(WorkItem::createDeref):
Create and return a DerefWorkItem.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::unprotectPluginFromDestruction):
If the PluginView has only one reference left, deref it asynchronously.

Tools:

The crash occurs when Flash posts a message to a window that it
creates, and in processing the message, it calls NPN_Evaluate to
evaluate JavaScript that removes the plug-in from the page. Flash then
crashes when we return to Flash code.

This test emulates that behavior.

* DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
(CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
Initialize member vars.
(CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
Remove our custom property from the message window, and destroy it.
(CallJSThatDestroysPlugin::NPP_Destroy):
Set m_isDestroyed, log that the plug-in was destroyed, and notify the
layout test controller that we're done.
(wndProc):
Get the PluginTest object, and call its runTest() function.
(CallJSThatDestroysPlugin::NPP_New):
Setup the test: register a class for the message-only window, create
it, and post a message to it to run the test.
(CallJSThatDestroysPlugin::runTest):
Execute JS that removes the plug-in from the page, and if we're not
destroyed, log a success message.

* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
Add new test to project.

LayoutTests:

* platform/win/plugins/call-javascript-that-destroys-plugin-expected.txt: Added.
* platform/win/plugins/call-javascript-that-destroys-plugin.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Wed, 25 May 2011 21:47:39 +0000 (21:47 +0000)]
2011-05-25  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Eric Carlson.

        Fix media element regression where ended event stopped firing after changing the src attribute.

        https://bugs.webkit.org/show_bug.cgi?id=61336

        * media/media-ended-expected.txt: Added.
        * media/media-ended.html: Added.
2011-05-25  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Eric Carlson.

        Fix media element regression where ended event stopped firing after changing the src attribute.

        https://bugs.webkit.org/show_bug.cgi?id=61336

        Test: media/media-ended.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::prepareForLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Wed, 25 May 2011 21:38:31 +0000 (21:38 +0000)]
2011-05-25  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        REGRESSION: Fullscreen button on embedded Vimeo videos does nothing
        https://bugs.webkit.org/show_bug.cgi?id=61461

        * fullscreen/full-screen-iframe-legacy-expected.txt: Added.
        * fullscreen/full-screen-iframe-legacy.html: Added.
        * fullscreen/resources/legacy.html: Added.
2011-05-25  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        REGRESSION: Fullscreen button on embedded Vimeo videos does nothing
        https://bugs.webkit.org/show_bug.cgi?id=61461

        Tests: fullscreen/full-screen-iframe-legacy.html

        Allow calls from the legacy full-screen API to bypass the iframe
        "webkitallowfullscreen" requirement by adding a parameter to
        Document::webkitRequestFullScreenForElement specifying the strictness
        of that check.  Specify this new parameter everywhere that function is
        called, including in the default controls' full-screen button handler.

        * dom/Document.cpp:
        (WebCore::Document::webkitRequestFullScreenForElement):
        * dom/Document.h:
        * dom/Element.cpp:
        (WebCore::Element::requestFullScreen): Renamed from webkitRequestFullScreen.
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::enterFullscreen):
        * html/shadow/MediaControlElements.cpp:
        (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 25 May 2011 21:33:15 +0000 (21:33 +0000)]
2011-05-25  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        webkitpy's NetworkTransaction shouldn't use mechanize
        https://bugs.webkit.org/show_bug.cgi?id=61450

        mechanize.HTTPError is just an alias for urllib2.HTTPError, so
        use urllib2 directly.  Re-add NetworkTransaction to
        test_results_uploader.py (reverting r87124).

        * Scripts/webkitpy/common/net/networktransaction.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Missing update for expected results in LayoutTests after r87315
caio.oliveira@openbossa.org [Wed, 25 May 2011 21:31:37 +0000 (21:31 +0000)]
[Qt] Missing update for expected results in LayoutTests after r87315
https://bugs.webkit.org/show_bug.cgi?id=61467

Reviewed by Andreas Kling.

We now expose __qt_sender__ as a non-enumarated property in the
global object. Fix our expectations in relevant tests.

* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org>
commit-queue@webkit.org [Wed, 25 May 2011 21:29:32 +0000 (21:29 +0000)]
2011-05-25  Kulanthaivel Palanichamy  <kulanthaivel@codeaurora.org>

        Reviewed by David Hyatt.

        Selector matching doesn't update when DOM changes ("[data-a=x] #x")
        https://bugs.webkit.org/show_bug.cgi?id=60752

        Added test cases for all the attribute selector types (CSS2.1 & CSS3).

        * fast/css/attribute-selector-begin-dynamic-no-elementstyle-expected.txt: Added.
        * fast/css/attribute-selector-begin-dynamic-no-elementstyle.html: Added.
        * fast/css/attribute-selector-contain-dynamic-no-elementstyle-expected.txt: Added.
        * fast/css/attribute-selector-contain-dynamic-no-elementstyle.html: Added.
        * fast/css/attribute-selector-end-dynamic-no-elementstyle-expected.txt: Added.
        * fast/css/attribute-selector-end-dynamic-no-elementstyle.html: Added.
        * fast/css/attribute-selector-exact-dynamic-no-elementstyle-expected.txt: Added.
        * fast/css/attribute-selector-exact-dynamic-no-elementstyle.html: Added.
        * fast/css/attribute-selector-hyphen-dynamic-no-elementstyle-expected.txt: Added.
        * fast/css/attribute-selector-hyphen-dynamic-no-elementstyle.html: Added.
        * fast/css/attribute-selector-list-dynamic-no-elementstyle-expected.txt: Added.
        * fast/css/attribute-selector-list-dynamic-no-elementstyle.html: Added.
        * fast/css/attribute-selector-set-dynamic-no-elementstyle-expected.txt: Added.
        * fast/css/attribute-selector-set-dynamic-no-elementstyle.html: Added.
2011-05-25  Kulanthaivel Palanichamy  <kulanthaivel@codeaurora.org>

        Reviewed by David Hyatt.

        Selector matching doesn't update when DOM changes ("[data-a=x] #x")
        https://bugs.webkit.org/show_bug.cgi?id=60752

        Currently CSSStyleSelector maintains a HashSet of attributes (m_selectorAttrs)
        which are used in CSS attribute selectors to determine the need for style
        recalculation whenever element attributes are manipulated in DOM.
        In certain conditions (element with no style, element is styled and attribute
        is not a mapped attribute, attribute is of type 'type' or read-only)
        even when attribute selector matches for an element, the attribute is not
        added to m_selectorAttrs. This results in missing style recalculations
        when a DOM element attribute is changed and is not found in m_selectorAttrs.

        Removing the above said conditions in
        CSSStyleSelector::SelectorChecker::checkOneSelector() for registering
        attributes in m_selectorAttrs will solve this issue. But this particular
        function is called numerous times which triggers adding duplicate attributes
        again and again.

        This patch follows the approach taken for collecting ids in selectors, where
        all the attributes in selectors are added to a HashSet at the time of adding
        style rules to CSSStyleSelector from StyleSheets and when
        CSSStyleSelector::hasSelectorForAttribute() is called, the attribute is
        simply looked up in this pre-populated hash set.

        Test: fast/css/attribute-selector-dynamic-no-elementstyle.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
        (WebCore::CSSStyleSelector::checkSelector):
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
        (WebCore::collectFeaturesFromSelector):
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::hasSelectorForAttribute):
        * css/CSSStyleSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Wed, 25 May 2011 21:23:05 +0000 (21:23 +0000)]
2011-05-25  Adam Klein  <adamk@chromium.org>

        Unreviewed. Update chromium expectations after r87307.

        * platform/chromium/test_expectations.txt: suppress, WK61470.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 25 May 2011 20:32:37 +0000 (20:32 +0000)]
2011-05-25  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by James Robinson.

        CSSStyleSelector should provide a way to obtain rules from non-author stylesheets
        https://bugs.webkit.org/show_bug.cgi?id=61454

        Replaced bool and enum arguments of styleRulesForElement and pseudoStyleRulesForElement
        by one enum, and provided a way to obtain rules from UA/user stylesheets.

        * css/CSSRule.h: Removed CSSRuleFilter.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::styleRulesForElement): See above.
        (WebCore::CSSStyleSelector::pseudoStyleRulesForElement): Ditto.
        * css/CSSStyleSelector.h: Moved CSSRuleFilter here.
        * editing/markup.cpp:
        (WebCore::styleFromMatchedRulesForElement): Calls styleRulesForElement.
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::getStylesForNode): Ditto.
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::getMatchedCSSRules): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 25 May 2011 19:37:18 +0000 (19:37 +0000)]
2011-05-24  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Geoffrey Garen.

        Removed MarkSetProperties because it was unused
        https://bugs.webkit.org/show_bug.cgi?id=61418

        * heap/MarkStack.h:
        (JSC::MarkSet::MarkSet):
        (JSC::MarkStack::append):
        * runtime/JSActivation.cpp:
        (JSC::JSActivation::visitChildren):
        * runtime/JSArray.h:
        (JSC::JSArray::visitChildrenDirect):
        * runtime/JSPropertyNameIterator.cpp:
        (JSC::JSPropertyNameIterator::visitChildren):
        * runtime/WriteBarrier.h:
        (JSC::MarkStack::appendValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
caio.oliveira@openbossa.org [Wed, 25 May 2011 19:28:22 +0000 (19:28 +0000)]
2011-05-25  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] JSC bridge: implement __qt_sender__ without using Scope Chain
        https://bugs.webkit.org/show_bug.cgi?id=61343

        Create a stack to keep track of the sender objects. This is simpler than
        the similar mechanism in QObject (C++ API), that keeps a stack per-object.

        Since we do not support multiple threads, one static stack will be enough for
        handling the behavior.

        This behavior is covered by the tst_QWebFrame::connectAndDisconnect() auto test.

        * bridge/qt/qt_instance.cpp:
        (JSC::Bindings::QtInstance::qtSenderStack):
        We have one static stack of QObject*. The top of the stack contains the
        last object that emitted signal that called a JavaScript function.

        * bridge/qt/qt_instance.h:
        (JSC::Bindings::QtInstance::QtSenderStack::top):
        (JSC::Bindings::QtInstance::QtSenderStack::push):
        (JSC::Bindings::QtInstance::QtSenderStack::pop):
        Minimal functionality to manipulate the sender stack.

        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::QtConnectionObject::execute):
        Remove the previous code that modified the scope chain. Push the sender object
        to the stack before calling the JavaScript function (the "slot" in Qt-speak) and
        pop it afterwards.
2011-05-25  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] JSC bridge: implement __qt_sender__ without using Scope Chain
        https://bugs.webkit.org/show_bug.cgi?id=61343

        Create a '__qt_sender__' property in the global object, that returns the top of
        the qtSenderStack. This is an alternative implementation for the feature of
        providing a way for a function (acting as a Qt 'slot') discover which object
        emitted the signal that caused it to be executed.

        This reduces the coupling of the Qt bridge and JSC internal implementation. The
        patch tries to use as much JSC public API as possible.

        This behavior is covered by the tst_QWebFrame::connectAndDisconnect() auto test.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
        Instead of emitting the QWebPage::javaScriptWindowObjectCleared() directly, calls
        a QWebPagePrivate function to do it.

        * Api/qwebframe_p.h:
        * Api/qwebframe.cpp:
        (QWebFramePrivate::didClearedWindowObject):
        Before emitting the signal mentioned, adds the '__qt_sender__' to the fresh
        global object.

        (qtSenderCallback):
        Returns the JSObjectRef corresponding to the top of qtSenderStack.

        (QWebFramePrivate::addQtSenderToGlobalObject):
        Create a property with a qtSenderCallback as getter function in the global object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed build fix, do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
kevino@webkit.org [Wed, 25 May 2011 19:25:50 +0000 (19:25 +0000)]
[Chromium] Unreviewed build fix, do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
until the port begins using those export macros.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 25 May 2011 19:23:39 +0000 (19:23 +0000)]
2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87257.
        http://trac.webkit.org/changeset/87257
        https://bugs.webkit.org/show_bug.cgi?id=61457

        This broke layout tests, see bug 61431. (Requested by
        hwennborg on #webkit).

        * storage/indexeddb/migrate-basics-expected.txt: Removed.
        * storage/indexeddb/migrate-basics.html: Removed.
2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87257.
        http://trac.webkit.org/changeset/87257
        https://bugs.webkit.org/show_bug.cgi?id=61457

        This broke layout tests, see bug 61431. (Requested by
        hwennborg on #webkit).

        * storage/IDBBackingStore.h:
        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::IDBFactoryBackendImpl::IDBFactoryBackendImpl):
        (WebCore::IDBFactoryBackendImpl::open):
        * storage/IDBFactoryBackendImpl.h:
        * storage/IDBFactoryBackendInterface.h:
        * storage/IDBLevelDBBackingStore.cpp:
        * storage/IDBLevelDBBackingStore.h:
        * storage/IDBSQLiteBackingStore.cpp:
        * storage/IDBSQLiteBackingStore.h:
2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87257.
        http://trac.webkit.org/changeset/87257
        https://bugs.webkit.org/show_bug.cgi?id=61457

        This broke layout tests, see bug 61431. (Requested by
        hwennborg on #webkit).

        * public/WebIDBFactory.h:
        * src/AssertMatchingEnums.cpp:
        * src/IDBFactoryBackendProxy.cpp:
        * src/IDBFactoryBackendProxy.h:
        * src/WebIDBFactoryImpl.cpp:
        (WebKit::WebIDBFactoryImpl::WebIDBFactoryImpl):
        (WebKit::WebIDBFactoryImpl::open):
        * src/WebIDBFactoryImpl.h:
2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87257.
        http://trac.webkit.org/changeset/87257
        https://bugs.webkit.org/show_bug.cgi?id=61457

        This broke layout tests, see bug 61431. (Requested by
        hwennborg on #webkit).

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::clearAllDatabases):
        * DumpRenderTree/chromium/LayoutTestController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Wed, 25 May 2011 19:22:25 +0000 (19:22 +0000)]
2011-05-25  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Eric Carlson.

        [Qt] Enable usage of QuickTime mediaplayer for the Qt port on Mac.
        https://bugs.webkit.org/show_bug.cgi?id=61279

        Enable the QuickTime backend for the Qt port on Mac. The patch adds the bits in WebCore
        to enable the QTKit backend of the Mac port. It can be enabled by passing DEFINES+=USE_QTKIT=1
        when calling build-webkit.

        * WebCore.pri:
        * WebCore.pro:
        * features.pri:
        * platform/KURL.h:
        * platform/SharedBuffer.h:
        * platform/cf/KURLCFNet.cpp:
        * platform/cf/SharedBufferCF.cpp:
        * platform/graphics/FloatSize.h:
        * platform/graphics/IntRect.h:
        * platform/graphics/IntSize.h:
        * platform/graphics/MediaPlayer.cpp:
        * platform/graphics/cg/FloatSizeCG.cpp:
        * platform/graphics/cg/IntRectCG.cpp:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivateQTKit::createQTMovieView):
        (WebCore::MediaPlayerPrivateQTKit::createQTVideoRenderer):
        (WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
        (WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode):
        (WebCore::MediaPlayerPrivateQTKit::paint):
        (-[WebCoreMovieObserver layerHostChanged:]):
        * platform/mac/KURLMac.mm:
        * platform/mac/SharedBufferMac.mm:
        (+[WebCoreSharedBufferData initialize]):
        * platform/mac/WebCoreObjCExtras.mm:
        * platform/qt/WebCoreSystemInterface.h: Added.
        * platform/qt/WebCoreSystemInterface.mm: Added.
2011-05-25  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Eric Carlson.

        [Qt] Enable usage of QuickTime mediaplayer for the Qt port on Mac.
        https://bugs.webkit.org/show_bug.cgi?id=61279

        Enable the usage of QuickTime backend for the Qt port. It can be enabled by
        passing DEFINES+=USE_QTKIT=1 when calling build-webkit.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::QWebPagePrivate):
        * QtWebKit.pro:
        * WebCoreSupport/FullScreenVideoQt.cpp:
        (WebCore::FullScreenVideoQt::enterFullScreenForNode):
        (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
        (WebCore::FullScreenVideoQt::isValid):
        * WebCoreSupport/WebSystemInterface.h: Added.
        * WebCoreSupport/WebSystemInterface.mm: Added.
        (InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Qi Zhang <qi.2.zhang@nokia.com>
qi.2.zhang@nokia.com [Wed, 25 May 2011 19:20:29 +0000 (19:20 +0000)]
2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] fast/css/disabled-author-styles.html failed
        https://bugs.webkit.org/show_bug.cgi?id=61438

        Unskip test case and provide expect result files.

        * platform/qt/Skipped:
        * platform/qt/fast/css/disabled-author-styles-expected.png: Added.
        * platform/qt/fast/css/disabled-author-styles-expected.txt: Added.
2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] fast/css/disabled-author-styles.html failed
        https://bugs.webkit.org/show_bug.cgi?id=61438

        Provided API setAuthorAndUserStylesEnabled for DumpRenderTree.

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::setAuthorAndUserStylesEnabled):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] fast/css/disabled-author-styles.html failed
        https://bugs.webkit.org/show_bug.cgi?id=61438

        Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::WebPage::resetSettings):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setAuthorAndUserStylesEnabled):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Wed, 25 May 2011 19:01:46 +0000 (19:01 +0000)]
2011-05-25  Rob Buis  <rbuis@rim.com>

        Reviewed by Eric Seidel.

        WebKit does not handle missing filter elements correctly
        https://bugs.webkit.org/show_bug.cgi?id=12569

        Updated improved pixel test result and add new SVG1.1 SE test and results.

        * platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
        * platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
        * platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
        * svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg: Added.
2011-05-25  Rob Buis  <rbuis@rim.com>

        Reviewed by Eric Seidel.
        New test rubber-stamped by Dirk Schulze.

        WebKit does not handle missing filter elements correctly
        https://bugs.webkit.org/show_bug.cgi?id=12569

        Do not render elements that reference non-existant filters.

        Test: svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg

        * rendering/svg/SVGRenderSupport.cpp:
        (WebCore::SVGRenderSupport::prepareToRenderSVGContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 25 May 2011 18:51:27 +0000 (18:51 +0000)]
2011-05-25  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Put view-source documents in a unique origin and always allow them to run scripts. This ensures tools like
        XMLViewer work even when scripts are disabled, while still providing the protections expected when scripts are disabled.
        https://bugs.webkit.org/show_bug.cgi?id=59113

        * bindings/ScriptControllerBase.cpp:
        (WebCore::ScriptController::canExecuteScripts): Check whether the document is viewing source, and allow scripts in that case.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::matchUARules):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::setIsViewSource): Renamed from setUsesViewSourceStyles(), set's a unique security origin if we are viewing source.
        * dom/Document.h:
        (WebCore::Document::isViewSource): Renamed from usesViewSourceStyles().
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::receivedFirstData):
        * xml/XMLTreeViewer.cpp:
        (WebCore::XMLTreeViewer::transformDocumentToTreeView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 25 May 2011 18:48:25 +0000 (18:48 +0000)]
2011-05-25  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Make allocations with guard pages ensure that the allocation succeeded
        https://bugs.webkit.org/show_bug.cgi?id=61453

        Add null checks, and make PageBlock's operator bool() use
        the realbase, rather than the start of usable memory.

        * wtf/OSAllocatorPosix.cpp:
        (WTF::OSAllocator::reserveAndCommit):
        * wtf/PageBlock.h:
        (WTF::PageBlock::operator bool):
        (WTF::PageBlock::PageBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Julien Chaffraix <jchaffraix@codeaurora.org>
jchaffraix@webkit.org [Wed, 25 May 2011 18:45:56 +0000 (18:45 +0000)]
2011-05-25  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by James Robinson.

        http://philip.html5.org/tests/canvas/suite/tests/2d.composite.uncovered.fill.source-in.html fails
        https://bugs.webkit.org/show_bug.cgi?id=39027

        And:

        - Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.source-out.html
          https://bugs.webkit.org/show_bug.cgi?id=48295

        - Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.source-in.html
          https://bugs.webkit.org/show_bug.cgi?id=48304

        - Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.source-out.html
        https://bugs.webkit.org/show_bug.cgi?id=48305

        * canvas/philip/tests/2d.composite.uncovered.pattern.source-in-expected.txt:
        * canvas/philip/tests/2d.composite.uncovered.pattern.source-out-expected.txt:
        Those 2 tests need a trailing line that was added as part of this change.

        * fast/canvas/canvas-composite-alpha.html: Updated the test result to match the specification.
        The changes are fairly simple:
          - Clear up the destination rectangle as it should be always transparent now (source is transparent
            outside the source rectangle).
          - Clear the composition rectangle if source or destination is transparent.
          - Fixed the test when run in the browser.
        Validated the changes against FF and Opera (IE 9 cannot render this test).

        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        Re-enable 4 tests.
2011-05-25  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by James Robinson.

        http://philip.html5.org/tests/canvas/suite/tests/2d.composite.uncovered.fill.source-in.html fails
        https://bugs.webkit.org/show_bug.cgi?id=39027

        And:

        - Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.source-out.html
          https://bugs.webkit.org/show_bug.cgi?id=48295

        - Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.source-in.html
          https://bugs.webkit.org/show_bug.cgi?id=48304

        - Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.source-out.html
        https://bugs.webkit.org/show_bug.cgi?id=48305

        Those 4 tests have the same root cause for failing. Instead of splitting them in 2 fixes, I squashed
        them together as the fix is common.

        Based on an older work by Ariya Hidayat.

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::fill):
        (WebCore::CanvasRenderingContext2D::fillRect): Added call displayTransparencyEverywhere for those 2
        cases if we have to.

        (WebCore::CanvasRenderingContext2D::shouldDisplayTransparencyEverywhere): This method returns true if
        the spec says to display transparency everywhere. We only do so for source-in and source-out for now.
        (WebCore::CanvasRenderingContext2D::displayTransparencyEverywhere): This method implements the spec
        (which matches other browsers' behavior) and "display transparency elsewhere".

        * html/canvas/CanvasRenderingContext2D.h: Added the two previous methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-20 Robert Hogan <robert@webkit.org>
robert@webkit.org [Wed, 25 May 2011 17:58:48 +0000 (17:58 +0000)]
2011-05-20  Robert Hogan  <robert@webkit.org>

        Reviewed by Geoffrey Garen.

        [Qt/Gtk/Chromium] Fix plugins/embed-attributes-setting.html

        Use the test netscape plugin instead of quicktime.
        Allows the test to pass on Qt/Gtk/Chromium as well as Mac.

        https://bugs.webkit.org/show_bug.cgi?id=61182
        http://code.google.com/p/chromium/issues/detail?id=15797

        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * plugins/embed-attributes-setting-expected.txt:
        * plugins/embed-attributes-setting.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/9496795> REGRESSION (r86851): Plug-ins disappear when scrolled with...
mitz@apple.com [Wed, 25 May 2011 17:22:23 +0000 (17:22 +0000)]
<rdar://problem/9496795> REGRESSION (r86851): Plug-ins disappear when scrolled with non-1 page scale
https://bugs.webkit.org/show_bug.cgi?id=61448

Reviewed by Anders Carlsson.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::clipRectInWindowCoordinates): Correct for page scale
after intersecting the two rectangles.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReviewed by Eric Seidel.
kevino@webkit.org [Wed, 25 May 2011 17:10:03 +0000 (17:10 +0000)]
Reviewed by Eric Seidel.

Add JS_EXPORT_PRIVATE macro for exported methods in bytecompiler headers.

https://bugs.webkit.org/show_bug.cgi?id=27551

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Wed, 25 May 2011 17:06:32 +0000 (17:06 +0000)]
2011-05-25  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Add IntPoint versions of IntRect::move and IntPoint::move
        https://bugs.webkit.org/show_bug.cgi?id=61390

        Adding move methods to IntRect and IntPoint that take an IntPoint
        that's acting as an offset. Since we also apply negative offsets,
        also adding a single parameter operator- for IntPoint.

        No new tests since this is refactoring.

        * page/FrameView.cpp:
        (WebCore::FrameView::invalidateScrollbarRect):
        (WebCore::FrameView::convertFromRenderer):
        (WebCore::FrameView::convertToRenderer):
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::wheelEvent):
        * platform/ScrollView.h:
        (WebCore::ScrollView::convertChildToSelf):
        (WebCore::ScrollView::convertSelfToChild):
        * platform/ScrollbarThemeComposite.cpp:
        (WebCore::ScrollbarThemeComposite::invalidatePart):
        * platform/graphics/IntPoint.h:
        (WebCore::IntPoint::move):
        (WebCore::operator-):
        * platform/graphics/IntRect.h:
        (WebCore::IntRect::move):
        * platform/graphics/filters/FilterEffect.cpp:
        (WebCore::FilterEffect::requestedRegionOfInputImageData):
        * platform/graphics/gpu/Texture.cpp:
        (WebCore::Texture::updateSubRect):
        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::paint):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::logicalRectToPhysicalRect):
        (WebCore::RenderBlock::selectionGaps):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::offsetFromContainer):
        (WebCore::RenderBox::computeRectForRepaint):
        (WebCore::RenderBox::localCaretRect):
        * rendering/RenderDetailsMarker.cpp:
        (WebCore::RenderDetailsMarker::paint):
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
        * rendering/RenderInputSpeech.cpp:
        (WebCore::RenderInputSpeech::paintInputFieldSpeechButton):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::paintScrollbar):
        (WebCore::RenderLayerBacking::paintContents):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::paintScrollbar):
        (WebCore::RenderLayerCompositor::paintContents):
        * rendering/RenderListItem.cpp:
        (WebCore::RenderListItem::positionListMarker):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::paint):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::computeRectForRepaint):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::nodeAtPoint):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::repaintViewRectangle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Wed, 25 May 2011 17:04:47 +0000 (17:04 +0000)]
2011-05-25  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch addFocusRingRects to use IntPoint
        https://bugs.webkit.org/show_bug.cgi?id=60783

        Switching addFocusRingRects to use an IntPoint representing the offset being
        applied instead of a pair of ints.

        No new tests as this is only refactoring.

        * platform/graphics/FloatSize.h:
        (WebCore::flooredIntPoint):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::addFocusRingRects):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::addFocusRingRects):
        * rendering/RenderBox.h:
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::addFocusRingRects):
        * rendering/RenderInline.h:
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::addFocusRingRects):
        * rendering/RenderListBox.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::paintFocusRing):
        (WebCore::RenderObject::absoluteFocusRingQuads):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::addFocusRingRects):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::addFocusRingRects):
        * rendering/RenderTextControl.h:
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::addFocusRingRects):
        * rendering/RenderTextControlSingleLine.h:
        * rendering/svg/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::addFocusRingRects):
        * rendering/svg/RenderSVGContainer.h:
        * rendering/svg/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::addFocusRingRects):
        * rendering/svg/RenderSVGImage.h:
        * rendering/svg/RenderSVGPath.cpp:
        (WebCore::RenderSVGPath::addFocusRingRects):
        * rendering/svg/RenderSVGPath.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 25 May 2011 16:50:53 +0000 (16:50 +0000)]
2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87229.
        http://trac.webkit.org/changeset/87229
        https://bugs.webkit.org/show_bug.cgi?id=61445

        Lots of tests crashing in
        CFNetwork!URLResponse::createFilenameFromResponseHeaders on
        Windows XP (Requested by aroben on #webkit).

        * platform/network/ResourceResponseBase.cpp:
        (WebCore::ResourceResponseBase::adopt):
        (WebCore::ResourceResponseBase::suggestedFilename):
        (WebCore::ResourceResponseBase::setSuggestedFilename):
        (WebCore::ResourceResponseBase::httpStatusText):
        (WebCore::ResourceResponseBase::setHTTPStatusText):
        (WebCore::ResourceResponseBase::httpHeaderField):
        (WebCore::ResourceResponseBase::setHTTPHeaderField):
        (WebCore::ResourceResponseBase::httpHeaderFields):
        (WebCore::ResourceResponseBase::isAttachment):
        (WebCore::ResourceResponseBase::setLastModifiedDate):
        (WebCore::ResourceResponseBase::lastModifiedDate):
        (WebCore::ResourceResponseBase::wasCached):
        (WebCore::ResourceResponseBase::connectionReused):
        (WebCore::ResourceResponseBase::setConnectionReused):
        (WebCore::ResourceResponseBase::connectionID):
        (WebCore::ResourceResponseBase::setConnectionID):
        (WebCore::ResourceResponseBase::resourceLoadTiming):
        (WebCore::ResourceResponseBase::setResourceLoadTiming):
        (WebCore::ResourceResponseBase::resourceLoadInfo):
        (WebCore::ResourceResponseBase::setResourceLoadInfo):
        * platform/network/ResourceResponseBase.h:
        * platform/network/cf/ResourceResponse.h:
        (WebCore::ResourceResponse::ResourceResponse):
        * platform/network/cf/ResourceResponseCFNet.cpp:
        (WebCore::ResourceResponse::platformLazyInit):
        * platform/network/mac/ResourceResponseMac.mm:
        (WebCore::ResourceResponse::platformLazyInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Leon Scroggins <scroggo@google.com>
commit-queue@webkit.org [Wed, 25 May 2011 16:48:03 +0000 (16:48 +0000)]
2011-05-25  Leon Scroggins  <scroggo@google.com>

        Reviewed by Steve Block.

        Update chromium expectations for more canvas fixes.
        https://bugs.webkit.org/show_bug.cgi?id=61433

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIdentify, rather than skip, builds where run-webkit-tests exited early due to too...
aroben@apple.com [Wed, 25 May 2011 16:38:29 +0000 (16:38 +0000)]
Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures

Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
started exiting early due to too many crashes, timeouts, or failures

Reviewed by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
run-webkit-tests exits early due to too many failures, pass that information in another
argument to the callback.
(Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
the new structure of the object passed to the callback.
(Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
getNumberOfFailingTests and to pass that along to our own callbacks.
(Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
from _getFailingTests and to store that value in the history object.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
(.info): Added.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._displayBuilder): Updated for change in structure to the history
object and to add a note when run-webkit-tests exited early due to too many failures.
(ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
latestBuildInfos since each entry now contains more than just the tester and failure count.
Now displays a message for testers where the latest build exited early due to too many
failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
store that value in latestBuildInfos.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Igor Oliveira <igor.oliveira@openbossa.org>
commit-queue@webkit.org [Wed, 25 May 2011 16:33:57 +0000 (16:33 +0000)]
2011-05-25  Igor Oliveira  <igor.oliveira@openbossa.org>

        Reviewed by Antonio Gomes.

        [Qt] QtWebKit crashes when dragging not loaded images
        https://bugs.webkit.org/show_bug.cgi?id=61314

        Checks if WebKit crashes when dragging an image not yet loaded.

        * http/tests/misc/drag-not-loaded-image-expected.txt: Added.
        * http/tests/misc/drag-not-loaded-image.html: Added.
2011-05-25  Igor Oliveira  <igor.oliveira@openbossa.org>

        Reviewed by Antonio Gomes.

        [Qt] QtWebKit crashes when dragging not loaded images
        https://bugs.webkit.org/show_bug.cgi?id=61314

        Checks if nativeImageForCurrentFrame is a valid pointer.

        Test: http/tests/misc/drag-not-loaded-image.html

        * platform/qt/DragImageQt.cpp:
        (WebCore::createDragImageFromImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Wed, 25 May 2011 16:27:30 +0000 (16:27 +0000)]
2011-05-25  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Xan Lopez.

        [GTK] combobox and scrollbar are rendered small size at gtk+2.22.0
        https://bugs.webkit.org/show_bug.cgi?id=61436

        Fix arguments of gdk_drawable_get_size.

        No new tests, no behavior change.

        * platform/gtk/GtkVersioning.c:
        (getGdkDrawableSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 25 May 2011 14:58:32 +0000 (14:58 +0000)]
2011-05-25  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Skipped 3 new inspector tests that time out on gtk.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Gabor Loki <loki@webkit.org>
loki@webkit.org [Wed, 25 May 2011 14:20:23 +0000 (14:20 +0000)]
2011-05-25  Gabor Loki  <loki@webkit.org>

        Rubber-stamped by Csaba Osztrogonác.

        [Qt] Skip failed tests after r87290 and r87292 on ARM

        * platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-23 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 25 May 2011 14:02:10 +0000 (14:02 +0000)]
2011-05-23  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: extreme lagging when searching for "img[src*="
        https://bugs.webkit.org/show_bug.cgi?id=61282

        No new tests, as this is a refactoring: ElementsTreeElement DOM is manipulated directly
        when built and search-highlighted, rather than through innerHTML.

        * inspector/front-end/DOMSyntaxHighlighter.js:
        (WebInspector.DOMSyntaxHighlighter):
        (WebInspector.DOMSyntaxHighlighter.prototype.createSpan):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype._hideSearchHighlights):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype.highlightSearchResults):
        (WebInspector.ElementsTreeElement.prototype.hideSearchHighlights):
        (WebInspector.ElementsTreeElement.prototype._updateSearchHighlight.updateEntryShow):
        (WebInspector.ElementsTreeElement.prototype._updateSearchHighlight.updateEntryHide):
        (WebInspector.ElementsTreeElement.prototype._updateSearchHighlight):
        (WebInspector.ElementsTreeElement.prototype._addNewAttribute):
        (WebInspector.ElementsTreeElement.prototype.updateTitle):
        (WebInspector.ElementsTreeElement.prototype._buildAttributeDOM):
        ():
        * inspector/front-end/utilities.js:
        ():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Leandro Gracia Gil <leandrogracia@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 12:34:04 +0000 (12:34 +0000)]
2011-05-25  Leandro Gracia Gil  <leandrogracia@chromium.org>

        Reviewed by Tony Gentilcore.

        Introduce HTML5 track list objects.
        https://bugs.webkit.org/show_bug.cgi?id=60184

        Introduce the TrackList, MultipleTrackList and ExclusiveTrackList objects
        for their use in the MediaStream API and the HTML Media Element.
        Current spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#tracklist

        The Media Stream API will test this feature in the bug 56587.
        More tests related to the HTML Media Element may be added later.

        * CMakeLists.txt:
        * CodeGenerators.pri:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSEventTarget.cpp:
        (WebCore::toJS):
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
        * dom/DOMAllInOne.cpp:
        * dom/EventTarget.cpp:
        (WebCore::EventTarget::toTrackList):
        (WebCore::EventTarget::toMultipleTrackList):
        (WebCore::EventTarget::toExclusiveTrackList):
        * dom/EventTarget.h:
        * dom/ExclusiveTrackList.cpp: Added.
        (WebCore::ExclusiveTrackList::create):
        (WebCore::ExclusiveTrackList::ExclusiveTrackList):
        (WebCore::ExclusiveTrackList::~ExclusiveTrackList):
        (WebCore::ExclusiveTrackList::clear):
        (WebCore::ExclusiveTrackList::select):
        (WebCore::ExclusiveTrackList::toExclusiveTrackList):
        * dom/ExclusiveTrackList.h: Added.
        (WebCore::ExclusiveTrackList::selectedIndex):
        * dom/ExclusiveTrackList.idl: Added.
        * dom/MultipleTrackList.cpp: Added.
        (WebCore::MultipleTrackList::create):
        (WebCore::MultipleTrackList::MultipleTrackList):
        (WebCore::MultipleTrackList::~MultipleTrackList):
        (WebCore::MultipleTrackList::clear):
        (WebCore::MultipleTrackList::isEnabled):
        (WebCore::MultipleTrackList::enable):
        (WebCore::MultipleTrackList::disable):
        (WebCore::MultipleTrackList::toMultipleTrackList):
        * dom/MultipleTrackList.h: Added.
        * dom/MultipleTrackList.idl: Added.
        * dom/TrackList.cpp: Added.
        (WebCore::Track::create):
        (WebCore::Track::Track):
        (WebCore::TrackList::create):
        (WebCore::TrackList::TrackList):
        (WebCore::TrackList::~TrackList):
        (WebCore::TrackList::length):
        (WebCore::TrackList::checkIndex):
        (WebCore::TrackList::getID):
        (WebCore::TrackList::getKind):
        (WebCore::TrackList::getLabel):
        (WebCore::TrackList::getLanguage):
        (WebCore::TrackList::clear):
        (WebCore::TrackList::postChangeEvent):
        (WebCore::TrackList::dispatchChangeEvent):
        (WebCore::TrackList::toTrackList):
        (WebCore::TrackList::scriptExecutionContext):
        (WebCore::TrackList::eventTargetData):
        (WebCore::TrackList::ensureEventTargetData):
        * dom/TrackList.h: Added.
        (WebCore::Track::id):
        (WebCore::Track::kind):
        (WebCore::Track::label):
        (WebCore::Track::language):
        (WebCore::TrackList::DispatchTask::create):
        (WebCore::TrackList::DispatchTask::performTask):
        (WebCore::TrackList::DispatchTask::DispatchTask):
        (WebCore::TrackList::refEventTarget):
        (WebCore::TrackList::derefEventTarget):
        * dom/TrackList.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Keishi Hattori <keishi@webkit.org>
keishi@webkit.org [Wed, 25 May 2011 11:55:13 +0000 (11:55 +0000)]
2011-05-25  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Move ElementWithPseudoId to separate file
        https://bugs.webkit.org/show_bug.cgi?id=61430

        No new tests because no behavior changes.

        * CMakeLists.txt: Added ElementWithPseudoId.cpp
        * GNUmakefile.list.am: Added ElementWithPseudoId.{h,cpp}
        * WebCore.gypi: Added ElementWithPseudoId.{h,cpp}
        * WebCore.pro: Added ElementWithPseudoId.{h,cpp}
        * WebCore.vcproj/WebCore.vcproj: Added ElementWithPseudoId.{h,cpp}
        * WebCore.xcodeproj/project.pbxproj: Added ElementWithPseudoId.{h,cpp}
        * html/ValidationMessage.cpp: Removed ElementWithPseudoId definition.
        * html/shadow/ElementWithPseudoId.cpp: Added.
        (WebCore::ElementWithPseudoId::shadowPseudoId):
        * html/shadow/ElementWithPseudoId.h: Added.
        (WebCore::ElementWithPseudoId::create):
        (WebCore::ElementWithPseudoId::ElementWithPseudoId):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Wed, 25 May 2011 11:43:46 +0000 (11:43 +0000)]
2011-05-25  Anton Muhin  <antonm@chromium.org>

        Unreviewed.

        Update test expectations after 3.3.6.1 v8 roll.

        * platform/chromium-mac/ietestcenter/Javascript/15.5.4.20-1-1-expected.txt:
        * platform/chromium-mac/ietestcenter/Javascript/15.5.4.20-1-2-expected.txt:
        * platform/chromium-win/ietestcenter/Javascript/15.5.4.20-1-1-expected.txt:
        * platform/chromium-win/ietestcenter/Javascript/15.5.4.20-1-2-expected.txt:
        * platform/chromium/ietestcenter: Added.
        * platform/chromium/ietestcenter/Javascript: Added.
        * platform/chromium/ietestcenter/Javascript/15.4.4.14-5-28-expected.txt: Added.
        * platform/chromium/ietestcenter/Javascript/15.4.4.15-5-28-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Wed, 25 May 2011 11:39:41 +0000 (11:39 +0000)]
2011-05-25  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Antonio Gomes.

        [Qt] When QWebView has a different style set on it then the scrollbars are not rendered correctly
        https://bugs.webkit.org/show_bug.cgi?id=34635

        Make sure the scrollbar is properly rendered on Mac with another style than the Mac style. The code had
        two paths, one for Mac and one for any other styles. The problem is that on Mac you can still run the
        application with -style plastique for example, therefore the code used for other styles should also be
        used whenever the current style is not the Mac style.

        * platform/qt/ScrollbarThemeQt.cpp:
        (WebCore::ScrollbarThemeQt::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed.
ukai@chromium.org [Wed, 25 May 2011 11:21:29 +0000 (11:21 +0000)]
Unreviewed.

Update chromium test expectations.

* platform/chromium/test_expectations.txt: svn/dynamic-updates failing

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Gabor Loki <loki@webkit.org>
loki@webkit.org [Wed, 25 May 2011 11:19:39 +0000 (11:19 +0000)]
2011-05-25  Gabor Loki  <loki@webkit.org>

        Rubber-stamped by Csaba Osztrogonác.

        [Qt] Skip a flakey timed out test on ARM

        * platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed.
ukai@chromium.org [Wed, 25 May 2011 11:08:55 +0000 (11:08 +0000)]
Unreviewed.

Update chromium test expectations.

* platform/chromium/test_expectations.txt: mhtml tests pass

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed.
ukai@chromium.org [Wed, 25 May 2011 11:00:08 +0000 (11:00 +0000)]
Unreviewed.

Update chromium test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed.
ukai@chromium.org [Wed, 25 May 2011 10:41:39 +0000 (10:41 +0000)]
Unreviewed.

Update chromium test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Felician Marton <marton.felician.zoltan@stud.u-szeged.hu>
commit-queue@webkit.org [Wed, 25 May 2011 10:34:20 +0000 (10:34 +0000)]
2011-05-25  Felician Marton  <marton.felician.zoltan@stud.u-szeged.hu>

        Reviewed by Csaba Osztrogonác.

        Added dynamic tests for missing properties (and attributes) in TextElement. The corresponding Mac pixel test results also added.
        https://bugs.webkit.org/show_bug.cgi?id=59677

        * platform/mac/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Added.
        * svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-dom-dx-attr.html: Added.
        * svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-dom-dy-attr.html: Added.
        * svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-dom-rotate-attr.html: Added.
        * svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-dom-x-attr.html: Added.
        * svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-dom-y-attr.html: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-dx-prop.html: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-dy-prop.html: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-x-prop.html: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-y-prop.html: Added.
        * svg/dynamic-updates/script-tests/SVGTextElement-dom-dx-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-dom-dy-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-dom-rotate-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-dom-x-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-dom-y-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-svgdom-dx-prop.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-svgdom-dy-prop.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-svgdom-x-prop.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-svgdom-y-prop.js: Added.
        (executeTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Wed, 25 May 2011 10:12:35 +0000 (10:12 +0000)]
2011-05-25  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] Clean up WebSocket test expectations
        https://bugs.webkit.org/show_bug.cgi?id=61429

        * platform/chromium/test_expectations.txt:
        Remove two test expectations for tests that are no longer failing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Wed, 25 May 2011 09:52:36 +0000 (09:52 +0000)]
2011-05-25  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket: Use fail() when WebSocketChannel has failed
        https://bugs.webkit.org/show_bug.cgi?id=61353

        * http/tests/websocket/tests/frame-length-overflow-expected.txt:
        Added a new console message.
2011-05-25  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket: Use fail() when WebSocketChannel has failed
        https://bugs.webkit.org/show_bug.cgi?id=61353

        An existing error message has been modified, but it is impossible
        to test this message in LayoutTests because it is only shown when
        memory allocation has failed, which is hard to reproduce reliably.

        One new message has been added. It is covered by an existing test
        http/tests/websocket/tests/frame-length-overflow.html.

        There is no other change in behavior. No new tests are added.

        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::fail):
        Do not close if we know the socket stream is already closed. This does not
        change the behavior, because SocketStreamBase does nothing if it is already
        closed.
        (WebCore::WebSocketChannel::didOpen):
        (WebCore::WebSocketChannel::didReceiveData):
        We need to set m_shouldDiscardReceivedData to true before calling fail(),
        so I moved the error message from appendToBuffer() to here.
        The error message was rephrased in order to improve readability.
        (WebCore::WebSocketChannel::appendToBuffer):
        Unnested the code.
        (WebCore::WebSocketChannel::processBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-16 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 25 May 2011 09:35:43 +0000 (09:35 +0000)]
2011-05-16  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by David Levin.

        CSSParser: m_implicitShorthand should probably be RAII
        https://bugs.webkit.org/show_bug.cgi?id=51586

        It was impossible to entirely eliminate the m_implicitShorthand manual changes
        due to the parseFill*() method stateful call chains.

        No new tests, as this is a refactoring.

        * css/CSSParser.cpp:
        (ImplicitScope::ImplicitScope):
        (ImplicitScope::~ImplicitScope):
        (WebCore::CSSParser::parseShorthand):
        (WebCore::CSSParser::parse4Values):
        (WebCore::CSSParser::parseBorderRadius):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 25 May 2011 09:03:11 +0000 (09:03 +0000)]
2011-05-24  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: inspected page crashes when call stack is empty after live edit.
        https://bugs.webkit.org/show_bug.cgi?id=61364

        * inspector/debugger/live-edit-expected.txt:
        * inspector/debugger/live-edit.html:
        * platform/chromium/test_expectations.txt:
2011-05-24  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: inspected page crashes when call stack is empty after live edit.
        https://bugs.webkit.org/show_bug.cgi?id=61364

        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::currentCallFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Mads Ager <ager@chromium.org>
ager@chromium.org [Wed, 25 May 2011 07:48:53 +0000 (07:48 +0000)]
2011-05-25  Mads Ager  <ager@chromium.org>

        Reviewed by Adam Barth.

        Update chromium expectations after removal of execScript from V8
        https://bugs.webkit.org/show_bug.cgi?id=61267

        * platform/chromium/fast/dom/prototype-inheritance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-23 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 25 May 2011 07:45:33 +0000 (07:45 +0000)]
2011-05-23  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Adam Barth.

        Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
        https://bugs.webkit.org/show_bug.cgi?id=61194

        Test: inspector/console/console-eval-syntax-error.html

        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::V8InjectedScriptHost::evaluateCallback): return immediately in case of syntax error

2011-05-23  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Adam Barth.

        Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
        https://bugs.webkit.org/show_bug.cgi?id=61194

        * inspector/console/console-eval-syntax-error-expected.txt: Added.
        * inspector/console/console-eval-syntax-error.html: Added.
        * platform/chromium/inspector/console/console-eval-syntax-error-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Wed, 25 May 2011 07:17:21 +0000 (07:17 +0000)]
2011-05-25  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Kent Tamura.

        Fix for Bug 61352 - Refactor RenderView::{enable,disable}LayoutState call sites to use RIIA
        https://bugs.webkit.org/show_bug.cgi?id=61352

        No new tests because no behavior changes.

        * html/shadow/MediaControlElements.cpp:
        (WebCore::RenderMediaVolumeSliderContainer::layout):
        * page/FrameView.cpp:
        (WebCore::FrameView::layout):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::repaintOverhangingFloats):
        (WebCore::RenderBlock::updateFirstLetter):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPositions):
        (WebCore::RenderLayer::updateScrollInfoAfterLayout):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::layout):
        * rendering/RenderListItem.cpp:
        (WebCore::RenderListItem::updateMarkerLocation):
        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::layout):
        * rendering/RenderView.h:
        (WebCore::RenderView::disableLayoutState):
        (WebCore::RenderView::enableLayoutState):
        (WebCore::LayoutStateDisabler::LayoutStateDisabler):
        (WebCore::LayoutStateDisabler::~LayoutStateDisabler):
        * rendering/svg/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed typo fix after r87228.
ossy@webkit.org [Wed, 25 May 2011 06:42:11 +0000 (06:42 +0000)]
[Qt] Unreviewed typo fix after r87228.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake the Web Inspector bring the right window to the front when docked.
timothy@apple.com [Wed, 25 May 2011 06:37:42 +0000 (06:37 +0000)]
Make the Web Inspector bring the right window to the front when docked.

rdar://problem/9464685
https://webkit.org/b/61420

Reviewed by Brian Weinstein.

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformBringToFront): Order front the parent window of the Inspector's WKView.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformBringToFront): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Keishi Hattori <keishi@webkit.org>
tkent@chromium.org [Wed, 25 May 2011 06:03:09 +0000 (06:03 +0000)]
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        * configure.ac: Added INPUT_COLOR feature flag.
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        * fast/forms/ValidityState-typeMismatch-color-expected.txt: Removed.
        * fast/forms/ValidityState-typeMismatch-color.html: Removed.
        * fast/forms/color/input-value-sanitization-color-expected.txt: Added.
        * fast/forms/color/input-value-sanitization-color.html: Added. Tests
        sanitization algorithm for input type=color.
        * fast/forms/input-type-change3-expected.txt:
        * fast/forms/input-widths-expected.txt:
        * fast/forms/input-widths.html: Removed type=color because it
        is no loger a text input type.
        * fast/forms/script-tests/ValidityState-patternMismatch-unsupported.js: Changed to range input type.
        * fast/forms/script-tests/ValidityState-typeMismatch-color.js: Removed.
        * fast/forms/script-tests/input-type-change3.js:
        * platform/gtk/Skipped: Skip fast/forms/color.
        * platform/mac/Skipped: Skip fast/forms/color.
        * platform/qt/Skipped: Skip fast/forms/color.
        * platform/win/Skipped: Skip fast/forms/color.
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        * Configurations/FeatureDefines.xcconfig: Added COLOR_INPUT feature flag.
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        Test: fast/forms/color/input-value-sanitization-color.html

        * Configurations/FeatureDefines.xcconfig: Added COLOR_INPUT feature flag.
        * GNUmakefile.am: Added COLOR_INPUT feature flag.
        * features.pri: Added COLOR_INPUT feature flag.
        * html/ColorInputType.cpp: Wrapped with COLOR_INPUT feature flag.
        (WebCore::ColorInputType::isColorControl): Added.
        (WebCore::ColorInputType::fallbackValue): Added. Fallback value defined in spec.
        (WebCore::ColorInputType::sanitizeValue): Added. Sanitize value string as defined in spec.
        * html/ColorInputType.h: Wrapped with COLOR_INPUT feature flag.
        (WebCore::ColorInputType::ColorInputType): Changed to inherit BaseButtonInputType.
        * html/InputType.cpp:
        (WebCore::InputType::isColorControl): Added.
        * html/InputType.h:
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        * features.gypi: Added INPUT_COLOR feature flag.
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable input color. Add INPUT_COLOR feature flag. Implement input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        * Configurations/FeatureDefines.xcconfig: Added INPUT_COLOR feature flag.
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        * Configurations/FeatureDefines.xcconfig: Added INPUT_COLOR feature flag.
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        * Scripts/build-webkit: Added INPUT_COLOR feature flag.
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable input color. Add INPUT_COLOR feature flag. Implement input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        * win/tools/vsprops/FeatureDefines.vsprops: Added INPUT_COLOR feature flag.
        * win/tools/vsprops/FeatureDefinesCairo.vsprops: Added INPUT_COLOR feature flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Skip new failing test.
ossy@webkit.org [Wed, 25 May 2011 05:56:58 +0000 (05:56 +0000)]
[Qt][WK2] Skip new failing test.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Wed, 25 May 2011 04:54:46 +0000 (04:54 +0000)]
2011-05-24  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Update the WebProcess sandbox exceptions to silence warnings for a file that is accessed uselessly
        https://bugs.webkit.org/show_bug.cgi?id=61349
        <rdar://problem/9476255>

        * WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Annie Sullivan <sullivan@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 04:38:26 +0000 (04:38 +0000)]
2011-05-24  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Ryosuke Niwa.

        Convert LayoutTests/editing/selection/4895428-1 and -4 to dump-as-markup
        https://bugs.webkit.org/show_bug.cgi?id=61402

        Converts the two html files to dump-as-markup and adds doctype, html, and body tags.

        * editing/selection/4895428-1-expected.txt: Added.
        * editing/selection/4895428-1.html: Converted to dump-as-markup
        * editing/selection/4895428-4-expected.txt: Added.
        * editing/selection/4895428-4.html: Converted to dump-as-markup
        * platform/chromium-linux/editing/selection/4895428-1-expected.png: Removed.
        * platform/chromium-linux/editing/selection/4895428-4-expected.png: Removed.
        * platform/chromium-win/editing/selection/4895428-1-expected.png: Removed.
        * platform/chromium-win/editing/selection/4895428-1-expected.txt: Removed.
        * platform/chromium-win/editing/selection/4895428-4-expected.png: Removed.
        * platform/chromium-win/editing/selection/4895428-4-expected.txt: Removed.
        * platform/gtk/editing/selection/4895428-1-expected.png: Removed.
        * platform/gtk/editing/selection/4895428-1-expected.txt: Removed.
        * platform/gtk/editing/selection/4895428-4-expected.png: Removed.
        * platform/gtk/editing/selection/4895428-4-expected.txt: Removed.
        * platform/mac-leopard/editing/selection/4895428-1-expected.png: Removed.
        * platform/mac-leopard/editing/selection/4895428-4-expected.png: Removed.
        * platform/mac/editing/selection/4895428-1-expected.png: Removed.
        * platform/mac/editing/selection/4895428-1-expected.txt: Removed.
        * platform/mac/editing/selection/4895428-4-expected.png: Removed.
        * platform/mac/editing/selection/4895428-4-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReviewed by Eric Seidel.
kevino@webkit.org [Wed, 25 May 2011 04:38:26 +0000 (04:38 +0000)]
Reviewed by Eric Seidel.

Add export macros to WTFString.h.

https://bugs.webkit.org/show_bug.cgi?id=27551

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Steve Lacey <sjl@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 04:35:37 +0000 (04:35 +0000)]
2011-05-24  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        Move chromium media controls timeline back to flexible rather than absolute
        layout.

        https://bugs.webkit.org/show_bug.cgi?id=61379

        * platform/chromium/test_expectations.txt: Added expected failures from this change.
2011-05-24  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        Move chromium media controls timeline back to flexible rather than absolute
        layout.

        https://bugs.webkit.org/show_bug.cgi?id=61379

        * css/mediaControlsChromium.css:
        (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
        (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 25 May 2011 04:26:04 +0000 (04:26 +0000)]
2011-05-24  Kent Tamura  <tkent@chromium.org>

        Reviewed by Hajime Morita.

        Convert fast/forms/input-type-change.html to a dumpAsText() test
        https://bugs.webkit.org/show_bug.cgi?id=61029

        Merge input-type-change2 to input-type-change.html, and convert it to
        a dumpAsText() test.

        * fast/forms/input-type-change-expected.txt:
        * fast/forms/input-type-change.html:
        * fast/forms/input-type-change2.html: Removed.
        * platform/chromium-linux/fast/forms/input-type-change-expected.png: Removed.
        * platform/chromium-linux/fast/forms/input-type-change2-expected.png: Removed.
        * platform/chromium-mac-leopard/fast/forms/input-type-change-expected.png: Removed.
        * platform/chromium-mac/fast/forms/input-type-change-expected.png: Removed.
        * platform/chromium-win/fast/forms/input-type-change-expected.png: Removed.
        * platform/chromium-win/fast/forms/input-type-change-expected.txt: Removed.
        * platform/chromium-win/fast/forms/input-type-change2-expected.png: Removed.
        * platform/chromium-win/fast/forms/input-type-change2-expected.txt: Removed.
        * platform/gtk/fast/forms/input-type-change-expected.png: Removed.
        * platform/gtk/fast/forms/input-type-change-expected.txt: Removed.
        * platform/gtk/fast/forms/input-type-change2-expected.png: Removed.
        * platform/gtk/fast/forms/input-type-change2-expected.txt: Removed.
        * platform/mac-leopard/fast/forms/input-type-change-expected.png: Removed.
        * platform/mac-leopard/fast/forms/input-type-change2-expected.png: Removed.
        * platform/mac/fast/forms/input-type-change-expected.png: Removed.
        * platform/mac/fast/forms/input-type-change-expected.txt:
        * platform/mac/fast/forms/input-type-change-expected.txt: Removed.
        * platform/mac/fast/forms/input-type-change2-expected.png: Removed.
        * platform/mac/fast/forms/input-type-change2-expected.txt: Removed.
        * platform/qt-arm/Skipped: Remove input-type-change2.html.
        * platform/qt-mac/Skipped: ditto.
        * platform/qt/fast/forms/input-type-change-expected.txt: Removed.
        * platform/qt/fast/forms/input-type-change2-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fix clang error.
ukai@chromium.org [Wed, 25 May 2011 04:20:02 +0000 (04:20 +0000)]
Unreviewed. Fix clang error.

error: initialization of pointer of type 'WebCore::MHTMLArchive *' to
NULL from a constant boolean expression [-Werror,-Wbool-conversio

* loader/archive/mhtml/MHTMLArchive.cpp:
(WebCore::MHTMLArchive::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Julien Chaffraix <jchaffraix@codeaurora.org>
commit-queue@webkit.org [Wed, 25 May 2011 04:17:03 +0000 (04:17 +0000)]
2011-05-24  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Hajime Morita.

        <legend> element is dropped on the floor
        https://bugs.webkit.org/show_bug.cgi?id=18691

        * html5lib/resources/webkit02.dat: Added a passing
        test for <legend> parsing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Annie Sullivan <sullivan@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 04:14:51 +0000 (04:14 +0000)]
2011-05-24  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Tony Chang.

        editing/deleting/5032066 should be a dump-as-markup test
        https://bugs.webkit.org/show_bug.cgi?id=61327

        Converts 5032066 to dump-as-markup and adds doctype, html, and body tags.

        * editing/deleting/5032066-expected.txt: Added.
        * editing/deleting/5032066.html:
        * platform/chromium-linux/editing/deleting/5032066-expected.png: Removed.
        * platform/chromium-win/editing/deleting/5032066-expected.png: Removed.
        * platform/chromium-win/editing/deleting/5032066-expected.txt: Removed.
        * platform/gtk/editing/deleting/5032066-expected.txt: Removed.
        * platform/mac-leopard/editing/deleting/5032066-expected.png: Removed.
        * platform/mac/editing/deleting/5032066-expected.png: Removed.
        * platform/mac/editing/deleting/5032066-expected.txt: Removed.
        * platform/qt/editing/deleting/5032066-expected.png: Removed.
        * platform/qt/editing/deleting/5032066-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Annie Sullivan <sullivan@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 04:04:03 +0000 (04:04 +0000)]
2011-05-24  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Ryosuke Niwa.

        Convert LayoutTests/editing/deleting/5115601.html to dump-as-markup.
        https://bugs.webkit.org/show_bug.cgi?id=61330

        Converted to dump-as-markup and added a little html cleanup.

        * editing/deleting/5115601-expected.txt: Added.
        * editing/deleting/5115601.html: Convert to dump-as-markup.
        * platform/chromium-linux/editing/deleting/5115601-expected.png: Removed.
        * platform/chromium-win/editing/deleting/5115601-expected.png: Removed.
        * platform/chromium-win/editing/deleting/5115601-expected.txt: Removed.
        * platform/gtk/editing/deleting/5115601-expected.txt: Removed.
        * platform/mac-leopard/editing/deleting/5115601-expected.png: Removed.
        * platform/mac/editing/deleting/5115601-expected.png: Removed.
        * platform/mac/editing/deleting/5115601-expected.txt: Removed.
        * platform/qt/editing/deleting/5115601-expected.png: Removed.
        * platform/qt/editing/deleting/5115601-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Annie Sullivan <sullivan@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 03:50:54 +0000 (03:50 +0000)]
2011-05-24  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Ryosuke Niwa.

        Convert LayoutTests/editing/deleting/5206311-2.html to dump-as-markup
        https://bugs.webkit.org/show_bug.cgi?id=61332

        Used dump-as-markup to improve readability of results.
        Also improved HTML and cleaned up descriptions.

        * editing/deleting/5206311-2-expected.txt: Added.
        * editing/deleting/5206311-2.html: Convert to dump-as-markup.
        * platform/chromium-linux/editing/deleting/5206311-2-expected.png: Removed.
        * platform/chromium-win/editing/deleting/5206311-2-expected.png: Removed.
        * platform/chromium-win/editing/deleting/5206311-2-expected.txt: Removed.
        * platform/gtk/editing/deleting/5206311-2-expected.txt: Removed.
        * platform/mac-leopard/editing/deleting/5206311-2-expected.png: Removed.
        * platform/mac/editing/deleting/5206311-2-expected.png: Removed.
        * platform/mac/editing/deleting/5206311-2-expected.txt: Removed.
        * platform/qt/editing/deleting/5206311-2-expected.png: Removed.
        * platform/qt/editing/deleting/5206311-2-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Annie Sullivan <sullivan@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 03:39:22 +0000 (03:39 +0000)]
2011-05-24  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Ryosuke Niwa.

        Convert LayoutTests/editing/deleting/delete-block-table.html to dumpAsText test.
        https://bugs.webkit.org/show_bug.cgi?id=61333

        Converts delete-block-table.html to dumpAsText test by changing to use runDumpAsTextEditingTest.

        * editing/deleting/delete-block-table-expected.txt: Added.
        * editing/deleting/delete-block-table.html: Converted to dump-as-markup.
        * platform/chromium-linux/editing/deleting/delete-block-table-expected.png: Removed.
        * platform/chromium-win/editing/deleting/delete-block-table-expected.png: Removed.
        * platform/chromium-win/editing/deleting/delete-block-table-expected.txt: Removed.
        * platform/gtk/editing/deleting/delete-block-table-expected.png: Removed.
        * platform/gtk/editing/deleting/delete-block-table-expected.txt: Removed.
        * platform/mac-leopard/editing/deleting/delete-block-table-expected.png: Removed.
        * platform/mac/editing/deleting/delete-block-table-expected.png: Removed.
        * platform/mac/editing/deleting/delete-block-table-expected.txt: Removed.
        * platform/qt/editing/deleting/delete-block-table-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 25 May 2011 03:39:21 +0000 (03:39 +0000)]
2011-05-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add FIXME comments about removing FrameLoader::isProcessingUserGesture
        https://bugs.webkit.org/show_bug.cgi?id=61395

        All the callers of the API are wrong.  They should call the more modern
        static member function of ScriptController instead.  I'll remove the
        FrameLoader function in a future patch.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::processingUserGesture):
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::click):
2011-05-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add FIXME comments about removing FrameLoader::isProcessingUserGesture
        https://bugs.webkit.org/show_bug.cgi?id=61395

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::isProcessingUserGesture):
2011-05-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add FIXME comments about removing FrameLoader::isProcessingUserGesture
        https://bugs.webkit.org/show_bug.cgi?id=61395

        * WebView/WebView.mm:
        (-[WebView _isProcessingUserGesture]):
2011-05-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add FIXME comments about removing FrameLoader::isProcessingUserGesture
        https://bugs.webkit.org/show_bug.cgi?id=61395

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (drtPrintFrameUserGestureStatus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Justin Novosad <junov@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 03:28:18 +0000 (03:28 +0000)]
2011-05-24  Justin Novosad  <junov@chromium.org>

        Reviewed by Stephen White.

        [Chromium] cleanup test expectations for drawImage that are no longer
        flaky
        https://bugs.webkit.org/show_bug.cgi?id=61389

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Wed, 25 May 2011 03:03:46 +0000 (03:03 +0000)]
2011-05-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Unreviewed. Fix style error.

        * platform/efl/WidgetEfl.cpp:
        (WebCore::WidgetPrivate::WidgetPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Greg Simon <gregsimon@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 03:00:58 +0000 (03:00 +0000)]
2011-05-24  Greg Simon  <gregsimon@chromium.org>

        Reviewed by Dimitri Glazkov.

        Control Indexeddb backends from LayoutTestController
        https://bugs.webkit.org/show_bug.cgi?id=61000

        LayoutTest for migration between SQLite and LevelDB
        in IndxededDB.

        * storage/indexeddb/migrate-basics-expected.txt: Added.
        * storage/indexeddb/migrate-basics.html: Added.
2011-05-24  Greg Simon  <gregsimon@chromium.org>

        Reviewed by Dimitri Glazkov.

        Control Indexeddb backends from LayoutTestController
        https://bugs.webkit.org/show_bug.cgi?id=61000

        Test: storage/indexeddb/migrate-basics.html

        * storage/IDBBackingStore.h:
        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::IDBFactoryBackendImpl::IDBFactoryBackendImpl):
        (WebCore::IDBFactoryBackendImpl::open):
        (WebCore::IDBFactoryBackendImpl::setEnableMigration):
        (WebCore::IDBFactoryBackendImpl::migrate):
        * storage/IDBFactoryBackendImpl.h:
        * storage/IDBFactoryBackendInterface.h:
        * storage/IDBLevelDBBackingStore.cpp:
        (WebCore::IDBLevelDBBackingStore::backingStoreExists):
        * storage/IDBLevelDBBackingStore.h:
        (WebCore::IDBLevelDBBackingStore::backingStoreType):
        * storage/IDBSQLiteBackingStore.cpp:
        (WebCore::IDBSQLiteBackingStore::backingStoreExists):
        * storage/IDBSQLiteBackingStore.h:
        (WebCore::IDBSQLiteBackingStore::backingStoreType):
2011-05-24  Greg Simon  <gregsimon@chromium.org>

        Reviewed by Dimitri Glazkov.

        Control Indexeddb backends from LayoutTestController
        https://bugs.webkit.org/show_bug.cgi?id=61000

        * public/WebIDBFactory.h:
        (WebKit::WebIDBFactory::setEnableMigration):
        * src/AssertMatchingEnums.cpp:
        * src/IDBFactoryBackendProxy.cpp:
        (WebKit::IDBFactoryBackendProxy::setEnableMigration):
        * src/IDBFactoryBackendProxy.h:
        * src/WebIDBFactoryImpl.cpp:
        (WebKit::WebIDBFactory::setOverrideBackingStoreType):
        (WebKit::WebIDBFactory::setTemporaryDatabaseFolder):
        (WebKit::WebIDBFactoryImpl::WebIDBFactoryImpl):
        (WebKit::WebIDBFactoryImpl::open):
        (WebKit::WebIDBFactoryImpl::setEnableMigration):
        * src/WebIDBFactoryImpl.h:
2011-05-24  Greg Simon  <gregsimon@chromium.org>

        Reviewed by Dimitri Glazkov.

        Control Indexeddb backends from LayoutTestController
        https://bugs.webkit.org/show_bug.cgi?id=61000

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::setOverrideIndexedDBBackingStore):
        (LayoutTestController::clearAllDatabases):
        * DumpRenderTree/chromium/LayoutTestController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed.
ukai@chromium.org [Wed, 25 May 2011 02:54:29 +0000 (02:54 +0000)]
Unreviewed.

Chromium expectations update. (mhtml)

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the 32-bit build.
mrowe@apple.com [Wed, 25 May 2011 02:52:31 +0000 (02:52 +0000)]
Fix the 32-bit build.

Explicitly use uint32_t when encoding / decoding a type that is a typedef of OSType,
as this is declared as different underlying types in 32- and 64-bit (unsigned long
vs unsigned int).

* Shared/mac/KeychainAttribute.cpp:
(CoreIPC::encode):
(CoreIPC::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Leon Scroggins <scroggo@google.com>
commit-queue@webkit.org [Wed, 25 May 2011 02:35:35 +0000 (02:35 +0000)]
2011-05-24  Leon Scroggins  <scroggo@google.com>

        Reviewed by Kenneth Russell.

        Update expectations for tests drawing a canvas into another canvas (or itself), which have been fixed in gpu.
        https://bugs.webkit.org/show_bug.cgi?id=61362

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnable coalesced wheel events
weinig@apple.com [Wed, 25 May 2011 02:22:23 +0000 (02:22 +0000)]
Enable coalesced wheel events
<rdar://problem/9444786>

Reviewed by Maciej Stachowiak.

* UIProcess/WebPageProxy.cpp:
Flip the switch for coalescing wheel events rather than dropping them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 25 May 2011 02:07:48 +0000 (02:07 +0000)]
2011-05-24  Ryosuke Niwa  <rniwa@webkit.org>

        Final attempt to fix a test; if this fails, I'm just going to skip it.

        * fast/events/selectstart-by-double-triple-clicks.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Leo Yang <leo.yang@torchmobile.com.cn>
leo.yang@torchmobile.com.cn [Wed, 25 May 2011 01:26:53 +0000 (01:26 +0000)]
2011-05-24  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Ryosuke Niwa.

        [SVG] Assertion failure by dragging text between input fields inside <foreignObject>s
        https://bugs.webkit.org/show_bug.cgi?id=60692

        Add NULL check of 'holder' in WebCore::ReplacementFragment::ReplacementFragment()
        before call VisibleSelection::selectionFromContentsOfNode() to prevent crashing.

        Test: editing/pasteboard/drag-drop-input-in-svg.svg

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::ReplacementFragment):
2011-05-24  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Ryosuke Niwa.

        [SVG] Assertion failure by dragging text between input fields inside <foreignObject>s
        https://bugs.webkit.org/show_bug.cgi?id=60692

        Test case to verify dragging and dropping text between input fields
        inside SVG <foreignObject>s. Test passes if no crash occurs in debug mode.

        Drag and drop is not supported in Qt DRT, so skip this case on Qt platform.

        * editing/pasteboard/drag-drop-input-in-svg-expected.txt: Added.
        * editing/pasteboard/drag-drop-input-in-svg.svg: Added.
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 25 May 2011 01:05:21 +0000 (01:05 +0000)]
2011-05-24  Ryosuke Niwa  <rniwa@webkit.org>

        Yet another attempt to make Chromium Windows test bots happy.

        * fast/events/selectstart-by-double-triple-clicks.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Andy Estes <aestes@apple.com>
aestes@apple.com [Wed, 25 May 2011 00:48:00 +0000 (00:48 +0000)]
2011-05-24  Andy Estes  <aestes@apple.com>

        Reviewed by Geoffrey Garen.

        REGRESSION (r70748): WebKit cannot play QuickTime movies on Mac OS X Wiki Server pages
        https://bugs.webkit.org/show_bug.cgi?id=61229

        This site-specific hack maintains compatibility with Mac OS X Wiki Server,
        which embeds QuickTime movies using an object tag containing QuickTime's
        ActiveX classid. Treat this classid as valid only if OS X Server's unique
        'generator' meta tag is present. Only apply this quirk if there is no
        fallback content, which ensures the quirk will disable itself if Wiki
        Server is updated to generate an alternate embed tag as fallback content.

        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk): Return
        true if site-specific quirks are enabled, the object element has no
        fallback content, the classid attribute matches QuickTime's classid and
        the document has a 'generator' meta tag matching Mac OS X Web Services
        Server's unique generator string.
        (WebCore::HTMLObjectElement::hasValidClassId): Call
        shouldAllowQuickTimeClassIdQuirk()
        * html/HTMLObjectElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMaybe fix the Mac build now?
ggaren@apple.com [Wed, 25 May 2011 00:33:00 +0000 (00:33 +0000)]
Maybe fix the Mac build now?

* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 25 May 2011 00:24:38 +0000 (00:24 +0000)]
2011-05-24  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Change CachedResources to take a ResourceRequest instead of
        a url in their constructors and provide a very minimal set of
        cases for avoiding reusing a CachedResource. The ResourceRequest
        part of this change requires pushing responsibility
        for calling Document::completeURL() to the caller, instead of
        CachedResourceLoader, since ResourceRequest ASSERTs if it
        is constructed with an invalid url.

        https://bugs.webkit.org/show_bug.cgi?id=61318

        Refactor, no new tests.

        * css/CSSFontSelector.cpp:
        (WebCore::CSSFontSelector::addFontFaceRule):
        * css/CSSImageValue.cpp:
        (WebCore::CSSImageValue::cachedImage):
        * css/CSSImportRule.cpp:
        (WebCore::CSSImportRule::insertedIntoParent):
        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::checkStyleSheet):
        * dom/ScriptElement.cpp:
        (WebCore::ScriptElement::requestScript):
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process):
        * loader/ImageLoader.cpp:
        (WebCore::ImageLoader::updateFromElement):
        * loader/cache/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
        (WebCore::CachedCSSStyleSheet::didAddClient):
        (WebCore::CachedCSSStyleSheet::checkNotify):
        * loader/cache/CachedCSSStyleSheet.h:
        * loader/cache/CachedFont.cpp:
        (WebCore::CachedFont::CachedFont):
        * loader/cache/CachedFont.h:
        * loader/cache/CachedImage.cpp:
        (WebCore::CachedImage::CachedImage):
        (WebCore::CachedImage::checkShouldPaintBrokenImage):
        * loader/cache/CachedImage.h:
        * loader/cache/CachedResource.cpp:
        (WebCore::CachedResource::CachedResource):
        (WebCore::reuseRequest):
        (WebCore::CachedResource::allowReuseOfRequest):
        (WebCore::CachedResource::removeClient):
        (WebCore::CachedResource::canUseCacheValidator):
        * loader/cache/CachedResource.h:
        (WebCore::CachedResource::resourceRequest):
        (WebCore::CachedResource::url):
        * loader/cache/CachedResourceLoader.cpp:
        * loader/cache/CachedResourceLoader.h:
        * loader/cache/CachedResourceRequest.cpp:
        (WebCore::CachedResourceRequest::load):
        * loader/cache/CachedScript.cpp:
        (WebCore::CachedScript::CachedScript):
        * loader/cache/CachedScript.h:
        * loader/cache/CachedXSLStyleSheet.cpp:
        (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
        (WebCore::CachedXSLStyleSheet::didAddClient):
        (WebCore::CachedXSLStyleSheet::checkNotify):
        * loader/cache/CachedXSLStyleSheet.h:
        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::requestImageResource):
        * svg/SVGFontFaceUriElement.cpp:
        (WebCore::SVGFontFaceUriElement::loadFont):
        * xml/XSLImportRule.cpp:
        (WebCore::XSLImportRule::loadSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 25 May 2011 00:23:04 +0000 (00:23 +0000)]
2011-05-24  Sam Weinig  <sam@webkit.org>

        Reviewed by Maciej Stachowiak.

        Additional sandbox extension required for quarantine database
        <rdar://problem/9397494>
        https://bugs.webkit.org/show_bug.cgi?id=61405

        * WebProcess/com.apple.WebProcess.sb:
        Add read-data access for ~/Library/Preferences.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 25 May 2011 00:18:31 +0000 (00:18 +0000)]
2011-05-24  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Use Element::shadowPseudoId() for text field decoration elements
        https://bugs.webkit.org/show_bug.cgi?id=61351

        No new tests. Covered by existing tests.

        * css/CSSSelector.cpp: Remove support for the following static pseudo selectors:
          - -webkit-inner-spin-button
          - -webkit-input-speech-button
          - -webkit-outer-spin-button
          - -webkit-search-cancel-button
          - -webkit-search-decoration
          - -webkit-search-results-button
          - -webkit-search-results-decoration
        (WebCore::CSSSelector::pseudoId):
        (WebCore::nameToPseudoTypeMap):
        (WebCore::CSSSelector::extractPseudoType):
        * css/CSSSelector.h: ditto.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::matchRules):
          Store shadowPseudoId() result in a local variable because
          SearchFieldResultsButtonElement::shadowPseudoId() is a little expensive.
        * html/shadow/TextControlInnerElements.cpp:
         Override Element::shadowPseudoId() instead of Element::styleForRenderer().
        (WebCore::SearchFieldResultsButtonElement::shadowPseudoId):
        (WebCore::SearchFieldCancelButtonElement::shadowPseudoId):
        (WebCore::SpinButtonElement::shadowPseudoId):
        (WebCore::InputFieldSpeechButtonElement::shadowPseudoId):
        * html/shadow/TextControlInnerElements.h: Update declarations.
        * rendering/RenderTextControlSingleLine.cpp: Remove createFooStyle() functions.
        * rendering/RenderTextControlSingleLine.h: ditto.
        * rendering/style/RenderStyleConstants.h: Remove unused pseudo IDs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMaybe fix the Mac build?
ggaren@apple.com [Wed, 25 May 2011 00:12:27 +0000 (00:12 +0000)]
Maybe fix the Mac build?

* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 24 May 2011 23:49:30 +0000 (23:49 +0000)]
2011-05-24  Dimitri Glazkov  <dglazkov@chromium.org>

        Sorted WebCore.xcodeproj again.

        * WebCore.xcodeproj/project.pbxproj: Ran sort-XCode-project-file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 24 May 2011 23:46:35 +0000 (23:46 +0000)]
2011-05-24  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Split HeapRootVisitor into its own class
        https://bugs.webkit.org/show_bug.cgi?id=61399

        * GNUmakefile.list.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * heap/HandleHeap.cpp:
        * heap/HandleStack.cpp:
        * heap/Heap.cpp:
        * heap/HeapRootVisitor.h: Copied from Source/JavaScriptCore/heap/MarkStack.h.
        * heap/MarkStack.h:
        * runtime/ArgList.cpp:
        * runtime/SmallStrings.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=61345
slewis@apple.com [Tue, 24 May 2011 23:46:14 +0000 (23:46 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=61345
part of <rdar://problem/8675177>
Don't initialize ResourceResponse.m_suggestedFilename until we want to use it.  Initializing it requires reading in and parsing a plist.
Add new initialization state CommonAndUncommonFields to ResourceResponse.  This will be for all the header fields.
Move suggestedFilename initialization to AllFields so it is never initialized unless we ask for it.
Add "Content-Type" to common headers since it is looked for by every CSS sheet load.

Reviewed by Geoff Garen.

No new tests because functionality has not changed.

* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::suggestedFilename):
(WebCore::ResourceResponseBase::setSuggestedFilename):
(WebCore::ResourceResponseBase::httpStatusText):
(WebCore::ResourceResponseBase::setHTTPStatusText):
(WebCore::ResourceResponseBase::httpHeaderField):
(WebCore::ResourceResponseBase::setHTTPHeaderField):
(WebCore::ResourceResponseBase::httpHeaderFields):
(WebCore::ResourceResponseBase::isAttachment):
(WebCore::ResourceResponseBase::setLastModifiedDate):
(WebCore::ResourceResponseBase::lastModifiedDate):
(WebCore::ResourceResponseBase::wasCached):
(WebCore::ResourceResponseBase::connectionReused):
(WebCore::ResourceResponseBase::setConnectionReused):
(WebCore::ResourceResponseBase::connectionID):
(WebCore::ResourceResponseBase::setConnectionID):
(WebCore::ResourceResponseBase::resourceLoadTiming):
(WebCore::ResourceResponseBase::setResourceLoadTiming):
(WebCore::ResourceResponseBase::resourceLoadInfo):
(WebCore::ResourceResponseBase::setResourceLoadInfo):
* platform/network/ResourceResponseBase.h:
* platform/network/cf/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
* platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::platformLazyInit):
* platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::platformLazyInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Tue, 24 May 2011 23:43:15 +0000 (23:43 +0000)]
2011-05-24  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        Improve handling in WebCore of low memory situations
        https://bugs.webkit.org/show_bug.cgi?id=61222

        Added call to enable memory pressure handling.

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
        * WebView/WebViewInternal.h:
2011-05-24  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        Improve handling in WebCore of low memory situations
        https://bugs.webkit.org/show_bug.cgi?id=61222

        Added new class, MemoryPressureHandler, to platform to respond to low
        system memory events. Added Mac specific implementation that reduces the
        page cache, NSURL cache, WebCore cache by half their current usage
        and then garbage collects.  This can allow Safari to continue operating
        in a low memory situation with minimal paging.
        Split up prune operations in MemoryCache to allow for pruning to a
        specific actual size to support this change.

        No tests added as the functionality of WebKit wasn't changed.

        * GNUmakefile.list.am:
        * WebCore.exp.in:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * loader/cache/MemoryCache.cpp:
        (WebCore::MemoryCache::pruneLiveResources):
        (WebCore::MemoryCache::forcePruneLiveResources):
        (WebCore::MemoryCache::pruneLiveResourcesToTarget):
        (WebCore::MemoryCache::pruneDeadResources):
        (WebCore::MemoryCache::forcePruneDeadResources):
        (WebCore::MemoryCache::pruneDeadResourcesToTarget):
        * loader/cache/MemoryCache.h:
        (WebCore::MemoryCache::forcePrune):
        * platform/MemoryPressureHandler.cpp: Added.
        (WebCore::memoryPressureHandler):
        (WebCore::MemoryPressureHandler::MemoryPressureHandler):
        (WebCore::MemoryPressureHandler::install):
        (WebCore::MemoryPressureHandler::respondToMemoryPressure):
        * platform/MemoryPressureHandler.h: Added.
        * platform/mac/MemoryPressureHandler.mm: Added.
        (WebCore::MemoryPressureHandler::install):
        (WebCore::MemoryPressureHandler::respondToMemoryPressure):
2011-05-24  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        Improve handling in WebCore of low memory situations
        https://bugs.webkit.org/show_bug.cgi?id=61222

        Added call to enable memory pressure handling for Mac case.

        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::initializeWebProcess):
        * WebProcess/WebProcess.h:
        * WebProcess/mac/WebProcessMac.mm:
        (WebKit::WebProcess::platformInitializeWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 24 May 2011 23:19:55 +0000 (23:19 +0000)]
2011-05-24  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Node::shadowAncestorNode() and shadowTreeRootNode() should be const.
        https://bugs.webkit.org/show_bug.cgi?id=61398

        shadowAncestorNode() and shadowTreeRootNode() should be const
        though they can return 'this' pointer.

        No new tests. This doesn't change any visible behavior.

        * dom/Node.cpp:
        (WebCore::Node::shadowAncestorNode): Make this const.
        (WebCore::Node::shadowTreeRootNode): ditto.
        * dom/Node.h: Update declarations.
        * html/shadow/TextControlInnerElements.h:
        (WebCore::SpinButtonElement::isEnabledFormControl): Need no const_cast<>.
        (WebCore::SpinButtonElement::isReadOnlyFormControl): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPart of <rdar://problem/9434311> and https://bugs.webkit.org/show_bug.cgi?id=61334
beidson@apple.com [Tue, 24 May 2011 22:52:21 +0000 (22:52 +0000)]
Part of <rdar://problem/9434311> and https://bugs.webkit.org/show_bug.cgi?id=61334
Should shim a few SecKeychainItem* methods on SnowLeopard

Reviewed by Darin Adler.

Initialize the KeychainItem shim on SnowLeopard:
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::initializeShim):

On SnowLeopard, shim the 4 SecKeychainItem methods:
* WebProcess/mac/WebProcessShim.h:
* WebProcess/mac/WebProcessShim.mm:
(WebKit::shimSecKeychainItemCopyContent):
(WebKit::shimSecKeychainItemCreateFromContent):
(WebKit::shimSecKeychainItemModifyContent):
(WebKit::shimSecKeychainItemFreeContent):
(WebKit::WebKitWebProcessKeychainItemShimInitialize):

* WebProcess/mac/KeychainItemShimMethods.h: Added.
* WebProcess/mac/KeychainItemShimMethods.mm: Added.
Manage a set of shim-controlled AttributeList data:
(WebKit::shimManagedAttributeLists):
(WebKit::freeAttributeListContents):
(WebKit::allocateAttributeListContents):

Manage a set of shim-controlled KeychainItem data:
(WebKit::shimManagedKeychainItemContents):
(WebKit::allocateKeychainItemContentData):

Free any shim-controlled AttributeList or KeychainItem data:
(WebKit::webFreeAttributeListContentOnMainThread):
(WebKit::webFreeAttributeListContent):
(WebKit::webFreeKeychainItemContentOnMainThread):
(WebKit::webFreeKeychainItemContent):

Marshall these 3 KeychainItem methods to the UIProcess:
(WebKit::webSecKeychainItemCopyContentOnMainThread):
(WebKit::webSecKeychainItemCopyContent):
(WebKit::webSecKeychainItemCreateFromContentOnMainThread):
(WebKit::webSecKeychainItemCreateFromContent):
(WebKit::webSecKeychainItemModifyContentOnMainThread):
(WebKit::webSecKeychainItemModifyContent):
(WebKit::initializeKeychainItemShim):

Container for an AttributeList entry that knows how to encode/decode:
* Shared/mac/KeychainAttribute.cpp: Added.
(WebKit::KeychainAttribute::KeychainAttribute):
(CoreIPC::encode):
(CoreIPC::decode):
* Shared/mac/KeychainAttribute.h: Added.

Container for the relevant arguments to the shimmed methods, to send to the UIProcess:
* Shared/mac/SecKeychainItemRequestData.cpp: Added.
(WebKit::SecKeychainItemRequestData::SecKeychainItemRequestData):
(WebKit::SecKeychainItemRequestData::initializeWithAttributeList):
(WebKit::SecKeychainItemRequestData::~SecKeychainItemRequestData):
(WebKit::SecKeychainItemRequestData::attributeList):
(WebKit::SecKeychainItemRequestData::encode):
(WebKit::SecKeychainItemRequestData::decode):
* Shared/mac/SecKeychainItemRequestData.h: Added.
(WebKit::SecKeychainItemRequestData::keychainItem):
(WebKit::SecKeychainItemRequestData::itemClass):
(WebKit::SecKeychainItemRequestData::length):
(WebKit::SecKeychainItemRequestData::data):

Container for the possible output from the shimmed methods, to send back to the WebProcess:
* Shared/mac/SecKeychainItemResponseData.cpp: Added.
(WebKit::SecKeychainItemResponseData::SecKeychainItemResponseData):
(WebKit::SecKeychainItemResponseData::encode):
(WebKit::SecKeychainItemResponseData::decode):
* Shared/mac/SecKeychainItemResponseData.h: Added.
(WebKit::SecKeychainItemResponseData::itemClass):
(WebKit::SecKeychainItemResponseData::data):
(WebKit::SecKeychainItemResponseData::resultCode):
(WebKit::SecKeychainItemResponseData::attributes):
(WebKit::SecKeychainItemResponseData::keychainItem):

Actually implement the calls to the SecKeychainItem* methods in the UIProcess:
* UIProcess/WebProcessProxy.h:
* UIProcess/WebProcessProxy.messages.in:
* UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::WebProcessProxy::secKeychainItemCopyContent):
(WebKit::WebProcessProxy::secKeychainItemCreateFromContent):
(WebKit::WebProcessProxy::secKeychainItemModifyContent):

* WebKit2.xcodeproj/project.pbxproj: Project file stuff
* Configurations/Shim.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 24 May 2011 22:22:26 +0000 (22:22 +0000)]
2011-05-24  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        [chromium] selectstart-by-drag.html and selectstart-by-double-triple-clicks.html
        fail on Windows and Linux
        https://bugs.webkit.org/show_bug.cgi?id=61377

        selectstart-by-drag.html pass on Chromium Windows and Chromium Linux so don't use
        the failing test expectation on Windows port.

        In selectstart-by-double-triple-clicks.html, /^\s|\s$/ isn't recognized by V8 so
        replace it by /^[ \t]|[ \t]$/.

        * platform/chromium/fast/events/selectstart-by-drag-expected.txt: Copied from
        LayoutTests/fast/events/selectstart-by-drag-expected.txt.
        * fast/events/selectstart-by-double-triple-clicks.html:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Tue, 24 May 2011 22:12:24 +0000 (22:12 +0000)]
2011-05-24  James Simonsen  <simonjam@chromium.org>

        Reviewed by Eric Seidel.

        ASSERT_NOT_REACHED reached with broken ideograph and system fallback
        https://bugs.webkit.org/show_bug.cgi?id=53528

        * platform/chromium/test_expectations.txt: Remove CRASH from fixed test.
2011-05-24  James Simonsen  <simonjam@chromium.org>

        Reviewed by Eric Seidel.

        ASSERT_NOT_REACHED reached with broken ideograph and system fallback
        https://bugs.webkit.org/show_bug.cgi?id=53528

        Test: fast/text/justify-ideograph-vertical.html (on chromium linux)

        * platform/graphics/FontFastPath.cpp:
        (WebCore::Font::glyphDataForCharacter): Identify and handle broken ideographs as any other variant.
        * platform/graphics/SimpleFontData.h:
        (WebCore::SimpleFontData::variantFontData): Added BrokenIdeographVariant.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 24 May 2011 22:10:03 +0000 (22:10 +0000)]
2011-05-24  Ryosuke Niwa  <rniwa@webkit.org>

        Skip fast/events/scroll-in-scaled-page-with-overflow-hidden.html on Mac WebKit2
        since WebKitTestRunner doesn't implement eventSender.mouseScrollBy yet (bug 42194).

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Jay Civelli <jcivelli@chromium.org>
abarth@webkit.org [Tue, 24 May 2011 22:09:37 +0000 (22:09 +0000)]
2011-05-24  Jay Civelli  <jcivelli@chromium.org>

        Rubberstamped by David Kilzer.

        Updated some files that I forgot in my previous MHTML CL.

        * Configurations/FeatureDefines.xcconfig:
2011-05-24  Jay Civelli  <jcivelli@chromium.org>

        Rubberstamped by David Kilzer.

        Updated some files that I forgot in my previous MHTML CL.

        * Configurations/FeatureDefines.xcconfig:
2011-05-24  Jay Civelli  <jcivelli@chromium.org>

        Rubberstamped by David Kilzer.

        Updated some files that I forgot in my previous MHTML CL.

       * Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Skip platform/mac/editing/input/maxlength.html - textInputController is not...
ap@apple.com [Tue, 24 May 2011 22:06:37 +0000 (22:06 +0000)]
    Skip platform/mac/editing/input/maxlength.html - textInputController is not implemented.

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Robert Hogan <robert@webkit.org>
robert@webkit.org [Tue, 24 May 2011 21:59:54 +0000 (21:59 +0000)]
2011-05-24  Robert Hogan  <robert@webkit.org>

        Reviewed by Ryosuke Niwa.

        [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
        https://bugs.webkit.org/show_bug.cgi?id=61393

        * platform/qt/Skipped: Unskip fast/events/selectstart-by-single-click-with-shift.html
2011-05-24  Robert Hogan  <robert@webkit.org>

        Reviewed by Ryosuke Niwa.

        [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
        https://bugs.webkit.org/show_bug.cgi?id=61393

        * DumpRenderTree/qt/EventSenderQt.h:
        * DumpRenderTree/qt/EventSenderQt.cpp:
        (getModifiers): static function for interpreting modifiers
        (EventSender::mouseDown): Respect keyboard modifiers
        (EventSender::keyDown): use new static function
        (EventSender::sendOrQueueEvent): whitespace fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 24 May 2011 21:56:45 +0000 (21:56 +0000)]
2011-05-24  Ryosuke Niwa  <rniwa@webkit.org>

        Skip fast/events/selectstart-by-double-triple-clicks.html and selectstart-by-drag.html
        on Mac WebKit 2 per the bug 42194.

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Syed Idris Shah <syed.idris-shah@nokia.com>
commit-queue@webkit.org [Tue, 24 May 2011 21:47:27 +0000 (21:47 +0000)]
2011-05-24  Syed Idris Shah  <syed.idris-shah@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] fast/canvas/webgl/gl-uniform-arrays.html failing for Qt on Linux
        https://bugs.webkit.org/show_bug.cgi?id=60377

        LayoutTests/fast/canvas/webgl/gl-uniform-arrays.html

        We do not need assert for the useProgram as program can be null.

        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3D::useProgram): Program can be null. Removing assert.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 24 May 2011 21:36:06 +0000 (21:36 +0000)]
2011-05-24  Ryosuke Niwa  <rniwa@webkit.org>

        Skip fast/events/scroll-in-scaled-page-with-overflow-hidden.html added by r87187 on GTK
        because GTK port doesn't implement eventSender.scalePageBy yet (bug 61396).

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 24 May 2011 21:29:30 +0000 (21:29 +0000)]
2011-05-24  Ryosuke Niwa  <rniwa@webkit.org>

        Skip fast/events/scroll-in-scaled-page-with-overflow-hidden.html added by r87187 on Windows
        because Windows port doesn't implement eventSender.scalePageBy yet (bug 59098).

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 24 May 2011 21:22:27 +0000 (21:22 +0000)]
2011-05-24  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Undo gets broken in contenteditable area when a text field's value is set by script
        https://bugs.webkit.org/show_bug.cgi?id=61340

        Added a test to ensure WebKit does not clear undo stack when setting the value of input or textarea.

        * editing/undo/undo-after-setting-value-expected.txt: Added.
        * editing/undo/undo-after-setting-value.html: Added.
2011-05-24  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Undo gets broken in contenteditable area when a text field's value is set by script
        https://bugs.webkit.org/show_bug.cgi?id=61340

        The bug was caused by RenderTextControl::setInnerTextValue's clearing undo stack by
        calling clearUndoRedoOperations whenever script sets new value to input or textarea.

        Fixed the bug by removing the offending call to clearUndoRedoOperations. While this call
        was added by r15565 to fix a crash, SimpleEditCommands have since become much more robust
        and the test added by r15565 (fast/forms/text-field-setvalue-crash.html) still passes.

        Test: editing/undo/undo-after-setting-value.html

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::setInnerTextValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-24 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Tue, 24 May 2011 21:12:02 +0000 (21:12 +0000)]
2011-05-24  Adam Klein  <adamk@chromium.org>

        Unreviewed. Updating Chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove code to discover if a CTFont has vertical glyphs out of SimpleFontData::platform...
mitz@apple.com [Tue, 24 May 2011 21:01:47 +0000 (21:01 +0000)]
Move code to discover if a CTFont has vertical glyphs out of SimpleFontData::platformInit()
https://bugs.webkit.org/show_bug.cgi?id=61392

Reviewed by Dave Hyatt.

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::fontHasVerticalGlyphs): Moved code here...
(WebCore::SimpleFontData::platformInit): ...from here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the Mac build: Yes, please do remove these files, svn.
ggaren@apple.com [Tue, 24 May 2011 20:56:36 +0000 (20:56 +0000)]
Fix the Mac build: Yes, please do remove these files, svn.

* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87199 268f45cc-cd09-0410-ab3c-d52691b4dbfc